[jira] [Commented] (TINKERPOP-1612) Remove gremlin-groovy-test module
[
https://issues.apache.org/jira/browse/TINKERPOP-1612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894957#comment-15894957
]
ASF GitHub Bot commented on TINKERPOP-1612:
---
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/565
> Remove gremlin-groovy-test module
> -
>
> Key: TINKERPOP-1612
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1612
> Project: TinkerPop
> Issue Type: Improvement
> Components: test-suite
>Affects Versions: 3.2.3
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Minor
> Labels: breaking
> Fix For: 3.3.0
>
>
> `gremlin-groovy-test` is can be for 3.3.0 with its test either migrated to
> other modules or simply removed. `gremlin-groovy` will now be tested in the
> same way that `gremlin-python` is.
> This issue is labelled as "breaking" as it removes a module that graph
> providers depend on. The tests in the module were deprecated in 3.2.4 so
> there has been some warning that this would happen. For 3.3.0, graph
> providers will want to simply remove these tests from their test suites.
> This also means a "breaking" change for those using the deprecated
> {{TinkerGraphGremlinPlugin}} in
> {{org.apache.tinkerpop.gremlin.tinkergraph.groovy.plugin}} and not the one
> introduced in 3.2.4 at {{org.apache.tinkerpop.gremlin.tinkergraph.jsr223}}.
> the same can be said of {{Neo4jGremlinPlugin}}, {{HadoopGremlinPlugin}}
> {{GiraphGremlinPlugin}} and {{SparkGremlinPlugin}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1612) Remove gremlin-groovy-test module
[
https://issues.apache.org/jira/browse/TINKERPOP-1612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894737#comment-15894737
]
ASF GitHub Bot commented on TINKERPOP-1612:
---
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/565
`docker/build.sh -t -n -i` succeeded.
VOTE +1
> Remove gremlin-groovy-test module
> -
>
> Key: TINKERPOP-1612
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1612
> Project: TinkerPop
> Issue Type: Improvement
> Components: test-suite
>Affects Versions: 3.2.3
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Minor
> Labels: breaking
> Fix For: 3.3.0
>
>
> `gremlin-groovy-test` is can be for 3.3.0 with its test either migrated to
> other modules or simply removed. `gremlin-groovy` will now be tested in the
> same way that `gremlin-python` is.
> This issue is labelled as "breaking" as it removes a module that graph
> providers depend on. The tests in the module were deprecated in 3.2.4 so
> there has been some warning that this would happen. For 3.3.0, graph
> providers will want to simply remove these tests from their test suites.
> This also means a "breaking" change for those using the deprecated
> {{TinkerGraphGremlinPlugin}} in
> {{org.apache.tinkerpop.gremlin.tinkergraph.groovy.plugin}} and not the one
> introduced in 3.2.4 at {{org.apache.tinkerpop.gremlin.tinkergraph.jsr223}}.
> the same can be said of {{Neo4jGremlinPlugin}}, {{HadoopGremlinPlugin}}
> {{GiraphGremlinPlugin}} and {{SparkGremlinPlugin}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1612) Remove gremlin-groovy-test module
[
https://issues.apache.org/jira/browse/TINKERPOP-1612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15892950#comment-15892950
]
ASF GitHub Bot commented on TINKERPOP-1612:
---
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/565
This is an insane amount of work you did here. I like it. We now have put
Gremlin-Groovy and the same standing as Gremlin-Python. They are both simply
dialects (variants) of Gremlin. This is superb.
I think once this gets merged, we should take the `gremlin-tools/` work I
did in the `GraphActors` branch and put it here so we can reuse the
`TinkerGraphProvider` for Groovy, Python, etc. I think that would be a nice
cherry on top to this superb refactor.
VOTE +1.
> Remove gremlin-groovy-test module
> -
>
> Key: TINKERPOP-1612
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1612
> Project: TinkerPop
> Issue Type: Improvement
> Components: test-suite
>Affects Versions: 3.2.3
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Minor
> Labels: breaking
> Fix For: 3.3.0
>
>
> `gremlin-groovy-test` is can be for 3.3.0 with its test either migrated to
> other modules or simply removed. `gremlin-groovy` will now be tested in the
> same way that `gremlin-python` is.
> This issue is labelled as "breaking" as it removes a module that graph
> providers depend on. The tests in the module were deprecated in 3.2.4 so
> there has been some warning that this would happen. For 3.3.0, graph
> providers will want to simply remove these tests from their test suites.
> This also means a "breaking" change for those using the deprecated
> {{TinkerGraphGremlinPlugin}} in
> {{org.apache.tinkerpop.gremlin.tinkergraph.groovy.plugin}} and not the one
> introduced in 3.2.4 at {{org.apache.tinkerpop.gremlin.tinkergraph.jsr223}}.
> the same can be said of {{Neo4jGremlinPlugin}}, {{HadoopGremlinPlugin}}
> {{GiraphGremlinPlugin}} and {{SparkGremlinPlugin}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1612) Remove gremlin-groovy-test module
[
https://issues.apache.org/jira/browse/TINKERPOP-1612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891241#comment-15891241
]
ASF GitHub Bot commented on TINKERPOP-1612:
---
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/565
Test suite passes. Still doing a code review. Got stuck with the
`ComputerVerificationStrategy` merge this afternoon...
> Remove gremlin-groovy-test module
> -
>
> Key: TINKERPOP-1612
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1612
> Project: TinkerPop
> Issue Type: Improvement
> Components: test-suite
>Affects Versions: 3.2.3
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Minor
> Labels: breaking
> Fix For: 3.3.0
>
>
> `gremlin-groovy-test` is can be for 3.3.0 with its test either migrated to
> other modules or simply removed. `gremlin-groovy` will now be tested in the
> same way that `gremlin-python` is.
> This issue is labelled as "breaking" as it removes a module that graph
> providers depend on. The tests in the module were deprecated in 3.2.4 so
> there has been some warning that this would happen. For 3.3.0, graph
> providers will want to simply remove these tests from their test suites.
> This also means a "breaking" change for those using the deprecated
> {{TinkerGraphGremlinPlugin}} in
> {{org.apache.tinkerpop.gremlin.tinkergraph.groovy.plugin}} and not the one
> introduced in 3.2.4 at {{org.apache.tinkerpop.gremlin.tinkergraph.jsr223}}.
> the same can be said of {{Neo4jGremlinPlugin}}, {{HadoopGremlinPlugin}}
> {{GiraphGremlinPlugin}} and {{SparkGremlinPlugin}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1612) Remove gremlin-groovy-test module
[
https://issues.apache.org/jira/browse/TINKERPOP-1612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891062#comment-15891062
]
ASF GitHub Bot commented on TINKERPOP-1612:
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/565
I just pushed a fix on `tp32` which has merged forward to this branch. That
should allow it to build for you now @okram - can you give it another shot?
> Remove gremlin-groovy-test module
> -
>
> Key: TINKERPOP-1612
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1612
> Project: TinkerPop
> Issue Type: Improvement
> Components: test-suite
>Affects Versions: 3.2.3
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Minor
> Labels: breaking
> Fix For: 3.3.0
>
>
> `gremlin-groovy-test` is can be for 3.3.0 with its test either migrated to
> other modules or simply removed. `gremlin-groovy` will now be tested in the
> same way that `gremlin-python` is.
> This issue is labelled as "breaking" as it removes a module that graph
> providers depend on. The tests in the module were deprecated in 3.2.4 so
> there has been some warning that this would happen. For 3.3.0, graph
> providers will want to simply remove these tests from their test suites.
> This also means a "breaking" change for those using the deprecated
> {{TinkerGraphGremlinPlugin}} in
> {{org.apache.tinkerpop.gremlin.tinkergraph.groovy.plugin}} and not the one
> introduced in 3.2.4 at {{org.apache.tinkerpop.gremlin.tinkergraph.jsr223}}.
> the same can be said of {{Neo4jGremlinPlugin}}, {{HadoopGremlinPlugin}}
> {{GiraphGremlinPlugin}} and {{SparkGremlinPlugin}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1612) Remove gremlin-groovy-test module
[
https://issues.apache.org/jira/browse/TINKERPOP-1612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15890940#comment-15890940
]
ASF GitHub Bot commented on TINKERPOP-1612:
---
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/565
Gremlin-Python has failed twice for me locally now. :/ I'll keep reviewing
the code aspects of Groovy.
```
[WARNING] Request for side-effect keys on
b5f1b521-1431-4ee2-892d-191d3c47a500 returned no side-effects in the cache
[WARNING] Could not find side-effects for
b5f1b521-1431-4ee2-892d-191d3c47a500.
[WARNING] Could not find side-effect key for x in
fbeaa674-19f5-4629-9f11-289ff65a2c32.
[exec] tests/driver/test_driver_remote_connection.py ..
[exec] tests/driver/test_driver_remote_connection_threaded.py ..
[exec] tests/process/test_strategies.py ..
[exec] tests/process/test_traversal.py ...
[exec] tests/structure/test_graph.py ..
[exec] tests/structure/io/test_graphson.py ...
[exec]
[exec] generated xml file:
/Users/marko/software/tinkerpop/gremlin-python/target/python-reports/TEST-native-python.xml
[exec] === FAILURES
===
[exec] __ test_client_async
___
[exec]
[exec] client =
[exec]
[exec] def test_client_async(client):
[exec] g = Graph().traversal()
[exec] t = g.V()
[exec] message = RequestMessage('traversal', 'bytecode',
{'gremlin': t.bytecode})
[exec] future = client.submitAsync(message)
[exec] > assert not future.done()
[exec] E assert not True
[exec] E+ where True = >()
[exec] E+where > = .done
[exec]
[exec] tests/driver/test_client.py:75: AssertionError
[exec] = 1 failed, 35 passed in 2.71 seconds
==
```
> Remove gremlin-groovy-test module
> -
>
> Key: TINKERPOP-1612
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1612
> Project: TinkerPop
> Issue Type: Improvement
> Components: test-suite
>Affects Versions: 3.2.3
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Minor
> Labels: breaking
> Fix For: 3.3.0
>
>
> `gremlin-groovy-test` is can be for 3.3.0 with its test either migrated to
> other modules or simply removed. `gremlin-groovy` will now be tested in the
> same way that `gremlin-python` is.
> This issue is labelled as "breaking" as it removes a module that graph
> providers depend on. The tests in the module were deprecated in 3.2.4 so
> there has been some warning that this would happen. For 3.3.0, graph
> providers will want to simply remove these tests from their test suites.
> This also means a "breaking" change for those using the deprecated
> {{TinkerGraphGremlinPlugin}} in
> {{org.apache.tinkerpop.gremlin.tinkergraph.groovy.plugin}} and not the one
> introduced in 3.2.4 at {{org.apache.tinkerpop.gremlin.tinkergraph.jsr223}}.
> the same can be said of {{Neo4jGremlinPlugin}}, {{HadoopGremlinPlugin}}
> {{GiraphGremlinPlugin}} and {{SparkGremlinPlugin}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
