[GitHub] tinkerpop issue #620: TINKERPOP-1552 C# GLV: Generics and enum generation

[jorgebay]

Github user jorgebay commented on the issue:

https://github.com/apache/tinkerpop/pull/620
  
cc @FlorianHockmann 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1552) C# Gremlin Language Variant

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16042373#comment-16042373
 ] 

ASF GitHub Bot commented on TINKERPOP-1552:
---

GitHub user jorgebay opened a pull request:

https://github.com/apache/tinkerpop/pull/620

TINKERPOP-1552 C# GLV: Generics and enum generation

Added type safety to traversal interface. For example:

```csharp
Vertex vertex = g.V().Next();
// Compile time error
Edge edge = g.V().Next();
```

As C# generics is more strict than in Java, some methods require the user 
to specify the expected type:
```csharp
// Specify the type of the value of the property "age"
IList userAgeList = g.V().HasLabel("user").Values("age").ToList();
```

Additionally, I've changed the letter case of the enums generated in C# to 
match the C# naming convention, ie: 
`g.V().Values("age").Order().By(Order.Decr)`

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jorgebay/tinkerpop csharp-glv-generics

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/620.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #620


commit 027524afce7fd239cc7db600ba1fd0b5f005e46e
Author: Jorge Bay Gondra 
Date:   2017-05-31T15:19:55Z

C# GLV: Generics and enum generation




> C# Gremlin Language Variant
> ---
>
> Key: TINKERPOP-1552
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1552
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: language-variant
>Affects Versions: 3.2.3
>Reporter: Jorge Bay
>Assignee: stephen mallette
>
> It would be nice to have a C# GLV that runs under .NET Framework 4.5+ and 
> .NET Core.
> The maven build could use the Exec Maven Plugin to exec .NET Core's [dotnet 
> test|https://www.microsoft.com/net/core#macos] command.
> Some requirements, from the mailing list (edited):
> {quote}
> 1. The GLV should keep in line with class/method names of the java API
> where possible to ensure consistency of feel across languages.
> 2. There needs to be adequate tests (we're still discussing the approach to
> testing GLVs and i think that needs to be tackled sooner than later as more
> GLVs start to come in). Those tests should produce xunit style output
> unless there is some good reason not to.
> 3. There needs to be adequate documentation (e.g. Reference docs)
> 4. The build/deploy process needs to be bound to maven which might be one of 
> the trickier bits to deal with.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: [TinkerPop] Re: Docker images: gremlin-server and gremlin-console

[Florian Hockmann]

I think official images would be a very good idea as there exist currently 
a lot of images, especially for Gremlin Server. Users typically search for 
the official image or just take the image with the most pulls. Images 
published directly by TinkerPop would get the most attention so users don't 
end up with some image that isn't actively maintained.

Another advantage of integrating the images in TinkerPop would probably be 
that the deployment could be integrated into TinkerPop's usual release 
cycle. So new images can be published directly for each new version.

Am Dienstag, 6. Juni 2017 18:39:09 UTC+2 schrieb Stephen Mallette:
>
> Would it be interesting to anyone for TinkerPop to have an official docker 
> image? 
>
> On Tue, Jun 6, 2017 at 12:22 PM, Benjamin Ricaud  > wrote:
>
>> Thanks Jean-Baptiste,
>>
>> I have also done a container for the gremlin-server 3.2.4, configured to 
>> be used with gremlin-python:
>> https://hub.docker.com/r/bricaud/gremlin-server/
>>
>> I noticed that you do not need the IP trick for the server to be 
>> accessed. If you set
>> host: 0
>> in your gremlin-conf.yaml, (and open the port with -p 8182:8182) you can 
>> access the server.
>> (see my conf files on the github repo).
>>
>> Best,
>> Benjamin
>>
>> Le jeudi 1 juin 2017 00:37:07 UTC+2, Jean-Baptiste Musso a écrit :
>>>
>>> Dear TinkerPop,
>>>
>>> I published a couple automatically built Docker images for 
>>> gremlin-server and gremlin-console (current image tags: latest, 3.2.4, 3.2 
>>> and 3):
>>>
>>> https://hub.docker.com/r/jbmusso/gremlin-server/
>>> https://hub.docker.com/r/jbmusso/gremlin-console/
>>>
>>> I built these because I needed to quickly start different configurations 
>>> of gremlin-server when developing the gremlin-javascript client.
>>> Source repository: https://github.com/jbmusso/docker-tinkerpop
>>>
>>>
>>> Start gremlin-server with:
>>>
>>> docker run -p 8182:8182 jbmusso/gremlin-server:3.2.4
>>>
>>>
>>> Defaults to conf/gremlin-server.yaml within that container, or pass 
>>> another .yaml file:
>>>
>>> docker run -p 8182:8182 jbmusso/gremlin-server:3.2.4 
>>> conf/gremlin-server-modern.yaml
>>>
>>>
>>> Mounting your own config .yaml file with docker run -v argument should 
>>> also work (untested).
>>>
>>>
>>> You can play with the console this way (make sure you run with the -it 
>>> flags so Docker don't quit and actually lets you type commands from your 
>>> shell):
>>>
>>> docker run -it jbmusso/gremlin-console:3.2.4
>>>
>>>
>>> If you want to execute a file located on your host from within a 
>>> gremin-console container (the following assumes that foobar.groovy file 
>>> exists in your $HOME dir):
>>>
>>> docker run -it -v ~/foobar.groovy:/script/foobar.groovy 
>>> jbmusso/gremlin-console:3.2.4 -e /script/foobar.groovy
>>>
>>>
>>>
>>>
>>> Jean-Baptiste
>>>
>>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Gremlin-users" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to gremlin-user...@googlegroups.com .
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/gremlin-users/c8141999-2e9d-4fd3-a763-5630866e5c6b%40googlegroups.com
>>  
>> 
>> .
>>
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

[GitHub] tinkerpop pull request #620: TINKERPOP-1552 C# GLV: Generics and enum genera...

[jorgebay]

GitHub user jorgebay opened a pull request:

https://github.com/apache/tinkerpop/pull/620

TINKERPOP-1552 C# GLV: Generics and enum generation

Added type safety to traversal interface. For example:

```csharp
Vertex vertex = g.V().Next();
// Compile time error
Edge edge = g.V().Next();
```

As C# generics is more strict than in Java, some methods require the user 
to specify the expected type:
```csharp
// Specify the type of the value of the property "age"
IList userAgeList = g.V().HasLabel("user").Values("age").ToList();
```

Additionally, I've changed the letter case of the enums generated in C# to 
match the C# naming convention, ie: 
`g.V().Values("age").Order().By(Order.Decr)`

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jorgebay/tinkerpop csharp-glv-generics

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/620.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #620


commit 027524afce7fd239cc7db600ba1fd0b5f005e46e
Author: Jorge Bay Gondra 
Date:   2017-05-31T15:19:55Z

C# GLV: Generics and enum generation




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1552) C# Gremlin Language Variant

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16042380#comment-16042380
 ] 

ASF GitHub Bot commented on TINKERPOP-1552:
---

Github user jorgebay commented on the issue:

https://github.com/apache/tinkerpop/pull/620
  
cc @FlorianHockmann 


> C# Gremlin Language Variant
> ---
>
> Key: TINKERPOP-1552
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1552
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: language-variant
>Affects Versions: 3.2.3
>Reporter: Jorge Bay
>Assignee: stephen mallette
>
> It would be nice to have a C# GLV that runs under .NET Framework 4.5+ and 
> .NET Core.
> The maven build could use the Exec Maven Plugin to exec .NET Core's [dotnet 
> test|https://www.microsoft.com/net/core#macos] command.
> Some requirements, from the mailing list (edited):
> {quote}
> 1. The GLV should keep in line with class/method names of the java API
> where possible to ensure consistency of feel across languages.
> 2. There needs to be adequate tests (we're still discussing the approach to
> testing GLVs and i think that needs to be tackled sooner than later as more
> GLVs start to come in). Those tests should produce xunit style output
> unless there is some good reason not to.
> 3. There needs to be adequate documentation (e.g. Reference docs)
> 4. The build/deploy process needs to be bound to maven which might be one of 
> the trickier bits to deal with.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (TINKERPOP-1689) Make TokenTraversal work with properties

[Daniel Kuppitz (JIRA)]

Daniel Kuppitz created TINKERPOP-1689:
-

 Summary: Make TokenTraversal work with properties
 Key: TINKERPOP-1689
 URL: https://issues.apache.org/jira/browse/TINKERPOP-1689
 Project: TinkerPop
  Issue Type: Bug
  Components: process
Affects Versions: 3.2.4
Reporter: Daniel Kuppitz
Assignee: Marko A. Rodriguez


{noformat}
gremlin> g.V().outE().properties("weight").path().by("name").by().by(__.value())
==>[marko,e[9][1-created->3],0.4]
==>[marko,e[7][1-knows->2],0.5]
==>[marko,e[8][1-knows->4],1.0]
==>[josh,e[10][4-created->5],1.0]
==>[josh,e[11][4-created->3],0.4]
==>[peter,e[12][6-created->3],0.2]
gremlin> g.V().outE().properties("weight").path().by("name").by().by(value)
org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerProperty cannot be 
cast to org.apache.tinkerpop.gremlin.structure.Element
Type ':help' or ':h' for help.
Display stack trace? [yN]
{noformat}

Related ticket: https://issues.apache.org/jira/browse/TINKERPOP-1682

[~okram]you can reassign the ticket to me, but we should discuss how we gonna 
solve this problem.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (TINKERPOP-1689) Make TokenTraversal work with properties

[Daniel Kuppitz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Kuppitz updated TINKERPOP-1689:
--
Description: 
{noformat}
gremlin> g.V().outE().properties("weight").path().by("name").by().by(__.value())
==>[marko,e[9][1-created->3],0.4]
==>[marko,e[7][1-knows->2],0.5]
==>[marko,e[8][1-knows->4],1.0]
==>[josh,e[10][4-created->5],1.0]
==>[josh,e[11][4-created->3],0.4]
==>[peter,e[12][6-created->3],0.2]
gremlin> g.V().outE().properties("weight").path().by("name").by().by(value)
org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerProperty cannot be 
cast to org.apache.tinkerpop.gremlin.structure.Element
Type ':help' or ':h' for help.
Display stack trace? [yN]
{noformat}

Related ticket: https://issues.apache.org/jira/browse/TINKERPOP-1682

[~okram] you can reassign the ticket to me, but we should discuss how we gonna 
solve this problem.

  was:
{noformat}
gremlin> g.V().outE().properties("weight").path().by("name").by().by(__.value())
==>[marko,e[9][1-created->3],0.4]
==>[marko,e[7][1-knows->2],0.5]
==>[marko,e[8][1-knows->4],1.0]
==>[josh,e[10][4-created->5],1.0]
==>[josh,e[11][4-created->3],0.4]
==>[peter,e[12][6-created->3],0.2]
gremlin> g.V().outE().properties("weight").path().by("name").by().by(value)
org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerProperty cannot be 
cast to org.apache.tinkerpop.gremlin.structure.Element
Type ':help' or ':h' for help.
Display stack trace? [yN]
{noformat}

Related ticket: https://issues.apache.org/jira/browse/TINKERPOP-1682

[~okram]you can reassign the ticket to me, but we should discuss how we gonna 
solve this problem.


> Make TokenTraversal work with properties
> 
>
> Key: TINKERPOP-1689
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1689
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.4
>Reporter: Daniel Kuppitz
>Assignee: Marko A. Rodriguez
>
> {noformat}
> gremlin> 
> g.V().outE().properties("weight").path().by("name").by().by(__.value())
> ==>[marko,e[9][1-created->3],0.4]
> ==>[marko,e[7][1-knows->2],0.5]
> ==>[marko,e[8][1-knows->4],1.0]
> ==>[josh,e[10][4-created->5],1.0]
> ==>[josh,e[11][4-created->3],0.4]
> ==>[peter,e[12][6-created->3],0.2]
> gremlin> g.V().outE().properties("weight").path().by("name").by().by(value)
> org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerProperty cannot be 
> cast to org.apache.tinkerpop.gremlin.structure.Element
> Type ':help' or ':h' for help.
> Display stack trace? [yN]
> {noformat}
> Related ticket: https://issues.apache.org/jira/browse/TINKERPOP-1682
> [~okram] you can reassign the ticket to me, but we should discuss how we 
> gonna solve this problem.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] tinkerpop pull request #621: TINKERPOP-1682 by-modulator optimization strate...

[dkuppitz]

GitHub user dkuppitz opened a pull request:

https://github.com/apache/tinkerpop/pull/621

TINKERPOP-1682 by-modulator optimization strategy

https://issues.apache.org/jira/browse/TINKERPOP-1682

Implemented `ByModulatorOptimizationStrategy` which replaces certain 
standard traversals w/ optimized traversals (e.g. `TokenTraversal`).

`docker/build.sh -t -i` succeeded.

VOTE: +1

I wouldn't mind to wait for 
[TINKERPOP-1689](https://issues.apache.org/jira/browse/TINKERPOP-1689) to fix 
the 
[todo](https://github.com/apache/tinkerpop/commit/c5a1bdebf02538dda19fa73c26e1aa350aa8c32f#diff-116d9ef1d2f03e342eef281717bc5f39R83)
 though.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1682

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/621.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #621


commit c5a1bdebf02538dda19fa73c26e1aa350aa8c32f
Author: Daniel Kuppitz 
Date:   2017-06-08T13:23:08Z

Implemented `ByModulatorOptimizationStrategy` which replaces certain 
standard traversals w/ optimized traversals (e.g. `TokenTraversal`).




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1682) by-modulator optimization strategy

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16043963#comment-16043963
 ] 

ASF GitHub Bot commented on TINKERPOP-1682:
---

GitHub user dkuppitz opened a pull request:

https://github.com/apache/tinkerpop/pull/621

TINKERPOP-1682 by-modulator optimization strategy

https://issues.apache.org/jira/browse/TINKERPOP-1682

Implemented `ByModulatorOptimizationStrategy` which replaces certain 
standard traversals w/ optimized traversals (e.g. `TokenTraversal`).

`docker/build.sh -t -i` succeeded.

VOTE: +1

I wouldn't mind to wait for 
[TINKERPOP-1689](https://issues.apache.org/jira/browse/TINKERPOP-1689) to fix 
the 
[todo](https://github.com/apache/tinkerpop/commit/c5a1bdebf02538dda19fa73c26e1aa350aa8c32f#diff-116d9ef1d2f03e342eef281717bc5f39R83)
 though.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1682

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/621.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #621


commit c5a1bdebf02538dda19fa73c26e1aa350aa8c32f
Author: Daniel Kuppitz 
Date:   2017-06-08T13:23:08Z

Implemented `ByModulatorOptimizationStrategy` which replaces certain 
standard traversals w/ optimized traversals (e.g. `TokenTraversal`).




> by-modulator optimization strategy
> --
>
> Key: TINKERPOP-1682
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1682
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.4
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
>
> The can be a significant difference in performance depending on whether you 
> use {{by(id)}} or {{by(id())}}:
> {noformat}
> gremlin> g.V().out().in().path().by(id()).profile()
> ==>Traversal Metrics
> Step   Count  
> Traversers   Time (ms)% Dur
> =
> TinkerGraphStep(vertex,[]) 6  
>  6  12.13758.03
> VertexStep(OUT,vertex) 6  
>  6   1.345 6.43
> VertexStep(IN,vertex) 12  
> 12   0.861 4.12
> PathStep([[IdStep, ProfileStep]]) 12  
> 12   6.57031.42
>   IdStep  36  
> 36   0.452
> >TOTAL -  
>  -  20.916-
> gremlin> g.V().out().in().path().by(id).profile()
> ==>Traversal Metrics
> Step   Count  
> Traversers   Time (ms)% Dur
> =
> TinkerGraphStep(vertex,[]) 6  
>  6   0.87611.54
> VertexStep(OUT,vertex) 6  
>  6   0.714 9.40
> VertexStep(IN,vertex) 12  
> 12   3.29943.43
> PathStep([id])12  
> 12   2.70635.63
> >TOTAL -  
>  -   7.596-
> {noformat}
> We should have a strategy that rewrites these simple patterns. This affects 
> {{id()}}, {{label()}}, {{key()}}, {{value()}}, but also 
> {{by(values("name"))}}, which can be rewritten as {{by("name")}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (TINKERPOP-1685) Introduce optional feature to allow for upserts without read-before-write

[stephen mallette (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette updated TINKERPOP-1685:

Affects Version/s: 3.2.4
  Component/s: structure
   Issue Type: Improvement  (was: Wish)

> Introduce optional feature to allow for upserts without read-before-write
> -
>
> Key: TINKERPOP-1685
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1685
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: structure
>Affects Versions: 3.2.4
>Reporter: Jeremy Hanna
>
> Currently TINKERPOP-479 is being considered to do some sort of 
> {{getOrCreate}} functionality.  However for some data stores such as 
> Cassandra, this is still short of upserts.  As I understand it, 
> {{getOrCreate}} still has to do a read-before-write.  In cases where the user 
> can guarantee that upserts are going to be idempotent, there is a significant 
> performance improvement and risk avoidance (race condition with 
> multi-threaded read-before-write).  Additionally with some data stores such 
> as Apache Cassandra, the natural way to update data is with an upsert.
> This ticket is to consider adding an additional optional feature to support 
> upserts by default on {{addV}} and {{addE}}.  It could be called something 
> like {{upsert_on_add}}.  This configuration would default to false so that it 
> doesn't break anyone currently relying on errors when adding the same vertex 
> or edge.  However if enabled, it would just add or modify data on the 
> existing vertex or edge.
> If overriding the existing {{addV}} and {{addE}} operations with this 
> optional feature is undesirable, then perhaps new operators could be added 
> like {{upsertV}} and {{upsertE}} or {{putV}} and {{putE}} and those could be 
> used to both add and update the data.  Allowing it to insert data is 
> important because otherwise you are left with having to read-before-write 
> which incurs the performance cost and race condition risk.  A benefit of a 
> separate operator is that you could mix upsert behavior and non-upsert add 
> behavior in a single graph.  I'm not sure there is a huge need to use both in 
> a single graph, but it is a difference between the two strategies.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (TINKERPOP-1687) Record metrics around how long it gremlin script executions sit in executor queue waiting to be executed.

[David Pitera (JIRA)]

David Pitera created TINKERPOP-1687:
---

 Summary: Record metrics around how long it gremlin script 
executions sit in executor queue waiting to be executed.
 Key: TINKERPOP-1687
 URL: https://issues.apache.org/jira/browse/TINKERPOP-1687
 Project: TinkerPop
  Issue Type: Improvement
Affects Versions: 3.2.4
Reporter: David Pitera
Priority: Minor
 Fix For: 3.2.5


The issue will be breaking because I will be moving the MetricManager into the 
gremlin-core project from the gremlin-server project for easier use across the 
project. Therefore whoever is using the MetricManager will need to update their 
location from where they grab it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] tinkerpop pull request #620: TINKERPOP-1552 C# GLV: Generics and enum genera...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/620


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-915) Gremlin Server supports REST and Websockets simultanteously

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16042608#comment-16042608
 ] 

ASF GitHub Bot commented on TINKERPOP-915:
--

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/618
  
I probably should have mentioned this on my last post, but I probably won't 
review this until next week as we are currently preparing for release and the 
release branches are frozen during testing.


> Gremlin Server supports REST and Websockets simultanteously
> ---
>
> Key: TINKERPOP-915
> URL: https://issues.apache.org/jira/browse/TINKERPOP-915
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.0.2-incubating
>Reporter: stephen mallette
>
> Develop a {{Channelizer}} that allows REST and Websockets to be configured at 
> the same time.  I've personally tried to do this on a couple of attempts 
> while following a Netty sample, but I've never been able to get it to work.  
> Perhaps folks like [~pluradj] or [~dmill] would like to give it a go some 
> day? :)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TINKERPOP-915) Gremlin Server supports REST and Websockets simultanteously

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16043054#comment-16043054
 ] 

ASF GitHub Bot commented on TINKERPOP-915:
--

Github user krlohnes commented on the issue:

https://github.com/apache/tinkerpop/pull/618
  
@spmallette Thanks for the heads up. 


> Gremlin Server supports REST and Websockets simultanteously
> ---
>
> Key: TINKERPOP-915
> URL: https://issues.apache.org/jira/browse/TINKERPOP-915
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.0.2-incubating
>Reporter: stephen mallette
>
> Develop a {{Channelizer}} that allows REST and Websockets to be configured at 
> the same time.  I've personally tried to do this on a couple of attempts 
> while following a Netty sample, but I've never been able to get it to work.  
> Perhaps folks like [~pluradj] or [~dmill] would like to give it a go some 
> day? :)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] tinkerpop issue #618: [TINKERPOP-915]Add combined handler for Http and Webso...

[krlohnes]

Github user krlohnes commented on the issue:

https://github.com/apache/tinkerpop/pull/618
  
@spmallette Thanks for the heads up. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (TINKERPOP-1687) Record metrics around how long it gremlin script executions sit in executor queue waiting to be executed.

[stephen mallette (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette updated TINKERPOP-1687:

Component/s: server

> Record metrics around how long it gremlin script executions sit in executor 
> queue waiting to be executed.
> -
>
> Key: TINKERPOP-1687
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1687
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.2.4
>Reporter: David Pitera
>Priority: Minor
>  Labels: breaking
> Fix For: 3.2.5
>
>
> The issue will be breaking because I will be moving the MetricManager into 
> the gremlin-core project from the gremlin-server project for easier use 
> across the project. Therefore whoever is using the MetricManager will need to 
> update their location from where they grab it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (TINKERPOP-1686) Make TraversalMetrics thread safe

[stephen mallette (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette updated TINKERPOP-1686:

Summary: Make TraversalMetrics thread safe  (was: Make Metrics thread safe)

> Make TraversalMetrics thread safe
> -
>
> Key: TINKERPOP-1686
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1686
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.4
>Reporter: stephen mallette
>Assignee: stephen mallette
>
> Ensure that it is possible to write to metrics from multiple threads.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TINKERPOP-1552) C# Gremlin Language Variant

[stephen mallette (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16042914#comment-16042914
 ] 

stephen mallette commented on TINKERPOP-1552:
-

I just cleaned up the poms a bit here and got rid of what looked like 
unnecessary declarations. Seemed to build ok for me after all my changes.

> C# Gremlin Language Variant
> ---
>
> Key: TINKERPOP-1552
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1552
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: language-variant
>Affects Versions: 3.2.3
>Reporter: Jorge Bay
>Assignee: stephen mallette
>
> It would be nice to have a C# GLV that runs under .NET Framework 4.5+ and 
> .NET Core.
> The maven build could use the Exec Maven Plugin to exec .NET Core's [dotnet 
> test|https://www.microsoft.com/net/core#macos] command.
> Some requirements, from the mailing list (edited):
> {quote}
> 1. The GLV should keep in line with class/method names of the java API
> where possible to ensure consistency of feel across languages.
> 2. There needs to be adequate tests (we're still discussing the approach to
> testing GLVs and i think that needs to be tackled sooner than later as more
> GLVs start to come in). Those tests should produce xunit style output
> unless there is some good reason not to.
> 3. There needs to be adequate documentation (e.g. Reference docs)
> 4. The build/deploy process needs to be bound to maven which might be one of 
> the trickier bits to deal with.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TINKERPOP-1687) Record metrics around how long it gremlin script executions sit in executor queue waiting to be executed.

[David Pitera (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16042804#comment-16042804
 ] 

David Pitera commented on TINKERPOP-1687:
-

I just noticed this commit: 
https://github.com/apache/tinkerpop/commit/b689deb1dd1a0c745966a1ed5f8e7e3b2d543af2

which makes the MetricManager rely on the GremlinServer which is in the 
gremlin-server module, so I am not sure I'll be able to move the Manager into 
gremlin-core anyway. I will have to think a bit about it, because the code I 
need to instrument is in the gremlin-groovy project 
https://github.com/apache/tinkerpop/blob/master/gremlin-groovy/src/main/java/org/apache/tinkerpop/gremlin/groovy/engine/GremlinExecutor.java#L249-L282

> Record metrics around how long it gremlin script executions sit in executor 
> queue waiting to be executed.
> -
>
> Key: TINKERPOP-1687
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1687
> Project: TinkerPop
>  Issue Type: Improvement
>Affects Versions: 3.2.4
>Reporter: David Pitera
>Priority: Minor
>  Labels: breaking
> Fix For: 3.2.5
>
>
> The issue will be breaking because I will be moving the MetricManager into 
> the gremlin-core project from the gremlin-server project for easier use 
> across the project. Therefore whoever is using the MetricManager will need to 
> update their location from where they grab it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (TINKERPOP-1688) Include TraversalMetrics annotation in pretty print

[stephen mallette (JIRA)]

stephen mallette created TINKERPOP-1688:
---

 Summary: Include TraversalMetrics annotation in pretty print
 Key: TINKERPOP-1688
 URL: https://issues.apache.org/jira/browse/TINKERPOP-1688
 Project: TinkerPop
  Issue Type: Improvement
  Components: process
Affects Versions: 3.2.4
Reporter: stephen mallette
Assignee: stephen mallette


Currently annotations on metrics are not displayed when you view the results of 
a {{profile()}} via {{toString()}}. Including annotations might provide 
important information to users that would otherwise be hidden or force the user 
to manually pick apart the {{TraversalMetrics}} object itself which isn't 
convenient.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TINKERPOP-1687) Record metrics around how long it gremlin script executions sit in executor queue waiting to be executed.

[stephen mallette (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16042818#comment-16042818
 ] 

stephen mallette commented on TINKERPOP-1687:
-

ok - i think we'll want to think this kind of change through carefully (which 
is why a DISCUSS thread might be good as it slows things down a bit). 
{{MetricManager}} is a bit of a bad class. I think metrics should be loaded 
differently and I was going to start making those changes for 3.3.0 which is 
also a breaking change: TINKERPOP-1550

> Record metrics around how long it gremlin script executions sit in executor 
> queue waiting to be executed.
> -
>
> Key: TINKERPOP-1687
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1687
> Project: TinkerPop
>  Issue Type: Improvement
>Affects Versions: 3.2.4
>Reporter: David Pitera
>Priority: Minor
>  Labels: breaking
> Fix For: 3.2.5
>
>
> The issue will be breaking because I will be moving the MetricManager into 
> the gremlin-core project from the gremlin-server project for easier use 
> across the project. Therefore whoever is using the MetricManager will need to 
> update their location from where they grab it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TINKERPOP-1688) Include TraversalMetrics annotation in pretty print

[stephen mallette (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16042990#comment-16042990
 ] 

stephen mallette commented on TINKERPOP-1688:
-

Going with a format that basically looks like this:

{code}
Step   Count  
Traversers   Time (ms)% Dur
=
TinkerGraphStep(vertex,[]) 6
   6   0.077 8.48
\_annotation-1=1234
\_annotation-2=this is a long one. it will wrap nicely from one line to the 
next when it gets longer than
   than the end of the line and then you get this nice wrapping 
action which is good 
HasStep([~label.eq(person)])  48
   4   0.054 5.90
PropertiesStep([age],value)   48
   4   0.056 6.13
SumGlobalStep  1
   1   0.09810.72
>TOTAL -
   -   0.919-
{code}

Obviously annotations will only displayed if they are present.

> Include TraversalMetrics annotation in pretty print
> ---
>
> Key: TINKERPOP-1688
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1688
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.4
>Reporter: stephen mallette
>Assignee: stephen mallette
>
> Currently annotations on metrics are not displayed when you view the results 
> of a {{profile()}} via {{toString()}}. Including annotations might provide 
> important information to users that would otherwise be hidden or force the 
> user to manually pick apart the {{TraversalMetrics}} object itself which 
> isn't convenient.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TINKERPOP-1552) C# Gremlin Language Variant

[Florian Hockmann (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16043013#comment-16043013
 ] 

Florian Hockmann commented on TINKERPOP-1552:
-

Wow, that looks really nice, [~jorgebg]! I just have two questions:

# Is there a reason why you didn't also add a type parameter to {{Traverser}}? 
That would make it possible to be type-safe all the way down to the driver if I 
didn't miss something.
# What do you mean with the comment in the test 
{{g_V_HasXname_markoX_ValueMap_Next}} from {{GraphTraversalTests}}:
{code}
//Unable to cast object of type 
//'System.Collections.Generic.Dictionary`2[System.String,System.Object]' to 
type 
//'System.Collections.Generic.IDictionary`2[System.String,System.Collections.Generic.IList`1[System.Object]]'.
{code}
It seems to work just fine.

Your changes also allow to cleanup the tests a bit as they contain many 
explicit type conversions that aren't needed anymore.

And thank you [~spmallette] for cleaning up the poms! It was really the first 
time that I worked with Maven, hence all the unnecessary declarations. I am 
just seeing an error now when the Gremlin Server should be started / stopped 
for the integration tests with the inlined Groovy script:
{code}
Unable to initialize 'ant' with a new AntBuilder object.  Is Groovy a 
dependency?  If you are using Groovy >= 2.3.0-rc-1, remember to include 
groovy-ant as a dependency
{code}
Nevertheless, everything seems to work anyway. At least all tests pass. I am 
also not 100% sure that this error didn't occur before.

> C# Gremlin Language Variant
> ---
>
> Key: TINKERPOP-1552
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1552
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: language-variant
>Affects Versions: 3.2.3
>Reporter: Jorge Bay
>Assignee: stephen mallette
>
> It would be nice to have a C# GLV that runs under .NET Framework 4.5+ and 
> .NET Core.
> The maven build could use the Exec Maven Plugin to exec .NET Core's [dotnet 
> test|https://www.microsoft.com/net/core#macos] command.
> Some requirements, from the mailing list (edited):
> {quote}
> 1. The GLV should keep in line with class/method names of the java API
> where possible to ensure consistency of feel across languages.
> 2. There needs to be adequate tests (we're still discussing the approach to
> testing GLVs and i think that needs to be tackled sooner than later as more
> GLVs start to come in). Those tests should produce xunit style output
> unless there is some good reason not to.
> 3. There needs to be adequate documentation (e.g. Reference docs)
> 4. The build/deploy process needs to be bound to maven which might be one of 
> the trickier bits to deal with.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TINKERPOP-1552) C# Gremlin Language Variant

[stephen mallette (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16043046#comment-16043046
 ] 

stephen mallette commented on TINKERPOP-1552:
-

I just pushed a fix for that [~Florian Hockmann] - thanks for pointing that out.

> C# Gremlin Language Variant
> ---
>
> Key: TINKERPOP-1552
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1552
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: language-variant
>Affects Versions: 3.2.3
>Reporter: Jorge Bay
>Assignee: stephen mallette
>
> It would be nice to have a C# GLV that runs under .NET Framework 4.5+ and 
> .NET Core.
> The maven build could use the Exec Maven Plugin to exec .NET Core's [dotnet 
> test|https://www.microsoft.com/net/core#macos] command.
> Some requirements, from the mailing list (edited):
> {quote}
> 1. The GLV should keep in line with class/method names of the java API
> where possible to ensure consistency of feel across languages.
> 2. There needs to be adequate tests (we're still discussing the approach to
> testing GLVs and i think that needs to be tackled sooner than later as more
> GLVs start to come in). Those tests should produce xunit style output
> unless there is some good reason not to.
> 3. There needs to be adequate documentation (e.g. Reference docs)
> 4. The build/deploy process needs to be bound to maven which might be one of 
> the trickier bits to deal with.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] tinkerpop issue #618: [TINKERPOP-915]Add combined handler for Http and Webso...

[spmallette]

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/618
  
I probably should have mentioned this on my last post, but I probably won't 
review this until next week as we are currently preparing for release and the 
release branches are frozen during testing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---