[Bug 63383] New: Tomcat9 version of the cookie value bug
https://bz.apache.org/bugzilla/show_bug.cgi?id=63383 Bug ID: 63383 Summary: Tomcat9 version of the cookie value bug Product: Tomcat 9 Version: 9.0.19 Hardware: PC Status: NEW Severity: critical Priority: P2 Component: Servlet Assignee: dev@tomcat.apache.org Reporter: luanzhao...@outlook.com Target Milestone: - A new version of Tomcat9 has a serious impact on development. The error is that there can be no spaces in the value of the cookie. Otherwise, the addCookie method cannot be used to add the cookie and send it to the client. The exception is java.lang.IllegalArgumentException. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63382] New: cookie value bug
https://bz.apache.org/bugzilla/show_bug.cgi?id=63382 Bug ID: 63382 Summary: cookie value bug Product: Tomcat 9 Version: 9.0.17 Hardware: PC Status: NEW Severity: blocker Priority: P2 Component: Servlet Assignee: dev@tomcat.apache.org Reporter: luanzhao...@outlook.com Target Milestone: - Created attachment 36548 --> https://bz.apache.org/bugzilla/attachment.cgi?id=36548=edit I will submit a demo written by the test cookie In the value of cookie there can be no spaces, if there are spaces, you can not call the addCookie method to add cookies and send them to the front desk, which seriously affects the use of cookies. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63370] Message files (LocalStrings_*.properties) of the examples webapp not converted to ascii
https://bz.apache.org/bugzilla/show_bug.cgi?id=63370 Woonsan Ko changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Woonsan Ko --- Fixed in: - master for 9.0.20 onwards -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch master updated (f11449d -> 687c0ff)
This is an automated email from the ASF dual-hosted git repository. woonsan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from f11449d Cleanup new a02c62f native2ascii on example war messages new 29e44ab 63370 update changelog new 687c0ff Merge pull request #159 from woonsan/bugfix/messages_of_examples_war The 20779 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: build.xml | 9 + webapps/docs/changelog.xml | 8 2 files changed, 17 insertions(+) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] woonsan merged pull request #159: 63370 - Message files (LocalStrings_*.properties) of the examples webapp not converted to ascii
woonsan merged pull request #159: 63370 - Message files (LocalStrings_*.properties) of the examples webapp not converted to ascii URL: https://github.com/apache/tomcat/pull/159 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [tomcat] branch master updated: Security hardening. Avoid loading user specified classes.
On 23/04/2019 14:44, Christopher Schultz wrote:
> Mark,
>
> On 4/18/19 14:34, ma...@apache.org wrote:
>> This is an automated email from the ASF dual-hosted git
>> repository.
>
>> markt pushed a commit to branch master in repository
>> https://gitbox.apache.org/repos/asf/tomcat.git
>
>
>> The following commit(s) were added to refs/heads/master by this
>> push: new 3032e08 Security hardening. Avoid loading user specified
>> classes. 3032e08 is described below
>
>> commit 3032e08baec63874fec292daf288c319719dfeac Author: Mark Thomas
>> AuthorDate: Thu Apr 18 19:32:57 2019 +0100
>
>> Security hardening. Avoid loading user specified classes.
>
>> The user is trusted so loading a user specified class should be
>> safe but given it isn't necessary to load the class, avoid doing
>> so. Reported by Coverity scan.
>
> [...]
>
>> diff --git a/java/org/apache/tomcat/util/IntrospectionUtils.java
>> b/java/org/apache/tomcat/util/IntrospectionUtils.java index
>> 82752e4..bb954fb 100644 ---
>> a/java/org/apache/tomcat/util/IntrospectionUtils.java +++
>> b/java/org/apache/tomcat/util/IntrospectionUtils.java @@ -433,6
>> +433,28 @@ public final class IntrospectionUtils { return result;
>> }
>
>> + +public static boolean isInstance(Class clazz, String
>> type) { +if (type.equals(clazz.getName())) { +
>> return true; +} + +Class[] ifaces =
>> clazz.getInterfaces(); +for (Class iface : ifaces) { +
>> if (isInstance(iface, type)) { +return true; +
>> } +} + +Class superClazz =
>> clazz.getSuperclass(); +if (superClazz == null) { +
>> return false; +} else { +return
>> isInstance(superClazz, type); +} +} +
>
> This method is basically Class.isAssignableFrom except that it works
> on a String argument and never instantiates the Class object it
> represents, right?
Correct.
> If so, I'll add a little Javadoc because when I has read the code
> (without apparently reading the "Detail" text of this patch), I
> thought "why not just call Class.isAssignableFrom instead of all this?
Thanks.
> Is there ever any problem with primitive values, or is that never an
> issue?
In this instance I think any primitive type will be boxed to the
corresponding object. More generally, I guess this might get used with
primitives at some point. I don't think I tested that.
Mark
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Finally getting around to switching to Git
On 4/23/2019 8:48 AM, Martin Grigorov wrote: On Tue, Apr 23, 2019, 17:29 Christopher Schultz < ch...@christopherschultz.net> wrote: Setting up the account is needed. I failed to do it, and Mark told me I needed three green ticks there: https://gitbox.apache.org/setup/ Thanks. Looks like I'm not a part of the ASF-org on GitHub. Anyone with the Karma to do so, can I be added to ASF-org on GitHub? My GitHub username is ChristopherSchultz. Go to https://id.apache.org and enter your Github ID there. Right. You will also need to enable 2FA on GitHub (I am using the FreeOTP app which works well for me), and when pushing commits I was only able to use it with the https:// scheme and not with the git:// one. Another thing that I have changed in my workflow based on Mark's past suggestion, is that I keep a local repo for each major branch now. While in the past I would use a single local repo and just switch branches, I have found that it messes things up in the IDE etc. I therefore now keep 3 local directories, each set to a different major branch. It seemed contrary to most git workflows at first, but I find that switching between branches that have major changes in the development environment can get messy. Best, Igal - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Finally getting around to switching to Git
On Tue, Apr 23, 2019, 17:29 Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Rémy, > > On 4/23/19 10:07, Rémy Maucherat wrote: > > On Tue, Apr 23, 2019 at 3:54 PM Christopher Schultz < > > ch...@christopherschultz.net> wrote: > > > > All, > > > > I haven't updated my local working copies of Tomcat source since > > the move to Git. I'm going to do that, now, and I'm looking for > > advice. > > > > Specifically, which repo is "better" -- gitbox or GitHub? I'm > > guessing the its all go to the same place eventually. Should > > committers use gitbox for direct-commits? If I use GitHub, will my > > commits require some other review? Do I have to link my GitHub > > account with my ASF LDAP id? Is one of them reliably faster? > > > > > >> I use github personally. No commit review is required (but for > >> example I used a PR for larger NIO changes, although in the end I > >> didn't really get any feedback). > > > >> Setting up the account is needed. I failed to do it, and Mark > >> told me I needed three green ticks there: > >> https://gitbox.apache.org/setup/ > Thanks. Looks like I'm not a part of the ASF-org on GitHub. > > Anyone with the Karma to do so, can I be added to ASF-org on GitHub? > My GitHub username is ChristopherSchultz. > Go to https://id.apache.org and enter your Github ID there. > - -chris > -BEGIN PGP SIGNATURE- > Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ > > iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAly/ISUACgkQHPApP6U8 > pFgFrQ/8DeucBQTlxJ4TVKVZIBbR5yqq7KoOqaEH3UWsZ4hFdudmWsGZoV+2zkbL > NVaSJPaAGSu7uA2xH8dCeg/151V4PKBlbvV/Q00xiMF6cC58skneNurOdysJIyuX > UdaUgLVu9juzRrXk4MnedenXFEJGGq7hVo+7APVKfmWju38Zut3iCpAzU8YNAaa1 > alKE0ZXopLWiBh07oTHIea7+fMdlxucgwPbcg3a4QmSR1sy8mH/qIwbSiWk+irWT > EiFJKst7E13qAb1Zi3KuOtYny06jZWyTW3Jo8EzWRAHkMUUKEpG1WkXcl2gLw1qz > IQAVXjIUT2rfCQK3bcdmwvhriM7tWAfaK4NETlxu77QgoSRuA0+DbZgvHIP73FRg > MK/EORN15d+pQiB7ez//qwlHSm11+nJALynkWRhYb6q9LvNaq2kN6ympyiAch3PO > bm4bj8gbXSgquSHNMvxcw3dLNjL9yySh9vJ17WBbkunLTW9dRjuuMYIXwTtPRB34 > lSfeZZP1iorBivbZeidS3WBUDXNXy0U9d/bFrJWfK25YR+2LqolIkokKXMx9H/MC > KjaqFqn/uGBjLxjbLNEfAh/KksTR7zc2XfQTIXCJMyQnJvamuhw64BAinrOraUjS > MdVCXfYWcfkZoHzpLl9svgVUX3GtptxoCxUCgMpih9akyuVLNOU= > =VMk3 > -END PGP SIGNATURE- > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
Re: Finally getting around to switching to Git
On Tue, Apr 23, 2019 at 10:33 AM Rémy Maucherat wrote: > On Tue, Apr 23, 2019 at 4:29 PM Christopher Schultz < > ch...@christopherschultz.net> wrote: > > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA256 > > > > Rémy, > > > > On 4/23/19 10:07, Rémy Maucherat wrote: > > > On Tue, Apr 23, 2019 at 3:54 PM Christopher Schultz < > > > ch...@christopherschultz.net> wrote: > > > > > > All, > > > > > > I haven't updated my local working copies of Tomcat source since > > > the move to Git. I'm going to do that, now, and I'm looking for > > > advice. > > > > > > Specifically, which repo is "better" -- gitbox or GitHub? I'm > > > guessing the its all go to the same place eventually. Should > > > committers use gitbox for direct-commits? If I use GitHub, will my > > > commits require some other review? Do I have to link my GitHub > > > account with my ASF LDAP id? Is one of them reliably faster? > > > > > > > > >> I use github personally. No commit review is required (but for > > >> example I used a PR for larger NIO changes, although in the end I > > >> didn't really get any feedback). > > > > So did you fork the Tomcat project and you commit to your fork with > > PRs usually? Or just for some stuff? > > > > I did fork and I use it to do big stuff [this way I can accidentally trash > the repo without too many problems too ;) ]. For small stuff I simply use > the main repo instead. > +1. Since I'm not as experienced as others, I sometimes create a PR for things I'm unsure about to be reviewed before pushing to master also :) > > Rémy > > > > > > - -chris > > -BEGIN PGP SIGNATURE- > > Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ > > > > iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAly/IV0ACgkQHPApP6U8 > > pFgUFRAAmQLAO8Tn2eKDkcru+PptsybUG1aNYDpRAmAyARAZuu6m50E8HkS0urZ9 > > ZlYI4WN9SN6TZuoimnhJp8GzEmoX3nKkhMuGqvxsKLvM+QG7iEkfN1/hisf2/8im > > C7exCA43U5TImja6Z+TaXZIV1ZFdoN5dbSzHdj+nACU0gctpjE+jurZ16unRdNCZ > > ZlNZwJen2wKCDwmk9dedAHrVuK7mGgoNkkxj/gqeBimuVeqKSwt/85wGDG/tkqRv > > 8JVe1OhiP/48t1T5P2cMURSUjRYsLeyqRNPjHzU+Bgi1eK/mvACqzDvRNnixU8l/ > > ZjhZGksqBTIBkDEY7C39JM0tDqjW5/N4CBovWBsM4ONAkSGiqzSKuUCn9hEGqBkq > > t3RsWg6LJ3GfT40F3xXHhE2Z/txW5wZ6qrB9vozbbPHExCPAsRCbgQ3WfW8DxxT/ > > Wt7f+mdjGGYCmkiVsWG7+MimK1po14ANkBnE+Ylo9zd2GH6W29AC4aDOOuROOq2S > > DLFhAlw9WxaioqtRE6mhDdadzAV0HfEnRDouZb9Ma6M7DfXoFE1BuQ7cQQeF8ItZ > > FZ1VyiV5WOFu7+SHtePx+R6nFfsBpLNFoIEdisMn0WbTiGgoQGyJDlxazAQnuCFx > > tKIsIDSDOOPbW8XL2bT96GpELAXFjcoOvchUh1dvblcM0Ir4DYM= > > =i8Yc > > -END PGP SIGNATURE- > > >
Re: Finally getting around to switching to Git
On Tue, Apr 23, 2019 at 4:29 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Rémy, > > On 4/23/19 10:07, Rémy Maucherat wrote: > > On Tue, Apr 23, 2019 at 3:54 PM Christopher Schultz < > > ch...@christopherschultz.net> wrote: > > > > All, > > > > I haven't updated my local working copies of Tomcat source since > > the move to Git. I'm going to do that, now, and I'm looking for > > advice. > > > > Specifically, which repo is "better" -- gitbox or GitHub? I'm > > guessing the its all go to the same place eventually. Should > > committers use gitbox for direct-commits? If I use GitHub, will my > > commits require some other review? Do I have to link my GitHub > > account with my ASF LDAP id? Is one of them reliably faster? > > > > > >> I use github personally. No commit review is required (but for > >> example I used a PR for larger NIO changes, although in the end I > >> didn't really get any feedback). > > So did you fork the Tomcat project and you commit to your fork with > PRs usually? Or just for some stuff? > I did fork and I use it to do big stuff [this way I can accidentally trash the repo without too many problems too ;) ]. For small stuff I simply use the main repo instead. Rémy > > - -chris > -BEGIN PGP SIGNATURE- > Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ > > iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAly/IV0ACgkQHPApP6U8 > pFgUFRAAmQLAO8Tn2eKDkcru+PptsybUG1aNYDpRAmAyARAZuu6m50E8HkS0urZ9 > ZlYI4WN9SN6TZuoimnhJp8GzEmoX3nKkhMuGqvxsKLvM+QG7iEkfN1/hisf2/8im > C7exCA43U5TImja6Z+TaXZIV1ZFdoN5dbSzHdj+nACU0gctpjE+jurZ16unRdNCZ > ZlNZwJen2wKCDwmk9dedAHrVuK7mGgoNkkxj/gqeBimuVeqKSwt/85wGDG/tkqRv > 8JVe1OhiP/48t1T5P2cMURSUjRYsLeyqRNPjHzU+Bgi1eK/mvACqzDvRNnixU8l/ > ZjhZGksqBTIBkDEY7C39JM0tDqjW5/N4CBovWBsM4ONAkSGiqzSKuUCn9hEGqBkq > t3RsWg6LJ3GfT40F3xXHhE2Z/txW5wZ6qrB9vozbbPHExCPAsRCbgQ3WfW8DxxT/ > Wt7f+mdjGGYCmkiVsWG7+MimK1po14ANkBnE+Ylo9zd2GH6W29AC4aDOOuROOq2S > DLFhAlw9WxaioqtRE6mhDdadzAV0HfEnRDouZb9Ma6M7DfXoFE1BuQ7cQQeF8ItZ > FZ1VyiV5WOFu7+SHtePx+R6nFfsBpLNFoIEdisMn0WbTiGgoQGyJDlxazAQnuCFx > tKIsIDSDOOPbW8XL2bT96GpELAXFjcoOvchUh1dvblcM0Ir4DYM= > =i8Yc > -END PGP SIGNATURE- >
Re: Finally getting around to switching to Git
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rémy, On 4/23/19 10:07, Rémy Maucherat wrote: > On Tue, Apr 23, 2019 at 3:54 PM Christopher Schultz < > ch...@christopherschultz.net> wrote: > > All, > > I haven't updated my local working copies of Tomcat source since > the move to Git. I'm going to do that, now, and I'm looking for > advice. > > Specifically, which repo is "better" -- gitbox or GitHub? I'm > guessing the its all go to the same place eventually. Should > committers use gitbox for direct-commits? If I use GitHub, will my > commits require some other review? Do I have to link my GitHub > account with my ASF LDAP id? Is one of them reliably faster? > > >> I use github personally. No commit review is required (but for >> example I used a PR for larger NIO changes, although in the end I >> didn't really get any feedback). So did you fork the Tomcat project and you commit to your fork with PRs usually? Or just for some stuff? - -chris -BEGIN PGP SIGNATURE- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAly/IV0ACgkQHPApP6U8 pFgUFRAAmQLAO8Tn2eKDkcru+PptsybUG1aNYDpRAmAyARAZuu6m50E8HkS0urZ9 ZlYI4WN9SN6TZuoimnhJp8GzEmoX3nKkhMuGqvxsKLvM+QG7iEkfN1/hisf2/8im C7exCA43U5TImja6Z+TaXZIV1ZFdoN5dbSzHdj+nACU0gctpjE+jurZ16unRdNCZ ZlNZwJen2wKCDwmk9dedAHrVuK7mGgoNkkxj/gqeBimuVeqKSwt/85wGDG/tkqRv 8JVe1OhiP/48t1T5P2cMURSUjRYsLeyqRNPjHzU+Bgi1eK/mvACqzDvRNnixU8l/ ZjhZGksqBTIBkDEY7C39JM0tDqjW5/N4CBovWBsM4ONAkSGiqzSKuUCn9hEGqBkq t3RsWg6LJ3GfT40F3xXHhE2Z/txW5wZ6qrB9vozbbPHExCPAsRCbgQ3WfW8DxxT/ Wt7f+mdjGGYCmkiVsWG7+MimK1po14ANkBnE+Ylo9zd2GH6W29AC4aDOOuROOq2S DLFhAlw9WxaioqtRE6mhDdadzAV0HfEnRDouZb9Ma6M7DfXoFE1BuQ7cQQeF8ItZ FZ1VyiV5WOFu7+SHtePx+R6nFfsBpLNFoIEdisMn0WbTiGgoQGyJDlxazAQnuCFx tKIsIDSDOOPbW8XL2bT96GpELAXFjcoOvchUh1dvblcM0Ir4DYM= =i8Yc -END PGP SIGNATURE- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Finally getting around to switching to Git
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rémy, On 4/23/19 10:07, Rémy Maucherat wrote: > On Tue, Apr 23, 2019 at 3:54 PM Christopher Schultz < > ch...@christopherschultz.net> wrote: > > All, > > I haven't updated my local working copies of Tomcat source since > the move to Git. I'm going to do that, now, and I'm looking for > advice. > > Specifically, which repo is "better" -- gitbox or GitHub? I'm > guessing the its all go to the same place eventually. Should > committers use gitbox for direct-commits? If I use GitHub, will my > commits require some other review? Do I have to link my GitHub > account with my ASF LDAP id? Is one of them reliably faster? > > >> I use github personally. No commit review is required (but for >> example I used a PR for larger NIO changes, although in the end I >> didn't really get any feedback). > >> Setting up the account is needed. I failed to do it, and Mark >> told me I needed three green ticks there: >> https://gitbox.apache.org/setup/ Thanks. Looks like I'm not a part of the ASF-org on GitHub. Anyone with the Karma to do so, can I be added to ASF-org on GitHub? My GitHub username is ChristopherSchultz. - -chris -BEGIN PGP SIGNATURE- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAly/ISUACgkQHPApP6U8 pFgFrQ/8DeucBQTlxJ4TVKVZIBbR5yqq7KoOqaEH3UWsZ4hFdudmWsGZoV+2zkbL NVaSJPaAGSu7uA2xH8dCeg/151V4PKBlbvV/Q00xiMF6cC58skneNurOdysJIyuX UdaUgLVu9juzRrXk4MnedenXFEJGGq7hVo+7APVKfmWju38Zut3iCpAzU8YNAaa1 alKE0ZXopLWiBh07oTHIea7+fMdlxucgwPbcg3a4QmSR1sy8mH/qIwbSiWk+irWT EiFJKst7E13qAb1Zi3KuOtYny06jZWyTW3Jo8EzWRAHkMUUKEpG1WkXcl2gLw1qz IQAVXjIUT2rfCQK3bcdmwvhriM7tWAfaK4NETlxu77QgoSRuA0+DbZgvHIP73FRg MK/EORN15d+pQiB7ez//qwlHSm11+nJALynkWRhYb6q9LvNaq2kN6ympyiAch3PO bm4bj8gbXSgquSHNMvxcw3dLNjL9yySh9vJ17WBbkunLTW9dRjuuMYIXwTtPRB34 lSfeZZP1iorBivbZeidS3WBUDXNXy0U9d/bFrJWfK25YR+2LqolIkokKXMx9H/MC KjaqFqn/uGBjLxjbLNEfAh/KksTR7zc2XfQTIXCJMyQnJvamuhw64BAinrOraUjS MdVCXfYWcfkZoHzpLl9svgVUX3GtptxoCxUCgMpih9akyuVLNOU= =VMk3 -END PGP SIGNATURE- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Finally getting around to switching to Git
On Tue, Apr 23, 2019 at 3:54 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > All, > > I haven't updated my local working copies of Tomcat source since the > move to Git. I'm going to do that, now, and I'm looking for advice. > > Specifically, which repo is "better" -- gitbox or GitHub? I'm guessing > the its all go to the same place eventually. Should committers use > gitbox for direct-commits? If I use GitHub, will my commits require > some other review? Do I have to link my GitHub account with my ASF > LDAP id? Is one of them reliably faster? > I use github personally. No commit review is required (but for example I used a PR for larger NIO changes, although in the end I didn't really get any feedback). Setting up the account is needed. I failed to do it, and Mark told me I needed three green ticks there: https://gitbox.apache.org/setup/ Rémy > > Some guidance would be appreciated. > > Thanks, > - -chris > -BEGIN PGP SIGNATURE- > Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ > > iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAly/GQ4ACgkQHPApP6U8 > pFgOgRAAyJwFf1rJw9TjQDPqeGekcSzchfflAxplYu6F5o8GFvwkxDeVzHgxGXe8 > Z9t5Oq+Fonmj62rvepxxIarXTTqRCqpsmRIYTzZ8LXwMzlBuZIOeM6ilTijo5HgG > YDWocwLOY7cSIPXtqSBa7zDlloO27drBnb14kadoXJRpqBmwQnssOKOU2hInKzhJ > /SJBp7r//d1tVYSo4J1wRqKigOi8RojafqM1+rh61L1CJlBVK9PCNjdzeP/ewm3l > TBVWekhqDWTXcogEJ7PsxH+zPrfp5EDG03tAl3q7nho/yA1MN0XwTjw3hxbHPCg9 > pKZ+UJzCQpczsJTl5hxR1BemVGZHsReFTZyUEl1AEJDxeg8bXiPtI6AlIN3fYOjP > eJC8kZcoH4Jcge767DuOPQCc1uPyrR1cINl7ajRGdeU1nGTUhwgjZjDRB1eiCTVn > glzK9o88/mpPNEv3ruP/LdnLlj6so+ax4bokxqfnfrBzInYx+jeWiROY/HKik1sA > ysCOEg4tvNazaop26xDMJ5MNROUVcmhd+v2CbM8nZh+6nOoigf8xbRLgT6iJUcDp > 2CgJnWkSIIzadaG4N6CaCHDs03/9jkgDio00nQNDrVS9ufTGlf618bsUHl+Z9wWx > BMo/cLoKOvPasRRIkJRtEzm2VEp4CiPCMq+SLNuiwqkpZ25MRP0= > =1wFC > -END PGP SIGNATURE- > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
[Bug 63379] Tomcat socket listening timeouts
https://bz.apache.org/bugzilla/show_bug.cgi?id=63379 --- Comment #3 from Remy Maucherat --- (In reply to vojtech from comment #2) > What else can I provide you with? Can I create you some kind of internal log > dump? We need to understand why this timeout occurs, since it's an exception thrown by the JVM, and how to avoid it if possible. For a workaround, unless you really don't need the shutdown command, you can also configure the org.apache.catalina.core.StandardServer logger. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Finally getting around to switching to Git
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, I haven't updated my local working copies of Tomcat source since the move to Git. I'm going to do that, now, and I'm looking for advice. Specifically, which repo is "better" -- gitbox or GitHub? I'm guessing the its all go to the same place eventually. Should committers use gitbox for direct-commits? If I use GitHub, will my commits require some other review? Do I have to link my GitHub account with my ASF LDAP id? Is one of them reliably faster? Some guidance would be appreciated. Thanks, - -chris -BEGIN PGP SIGNATURE- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAly/GQ4ACgkQHPApP6U8 pFgOgRAAyJwFf1rJw9TjQDPqeGekcSzchfflAxplYu6F5o8GFvwkxDeVzHgxGXe8 Z9t5Oq+Fonmj62rvepxxIarXTTqRCqpsmRIYTzZ8LXwMzlBuZIOeM6ilTijo5HgG YDWocwLOY7cSIPXtqSBa7zDlloO27drBnb14kadoXJRpqBmwQnssOKOU2hInKzhJ /SJBp7r//d1tVYSo4J1wRqKigOi8RojafqM1+rh61L1CJlBVK9PCNjdzeP/ewm3l TBVWekhqDWTXcogEJ7PsxH+zPrfp5EDG03tAl3q7nho/yA1MN0XwTjw3hxbHPCg9 pKZ+UJzCQpczsJTl5hxR1BemVGZHsReFTZyUEl1AEJDxeg8bXiPtI6AlIN3fYOjP eJC8kZcoH4Jcge767DuOPQCc1uPyrR1cINl7ajRGdeU1nGTUhwgjZjDRB1eiCTVn glzK9o88/mpPNEv3ruP/LdnLlj6so+ax4bokxqfnfrBzInYx+jeWiROY/HKik1sA ysCOEg4tvNazaop26xDMJ5MNROUVcmhd+v2CbM8nZh+6nOoigf8xbRLgT6iJUcDp 2CgJnWkSIIzadaG4N6CaCHDs03/9jkgDio00nQNDrVS9ufTGlf618bsUHl+Z9wWx BMo/cLoKOvPasRRIkJRtEzm2VEp4CiPCMq+SLNuiwqkpZ25MRP0= =1wFC -END PGP SIGNATURE- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [tomcat] branch master updated: Security hardening. Avoid loading user specified classes.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Mark,
On 4/18/19 14:34, ma...@apache.org wrote:
> This is an automated email from the ASF dual-hosted git
> repository.
>
> markt pushed a commit to branch master in repository
> https://gitbox.apache.org/repos/asf/tomcat.git
>
>
> The following commit(s) were added to refs/heads/master by this
> push: new 3032e08 Security hardening. Avoid loading user specified
> classes. 3032e08 is described below
>
> commit 3032e08baec63874fec292daf288c319719dfeac Author: Mark Thomas
> AuthorDate: Thu Apr 18 19:32:57 2019 +0100
>
> Security hardening. Avoid loading user specified classes.
>
> The user is trusted so loading a user specified class should be
> safe but given it isn't necessary to load the class, avoid doing
> so. Reported by Coverity scan.
[...]
> diff --git a/java/org/apache/tomcat/util/IntrospectionUtils.java
> b/java/org/apache/tomcat/util/IntrospectionUtils.java index
> 82752e4..bb954fb 100644 ---
> a/java/org/apache/tomcat/util/IntrospectionUtils.java +++
> b/java/org/apache/tomcat/util/IntrospectionUtils.java @@ -433,6
> +433,28 @@ public final class IntrospectionUtils { return result;
> }
>
> + +public static boolean isInstance(Class clazz, String
> type) { +if (type.equals(clazz.getName())) { +
> return true; +} + +Class[] ifaces =
> clazz.getInterfaces(); +for (Class iface : ifaces) { +
> if (isInstance(iface, type)) { +return true; +
> } +} + +Class superClazz =
> clazz.getSuperclass(); +if (superClazz == null) { +
> return false; +} else { +return
> isInstance(superClazz, type); +} +} +
This method is basically Class.isAssignableFrom except that it works
on a String argument and never instantiates the Class object it
represents, right?
If so, I'll add a little Javadoc because when I has read the code
(without apparently reading the "Detail" text of this patch), I
thought "why not just call Class.isAssignableFrom instead of all this?
Is there ever any problem with primitive values, or is that never an
issue?
- -chris
-BEGIN PGP SIGNATURE-
Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/
iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAly/FtIACgkQHPApP6U8
pFjJYw/+Lw6As1tmjIhNI8o6F26RILrg6j3hFK6BfPC+Sq2vSuDXpeAwg74d641e
rpf/RzSpt08AYDU7cEFaALGJX1+FoC/jOD5/kfQvt3blaKn+fteFXAl5w4vX6Ato
y30jy4H0drdAATcHjFyvIlVD9U1YRra345kmN8ARHLkb3O8aSGYrBvWfPbe7vzLv
iEkGXBp/CJj/H1Vq8KWszJ1kNtbue8HQx5NhF9UvLIWKwZQzpDHrYtBr9uyaai46
twD535AqhhjyStLqgG1+Dgq4jMjHOyABD2NY2bH0KQBbbzzJhZTLJjQuKR8HweeK
U+DoypqKh606vAMmTVdc5X/6IjyxRFoXTlhGheYpQjeESLBFDKfPW1ZnV6k0BhFC
kPXEJJAYZRRONaEocumWjmQ1d7nTqStfRvzLUTWwkdf7UnGheSgc7rhxLS2pFRPe
il3cG1JRVxECa7GzagnTu1o+0QecaUxZKW0KNUFd9zo9l2ohvuHRwG5D96+3/CDM
uHAD8T5Xpk7zkSRZ/UbympZAGjXz/trh6Srxo6Upi9HtOtN4YrsKBtWPQvWitPBg
fba7r6aRGrtussjoe9FG+Gkt4vG1Mm/uhRd5gPBzUuqBK/FXIJ0jHOC/Jl8IqBq0
Rx0ptB0BQLn8BvQZTEkSPGoCFVWsAnxXdhJptPNUJTV3BPI5RBs=
=alEg
-END PGP SIGNATURE-
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63379] Tomcat socket listening timeouts
https://bz.apache.org/bugzilla/show_bug.cgi?id=63379 --- Comment #2 from vojt...@knyt.tl --- What else can I provide you with? Can I create you some kind of internal log dump? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63379] Tomcat socket listening timeouts
https://bz.apache.org/bugzilla/show_bug.cgi?id=63379 Remy Maucherat changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #1 from Remy Maucherat --- A 256ms timeout is obviously a problem. I'm not getting it on Linux / JDK 11. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63379] Tomcat socket listening timeouts
https://bz.apache.org/bugzilla/show_bug.cgi?id=63379 vojt...@knyt.tl changed: What|Removed |Added CC||vojt...@knyt.tl -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63379] New: Tomcat socket listening timeouts
https://bz.apache.org/bugzilla/show_bug.cgi?id=63379 Bug ID: 63379 Summary: Tomcat socket listening timeouts Product: Tomcat 9 Version: 9.0.16 Hardware: PC OS: Linux Status: NEW Severity: normal Priority: P2 Component: Catalina Assignee: dev@tomcat.apache.org Reporter: vojt...@knyt.tl Target Milestone: - We just updated from JDK8 to JDK11 and our Tomcat started reporting this warning (we use Docker image tomcat:9-jre11-slim): 2019-04-17 10:17:35.060 WARNING [:tomcat] org.apache.catalina.core.StandardServer The socket listening for the shutdown command experienced an unexpected timeout [256] milliseconds after the call to accept(). Is this an instance of bug 56684? java.net.SocketTimeoutException: Accept timed out at java.base/java.net.PlainSocketImpl.socketAccept(Native Method) at java.base/java.net.AbstractPlainSocketImpl.accept(AbstractPlainSocketImpl.java:458) at java.base/java.net.ServerSocket.implAccept(ServerSocket.java:551) at java.base/java.net.ServerSocket.accept(ServerSocket.java:519) at org.apache.catalina.core.StandardServer.await(StandardServer.java:607) at org.apache.catalina.startup.Catalina.await(Catalina.java:722) at org.apache.catalina.startup.Catalina.start(Catalina.java:668) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:350) at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:492) The bug #56684 mentioned in the warning refers to this: https://bz.apache.org/bugzilla/show_bug.cgi?id=56684 - which is probably fixed and not very relevant. We get hundreds of these exceptions in our logs and we have disabled it with setting -1 to the shutdown port as a temporary solution. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch master updated: Cleanup
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new f11449d Cleanup
f11449d is described below
commit f11449d9ebb09c5bb5c5571b413b29475c8a9fd6
Author: remm
AuthorDate: Tue Apr 23 13:50:48 2019 +0200
Cleanup
It seems the Registry constructor could be protected since getRegistry
should be used instead.
---
java/org/apache/tomcat/util/modeler/NoDescriptorRegistry.java | 2 +-
java/org/apache/tomcat/util/modeler/Registry.java | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/java/org/apache/tomcat/util/modeler/NoDescriptorRegistry.java
b/java/org/apache/tomcat/util/modeler/NoDescriptorRegistry.java
index ef7d341..33c5d97 100644
--- a/java/org/apache/tomcat/util/modeler/NoDescriptorRegistry.java
+++ b/java/org/apache/tomcat/util/modeler/NoDescriptorRegistry.java
@@ -44,7 +44,7 @@ import javax.management.QueryExp;
import javax.management.ReflectionException;
import javax.management.loading.ClassLoaderRepository;
-/*
+/**
* An implementation of the MBean registry that effectively disables MBean
* registration. This is typically used when low memory footprint is a primary
* concern.
diff --git a/java/org/apache/tomcat/util/modeler/Registry.java
b/java/org/apache/tomcat/util/modeler/Registry.java
index 5a66a0f..0958a92 100644
--- a/java/org/apache/tomcat/util/modeler/Registry.java
+++ b/java/org/apache/tomcat/util/modeler/Registry.java
@@ -114,7 +114,7 @@ public class Registry implements RegistryMBean,
MBeanRegistration {
// --- Constructors
-public Registry() {
+protected Registry() {
super();
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63377] Failed Error during WebSocket handshake: Unexpected response code: 404
https://bz.apache.org/bugzilla/show_bug.cgi?id=63377 --- Comment #3 from Mark Thomas --- There are no code changes to the WebSocket code between the 8.5.39 and 8.5.40 tags. Again, the users list is the place to seek help. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63377] Failed Error during WebSocket handshake: Unexpected response code: 404
https://bz.apache.org/bugzilla/show_bug.cgi?id=63377 --- Comment #2 from David Querci --- I don't think it's a configuration problem. Using the version of tomcat 8.5.40 and changing the jar tomcat-websocket.jar with that of version 8.5.39 the problem does not occur. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63377] Failed Error during WebSocket handshake: Unexpected response code: 404
https://bz.apache.org/bugzilla/show_bug.cgi?id=63377 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME OS||All --- Comment #1 from Mark Thomas --- The built-in WebSocket examples work for me in the latest 8.5.x code. I don't recall any changes to WebSocket that could trigger this. Neither does the changelog list any relevant changes. This looks like a configuration error. Please use the users mailing list to debug this further. If that thread concludes there there is a Tomcat bug, please re-open this issue and add the exact steps to reproduce it from a clean Tomcat install. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63361] Provide a configuration option to disable MBean registration
https://bz.apache.org/bugzilla/show_bug.cgi?id=63361 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #3 from Mark Thomas --- Fixed in: - master for 9.0.20 onwards Call Registry.disableRegistry() before the first Tomcat MBean is registered. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch master updated (8b88823 -> 4387c2b)
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 8b88823 Remove unused code new 4654cd0 Copy NoDescriptorRegistry from Meecrowave new 263ed70 Fix build warnings new 759536e Format source (mainly line length changes) new c51c0ac Expand comment new 1b7f49c Fix NPE when using with a default Tomcat configuration new 4387c2b Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63361 The 20775 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../tomcat/util/modeler/LocalStrings.properties| 1 + .../tomcat/util/modeler/NoDescriptorRegistry.java | 407 + java/org/apache/tomcat/util/modeler/Registry.java | 9 + webapps/docs/changelog.xml | 6 + 4 files changed, 423 insertions(+) create mode 100644 java/org/apache/tomcat/util/modeler/NoDescriptorRegistry.java - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63377] Failed Error during WebSocket handshake: Unexpected response code: 404
https://bz.apache.org/bugzilla/show_bug.cgi?id=63377 David Querci changed: What|Removed |Added CC||quercida...@gmail.com OS||All -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63377] Failed Error during WebSocket handshake: Unexpected response code: 404
https://bz.apache.org/bugzilla/show_bug.cgi?id=63377 David Querci changed: What|Removed |Added OS|All |Windows 10 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63377] New: Failed Error during WebSocket handshake: Unexpected response code: 404
https://bz.apache.org/bugzilla/show_bug.cgi?id=63377 Bug ID: 63377 Summary: Failed Error during WebSocket handshake: Unexpected response code: 404 Product: Tomcat 8 Version: 8.5.40 Hardware: PC Status: NEW Severity: blocker Priority: P2 Component: WebSocket Assignee: dev@tomcat.apache.org Reporter: quercida...@gmail.com Target Milestone: Using the version of tomcat 8.5.40 for my application the connection via websocket no longer works. The version of java is 8. The error is as follows: WebSocket connection to 'ws: // localhost: 8781 / XXX / XXX / ufsmu02u' failed: Error during WebSocket handshake: Unexpected response code: 404 There is no problem using the version of tomcat 8.5.39. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 58489] QueryStatsComparator throws IllegalArgumentException: Comparison method violates its general contract!
https://bz.apache.org/bugzilla/show_bug.cgi?id=58489 Craig Webb changed: What|Removed |Added CC||c.w...@crossflight.com -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch master updated: Remove unused code
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new 8b88823 Remove unused code
8b88823 is described below
commit 8b8882349f0634467527404d0e5b74043d020708
Author: Mark Thomas
AuthorDate: Tue Apr 23 11:09:08 2019 +0100
Remove unused code
---
java/org/apache/tomcat/util/modeler/Registry.java | 34 ++-
1 file changed, 2 insertions(+), 32 deletions(-)
diff --git a/java/org/apache/tomcat/util/modeler/Registry.java
b/java/org/apache/tomcat/util/modeler/Registry.java
index c116b82..bea9c51 100644
--- a/java/org/apache/tomcat/util/modeler/Registry.java
+++ b/java/org/apache/tomcat/util/modeler/Registry.java
@@ -76,11 +76,6 @@ public class Registry implements RegistryMBean,
MBeanRegistration {
// Support for the factory methods
/**
- * Will be used to isolate different apps and enhance security.
- */
-private static final HashMap perLoaderRegistries = null;
-
-/**
* The registry instance created by our factory method the first time it is
* called.
*/
@@ -131,38 +126,13 @@ public class Registry implements RegistryMBean,
MBeanRegistration {
* Factory method to create (if necessary) and return our
* Registry instance.
*
- * The current version uses a static - future versions could use the thread
- * class loader.
- *
- * @param key Support for application isolation. If null, the context class
- *loader will be used ( if setUseContextClassLoader is called )
- *or the default registry is returned.
+ * @param key Unused
* @param guard Prevent access to the registry by untrusted components
+ *
* @return the registry
* @since 1.1
*/
public static synchronized Registry getRegistry(Object key, Object guard) {
-Registry localRegistry;
-if (perLoaderRegistries != null) {
-if (key == null)
-key = Thread.currentThread().getContextClassLoader();
-if (key != null) {
-localRegistry = perLoaderRegistries.get(key);
-if (localRegistry == null) {
-localRegistry = new Registry();
-// localRegistry.key=key;
-localRegistry.guard = guard;
-perLoaderRegistries.put(key, localRegistry);
-return localRegistry;
-}
-if (localRegistry.guard != null && localRegistry.guard !=
guard) {
-return null; // XXX Should I throw a permission ex ?
-}
-return localRegistry;
-}
-}
-
-// static
if (registry == null) {
registry = new Registry();
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch master updated: Clean-up. Remove unused code.
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new 008b050 Clean-up. Remove unused code.
008b050 is described below
commit 008b0503c40f500e2e2c7cda338810c9f6bae522
Author: Mark Thomas
AuthorDate: Tue Apr 23 11:02:36 2019 +0100
Clean-up. Remove unused code.
A helpful side-effect of this change is that the creation of the
Registry is delayed until the Server container is initialised.
---
.../apache/catalina/mbeans/GlobalResourcesLifecycleListener.java | 7 ---
1 file changed, 7 deletions(-)
diff --git
a/java/org/apache/catalina/mbeans/GlobalResourcesLifecycleListener.java
b/java/org/apache/catalina/mbeans/GlobalResourcesLifecycleListener.java
index b11a925..59db8f2 100644
--- a/java/org/apache/catalina/mbeans/GlobalResourcesLifecycleListener.java
+++ b/java/org/apache/catalina/mbeans/GlobalResourcesLifecycleListener.java
@@ -36,7 +36,6 @@ import org.apache.catalina.User;
import org.apache.catalina.UserDatabase;
import org.apache.juli.logging.Log;
import org.apache.juli.logging.LogFactory;
-import org.apache.tomcat.util.modeler.Registry;
import org.apache.tomcat.util.res.StringManager;
@@ -62,12 +61,6 @@ public class GlobalResourcesLifecycleListener implements
LifecycleListener {
protected Lifecycle component = null;
-/**
- * The configuration information registry for our managed beans.
- */
-protected static final Registry registry = MBeanUtils.createRegistry();
-
-
// -- LifecycleListener Methods
/**
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63365] Not check the keystore configuration
https://bz.apache.org/bugzilla/show_bug.cgi?id=63365 Remy Maucherat changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Remy Maucherat --- You should discuss this in the Tomcat user list. If the keystore is not found, the connector is not available, however your health check is not a Tomcat component. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63350] JSP out.print() does not rethrow IOException
https://bz.apache.org/bugzilla/show_bug.cgi?id=63350 Remy Maucherat changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Remy Maucherat --- Please use the user list to discuss the behavior if you'd like. The Servlet's writer is indeed a PrintWriter, it sets error flags but does not throw IOE exceptions. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
