[Bug 65301] the enableLookups configuration is not fully active
https://bz.apache.org/bugzilla/show_bug.cgi?id=65301 --- Comment #4 from wangmc --- thanks，You're right. when the system is configured with DNS, getLocalName will attempt to search for "hostname" using the native IP. This will also use the DNS service, which will occasionally result in a slow query if the system is not configured with DNS cache. You can get the "hostname" efficiently in the simpler way you mentioned, without the DNS query. now I have circumvented this problem by installing the NSCD service. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Release Managers wanted
Mark, On 5/12/21 18:10, Mark Thomas wrote: All, Assuming 7.0.109 is the last Tomcat 7 release I am the current release manager for 10.0.x, 9.0.x, 8.5.x, migration tool, native and mod_jk. I'd like to share the load and the knowledge a little. The step-by-step release process was documented for Tomcat 7: https://cwiki.apache.org/confluence/display/TOMCAT/ReleaseProcess It needs a few minor updates but that should give you an idea of what is involved. I suggest that the major Tomcat versions are actually easier to release as: - the process is more automated - because the happen on a roughly monthly cycle you don't forget too much of the detail between releases - there is greater flexibility in the build environment (anything that needs a Windows binary needs a very specific environment to avoid unwanted system dependencies) You should be able to build on Linux or Windows (or MacOS assuming cygwin works well enough with NSIS) although anything other than Windows will require a little more setup in the first instance I'd be happy to mentor volunteers through their first couple of releases. Once you get into the swing of things, the process is fairly quick. The only pre-requisite is that you need to be a committer. So, who'd like to volunteer? Long ago I threatened to RM for the 8.5 line and never followed through. I'd love to be able to get things working on MacOS if at all possible. Otherwise, I can build a Linux or Win10 environment in a Virtual Machine for everything. Can you devote some time to working with me to bash-through the initial setup? -chris - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE][RESULT] Release Apache Tomcat 8.5.66
Mark, On 5/12/21 17:56, Mark Thomas wrote: The following votes were cast: Binding: +1: isapir, remm, mgrigorov, markt I also voted +1 No other votes were cast. The vote therefore passes. Yay! Thanks to everyone who contributed to this release. +1 -chris - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Release Managers wanted
All, Assuming 7.0.109 is the last Tomcat 7 release I am the current release manager for 10.0.x, 9.0.x, 8.5.x, migration tool, native and mod_jk. I'd like to share the load and the knowledge a little. The step-by-step release process was documented for Tomcat 7: https://cwiki.apache.org/confluence/display/TOMCAT/ReleaseProcess It needs a few minor updates but that should give you an idea of what is involved. I suggest that the major Tomcat versions are actually easier to release as: - the process is more automated - because the happen on a roughly monthly cycle you don't forget too much of the detail between releases - there is greater flexibility in the build environment (anything that needs a Windows binary needs a very specific environment to avoid unwanted system dependencies) You should be able to build on Linux or Windows (or MacOS assuming cygwin works well enough with NSIS) although anything other than Windows will require a little more setup in the first instance I'd be happy to mentor volunteers through their first couple of releases. Once you get into the swing of things, the process is fairly quick. The only pre-requisite is that you need to be a committer. So, who'd like to volunteer? Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] 01/02: Remove unnecessary code
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 1533b42a103580844a4618fe809a812de2981493
Author: Mark Thomas
AuthorDate: Tue May 11 21:49:07 2021 +0100
Remove unnecessary code
This method is called for a SimpleTag.
pushBodyCountVar is always null for SimpleTag as the code where it is
set in visit(CustomTag) is never called if n.implementsSimpleTag() is
true.
---
java/org/apache/jasper/compiler/Generator.java | 4
webapps/docs/changelog.xml | 8
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/java/org/apache/jasper/compiler/Generator.java
b/java/org/apache/jasper/compiler/Generator.java
index a48494f..fbe1d96 100644
--- a/java/org/apache/jasper/compiler/Generator.java
+++ b/java/org/apache/jasper/compiler/Generator.java
@@ -3281,10 +3281,6 @@ class Generator {
boolean tmpIsFragment = isFragment;
isFragment = true;
String pushBodyCountVarSave = pushBodyCountVar;
-if (pushBodyCountVar != null) {
-// Use a fixed name for push body count, to simplify code gen
-pushBodyCountVar = "_jspx_push_body_count";
-}
visitBody(n);
out = outSave;
parent = tmpParent;
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index dfcabe1..cd2f951 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -104,6 +104,14 @@
issues do not "pop up" wrt. others).
-->
+
+
+
+Review code used to generate Java source from JSPs and tags and remove
+code found to be unnecessary. (markt)
+
+
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] 02/02: Add release date for 8.5.66
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit bc95c9811a16910819651de92fb1863a588a510f Author: Mark Thomas AuthorDate: Wed May 12 22:59:10 2021 +0100 Add release date for 8.5.66 --- webapps/docs/changelog.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index cd2f951..6ac3c3d 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -113,7 +113,7 @@ - + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 8.5.x updated (273770f -> bc95c98)
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 273770f Increment version number of next development release new 1533b42 Remove unnecessary code new bc95c98 Add release date for 8.5.66 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: java/org/apache/jasper/compiler/Generator.java | 4 webapps/docs/changelog.xml | 10 +- 2 files changed, 9 insertions(+), 5 deletions(-) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r47669 - /dev/tomcat/tomcat-8/v8.5.66/ /release/tomcat/tomcat-8/v8.5.66/
Author: markt Date: Wed May 12 21:57:44 2021 New Revision: 47669 Log: Release Apache Tomcat 8.5.66 Added: release/tomcat/tomcat-8/v8.5.66/ - copied from r47668, dev/tomcat/tomcat-8/v8.5.66/ Removed: dev/tomcat/tomcat-8/v8.5.66/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE][RESULT] Release Apache Tomcat 8.5.66
The following votes were cast: Binding: +1: isapir, remm, mgrigorov, markt No other votes were cast. The vote therefore passes. Thanks to everyone who contributed to this release. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: Add release date for 9.0.46
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 6b5baf0 Add release date for 9.0.46 6b5baf0 is described below commit 6b5baf077c01f5cee00eccbb5e035a1febfb3cc6 Author: Mark Thomas AuthorDate: Wed May 12 22:55:31 2021 +0100 Add release date for 9.0.46 --- webapps/docs/changelog.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index dc1bd17..b53420e 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -113,7 +113,7 @@ - + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r47668 - /dev/tomcat/tomcat-9/v9.0.46/ /release/tomcat/tomcat-9/v9.0.46/
Author: markt Date: Wed May 12 21:55:02 2021 New Revision: 47668 Log: Release Apache Tomcat 9.0.46 Added: release/tomcat/tomcat-9/v9.0.46/ - copied from r47667, dev/tomcat/tomcat-9/v9.0.46/ Removed: dev/tomcat/tomcat-9/v9.0.46/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE][RESULT] Release Apache Tomcat 9.0.46
The following votes were cast: Binding: +1: isapir, remm, mgrigorov, markt No other votes were cast. The vote therefore passes. Thanks to everyone who contributed to this release. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r47667 - /dev/tomcat/tomcat-10/v10.0.6/ /release/tomcat/tomcat-10/v10.0.6/
Author: markt Date: Wed May 12 21:35:52 2021 New Revision: 47667 Log: Release Apache Tomcat 10.0.6 Added: release/tomcat/tomcat-10/v10.0.6/ - copied from r47666, dev/tomcat/tomcat-10/v10.0.6/ Removed: dev/tomcat/tomcat-10/v10.0.6/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE][RESULT} Release Apache Tomcat 10.0.6
The following votes were cast: Binding: +1: isapir, remm, mgrigorov, jfclere, markt Non-binding: +1: rmannibucau No other votes were cast. The vote therefore passes. Thank you to everyone who contributed to this release. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.66
On 09/05/2021 00:12, Mark Thomas wrote: The proposed 8.5.66 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 8.5.66 Test pass for NIO, NIO2 and APR/Native (with Tomcat Native 1.2.28) on Linux, Windows and MacOS. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.46
On 08/05/2021 19:14, Mark Thomas wrote: The proposed 9.0.46 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 9.0.46 Test pass for NIO, NIO2 and APR/Native (with Tomcat Native 1.2.28) on Linux, Windows and MacOS. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 10.0.6
On 08/05/2021 17:18, Mark Thomas wrote: The proposed 10.0.6 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 10.0.6 (stable) Test pass for NIO, NIO2 and APR/Native (with Tomcat Native 1.2.28) on Linux, Windows and MacOS. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: A thank you to the devs
Neale, Thanks for the kind words. It is great to hear that Tomcat has served you, and continues to serve you, so well. Kind regards, Mark On 12/05/2021 16:13, Neale Rudd wrote: To the great Tomcat Devs, tl;dr - This isn't a question, just a praise email. Firstly, I want to say that I really appreciate all the hard work you have all put in to this project over the years. We are a small company but have been hosting Tomcat since version 3 (we started on ServletExec in 1997), we were the first Australian Java Host and now we're the only one exclusively hosting Java in Australia.ￂﾠ Tomcat is lean, fast, secure, continually updated and friendly to use.ￂﾠ It's kept our customers very happy ever since we started providing it. Our wiki on web.xml is listed on GAE as the main reference for web.xml, above the offical Servlet Spec at https://cloud.google.com/appengine/docs/standard/java/config/webxml - it could do with an update ;-)ￂﾠￂﾠ You can find the GAE web.xml doc by searching for "google web.xml", it's always the first link.ￂﾠ If anyone has any new element docs to add I'm happy to add your name as a contributor in the comments. As for Tomcat itself, I've only suggested a couple of changes over the years: - catalina.policy change for when catalina.home and catalina.base are different, which was accepted and is in catalina.policy from 7 to 10 - one regarding an error in the DIGEST authentication which was also accepted and subsequently improved upon by Mark, in Tomcat 7. I hope to contribute more in the future but I rarely find any problems.ￂﾠ I'm also in contact with a dev from the TomEE team who has been great too and hosts his blog with us. Today we've been published in an article and I've tweeted about it and made special thanks to Tomcat, TomEE, Ubuntu and MySQL for all for your great work. https://twitter.com/metawerx/status/1392484462382903298 Anyway, I just wanted to thank and commend you all on your great, tireless and often under-appreciated work on Tomcat, the best container ever and any other open source projects or libraries you have been involved in.ￂﾠ Without your hard work, the world would be stuck in the past. Also, congratulations on the new Tomcat 10 going into production! Best Regards, Neale Rudd Managing Director metawerx.net - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 65302] Add support for setting com.sun.jndi.ldap.tls.cbtype
https://bz.apache.org/bugzilla/show_bug.cgi?id=65302 --- Comment #2 from Christopher Schultz --- Would it hurt anything to unconditionally add com.sun.jndi.ldap.tls.cbtype=tls-server-end-point to the properties used to initialize to the InitialContext? Or does this really need to be something controlled by configuration? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 65302] Add support for setting com.sun.jndi.ldap.tls.cbtype
https://bz.apache.org/bugzilla/show_bug.cgi?id=65302 --- Comment #1 from Michael Osipov --- Why? I did several reviews of the ticket when it was discussed with security-dev@. The only SASL mech supporting this is GSSAPI and you can request GSS-API to completely encrypt your traffic with Kerberos (auth-conf), no TLS necessary. SSPI offers other mechs besides GSSAPI to use channel binding (Digest MD5 which is dead). This is a case (auth-conf) even MS considers to be secure and no need to enforce TLS channel binding. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 65302] New: Add support for setting com.sun.jndi.ldap.tls.cbtype
https://bz.apache.org/bugzilla/show_bug.cgi?id=65302 Bug ID: 65302 Summary: Add support for setting com.sun.jndi.ldap.tls.cbtype Product: Tomcat 9 Version: 9.0.39 Hardware: PC OS: Linux Status: NEW Severity: enhancement Priority: P2 Component: Catalina Assignee: dev@tomcat.apache.org Reporter: mmill...@redhat.com Target Milestone: - Microsoft advises using LDAP channel binding: https://msrc.microsoft.com/update-guide/en-us/vulnerability/ADV190023 LDAP channel binding was implemented in OpenJDK 16: https://bugs.openjdk.java.net/browse/JDK-8247311 And was backported to OpenJDK 11: https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2021-April/005860.html The tomcat JNDIRealm.getDirectoryContextEnvironment() method needs to be updated to provide the capability to set 'com.sun.jndi.ldap.tls.cbtype' to 'tls-server-end-point' for channel-binding to work[1]. References: [1]https://github.com/apache/tomcat/blob/master/java/org/apache/catalina/realm/JNDIRealm.java#L2603 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Disabling Some Test Cases by Pattern
Martin, On Tue, May 11, 2021 at 12:18 AM Martin Grigorov wrote: > Hi Igal, > > On Mon, May 10, 2021 at 4:28 AM Igal Sapir wrote: > > > I am trying to disable some test cases that constantly fail on my > machine. > > I have added the following to build.properties: > > > > > > > test.exclude=org.apache.catalina.tribes.group.Test**,org.apache.catalina.tribes.group.interceptors.Test** > > > > But I still get the following failures: > > > >[concat] Testsuites with failed tests: > >[concat] > > > > > TEST-org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO2.txt > >[concat] > > > > > TEST-org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.NIO2.txt > >[concat] > > > > > TEST-org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO2.txt > >[concat] > > > > > TEST-org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.NIO2.txt > > > > I expect the pattern > [org.apache.catalina.tribes.group.interceptors.Test**] > > to exclude the last 3 for example, but that doesn't happen. > > > > What am I doing wrong? > > > > Looking at > > https://github.com/apache/tomcat/blob/9747a3a6334369deb9b5bef1b17b1fe0ce774cdf/build.xml#L2024-L2039 > I think you should use '/' instead of '.', > i.e. > > test.exclude=org/apache/catalina/tribes/group/Test*,org/apache/catalina/tribes/group/interceptors/Test* > Brilliant! That worked. Thank you, Igal > > > > > > Thanks, > > > > Igal > > >
Re: [VOTE] Release Apache Tomcat 8.5.66
Mark, Thanks for RMing On 5/8/21 19:12, Mark Thomas wrote: The proposed Apache Tomcat 8.5.66 release is now available for voting. The notable changes compared to the 8.5.65 release are: - Ensure the correct escaping of attribute values and search filters in the JNDIRealm. - HandlesTypes should include classes that use the specified annotation types on fields or methods. - Refactor the creation of WebSocket end point, decoder and encoder instances to be more IoC friendly. Instances are now created via the InstanceManager where possible. Along with lots of other bug fixes and improvements. For full details, see the changelog: https://ci.apache.org/projects/tomcat/tomcat85/docs/changelog.html It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.66/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1311/ The tag is: https://github.com/apache/tomcat/tree/8.5.66 12afa2cd11ffa9522cd98acc228ecb1bad6b8006 The proposed 8.5.66 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 8.5.66 Works for a vanilla servlet-based application in development environment. Details: * Environment * Java (build): openjdk version "1.8.0_292" OpenJDK Runtime Environment (build 1.8.0_292-8u292-b10-0+deb9u1-b10) OpenJDK 64-Bit Server VM (build 25.292-b10, mixed mode) * Java (test): openjdk version "1.8.0_292" OpenJDK Runtime Environment (build 1.8.0_292-8u292-b10-0+deb9u1-b10) OpenJDK 64-Bit Server VM (build 25.292-b10, mixed mode) * OS: Linux 4.9.0-9-amd64 x86_64 * cc: cc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516 * make: GNU Make 4.1 * OpenSSL: OpenSSL 1.1.1 11 Sep 2018 * APR: 1.5.2 * * Valid SHA-512 signature for apache-tomcat-8.5.66.zip * Valid GPG signature for apache-tomcat-8.5.66.zip * Valid SHA-512 signature for apache-tomcat-8.5.66.tar.gz * Valid GPG signature for apache-tomcat-8.5.66.tar.gz * Valid SHA-512 signature for apache-tomcat-8.5.66.exe * Valid GPG signature for apache-tomcat-8.5.66.exe * Valid SHA512 signature for apache-tomcat-8.5.66-src.zip * Valid GPG signature for apache-tomcat-8.5.66-src.zip * Valid SHA512 signature for apache-tomcat-8.5.66-src.tar.gz * Valid GPG signature for apache-tomcat-8.5.66-src.tar.gz * * Binary Zip and tarball: Same * Source Zip and tarball: Same * * Building dependencies returned: 0 * tcnative builds cleanly * Tomcat builds cleanly * Junit Tests: FAILED * * Tests that failed: * org.apache.tomcat.util.net.openssl.ciphers.TestCipher.APR.txt * org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO.txt * org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO2.txt * org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser.APR.txt * org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser.NIO.txt * org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser.NIO2.txt -chris - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 65301] the enableLookups configuration is not fully active
https://bz.apache.org/bugzilla/show_bug.cgi?id=65301 --- Comment #3 from Remy Maucherat --- As it is right now, the enableLookups flags documentation is accurate: "Set to true if you want calls to request.getRemoteHost() to perform DNS lookups in order to return the actual host name of the remote client. Set to false to skip the DNS lookup and return the IP address in String form instead (thereby improving performance). By default, DNS lookups are disabled." As a result, I think the current behavior of the flag should not be changed. If the local name lookup is really a problem, then a new flag can be introduced. Reading the RemoteIpValve code, saving and restoring the localName is not needed if isChangeLocalName() is false (the default value). Since this has a cost, it's an easy enhancement that I'll do. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
A thank you to the devs
To the great Tomcat Devs, tl;dr - This isn't a question, just a praise email. Firstly, I want to say that I really appreciate all the hard work you have all put in to this project over the years. We are a small company but have been hosting Tomcat since version 3 (we started on ServletExec in 1997), we were the first Australian Java Host and now we're the only one exclusively hosting Java in Australia.ￂﾠ Tomcat is lean, fast, secure, continually updated and friendly to use.ￂﾠ It's kept our customers very happy ever since we started providing it. Our wiki on web.xml is listed on GAE as the main reference for web.xml, above the offical Servlet Spec at https://cloud.google.com/appengine/docs/standard/java/config/webxml - it could do with an update ;-)ￂﾠￂﾠ You can find the GAE web.xml doc by searching for "google web.xml", it's always the first link.ￂﾠ If anyone has any new element docs to add I'm happy to add your name as a contributor in the comments. As for Tomcat itself, I've only suggested a couple of changes over the years: - catalina.policy change for when catalina.home and catalina.base are different, which was accepted and is in catalina.policy from 7 to 10 - one regarding an error in the DIGEST authentication which was also accepted and subsequently improved upon by Mark, in Tomcat 7. I hope to contribute more in the future but I rarely find any problems.ￂﾠ I'm also in contact with a dev from the TomEE team who has been great too and hosts his blog with us. Today we've been published in an article and I've tweeted about it and made special thanks to Tomcat, TomEE, Ubuntu and MySQL for all for your great work. https://twitter.com/metawerx/status/1392484462382903298 Anyway, I just wanted to thank and commend you all on your great, tireless and often under-appreciated work on Tomcat, the best container ever and any other open source projects or libraries you have been involved in.ￂﾠ Without your hard work, the world would be stuck in the past. Also, congratulations on the new Tomcat 10 going into production! Best Regards, Neale Rudd Managing Director metawerx.net - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: Remove unnecessary code
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new e2624ac Remove unnecessary code
e2624ac is described below
commit e2624ac20bee1f1549109922ad7bc8d4ea80c6ed
Author: Mark Thomas
AuthorDate: Tue May 11 21:49:07 2021 +0100
Remove unnecessary code
This method is called for a SimpleTag.
pushBodyCountVar is always null for SimpleTag as the code where it is
set in visit(CustomTag) is never called if n.implementsSimpleTag() is
true.
---
java/org/apache/jasper/compiler/Generator.java | 4
webapps/docs/changelog.xml | 8
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/java/org/apache/jasper/compiler/Generator.java
b/java/org/apache/jasper/compiler/Generator.java
index b6e0cd5..ba36ffe 100644
--- a/java/org/apache/jasper/compiler/Generator.java
+++ b/java/org/apache/jasper/compiler/Generator.java
@@ -3313,10 +3313,6 @@ class Generator {
boolean tmpIsFragment = isFragment;
isFragment = true;
String pushBodyCountVarSave = pushBodyCountVar;
-if (pushBodyCountVar != null) {
-// Use a fixed name for push body count, to simplify code gen
-pushBodyCountVar = "_jspx_push_body_count";
-}
visitBody(n);
out = outSave;
parent = tmpParent;
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 3a6a78c..dc1bd17 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -104,6 +104,14 @@
issues do not "pop up" wrt. others).
-->
+
+
+
+Review code used to generate Java source from JSPs and tags and remove
+code found to be unnecessary. (markt)
+
+
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch master updated: Remove unnecessary code
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new 9f2d784 Remove unnecessary code
9f2d784 is described below
commit 9f2d78449f409ecffade937dfc7441d90ac914b3
Author: Mark Thomas
AuthorDate: Tue May 11 21:49:07 2021 +0100
Remove unnecessary code
This method is called for a SimpleTag.
pushBodyCountVar is always null for SimpleTag as the code where it is
set in visit(CustomTag) is never called if n.implementsSimpleTag() is
true.
---
java/org/apache/jasper/compiler/Generator.java | 4
webapps/docs/changelog.xml | 8
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/java/org/apache/jasper/compiler/Generator.java
b/java/org/apache/jasper/compiler/Generator.java
index 25c67ac..b34c6b7 100644
--- a/java/org/apache/jasper/compiler/Generator.java
+++ b/java/org/apache/jasper/compiler/Generator.java
@@ -3300,10 +3300,6 @@ class Generator {
boolean tmpIsFragment = isFragment;
isFragment = true;
String pushBodyCountVarSave = pushBodyCountVar;
-if (pushBodyCountVar != null) {
-// Use a fixed name for push body count, to simplify code gen
-pushBodyCountVar = "_jspx_push_body_count";
-}
visitBody(n);
out = outSave;
parent = tmpParent;
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 5bd018f..5babeb4 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -104,6 +104,14 @@
issues do not "pop up" wrt. others).
-->
+
+
+
+Review code used to generate Java source from JSPs and tags and remove
+code found to be unnecessary. (markt)
+
+
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 10.0.6
On 08/05/2021 18:18, Mark Thomas wrote: [X] Stable - go ahead and release as 10.0.6 (stable) Tested on fedora34. -- Cheers Jean-Frederic - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 65301] the enableLookups configuration is not fully active
https://bz.apache.org/bugzilla/show_bug.cgi?id=65301 --- Comment #2 from wangmc --- on my service dns is a must. so I disabled Lookups(default is false) in "server.xml".but in my code used RemoteIpValve class, the methord getLocalName does not on the controll of the "enableLookups=false",this methord alawys do dnslockup.This is not what I expected and It's also an imperfect judgment. so one way I must deprecated to use RemoteIpValve ,one way disable DNS at the system level and edit hosts to suport needed dns. I expect the configuration(enableLookups) to be consistent,It's more rigorous. thanks -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Tagging May releases towards the end of this week
On Tue, May 4, 2021 at 12:55 PM Mark Thomas wrote: > On 04/05/2021 08:43, Rémy Maucherat wrote: > > On Tue, May 4, 2021 at 9:36 AM Mark Thomas wrote: > > > >> On 04/05/2021 08:29, Rémy Maucherat wrote: > >>> On Tue, May 4, 2021 at 9:26 AM Mark Thomas wrote: > >>> > Hi all, > > It is the start of a new month so time to tag and release. I have a > few > things I'd like to get fixed first: > > 1. BZ 65272 (allow CR as HTTP line separator). > I'm planning on applying PR 417 to address this before I tag > unless > there are objections. > > 2. BZ 65262 (WebSocket & InstanceManager) > I have a patch for this about 80% complete. I intend to complete > >> and > apply it before tagging. > > Given these (and no more issues raised this week) I'm currently > expecting the tags to be towards the end of the week. > > >>> > >>> Can we release a stable Jakarta migration tool before that release ? > >> There > >>> are a couple changes that could be picked up and since it's a > >> subcomponent > >>> it would need to be declared stable anyway. > >> > >> Sure. 0.3.0 or 1.0.0 ? > >> > > > > I think it should move to stable 1.0, unless there's some mandatory > feature > > that got forgotten. > > I can't think of anything. Folks are starting to use it (and Tomcat 10) > and the biggest problem seems to be that users aren't aware of the Java > EE -> Jakarta EE changes. > > Is there merit in attempting to detect an application trying to load a > Java EE 9 class (maybe limit it to Servlet, JSP, EL & WebSocket) and > fail the deployment (assuming we catch the problem early enough) with a > clear error message? Maybe pointing to a (maybe expanded) section in the > migration guide? > That could be a good idea but it goes back to the deployment problem: ideally legacy EE webapps would be detected and migrated automatically (unless configured otherwise). But there is a problem since it's hard to do. Even if the intent is to limit that to classloading, it's only a bit easier. Most webapps do load stuff on startup so that's a great spot to detect this kind of problem, but for the others the error will be lost in the shuffle. Rémy > > Mark > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
[Bug 65301] the enableLookups configuration is not fully active
https://bz.apache.org/bugzilla/show_bug.cgi?id=65301 --- Comment #1 from Remy Maucherat --- Created attachment 37858 --> https://bz.apache.org/bugzilla/attachment.cgi?id=37858=edit Patch This can be fixed easily, *but* there's a problem. Most often (= always) DNS lookup must be disabled, so then the actual local name is not available anymore. The actual local name could be used a lot more in user code than the remote host name (which if needed is probably coded with DNS resolution) and as a result it could break existing apps. I don't understand why your local name lookup would be so slow. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 65301] New: the enableLookups configuration is not fully active
https://bz.apache.org/bugzilla/show_bug.cgi?id=65301 Bug ID: 65301 Summary: the enableLookups configuration is not fully active Product: Tomcat 9 Version: 9.0.41 Hardware: PC OS: Linux Status: NEW Severity: normal Priority: P2 Component: Catalina Assignee: dev@tomcat.apache.org Reporter: wan...@bonree.com Target Milestone: - Created attachment 37857 --> https://bz.apache.org/bugzilla/attachment.cgi?id=37857=edit key line when I use org.apache.catalina.valves.RemoteIpValve to get real protocol from "X-Forwarded-Proto", sometimes it take too many times to search local machine hostname. the thread dump as follows : "http-nio-8080-exec-1" #85 daemon prio=5 os_prio=0 tid=0x7f0ef8fdd000 nid=0x79 runnable [0x7f0e8d1d4000] java.lang.Thread.State: RUNNABLE at java.net.Inet4AddressImpl.getHostByAddr(Native Method) at java.net.InetAddress$2.getHostByAddr(InetAddress.java:932) at java.net.InetAddress.getHostFromNameService(InetAddress.java:617) at java.net.InetAddress.getHostName(InetAddress.java:559) at java.net.InetAddress.getHostName(InetAddress.java:531) at org.apache.tomcat.util.net.NioEndpoint$NioSocketWrapper.populateLocalName(NioEndpoint.java:1354) at org.apache.tomcat.util.net.SocketWrapperBase.getLocalName(SocketWrapperBase.java:275) at org.apache.coyote.AbstractProcessor.action(AbstractProcessor.java:472) at org.apache.coyote.Request.action(Request.java:432) at org.apache.catalina.connector.Request.getLocalName(Request.java:1331) at org.apache.catalina.valves.RemoteIpValve.invoke(RemoteIpValve.java:612) when I see org.apache.catalina.valves.RemoteIpValve in tomcat , getLocalName methord must search ip from machine dnsserver,why this does not check whether it's(enableLookups) on or not ,like line num 663 in this class. the methord getLoaclName alawys call dns to search local ip. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
