Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.8

[Rémy Maucherat]

On Fri, Feb 2, 2024 at 4:53 PM Mark Thomas  wrote:
>
> The proposed Apache Tomcat migration tool for Jakarta EE 1.0.8 is now
> available for voting.
>
> The significant changes since 1.0.7 are:
>
> - Recognize .ear files as archives
>
> - Include .jspf and .tagf files in the conversion process
>
> - Update dependencies
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.8/
>
> The Maven staging repository is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1479/
>
> The tag is:
> https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.8
> 7c1559661980d93e84b947682c67959165abbc4a
>
> The proposed 1.0.8 release is:
>
> [ ] -1: Broken. Do not release because...
> [X] +1: Acceptable. Go ahead and release.

Rémy

> Thanks,
>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.8

[Mark Thomas]

On 02/02/2024 18:42, Mark Thomas wrote:

On 02/02/2024 18:19, Christopher Schultz wrote:

Mark,

On 2/2/24 10:53, Mark Thomas wrote:

The proposed Apache Tomcat migration tool for Jakarta EE 1.0.8 is now
available for voting.

The significant changes since 1.0.7 are:

- Recognize .ear files as archives

- Include .jspf and .tagf files in the conversion process

- Update dependencies

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.8/

The Maven staging repository is:
https://repository.apache.org/content/repositories/orgapachetomcat-1479/

The tag is:
https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.8
7c1559661980d93e84b947682c67959165abbc4a

The proposed 1.0.8 release is:

[ ] -1: Broken. Do not release because...
[ ] +1: Acceptable. Go ahead and release.


+1 for stable release

Builds from source and passes the "verify" target (aka unit tests).

Running the "shaded" version of the JAR file worked on the first try 
with an application written using Java EE APIs and associated (legacy) 
libraries. A quick smoke-test in Tomcat 10.1.18 using the migrated WAR 
file indicates that everything is working as expected.


Details:

MacOS X Ventura x86-64
Java 21
Maven 3.8.1

Running "mvn package" results in lots of stack traces being dumped to 
the console, mostly java.lang.instrument.IllegalClassFormatException 
coming from JaCoCo and some failed unit tests.


I get warnings about weak DSA signatures for the JAR signatures. The 
"signed" JAR files also say they are not signed when I check with 
"jarsigned -verify [jar]". Is that expected if I perform the build 
locally?


I don't think I've tried the build with Java 21. I'm using Java 17 for 
that at the moment. I'll try 21 and see what happens.


I see warnings about self-signed certificates for JAR signing.

I also see the JAR is reported as unsigned. That is expected. The 
migration process removes the signatures.


The Jacoco plugin needed an update. I missed that in my last round of 
updates. I'll do that now.


Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.8

[Mark Thomas]

On 02/02/2024 18:19, Christopher Schultz wrote:

Mark,

On 2/2/24 10:53, Mark Thomas wrote:

The proposed Apache Tomcat migration tool for Jakarta EE 1.0.8 is now
available for voting.

The significant changes since 1.0.7 are:

- Recognize .ear files as archives

- Include .jspf and .tagf files in the conversion process

- Update dependencies

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.8/

The Maven staging repository is:
https://repository.apache.org/content/repositories/orgapachetomcat-1479/

The tag is:
https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.8
7c1559661980d93e84b947682c67959165abbc4a

The proposed 1.0.8 release is:

[ ] -1: Broken. Do not release because...
[ ] +1: Acceptable. Go ahead and release.


+1 for stable release

Builds from source and passes the "verify" target (aka unit tests).

Running the "shaded" version of the JAR file worked on the first try 
with an application written using Java EE APIs and associated (legacy) 
libraries. A quick smoke-test in Tomcat 10.1.18 using the migrated WAR 
file indicates that everything is working as expected.


Details:

MacOS X Ventura x86-64
Java 21
Maven 3.8.1

Running "mvn package" results in lots of stack traces being dumped to 
the console, mostly java.lang.instrument.IllegalClassFormatException 
coming from JaCoCo and some failed unit tests.


I get warnings about weak DSA signatures for the JAR signatures. The 
"signed" JAR files also say they are not signed when I check with 
"jarsigned -verify [jar]". Is that expected if I perform the build locally?


I don't think I've tried the build with Java 21. I'm using Java 17 for 
that at the moment. I'll try 21 and see what happens.


Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.8

[Christopher Schultz]

Mark,

On 2/2/24 10:53, Mark Thomas wrote:

The proposed Apache Tomcat migration tool for Jakarta EE 1.0.8 is now
available for voting.

The significant changes since 1.0.7 are:

- Recognize .ear files as archives

- Include .jspf and .tagf files in the conversion process

- Update dependencies

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.8/

The Maven staging repository is:
https://repository.apache.org/content/repositories/orgapachetomcat-1479/

The tag is:
https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.8
7c1559661980d93e84b947682c67959165abbc4a

The proposed 1.0.8 release is:

[ ] -1: Broken. Do not release because...
[ ] +1: Acceptable. Go ahead and release.


+1 for stable release

Builds from source and passes the "verify" target (aka unit tests).

Running the "shaded" version of the JAR file worked on the first try 
with an application written using Java EE APIs and associated (legacy) 
libraries. A quick smoke-test in Tomcat 10.1.18 using the migrated WAR 
file indicates that everything is working as expected.


Details:

MacOS X Ventura x86-64
Java 21
Maven 3.8.1

Running "mvn package" results in lots of stack traces being dumped to 
the console, mostly java.lang.instrument.IllegalClassFormatException 
coming from JaCoCo and some failed unit tests.


I get warnings about weak DSA signatures for the JAR signatures. The 
"signed" JAR files also say they are not signed when I check with 
"jarsigned -verify [jar]". Is that expected if I perform the build locally?


-chris

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.8

[Mark Thomas]

On 02/02/2024 15:53, Mark Thomas wrote:


The proposed 1.0.8 release is:

[ ] -1: Broken. Do not release because...
[X] +1: Acceptable. Go ahead and release.


The tests pass during the build.

When used with Tomcat 11.0.x, the 1.0.8 shaded JAR successfully converts 
the 9.0.x examples web application. The WebSocket snake and drawing 
examples work in the migrated web application.


Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.7

[Rémy Maucherat]

On Wed, Apr 26, 2023 at 6:19 PM Mark Thomas  wrote:
>
> The proposed Apache Tomcat migration tool for Jakarta EE 1.0.7 is now
> available for voting.
>
> The significant changes since 1.0.6 are:
>
> - Provide a workaround for a known JDK bug (JDK-8303866) that prevents
>some migrated JARs from being read
>
> - Add new matchExcludesAgainstPathName configuration option
>
> - Include file names in the renaming process
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.7/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1431/
>
> The tag is:
> https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.7
> 0f74b6a7541c1f7ff26b9588a9ede92f316a7c46
>
> The proposed 1.0.7 release is:
>
> [ ] -1: Broken. Do not release because...
> [X] +1: Acceptable. Go ahead and release.

Rémy

> Thanks,
>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.7

[Felix Schumacher]

Am 26.04.23 um 18:19 schrieb Mark Thomas:

The proposed Apache Tomcat migration tool for Jakarta EE 1.0.7 is now
available for voting.

The significant changes since 1.0.6 are:

- Provide a workaround for a known JDK bug (JDK-8303866) that prevents
  some migrated JARs from being read

- Add new matchExcludesAgainstPathName configuration option

- Include file names in the renaming process

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.7/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1431/

The tag is:
https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.7
0f74b6a7541c1f7ff26b9588a9ede92f316a7c46

The proposed 1.0.7 release is:

[ ] -1: Broken. Do not release because...
[x] +1: Acceptable. Go ahead and release.


Fellix



Thanks,

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



OpenPGP_0xEA6C3728EA91C4AF.asc
Description: OpenPGP public key


OpenPGP_signature
Description: OpenPGP digital signature

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.7

[Mark Thomas]

On 26/04/2023 17:19, Mark Thomas wrote:

The proposed Apache Tomcat migration tool for Jakarta EE 1.0.7 is now
available for voting.

The significant changes since 1.0.6 are:

- Provide a workaround for a known JDK bug (JDK-8303866) that prevents
   some migrated JARs from being read

- Add new matchExcludesAgainstPathName configuration option

- Include file names in the renaming process

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.7/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1431/

The tag is:
https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.7
0f74b6a7541c1f7ff26b9588a9ede92f316a7c46

The proposed 1.0.7 release is:

[ ] -1: Broken. Do not release because...
[X] +1: Acceptable. Go ahead and release.


Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.7

[Han Li]

> On Apr 27, 2023, at 00:19, Mark Thomas  wrote:
> 
> The proposed Apache Tomcat migration tool for Jakarta EE 1.0.7 is now
> available for voting.
> 
> The significant changes since 1.0.6 are:
> 
> - Provide a workaround for a known JDK bug (JDK-8303866) that prevents
>  some migrated JARs from being read
> 
> - Add new matchExcludesAgainstPathName configuration option
> 
> - Include file names in the renaming process
> 
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.7/
> 
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1431/
> 
> The tag is:
> https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.7
> 0f74b6a7541c1f7ff26b9588a9ede92f316a7c46
> 
> The proposed 1.0.7 release is:
> 
> [ ] -1: Broken. Do not release because…
> [X ] +1: Acceptable. Go ahead and release.

Han

> 
> Thanks,
> 
> Mark
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.7

[Emmanuel Bourg]

Le 26/04/2023 à 18:19, Mark Thomas a écrit :


The proposed 1.0.7 release is:

[ ] -1: Broken. Do not release because...
[X] +1: Acceptable. Go ahead and release.




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.7

[Dimitris Soumis]

Tests run and build reproducible.

On Wed, Apr 26, 2023 at 7:26 PM Mark Thomas  wrote:

> The proposed Apache Tomcat migration tool for Jakarta EE 1.0.7 is now
> available for voting.
>
> The significant changes since 1.0.6 are:
>
> - Provide a workaround for a known JDK bug (JDK-8303866) that prevents
>some migrated JARs from being read
>
> - Add new matchExcludesAgainstPathName configuration option
>
> - Include file names in the renaming process
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.7/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1431/
>
> The tag is:
> https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.7
> 0f74b6a7541c1f7ff26b9588a9ede92f316a7c46
>
> The proposed 1.0.7 release is:
>
> [ ] -1: Broken. Do not release because...
> [ X] +1: Acceptable. Go ahead and release.
>
> Thanks,
>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.6

[Mark Thomas]

On 02/12/2022 10:24, Mark Thomas wrote:

The proposed 1.0.6 release is:

[ ] -1: Broken. Do not release because...
[X] +1: Acceptable. Go ahead and release.


Tomcat 9 examples work on Tomcat 11.0.x when converted at deployment 
using the shaded JAR.


Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.6

[Mark Thomas]

On 04/12/2022 10:05, Felix Schumacher wrote:


Am 02.12.22 um 11:24 schrieb Mark Thomas:

The proposed Apache Tomcat migration tool for Jakarta EE 1.0.6 is now
available for voting.

The significant changes since 1.0.5 are:

- Correct regression in handling of javax.annotation package introduced
  in 1.0.5. PR provided by Danny Thomas.

- Allow parallel use of ClassConverter. PR provided by Danny Thomas.

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.6/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1411/

The tag is:
https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.6
3339fc418974bd5ce3432ea9503abda52d96a435

The proposed 1.0.6 release is:

[ ] -1: Broken. Do not release because...
[x] +1: Acceptable. Go ahead and release.


Unit tests run successfully with Java 11

(On Java 8 `mvn verify` fails, which is probably expected, but should 
not we state this in the pom.xml by setting the source/target to Java 11 
instead of 8?)


That isn't expected. The tool targets Java 8.

Try:
mvn clean verify

Mark




Felix



Thanks,

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.6

[Felix Schumacher]

Am 02.12.22 um 11:24 schrieb Mark Thomas:

The proposed Apache Tomcat migration tool for Jakarta EE 1.0.6 is now
available for voting.

The significant changes since 1.0.5 are:

- Correct regression in handling of javax.annotation package introduced
  in 1.0.5. PR provided by Danny Thomas.

- Allow parallel use of ClassConverter. PR provided by Danny Thomas.

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.6/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1411/

The tag is:
https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.6
3339fc418974bd5ce3432ea9503abda52d96a435

The proposed 1.0.6 release is:

[ ] -1: Broken. Do not release because...
[x] +1: Acceptable. Go ahead and release.


Unit tests run successfully with Java 11

(On Java 8 `mvn verify` fails, which is probably expected, but should 
not we state this in the pom.xml by setting the source/target to Java 11 
instead of 8?)


Felix



Thanks,

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



OpenPGP_0xEA6C3728EA91C4AF.asc
Description: OpenPGP public key


OpenPGP_signature
Description: OpenPGP digital signature

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.6

[Han Li]

> On Dec 2, 2022, at 18:24, Mark Thomas  wrote:
> 
> The proposed Apache Tomcat migration tool for Jakarta EE 1.0.6 is now
> available for voting.
> 
> The significant changes since 1.0.5 are:
> 
> - Correct regression in handling of javax.annotation package introduced
>  in 1.0.5. PR provided by Danny Thomas.
> 
> - Allow parallel use of ClassConverter. PR provided by Danny Thomas.
> 
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.6/
> 
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1411/
> 
> The tag is:
> https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.6
> 3339fc418974bd5ce3432ea9503abda52d96a435
> 
> The proposed 1.0.6 release is:
> 
> [ ] -1: Broken. Do not release because…
> [X ] +1: Acceptable. Go ahead and release.

Han
> 
> Thanks,
> 
> Mark
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.6

[Rémy Maucherat]

On Fri, Dec 2, 2022 at 11:24 AM Mark Thomas  wrote:
>
> The proposed Apache Tomcat migration tool for Jakarta EE 1.0.6 is now
> available for voting.
>
> The significant changes since 1.0.5 are:
>
> - Correct regression in handling of javax.annotation package introduced
>in 1.0.5. PR provided by Danny Thomas.
>
> - Allow parallel use of ClassConverter. PR provided by Danny Thomas.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.6/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1411/
>
> The tag is:
> https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.6
> 3339fc418974bd5ce3432ea9503abda52d96a435
>
> The proposed 1.0.6 release is:
>
> [ ] -1: Broken. Do not release because...
> [X] +1: Acceptable. Go ahead and release.

Tested with examples webapp from Tomcat 9.

Rémy

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.5

[Mark Thomas]

The following votes were cast:

Binding:
+1: remm, markt, jfclere

Non-binding:
+1: lihan

No other votes were cast.

The vote therefore passes.

Thanks to everyone who contributed to this release.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.5

[jean-frederic clere]

On 11/2/22 13:43, Mark Thomas wrote:

[X] +1: Acceptable. Go ahead and release.


Tested on fedora using 9.0.67 examples on 10.1.0 tomcat.

--
Cheers

Jean-Frederic


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.5

[Mark Thomas]

Ping.

We need one more PMC vote for this release.

Mark


On 02/11/2022 12:43, Mark Thomas wrote:

The proposed Apache Tomcat migration tool for Jakarta EE 1.0.5 is now
available for voting.

The significant changes since 1.0.4 are:

- #37 narrow scope of javax.annotation conversion to Java EE. PR by
   Danny Thomas
- #36 Improve manifest handling and conversion performance. PR by Danny
   Thomas.

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.5/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1404/

The tag is:
https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.5
d87e1ec7e67c8d61340111b796e3bb8179a6f0ba

The proposed 1.0.5 release is:

[ ] -1: Broken. Do not release because...
[ ] +1: Acceptable. Go ahead and release.

Thanks,

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.5

[Mark Thomas]

On 02/11/2022 12:43, Mark Thomas wrote:

The proposed 1.0.5 release is:

[ ] -1: Broken. Do not release because...
[X] +1: Acceptable. Go ahead and release.


Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.5

[Rémy Maucherat]

On Wed, Nov 2, 2022 at 1:43 PM Mark Thomas  wrote:
>
> The proposed Apache Tomcat migration tool for Jakarta EE 1.0.5 is now
> available for voting.
>
> The significant changes since 1.0.4 are:
>
> - #37 narrow scope of javax.annotation conversion to Java EE. PR by
>Danny Thomas
> - #36 Improve manifest handling and conversion performance. PR by Danny
>Thomas.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.5/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1404/
>
> The tag is:
> https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.5
> d87e1ec7e67c8d61340111b796e3bb8179a6f0ba
>
> The proposed 1.0.5 release is:
>
> [ ] -1: Broken. Do not release because...
> [X] +1: Acceptable. Go ahead and release.

Rémy

> Thanks,
>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.5

[Han Li]

> 2022年11月2日 20:43，Mark Thomas  写道：
> 
> The proposed Apache Tomcat migration tool for Jakarta EE 1.0.5 is now
> available for voting.
> 
> The significant changes since 1.0.4 are:
> 
> - #37 narrow scope of javax.annotation conversion to Java EE. PR by
>  Danny Thomas
> - #36 Improve manifest handling and conversion performance. PR by Danny
>  Thomas.
> 
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.5/
> 
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1404/
> 
> The tag is:
> https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.5
> d87e1ec7e67c8d61340111b796e3bb8179a6f0ba
> 
> The proposed 1.0.5 release is:
> 
> [ ] -1: Broken. Do not release because...
> [ X] +1: Acceptable. Go ahead and release.

Test pass with old j2ee sample on tomcat 10.1.x.

Han

> 
> Thanks,
> 
> Mark
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.4

[Mark Thomas]

On 20/09/2022 11:39, Felix Schumacher wrote:
Well, my second mail included a +1, but I will re-send a new +1 to make 
it more clear.


Thanks. I see that now but it wasn't clear when I first looked.

Mark



Felix

Am 19.09.22 um 15:07 schrieb Mark Thomas:

Ping.

We need one more PMC vote for this release.

While Felix did indicate support for the release, there wasn't an 
explicit +1 and I'm opting to err on the side of caution.


Mark


On 15/09/2022 10:06, Mark Thomas wrote:

The proposed Apache Tomcat migration tool for Jakarta EE 1.0.4 is now
available for voting.

The significant changes since 1.0.3 are:

- Issue #26 - Re-fix
- PR #28 - Add Jakarta EE -. Java EE profile (with warnings)
- Add checkstyle

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.4/ 



The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1392/

The tag is:
https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.4
a74aad315b8af81de0fa1837acc2adb278f5cb5a

The proposed 1.0.4 release is:

[ ] -1: Broken. Do not release because...
[ ] +1: Acceptable. Go ahead and release.

Thanks,

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.4

[Felix Schumacher]

Am 15.09.22 um 11:06 schrieb Mark Thomas:

The proposed Apache Tomcat migration tool for Jakarta EE 1.0.4 is now
available for voting.

The significant changes since 1.0.3 are:

- Issue #26 - Re-fix
- PR #28 - Add Jakarta EE -. Java EE profile (with warnings)
- Add checkstyle

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.4/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1392/

The tag is:
https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.4
a74aad315b8af81de0fa1837acc2adb278f5cb5a

The proposed 1.0.4 release is:

[ ] -1: Broken. Do not release because...
[x] +1: Acceptable. Go ahead and release.


Thanks for RM

Felix



Thanks,

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



OpenPGP_0xEA6C3728EA91C4AF.asc
Description: OpenPGP public key


OpenPGP_signature
Description: OpenPGP digital signature

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.4

[Felix Schumacher]

Well, my second mail included a +1, but I will re-send a new +1 to make 
it more clear.


Felix

Am 19.09.22 um 15:07 schrieb Mark Thomas:

Ping.

We need one more PMC vote for this release.

While Felix did indicate support for the release, there wasn't an 
explicit +1 and I'm opting to err on the side of caution.


Mark


On 15/09/2022 10:06, Mark Thomas wrote:

The proposed Apache Tomcat migration tool for Jakarta EE 1.0.4 is now
available for voting.

The significant changes since 1.0.3 are:

- Issue #26 - Re-fix
- PR #28 - Add Jakarta EE -. Java EE profile (with warnings)
- Add checkstyle

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.4/ 



The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1392/

The tag is:
https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.4
a74aad315b8af81de0fa1837acc2adb278f5cb5a

The proposed 1.0.4 release is:

[ ] -1: Broken. Do not release because...
[ ] +1: Acceptable. Go ahead and release.

Thanks,

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



OpenPGP_0xEA6C3728EA91C4AF.asc
Description: OpenPGP public key


OpenPGP_signature
Description: OpenPGP digital signature

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.4

[Mark Thomas]

Ping.

We need one more PMC vote for this release.

While Felix did indicate support for the release, there wasn't an 
explicit +1 and I'm opting to err on the side of caution.


Mark


On 15/09/2022 10:06, Mark Thomas wrote:

The proposed Apache Tomcat migration tool for Jakarta EE 1.0.4 is now
available for voting.

The significant changes since 1.0.3 are:

- Issue #26 - Re-fix
- PR #28 - Add Jakarta EE -. Java EE profile (with warnings)
- Add checkstyle

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.4/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1392/

The tag is:
https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.4
a74aad315b8af81de0fa1837acc2adb278f5cb5a

The proposed 1.0.4 release is:

[ ] -1: Broken. Do not release because...
[ ] +1: Acceptable. Go ahead and release.

Thanks,

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.4

[Mark Thomas]

On 15/09/2022 10:06, Mark Thomas wrote:

The proposed Apache Tomcat migration tool for Jakarta EE 1.0.4 is now
available for voting.

The significant changes since 1.0.3 are:

- Issue #26 - Re-fix
- PR #28 - Add Jakarta EE -. Java EE profile (with warnings)
- Add checkstyle

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.4/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1392/

The tag is:
https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.4
a74aad315b8af81de0fa1837acc2adb278f5cb5a

The proposed 1.0.4 release is:

[ ] -1: Broken. Do not release because...
[X] +1: Acceptable. Go ahead and release.


Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.4

[Felix Schumacher]

Am 15.09.22 um 16:32 schrieb Mark Thomas:

On 15/09/2022 14:36, Felix Schumacher wrote:


Am 15.09.22 um 11:06 schrieb Mark Thomas:

The proposed Apache Tomcat migration tool for Jakarta EE 1.0.4 is now
available for voting.

The significant changes since 1.0.3 are:

- Issue #26 - Re-fix
- PR #28 - Add Jakarta EE -. Java EE profile (with warnings)
- Add checkstyle

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.4/ 



The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1392/ 



The tag is:
https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.4
a74aad315b8af81de0fa1837acc2adb278f5cb5a

The proposed 1.0.4 release is:

[ ] -1: Broken. Do not release because...
[x] +1: Acceptable. Go ahead and release.


When I try to build the sources from the tar.gz maven complains about 
missing checkstyle files:


[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-checkstyle-plugin:3.2.0:check 
(validate) on project jakartaee-migration: Failed during checkstyle 
execution: Unable to find configuration file at location: 
res/checkstyle/checkstyle.xml: Could not find resource 
'res/checkstyle/checkstyle.xml'. -> [Help 1]


When I copy the files from git into the source folder mvn verify 
works as expected.


I'll get that fixed.

Do we want 1.0.5 for this?


I would be OK without a fix, but wasn't sure about it generally.

Felix



Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



OpenPGP_0xEA6C3728EA91C4AF.asc
Description: OpenPGP public key


OpenPGP_signature
Description: OpenPGP digital signature

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.4

[Mark Thomas]

On 15/09/2022 14:36, Felix Schumacher wrote:


Am 15.09.22 um 11:06 schrieb Mark Thomas:

The proposed Apache Tomcat migration tool for Jakarta EE 1.0.4 is now
available for voting.

The significant changes since 1.0.3 are:

- Issue #26 - Re-fix
- PR #28 - Add Jakarta EE -. Java EE profile (with warnings)
- Add checkstyle

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.4/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1392/

The tag is:
https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.4
a74aad315b8af81de0fa1837acc2adb278f5cb5a

The proposed 1.0.4 release is:

[ ] -1: Broken. Do not release because...
[ ] +1: Acceptable. Go ahead and release.


When I try to build the sources from the tar.gz maven complains about 
missing checkstyle files:


[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-checkstyle-plugin:3.2.0:check (validate) 
on project jakartaee-migration: Failed during checkstyle execution: 
Unable to find configuration file at location: 
res/checkstyle/checkstyle.xml: Could not find resource 
'res/checkstyle/checkstyle.xml'. -> [Help 1]


When I copy the files from git into the source folder mvn verify works 
as expected.


I'll get that fixed.

Do we want 1.0.5 for this?

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.4

[Felix Schumacher]

Am 15.09.22 um 11:06 schrieb Mark Thomas:

The proposed Apache Tomcat migration tool for Jakarta EE 1.0.4 is now
available for voting.

The significant changes since 1.0.3 are:

- Issue #26 - Re-fix
- PR #28 - Add Jakarta EE -. Java EE profile (with warnings)
- Add checkstyle

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.4/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1392/

The tag is:
https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.4
a74aad315b8af81de0fa1837acc2adb278f5cb5a

The proposed 1.0.4 release is:

[ ] -1: Broken. Do not release because...
[ ] +1: Acceptable. Go ahead and release.


When I try to build the sources from the tar.gz maven complains about 
missing checkstyle files:


[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-checkstyle-plugin:3.2.0:check (validate) 
on project jakartaee-migration: Failed during checkstyle execution: 
Unable to find configuration file at location: 
res/checkstyle/checkstyle.xml: Could not find resource 
'res/checkstyle/checkstyle.xml'. -> [Help 1]


When I copy the files from git into the source folder mvn verify works 
as expected.


Felix



Thanks,

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



OpenPGP_0xEA6C3728EA91C4AF.asc
Description: OpenPGP public key


OpenPGP_signature
Description: OpenPGP digital signature

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.4

[Rémy Maucherat]

On Thu, Sep 15, 2022 at 11:06 AM Mark Thomas  wrote:
>
> The proposed Apache Tomcat migration tool for Jakarta EE 1.0.4 is now
> available for voting.
>
> The significant changes since 1.0.3 are:
>
> - Issue #26 - Re-fix
> - PR #28 - Add Jakarta EE -. Java EE profile (with warnings)
> - Add checkstyle
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.4/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1392/
>
> The tag is:
> https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.4
> a74aad315b8af81de0fa1837acc2adb278f5cb5a
>
> The proposed 1.0.4 release is:
>
> [ ] -1: Broken. Do not release because...
> [X] +1: Acceptable. Go ahead and release.

Rémy

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.4

[Han Li]

> 2022年9月15日 17:06，Mark Thomas  写道：
> 
> The proposed Apache Tomcat migration tool for Jakarta EE 1.0.4 is now
> available for voting.
> 
> The significant changes since 1.0.3 are:
> 
> - Issue #26 - Re-fix
> - PR #28 - Add Jakarta EE -. Java EE profile (with warnings)
> - Add checkstyle
> 
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.4/
> 
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1392/
> 
> The tag is:
> https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.4
> a74aad315b8af81de0fa1837acc2adb278f5cb5a
> 
> The proposed 1.0.4 release is:
> 
> [ ] -1: Broken. Do not release because...
> [ X] +1: Acceptable. Go ahead and release.

Unit tests pass.

Sample application that has migrated which runs properly on Tomcat 10.0.23 with 
some SORTED jars.

Han

> 
> Thanks,
> 
> Mark
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.3

[Felix Schumacher]

Am 06.09.22 um 16:30 schrieb Mark Thomas:

The proposed Apache Tomcat migration tool for Jakarta EE 1.0.3 is now
available for voting.

The significant changes since 1.0.1 are:

- Issue #26 - bad CRC checksums
- Issue #32 - Manifests in exploded JARs

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.3/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1387/

The tag is:
https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.3
a5e9028e610b7b2ac1ef6fbef8a96dc3d97d7a45

The proposed 1.0.3 release is:

[ ] -1: Broken. Do not release because...
[x] +1: Acceptable. Go ahead and release.


Unit tests pass.

Felix



Thanks,

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



OpenPGP_0xEA6C3728EA91C4AF.asc
Description: OpenPGP public key


OpenPGP_signature
Description: OpenPGP digital signature

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.3

[Mark Thomas]

Ping.

We need one more +1 PMC member vote for this release vote to pass.

Mark


On 06/09/2022 15:30, Mark Thomas wrote:

The proposed Apache Tomcat migration tool for Jakarta EE 1.0.3 is now
available for voting.

The significant changes since 1.0.1 are:

- Issue #26 - bad CRC checksums
- Issue #32 - Manifests in exploded JARs

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.3/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1387/

The tag is:
https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.3
a5e9028e610b7b2ac1ef6fbef8a96dc3d97d7a45

The proposed 1.0.3 release is:

[ ] -1: Broken. Do not release because...
[ ] +1: Acceptable. Go ahead and release.

Thanks,

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.3

[Rémy Maucherat]

On Tue, Sep 6, 2022 at 4:30 PM Mark Thomas  wrote:
>
> The proposed Apache Tomcat migration tool for Jakarta EE 1.0.3 is now
> available for voting.
>
> The significant changes since 1.0.1 are:
>
> - Issue #26 - bad CRC checksums
> - Issue #32 - Manifests in exploded JARs
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.3/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1387/
>
> The tag is:
> https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.3
> a5e9028e610b7b2ac1ef6fbef8a96dc3d97d7a45
>
> The proposed 1.0.3 release is:
>
> [ ] -1: Broken. Do not release because...
> [X] +1: Acceptable. Go ahead and release.

Remy

> Thanks,
>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.3

[Mark Thomas]

On 06/09/2022 15:30, Mark Thomas wrote:

The proposed Apache Tomcat migration tool for Jakarta EE 1.0.3 is now
available for voting.

The significant changes since 1.0.1 are:

- Issue #26 - bad CRC checksums
- Issue #32 - Manifests in exploded JARs

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.3/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1387/

The tag is:
https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.3
a5e9028e610b7b2ac1ef6fbef8a96dc3d97d7a45

The proposed 1.0.3 release is:

[ ] -1: Broken. Do not release because...
[X] +1: Acceptable. Go ahead and release.


Tested by deploying Tomcat 9.0.x examples web application to Tomcat 10.1.x

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.3

[Han Li]

> 2022年9月6日 22:30，Mark Thomas  写道：
> 
> The proposed Apache Tomcat migration tool for Jakarta EE 1.0.3 is now
> available for voting.
> 
> The significant changes since 1.0.1 are:
> 
> - Issue #26 - bad CRC checksums
> - Issue #32 - Manifests in exploded JARs
> 
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.3/
> 
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1387/
> 
> The tag is:
> https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.3
> a5e9028e610b7b2ac1ef6fbef8a96dc3d97d7a45
> 
> The proposed 1.0.3 release is:
> 
> [ ] -1: Broken. Do not release because…
> [X ] +1: Acceptable. Go ahead and release.

All unit tests pass.

Han

> 
> Thanks,
> 
> Mark
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.2

[Rémy Maucherat]

On Fri, Sep 2, 2022 at 11:20 PM Mark Thomas  wrote:
>
> The proposed Apache Tomcat migration tool for Jakarta EE 1.0.2 is now
> available for voting.
>
> The significant changes since 1.0.1 are:
>
> - Issue #26 - bad CRC checksums
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.2/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1386/
>
> The tag is:
> https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.2
> 37a9d5a438206b429997d4c1a9bb19f21b133145
>
> The proposed 1.0.2 release is:
>
> [ ] -1: Broken. Do not release because...
> [X] +1: Acceptable. Go ahead and release.

Rémy

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.2

[Mark Thomas]

On 02/09/2022 22:19, Mark Thomas wrote:

The proposed Apache Tomcat migration tool for Jakarta EE 1.0.2 is now
available for voting.

The significant changes since 1.0.1 are:

- Issue #26 - bad CRC checksums

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.2/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1386/

The tag is:
https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.2
37a9d5a438206b429997d4c1a9bb19f21b133145

The proposed 1.0.2 release is:

[ ] -1: Broken. Do not release because...
[X] +1: Acceptable. Go ahead and release.


Unit tests pass.

Tested with examples web application from 9.0.x on 10.1.x.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.2

[Han Li]

> 2022年9月3日 05:19，Mark Thomas  写道：
> 
> The proposed Apache Tomcat migration tool for Jakarta EE 1.0.2 is now
> available for voting.
> 
> The significant changes since 1.0.1 are:
> 
> - Issue #26 - bad CRC checksums
> 
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.2/
> 
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1386/
> 
> The tag is:
> https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.2
> 37a9d5a438206b429997d4c1a9bb19f21b133145
> 
> The proposed 1.0.2 release is:
> 
> [ ] -1: Broken. Do not release because…
> [X ] +1: Acceptable. Go ahead and release.

All unit tests have passed.


Han

> 
> Thanks,
> 
> Mark
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.1

[Mark Thomas]

Thanks for the review. Fixes made for next release.

Mark


On 07/07/2022 14:03, Konstantin Kolinko wrote:

вт, 5 июл. 2022 г. в 22:49, Mark Thomas :


The proposed Apache Tomcat migration tool for Jakarta EE 1.0.1 is now
available for voting.

The significant changes since 1.0.0 are:

- Add support for .groovy files

- Better support for non-standard archives

- Numerous library updates

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.1/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1381/

The tag is:
https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.1
acf10c08b41c6ce8fa4965fd975420b6e9e2b038

The proposed 1.0.1 release is:



Not tested, but reviewed the distributables.
Minor issues.

1. The NOTICE.txt file has not been updated for the year 2022.

It says:
Apache Tomcat migration tool for Jakarta EE
Copyright 2021 The Apache Software Foundation

instead of 2021-2022 as usual.

I think it is not a stopper. I think that it is still valid from the
legal point of view.


2. jakartaee-migration-1.0.1-src.zip and
jakartaee-migration-1.0.1-src.tar.gz miss some files:

.gitignore
.travis.yml
CHANGES.md
.mvn/wrapper/maven-wrapper.jar

Looking into mvnw.cmd and mvnw scripts,
I see that they can deal with missing maven-wrapper.jar file:
They will download version 0.5.6 of maven-wrapper from Maven Central,
if one is missing locally.

So I think it is not a stopper.


3. Version numbering, "1.0.1" vs "1.1.0" and Semantic Versioning.

For reference:
https://semver.org/

According to CHANGES.md,
https://github.com/apache/tomcat-jakartaee-migration/blob/main/CHANGES.md
I see two functionality changes that are not bug fixes:

(1) "Fix #19. Add support for converting .groovy files."

- From the description it sounds as an "added feature" and thus I was
thinking whether it needs bumping the version number to 1.1.0,
but actually it is an internal, one-liner change
https://github.com/apache/tomcat-jakartaee-migration/commit/6465822873b3215cabc4a922e8444c4a960d7761

There are no new configuration options or anything like that. So I
think it does not count as an "added feature".

(2) "Remove deprecated -verbose command line option (remm)"

https://github.com/apache/tomcat-jakartaee-migration/commit/528f05e09ba5745c56bcd66e02d88ce7ad8bb596

Removing an undocumented option that is commented as deprecated in the
code is OK.
I think it does not count as an "added feature". If it is breaking
something, it is covered by 0.2.0 -> 1.0.0 version number change.

Thus I am OK with the version number of 1.0.1.


[ ] -1: Broken. Do not release because...
[x] +1: Acceptable. Go ahead and release.


Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.1

[Konstantin Kolinko]

вт, 5 июл. 2022 г. в 22:49, Mark Thomas :
>
> The proposed Apache Tomcat migration tool for Jakarta EE 1.0.1 is now
> available for voting.
>
> The significant changes since 1.0.0 are:
>
> - Add support for .groovy files
>
> - Better support for non-standard archives
>
> - Numerous library updates
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.1/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1381/
>
> The tag is:
> https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.1
> acf10c08b41c6ce8fa4965fd975420b6e9e2b038
>
> The proposed 1.0.1 release is:
>

Not tested, but reviewed the distributables.
Minor issues.

1. The NOTICE.txt file has not been updated for the year 2022.

It says:
Apache Tomcat migration tool for Jakarta EE
Copyright 2021 The Apache Software Foundation

instead of 2021-2022 as usual.

I think it is not a stopper. I think that it is still valid from the
legal point of view.


2. jakartaee-migration-1.0.1-src.zip and
jakartaee-migration-1.0.1-src.tar.gz miss some files:

.gitignore
.travis.yml
CHANGES.md
.mvn/wrapper/maven-wrapper.jar

Looking into mvnw.cmd and mvnw scripts,
I see that they can deal with missing maven-wrapper.jar file:
They will download version 0.5.6 of maven-wrapper from Maven Central,
if one is missing locally.

So I think it is not a stopper.


3. Version numbering, "1.0.1" vs "1.1.0" and Semantic Versioning.

For reference:
https://semver.org/

According to CHANGES.md,
https://github.com/apache/tomcat-jakartaee-migration/blob/main/CHANGES.md
I see two functionality changes that are not bug fixes:

(1) "Fix #19. Add support for converting .groovy files."

- From the description it sounds as an "added feature" and thus I was
thinking whether it needs bumping the version number to 1.1.0,
but actually it is an internal, one-liner change
https://github.com/apache/tomcat-jakartaee-migration/commit/6465822873b3215cabc4a922e8444c4a960d7761

There are no new configuration options or anything like that. So I
think it does not count as an "added feature".

(2) "Remove deprecated -verbose command line option (remm)"

https://github.com/apache/tomcat-jakartaee-migration/commit/528f05e09ba5745c56bcd66e02d88ce7ad8bb596

Removing an undocumented option that is commented as deprecated in the
code is OK.
I think it does not count as an "added feature". If it is breaking
something, it is covered by 0.2.0 -> 1.0.0 version number change.

Thus I am OK with the version number of 1.0.1.

> [ ] -1: Broken. Do not release because...
> [x] +1: Acceptable. Go ahead and release.

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.1

[Mark Thomas]

On 05/07/2022 20:48, Mark Thomas wrote:

The proposed Apache Tomcat migration tool for Jakarta EE 1.0.1 is now
available for voting.

The significant changes since 1.0.0 are:

- Add support for .groovy files

- Better support for non-standard archives

- Numerous library updates

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.1/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1381/

The tag is:
https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.1
acf10c08b41c6ce8fa4965fd975420b6e9e2b038

The proposed 1.0.1 release is:

[ ] -1: Broken. Do not release because...
[X] +1: Acceptable. Go ahead and release.


Built the Tomcat 9.0.x webapps, deployed them on Tomcat 10.1.x modified 
to use this library and performed some basic testing. All looks good.


Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.1

[Rémy Maucherat]

On Tue, Jul 5, 2022 at 9:49 PM Mark Thomas  wrote:
>
> The proposed Apache Tomcat migration tool for Jakarta EE 1.0.1 is now
> available for voting.
>
> The significant changes since 1.0.0 are:
>
> - Add support for .groovy files
>
> - Better support for non-standard archives
>
> - Numerous library updates
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.1/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1381/
>
> The tag is:
> https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.1
> acf10c08b41c6ce8fa4965fd975420b6e9e2b038
>
> The proposed 1.0.1 release is:
>
> [ ] -1: Broken. Do not release because...
> [X] +1: Acceptable. Go ahead and release.

Remy

> Thanks,
>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.1

[Han Li]

> 2022年7月6日 03:48，Mark Thomas  写道：
> 
> The proposed Apache Tomcat migration tool for Jakarta EE 1.0.1 is now
> available for voting.
> 
> The significant changes since 1.0.0 are:
> 
> - Add support for .groovy files
> 
> - Better support for non-standard archives
> 
> - Numerous library updates
> 
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.1/
> 
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1381/
> 
> The tag is:
> https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.1
> acf10c08b41c6ce8fa4965fd975420b6e9e2b038
> 
> The proposed 1.0.1 release is:
> 
> [ ] -1: Broken. Do not release because…
> [X] +1: Acceptable. Go ahead and release.
> 
> Thanks,
> 
> Mark
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


All unit test passed.

Sorry, the previous reply is invalid.;)

Han
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.1

[Han Li]

> 2022年7月6日 03:48，Mark Thomas  写道：
> 
> The proposed Apache Tomcat migration tool for Jakarta EE 1.0.1 is now
> available for voting.
> 
> The significant changes since 1.0.0 are:
> 
> - Add support for .groovy files
> 
> - Better support for non-standard archives
> 
> - Numerous library updates
> 
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.1/
> 
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1381/
> 
> The tag is:
> https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.1
> acf10c08b41c6ce8fa4965fd975420b6e9e2b038
> 
> The proposed 1.0.1 release is:
> 
> [ ] -1: Broken. Do not release because...
> [ ] +1: Acceptable. Go ahead and release.
> 
> Thanks,
> 
> Mark
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 

Mark,

The Migration unit test failed because some jar packages were missing.
Is this normal?

Han


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.0

[Martin Grigorov]

On Tue, May 4, 2021 at 3:06 PM Mark Thomas  wrote:

> The proposed Apache Tomcat migration tool for Jakarta EE 1.0.0 is now
> available for voting.
>
> The significant changes since 0.2.0 are:
>
> - Further fixes to exclude javax.xml packages that are not part of
>Java EE from the migration
>
> - The class transformer now validates that the target classes in the
>Jakarta namespace exist in the runtime environment
>
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.0/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1308/
>
> The tag is:
> https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.0
> 2a27b633f456710dc5d51680344ca7f047642a60
>
> The proposed 1.0.0 release is:
>
> [ ] -1: Broken. Do not release because...
> [ X ] +1: Acceptable. Go ahead and release.
>

Regards,
Martin


>
> Thanks,
>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.0

[Mark Thomas]

On 04/05/2021 13:06, Mark Thomas wrote:


The proposed 1.0.0 release is:

[ ] -1: Broken. Do not release because...
[X] +1: Acceptable. Go ahead and release.


Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.0

[jean-frederic clere]

On 04/05/2021 14:06, Mark Thomas wrote:

[X] +1: Acceptable. Go ahead and release.


tested with my test war file, works like a charm.

--
Cheers

Jean-Frederic

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.0

[Romain Manni-Bucau]

+1, xml fix is helping

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le mar. 4 mai 2021 à 14:52, Rémy Maucherat  a écrit :

> On Tue, May 4, 2021 at 2:06 PM Mark Thomas  wrote:
>
> > The proposed Apache Tomcat migration tool for Jakarta EE 1.0.0 is now
> > available for voting.
> >
> > The significant changes since 0.2.0 are:
> >
> > - Further fixes to exclude javax.xml packages that are not part of
> >Java EE from the migration
> >
> > - The class transformer now validates that the target classes in the
> >Jakarta namespace exist in the runtime environment
> >
> >
> > It can be obtained from:
> >
> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.0/
> >
> > The Maven staging repo is:
> > https://repository.apache.org/content/repositories/orgapachetomcat-1308/
> >
> > The tag is:
> > https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.0
> > 2a27b633f456710dc5d51680344ca7f047642a60
> >
> > The proposed 1.0.0 release is:
> >
> > [ ] -1: Broken. Do not release because...
> > [X] +1: Acceptable. Go ahead and release.
> >
> > Rémy
>

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.0

[Rémy Maucherat]

On Tue, May 4, 2021 at 2:06 PM Mark Thomas  wrote:

> The proposed Apache Tomcat migration tool for Jakarta EE 1.0.0 is now
> available for voting.
>
> The significant changes since 0.2.0 are:
>
> - Further fixes to exclude javax.xml packages that are not part of
>Java EE from the migration
>
> - The class transformer now validates that the target classes in the
>Jakarta namespace exist in the runtime environment
>
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.0/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1308/
>
> The tag is:
> https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.0
> 2a27b633f456710dc5d51680344ca7f047642a60
>
> The proposed 1.0.0 release is:
>
> [ ] -1: Broken. Do not release because...
> [X] +1: Acceptable. Go ahead and release.
>
> Rémy

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 0.2.0

[Romain Manni-Bucau]

+1 (non binding)

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le mar. 16 févr. 2021 à 08:43, Martin Grigorov  a
écrit :

> On Thu, Feb 11, 2021 at 7:47 PM Mark Thomas  wrote:
>
> > The proposed Apache Tomcat migration tool for Jakarta EE 0.2.0 is now
> > available for voting.
> >
> > The significant changes since 0.1.0 are:
> >
> > - Various fixes to the packages that are and are not converted
> >
> > - A new option to process zip archives in memory to support zip files
> >   that use options that are incompatible with a streaming approach
> >
> > - A new option to exclude files from transformation
> >
> > It can be obtained from:
> >
> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v0.2.0/
> >
> > The Maven staging repo is:
> > https://repository.apache.org/content/repositories/orgapachetomcat-1299/
> >
> > The tag is:
> > https://github.com/apache/tomcat-jakartaee-migration/tree/0.2.0
> > 041e256e92078cd3b16a9adcd77faf257e3a5c88
> >
> > The proposed 0.2.0 release is:
> >
> > [ ] -1: Broken. Do not release because...
> > [ X ] +1: Acceptable. Go ahead and release.
> >
>
> Built it from sources.
> Migrated Apache Wicket 9.x examples application, with streaming.
>
> Martin
>
>
> > Thanks,
> >
> > Mark
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
> >
>

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 0.2.0

[Martin Grigorov]

On Thu, Feb 11, 2021 at 7:47 PM Mark Thomas  wrote:

> The proposed Apache Tomcat migration tool for Jakarta EE 0.2.0 is now
> available for voting.
>
> The significant changes since 0.1.0 are:
>
> - Various fixes to the packages that are and are not converted
>
> - A new option to process zip archives in memory to support zip files
>   that use options that are incompatible with a streaming approach
>
> - A new option to exclude files from transformation
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v0.2.0/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1299/
>
> The tag is:
> https://github.com/apache/tomcat-jakartaee-migration/tree/0.2.0
> 041e256e92078cd3b16a9adcd77faf257e3a5c88
>
> The proposed 0.2.0 release is:
>
> [ ] -1: Broken. Do not release because...
> [ X ] +1: Acceptable. Go ahead and release.
>

Built it from sources.
Migrated Apache Wicket 9.x examples application, with streaming.

Martin


> Thanks,
>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 0.2.0

[Rémy Maucherat]

On Thu, Feb 11, 2021 at 6:47 PM Mark Thomas  wrote:

> The proposed Apache Tomcat migration tool for Jakarta EE 0.2.0 is now
> available for voting.
>
> The significant changes since 0.1.0 are:
>
> - Various fixes to the packages that are and are not converted
>
> - A new option to process zip archives in memory to support zip files
>   that use options that are incompatible with a streaming approach
>
> - A new option to exclude files from transformation
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v0.2.0/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1299/
>
> The tag is:
> https://github.com/apache/tomcat-jakartaee-migration/tree/0.2.0
> 041e256e92078cd3b16a9adcd77faf257e3a5c88
>
> The proposed 0.2.0 release is:
>
> [ ] -1: Broken. Do not release because...
> [X] +1: Acceptable. Go ahead and release.
>

Rémy

>
> Thanks,
>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 0.2.0

[Mark Thomas]

On 11/02/2021 17:47, Mark Thomas wrote:
> The proposed Apache Tomcat migration tool for Jakarta EE 0.2.0 is now
> available for voting.
> 
> The significant changes since 0.1.0 are:
> 
> - Various fixes to the packages that are and are not converted
> 
> - A new option to process zip archives in memory to support zip files
>   that use options that are incompatible with a streaming approach
> 
> - A new option to exclude files from transformation
> 
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v0.2.0/
> 
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1299/
> 
> The tag is:
> https://github.com/apache/tomcat-jakartaee-migration/tree/0.2.0
> 041e256e92078cd3b16a9adcd77faf257e3a5c88
> 
> The proposed 0.2.0 release is:
> 
> [ ] -1: Broken. Do not release because...
> [X] +1: Acceptable. Go ahead and release.

Tested with my local changes that add migration to Tomcat 10. A WAR
built from the Tomcat 9 examples works happily (Servlets, JSPs,
WebSocket) on Tomcat 10.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE

[Igal Sapir]

On Thu, Dec 10, 2020 at 11:45 PM Mark Thomas  wrote:

> On 11/12/2020 06:58, Martin Grigorov wrote:
> > On Thu, Dec 10, 2020 at 11:50 PM Igal Sapir  wrote:
> >
> >> On Thu, Dec 10, 2020 at 5:58 AM Christopher Schultz <
> >> ch...@christopherschultz.net> wrote:
> >>
> >>> Mark,
> >>>
> >>> On 12/10/20 06:39, Mark Thomas wrote:
>  The proposed Apache Tomcat migration tool for Jakarta EE 0.1.0 is now
>  available for voting.
> 
>  This is (potentially) the first release.
> 
>  It can be obtained from:
> 
> >>>
> >>
> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v0.1.0/
> 
>  The Maven staging repo is:
> 
> >>
> https://repository.apache.org/content/repositories/orgapachetomcat-1291/
> 
>  The tag is:
>  https://github.com/apache/tomcat-jakartaee-migration/tree/0.1.0
>  cbada3204bf9c43ca0cf481cd88c7521690b30a0
> 
>  The proposed 0.1.0 release is:
> 
>  [ ] -1: Broken. Do not release because...
>  [ ] +1: Acceptable. Go ahead and release.
> >>>
> >>> Do we even need (a) a release and (b) a VOTE?
> >>>
> >>> I once heard Ross say that there was an ASP project (Subversion?) that
> >>> never had votes; they only had releases. That seemed to cut-down on the
> >>> red-tape required to get things out into the world. I can't find a
> >>> reference for that, now.
> >>>
> >>> Since this is a developer tool and not a runtime library or anything
> >>> like that, maybe we can just say "YMMV, this is available any time you
> >>> want it"?
> >>>
> >>> That said, I have no objections whatsoever with holding a vote. I am an
> >>> unsigned "0" on the vote itself; I have not even downloaded the source
> >>> let alone attempted to migrate a project using it.
> >>>
> >>
> >> I'm a +0 on this one.  Like Chris, I also did not even download nor
> tested
> >> that tool.
> >>
> >> Did we use that tool to migrate the Tomcat examples?  Were they all
> >> migrated successfully?
> >>
> >
> > No. The examples were migrated manually, i.e. their source code was
> > migrated.
> > The tool migrates binary files (.war,.jar, .class). It is useful when
> your
> > application depends on third party libraries which still use javax.**
>
> Martin is correct, the examples were migrated using a package rename in
> the IDE.
>
> The JSTL JARs (used by the examples webapp) were migrated with this tool.
>

Thank you both for clarifying.  My question just shows why at this point I
should remain a +0 on this one.

Igal



>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE

[Christopher Schultz]

Mark,

On 12/10/20 11:14, Mark Thomas wrote:

[snip]

>

Doing conversion on the fly or at deployment/start-up time raises
various issues that boil down to "How do we detect if conversion is
required?" and "What are the performance impacts of doing so?". There
are users who want to squeeze every last drop of performance out of the
system so I think that leads to some sort of configuration option.


This conversion is only applied at class-loading time, yes? Not on every 
request, etc. I would imagine that a one-time hit for all classes 
wouldn't be that big of a deal.


Tomcat could allow admins to either allow auto-conversion or not, for 
the whole server. Or, maybe, for the whole  or something.


-chris

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE

[Christopher Schultz]

Mark,

On 12/10/20 11:14, Mark Thomas wrote:

On 10/12/2020 14:52, Romain Manni-Bucau wrote:

Le jeu. 10 déc. 2020 à 15:49, Rémy Maucherat  a écrit :

On Thu, Dec 10, 2020 at 3:13 PM Mark Thomas  wrote:

On 10/12/2020 13:58, Christopher Schultz wrote:





Since this is a developer tool and not a runtime library or anything
like that, maybe we can just say "YMMV, this is available any time you
want it"?


It could be a runtime library. One possibility is that we integrate it
into Tomcat 10 somehow so that if you try and deploy a Java EE 8 WAR it
gets automatically converted to a Jakarta EE 9 WAR.



It sounds doable with a special folder of the host (like a legacyAppBase),
and it creates the result in the host's appBase. Like HostConfig.deployApps
simply does this first, then moves down the usual deployments. I'm not sure
that this is really useful though.



Does it sound stupid to make the library a ClassFileTransformer added on
the webapp classloader? Sounds the most hurtless for users even if it will
adds a small overhead (and avoids a lot of file duplication which can be
harder to maintain at some point).


It doesn't sound stupid at all. It was one of the options considered
when we first started thinking about this. That was before we had the
current implementation. With the experience of what the current
implementation looks like we might want to revisit that discussion.

My own thinking was to convert appBase/javaee.war to
appBase/javaee##converted.war and let the parallel deployment code take
care of deploying just the updated version.

Doing conversion on the fly or at deployment/start-up time raises
various issues that boil down to "How do we detect if conversion is
required?" and "What are the performance impacts of doing so?". There
are users who want to squeeze every last drop of performance out of the
system so I think that leads to some sort of configuration option.

Just thinking about that I thought of:
- watch what classes are requested
- as soon as javax.servlet.* (or one of the others is detected) stop the
   context, enable conversion and restart the context

Then I thought that apps might try to determine if they are running on
Java EE or Jakarta EE by trying to load classes. That could incorrectly
trigger the conversion.

Hmm. Anything apart from an explicitly user set flag starts to look
potentially tricky for some use cases.

Thoughts?


Read the WEB-INF/web.xml file for the web-app version?

-chris

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE

[Christopher Schultz]

Mark,

On 12/10/20 09:13, Mark Thomas wrote:

On 10/12/2020 13:58, Christopher Schultz wrote:

Mark,

On 12/10/20 06:39, Mark Thomas wrote:

The proposed Apache Tomcat migration tool for Jakarta EE 0.1.0 is now
available for voting.

This is (potentially) the first release.

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v0.1.0/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1291/

The tag is:
https://github.com/apache/tomcat-jakartaee-migration/tree/0.1.0
cbada3204bf9c43ca0cf481cd88c7521690b30a0

The proposed 0.1.0 release is:

[ ] -1: Broken. Do not release because...
[ ] +1: Acceptable. Go ahead and release.


Do we even need (a) a release and (b) a VOTE?


If we want a release, we MUST have a VOTE.


I was kind of thinking that if we didn't need (a) then (b) would be 
unnecessary.



Since this is a developer tool and not a runtime library or anything
like that, maybe we can just say "YMMV, this is available any time you
want it"?


It could be a runtime library. One possibility is that we integrate it
into Tomcat 10 somehow so that if you try and deploy a Java EE 8 WAR it
gets automatically converted to a Jakarta EE 9 WAR.


Witchcraft.

-chris

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE

[Romain Manni-Bucau]

Le ven. 11 déc. 2020 à 10:59, Rémy Maucherat  a écrit :

> On Thu, Dec 10, 2020 at 5:14 PM Mark Thomas  wrote:
>
> > On 10/12/2020 14:52, Romain Manni-Bucau wrote:
> > > Le jeu. 10 déc. 2020 à 15:49, Rémy Maucherat  a
> écrit :
> > >> On Thu, Dec 10, 2020 at 3:13 PM Mark Thomas  wrote:
> > >>> On 10/12/2020 13:58, Christopher Schultz wrote:
> >
> > 
> >
> >  Since this is a developer tool and not a runtime library or anything
> >  like that, maybe we can just say "YMMV, this is available any time
> you
> >  want it"?
> > >>>
> > >>> It could be a runtime library. One possibility is that we integrate
> it
> > >>> into Tomcat 10 somehow so that if you try and deploy a Java EE 8 WAR
> it
> > >>> gets automatically converted to a Jakarta EE 9 WAR.
> > >>>
> > >>
> > >> It sounds doable with a special folder of the host (like a
> > legacyAppBase),
> > >> and it creates the result in the host's appBase. Like
> > HostConfig.deployApps
> > >> simply does this first, then moves down the usual deployments. I'm not
> > sure
> > >> that this is really useful though.
> > >>
> > >
> > > Does it sound stupid to make the library a ClassFileTransformer added
> on
> > > the webapp classloader? Sounds the most hurtless for users even if it
> > will
> > > adds a small overhead (and avoids a lot of file duplication which can
> be
> > > harder to maintain at some point).
> >
> > It doesn't sound stupid at all. It was one of the options considered
> > when we first started thinking about this. That was before we had the
> > current implementation. With the experience of what the current
> > implementation looks like we might want to revisit that discussion.
> >
> > My own thinking was to convert appBase/javaee.war to
> > appBase/javaee##converted.war and let the parallel deployment code take
> > care of deploying just the updated version.
> >
>
> I would think a separate appBase is preferable since it's easier, and
> there's nothing to detect. Everything gets processed by the conversion tool
> and that's it.
>
>
> >
> > Doing conversion on the fly or at deployment/start-up time raises
> > various issues that boil down to "How do we detect if conversion is
> > required?" and "What are the performance impacts of doing so?". There
> > are users who want to squeeze every last drop of performance out of the
> > system so I think that leads to some sort of configuration option.
> >
>
> Still not convinced by the classloading magic (the tool does a bit more
> than this) and AOT would be a problem.
>

Same applies for the different app base, basically AOT can only work if
done at build time so having a cllassfiletransfomer wired either in the
config of the classloader (once again, when tuned to ignored most of
commons  etc by jar name and packages it will not slow down the app
significantly enough to not be worth it as proven by other transformers out
there - take tomee as an example ;)) and another wiring in a main - as of
today - where it enables to get a new binary, potentially integrated with
tomcat embedded/standalone (new Tomcat()) and then go through graalvm.


>
> Rémy
>
>
> >
> > Just thinking about that I thought of:
> > - watch what classes are requested
> > - as soon as javax.servlet.* (or one of the others is detected) stop the
> >   context, enable conversion and restart the context
> >
> > Then I thought that apps might try to determine if they are running on
> > Java EE or Jakarta EE by trying to load classes. That could incorrectly
> > trigger the conversion.
> >
> > Hmm. Anything apart from an explicitly user set flag starts to look
> > potentially tricky for some use cases.
> >
> > Thoughts?
> >
> > Mark
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
> >
>

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE

[Rémy Maucherat]

On Thu, Dec 10, 2020 at 5:14 PM Mark Thomas  wrote:

> On 10/12/2020 14:52, Romain Manni-Bucau wrote:
> > Le jeu. 10 déc. 2020 à 15:49, Rémy Maucherat  a écrit :
> >> On Thu, Dec 10, 2020 at 3:13 PM Mark Thomas  wrote:
> >>> On 10/12/2020 13:58, Christopher Schultz wrote:
>
> 
>
>  Since this is a developer tool and not a runtime library or anything
>  like that, maybe we can just say "YMMV, this is available any time you
>  want it"?
> >>>
> >>> It could be a runtime library. One possibility is that we integrate it
> >>> into Tomcat 10 somehow so that if you try and deploy a Java EE 8 WAR it
> >>> gets automatically converted to a Jakarta EE 9 WAR.
> >>>
> >>
> >> It sounds doable with a special folder of the host (like a
> legacyAppBase),
> >> and it creates the result in the host's appBase. Like
> HostConfig.deployApps
> >> simply does this first, then moves down the usual deployments. I'm not
> sure
> >> that this is really useful though.
> >>
> >
> > Does it sound stupid to make the library a ClassFileTransformer added on
> > the webapp classloader? Sounds the most hurtless for users even if it
> will
> > adds a small overhead (and avoids a lot of file duplication which can be
> > harder to maintain at some point).
>
> It doesn't sound stupid at all. It was one of the options considered
> when we first started thinking about this. That was before we had the
> current implementation. With the experience of what the current
> implementation looks like we might want to revisit that discussion.
>
> My own thinking was to convert appBase/javaee.war to
> appBase/javaee##converted.war and let the parallel deployment code take
> care of deploying just the updated version.
>

I would think a separate appBase is preferable since it's easier, and
there's nothing to detect. Everything gets processed by the conversion tool
and that's it.


>
> Doing conversion on the fly or at deployment/start-up time raises
> various issues that boil down to "How do we detect if conversion is
> required?" and "What are the performance impacts of doing so?". There
> are users who want to squeeze every last drop of performance out of the
> system so I think that leads to some sort of configuration option.
>

Still not convinced by the classloading magic (the tool does a bit more
than this) and AOT would be a problem.

Rémy


>
> Just thinking about that I thought of:
> - watch what classes are requested
> - as soon as javax.servlet.* (or one of the others is detected) stop the
>   context, enable conversion and restart the context
>
> Then I thought that apps might try to determine if they are running on
> Java EE or Jakarta EE by trying to load classes. That could incorrectly
> trigger the conversion.
>
> Hmm. Anything apart from an explicitly user set flag starts to look
> potentially tricky for some use cases.
>
> Thoughts?
>
> Mark
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE

[Mark Thomas]

On 11/12/2020 06:58, Martin Grigorov wrote:
> On Thu, Dec 10, 2020 at 11:50 PM Igal Sapir  wrote:
> 
>> On Thu, Dec 10, 2020 at 5:58 AM Christopher Schultz <
>> ch...@christopherschultz.net> wrote:
>>
>>> Mark,
>>>
>>> On 12/10/20 06:39, Mark Thomas wrote:
 The proposed Apache Tomcat migration tool for Jakarta EE 0.1.0 is now
 available for voting.

 This is (potentially) the first release.

 It can be obtained from:

>>>
>> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v0.1.0/

 The Maven staging repo is:

>> https://repository.apache.org/content/repositories/orgapachetomcat-1291/

 The tag is:
 https://github.com/apache/tomcat-jakartaee-migration/tree/0.1.0
 cbada3204bf9c43ca0cf481cd88c7521690b30a0

 The proposed 0.1.0 release is:

 [ ] -1: Broken. Do not release because...
 [ ] +1: Acceptable. Go ahead and release.
>>>
>>> Do we even need (a) a release and (b) a VOTE?
>>>
>>> I once heard Ross say that there was an ASP project (Subversion?) that
>>> never had votes; they only had releases. That seemed to cut-down on the
>>> red-tape required to get things out into the world. I can't find a
>>> reference for that, now.
>>>
>>> Since this is a developer tool and not a runtime library or anything
>>> like that, maybe we can just say "YMMV, this is available any time you
>>> want it"?
>>>
>>> That said, I have no objections whatsoever with holding a vote. I am an
>>> unsigned "0" on the vote itself; I have not even downloaded the source
>>> let alone attempted to migrate a project using it.
>>>
>>
>> I'm a +0 on this one.  Like Chris, I also did not even download nor tested
>> that tool.
>>
>> Did we use that tool to migrate the Tomcat examples?  Were they all
>> migrated successfully?
>>
> 
> No. The examples were migrated manually, i.e. their source code was
> migrated.
> The tool migrates binary files (.war,.jar, .class). It is useful when your
> application depends on third party libraries which still use javax.**

Martin is correct, the examples were migrated using a package rename in
the IDE.

The JSTL JARs (used by the examples webapp) were migrated with this tool.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE

[Martin Grigorov]

On Thu, Dec 10, 2020 at 1:39 PM Mark Thomas  wrote:

> The proposed Apache Tomcat migration tool for Jakarta EE 0.1.0 is now
> available for voting.
>
> This is (potentially) the first release.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v0.1.0/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1291/
>
> The tag is:
> https://github.com/apache/tomcat-jakartaee-migration/tree/0.1.0
> cbada3204bf9c43ca0cf481cd88c7521690b30a0
>
> The proposed 0.1.0 release is:
>
> [ ] -1: Broken. Do not release because...
> [ X ] +1: Acceptable. Go ahead and release.
>

Regards,
Martin


>
> Thanks,
>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE

[Martin Grigorov]

On Thu, Dec 10, 2020 at 11:50 PM Igal Sapir  wrote:

> On Thu, Dec 10, 2020 at 5:58 AM Christopher Schultz <
> ch...@christopherschultz.net> wrote:
>
> > Mark,
> >
> > On 12/10/20 06:39, Mark Thomas wrote:
> > > The proposed Apache Tomcat migration tool for Jakarta EE 0.1.0 is now
> > > available for voting.
> > >
> > > This is (potentially) the first release.
> > >
> > > It can be obtained from:
> > >
> >
> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v0.1.0/
> > >
> > > The Maven staging repo is:
> > >
> https://repository.apache.org/content/repositories/orgapachetomcat-1291/
> > >
> > > The tag is:
> > > https://github.com/apache/tomcat-jakartaee-migration/tree/0.1.0
> > > cbada3204bf9c43ca0cf481cd88c7521690b30a0
> > >
> > > The proposed 0.1.0 release is:
> > >
> > > [ ] -1: Broken. Do not release because...
> > > [ ] +1: Acceptable. Go ahead and release.
> >
> > Do we even need (a) a release and (b) a VOTE?
> >
> > I once heard Ross say that there was an ASP project (Subversion?) that
> > never had votes; they only had releases. That seemed to cut-down on the
> > red-tape required to get things out into the world. I can't find a
> > reference for that, now.
> >
> > Since this is a developer tool and not a runtime library or anything
> > like that, maybe we can just say "YMMV, this is available any time you
> > want it"?
> >
> > That said, I have no objections whatsoever with holding a vote. I am an
> > unsigned "0" on the vote itself; I have not even downloaded the source
> > let alone attempted to migrate a project using it.
> >
>
> I'm a +0 on this one.  Like Chris, I also did not even download nor tested
> that tool.
>
> Did we use that tool to migrate the Tomcat examples?  Were they all
> migrated successfully?
>

No. The examples were migrated manually, i.e. their source code was
migrated.
The tool migrates binary files (.war,.jar, .class). It is useful when your
application depends on third party libraries which still use javax.**

Martin


>
> Igal
>
>
>
> >
> > -chris
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
> >
>

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE

[Igal Sapir]

On Thu, Dec 10, 2020 at 5:58 AM Christopher Schultz <
ch...@christopherschultz.net> wrote:

> Mark,
>
> On 12/10/20 06:39, Mark Thomas wrote:
> > The proposed Apache Tomcat migration tool for Jakarta EE 0.1.0 is now
> > available for voting.
> >
> > This is (potentially) the first release.
> >
> > It can be obtained from:
> >
> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v0.1.0/
> >
> > The Maven staging repo is:
> > https://repository.apache.org/content/repositories/orgapachetomcat-1291/
> >
> > The tag is:
> > https://github.com/apache/tomcat-jakartaee-migration/tree/0.1.0
> > cbada3204bf9c43ca0cf481cd88c7521690b30a0
> >
> > The proposed 0.1.0 release is:
> >
> > [ ] -1: Broken. Do not release because...
> > [ ] +1: Acceptable. Go ahead and release.
>
> Do we even need (a) a release and (b) a VOTE?
>
> I once heard Ross say that there was an ASP project (Subversion?) that
> never had votes; they only had releases. That seemed to cut-down on the
> red-tape required to get things out into the world. I can't find a
> reference for that, now.
>
> Since this is a developer tool and not a runtime library or anything
> like that, maybe we can just say "YMMV, this is available any time you
> want it"?
>
> That said, I have no objections whatsoever with holding a vote. I am an
> unsigned "0" on the vote itself; I have not even downloaded the source
> let alone attempted to migrate a project using it.
>

I'm a +0 on this one.  Like Chris, I also did not even download nor tested
that tool.

Did we use that tool to migrate the Tomcat examples?  Were they all
migrated successfully?

Igal



>
> -chris
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE

[Emmanuel Bourg]

Le 10/12/2020 à 12:39, Mark Thomas a écrit :

> The proposed 0.1.0 release is:
> 
> [ ] -1: Broken. Do not release because...
> [X] +1: Acceptable. Go ahead and release.

Emmanuel Bourg

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE

[Romain Manni-Bucau]

Le jeu. 10 déc. 2020 à 17:14, Mark Thomas  a écrit :

> On 10/12/2020 14:52, Romain Manni-Bucau wrote:
> > Le jeu. 10 déc. 2020 à 15:49, Rémy Maucherat  a écrit :
> >> On Thu, Dec 10, 2020 at 3:13 PM Mark Thomas  wrote:
> >>> On 10/12/2020 13:58, Christopher Schultz wrote:
>
> 
>
>  Since this is a developer tool and not a runtime library or anything
>  like that, maybe we can just say "YMMV, this is available any time you
>  want it"?
> >>>
> >>> It could be a runtime library. One possibility is that we integrate it
> >>> into Tomcat 10 somehow so that if you try and deploy a Java EE 8 WAR it
> >>> gets automatically converted to a Jakarta EE 9 WAR.
> >>>
> >>
> >> It sounds doable with a special folder of the host (like a
> legacyAppBase),
> >> and it creates the result in the host's appBase. Like
> HostConfig.deployApps
> >> simply does this first, then moves down the usual deployments. I'm not
> sure
> >> that this is really useful though.
> >>
> >
> > Does it sound stupid to make the library a ClassFileTransformer added on
> > the webapp classloader? Sounds the most hurtless for users even if it
> will
> > adds a small overhead (and avoids a lot of file duplication which can be
> > harder to maintain at some point).
>
> It doesn't sound stupid at all. It was one of the options considered
> when we first started thinking about this. That was before we had the
> current implementation. With the experience of what the current
> implementation looks like we might want to revisit that discussion.
>
> My own thinking was to convert appBase/javaee.war to
> appBase/javaee##converted.war and let the parallel deployment code take
> care of deploying just the updated version.
>

Hmm, there are env the parallel deployment has pitfalls and it assumes the
not converted app would work no?


>
> Doing conversion on the fly or at deployment/start-up time raises
> various issues that boil down to "How do we detect if conversion is
> required?" and "What are the performance impacts of doing so?". There
> are users who want to squeeze every last drop of performance out of the
> system so I think that leads to some sort of configuration option.
>

Using a transformer it can be configured in context.xml so sounds "easy"
(requires to move to static constant to field instances but nothing crazy).
In terms of performances it is acceptable for such apps - don't forget we
often add javaagents doing potentially worse + JPA adds a transformer
already visiting all classes most of the time. That said a config with some
jar exclusions would be welcomed to only include a few jars.


>
> Just thinking about that I thought of:
> - watch what classes are requested
> - as soon as javax.servlet.* (or one of the others is detected) stop the
>   context, enable conversion and restart the context


> Then I thought that apps might try to determine if they are running on
> Java EE or Jakarta EE by trying to load classes. That could incorrectly
> trigger the conversion.
>
> Hmm. Anything apart from an explicitly user set flag starts to look
> potentially tricky for some use cases.
>
> Thoughts?
>

That's why the transformer looked handy from my window: it is configurable
and easy - we must keep in mind these cases will be rare, the move to
jakarta is not for tomorrow IMHO and when it will come it will be all at
once per spec or not.


>
> Mark
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE

[Mark Thomas]

On 10/12/2020 14:52, Romain Manni-Bucau wrote:
> Le jeu. 10 déc. 2020 à 15:49, Rémy Maucherat  a écrit :
>> On Thu, Dec 10, 2020 at 3:13 PM Mark Thomas  wrote:
>>> On 10/12/2020 13:58, Christopher Schultz wrote:



 Since this is a developer tool and not a runtime library or anything
 like that, maybe we can just say "YMMV, this is available any time you
 want it"?
>>>
>>> It could be a runtime library. One possibility is that we integrate it
>>> into Tomcat 10 somehow so that if you try and deploy a Java EE 8 WAR it
>>> gets automatically converted to a Jakarta EE 9 WAR.
>>>
>>
>> It sounds doable with a special folder of the host (like a legacyAppBase),
>> and it creates the result in the host's appBase. Like HostConfig.deployApps
>> simply does this first, then moves down the usual deployments. I'm not sure
>> that this is really useful though.
>>
> 
> Does it sound stupid to make the library a ClassFileTransformer added on
> the webapp classloader? Sounds the most hurtless for users even if it will
> adds a small overhead (and avoids a lot of file duplication which can be
> harder to maintain at some point).

It doesn't sound stupid at all. It was one of the options considered
when we first started thinking about this. That was before we had the
current implementation. With the experience of what the current
implementation looks like we might want to revisit that discussion.

My own thinking was to convert appBase/javaee.war to
appBase/javaee##converted.war and let the parallel deployment code take
care of deploying just the updated version.

Doing conversion on the fly or at deployment/start-up time raises
various issues that boil down to "How do we detect if conversion is
required?" and "What are the performance impacts of doing so?". There
are users who want to squeeze every last drop of performance out of the
system so I think that leads to some sort of configuration option.

Just thinking about that I thought of:
- watch what classes are requested
- as soon as javax.servlet.* (or one of the others is detected) stop the
  context, enable conversion and restart the context

Then I thought that apps might try to determine if they are running on
Java EE or Jakarta EE by trying to load classes. That could incorrectly
trigger the conversion.

Hmm. Anything apart from an explicitly user set flag starts to look
potentially tricky for some use cases.

Thoughts?

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE

[Romain Manni-Bucau]

Le jeu. 10 déc. 2020 à 15:49, Rémy Maucherat  a écrit :

> On Thu, Dec 10, 2020 at 3:13 PM Mark Thomas  wrote:
>
> > On 10/12/2020 13:58, Christopher Schultz wrote:
> > > Mark,
> > >
> > > On 12/10/20 06:39, Mark Thomas wrote:
> > >> The proposed Apache Tomcat migration tool for Jakarta EE 0.1.0 is now
> > >> available for voting.
> > >>
> > >> This is (potentially) the first release.
> > >>
> > >> It can be obtained from:
> > >>
> >
> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v0.1.0/
> > >>
> > >> The Maven staging repo is:
> > >>
> > https://repository.apache.org/content/repositories/orgapachetomcat-1291/
> > >>
> > >> The tag is:
> > >> https://github.com/apache/tomcat-jakartaee-migration/tree/0.1.0
> > >> cbada3204bf9c43ca0cf481cd88c7521690b30a0
> > >>
> > >> The proposed 0.1.0 release is:
> > >>
> > >> [ ] -1: Broken. Do not release because...
> > >> [ ] +1: Acceptable. Go ahead and release.
> > >
> > > Do we even need (a) a release and (b) a VOTE?
> >
> > If we want a release, we MUST have a VOTE.
> >
> > > I once heard Ross say that there was an ASP project (Subversion?) that
> > > never had votes; they only had releases. That seemed to cut-down on the
> > > red-tape required to get things out into the world. I can't find a
> > > reference for that, now.
> >
> > That doesn't sound right. From memory, Subversion doesn't have votes for
> > new committers but PMC membership and releases require a VOTE.
> >
> > > Since this is a developer tool and not a runtime library or anything
> > > like that, maybe we can just say "YMMV, this is available any time you
> > > want it"?
> >
> > It could be a runtime library. One possibility is that we integrate it
> > into Tomcat 10 somehow so that if you try and deploy a Java EE 8 WAR it
> > gets automatically converted to a Jakarta EE 9 WAR.
> >
>
> It sounds doable with a special folder of the host (like a legacyAppBase),
> and it creates the result in the host's appBase. Like HostConfig.deployApps
> simply does this first, then moves down the usual deployments. I'm not sure
> that this is really useful though.
>

Does it sound stupid to make the library a ClassFileTransformer added on
the webapp classloader? Sounds the most hurtless for users even if it will
adds a small overhead (and avoids a lot of file duplication which can be
harder to maintain at some point).


>
> Rémy
>
>
> >
> > > That said, I have no objections whatsoever with holding a vote. I am an
> > > unsigned "0" on the vote itself; I have not even downloaded the source
> > > let alone attempted to migrate a project using it.
> >
> > Fair enough.
> >
> > I think the naming of some of the artefacts could be improved. As this
> > is the first ever release I'm leaning towards cancelling / voting
> > against to get them fixed so all releases will (hopefully) use a
> > consistent naming convention rather it changing after the first release.
> >
> > Mark
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
> >
>

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE

[Rémy Maucherat]

On Thu, Dec 10, 2020 at 3:13 PM Mark Thomas  wrote:

> On 10/12/2020 13:58, Christopher Schultz wrote:
> > Mark,
> >
> > On 12/10/20 06:39, Mark Thomas wrote:
> >> The proposed Apache Tomcat migration tool for Jakarta EE 0.1.0 is now
> >> available for voting.
> >>
> >> This is (potentially) the first release.
> >>
> >> It can be obtained from:
> >>
> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v0.1.0/
> >>
> >> The Maven staging repo is:
> >>
> https://repository.apache.org/content/repositories/orgapachetomcat-1291/
> >>
> >> The tag is:
> >> https://github.com/apache/tomcat-jakartaee-migration/tree/0.1.0
> >> cbada3204bf9c43ca0cf481cd88c7521690b30a0
> >>
> >> The proposed 0.1.0 release is:
> >>
> >> [ ] -1: Broken. Do not release because...
> >> [ ] +1: Acceptable. Go ahead and release.
> >
> > Do we even need (a) a release and (b) a VOTE?
>
> If we want a release, we MUST have a VOTE.
>
> > I once heard Ross say that there was an ASP project (Subversion?) that
> > never had votes; they only had releases. That seemed to cut-down on the
> > red-tape required to get things out into the world. I can't find a
> > reference for that, now.
>
> That doesn't sound right. From memory, Subversion doesn't have votes for
> new committers but PMC membership and releases require a VOTE.
>
> > Since this is a developer tool and not a runtime library or anything
> > like that, maybe we can just say "YMMV, this is available any time you
> > want it"?
>
> It could be a runtime library. One possibility is that we integrate it
> into Tomcat 10 somehow so that if you try and deploy a Java EE 8 WAR it
> gets automatically converted to a Jakarta EE 9 WAR.
>

It sounds doable with a special folder of the host (like a legacyAppBase),
and it creates the result in the host's appBase. Like HostConfig.deployApps
simply does this first, then moves down the usual deployments. I'm not sure
that this is really useful though.

Rémy


>
> > That said, I have no objections whatsoever with holding a vote. I am an
> > unsigned "0" on the vote itself; I have not even downloaded the source
> > let alone attempted to migrate a project using it.
>
> Fair enough.
>
> I think the naming of some of the artefacts could be improved. As this
> is the first ever release I'm leaning towards cancelling / voting
> against to get them fixed so all releases will (hopefully) use a
> consistent naming convention rather it changing after the first release.
>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE

[Mark Thomas]

On 10/12/2020 13:58, Christopher Schultz wrote:
> Mark,
> 
> On 12/10/20 06:39, Mark Thomas wrote:
>> The proposed Apache Tomcat migration tool for Jakarta EE 0.1.0 is now
>> available for voting.
>>
>> This is (potentially) the first release.
>>
>> It can be obtained from:
>> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v0.1.0/
>>
>> The Maven staging repo is:
>> https://repository.apache.org/content/repositories/orgapachetomcat-1291/
>>
>> The tag is:
>> https://github.com/apache/tomcat-jakartaee-migration/tree/0.1.0
>> cbada3204bf9c43ca0cf481cd88c7521690b30a0
>>
>> The proposed 0.1.0 release is:
>>
>> [ ] -1: Broken. Do not release because...
>> [ ] +1: Acceptable. Go ahead and release.
> 
> Do we even need (a) a release and (b) a VOTE?

If we want a release, we MUST have a VOTE.

> I once heard Ross say that there was an ASP project (Subversion?) that
> never had votes; they only had releases. That seemed to cut-down on the
> red-tape required to get things out into the world. I can't find a
> reference for that, now.

That doesn't sound right. From memory, Subversion doesn't have votes for
new committers but PMC membership and releases require a VOTE.

> Since this is a developer tool and not a runtime library or anything
> like that, maybe we can just say "YMMV, this is available any time you
> want it"?

It could be a runtime library. One possibility is that we integrate it
into Tomcat 10 somehow so that if you try and deploy a Java EE 8 WAR it
gets automatically converted to a Jakarta EE 9 WAR.

> That said, I have no objections whatsoever with holding a vote. I am an
> unsigned "0" on the vote itself; I have not even downloaded the source
> let alone attempted to migrate a project using it.

Fair enough.

I think the naming of some of the artefacts could be improved. As this
is the first ever release I'm leaning towards cancelling / voting
against to get them fixed so all releases will (hopefully) use a
consistent naming convention rather it changing after the first release.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE

[Christopher Schultz]

Mark,

On 12/10/20 06:39, Mark Thomas wrote:

The proposed Apache Tomcat migration tool for Jakarta EE 0.1.0 is now
available for voting.

This is (potentially) the first release.

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v0.1.0/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1291/

The tag is:
https://github.com/apache/tomcat-jakartaee-migration/tree/0.1.0
cbada3204bf9c43ca0cf481cd88c7521690b30a0

The proposed 0.1.0 release is:

[ ] -1: Broken. Do not release because...
[ ] +1: Acceptable. Go ahead and release.


Do we even need (a) a release and (b) a VOTE?

I once heard Ross say that there was an ASP project (Subversion?) that 
never had votes; they only had releases. That seemed to cut-down on the 
red-tape required to get things out into the world. I can't find a 
reference for that, now.


Since this is a developer tool and not a runtime library or anything 
like that, maybe we can just say "YMMV, this is available any time you 
want it"?


That said, I have no objections whatsoever with holding a vote. I am an 
unsigned "0" on the vote itself; I have not even downloaded the source 
let alone attempted to migrate a project using it.


-chris

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE

[Rémy Maucherat]

On Thu, Dec 10, 2020 at 12:39 PM Mark Thomas  wrote:

> The proposed Apache Tomcat migration tool for Jakarta EE 0.1.0 is now
> available for voting.
>
> This is (potentially) the first release.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v0.1.0/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1291/
>
> The tag is:
> https://github.com/apache/tomcat-jakartaee-migration/tree/0.1.0
> cbada3204bf9c43ca0cf481cd88c7521690b30a0
>
> The proposed 0.1.0 release is:
>
> [ ] -1: Broken. Do not release because...
> [X] +1: Acceptable. Go ahead and release.
>
> Very good IMO for a first release.

Rémy