Re: [VOTE] Release Apache Tomcat 8.5.37
On 12/12/2018 13:22, Mark Thomas wrote: > The proposed 8.5.37 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 8.5.37 Unit tests passed for NIO, NIO2 and APR/native on OSX, Linux and Windows with Tomcat Native 1.2.19 built with APR 1.6.5 and OpenSSL 1.1.1a Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.37
On 18/12/2018 00:03, Emmanuel Bourg wrote: > I've tested on Debian Sid with OpenJDK 11.0.1+13 and OpenSSL 1.1.1a, and > I've noticed two test failures in TestClientCertTls13 with the three > connectors. Is this expected? No. It looks like a fix to the tests didn't get back-ported correctly. I'll get that fixed. Only the tests should be affected so I'm not planning to re-roll the release. Mark > > Testcase: testClientCertPost took 0.77 sec > Caused an ERROR > Received fatal alert: protocol_version > javax.net.ssl.SSLHandshakeException: Received fatal alert: protocol_version > at java.base/sun.security.ssl.Alert.createSSLException(Alert.java:128) > at java.base/sun.security.ssl.Alert.createSSLException(Alert.java:117) > at > java.base/sun.security.ssl.TransportContext.fatal(TransportContext.java:308) > at > java.base/sun.security.ssl.Alert$AlertConsumer.consume(Alert.java:279) > at > java.base/sun.security.ssl.TransportContext.dispatch(TransportContext.java:181) > at > java.base/sun.security.ssl.SSLTransport.decode(SSLTransport.java:164) > at > java.base/sun.security.ssl.SSLSocketImpl.decode(SSLSocketImpl.java:1152) > at > java.base/sun.security.ssl.SSLSocketImpl.readHandshakeRecord(SSLSocketImpl.java:1063) > at > java.base/sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:402) > at > java.base/sun.net.www.protocol.https.HttpsClient.afterConnect(HttpsClient.java:567) > at > java.base/sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.connect(AbstractDelegateHttpsURLConnection.java:185) > at > java.base/sun.net.www.protocol.https.HttpsURLConnectionImpl.connect(HttpsURLConnectionImpl.java:163) > at > org.apache.catalina.startup.TomcatBaseTest.postUrl(TomcatBaseTest.java:782) > at > org.apache.catalina.startup.TomcatBaseTest.postUrl(TomcatBaseTest.java:748) > at > org.apache.catalina.startup.TomcatBaseTest.postUrl(TomcatBaseTest.java:722) > at > org.apache.tomcat.util.net.TestClientCertTls13.testClientCertPost(TestClientCertTls13.java:61) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > > Testcase: testClientCertGet took 0.038 sec > Caused an ERROR > Received fatal alert: protocol_version > javax.net.ssl.SSLHandshakeException: Received fatal alert: protocol_version > at java.base/sun.security.ssl.Alert.createSSLException(Alert.java:128) > at java.base/sun.security.ssl.Alert.createSSLException(Alert.java:117) > at > java.base/sun.security.ssl.TransportContext.fatal(TransportContext.java:308) > at > java.base/sun.security.ssl.Alert$AlertConsumer.consume(Alert.java:279) > at > java.base/sun.security.ssl.TransportContext.dispatch(TransportContext.java:181) > at > java.base/sun.security.ssl.SSLTransport.decode(SSLTransport.java:164) > at > java.base/sun.security.ssl.SSLSocketImpl.decode(SSLSocketImpl.java:1152) > at > java.base/sun.security.ssl.SSLSocketImpl.readHandshakeRecord(SSLSocketImpl.java:1063) > at > java.base/sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:402) > at > java.base/sun.net.www.protocol.https.HttpsClient.afterConnect(HttpsClient.java:567) > at > java.base/sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.connect(AbstractDelegateHttpsURLConnection.java:185) > at > java.base/sun.net.www.protocol.https.HttpsURLConnectionImpl.connect(HttpsURLConnectionImpl.java:163) > at > org.apache.catalina.startup.TomcatBaseTest.methodUrl(TomcatBaseTest.java:689) > at > org.apache.catalina.startup.TomcatBaseTest.methodUrl(TomcatBaseTest.java:663) > at > org.apache.catalina.startup.TomcatBaseTest.getUrl(TomcatBaseTest.java:657) > at > org.apache.catalina.startup.TomcatBaseTest.getUrl(TomcatBaseTest.java:651) > at > org.apache.catalina.startup.TomcatBaseTest.getUrl(TomcatBaseTest.java:636) > at > org.apache.catalina.startup.TomcatBaseTest.getUrl(TomcatBaseTest.java:630) > at > org.apache.tomcat.util.net.TestClientCertTls13.testClientCertGet(TestClientCertTls13.java:45) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands,
Re: [VOTE] Release Apache Tomcat 8.5.37
Le 12/12/2018 à 14:22, Mark Thomas a écrit : > The proposed Apache Tomcat 8.5.37 release is now available for voting. > > The major changes compared to the 8.5.35 release are: > > - Implement the requirements of section 8.2.2 2.c of the Servlet > specification and prevent a web application from deploying if it has > fragments with duplicate names and is configured to use relative > ordering of fragments. > > - The default Servlet no longer overrides a previously set content-type. > > - Update the packaged version of the Tomcat Native Library to 1.2.19 to > pick up the latest Windows binaries built with APR 1.6.5 and OpenSSL > 1.1.1a. > > Along with lots of other bug fixes and improvements. I've tested on Debian Sid with OpenJDK 11.0.1+13 and OpenSSL 1.1.1a, and I've noticed two test failures in TestClientCertTls13 with the three connectors. Is this expected? Testcase: testClientCertPost took 0.77 sec Caused an ERROR Received fatal alert: protocol_version javax.net.ssl.SSLHandshakeException: Received fatal alert: protocol_version at java.base/sun.security.ssl.Alert.createSSLException(Alert.java:128) at java.base/sun.security.ssl.Alert.createSSLException(Alert.java:117) at java.base/sun.security.ssl.TransportContext.fatal(TransportContext.java:308) at java.base/sun.security.ssl.Alert$AlertConsumer.consume(Alert.java:279) at java.base/sun.security.ssl.TransportContext.dispatch(TransportContext.java:181) at java.base/sun.security.ssl.SSLTransport.decode(SSLTransport.java:164) at java.base/sun.security.ssl.SSLSocketImpl.decode(SSLSocketImpl.java:1152) at java.base/sun.security.ssl.SSLSocketImpl.readHandshakeRecord(SSLSocketImpl.java:1063) at java.base/sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:402) at java.base/sun.net.www.protocol.https.HttpsClient.afterConnect(HttpsClient.java:567) at java.base/sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.connect(AbstractDelegateHttpsURLConnection.java:185) at java.base/sun.net.www.protocol.https.HttpsURLConnectionImpl.connect(HttpsURLConnectionImpl.java:163) at org.apache.catalina.startup.TomcatBaseTest.postUrl(TomcatBaseTest.java:782) at org.apache.catalina.startup.TomcatBaseTest.postUrl(TomcatBaseTest.java:748) at org.apache.catalina.startup.TomcatBaseTest.postUrl(TomcatBaseTest.java:722) at org.apache.tomcat.util.net.TestClientCertTls13.testClientCertPost(TestClientCertTls13.java:61) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) Testcase: testClientCertGet took 0.038 sec Caused an ERROR Received fatal alert: protocol_version javax.net.ssl.SSLHandshakeException: Received fatal alert: protocol_version at java.base/sun.security.ssl.Alert.createSSLException(Alert.java:128) at java.base/sun.security.ssl.Alert.createSSLException(Alert.java:117) at java.base/sun.security.ssl.TransportContext.fatal(TransportContext.java:308) at java.base/sun.security.ssl.Alert$AlertConsumer.consume(Alert.java:279) at java.base/sun.security.ssl.TransportContext.dispatch(TransportContext.java:181) at java.base/sun.security.ssl.SSLTransport.decode(SSLTransport.java:164) at java.base/sun.security.ssl.SSLSocketImpl.decode(SSLSocketImpl.java:1152) at java.base/sun.security.ssl.SSLSocketImpl.readHandshakeRecord(SSLSocketImpl.java:1063) at java.base/sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:402) at java.base/sun.net.www.protocol.https.HttpsClient.afterConnect(HttpsClient.java:567) at java.base/sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.connect(AbstractDelegateHttpsURLConnection.java:185) at java.base/sun.net.www.protocol.https.HttpsURLConnectionImpl.connect(HttpsURLConnectionImpl.java:163) at org.apache.catalina.startup.TomcatBaseTest.methodUrl(TomcatBaseTest.java:689) at org.apache.catalina.startup.TomcatBaseTest.methodUrl(TomcatBaseTest.java:663) at org.apache.catalina.startup.TomcatBaseTest.getUrl(TomcatBaseTest.java:657) at org.apache.catalina.startup.TomcatBaseTest.getUrl(TomcatBaseTest.java:651) at org.apache.catalina.startup.TomcatBaseTest.getUrl(TomcatBaseTest.java:636) at org.apache.catalina.startup.TomcatBaseTest.getUrl(TomcatBaseTest.java:630) at org.apache.tomcat.util.net.TestClientCertTls13.testClientCertGet(TestClientCertTls13.java:45) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at
Re: [VOTE] Release Apache Tomcat 8.5.37
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, Thanks for volunteering to RM this release. Sigs are correct. Unit test failure is environmental in nature. +1 to release STABLE 8.5.37 - -chris On 12/16/18 11:02, Christopher Schultz wrote: > All, > > On 12/12/18 08:22, Mark Thomas wrote: >> The proposed Apache Tomcat 8.5.37 release is now available for >> voting. > >> The major changes compared to the 8.5.35 release are: > >> - Implement the requirements of section 8.2.2 2.c of the Servlet >> specification and prevent a web application from deploying if >> it has fragments with duplicate names and is configured to use >> relative ordering of fragments. > >> - The default Servlet no longer overrides a previously set >> content-type. > >> - Update the packaged version of the Tomcat Native Library to >> 1.2.19 to pick up the latest Windows binaries built with APR >> 1.6.5 and OpenSSL 1.1.1a. > >> Along with lots of other bug fixes and improvements. > >> It can be obtained from: >> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.37/ >> The Maven staging repo is: >> https://repository.apache.org/content/repositories/orgapachetomcat-12 0 > >> 1/ > > > The svn tag is: >> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_37/ > >> The proposed 8.5.37 release is: [ ] Broken - do not release [ ] >> Stable - go ahead and release as 8.5.37 > > I've got a signature problem with the Windows installer (see > below). Everything else seems okay. I'll hold my +1 until we sort > that out. > > Works with a standard servlet application. > > Details: > > * Environment * Java (build): java version "1.8.0_181" > Java(TM) SE Runtime Environment (build 1.8.0_181-b13) Java > HotSpot(TM) 64-Bit Server VM (build 25.181-b13, mixed mode) * Java > (test): java version "1.8.0_181" Java(TM) SE Runtime > Environment (build 1.8.0_181-b13) Java HotSpot(TM) 64-Bit Server > VM (build 25.181-b13, mixed mode) * OS: Linux 2.6.32-312-ec2 > x86_64 * cc: cc (Debian 4.7.2-5) 4.7.2 * make: GNU Make > 3.81 * OpenSSL: OpenSSL 1.1.1 11 Sep 2018 * APR: 1.4.6 * > Valid SHA-2512 signature for apache-tomcat-8.5.37.zip * Valid GPG > signature for apache-tomcat-8.5.37.zip * Valid SHA-512 signature > for apache-tomcat-8.5.37.tar.gz * Valid GPG signature for > apache-tomcat-8.5.37.tar.gz * !! Invalid SHA-256 signature for > apache-tomcat-8.5.37.exe > > Hmm. The SHA512 sig I get is: > > 0d0ed883f57e85d334450a27c5104b17f4a99156eeba9ebf81ea8a0b3a56d021b990b0 0b > > 7c289163c9b3478e00d54935f0b65d6df9de04d05ba9b3f0ce2437cc > > The sig file says: > > 2ef46708f1d04561481ba23dca78a13eaf32cfe0e5c681e58353cc08f446f627da29ef 18 > > 9794df2b38e9190886300e7a8dca69c604ad4f29d9d0871fc553 > > * !! Invalid GPG signature for apache-tomcat-8.5.37.exe > > $ gpg --verbose --keyring ./apache-keys --no-default-keyring > --verify apache-tomcat-8.5.37.exe.asc apache-tomcat-8.5.37.exe gpg: > Signature made Wed 12 Dec 2018 07:08:29 AM EST using RSA key ID > 2F6059E7 gpg: using PGP trust model gpg: BAD signature from "Mark E > D Thomas " gpg: binary signature, digest > algorithm SHA256 > > > I got a fresh copy from > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.37/bin/ > > and I'm getting the same errors on that file. > > * Valid SHA512 signature for apache-tomcat-8.5.37-src.zip * Valid > GPG signature for apache-tomcat-8.5.37-src.zip * Valid SHA512 > signature for apache-tomcat-8.5.37-src.tar.gz * Valid GPG signature > for apache-tomcat-8.5.37-src.tar.gz * Binary Zip and tarball: Same > * Source Zip and tarball: Same * Building dependencies returned: 0 > * tcnative builds cleanly * Tomcat builds cleanly * Junit Tests: > FAILED * Tests that failed: * > org.apache.catalina.session.TestStandardSessionIntegration.NIO.txt > > I get this error in the above test: > > 14-Dec-2018 17:06:54.042 SEVERE [main] > org.apache.catalina.tribes.transport.nio.NioReceiver.start Unable > to start cluster receiver java.net.BindException: Cannot assign > requested address at sun.nio.ch.Net.bind0(Native Method) at > sun.nio.ch.Net.bind(Net.java:433) at > sun.nio.ch.Net.bind(Net.java:425) at > sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:2 23 > > ) > at > sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74) at > sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:67) > at > org.apache.catalina.tribes.transport.ReceiverBase.bind(ReceiverBase.ja va > > :205) > > > I'm not sure what address is being attempted there, but this could > be an environmental issue. Historically, I've had issues with > Tribes integration tests, though I have far fewer of them these > days. I used to think it was because of lack of multicast, but it > appears that multicast is indeed enabled. > > Re-running the test again also fails. Any ideas for what to look > for? > > -chris > > - > >
Re: [VOTE] Release Apache Tomcat 8.5.37
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 12/17/18 11:37, Mark Thomas wrote: > On 17/12/2018 16:21, Christopher Schultz wrote: > > > >> 16-Dec-2018 11:01:04.189 INFO [main] >> org.apache.catalina.tribes.transport.ReceiverBase.bind Unable to >> bind server socket to:[/:4099] throwing error. >> 16-Dec-2018 11:01:04.190 SEVERE [main] >> org.apache.catalina.tribes.transport.nio.NioReceiver.start Unable >> to start cluster receiver java.net.BindException: Cannot assign >> requested address at sun.nio.ch.Net.bind0(Native Method) [...] >> >> Is that / before the IP address correct? > > Yes. Looking at the toString() implementation it is: > > > > and is the empty string if the host name is unknown. > >> The IP address is an IP address that can be used >> to reach this EC2 instance (where I'm running the testing), but >> it's not an IP address held by the actual VM, so that's probably >> the problem. Is there a way to force the "localhost" IP address >> for these tests? It needs to be 10.something. > > That sounds like an explicit setter needs to be added to the unit > test although I haven't dug into exactly what/where. Okay. This unit test does not represent a general problem, then. I'll reply separately with my vote. - -chris -BEGIN PGP SIGNATURE- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlwX1sQACgkQHPApP6U8 pFi6Dw//SHy7ZNVGDtAU8OnF3yFGsfaK/0Kf/be5ozlbRUmyYCE5RJLN14MdzKtf YUGhpHP31IolatYSVHmhR3unLa3dd7UXM0fqMmZ22XL2Zf8TRHjhvIpa5St/1PoK Kf3nR087TK+XRC5m3EdCgQ3DZJusgptVc2HHm+c1tpsD4l2PGr5vDeQBez3xCw4J jMqSyUSeY5SCEnDzG8nuXSapSUbDu4Z4nLXgazCu6hbhhCCcRsCrN0UwmcoA8916 XCHCDHZojLQUg8QLebc+/nODPtEQhntGY5sJKbs2Qatts4FUlmBD3zPdll13Xt4s 7WAp8Q0kMd/GUjwRVoiAcwsMnv2x8cNIh6BPlqrSE87mkN67twQA0Q/Kk41l+3xx uMf94091KqcDUq5Vnk12ZOjx8ndOpBt/uOAPa36EPJHF0yjNike7BcNX+im0HXuY VnJqRIjWNK2SBGuFyHJYBfLCQlQU+bwr/d9oMzqeiD0O+Fpxm/0AhKtNZrt6CLjS p9LSVd+CROJ6pIls3bqUSTBEDJba12L2D9cBMvi1DPtKHRJQT4Mu/YfoHYzKjx4u Y1TOf/qPMF6BKlUw+yNSBZJHLzXkvEZj9V9LqjX80umb34J7gqL85DWwwf9KfYQG 66YfjTrgrBcxtpUoYCnboRU10C2Fnx8l3UzRHqsWgjlmwXi6g5c= =1mNB -END PGP SIGNATURE- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.37
On 17/12/2018 16:21, Christopher Schultz wrote: > 16-Dec-2018 11:01:04.189 INFO [main] > org.apache.catalina.tribes.transport.ReceiverBase.bind Unable to bind > server socket to:[/:4099] throwing error. > 16-Dec-2018 11:01:04.190 SEVERE [main] > org.apache.catalina.tribes.transport.nio.NioReceiver.start Unable to > start cluster receiver > java.net.BindException: Cannot assign requested address > at sun.nio.ch.Net.bind0(Native Method) > [...] > > Is that / before the IP address correct? Yes. Looking at the toString() implementation it is: and is the empty string if the host name is unknown. > The IP address is an IP address that can be used to > reach this EC2 instance (where I'm running the testing), but it's not > an IP address held by the actual VM, so that's probably the problem. > Is there a way to force the "localhost" IP address for these tests? It > needs to be 10.something. That sounds like an explicit setter needs to be added to the unit test although I haven't dug into exactly what/where. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.37
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 12/17/18 05:49, Mark Thomas wrote: > On 16/12/2018 16:02, Christopher Schultz wrote: > > > >> I've got a signature problem with the Windows installer (see >> below). Everything else seems okay. I'll hold my +1 until we sort >> that out. > > Ah. That is probably my fault. I managed to kill the release build > after it had completed the Windows installer signing so, rather > than incrementing the version number and starting again (you can't > sign the same version twice), I opted to call each of the remaining > targets manually. I'm guessing I missed the part of the script that > re-generates the GPG sig and hashes for the window installer after > the installer had been signed for Windows. > > I keep the build directory structure for a release until I do the > next release in case of issues like this so I'll take a look. > > [snip] > > Looking at the timestamps, I failed to update that hash and sig. > Should be fixed now. Sigs look good, now: $ gpg --verbose --keyring ./apache-keys --no-default-keyring --verify apache-tomcat-8.5.37.exe.asc apache-tomcat-8.5.37.exe gpg: armor header: Comment: GPGTools - http://gpgtools.org gpg: Signature made Mon 17 Dec 2018 05:35:51 AM EST using RSA key ID 2F6059E7 gpg: using PGP trust model gpg: Good signature from "Mark E D Thomas " gpg: WARNING: This key is not certified with a trusted signature! gpg: There is no indication that the signature belongs to the owner. Primary key fingerprint: A9C5 DF4D 22E9 9998 D987 5A51 10C0 1C5A 2F60 59E7 gpg: binary signature, digest algorithm SHA512 $ sha512sum -c apache-tomcat-8.5.37.exe.sha512 apache-tomcat-8.5.37.exe: OK >> * Junit Tests: FAILED * Tests that failed: * >> org.apache.catalina.session.TestStandardSessionIntegration.NIO.txt >> >> >> I get this error in the above test: >> >> 14-Dec-2018 17:06:54.042 SEVERE [main] >> org.apache.catalina.tribes.transport.nio.NioReceiver.start Unable >> to start cluster receiver java.net.BindException: Cannot assign >> requested address at sun.nio.ch.Net.bind0(Native Method) at >> sun.nio.ch.Net.bind(Net.java:433) at >> sun.nio.ch.Net.bind(Net.java:425) at >> sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java: 223 >> >> ) >> at >> sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74) >> at >> sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:67) >> at >> org.apache.catalina.tribes.transport.ReceiverBase.bind(ReceiverBase.j ava >> >> :205) >> >> >> I'm not sure what address is being attempted there, but this >> could be an environmental issue. Historically, I've had issues >> with Tribes integration tests, though I have far fewer of them >> these days. I used to think it was because of lack of multicast, >> but it appears that multicast is indeed enabled. >> >> Re-running the test again also fails. Any ideas for what to look >> for? > > There should be a log message that includes the address - I think > before the exception you quote above. That might provide some > clues. Testsuite: org.apache.catalina.session.TestStandardSessionIntegration Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.415 se c - - Standard Error - 16-Dec-2018 11:01:02.983 INFO [main] org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case [testBug56578a] 16-Dec-2018 11:01:03.895 INFO [main] org.apache.coyote.AbstractProtocol.init Initializing ProtocolHandler ["http-nio-127.0.0.1-auto-1"] 16-Dec-2018 11:01:03.935 INFO [main] org.apache.tomcat.util.net.NioSelectorPool.getSharedSelector Using a shared selector for servlet write/read 16-Dec-2018 11:01:03.970 INFO [main] org.apache.catalina.core.StandardService.startInternal Starting service [Tomcat] 16-Dec-2018 11:01:03.970 INFO [main] org.apache.catalina.core.StandardEngine.startInternal Starting Servlet Engine: Apache Tomcat/8.5.37 16-Dec-2018 11:01:03.990 INFO [main] org.apache.catalina.ha.tcp.SimpleTcpCluster.startInternal Cluster is about to start 16-Dec-2018 11:01:04.189 INFO [main] org.apache.catalina.tribes.transport.ReceiverBase.bind Unable to bind server socket to:[/:4099] throwing error. 16-Dec-2018 11:01:04.190 SEVERE [main] org.apache.catalina.tribes.transport.nio.NioReceiver.start Unable to start cluster receiver java.net.BindException: Cannot assign requested address at sun.nio.ch.Net.bind0(Native Method) [...] Is that / before the IP address correct? The IP address is an IP address that can be used to reach this EC2 instance (where I'm running the testing), but it's not an IP address held by the actual VM, so that's probably the problem. Is there a way to force the "localhost" IP address for these tests? It needs to be 10.something. - -chris -BEGIN PGP SIGNATURE- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlwXzPcACgkQHPApP6U8
Re: [VOTE] Release Apache Tomcat 8.5.37
On 16/12/2018 16:02, Christopher Schultz wrote: > I've got a signature problem with the Windows installer (see below). > Everything else seems okay. I'll hold my +1 until we sort that out. Ah. That is probably my fault. I managed to kill the release build after it had completed the Windows installer signing so, rather than incrementing the version number and starting again (you can't sign the same version twice), I opted to call each of the remaining targets manually. I'm guessing I missed the part of the script that re-generates the GPG sig and hashes for the window installer after the installer had been signed for Windows. I keep the build directory structure for a release until I do the next release in case of issues like this so I'll take a look. > Works with a standard servlet application. > > Details: > > * Environment > * Java (build): java version "1.8.0_181" Java(TM) SE Runtime > Environment (build 1.8.0_181-b13) Java HotSpot(TM) 64-Bit Server VM > (build 25.181-b13, mixed mode) > * Java (test): java version "1.8.0_181" Java(TM) SE Runtime > Environment (build 1.8.0_181-b13) Java HotSpot(TM) 64-Bit Server VM > (build 25.181-b13, mixed mode) > * OS: Linux 2.6.32-312-ec2 x86_64 > * cc: cc (Debian 4.7.2-5) 4.7.2 > * make: GNU Make 3.81 > * OpenSSL: OpenSSL 1.1.1 11 Sep 2018 > * APR: 1.4.6 > * Valid SHA-2512 signature for apache-tomcat-8.5.37.zip > * Valid GPG signature for apache-tomcat-8.5.37.zip > * Valid SHA-512 signature for apache-tomcat-8.5.37.tar.gz > * Valid GPG signature for apache-tomcat-8.5.37.tar.gz > * !! Invalid SHA-256 signature for apache-tomcat-8.5.37.exe > > Hmm. The SHA512 sig I get is: > > 0d0ed883f57e85d334450a27c5104b17f4a99156eeba9ebf81ea8a0b3a56d021b990b00b > 7c289163c9b3478e00d54935f0b65d6df9de04d05ba9b3f0ce2437cc > > The sig file says: > > 2ef46708f1d04561481ba23dca78a13eaf32cfe0e5c681e58353cc08f446f627da29ef18 > 9794df2b38e9190886300e7a8dca69c604ad4f29d9d0871fc553 > > * !! Invalid GPG signature for apache-tomcat-8.5.37.exe > > $ gpg --verbose --keyring ./apache-keys --no-default-keyring --verify > apache-tomcat-8.5.37.exe.asc apache-tomcat-8.5.37.exe > gpg: Signature made Wed 12 Dec 2018 07:08:29 AM EST using RSA key ID > 2F6059E7 > gpg: using PGP trust model > gpg: BAD signature from "Mark E D Thomas " > gpg: binary signature, digest algorithm SHA256 > > > I got a fresh copy from > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.37/bin/ > and I'm getting the same errors on that file. Looking at the timestamps, I failed to update that hash and sig. Should be fixed now. > * Junit Tests: FAILED > * Tests that failed: > * org.apache.catalina.session.TestStandardSessionIntegration.NIO.txt > > I get this error in the above test: > > 14-Dec-2018 17:06:54.042 SEVERE [main] > org.apache.catalina.tribes.transport.nio.NioReceiver.start Unable to > start cluster receiver > java.net.BindException: Cannot assign requested address > at sun.nio.ch.Net.bind0(Native Method) > at sun.nio.ch.Net.bind(Net.java:433) > at sun.nio.ch.Net.bind(Net.java:425) > at > sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:223 > ) > at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74) > at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:67) > at > org.apache.catalina.tribes.transport.ReceiverBase.bind(ReceiverBase.java > :205) > > > I'm not sure what address is being attempted there, but this could be > an environmental issue. Historically, I've had issues with Tribes > integration tests, though I have far fewer of them these days. I used > to think it was because of lack of multicast, but it appears that > multicast is indeed enabled. > > Re-running the test again also fails. Any ideas for what to look for? There should be a log message that includes the address - I think before the exception you quote above. That might provide some clues. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.37
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, On 12/12/18 08:22, Mark Thomas wrote: > The proposed Apache Tomcat 8.5.37 release is now available for > voting. > > The major changes compared to the 8.5.35 release are: > > - Implement the requirements of section 8.2.2 2.c of the Servlet > specification and prevent a web application from deploying if it > has fragments with duplicate names and is configured to use > relative ordering of fragments. > > - The default Servlet no longer overrides a previously set > content-type. > > - Update the packaged version of the Tomcat Native Library to > 1.2.19 to pick up the latest Windows binaries built with APR 1.6.5 > and OpenSSL 1.1.1a. > > Along with lots of other bug fixes and improvements. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.37/ The > Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-120 1/ > > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_37/ > > The proposed 8.5.37 release is: [ ] Broken - do not release [ ] > Stable - go ahead and release as 8.5.37 I've got a signature problem with the Windows installer (see below). Everything else seems okay. I'll hold my +1 until we sort that out. Works with a standard servlet application. Details: * Environment * Java (build): java version "1.8.0_181" Java(TM) SE Runtime Environment (build 1.8.0_181-b13) Java HotSpot(TM) 64-Bit Server VM (build 25.181-b13, mixed mode) * Java (test): java version "1.8.0_181" Java(TM) SE Runtime Environment (build 1.8.0_181-b13) Java HotSpot(TM) 64-Bit Server VM (build 25.181-b13, mixed mode) * OS: Linux 2.6.32-312-ec2 x86_64 * cc: cc (Debian 4.7.2-5) 4.7.2 * make: GNU Make 3.81 * OpenSSL: OpenSSL 1.1.1 11 Sep 2018 * APR: 1.4.6 * Valid SHA-2512 signature for apache-tomcat-8.5.37.zip * Valid GPG signature for apache-tomcat-8.5.37.zip * Valid SHA-512 signature for apache-tomcat-8.5.37.tar.gz * Valid GPG signature for apache-tomcat-8.5.37.tar.gz * !! Invalid SHA-256 signature for apache-tomcat-8.5.37.exe Hmm. The SHA512 sig I get is: 0d0ed883f57e85d334450a27c5104b17f4a99156eeba9ebf81ea8a0b3a56d021b990b00b 7c289163c9b3478e00d54935f0b65d6df9de04d05ba9b3f0ce2437cc The sig file says: 2ef46708f1d04561481ba23dca78a13eaf32cfe0e5c681e58353cc08f446f627da29ef18 9794df2b38e9190886300e7a8dca69c604ad4f29d9d0871fc553 * !! Invalid GPG signature for apache-tomcat-8.5.37.exe $ gpg --verbose --keyring ./apache-keys --no-default-keyring --verify apache-tomcat-8.5.37.exe.asc apache-tomcat-8.5.37.exe gpg: Signature made Wed 12 Dec 2018 07:08:29 AM EST using RSA key ID 2F6059E7 gpg: using PGP trust model gpg: BAD signature from "Mark E D Thomas " gpg: binary signature, digest algorithm SHA256 I got a fresh copy from https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.37/bin/ and I'm getting the same errors on that file. * Valid SHA512 signature for apache-tomcat-8.5.37-src.zip * Valid GPG signature for apache-tomcat-8.5.37-src.zip * Valid SHA512 signature for apache-tomcat-8.5.37-src.tar.gz * Valid GPG signature for apache-tomcat-8.5.37-src.tar.gz * Binary Zip and tarball: Same * Source Zip and tarball: Same * Building dependencies returned: 0 * tcnative builds cleanly * Tomcat builds cleanly * Junit Tests: FAILED * Tests that failed: * org.apache.catalina.session.TestStandardSessionIntegration.NIO.txt I get this error in the above test: 14-Dec-2018 17:06:54.042 SEVERE [main] org.apache.catalina.tribes.transport.nio.NioReceiver.start Unable to start cluster receiver java.net.BindException: Cannot assign requested address at sun.nio.ch.Net.bind0(Native Method) at sun.nio.ch.Net.bind(Net.java:433) at sun.nio.ch.Net.bind(Net.java:425) at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:223 ) at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74) at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:67) at org.apache.catalina.tribes.transport.ReceiverBase.bind(ReceiverBase.java :205) I'm not sure what address is being attempted there, but this could be an environmental issue. Historically, I've had issues with Tribes integration tests, though I have far fewer of them these days. I used to think it was because of lack of multicast, but it appears that multicast is indeed enabled. Re-running the test again also fails. Any ideas for what to look for? - -chris -BEGIN PGP SIGNATURE- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlwWdzAACgkQHPApP6U8 pFi+fhAApxuYxAWI9ZPA9/GKy9FRhkUkL7XYdVNW4S5/vbhtqFHQMRdHyoqaGJTC EeEovsKNLU+P5detYgMZEbPfWhXGdRWpN7jRnZbpH9EBqpgascisv1Qw4bewRNQL 8986n/0jf91ydbYjvTVZABtgpW+4HUv7glZ1e/H5UK46m7mzTNSLEafVOvEnhrqS QxyKgsx+kTHFE4hmFp33wIuunQcbb8iZa+SRwdV3p9PzvIaPV44Rm7BDoBDvYD/G
Re: [VOTE] Release Apache Tomcat 8.5.37
Am 12.12.18 um 14:22 schrieb Mark Thomas: The proposed Apache Tomcat 8.5.37 release is now available for voting. The major changes compared to the 8.5.35 release are: - Implement the requirements of section 8.2.2 2.c of the Servlet specification and prevent a web application from deploying if it has fragments with duplicate names and is configured to use relative ordering of fragments. - The default Servlet no longer overrides a previously set content-type. - Update the packaged version of the Tomcat Native Library to 1.2.19 to pick up the latest Windows binaries built with APR 1.6.5 and OpenSSL 1.1.1a. Along with lots of other bug fixes and improvements. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.37/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1201/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_37/ The proposed 8.5.37 release is: [ ] Broken - do not release [x] Stable - go ahead and release as 8.5.37 Regards, Felix - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.37
On Wed, Dec 12, 2018 at 5:23 AM Mark Thomas wrote: > The proposed Apache Tomcat 8.5.37 release is now available for voting. > > The major changes compared to the 8.5.35 release are: > > - Implement the requirements of section 8.2.2 2.c of the Servlet > specification and prevent a web application from deploying if it has > fragments with duplicate names and is configured to use relative > ordering of fragments. > > - The default Servlet no longer overrides a previously set content-type. > > - Update the packaged version of the Tomcat Native Library to 1.2.19 to > pick up the latest Windows binaries built with APR 1.6.5 and OpenSSL > 1.1.1a. > > Along with lots of other bug fixes and improvements. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.37/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1201/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_37/ > > The proposed 8.5.37 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 8.5.37 > Tested on Windows 10 with no errors Tested on Fedora 28 and got SSL cipher errors but I always get those so doesn't look like regression.