[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...

[corneadoug]

Github user corneadoug commented on the issue:

https://github.com/apache/zeppelin/pull/1210
  
@mwpenny With the way we include the css, there is still a risk of not 
being able to get the css, but having the JS file just fine.
Which end up in the map not showing, and no error message like the one we 
added in case there is no internet connection. I actually got that a few times 
with slow internet.

Except for that, LGTM, awesome work!
if anybody wants to try it, I use the test case of #765 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1321: [BUILD][HOTFIX] Add -DskipTests property to reduce bui...

[minahlee]

Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1321
  
Merge if there is no more discussion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1193: [ZEPPELIN-1192] Block pyspark paragraph hang.

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1193
  
@astroshim great! Small suggestion above. And what is with CI here? May be 
it's worth to `git rebase master` and force push?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1321: [BUILD][HOTFIX] Add -DskipTests property to reduce bui...

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1321
  
Looks great to me @minahlee !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1248
  
Thanks! In my experience, if in case of CI failure PR author posts the 
failure result from logs - that speeds us review a lot!

CI fails now on Spark 1.6 Scala 2.10 and Scala 2.11 profiles with

```
[INFO] Zeppelin: web Application .. FAILURE [01:31 
min]
[INFO] make: Leaving directory 
`/home/travis/build/apache/zeppelin/zeppelin-web/node_modules/karma/node_modules/socket.io/node_modules/socket.io-client/node_modules/ws/build'
[ERROR] npm ERR! Linux 3.13.0-40-generic
[ERROR] npm ERR! argv 
"/home/travis/build/apache/zeppelin/zeppelin-web/node/node" 
"/home/travis/build/apache/zeppelin/zeppelin-web/node/node_modules/npm/bin/npm-cli.js"
 "install" "--color=false"
[ERROR] npm ERR! node v0.12.13
[ERROR] npm ERR! npm  v2.15.0
[ERROR] npm ERR! code ECONNRESET
[ERROR] npm ERR! errno ECONNRESET
[ERROR] npm ERR! syscall read
[ERROR] 
[ERROR] npm ERR! network read ECONNRESET
[ERROR] npm ERR! network This is most likely not a problem with npm itself
[ERROR] npm ERR! network and is related to network connectivity.
[ERROR] npm ERR! network In most cases you are behind a proxy or have bad 
network settings.
[ERROR] npm ERR! network 
[ERROR] npm ERR! network If you are behind a proxy, please make sure that 
the
[ERROR] npm ERR! network 'proxy' config is set properly.  See: 'npm help 
config'
```

Which seems to be networking issue on Travis side 😒 

Thank you @mwkang , looks great to me, merging to master if there is no 
further discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1254: [ZEPPELIN-1257] storage - fix get note revision api

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1254
  
@khalidhuseynov `git rebase master` to re-trigger CI? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1318: [ZEPPELIN-1280][Spark on Yarn] Documents for running z...

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1318
  
Docs looks great to me, thank you @astroshim !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1314: [MINOR] Update outdated contents in zeppelin-distribut...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1314
  
merging if no more comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1318: [ZEPPELIN-1280][Spark on Yarn] Documents for running z...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1318
  
cool. hadoop versions in distributions:
CDH: 2.6.0
HDP/Azure: 2.7.1
EMR: 2.7.2
GCP Dataproc: 2.7.2



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1322: [ZEPPELIN-1320] Security fix for Shell/Spark and Pytho...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1322
  
shouldn't interpreter process be impersonating the user logging onto the 
web front end?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1264: Updated path to point to latest Maven binaries

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1264


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...

[mwpenny]

Github user mwpenny commented on the issue:

https://github.com/apache/zeppelin/pull/1210
  
@corneadoug I'm all to familiar with that magic when trying to reproduce 
bugs ;)

I've made the changes.

* __Small popup:__ The side and bottom margins of the popup are present due 
to yesterday's changes (differentiating the white of the popup from the white 
of the paragraph) and the extra-large top margin is from Esri's CSS. After 
decreasing the top margin the popup is still very cluttered but a bit more 
usable.

![zeppelin13](https://cloud.githubusercontent.com/assets/9356790/17601232/0d439994-5fd5-11e6-89fa-bd8fbb64d960.png)
Even with some extra CSS styling, I just don't think there's enough space 
to display the popup nicely in a paragraph that small. Other graph modes have a 
similar problem which users are likely already accustomed to:

![zeppelin14](https://cloud.githubusercontent.com/assets/9356790/17601551/b36a6ff4-5fd6-11e6-99af-858f4eb72347.png)



* __Internet error message:__ I went with a look similar to the other graph 
modes:

![zeppelin12](https://cloud.githubusercontent.com/assets/9356790/17600368/2353e076-5fd1-11e6-8d29-20ca4001c169.png)

* __Lazy loading:__ Similar to the way esriLoader loads the map JavaScript, 
the CSS is now lazy loaded the first time it is needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1322) zeppelin.ssl.truststore is getting configured to keystore by default if truststore is empty

[Kshitij Badani (JIRA)]

Kshitij Badani created ZEPPELIN-1322:


 Summary: zeppelin.ssl.truststore is getting configured to keystore 
by default if truststore is empty
 Key: ZEPPELIN-1322
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1322
 Project: Zeppelin
  Issue Type: Bug
  Components: zeppelin-server
Affects Versions: 0.6.0
Reporter: Kshitij Badani
Priority: Critical
 Fix For: 0.6.0


Currently if user does not pass any value in zeppelin.ssl.truststore, then it 
gets configured to keystore by default. 

Zeppelin should by default not assume both to be the same in case truststore is 
not specified. In this case, Zeppelin must throw an error mentioning 
trust-store file missing.
 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ZEPPELIN-1321) Zeppelin HTTP and HTTPS port should be managed seperately

[Yesha Vora (JIRA)]

Yesha Vora created ZEPPELIN-1321:


 Summary: Zeppelin HTTP and HTTPS port should be managed seperately
 Key: ZEPPELIN-1321
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1321
 Project: Zeppelin
  Issue Type: Bug
  Components: zeppelin-server
Reporter: Yesha Vora


Currently, Zeppelin's default http and https port are same which is not 
recommended.

Https ports are considered to be secure ports. and are always different than 
http port.

Thus, we recommend to change default port of Zeppelin to other than 9995 when 
SSL is enabled.

It will be good if can be managed by two seperate configuration. 
(zeppelin.http.port and zeppelin.https.port)





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin pull request #1254: [ZEPPELIN-1257] storage - fix get note revision...

[khalidhuseynov]

GitHub user khalidhuseynov reopened a pull request:

https://github.com/apache/zeppelin/pull/1254

[ZEPPELIN-1257] storage - fix get note revision api

### What is this PR for?
Getting revision of note requires only unique revision id and the whole 
revision object isn't required. This PR is to fix the issue.


### What type of PR is it?
Bug Fix | Improvement

### Todos
* [x] - change storage api
* [x] - modify notebook server

### What is the Jira issue?
[ZEPPELIN-1257](https://issues.apache.org/jira/browse/ZEPPELIN-1257)

### How should this be tested?
Storage layer tests should pass, green CI

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/khalidhuseynov/incubator-zeppelin 
fix/get-note-revision-api

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1254.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1254


commit 96490a29295221a2dbc8f8bac50b5f87cf9bb847
Author: Khalid Huseynov 
Date:   2016-07-31T07:15:08Z

change api Revision -> String (revision id)

commit 3b7868e254bfe338755ebf4a9de8a71ac49db8b8
Author: Khalid Huseynov 
Date:   2016-07-31T07:31:39Z

change Revision -> String in NotebookServer

commit 1bab6a4c9b3bbca958c540c6c6cfd4e012504270
Author: Khalid Huseynov 
Date:   2016-07-31T07:37:46Z

consistency check: NotebookRepo.Revision -> Revision

commit f14c15afb59da0e2c7bdab0cd443653276cdbbfc
Author: Khalid Huseynov 
Date:   2016-08-01T04:59:16Z

fix tests




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1304: [ZEPPELIN-1190] [WIP] Visit Notebook Revision

[khalidhuseynov]

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/1304
  
@bzz exactly, that's the point i was trying to make in #1254. 
@anthonycorbacho i'm completely agree with you, and that was the original 
starting premise. 
I'm happy that everyone got the point now! I'll reopen and rebase #1254 
then.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1322: [ZEPPELIN-1320] Security fix for Shell/Spark an...

[prabhjyotsingh]

GitHub user prabhjyotsingh opened a pull request:

https://github.com/apache/zeppelin/pull/1322

[ZEPPELIN-1320] Security fix for Shell/Spark and Python Interpreter

### What is this PR for?
While running a Notebook using shell, spark, python uses same user as which 
zeppelin server is running. Which means these interprets have same permission 
on file system as zeppelin server.
IMO user should have option to run these interpreters as different user.

### What type of PR is it?
[Improvement]

### Todos
* [ ] - Update doc

### What is the Jira issue?
* [ZEPPELIN-1320](https://issues.apache.org/jira/browse/ZEPPELIN-1320)

### How should this be tested?
 - Add an user in system say "zeppelin-interpreter"
 - Add ssh key for the same
```
ssh-keygen
ssh zeppelin-interpreter@localhost mkdir -p .ssh
cat ~/.ssh/id_rsa.pub | ssh zeppelin-interpreter@localhost 'cat >> 
.ssh/authorized_keys'
```
 - Add `export ZEPPELIN_INTERPRETER_USER="zeppelin-interpreter"` in  
`zeppelin-env.sh` 
 - Start zeppelin server, try and run following in paragraph in a notebook

```
%sh
whoami
```

Check that it should run as new user, i.e. "zeppelin-interpreter"

### Screenshots (if appropriate)

https://cloud.githubusercontent.com/assets/674497/17593747/8c9eb096-6004-11e6-8487-3e44a1a0d6eb.png;>



### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? yes



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-1320

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1322.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1322


commit 6aafac445db4cd8944caa07280fcdbebb2faea0f
Author: Prabhjyot Singh 
Date:   2016-08-11T15:08:12Z

user should have option to run these interpreters as different user.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1320: [ZEPPELIN-1287][branch-0.6] No need to call pri...

[minahlee]

GitHub user minahlee reopened a pull request:

https://github.com/apache/zeppelin/pull/1320

[ZEPPELIN-1287][branch-0.6] No need to call print to display output in 
PythonInterpreter

### What is this PR for?
Implement #1278 to merge branch-0.6

### What type of PR is it?
Bug Fix

### What is the Jira issue?
[ZEPPELIN-1287](https://issues.apache.org/jira/browse/ZEPPELIN-1287)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/minahlee/zeppelin branch-0.6_ZEPPELIN-1287

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1320.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1320


commit ac83b14d880b1b6fa2586349cb4d69c7f8c1db2e
Author: Mina Lee 
Date:   2016-08-11T13:30:11Z

No need to call print to display output in PythonInterpreter




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1320: [ZEPPELIN-1287][branch-0.6] No need to call pri...

[minahlee]

Github user minahlee closed the pull request at:

https://github.com/apache/zeppelin/pull/1320


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1321: [BUILD][HOTFIX] Add -DskipTests property to red...

[minahlee]

GitHub user minahlee opened a pull request:

https://github.com/apache/zeppelin/pull/1321

[BUILD][HOTFIX] Add -DskipTests property to reduce build time

### What is this PR for?
In `dev/publish_release.sh` there are two mvn build. Second build fails 
with follow error:
```
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-antrun-plugin:1.7:run (start-zeppelin) on 
project zeppelin-server: An Ant BuildException has occured: The directory 
/private/tmp/zeppelin-release/zeppelin/zeppelin-server/${zeppelin.daemon.package.base}
 does not exist
[ERROR] around Ant part .. @ 
4:94 in 
/private/tmp/zeppelin-release/zeppelin/zeppelin-server/target/antrun/build-main.xml
```

This PR skip tests to fix this issue as hotfix

### What type of PR is it?
Build

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/minahlee/zeppelin build_skipTests

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1321.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1321


commit c1aa8456d5d2f274bee1d66e29308065eb3d65e4
Author: Mina Lee 
Date:   2016-08-11T14:17:48Z

Add -DskipTests property to reduce build time




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

[mwkang]

Github user mwkang commented on the issue:

https://github.com/apache/zeppelin/pull/1248
  
@bzz Thanks for your review. I rebase on to master and force push.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1304: [ZEPPELIN-1190] [WIP] Visit Notebook Revision

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1304
  
@corneadoug thank you for explaining!

So we are talking about WS API to fetch full notebook state from the 
history by it's revision? Wich on client-side looks like 
[websocketMsgSrv.getNoteRevision($routeParams.noteId, 
$routeParams.revisionId);](https://github.com/apache/zeppelin/blob/3bd94ddc77ef9f9853ae978bf024d206378f16ba/zeppelin-web/src/components/websocketEvents/websocketMsg.service.js#L175)

And on the back-end is a 
[NOTE_REVISION](https://github.com/apache/zeppelin/blob/36a7e38ffd6af614ad770a6e23ec1fd98a90c809/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java#L239)
 event in `NotebookServer`.

@khalidhuseynov I think first of all, there is a bit of confusion here: 
this event is handled by
`getNoteRevision` which looks more like `getNoteByRevision` because 
`Revision`, as discussed before, just represents the reference to the point in 
time, knowing which a full Note can be obtained, as it was back then. So 
`getNoteRevision` may be interpreted as a getter for Revision, rather than the 
Note.

Then, it makes perfect sense to change the 
[Notebook.getNoteRevision()](https://github.com/apache/zeppelin/blob/5cdc02d3651fc8f5b7f9aa81f1d617007932b666/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java#L366)
 API, both, function name AND a signature, as that is the place where actual 
work of retrieving the Note is done, to something like:

```java
getNoteByRevisionId(String noteId, String revisionId, AuthenticationInfo 
subject)
```

And this necessity, that comes from API client, at least for me, is an 
overriding argument in our discussion: you were right and we should adjust 
[NotebookRepo.get](https://github.com/apache/zeppelin/pull/1254/files#diff-eea417ea15b9480afaf52ebe1f51449dR92)
 interface and follow your design from #1254 (and close #1277).

What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1294: Change maven version from 3.3.3 to 3.3.9 at vagrant sc...

[minahlee]

Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1294
  
Merge if there is no more discussion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1320: [ZEPPELIN-1287][branch-0.6] No need to call pri...

[minahlee]

GitHub user minahlee reopened a pull request:

https://github.com/apache/zeppelin/pull/1320

[ZEPPELIN-1287][branch-0.6] No need to call print to display output in 
PythonInterpreter

### What is this PR for?
Implement #1278 to merge branch-0.6

### What type of PR is it?
Bug Fix

### What is the Jira issue?
[ZEPPELIN-1287](https://issues.apache.org/jira/browse/ZEPPELIN-1287)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/minahlee/zeppelin branch-0.6_ZEPPELIN-1287

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1320.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1320


commit ac83b14d880b1b6fa2586349cb4d69c7f8c1db2e
Author: Mina Lee 
Date:   2016-08-11T13:30:11Z

No need to call print to display output in PythonInterpreter




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1264: Updated path to point to latest Maven binaries

[minahlee]

Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1264
  
Merge if there is no more discussion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1248
  
This looks like an issue fixed in master 10h ago:

```
- should provide onclick method *** FAILED ***
  The code passed to eventually never returned normally. Attempted 1 
times over 231.694296 milliseconds. Last failure message: 0 was not equal to 1. 
(AbstractAngularElemTest.scala:72)
```

Could you please try rebasing on latest master `git pull ; git rebase 
master; git push -f` ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1320: [ZEPPELIN-1287][branch-0.6] No need to call print to d...

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1320
  
@minahlee I think we also need to set appropriate "fix for" versions in 
JIRA before merging #1278  otherwise it will be very hard for you, as release 
manager to figure out changelog and attributions may get lost.

I have updated current one to both `0.7.0` for master and `0.6.1` for 
branch-0.6

LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1301: [MINOR] Removed unused profiles from spark/pom.xml

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1301
  
Thank you for explanation! Makes sense.

Looks great to me.

May be it's worth to `git rebase master` as CI seems to be recently fixed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1320: [ZEPPELIN-1287][branch-0.6] No need to call print to d...

[minahlee]

Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1320
  
\cc @zjffdu for review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1320: [ZEPPELIN-1287][branch-0.6] No need to call pri...

[minahlee]

GitHub user minahlee opened a pull request:

https://github.com/apache/zeppelin/pull/1320

[ZEPPELIN-1287][branch-0.6] No need to call print to display output in 
PythonInterpreter

### What is this PR for?
Implement #1278 to merge branch-0.6

### What type of PR is it?
Bug Fix

### What is the Jira issue?
[ZEPPELIN-1287](https://issues.apache.org/jira/browse/ZEPPELIN-1287)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/minahlee/zeppelin branch-0.6_ZEPPELIN-1287

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1320.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1320


commit ac83b14d880b1b6fa2586349cb4d69c7f8c1db2e
Author: Mina Lee 
Date:   2016-08-11T13:30:11Z

No need to call print to display output in PythonInterpreter




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1257: [Zeppelin-945] Interpreter authorization

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1257
  
@astroshim your changes look awesome to me!

There is one more improvement on Java side noted above, other than that - 
looks good to merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1193: [ZEPPELIN-1192] Block pyspark paragraph hang.

[astroshim]

Github user astroshim commented on the issue:

https://github.com/apache/zeppelin/pull/1193
  
@bzz I added log and tested. Thank you for taking care of this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1319: ZEPPELIN-1319 Use absolute path for ssl truststore and...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/1319
  
Good catch, LGTM!

CI failure looks unrelated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1318: [ZEPPELIN-1280][Spark on Yarn] Documents for running z...

[astroshim]

Github user astroshim commented on the issue:

https://github.com/apache/zeppelin/pull/1318
  
Spark2.0 & hadoop2.3 is working well.

![image](https://cloud.githubusercontent.com/assets/3348133/17588549/d611d7ca-600a-11e6-87f6-4a692fbae273.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1319: ZEPPELIN-1319 Use absolute path for ssl trustst...

[r-kamath]

GitHub user r-kamath opened a pull request:

https://github.com/apache/zeppelin/pull/1319

ZEPPELIN-1319 Use absolute path for ssl truststore and keystore when 
available

### What is this PR for?
Use absolute path for ssl truststore and keystore when available

### What type of PR is it?
Improvement

### Todos
* [ ] - Task

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1319

### How should this be tested?
Config `zeppelin.ssl.truststore.path`, `zeppelin.ssl.keystore.path` and 
verify whether the absolute path or the path relative to conf is used.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? n/a
* Is there breaking changes for older versions? n/a
* Does this needs documentation? n/a


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/r-kamath/zeppelin ZEPPELIN-1319

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1319.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1319


commit fc2ac9f01e7712a8519b4b618f8b32d6d2be4390
Author: Renjith Kamath 
Date:   2016-08-11T11:58:53Z

ZEPPELIN-1319 Use absolute path for ssl truststore and keystore when 
available




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1319) Use absolute path for ssl truststore and keystore when available

[Renjith Kamath (JIRA)]

Renjith Kamath created ZEPPELIN-1319:


 Summary: Use absolute path for ssl truststore and keystore when 
available
 Key: ZEPPELIN-1319
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1319
 Project: Zeppelin
  Issue Type: Bug
Reporter: Renjith Kamath
Assignee: Renjith Kamath






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin issue #1193: [ZEPPELIN-1192] Block pyspark paragraph hang.

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1193
  
Looks great to me, modulo the timeout logging issue noted about.

@astroshim plz ping when it's addressed and I'll be happy to merge it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1168: [MINOR] Add formatter

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1168
  
Got it. Let's may be change PR title to WIP or even may be close it for now 
but keep the branch and create a dedicated JIRA issue and link this work there? 

It's a bigger effort that we initially think, so we can add sub-tasts like  
 - InteliJ formatter
 - Eclipse formatter
 - Build time check of the code conventions to conform our styleguide

One problem that I can see though - it will be not very useful commit, 
retrofitting whole codebase to the styleguilde: it will touch all the files in 
the project and just re-formatting it. This complicates navigating the history 
of changes and makes 'git blame' less useful.

What would be great if we could provide consistent formatters for IDEs 
first, advise everyone to use them AND then make mandatory style checks ONLY 
for the new code.

I think this should be possible! I can look into that.

But we still need 2 consistent formatters.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1311: [ZEPPELIN-1316] Zeppelin can not start due to an incor...

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1311
  
Thank you for prompt review!

Merging _to master_ if there is no further discussion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1318: [ZEPPELIN-1280][Spark on Yarn] Documents for running z...

[astroshim]

Github user astroshim commented on the issue:

https://github.com/apache/zeppelin/pull/1318
  
Do you know what version of spark is popular? I will test it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1265
  
@jongyoul  Does that mean the login user is the process owner ? Because it 
matters for security reason. 
e.g. 
* For spark interpreter, it would be better to launch the yarn app as the 
user who login in zeppelin.  
* For shell interpreter, it would be better to launch the shell as the user 
who login in zeppelin. Otherwise it is pretty dangerous. The user can delete 
all the files owner by others. 
 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1265
  
@jongyoul this looks very interesting! Could you plz help me to understand 
- does this changes mean for Zeepelin to run a new separate interpreter process 
for every user and schedulle only his jobs to be executed there? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1310: Apply new mechanism to HbaseInterpreter

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/1310
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1318: [ZEPPELIN-1280][Spark on Yarn] Documents for running z...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1318
  
It's hard to say - I think one approach would be latest (spark 2.0 & Hadoop 
2.7); another approach would be the most popular ones




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1278: ZEPPELIN-1287. No need to call print to display...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1278


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1303: ZEPPELIN-1308 Apache Ignite version upgraded up...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1303


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1218: [Zeppelin-1213] Customize editor configuration

[cloverhearts]

Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/1218
  
@bzz Okay!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...

[corneadoug]

Github user corneadoug commented on the issue:

https://github.com/apache/zeppelin/pull/1210
  
@mwpenny latest changes I promise haha

If you resize the paragraph to the smallest height allowed, the popup is 
crushed and unusable, however there is plenty of space on top and bottom of the 
popup, maybe we could try to reduce it.
We can't support every width and height, but lets see if we can do 
something for that case
![screen shot 2016-08-11 at 4 16 07 
pm](https://cloud.githubusercontent.com/assets/710411/17582155/0776e77c-5fe5-11e6-8066-9e76063140dc.png)

If you don't have internet, it would be nice to show a small error message 
instead of the map
![screen shot 2016-08-11 at 4 19 48 
pm](https://cloud.githubusercontent.com/assets/710411/17582134/e521efb4-5fe4-11e6-9a14-b170ea8c3b7c.png)

Also without internet, the app takes a good 20-30seconds to load/show (even 
home page).
It is due to the page try to load the esri CSS from online.
I think this 
[plugin](https://github.com/GabrielDelepine/angular-css-injector) could help 
with that problem.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1314: [MINOR] Update outdated contents in zeppelin-distribut...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1314
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1316: [ZEPPELIN-1118] Migrate Zeppelin Live Demo feature fro...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1316
  
It would probably be a good idea to have a click-through terms of service.
Should we also display the zeppelin version?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1310: Apply new mechanism to HbaseInterpreter

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1310
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1317: [HOTFIX] Bring zeppelin-display back to depende...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1317


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1283: Buffer append output results + fix extra incorrect res...

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1283
  
I've a few comment on your comments. Please check it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1317: [HOTFIX] Bring zeppelin-display back to dependency of ...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1317
  
Merge it into master and branch-0.6 as a hotfix


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1315: [ZEPPELIN-530] Added changes for Credential Provider, ...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/1315
  
Thank you @rconline for taking care of this. LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #681: Notebook Authorization

[qinzl1]

Github user qinzl1 commented on the issue:

https://github.com/apache/zeppelin/pull/681
  
thanks  @AhyoungRyu 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---