[GitHub] zeppelin issue #1536: [Zeppelin 796] Duplicated notebook names should not be...
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1536 Any updates ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1536: [Zeppelin 796] Duplicated notebook names should not be...
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1536 Now i have resolved the conflicts. Please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1536: [Zeppelin 796] Duplicated notebook names should not be...
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1536 Ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1536: [Zeppelin 796] Duplicated notebook names should not be...
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1536 @All : Please review this PR and let me know your comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1536: [Zeppelin 796] Duplicated notebook names should not be...
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1536 @anthonycorbacho : For import note function too, we will have same problem as i pointed out first. Anyway for import note too, any user can give a new name for importing notebook --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1536: [Zeppelin 796] Duplicated notebook names should not be...
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1536 @anthonycorbacho : Lets say if i create a note with name 'Note'. If zeppelin allows me to create a new note with name 'Note', then after sometime when i search for one of this note, I am going to get confused here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1464: [Zeppelin 796] Duplicated notebook names should not be...
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1464 Hi All, An unknown commit got merged into this PR. I just had this issue while rebasing. I am going to open new PR for the same.So, Closing this PR . Please continue the discussion in the new PR https://github.com/apache/zeppelin/pull/1536 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1464: [Zeppelin 796] Duplicated notebook names should...
Github user rajarajan-g closed the pull request at: https://github.com/apache/zeppelin/pull/1464 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1536: [Zeppelin 796] Duplicated notebook names should...
GitHub user rajarajan-g opened a pull request: https://github.com/apache/zeppelin/pull/1536 [Zeppelin 796] Duplicated notebook names should not be allowed What is this PR for? When a notebook is created/cloned/imported the title/name of the new notebook should not be duplicate of the existing notebook's title/name What type of PR is it? Improvement Todos - Task What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-796 How should this be tested? Create a notebook with name 'Note', Notebook should allow user to create a note When a user try to create/clone/import a notebook with name 'Note', Notebook should not allow user to create note. Screenshots (if appropriate) Screenshot of error message displayed during create/clone notebook  Screenshot of error message displayed during import notebook  Questions: Does the licenses files need update? No Is there breaking changes for older versions? No Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajarajan-g/zeppelin Z-796 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1536.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1536 commit 9ec319f3cd0a43d5f532d3e2037f35d659f2254d Author: rajarajan-g Date: 2016-10-18T05:35:47Z code changes for ZEPPELIN-796 commit 3b4ae2c929e6c579ac3f16a6f5aaba76b7231cc7 Author: rajarajan-g Date: 2016-10-18T06:38:16Z format changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1524: [ZEPPELIN-1542] Cleanup of Note created during ...
GitHub user rajarajan-g reopened a pull request: https://github.com/apache/zeppelin/pull/1524 [ZEPPELIN-1542] Cleanup of Note created during jUnit test in zeppelin-server, zeppelin-zengine ### What is this PR for? While running jUnit tests in zeppelin-server & zeppelin-zengine projects, several note are created during the process and those notes are never purged after the execution of the tests. ### What type of PR is it? Bug Fix ### Todos ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1542 ### How should this be tested? Prerequisites: 1. Get the list of note that already exist in server. Now build zeppelin project by running maven commands(mvn clean package)(mvn clean package -pl 'zeppelin-interpreter,zeppelin-zengine,zeppelin-server'). 1. Now no extra note should get created after running the maven command ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajarajan-g/zeppelin ZEPPELIN-1542 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1524.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1524 commit d97cb4a8530b253665240453dccaa112d137b451 Author: rajarajan-g Date: 2016-10-14T09:01:12Z code changes for ZEPPELIN-1542 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1524: [ZEPPELIN-1542] Cleanup of Note created during jUnit t...
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1524 Reopening the PR to trigger CI build --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1524: [ZEPPELIN-1542] Cleanup of Note created during ...
Github user rajarajan-g closed the pull request at: https://github.com/apache/zeppelin/pull/1524 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1467: [ZEPPELIN-1488] JDBC Interpreter throws error while th...
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1467 ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1524: [ZEPPELIN-1542] Cleanup of Note created during ...
GitHub user rajarajan-g opened a pull request: https://github.com/apache/zeppelin/pull/1524 [ZEPPELIN-1542] Cleanup of Note created during jUnit test in zeppelin-server, zeppelin-zengine ### What is this PR for? While running jUnit tests in zeppelin-server & zeppelin-zengine projects, several note are created during the process and those notes are never purged after the execution of the tests. ### What type of PR is it? Bug Fix ### Todos ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1542 ### How should this be tested? Prerequisites: 1. Get the list of note that already exist in server. Now build zeppelin project by running maven commands(mvn clean package)(mvn clean package -pl 'zeppelin-interpreter,zeppelin-zengine,zeppelin-server'). 1. Now no extra note should get created after running the maven command ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajarajan-g/zeppelin ZEPPELIN-1542 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1524.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1524 commit d97cb4a8530b253665240453dccaa112d137b451 Author: rajarajan-g Date: 2016-10-14T09:01:12Z code changes for ZEPPELIN-1542 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (ZEPPELIN-1542) Cleanup of Note created during jUnit test in zeppelin-server, zeppelin-zengine
Rajarajan G created ZEPPELIN-1542: - Summary: Cleanup of Note created during jUnit test in zeppelin-server, zeppelin-zengine Key: ZEPPELIN-1542 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1542 Project: Zeppelin Issue Type: Test Components: Core Affects Versions: 0.6.1 Reporter: Rajarajan G Priority: Minor While running jUnit tests in zeppelin-server & zeppelin-zengine projects, several note are created during the process and those notes are never purged after the execution of the tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] zeppelin issue #1464: [Zeppelin 796] [WIP] Duplicated notebook names should ...
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1464 @corneadoug : If a user creates a note with same name, it would do no good to that user itself as it confuses him. For resolving the scenario, we can pick one of the below ways 1. we should have one unique notebook name across the server.(Not quite a solution) 2. we can follow unique notebook name per user in server. In case if a note is shared by the creator with other users, an extra information should be available to user like below in home page of notebook **NoteName** _**(created by user1)**_ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1464: [Zeppelin 796] [WIP] Duplicated notebook names should ...
Github user rajarajan-g commented on the issue:
https://github.com/apache/zeppelin/pull/1464
@jongyoul : Hey i was quite busy for sometime.
I was trying to resolve the commit issues that you have pointed out.
but while during rebase i am getting below error
```
git rebase master
First, rewinding head to replay your work on top of it...
Applying: Code changes for ZEPPELIN-796
Using index info to reconstruct a base tree...
M
zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
M zeppelin-web/src/components/noteName-create/notename.controller.js
M zeppelin-web/src/components/noteName-import/note-import-dialog.html
M zeppelin-web/src/components/noteName-import/notenameImport.controller.js
M zeppelin-web/src/components/websocketEvents/websocketEvents.factory.js
:18: trailing whitespace.
* @throws DuplicateNameException
:40: trailing whitespace.
* @throws DuplicateNameException
:98: trailing whitespace.
* @throws DuplicateNameException
:175: trailing whitespace.
:187: trailing whitespace.
conn.send(serializeMessage(new Message(OP.ERROR_DIALOG).put("info",
warning: squelched 21 whitespace errors
warning: 26 lines add whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging
zeppelin-web/src/components/websocketEvents/websocketEvents.factory.js
CONFLICT (content): Merge conflict in
zeppelin-web/src/components/websocketEvents/websocketEvents.factory.js
Auto-merging
zeppelin-web/src/components/noteName-import/notenameImport.controller.js
CONFLICT (content): Merge conflict in
zeppelin-web/src/components/noteName-import/notenameImport.controller.js
Auto-merging
zeppelin-web/src/components/noteName-import/note-import-dialog.html
Auto-merging
zeppelin-web/src/components/noteName-create/notename.controller.js
CONFLICT (content): Merge conflict in
zeppelin-web/src/components/noteName-create/notename.controller.js
Auto-merging
zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
Failed to merge in the changes.
Patch failed at 0001 Code changes for ZEPPELIN-796
The copy of the patch that failed is found in:
/home/rajarajang/Workspace/stsWorksapce/zeppelin/.git/rebase-apply/patch
When you have resolved this problem, run "git rebase --continue".
If you prefer to skip this patch, run "git rebase --skip" instead.
To check out the original branch and stop rebasing, run "git rebase
--abort".
```
Even though after i resolve the conflicts, again it shows conflict again
and not able to remove that unnecessary commit that you pointed out. Please
help me out on resolving that issue
Please let me know if anyone has faced this issue and also please let me if
there is a way to resolve this issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1467: [ZEPPELIN-1488] JDBC Interpreter throws error while th...
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1467 Oh. Its' ok. now i see your comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1467: [ZEPPELIN-1488] JDBC Interpreter throws error while th...
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1467 i didn't get the question. Can you please share it again ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1467: [ZEPPELIN-1488] JDBC Interpreter throws error while th...
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1467 Ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1464: [Zeppelin 796] [WIP] Duplicated notebook names should ...
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1464 @corneadoug : Nice catch. I didn't check that scenario. Will let you once, i figure out a way. Let me check the current implementation too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1464: [Zeppelin 796] [WIP] Duplicated notebook names should ...
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1464 @jongyoul : Thanks for noticing that. I didn't make those changes. Those changes seems to come from another commit. Need to check that --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1464: [Zeppelin 796] [WIP] Duplicated notebook names should ...
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1464 CI build is green & success. Please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1464: [Zeppelin 796] [WIP] Duplicated notebook names should ...
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1464 Going to reopen the pull request to trigger CI build --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1464: [Zeppelin 796] [WIP] Duplicated notebook names ...
Github user rajarajan-g closed the pull request at: https://github.com/apache/zeppelin/pull/1464 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1464: [Zeppelin 796] [WIP] Duplicated notebook names ...
GitHub user rajarajan-g reopened a pull request: https://github.com/apache/zeppelin/pull/1464 [Zeppelin 796] [WIP] Duplicated notebook names should not be allowed ### What is this PR for? When a notebook is created/cloned/imported the title/name of the new notebook should not be duplicate of the existing notebook's title/name ### What type of PR is it? Improvement ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-796 ### How should this be tested? 1. Create a notebook with name 'Note', Notebook should allow user to create a note 2. When a user try to create/clone/import a notebook with name 'Note', Notebook should not allow user to create note. ### Screenshots (if appropriate) Screenshot of error message displayed during create/clone notebook  Screenshot of error message displayed during import notebook  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajarajan-g/zeppelin ZEPPELIN-796 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1464.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1464 commit 2dec9d0b895df16c49e73b0bda5abef6457cc7bc Author: rajarajan-g Date: 2016-09-27T05:43:03Z Code changes for ZEPPELIN-796 commit ab04be9e0c2b6d211052a6c22c52b11a9942c866 Author: rajarajan-g Date: 2016-09-27T05:52:12Z Removed unnecessary statements commit 8ec520a509e3e3f1af255b6b1969aae91ad91217 Author: rajarajan-g Date: 2016-09-27T06:15:38Z code formatted commit 010f3e39f2162f489a34b3e34a36bdaf97425cd0 Author: rajarajan-g Date: 2016-09-27T06:53:56Z removed unnecessary statement commit e89090c521e7bf4a3f86eb9b42823726cd715aa1 Author: rajarajan-g Date: 2016-09-27T07:26:54Z fix for changes commit 2adbf7589cef4a318709b8e7ff76acd21187d9de Author: rajarajan-g Date: 2016-09-27T14:02:41Z code fix for Test commit c42711fc6701acbca08d9c9423a098e74c1744fc Author: rajarajan-g Date: 2016-09-28T08:47:03Z custom exception commit b24491bafa78693457687dd5da460d5e387e9ddb Author: astroshim Date: 2016-09-23T07:31:19Z [ZEPPELIN-1405] ConnectionPool for JDBCInterpreter. ### What is this PR for? This PR is for refactoring code for JDBCInterpreter. There is no putting 'Connection' to 'propertyKeyUnusedConnectionListMap' anywhere in the original code. ### What type of PR is it? Improvement ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1405 ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: astroshim Closes #1396 from astroshim/ZEPPELIN-1405 and squashes the following commits: b07e162 [astroshim] add checking connection is null f6998c2 [astroshim] Merge branch 'master' into ZEPPELIN-1405 1862ae6 [astroshim] Merge branch 'master' into ZEPPELIN-1405 efc2bfc [astroshim] rebase 21217a7 [astroshim] fix indentation. 4d4f85c [astroshim] refactoring code of close() 9f1e368 [astroshim] replace ConnectionPool 4dabbcc [astroshim] wip) changing to use dbcp 12dd7cb [astroshim] remove propertyKeyUnusedConnectionListMap map commit e1e54b5d2435c9078d2e9122385c5a5f5e6059c7 Author: rajarajan-g Date: 2016-09-28T15:12:01Z fixes for junit tests commit 1307a650451226df1937109116408bad0595eb97 Author: rajarajan-g Date: 2016-09-27T05:43:03Z Code changes for ZEPPELIN-796 commit 8911fe24509e197c6b6e4dcc65975cff047a7cef Author: rajarajan-g Date: 2016-09-27T05:52:12Z Removed unnecessary statements commit 20c14eef15d09aa98c17beeb4c59db829204fcf7 Author: rajarajan-g Date: 2016-09-27T06:15:38Z code formatted commit cc01966bd08945741154625b68027e58c47ca5fd Author: rajarajan-g Date: 2016-09-27T06:53:56Z removed unnecessary statement commit 512832f994f7802968f47e2150dc0a570e024e0e Author: rajarajan-g Date: 2016-09-27T07:26:54Z fix for changes commit 66925981e9014ec2b6c05b196289e9989f0e3403 Author: rajarajan-g Date: 2016-09-27T14:02:41Z code fix for Test commit aba85802689bb6bab889f753bbedfb312d0c4ab1 Author: rajarajan-g Date: 2016-09-28T08:47:03Z custom
[GitHub] zeppelin issue #1464: [Zeppelin 796] [WIP] Duplicated notebook names should ...
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1464 @khalidhuseynov : Lets say if i create a note with name 'Note'. If zeppelin allows me to create a new note with name 'Note', then after sometime when i search for one of this note, I am going to get confused here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1467: [ZEPPELIN-1488] JDBC Interpreter throws error while th...
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1467 CI build is green.Please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1467: [ZEPPELIN-1488] JDBC Interpreter throws error w...
GitHub user rajarajan-g opened a pull request: https://github.com/apache/zeppelin/pull/1467 [ZEPPELIN-1488] JDBC Interpreter throws error while the interpreter is downloading dependencies ### What is this PR for? For first time, when we add dependencies for JDBC interpreter, dependencies will start getting downloaded in background. During that time, if user runs a paragraph of JDBC interpreter now user getting error , But instead paragraph execution should be put on 'PENDING' state and wait for dependencies to get downloaded and then run the paragraph ### What type of PR is it? Bug Fix ### Todos ### What is the Jira issue? [ZEPPELIN-1488] https://issues.apache.org/jira/browse/ZEPPELIN-1488 ### How should this be tested? prerequisites: 1. Any DB setup.(For my testing, i considered hive) Steps: 1. Delete the local-repo folder under zeppelin project, if it exists 2. Go to interpreter settings page, provide hive connection details under JDBC interprepreter 3. For hive interpreter to run, it needs some dependencies to be added in interpreter settings page For hive below dependencies needs to added 1. org.apache.hive:hive-jdbc:0.14.0 2. org.apache.hadoop:hadoop-common:2.6.0 4. Once the settings for JDBC interpreter is saved, dependencies will start getting downloaded in background. 5. Run any paragraph with JDBC as interpreter, paragraph should not throw error, status of the paragraph should change to 'pending' while the dependencies are getting downloaded in background. 6. Once the downloading of dependencies is done, the paragraph which were in pending will start executing in order depending on the execution mode of the interpreter (i.e Shared, Scoped, Isolated) ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajarajan-g/zeppelin ZEPPELIN-1488 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1467.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1467 commit 4f7b9381713537a9e90e3cb1e90c128f2833be81 Author: rajarajan-g Date: 2016-09-27T15:17:02Z code fix for ZEPPELIN-1488 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1464: [Zeppelin 796] [WIP] Duplicated notebook names ...
GitHub user rajarajan-g opened a pull request: https://github.com/apache/zeppelin/pull/1464 [Zeppelin 796] [WIP] Duplicated notebook names should not be allowed ### What is this PR for? When a notebook is created/cloned/imported the title/name of the new notebook should not be duplicate of the existing notebook's title/name ### What type of PR is it? Improvement ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-796 ### How should this be tested? 1. Create a notebook with name 'Note', Notebook should allow user to create a note 2. When a user try to create/clone/import a notebook with name 'Note', Notebook should not allow user to create note. ### Screenshots (if appropriate) Screenshot of error message displayed during create/clone notebook  Screenshot of error message displayed during import notebook  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajarajan-g/zeppelin ZEPPELIN-796 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1464.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1464 commit 681c600cd96dbab8ffe9fb44e93524bfbaacf109 Author: rajarajan-g Date: 2016-09-27T05:43:03Z Code changes for ZEPPELIN-796 commit bfe7091902bb3e3c16fcf4b50322b7b2b6f9a2e0 Author: rajarajan-g Date: 2016-09-27T05:52:12Z Removed unnecessary statements commit 9071d2ae093f8fdfc1803e9a86f2234ee9eb78bf Author: rajarajan-g Date: 2016-09-27T06:15:38Z code formatted commit 055637f56deede4a4fa19c5bf31ff13880c827fe Author: rajarajan-g Date: 2016-09-27T06:53:56Z removed unnecessary statement commit a4dc418f6a89eaeca53775a7bf86a0868e440fb2 Author: rajarajan-g Date: 2016-09-27T07:26:54Z fix for changes commit 3991eceb93192536855d4550241951e23d5b57c3 Author: rajarajan-g Date: 2016-09-27T14:02:41Z code fix for Test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (ZEPPELIN-1488) JDBC Intrepreter throws error while the interpreter is downloading dependencies
Rajarajan G created ZEPPELIN-1488: - Summary: JDBC Intrepreter throws error while the interpreter is downloading dependencies Key: ZEPPELIN-1488 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1488 Project: Zeppelin Issue Type: Improvement Components: Interpreters Affects Versions: 0.6.0 Reporter: Rajarajan G -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] zeppelin issue #1399: [ZEPPELIN-1182] Zeppelin should have Startup and Shutd...
Github user rajarajan-g commented on the issue:
https://github.com/apache/zeppelin/pull/1399
It makes more sense to have message logged in ```${ZEPPELIN_OUTFILE}```
rather of ```${ZEPPELIN_LOGFILE}```.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1399: [ZEPPELIN-1182] Zeppelin should have Startup and Shutd...
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1399 Ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1399: [ZEPPELIN-1182] Zeppelin should have Startup and Shutd...
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1399 @all: Please do review and let me know your opnion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1399: [ZEPPELIN-1182] Zeppelin should have Startup and Shutd...
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1399 I am logging the configuration details of Zeppelin . I am not sure if we have any more configuration details to be logged. Please check PR and let me know if any more configuration needs to be added. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1399: [ZEPPELIN-1182] Zeppelin should have Startup an...
GitHub user rajarajan-g opened a pull request:
https://github.com/apache/zeppelin/pull/1399
[ZEPPELIN-1182] Zeppelin should have Startup and Shutdown message
### What is this PR for?
PR is for logging configuration details of Zeppelin server.
### What type of PR is it?
Improvement
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1182
### How should this be tested?
Please check the log if information on Server host, server path, context
path, zeppelin version, class path is available in that file.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Note:
For configuration details such as zeppelin version, server host, port
& context path , these are available as part of zeppelin configuration.
Logging information
```
INFO [2016-09-02 14:35:25,218] ({main}
ZeppelinConfiguration.java[create]:107) - Server Host: 0.0.0.0
INFO [2016-09-02 14:35:25,218] ({main}
ZeppelinConfiguration.java[create]:108) - Server Port: 8080
INFO [2016-09-02 14:35:25,218] ({main}
ZeppelinConfiguration.java[create]:109) - Context Path: /
INFO [2016-09-02 14:35:25,224] ({main}
ZeppelinConfiguration.java[create]:110) - Zeppelin Version: 0.7.0-SNAPSHOT
```
For Zeppelin class path and restart information, I am logging it from
Shell script to log file as in below paragraph, So the format of logging is
different . I know this is not per standards, Please let me know if you have
any suggestions
```
Zeppelin is restarted
ZEPPELIN_CLASSPATH:
/home/rajarajang/Workspace/stsWorksapce/zeppelin/zeppelin-server/target/lib/*:/home/rajarajang/Workspace/stsWorksapce/zeppelin/zeppelin-zengine/target/lib/*:/home/rajarajang/Workspace/stsWorksapce/zeppelin/zeppelin-interpreter/target/lib/*:/home/rajarajang/Workspace/stsWorksapce/zeppelin/*::/home/rajarajang/Workspace/stsWorksapce/zeppelin/conf:/home/rajarajang/Workspace/stsWorksapce/zeppelin/zeppelin-interpreter/target/classes:/home/rajarajang/Workspace/stsWorksapce/zeppelin/zeppelin-zengine/target/classes:/home/rajarajang/Workspace/stsWorksapce/zeppelin/zeppelin-server/target/classes
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rajarajan-g/zeppelin ZEPPELIN-1182
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1399.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1399
commit da69b165dfdd7c3911405ff84d824c9698fe31b0
Author: rajarajan-g
Date: 2016-09-02T09:21:03Z
Added log statements for configuration
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1367: [ZEPPELIN-1040] Show the time when the result i...
GitHub user rajarajan-g reopened a pull request: https://github.com/apache/zeppelin/pull/1367 [ZEPPELIN-1040] Show the time when the result is updated ### What is this PR for? As per existing usage, the time shown in end of each paragraph is the time the paragraph is updated not when the paragraph is actually executed/run. _" Took 10 sec. Last updated by anonymous at **August 26 2016, 1:52:01 PM.** "_ PR is aimed at changing the existing usage to show when the paragraph is last executed as this gives clarification to users about the executed time of paragraph ### What type of PR is it? Improvement ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1040 ### How should this be tested? 1. Start the server and create a new note book 2. create a new paragraph and execute the paragraph 3. Now rerun the paragraph, the time should get updated now inline with execution of the paragraph ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajarajan-g/zeppelin ZEPPELIN-1040 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1367.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1367 commit d30f1b28e3a7c3a3160a3eab7e6e30aa1f53083c Author: rajarajan-g Date: 2016-08-26T08:30:10Z code changed for showing last run time after execution of paragraph --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1367: [ZEPPELIN-1040] Show the time when the result i...
Github user rajarajan-g closed the pull request at: https://github.com/apache/zeppelin/pull/1367 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1367: [ZEPPELIN-1040] Show the time when the result i...
GitHub user rajarajan-g opened a pull request: https://github.com/apache/zeppelin/pull/1367 [ZEPPELIN-1040] Show the time when the result is updated ### What is this PR for? As per existing usage, the time shown in end of each paragraph is the time the paragraph is updated not when the paragraph is actually executed/run. _" Took 10 sec. Last updated by anonymous at **August 26 2016, 1:52:01 PM.** "_ PR is aimed at changing the existing usage to show when the paragraph is last executed as this gives clarification to users about the executed time of paragraph ### What type of PR is it? Improvement ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1040 ### How should this be tested? 1. Start the server and create a new note book 2. create a new paragraph and execute the paragraph 3. Now rerun the paragraph, the time should get updated now inline with execution of the paragraph ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajarajan-g/zeppelin ZEPPELIN-1040 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1367.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1367 commit d30f1b28e3a7c3a3160a3eab7e6e30aa1f53083c Author: rajarajan-g Date: 2016-08-26T08:30:10Z code changed for showing last run time after execution of paragraph --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1313: [ZEPPELIN-1245] Focus first paragraph after notebook c...
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1313 its 'thinktank' --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1341: [ZEPPELIN-1162] Fix rawType in NotebookRestApi
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1341 Please review this PR and let me your thoughts in comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1341: [ZEPPELIN-1162] Fix rawType in NotebookRestApi
Github user rajarajan-g closed the pull request at: https://github.com/apache/zeppelin/pull/1341 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1341: [ZEPPELIN-1162] Fix rawType in NotebookRestApi
GitHub user rajarajan-g reopened a pull request: https://github.com/apache/zeppelin/pull/1341 [ZEPPELIN-1162] Fix rawType in NotebookRestApi ### What is this PR for? Some HashSet is declared without types. Fix it in NotebookRestApi ### What type of PR is it? Refactoring ### Todos ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1162 ### How should this be tested? All existing test cases related to permissions ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajarajan-g/zeppelin ZEPPELIN-1162 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1341.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1341 commit 87b13f725deb7f76c0103a2666d2adde992e7a6e Author: rajarajan-g Date: 2016-08-18T09:25:52Z fix for rawtype --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1313: [ZEPPELIN-1245] Focus first paragraph after notebook c...
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1313 In my opinion, since the editor itself is not available, it shouldn't focus that paragraph which is also behaviour after this PR If you/other folks have any other opinions, please let me know. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1341: [ZEPPELIN-1162] Fix rawType in NotebookRestApi
GitHub user rajarajan-g reopened a pull request: https://github.com/apache/zeppelin/pull/1341 [ZEPPELIN-1162] Fix rawType in NotebookRestApi ### What is this PR for? Some HashSet is declared without types. Fix it in NotebookRestApi ### What type of PR is it? Refactoring ### Todos ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1162 ### How should this be tested? All existing test cases related to permissions ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajarajan-g/zeppelin ZEPPELIN-1162 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1341.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1341 commit 87b13f725deb7f76c0103a2666d2adde992e7a6e Author: rajarajan-g Date: 2016-08-18T09:25:52Z fix for rawtype --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1341: [ZEPPELIN-1162] Fix rawType in NotebookRestApi
Github user rajarajan-g closed the pull request at: https://github.com/apache/zeppelin/pull/1341 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1341: [ZEPPELIN-1162] Fix rawType in NotebookRestApi
Github user rajarajan-g closed the pull request at: https://github.com/apache/zeppelin/pull/1341 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1341: [ZEPPELIN-1162] Fix rawType in NotebookRestApi
GitHub user rajarajan-g reopened a pull request: https://github.com/apache/zeppelin/pull/1341 [ZEPPELIN-1162] Fix rawType in NotebookRestApi ### What is this PR for? Some HashSet is declared without types. Fix it in NotebookRestApi ### What type of PR is it? Refactoring ### Todos ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1162 ### How should this be tested? All existing test cases related to permissions ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajarajan-g/zeppelin ZEPPELIN-1162 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1341.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1341 commit 87b13f725deb7f76c0103a2666d2adde992e7a6e Author: rajarajan-g Date: 2016-08-18T09:25:52Z fix for rawtype --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1313: [ZEPPELIN-1245] Focus first paragraph after notebook c...
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1313 CI build is success now. Please do review and let me in know in comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1341: [ZEPPELIN-1162] Fix rawType in NotebookRestApi
GitHub user rajarajan-g opened a pull request: https://github.com/apache/zeppelin/pull/1341 [ZEPPELIN-1162] Fix rawType in NotebookRestApi ### What is this PR for? Some HashSet is declared without types. Fix it in NotebookRestApi ### What type of PR is it? Refactoring ### Todos ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1162 ### How should this be tested? All existing test cases related to permissions ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajarajan-g/zeppelin ZEPPELIN-1162 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1341.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1341 commit 87b13f725deb7f76c0103a2666d2adde992e7a6e Author: rajarajan-g Date: 2016-08-18T09:25:52Z fix for rawtype --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1313: [ZEPPELIN-1245] Focus first paragraph after notebook c...
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1313 Reopening the pull request to trigger CI build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1313: [ZEPPELIN-1245] Focus first paragraph after not...
GitHub user rajarajan-g reopened a pull request: https://github.com/apache/zeppelin/pull/1313 [ZEPPELIN-1245] Focus first paragraph after notebook creation ### What is this PR for? Once the notebook is created, cursor should focus on the first paragraph ### What type of PR is it? Bug Fix ### Todos * [ ] - None ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1245 ### How should this be tested? Once the Zeppelin server is started , Create a new notebook check if cursor blinks on the first paragraph of the notebook ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajarajan-g/zeppelin ZEPPELIN-1245 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1313.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1313 commit e14792702e9011238b6431204bcefd472355106d Author: rajarajan-g Date: 2016-08-10T08:41:12Z fix for ZEPPELIN-1245 commit 068cd0b85d56ef615f8915418c6aeefae1abbfc7 Author: rajarajan-g Date: 2016-08-12T06:19:13Z test case modified commit 85794e9e79265e02bdd7d92b904768fff02d4551 Author: rajarajan-g Date: 2016-08-17T14:44:01Z code modified as per review comments commit 8eb7b32a6339d740524f1678066a4c74add058de Author: rajarajan-g Date: 2016-08-17T15:08:03Z test case changed to check the default behaviour --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1313: [ZEPPELIN-1245] Focus first paragraph after not...
Github user rajarajan-g closed the pull request at: https://github.com/apache/zeppelin/pull/1313 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1313: [ZEPPELIN-1245] Focus first paragraph after notebook c...
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1313 @Leemoonsoo : Thanks for reviewing the code I did check the existing behaviour , for existing note it doesn't focus to any paragraph. So,I did code changes now in such way, if we create notebook/open an existing notebook, it will focus on the first paragraph. For existing notebook, i do focus to end of the paragraph.I hope those changes are fine. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1312: [ZEPPELIN-1245] Focus first paragraph after not...
Github user rajarajan-g closed the pull request at: https://github.com/apache/zeppelin/pull/1312 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1312: [ZEPPELIN-1245] Focus first paragraph after notebook c...
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1312 closing the Pull Request since there are merge conflicts --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1312: [ZEPPELIN-1245] Focus first paragraph after notebook c...
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1312 Closing this pull request as it is invalid --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1313: [ZEPPELIN-1245] Focus first paragraph after not...
GitHub user rajarajan-g opened a pull request: https://github.com/apache/zeppelin/pull/1313 [ZEPPELIN-1245] Focus first paragraph after notebook creation ### What is this PR for? Once the notebook is created, cursor should focus on the first paragraph ### What type of PR is it? Bug Fix ### Todos * [ ] - None ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1245 ### How should this be tested? Once the Zeppelin server is started , Create a new notebook check if cursor blinks on the first paragraph of the notebook ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajarajan-g/zeppelin ZEPPELIN-1245 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1313.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1313 commit 5875bc8ab5e04849e4f806c433bf32c7449693dc Author: rajarajan-g Date: 2016-08-10T08:41:12Z fix for ZEPPELIN-1245 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1312: [ZEPPELIN-1268] Focus first paragraph after not...
GitHub user rajarajan-g opened a pull request: https://github.com/apache/zeppelin/pull/1312 [ZEPPELIN-1268] Focus first paragraph after notebook creation ### What is this PR for? Once the notebook is created, cursor should focus on the first paragraph ### What type of PR is it? Bug Fix ### Todos * [ ] - None ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1245 ### How should this be tested? Once the Zeppelin server is started , Create a new notebook check if cursor blinks on the first paragraph ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajarajan-g/zeppelin zeppelin-1245 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1312.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1312 commit 84332127d79aa9c6ee16bd1aa5dec8b4b7891ee5 Author: rajarajan-g Date: 2016-08-09T06:30:45Z fixed for #1245 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
