[jira] [Commented] (ZOOKEEPER-2829) Interface usability / compatibility improvements through Java annotation.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104369#comment-16104369 ] ASF GitHub Bot commented on ZOOKEEPER-2829: --- Github user afine closed the pull request at: https://github.com/apache/zookeeper/pull/317 > Interface usability / compatibility improvements through Java annotation. > - > > Key: ZOOKEEPER-2829 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2829 > Project: ZooKeeper > Issue Type: Improvement > Components: java client, server >Affects Versions: 3.4.10, 3.5.3 >Reporter: Michael Han >Assignee: Abraham Fine > Labels: annotation > > Hadoop has interface classification regarding the interfaces' scope and > stability. ZK should do something similar, which not only provides additional > benefits of making API compatibility easier between releases (or even > commits, by automating the checks via some tooling), but also consistent with > rest of Hadoop ecosystem. > See HADOOP-5073 for more context. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] zookeeper pull request #317: ZOOKEEPER-2829: Interface usability / compatibi...
Github user afine closed the pull request at: https://github.com/apache/zookeeper/pull/317 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
ZooKeeper_branch35_jdk8 - Build # 616 - Still Failing
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/616/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 69.94 MB...]
[junit] 2017-07-28 01:27:46,934 [myid:] - INFO
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2017-07-28 01:27:46,934 [myid:] - INFO
[main:PrepRequestProcessor@1005] - Shutting down
[junit] 2017-07-28 01:27:46,934 [myid:] - INFO
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2017-07-28 01:27:46,934 [myid:] - INFO
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2017-07-28 01:27:46,934 [myid:] - INFO [ProcessThread(sid:0
cport:19547)::PrepRequestProcessor@155] - PrepRequestProcessor exited loop!
[junit] 2017-07-28 01:27:46,934 [myid:] - INFO
[main:FinalRequestProcessor@481] - shutdown of request processor complete
[junit] 2017-07-28 01:27:46,935 [myid:] - INFO [main:MBeanRegistry@128] -
Unregister MBean
[org.apache.ZooKeeperService:name0=StandaloneServer_port19547,name1=InMemoryDataTree]
[junit] 2017-07-28 01:27:46,935 [myid:] - INFO [main:MBeanRegistry@128] -
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port19547]
[junit] 2017-07-28 01:27:46,935 [myid:] - INFO
[main:FourLetterWordMain@87] - connecting to 127.0.0.1 19547
[junit] 2017-07-28 01:27:46,936 [myid:] - INFO [main:JMXEnv@146] -
ensureOnly:[]
[junit] 2017-07-28 01:27:46,939 [myid:] - INFO [main:ClientBase@611] -
fdcount after test is: 1539 at start it was 1539
[junit] 2017-07-28 01:27:46,939 [myid:] - INFO [main:ZKTestCase$1@68] -
SUCCEEDED testWatcherAutoResetWithLocal
[junit] 2017-07-28 01:27:46,939 [myid:] - INFO [main:ZKTestCase$1@63] -
FINISHED testWatcherAutoResetWithLocal
[junit] Tests run: 103, Failures: 2, Errors: 0, Skipped: 0, Time elapsed:
410.135 sec, Thread: 4, Class: org.apache.zookeeper.test.NettyNettySuiteTest
[junit] 2017-07-28 01:27:47,074 [myid:127.0.0.1:19301] - INFO
[main-SendThread(127.0.0.1:19301):ClientCnxn$SendThread@1113] - Opening socket
connection to server 127.0.0.1/127.0.0.1:19301. Will not attempt to
authenticate using SASL (unknown error)
[junit] 2017-07-28 01:27:47,075 [myid:] - INFO [New I/O boss
#18:ClientCnxnSocketNetty$1@127] - future isn't success, cause: {}
[junit] java.net.ConnectException: Connection refused:
127.0.0.1/127.0.0.1:19301
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
[junit] at
org.jboss.netty.channel.socket.nio.NioClientBoss.connect(NioClientBoss.java:152)
[junit] at
org.jboss.netty.channel.socket.nio.NioClientBoss.processSelectedKeys(NioClientBoss.java:105)
[junit] at
org.jboss.netty.channel.socket.nio.NioClientBoss.process(NioClientBoss.java:79)
[junit] at
org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
[junit] at
org.jboss.netty.channel.socket.nio.NioClientBoss.run(NioClientBoss.java:42)
[junit] at
org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
[junit] at
org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
[junit] at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[junit] at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[junit] at java.lang.Thread.run(Thread.java:748)
[junit] 2017-07-28 01:27:47,075 [myid:] - WARN [New I/O boss
#18:ClientCnxnSocketNetty$ZKClientHandler@439] - Exception caught: [id:
0xc8e46501] EXCEPTION: java.net.ConnectException: Connection refused:
127.0.0.1/127.0.0.1:19301
[junit] java.net.ConnectException: Connection refused:
127.0.0.1/127.0.0.1:19301
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
[junit] at
org.jboss.netty.channel.socket.nio.NioClientBoss.connect(NioClientBoss.java:152)
[junit] at
org.jboss.netty.channel.socket.nio.NioClientBoss.processSelectedKeys(NioClientBoss.java:105)
[junit] at
org.jboss.netty.channel.socket.nio.NioClientBoss.process(NioClientBoss.java:79)
[junit] at
org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
[junit] at
org.jboss.netty.channel.socket.nio.NioClientBoss.run(NioClientBoss.java:42)
[junit] at
org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
[junit] at
org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
[junit] at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[junit] at
ZooKeeper-trunk-jdk8 - Build # 1144 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/1144/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 66.19 MB...] [junit] at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireInterruptibly(AbstractQueuedSynchronizer.java:1220) [junit] at java.util.concurrent.locks.ReentrantLock.lockInterruptibly(ReentrantLock.java:335) [junit] at java.util.concurrent.LinkedBlockingQueue.put(LinkedBlockingQueue.java:339) [junit] at org.apache.zookeeper.server.quorum.LearnerHandler.shutdown(LearnerHandler.java:902) [junit] at org.apache.zookeeper.server.quorum.LearnerHandler.run(LearnerHandler.java:623) [junit] 2017-07-28 01:10:30,737 [myid:] - INFO [QuorumPeer[myid=5](plain=/127.0.0.1:11383)(secure=disabled):MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id5,name1=replica.5,name2=Leader] [junit] 2017-07-28 01:10:30,737 [myid:] - WARN [QuorumPeer[myid=5](plain=/127.0.0.1:11383)(secure=disabled):QuorumPeer@1130] - Unexpected exception [junit] java.lang.InterruptedException [junit] at java.lang.Object.wait(Native Method) [junit] at org.apache.zookeeper.server.quorum.Leader.lead(Leader.java:563) [junit] at org.apache.zookeeper.server.quorum.QuorumPeer.run(QuorumPeer.java:1127) [junit] 2017-07-28 01:10:30,738 [myid:] - INFO [QuorumPeer[myid=5](plain=/127.0.0.1:11383)(secure=disabled):Leader@626] - Shutting down [junit] 2017-07-28 01:10:30,738 [myid:] - WARN [QuorumPeer[myid=5](plain=/127.0.0.1:11383)(secure=disabled):QuorumPeer@1161] - PeerState set to LOOKING [junit] 2017-07-28 01:10:30,738 [myid:] - WARN [QuorumPeer[myid=5](plain=/127.0.0.1:11383)(secure=disabled):QuorumPeer@1143] - QuorumPeer main thread exited [junit] 2017-07-28 01:10:30,738 [myid:] - INFO [QuorumPeer[myid=5](plain=/127.0.0.1:11383)(secure=disabled):MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id5] [junit] 2017-07-28 01:10:30,738 [myid:] - INFO [QuorumPeer[myid=5](plain=/127.0.0.1:11383)(secure=disabled):MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id5,name1=replica.5] [junit] 2017-07-28 01:10:30,738 [myid:] - INFO [QuorumPeer[myid=5](plain=/127.0.0.1:11383)(secure=disabled):MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id5,name1=replica.1] [junit] 2017-07-28 01:10:30,738 [myid:] - INFO [QuorumPeer[myid=5](plain=/127.0.0.1:11383)(secure=disabled):MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id5,name1=replica.2] [junit] 2017-07-28 01:10:30,738 [myid:] - INFO [QuorumPeer[myid=5](plain=/127.0.0.1:11383)(secure=disabled):MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id5,name1=replica.3] [junit] 2017-07-28 01:10:30,738 [myid:] - INFO [/127.0.0.1:11385:QuorumCnxManager$Listener@667] - Leaving listener [junit] 2017-07-28 01:10:30,739 [myid:] - INFO [main:QuorumUtil@254] - Shutting down leader election QuorumPeer[myid=5](plain=/127.0.0.1:11383)(secure=disabled) [junit] 2017-07-28 01:10:30,739 [myid:] - INFO [main:QuorumUtil@259] - Waiting for QuorumPeer[myid=5](plain=/127.0.0.1:11383)(secure=disabled) to exit thread [junit] 2017-07-28 01:10:30,739 [myid:] - INFO [main:FourLetterWordMain@87] - connecting to 127.0.0.1 11371 [junit] 2017-07-28 01:10:30,740 [myid:] - INFO [main:QuorumUtil@243] - 127.0.0.1:11371 is no longer accepting client connections [junit] 2017-07-28 01:10:30,740 [myid:] - INFO [main:FourLetterWordMain@87] - connecting to 127.0.0.1 11374 [junit] 2017-07-28 01:10:30,740 [myid:] - INFO [main:QuorumUtil@243] - 127.0.0.1:11374 is no longer accepting client connections [junit] 2017-07-28 01:10:30,741 [myid:] - INFO [main:FourLetterWordMain@87] - connecting to 127.0.0.1 11377 [junit] 2017-07-28 01:10:30,741 [myid:] - INFO [main:QuorumUtil@243] - 127.0.0.1:11377 is no longer accepting client connections [junit] 2017-07-28 01:10:30,741 [myid:] - INFO [main:FourLetterWordMain@87] - connecting to 127.0.0.1 11380 [junit] 2017-07-28 01:10:30,742 [myid:] - INFO [main:QuorumUtil@243] - 127.0.0.1:11380 is no longer accepting client connections [junit] 2017-07-28 01:10:30,742 [myid:] - INFO [main:FourLetterWordMain@87] - connecting to 127.0.0.1 11383 [junit] 2017-07-28 01:10:30,742 [myid:] - INFO [main:QuorumUtil@243] - 127.0.0.1:11383 is no longer accepting client connections [junit] 2017-07-28 01:10:30,744 [myid:] - INFO [main:ZKTestCase$1@68] - SUCCEEDED testRemoveOneAsynchronous [junit] 2017-07-28 01:10:30,744 [myid:] - INFO [main:ZKTestCase$1@63] - FINISHED testRemoveOneAsynchronous [junit] Tests run: 13,
ZooKeeper_branch35_jdk7 - Build # 1059 - Still Failing
See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/1059/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 71.46 MB...] [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214) [junit] 2017-07-28 00:16:19,924 [myid:127.0.0.1:27380] - INFO [main-SendThread(127.0.0.1:27380):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:27380. Will not attempt to authenticate using SASL (unknown error) [junit] 2017-07-28 00:16:19,925 [myid:127.0.0.1:27380] - WARN [main-SendThread(127.0.0.1:27380):ClientCnxn$SendThread@1235] - Session 0x4fff0f5cf for server 127.0.0.1/127.0.0.1:27380, unexpected error, closing socket connection and attempting reconnect [junit] java.net.ConnectException: Connection refused [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744) [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214) [junit] 2017-07-28 00:16:20,064 [myid:127.0.0.1:27383] - INFO [main-SendThread(127.0.0.1:27383):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:27383. Will not attempt to authenticate using SASL (unknown error) [junit] 2017-07-28 00:16:20,065 [myid:127.0.0.1:27383] - WARN [main-SendThread(127.0.0.1:27383):ClientCnxn$SendThread@1235] - Session 0x104fff0f7e20001 for server 127.0.0.1/127.0.0.1:27383, unexpected error, closing socket connection and attempting reconnect [junit] java.net.ConnectException: Connection refused [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744) [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214) [junit] 2017-07-28 00:16:20,483 [myid:127.0.0.1:27380] - INFO [main-SendThread(127.0.0.1:27380):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:27380. Will not attempt to authenticate using SASL (unknown error) [junit] 2017-07-28 00:16:20,484 [myid:127.0.0.1:27380] - WARN [main-SendThread(127.0.0.1:27380):ClientCnxn$SendThread@1235] - Session 0x4fff0f5cf0001 for server 127.0.0.1/127.0.0.1:27380, unexpected error, closing socket connection and attempting reconnect [junit] java.net.ConnectException: Connection refused [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744) [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214) [junit] 2017-07-28 00:16:20,590 [myid:127.0.0.1:27383] - INFO [main-SendThread(127.0.0.1:27383):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:27383. Will not attempt to authenticate using SASL (unknown error) [junit] 2017-07-28 00:16:20,591 [myid:127.0.0.1:27383] - WARN [main-SendThread(127.0.0.1:27383):ClientCnxn$SendThread@1235] - Session 0x104fff0f7e2 for server 127.0.0.1/127.0.0.1:27383, unexpected error, closing socket connection and attempting reconnect [junit] java.net.ConnectException: Connection refused [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744) [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214) [junit] 2017-07-28 00:16:21,274 [myid:127.0.0.1:27380] - INFO [main-SendThread(127.0.0.1:27380):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:27380. Will not attempt to authenticate using SASL (unknown error) [junit] 2017-07-28 00:16:21,274 [myid:127.0.0.1:27380] - WARN [main-SendThread(127.0.0.1:27380):ClientCnxn$SendThread@1235] - Session 0x4fff0f5cf for server 127.0.0.1/127.0.0.1:27380, unexpected error, closing socket connection and attempting reconnect [junit] java.net.ConnectException: Connection refused [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744) [junit] at
ZooKeeper_branch34_jdk8 - Build # 1076 - Failure
See https://builds.apache.org/job/ZooKeeper_branch34_jdk8/1076/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 136.19 MB...] [junit] 2017-07-27 23:59:06,895 [myid:] - INFO [main:PrepRequestProcessor@769] - Shutting down [junit] 2017-07-27 23:59:06,895 [myid:] - INFO [main:SyncRequestProcessor@208] - Shutting down [junit] 2017-07-27 23:59:06,895 [myid:] - INFO [ProcessThread(sid:0 cport:11221)::PrepRequestProcessor@144] - PrepRequestProcessor exited loop! [junit] 2017-07-27 23:59:06,895 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@186] - SyncRequestProcessor exited! [junit] 2017-07-27 23:59:06,895 [myid:] - INFO [main:FinalRequestProcessor@403] - shutdown of request processor complete [junit] 2017-07-27 23:59:06,896 [myid:] - INFO [main:FourLetterWordMain@65] - connecting to 127.0.0.1 11221 [junit] 2017-07-27 23:59:06,897 [myid:] - INFO [main:JMXEnv@147] - ensureOnly:[] [junit] 2017-07-27 23:59:06,898 [myid:] - INFO [main:ClientBase@489] - STARTING server [junit] 2017-07-27 23:59:06,899 [myid:] - INFO [main:ClientBase@410] - CREATING server instance 127.0.0.1:11221 [junit] 2017-07-27 23:59:06,899 [myid:] - INFO [main:ServerCnxnFactory@111] - Using org.apache.zookeeper.server.NIOServerCnxnFactory as server connection factory [junit] 2017-07-27 23:59:06,899 [myid:] - INFO [main:NIOServerCnxnFactory@89] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2017-07-27 23:59:06,900 [myid:] - INFO [main:ClientBase@385] - STARTING server instance 127.0.0.1:11221 [junit] 2017-07-27 23:59:06,900 [myid:] - INFO [main:ZooKeeperServer@173] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk8/build/test/tmp/test939690804762280815.junit.dir/version-2 snapdir /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk8/build/test/tmp/test939690804762280815.junit.dir/version-2 [junit] 2017-07-27 23:59:06,904 [myid:] - ERROR [main:ZooKeeperServer@468] - ZKShutdownHandler is not registered, so ZooKeeper server won't take any action on ERROR or SHUTDOWN server state changes [junit] 2017-07-27 23:59:06,904 [myid:] - INFO [main:FourLetterWordMain@65] - connecting to 127.0.0.1 11221 [junit] 2017-07-27 23:59:06,905 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@192] - Accepted socket connection from /127.0.0.1:38868 [junit] 2017-07-27 23:59:06,905 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@883] - Processing stat command from /127.0.0.1:38868 [junit] 2017-07-27 23:59:06,908 [myid:] - INFO [Thread-4:NIOServerCnxn$StatCommand@674] - Stat command output [junit] 2017-07-27 23:59:06,909 [myid:] - INFO [Thread-4:NIOServerCnxn@1044] - Closed socket connection for client /127.0.0.1:38868 (no session established for client) [junit] 2017-07-27 23:59:06,909 [myid:] - INFO [main:JMXEnv@230] - ensureParent:[InMemoryDataTree, StandaloneServer_port] [junit] 2017-07-27 23:59:06,911 [myid:] - INFO [main:JMXEnv@247] - expect:InMemoryDataTree [junit] 2017-07-27 23:59:06,911 [myid:] - INFO [main:JMXEnv@251] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree [junit] 2017-07-27 23:59:06,911 [myid:] - INFO [main:JMXEnv@247] - expect:StandaloneServer_port [junit] 2017-07-27 23:59:06,911 [myid:] - INFO [main:JMXEnv@251] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port11221 [junit] 2017-07-27 23:59:06,912 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@58] - Memory used 35543 [junit] 2017-07-27 23:59:06,912 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@63] - Number of threads 20 [junit] 2017-07-27 23:59:06,912 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@78] - FINISHED TEST METHOD testQuota [junit] 2017-07-27 23:59:06,912 [myid:] - INFO [main:ClientBase@566] - tearDown starting [junit] 2017-07-27 23:59:06,979 [myid:] - INFO [main:ZooKeeper@687] - Session: 0x105b14afa56 closed [junit] 2017-07-27 23:59:06,979 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@520] - EventThread shut down for session: 0x105b14afa56 [junit] 2017-07-27 23:59:06,980 [myid:] - INFO [main:ClientBase@536] - STOPPING server [junit] 2017-07-27 23:59:06,980 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@219] - NIOServerCnxn factory exited run method [junit] 2017-07-27 23:59:06,980 [myid:] - INFO [main:ZooKeeperServer@501] - shutting down [junit] 2017-07-27 23:59:06,981 [myid:] - ERROR [main:ZooKeeperServer@468] - ZKShutdownHandler is not registered, so ZooKeeper server won't take any action on ERROR or
[jira] [Commented] (ZOOKEEPER-2841) ZooKeeper public include files leak porting changes
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104083#comment-16104083
]
ASF GitHub Bot commented on ZOOKEEPER-2841:
---
Github user andschwa commented on the issue:
https://github.com/apache/zookeeper/pull/311
Thank you!
> ZooKeeper public include files leak porting changes
> ---
>
> Key: ZOOKEEPER-2841
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2841
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Environment: Windows 10 with Visual Studio 2017
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
> Labels: windows
>
> The fundamental problem is that the port of the C client to Windows is now
> close to six years old, with very few updates. This port leaks a lot of
> changes that should be internal to ZooKeeper, and many of those changes are
> simply no longer relevant. The correct thing to do is attempt to refactor the
> Windows port for new versions of ZooKeeper, removing dead/unneeded porting
> code, and moving dangerous porting code to C files instead of public headers.
> Two primary examples of this problem are
> [ZOOKEEPER-2491|https://issues.apache.org/jira/browse/ZOOKEEPER-2491] and
> [MESOS-7541|https://issues.apache.org/jira/browse/MESOS-7541].
> The first issue stems from this ancient porting code:
> {noformat}
> #define snprintf _snprintf
> {noformat}
> in
> [winconfig.h|https://github.com/apache/zookeeper/blob/ddf0364903bf7ac7cd25b2e1927f0d9d3c7203c4/src/c/include/winconfig.h#L179].
> Newer versions of Windows C libraries define {{snprintf}} as a function, and
> so it cannot be redefined.
> The second issue comes from this undocumented change:
> {noformat}
> #undef AF_INET6
> {noformat}
> again in
> [winconfig.h|https://github.com/apache/zookeeper/blob/ddf0364903bf7ac7cd25b2e1927f0d9d3c7203c4/src/c/include/winconfig.h#L169]
> which breaks any library that uses IPv6 and {{winsock2.h}}.
> Furthermore, the inclusion of the following defines and headers causes
> terrible problems for consuming libraries, as they leak into ZooKeeper's
> public headers:
> {noformat}
> #define _CRT_SECURE_NO_WARNINGS
> #define WIN32_LEAN_AND_MEAN
> #include
> #include
> #include
> #include
> #include
> {noformat}
> Depending on the order that a project includes or compiles files, this may or
> may not cause {{WIN32_LEAN_AND_MEAN}} to become unexpectedly defined, and
> {{windows.h}} to be unexpectedly included. This problem is exacberated by the
> fact that the {{winsock2.h}} and {{windows.h}} headers are order-dependent
> (if you read up on this, you'll see that defining {{WIN32_LEAN_AND_MEAN}} was
> meant to work-around this).
> Going forward, porting changes should live next to where they are used,
> preferably in source files, not header files, so they remain contained.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2841) ZooKeeper public include files leak porting changes
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104084#comment-16104084
]
ASF GitHub Bot commented on ZOOKEEPER-2841:
---
Github user andschwa closed the pull request at:
https://github.com/apache/zookeeper/pull/311
> ZooKeeper public include files leak porting changes
> ---
>
> Key: ZOOKEEPER-2841
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2841
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Environment: Windows 10 with Visual Studio 2017
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
> Labels: windows
>
> The fundamental problem is that the port of the C client to Windows is now
> close to six years old, with very few updates. This port leaks a lot of
> changes that should be internal to ZooKeeper, and many of those changes are
> simply no longer relevant. The correct thing to do is attempt to refactor the
> Windows port for new versions of ZooKeeper, removing dead/unneeded porting
> code, and moving dangerous porting code to C files instead of public headers.
> Two primary examples of this problem are
> [ZOOKEEPER-2491|https://issues.apache.org/jira/browse/ZOOKEEPER-2491] and
> [MESOS-7541|https://issues.apache.org/jira/browse/MESOS-7541].
> The first issue stems from this ancient porting code:
> {noformat}
> #define snprintf _snprintf
> {noformat}
> in
> [winconfig.h|https://github.com/apache/zookeeper/blob/ddf0364903bf7ac7cd25b2e1927f0d9d3c7203c4/src/c/include/winconfig.h#L179].
> Newer versions of Windows C libraries define {{snprintf}} as a function, and
> so it cannot be redefined.
> The second issue comes from this undocumented change:
> {noformat}
> #undef AF_INET6
> {noformat}
> again in
> [winconfig.h|https://github.com/apache/zookeeper/blob/ddf0364903bf7ac7cd25b2e1927f0d9d3c7203c4/src/c/include/winconfig.h#L169]
> which breaks any library that uses IPv6 and {{winsock2.h}}.
> Furthermore, the inclusion of the following defines and headers causes
> terrible problems for consuming libraries, as they leak into ZooKeeper's
> public headers:
> {noformat}
> #define _CRT_SECURE_NO_WARNINGS
> #define WIN32_LEAN_AND_MEAN
> #include
> #include
> #include
> #include
> #include
> {noformat}
> Depending on the order that a project includes or compiles files, this may or
> may not cause {{WIN32_LEAN_AND_MEAN}} to become unexpectedly defined, and
> {{windows.h}} to be unexpectedly included. This problem is exacberated by the
> fact that the {{winsock2.h}} and {{windows.h}} headers are order-dependent
> (if you read up on this, you'll see that defining {{WIN32_LEAN_AND_MEAN}} was
> meant to work-around this).
> Going forward, porting changes should live next to where they are used,
> preferably in source files, not header files, so they remain contained.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] zookeeper issue #311: ZOOKEEPER-2841: ZooKeeper public include files leak po...
Github user andschwa commented on the issue: https://github.com/apache/zookeeper/pull/311 Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper pull request #311: ZOOKEEPER-2841: ZooKeeper public include files ...
Github user andschwa closed the pull request at: https://github.com/apache/zookeeper/pull/311 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
ZooKeeper-trunk - Build # 3480 - Failure
See https://builds.apache.org/job/ZooKeeper-trunk/3480/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 67.38 MB...]
[junit] 2017-07-27 23:28:15,105 [myid:] - INFO [New I/O boss
#10164:ClientCnxnSocketNetty@208] - channel is told closing
[junit] 2017-07-27 23:28:15,105 [myid:127.0.0.1:22120] - INFO
[main-SendThread(127.0.0.1:22120):ClientCnxn$SendThread@1231] - channel for
sessionid 0x20073041327 is lost, closing socket connection and attempting
reconnect
[junit] 2017-07-27 23:28:15,573 [myid:127.0.0.1:22058] - INFO
[main-SendThread(127.0.0.1:22058):ClientCnxn$SendThread@1113] - Opening socket
connection to server 127.0.0.1/127.0.0.1:22058. Will not attempt to
authenticate using SASL (unknown error)
[junit] 2017-07-27 23:28:15,573 [myid:] - INFO [New I/O boss
#7227:ClientCnxnSocketNetty$1@127] - future isn't success, cause: {}
[junit] java.net.ConnectException: Connection refused:
127.0.0.1/127.0.0.1:22058
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at
org.jboss.netty.channel.socket.nio.NioClientBoss.connect(NioClientBoss.java:152)
[junit] at
org.jboss.netty.channel.socket.nio.NioClientBoss.processSelectedKeys(NioClientBoss.java:105)
[junit] at
org.jboss.netty.channel.socket.nio.NioClientBoss.process(NioClientBoss.java:79)
[junit] at
org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
[junit] at
org.jboss.netty.channel.socket.nio.NioClientBoss.run(NioClientBoss.java:42)
[junit] at
org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
[junit] at
org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
[junit] at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
[junit] at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
[junit] at java.lang.Thread.run(Thread.java:745)
[junit] 2017-07-27 23:28:15,574 [myid:] - WARN [New I/O boss
#7227:ClientCnxnSocketNetty$ZKClientHandler@439] - Exception caught: [id:
0x681d5f27] EXCEPTION: java.net.ConnectException: Connection refused:
127.0.0.1/127.0.0.1:22058
[junit] java.net.ConnectException: Connection refused:
127.0.0.1/127.0.0.1:22058
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at
org.jboss.netty.channel.socket.nio.NioClientBoss.connect(NioClientBoss.java:152)
[junit] at
org.jboss.netty.channel.socket.nio.NioClientBoss.processSelectedKeys(NioClientBoss.java:105)
[junit] at
org.jboss.netty.channel.socket.nio.NioClientBoss.process(NioClientBoss.java:79)
[junit] at
org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
[junit] at
org.jboss.netty.channel.socket.nio.NioClientBoss.run(NioClientBoss.java:42)
[junit] at
org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
[junit] at
org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
[junit] at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
[junit] at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
[junit] at java.lang.Thread.run(Thread.java:745)
[junit] 2017-07-27 23:28:15,574 [myid:] - INFO [New I/O boss
#7227:ClientCnxnSocketNetty@208] - channel is told closing
[junit] 2017-07-27 23:28:15,574 [myid:127.0.0.1:22058] - INFO
[main-SendThread(127.0.0.1:22058):ClientCnxn$SendThread@1231] - channel for
sessionid 0x10073016a0d is lost, closing socket connection and attempting
reconnect
fail.build.on.test.failure:
BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/build.xml:1339: The
following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/build.xml:1220: The
following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/build.xml:1224: Tests
failed!
Total time: 12 minutes 1 second
Build step 'Execute shell' marked build as failure
[FINDBUGS] Skipping publisher since build result is FAILURE
[WARNINGS] Skipping publisher since build result is FAILURE
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording fingerprints
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[JIRA] Updating issue ZOOKEEPER-2829
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Publishing Javadoc
Setting
[jira] [Commented] (ZOOKEEPER-2829) Interface usability / compatibility improvements through Java annotation.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104078#comment-16104078 ] Hudson commented on ZOOKEEPER-2829: --- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #3480 (See [https://builds.apache.org/job/ZooKeeper-trunk/3480/]) ZOOKEEPER-2829: Interface usability / compatibility improvements through (hanm: rev 0cb4011dac7ec28637426cafd98b4f8f299ef61d) * (edit) src/java/main/org/apache/zookeeper/admin/ZooKeeperAdmin.java * (edit) src/java/main/org/apache/zookeeper/server/LogFormatter.java * (edit) src/java/main/org/apache/zookeeper/client/ZKClientConfig.java * (edit) src/java/main/org/apache/zookeeper/CreateMode.java * (edit) src/java/main/org/apache/zookeeper/Watcher.java * (edit) src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java * (edit) src/java/main/org/apache/zookeeper/client/FourLetterWordMain.java * (edit) src/java/main/org/apache/zookeeper/client/HostProvider.java * (edit) src/java/main/org/apache/zookeeper/KeeperException.java * (edit) src/java/main/org/apache/zookeeper/Transaction.java * (edit) src/java/main/org/apache/zookeeper/server/admin/AdminServer.java * (edit) src/java/main/org/apache/zookeeper/server/PurgeTxnLog.java * (edit) src/java/main/org/apache/zookeeper/ZooDefs.java * (edit) src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java * (edit) src/java/main/org/apache/jute/compiler/JRecord.java * (edit) src/java/main/org/apache/zookeeper/ZooKeeperMain.java * (edit) src/java/main/org/apache/zookeeper/server/ServerConfig.java * (edit) src/java/main/org/apache/zookeeper/server/SnapshotFormatter.java * (edit) build.xml * (edit) src/java/main/org/apache/zookeeper/AsyncCallback.java * (edit) ivy.xml * (edit) src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java * (edit) src/java/main/org/apache/zookeeper/ZooKeeper.java * (edit) src/java/main/org/apache/zookeeper/WatchedEvent.java * (edit) src/java/main/org/apache/jute/Record.java * (edit) src/java/main/org/apache/zookeeper/ServerAdminClient.java * (edit) src/java/main/org/apache/zookeeper/client/StaticHostProvider.java > Interface usability / compatibility improvements through Java annotation. > - > > Key: ZOOKEEPER-2829 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2829 > Project: ZooKeeper > Issue Type: Improvement > Components: java client, server >Affects Versions: 3.4.10, 3.5.3 >Reporter: Michael Han >Assignee: Abraham Fine > Labels: annotation > > Hadoop has interface classification regarding the interfaces' scope and > stability. ZK should do something similar, which not only provides additional > benefits of making API compatibility easier between releases (or even > commits, by automating the checks via some tooling), but also consistent with > rest of Hadoop ecosystem. > See HADOOP-5073 for more context. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
ZooKeeper_branch35_openjdk7 - Build # 615 - Failure
See https://builds.apache.org/job/ZooKeeper_branch35_openjdk7/615/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 67.79 MB...] [junit] 2017-07-27 23:08:58,257 [myid:127.0.0.1:21994] - INFO [main-SendThread(127.0.0.1:21994):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:21994. Will not attempt to authenticate using SASL (unknown error) [junit] 2017-07-27 23:08:58,258 [myid:127.0.0.1:21994] - WARN [main-SendThread(127.0.0.1:21994):ClientCnxn$SendThread@1235] - Session 0x105b02d7093 for server 127.0.0.1/127.0.0.1:21994, unexpected error, closing socket connection and attempting reconnect [junit] java.net.ConnectException: Connection refused [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:739) [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214) [junit] 2017-07-27 23:08:58,408 [myid:127.0.0.1:22058] - INFO [main-SendThread(127.0.0.1:22058):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:22058. Will not attempt to authenticate using SASL (unknown error) [junit] 2017-07-27 23:08:58,409 [myid:127.0.0.1:22058] - WARN [main-SendThread(127.0.0.1:22058):ClientCnxn$SendThread@1235] - Session 0x105b02e10c3 for server 127.0.0.1/127.0.0.1:22058, unexpected error, closing socket connection and attempting reconnect [junit] java.net.ConnectException: Connection refused [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:739) [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214) [junit] 2017-07-27 23:08:58,885 [myid:] - INFO [ProcessThread(sid:0 cport:22240)::PrepRequestProcessor@611] - Processed session termination for sessionid: 0x105b0338e3f [junit] 2017-07-27 23:08:58,886 [myid:] - INFO [SyncThread:0:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port22240,name1=Connections,name2=127.0.0.1,name3=0x105b0338e3f] [junit] 2017-07-27 23:08:58,886 [myid:] - INFO [main:ZooKeeper@1334] - Session: 0x105b0338e3f closed [junit] 2017-07-27 23:08:58,886 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for session: 0x105b0338e3f [junit] 2017-07-27 23:08:58,887 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 212547 [junit] 2017-07-27 23:08:58,887 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 2431 [junit] 2017-07-27 23:08:58,887 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD testWatcherAutoResetWithLocal [junit] 2017-07-27 23:08:58,887 [myid:] - INFO [main:ClientBase@586] - tearDown starting [junit] 2017-07-27 23:08:58,887 [myid:] - INFO [main:ClientBase@556] - STOPPING server [junit] 2017-07-27 23:08:58,887 [myid:] - INFO [main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:22240 [junit] 2017-07-27 23:08:58,894 [myid:] - INFO [main:ZooKeeperServer@541] - shutting down [junit] 2017-07-27 23:08:58,895 [myid:] - ERROR [main:ZooKeeperServer@505] - ZKShutdownHandler is not registered, so ZooKeeper server won't take any action on ERROR or SHUTDOWN server state changes [junit] 2017-07-27 23:08:58,895 [myid:] - INFO [main:SessionTrackerImpl@232] - Shutting down [junit] 2017-07-27 23:08:58,895 [myid:] - INFO [main:PrepRequestProcessor@1005] - Shutting down [junit] 2017-07-27 23:08:58,895 [myid:] - INFO [main:SyncRequestProcessor@191] - Shutting down [junit] 2017-07-27 23:08:58,895 [myid:] - INFO [ProcessThread(sid:0 cport:22240)::PrepRequestProcessor@155] - PrepRequestProcessor exited loop! [junit] 2017-07-27 23:08:58,896 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited! [junit] 2017-07-27 23:08:58,896 [myid:] - INFO [main:FinalRequestProcessor@481] - shutdown of request processor complete [junit] 2017-07-27 23:08:58,896 [myid:] - INFO [main:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port22240,name1=InMemoryDataTree] [junit] 2017-07-27 23:08:58,897 [myid:] - INFO [main:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port22240] [junit] 2017-07-27 23:08:58,897 [myid:] - INFO [main:FourLetterWordMain@87] - connecting to 127.0.0.1 22240
[jira] [Commented] (ZOOKEEPER-2841) ZooKeeper public include files leak porting changes
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104056#comment-16104056
]
ASF GitHub Bot commented on ZOOKEEPER-2841:
---
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/311
Committed to 3.5. Thanks for the work, and please close the pull request.
@andschwa
> ZooKeeper public include files leak porting changes
> ---
>
> Key: ZOOKEEPER-2841
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2841
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Environment: Windows 10 with Visual Studio 2017
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
> Labels: windows
>
> The fundamental problem is that the port of the C client to Windows is now
> close to six years old, with very few updates. This port leaks a lot of
> changes that should be internal to ZooKeeper, and many of those changes are
> simply no longer relevant. The correct thing to do is attempt to refactor the
> Windows port for new versions of ZooKeeper, removing dead/unneeded porting
> code, and moving dangerous porting code to C files instead of public headers.
> Two primary examples of this problem are
> [ZOOKEEPER-2491|https://issues.apache.org/jira/browse/ZOOKEEPER-2491] and
> [MESOS-7541|https://issues.apache.org/jira/browse/MESOS-7541].
> The first issue stems from this ancient porting code:
> {noformat}
> #define snprintf _snprintf
> {noformat}
> in
> [winconfig.h|https://github.com/apache/zookeeper/blob/ddf0364903bf7ac7cd25b2e1927f0d9d3c7203c4/src/c/include/winconfig.h#L179].
> Newer versions of Windows C libraries define {{snprintf}} as a function, and
> so it cannot be redefined.
> The second issue comes from this undocumented change:
> {noformat}
> #undef AF_INET6
> {noformat}
> again in
> [winconfig.h|https://github.com/apache/zookeeper/blob/ddf0364903bf7ac7cd25b2e1927f0d9d3c7203c4/src/c/include/winconfig.h#L169]
> which breaks any library that uses IPv6 and {{winsock2.h}}.
> Furthermore, the inclusion of the following defines and headers causes
> terrible problems for consuming libraries, as they leak into ZooKeeper's
> public headers:
> {noformat}
> #define _CRT_SECURE_NO_WARNINGS
> #define WIN32_LEAN_AND_MEAN
> #include
> #include
> #include
> #include
> #include
> {noformat}
> Depending on the order that a project includes or compiles files, this may or
> may not cause {{WIN32_LEAN_AND_MEAN}} to become unexpectedly defined, and
> {{windows.h}} to be unexpectedly included. This problem is exacberated by the
> fact that the {{winsock2.h}} and {{windows.h}} headers are order-dependent
> (if you read up on this, you'll see that defining {{WIN32_LEAN_AND_MEAN}} was
> meant to work-around this).
> Going forward, porting changes should live next to where they are used,
> preferably in source files, not header files, so they remain contained.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] zookeeper issue #311: ZOOKEEPER-2841: ZooKeeper public include files leak po...
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/311 Committed to 3.5. Thanks for the work, and please close the pull request. @andschwa --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (ZOOKEEPER-2841) ZooKeeper public include files leak porting changes
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104054#comment-16104054
]
ASF GitHub Bot commented on ZOOKEEPER-2841:
---
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/311
LGTM. The failing precommit test is not relevant to this patch and should
already be fixed by commit 837b37636201ee9aca4cbbb962d18a7883e14c1b.
> ZooKeeper public include files leak porting changes
> ---
>
> Key: ZOOKEEPER-2841
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2841
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Environment: Windows 10 with Visual Studio 2017
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
> Labels: windows
>
> The fundamental problem is that the port of the C client to Windows is now
> close to six years old, with very few updates. This port leaks a lot of
> changes that should be internal to ZooKeeper, and many of those changes are
> simply no longer relevant. The correct thing to do is attempt to refactor the
> Windows port for new versions of ZooKeeper, removing dead/unneeded porting
> code, and moving dangerous porting code to C files instead of public headers.
> Two primary examples of this problem are
> [ZOOKEEPER-2491|https://issues.apache.org/jira/browse/ZOOKEEPER-2491] and
> [MESOS-7541|https://issues.apache.org/jira/browse/MESOS-7541].
> The first issue stems from this ancient porting code:
> {noformat}
> #define snprintf _snprintf
> {noformat}
> in
> [winconfig.h|https://github.com/apache/zookeeper/blob/ddf0364903bf7ac7cd25b2e1927f0d9d3c7203c4/src/c/include/winconfig.h#L179].
> Newer versions of Windows C libraries define {{snprintf}} as a function, and
> so it cannot be redefined.
> The second issue comes from this undocumented change:
> {noformat}
> #undef AF_INET6
> {noformat}
> again in
> [winconfig.h|https://github.com/apache/zookeeper/blob/ddf0364903bf7ac7cd25b2e1927f0d9d3c7203c4/src/c/include/winconfig.h#L169]
> which breaks any library that uses IPv6 and {{winsock2.h}}.
> Furthermore, the inclusion of the following defines and headers causes
> terrible problems for consuming libraries, as they leak into ZooKeeper's
> public headers:
> {noformat}
> #define _CRT_SECURE_NO_WARNINGS
> #define WIN32_LEAN_AND_MEAN
> #include
> #include
> #include
> #include
> #include
> {noformat}
> Depending on the order that a project includes or compiles files, this may or
> may not cause {{WIN32_LEAN_AND_MEAN}} to become unexpectedly defined, and
> {{windows.h}} to be unexpectedly included. This problem is exacberated by the
> fact that the {{winsock2.h}} and {{windows.h}} headers are order-dependent
> (if you read up on this, you'll see that defining {{WIN32_LEAN_AND_MEAN}} was
> meant to work-around this).
> Going forward, porting changes should live next to where they are used,
> preferably in source files, not header files, so they remain contained.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
ZooKeeper-trunk-openjdk7 - Build # 1560 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/1560/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 61.78 MB...] [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214) [junit] 2017-07-27 22:58:07,431 [myid:127.0.0.1:27396] - INFO [main-SendThread(127.0.0.1:27396):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:27396. Will not attempt to authenticate using SASL (unknown error) [junit] 2017-07-27 22:58:07,432 [myid:127.0.0.1:27396] - WARN [main-SendThread(127.0.0.1:27396):ClientCnxn$SendThread@1235] - Session 0x305b12efad0 for server 127.0.0.1/127.0.0.1:27396, unexpected error, closing socket connection and attempting reconnect [junit] java.net.ConnectException: Connection refused [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:739) [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214) [junit] 2017-07-27 22:58:08,571 [myid:127.0.0.1:27396] - INFO [main-SendThread(127.0.0.1:27396):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:27396. Will not attempt to authenticate using SASL (unknown error) [junit] 2017-07-27 22:58:08,571 [myid:127.0.0.1:27396] - WARN [main-SendThread(127.0.0.1:27396):ClientCnxn$SendThread@1235] - Session 0x305b12efad0 for server 127.0.0.1/127.0.0.1:27396, unexpected error, closing socket connection and attempting reconnect [junit] java.net.ConnectException: Connection refused [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:739) [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214) [junit] 2017-07-27 22:58:10,598 [myid:127.0.0.1:27396] - INFO [main-SendThread(127.0.0.1:27396):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:27396. Will not attempt to authenticate using SASL (unknown error) [junit] 2017-07-27 22:58:10,598 [myid:127.0.0.1:27396] - WARN [main-SendThread(127.0.0.1:27396):ClientCnxn$SendThread@1235] - Session 0x305b12efad0 for server 127.0.0.1/127.0.0.1:27396, unexpected error, closing socket connection and attempting reconnect [junit] java.net.ConnectException: Connection refused [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:739) [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214) [junit] 2017-07-27 22:58:11,996 [myid:127.0.0.1:27396] - INFO [main-SendThread(127.0.0.1:27396):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:27396. Will not attempt to authenticate using SASL (unknown error) [junit] 2017-07-27 22:58:11,997 [myid:127.0.0.1:27396] - WARN [main-SendThread(127.0.0.1:27396):ClientCnxn$SendThread@1235] - Session 0x305b12efad0 for server 127.0.0.1/127.0.0.1:27396, unexpected error, closing socket connection and attempting reconnect [junit] java.net.ConnectException: Connection refused [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:739) [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214) [junit] 2017-07-27 22:58:13,348 [myid:127.0.0.1:27396] - INFO [main-SendThread(127.0.0.1:27396):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:27396. Will not attempt to authenticate using SASL (unknown error) [junit] 2017-07-27 22:58:13,348 [myid:127.0.0.1:27396] - WARN [main-SendThread(127.0.0.1:27396):ClientCnxn$SendThread@1235] - Session 0x305b12efad0 for server 127.0.0.1/127.0.0.1:27396, unexpected error, closing socket connection and attempting reconnect [junit] java.net.ConnectException: Connection refused [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:739) [junit] at
[GitHub] zookeeper issue #311: ZOOKEEPER-2841: ZooKeeper public include files leak po...
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/311 LGTM. The failing precommit test is not relevant to this patch and should already be fixed by commit 837b37636201ee9aca4cbbb962d18a7883e14c1b. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (ZOOKEEPER-2841) ZooKeeper public include files leak porting changes
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104050#comment-16104050
]
ASF GitHub Bot commented on ZOOKEEPER-2841:
---
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/313
Actually, @andschwa Can you please update the PR to remove the port of
ZOOKEEPER-1643
(https://github.com/apache/zookeeper/pull/313/commits/7776bd61c625c8b363655ab7244fa9f33e5f2198)?
I will do a separate commit to pick that up into branch-3.4 after this PR
being merged.
Doing it separately avoid messing up two different credentials associated
with two separate commits - that is a limitation of current commit script we
have. Plus back port of ZOOKEEPER-1643 deserves its separate commit for the
record.
> ZooKeeper public include files leak porting changes
> ---
>
> Key: ZOOKEEPER-2841
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2841
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Environment: Windows 10 with Visual Studio 2017
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
> Labels: windows
>
> The fundamental problem is that the port of the C client to Windows is now
> close to six years old, with very few updates. This port leaks a lot of
> changes that should be internal to ZooKeeper, and many of those changes are
> simply no longer relevant. The correct thing to do is attempt to refactor the
> Windows port for new versions of ZooKeeper, removing dead/unneeded porting
> code, and moving dangerous porting code to C files instead of public headers.
> Two primary examples of this problem are
> [ZOOKEEPER-2491|https://issues.apache.org/jira/browse/ZOOKEEPER-2491] and
> [MESOS-7541|https://issues.apache.org/jira/browse/MESOS-7541].
> The first issue stems from this ancient porting code:
> {noformat}
> #define snprintf _snprintf
> {noformat}
> in
> [winconfig.h|https://github.com/apache/zookeeper/blob/ddf0364903bf7ac7cd25b2e1927f0d9d3c7203c4/src/c/include/winconfig.h#L179].
> Newer versions of Windows C libraries define {{snprintf}} as a function, and
> so it cannot be redefined.
> The second issue comes from this undocumented change:
> {noformat}
> #undef AF_INET6
> {noformat}
> again in
> [winconfig.h|https://github.com/apache/zookeeper/blob/ddf0364903bf7ac7cd25b2e1927f0d9d3c7203c4/src/c/include/winconfig.h#L169]
> which breaks any library that uses IPv6 and {{winsock2.h}}.
> Furthermore, the inclusion of the following defines and headers causes
> terrible problems for consuming libraries, as they leak into ZooKeeper's
> public headers:
> {noformat}
> #define _CRT_SECURE_NO_WARNINGS
> #define WIN32_LEAN_AND_MEAN
> #include
> #include
> #include
> #include
> #include
> {noformat}
> Depending on the order that a project includes or compiles files, this may or
> may not cause {{WIN32_LEAN_AND_MEAN}} to become unexpectedly defined, and
> {{windows.h}} to be unexpectedly included. This problem is exacberated by the
> fact that the {{winsock2.h}} and {{windows.h}} headers are order-dependent
> (if you read up on this, you'll see that defining {{WIN32_LEAN_AND_MEAN}} was
> meant to work-around this).
> Going forward, porting changes should live next to where they are used,
> preferably in source files, not header files, so they remain contained.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] zookeeper issue #313: ZOOKEEPER-2841: ZooKeeper public include files leak po...
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/313 Actually, @andschwa Can you please update the PR to remove the port of ZOOKEEPER-1643 (https://github.com/apache/zookeeper/pull/313/commits/7776bd61c625c8b363655ab7244fa9f33e5f2198)? I will do a separate commit to pick that up into branch-3.4 after this PR being merged. Doing it separately avoid messing up two different credentials associated with two separate commits - that is a limitation of current commit script we have. Plus back port of ZOOKEEPER-1643 deserves its separate commit for the record. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (ZOOKEEPER-2841) ZooKeeper public include files leak porting changes
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104045#comment-16104045
]
ASF GitHub Bot commented on ZOOKEEPER-2841:
---
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/313
Regarding `testAsyncWatcherAutoResetterminate`:
I ran c tests on linux and don't observe consistent failure of with this
patch.
Otherwise lgtm, I am merging this in 3.4.
> ZooKeeper public include files leak porting changes
> ---
>
> Key: ZOOKEEPER-2841
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2841
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Environment: Windows 10 with Visual Studio 2017
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
> Labels: windows
>
> The fundamental problem is that the port of the C client to Windows is now
> close to six years old, with very few updates. This port leaks a lot of
> changes that should be internal to ZooKeeper, and many of those changes are
> simply no longer relevant. The correct thing to do is attempt to refactor the
> Windows port for new versions of ZooKeeper, removing dead/unneeded porting
> code, and moving dangerous porting code to C files instead of public headers.
> Two primary examples of this problem are
> [ZOOKEEPER-2491|https://issues.apache.org/jira/browse/ZOOKEEPER-2491] and
> [MESOS-7541|https://issues.apache.org/jira/browse/MESOS-7541].
> The first issue stems from this ancient porting code:
> {noformat}
> #define snprintf _snprintf
> {noformat}
> in
> [winconfig.h|https://github.com/apache/zookeeper/blob/ddf0364903bf7ac7cd25b2e1927f0d9d3c7203c4/src/c/include/winconfig.h#L179].
> Newer versions of Windows C libraries define {{snprintf}} as a function, and
> so it cannot be redefined.
> The second issue comes from this undocumented change:
> {noformat}
> #undef AF_INET6
> {noformat}
> again in
> [winconfig.h|https://github.com/apache/zookeeper/blob/ddf0364903bf7ac7cd25b2e1927f0d9d3c7203c4/src/c/include/winconfig.h#L169]
> which breaks any library that uses IPv6 and {{winsock2.h}}.
> Furthermore, the inclusion of the following defines and headers causes
> terrible problems for consuming libraries, as they leak into ZooKeeper's
> public headers:
> {noformat}
> #define _CRT_SECURE_NO_WARNINGS
> #define WIN32_LEAN_AND_MEAN
> #include
> #include
> #include
> #include
> #include
> {noformat}
> Depending on the order that a project includes or compiles files, this may or
> may not cause {{WIN32_LEAN_AND_MEAN}} to become unexpectedly defined, and
> {{windows.h}} to be unexpectedly included. This problem is exacberated by the
> fact that the {{winsock2.h}} and {{windows.h}} headers are order-dependent
> (if you read up on this, you'll see that defining {{WIN32_LEAN_AND_MEAN}} was
> meant to work-around this).
> Going forward, porting changes should live next to where they are used,
> preferably in source files, not header files, so they remain contained.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] zookeeper issue #313: ZOOKEEPER-2841: ZooKeeper public include files leak po...
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/313 Regarding `testAsyncWatcherAutoResetterminate`: I ran c tests on linux and don't observe consistent failure of with this patch. Otherwise lgtm, I am merging this in 3.4. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (ZOOKEEPER-2829) Interface usability / compatibility improvements through Java annotation.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104039#comment-16104039 ] ASF GitHub Bot commented on ZOOKEEPER-2829: --- Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/317 @afine Merged, please close the pr. > Interface usability / compatibility improvements through Java annotation. > - > > Key: ZOOKEEPER-2829 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2829 > Project: ZooKeeper > Issue Type: Improvement > Components: java client, server >Affects Versions: 3.4.10, 3.5.3 >Reporter: Michael Han >Assignee: Abraham Fine > Labels: annotation > > Hadoop has interface classification regarding the interfaces' scope and > stability. ZK should do something similar, which not only provides additional > benefits of making API compatibility easier between releases (or even > commits, by automating the checks via some tooling), but also consistent with > rest of Hadoop ecosystem. > See HADOOP-5073 for more context. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] zookeeper issue #317: ZOOKEEPER-2829: Interface usability / compatibility im...
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/317 @afine Merged, please close the pr. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
ZooKeeper_branch35_jdk8 - Build # 615 - Still Failing
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/615/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 67.60 MB...]
[junit] java.net.ConnectException: Connection refused:
127.0.0.1/127.0.0.1:19424
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
[junit] at
org.jboss.netty.channel.socket.nio.NioClientBoss.connect(NioClientBoss.java:152)
[junit] at
org.jboss.netty.channel.socket.nio.NioClientBoss.processSelectedKeys(NioClientBoss.java:105)
[junit] at
org.jboss.netty.channel.socket.nio.NioClientBoss.process(NioClientBoss.java:79)
[junit] at
org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
[junit] at
org.jboss.netty.channel.socket.nio.NioClientBoss.run(NioClientBoss.java:42)
[junit] at
org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
[junit] at
org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
[junit] at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[junit] at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[junit] at java.lang.Thread.run(Thread.java:748)
[junit] 2017-07-27 22:39:18,426 [myid:] - INFO [New I/O boss
#2763:ClientCnxnSocketNetty@208] - channel is told closing
[junit] 2017-07-27 22:39:18,426 [myid:127.0.0.1:19424] - INFO
[main-SendThread(127.0.0.1:19424):ClientCnxn$SendThread@1231] - channel for
sessionid 0x106cc0032a8 is lost, closing socket connection and attempting
reconnect
[junit] 2017-07-27 22:39:18,461 [myid:127.0.0.1:19427] - INFO
[main-SendThread(127.0.0.1:19427):ClientCnxn$SendThread@1113] - Opening socket
connection to server 127.0.0.1/127.0.0.1:19427. Will not attempt to
authenticate using SASL (unknown error)
[junit] 2017-07-27 22:39:18,462 [myid:] - INFO [New I/O boss
#2772:ClientCnxnSocketNetty$1@127] - future isn't success, cause: {}
[junit] java.net.ConnectException: Connection refused:
127.0.0.1/127.0.0.1:19427
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
[junit] at
org.jboss.netty.channel.socket.nio.NioClientBoss.connect(NioClientBoss.java:152)
[junit] at
org.jboss.netty.channel.socket.nio.NioClientBoss.processSelectedKeys(NioClientBoss.java:105)
[junit] at
org.jboss.netty.channel.socket.nio.NioClientBoss.process(NioClientBoss.java:79)
[junit] at
org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
[junit] at
org.jboss.netty.channel.socket.nio.NioClientBoss.run(NioClientBoss.java:42)
[junit] at
org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
[junit] at
org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
[junit] at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[junit] at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[junit] at java.lang.Thread.run(Thread.java:748)
[junit] 2017-07-27 22:39:18,462 [myid:] - WARN [New I/O boss
#2772:ClientCnxnSocketNetty$ZKClientHandler@439] - Exception caught: [id:
0xf260cfc0] EXCEPTION: java.net.ConnectException: Connection refused:
127.0.0.1/127.0.0.1:19427
[junit] java.net.ConnectException: Connection refused:
127.0.0.1/127.0.0.1:19427
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
[junit] at
org.jboss.netty.channel.socket.nio.NioClientBoss.connect(NioClientBoss.java:152)
[junit] at
org.jboss.netty.channel.socket.nio.NioClientBoss.processSelectedKeys(NioClientBoss.java:105)
[junit] at
org.jboss.netty.channel.socket.nio.NioClientBoss.process(NioClientBoss.java:79)
[junit] at
org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
[junit] at
org.jboss.netty.channel.socket.nio.NioClientBoss.run(NioClientBoss.java:42)
[junit] at
org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
[junit] at
org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
[junit] at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[junit] at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[junit] at java.lang.Thread.run(Thread.java:748)
[junit] 2017-07-27 22:39:18,462
[jira] [Commented] (ZOOKEEPER-2829) Interface usability / compatibility improvements through Java annotation.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104031#comment-16104031 ] ASF GitHub Bot commented on ZOOKEEPER-2829: --- Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/316 > Interface usability / compatibility improvements through Java annotation. > - > > Key: ZOOKEEPER-2829 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2829 > Project: ZooKeeper > Issue Type: Improvement > Components: java client, server >Affects Versions: 3.4.10, 3.5.3 >Reporter: Michael Han >Assignee: Abraham Fine > Labels: annotation > > Hadoop has interface classification regarding the interfaces' scope and > stability. ZK should do something similar, which not only provides additional > benefits of making API compatibility easier between releases (or even > commits, by automating the checks via some tooling), but also consistent with > rest of Hadoop ecosystem. > See HADOOP-5073 for more context. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] zookeeper pull request #316: ZOOKEEPER-2829: Interface usability / compatibi...
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/316 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
ZooKeeper-trunk-jdk8 - Build # 1143 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/1143/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 64.58 MB...] [junit] 2017-07-27 22:15:52,125 [myid:127.0.0.1:13979] - WARN [main-SendThread(127.0.0.1:13979):ClientCnxn$SendThread@1235] - Session 0x104ff8aba91 for server 127.0.0.1/127.0.0.1:13979, unexpected error, closing socket connection and attempting reconnect [junit] java.net.ConnectException: Connection refused [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214) [junit] 2017-07-27 22:15:52,364 [myid:127.0.0.1:13964] - INFO [main-SendThread(127.0.0.1:13964):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:13964. Will not attempt to authenticate using SASL (unknown error) [junit] 2017-07-27 22:15:52,364 [myid:127.0.0.1:13964] - WARN [main-SendThread(127.0.0.1:13964):ClientCnxn$SendThread@1235] - Session 0x104ff8a55b1 for server 127.0.0.1/127.0.0.1:13964, unexpected error, closing socket connection and attempting reconnect [junit] java.net.ConnectException: Connection refused [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214) [junit] 2017-07-27 22:15:52,380 [myid:] - INFO [ProcessThread(sid:0 cport:14161)::PrepRequestProcessor@614] - Processed session termination for sessionid: 0x104ff904197 [junit] 2017-07-27 22:15:52,383 [myid:] - INFO [SyncThread:0:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port14161,name1=Connections,name2=127.0.0.1,name3=0x104ff904197] [junit] 2017-07-27 22:15:52,384 [myid:] - INFO [main:ZooKeeper@1329] - Session: 0x104ff904197 closed [junit] 2017-07-27 22:15:52,384 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for session: 0x104ff904197 [junit] 2017-07-27 22:15:52,384 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 161560 [junit] 2017-07-27 22:15:52,384 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 864 [junit] 2017-07-27 22:15:52,384 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD testWatcherAutoResetWithLocal [junit] 2017-07-27 22:15:52,384 [myid:] - INFO [main:ClientBase@601] - tearDown starting [junit] 2017-07-27 22:15:52,384 [myid:] - INFO [main:ClientBase@571] - STOPPING server [junit] 2017-07-27 22:15:52,385 [myid:] - INFO [main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:14161 [junit] 2017-07-27 22:15:52,386 [myid:] - INFO [main:ZooKeeperServer@541] - shutting down [junit] 2017-07-27 22:15:52,386 [myid:] - ERROR [main:ZooKeeperServer@505] - ZKShutdownHandler is not registered, so ZooKeeper server won't take any action on ERROR or SHUTDOWN server state changes [junit] 2017-07-27 22:15:52,386 [myid:] - INFO [main:SessionTrackerImpl@232] - Shutting down [junit] 2017-07-27 22:15:52,387 [myid:] - INFO [main:PrepRequestProcessor@1008] - Shutting down [junit] 2017-07-27 22:15:52,387 [myid:] - INFO [main:SyncRequestProcessor@191] - Shutting down [junit] 2017-07-27 22:15:52,387 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited! [junit] 2017-07-27 22:15:52,387 [myid:] - INFO [main:FinalRequestProcessor@481] - shutdown of request processor complete [junit] 2017-07-27 22:15:52,387 [myid:] - INFO [ProcessThread(sid:0 cport:14161)::PrepRequestProcessor@155] - PrepRequestProcessor exited loop! [junit] 2017-07-27 22:15:52,387 [myid:] - INFO [main:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port14161,name1=InMemoryDataTree] [junit] 2017-07-27 22:15:52,388 [myid:] - INFO [main:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port14161] [junit] 2017-07-27 22:15:52,388 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 14161 [junit] 2017-07-27 22:15:52,388 [myid:] - INFO [main:JMXEnv@146] - ensureOnly:[] [junit] 2017-07-27 22:15:52,393 [myid:] - INFO [main:ClientBase@626] - fdcount after test is: 2550 at start it was 2550 [junit] 2017-07-27 22:15:52,393 [myid:] - INFO
ZooKeeper_branch35_jdk7 - Build # 1058 - Still Failing
See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/1058/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 185.12 MB...] [junit] 2017-07-27 22:04:12,451 [myid:] - INFO [ProcessThread(sid:0 cport:19547)::PrepRequestProcessor@611] - Processed session termination for sessionid: 0x105b1469d4e [junit] 2017-07-27 22:04:12,452 [myid:] - INFO [SyncThread:0:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port19547,name1=Connections,name2=127.0.0.1,name3=0x105b1469d4e] [junit] 2017-07-27 22:04:12,452 [myid:] - INFO [main:ZooKeeper@1331] - Session: 0x105b1469d4e closed [junit] 2017-07-27 22:04:12,452 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for session: 0x105b1469d4e [junit] 2017-07-27 22:04:12,452 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 221725 [junit] 2017-07-27 22:04:12,453 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 2431 [junit] 2017-07-27 22:04:12,453 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD testWatcherAutoResetWithLocal [junit] 2017-07-27 22:04:12,453 [myid:] - INFO [main:ClientBase@586] - tearDown starting [junit] 2017-07-27 22:04:12,453 [myid:] - INFO [main:ClientBase@556] - STOPPING server [junit] 2017-07-27 22:04:12,453 [myid:] - INFO [main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:19547 [junit] 2017-07-27 22:04:12,455 [myid:] - INFO [main:ZooKeeperServer@541] - shutting down [junit] 2017-07-27 22:04:12,455 [myid:] - ERROR [main:ZooKeeperServer@505] - ZKShutdownHandler is not registered, so ZooKeeper server won't take any action on ERROR or SHUTDOWN server state changes [junit] 2017-07-27 22:04:12,455 [myid:] - INFO [main:SessionTrackerImpl@232] - Shutting down [junit] 2017-07-27 22:04:12,455 [myid:] - INFO [main:PrepRequestProcessor@1005] - Shutting down [junit] 2017-07-27 22:04:12,456 [myid:] - INFO [main:SyncRequestProcessor@191] - Shutting down [junit] 2017-07-27 22:04:12,456 [myid:] - INFO [ProcessThread(sid:0 cport:19547)::PrepRequestProcessor@155] - PrepRequestProcessor exited loop! [junit] 2017-07-27 22:04:12,456 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited! [junit] 2017-07-27 22:04:12,456 [myid:] - INFO [main:FinalRequestProcessor@481] - shutdown of request processor complete [junit] 2017-07-27 22:04:12,456 [myid:] - INFO [main:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port19547,name1=InMemoryDataTree] [junit] 2017-07-27 22:04:12,456 [myid:] - INFO [main:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port19547] [junit] 2017-07-27 22:04:12,457 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 19547 [junit] 2017-07-27 22:04:12,457 [myid:] - INFO [main:JMXEnv@146] - ensureOnly:[] [junit] 2017-07-27 22:04:12,464 [myid:] - INFO [main:ClientBase@611] - fdcount after test is: 7158 at start it was 7158 [junit] 2017-07-27 22:04:12,464 [myid:] - INFO [main:ZKTestCase$1@68] - SUCCEEDED testWatcherAutoResetWithLocal [junit] 2017-07-27 22:04:12,464 [myid:] - INFO [main:ZKTestCase$1@63] - FINISHED testWatcherAutoResetWithLocal [junit] Tests run: 103, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 427.436 sec, Thread: 4, Class: org.apache.zookeeper.test.NioNettySuiteTest [junit] 2017-07-27 22:04:12,477 [myid:127.0.0.1:19350] - INFO [main-SendThread(127.0.0.1:19350):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:19350. Will not attempt to authenticate using SASL (unknown error) [junit] 2017-07-27 22:04:12,478 [myid:127.0.0.1:19350] - WARN [main-SendThread(127.0.0.1:19350):ClientCnxn$SendThread@1235] - Session 0x105b1407d8a0001 for server 127.0.0.1/127.0.0.1:19350, unexpected error, closing socket connection and attempting reconnect [junit] java.net.ConnectException: Connection refused [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744) [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214) [junit] 2017-07-27 22:04:12,550 [myid:127.0.0.1:19301] - INFO [main-SendThread(127.0.0.1:19301):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:19301. Will not attempt to authenticate using SASL (unknown error) [junit] 2017-07-27 22:04:12,551 [myid:127.0.0.1:19301] - WARN
[jira] [Resolved] (ZOOKEEPER-2491) C client build error in vs 2015
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han resolved ZOOKEEPER-2491. Resolution: Duplicate > C client build error in vs 2015 > > > Key: ZOOKEEPER-2491 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2491 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.5.2 > Environment: windows vs 2015 >Reporter: spooky000 >Assignee: Andrew Schwartzmeyer >Priority: Minor > Fix For: 3.5.4, 3.6.0 > > Attachments: ZOOKEEPER-2491.patch, ZOOKEEPER-2491.patch, > ZOOKEEPER-2491.patch > > > Visual Studio 2015 supports snprintf. > #define snprintf _snprintf throw error. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2491) C client build error in vs 2015
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103983#comment-16103983 ] Michael Han commented on ZOOKEEPER-2491: [~andschwa] There are two issues described in this JIRA actually - one is MSVC 15 finally implemented C99 complaint snprintf so we don't need define that in header, this is fixed by your patch. The other is how to deal with the fact that prior to MSVC 15 _snprintf does not add null terminator at end of buffer, and this discussion somehow got involved with legal / license issue. I think it's OK to close the JIRA, and let its scope only covers what the JIRA title describes. For the _snprintf MSVC complaint issue, if it turns out to be an issue we can create a separate JIRA to track it. > C client build error in vs 2015 > > > Key: ZOOKEEPER-2491 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2491 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.5.2 > Environment: windows vs 2015 >Reporter: spooky000 >Assignee: Andrew Schwartzmeyer >Priority: Minor > Fix For: 3.5.4, 3.6.0 > > Attachments: ZOOKEEPER-2491.patch, ZOOKEEPER-2491.patch, > ZOOKEEPER-2491.patch > > > Visual Studio 2015 supports snprintf. > #define snprintf _snprintf throw error. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2577) Flaky Test: org.apache.zookeeper.server.quorum.ReconfigDuringLeaderSyncTest.testDuringLeaderSync
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103964#comment-16103964
]
Hudson commented on ZOOKEEPER-2577:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #3479 (See
[https://builds.apache.org/job/ZooKeeper-trunk/3479/])
ZOOKEEPER-2577: Fix flaky testDuringLeaderSync test. (hanm: rev
32794ca5d5a233abc6e019b07aadbfd375060bbd)
* (edit)
src/java/test/org/apache/zookeeper/server/quorum/ReconfigDuringLeaderSyncTest.java
* (edit) src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java
* (edit) src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
> Flaky Test:
> org.apache.zookeeper.server.quorum.ReconfigDuringLeaderSyncTest.testDuringLeaderSync
>
>
> Key: ZOOKEEPER-2577
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2577
> Project: ZooKeeper
> Issue Type: Test
> Components: tests
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
> Labels: flaky, flaky-test
> Fix For: 3.5.4, 3.6.0
>
>
> {noformat}
> Error Message
> zoo.cfg.dynamic.next is not deleted.
> Stacktrace
> junit.framework.AssertionFailedError: zoo.cfg.dynamic.next is not deleted.
> at
> org.apache.zookeeper.server.quorum.ReconfigDuringLeaderSyncTest.testDuringLeaderSync(ReconfigDuringLeaderSyncTest.java:155)
> at
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)
> Standard Output
> 2016-09-13 05:09:25,247 [myid:] - INFO [main:JUnit4ZKTestRunner@47] - No
> test.method specified. using default methods.
> 2016-09-13 05:09:25,349 [myid:] - INFO [main:JUnit4ZKTestRunner@47] - No
> test.method specified. using default methods.
> 2016-09-13 05:09:25,370 [myid:] - INFO [main:ZKTestCase$1@55] - STARTING
> testDuringLeaderSync
> 2016-09-13 05:09:25,372 [myid:] - INFO
> [main:JUnit4ZKTestRunner$LoggedInvokeMethod@77] - RUNNING TEST METHOD
> testDuringLeaderSync
> 2016-09-13 05:09:25,375 [myid:] - INFO [main:PortAssignment@151] - Test
> process 2/8 using ports from 13914 - 16606.
> 2016-09-13 05:09:25,380 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13915 from range 13914 - 16606.
> 2016-09-13 05:09:25,380 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13916 from range 13914 - 16606.
> 2016-09-13 05:09:25,381 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13917 from range 13914 - 16606.
> 2016-09-13 05:09:25,381 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13918 from range 13914 - 16606.
> 2016-09-13 05:09:25,381 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13919 from range 13914 - 16606.
> 2016-09-13 05:09:25,382 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13920 from range 13914 - 16606.
> 2016-09-13 05:09:25,382 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13921 from range 13914 - 16606.
> 2016-09-13 05:09:25,382 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13922 from range 13914 - 16606.
> 2016-09-13 05:09:25,383 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13923 from range 13914 - 16606.
> 2016-09-13 05:09:25,406 [myid:] - INFO
> [main:QuorumPeerTestBase$MainThread@131] - id = 0 tmpDir =
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test8397079557861207505.junit.dir
> clientPort = 13915 adminServerPort = 8080
> 2016-09-13 05:09:25,416 [myid:] - INFO
> [main:QuorumPeerTestBase$MainThread@131] - id = 1 tmpDir =
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test176919429940621.junit.dir
> clientPort = 13918 adminServerPort = 8080
> 2016-09-13 05:09:25,420 [myid:] - INFO
> [main:QuorumPeerTestBase$MainThread@131] - id = 2 tmpDir =
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test5455612786130415623.junit.dir
> clientPort = 13921 adminServerPort = 8080
> 2016-09-13 05:09:25,422 [myid:] - INFO [Thread-0:QuorumPeerConfig@116] -
> Reading configuration from:
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test8397079557861207505.junit.dir/zoo.cfg
> 2016-09-13 05:09:25,422 [myid:] - INFO [Thread-2:QuorumPeerConfig@116] -
> Reading configuration from:
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test5455612786130415623.junit.dir/zoo.cfg
> 2016-09-13 05:09:25,422 [myid:] - INFO [Thread-1:QuorumPeerConfig@116] -
> Reading configuration from:
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test176919429940621.junit.dir/zoo.cfg
> 2016-09-13 05:09:25,424 [myid:] - INFO [main:FourLetterWordMain@85] -
> connecting to 127.0.0.1 13915
> 2016-09-13
[jira] [Resolved] (ZOOKEEPER-2577) Flaky Test: org.apache.zookeeper.server.quorum.ReconfigDuringLeaderSyncTest.testDuringLeaderSync
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Han resolved ZOOKEEPER-2577.
Resolution: Fixed
Fix Version/s: 3.5.4
> Flaky Test:
> org.apache.zookeeper.server.quorum.ReconfigDuringLeaderSyncTest.testDuringLeaderSync
>
>
> Key: ZOOKEEPER-2577
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2577
> Project: ZooKeeper
> Issue Type: Test
> Components: tests
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
> Labels: flaky, flaky-test
> Fix For: 3.5.4, 3.6.0
>
>
> {noformat}
> Error Message
> zoo.cfg.dynamic.next is not deleted.
> Stacktrace
> junit.framework.AssertionFailedError: zoo.cfg.dynamic.next is not deleted.
> at
> org.apache.zookeeper.server.quorum.ReconfigDuringLeaderSyncTest.testDuringLeaderSync(ReconfigDuringLeaderSyncTest.java:155)
> at
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)
> Standard Output
> 2016-09-13 05:09:25,247 [myid:] - INFO [main:JUnit4ZKTestRunner@47] - No
> test.method specified. using default methods.
> 2016-09-13 05:09:25,349 [myid:] - INFO [main:JUnit4ZKTestRunner@47] - No
> test.method specified. using default methods.
> 2016-09-13 05:09:25,370 [myid:] - INFO [main:ZKTestCase$1@55] - STARTING
> testDuringLeaderSync
> 2016-09-13 05:09:25,372 [myid:] - INFO
> [main:JUnit4ZKTestRunner$LoggedInvokeMethod@77] - RUNNING TEST METHOD
> testDuringLeaderSync
> 2016-09-13 05:09:25,375 [myid:] - INFO [main:PortAssignment@151] - Test
> process 2/8 using ports from 13914 - 16606.
> 2016-09-13 05:09:25,380 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13915 from range 13914 - 16606.
> 2016-09-13 05:09:25,380 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13916 from range 13914 - 16606.
> 2016-09-13 05:09:25,381 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13917 from range 13914 - 16606.
> 2016-09-13 05:09:25,381 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13918 from range 13914 - 16606.
> 2016-09-13 05:09:25,381 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13919 from range 13914 - 16606.
> 2016-09-13 05:09:25,382 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13920 from range 13914 - 16606.
> 2016-09-13 05:09:25,382 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13921 from range 13914 - 16606.
> 2016-09-13 05:09:25,382 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13922 from range 13914 - 16606.
> 2016-09-13 05:09:25,383 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13923 from range 13914 - 16606.
> 2016-09-13 05:09:25,406 [myid:] - INFO
> [main:QuorumPeerTestBase$MainThread@131] - id = 0 tmpDir =
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test8397079557861207505.junit.dir
> clientPort = 13915 adminServerPort = 8080
> 2016-09-13 05:09:25,416 [myid:] - INFO
> [main:QuorumPeerTestBase$MainThread@131] - id = 1 tmpDir =
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test176919429940621.junit.dir
> clientPort = 13918 adminServerPort = 8080
> 2016-09-13 05:09:25,420 [myid:] - INFO
> [main:QuorumPeerTestBase$MainThread@131] - id = 2 tmpDir =
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test5455612786130415623.junit.dir
> clientPort = 13921 adminServerPort = 8080
> 2016-09-13 05:09:25,422 [myid:] - INFO [Thread-0:QuorumPeerConfig@116] -
> Reading configuration from:
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test8397079557861207505.junit.dir/zoo.cfg
> 2016-09-13 05:09:25,422 [myid:] - INFO [Thread-2:QuorumPeerConfig@116] -
> Reading configuration from:
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test5455612786130415623.junit.dir/zoo.cfg
> 2016-09-13 05:09:25,422 [myid:] - INFO [Thread-1:QuorumPeerConfig@116] -
> Reading configuration from:
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test176919429940621.junit.dir/zoo.cfg
> 2016-09-13 05:09:25,424 [myid:] - INFO [main:FourLetterWordMain@85] -
> connecting to 127.0.0.1 13915
> 2016-09-13 05:09:25,425 [myid:] - INFO [Thread-0:QuorumPeerConfig@318] -
> clientPortAddress is 0.0.0.0/0.0.0.0:13915
> 2016-09-13 05:09:25,425 [myid:] - INFO [Thread-0:QuorumPeerConfig@322] -
> secureClientPort is not set
> 2016-09-13 05:09:25,425 [myid:] - INFO [Thread-1:QuorumPeerConfig@318] -
> clientPortAddress is 0.0.0.0/0.0.0.0:13918
> 2016-09-13 05:09:25,425 [myid:] - INFO [Thread-1:QuorumPeerConfig@322] -
> secureClientPort is not set
>
[jira] [Commented] (ZOOKEEPER-2577) Flaky Test: org.apache.zookeeper.server.quorum.ReconfigDuringLeaderSyncTest.testDuringLeaderSync
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103923#comment-16103923
]
Michael Han commented on ZOOKEEPER-2577:
Committed.
Master:
https://github.com/apache/zookeeper/commit/32794ca5d5a233abc6e019b07aadbfd375060bbd
branch-3.5:
https://github.com/apache/zookeeper/commit/837b37636201ee9aca4cbbb962d18a7883e14c1b
> Flaky Test:
> org.apache.zookeeper.server.quorum.ReconfigDuringLeaderSyncTest.testDuringLeaderSync
>
>
> Key: ZOOKEEPER-2577
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2577
> Project: ZooKeeper
> Issue Type: Test
> Components: tests
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
> Labels: flaky, flaky-test
> Fix For: 3.6.0
>
>
> {noformat}
> Error Message
> zoo.cfg.dynamic.next is not deleted.
> Stacktrace
> junit.framework.AssertionFailedError: zoo.cfg.dynamic.next is not deleted.
> at
> org.apache.zookeeper.server.quorum.ReconfigDuringLeaderSyncTest.testDuringLeaderSync(ReconfigDuringLeaderSyncTest.java:155)
> at
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)
> Standard Output
> 2016-09-13 05:09:25,247 [myid:] - INFO [main:JUnit4ZKTestRunner@47] - No
> test.method specified. using default methods.
> 2016-09-13 05:09:25,349 [myid:] - INFO [main:JUnit4ZKTestRunner@47] - No
> test.method specified. using default methods.
> 2016-09-13 05:09:25,370 [myid:] - INFO [main:ZKTestCase$1@55] - STARTING
> testDuringLeaderSync
> 2016-09-13 05:09:25,372 [myid:] - INFO
> [main:JUnit4ZKTestRunner$LoggedInvokeMethod@77] - RUNNING TEST METHOD
> testDuringLeaderSync
> 2016-09-13 05:09:25,375 [myid:] - INFO [main:PortAssignment@151] - Test
> process 2/8 using ports from 13914 - 16606.
> 2016-09-13 05:09:25,380 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13915 from range 13914 - 16606.
> 2016-09-13 05:09:25,380 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13916 from range 13914 - 16606.
> 2016-09-13 05:09:25,381 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13917 from range 13914 - 16606.
> 2016-09-13 05:09:25,381 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13918 from range 13914 - 16606.
> 2016-09-13 05:09:25,381 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13919 from range 13914 - 16606.
> 2016-09-13 05:09:25,382 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13920 from range 13914 - 16606.
> 2016-09-13 05:09:25,382 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13921 from range 13914 - 16606.
> 2016-09-13 05:09:25,382 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13922 from range 13914 - 16606.
> 2016-09-13 05:09:25,383 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13923 from range 13914 - 16606.
> 2016-09-13 05:09:25,406 [myid:] - INFO
> [main:QuorumPeerTestBase$MainThread@131] - id = 0 tmpDir =
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test8397079557861207505.junit.dir
> clientPort = 13915 adminServerPort = 8080
> 2016-09-13 05:09:25,416 [myid:] - INFO
> [main:QuorumPeerTestBase$MainThread@131] - id = 1 tmpDir =
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test176919429940621.junit.dir
> clientPort = 13918 adminServerPort = 8080
> 2016-09-13 05:09:25,420 [myid:] - INFO
> [main:QuorumPeerTestBase$MainThread@131] - id = 2 tmpDir =
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test5455612786130415623.junit.dir
> clientPort = 13921 adminServerPort = 8080
> 2016-09-13 05:09:25,422 [myid:] - INFO [Thread-0:QuorumPeerConfig@116] -
> Reading configuration from:
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test8397079557861207505.junit.dir/zoo.cfg
> 2016-09-13 05:09:25,422 [myid:] - INFO [Thread-2:QuorumPeerConfig@116] -
> Reading configuration from:
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test5455612786130415623.junit.dir/zoo.cfg
> 2016-09-13 05:09:25,422 [myid:] - INFO [Thread-1:QuorumPeerConfig@116] -
> Reading configuration from:
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test176919429940621.junit.dir/zoo.cfg
> 2016-09-13 05:09:25,424 [myid:] - INFO [main:FourLetterWordMain@85] -
> connecting to 127.0.0.1 13915
> 2016-09-13 05:09:25,425 [myid:] - INFO [Thread-0:QuorumPeerConfig@318] -
> clientPortAddress is 0.0.0.0/0.0.0.0:13915
> 2016-09-13 05:09:25,425 [myid:] - INFO [Thread-0:QuorumPeerConfig@322] -
> secureClientPort is not set
> 2016-09-13 05:09:25,425 [myid:] - INFO
[jira] [Commented] (ZOOKEEPER-2577) Flaky Test: org.apache.zookeeper.server.quorum.ReconfigDuringLeaderSyncTest.testDuringLeaderSync
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103918#comment-16103918
]
ASF GitHub Bot commented on ZOOKEEPER-2577:
---
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/315
> Flaky Test:
> org.apache.zookeeper.server.quorum.ReconfigDuringLeaderSyncTest.testDuringLeaderSync
>
>
> Key: ZOOKEEPER-2577
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2577
> Project: ZooKeeper
> Issue Type: Test
> Components: tests
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
> Labels: flaky, flaky-test
> Fix For: 3.6.0
>
>
> {noformat}
> Error Message
> zoo.cfg.dynamic.next is not deleted.
> Stacktrace
> junit.framework.AssertionFailedError: zoo.cfg.dynamic.next is not deleted.
> at
> org.apache.zookeeper.server.quorum.ReconfigDuringLeaderSyncTest.testDuringLeaderSync(ReconfigDuringLeaderSyncTest.java:155)
> at
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)
> Standard Output
> 2016-09-13 05:09:25,247 [myid:] - INFO [main:JUnit4ZKTestRunner@47] - No
> test.method specified. using default methods.
> 2016-09-13 05:09:25,349 [myid:] - INFO [main:JUnit4ZKTestRunner@47] - No
> test.method specified. using default methods.
> 2016-09-13 05:09:25,370 [myid:] - INFO [main:ZKTestCase$1@55] - STARTING
> testDuringLeaderSync
> 2016-09-13 05:09:25,372 [myid:] - INFO
> [main:JUnit4ZKTestRunner$LoggedInvokeMethod@77] - RUNNING TEST METHOD
> testDuringLeaderSync
> 2016-09-13 05:09:25,375 [myid:] - INFO [main:PortAssignment@151] - Test
> process 2/8 using ports from 13914 - 16606.
> 2016-09-13 05:09:25,380 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13915 from range 13914 - 16606.
> 2016-09-13 05:09:25,380 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13916 from range 13914 - 16606.
> 2016-09-13 05:09:25,381 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13917 from range 13914 - 16606.
> 2016-09-13 05:09:25,381 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13918 from range 13914 - 16606.
> 2016-09-13 05:09:25,381 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13919 from range 13914 - 16606.
> 2016-09-13 05:09:25,382 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13920 from range 13914 - 16606.
> 2016-09-13 05:09:25,382 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13921 from range 13914 - 16606.
> 2016-09-13 05:09:25,382 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13922 from range 13914 - 16606.
> 2016-09-13 05:09:25,383 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13923 from range 13914 - 16606.
> 2016-09-13 05:09:25,406 [myid:] - INFO
> [main:QuorumPeerTestBase$MainThread@131] - id = 0 tmpDir =
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test8397079557861207505.junit.dir
> clientPort = 13915 adminServerPort = 8080
> 2016-09-13 05:09:25,416 [myid:] - INFO
> [main:QuorumPeerTestBase$MainThread@131] - id = 1 tmpDir =
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test176919429940621.junit.dir
> clientPort = 13918 adminServerPort = 8080
> 2016-09-13 05:09:25,420 [myid:] - INFO
> [main:QuorumPeerTestBase$MainThread@131] - id = 2 tmpDir =
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test5455612786130415623.junit.dir
> clientPort = 13921 adminServerPort = 8080
> 2016-09-13 05:09:25,422 [myid:] - INFO [Thread-0:QuorumPeerConfig@116] -
> Reading configuration from:
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test8397079557861207505.junit.dir/zoo.cfg
> 2016-09-13 05:09:25,422 [myid:] - INFO [Thread-2:QuorumPeerConfig@116] -
> Reading configuration from:
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test5455612786130415623.junit.dir/zoo.cfg
> 2016-09-13 05:09:25,422 [myid:] - INFO [Thread-1:QuorumPeerConfig@116] -
> Reading configuration from:
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test176919429940621.junit.dir/zoo.cfg
> 2016-09-13 05:09:25,424 [myid:] - INFO [main:FourLetterWordMain@85] -
> connecting to 127.0.0.1 13915
> 2016-09-13 05:09:25,425 [myid:] - INFO [Thread-0:QuorumPeerConfig@318] -
> clientPortAddress is 0.0.0.0/0.0.0.0:13915
> 2016-09-13 05:09:25,425 [myid:] - INFO [Thread-0:QuorumPeerConfig@322] -
> secureClientPort is not set
> 2016-09-13 05:09:25,425 [myid:] - INFO [Thread-1:QuorumPeerConfig@318] -
> clientPortAddress is 0.0.0.0/0.0.0.0:13918
> 2016-09-13 05:09:25,425
[GitHub] zookeeper pull request #315: ZOOKEEPER-2577: Fix flaky testDuringLeaderSync ...
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/315 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (ZOOKEEPER-2577) Flaky Test: org.apache.zookeeper.server.quorum.ReconfigDuringLeaderSyncTest.testDuringLeaderSync
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103892#comment-16103892
]
ASF GitHub Bot commented on ZOOKEEPER-2577:
---
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/315#discussion_r129956031
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -1451,7 +1452,12 @@ public synchronized void
restartLeaderElection(QuorumVerifier qvOLD, QuorumVerif
}
public String getNextDynamicConfigFilename() {
-return configFilename +
QuorumPeerConfig.nextDynamicConfigFileSuffix;
+if (configFilename != null) {
--- End diff --
Update pull request based on offline chat with Alex. The idea is to detect
the null cases for configFileName and for those cases don't write intermediate
reconfig file to disk because if we do, the shared "null.dynamic.cfg" file will
be overwritten and might likely break other things without notice.
> Flaky Test:
> org.apache.zookeeper.server.quorum.ReconfigDuringLeaderSyncTest.testDuringLeaderSync
>
>
> Key: ZOOKEEPER-2577
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2577
> Project: ZooKeeper
> Issue Type: Test
> Components: tests
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
> Labels: flaky, flaky-test
> Fix For: 3.6.0
>
>
> {noformat}
> Error Message
> zoo.cfg.dynamic.next is not deleted.
> Stacktrace
> junit.framework.AssertionFailedError: zoo.cfg.dynamic.next is not deleted.
> at
> org.apache.zookeeper.server.quorum.ReconfigDuringLeaderSyncTest.testDuringLeaderSync(ReconfigDuringLeaderSyncTest.java:155)
> at
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)
> Standard Output
> 2016-09-13 05:09:25,247 [myid:] - INFO [main:JUnit4ZKTestRunner@47] - No
> test.method specified. using default methods.
> 2016-09-13 05:09:25,349 [myid:] - INFO [main:JUnit4ZKTestRunner@47] - No
> test.method specified. using default methods.
> 2016-09-13 05:09:25,370 [myid:] - INFO [main:ZKTestCase$1@55] - STARTING
> testDuringLeaderSync
> 2016-09-13 05:09:25,372 [myid:] - INFO
> [main:JUnit4ZKTestRunner$LoggedInvokeMethod@77] - RUNNING TEST METHOD
> testDuringLeaderSync
> 2016-09-13 05:09:25,375 [myid:] - INFO [main:PortAssignment@151] - Test
> process 2/8 using ports from 13914 - 16606.
> 2016-09-13 05:09:25,380 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13915 from range 13914 - 16606.
> 2016-09-13 05:09:25,380 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13916 from range 13914 - 16606.
> 2016-09-13 05:09:25,381 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13917 from range 13914 - 16606.
> 2016-09-13 05:09:25,381 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13918 from range 13914 - 16606.
> 2016-09-13 05:09:25,381 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13919 from range 13914 - 16606.
> 2016-09-13 05:09:25,382 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13920 from range 13914 - 16606.
> 2016-09-13 05:09:25,382 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13921 from range 13914 - 16606.
> 2016-09-13 05:09:25,382 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13922 from range 13914 - 16606.
> 2016-09-13 05:09:25,383 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13923 from range 13914 - 16606.
> 2016-09-13 05:09:25,406 [myid:] - INFO
> [main:QuorumPeerTestBase$MainThread@131] - id = 0 tmpDir =
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test8397079557861207505.junit.dir
> clientPort = 13915 adminServerPort = 8080
> 2016-09-13 05:09:25,416 [myid:] - INFO
> [main:QuorumPeerTestBase$MainThread@131] - id = 1 tmpDir =
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test176919429940621.junit.dir
> clientPort = 13918 adminServerPort = 8080
> 2016-09-13 05:09:25,420 [myid:] - INFO
> [main:QuorumPeerTestBase$MainThread@131] - id = 2 tmpDir =
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test5455612786130415623.junit.dir
> clientPort = 13921 adminServerPort = 8080
> 2016-09-13 05:09:25,422 [myid:] - INFO [Thread-0:QuorumPeerConfig@116] -
> Reading configuration from:
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test8397079557861207505.junit.dir/zoo.cfg
> 2016-09-13 05:09:25,422 [myid:] - INFO [Thread-2:QuorumPeerConfig@116] -
> Reading configuration from:
>
[GitHub] zookeeper pull request #315: ZOOKEEPER-2577: Fix flaky testDuringLeaderSync ...
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/315#discussion_r129956031
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -1451,7 +1452,12 @@ public synchronized void
restartLeaderElection(QuorumVerifier qvOLD, QuorumVerif
}
public String getNextDynamicConfigFilename() {
-return configFilename +
QuorumPeerConfig.nextDynamicConfigFileSuffix;
+if (configFilename != null) {
--- End diff --
Update pull request based on offline chat with Alex. The idea is to detect
the null cases for configFileName and for those cases don't write intermediate
reconfig file to disk because if we do, the shared "null.dynamic.cfg" file will
be overwritten and might likely break other things without notice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (ZOOKEEPER-2829) Interface usability / compatibility improvements through Java annotation.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103886#comment-16103886 ] ASF GitHub Bot commented on ZOOKEEPER-2829: --- Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/316 Sounds good to me - my concern was that these empty packages should be removed but since Hadoop and Hbase also has this "feature", and removing them default the purpose of the annotation, I am OK with current approach. I also verified the new javadoc with "ant javadoc", the newly added classes / APIs also look good. Overall LGTM, good work @afine. Will merge soon. > Interface usability / compatibility improvements through Java annotation. > - > > Key: ZOOKEEPER-2829 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2829 > Project: ZooKeeper > Issue Type: Improvement > Components: java client, server >Affects Versions: 3.4.10, 3.5.3 >Reporter: Michael Han >Assignee: Abraham Fine > Labels: annotation > > Hadoop has interface classification regarding the interfaces' scope and > stability. ZK should do something similar, which not only provides additional > benefits of making API compatibility easier between releases (or even > commits, by automating the checks via some tooling), but also consistent with > rest of Hadoop ecosystem. > See HADOOP-5073 for more context. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] zookeeper issue #316: ZOOKEEPER-2829: Interface usability / compatibility im...
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/316 Sounds good to me - my concern was that these empty packages should be removed but since Hadoop and Hbase also has this "feature", and removing them default the purpose of the annotation, I am OK with current approach. I also verified the new javadoc with "ant javadoc", the newly added classes / APIs also look good. Overall LGTM, good work @afine. Will merge soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (ZOOKEEPER-2577) Flaky Test: org.apache.zookeeper.server.quorum.ReconfigDuringLeaderSyncTest.testDuringLeaderSync
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103872#comment-16103872
]
Hadoop QA commented on ZOOKEEPER-2577:
--
+1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/905//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/905//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/905//console
This message is automatically generated.
> Flaky Test:
> org.apache.zookeeper.server.quorum.ReconfigDuringLeaderSyncTest.testDuringLeaderSync
>
>
> Key: ZOOKEEPER-2577
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2577
> Project: ZooKeeper
> Issue Type: Test
> Components: tests
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
> Labels: flaky, flaky-test
> Fix For: 3.6.0
>
>
> {noformat}
> Error Message
> zoo.cfg.dynamic.next is not deleted.
> Stacktrace
> junit.framework.AssertionFailedError: zoo.cfg.dynamic.next is not deleted.
> at
> org.apache.zookeeper.server.quorum.ReconfigDuringLeaderSyncTest.testDuringLeaderSync(ReconfigDuringLeaderSyncTest.java:155)
> at
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)
> Standard Output
> 2016-09-13 05:09:25,247 [myid:] - INFO [main:JUnit4ZKTestRunner@47] - No
> test.method specified. using default methods.
> 2016-09-13 05:09:25,349 [myid:] - INFO [main:JUnit4ZKTestRunner@47] - No
> test.method specified. using default methods.
> 2016-09-13 05:09:25,370 [myid:] - INFO [main:ZKTestCase$1@55] - STARTING
> testDuringLeaderSync
> 2016-09-13 05:09:25,372 [myid:] - INFO
> [main:JUnit4ZKTestRunner$LoggedInvokeMethod@77] - RUNNING TEST METHOD
> testDuringLeaderSync
> 2016-09-13 05:09:25,375 [myid:] - INFO [main:PortAssignment@151] - Test
> process 2/8 using ports from 13914 - 16606.
> 2016-09-13 05:09:25,380 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13915 from range 13914 - 16606.
> 2016-09-13 05:09:25,380 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13916 from range 13914 - 16606.
> 2016-09-13 05:09:25,381 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13917 from range 13914 - 16606.
> 2016-09-13 05:09:25,381 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13918 from range 13914 - 16606.
> 2016-09-13 05:09:25,381 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13919 from range 13914 - 16606.
> 2016-09-13 05:09:25,382 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13920 from range 13914 - 16606.
> 2016-09-13 05:09:25,382 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13921 from range 13914 - 16606.
> 2016-09-13 05:09:25,382 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13922 from range 13914 - 16606.
> 2016-09-13 05:09:25,383 [myid:] - INFO [main:PortAssignment@85] - Assigned
> port 13923 from range 13914 - 16606.
> 2016-09-13 05:09:25,406 [myid:] - INFO
> [main:QuorumPeerTestBase$MainThread@131] - id = 0 tmpDir =
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test8397079557861207505.junit.dir
> clientPort = 13915 adminServerPort = 8080
> 2016-09-13 05:09:25,416 [myid:] - INFO
> [main:QuorumPeerTestBase$MainThread@131] - id = 1 tmpDir =
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test176919429940621.junit.dir
> clientPort = 13918 adminServerPort = 8080
> 2016-09-13 05:09:25,420 [myid:] - INFO
> [main:QuorumPeerTestBase$MainThread@131] - id = 2 tmpDir =
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test5455612786130415623.junit.dir
> clientPort = 13921 adminServerPort = 8080
> 2016-09-13 05:09:25,422 [myid:] - INFO [Thread-0:QuorumPeerConfig@116] -
> Reading configuration from:
>
Success: ZOOKEEPER- PreCommit Build #905
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/905/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 74.68 MB...] [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/905//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/905//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/905//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 755643d99e739f33ed2f600a0beb96430670effe logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: ‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’ and ‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’ are the same file BUILD SUCCESSFUL Total time: 18 minutes 0 seconds Archiving artifacts Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Recording test results Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 [description-setter] Description set: ZOOKEEPER-2577 Putting comment on the pull request Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Email was triggered for: Success Sending email for trigger: Success Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-2614) Port ZOOKEEPER-1576 to branch3.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103527#comment-16103527 ] Edward Ribeiro commented on ZOOKEEPER-2614: --- Hi Thomas, take a look at https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute on how to contribute via Github. I can take a look today yet or as soon as it is available. > Port ZOOKEEPER-1576 to branch3.4 > > > Key: ZOOKEEPER-2614 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2614 > Project: ZooKeeper > Issue Type: Bug >Affects Versions: 3.4.9 >Reporter: Vishal Khandelwal >Assignee: Vishal Khandelwal > Fix For: 3.4.11 > > Attachments: ZOOKEEPER-2614.branch-3.4.00.patch > > > ZOOKEEPER-1576 handles UnknownHostException and it good to have this change > for 3.4 branch as well. Porting the changes to 3.4 after resolving the > conflicts -- This message was sent by Atlassian JIRA (v6.4.14#64029)
ZooKeeper_branch34_openjdk7 - Build # 1589 - Still Failing
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1589/
###
## LAST 60 LINES OF THE CONSOLE
###
Started by timer
[EnvInject] - Loading node environment variables.
Building remotely on H21 (couchdbtest ubuntu xenial) in workspace
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7
Cloning the remote Git repository
Cloning repository git://git.apache.org/zookeeper.git
> git init /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7 #
> timeout=10
Fetching upstream changes from git://git.apache.org/zookeeper.git
> git --version # timeout=10
> git fetch --tags --progress git://git.apache.org/zookeeper.git
> +refs/heads/*:refs/remotes/origin/*
> git config remote.origin.url git://git.apache.org/zookeeper.git # timeout=10
> git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* #
> timeout=10
> git config remote.origin.url git://git.apache.org/zookeeper.git # timeout=10
Cleaning workspace
> git rev-parse --verify HEAD # timeout=10
No valid HEAD. Skipping the resetting
> git clean -fdx # timeout=10
Fetching upstream changes from git://git.apache.org/zookeeper.git
> git fetch --tags --progress git://git.apache.org/zookeeper.git
> +refs/heads/*:refs/remotes/origin/*
> git rev-parse refs/remotes/origin/branch-3.4^{commit} # timeout=10
> git rev-parse refs/remotes/origin/origin/branch-3.4^{commit} # timeout=10
Checking out Revision 90652669bece7bcde11e16df3f5722d80b3c5b31
(refs/remotes/origin/branch-3.4)
Commit message: "ZOOKEEPER-2856: ZooKeeperSaslClient#respondToServer should log
exception"
> git config core.sparsecheckout # timeout=10
> git checkout -f 90652669bece7bcde11e16df3f5722d80b3c5b31
> git rev-list 90652669bece7bcde11e16df3f5722d80b3c5b31 # timeout=10
No emails were triggered.
[ZooKeeper_branch34_openjdk7] $
/home/jenkins/tools/ant/apache-ant-1.9.9/bin/ant -Dtest.output=yes
-Dtest.junit.threads=8 -Dtest.junit.output.format=xml -Djavac.target=1.7 clean
test-core-java
Error: JAVA_HOME is not defined correctly.
We cannot execute /usr/lib/jvm/java-7-openjdk-amd64//bin/java
Build step 'Invoke Ant' marked build as failure
Recording test results
ERROR: Step ?Publish JUnit test result report? failed: No test report files
were found. Configuration error?
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
###
## FAILED TESTS (if any)
##
No tests ran.
ZooKeeper_branch35_jdk8 - Build # 614 - Still Failing
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/614/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 68.91 MB...] [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214) [junit] 2017-07-27 12:35:46,366 [myid:] - INFO [main:ZooKeeper@1331] - Session: 0x106c9dac995 closed [junit] 2017-07-27 12:35:46,366 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for session: 0x106c9dac995 [junit] 2017-07-27 12:35:46,367 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 59031 [junit] 2017-07-27 12:35:46,367 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 470 [junit] 2017-07-27 12:35:46,367 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD testWatcherAutoResetWithLocal [junit] 2017-07-27 12:35:46,367 [myid:] - INFO [main:ClientBase@586] - tearDown starting [junit] 2017-07-27 12:35:46,367 [myid:] - INFO [main:ClientBase@556] - STOPPING server [junit] 2017-07-27 12:35:46,367 [myid:] - INFO [main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:27626 [junit] 2017-07-27 12:35:46,368 [myid:] - INFO [main:ZooKeeperServer@541] - shutting down [junit] 2017-07-27 12:35:46,368 [myid:] - ERROR [main:ZooKeeperServer@505] - ZKShutdownHandler is not registered, so ZooKeeper server won't take any action on ERROR or SHUTDOWN server state changes [junit] 2017-07-27 12:35:46,368 [myid:] - INFO [main:SessionTrackerImpl@232] - Shutting down [junit] 2017-07-27 12:35:46,368 [myid:] - INFO [main:PrepRequestProcessor@1005] - Shutting down [junit] 2017-07-27 12:35:46,369 [myid:] - INFO [main:SyncRequestProcessor@191] - Shutting down [junit] 2017-07-27 12:35:46,369 [myid:] - INFO [ProcessThread(sid:0 cport:27626)::PrepRequestProcessor@155] - PrepRequestProcessor exited loop! [junit] 2017-07-27 12:35:46,369 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited! [junit] 2017-07-27 12:35:46,369 [myid:] - INFO [main:FinalRequestProcessor@481] - shutdown of request processor complete [junit] 2017-07-27 12:35:46,369 [myid:] - INFO [main:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port27626,name1=InMemoryDataTree] [junit] 2017-07-27 12:35:46,369 [myid:] - INFO [main:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port27626] [junit] 2017-07-27 12:35:46,369 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 27626 [junit] 2017-07-27 12:35:46,370 [myid:] - INFO [main:JMXEnv@146] - ensureOnly:[] [junit] 2017-07-27 12:35:46,373 [myid:] - INFO [main:ClientBase@611] - fdcount after test is: 1409 at start it was 1413 [junit] 2017-07-27 12:35:46,373 [myid:] - INFO [main:ZKTestCase$1@68] - SUCCEEDED testWatcherAutoResetWithLocal [junit] 2017-07-27 12:35:46,373 [myid:] - INFO [main:ZKTestCase$1@63] - FINISHED testWatcherAutoResetWithLocal [junit] Tests run: 103, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 440.886 sec, Thread: 7, Class: org.apache.zookeeper.test.NioNettySuiteTest [junit] 2017-07-27 12:35:46,562 [myid:127.0.0.1:27503] - INFO [main-SendThread(127.0.0.1:27503):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:27503. Will not attempt to authenticate using SASL (unknown error) [junit] 2017-07-27 12:35:46,563 [myid:127.0.0.1:27503] - WARN [main-SendThread(127.0.0.1:27503):ClientCnxn$SendThread@1235] - Session 0x106c9d751a2 for server 127.0.0.1/127.0.0.1:27503, unexpected error, closing socket connection and attempting reconnect [junit] java.net.ConnectException: Connection refused [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214) [junit] 2017-07-27 12:35:46,752 [myid:127.0.0.1:27444] - INFO [main-SendThread(127.0.0.1:27444):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:27444. Will not attempt to authenticate using SASL (unknown error) [junit] 2017-07-27 12:35:46,752 [myid:127.0.0.1:27444] - WARN [main-SendThread(127.0.0.1:27444):ClientCnxn$SendThread@1235] - Session 0x106c9d4f8b6 for server 127.0.0.1/127.0.0.1:27444, unexpected error, closing socket connection and attempting reconnect [junit]
ZooKeeper-trunk-jdk8 - Build # 1142 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/1142/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 66.22 MB...] [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214) [junit] 2017-07-27 12:23:34,313 [myid:127.0.0.1:19301] - INFO [main-SendThread(127.0.0.1:19301):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:19301. Will not attempt to authenticate using SASL (unknown error) [junit] 2017-07-27 12:23:34,313 [myid:127.0.0.1:19301] - WARN [main-SendThread(127.0.0.1:19301):ClientCnxn$SendThread@1235] - Session 0x4fd6469280001 for server 127.0.0.1/127.0.0.1:19301, unexpected error, closing socket connection and attempting reconnect [junit] java.net.ConnectException: Connection refused [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214) [junit] 2017-07-27 12:23:34,946 [myid:127.0.0.1:19304] - INFO [main-SendThread(127.0.0.1:19304):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:19304. Will not attempt to authenticate using SASL (unknown error) [junit] 2017-07-27 12:23:34,946 [myid:127.0.0.1:19304] - WARN [main-SendThread(127.0.0.1:19304):ClientCnxn$SendThread@1235] - Session 0x104fd646aec for server 127.0.0.1/127.0.0.1:19304, unexpected error, closing socket connection and attempting reconnect [junit] java.net.ConnectException: Connection refused [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214) [junit] 2017-07-27 12:23:35,551 [myid:127.0.0.1:19301] - INFO [main-SendThread(127.0.0.1:19301):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:19301. Will not attempt to authenticate using SASL (unknown error) [junit] 2017-07-27 12:23:35,551 [myid:127.0.0.1:19301] - WARN [main-SendThread(127.0.0.1:19301):ClientCnxn$SendThread@1235] - Session 0x4fd646928 for server 127.0.0.1/127.0.0.1:19301, unexpected error, closing socket connection and attempting reconnect [junit] java.net.ConnectException: Connection refused [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214) [junit] 2017-07-27 12:23:35,760 [myid:127.0.0.1:19304] - INFO [main-SendThread(127.0.0.1:19304):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:19304. Will not attempt to authenticate using SASL (unknown error) [junit] 2017-07-27 12:23:35,760 [myid:127.0.0.1:19304] - WARN [main-SendThread(127.0.0.1:19304):ClientCnxn$SendThread@1235] - Session 0x104fd646aec0001 for server 127.0.0.1/127.0.0.1:19304, unexpected error, closing socket connection and attempting reconnect [junit] java.net.ConnectException: Connection refused [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214) [junit] 2017-07-27 12:23:35,813 [myid:127.0.0.1:19301] - INFO [main-SendThread(127.0.0.1:19301):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:19301. Will not attempt to authenticate using SASL (unknown error) [junit] 2017-07-27 12:23:35,813 [myid:127.0.0.1:19301] - WARN [main-SendThread(127.0.0.1:19301):ClientCnxn$SendThread@1235] - Session 0x4fd6469280001 for server 127.0.0.1/127.0.0.1:19301, unexpected error, closing socket connection and attempting reconnect [junit] java.net.ConnectException: Connection refused [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357) [junit] at
[jira] [Commented] (ZOOKEEPER-2614) Port ZOOKEEPER-1576 to branch3.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103072#comment-16103072 ] Thomas Schüttel commented on ZOOKEEPER-2614: Hi Michael, thanks for assigning it to 3.4.11. Is there any way I can help in the process? Should I create PR out of the attached patch? > Port ZOOKEEPER-1576 to branch3.4 > > > Key: ZOOKEEPER-2614 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2614 > Project: ZooKeeper > Issue Type: Bug >Affects Versions: 3.4.9 >Reporter: Vishal Khandelwal >Assignee: Vishal Khandelwal > Fix For: 3.4.11 > > Attachments: ZOOKEEPER-2614.branch-3.4.00.patch > > > ZOOKEEPER-1576 handles UnknownHostException and it good to have this change > for 3.4 branch as well. Porting the changes to 3.4 after resolving the > conflicts -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (ZOOKEEPER-2860) Update sample server jaas config for kerberos auth
Andrey created ZOOKEEPER-2860:
-
Summary: Update sample server jaas config for kerberos auth
Key: ZOOKEEPER-2860
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2860
Project: ZooKeeper
Issue Type: Bug
Components: documentation
Reporter: Andrey
Currently sample server jaas configuration for kerberos contains:
{code}
principal="zookeeper/yourzkhostname"
{code}
Background on why "princinpal=SPN" and "isInitiator=true" won't work is here:
https://dmdaa.wordpress.com/2010/03/27/the-impact-of-isinitiator-on-jaas-login-configuration-and-the-role-if-spn/
Expected:
{code}
isInitiator=false
principal="zookeeper/yourzkhostname";
{code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
ZooKeeper_branch35_jdk7 - Build # 1057 - Still Failing
See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/1057/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 70.28 MB...] [junit] 2017-07-27 09:07:30,980 [myid:] - INFO [SyncThread:0:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port30319,name1=Connections,name2=127.0.0.1,name3=0x105ae49922a] [junit] 2017-07-27 09:07:30,980 [myid:] - INFO [main:ZooKeeper@1331] - Session: 0x105ae49922a closed [junit] 2017-07-27 09:07:30,980 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for session: 0x105ae49922a [junit] 2017-07-27 09:07:30,980 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 242356 [junit] 2017-07-27 09:07:30,980 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 2434 [junit] 2017-07-27 09:07:30,980 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD testWatcherAutoResetWithLocal [junit] 2017-07-27 09:07:30,980 [myid:] - INFO [main:ClientBase@586] - tearDown starting [junit] 2017-07-27 09:07:30,980 [myid:] - INFO [main:ClientBase@556] - STOPPING server [junit] 2017-07-27 09:07:30,981 [myid:] - INFO [main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:30319 [junit] 2017-07-27 09:07:30,981 [myid:127.0.0.1:30073] - INFO [main-SendThread(127.0.0.1:30073):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:30073. Will not attempt to authenticate using SASL (unknown error) [junit] 2017-07-27 09:07:30,981 [myid:127.0.0.1:30073] - WARN [main-SendThread(127.0.0.1:30073):ClientCnxn$SendThread@1235] - Session 0x105ae437c7d for server 127.0.0.1/127.0.0.1:30073, unexpected error, closing socket connection and attempting reconnect [junit] java.net.ConnectException: Connection refused [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744) [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214) [junit] 2017-07-27 09:07:30,987 [myid:] - INFO [main:ZooKeeperServer@541] - shutting down [junit] 2017-07-27 09:07:30,987 [myid:] - ERROR [main:ZooKeeperServer@505] - ZKShutdownHandler is not registered, so ZooKeeper server won't take any action on ERROR or SHUTDOWN server state changes [junit] 2017-07-27 09:07:30,987 [myid:] - INFO [main:SessionTrackerImpl@232] - Shutting down [junit] 2017-07-27 09:07:30,988 [myid:] - INFO [main:PrepRequestProcessor@1005] - Shutting down [junit] 2017-07-27 09:07:30,988 [myid:] - INFO [main:SyncRequestProcessor@191] - Shutting down [junit] 2017-07-27 09:07:30,988 [myid:] - INFO [ProcessThread(sid:0 cport:30319)::PrepRequestProcessor@155] - PrepRequestProcessor exited loop! [junit] 2017-07-27 09:07:30,988 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited! [junit] 2017-07-27 09:07:30,988 [myid:] - INFO [main:FinalRequestProcessor@481] - shutdown of request processor complete [junit] 2017-07-27 09:07:30,988 [myid:] - INFO [main:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port30319,name1=InMemoryDataTree] [junit] 2017-07-27 09:07:30,989 [myid:] - INFO [main:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port30319] [junit] 2017-07-27 09:07:30,989 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 30319 [junit] 2017-07-27 09:07:30,989 [myid:] - INFO [main:JMXEnv@146] - ensureOnly:[] [junit] 2017-07-27 09:07:30,998 [myid:] - INFO [main:ClientBase@611] - fdcount after test is: 7172 at start it was 7172 [junit] 2017-07-27 09:07:30,998 [myid:] - INFO [main:ZKTestCase$1@68] - SUCCEEDED testWatcherAutoResetWithLocal [junit] 2017-07-27 09:07:30,998 [myid:] - INFO [main:ZKTestCase$1@63] - FINISHED testWatcherAutoResetWithLocal [junit] Tests run: 103, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 405.4 sec, Thread: 8, Class: org.apache.zookeeper.test.NioNettySuiteTest [junit] 2017-07-27 09:07:31,277 [myid:127.0.0.1:30196] - INFO [main-SendThread(127.0.0.1:30196):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:30196. Will not attempt to authenticate using SASL (unknown error) [junit] 2017-07-27 09:07:31,278 [myid:127.0.0.1:30196] - WARN [main-SendThread(127.0.0.1:30196):ClientCnxn$SendThread@1235] - Session 0x105ae466471 for server 127.0.0.1/127.0.0.1:30196, unexpected error, closing socket connection and attempting reconnect
