[GitHub] zookeeper issue #686: Zookeeper 3167
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/686 - agree with this > Would be better to use key.startsWith(path) instead of contains to make sure the path starts with the parent's. - `getAllChildNumber` is just foreach the treemap,no limit may be also ok. but `setAcl ` does a recursion which really needs a limit.we can create a seperate jira to do this. > Have you considered limiting the access to this command? I'm not sure if it's needed (say we've merged the recursive flag of setAcl command recently which didn't have limits either) BTW. - this patch needs a unit test. - Do we need a CLI for this feature?we can create a seperate jira to do this. ---
回复：Re: asfgit commenting on PRs
+1,for removing the asfgit successful build comments. Best regards maoling Beijing,China - 原始邮件 - 发件人：Enrico Olivelli 收件人：dev@zookeeper.apache.org 主题：Re: asfgit commenting on PRs 日期：2018年11月06日 04点57分 Il lun 5 nov 2018, 21:28 Andor Molnar ha scritto: > I also feel the comments redundant. > Enrico - shall we remove this? > I will check, it should be a flag on job config Enrico > Andor > > > > > On 2018. Nov 5., at 12:24, Norbert Kalmar > wrote: > > > > Hi all, > > > > One of the recent development was that asfgit now comments on the PRs > every > > successful builds. > > But we do have the same information under "Show all checks". (This might > be > > gone after closing the PR though). > > > > I wouldn't mind the extra commit, but on github, in > > https://github.com/apache/zookeeper/pulls, we have multiple comments > > showing under every PR. Before this, for me at least, I used this to > > quickly identify the PRs which haven't been reviewed by anyone (having 0 > or > > 1 comments). Or to see quickly if something is getting a lot of attention > > lately, or getting updates etc. > > > > This was a convenient thing for me, of course not a feature I can't live > > without. I just wanted to ask other devs view on this. > > > > So, what's your view? :) > > > > Regards, > > Norbert > > -- -- Enrico Olivelli
[GitHub] zookeeper pull request #684: ZOOKEEPER-3180: Add response cache to improve t...
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r230973324
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/DumbWatcher.java ---
@@ -69,7 +69,7 @@ public void sendCloseSession() { }
void setSessionId(long sessionId) { }
@Override
-void sendBuffer(ByteBuffer closeConn) { }
+void sendBuffer(ByteBuffer... closeConn) { }
--- End diff --
Why have you changed the serialization logic to use multiple buffers
instead of a single one?
---
[GitHub] zookeeper pull request #684: ZOOKEEPER-3180: Add response cache to improve t...
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r230973619
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxn.java
---
@@ -151,12 +148,17 @@ void sendBufferSync(ByteBuffer bb) {
* sendBuffer pushes a byte buffer onto the outgoing buffer queue for
* asynchronous writes.
*/
-public void sendBuffer(ByteBuffer bb) {
+public void sendBuffer(ByteBuffer... buffers) {
if (LOG.isTraceEnabled()) {
LOG.trace("Add a buffer to outgoingBuffers, sk " + sk
+ " is valid: " + sk.isValid());
}
-outgoingBuffers.add(bb);
+synchronized (outgoingBuffers) {
--- End diff --
This synchronization had to be added, because of the ability to send
multiple byte buffers at once. What's the performance impact?
---
[GitHub] zookeeper pull request #684: ZOOKEEPER-3180: Add response cache to improve t...
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r230974144
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ResponseCache.java
---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.server;
+
+import java.util.Collections;
+import java.util.LinkedHashMap;
+import java.util.Map;
+
+import org.apache.jute.Record;
+import org.apache.zookeeper.data.Stat;
+
+@SuppressWarnings("serial")
+public class ResponseCache {
+private static final int DEFAULT_RESPONSE_CACHE_SIZE = 400;
+
+private static class Entry {
+public Stat stat;
+public byte[] data;
+}
+
+private Map cache = Collections.synchronizedMap(
+new LRUCache(getResponseCacheSize()));
+
+public ResponseCache() {
+}
+
+public void put(String path, byte[] data, Stat stat) {
+Entry entry = new Entry();
+entry.data = data;
+entry.stat = stat;
+cache.put(path, entry);
+}
+
+public byte[] get(String key, Stat stat) {
+Entry entry = cache.get(key);
+if (entry == null) {
+return null;
+}
+if (!stat.equals(entry.stat)) {
+// The node has been modified, invalidate cache.
+cache.remove(key);
+return null;
+} else {
+return entry.data;
+}
+}
+
+private static int getResponseCacheSize() {
+String value =
System.getProperty("zookeeper.maxResponseCacheSize");
+return value == null ? DEFAULT_RESPONSE_CACHE_SIZE :
Integer.parseInt(value);
+}
+
+public static boolean isEnabled() {
+return getResponseCacheSize() != 0;
+}
+
+private static class LRUCache extends LinkedHashMap {
+private int cacheSize;
+
+public LRUCache(int cacheSize) {
--- End diff --
I agreed with @hanm and like the idea of removing and re-putting nodes, but
doesn't look like it can be easily implemented.
---
[GitHub] zookeeper pull request #684: ZOOKEEPER-3180: Add response cache to improve t...
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r230973727
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxn.java
---
@@ -235,10 +237,12 @@ void handleWrite(SelectionKey k) throws IOException,
CloseRequestException {
if (bb == ServerCnxnFactory.closeConn) {
throw new CloseRequestException("close requested");
}
+if (bb == packetSentinel) {
--- End diff --
Seems like you're fixing a bug by introducing `packetSentinel`. Is that
correct?
---
[GitHub] zookeeper pull request #684: ZOOKEEPER-3180: Add response cache to improve t...
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r230973999
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ResponseCache.java
---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.server;
+
+import java.util.Collections;
+import java.util.LinkedHashMap;
+import java.util.Map;
+
+import org.apache.jute.Record;
+import org.apache.zookeeper.data.Stat;
+
+@SuppressWarnings("serial")
+public class ResponseCache {
+private static final int DEFAULT_RESPONSE_CACHE_SIZE = 400;
+
+private static class Entry {
+public Stat stat;
+public byte[] data;
+}
+
+private Map cache = Collections.synchronizedMap(
+new LRUCache(getResponseCacheSize()));
+
+public ResponseCache() {
+}
+
+public void put(String path, byte[] data, Stat stat) {
+Entry entry = new Entry();
+entry.data = data;
+entry.stat = stat;
+cache.put(path, entry);
+}
+
+public byte[] get(String key, Stat stat) {
+Entry entry = cache.get(key);
+if (entry == null) {
+return null;
+}
+if (!stat.equals(entry.stat)) {
--- End diff --
Comparing `mzxid` instead?
---
[GitHub] zookeeper pull request #684: ZOOKEEPER-3180: Add response cache to improve t...
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r230975652
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerCnxn.java ---
@@ -68,29 +70,74 @@
private volatile boolean stale = false;
+final ZooKeeperServer zkServer;
+
+public ServerCnxn(final ZooKeeperServer zkServer) {
+this.zkServer = zkServer;
+}
+
abstract int getSessionTimeout();
abstract void close();
+public abstract void sendResponse(ReplyHeader h, Record r,
+String tag, String cacheKey, Stat stat) throws IOException;
+
public void sendResponse(ReplyHeader h, Record r, String tag) throws
IOException {
-ByteArrayOutputStream baos = new ByteArrayOutputStream();
-// Make space for length
+sendResponse(h, r, tag, null, null);
+}
+
+protected byte[] serializeRecord(Record record) throws IOException {
+ByteArrayOutputStream baos = new ByteArrayOutputStream(
+ZooKeeperServer.intBufferStartingSizeBytes);
BinaryOutputArchive bos = BinaryOutputArchive.getArchive(baos);
-try {
-baos.write(fourBytes);
-bos.writeRecord(h, "header");
-if (r != null) {
-bos.writeRecord(r, tag);
+bos.writeRecord(record, null);
+return baos.toByteArray();
+}
+
+protected ByteBuffer[] serialize(ReplyHeader h, Record r, String tag,
+String cacheKey, Stat stat) throws IOException {
+byte[] header = serializeRecord(h);
+byte[] data = null;
+if (r != null) {
+ResponseCache cache = zkServer.getReadResponseCache();
+if (cache != null && stat != null && cacheKey != null &&
+!cacheKey.endsWith(Quotas.statNode)) {
+// Use cache to get serialized data.
+//
+// NB: Tag is ignored both during cache lookup and
serialization,
+// since is is not used in read responses, which are being
cached.
+data = cache.get(cacheKey, stat);
+if (data == null) {
+// Cache miss, serialize the response and put it in
cache.
+data = serializeRecord(r);
--- End diff --
`put()` aquires the write lock anyway, so in my opinion this will cause the
response to be serialized twice and put into the cache twice (second overwrites
first). I think it's fine.
---
[GitHub] zookeeper pull request #684: ZOOKEEPER-3180: Add response cache to improve t...
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r230973904
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ResponseCache.java
---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.server;
+
+import java.util.Collections;
+import java.util.LinkedHashMap;
+import java.util.Map;
+
+import org.apache.jute.Record;
+import org.apache.zookeeper.data.Stat;
+
+@SuppressWarnings("serial")
+public class ResponseCache {
+private static final int DEFAULT_RESPONSE_CACHE_SIZE = 400;
--- End diff --
Agreed. You might want to add some useful comment here.
---
[GitHub] zookeeper issue #689: ZOOKEEPER-3183:Notifying the WatcherCleaner thread and...
Github user tumativ commented on the issue: https://github.com/apache/zookeeper/pull/689 I realized that processing remaining watchers is not a good idea without knowing the context of the shutdown. The shutdown contract itself is stop processing. I have modified the JIRA description. It targets below improvements. - Notify the WatcherCleaner thread during shutdown if it is waiting for dead watchers get the certain number(watcherCleanThreshold) - Notify the threads who are waiting on totalDeadWatchers, this can happen when pending watchers are reached maximum -Stop taking incoming dead watcher and adding to deadWatchers even cleaner thread is stopped. ---
[jira] [Updated] (ZOOKEEPER-3183) Interrupting or notifying the WatcherCleaner thread during shutdown if it is waiting for dead watchers get certain number(watcherCleanThreshold) and also stop addin
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Venkateswarlu Tumati updated ZOOKEEPER-3183: Description: Interrupting or notifying the WatcherCleaner thread during shutdown if it is waiting for dead watchers get certain number(watcherCleanThreshold) and also stop adding incoming deadWatcher to deadWatchersList when shutdown is initiated. (was: WatcherCleaner thread is waiting to get certain dead watchers, the shut down can happen when WatcherCleaner thread is waiting . It will be better if we Interrupt or notify to avoid the long waiting as shut down is initiated. And also complete the remaining dead watchers when interrupt happend.) Summary: Interrupting or notifying the WatcherCleaner thread during shutdown if it is waiting for dead watchers get certain number(watcherCleanThreshold) and also stop adding incoming deadWatcher to deadWatchersList when shutdown is initiated. (was: Interrupting or notifying the WatcherCleaner thread during shutdown if it is waiting for dead watchers get certain number(watcherCleanThreshold) and also process the remaining dead watchers rather coming out without processing .) > Interrupting or notifying the WatcherCleaner thread during shutdown if it > is waiting for dead watchers get certain number(watcherCleanThreshold) and > also stop adding incoming deadWatcher to deadWatchersList when shutdown is > initiated. > - > > Key: ZOOKEEPER-3183 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3183 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: Venkateswarlu Tumati >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 40m > Remaining Estimate: 0h > > Interrupting or notifying the WatcherCleaner thread during shutdown if it > is waiting for dead watchers get certain number(watcherCleanThreshold) and > also stop adding incoming deadWatcher to deadWatchersList when shutdown is > initiated. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] zookeeper issue #676: ZOOKEEPER-3181: ZOOKEEPER-2355 broke Curator TestingQu...
Github user aajisaka commented on the issue: https://github.com/apache/zookeeper/pull/676 @hanm It seems hard to make a new 2.x release. Patching itself is easy, however, there is no branch for developing 2.x and no activity to release 2.x. Please see https://issues.apache.org/jira/browse/CURATOR-409 for the detail. (I'm not familiar with Apache Curator project, so I'm not sure how actually hard it is.) ---
[GitHub] zookeeper issue #676: ZOOKEEPER-3181: ZOOKEEPER-2355 broke Curator TestingQu...
Github user aajisaka commented on the issue: https://github.com/apache/zookeeper/pull/676 @anmolnar Here is the `getQuorumPeer()` method in Apache Curator 2.12.0 https://github.com/apache/curator/blob/apache-curator-2.12.0/curator-test/src/main/java/org/apache/curator/test/TestingQuorumPeerMain.java#L56 ---
Failed: ZOOKEEPER- PreCommit Build #2592
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2592/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 87.09 MB...] [exec] == [exec] [exec] [exec] [exec] Error: No value specified for option "issue" [exec] Session logged out. Session was JSESSIONID=DE82A859DDD9AFFFB08ADA6D95AD1D1B. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' are the same file BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1859: exec returned: 1 Total time: 13 minutes 33 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ [description-setter] Description set: ZOOKEEPER-3172 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Adding one-line test results to commit status... Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting status of 69f5185c8c14720e94c81f0147ee9cbc2ae42f89 to FAILURE with url https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2592/ and message: 'FAILURE 2307 tests run, 1 skipped, 3 failed.' Using context: Jenkins Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2592/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ ### ## FAILED TESTS (if any) ## 3 tests failed. FAILED: org.apache.zookeeper.SaslAuthTest.testZKOperationsAfterClientSaslAuthFailure Error Message: Failed to connect to ZooKeeper server. Stack Trace: java.util.concurrent.TimeoutException: Failed to connect to ZooKeeper server. at org.apache.zookeeper.test.ClientBase$CountdownWatcher.waitForConnected(ClientBase.java:151) at org.apache.zookeeper.SaslAuthTest.testZKOperationsAfterClientSaslAuthFailure(SaslAuthTest.java:176) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79) FAILED: org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentServersAreObserversInNextConfig Error Message: waiting for server 4 being up Stack Trace: junit.framework.AssertionFailedError: waiting for server 4 being up at org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentServersAreObserversInNextConfig(ReconfigRecoveryTest.java:224) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79) FAILED: org.apache.zookeeper.server.quorum.UnifiedServerSocketTest.testDenialOfServiceResistanceNonStrictServer[0] Error Message: null Stack Trace: junit.framework.AssertionFailedError at
[GitHub] zookeeper issue #679: ZOOKEEPER-3172: Quorum TLS - fix port unification to a...
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/679 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2592/ ---
[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...
Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r230965607 --- Diff: zookeeper-docs/src/documentation/content/xdocs/zookeeperObservers.xml --- @@ -111,7 +111,41 @@ the ZooKeeper service. - + --- End diff -- general comments about documentation - great work! But we need put the document in markdown source now with ZOOKEEPER-3153 / 3154 is done. ---
[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/628#discussion_r230965386
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/ObserverMaster.java
---
@@ -0,0 +1,514 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.server.quorum;
+
+import org.apache.zookeeper.jmx.MBeanRegistry;
+import org.apache.zookeeper.server.Request;
+import org.apache.zookeeper.server.ZKDatabase;
+
+import java.io.BufferedInputStream;
+import java.io.ByteArrayInputStream;
+import java.io.DataInputStream;
+import java.io.IOException;
+import java.net.ServerSocket;
+import java.net.Socket;
+import java.net.SocketAddress;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Iterator;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentLinkedQueue;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicLong;
+
+import org.apache.zookeeper.server.quorum.auth.QuorumAuthServer;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Used by Followers to host Observers. This reduces the network load on
the Leader process by pushing
+ * the responsibility for keeping Observers in sync off the leading peer.
+ *
+ * It is expected that Observers will continue to perform the initial
vetting of clients and requests.
+ * Observers send the request to the follower where it is received by an
ObserverMaster.
+ *
+ * The ObserverMaster forwards a copy of the request to the ensemble
Leader and inserts it into its own
+ * request processor pipeline where it can be matched with the response
comes back. All commits received
+ * from the Leader will be forwarded along to every Learner connected to
the ObserverMaster.
+ *
+ * New Learners connecting to a Follower will receive a LearnerHandler
object and be party to its syncing logic
+ * to be brought up to date.
+ *
+ * The logic is quite a bit simpler than the corresponding logic in Leader
because it only hosts observers.
+ */
+public class ObserverMaster implements LearnerMaster, Runnable {
+private static final Logger LOG =
LoggerFactory.getLogger(ObserverMaster.class);
+
+//Follower counter
+private final AtomicLong followerCounter = new AtomicLong(-1);
--- End diff --
I have a question about what variable this for. I see this value will never
get incremented, as the only function references it is
`getAndDecrementFollowerCounter`. Might worth to put more comments here.
---
[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...
Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r230964928 --- Diff: zookeeper-docs/src/documentation/content/xdocs/zookeeperAdmin.xml --- @@ -764,6 +764,18 @@ server.3=zoo3:2888:3888 + +observerMasterPort --- End diff -- If we leave `observerMasterPort` as a separation configuration option (as opposed to part of server:ports configuration), then we will not be able to reconfigure this port using dynamic reconfig, right? Is this expected? ---
[GitHub] zookeeper issue #676: ZOOKEEPER-3181: ZOOKEEPER-2355 broke Curator TestingQu...
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/676 >> Since there are no releases in curator 2.x for more than one year, I'm not sure CURATOR-409 will be fixed in 2.x and the maintenance release will be released soon. How hard is it to do a back port and make a new 2.x release? This seems the most reasonable solution to me for this specific problem given Curator already did the fix for 4.x, and this approach has added benefit of patching existing ZK releases without requiring a new ZK release (we kind of very slow on release zookeeper, if not slower than Curator). ---
[GitHub] zookeeper pull request #679: ZOOKEEPER-3172: Quorum TLS - fix port unificati...
Github user ivmaykov closed the pull request at: https://github.com/apache/zookeeper/pull/679 ---
[GitHub] zookeeper pull request #679: ZOOKEEPER-3172: Quorum TLS - fix port unificati...
GitHub user ivmaykov reopened a pull request: https://github.com/apache/zookeeper/pull/679 ZOOKEEPER-3172: Quorum TLS - fix port unification to allow rolling upgrades Fix numerous problems with UnifiedServerSocket, such as hanging the accept() thread when the client doesn't send any data or crashing if less than 5 bytes are read from the socket in the initial read. Re-enable the "portUnification" config option. Note that this is stacked on top of #678 and thus includes it. Please only consider the ZOOKEEPER-3172 commit when reviewing. Once the other PR is merged upstream, I will rebase this so it only contains one commit. ## Fixed networking issues/bugs in UnifiedServerSocket - don't crash the `accept()` thread if the client closes the connection without sending any data - don't corrupt the connection if the client sends fewer than 5 bytes for the initial read - delay the detection of TLS vs. plaintext mode until a socket stream is read from or written to. This prevents the `accept()` thread from getting blocked on a `read()` operation from the newly connected socket. - prepending 5 bytes to `PrependableSocket` and then trying to read >5 bytes would only return the first 5 bytes, even if more bytes were available. This is fixed. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ivmaykov/zookeeper ZOOKEEPER-3172 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/679.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #679 commit 2122c8c23a0dbb27f9b2aff55e800e48d253f943 Author: Ilya Maykov Date: 2018-10-25T00:41:48Z ZOOKEEPER-3173: Quorum TLS - support PEM trust/key stores ZOOKEEPER-3175: Quorum TLS - test improvements Add support for loading key and trust stores from PEM files. Also added test utils for testing X509-related code, because it was very difficult to untangle them from the PEM support code. commit 69f5185c8c14720e94c81f0147ee9cbc2ae42f89 Author: Ilya Maykov Date: 2018-10-25T01:22:24Z ZOOKEEPER-3172: Quorum TLS - fix port unification to allow rolling upgrades ---
[GitHub] zookeeper issue #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/key sto...
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/678 What's wrong with this build? @ivmaykov Does it work for you locally? ---
[jira] [Commented] (ZOOKEEPER-3156) ZOOKEEPER-2184 causes kerberos principal to not have resolved host name
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675917#comment-16675917 ] Hudson commented on ZOOKEEPER-3156: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #256 (See [https://builds.apache.org/job/ZooKeeper-trunk/256/]) ZOOKEEPER-3156: Add in option to canonicalize host name (andor: rev 83fd6e298dda420125f8be35fda68cb226b0ee05) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/client/ZKClientConfig.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java * (add) zookeeper-server/src/test/java/org/apache/zookeeper/ClientCanonicalizeTest.java * (add) zookeeper-server/src/main/java/org/apache/zookeeper/SaslServerPrincipal.java > ZOOKEEPER-2184 causes kerberos principal to not have resolved host name > --- > > Key: ZOOKEEPER-3156 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3156 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.6.0, 3.4.13, 3.5.5 >Reporter: Robert Joseph Evans >Assignee: Robert Joseph Evans >Priority: Blocker > Labels: pull-request-available > Fix For: 3.6.0, 3.5.5, 3.4.14 > > Time Spent: 12h > Remaining Estimate: 0h > > Prior to ZOOKEEPER-2184 the zookeeper client would canonicalize a configured > host name before creating the SASL client which is used to create the > principal name. After ZOOKEEPER-2184 that canonicalization does not happen > so the principal that the ZK client tries to use when it is configured to > talk to a CName is different between 3.4.13 and all previous versions of ZK. > > For example > > zk1.mycluster.mycompany.com maps to real-node.mycompany.com. > > 3.4.13 will want the server to have > [zookeeper/zk1.mycluster@kdc.mycompany.com|mailto:zookeeper/zk1.mycluster@kdc.mycompany.com] > 3.4.12 wants the server to have > [zookeeper/real-node.mycompany@kdc.mycompany.com|mailto:zookeeper/real-node.mycompany@kdc.mycompany.com] > > This makes 3.4.13 incompatible with many ZK setups currently in existence. > It would be nice to have that resolution be optional because in some cases it > might be nice to have a single principal tied to the cname. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] zookeeper issue #681: ZOOKEEPER-3176: Quorum TLS - add SSL config options
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/681 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2591/ ---
Success: ZOOKEEPER- PreCommit Build #2591
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2591/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 86.63 MB...] [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] [exec] Error: No value specified for option "issue" [exec] Session logged out. Session was JSESSIONID=60D772BC192F3C4FDA6A58335B20C5A1. [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' are the same file [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD SUCCESSFUL Total time: 18 minutes 37 seconds Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ [description-setter] Description set: ZOOKEEPER-3176 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Adding one-line test results to commit status... Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting status of a55be86a0a4c28f2d7d92c1c793e369bb7e35448 to SUCCESS with url https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2591/ and message: 'SUCCESS 2360 tests run, 1 skipped, 0 failed.' Using context: Jenkins Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2591/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Email was triggered for: Success Sending email for trigger: Success Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ ### ## FAILED TESTS (if any) ## All tests passed
[GitHub] zookeeper issue #686: Zookeeper 3167
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/686 @TyqITstudent Please create pull request for the master branch first. We can talk about integrating this into 3.5, but we don't accept new features for 3.4 Would be better to use `key.startsWith(path)` instead of contains to make sure the path starts with the parent's. Have you considered limiting the access to this command? I'm not sure if it's needed (say we've merged the recursive flag of `setAcl` command recently which didn't have limits either), but this command could be too expensive, if the ensemble has millions of nodes. As a consequence the command can be used for a DOS attach, similarly to 4lw commands which have been blacklisted previously. ---
Failed: ZOOKEEPER- PreCommit Build #2589
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2589/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 81.25 MB...] [exec] /bin/kill -9 25254 [exec] /bin/kill -9 25283 [exec] /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/zookeeper-server/src/test/resources/test-github-pr.sh: line 471: 25302 Killed $ANT_HOME/bin/ant -DZookeeperPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes test-contrib [exec] [exec] Error: No value specified for option "issue" [exec] Session logged out. Session was JSESSIONID=3790736D70BB08C063C7C0EB00C1B1E5. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' are the same file BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1859: exec returned: 2 Total time: 12 minutes 5 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ [description-setter] Description set: ZOOKEEPER-3173 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Adding one-line test results to commit status... Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting status of 2122c8c23a0dbb27f9b2aff55e800e48d253f943 to FAILURE with url https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2589/ and message: 'FAILURE 2004 tests run, 2 skipped, 0 failed.' Using context: Jenkins Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2589/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ ### ## FAILED TESTS (if any) ## All tests passed
[GitHub] zookeeper issue #688: reduce session revalidation time after zxid roll over
Github user nkalmar commented on the issue: https://github.com/apache/zookeeper/pull/688 LGTM. Please create a jira for this PR and/or mention the jira number in the commit message and PR name. Thanks! ---
[GitHub] zookeeper issue #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/key sto...
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/678 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2589/ ---
Failed: ZOOKEEPER- PreCommit Build #2590
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2590/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 38.06 KB...] [exec] [exec] [exec] [exec] Error: No value specified for option "issue" [exec] Session logged out. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess' are the same file BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/build.xml:1859: exec returned: 1 Total time: 2 minutes 37 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ ERROR: Step ?Publish JUnit test result report? failed: No test report files were found. Configuration error? Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ [description-setter] Description set: ZOOKEEPER-3174 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Adding one-line test results to commit status... Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting status of d9e09dc73a42be079a6bd28b51c09635fff32e95 to FAILURE with url https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2590/ and message: 'FAILURE No test results found.' Using context: Jenkins Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2590/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ ### ## FAILED TESTS (if any) ## No tests ran.
[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/680 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2590/ ---
[GitHub] zookeeper issue #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/key sto...
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/678 retest this please ---
[GitHub] zookeeper issue #689: ZOOKEEPER-3183:Notifying the WatcherCleaner thread and...
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/689 @tumativ This patch makes sense to me and looks like a nice improvement. In the Jira you're saying "also complete the remaining dead watchers when interrupt happen", but I cannot see the change related to this. If cleanUp thread gets interrupted it brakes the while loop and doesn't process `deadWatchers`. (which I believe is right, but not sure what you're referring to) ---
[GitHub] zookeeper issue #669: ZOOKEEPER-3152: Port ZK netty stack to netty4
Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/669 @maoling it will be hard to do perf comparison of netty3 vs netty4 for us because we are currently using the NIO transports, and we don't plan on switching to netty3 in production. Comparing NIO vs netty4 is kind of apples-and-oranges. A quick perf test with this patch showed that NIO to netty4 did not result in any obvious performance regressions, so I think we can say they are at least comparable :) ---
[GitHub] zookeeper issue #676: ZOOKEEPER-3181: ZOOKEEPER-2355 broke Curator TestingQu...
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/676 @aajisaka I'm a little bit confused with this patch, because I cannot find the class `TestingQuorumPeerMain` which was overwritten the `getQuorumPeer()` method as mentioned in the Jira. Where is that class exactly? ---
[jira] [Commented] (ZOOKEEPER-3156) ZOOKEEPER-2184 causes kerberos principal to not have resolved host name
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675821#comment-16675821 ] Hudson commented on ZOOKEEPER-3156: --- FAILURE: Integrated in Jenkins build Zookeeper-trunk-single-thread #94 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/94/]) ZOOKEEPER-3156: Add in option to canonicalize host name (andor: rev 83fd6e298dda420125f8be35fda68cb226b0ee05) * (add) zookeeper-server/src/main/java/org/apache/zookeeper/SaslServerPrincipal.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/client/ZKClientConfig.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java * (add) zookeeper-server/src/test/java/org/apache/zookeeper/ClientCanonicalizeTest.java > ZOOKEEPER-2184 causes kerberos principal to not have resolved host name > --- > > Key: ZOOKEEPER-3156 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3156 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.6.0, 3.4.13, 3.5.5 >Reporter: Robert Joseph Evans >Assignee: Robert Joseph Evans >Priority: Blocker > Labels: pull-request-available > Fix For: 3.6.0, 3.5.5, 3.4.14 > > Time Spent: 12h > Remaining Estimate: 0h > > Prior to ZOOKEEPER-2184 the zookeeper client would canonicalize a configured > host name before creating the SASL client which is used to create the > principal name. After ZOOKEEPER-2184 that canonicalization does not happen > so the principal that the ZK client tries to use when it is configured to > talk to a CName is different between 3.4.13 and all previous versions of ZK. > > For example > > zk1.mycluster.mycompany.com maps to real-node.mycompany.com. > > 3.4.13 will want the server to have > [zookeeper/zk1.mycluster@kdc.mycompany.com|mailto:zookeeper/zk1.mycluster@kdc.mycompany.com] > 3.4.12 wants the server to have > [zookeeper/real-node.mycompany@kdc.mycompany.com|mailto:zookeeper/real-node.mycompany@kdc.mycompany.com] > > This makes 3.4.13 incompatible with many ZK setups currently in existence. > It would be nice to have that resolution be optional because in some cases it > might be nice to have a single principal tied to the cname. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: asfgit commenting on PRs
Il lun 5 nov 2018, 21:28 Andor Molnar ha scritto: > I also feel the comments redundant. > Enrico - shall we remove this? > I will check, it should be a flag on job config Enrico > Andor > > > > > On 2018. Nov 5., at 12:24, Norbert Kalmar > wrote: > > > > Hi all, > > > > One of the recent development was that asfgit now comments on the PRs > every > > successful builds. > > But we do have the same information under "Show all checks". (This might > be > > gone after closing the PR though). > > > > I wouldn't mind the extra commit, but on github, in > > https://github.com/apache/zookeeper/pulls, we have multiple comments > > showing under every PR. Before this, for me at least, I used this to > > quickly identify the PRs which haven't been reviewed by anyone (having 0 > or > > 1 comments). Or to see quickly if something is getting a lot of attention > > lately, or getting updates etc. > > > > This was a convenient thing for me, of course not a feature I can't live > > without. I just wanted to ask other devs view on this. > > > > So, what's your view? :) > > > > Regards, > > Norbert > > -- -- Enrico Olivelli
Re: asfgit commenting on PRs
I also feel the comments redundant. Enrico - shall we remove this? Andor > On 2018. Nov 5., at 12:24, Norbert Kalmar > wrote: > > Hi all, > > One of the recent development was that asfgit now comments on the PRs every > successful builds. > But we do have the same information under "Show all checks". (This might be > gone after closing the PR though). > > I wouldn't mind the extra commit, but on github, in > https://github.com/apache/zookeeper/pulls, we have multiple comments > showing under every PR. Before this, for me at least, I used this to > quickly identify the PRs which haven't been reviewed by anyone (having 0 or > 1 comments). Or to see quickly if something is getting a lot of attention > lately, or getting updates etc. > > This was a convenient thing for me, of course not a feature I can't live > without. I just wanted to ask other devs view on this. > > So, what's your view? :) > > Regards, > Norbert
asfgit commenting on PRs
Hi all, One of the recent development was that asfgit now comments on the PRs every successful builds. But we do have the same information under "Show all checks". (This might be gone after closing the PR though). I wouldn't mind the extra commit, but on github, in https://github.com/apache/zookeeper/pulls, we have multiple comments showing under every PR. Before this, for me at least, I used this to quickly identify the PRs which haven't been reviewed by anyone (having 0 or 1 comments). Or to see quickly if something is getting a lot of attention lately, or getting updates etc. This was a convenient thing for me, of course not a feature I can't live without. I just wanted to ask other devs view on this. So, what's your view? :) Regards, Norbert
Success: ZOOKEEPER- PreCommit Build #2588
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2588/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 80.31 MB...] [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] [exec] Error: No value specified for option "issue" [exec] Session logged out. Session was JSESSIONID=46318B65F34BA3AF3364957B75D18DA7. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' are the same file BUILD SUCCESSFUL Total time: 21 minutes 17 seconds Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ [description-setter] Description set: ZOOKEEPER-3152 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Adding one-line test results to commit status... Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting status of c8a0dafea2764bbe4c6a93bdf71db6a142999529 to SUCCESS with url https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2588/ and message: 'SUCCESS 1806 tests run, 2 skipped, 0 failed.' Using context: Jenkins Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2588/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Email was triggered for: Success Sending email for trigger: Success Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ ### ## FAILED TESTS (if any) ## All tests passed
[GitHub] zookeeper issue #669: ZOOKEEPER-3152: Port ZK netty stack to netty4
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/669 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2588/ ---
Failed: ZOOKEEPER- PreCommit Build #2587
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2587/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 86.22 MB...] [exec] == [exec] [exec] [exec] [exec] Error: No value specified for option "issue" [exec] Session logged out. Session was JSESSIONID=8AD0434A0313FDA55D84FE840B63F56D. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: ‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’ and ‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’ are the same file BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1859: exec returned: 1 Total time: 21 minutes 35 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ [description-setter] Description set: ZOOKEEPER-3176 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Adding one-line test results to commit status... Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting status of c1734d40934583a911c2f7f1af48da86958063be to FAILURE with url https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2587/ and message: 'FAILURE 2360 tests run, 1 skipped, 0 failed.' Using context: Jenkins Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2587/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ ### ## FAILED TESTS (if any) ## All tests passed
[GitHub] zookeeper issue #681: ZOOKEEPER-3176: Quorum TLS - add SSL config options
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/681 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2587/ ---
Success: ZOOKEEPER- PreCommit Build #2586
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2586/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 86.66 MB...] [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] [exec] Error: No value specified for option "issue" [exec] Session logged out. Session was JSESSIONID=2C7120137CB039FEBA89FC65756DF643. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' are the same file BUILD SUCCESSFUL Total time: 18 minutes 43 seconds Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ [description-setter] Description set: ZOOKEEPER-3174 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Adding one-line test results to commit status... Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting status of b6d2076ad115040691466fb08d372b4bea7f37e7 to SUCCESS with url https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2586/ and message: 'SUCCESS 2312 tests run, 1 skipped, 0 failed.' Using context: Jenkins Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2586/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Email was triggered for: Success Sending email for trigger: Success Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ ### ## FAILED TESTS (if any) ## All tests passed
[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/680 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2586/ ---
[GitHub] zookeeper issue #669: ZOOKEEPER-3152: Port ZK netty stack to netty4
Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/669 Rebase, update localAddress after accepting connection and log it ---
[GitHub] zookeeper issue #679: ZOOKEEPER-3172: Quorum TLS - fix port unification to a...
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/679 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2585/ ---
[GitHub] zookeeper issue #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/key sto...
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/678 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2584/ ---
Failed: ZOOKEEPER- PreCommit Build #2584
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2584/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 1.76 MB...] [exec] /bin/kill -9 10587 [exec] /bin/kill -9 10609 [exec] /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/zookeeper-server/src/test/resources/test-github-pr.sh: line 471: 10638 Killed $ANT_HOME/bin/ant -DZookeeperPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes test-contrib [exec] [exec] Error: No value specified for option "issue" [exec] Session logged out. Session was JSESSIONID=77274F68413D7069836D8EF261408F30. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' are the same file BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1859: exec returned: 2 Total time: 3 minutes 16 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ [description-setter] Description set: ZOOKEEPER-3173 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Adding one-line test results to commit status... Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting status of 2122c8c23a0dbb27f9b2aff55e800e48d253f943 to FAILURE with url https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2584/ and message: 'FAILURE 600 tests run, 0 skipped, 0 failed.' Using context: Jenkins Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2584/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ ### ## FAILED TESTS (if any) ## All tests passed
Failed: ZOOKEEPER- PreCommit Build #2585
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2585/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 37.82 KB...] [exec] [exec] [exec] [exec] Error: No value specified for option "issue" [exec] Session logged out. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess' are the same file BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/build.xml:1859: exec returned: 2 Total time: 2 minutes 48 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ ERROR: Step ?Publish JUnit test result report? failed: No test report files were found. Configuration error? Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ [description-setter] Description set: ZOOKEEPER-3172 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Adding one-line test results to commit status... Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting status of 69f5185c8c14720e94c81f0147ee9cbc2ae42f89 to FAILURE with url https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2585/ and message: 'FAILURE No test results found.' Using context: Jenkins Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2585/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ ### ## FAILED TESTS (if any) ## No tests ran.
Success: ZOOKEEPER- PreCommit Build #2583
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2583/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 40.91 MB...] [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] [exec] Error: No value specified for option "issue" [exec] Session logged out. Session was JSESSIONID=E36E207BDEF9901C934E4D08207AA6B5. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' are the same file BUILD SUCCESSFUL Total time: 35 minutes 0 seconds Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ [description-setter] Description set: ZOOKEEPER-3156 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Adding one-line test results to commit status... Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting status of bb90e9eaefaf5ea7336333861488805f414efb92 to SUCCESS with url https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2583/ and message: 'SUCCESS 660 tests run, 3 skipped, 0 failed.' Using context: Jenkins Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2583/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Email was triggered for: Success Sending email for trigger: Success Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ ### ## FAILED TESTS (if any) ## All tests passed
[GitHub] zookeeper issue #540: Branch 3.4
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/540 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2583/ ---
[GitHub] zookeeper issue #687: Zookeeper 3169
Github user nkalmar commented on the issue: https://github.com/apache/zookeeper/pull/687 I think you need to rebase before commiting. But theres too much commit, are you sure you branched from master, and not from i.e. 3.4? ---
[GitHub] zookeeper issue #540: Branch 3.4
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/540 @timelapsewithinlive would you please close this PR? ---
[GitHub] zookeeper issue #648: ZOOKEEPER-3156: Add in option to canonicalize host nam...
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/648 Committed. Thanks @revans2 ! Please close this PR. ---
[jira] [Updated] (ZOOKEEPER-3156) ZOOKEEPER-2184 causes kerberos principal to not have resolved host name
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar updated ZOOKEEPER-3156: Fix Version/s: 3.4.14 > ZOOKEEPER-2184 causes kerberos principal to not have resolved host name > --- > > Key: ZOOKEEPER-3156 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3156 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.6.0, 3.4.13, 3.5.5 >Reporter: Robert Joseph Evans >Assignee: Robert Joseph Evans >Priority: Blocker > Labels: pull-request-available > Fix For: 3.6.0, 3.5.5, 3.4.14 > > Time Spent: 11h 50m > Remaining Estimate: 0h > > Prior to ZOOKEEPER-2184 the zookeeper client would canonicalize a configured > host name before creating the SASL client which is used to create the > principal name. After ZOOKEEPER-2184 that canonicalization does not happen > so the principal that the ZK client tries to use when it is configured to > talk to a CName is different between 3.4.13 and all previous versions of ZK. > > For example > > zk1.mycluster.mycompany.com maps to real-node.mycompany.com. > > 3.4.13 will want the server to have > [zookeeper/zk1.mycluster@kdc.mycompany.com|mailto:zookeeper/zk1.mycluster@kdc.mycompany.com] > 3.4.12 wants the server to have > [zookeeper/real-node.mycompany@kdc.mycompany.com|mailto:zookeeper/real-node.mycompany@kdc.mycompany.com] > > This makes 3.4.13 incompatible with many ZK setups currently in existence. > It would be nice to have that resolution be optional because in some cases it > might be nice to have a single principal tied to the cname. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ZOOKEEPER-3156) ZOOKEEPER-2184 causes kerberos principal to not have resolved host name
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-3156. - Resolution: Fixed Fix Version/s: 3.5.5 3.6.0 Issue resolved by pull request 652 [https://github.com/apache/zookeeper/pull/652] > ZOOKEEPER-2184 causes kerberos principal to not have resolved host name > --- > > Key: ZOOKEEPER-3156 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3156 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.6.0, 3.4.13, 3.5.5 >Reporter: Robert Joseph Evans >Assignee: Robert Joseph Evans >Priority: Blocker > Labels: pull-request-available > Fix For: 3.6.0, 3.5.5 > > Time Spent: 11h 40m > Remaining Estimate: 0h > > Prior to ZOOKEEPER-2184 the zookeeper client would canonicalize a configured > host name before creating the SASL client which is used to create the > principal name. After ZOOKEEPER-2184 that canonicalization does not happen > so the principal that the ZK client tries to use when it is configured to > talk to a CName is different between 3.4.13 and all previous versions of ZK. > > For example > > zk1.mycluster.mycompany.com maps to real-node.mycompany.com. > > 3.4.13 will want the server to have > [zookeeper/zk1.mycluster@kdc.mycompany.com|mailto:zookeeper/zk1.mycluster@kdc.mycompany.com] > 3.4.12 wants the server to have > [zookeeper/real-node.mycompany@kdc.mycompany.com|mailto:zookeeper/real-node.mycompany@kdc.mycompany.com] > > This makes 3.4.13 incompatible with many ZK setups currently in existence. > It would be nice to have that resolution be optional because in some cases it > might be nice to have a single principal tied to the cname. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] zookeeper issue #652: ZOOKEEPER-3156: Add in option to canonicalize host nam...
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/652 Merged to 3.5 and master branches. Thanks @revans2 ! ---
[GitHub] zookeeper pull request #652: ZOOKEEPER-3156: Add in option to canonicalize h...
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/652 ---
[GitHub] zookeeper issue #676: ZOOKEEPER-3181: ZOOKEEPER-2355 broke Curator TestingQu...
Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/676 @lvfangmin I guess the problem is not a 'test' in Curator but that class. Curator is used very much in tests of downstream projects in order to start Zookeeper servers as it provides easy ways to start single server and multi server Zookeeper systems for unit tests That change broke Curator. Restoring the 'compatibility' is easy and it can help other projects ---
ZooKeeper_branch35_jdk8 - Build # 1180 - Still Failing
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1180/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 64.39 KB...] [junit] Running org.apache.zookeeper.test.SaslClientTest in thread 4 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.453 sec, Thread: 4, Class: org.apache.zookeeper.test.SaslClientTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.91 sec, Thread: 2, Class: org.apache.zookeeper.test.SaslAuthMissingClientConfigTest [junit] Running org.apache.zookeeper.test.ServerCnxnTest in thread 4 [junit] Running org.apache.zookeeper.test.SaslSuperUserTest in thread 3 [junit] Running org.apache.zookeeper.test.SessionInvalidationTest in thread 2 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.642 sec, Thread: 3, Class: org.apache.zookeeper.test.SaslSuperUserTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.085 sec, Thread: 2, Class: org.apache.zookeeper.test.SessionInvalidationTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.167 sec, Thread: 4, Class: org.apache.zookeeper.test.ServerCnxnTest [junit] Running org.apache.zookeeper.test.SessionTest in thread 3 [junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 4 [junit] Running org.apache.zookeeper.test.SessionTimeoutTest in thread 2 [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.704 sec, Thread: 4, Class: org.apache.zookeeper.test.SessionTrackerCheckTest [junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 4 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.719 sec, Thread: 2, Class: org.apache.zookeeper.test.SessionTimeoutTest [junit] Running org.apache.zookeeper.test.StandaloneTest in thread 2 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.141 sec, Thread: 2, Class: org.apache.zookeeper.test.StandaloneTest [junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 15.438 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionTest [junit] Running org.apache.zookeeper.test.StatTest in thread 2 [junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 3 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.604 sec, Thread: 2, Class: org.apache.zookeeper.test.StatTest [junit] Tests run: 26, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.548 sec, Thread: 3, Class: org.apache.zookeeper.test.StaticHostProviderTest [junit] Running org.apache.zookeeper.test.StringUtilTest in thread 2 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.518 sec, Thread: 2, Class: org.apache.zookeeper.test.StringUtilTest [junit] Running org.apache.zookeeper.test.SyncCallTest in thread 3 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.384 sec, Thread: 3, Class: org.apache.zookeeper.test.SyncCallTest [junit] Running org.apache.zookeeper.test.TruncateTest in thread 2 [junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in thread 3 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 34.05 sec, Thread: 4, Class: org.apache.zookeeper.test.SessionUpgradeTest [junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 4 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.496 sec, Thread: 4, Class: org.apache.zookeeper.test.WatchedEventTest [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.274 sec, Thread: 2, Class: org.apache.zookeeper.test.TruncateTest [junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 4 [junit] Running org.apache.zookeeper.test.WatcherTest in thread 2 [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.428 sec, Thread: 4, Class: org.apache.zookeeper.test.WatcherFuncTest [junit] Running org.apache.zookeeper.test.X509AuthTest in thread 4 [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.363 sec, Thread: 4, Class: org.apache.zookeeper.test.X509AuthTest [junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in thread 4 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 34.813 sec, Thread: 3, Class: org.apache.zookeeper.test.WatchEventWhenAutoResetTest [junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 3 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.005 sec, Thread: 3, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest [junit] Running org.apache.jute.BinaryInputArchiveTest in thread 3 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
[GitHub] zookeeper issue #689: ZOOKEEPER-3183:Notifying the WatcherCleaner thread and...
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/689 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2582/ ---
Failed: ZOOKEEPER- PreCommit Build #2582
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2582/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 85.08 MB...] [exec] == [exec] [exec] [exec] [exec] Error: No value specified for option "issue" [exec] Session logged out. Session was JSESSIONID=0AD26560DE9304A958AFE2851E93038D. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' are the same file BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1859: exec returned: 2 Total time: 18 minutes 56 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ [description-setter] Description set: ZOOKEEPER-3183 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Adding one-line test results to commit status... Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting status of b947aeb0f0f92f3bce2d6315196abbfeb41878c4 to FAILURE with url https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2582/ and message: 'FAILURE 1802 tests run, 2 skipped, 0 failed.' Using context: Jenkins Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2582/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ ### ## FAILED TESTS (if any) ## All tests passed
ZooKeeper_branch34_openjdk8 - Build # 110 - Still Failing
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk8/110/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 43.29 KB...] [junit] Running org.apache.zookeeper.test.SaslAuthFailDesignatedClientTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.848 sec [junit] Running org.apache.zookeeper.test.SaslAuthFailNotifyTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.612 sec [junit] Running org.apache.zookeeper.test.SaslAuthFailTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.681 sec [junit] Running org.apache.zookeeper.test.SaslAuthMissingClientConfigTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.587 sec [junit] Running org.apache.zookeeper.test.SaslClientTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.075 sec [junit] Running org.apache.zookeeper.test.SessionInvalidationTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.757 sec [junit] Running org.apache.zookeeper.test.SessionTest [junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.272 sec [junit] Running org.apache.zookeeper.test.SessionTimeoutTest [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.88 sec [junit] Running org.apache.zookeeper.test.StandaloneTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.951 sec [junit] Running org.apache.zookeeper.test.StatTest [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.949 sec [junit] Running org.apache.zookeeper.test.StaticHostProviderTest [junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.729 sec [junit] Running org.apache.zookeeper.test.SyncCallTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.677 sec [junit] Running org.apache.zookeeper.test.TruncateTest [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.532 sec [junit] Running org.apache.zookeeper.test.UpgradeTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.882 sec [junit] Running org.apache.zookeeper.test.WatchedEventTest [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.086 sec [junit] Running org.apache.zookeeper.test.WatcherFuncTest [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.355 sec [junit] Running org.apache.zookeeper.test.WatcherTest [junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 27.381 sec [junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.801 sec [junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.777 sec [junit] Running org.apache.jute.BinaryInputArchiveTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.081 sec fail.build.on.test.failure: BUILD FAILED /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk8/build.xml:1426: The following error occurred while executing this line: /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk8/build.xml:1429: Tests failed! Total time: 39 minutes 31 seconds Build step 'Invoke Ant' marked build as failure Archiving artifacts Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/ Recording test results Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/ Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/ Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/ Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/ Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/ ### ## FAILED TESTS (if any) ## 1 tests failed. FAILED: org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testNewFollowerRestartAfterNewEpoch Error Message: Waiting too long Stack Trace: java.lang.RuntimeException: Waiting too long at org.apache.zookeeper.server.quorum.QuorumPeerMainTest.waitForAll(QuorumPeerMainTest.java:449) at org.apache.zookeeper.server.quorum.QuorumPeerMainTest.waitForAll(QuorumPeerMainTest.java:439) at org.apache.zookeeper.server.quorum.QuorumPeerMainTest.LaunchServers(QuorumPeerMainTest.java:547) at
Failed: ZOOKEEPER- PreCommit Build #2581
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2581/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 85.25 MB...] [exec] == [exec] [exec] [exec] [exec] Error: No value specified for option "issue" [exec] Session logged out. Session was JSESSIONID=E576EB2F0719D1E0E08E855AD73798CB. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' are the same file BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1859: exec returned: 1 Total time: 18 minutes 15 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ [description-setter] Description set: ZOOKEEPER-3183 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Adding one-line test results to commit status... Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting status of c6e0f7af5aace94daf0caf0ba7b860e99540a284 to FAILURE with url https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2581/ and message: 'FAILURE 1802 tests run, 2 skipped, 0 failed.' Using context: Jenkins Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2581/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/ ### ## FAILED TESTS (if any) ## All tests passed
[GitHub] zookeeper issue #689: ZOOKEEPER-3183:Notifying the WatcherCleaner thread and...
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/689 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2581/ ---
[jira] [Updated] (ZOOKEEPER-3183) Interrupting or notifying the WatcherCleaner thread during shutdown if it is waiting for dead watchers get certain number(watcherCleanThreshold) and also process th
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3183: -- Labels: pull-request-available (was: ) > Interrupting or notifying the WatcherCleaner thread during shutdown if it > is waiting for dead watchers get certain number(watcherCleanThreshold) and > also process the remaining dead watchers rather coming out without > processing . > --- > > Key: ZOOKEEPER-3183 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3183 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: Venkateswarlu Tumati >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > > WatcherCleaner thread is waiting to get certain dead watchers, the shut down > can happen when WatcherCleaner thread is waiting . It will be better if we > Interrupt or notify to avoid the long waiting as shut down is initiated. And > also complete the remaining dead watchers when interrupt happend. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] zookeeper pull request #689: ZOOKEEPER-3183:Notifying the WatcherCleaner thr...
GitHub user tumativ opened a pull request: https://github.com/apache/zookeeper/pull/689 ZOOKEEPER-3183:Notifying the WatcherCleaner thread and Threads which ⦠â¦are waiting list to add watchers during the shutdown and avoid adding the dead watchers when shut down is initiated You can merge this pull request into a Git repository by running: $ git pull https://github.com/tumativ/zookeeper ZOOKEEPER-3183 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/689.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #689 commit c6e0f7af5aace94daf0caf0ba7b860e99540a284 Author: vtumati Date: 2018-11-05T11:51:23Z ZOOKEEPER-3183:Notifying the WatcherCleaner thread and Threads which are waiting list to add watchers during shutdown and avoid adding the dead watchers when shut down is initiated ---
[jira] [Commented] (ZOOKEEPER-2807) Flaky test: org.apache.zookeeper.test.WatchEventWhenAutoResetTest.testNodeDataChanged
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674974#comment-16674974 ] Hudson commented on ZOOKEEPER-2807: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #255 (See [https://builds.apache.org/job/ZooKeeper-trunk/255/]) ZOOKEEPER-2807: Fix flaky test (fangmin: rev 05d4d437d808f6cdf4c9dc5419a6e8d635c2ba5d) * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/test/WatchEventWhenAutoResetTest.java > Flaky test: > org.apache.zookeeper.test.WatchEventWhenAutoResetTest.testNodeDataChanged > - > > Key: ZOOKEEPER-2807 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2807 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Abraham Fine >Assignee: Andor Molnar >Priority: Major > Labels: pull-request-available > Time Spent: 5h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-2807) Flaky test: org.apache.zookeeper.test.WatchEventWhenAutoResetTest.testNodeDataChanged
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674906#comment-16674906 ] Hudson commented on ZOOKEEPER-2807: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #92 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/92/]) ZOOKEEPER-2807: Fix flaky test (fangmin: rev 05d4d437d808f6cdf4c9dc5419a6e8d635c2ba5d) * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/test/WatchEventWhenAutoResetTest.java > Flaky test: > org.apache.zookeeper.test.WatchEventWhenAutoResetTest.testNodeDataChanged > - > > Key: ZOOKEEPER-2807 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2807 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Abraham Fine >Assignee: Andor Molnar >Priority: Major > Labels: pull-request-available > Time Spent: 5h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
