complete quota system proposal

[Mocheng Guo]

Hi, currently Zookeeper has a storage quota feature which is informational
only and there are a few JIRAs to enforce throttling.

ZOOKEEPER-451
ZOOKEEPER-2593
ZOOKEEPER-3301

I am wondering if a more complete quota/throttling system covering metrics
such as storage/rate/watch/connection would be valuable here? We at FB have
been battling with excessive system usage from clients and did some work in
this area. We'd be happy to submit the work for review and consolidate with
existing efforts if people feel this is a good feature to add.

thanks
Mocheng

ZooKeeper_branch34_openjdk8 - Build # 389 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34_openjdk8/389/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 44.22 KB...]
[junit] Running org.apache.zookeeper.test.SaslAuthFailNotifyTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.548 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.618 sec
[junit] Running org.apache.zookeeper.test.SaslAuthMissingClientConfigTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.496 sec
[junit] Running org.apache.zookeeper.test.SaslClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.087 sec
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.527 sec
[junit] Running org.apache.zookeeper.test.SessionTest
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
11.27 sec
[junit] Running org.apache.zookeeper.test.SessionTimeoutTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.772 sec
[junit] Running org.apache.zookeeper.test.StandaloneTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.933 sec
[junit] Running org.apache.zookeeper.test.StatTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.651 sec
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.733 sec
[junit] Running org.apache.zookeeper.test.SyncCallTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.549 sec
[junit] Running org.apache.zookeeper.test.TruncateTest
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
8.148 sec
[junit] Running org.apache.zookeeper.test.UpgradeTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.892 sec
[junit] Running org.apache.zookeeper.test.WatchedEventTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.084 sec
[junit] Running org.apache.zookeeper.test.WatcherFuncTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.758 sec
[junit] Running org.apache.zookeeper.test.WatcherTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
29.259 sec
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
5.245 sec
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.63 sec
[junit] Running org.apache.jute.BinaryInputArchiveTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.082 sec

fail.build.on.test.failure:

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk8/build.xml:1425:
 The following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk8/build.xml:1428:
 Tests failed!

Total time: 28 minutes 53 seconds
Build step 'Invoke Ant' marked build as failure
Archiving artifacts
Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/
Recording test results
Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/
Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/
Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/
Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/
Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/
Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  
org.apache.zookeeper.server.quorum.EphemeralNodeDeletionTest.testEphemeralNodeDeletion

Error Message:
After session close ephemeral node must be deleted expected null, but 
was:<4294967302,4294967302,1563290577673,1563290577673,0,0,0,145575150357250048,1,0,4294967302
>

Stack Trace:
junit.framework.AssertionFailedError: After session close ephemeral node must 
be deleted expected null, but 
was:<4294967302,4294967302,1563290577673,1563290577673,0,0,0,145575150357250048,1,0,4294967302
>
at 

Re: ASF Jenkins is no more validating our Pull Requests

[Enrico Olivelli]

Il giorno mar 16 lug 2019 alle ore 17:13 Patrick Hunt  ha
scritto:

> Enrico - FYI, seems this impacting many teams:
>
>
> https://issues.apache.org/jira/browse/INFRA-18748?focusedCommentId=16885091=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16885091
>
>
thank you Patrick

I was aware of the fix because I read about the change on bui...@apache.org
ML

I have fixed it, it is seems to be working now

Enrico



> Patrick
>
>
> On Tue, Jul 16, 2019 at 7:17 AM Enrico Olivelli 
> wrote:
>
> > Hi,
> > Jenkins is not validating the pull requests any more.
> >
> > We have to change a little the configuration due to ongoing changes from
> > INFRA
> >
> > I am activating now the "Build pull requests to the repository" flag on
> our
> > jobs
> >
> > Enrico
> >
>

Re: ASF Jenkins is no more validating our Pull Requests

[Patrick Hunt]

Enrico - FYI, seems this impacting many teams:

https://issues.apache.org/jira/browse/INFRA-18748?focusedCommentId=16885091=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16885091

Patrick


On Tue, Jul 16, 2019 at 7:17 AM Enrico Olivelli  wrote:

> Hi,
> Jenkins is not validating the pull requests any more.
>
> We have to change a little the configuration due to ongoing changes from
> INFRA
>
> I am activating now the "Build pull requests to the repository" flag on our
> jobs
>
> Enrico
>

ASF Jenkins is no more validating our Pull Requests

[Enrico Olivelli]

Hi,
Jenkins is not validating the pull requests any more.

We have to change a little the configuration due to ongoing changes from
INFRA

I am activating now the "Build pull requests to the repository" flag on our
jobs

Enrico

Re: Intellij Idea warning as error with -Xdoclint

[Andor Molnar]

Sure.

https://issues.apache.org/jira/browse/ZOOKEEPER-3463

Andor



> On 2019. Jul 16., at 15:32, Enrico Olivelli  wrote:
> 
> Il giorno mar 16 lug 2019 alle ore 14:59 Andor Molnar  ha
> scritto:
> 
>> It works for me with the following maven compiler options:
>> 
>> 
>>   true
>>   
>> ...
>> -Xdoclint:-missing
>> ...
>>  
>> 
>> 
> 
> Can please you send a patch ?
> 
> I am +1 in adding such configuration
> 
> Good catch
> 
> Enrico
> 
> 
>> 
>> Andor
>> 
>> 
>> 
>>> On 2019. Jul 16., at 14:40, Andor Molnar  wrote:
>>> 
>>> Maven default:
>>> 
>>> boolean 2.0
>>> Set to true to show compilation warnings.
>>> Default value is: false.
>>> 
>>> Andor
>>> 
>>> 
>>> 
 On 2019. Jul 16., at 14:33, Andor Molnar  wrote:
 
 ‘-nowarn’ disables all warning messages.
 Where does it come from?
 
 Andor
 
 
 
> On 2019. Jul 16., at 14:30, Enrico Olivelli 
>> wrote:
> 
> I am running inside zookeeper-server
> mvn compile -X
> 
> and I see:
> 
> [DEBUG] Command line options:
> [DEBUG] Command line options:
> [DEBUG] -d /home/username/dev/zookeeper/zookeeper-server/target/classes
> -classpath
> 
>> /home/username/dev/zookeeper/zookeeper-server/target/classes:/home/username/.m2/repository/com/github/spotbugs/spotbugs-annotations/3.1.9/spotbugs-annotations-3.1.9.jar:/home/username/.m2/repository/com/google/code/findbugs/jsr305/3.0.2/jsr305-3.0.2.jar:/home/username/.m2/repository/commons-lang/commons-lang/2.6/commons-lang-2.6.jar:/home/username/.m2/repository/org/apache/zookeeper/zookeeper-jute/3.6.0-SNAPSHOT/zookeeper-jute-3.6.0-SNAPSHOT.jar:/home/username/.m2/repository/commons-cli/commons-cli/1.2/commons-cli-1.2.jar:/home/username/.m2/repository/org/apache/yetus/audience-annotations/0.5.0/audience-annotations-0.5.0.jar:/home/username/.m2/repository/io/netty/netty-all/4.1.36.Final/netty-all-4.1.36.Final.jar:/home/username/.m2/repository/org/slf4j/slf4j-api/1.7.25/slf4j-api-1.7.25.jar:/home/username/.m2/repository/org/slf4j/slf4j-log4j12/1.7.25/slf4j-log4j12-1.7.25.jar:/home/username/.m2/repository/org/eclipse/jetty/jetty-server/9.4.17.v20190418/jetty-server-9.4.17.v20190418.jar:/home/username/.m2/repository/javax/servlet/javax.servlet-api/3.1.0/javax.servlet-api-3.1.0.jar:/home/username/.m2/repository/org/eclipse/jetty/jetty-http/9.4.17.v20190418/jetty-http-9.4.17.v20190418.jar:/home/username/.m2/repository/org/eclipse/jetty/jetty-util/9.4.17.v20190418/jetty-util-9.4.17.v20190418.jar:/home/username/.m2/repository/org/eclipse/jetty/jetty-io/
>> 9.4.17.
>> v20190418/jetty-io-9.4.17.v20190418.jar:/home/username/.m2/repository/org/eclipse/jetty/jetty-servlet/
>> 9.4.17.
>> v20190418/jetty-servlet-9.4.17.v20190418.jar:/home/username/.m2/repository/org/eclipse/jetty/jetty-security/9.4.17.v20190418/jetty-security-9.4.17.v20190418.jar:/home/username/.m2/repository/com/fasterxml/jackson/core/jackson-databind/
> 
>> 2.9.9.1/jackson-databind-2.9.9.1.jar:/home/username/.m2/repository/com/fasterxml/jackson/core/jackson-annotations/2.9.0/jackson-annotations-2.9.0.jar:/home/username/.m2/repository/com/fasterxml/jackson/core/jackson-core/2.9.9/jackson-core-2.9.9.jar:/home/username/.m2/repository/com/googlecode/json-simple/json-simple/1.1.1/json-simple-1.1.1.jar:/home/username/.m2/repository/jline/jline/2.11/jline-2.11.jar:/home/username/.m2/repository/io/dropwizard/metrics/metrics-core/3.2.5/metrics-core-3.2.5.jar:/home/username/.m2/repository/log4j/log4j/1.2.17/log4j-1.2.17.jar:/home/username/.m2/repository/org/xerial/snappy/snappy-java/1.1.7/snappy-java-1.1.7.jar
>> :
> -sourcepath
> 
>> /home/username/dev/zookeeper/zookeeper-server/src/main/java:/home/username/dev/zookeeper/zookeeper-server/target/generated-sources/java:/home/username/dev/zookeeper/zookeeper-server/target/generated-sources/annotations:
> -s
> 
>> /home/username/dev/zookeeper/zookeeper-server/target/generated-sources/annotations
> -g -nowarn -target 1.8 -source 1.8 -encoding UTF-8 -Werror
> -Xlint:deprecation -Xlint:unchecked -Xdoclint -Xpkginfo:always
> 
> maybe it is the '-nowarn' option ?
> 
> Enrico
> 
> 
> Il giorno mar 16 lug 2019 alle ore 14:23 Norbert Kalmar
>  ha scritto:
> 
>> I'm guessing you are using the bundled maven (that's the default).
>> What
>> about if you change to your mvn install under
>> Build,Execution,Deployment/Build tools/maven
>> 
>> I always found IDE integrated tools to be troublesome. Git, maven,
>> java
>> runtime etc.
>> 
>> Regards,
>> Norbert
>> 
>> On Tue, Jul 16, 2019 at 1:59 PM Andor Molnar 
>> wrote:
>> 
>>> Idea cannot build ZooKeeper out-of-the-box. Here’s the error message
>> when
>>> trying to build zookeeper-server:
>>> 
>>> 
>>> 
>> 
>> /Users/andormolnar/git/my-zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/command/StatCommand.java
>>> Warning:(19, 1) java: 

[jira] [Created] (ZOOKEEPER-3463) Enable warning messages in maven compiler plugin

[Andor Molnar (JIRA)]

Andor Molnar created ZOOKEEPER-3463:
---

 Summary: Enable warning messages in maven compiler plugin
 Key: ZOOKEEPER-3463
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3463
 Project: ZooKeeper
  Issue Type: Task
  Components: build
Affects Versions: 3.4.14, 3.5.5, 3.6.0
Reporter: Andor Molnar
Assignee: Andor Molnar


"Show Warnings" is off by default in Maven Compiler Plugin. This invalidates 
our most recent setting of -Werror (treat warnings as errors).

Let's enable compiler warning messages in all projects and adjust Xdoclint 
setting:
{noformat}

  true
  
...
-Xdoclint:-missing
...
 
{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Re: Intellij Idea warning as error with -Xdoclint

[Enrico Olivelli]

Il giorno mar 16 lug 2019 alle ore 14:59 Andor Molnar  ha
scritto:

> It works for me with the following maven compiler options:
>
> 
>true
>
>  ...
>  -Xdoclint:-missing
>  ...
>   
> 
>

Can please you send a patch ?

I am +1 in adding such configuration

Good catch

Enrico


>
> Andor
>
>
>
> > On 2019. Jul 16., at 14:40, Andor Molnar  wrote:
> >
> > Maven default:
> >
> > boolean 2.0
> > Set to true to show compilation warnings.
> > Default value is: false.
> >
> > Andor
> >
> >
> >
> >> On 2019. Jul 16., at 14:33, Andor Molnar  wrote:
> >>
> >> ‘-nowarn’ disables all warning messages.
> >> Where does it come from?
> >>
> >> Andor
> >>
> >>
> >>
> >>> On 2019. Jul 16., at 14:30, Enrico Olivelli 
> wrote:
> >>>
> >>> I am running inside zookeeper-server
> >>> mvn compile -X
> >>>
> >>> and I see:
> >>>
> >>> [DEBUG] Command line options:
> >>> [DEBUG] Command line options:
> >>> [DEBUG] -d /home/username/dev/zookeeper/zookeeper-server/target/classes
> >>> -classpath
> >>>
> /home/username/dev/zookeeper/zookeeper-server/target/classes:/home/username/.m2/repository/com/github/spotbugs/spotbugs-annotations/3.1.9/spotbugs-annotations-3.1.9.jar:/home/username/.m2/repository/com/google/code/findbugs/jsr305/3.0.2/jsr305-3.0.2.jar:/home/username/.m2/repository/commons-lang/commons-lang/2.6/commons-lang-2.6.jar:/home/username/.m2/repository/org/apache/zookeeper/zookeeper-jute/3.6.0-SNAPSHOT/zookeeper-jute-3.6.0-SNAPSHOT.jar:/home/username/.m2/repository/commons-cli/commons-cli/1.2/commons-cli-1.2.jar:/home/username/.m2/repository/org/apache/yetus/audience-annotations/0.5.0/audience-annotations-0.5.0.jar:/home/username/.m2/repository/io/netty/netty-all/4.1.36.Final/netty-all-4.1.36.Final.jar:/home/username/.m2/repository/org/slf4j/slf4j-api/1.7.25/slf4j-api-1.7.25.jar:/home/username/.m2/repository/org/slf4j/slf4j-log4j12/1.7.25/slf4j-log4j12-1.7.25.jar:/home/username/.m2/repository/org/eclipse/jetty/jetty-server/9.4.17.v20190418/jetty-server-9.4.17.v20190418.jar:/home/username/.m2/repository/javax/servlet/javax.servlet-api/3.1.0/javax.servlet-api-3.1.0.jar:/home/username/.m2/repository/org/eclipse/jetty/jetty-http/9.4.17.v20190418/jetty-http-9.4.17.v20190418.jar:/home/username/.m2/repository/org/eclipse/jetty/jetty-util/9.4.17.v20190418/jetty-util-9.4.17.v20190418.jar:/home/username/.m2/repository/org/eclipse/jetty/jetty-io/
> 9.4.17.
> v20190418/jetty-io-9.4.17.v20190418.jar:/home/username/.m2/repository/org/eclipse/jetty/jetty-servlet/
> 9.4.17.
> v20190418/jetty-servlet-9.4.17.v20190418.jar:/home/username/.m2/repository/org/eclipse/jetty/jetty-security/9.4.17.v20190418/jetty-security-9.4.17.v20190418.jar:/home/username/.m2/repository/com/fasterxml/jackson/core/jackson-databind/
> >>>
> 2.9.9.1/jackson-databind-2.9.9.1.jar:/home/username/.m2/repository/com/fasterxml/jackson/core/jackson-annotations/2.9.0/jackson-annotations-2.9.0.jar:/home/username/.m2/repository/com/fasterxml/jackson/core/jackson-core/2.9.9/jackson-core-2.9.9.jar:/home/username/.m2/repository/com/googlecode/json-simple/json-simple/1.1.1/json-simple-1.1.1.jar:/home/username/.m2/repository/jline/jline/2.11/jline-2.11.jar:/home/username/.m2/repository/io/dropwizard/metrics/metrics-core/3.2.5/metrics-core-3.2.5.jar:/home/username/.m2/repository/log4j/log4j/1.2.17/log4j-1.2.17.jar:/home/username/.m2/repository/org/xerial/snappy/snappy-java/1.1.7/snappy-java-1.1.7.jar
> :
> >>> -sourcepath
> >>>
> /home/username/dev/zookeeper/zookeeper-server/src/main/java:/home/username/dev/zookeeper/zookeeper-server/target/generated-sources/java:/home/username/dev/zookeeper/zookeeper-server/target/generated-sources/annotations:
> >>> -s
> >>>
> /home/username/dev/zookeeper/zookeeper-server/target/generated-sources/annotations
> >>> -g -nowarn -target 1.8 -source 1.8 -encoding UTF-8 -Werror
> >>> -Xlint:deprecation -Xlint:unchecked -Xdoclint -Xpkginfo:always
> >>>
> >>> maybe it is the '-nowarn' option ?
> >>>
> >>> Enrico
> >>>
> >>>
> >>> Il giorno mar 16 lug 2019 alle ore 14:23 Norbert Kalmar
> >>>  ha scritto:
> >>>
>  I'm guessing you are using the bundled maven (that's the default).
> What
>  about if you change to your mvn install under
>  Build,Execution,Deployment/Build tools/maven
> 
>  I always found IDE integrated tools to be troublesome. Git, maven,
> java
>  runtime etc.
> 
>  Regards,
>  Norbert
> 
>  On Tue, Jul 16, 2019 at 1:59 PM Andor Molnar 
> wrote:
> 
> > Idea cannot build ZooKeeper out-of-the-box. Here’s the error message
> when
> > trying to build zookeeper-server:
> >
> >
> >
> 
> /Users/andormolnar/git/my-zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/command/StatCommand.java
> > Warning:(19, 1) java: documentation comment not expected here
> > Warning:(33, 8) java: no comment
> > Warning:(34, 33) java: no comment
> > Warning:(36, 17) java: no comment
> > Warning:(37, 12) java: no comment
> > 

Re: Intellij Idea warning as error with -Xdoclint

[Andor Molnar]

It works for me with the following maven compiler options:


   true
   
 ...
 -Xdoclint:-missing
 ...
  


Andor



> On 2019. Jul 16., at 14:40, Andor Molnar  wrote:
> 
> Maven default:
> 
> boolean 2.0 
> Set to true to show compilation warnings.
> Default value is: false.
> 
> Andor
> 
> 
> 
>> On 2019. Jul 16., at 14:33, Andor Molnar  wrote:
>> 
>> ‘-nowarn’ disables all warning messages.
>> Where does it come from?
>> 
>> Andor
>> 
>> 
>> 
>>> On 2019. Jul 16., at 14:30, Enrico Olivelli  wrote:
>>> 
>>> I am running inside zookeeper-server
>>> mvn compile -X
>>> 
>>> and I see:
>>> 
>>> [DEBUG] Command line options:
>>> [DEBUG] Command line options:
>>> [DEBUG] -d /home/username/dev/zookeeper/zookeeper-server/target/classes
>>> -classpath
>>> /home/username/dev/zookeeper/zookeeper-server/target/classes:/home/username/.m2/repository/com/github/spotbugs/spotbugs-annotations/3.1.9/spotbugs-annotations-3.1.9.jar:/home/username/.m2/repository/com/google/code/findbugs/jsr305/3.0.2/jsr305-3.0.2.jar:/home/username/.m2/repository/commons-lang/commons-lang/2.6/commons-lang-2.6.jar:/home/username/.m2/repository/org/apache/zookeeper/zookeeper-jute/3.6.0-SNAPSHOT/zookeeper-jute-3.6.0-SNAPSHOT.jar:/home/username/.m2/repository/commons-cli/commons-cli/1.2/commons-cli-1.2.jar:/home/username/.m2/repository/org/apache/yetus/audience-annotations/0.5.0/audience-annotations-0.5.0.jar:/home/username/.m2/repository/io/netty/netty-all/4.1.36.Final/netty-all-4.1.36.Final.jar:/home/username/.m2/repository/org/slf4j/slf4j-api/1.7.25/slf4j-api-1.7.25.jar:/home/username/.m2/repository/org/slf4j/slf4j-log4j12/1.7.25/slf4j-log4j12-1.7.25.jar:/home/username/.m2/repository/org/eclipse/jetty/jetty-server/9.4.17.v20190418/jetty-server-9.4.17.v20190418.jar:/home/username/.m2/repository/javax/servlet/javax.servlet-api/3.1.0/javax.servlet-api-3.1.0.jar:/home/username/.m2/repository/org/eclipse/jetty/jetty-http/9.4.17.v20190418/jetty-http-9.4.17.v20190418.jar:/home/username/.m2/repository/org/eclipse/jetty/jetty-util/9.4.17.v20190418/jetty-util-9.4.17.v20190418.jar:/home/username/.m2/repository/org/eclipse/jetty/jetty-io/9.4.17.v20190418/jetty-io-9.4.17.v20190418.jar:/home/username/.m2/repository/org/eclipse/jetty/jetty-servlet/9.4.17.v20190418/jetty-servlet-9.4.17.v20190418.jar:/home/username/.m2/repository/org/eclipse/jetty/jetty-security/9.4.17.v20190418/jetty-security-9.4.17.v20190418.jar:/home/username/.m2/repository/com/fasterxml/jackson/core/jackson-databind/
>>> 2.9.9.1/jackson-databind-2.9.9.1.jar:/home/username/.m2/repository/com/fasterxml/jackson/core/jackson-annotations/2.9.0/jackson-annotations-2.9.0.jar:/home/username/.m2/repository/com/fasterxml/jackson/core/jackson-core/2.9.9/jackson-core-2.9.9.jar:/home/username/.m2/repository/com/googlecode/json-simple/json-simple/1.1.1/json-simple-1.1.1.jar:/home/username/.m2/repository/jline/jline/2.11/jline-2.11.jar:/home/username/.m2/repository/io/dropwizard/metrics/metrics-core/3.2.5/metrics-core-3.2.5.jar:/home/username/.m2/repository/log4j/log4j/1.2.17/log4j-1.2.17.jar:/home/username/.m2/repository/org/xerial/snappy/snappy-java/1.1.7/snappy-java-1.1.7.jar:
>>> -sourcepath
>>> /home/username/dev/zookeeper/zookeeper-server/src/main/java:/home/username/dev/zookeeper/zookeeper-server/target/generated-sources/java:/home/username/dev/zookeeper/zookeeper-server/target/generated-sources/annotations:
>>> -s
>>> /home/username/dev/zookeeper/zookeeper-server/target/generated-sources/annotations
>>> -g -nowarn -target 1.8 -source 1.8 -encoding UTF-8 -Werror
>>> -Xlint:deprecation -Xlint:unchecked -Xdoclint -Xpkginfo:always
>>> 
>>> maybe it is the '-nowarn' option ?
>>> 
>>> Enrico
>>> 
>>> 
>>> Il giorno mar 16 lug 2019 alle ore 14:23 Norbert Kalmar
>>>  ha scritto:
>>> 
 I'm guessing you are using the bundled maven (that's the default). What
 about if you change to your mvn install under
 Build,Execution,Deployment/Build tools/maven
 
 I always found IDE integrated tools to be troublesome. Git, maven, java
 runtime etc.
 
 Regards,
 Norbert
 
 On Tue, Jul 16, 2019 at 1:59 PM Andor Molnar  wrote:
 
> Idea cannot build ZooKeeper out-of-the-box. Here’s the error message when
> trying to build zookeeper-server:
> 
> 
> 
 /Users/andormolnar/git/my-zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/command/StatCommand.java
> Warning:(19, 1) java: documentation comment not expected here
> Warning:(33, 8) java: no comment
> Warning:(34, 33) java: no comment
> Warning:(36, 17) java: no comment
> Warning:(37, 12) java: no comment
> Error:java: warnings found and -Werror specified
> 
> There’re lots of others, I just picked StatCommand.java as an example.
> 
> Idea is running the standard Javac compiler with the arguments imported
> from Maven settings:
> javac -Werror -Xlint:deprecation -Xlint:unchecked -Xdoclint
> -Xpkginfo:always

Re: Intellij Idea warning as error with -Xdoclint

[Andor Molnar]

Maven default:

  boolean 2.0 
Set to true to show compilation warnings.
Default value is: false.

Andor



> On 2019. Jul 16., at 14:33, Andor Molnar  wrote:
> 
> ‘-nowarn’ disables all warning messages.
> Where does it come from?
> 
> Andor
> 
> 
> 
>> On 2019. Jul 16., at 14:30, Enrico Olivelli  wrote:
>> 
>> I am running inside zookeeper-server
>> mvn compile -X
>> 
>> and I see:
>> 
>> [DEBUG] Command line options:
>> [DEBUG] Command line options:
>> [DEBUG] -d /home/username/dev/zookeeper/zookeeper-server/target/classes
>> -classpath
>> /home/username/dev/zookeeper/zookeeper-server/target/classes:/home/username/.m2/repository/com/github/spotbugs/spotbugs-annotations/3.1.9/spotbugs-annotations-3.1.9.jar:/home/username/.m2/repository/com/google/code/findbugs/jsr305/3.0.2/jsr305-3.0.2.jar:/home/username/.m2/repository/commons-lang/commons-lang/2.6/commons-lang-2.6.jar:/home/username/.m2/repository/org/apache/zookeeper/zookeeper-jute/3.6.0-SNAPSHOT/zookeeper-jute-3.6.0-SNAPSHOT.jar:/home/username/.m2/repository/commons-cli/commons-cli/1.2/commons-cli-1.2.jar:/home/username/.m2/repository/org/apache/yetus/audience-annotations/0.5.0/audience-annotations-0.5.0.jar:/home/username/.m2/repository/io/netty/netty-all/4.1.36.Final/netty-all-4.1.36.Final.jar:/home/username/.m2/repository/org/slf4j/slf4j-api/1.7.25/slf4j-api-1.7.25.jar:/home/username/.m2/repository/org/slf4j/slf4j-log4j12/1.7.25/slf4j-log4j12-1.7.25.jar:/home/username/.m2/repository/org/eclipse/jetty/jetty-server/9.4.17.v20190418/jetty-server-9.4.17.v20190418.jar:/home/username/.m2/repository/javax/servlet/javax.servlet-api/3.1.0/javax.servlet-api-3.1.0.jar:/home/username/.m2/repository/org/eclipse/jetty/jetty-http/9.4.17.v20190418/jetty-http-9.4.17.v20190418.jar:/home/username/.m2/repository/org/eclipse/jetty/jetty-util/9.4.17.v20190418/jetty-util-9.4.17.v20190418.jar:/home/username/.m2/repository/org/eclipse/jetty/jetty-io/9.4.17.v20190418/jetty-io-9.4.17.v20190418.jar:/home/username/.m2/repository/org/eclipse/jetty/jetty-servlet/9.4.17.v20190418/jetty-servlet-9.4.17.v20190418.jar:/home/username/.m2/repository/org/eclipse/jetty/jetty-security/9.4.17.v20190418/jetty-security-9.4.17.v20190418.jar:/home/username/.m2/repository/com/fasterxml/jackson/core/jackson-databind/
>> 2.9.9.1/jackson-databind-2.9.9.1.jar:/home/username/.m2/repository/com/fasterxml/jackson/core/jackson-annotations/2.9.0/jackson-annotations-2.9.0.jar:/home/username/.m2/repository/com/fasterxml/jackson/core/jackson-core/2.9.9/jackson-core-2.9.9.jar:/home/username/.m2/repository/com/googlecode/json-simple/json-simple/1.1.1/json-simple-1.1.1.jar:/home/username/.m2/repository/jline/jline/2.11/jline-2.11.jar:/home/username/.m2/repository/io/dropwizard/metrics/metrics-core/3.2.5/metrics-core-3.2.5.jar:/home/username/.m2/repository/log4j/log4j/1.2.17/log4j-1.2.17.jar:/home/username/.m2/repository/org/xerial/snappy/snappy-java/1.1.7/snappy-java-1.1.7.jar:
>> -sourcepath
>> /home/username/dev/zookeeper/zookeeper-server/src/main/java:/home/username/dev/zookeeper/zookeeper-server/target/generated-sources/java:/home/username/dev/zookeeper/zookeeper-server/target/generated-sources/annotations:
>> -s
>> /home/username/dev/zookeeper/zookeeper-server/target/generated-sources/annotations
>> -g -nowarn -target 1.8 -source 1.8 -encoding UTF-8 -Werror
>> -Xlint:deprecation -Xlint:unchecked -Xdoclint -Xpkginfo:always
>> 
>> maybe it is the '-nowarn' option ?
>> 
>> Enrico
>> 
>> 
>> Il giorno mar 16 lug 2019 alle ore 14:23 Norbert Kalmar
>>  ha scritto:
>> 
>>> I'm guessing you are using the bundled maven (that's the default). What
>>> about if you change to your mvn install under
>>> Build,Execution,Deployment/Build tools/maven
>>> 
>>> I always found IDE integrated tools to be troublesome. Git, maven, java
>>> runtime etc.
>>> 
>>> Regards,
>>> Norbert
>>> 
>>> On Tue, Jul 16, 2019 at 1:59 PM Andor Molnar  wrote:
>>> 
 Idea cannot build ZooKeeper out-of-the-box. Here’s the error message when
 trying to build zookeeper-server:
 
 
 
>>> /Users/andormolnar/git/my-zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/command/StatCommand.java
 Warning:(19, 1) java: documentation comment not expected here
 Warning:(33, 8) java: no comment
 Warning:(34, 33) java: no comment
 Warning:(36, 17) java: no comment
 Warning:(37, 12) java: no comment
 Error:java: warnings found and -Werror specified
 
 There’re lots of others, I just picked StatCommand.java as an example.
 
 Idea is running the standard Javac compiler with the arguments imported
 from Maven settings:
 javac -Werror -Xlint:deprecation -Xlint:unchecked -Xdoclint
 -Xpkginfo:always
 
 thanks,
 Andor
 
 
 
> On 2019. Jul 16., at 13:37, Enrico Olivelli 
>>> wrote:
> 
> Il giorno mar 16 lug 2019 alle ore 07:44 Andor Molnar <
>>> an...@apache.org>
 ha
> scritto:
> 
>> Yes, my main concern is: why does the maven 

Jenkins build became unstable: zookeeper-master-maven-jdk11 #46

[Apache Jenkins Server]

See 

Re: Intellij Idea warning as error with -Xdoclint

[Andor Molnar]

‘-nowarn’ disables all warning messages.
Where does it come from?

Andor



> On 2019. Jul 16., at 14:30, Enrico Olivelli  wrote:
> 
> I am running inside zookeeper-server
> mvn compile -X
> 
> and I see:
> 
> [DEBUG] Command line options:
> [DEBUG] Command line options:
> [DEBUG] -d /home/username/dev/zookeeper/zookeeper-server/target/classes
> -classpath
> /home/username/dev/zookeeper/zookeeper-server/target/classes:/home/username/.m2/repository/com/github/spotbugs/spotbugs-annotations/3.1.9/spotbugs-annotations-3.1.9.jar:/home/username/.m2/repository/com/google/code/findbugs/jsr305/3.0.2/jsr305-3.0.2.jar:/home/username/.m2/repository/commons-lang/commons-lang/2.6/commons-lang-2.6.jar:/home/username/.m2/repository/org/apache/zookeeper/zookeeper-jute/3.6.0-SNAPSHOT/zookeeper-jute-3.6.0-SNAPSHOT.jar:/home/username/.m2/repository/commons-cli/commons-cli/1.2/commons-cli-1.2.jar:/home/username/.m2/repository/org/apache/yetus/audience-annotations/0.5.0/audience-annotations-0.5.0.jar:/home/username/.m2/repository/io/netty/netty-all/4.1.36.Final/netty-all-4.1.36.Final.jar:/home/username/.m2/repository/org/slf4j/slf4j-api/1.7.25/slf4j-api-1.7.25.jar:/home/username/.m2/repository/org/slf4j/slf4j-log4j12/1.7.25/slf4j-log4j12-1.7.25.jar:/home/username/.m2/repository/org/eclipse/jetty/jetty-server/9.4.17.v20190418/jetty-server-9.4.17.v20190418.jar:/home/username/.m2/repository/javax/servlet/javax.servlet-api/3.1.0/javax.servlet-api-3.1.0.jar:/home/username/.m2/repository/org/eclipse/jetty/jetty-http/9.4.17.v20190418/jetty-http-9.4.17.v20190418.jar:/home/username/.m2/repository/org/eclipse/jetty/jetty-util/9.4.17.v20190418/jetty-util-9.4.17.v20190418.jar:/home/username/.m2/repository/org/eclipse/jetty/jetty-io/9.4.17.v20190418/jetty-io-9.4.17.v20190418.jar:/home/username/.m2/repository/org/eclipse/jetty/jetty-servlet/9.4.17.v20190418/jetty-servlet-9.4.17.v20190418.jar:/home/username/.m2/repository/org/eclipse/jetty/jetty-security/9.4.17.v20190418/jetty-security-9.4.17.v20190418.jar:/home/username/.m2/repository/com/fasterxml/jackson/core/jackson-databind/
> 2.9.9.1/jackson-databind-2.9.9.1.jar:/home/username/.m2/repository/com/fasterxml/jackson/core/jackson-annotations/2.9.0/jackson-annotations-2.9.0.jar:/home/username/.m2/repository/com/fasterxml/jackson/core/jackson-core/2.9.9/jackson-core-2.9.9.jar:/home/username/.m2/repository/com/googlecode/json-simple/json-simple/1.1.1/json-simple-1.1.1.jar:/home/username/.m2/repository/jline/jline/2.11/jline-2.11.jar:/home/username/.m2/repository/io/dropwizard/metrics/metrics-core/3.2.5/metrics-core-3.2.5.jar:/home/username/.m2/repository/log4j/log4j/1.2.17/log4j-1.2.17.jar:/home/username/.m2/repository/org/xerial/snappy/snappy-java/1.1.7/snappy-java-1.1.7.jar:
> -sourcepath
> /home/username/dev/zookeeper/zookeeper-server/src/main/java:/home/username/dev/zookeeper/zookeeper-server/target/generated-sources/java:/home/username/dev/zookeeper/zookeeper-server/target/generated-sources/annotations:
> -s
> /home/username/dev/zookeeper/zookeeper-server/target/generated-sources/annotations
> -g -nowarn -target 1.8 -source 1.8 -encoding UTF-8 -Werror
> -Xlint:deprecation -Xlint:unchecked -Xdoclint -Xpkginfo:always
> 
> maybe it is the '-nowarn' option ?
> 
> Enrico
> 
> 
> Il giorno mar 16 lug 2019 alle ore 14:23 Norbert Kalmar
>  ha scritto:
> 
>> I'm guessing you are using the bundled maven (that's the default). What
>> about if you change to your mvn install under
>> Build,Execution,Deployment/Build tools/maven
>> 
>> I always found IDE integrated tools to be troublesome. Git, maven, java
>> runtime etc.
>> 
>> Regards,
>> Norbert
>> 
>> On Tue, Jul 16, 2019 at 1:59 PM Andor Molnar  wrote:
>> 
>>> Idea cannot build ZooKeeper out-of-the-box. Here’s the error message when
>>> trying to build zookeeper-server:
>>> 
>>> 
>>> 
>> /Users/andormolnar/git/my-zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/command/StatCommand.java
>>> Warning:(19, 1) java: documentation comment not expected here
>>> Warning:(33, 8) java: no comment
>>> Warning:(34, 33) java: no comment
>>> Warning:(36, 17) java: no comment
>>> Warning:(37, 12) java: no comment
>>> Error:java: warnings found and -Werror specified
>>> 
>>> There’re lots of others, I just picked StatCommand.java as an example.
>>> 
>>> Idea is running the standard Javac compiler with the arguments imported
>>> from Maven settings:
>>> javac -Werror -Xlint:deprecation -Xlint:unchecked -Xdoclint
>>> -Xpkginfo:always
>>> 
>>> thanks,
>>> Andor
>>> 
>>> 
>>> 
 On 2019. Jul 16., at 13:37, Enrico Olivelli 
>> wrote:
 
 Il giorno mar 16 lug 2019 alle ore 07:44 Andor Molnar <
>> an...@apache.org>
>>> ha
 scritto:
 
> Yes, my main concern is: why does the maven succeed, if we're still
> having javadoc issues?
> 
 
 if I run in zookeeper-server this command I can't find any WARNING or
>>> ERROR
 mvn javadoc:javadoc
 
 only this ignorable one (I think)
 INFO] --- 

Re: Intellij Idea warning as error with -Xdoclint

[Enrico Olivelli]

I am running inside zookeeper-server
mvn compile -X

and I see:

[DEBUG] Command line options:
[DEBUG] Command line options:
[DEBUG] -d /home/username/dev/zookeeper/zookeeper-server/target/classes
-classpath
/home/username/dev/zookeeper/zookeeper-server/target/classes:/home/username/.m2/repository/com/github/spotbugs/spotbugs-annotations/3.1.9/spotbugs-annotations-3.1.9.jar:/home/username/.m2/repository/com/google/code/findbugs/jsr305/3.0.2/jsr305-3.0.2.jar:/home/username/.m2/repository/commons-lang/commons-lang/2.6/commons-lang-2.6.jar:/home/username/.m2/repository/org/apache/zookeeper/zookeeper-jute/3.6.0-SNAPSHOT/zookeeper-jute-3.6.0-SNAPSHOT.jar:/home/username/.m2/repository/commons-cli/commons-cli/1.2/commons-cli-1.2.jar:/home/username/.m2/repository/org/apache/yetus/audience-annotations/0.5.0/audience-annotations-0.5.0.jar:/home/username/.m2/repository/io/netty/netty-all/4.1.36.Final/netty-all-4.1.36.Final.jar:/home/username/.m2/repository/org/slf4j/slf4j-api/1.7.25/slf4j-api-1.7.25.jar:/home/username/.m2/repository/org/slf4j/slf4j-log4j12/1.7.25/slf4j-log4j12-1.7.25.jar:/home/username/.m2/repository/org/eclipse/jetty/jetty-server/9.4.17.v20190418/jetty-server-9.4.17.v20190418.jar:/home/username/.m2/repository/javax/servlet/javax.servlet-api/3.1.0/javax.servlet-api-3.1.0.jar:/home/username/.m2/repository/org/eclipse/jetty/jetty-http/9.4.17.v20190418/jetty-http-9.4.17.v20190418.jar:/home/username/.m2/repository/org/eclipse/jetty/jetty-util/9.4.17.v20190418/jetty-util-9.4.17.v20190418.jar:/home/username/.m2/repository/org/eclipse/jetty/jetty-io/9.4.17.v20190418/jetty-io-9.4.17.v20190418.jar:/home/username/.m2/repository/org/eclipse/jetty/jetty-servlet/9.4.17.v20190418/jetty-servlet-9.4.17.v20190418.jar:/home/username/.m2/repository/org/eclipse/jetty/jetty-security/9.4.17.v20190418/jetty-security-9.4.17.v20190418.jar:/home/username/.m2/repository/com/fasterxml/jackson/core/jackson-databind/
2.9.9.1/jackson-databind-2.9.9.1.jar:/home/username/.m2/repository/com/fasterxml/jackson/core/jackson-annotations/2.9.0/jackson-annotations-2.9.0.jar:/home/username/.m2/repository/com/fasterxml/jackson/core/jackson-core/2.9.9/jackson-core-2.9.9.jar:/home/username/.m2/repository/com/googlecode/json-simple/json-simple/1.1.1/json-simple-1.1.1.jar:/home/username/.m2/repository/jline/jline/2.11/jline-2.11.jar:/home/username/.m2/repository/io/dropwizard/metrics/metrics-core/3.2.5/metrics-core-3.2.5.jar:/home/username/.m2/repository/log4j/log4j/1.2.17/log4j-1.2.17.jar:/home/username/.m2/repository/org/xerial/snappy/snappy-java/1.1.7/snappy-java-1.1.7.jar:
-sourcepath
/home/username/dev/zookeeper/zookeeper-server/src/main/java:/home/username/dev/zookeeper/zookeeper-server/target/generated-sources/java:/home/username/dev/zookeeper/zookeeper-server/target/generated-sources/annotations:
-s
/home/username/dev/zookeeper/zookeeper-server/target/generated-sources/annotations
-g -nowarn -target 1.8 -source 1.8 -encoding UTF-8 -Werror
-Xlint:deprecation -Xlint:unchecked -Xdoclint -Xpkginfo:always

maybe it is the '-nowarn' option ?

Enrico


Il giorno mar 16 lug 2019 alle ore 14:23 Norbert Kalmar
 ha scritto:

> I'm guessing you are using the bundled maven (that's the default). What
> about if you change to your mvn install under
> Build,Execution,Deployment/Build tools/maven
>
> I always found IDE integrated tools to be troublesome. Git, maven, java
> runtime etc.
>
> Regards,
> Norbert
>
> On Tue, Jul 16, 2019 at 1:59 PM Andor Molnar  wrote:
>
> > Idea cannot build ZooKeeper out-of-the-box. Here’s the error message when
> > trying to build zookeeper-server:
> >
> >
> >
> /Users/andormolnar/git/my-zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/command/StatCommand.java
> > Warning:(19, 1) java: documentation comment not expected here
> > Warning:(33, 8) java: no comment
> > Warning:(34, 33) java: no comment
> > Warning:(36, 17) java: no comment
> > Warning:(37, 12) java: no comment
> > Error:java: warnings found and -Werror specified
> >
> > There’re lots of others, I just picked StatCommand.java as an example.
> >
> > Idea is running the standard Javac compiler with the arguments imported
> > from Maven settings:
> > javac -Werror -Xlint:deprecation -Xlint:unchecked -Xdoclint
> > -Xpkginfo:always
> >
> > thanks,
> > Andor
> >
> >
> >
> > > On 2019. Jul 16., at 13:37, Enrico Olivelli 
> wrote:
> > >
> > > Il giorno mar 16 lug 2019 alle ore 07:44 Andor Molnar <
> an...@apache.org>
> > ha
> > > scritto:
> > >
> > >> Yes, my main concern is: why does the maven succeed, if we're still
> > >> having javadoc issues?
> > >>
> > >
> > > if I run in zookeeper-server this command I can't find any WARNING or
> > ERROR
> > > mvn javadoc:javadoc
> > >
> > > only this ignorable one (I think)
> > > INFO] --- maven-javadoc-plugin:3.0.1:javadoc (default-cli) @ zookeeper
> > ---
> > > [ERROR] Error fetching link:
> > >
> >
> /home/diennea.lan/enrico.olivelli/dev/zookeeper/zookeeper-jute/target/site/apidocs/package-list.
> > > 

Re: Intellij Idea warning as error with -Xdoclint

[Norbert Kalmar]

I'm guessing you are using the bundled maven (that's the default). What
about if you change to your mvn install under
Build,Execution,Deployment/Build tools/maven

I always found IDE integrated tools to be troublesome. Git, maven, java
runtime etc.

Regards,
Norbert

On Tue, Jul 16, 2019 at 1:59 PM Andor Molnar  wrote:

> Idea cannot build ZooKeeper out-of-the-box. Here’s the error message when
> trying to build zookeeper-server:
>
>
> /Users/andormolnar/git/my-zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/command/StatCommand.java
> Warning:(19, 1) java: documentation comment not expected here
> Warning:(33, 8) java: no comment
> Warning:(34, 33) java: no comment
> Warning:(36, 17) java: no comment
> Warning:(37, 12) java: no comment
> Error:java: warnings found and -Werror specified
>
> There’re lots of others, I just picked StatCommand.java as an example.
>
> Idea is running the standard Javac compiler with the arguments imported
> from Maven settings:
> javac -Werror -Xlint:deprecation -Xlint:unchecked -Xdoclint
> -Xpkginfo:always
>
> thanks,
> Andor
>
>
>
> > On 2019. Jul 16., at 13:37, Enrico Olivelli  wrote:
> >
> > Il giorno mar 16 lug 2019 alle ore 07:44 Andor Molnar 
> ha
> > scritto:
> >
> >> Yes, my main concern is: why does the maven succeed, if we're still
> >> having javadoc issues?
> >>
> >
> > if I run in zookeeper-server this command I can't find any WARNING or
> ERROR
> > mvn javadoc:javadoc
> >
> > only this ignorable one (I think)
> > INFO] --- maven-javadoc-plugin:3.0.1:javadoc (default-cli) @ zookeeper
> ---
> > [ERROR] Error fetching link:
> >
> /home/diennea.lan/enrico.olivelli/dev/zookeeper/zookeeper-jute/target/site/apidocs/package-list.
> > Ignored it.
> >
> > and javadocs are generated correctly
> >
> > Does Idea fail the build  ? do you have logs to share ? (I don't have
> Idea,
> > I am using NetBeans that apparently runs maven from the command line when
> > building)
> >
> > Enrico
> >
> >
> >
> >>
> >> Andor
> >>
> >>
> >> -Original Message-
> >> From: Enrico Olivelli 
> >> Reply-To: dev@zookeeper.apache.org
> >> To: dev@zookeeper.apache.org
> >> Subject: Re: Intellij Idea warning as error with -Xdoclint
> >> Date: Mon, 15 Jul 2019 21:58:09 +0200
> >>
> >> Il lun 15 lug 2019, 13:53 Andor Molnar <
> >> an...@apache.org
> >>> ha scritto:
> >>
> >>> Hi Enrico,
> >>>
> >>> This is still an issue for me in IDEA:
> >>>
> >>> Javadoc problems found in zookeeper-jute and zookeeper-server
> >>> projects, so
> >>> the build eventually fails. Strange thing is that running maven from
> >>> command line doesn’t show any warning nor error.
> >>>
> >>> From javac params -Werror and -Xdoclint I think IDEA’s behaviour is
> >>> correct.
> >>>
> >>> Most warning messages in IDEA are about missing javadoc comments, so
> >>> changing it to "-Xdoclint:-missing” solves the problem.
> >>>
> >>
> >> I can try to understand better.
> >> If I understand correctly your point is that apparently Idea is working
> >> as
> >> expected but Maven not and this is not good because CI runs with Maven.
> >>
> >> I will be back with news.
> >> Hopefully we can fix javadocs and have a reliable way to detect issues
> >> on
> >> docs on CI/precommit/nightly
> >>
> >> Enrico
> >>
> >>
> >>> Regards,
> >>> Andor
> >>>
> >>>
> >>>
> >>>
>  On 2019. Jun 20., at 20:28, Andor Molnar <
>  an...@apache.org
> > wrote:
> 
>  Done. #983 merged, problem gone.
>  Thanks maoling!
> 
>  Andor
> 
> 
> 
> > On 2019. Jun 20., at 15:43, maoling <
> > maoling199210...@sina.com
> >> wrote:
> >
> > I also noticed this when running UT with IDEA.may we can merge
> > this PR:
> > https://github.com/apache/zookeeper/pull/988
> >
> > Or this one:
> > https://github.com/apache/zookeeper/pull/983
> > to remove
> >>>
> >>> that warning.
> > 发送自 Windows 10 版邮件应用
> >
> > 发件人: Andor Molnar
> > 发送时间: 2019年6月20日 5:46
> > 收件人: DevZooKeeper
> > 主题: Intellij Idea warning as error with -Xdoclint
> >
> >
> > Hi Enrico,
> >
> > I have the following error message in Idea since -Xdoclint is
> > enabled
> >>>
> >>> in the main pom.xml file:
> >
> >>>
> >>> /Users/andormolnar/git/my-zookeeper/zookeeper-
> >>> jute/src/main/java/org/apache/jute/Utils.java
> > Error:(194, 15) java: @param name not found
> > Error:(231, 15) java: @param name not found
> >
> > Strange that I don’t see the same warnings in console when
> > running ‘mvn
> >>>
> >>> install’.
> > I confirm that removing “-Xdoclint” (or fixing javadoc issues)
> > solves
> >>>
> >>> the problem.
> > Andor
> >
> >
> >
> >
> >>>
> >>>
> >>
> >>
>
>

ZooKeeper-trunk - Build # 618 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk/618/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 187.48 KB...]
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.856 sec, Thread: 4, Class: org.apache.zookeeper.test.SessionInvalidationTest
[junit] Running org.apache.zookeeper.test.SessionTest in thread 4
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.531 sec, Thread: 2, Class: org.apache.zookeeper.test.ServerCnxnTest
[junit] Running org.apache.zookeeper.test.SessionTimeoutTest in thread 2
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.12 sec, Thread: 2, Class: org.apache.zookeeper.test.SessionTimeoutTest
[junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 
2
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.153 sec, Thread: 2, Class: org.apache.zookeeper.test.SessionTrackerCheckTest
[junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 2
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
9.99 sec, Thread: 2, Class: org.apache.zookeeper.test.SessionUpgradeTest
[junit] Running org.apache.zookeeper.test.StandaloneTest in thread 2
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
17.282 sec, Thread: 4, Class: org.apache.zookeeper.test.SessionTest
[junit] Running org.apache.zookeeper.test.StatTest in thread 4
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.699 sec, Thread: 4, Class: org.apache.zookeeper.test.StatTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.01 sec, Thread: 2, Class: org.apache.zookeeper.test.StandaloneTest
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 4
[junit] Running org.apache.zookeeper.test.StringUtilTest in thread 2
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.083 sec, Thread: 2, Class: org.apache.zookeeper.test.StringUtilTest
[junit] Running org.apache.zookeeper.test.SyncCallTest in thread 2
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.959 sec, Thread: 2, Class: org.apache.zookeeper.test.SyncCallTest
[junit] Running org.apache.zookeeper.test.TruncateTest in thread 2
[junit] Tests run: 26, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.047 sec, Thread: 4, Class: org.apache.zookeeper.test.StaticHostProviderTest
[junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in 
thread 4
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
14.504 sec, Thread: 2, Class: org.apache.zookeeper.test.TruncateTest
[junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 2
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.223 sec, Thread: 2, Class: org.apache.zookeeper.test.WatchedEventTest
[junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 2
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
18.069 sec, Thread: 4, Class: 
org.apache.zookeeper.test.WatchEventWhenAutoResetTest
[junit] Running org.apache.zookeeper.test.WatcherTest in thread 4
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
4.031 sec, Thread: 2, Class: org.apache.zookeeper.test.WatcherFuncTest
[junit] Running org.apache.zookeeper.test.X509AuthTest in thread 2
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.129 sec, Thread: 2, Class: org.apache.zookeeper.test.X509AuthTest
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in 
thread 2
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
6.699 sec, Thread: 2, Class: org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 2
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.387 sec, Thread: 2, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Running org.apache.zookeeper.util.PemReaderTest in thread 2
[junit] Tests run: 64, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
6.604 sec, Thread: 2, Class: org.apache.zookeeper.util.PemReaderTest
[junit] Running org.apache.jute.BinaryInputArchiveTest in thread 2
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.533 sec, Thread: 2, Class: org.apache.jute.BinaryInputArchiveTest
[junit] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
33.578 sec, Thread: 4, Class: org.apache.zookeeper.test.WatcherTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
111.013 sec, Thread: 3, Class: org.apache.zookeeper.test.RestoreCommittedLogTest
[junit] Tests run: 13, 

Re: Intellij Idea warning as error with -Xdoclint

[Andor Molnar]

Idea cannot build ZooKeeper out-of-the-box. Here’s the error message when 
trying to build zookeeper-server:

/Users/andormolnar/git/my-zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/command/StatCommand.java
Warning:(19, 1) java: documentation comment not expected here
Warning:(33, 8) java: no comment
Warning:(34, 33) java: no comment
Warning:(36, 17) java: no comment
Warning:(37, 12) java: no comment
Error:java: warnings found and -Werror specified

There’re lots of others, I just picked StatCommand.java as an example.

Idea is running the standard Javac compiler with the arguments imported from 
Maven settings:
javac -Werror -Xlint:deprecation -Xlint:unchecked -Xdoclint -Xpkginfo:always

thanks,
Andor



> On 2019. Jul 16., at 13:37, Enrico Olivelli  wrote:
> 
> Il giorno mar 16 lug 2019 alle ore 07:44 Andor Molnar  ha
> scritto:
> 
>> Yes, my main concern is: why does the maven succeed, if we're still
>> having javadoc issues?
>> 
> 
> if I run in zookeeper-server this command I can't find any WARNING or ERROR
> mvn javadoc:javadoc
> 
> only this ignorable one (I think)
> INFO] --- maven-javadoc-plugin:3.0.1:javadoc (default-cli) @ zookeeper ---
> [ERROR] Error fetching link:
> /home/diennea.lan/enrico.olivelli/dev/zookeeper/zookeeper-jute/target/site/apidocs/package-list.
> Ignored it.
> 
> and javadocs are generated correctly
> 
> Does Idea fail the build  ? do you have logs to share ? (I don't have Idea,
> I am using NetBeans that apparently runs maven from the command line when
> building)
> 
> Enrico
> 
> 
> 
>> 
>> Andor
>> 
>> 
>> -Original Message-
>> From: Enrico Olivelli 
>> Reply-To: dev@zookeeper.apache.org
>> To: dev@zookeeper.apache.org
>> Subject: Re: Intellij Idea warning as error with -Xdoclint
>> Date: Mon, 15 Jul 2019 21:58:09 +0200
>> 
>> Il lun 15 lug 2019, 13:53 Andor Molnar <
>> an...@apache.org
>>> ha scritto:
>> 
>>> Hi Enrico,
>>> 
>>> This is still an issue for me in IDEA:
>>> 
>>> Javadoc problems found in zookeeper-jute and zookeeper-server
>>> projects, so
>>> the build eventually fails. Strange thing is that running maven from
>>> command line doesn’t show any warning nor error.
>>> 
>>> From javac params -Werror and -Xdoclint I think IDEA’s behaviour is
>>> correct.
>>> 
>>> Most warning messages in IDEA are about missing javadoc comments, so
>>> changing it to "-Xdoclint:-missing” solves the problem.
>>> 
>> 
>> I can try to understand better.
>> If I understand correctly your point is that apparently Idea is working
>> as
>> expected but Maven not and this is not good because CI runs with Maven.
>> 
>> I will be back with news.
>> Hopefully we can fix javadocs and have a reliable way to detect issues
>> on
>> docs on CI/precommit/nightly
>> 
>> Enrico
>> 
>> 
>>> Regards,
>>> Andor
>>> 
>>> 
>>> 
>>> 
 On 2019. Jun 20., at 20:28, Andor Molnar <
 an...@apache.org
> wrote:
 
 Done. #983 merged, problem gone.
 Thanks maoling!
 
 Andor
 
 
 
> On 2019. Jun 20., at 15:43, maoling <
> maoling199210...@sina.com
>> wrote:
> 
> I also noticed this when running UT with IDEA.may we can merge
> this PR:
> https://github.com/apache/zookeeper/pull/988
> 
> Or this one:
> https://github.com/apache/zookeeper/pull/983
> to remove
>>> 
>>> that warning.
> 发送自 Windows 10 版邮件应用
> 
> 发件人: Andor Molnar
> 发送时间: 2019年6月20日 5:46
> 收件人: DevZooKeeper
> 主题: Intellij Idea warning as error with -Xdoclint
> 
> 
> Hi Enrico,
> 
> I have the following error message in Idea since -Xdoclint is
> enabled
>>> 
>>> in the main pom.xml file:
> 
>>> 
>>> /Users/andormolnar/git/my-zookeeper/zookeeper-
>>> jute/src/main/java/org/apache/jute/Utils.java
> Error:(194, 15) java: @param name not found
> Error:(231, 15) java: @param name not found
> 
> Strange that I don’t see the same warnings in console when
> running ‘mvn
>>> 
>>> install’.
> I confirm that removing “-Xdoclint” (or fixing javadoc issues)
> solves
>>> 
>>> the problem.
> Andor
> 
> 
> 
> 
>>> 
>>> 
>> 
>> 

Re: Intellij Idea warning as error with -Xdoclint

[Enrico Olivelli]

Il giorno mar 16 lug 2019 alle ore 07:44 Andor Molnar  ha
scritto:

> Yes, my main concern is: why does the maven succeed, if we're still
> having javadoc issues?
>

if I run in zookeeper-server this command I can't find any WARNING or ERROR
mvn javadoc:javadoc

only this ignorable one (I think)
INFO] --- maven-javadoc-plugin:3.0.1:javadoc (default-cli) @ zookeeper ---
[ERROR] Error fetching link:
/home/diennea.lan/enrico.olivelli/dev/zookeeper/zookeeper-jute/target/site/apidocs/package-list.
Ignored it.

and javadocs are generated correctly

Does Idea fail the build  ? do you have logs to share ? (I don't have Idea,
I am using NetBeans that apparently runs maven from the command line when
building)

Enrico



>
> Andor
>
>
> -Original Message-
> From: Enrico Olivelli 
> Reply-To: dev@zookeeper.apache.org
> To: dev@zookeeper.apache.org
> Subject: Re: Intellij Idea warning as error with -Xdoclint
> Date: Mon, 15 Jul 2019 21:58:09 +0200
>
> Il lun 15 lug 2019, 13:53 Andor Molnar <
> an...@apache.org
> > ha scritto:
>
> > Hi Enrico,
> >
> > This is still an issue for me in IDEA:
> >
> > Javadoc problems found in zookeeper-jute and zookeeper-server
> > projects, so
> > the build eventually fails. Strange thing is that running maven from
> > command line doesn’t show any warning nor error.
> >
> > From javac params -Werror and -Xdoclint I think IDEA’s behaviour is
> > correct.
> >
> > Most warning messages in IDEA are about missing javadoc comments, so
> > changing it to "-Xdoclint:-missing” solves the problem.
> >
>
> I can try to understand better.
> If I understand correctly your point is that apparently Idea is working
> as
> expected but Maven not and this is not good because CI runs with Maven.
>
> I will be back with news.
> Hopefully we can fix javadocs and have a reliable way to detect issues
> on
> docs on CI/precommit/nightly
>
> Enrico
>
>
> > Regards,
> > Andor
> >
> >
> >
> >
> > > On 2019. Jun 20., at 20:28, Andor Molnar <
> > > an...@apache.org
> > > > wrote:
> > >
> > > Done. #983 merged, problem gone.
> > > Thanks maoling!
> > >
> > > Andor
> > >
> > >
> > >
> > > > On 2019. Jun 20., at 15:43, maoling <
> > > > maoling199210...@sina.com
> > > > > wrote:
> > > >
> > > > I also noticed this when running UT with IDEA.may we can merge
> > > > this PR:
> > > > https://github.com/apache/zookeeper/pull/988
> > > >
> > > > Or this one:
> > > > https://github.com/apache/zookeeper/pull/983
> > > >  to remove
> >
> > that warning.
> > > > 发送自 Windows 10 版邮件应用
> > > >
> > > > 发件人: Andor Molnar
> > > > 发送时间: 2019年6月20日 5:46
> > > > 收件人: DevZooKeeper
> > > > 主题: Intellij Idea warning as error with -Xdoclint
> > > >
> > > >
> > > > Hi Enrico,
> > > >
> > > > I have the following error message in Idea since -Xdoclint is
> > > > enabled
> >
> > in the main pom.xml file:
> > > >
> >
> > /Users/andormolnar/git/my-zookeeper/zookeeper-
> > jute/src/main/java/org/apache/jute/Utils.java
> > > > Error:(194, 15) java: @param name not found
> > > > Error:(231, 15) java: @param name not found
> > > >
> > > > Strange that I don’t see the same warnings in console when
> > > > running ‘mvn
> >
> > install’.
> > > > I confirm that removing “-Xdoclint” (or fixing javadoc issues)
> > > > solves
> >
> > the problem.
> > > > Andor
> > > >
> > > >
> > > >
> > > >
> >
> >
>
>

Re: Re: Re: Re: Re: Clean up the all the checkstyle violations in the zookeeper-server module

[Zili Chen]

Hi Justin,

Thanks for the reply.

I will close ZOOKEEPER-3446 later in fact. Because
our consensus above is that we would add the checkstyle
configuration at first and enable it per module.

I'm glad to follow ZOOKEEPER-3431 to see if anything I
can help with.

Best,
tison.


Justin Ling Mao  于2019年7月16日周二 下午6:19写道：

> -1. @Zili Chen
> I had linked ZOOKEEPER-3434(closed),ZOOKEEPER-3446 to the *ZOOKEEPER-3431*
> which now is a Umbrella JIRA (Type:Task).
> I will also take your advice about the subtasks.
> -2 --->"*Please add jute and Prometheus module*"
> @Olivelli.That's OK.
>
>
> - Original Message -
> From: Zili Chen 
> To: DevZooKeeper 
> Cc: maoling199210...@sina.com
> Subject: Re: Re: Re: Re: Clean up the all the checkstyle violations in the
> zookeeper-server module
> Date: 2019-07-16 15:18
>
> The main concern here is that we have already too
> many issues on enable specific rules on zookeeper,
> including ZOOKEEPER-3434 and ZOOKEEPER-3446,
> and it would be quite noisy to enable per rule(as
> been described and reached a consensus).
>
> Best,
> tison.
>
>
> Zili Chen  于2019年7月16日周二 上午9:17写道：
>
> Hi Justin,
>
> Thanks for driving this thread. Please go ahead!
>
> One thing I'd like to pick up is that ZOOKEEPER-3431
> has a specific description and I'm afraid it could not
> be an umbrella issue.
>
> How about close all checkstyle related issues and start
> a new issues structure as
>
> Umbrella: Enable Google checkstyle configuration
>   Subtask-1: Add silent Google checkstyle configuration
>   Subtask-2: Enable Google checkstyle configuration on zookeeper-server
>   Subtask-3: Enable Google checkstyle configuration on zookeeper-jute
>   Subtask-4: Enable Google checkstyle configuration on zookeeper-prometheus
>   ...
>
> Best,
> tison.
>
>
> Enrico Olivelli  于2019年7月16日周二 上午12:06写道：
>
> Il lun 15 lug 2019, 09:14 Justin Ling Mao  ha
> scritto:
>
> > - any advance for the discussion???- any objections about these two
> > things: 1.only clean the main-module:zookeeper-server;
>
>
> Please add jute and Prometheus module
>
> 2.using the google's checkstyle_style?-
>
>
> Works for me
>
> > who will head it up?  how about me？
> >
>
> Sure! Go for it. Thanks
>
> Enrico
>
> >
> >
> > - Original Message -
> > From: "Justin Ling Mao" 
> > To: "dev" 
> > Subject: Re: Re: Re: Clean up the all the checkstyle violations in the
> > zookeeper-server module
> > Date: 2019-07-07 15:56
> >
> > 1.--->“we'd better first create an umbrella issue named "Enable
> checkstyle
> > rules" or sth”I had created ZOOKEEPER-3431 previously, and we can create
> a
> > series of sub-tasks under it.
> > 2.I think we still have two things which should be discussed:  2.1
> > Currently, we only need to enforce the checkstyle violations check in the
> > main-module:zookeeper-server, not included other modules?  IMO,
> because
> > the zookeeper-contrib, zookeeper-recipes are now not well-maintained.
> > and some violations in the zookeeper-jute are auto-generated. so focusing
> > on zookeeper-server is enough?
> >   2.2 What checkstyle template we will pick up? Now we have three
> > options:  A:[google_style](
> > https://checkstyle.sourceforge.io/google_style.html)
> > B:[bookkeeper_style] (
> >
> https://github.com/apache/bookkeeper/blob/master/buildtools/src/main/resources/bookkeeper/checkstyle.xml
> )
> > C:[hbase_style](
> >
> https://github.com/apache/hbase/blob/master/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml
> )
> > Which one will we choose?
> >
> >
> > - Original Message -
> > From: Enrico Olivelli 
> > To: dev@zookeeper.apache.org
> > Cc: maoling199210...@sina.com
> > Subject: Re: Re: Clean up the all the checkstyle violations in the
> > zookeeper-server module
> > Date: 2019-07-07 15:13
> >
> > Il dom 7 lug 2019, 01:29 Zili Chen  ha scritto:
> > > Justin & Enrico,
> > >
> > > Receiving no opposition on this proposal, we could regard it as
> > > a consensus. According to bookkeeper#230 we'd better first create
> > > an umbrella issue named "Enable checkstyle rules" or sth. Under
> > > there we can finally decide the checkstyle configuration and
> > > start sub-tasks enabling per package.
> > >
> > > For keeping current checkstyle, I'd like to pick up that it's
> > > possible that we remain the current simple config for all pkgs,
> > > adding a config said copied from bookkeeper named
> > > "strict-checkstyle.xml", enabling per pkg, which contains @author
> > > tags and rules in simple config. Once we enabling the strict one
> > > for all pkgs. We can merge two configs into one.
> > >
> > +1 please go ahead
> > Enrico
> > > Best,
> > > tison.
> > >
> > >
> > > Enrico Olivelli  于2019年7月6日周六 下午8:20写道：
> > >
> > > > Justin,
> > > > This is how we did it in Bookkeeper, we enabled checkstyle only for
> > group
> > > > of packages in the main module (the biggest one, bookkeeper-server)
> > > >
> > > > https://github.com/apache/bookkeeper/issues/230
> > > >
> > > > I suggest using 

Re: Re: Re: Re: Re: Clean up the all the checkstyle violations in the zookeeper-server module

[Justin Ling Mao]

-1. @Zili Chen   I had linked ZOOKEEPER-3434(closed),ZOOKEEPER-3446 to the 
ZOOKEEPER-3431 which now is a Umbrella JIRA (Type:Task).   I will also take 
your advice about the subtasks.-2 --->"Please add jute and Prometheus module"   
@Olivelli.That's OK.

- Original Message -
From: Zili Chen 
To: DevZooKeeper 
Cc: maoling199210...@sina.com
Subject: Re: Re: Re: Re: Clean up the all the checkstyle violations in the 
zookeeper-server module
Date: 2019-07-16 15:18

The main concern here is that we have already toomany issues on enable specific 
rules on zookeeper,including ZOOKEEPER-3434 and ZOOKEEPER-3446,and it would be 
quite noisy to enable per rule(asbeen described and reached a consensus).
Best,tison.

Zili Chen  于2019年7月16日周二 上午9:17写道：
Hi Justin,
Thanks for driving this thread. Please go ahead!
One thing I'd like to pick up is that ZOOKEEPER-3431has a specific description 
and I'm afraid it could notbe an umbrella issue.
How about close all checkstyle related issues and starta new issues structure as
Umbrella: Enable Google checkstyle configuration  Subtask-1: Add silent Google 
checkstyle configuration  Subtask-2: Enable Google checkstyle configuration on 
zookeeper-server  Subtask-3: Enable Google checkstyle configuration on 
zookeeper-jute
  Subtask-4: Enable Google checkstyle configuration on zookeeper-prometheus
  ...
Best,tison.

Enrico Olivelli  于2019年7月16日周二 上午12:06写道：
Il lun 15 lug 2019, 09:14 Justin Ling Mao  ha

scritto:



> - any advance for the discussion???- any objections about these two

> things: 1.only clean the main-module:zookeeper-server;





Please add jute and Prometheus module



2.using the google's checkstyle_style?-





Works for me



> who will head it up?  how about me？

>



Sure! Go for it. Thanks



Enrico



>

>

> - Original Message -

> From: "Justin Ling Mao" 

> To: "dev" 

> Subject: Re: Re: Re: Clean up the all the checkstyle violations in the

> zookeeper-server module

> Date: 2019-07-07 15:56

>

> 1.--->“we'd better first create an umbrella issue named "Enable checkstyle

> rules" or sth”I had created ZOOKEEPER-3431 previously, and we can create a

> series of sub-tasks under it.

> 2.I think we still have two things which should be discussed:  2.1

> Currently, we only need to enforce the checkstyle violations check in the

> main-module:zookeeper-server, not included other modules?  IMO, because

> the zookeeper-contrib, zookeeper-recipes are now not well-maintained.

> and some violations in the zookeeper-jute are auto-generated. so focusing

> on zookeeper-server is enough?

>   2.2 What checkstyle template we will pick up? Now we have three

> options:  A:[google_style](

> https://checkstyle.sourceforge.io/google_style.html)

> B:[bookkeeper_style] (

> https://github.com/apache/bookkeeper/blob/master/buildtools/src/main/resources/bookkeeper/checkstyle.xml)

> C:[hbase_style](

> https://github.com/apache/hbase/blob/master/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml)

> Which one will we choose?

>

>

> - Original Message -

> From: Enrico Olivelli 

> To: dev@zookeeper.apache.org

> Cc: maoling199210...@sina.com

> Subject: Re: Re: Clean up the all the checkstyle violations in the

> zookeeper-server module

> Date: 2019-07-07 15:13

>

> Il dom 7 lug 2019, 01:29 Zili Chen  ha scritto:

> > Justin & Enrico,

> >

> > Receiving no opposition on this proposal, we could regard it as

> > a consensus. According to bookkeeper#230 we'd better first create

> > an umbrella issue named "Enable checkstyle rules" or sth. Under

> > there we can finally decide the checkstyle configuration and

> > start sub-tasks enabling per package.

> >

> > For keeping current checkstyle, I'd like to pick up that it's

> > possible that we remain the current simple config for all pkgs,

> > adding a config said copied from bookkeeper named

> > "strict-checkstyle.xml", enabling per pkg, which contains @author

> > tags and rules in simple config. Once we enabling the strict one

> > for all pkgs. We can merge two configs into one.

> >

> +1 please go ahead

> Enrico

> > Best,

> > tison.

> >

> >

> > Enrico Olivelli  于2019年7月6日周六 下午8:20写道：

> >

> > > Justin,

> > > This is how we did it in Bookkeeper, we enabled checkstyle only for

> group

> > > of packages in the main module (the biggest one, bookkeeper-server)

> > >

> > > https://github.com/apache/bookkeeper/issues/230

> > >

> > > I suggest using that checkstyle config, I feel we won't have so many

> > > violations.

> > >

> > > We can keep current checkstyle invokation that checks for @author tags

> > as a

> > > separate 'execution' of the plugin with a specific checkstyle file (as

> > you

> > > already said)

> > >

> > > I am happy to help, thank you for driving this effort

> > >

> > > Enrico

> > >

> > >

> > > Il sab 6 lug 2019, 11:33 Justin Ling Mao 

> ha

> > > scritto:

> > >

> > > > - 1.It seems that we had reached a consensus to work 

Re: Re: Re: Time to think about a 3.6.0 release?

[Justin Ling Mao]

- 1. @Andor Thanks for reformatting my email. I must be careful next time.








- 2. I absolutely agree with what Olivelli said.  --> “I guess that if we 
start now we can have a 3.6 in September”.   maybe not need so fast. But 
having a planning, especially about what features will be included, what 
approximate time(A time range) will cut 3.6.0 is a good idea  drawing from the 
previous lessons- 3. I have a question: "After 3.6.0 has landed, the 3.5.* will 
not be applied any new feature and only fix the bugs and prominent 
improvements" Is it right?



- Original Message -
From: Enrico Olivelli 
To: DevZooKeeper , maoling199210...@sina.com
Subject: Re: Re: Time to think about a 3.6.0 release?
Date: 2019-07-15 21:55

Justin,
I think that current master has already plenty of new features and it is
worth to start thinking to a release.
The more with add code the more we add risk.
The point of this thread is more about 'stop adding new stuff, complete
ongoing work and start a rampdown phase', it is not "cut a release right
now"
As far as I know current master is very different from branch 3.5,
expecially on server side code, lots of feature came in and stalled on
master branch for months or even years,
so feedback from 3.5 is useful but not so blocker
We should make current master stable
IMHO the recipe for a great release is:
1) enough stuff committed to the release branch sothat it is worth to cut a
release
2) code in good shape: tests are passing, automatic checks are passing
(spotbugs, rat...)
3) licensing stuff is okay
4)  upgrade instructions and changelog about breaking changes/new
beheaviours are complete
5) CI is doing well
6) consensus of the community about the release
Hopefully now that we got out of the 3.5-BETA  problem and we are stable we
can think about a time based release schedule, if a feature can't be
delivered on a release it won't pass so much time for a new release, say
3-4 months
I don't know how many companies are using "current master" (or something
like that) in production, I feel that running 3.5 does not tell very much
about the stability of current 3.6
So my plan would be:
- merge pending pull requests that are ready
- stabilize the codebase  (no more BLOCKER issues for the release)
- start release process
I guess that if we start now we can have a 3.6 in September
Enrico
Il lun 15 lug 2019, 11:55 Justin Ling Mao  ha
scritto:
> - 1.Since the 3.5.5 has just released in May. we still need some time to
> collect the users' feedback.we cannot make sure the release time of 3.6.0?
> Giving the experience from the previous release history:)- 2.please Let me
> share some my thoughts, and the work in progress will be arriving into
> 3.6.0. Plz correct me if I got something wrong.
>  
> --P0
>- Support the backend store engine:LMDB. this work needs a very detailed
> proposal which I will send to the community for being discussed fully.
>  - Add a complete backup mechanism for zookeeper internal(PR-917) which I
> will sharp it this week. - A very powerful benchmark tool(PR-1011)
> which will be available within these two week. - improve the
> performance of read/write to have the distinct advantages compared to etcd
> v3.4 which will be released soon. - To strengthen the quota
> feature(PR-934,PR-936,PR-938) and implement the throughout quota. - To
> strengthen the implements of TTL node(PR-1010) - Add some new very
> useful CLIs: quorumInfo, watch .etc - Observe and strengthen the new
> metric system continuously.
>  
> --P1
>- strength the docs, especially about the c client, local session,
> security(TLS),ZAB protocol .etc - introduce some chaos, fuzzy tests and
> tools to hit and check the zk. - Clean up the all the checkstyle
> violations in the zookeeper-server module(ZOOKEEPER-3431)
>  -
> P2-- -
> Debug mode feature. Look at an example of redis - the tracing
> feature(PR-994). if having another time, integrating with opentracing
> sounds a very good idea. - replace jute with thrift or PB may be put
> into the 4.0.0 when wanting to break the backward compatibility? And at the
> 4.0.0, implementing the restful api is also a  very good idea.
>
>
>
> - Original Message -
> From: Fangmin Lv 
> To: dev@zookeeper.apache.org
> Subject: Re: Time to think about a 3.6.0 release?
> Date: 2019-06-26 07:33
>
> It's great to have a 3.6.0 release, currently all the FB contributed
> features has been running inside FB for more than a month, so it
> should be stable enough for community to use.
> Also I agreed with Patrick's point to review all flags and consider to turn
> on by default.
> For the 

Re: Time to think about a 3.6.0 release?

[Andor Molnar]

> So my plan would be:
> - merge pending pull requests that are ready
> - stabilize the codebase  (no more BLOCKER issues for the release)
> - start release process

Sounds like a good plan. +1

Quick Jira stats: (3.6.0 only tickets)

- 77 Improvement
- 14 New Feature (Followers host observers, new metrics system, Prometheus.io 
integration, log-size based snapshots, new docs,
- 23 Bugfix
- 6 Task

I wouldn’t say we should not commit more stuff, but sounds like a good time to 
start stabilization.

Andor




> On 2019. Jul 15., at 14:08, Enrico Olivelli  wrote:
> 
> Justin,
> I think that current master has already plenty of new features and it is
> worth to start thinking to a release.
> The more with add code the more we add risk.
> 
> The point of this thread is more about 'stop adding new stuff, complete
> ongoing work and start a rampdown phase', it is not "cut a release right
> now"
> 
> As far as I know current master is very different from branch 3.5,
> expecially on server side code, lots of feature came in and stalled on
> master branch for months or even years,
> so feedback from 3.5 is useful but not so blocker
> 
> We should make current master stable
> 
> IMHO the recipe for a great release is:
> 1) enough stuff committed to the release branch sothat it is worth to cut a
> release
> 2) code in good shape: tests are passing, automatic checks are passing
> (spotbugs, rat...)
> 3) licensing stuff is okay
> 4)  upgrade instructions and changelog about breaking changes/new
> beheaviours are complete
> 5) CI is doing well
> 6) consensus of the community about the release
> 
> 
> Hopefully now that we got out of the 3.5-BETA  problem and we are stable we
> can think about a time based release schedule, if a feature can't be
> delivered on a release it won't pass so much time for a new release, say
> 3-4 months
> 
> I don't know how many companies are using "current master" (or something
> like that) in production, I feel that running 3.5 does not tell very much
> about the stability of current 3.6
> 
> So my plan would be:
> - merge pending pull requests that are ready
> - stabilize the codebase  (no more BLOCKER issues for the release)
> - start release process
> 
> I guess that if we start now we can have a 3.6 in September
> 
> Enrico
> 
> 
> 
> 
> Il lun 15 lug 2019, 11:55 Justin Ling Mao  ha
> scritto:
> 
>> - 1.Since the 3.5.5 has just released in May. we still need some time to
>> collect the users' feedback.we cannot make sure the release time of 3.6.0?
>> Giving the experience from the previous release history:)- 2.please Let me
>> share some my thoughts, and the work in progress will be arriving into
>> 3.6.0. Plz correct me if I got something wrong.
>> --P0
>>   - Support the backend store engine:LMDB. this work needs a very detailed
>> proposal which I will send to the community for being discussed fully.
>> - Add a complete backup mechanism for zookeeper internal(PR-917) which I
>> will sharp it this week. - A very powerful benchmark tool(PR-1011)
>> which will be available within these two week. - improve the
>> performance of read/write to have the distinct advantages compared to etcd
>> v3.4 which will be released soon. - To strengthen the quota
>> feature(PR-934,PR-936,PR-938) and implement the throughout quota. - To
>> strengthen the implements of TTL node(PR-1010) - Add some new very
>> useful CLIs: quorumInfo, watch .etc - Observe and strengthen the new
>> metric system continuously.
>> --P1
>>   - strength the docs, especially about the c client, local session,
>> security(TLS),ZAB protocol .etc - introduce some chaos, fuzzy tests and
>> tools to hit and check the zk. - Clean up the all the checkstyle
>> violations in the zookeeper-server module(ZOOKEEPER-3431)
>> -
>> P2-- -
>> Debug mode feature. Look at an example of redis - the tracing
>> feature(PR-994). if having another time, integrating with opentracing
>> sounds a very good idea. - replace jute with thrift or PB may be put
>> into the 4.0.0 when wanting to break the backward compatibility? And at the
>> 4.0.0, implementing the restful api is also a  very good idea.
>> 
>> 
>> 
>> - Original Message -
>> From: Fangmin Lv 
>> To: dev@zookeeper.apache.org
>> Subject: Re: Time to think about a 3.6.0 release?
>> Date: 2019-06-26 07:33
>> 
>> It's great to have a 3.6.0 release, currently all the FB contributed
>> features has been running inside FB for more than a month, so it
>> should be stable enough for community to use.
>> Also I agreed with Patrick's point to review all flags and consider to turn
>> on by default.
>> For the pending PRs, the following might be 

Jenkins build is back to stable : zookeeper-master-maven-jdk11 #45

[Apache Jenkins Server]

See 

Re: Re: Re: Re: Clean up the all the checkstyle violations in the zookeeper-server module

[Zili Chen]

The main concern here is that we have already too
many issues on enable specific rules on zookeeper,
including ZOOKEEPER-3434 and ZOOKEEPER-3446,
and it would be quite noisy to enable per rule(as
been described and reached a consensus).

Best,
tison.


Zili Chen  于2019年7月16日周二 上午9:17写道：

> Hi Justin,
>
> Thanks for driving this thread. Please go ahead!
>
> One thing I'd like to pick up is that ZOOKEEPER-3431
> has a specific description and I'm afraid it could not
> be an umbrella issue.
>
> How about close all checkstyle related issues and start
> a new issues structure as
>
> Umbrella: Enable Google checkstyle configuration
>   Subtask-1: Add silent Google checkstyle configuration
>   Subtask-2: Enable Google checkstyle configuration on zookeeper-server
>   Subtask-3: Enable Google checkstyle configuration on zookeeper-jute
>   Subtask-4: Enable Google checkstyle configuration on zookeeper-prometheus
>   ...
>
> Best,
> tison.
>
>
> Enrico Olivelli  于2019年7月16日周二 上午12:06写道：
>
>> Il lun 15 lug 2019, 09:14 Justin Ling Mao  ha
>> scritto:
>>
>> > - any advance for the discussion???- any objections about these two
>> > things: 1.only clean the main-module:zookeeper-server;
>>
>>
>> Please add jute and Prometheus module
>>
>> 2.using the google's checkstyle_style?-
>>
>>
>> Works for me
>>
>> > who will head it up?  how about me？
>> >
>>
>> Sure! Go for it. Thanks
>>
>> Enrico
>>
>> >
>> >
>> > - Original Message -
>> > From: "Justin Ling Mao" 
>> > To: "dev" 
>> > Subject: Re: Re: Re: Clean up the all the checkstyle violations in the
>> > zookeeper-server module
>> > Date: 2019-07-07 15:56
>> >
>> > 1.--->“we'd better first create an umbrella issue named "Enable
>> checkstyle
>> > rules" or sth”I had created ZOOKEEPER-3431 previously, and we can
>> create a
>> > series of sub-tasks under it.
>> > 2.I think we still have two things which should be discussed:  2.1
>> > Currently, we only need to enforce the checkstyle violations check in
>> the
>> > main-module:zookeeper-server, not included other modules?  IMO,
>> because
>> > the zookeeper-contrib, zookeeper-recipes are now not well-maintained.
>> > and some violations in the zookeeper-jute are auto-generated. so
>> focusing
>> > on zookeeper-server is enough?
>> >   2.2 What checkstyle template we will pick up? Now we have three
>> > options:  A:[google_style](
>> > https://checkstyle.sourceforge.io/google_style.html)
>> > B:[bookkeeper_style] (
>> >
>> https://github.com/apache/bookkeeper/blob/master/buildtools/src/main/resources/bookkeeper/checkstyle.xml
>> )
>> > C:[hbase_style](
>> >
>> https://github.com/apache/hbase/blob/master/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml
>> )
>> > Which one will we choose?
>> >
>> >
>> > - Original Message -
>> > From: Enrico Olivelli 
>> > To: dev@zookeeper.apache.org
>> > Cc: maoling199210...@sina.com
>> > Subject: Re: Re: Clean up the all the checkstyle violations in the
>> > zookeeper-server module
>> > Date: 2019-07-07 15:13
>> >
>> > Il dom 7 lug 2019, 01:29 Zili Chen  ha scritto:
>> > > Justin & Enrico,
>> > >
>> > > Receiving no opposition on this proposal, we could regard it as
>> > > a consensus. According to bookkeeper#230 we'd better first create
>> > > an umbrella issue named "Enable checkstyle rules" or sth. Under
>> > > there we can finally decide the checkstyle configuration and
>> > > start sub-tasks enabling per package.
>> > >
>> > > For keeping current checkstyle, I'd like to pick up that it's
>> > > possible that we remain the current simple config for all pkgs,
>> > > adding a config said copied from bookkeeper named
>> > > "strict-checkstyle.xml", enabling per pkg, which contains @author
>> > > tags and rules in simple config. Once we enabling the strict one
>> > > for all pkgs. We can merge two configs into one.
>> > >
>> > +1 please go ahead
>> > Enrico
>> > > Best,
>> > > tison.
>> > >
>> > >
>> > > Enrico Olivelli  于2019年7月6日周六 下午8:20写道：
>> > >
>> > > > Justin,
>> > > > This is how we did it in Bookkeeper, we enabled checkstyle only for
>> > group
>> > > > of packages in the main module (the biggest one, bookkeeper-server)
>> > > >
>> > > > https://github.com/apache/bookkeeper/issues/230
>> > > >
>> > > > I suggest using that checkstyle config, I feel we won't have so many
>> > > > violations.
>> > > >
>> > > > We can keep current checkstyle invokation that checks for @author
>> tags
>> > > as a
>> > > > separate 'execution' of the plugin with a specific checkstyle file
>> (as
>> > > you
>> > > > already said)
>> > > >
>> > > > I am happy to help, thank you for driving this effort
>> > > >
>> > > > Enrico
>> > > >
>> > > >
>> > > > Il sab 6 lug 2019, 11:33 Justin Ling Mao > >
>> > ha
>> > > > scritto:
>> > > >
>> > > > > - 1.It seems that we had reached a consensus to work on this.- 2.I
>> > also
>> > > > > agree on the way: fix one package at a time, then another.- 3.Now
>> Let
>> > > us
>> > > > > discuss some details:- 3.1 how to make the 

Re: Time to think about a 3.6.0 release?

[Norbert Kalmar]

A related question: Are we going to deprecate/EOL the 3.4 branch after
3.6.0 stable is released?

On Mon, Jul 15, 2019 at 2:23 PM Andor Molnar  wrote:

> Hi maoling,
>
> I reformatted your original message, because it was pretty hard to read
> (all in a single line) after Apache converted into plain text. Would you
> please try to send plain text messages by default to avoid the conversion?
> It might help.
>
> Answers inline.
>
>
> > On 2019. Jul 15., at 11:54, Justin Ling Mao 
> wrote:
> >
> > - 1.Since the 3.5.5 has just released in May. we still need some time to
> collect the users' feedback.we cannot make sure the release time of 3.6.0?
> Giving the experience from the previous release history:)
>
>
> I don’t feel it too fast. I’m happy to see people willing to work on
> releases and I believe it’s a good thing to speed up ZooKeeper releases. 4
> years release cycle is not something that we should follow in the future.
>
> The discussion about the next major release is just started and doesn’t
> mean we have to cut tomorrow. Talk about it. Your list of upcoming patches
> are more than welcome, we need to discuss where to fit them.
>
> Friends@Facebook are also working hard to get patches into 3.6.0. We need
> to synchronize with all contributors.
>
>
> > - 2.please Let me share some my thoughts, and the work in progress will
> be arriving into 3.6.0. Plz correct me if I got something wrong.
>
> Sure. Awesome list.
>
>
> >
> --P0
>
> > - Support the backend store engine:LMDB. this work needs a very detailed
> proposal which I will send to the community for being discussed fully.
>
> I think this should go into 4.0.0 instead if it’s only is design phase
> currently. This is probably true for the rest of patches too: everything
> which already has a PR or close to it can fit into 3.6.0, others should go
> to 4.0.0.
>
>
>
>
>
> > - Add a complete backup mechanism for zookeeper internal(PR-917) which I
> will sharp it this week.
> > - A very powerful benchmark tool(PR-1011) which will be available within
> these two week.
> > - improve the performance of read/write to have the distinct advantages
> compared to etcd v3.4 which will be released soon.
> > - To strengthen the quota feature(PR-934,PR-936,PR-938) and implement
> the throughout quota.
> > - To strengthen the implements of TTL node(PR-1010)
> > - Add some new very useful CLIs: quorumInfo, watch .etc
> > - Observe and strengthen the new metric system continuously.
> >
> --P1
>
> > - strength the docs, especially about the c client, local session,
> security(TLS),ZAB protocol .etc
> > - introduce some chaos, fuzzy tests and tools to hit and check the zk.
>
> > - Clean up the all the checkstyle violations in the zookeeper-server
> module(ZOOKEEPER-3431)
> > -
> P2—
> > - Debug mode feature. Look at an example of redis
> > - the tracing feature(PR-994). if having another time, integrating with
> opentracing sounds a very good idea.
> > - replace jute with thrift or PB may be put into the 4.0.0 when wanting
> to break the backward compatibility? And at the 4.0.0, implementing the
> restful api is also a  very good idea.
> >
>
> Thanks,
> Andor
>
>
> >
> >
> > - Original Message -
> > From: Fangmin Lv 
> > To: dev@zookeeper.apache.org
> > Subject: Re: Time to think about a 3.6.0 release?
> > Date: 2019-06-26 07:33
> >
> > It's great to have a 3.6.0 release, currently all the FB contributed
> > features has been running inside FB for more than a month, so it
> > should be stable enough for community to use.
> > Also I agreed with Patrick's point to review all flags and consider to
> turn
> > on by default.
> > For the pending PRs, the following might be higher priority and would be
> > nice to include in the 3.6.0 release:
> > * ZOOKEEPER-3356: Implement advanced Netty flow control based on feedback
> > from ZK to avoid OOM issue
> > * ZOOKEEPER-3145: Avoid watch missing issue due to stale pzxid when
> > replaying CloseSession txn with fuzzy snapshot
> > * ZOOKEEPER-3240: Close socket on Learner shutdown to avoid dangling
> socket
> > Thanks,
> > Fangmin
> > On Sat, Jun 15, 2019 at 9:21 AM Patrick Hunt  wrote:
> >> Good idea. Agree on including anything we've postponed to a new cycle -
> the
> >> patch from mapr is an obvious one to consider.
> >>
> >> We should also look at things we've disabled by default and consider
> >> whether we can turn them on by default. If not why not, and what can we
> do
> >> to fix this in a subsequent release.
> >>
> >> Have we deprecated anything that we should now remove?
> >>
> >> Also a good time to review the state of Java versions and make changes
> wrt
> >> supported versions and so forth.
> >>
> >> There was a proposal to remove contribs, or at least consider the ones
> that
> >> are still