[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[Michael Han (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15769038#comment-15769038
 ] 

Michael Han commented on ZOOKEEPER-2479:


[~rakeshr] A small change is required for this patch as it breaks apache builds 
for branch-3.4 which uses JDK 1.6 (it's actually using JDK 1.5 but that will be 
fixed by ZOOKEEPER-2646), where diamond operator was not available. 
https://github.com/apache/zookeeper/commit/52d365041759229ddc46798e34ee845fc1e26732#diff-3d1cc56cfc8e62939e368f3522cfc8a1R146





> Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean
> 
>
> Key: ZOOKEEPER-2479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2479
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch
>
>
> The idea of this jira is to expose {{time taken}} for the leader election via 
> jmx Leader, Follower beans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[Rakesh R (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15766572#comment-15766572
 ] 

Rakesh R commented on ZOOKEEPER-2479:
-

Thanks [~fpj] and [~hanm] for the discussion. I've closed the PR now, probably 
will observe this behavior while processing next PR.

> Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean
> 
>
> Key: ZOOKEEPER-2479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2479
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch
>
>
> The idea of this jira is to expose {{time taken}} for the leader election via 
> jmx Leader, Follower beans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15766565#comment-15766565
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2479:
---

Github user rakeshadr commented on the issue:

https://github.com/apache/zookeeper/pull/130
  
Closing PR manually as this is committed to the branch-3.4


> Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean
> 
>
> Key: ZOOKEEPER-2479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2479
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch
>
>
> The idea of this jira is to expose {{time taken}} for the leader election via 
> jmx Leader, Follower beans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15766566#comment-15766566
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2479:
---

Github user rakeshadr closed the pull request at:

https://github.com/apache/zookeeper/pull/130


> Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean
> 
>
> Key: ZOOKEEPER-2479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2479
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch
>
>
> The idea of this jira is to expose {{time taken}} for the leader election via 
> jmx Leader, Follower beans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[Flavio Junqueira (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15766542#comment-15766542
 ] 

Flavio Junqueira commented on ZOOKEEPER-2479:
-

I don't know why it didn't close the pull request, but I can see the commit in 
the branch:

{noformat}
commit 52d365041759229ddc46798e34ee845fc1e26732
Author: Rakesh Radhakrishnan 
Date:   Tue Dec 20 13:52:50 2016 +

ZOOKEEPER-2479: Add 'electionTimeTaken' value in LeaderMXBean and 
FollowerMXBean

This PR is against branch-3.4, please review. Thanks!

Author: Rakesh Radhakrishnan 

Reviewers: fpj 

Closes #130 from rakeshadr/ZK-2479-br-3-4
{noformat}

I didn't get any error message or anything. I'd say it is safe to close the 
pull request.

> Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean
> 
>
> Key: ZOOKEEPER-2479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2479
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch
>
>
> The idea of this jira is to expose {{time taken}} for the leader election via 
> jmx Leader, Follower beans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[Michael Han (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15766354#comment-15766354
 ] 

Michael Han commented on ZOOKEEPER-2479:


Good point - wondering how did this patch targeting 3.4 branch landed. If it's 
done through merge script then in theory the PR should be closed automatically 
after committing; if the commit was done manually then the PR needs to be 
closed explicitly. 

> Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean
> 
>
> Key: ZOOKEEPER-2479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2479
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch
>
>
> The idea of this jira is to expose {{time taken}} for the leader election via 
> jmx Leader, Follower beans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[Rakesh R (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15766271#comment-15766271
 ] 

Rakesh R commented on ZOOKEEPER-2479:
-

IIUC, its not done cherry pick to branch-3.4, because I've created PR 130 due 
to the code mismatches between master and branch-3.4. Yes, I can close this PR 
but keeping it open to know the reason why this PR is not auto closed after 
merging.

> Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean
> 
>
> Key: ZOOKEEPER-2479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2479
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch
>
>
> The idea of this jira is to expose {{time taken}} for the leader election via 
> jmx Leader, Follower beans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[Michael Han (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15766232#comment-15766232
 ] 

Michael Han commented on ZOOKEEPER-2479:


[~rakeshr] I think you could just close PR 130 because the commit of this patch 
landed. I assume what Flavio did was to cherry pick the commit during merging 
PR 98 using the merge script (see 
https://cwiki.apache.org/confluence/display/ZOOKEEPER/Merging+Github+Pull+Requests,
 which supports back porting commits to other branch while merging a PR), and 
the merge script in this case has no knowledge of the PR associated with 
branch-34 (which is PR 130). Possibly we could improve the scripts by having 
the scripts prompt to ask what PR to close during back porting so we don't have 
to close the PR manually.

> Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean
> 
>
> Key: ZOOKEEPER-2479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2479
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch
>
>
> The idea of this jira is to expose {{time taken}} for the leader election via 
> jmx Leader, Follower beans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[Rakesh R (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15764710#comment-15764710
 ] 

Rakesh R commented on ZOOKEEPER-2479:
-

Thank you [~fpj] for final reviews and commits.

[Pull Request_130|https://github.com/apache/zookeeper/pull/130] for the 
{{branch-3.4}} is still open. Do we have any procedure to close this?

> Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean
> 
>
> Key: ZOOKEEPER-2479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2479
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch
>
>
> The idea of this jira is to expose {{time taken}} for the leader election via 
> jmx Leader, Follower beans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15764338#comment-15764338
 ] 

Hudson commented on ZOOKEEPER-2479:
---

FAILURE: Integrated in Jenkins build ZooKeeper-trunk #3202 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/3202/])
ZOOKEEPER-2479: Add 'electionTimeTaken' value in LeaderMXBean and (fpj: rev 
8616a9ec8ce4bc8ac2987b7417a6f0c4b7333658)
* (edit) src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
* (edit) src/java/main/org/apache/zookeeper/server/quorum/LeaderBean.java
* (edit) src/java/test/org/apache/zookeeper/test/QuorumMajorityTest.java
* (edit) src/java/main/org/apache/zookeeper/server/quorum/FollowerBean.java
* (edit) src/java/main/org/apache/zookeeper/server/quorum/FollowerMXBean.java
* (edit) src/java/main/org/apache/zookeeper/server/quorum/Follower.java
* (edit) src/java/main/org/apache/zookeeper/server/quorum/Leader.java
* (edit) src/java/main/org/apache/zookeeper/server/quorum/LeaderMXBean.java


> Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean
> 
>
> Key: ZOOKEEPER-2479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2479
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch
>
>
> The idea of this jira is to expose {{time taken}} for the leader election via 
> jmx Leader, Follower beans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[Flavio Junqueira (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15764259#comment-15764259
 ] 

Flavio Junqueira commented on ZOOKEEPER-2479:
-

+1, thanks for the patch, [~rakeshr].

> Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean
> 
>
> Key: ZOOKEEPER-2479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2479
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch
>
>
> The idea of this jira is to expose {{time taken}} for the leader election via 
> jmx Leader, Follower beans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15764247#comment-15764247
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2479:
---

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/98


> Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean
> 
>
> Key: ZOOKEEPER-2479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2479
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch
>
>
> The idea of this jira is to expose {{time taken}} for the leader election via 
> jmx Leader, Follower beans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[Rakesh R (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15756521#comment-15756521
 ] 

Rakesh R commented on ZOOKEEPER-2479:
-

OK, I've created [PR-130|https://github.com/apache/zookeeper/pull/130].

> Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean
> 
>
> Key: ZOOKEEPER-2479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2479
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch
>
>
> The idea of this jira is to expose {{time taken}} for the leader election via 
> jmx Leader, Follower beans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15756517#comment-15756517
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2479:
---

GitHub user rakeshadr opened a pull request:

https://github.com/apache/zookeeper/pull/130

ZOOKEEPER-2479: Add 'electionTimeTaken' value in LeaderMXBean and Fol…

This PR is against branch-3.4, please review. Thanks!

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rakeshadr/zookeeper-1 ZK-2479-br-3-4

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/130.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #130


commit a5e70821094ae8a42a44ddd0b6b0feba81cfa973
Author: Rakesh Radhakrishnan 
Date:   2016-12-17T07:01:05Z

ZOOKEEPER-2479: Add 'electionTimeTaken' value in LeaderMXBean and 
FollowerMXBean




> Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean
> 
>
> Key: ZOOKEEPER-2479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2479
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch
>
>
> The idea of this jira is to expose {{time taken}} for the leader election via 
> jmx Leader, Follower beans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[Flavio Junqueira (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15754176#comment-15754176
 ] 

Flavio Junqueira commented on ZOOKEEPER-2479:
-

if there is no issue with having two pull requests for the same jira, then just 
do a pul request against branch-3.4.

> Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean
> 
>
> Key: ZOOKEEPER-2479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2479
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch
>
>
> The idea of this jira is to expose {{time taken}} for the leader election via 
> jmx Leader, Follower beans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[Rakesh R (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15753450#comment-15753450
 ] 

Rakesh R commented on ZOOKEEPER-2479:
-

Thanks [~fpj], I need to do the changes separately for branch-3.4 as trunk and 
branch-3.4 code are different. Do you prefer a new patch diff or PR against 
branch-3.4?

> Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean
> 
>
> Key: ZOOKEEPER-2479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2479
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch
>
>
> The idea of this jira is to expose {{time taken}} for the leader election via 
> jmx Leader, Follower beans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[Rakesh R (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15724267#comment-15724267
 ] 

Rakesh R commented on ZOOKEEPER-2479:
-

I think, this task will be useful to ZK-1045 feature.
[~fpj], [~rgs], please let me know anything else to be done for this. Thanks!

> Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean
> 
>
> Key: ZOOKEEPER-2479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2479
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch
>
>
> The idea of this jira is to expose {{time taken}} for the leader election via 
> jmx Leader, Follower beans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[Rakesh R (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15692915#comment-15692915
 ] 

Rakesh R commented on ZOOKEEPER-2479:
-

[~rgs], [~fpj], I've tried an attempt to fix your review comments. Do you have 
some cycles to visit the latest changes in the PR. Thanks!

It looks like, I need to prepare separate patch for branch-3.4 as trunk and 
branch-3.4 codes are different. Do you prefer a patch diff or PR against 
{{branch-3.4}}?

> Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean
> 
>
> Key: ZOOKEEPER-2479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2479
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch
>
>
> The idea of this jira is to expose {{time taken}} for the leader election via 
> jmx Leader, Follower beans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675943#comment-15675943
 ] 

Hadoop QA commented on ZOOKEEPER-2479:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 20 new Findbugs (version 
3.0.1) warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/76//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/76//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/76//console

This message is automatically generated.

> Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean
> 
>
> Key: ZOOKEEPER-2479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2479
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch
>
>
> The idea of this jira is to expose {{time taken}} for the leader election via 
> jmx Leader, Follower beans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675912#comment-15675912
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2479:
---

Github user rakeshadr commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/98#discussion_r88604035
  
--- Diff: src/java/test/org/apache/zookeeper/test/QuorumMajorityTest.java 
---
@@ -36,7 +38,30 @@
 /***/
 @Test
 public void testMajQuorums() throws Throwable {
-   
+LOG.info("Verify QuorumPeer#electionTimeTaken jmx bean attribute");
+
+ArrayList peers = getPeerList();
+for (int i = 1; i <= peers.size(); i++) {
+QuorumPeer qp = peers.get(i - 1);
+Long electionTimeTaken = -1L;
+String bean = "";
+if (qp.getPeerState() == ServerState.FOLLOWING) {
+bean = CommonNames.DOMAIN + ":name0=ReplicatedServer_id" + 
i
++ ",name1=replica." + i + ",name2=Follower";
--- End diff --

Thanks @rgs1, I've have modified the test code as per your suggestion. 
Please take another look at the new commits.


> Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean
> 
>
> Key: ZOOKEEPER-2479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2479
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch
>
>
> The idea of this jira is to expose {{time taken}} for the leader election via 
> jmx Leader, Follower beans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675883#comment-15675883
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2479:
---

Github user rgs1 commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/98#discussion_r88602850
  
--- Diff: src/java/test/org/apache/zookeeper/test/QuorumMajorityTest.java 
---
@@ -36,7 +38,30 @@
 /***/
 @Test
 public void testMajQuorums() throws Throwable {
-   
+LOG.info("Verify QuorumPeer#electionTimeTaken jmx bean attribute");
+
+ArrayList peers = getPeerList();
+for (int i = 1; i <= peers.size(); i++) {
+QuorumPeer qp = peers.get(i - 1);
+Long electionTimeTaken = -1L;
+String bean = "";
+if (qp.getPeerState() == ServerState.FOLLOWING) {
+bean = CommonNames.DOMAIN + ":name0=ReplicatedServer_id" + 
i
++ ",name1=replica." + i + ",name2=Follower";
+electionTimeTaken = (Long) JMXEnv.ensureBeanAttribute(bean,
+"ElectionTimeTaken");
+Assert.assertTrue("Wrong electionTimeTaken value!",
+electionTimeTaken >= 0);
+} else if (qp.getPeerState() == ServerState.LEADING) {
+bean = CommonNames.DOMAIN + ":name0=ReplicatedServer_id" + 
i
++ ",name1=replica." + i + ",name2=Leader";
--- End diff --

ditto


> Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean
> 
>
> Key: ZOOKEEPER-2479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2479
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch
>
>
> The idea of this jira is to expose {{time taken}} for the leader election via 
> jmx Leader, Follower beans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675882#comment-15675882
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2479:
---

Github user rgs1 commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/98#discussion_r88602842
  
--- Diff: src/java/test/org/apache/zookeeper/test/QuorumMajorityTest.java 
---
@@ -36,7 +38,30 @@
 /***/
 @Test
 public void testMajQuorums() throws Throwable {
-   
+LOG.info("Verify QuorumPeer#electionTimeTaken jmx bean attribute");
+
+ArrayList peers = getPeerList();
+for (int i = 1; i <= peers.size(); i++) {
+QuorumPeer qp = peers.get(i - 1);
+Long electionTimeTaken = -1L;
+String bean = "";
+if (qp.getPeerState() == ServerState.FOLLOWING) {
+bean = CommonNames.DOMAIN + ":name0=ReplicatedServer_id" + 
i
++ ",name1=replica." + i + ",name2=Follower";
--- End diff --

hyper nit: `String.format()` reads better than `+`


> Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean
> 
>
> Key: ZOOKEEPER-2479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2479
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch
>
>
> The idea of this jira is to expose {{time taken}} for the leader election via 
> jmx Leader, Follower beans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675758#comment-15675758
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2479:
---

Github user rakeshadr commented on the issue:

https://github.com/apache/zookeeper/pull/98
  
@eribeiro ,, appreciate your feedback. Thanks!


> Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean
> 
>
> Key: ZOOKEEPER-2479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2479
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch
>
>
> The idea of this jira is to expose {{time taken}} for the leader election via 
> jmx Leader, Follower beans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15666073#comment-15666073
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2479:
---

Github user fpj commented on the issue:

https://github.com/apache/zookeeper/pull/98
  
+1, LGTM. @eribeiro is this ready according to you?


> Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean
> 
>
> Key: ZOOKEEPER-2479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2479
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch
>
>
> The idea of this jira is to expose {{time taken}} for the leader election via 
> jmx Leader, Follower beans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[Rakesh R (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15666049#comment-15666049
 ] 

Rakesh R commented on ZOOKEEPER-2479:
-

[~fpj], please let me know anything else to be done for this. Thanks!

> Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean
> 
>
> Key: ZOOKEEPER-2479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2479
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch
>
>
> The idea of this jira is to expose {{time taken}} for the leader election via 
> jmx Leader, Follower beans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15635624#comment-15635624
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2479:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/98#discussion_r86502042
  
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 
---
@@ -520,6 +520,12 @@ public synchronized void setCurrentVote(Vote v){
 protected boolean quorumListenOnAllIPs = false;
 
 /**
+ * Keeps time taken for leader election in milliseconds. Sets the 
value to
+ * this variable only after the completion of leader election.
+ */
+private long electionTimeTaken = -1;
--- End diff --

Yup, agree. :) Thanks for explaining!


> Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean
> 
>
> Key: ZOOKEEPER-2479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2479
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch
>
>
> The idea of this jira is to expose {{time taken}} for the leader election via 
> jmx Leader, Follower beans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15635085#comment-15635085
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2479:
---

Github user rakeshadr commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/98#discussion_r86483860
  
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 
---
@@ -520,6 +520,12 @@ public synchronized void setCurrentVote(Vote v){
 protected boolean quorumListenOnAllIPs = false;
 
 /**
+ * Keeps time taken for leader election in milliseconds. Sets the 
value to
+ * this variable only after the completion of leader election.
+ */
+private long electionTimeTaken = -1;
--- End diff --

Thanks @eribeiro ,

LeaderMXBean, FollowerMXBean will be available only after the quorum leader 
election and the value won't be changed until next LE. I think, adding 
'volatile' doesn't make any difference, right?

code reference:


https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/quorum/Leader.java#L417

https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/quorum/Follower.java#L70

Leader.java
zk.registerJMX(new LeaderBean(this, zk), self.jmxLocalPeerBean);

Follower.java
fzk.registerJMX(new FollowerBean(this, zk), self.jmxLocalPeerBean);


> Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean
> 
>
> Key: ZOOKEEPER-2479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2479
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch
>
>
> The idea of this jira is to expose {{time taken}} for the leader election via 
> jmx Leader, Follower beans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633784#comment-15633784
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2479:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/98#discussion_r86415195
  
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 
---
@@ -520,6 +520,12 @@ public synchronized void setCurrentVote(Vote v){
 protected boolean quorumListenOnAllIPs = false;
 
 /**
+ * Keeps time taken for leader election in milliseconds. Sets the 
value to
+ * this variable only after the completion of leader election.
+ */
+private long electionTimeTaken = -1;
--- End diff --

sincere question: does it make sense to make this field `volatile`? I know 
there are some concurrency guarantees but not sure if it's worth change it.


> Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean
> 
>
> Key: ZOOKEEPER-2479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2479
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch
>
>
> The idea of this jira is to expose {{time taken}} for the leader election via 
> jmx Leader, Follower beans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[Rakesh R (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633544#comment-15633544
 ] 

Rakesh R commented on ZOOKEEPER-2479:
-

OK, attached new patch generated from git master.

> Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean
> 
>
> Key: ZOOKEEPER-2479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2479
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch
>
>
> The idea of this jira is to expose {{time taken}} for the leader election via 
> jmx Leader, Follower beans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[Flavio Junqueira (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632978#comment-15632978
 ] 

Flavio Junqueira commented on ZOOKEEPER-2479:
-

OK, but to be clear, if you do a diff, please do it agains git master, 
definitely not svn. I think you realized that on your own and that's what 
you're saying. :-)

> Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean
> 
>
> Key: ZOOKEEPER-2479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2479
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch
>
>
> The idea of this jira is to expose {{time taken}} for the leader election via 
> jmx Leader, Follower beans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[Rakesh R (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632783#comment-15632783
 ] 

Rakesh R commented on ZOOKEEPER-2479:
-

bq. It seems zk svn trunk doesn't have the latest code changes

Today morning(IST), I've fixed your comments and uploaded a new patch(generated 
from zk git repo) to this jira, but our [jenkins 
PreCommit-ZOOKEEPER-Build-3509|https://issues.apache.org/jira/browse/ZOOKEEPER-2479?focusedCommentId=15631354=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15631354]
 failed to apply this patch. Later I thought to use svn repo to create my 
patch, then I realized that it is quite old. Thats the background of my comment.

Sorry, please ignore my previous jira comment if it is confusing. Kindly use 
the [pull request 98|https://github.com/apache/zookeeper/pull/98] for further 
reviews and commits. I've incorporated your comments into this.

> Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean
> 
>
> Key: ZOOKEEPER-2479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2479
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch
>
>
> The idea of this jira is to expose {{time taken}} for the leader election via 
> jmx Leader, Follower beans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[Flavio Junqueira (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632634#comment-15632634
 ] 

Flavio Junqueira commented on ZOOKEEPER-2479:
-

Yeah, we've switched to git and I don't think the svn repo is being updated any 
longer. We should probably disable it at some point. 

I'm not sure I get your observation, though. If you look at the console output 
of the QA report, it did apply the patch to the master branch of the git repo. 
It doesn't look it is a matter of svn being outdated. I'm not sure why it is 
not applying, you're saying that it does apply to your copy of the master 
branch, right?



> Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean
> 
>
> Key: ZOOKEEPER-2479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2479
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch
>
>
> The idea of this jira is to expose {{time taken}} for the leader election via 
> jmx Leader, Follower beans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)