[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959831#comment-15959831
 ] 

Hadoop QA commented on ZOOKEEPER-2659:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 10 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/507//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/507//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/507//console

This message is automatically generated.

> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959795#comment-15959795
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

GitHub user praste reopened a pull request:

https://github.com/apache/zookeeper/pull/148

ZOOKEEPER-2659 Log4j 2 migration



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/praste/zookeeper log4j2-migration

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/148.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #148


commit 6141943989c65519a8ddcb346aeda79f9cab81ae
Author: Pushkar Raste 
Date:   2016-12-20T22:47:24Z

Log4j2 migration

commit f31eaa95e5ef3a884737dd7c1e56da8dea48c58c
Author: Pushkar Raste 
Date:   2016-12-20T22:48:17Z

Log4j2 migration

commit 5770af750e90e09ab81a362ddcfbc6d25b6db2a5
Author: Pushkar Raste 
Date:   2017-01-04T19:57:11Z

Log4j migration

commit 87f307592ca96c00e7c536f661715f8a6051de8d
Author: Pushkar Raste 
Date:   2017-01-04T22:32:16Z

Log4j2 migration

commit fe072cee365c09e1fb1c5bb8df754c0da78cd471
Author: Pushkar Raste 
Date:   2017-01-05T21:00:23Z

Log4j migration

commit 995277f5e80c998a0fa49fbd6b74ea53d7bf3468
Author: Pushkar Raste 
Date:   2017-01-13T16:35:49Z

Log4j-migration Added disruptor dependency

commit 1d94d27f3caf29e9e582f9778ab79e10abaec35e
Author: Pushkar Raste 
Date:   2017-01-13T16:43:33Z

Merge branch 'master' of https://github.com/apache/zookeeper into 
log4j2-migration

commit abc51db3ad3dbd30838fd72b782f8d41c7c808a0
Author: Pushkar Raste 
Date:   2017-01-13T18:35:43Z

Log4j2 migration

commit 42a587d8862892a27bbb9fbbe7ba1ca4dcb0f42f
Author: Pushkar Raste 
Date:   2017-01-14T02:13:21Z

Log4j2 migration

commit 2db983bc3e449c4220eddd4f720f5e4233ea3d55
Author: Pushkar Raste 
Date:   2017-01-20T14:02:17Z

Changes as per review comments

commit 77214d1d4b45d572633450ffb54310d6fd17c8dc
Author: Pushkar Raste 
Date:   2017-01-21T17:23:06Z

Fix ivy pattern




> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959794#comment-15959794
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user praste commented on the issue:

https://github.com/apache/zookeeper/pull/148
  
Reopening as multiple people are interested in it. However, I have switched 
jobs and may not be able to make further changes until I get approval from my 
new employer. 


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959787#comment-15959787
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user 12hys commented on the issue:

https://github.com/apache/zookeeper/pull/148
  
Would also like to see this merged.


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[Matt Sicker (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941513#comment-15941513
 ] 

Matt Sicker commented on ZOOKEEPER-2659:


Mikael and I are developers on log4j2, and we're here to help as well!

> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[Edward Ribeiro (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941510#comment-15941510
 ] 

Edward Ribeiro commented on ZOOKEEPER-2659:
---

Hey [~praste],

I am no committer, but I see that you have invested *a lot* of work on this. 
This has been the subject of a previous and unfinished JIRA issue, 
ZOOKEEPER-2342, so definitely there is an interest on this matter. Wouldn't you 
like to reopen the PR you made, so that others in the community can take a look?

I will take the liberty to ping some ZK committers -- [~arshadmohammad], 
[~hanm] so that they can take a look when/if they have a spare cycles. I hope 
you don't mind guys! I know you are pretty busy, but migrating to newer 
versions of log4j is a must have for future ZK versions, imo.

Cheers!


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930557#comment-15930557
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user jvz commented on the issue:

https://github.com/apache/zookeeper/pull/148
  
I'm still interested in it, though I'm not a Zookeeper committer, so I 
can't do anything about it.


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930497#comment-15930497
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user praste commented on the issue:

https://github.com/apache/zookeeper/pull/148
  
Looks like no one is really interested in this. 


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930498#comment-15930498
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user praste closed the pull request at:

https://github.com/apache/zookeeper/pull/148


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15853283#comment-15853283
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user praste commented on the issue:

https://github.com/apache/zookeeper/pull/148
  
can this be merged ?


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15849207#comment-15849207
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user nerdyyatrice commented on the issue:

https://github.com/apache/zookeeper/pull/148
  
Thanks, the second one worked.  I wonder how do I apply this to other pull 
requests?  I can't seem to find where to get "praste/zookeeper/"


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15849131#comment-15849131
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user praste commented on the issue:

https://github.com/apache/zookeeper/pull/148
  
Two options

1. Use patch 
* Use link 
https://patch-diff.githubusercontent.com/raw/apache/zookeeper/pull/148.diff and 
save it as patch. Then use `git apply-patch`
2. Pull from my fork (I have not really tested following steps, jut relying 
on my muscle memory)
* `git remote add praste https://github.com/praste/zookeeper/`
* `git fetch praste`
* `git pull praste/log4j2-migration`


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15849078#comment-15849078
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user nerdyyatrice commented on the issue:

https://github.com/apache/zookeeper/pull/148
  
Another stupid question, how can I git pull this request to my local 
machine and play with it? Thanks


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[Pushkar Raste (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848633#comment-15848633
 ] 

Pushkar Raste commented on ZOOKEEPER-2659:
--

any takers for this? 
Let me know if there are any changes we are waiting on for PR to get merged?

> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15843072#comment-15843072
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user jvz commented on the issue:

https://github.com/apache/zookeeper/pull/148
  
If any transitive dependencies rely on the log4j 1.x API itself (not SLF4J 
or Commons Log or java.util.logging or an obscure bridge I didn't mention), 
then they can be replaced with log4j-1.2-api from Log4j2 in general unless 
they're defining custom appenders or other plugins. I'm not too familiar with 
Ivy, but here's what Gradle generates in its embedded ivy.xml for something 
similar:

```xml
  

  
  

  
```


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840802#comment-15840802
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user praste commented on the issue:

https://github.com/apache/zookeeper/pull/148
  
Are sure you removed reference to `slf4j-log4j12` from all the `ivy.xml` 
files?
I am not an ivy expert but you can take a look at
http://stackoverflow.com/questions/5405310/find-hidden-dependencies-in-ivy 
and
http://ant.apache.org/ivy/history/latest-milestone/use/dependencytree.html


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840226#comment-15840226
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user nerdyyatrice commented on the issue:

https://github.com/apache/zookeeper/pull/148
  
Hi, I tried the same approach and I got a bin place conflict as some of the 
dependencies in my ivy.xml is still using log4j1.2. I wonder how can I find out 
which dependency bin placed that or is that a way to override that?


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[Pushkar Raste (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840125#comment-15840125
 ] 

Pushkar Raste commented on ZOOKEEPER-2659:
--

I am not a committer. 
Can someone take a look. 

> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840018#comment-15840018
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user jvz commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r98037086
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java ---
@@ -413,13 +418,18 @@ public void testBadPeerAddressInQuorum() throws 
Exception {
 ClientBase.setupTestEnv();
 
 // setup the logger to capture all logs
+LoggerContext loggerContext =  (LoggerContext) 
LogManager.getContext(false);
--- End diff --

Oh sorry, I meant to get back to you on this much sooner. You can merge 
without using it; just thought it would be a less hacky test.


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839840#comment-15839840
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user praste commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r98013864
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java ---
@@ -413,13 +418,18 @@ public void testBadPeerAddressInQuorum() throws 
Exception {
 ClientBase.setupTestEnv();
 
 // setup the logger to capture all logs
+LoggerContext loggerContext =  (LoggerContext) 
LogManager.getContext(false);
--- End diff --

@jvz is using ListAppender absolutely necessary? 

Can we merge this with  current changes? 


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833679#comment-15833679
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user praste commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r97232914
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java ---
@@ -413,13 +418,18 @@ public void testBadPeerAddressInQuorum() throws 
Exception {
 ClientBase.setupTestEnv();
 
 // setup the logger to capture all logs
+LoggerContext loggerContext =  (LoggerContext) 
LogManager.getContext(false);
--- End diff --

@jvz - I tried to update tests using the `ListAppender` but I don't think, 
it is the right way to verify the log messages. I observed that when I run all 
the tests in the `QuorumPeerMainTest` or `ReadOnlyModeTest`, tests fail. 
However, running 
following test using `test.method=` option works fine 
`QuorumPeerMainTest. testInconsistentPeerType` 
`QuorumPeerMainTest. testQuorumDefaults`
`QuorumPeerMainTest. testBadPeerAddressInQuorum`
`ReadOnlyModeTest.testSeekForRwServer`

Not sure what am I missing here.

Let me know what you think.


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833073#comment-15833073
 ] 

Hadoop QA commented on ZOOKEEPER-2659:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 10 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/227//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/227//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/227//console

This message is automatically generated.

> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[Pushkar Raste (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833060#comment-15833060
 ] 

Pushkar Raste commented on ZOOKEEPER-2659:
--

I am familiar with Maven but not at all with ivy. I tried all different 
combinations with build.xml and ivy.xml
However, no matter what song and dance, I tried, I could not get it to pull 
log4j-core-2.7-tests.jar

Can someone help me to figure out what changes I need to make to get it to work?

> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[Matt Sicker (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832023#comment-15832023
 ] 

Matt Sicker commented on ZOOKEEPER-2659:


{code:xml}

  org.apache.logging.log4j
  log4j-core
  2.7
  test-jar
  test

{code}

Is how it would normally be done in Maven. As for Ivy, [this looks potentially 
useful|http://stackoverflow.com/questions/39164796/resolve-maven-test-jar-in-ivy].

> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[Pushkar Raste (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15831822#comment-15831822
 ] 

Pushkar Raste commented on ZOOKEEPER-2659:
--

I have made all the changes as per review comments except for using the 
{{ListAppender}}

I will figure out how to add maven dependencies with test classifier and try to 
move to using {{ListAppender}}. 

Let me know of if there are any other pressing concerns. 

One suggestion I could see is people prefer properties style  configuration 
over xml. If that  is the case I will make changes accordingly. 

> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15831809#comment-15831809
 ] 

Hadoop QA commented on ZOOKEEPER-2659:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 10 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/226//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/226//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/226//console

This message is automatically generated.

> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827996#comment-15827996
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user praste commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r96629041
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java ---
@@ -413,13 +418,18 @@ public void testBadPeerAddressInQuorum() throws 
Exception {
 ClientBase.setupTestEnv();
 
 // setup the logger to capture all logs
+LoggerContext loggerContext =  (LoggerContext) 
LogManager.getContext(false);
--- End diff --

I am not familiar with Ivy. any idea how to add  maven dependencies with 
tests qualifier in Ivy?


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826356#comment-15826356
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user praste commented on the issue:

https://github.com/apache/zookeeper/pull/148
  
I have made all the suggested  changes except for using List appender,  
which I will look into tonight


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826291#comment-15826291
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user jvz commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r96442072
  
--- Diff: ivy.xml ---
@@ -41,13 +41,20 @@
 
   
 
-
+
+
+
+
+
+
+
--- End diff --

At first I read that it was version 3.0.0, sorry. Anyways, log4j 2 tends to 
stick with the latest versions of dependencies, so I'd recommend 3.3.6.


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826211#comment-15826211
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user revans2 commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r96435980
  
--- Diff: ivy.xml ---
@@ -41,13 +41,20 @@
 
   
 
-
+
+
+
+
+
+
+
--- End diff --

This is the version that log4j 2 uses itself, when you enable async logging.


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[Flavio Junqueira (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826184#comment-15826184
 ] 

Flavio Junqueira commented on ZOOKEEPER-2659:
-

I'm not sure, I need to revisit along with ZOOKEEPER-1371, which we had to 
revert. Perhaps [~arshad.mohammad] can chime in here, since he worked on 
ZOOKEEPER-1371?

> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[Pushkar Raste (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826059#comment-15826059
 ] 

Pushkar Raste commented on ZOOKEEPER-2659:
--

[~fpj] - log4j 1.X is EOL and will not work with JDK1.9, we have to bite the 
bullet at some point. I do understand concerns about making sure changes are as 
smooth as possible (or at the least well document any backwards incompatible 
changes). 

I have chosen to to use xml configuration instead of using properties style 
config. I like structured xml configs but if people have strong opinions on 
using properties style config,  I will definitely look into making required 
changes.

To summarize except for the fact that custom log configs made by the system 
admins, would need to updated with 'log4j 2'  equivalents, are there any other 
concerns?



> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[Flavio Junqueira (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15825797#comment-15825797
 ] 

Flavio Junqueira commented on ZOOKEEPER-2659:
-

Has anyone done due diligence to make sure that the issues reported in 
ZOOKEEPER-2342 have cleared? We have discussed that issue some time back and we 
need to revisit it before we go forward with this one.

Until we clear that issue, I'm -1 here.

> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15824814#comment-15824814
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user jvz commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r96329273
  
--- Diff: conf/log4j2.xml ---
@@ -0,0 +1,56 @@
+
+
+
+  
+%d{ISO8601} [myid:%X{myid}] - 
%-5p [%t:%C{1}@%L] - %m%n
--- End diff --

Ok, makes sense. Would be something good to note somewhere, though.


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15824813#comment-15824813
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user jvz commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r96329244
  
--- Diff: ivy.xml ---
@@ -41,13 +41,20 @@
 
   
 
-
+
+
+
+
+
+
+
+
 
   
 
 
 
-
+
--- End diff --

Agreed, just pointing out in case anything is still using the old API.


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15824783#comment-15824783
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user praste commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r96327023
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java ---
@@ -413,13 +418,18 @@ public void testBadPeerAddressInQuorum() throws 
Exception {
 ClientBase.setupTestEnv();
 
 // setup the logger to capture all logs
+LoggerContext loggerContext =  (LoggerContext) 
LogManager.getContext(false);
--- End diff --

@jvz Thanks for the suggestion, will look into it. 


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15824357#comment-15824357
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user praste commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r96277825
  
--- Diff: conf/log4j2.xml ---
@@ -0,0 +1,56 @@
+
+
+
+  
+%d{ISO8601} [myid:%X{myid}] - 
%-5p [%t:%C{1}@%L] - %m%n
--- End diff --

I was trying to make sure that I can generate log4j2.xml configuration 
compatible with the current log4j.properties 


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15824353#comment-15824353
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user praste commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r96277523
  
--- Diff: ivy.xml ---
@@ -41,13 +41,20 @@
 
   
 
-
+
+
+
+
+
+
+
+
 
   
 
 
 
-
+
--- End diff --

I don't think we should be using 'log4j 1' at all


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823407#comment-15823407
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user jvz commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r96145164
  
--- Diff: conf/log4j2.xml ---
@@ -0,0 +1,56 @@
+
+
+
--- End diff --

Not sure why you're using strict mode here. You're not using the right XML 
elements for strict mode. See the 
[docs](http://logging.apache.org/log4j/2.x/manual/configuration.html#Strict_XML).
 It'd be simpler to just remove the strict attribute as it's not the same type 
of strict as JS or Perl, for example (it's mainly useful for XSD validation).


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823412#comment-15823412
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user jvz commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r96145267
  
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperInternals.xml 
---
@@ -399,11 +399,11 @@ hierarchy of groups.
 
 Zookeeper uses 
 http://www.slf4j.org/index.html;>slf4j as an 
abstraction layer for logging. 
-http://logging.apache.org/log4j;>log4j in version 1.2 
is chosen as the final logging implementation for now.
+http://logging.apache.org/log4j/2.x/;>log4j2 in 
version 2 is chosen as the final logging implementation for now.
--- End diff --

Could you make this an https link? I've been trying to encourage the use of 
the https site.


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823411#comment-15823411
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user jvz commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r96145281
  
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperJMX.xml ---
@@ -100,15 +100,15 @@
   started the server you will be able to monitor and manage various
   service related features.
 
-Also note that ZooKeeper will register log4j MBeans as
+
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823406#comment-15823406
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user jvz commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r96145218
  
--- Diff: conf/log4j2.xml ---
@@ -0,0 +1,56 @@
+
+
+
+  
+%d{ISO8601} [myid:%X{myid}] - 
%-5p [%t:%C{1}@%L] - %m%n
--- End diff --

I'd generally advise against [enabling location 
information](http://logging.apache.org/log4j/2.x/manual/layouts.html#LocationInformation)
 by default due to performance issues. I personally don't find location 
information all that useful outside of caught exceptions anyways.


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823408#comment-15823408
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user jvz commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r96145091
  
--- Diff: ivy.xml ---
@@ -41,13 +41,20 @@
 
   
 
-
+
+
+
+
+
+
+
+
 
   
 
 
 
-
+
--- End diff --

If anything is using log4j 1's API still, you'll need `log4j-1.2-api` as 
well.


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823410#comment-15823410
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user jvz commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r96145357
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java ---
@@ -413,13 +418,18 @@ public void testBadPeerAddressInQuorum() throws 
Exception {
 ClientBase.setupTestEnv();
 
 // setup the logger to capture all logs
+LoggerContext loggerContext =  (LoggerContext) 
LogManager.getContext(false);
--- End diff --

If this test is just storing log messages for verification at the end of 
the test, then I recommend using log4j-core:test's `LoggerContextRule` and 
`ListAppender`. Example: 
[LoggerTest](https://github.com/apache/logging-log4j2/blob/master/log4j-core/src/test/java/org/apache/logging/log4j/core/LoggerTest.java),
 
[config.xml](https://github.com/apache/logging-log4j2/blob/master/log4j-core/src/test/resources/log4j-test2.xml)
 (see the `` appender configs). This way, the test won't 
break if internal details of log4j-core change.


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823405#comment-15823405
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user jvz commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r96145251
  
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
@@ -618,23 +618,23 @@ server.3=zoo3:2888:3888
 
 ZooKeeper uses http://www.slf4j.org;>SLF4J
 version 1.7.5 as its logging infrastructure. For backward 
compatibility it is bound to
-LOG4J but you can use
-http://logback.qos.ch/;>LOGBack
+LOG4J2 but you can use
--- End diff --

This paragraph doesn't make much sense anymore.


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823409#comment-15823409
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user jvz commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r96145076
  
--- Diff: ivy.xml ---
@@ -41,13 +41,20 @@
 
   
 
-
+
+
+
+
+
+
+
--- End diff --

Why are you using an older version of disruptor?


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[Matt Sicker (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823404#comment-15823404
 ] 

Matt Sicker commented on ZOOKEEPER-2659:


I added several comments on the PR that didn't get cross-posted here.

> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823239#comment-15823239
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user mikaelstaldal commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r96145992
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java ---
@@ -615,14 +631,18 @@ public void testQuorumDefaults() throws Exception {
 ClientBase.setupTestEnv();
 
 // setup the logger to capture all logs
+LoggerContext loggerContext =  (LoggerContext) 
LogManager.getContext(false);
+Configuration logConfig = loggerContext.getConfiguration();
+
 Layout layout =
-Logger.getRootLogger().getAppender("CONSOLE").getLayout();
+   
logConfig.getRootLogger().getAppenders().get("STDOUT").getLayout();
+String appenderName = "quorumAppender";
 ByteArrayOutputStream os = new ByteArrayOutputStream();
-WriterAppender appender = new WriterAppender(layout, os);
-appender.setImmediateFlush(true);
-appender.setThreshold(Level.INFO);
-Logger zlogger = Logger.getLogger("org.apache.zookeeper");
-zlogger.addAppender(appender);
+WriterAppender appender = 
WriterAppender.createAppender((StringLayout)layout, null, new 
OutputStreamWriter(os), appenderName, false, true);
--- End diff --

It's probably a good idea to use the builder to create the appender (see 
above).


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823240#comment-15823240
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user mikaelstaldal commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r96146002
  
--- Diff: src/java/test/org/apache/zookeeper/test/ReadOnlyModeTest.java ---
@@ -251,14 +257,19 @@ public void testSessionEstablishment() throws 
Exception {
 @Test(timeout = 9)
 public void testSeekForRwServer() throws Exception {
 // setup the logger to capture all logs
-Layout layout = Logger.getRootLogger().getAppender("CONSOLE")
-.getLayout();
+LoggerContext loggerContext =  (LoggerContext) 
LogManager.getContext(false);
+Configuration logConfig = loggerContext.getConfiguration();
+
+Layout layout =
+   
logConfig.getRootLogger().getAppenders().get("STDOUT").getLayout();
+String appenderName = "zkAppender";
 ByteArrayOutputStream os = new ByteArrayOutputStream();
-WriterAppender appender = new WriterAppender(layout, os);
-appender.setImmediateFlush(true);
-appender.setThreshold(Level.INFO);
-Logger zlogger = Logger.getLogger("org.apache.zookeeper");
-zlogger.addAppender(appender);
+WriterAppender appender = 
WriterAppender.createAppender((StringLayout)layout, null, new 
OutputStreamWriter(os), appenderName, false, true);
--- End diff --

It's probably a good idea to use the builder to create the appender (see 
above).


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823238#comment-15823238
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user mikaelstaldal commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r96145970
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java ---
@@ -470,16 +481,20 @@ public void testBadPeerAddressInQuorum() throws 
Exception {
 @Test
 public void testInconsistentPeerType() throws Exception {
 ClientBase.setupTestEnv();
-
-// setup the logger to capture all logs
+
+LoggerContext loggerContext =  (LoggerContext) 
LogManager.getContext(false);
+Configuration logConfig = loggerContext.getConfiguration();
+
 Layout layout =
-Logger.getRootLogger().getAppender("CONSOLE").getLayout();
+   
logConfig.getRootLogger().getAppenders().get("STDOUT").getLayout();
+String appenderName = "quorumAppender";
 ByteArrayOutputStream os = new ByteArrayOutputStream();
-WriterAppender appender = new WriterAppender(layout, os);
-appender.setThreshold(Level.INFO);
-Logger qlogger = 
Logger.getLogger("org.apache.zookeeper.server.quorum");
-qlogger.addAppender(appender);
-
+WriterAppender appender = 
WriterAppender.createAppender((StringLayout)layout, null, new 
OutputStreamWriter(os), appenderName, false, true);
--- End diff --

It's probably a good idea to use the builder to create the appender (see 
above).


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823237#comment-15823237
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user mikaelstaldal commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r96145959
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java ---
@@ -413,13 +418,18 @@ public void testBadPeerAddressInQuorum() throws 
Exception {
 ClientBase.setupTestEnv();
 
 // setup the logger to capture all logs
+LoggerContext loggerContext =  (LoggerContext) 
LogManager.getContext(false);
+Configuration logConfig = loggerContext.getConfiguration();
+
 Layout layout =
-Logger.getRootLogger().getAppender("CONSOLE").getLayout();
+   
logConfig.getRootLogger().getAppenders().get("STDOUT").getLayout();
+String appenderName = "quorumAppender";
 ByteArrayOutputStream os = new ByteArrayOutputStream();
-WriterAppender appender = new WriterAppender(layout, os);
-appender.setThreshold(Level.WARN);
-Logger qlogger = 
Logger.getLogger("org.apache.zookeeper.server.quorum");
-qlogger.addAppender(appender);
+WriterAppender appender = 
WriterAppender.createAppender((StringLayout)layout, null, new 
OutputStreamWriter(os), appenderName, false, true);
--- End diff --

It's probably a good idea to use the builder to create the appender:

```
WriterAppender.newBuilder().setLayout((StringLayout)layout).setTarget(new 
OutputStreamWriter(os)).setName(appenderName).build();
```



> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823226#comment-15823226
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user mikaelstaldal commented on the issue:

https://github.com/apache/zookeeper/pull/148
  
I would say that it is not proper to refer to Log4j 2.x as "Log4J2". You 
should refer to it as "Log4j 2.x" or "Log4j 2".


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[Edward Ribeiro (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15822904#comment-15822904
 ] 

Edward Ribeiro commented on ZOOKEEPER-2659:
---

Cool, [~praste]! 

After my comment, I remembered that there was some work on Log4j done by 
[~arshad.mohammad] last year. Please, catch up with the following JIRAS:

https://issues.apache.org/jira/browse/ZOOKEEPER-2393

https://issues.apache.org/jira/browse/ZOOKEEPER-1371

Furthermore, this issue seems like a duplicate of 
https://issues.apache.org/jira/browse/ZOOKEEPER-2342 so I would advise you to 
ping [~cnauroth], so that you don't work on the same thing and catch up with 
the discussion there too.

Cheers! 


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[Pushkar Raste (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15822825#comment-15822825
 ] 

Pushkar Raste commented on ZOOKEEPER-2659:
--

Thanks Edward, I have created a pull request 
https://github.com/apache/zookeeper/pull/148
One of the tests is seems to be failing 
({{ReconfigRecoveryTest.testCurrentObserverIsParticipantInNewConfig()}}. 

The test failed on when ran against {{master}} as well. 

> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[Edward Ribeiro (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15821839#comment-15821839
 ] 

Edward Ribeiro commented on ZOOKEEPER-2659:
---

Thanks for taking a stab at this issue, [~praste]! 

The ZK project is switching to a Github based workflow so that it can be easier 
for contributors to submit patches and reviewers to take a look at the patch. 
Would you mind to submit a PR for this issue? your PR title should start as 
"ZOOKEEPER-2664:" so that it can automatically be linked to this JIRA issue. 
More details here under 'Pull requests via github (work in progress)' here 
https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute

Best regards,
Edward

> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)