[edk2-devel] [PATCH] Revert ".pytool/EccCheck: Disable Ecc error code 10014 for open CI"

[Zhang, Shenglei]

This reverts commit d4e0b9607c9a64a8eff20724b2e35ea2cd5bd33f.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2951
Previously false positive Ecc issue whose error code is 10014 was reported
under Linux OS. So we disabled it in EccCheck plugin for edk2 open CI.
As the bug is fixed, we need to revert the change and re-enbale it.

Cc: Sean Brogan 
Cc: Bret Barkelew 
Cc: Michael D Kinney 
Cc: Liming Gao 
Signed-off-by: Shenglei Zhang 
---
 .pytool/Plugin/EccCheck/EccCheck.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/.pytool/Plugin/EccCheck/EccCheck.py 
b/.pytool/Plugin/EccCheck/EccCheck.py
index 3eaad0bf5623..eee1ff7a77b5 100644
--- a/.pytool/Plugin/EccCheck/EccCheck.py
+++ b/.pytool/Plugin/EccCheck/EccCheck.py
@@ -301,7 +301,6 @@ class EccCheck(ICiBuildPlugin):
  "10011",
  "10012",
  "10013",
- "10014", #need to be removed after BZ2904 is fixed
  "10015",
  "10016",
  "10017",
-- 
2.18.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64996): https://edk2.groups.io/g/devel/message/64996
Mute This Topic: https://groups.io/mt/76601437/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/1] Fix XhciDxe Timeouts

[Wu, Hao A]

> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Henz,
> Patrick
> Sent: Thursday, September 3, 2020 7:03 AM
> To: Wu, Hao A ; devel@edk2.groups.io
> Cc: Wang, Jian J ; Ni, Ray 
> Subject: Re: [edk2-devel] [PATCH 0/1] Fix XhciDxe Timeouts
> 
> Hello Hao,
> 
> Yes, I can provide patches for the UHCI and EHCI drivers. I haven't done any
> of the work on either of these yet but will hopefully get to them in the next
> day or so.


Thanks Patrick,

Could you help to add the UHCI and EHCI changes together with the existing XHCI 
patch into one series for the next version?
That will make a series which include 3 patches.

Best Regards,
Hao Wu


> 
> Thanks,
> Patrick Henz
> 
> -Original Message-
> From: Wu, Hao A [mailto:hao.a...@intel.com]
> Sent: Wednesday, September 2, 2020 12:09 AM
> To: Henz, Patrick ; devel@edk2.groups.io
> Cc: Wang, Jian J ; Ni, Ray 
> Subject: RE: [PATCH 0/1] Fix XhciDxe Timeouts
> 
> > -Original Message-
> > From: patrick.h...@hpe.com 
> > Sent: Wednesday, September 2, 2020 2:55 AM
> > To: devel@edk2.groups.io
> > Cc: henz ; Wang, Jian J ;
> > Wu, Hao A ; Ni, Ray 
> > Subject: [PATCH 0/1] Fix XhciDxe Timeouts
> >
> > From: henz 
> >
> > Timeouts in the XhciDxe driver are taking longer than expected due to
> > the timeout loops not accounting for code execution time. As en
> > example, 5 second timeouts have been observed to take around 36
> seconds to complete.
> > Use SetTimer and Create/CheckEvent from Boot Services to determine
> > when timeout occurred. This patch was tested using forced timeouts and
> > print statements with QEmu as well as phycial hardware. The forced
> > timeouts were implemented in code via static variables that guaranteed
> > a timeout the first time the function with the broken timeout was called.
> >
> > Example:
> >
> > XhcExecTransfer (
> >   .
> >   .
> >  )
> > {
> >   .
> >   .
> >   static int do_once = 1;  // test line
> >   .
> >   .
> >   do {
> > Finished = XhcCheckUrbResult (Xhc, Urb);
> > if (do_once) Finished = 0; // test line
> > if (Finished) {
> >   break;
> > }
> > gBS->Stall (XHC_1_MICROSECOND);
> >   } while (!EFI_ERROR(TimerStatus) && EFI_ERROR(gBS->CheckEvent
> > (TimeoutEvent)));
> >
> >   do_once = 0; // test line
> >
> > Using this forced timeout approach the correct timeouts were observed
> > on both hardware and in QEmu.
> >
> > Similar broken timeout loops have been found in the Uhci and Ehci
> > drivers. This patch does not fix those issues.
> 
> 
> Hello Patrick,
> 
> Besides the comments made by Ray in patch 1, could you help to provide 2
> more patches for UHCI and EHCI drivers as well for complete enhancement?
> Thanks in advance.
> 
> Best Regards,
> Hao Wu
> 
> 
> >
> > Cc: Jian J Wang 
> > Cc: Hao A Wu 
> > Cc: Ray Ni 
> > Signed-off-by: Patrick Henz 
> >
> > Patrick Henz (1):
> >   MdeModulePkg/XhciDxe: Fix Broken Timeouts
> >
> >  MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c   | 28 ---
> >  MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 34
> > +---
> >  2 files changed, 49 insertions(+), 13 deletions(-)
> >
> > --
> > 2.27.0
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64994): https://edk2.groups.io/g/devel/message/64994
Mute This Topic: https://groups.io/mt/76576825/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg/XhciDxe: Fix Broken Timeouts

[Wu, Hao A]

Hello Patrick, a couple of inline comments below.
Hello Ray, need your input on one thing below as well.


> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of
> patrick.h...@hpe.com
> Sent: Thursday, September 3, 2020 1:05 AM
> To: devel@edk2.groups.io
> Cc: Patrick Henz ; Wang, Jian J
> ; Wu, Hao A ; Ni, Ray
> 
> Subject: [edk2-devel] [PATCH v2 1/1] MdeModulePkg/XhciDxe: Fix Broken
> Timeouts
> 
> From: Patrick Henz 
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2948
> 
> Timeouts in the XhciDxe driver are taking longer than expected due to the
> timeout loops not accounting for code execution time. As en example, 5
> second timeouts have been observed to take around 36 seconds to
> complete.
> Use SetTimer and Create/CheckEvent from Boot Services to determine when
> timeout occurred.
> 
> Cc: Jian J Wang 
> Cc: Hao A Wu 
> Cc: Ray Ni 
> Signed-off-by: Patrick Henz 
> ---
>  MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c   | 35 ---
>  MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 43
> +++-
>  2 files changed, 65 insertions(+), 13 deletions(-)
> 
> diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c
> b/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c
> index 42b773ab31be..33ac13504669 100644
> --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c
> +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c
> @@ -442,17 +442,44 @@ XhcWaitOpRegBit (
>IN UINT32   Timeout
>)
>  {
> -  UINT32  Index;
> -  UINT64  Loop;
> +  EFI_STATUS Status;
> +  EFI_EVENT  TimeoutEvent;
> 
> -  Loop   = Timeout * XHC_1_MILLISECOND;
> +  TimeoutEvent = NULL;
> 
> -  for (Index = 0; Index < Loop; Index++) {
> +  if (Timeout == 0) {
> +goto TIMEOUT;
> +  }
> +
> +  Status = gBS->CreateEvent (
> +  EVT_TIMER,
> +  TPL_CALLBACK,
> +  NULL,
> +  NULL,
> +  &TimeoutEvent
> +  );
> +
> +  if (!EFI_ERROR (Status)) {
> +Status = gBS->SetTimer (TimeoutEvent,
> +TimerRelative,
> +EFI_TIMER_PERIOD_MILLISECONDS(Timeout));
> +  }
> +
> +  if (EFI_ERROR(Status)) {
> +goto TIMEOUT;
> +  }


Could you help to refine the return status for the case when CreateEvent or 
SetTimer calls fail?
I think it will return EFI_TIMEOUT at this moment, which might confuse the 
caller.
You may need to modify the function description comment section for the new 
return value also.

A similar case applies to XhcExecTransfer() as well.


> +
> +  do {
>  if (XHC_REG_BIT_IS_SET (Xhc, Offset, Bit) == WaitToSet) {
>return EFI_SUCCESS;
>  }
> 
>  gBS->Stall (XHC_1_MICROSECOND);
> +  } while (EFI_ERROR(gBS->CheckEvent (TimeoutEvent)));
> +
> +TIMEOUT:
> +  if (TimeoutEvent != NULL) {
> +gBS->CloseEvent (TimeoutEvent);
>}
> 
>return EFI_TIMEOUT;
> diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> index ab8957c546ee..d6290b5fe33b 100644
> --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> @@ -1273,11 +1273,19 @@ XhcExecTransfer (
>)
>  {
>EFI_STATUS  Status;
> -  UINTN   Index;
> -  UINT64  Loop;
>UINT8   SlotId;
>UINT8   Dci;
>BOOLEAN Finished;
> +  EFI_EVENT   TimeoutEvent;
> +  EFI_STATUS  TimerStatus;
> +
> +  Status   = EFI_SUCCESS;
> +  Finished = FALSE;
> +  TimeoutEvent = NULL;
> +
> +  if (Timeout == 0) {
> +goto DONE;
> +  }
> 
>if (CmdTransfer) {
>  SlotId = 0;
> @@ -1291,29 +1299,46 @@ XhcExecTransfer (
>  ASSERT (Dci < 32);
>}
> 
> -  Status = EFI_SUCCESS;
> -  Loop   = Timeout * XHC_1_MILLISECOND;
> -  if (Timeout == 0) {
> -Loop = 0x;


Ray and Patrick, the previous behavior when 'Timeout' is 0 for this function is 
that it will do a 'psudo-indefinite' loop
by setting the 'Loop' variable to the value of MAX_UINT32.

But after the patch, the behavior got changed and the function will directly 
return EFI_TIMEOUT when 'Timeout' is 0.
This behavior change might impact the callers when they expecting a 
'psudo-indefinite' timeout.
I think it would be better to keep the origin behavior, what is your thought?

Best Regards,
Hao Wu


> +  TimerStatus = gBS->CreateEvent (
> +   EVT_TIMER,
> +   TPL_CALLBACK,
> +   NULL,
> +   NULL,
> +   &TimeoutEvent
> +   );
> +
> +  if (!EFI_ERROR (TimerStatus)) {
> +TimerStatus = gBS->SetTimer (TimeoutEvent,
> + TimerRelative,
> +
> + EFI_TIMER_PERIOD_MILLISECONDS(Timeout));
> +  }
> +
> +  if (EFI_ERROR (TimerStatus)) {
> +goto DONE;
>}
> 
>XhcRingDoorBell (Xhc, SlotId, Dci);
> 
> -  for (Index = 0; Index < Loop; Index++) {

Re: [edk2-devel] Basetools as a pip module

[Andrew Fish via groups.io]

Matthew,

I did not meant to imply we should optimize for the current installed base, I 
just think it is useful to think about them. I think Lazlo is pointing out what 
is best for the project and that should have more weight than the installed 
base, but it is always good to think how things impact different groups. 

In terms of the UI I was thinking of pointing to the pip install location vs. 
your git repo not so much a boolean. I actually don’t quite understand what 
EDK_TOOL_PATH actually means if BaseTools is a pip module. If that is an 
obsolete concept then we should remove it, and replace with some kind of 
statement that the pip installed BaseTools are being used. Another question if 
I run build from the command line how did my path get set? For example my user 
account has 5 different versions of edk2 in it how do I configure different 
versions of BaseTools? How do I pip multiple versions on to my system? I guess 
my repo could have a yml file that points to the version of the tools that I 
use, but that seems like a per user, not per repo config? It seems to me we 
could have developers that want to contribute to edk2 and work on their own 
code base and that could rehire two different Basetool versions installed on 
the system, and I think we need a story for that. 

For the macOS Xcode compiler you can install as many versions as you want and 
there is a command line tool to let you set the current version of Xcode, and 
to show you the currently select versions. Basically the tools in the magic 
location in your path are just redirectors to the currently selected tools. 

Thanks,

Andrew Fish

> On Sep 2, 2020, at 12:06 PM, Matthew Carlson  
> wrote:
> 
> Andrew:
> 
> I think leveraging the existing edksetup is a great idea. Using the existing 
> EDK_TOOL_PATH variable could work but it seems clunky. Since the pip module 
> wouldn't be a path, it seems strange to put a boolean value in a variable 
> meant to hold a path. I definitely think that the scripts could print whether 
> they're using the pip modules or the in-source tools. Since Lazlo suggested 
> that pip will be the default, we could have the in-source modules notify of 
> the fact that you're using the in-source modules. An additional feature for 
> the pip module could be printing the version that they are (since you can use 
> the pip infrastructure to query the version of a given module within a python 
> script). Another option would be simply trying the pip module first and then 
> falling back to the in-source module. There would be a slight speed penalty 
> (likely around 10ms) but since this would only apply to trim and build, it 
> should have relatively low impact.
> 
> Lazlo:
> Thank you for the excellent summary of the different pieces of the discussion 
> along with the links. To answer your first point, I think what a developer 
> does with their pip module is largely up to them. They could do a virtual 
> environment, they could just do what the requirements state, or pip install 
> from a checked out basetools.I do think there are some variables that the 
> virtual environment sets up that would be a good signal whether you're in a 
> virtual environment or not. I agree with your approach of basetools 
> development going into the out of edk2 repo and the importance of making sure 
> package maintainers test and validate their areas with the new setup. I would 
> personally try to get this early into the development cycle, (just after this 
> next stable tag this week) to give the community and developers the most 
> amount of time to get used to things. A trial period of one release makes 
> sense.
> 
> I also agree that the gateway is important in maintaining cohesion between 
> the new and the old. Hopefully that's nearing completion. 
> 
> Hopefully other stewards will weigh in but otherwise we'll move ahead with a 
> proposed solution in patches next week.
> 
> -Matthew Carlson
> 
> 
> On Wed, Sep 2, 2020 at 1:49 AM Laszlo Ersek  > wrote:
> On 09/02/20 02:49, Andrew Fish via groups.io  wrote:
> > 
> > 
> >> On Sep 1, 2020, at 4:35 PM, Matthew Carlson  >> > wrote:
> >>
> >> Hello all,
> >>
> >> A recent topic on the RFC mailing list went out and the work on moving 
> >> Basetools/Sources/Python to a separate repo has started. See the RFC 
> >> conversation here: https://edk2.groups.io/g/rfc/topic/74009714#270 
> >>  
> >>  >> >
> >>
> >> The repo in question is here: https://github.com/tianocore/edk2-basetools 
> >>  
> >>  >> >
> >>
> >> The current plan is shortly after the stable tag is created, a series of 
> >> patches will come into edk2 that

Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Add check for CR3/GDT/IDT.

[Dong, Eric]

Hi Laszlo,

Thanks for your detail review and good comments, add my reply in below.

This issue was reported by tester. They use a shell application to do the test. 
In the test, it first moves the page table to above 4G range then calls 
StartUpThisAp to let AP run the test procedure.  The system will hang during 
the test.

Add more comments in below inline.

From: Laszlo Ersek mailto:ler...@redhat.com>>
Sent: Wednesday, September 2, 2020 3:43 PM
To: devel@edk2.groups.io; Dong, Eric 
mailto:eric.d...@intel.com>>
Cc: Ni, Ray mailto:ray...@intel.com>>
Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Add check for 
CR3/GDT/IDT.

Hi Eric,

On 09/02/20 02:43, Dong, Eric wrote:
> AP needs to run from real mode to 32bit mode to LONG mode. Page table
> (pointed by CR3) and GDT are necessary to set up to correct value when
> CPU execution mode is switched to LONG mode.
> AP uses the same location page table (CR3) and GDT as what BSP uses.
> But when the page table or GDT is above 4GB, it's impossible for CPU
> to use because GDTR.base and CR3 are 32bits before switching to LONG
> mode.
> This patch adds check for the CR3, GDT.Base and IDT.Base to not above
> 32 bits restriction.
>
> Signed-off-by: Eric Dong mailto:eric.d...@intel.com>>
> Cc: Ray Ni mailto:ray...@intel.com>>
> Cc: Laszlo Ersek mailto:ler...@redhat.com>>
> ---
>  UefiCpuPkg/Library/MpInitLib/DxeMpLib.c |   8 +-
>  UefiCpuPkg/Library/MpInitLib/MpLib.c| 108 +++-
>  UefiCpuPkg/Library/MpInitLib/MpLib.h|   6 +-
>  3 files changed, 97 insertions(+), 25 deletions(-)

(1) This is not for edk2-stable202008, correct?
[Eric] Yes, just a bug fix for the issue I received recently.



(2) If I understand correctly, this patch does not solve the problem
when any one of the IDT, GDT, and CR3, are out of 32-bit address space.
Instead, the patch makes the failure symptoms more graceful.

Is that correct?
[Eric] yes, current result is the system hang, I just add error handling to 
avoid hang.


If so, can you explain in the commit message what happens without the
patch, versus with the patch, when the IDT / GDT / CR3 are out of 32-bit
address space?
[Eric] got it, will include it in next version patch.


Like, if we abandon MpInitChangeApLoopCallback() mid-way, then (AIUI)
the AP "pen" (HLT loop) will not be relocated to reserved memory at
ExitBootServces(). I don't think that simply giving up can end well for
the OS!
[Eric] agree. I don’t find a good way to handle it, so I add an error console 
log
In it. I will also add  “ASSERT (FALSE)” code to highlight the error.

(3) Can you remind us in the commit message where the IDT / GDT / page
tables are actually allocated? That is, can you please name the
component that is usually responsible for keeping the allocations in the
32-bit address space?

And once we know where the IDT / GDT / page tables come from --
shouldn't we rather modify those modules, to allocate IDT / GDT / page
tables in the 32-bit address space?
[Eric] This issue trigged by a shell application, so I can’t provide the module 
or driver that cause this failure.


More below:

> diff --git a/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c 
> b/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
> index 2c00d72dde..27f12a75a8 100644
> --- a/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
> +++ b/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
> @@ -393,13 +393,19 @@ MpInitChangeApLoopCallback (
>)
>  {
>CPU_MP_DATA   *CpuMpData;
> +  EFI_STATUSStatus;
>
>CpuMpData = GetCpuMpData ();
>CpuMpData->PmCodeSegment = GetProtectedModeCS ();
>CpuMpData->Pm16CodeSegment = GetProtectedMode16CS ();
>CpuMpData->ApLoopMode = PcdGet8 (PcdCpuApLoopMode);
>mNumberToFinish = CpuMpData->CpuCount - 1;
> -  WakeUpAP (CpuMpData, TRUE, 0, RelocateApLoop, NULL, TRUE);
> +  Status = WakeUpAP (CpuMpData, TRUE, 0, RelocateApLoop, NULL, TRUE);
> +  if (EFI_ERROR (Status)) {
> +DEBUG ((DEBUG_ERROR, "ERROR :: %a() Change Ap Loop Mode failed!\n", 
> __FUNCTION__));
> +return;
> +  }
> +
>while (mNumberToFinish > 0) {
>  CpuPause ();
>}
> diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c 
> b/UefiCpuPkg/Library/MpInitLib/MpLib.c
> index 07426274f6..21b17a7b40 100644
> --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c
> +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c
> @@ -470,7 +470,7 @@ GetProcessorNumber (
>
>@return  CPU count detected
>  **/
> -UINTN
> +EFI_STATUS
>  CollectProcessorCount (
>IN CPU_MP_DATA *CpuMpData
>)
> @@ -478,12 +478,17 @@ CollectProcessorCount (
>UINTN  Index;
>CPU_INFO_IN_HOB*CpuInfoInHob;
>BOOLEANX2Apic;
> +  EFI_STATUS Status;
>
>//
>// Send 1st broadcast IPI to APs to wakeup APs
>//
>CpuMpData->InitFlag = ApInitConfig;
> -  WakeUpAP (CpuMpData, TRUE, 0, NULL, NULL, TRUE);
> +  Status = WakeUpAP (CpuMpData, TRUE, 0, NULL, NULL, TRUE);
> +  if (EFI_ERROR (Status)) {
>

Re: [edk2-devel] [PATCH 0/1] Fix XhciDxe Timeouts

[Henz, Patrick]

Hello Hao,

Yes, I can provide patches for the UHCI and EHCI drivers. I haven't done any of 
the work on either of these yet but will hopefully get to them in the next day 
or so.

Thanks,
Patrick Henz

-Original Message-
From: Wu, Hao A [mailto:hao.a...@intel.com] 
Sent: Wednesday, September 2, 2020 12:09 AM
To: Henz, Patrick ; devel@edk2.groups.io
Cc: Wang, Jian J ; Ni, Ray 
Subject: RE: [PATCH 0/1] Fix XhciDxe Timeouts

> -Original Message-
> From: patrick.h...@hpe.com 
> Sent: Wednesday, September 2, 2020 2:55 AM
> To: devel@edk2.groups.io
> Cc: henz ; Wang, Jian J ; 
> Wu, Hao A ; Ni, Ray 
> Subject: [PATCH 0/1] Fix XhciDxe Timeouts
> 
> From: henz 
> 
> Timeouts in the XhciDxe driver are taking longer than expected due to 
> the timeout loops not accounting for code execution time. As en 
> example, 5 second timeouts have been observed to take around 36 seconds to 
> complete.
> Use SetTimer and Create/CheckEvent from Boot Services to determine 
> when timeout occurred. This patch was tested using forced timeouts and 
> print statements with QEmu as well as phycial hardware. The forced 
> timeouts were implemented in code via static variables that guaranteed 
> a timeout the first time the function with the broken timeout was called.
> 
> Example:
> 
> XhcExecTransfer (
>   .
>   .
>  )
> {
>   .
>   .
>   static int do_once = 1;  // test line
>   .
>   .
>   do {
> Finished = XhcCheckUrbResult (Xhc, Urb);
> if (do_once) Finished = 0; // test line
> if (Finished) {
>   break;
> }
> gBS->Stall (XHC_1_MICROSECOND);
>   } while (!EFI_ERROR(TimerStatus) && EFI_ERROR(gBS->CheckEvent 
> (TimeoutEvent)));
> 
>   do_once = 0; // test line
> 
> Using this forced timeout approach the correct timeouts were observed 
> on both hardware and in QEmu.
> 
> Similar broken timeout loops have been found in the Uhci and Ehci 
> drivers. This patch does not fix those issues.


Hello Patrick,

Besides the comments made by Ray in patch 1, could you help to provide 2 more 
patches for UHCI and EHCI drivers as well for complete enhancement?
Thanks in advance.

Best Regards,
Hao Wu


> 
> Cc: Jian J Wang 
> Cc: Hao A Wu 
> Cc: Ray Ni 
> Signed-off-by: Patrick Henz 
> 
> Patrick Henz (1):
>   MdeModulePkg/XhciDxe: Fix Broken Timeouts
> 
>  MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c   | 28 ---
>  MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 34 
> +---
>  2 files changed, 49 insertions(+), 13 deletions(-)
> 
> --
> 2.27.0


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64989): https://edk2.groups.io/g/devel/message/64989
Mute This Topic: https://groups.io/mt/76576825/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] EmulatorPkg: Enable support for Authenticated Variables

[Michael D Kinney]

Cc EmulatorPkg maintainers.

The default in other platforms is SECURE_BOOT_ENABLE = FALSE.  This might be a 
good
default to use here as well so EmulatorPkg builds are faster without 
CryptoPkg/OpenSSL 
dependencies.  Developers wanting to use auth variables can enabled on the 
build 
command line using /D SECURE_BOOT_ENABLE=TRUE

I do not think this patch enables UEFI Secure Boot for PE/COFF image 
authentication.
Should we use a different define name such as AUTH_VARIABLE_ENABLE?

Thanks,

Mike

> -Original Message-
> From: Wadhawan, Divneil R 
> Sent: Wednesday, September 2, 2020 10:44 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Wadhawan, Divneil R 
> 
> Subject: [edk2-devel] [PATCH] EmulatorPkg: Enable support for Authenticated 
> Variables
> 
> SECURE_BOOT_ENABLE feature flag is introduced to enable Authenticated
> variable support by:
> o Enabling storage space
> o Enabling AuthLib support
> 
> Signed-off-by: Divneil Rai Wadhawan 
> ---
>  EmulatorPkg/EmulatorPkg.dsc | 17 -
>  EmulatorPkg/EmulatorPkg.fdf | 14 ++
>  2 files changed, 26 insertions(+), 5 deletions(-)
> 
> diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc
> index 86a6271735..06cd8a9b4c 100644
> --- a/EmulatorPkg/EmulatorPkg.dsc
> +++ b/EmulatorPkg/EmulatorPkg.dsc
> @@ -32,6 +32,7 @@
>DEFINE NETWORK_TLS_ENABLE   = FALSE
>DEFINE NETWORK_HTTP_BOOT_ENABLE = FALSE
>DEFINE NETWORK_ISCSI_ENABLE = FALSE
> +  DEFINE SECURE_BOOT_ENABLE   = TRUE
> 
>  [SkuIds]
>0|DEFAULT
> @@ -89,6 +90,7 @@
>
> TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTemplate.inf
>
> SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf
>CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
> +
>#
># Platform
>#
> @@ -106,12 +108,21 @@
>LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf
>
> CpuExceptionHandlerLib|MdeModulePkg/Library/CpuExceptionHandlerLibNull/CpuExceptionHandlerLibNull.inf
>
> TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
> -  
> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
>VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
>SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
>ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
>FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf
> 
> +  !if $(SECURE_BOOT_ENABLE) == TRUE
> +IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
> +OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
> +
> PlatformSecureLib|SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf
> +BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
> +AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
> +  !else
> +
> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
> +  !endif
> +
>  [LibraryClasses.common.SEC]
>PeiServicesLib|EmulatorPkg/Library/SecPeiServicesLib/SecPeiServicesLib.inf
>PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> @@ -190,6 +201,10 @@
>gEmulatorPkgTokenSpaceGuid.PcdEmuFirmwareFdSize|0x002a
>gEmulatorPkgTokenSpaceGuid.PcdEmuFirmwareBlockSize|0x1
>gEmulatorPkgTokenSpaceGuid.PcdEmuFirmwareVolume|L"../FV/FV_RECOVERY.fd"
> +  !if $(SECURE_BOOT_ENABLE) == TRUE
> +gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize|0x2800
> +gEfiSecurityPkgTokenSpaceGuid.PcdUserPhysicalPresence|TRUE
> +  !endif
> 
>gEmulatorPkgTokenSpaceGuid.PcdEmuMemorySize|L"64!64"
> 
> diff --git a/EmulatorPkg/EmulatorPkg.fdf b/EmulatorPkg/EmulatorPkg.fdf
> index 295f6f1db8..93552baf8b 100644
> --- a/EmulatorPkg/EmulatorPkg.fdf
> +++ b/EmulatorPkg/EmulatorPkg.fdf
> @@ -46,10 +46,16 @@ DATA = {
># Blockmap[1]: End
>0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
>## This is the VARIABLE_STORE_HEADER
> -  #Signature: gEfiVariableGuid =
> -  #  { 0xddcf3616, 0x3275, 0x4164, { 0x98, 0xb6, 0xfe, 0x85, 0x70, 0x7f, 
> 0xfe, 0x7d }}
> -  0x16, 0x36, 0xcf, 0xdd, 0x75, 0x32, 0x64, 0x41,
> -  0x98, 0xb6, 0xfe, 0x85, 0x70, 0x7f, 0xfe, 0x7d,
> +  !if $(SECURE_BOOT_ENABLE) == FALSE
> +#Signature: gEfiVariableGuid =
> +#  { 0xddcf3616, 0x3275, 0x4164, { 0x98, 0xb6, 0xfe, 0x85, 0x70, 0x7f, 
> 0xfe, 0x7d }}
> +0x16, 0x36, 0xcf, 0xdd, 0x75, 0x32, 0x64, 0x41,
> +0x98, 0xb6, 0xfe, 0x85, 0x70, 0x7f, 0xfe, 0x7d,
> +  !else
> +# Signature: gEfiAuthenticatedVariableGuid = { 0xaaf32c78, 0x947b, 
> 0x439a, { 0xa1, 0x80, 0x2e, 0x14, 0x4e, 0xc3, 0x77, 0x92 } }
> +0x78, 0x2c, 0xf3, 0xaa, 0x7b, 0x94, 0x9a, 0x43,
> +0xa1, 0x80, 0x2e, 0x14, 0x4e, 0xc3, 0x77, 0x92,
> +  !endif
>#Size: 0xc000 
> (gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize) - 0x48 (size 
> of EFI_FIRMWARE_VOLUME_HEADER) = 0xBFB8
># This can speed up the Variable Dis

Re: [edk2-devel] Basetools as a pip module

[Matthew Carlson]

Andrew:

I think leveraging the existing edksetup is a great idea. Using the
existing EDK_TOOL_PATH variable could work but it seems clunky. Since the
pip module wouldn't be a path, it seems strange to put a boolean value in a
variable meant to hold a path. I definitely think that the scripts could
print whether they're using the pip modules or the in-source tools. Since
Lazlo suggested that pip will be the default, we could have the in-source
modules notify of the fact that you're using the in-source modules. An
additional feature for the pip module could be printing the version that
they are (since you can use the pip infrastructure to query the version of
a given module within a python script). Another option would be simply
trying the pip module first and then falling back to the in-source module.
There would be a slight speed penalty (likely around 10ms) but since this
would only apply to trim and build, it should have relatively low impact.

Lazlo:
Thank you for the excellent summary of the different pieces of the
discussion along with the links. To answer your first point, I think what a
developer does with their pip module is largely up to them. They could do a
virtual environment, they could just do what the requirements state, or pip
install from a checked out basetools.I do think there are some variables
that the virtual environment sets up that would be a good signal whether
you're in a virtual environment or not. I agree with your approach of
basetools development going into the out of edk2 repo and the importance of
making sure package maintainers test and validate their areas with the new
setup. I would personally try to get this early into the development cycle,
(just after this next stable tag this week) to give the community and
developers the most amount of time to get used to things. A trial period of
one release makes sense.

I also agree that the gateway is important in maintaining cohesion between
the new and the old. Hopefully that's nearing completion.

Hopefully other stewards will weigh in but otherwise we'll move ahead with
a proposed solution in patches next week.

-Matthew Carlson


On Wed, Sep 2, 2020 at 1:49 AM Laszlo Ersek  wrote:

> On 09/02/20 02:49, Andrew Fish via groups.io wrote:
> >
> >
> >> On Sep 1, 2020, at 4:35 PM, Matthew Carlson 
> wrote:
> >>
> >> Hello all,
> >>
> >> A recent topic on the RFC mailing list went out and the work on moving
> Basetools/Sources/Python to a separate repo has started. See the RFC
> conversation here: https://edk2.groups.io/g/rfc/topic/74009714#270 <
> https://edk2.groups.io/g/rfc/topic/74009714#270>
> >>
> >> The repo in question is here:
> https://github.com/tianocore/edk2-basetools <
> https://github.com/tianocore/edk2-basetools>
> >>
> >> The current plan is shortly after the stable tag is created, a series
> of patches will come into edk2 that redirects the build system into the new
> python module as well as adds additional documentation. You can see a
> sample of this work here: https://github.com/matthewfcarlson/edk2 <
> https://github.com/matthewfcarlson/edk2> as this has a branch that has
> the work required to use the basetools pip module. The patches won't delete
> the Basetools/Sources/Python folder but will allow users to select between
> them. After a certain grace period, the python folder will be deleted and
> the pip module will be the de facto way of using basetools.
> >>
> >> Three questions need to be answered:
> >>
> >> 1. After the patches that enable the pip module land, how long should
> the grace period be?
> >> 2. During the grace period, should basetools commits land in both
> places or just in the edk2-basetools directory?
> >> 3. How should the user be able to select which basetools to use (the
> one in EDK2 or the pip module)? Currently the approach being considered is
> a simple environmental variable? One of the key considerations is
> transparency since it won't be apparent what is being used for a particular
> build without some sort of mechanism to notify the developer. With two
> seperate versions of Basetools, it becomes very easy for the version of
> basetools you're using to not be the one you expect.
> >>
> >
> > Matthew,
> >
> > I’ll throw out some current developer centric ideas.
> >
> > 1) If you `source edksetup.sh` (edksetup.bat) you get the current
> behavior, and you add an argument you get the pip flavor? So maybe
> `edksetup.bat pip-basetools`?
> > 2) We have similar issues to this with env variables and the build
> command dumps them out when it runs. Can we use the current EDK_TOOL_PATH?
> Or maybe add an extra print to show that the pip module is being used?
>
> I've skimmed:
>
> - the earlier discussion linked above (rooted at <
> https://edk2.groups.io/g/rfc/message/270>),
>
> - the even earlier comments in the "Discussion: Basetools a separate repo"
> thread on edk2-devel:
>
>   https://edk2.groups.io/g/devel/message/57482
>
> http://mid.mail-archive.com/734D49CCEBEEF84792F5B80ED

Re: [edk2-devel] [edk2-platforms] [PATCH V1] LogoFeaturePkg: Update Intel Logo

[Chaganty, Rangasai V]

Reviewed-by: Sai Chaganty 

-Original Message-
From: Nate DeSimone  
Sent: Wednesday, September 02, 2020 9:55 AM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Bi, Dandan 
; Liming Gao 
Subject: [edk2-platforms] [PATCH V1] LogoFeaturePkg: Update Intel Logo

Updated Intel corporate logo.

Cc: Sai Chaganty 
Cc: Dandan Bi 
Cc: Liming Gao 
Signed-off-by: Nate DeSimone 
---
 .../LogoFeaturePkg/LogoDxe/Logo.bmp   | Bin 183366 -> 109494 bytes
 .../LogoFeaturePkg/LogoDxe/Logo.jpg   | Bin 11944 -> 10573 bytes
 2 files changed, 0 insertions(+), 0 deletions(-)

diff --git a/Features/Intel/UserInterface/LogoFeaturePkg/LogoDxe/Logo.bmp 
b/Features/Intel/UserInterface/LogoFeaturePkg/LogoDxe/Logo.bmp
index 
7ec1aa6a852564e262df59929655f7a0f3d5445f..d7ca8c9693317088eac9f7e9f7aec7e3ec573489
 100644 GIT binary patch literal 109494
zcmeHQ3Gi0a`_C4ovNULs3{px-mNrY4G@43Trw}Fk7KxuMMH3^@*a~4Ll2SB8t3qW-
zSt2Dw+Jr<374iT4{&(j5&b;rr_de%&?z#8A@ArJ?r{D9Q`z)X5bMEuL_nv#sxhHp?
zGGT{G|NT1_|24vY&GGR+`2QU$)xy8Q-@F=?D*g9A|K}O-40r}S1D*lTfM=lMF|gPF
z|5d3{CFRuj-FM%UPd@qb%P$``Y}l)>zPfPX!mqyiYR#H8zyA8`zyJRG*I$2a*sx*!
z`t?hfE}b)H&V&gQ?!W*3%Pza@q?1kp-jtzc5^n$f_dn{WqZ&4Bxa+RFW&*$mO_qUO
zcG;y-qefl2bm`Zx--r<-UVi!Ix8HvI^UptDw{9Iy^=;d>;k4KPl8tWkw$DEMoO|xM
zk3IGnVEpsXKYDa48I}9|^UwG0-Me1Bdd5Jd+lVj5L4yXZSg}G8^2Z;4OrAWsWy_Yv
zq?8&%Fgh%5WOxot(8a~xoVKu`!q5dU^k(PIorew`I(P0|^rIC#7kC1n)vH(U*|X==
zsZ;T*X9bC(ylBy)+itt9L4yYF@avu_kiv9yKSsG})28^Uf%&JOemY>lfbQM9_v+Pa
zPBG5he+*9C$9=%wzz*X4CVnbp}1*}J0l%o5VELlRNC_*i)J9zEK9((Mh
zNt4hc5fNP+TD^KTuFtDgtHy&JYbC)P;T$)K%a#`Q9wcj8mpeVN(=gsCR*_jK_%S4BABCk2r+K
zD;O=YP0FYr5heDJ(IFal-+g!34jeczPzdT#dE35yJI2J+wKpDx+3J~z*)0q#d^+<0;VGDw9`(M)WUQmxrF&dJ4R43G#4o7_m5~f{q)ljG#Kh>-n=>F
zHf`D{SB~%~{}9+A%DW!%u()_q4V$ZCL%j@K1!W9p6^sf|0cyy@j5M^ACxTKjkZyuW&
zilN>GvGSgK?)lkgpHbZAPzOxzvBw^uAOEV6Va)r*gQPKI#^?_p;m{o(g_a$njO+2uH{WE_LNrwT
zM+-O~#*G_C^qFThJY;7qoseV{O)QRL?hTf=Y~H;2-h1!GWDgYMe*5j$v17;AUw<8O
z@hlS0I|`gQ#S_G0hbY&24DRCDv=9voIy&s*b=O@-beMBB3~6@g&><|%uy#pOVLtWt
z0}eO<1F8iNk1*PE+G(fhYD#vE2Z7ij%C#P`^pDL6-B5LLgn;?s1*Zz#f37rFu3Xu=
zb?b;s!wyNZ2=iIoj%(?*ZQFM3+7(j*F#oVvLA9iShaI9^>+$Qazh-knH&k65CSW=o
z)&bES@-(rw2qPPqw8=B4SYi1y#!SM}jBcm+57UYE%sUzui_%VvNO5JeLB~LTtx_att}5yNQWI4L`)#
zErjSlLX94=STn*c`%rNddJ8cq-C==dS=Qrs-+fn*CgbCK@4bh8Jc8vs#9q+Vu)xRa
z-mtQ?%Og=X22n7t7UeCU
z;vYIn-&QEUdc5ndyKG6&^|3mD$a$C=9!yL2-@wvo7e!%2i)-?S9(oAr|M=sNjEOf!
zpT&(jy|!|(H+hRK23?;RT{p3k%dZ}TwWwAkC}pg_s9n1@k@GM$Y+k1v+6vf8RQ~H6
z2F%!wlDzrmo1-VR7!B!-wj}8K^eA*q-M_6&jAH9n>6c$U;_-ya&Q`#jWZ^Il`fJ9F
z8MbkiJ~m$>_IL@Ysq7eni!>Q9lnD`!(zg}LuO8od=N(%Tls?v#3+oX-uk4W=EXX2u
zcWJ39dKrR?Oc^kg2@#Ldw-w5-9>4hF3tJMDKDJ&V5+0@|xmd+=p)j{4-LB|m2rd$5
zz)&VcJWAhID8G9A;fEh=Nl^NS9(pK|@G!Nfo_b1ovl6h{H_T_Lw_EX0pzI>|f)G|8
ziFmAh>dNI;kHO2=^c?9j=E4yP4^#W{%P;BSbWLpk80NFo+x0YUWf!^IV$k)8cytph
zx%}!;ve?jewst}9U}d@$`AQi(E2ccGT7cZ?N0lZ+Z~=?~LzxiqD1BR@{OVEiMgSt)
zVQP3;sxAM4{x{!z6XvrF+IgG=RxZ*{0S`Mwnbjknq_e4jq44(+^Fk%jOVl>DWF&dT
zI%g=PfQKET%<2&Z#ijy=jLy|f@csx%^b)nz88FI{yo?TojVa(^hw$~NQzz``2@@vh
z-YSS3OPYj-Smz9d6!5S^_*mP0%Rzc)g(j+{@I%g=PfQKEz*P~7yqjPnW<;$1r-YSBOnG8AuMp?px(V?(0
z1w4`vj5jh!2$4XIjhpTBjzxztvG0v<^S%(`SG#WTS>Jta_MgJxTglC44{v}9qi;)!11iR2npvDHxwjLWbYQ)YCo4mzl
z=T3qBhJ~h0o5rGIa{|Ly=M04u@JK>nK|T8|6}D_(R|*N#*l^j_BWT>XaU(Cm8*jWZ
zHakZO*usmqsRFi{rJOlDLINunDW`x(5(2h(bCZk23w)k<;)$4kAc0!ou=r!P^$0wZ
zCr{=j_{0-W6sMC;OT&f@d6?gL;|&Tzp7X$p;@?&$1w4`vupK&dsBKaV{ec4q3US5;
z&Ac9OxZws~j(D(6`K^g%fT6(dmpkvglM;?cNMJ?rZ>y669!Ut;;*~}zoDA~i53$T=
zUXR$bk=+*^J9dmsFmVN3tg_$j-mYCc3LZ8gFr@gm)ky)5Bt&2BQae8Aj9A2haJ{g-};tJ=Sa}EzJ?v(LH9ts|w|GWuYHC-7q
z&|)tGVtJq_oPGA$?C%Zys?tH~+1bjJL~M0zG3fflSh|Ts#w|?c%9V*hiE4Pv!G6Vz
zo=e}pePbi$q#oHfWkJ3pMvQQJ?*JO{MsmqZDsfF7+ZRef??hW!IZ05k#h~jGVdy48
zdHneC36^C2`t@-QCWI82AAR)Ev25g|99S$N21+c74t}+bQ3@LKQ;)dDkbf89U0vs$cV0n`?2nj-Bj1s7`}XaP8#lJXKsJ@d>n!??9-pEG9;eK6C=
z67CuvdE}98+qPN7H7eWwI0BE+53$jhjB-VHZ87Nj#3;InBYEY@m7_aix+(3#f5lp
z1uldnLj=*7>2s}x^%xDK_-JhJU>N=^ZfBt*__DYvewr*c@2z=qeLuU)$~=R8NlyY$ja70I?jwCCufwy`Ms
z(GjDMQv5?F+DYji9XD3V0+T
za%;PO{d(Kcyxi6!PNdGAJ0~^HnP!(^ixuL!s<2{_pbhgWX-@%k&9HX@@<9+a1plo>#0`Vf&S+cSj&c_>VnQ>`mSh8#F?J7(K#6?4cSpYAjy7
zI94rX1^V(jouZuABcS%`)vHu~C9#MD&uesgd9vip;YEzLN&$~BMBTb|SFKtlagwYp
z)+_Pe@{|91#HrG$Q>XmjOJcGgrXNS2*uh4==s+QnGs#ND#8mgb2eF@FW$YNs}h*4OJu<0$aSVO}Ngh
zgz6C|45kWT{^6D_TjbOw;sFaAuejohh%=dYNP>+QG1@8xJPC%t9LV(FV~9~lYgCc
zft3Q1eVL503K}u;|KNiU;(<#T2HW=1tw&@E@I8C>#PW>-mfU^BnjKs)W7kJpo~`sH
z_^kpFl~cguE(8|PEnT`);@@bCn?#(-1gA@W>3WrISQawy5qwg9g>ARZH=cpil<&sMx@w
ze!QMfxG$EXJrM9zambJ%wi|9JNIancgVje~#0p|{*kOlZHza&@+wS~;Cz~i|lwq@G
z&75*2tVgHV*v>IY=Blf%!ZLqM=(ReT17&QhJ89A+>@9%jS?+EUBeG*)RwfZ{{UOBw
z?l{`EZQG|$pJBs>p|5AooQdln-1y+P5APkoNZr(_Q*k*uV88&ZRd3$BIrcwPwoZkz
ztVhKdE>sRY@W2ioI$VGK^&>})#DhXGKY#vwJhWBJ&zLb|?AWo`u_4$%;GlyJQs!9+
zs<;?JR+xRMUVdQ60(^qnxuP?@BU)<;Z`0bh>^l9`k%Ra^`qDGc6ECJgv`%!Kyn
zpo}t9Cefb#(VR2j>oJENq>76nHe|27Eo{u%}dUF@zkZ;~~)*@byUNDm6_;87h<1
zK>9!~81VJzf>ohURa^`~7}}d>%Yd)PZ231vXOy8bF*@{(rNV%(#~k*QDlUeQ!*o0(
zIs?8Q>0G6z$tXi*;sWIM_bRdf=K@a|`}Fmg!_HO3#SmPi!!AY``adfMd_7vxm5wr_
z43&usguWhKuxj+_>(NL{wvDQ|7=jDrz8+n$YV_&r(MU_Sjf^r>CN7ZsdUV06(WkFR
zBQ4oBs^Ve@E|B|rbi

Re: [edk2-devel] [edk2-platforms] [PATCH V1] CometlakeOpenBoardPkg: Add usage of CometlakeSiliconBinPkg

[Chaganty, Rangasai V]

Reviewed-by: Sai Chaganty 

-Original Message-
From: Desimone, Nathaniel L  
Sent: Wednesday, September 02, 2020 12:15 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Chaganty, Rangasai V 
; Kethi Reddy, Deepika 
; Esakkithevar, Kathappan 

Subject: [edk2-platforms] [PATCH V1] CometlakeOpenBoardPkg: Add usage of 
CometlakeSiliconBinPkg

Updates CometlakeOpenBoardPkg to use CometlakeSiliconBinPkg instead of 
CoffeelakeSiliconBinPkg.

Cc: Chasel Chiu 
Cc: Rangasai V Chaganty 
Cc: Deepika Kethi Reddy 
Cc: Kathappan Esakkithevar 
Signed-off-by: Nate DeSimone 
---
 .../CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git 
a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc 
b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
index 2d9dcb139f..6de834565a 100644
--- a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
+++ b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.ds
+++ c
@@ -10,7 +10,7 @@
 [Defines]
   DEFINE  PLATFORM_PACKAGE  = MinPlatformPkg
   DEFINE  PLATFORM_SI_PACKAGE   = CoffeelakeSiliconPkg
-  DEFINE  PLATFORM_SI_BIN_PACKAGE   = CoffeelakeSiliconBinPkg
+  DEFINE  PLATFORM_SI_BIN_PACKAGE   = CometlakeSiliconBinPkg
   DEFINE  PLATFORM_FSP_BIN_PACKAGE  = CometLakeFspBinPkg/CometLake1
   DEFINE  PLATFORM_BOARD_PACKAGE= CometlakeOpenBoardPkg
   DEFINE  BOARD = CometlakeURvp
@@ -39,7 +39,8 @@
   #
   # Include PCD configuration for this board.
   #
-  !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc

+  !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
+
   !include OpenBoardPkgPcd.dsc
   !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
 
--
2.27.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64985): https://edk2.groups.io/g/devel/message/64985
Mute This Topic: https://groups.io/mt/76577729/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v2 0/1] Fix XhciDxe Timeouts

[patrick . henz]

From: Patrick Henz 

Timeouts in the XhciDxe driver are taking longer than
expected due to the timeout loops not accounting for
code execution time. As en example, 5 second timeouts
have been observed to take around 36 seconds to complete.
Use SetTimer and Create/CheckEvent from Boot Services to
determine when timeout occurred. This patch was tested
using forced timeouts and print statements with QEmu as
well as phycial hardware. The forced timeouts were
implemented in code via static variables that guaranteed
a timeout the first time the function with the broken
timeout was called.

Example:

XhcExecTransfer (
  .
  .
 )
{
  .
  .
  static int do_once = 1;  // test line
  .
  .
  do {
Finished = XhcCheckUrbResult (Xhc, Urb);
if (do_once) Finished = 0; // test line
if (Finished) {
  break;
}
gBS->Stall (XHC_1_MICROSECOND);
  } while (EFI_ERROR(gBS->CheckEvent (TimeoutEvent)));

  do_once = 0; // test line

Using this forced timeout approach the correct timeouts
were observed on both hardware and in QEmu.

Similar broken timeout loops have been found in the Uhci
and Ehci drivers. This patch does not fix those issues.

Cc: Jian J Wang 
Cc: Hao A Wu 
Cc: Ray Ni 
Signed-off-by: Patrick Henz 

Patrick Henz (1):
  MdeModulePkg/XhciDxe: Fix Broken Timeouts

 MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c   | 35 ---
 MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 43 +++-
 2 files changed, 65 insertions(+), 13 deletions(-)

-- 
2.28.0


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64983): https://edk2.groups.io/g/devel/message/64983
Mute This Topic: https://groups.io/mt/76587249/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v2 1/1] MdeModulePkg/XhciDxe: Fix Broken Timeouts

[patrick . henz]

From: Patrick Henz 

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2948

Timeouts in the XhciDxe driver are taking longer than
expected due to the timeout loops not accounting for
code execution time. As en example, 5 second timeouts
have been observed to take around 36 seconds to complete.
Use SetTimer and Create/CheckEvent from Boot Services to
determine when timeout occurred.

Cc: Jian J Wang 
Cc: Hao A Wu 
Cc: Ray Ni 
Signed-off-by: Patrick Henz 
---
 MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c   | 35 ---
 MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 43 +++-
 2 files changed, 65 insertions(+), 13 deletions(-)

diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c 
b/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c
index 42b773ab31be..33ac13504669 100644
--- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c
+++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c
@@ -442,17 +442,44 @@ XhcWaitOpRegBit (
   IN UINT32   Timeout
   )
 {
-  UINT32  Index;
-  UINT64  Loop;
+  EFI_STATUS Status;
+  EFI_EVENT  TimeoutEvent;
 
-  Loop   = Timeout * XHC_1_MILLISECOND;
+  TimeoutEvent = NULL;
 
-  for (Index = 0; Index < Loop; Index++) {
+  if (Timeout == 0) {
+goto TIMEOUT;
+  }
+
+  Status = gBS->CreateEvent (
+  EVT_TIMER,
+  TPL_CALLBACK,
+  NULL,
+  NULL,
+  &TimeoutEvent
+  );
+
+  if (!EFI_ERROR (Status)) {
+Status = gBS->SetTimer (TimeoutEvent,
+TimerRelative,
+EFI_TIMER_PERIOD_MILLISECONDS(Timeout));
+  }
+
+  if (EFI_ERROR(Status)) {
+goto TIMEOUT;
+  }
+
+  do {
 if (XHC_REG_BIT_IS_SET (Xhc, Offset, Bit) == WaitToSet) {
   return EFI_SUCCESS;
 }
 
 gBS->Stall (XHC_1_MICROSECOND);
+  } while (EFI_ERROR(gBS->CheckEvent (TimeoutEvent)));
+
+TIMEOUT:
+  if (TimeoutEvent != NULL) {
+gBS->CloseEvent (TimeoutEvent);
   }
 
   return EFI_TIMEOUT;
diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c 
b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
index ab8957c546ee..d6290b5fe33b 100644
--- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
+++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
@@ -1273,11 +1273,19 @@ XhcExecTransfer (
   )
 {
   EFI_STATUS  Status;
-  UINTN   Index;
-  UINT64  Loop;
   UINT8   SlotId;
   UINT8   Dci;
   BOOLEAN Finished;
+  EFI_EVENT   TimeoutEvent;
+  EFI_STATUS  TimerStatus;
+
+  Status   = EFI_SUCCESS;
+  Finished = FALSE;
+  TimeoutEvent = NULL;
+
+  if (Timeout == 0) {
+goto DONE;
+  }
 
   if (CmdTransfer) {
 SlotId = 0;
@@ -1291,29 +1299,46 @@ XhcExecTransfer (
 ASSERT (Dci < 32);
   }
 
-  Status = EFI_SUCCESS;
-  Loop   = Timeout * XHC_1_MILLISECOND;
-  if (Timeout == 0) {
-Loop = 0x;
+  TimerStatus = gBS->CreateEvent (
+   EVT_TIMER,
+   TPL_CALLBACK,
+   NULL,
+   NULL,
+   &TimeoutEvent
+   );
+
+  if (!EFI_ERROR (TimerStatus)) {
+TimerStatus = gBS->SetTimer (TimeoutEvent,
+ TimerRelative,
+ EFI_TIMER_PERIOD_MILLISECONDS(Timeout));
+  }
+
+  if (EFI_ERROR (TimerStatus)) {
+goto DONE;
   }
 
   XhcRingDoorBell (Xhc, SlotId, Dci);
 
-  for (Index = 0; Index < Loop; Index++) {
+  do {
 Finished = XhcCheckUrbResult (Xhc, Urb);
 if (Finished) {
   break;
 }
 gBS->Stall (XHC_1_MICROSECOND);
-  }
+  } while (EFI_ERROR(gBS->CheckEvent (TimeoutEvent)));
 
-  if (Index == Loop) {
+DONE:
+  if (!Finished) {
 Urb->Result = EFI_USB_ERR_TIMEOUT;
 Status  = EFI_TIMEOUT;
   } else if (Urb->Result != EFI_USB_NOERROR) {
 Status  = EFI_DEVICE_ERROR;
   }
 
+  if (TimeoutEvent != NULL) {
+gBS->CloseEvent (TimeoutEvent);
+  }
+
   return Status;
 }
 
-- 
2.28.0


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64984): https://edk2.groups.io/g/devel/message/64984
Mute This Topic: https://groups.io/mt/76587252/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-platforms] [PATCH V1] LogoFeaturePkg: Update Intel Logo

[Nate DeSimone]

Updated Intel corporate logo.

Cc: Sai Chaganty 
Cc: Dandan Bi 
Cc: Liming Gao 
Signed-off-by: Nate DeSimone 
---
 .../LogoFeaturePkg/LogoDxe/Logo.bmp   | Bin 183366 -> 109494 bytes
 .../LogoFeaturePkg/LogoDxe/Logo.jpg   | Bin 11944 -> 10573 bytes
 2 files changed, 0 insertions(+), 0 deletions(-)

diff --git a/Features/Intel/UserInterface/LogoFeaturePkg/LogoDxe/Logo.bmp 
b/Features/Intel/UserInterface/LogoFeaturePkg/LogoDxe/Logo.bmp
index 
7ec1aa6a852564e262df59929655f7a0f3d5445f..d7ca8c9693317088eac9f7e9f7aec7e3ec573489
 100644
GIT binary patch
literal 109494
zcmeHQ3Gi0a`_C4ovNULs3{px-mNrY4G@43Trw}Fk7KxuMMH3^@*a~4Ll2SB8t3qW-
zSt2Dw+Jr<374iT4{&(j5&b;rr_de%&?z#8A@ArJ?r{D9Q`z)X5bMEuL_nv#sxhHp?
zGGT{G|NT1_|24vY&GGR+`2QU$)xy8Q-@F=?D*g9A|K}O-40r}S1D*lTfM=lMF|gPF
z|5d3{CFRuj-FM%UPd@qb%P$``Y}l)>zPfPX!mqyiYR#H8zyA8`zyJRG*I$2a*sx*!
z`t?hfE}b)H&V&gQ?!W*3%Pza@q?1kp-jtzc5^n$f_dn{WqZ&4Bxa+RFW&*$mO_qUO
zcG;y-qefl2bm`Zx--r<-UVi!Ix8HvI^UptDw{9Iy^=;d>;k4KPl8tWkw$DEMoO|xM
zk3IGnVEpsXKYDa48I}9|^UwG0-Me1Bdd5Jd+lVj5L4yXZSg}G8^2Z;4OrAWsWy_Yv
zq?8&%Fgh%5WOxot(8a~xoVKu`!q5dU^k(PIorew`I(P0|^rIC#7kC1n)vH(U*|X==
zsZ;T*X9bC(ylBy)+itt9L4yYF@avu_kiv9yKSsG})28^Uf%&JOemY>lfbQM9_v+Pa
zPBG5he+*9C$9=%wzz*X4CVnbp}1*}J0l%o5VELlRNC_*i)J9zEK9((Mh
zNt4hc5fNP+TD^KTuFtDgtHy&JYbC)P;T$)K%a#`Q9wcj8mpeVN(=gsCR*_jK_%S4BABCk2r+K
zD;O=YP0FYr5heDJ(IFal-+g!34jeczPzdT#dE35yJI2J+wKpDx+3J~z*)0q#d^+<0;VGDw9`(M)WUQmxrF&dJ4R43G#4o7_m5~f{q)ljG#Kh>-n=>F
zHf`D{SB~%~{}9+A%DW!%u()_q4V$ZCL%j@K1!W9p6^sf|0cyy@j5M^ACxTKjkZyuW&
zilN>GvGSgK?)lkgpHbZAPzOxzvBw^uAOEV6Va)r*gQPKI#^?_p;m{o(g_a$njO+2uH{WE_LNrwT
zM+-O~#*G_C^qFThJY;7qoseV{O)QRL?hTf=Y~H;2-h1!GWDgYMe*5j$v17;AUw<8O
z@hlS0I|`gQ#S_G0hbY&24DRCDv=9voIy&s*b=O@-beMBB3~6@g&><|%uy#pOVLtWt
z0}eO<1F8iNk1*PE+G(fhYD#vE2Z7ij%C#P`^pDL6-B5LLgn;?s1*Zz#f37rFu3Xu=
zb?b;s!wyNZ2=iIoj%(?*ZQFM3+7(j*F#oVvLA9iShaI9^>+$Qazh-knH&k65CSW=o
z)&bES@-(rw2qPPqw8=B4SYi1y#!SM}jBcm+57UYE%sUzui_%VvNO5JeLB~LTtx_att}5yNQWI4L`)#
zErjSlLX94=STn*c`%rNddJ8cq-C==dS=Qrs-+fn*CgbCK@4bh8Jc8vs#9q+Vu)xRa
z-mtQ?%Og=X22n7t7UeCU
z;vYIn-&QEUdc5ndyKG6&^|3mD$a$C=9!yL2-@wvo7e!%2i)-?S9(oAr|M=sNjEOf!
zpT&(jy|!|(H+hRK23?;RT{p3k%dZ}TwWwAkC}pg_s9n1@k@GM$Y+k1v+6vf8RQ~H6
z2F%!wlDzrmo1-VR7!B!-wj}8K^eA*q-M_6&jAH9n>6c$U;_-ya&Q`#jWZ^Il`fJ9F
z8MbkiJ~m$>_IL@Ysq7eni!>Q9lnD`!(zg}LuO8od=N(%Tls?v#3+oX-uk4W=EXX2u
zcWJ39dKrR?Oc^kg2@#Ldw-w5-9>4hF3tJMDKDJ&V5+0@|xmd+=p)j{4-LB|m2rd$5
zz)&VcJWAhID8G9A;fEh=Nl^NS9(pK|@G!Nfo_b1ovl6h{H_T_Lw_EX0pzI>|f)G|8
ziFmAh>dNI;kHO2=^c?9j=E4yP4^#W{%P;BSbWLpk80NFo+x0YUWf!^IV$k)8cytph
zx%}!;ve?jewst}9U}d@$`AQi(E2ccGT7cZ?N0lZ+Z~=?~LzxiqD1BR@{OVEiMgSt)
zVQP3;sxAM4{x{!z6XvrF+IgG=RxZ*{0S`Mwnbjknq_e4jq44(+^Fk%jOVl>DWF&dT
zI%g=PfQKET%<2&Z#ijy=jLy|f@csx%^b)nz88FI{yo?TojVa(^hw$~NQzz``2@@vh
z-YSS3OPYj-Smz9d6!5S^_*mP0%Rzc)g(j+{@I%g=PfQKEz*P~7yqjPnW<;$1r-YSBOnG8AuMp?px(V?(0
z1w4`vj5jh!2$4XIjhpTBjzxztvG0v<^S%(`SG#WTS>Jta_MgJxTglC44{v}9qi;)!11iR2npvDHxwjLWbYQ)YCo4mzl
z=T3qBhJ~h0o5rGIa{|Ly=M04u@JK>nK|T8|6}D_(R|*N#*l^j_BWT>XaU(Cm8*jWZ
zHakZO*usmqsRFi{rJOlDLINunDW`x(5(2h(bCZk23w)k<;)$4kAc0!ou=r!P^$0wZ
zCr{=j_{0-W6sMC;OT&f@d6?gL;|&Tzp7X$p;@?&$1w4`vupK&dsBKaV{ec4q3US5;
z&Ac9OxZws~j(D(6`K^g%fT6(dmpkvglM;?cNMJ?rZ>y669!Ut;;*~}zoDA~i53$T=
zUXR$bk=+*^J9dmsFmVN3tg_$j-mYCc3LZ8gFr@gm)ky)5Bt&2BQae8Aj9A2haJ{g-};tJ=Sa}EzJ?v(LH9ts|w|GWuYHC-7q
z&|)tGVtJq_oPGA$?C%Zys?tH~+1bjJL~M0zG3fflSh|Ts#w|?c%9V*hiE4Pv!G6Vz
zo=e}pePbi$q#oHfWkJ3pMvQQJ?*JO{MsmqZDsfF7+ZRef??hW!IZ05k#h~jGVdy48
zdHneC36^C2`t@-QCWI82AAR)Ev25g|99S$N21+c74t}+bQ3@LKQ;)dDkbf89U0vs$cV0n`?2nj-Bj1s7`}XaP8#lJXKsJ@d>n!??9-pEG9;eK6C=
z67CuvdE}98+qPN7H7eWwI0BE+53$jhjB-VHZ87Nj#3;InBYEY@m7_aix+(3#f5lp
z1uldnLj=*7>2s}x^%xDK_-JhJU>N=^ZfBt*__DYvewr*c@2z=qeLuU)$~=R8NlyY$ja70I?jwCCufwy`Ms
z(GjDMQv5?F+DYji9XD3V0+T
za%;PO{d(Kcyxi6!PNdGAJ0~^HnP!(^ixuL!s<2{_pbhgWX-@%k&9HX@@<9+a1plo>#0`Vf&S+cSj&c_>VnQ>`mSh8#F?J7(K#6?4cSpYAjy7
zI94rX1^V(jouZuABcS%`)vHu~C9#MD&uesgd9vip;YEzLN&$~BMBTb|SFKtlagwYp
z)+_Pe@{|91#HrG$Q>XmjOJcGgrXNS2*uh4==s+QnGs#ND#8mgb2eF@FW$YNs}h*4OJu<0$aSVO}Ngh
zgz6C|45kWT{^6D_TjbOw;sFaAuejohh%=dYNP>+QG1@8xJPC%t9LV(FV~9~lYgCc
zft3Q1eVL503K}u;|KNiU;(<#T2HW=1tw&@E@I8C>#PW>-mfU^BnjKs)W7kJpo~`sH
z_^kpFl~cguE(8|PEnT`);@@bCn?#(-1gA@W>3WrISQawy5qwg9g>ARZH=cpil<&sMx@w
ze!QMfxG$EXJrM9zambJ%wi|9JNIancgVje~#0p|{*kOlZHza&@+wS~;Cz~i|lwq@G
z&75*2tVgHV*v>IY=Blf%!ZLqM=(ReT17&QhJ89A+>@9%jS?+EUBeG*)RwfZ{{UOBw
z?l{`EZQG|$pJBs>p|5AooQdln-1y+P5APkoNZr(_Q*k*uV88&ZRd3$BIrcwPwoZkz
ztVhKdE>sRY@W2ioI$VGK^&>})#DhXGKY#vwJhWBJ&zLb|?AWo`u_4$%;GlyJQs!9+
zs<;?JR+xRMUVdQ60(^qnxuP?@BU)<;Z`0bh>^l9`k%Ra^`qDGc6ECJgv`%!Kyn
zpo}t9Cefb#(VR2j>oJENq>76nHe|27Eo{u%}dUF@zkZ;~~)*@byUNDm6_;87h<1
zK>9!~81VJzf>ohURa^`~7}}d>%Yd)PZ231vXOy8bF*@{(rNV%(#~k*QDlUeQ!*o0(
zIs?8Q>0G6z$tXi*;sWIM_bRdf=K@a|`}Fmg!_HO3#SmPi!!AY``adfMd_7vxm5wr_
z43&usguWhKuxj+_>(NL{wvDQ|7=jDrz8+n$YV_&r(MU_Sjf^r>CN7ZsdUV06(WkFR
zBQ4oBs^Ve@E|B|rbiu08r>{pNE!j3Q%21iOKqYRaa
z3*^2YU9f8O>Fd!*OSX-wxEO*9(NL{wvCK3R3L-Jm@&3csA!XsrHq!LrXr$}sH8=bnxa%BMny_PD@D^Xt&}NI5uvfP
zOj2oNv@nuXBQ#^OWNI42{Qs~2|31%s?sM+c=yLP?u$}4~I
zi(gc&T9pb%(r}ZBL7=z@@Byk_yLQ{QZST74E=2vc*IwJXbLV&8eU}v5qABP5@4w%(
zXU`jNyz%6dPmUfvny+okmM!^wA9Ktx#f8_DZV-?

Re: [edk2-devel] [edk2-non-osi] [PATCH V1 2/2] edk2-non-osi: Add CometlakeSiliconBinPkg maintainers

[Chaganty, Rangasai V]

Reviewed-by: Sai Chaganty 

-Original Message-
From: Desimone, Nathaniel L  
Sent: Wednesday, September 02, 2020 12:11 AM
To: devel@edk2.groups.io
Cc: Esakkithevar, Kathappan ; Chaganty, 
Rangasai V ; Chiu, Chasel 
Subject: [edk2-non-osi] [PATCH V1 2/2] edk2-non-osi: Add CometlakeSiliconBinPkg 
maintainers

Cc: Kathappan Esakkithevar 
Cc: Sai Chaganty 
Cc: Chasel Chiu 
Signed-off-by: Nate DeSimone 
---
 Maintainers.txt | 4 
 1 file changed, 4 insertions(+)

diff --git a/Maintainers.txt b/Maintainers.txt index 652243e..7355c66 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -49,6 +49,10 @@ Platform/Intel/CoffeelakeSiliconBinPkg
 M: Chasel Chiu 
 M: Sai Chaganty 
 
+Platform/Intel/CometlakeSiliconBinPkg
+M: Kathappan Esakkithevar 
+M: Sai Chaganty 
+
 Silicon/Intel/KabylakeSiliconBinPkg
 M: Chasel Chiu 
 M: Sai Chaganty 
--
2.27.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64980): https://edk2.groups.io/g/devel/message/64980
Mute This Topic: https://groups.io/mt/76577642/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Correcting EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT definition

[Paul]

[AMD Public Use]

Hi Lazlo,

Thanks for the feedback.  Noted, I'll spell it out in the future.  'Last 
initial' was habit from a team I used to work with.

Thanks,
Paul


-Original Message-
From: Laszlo Ersek  
Sent: Wednesday, September 2, 2020 1:58 AM
To: devel@edk2.groups.io; Grimes, Paul 
Cc: Michael D Kinney ; Liming Gao 
; Zhiguang Liu 
Subject: Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Correcting 
EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT definition

[CAUTION: External Email]

Hi Paul,

meta:

On 08/27/20 22:40, Paul wrote:
> In Acpi10.h, EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT is defined as 0x10, but 
> should be 0x02 per the ACPI Specification.
>
> REF:https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2F
> bugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2937&data=02%7C01%7Cp
> aul.grimes%40amd.com%7C51cbad882a354dd9f33108d84f1e5a56%7C3dd8961fe488
> 4e608e11a82d994e183d%7C0%7C0%7C637346339077687090&sdata=WT8dJXxJhK
> LhXU4qGObyYo3KN91WBs3%2FTesgkYdzssA%3D&reserved=0
>
> Cc: Michael D Kinney 
> Cc: Liming Gao 
> Cc: Zhiguang Liu 
> Signed-off-by: Paul G 
> ---
>  MdePkg/Include/IndustryStandard/Acpi10.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

please consider setting the "user.name" git config knob to your full name. We 
now have:

commit 5ffcbc46908a2037ae3260d3cfcc103e4a6a48c0
Author: Paul 
Date:   Fri Aug 28 04:40:51 2020 +0800

MdePkg: Correcting EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT definition

and I like to be friendly :) but I think the Author field should state, in 
general, the full name, not just the first name.


Similary, the Signed-off-by tag at the end of the commit message should carry 
the full name too. Please see section "Developer Certificate of Origin" in 
"ReadMe.rst":

"""
Signed-off-by: Developer Name develo...@example.org

where ``Developer Name`` is the contributor's real name, and the email address 
is one the developer is reachable through at the time of contributing.
"""

It's quite obvious from the email address that "Paul G" stands for Paul Grimes, 
but still spell it out.


(These requests are for the future, of course; the present patch has been 
merged.)

Thanks!
Laszlo

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64978): https://edk2.groups.io/g/devel/message/64978
Mute This Topic: https://groups.io/mt/76462757/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: 回复: [edk2-devel] 回复: [PATCH 1/1] .pytool/EccCheck: Enable Ecc error code 10014 for open CI

[gaoliming]

Laszlo:

> -邮件原件-
> 发件人: bounce+27952+64972+4905953+8761...@groups.io
>  代表 Laszlo Ersek
> 发送时间: 2020年9月2日 19:09
> 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn; 'Shenglei Zhang'
> ; af...@apple.com; 'Leif Lindholm'
> 
> 抄送: 'Sean Brogan' ; 'Bret Barkelew'
> ; 'Michael D Kinney'
> 
> 主题: Re: 回复: [edk2-devel] 回复: [PATCH 1/1] .pytool/EccCheck: Enable
> Ecc error code 10014 for open CI
> 
> Hi Liming, Shenglei,
> 
> On 09/02/20 11:36, gaoliming wrote:
> > Because the fix for ECC tool has been merged, I also request to catch this
> > change for stable202008 tag.
> 
> I'm OK with that, given that this patch modifies .pytool (that is, CI)
> --  in other words, I'm OK because the patch affects our workflow only,
> and doesn't really affect the edk2 codebase itself.
> 
> (Put differently, downstream parties that fork edk2 at
> edk2-stable202008, or rebase their current forks to edk2-stable202008,
> cannot be affected by this change in any way.)
> 
> However, I suggest a different approach for the patch itself (the end
> result will be the same, code-wise). Please start the patch by running:
> 
> $ git revert d4e0b9607c9a
> 
> and then please extend the commit message. It should be clear from the
> commit log (subject and first paragraph) that this patch is a revert.
> 

Good point. The patch is just a revert. It should include revert message. 

> Furthermore, TianoCore#2904 is in RESOLVED|FIXED status already. (And
> even the code comment, from the original patch, says: "need to be
> removed *after* BZ2904 is fixed" [emphasis mine] -- so this new patch,
> the revert, is not expected to be a part of BZ2904.)
> 
> So I suggest opening a new TianoCore BZ as well, making it *dependent*
> on 2904. And the revert should reference the new BZ.
> 

https://bugzilla.tianocore.org/show_bug.cgi?id=2951 is submitted for this 
issue. 

Thanks
Liming
> Again, I'm fine with merging this patch before the stable tag, I'd just
> like the BZ reference and the revert statement to be clean.
> 
> Thanks!
> Laszlo
> 
> >> -邮件原件-
> >> 发件人: bounce+27952+64967+4905953+8761...@groups.io
> >>  代表 gaoliming
> >> 发送时间: 2020年9月2日 17:06
> >> 收件人: 'Shenglei Zhang' ;
> devel@edk2.groups.io
> >> 抄送: 'Sean Brogan' ; 'Bret Barkelew'
> >> ; 'Michael D Kinney'
> >> 
> >> 主题: [edk2-devel] 回复: [PATCH 1/1] .pytool/EccCheck: Enable Ecc
> error
> >> code 10014 for open CI
> >>
> >> Reviewed-by: Liming Gao 
> >>
> >> Thanks
> >> Liming
> >>> -邮件原件-
> >>> 发件人: Shenglei Zhang 
> >>> 发送时间: 2020年9月2日 16:38
> >>> 收件人: devel@edk2.groups.io
> >>> 抄送: Sean Brogan ; Bret Barkelew
> >>> ; Michael D Kinney
> >>> ; Liming Gao 
> >>> 主题: [PATCH 1/1] .pytool/EccCheck: Enable Ecc error code 10014 for
> open
> >> CI
> >>>
> >>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2904
> >>> As the false positive issue whose error code is 10014 has been
> >>> fixed, we need to re-enable it on open CI.
> >>>
> >>> Cc: Sean Brogan 
> >>> Cc: Bret Barkelew 
> >>> Cc: Michael D Kinney 
> >>> Cc: Liming Gao 
> >>> Signed-off-by: Shenglei Zhang 
> >>> ---
> >>>  .pytool/Plugin/EccCheck/EccCheck.py | 1 -
> >>>  1 file changed, 1 deletion(-)
> >>>
> >>> diff --git a/.pytool/Plugin/EccCheck/EccCheck.py
> >>> b/.pytool/Plugin/EccCheck/EccCheck.py
> >>> index 3eaad0bf5623..eee1ff7a77b5 100644
> >>> --- a/.pytool/Plugin/EccCheck/EccCheck.py
> >>> +++ b/.pytool/Plugin/EccCheck/EccCheck.py
> >>> @@ -301,7 +301,6 @@ class EccCheck(ICiBuildPlugin):
> >>>   "10011",
> >>>   "10012",
> >>>   "10013",
> >>> - "10014", #need to be removed after
> >>> BZ2904 is fixed
> >>>   "10015",
> >>>   "10016",
> >>>   "10017",
> >>> --
> >>> 2.18.0.windows.1
> >>
> >>
> >>
> >>
> >>
> >
> >
> >
> >
> >
> >
> 
> 
> 




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64977): https://edk2.groups.io/g/devel/message/64977
Mute This Topic: https://groups.io/mt/76584100/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] RISC-V port on edk2

[Abner Chang]

Hi edk2 developers,
We are pleased to announce that the RISC-V edk2 port is upstream to TianoCore 
on both edk2 and edk2-platform repositories.
Please refer the https://github.com/riscv/riscv-uefi-edk2-docs for the details.

Thanks to the huge code review effort from Leif,  the suggestions of edk2 code 
structure from Mike K and Ray Ni,  and edk2 maintenance efforts from Liming and 
all component owners to make the success of this project.
I appreciate all of your helps on this. You are welcome to join the further 
developments and contribute to RISC-V edk2 port.
Thanks
Abner


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64976): https://edk2.groups.io/g/devel/message/64976
Mute This Topic: https://groups.io/mt/76582046/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH] edk2-test/uefi-sct: Added Reviewer in Maintainers.txt

[G Edhaya Chandran]

From: edhcha01 

Added Samer El-Haj-Mahmoud as a Reviewer of the patches

Cc: Samer El-Haj-Mahmoud 
Cc: Eric Jin 
Signed-off-by: G Edhaya Chandran 
---
 uefi-sct/Maintainers.txt | 4 
 1 file changed, 4 insertions(+)

diff --git a/uefi-sct/Maintainers.txt b/uefi-sct/Maintainers.txt
index 1ebf03fe..48fee345 100644
--- a/uefi-sct/Maintainers.txt
+++ b/uefi-sct/Maintainers.txt
@@ -12,6 +12,7 @@ Descriptions of section entries:
   L: Mailing list that is relevant to this area (default is utwg)
  Patches and questions should be sent to the email list.
   M: Cc address for patches and questions (ie, the maintainer)
+  R: Cc address for patches (ie, the reviewer)
   W: Web-page with status/info
   T: SCM tree type and location.  Type is one of: git, svn.
   S: Status, one of the following:
@@ -41,5 +42,8 @@ UEFI-SCT:
 M: Eric Jin 
 M: G Edhaya Chandran 
 
+R: Samer El-Haj-Mahmoud 
+
+
 General questions on UEFI-SCT with the subject [edk2-test] can be sent to
 L: edk2-list 
-- 
2.17.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64975): https://edk2.groups.io/g/devel/message/64975
Mute This Topic: https://groups.io/mt/76581633/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v3] MdeModulePkg/Library: add PEIM and SEC module type to TpmMeasurementLibNull

[Laszlo Ersek]

On 09/02/20 10:46, Wang, Jian J wrote:
> Reviewed-by: Jian J Wang 

Merged as commit e8453aa373e9, via
.

Thanks
Laszlo

>> -Original Message-
>> From: Zhang, Qi1 
>> Sent: Tuesday, September 01, 2020 3:26 PM
>> To: devel@edk2.groups.io
>> Cc: Zhang, Qi1 ; Wang, Jian J ;
>> Wu, Hao A ; Yao, Jiewen ;
>> Laszlo Ersek 
>> Subject: [PATCH v3] MdeModulePkg/Library: add PEIM and SEC module type to
>> TpmMeasurementLibNull
>>
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2940
>>
>> Signed-off-by: Qi Zhang 
>> Cc: Jian J Wang 
>> Cc: Hao A Wu 
>> Cc: Jiewen Yao 
>> Reviewed-by: Laszlo Ersek 
>> ---
>>  .../Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git
>> a/MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.in
>> f
>> b/MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.in
>> f
>> index 61abcfa2ec..c3be447d40 100644
>> ---
>> a/MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.in
>> f
>> +++
>> b/MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.in
>> f
>> @@ -12,7 +12,7 @@
>>FILE_GUID  = 6DFD6E9F-9278-48D8-8F45-B6CFF2C2B69C
>>
>>MODULE_TYPE= UEFI_DRIVER
>>
>>VERSION_STRING = 1.0
>>
>> -  LIBRARY_CLASS  = TpmMeasurementLib|DXE_DRIVER
>> DXE_RUNTIME_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER
>>
>> +  LIBRARY_CLASS  = TpmMeasurementLib|SEC PEIM DXE_DRIVER
>> DXE_RUNTIME_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER
>>
>>MODULE_UNI_FILE= TpmMeasurementLibNull.uni
>>
>>
>>
>>  #
>>
>> --
>> 2.26.2.windows.1
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64974): https://edk2.groups.io/g/devel/message/64974
Mute This Topic: https://groups.io/mt/76551779/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: 回复: [edk2-devel] 回复: [PATCH 1/1] .pytool/EccCheck: Enable Ecc error code 10014 for open CI

[Laszlo Ersek]

(request for Mike below)

On 09/02/20 13:08, Laszlo Ersek wrote:
> Hi Liming, Shenglei,
> 
> On 09/02/20 11:36, gaoliming wrote:
>> Because the fix for ECC tool has been merged, I also request to catch this
>> change for stable202008 tag. 
> 
> I'm OK with that, given that this patch modifies .pytool (that is, CI)
> --  in other words, I'm OK because the patch affects our workflow only,
> and doesn't really affect the edk2 codebase itself.
> 
> (Put differently, downstream parties that fork edk2 at
> edk2-stable202008, or rebase their current forks to edk2-stable202008,
> cannot be affected by this change in any way.)
> 
> However, I suggest a different approach for the patch itself (the end
> result will be the same, code-wise). Please start the patch by running:
> 
> $ git revert d4e0b9607c9a
> 
> and then please extend the commit message. It should be clear from the
> commit log (subject and first paragraph) that this patch is a revert.
> 
> Furthermore, TianoCore#2904 is in RESOLVED|FIXED status already. (And
> even the code comment, from the original patch, says: "need to be
> removed *after* BZ2904 is fixed" [emphasis mine] -- so this new patch,
> the revert, is not expected to be a part of BZ2904.)
> 
> So I suggest opening a new TianoCore BZ as well, making it *dependent*
> on 2904. And the revert should reference the new BZ.
> 
> Again, I'm fine with merging this patch before the stable tag, I'd just
> like the BZ reference and the revert statement to be clean.

... also wanted to mention that #2904 is a BaseTools BZ, but this revert
patch is for .pytool (CI).

In fact: Mike, can we please add ".pytool" or maybe "Core CI" to the
Package list in the TianoCore Bugzilla installation? The original BZ for
commit d4e0b9607c9a -- i.e., the one that's now being reverted -- says
"Package: N/A", and that's not really helpful.

Thanks!
Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64973): https://edk2.groups.io/g/devel/message/64973
Mute This Topic: https://groups.io/mt/76578692/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: 回复: [edk2-devel] 回复: [PATCH 1/1] .pytool/EccCheck: Enable Ecc error code 10014 for open CI

[Laszlo Ersek]

Hi Liming, Shenglei,

On 09/02/20 11:36, gaoliming wrote:
> Because the fix for ECC tool has been merged, I also request to catch this
> change for stable202008 tag. 

I'm OK with that, given that this patch modifies .pytool (that is, CI)
--  in other words, I'm OK because the patch affects our workflow only,
and doesn't really affect the edk2 codebase itself.

(Put differently, downstream parties that fork edk2 at
edk2-stable202008, or rebase their current forks to edk2-stable202008,
cannot be affected by this change in any way.)

However, I suggest a different approach for the patch itself (the end
result will be the same, code-wise). Please start the patch by running:

$ git revert d4e0b9607c9a

and then please extend the commit message. It should be clear from the
commit log (subject and first paragraph) that this patch is a revert.

Furthermore, TianoCore#2904 is in RESOLVED|FIXED status already. (And
even the code comment, from the original patch, says: "need to be
removed *after* BZ2904 is fixed" [emphasis mine] -- so this new patch,
the revert, is not expected to be a part of BZ2904.)

So I suggest opening a new TianoCore BZ as well, making it *dependent*
on 2904. And the revert should reference the new BZ.

Again, I'm fine with merging this patch before the stable tag, I'd just
like the BZ reference and the revert statement to be clean.

Thanks!
Laszlo

>> -邮件原件-
>> 发件人: bounce+27952+64967+4905953+8761...@groups.io
>>  代表 gaoliming
>> 发送时间: 2020年9月2日 17:06
>> 收件人: 'Shenglei Zhang' ; devel@edk2.groups.io
>> 抄送: 'Sean Brogan' ; 'Bret Barkelew'
>> ; 'Michael D Kinney'
>> 
>> 主题: [edk2-devel] 回复: [PATCH 1/1] .pytool/EccCheck: Enable Ecc error
>> code 10014 for open CI
>>
>> Reviewed-by: Liming Gao 
>>
>> Thanks
>> Liming
>>> -邮件原件-
>>> 发件人: Shenglei Zhang 
>>> 发送时间: 2020年9月2日 16:38
>>> 收件人: devel@edk2.groups.io
>>> 抄送: Sean Brogan ; Bret Barkelew
>>> ; Michael D Kinney
>>> ; Liming Gao 
>>> 主题: [PATCH 1/1] .pytool/EccCheck: Enable Ecc error code 10014 for open
>> CI
>>>
>>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2904
>>> As the false positive issue whose error code is 10014 has been
>>> fixed, we need to re-enable it on open CI.
>>>
>>> Cc: Sean Brogan 
>>> Cc: Bret Barkelew 
>>> Cc: Michael D Kinney 
>>> Cc: Liming Gao 
>>> Signed-off-by: Shenglei Zhang 
>>> ---
>>>  .pytool/Plugin/EccCheck/EccCheck.py | 1 -
>>>  1 file changed, 1 deletion(-)
>>>
>>> diff --git a/.pytool/Plugin/EccCheck/EccCheck.py
>>> b/.pytool/Plugin/EccCheck/EccCheck.py
>>> index 3eaad0bf5623..eee1ff7a77b5 100644
>>> --- a/.pytool/Plugin/EccCheck/EccCheck.py
>>> +++ b/.pytool/Plugin/EccCheck/EccCheck.py
>>> @@ -301,7 +301,6 @@ class EccCheck(ICiBuildPlugin):
>>>   "10011",
>>>   "10012",
>>>   "10013",
>>> - "10014", #need to be removed after
>>> BZ2904 is fixed
>>>   "10015",
>>>   "10016",
>>>   "10017",
>>> --
>>> 2.18.0.windows.1
>>
>>
>>
>>
>>
> 
> 
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64972): https://edk2.groups.io/g/devel/message/64972
Mute This Topic: https://groups.io/mt/76578692/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/3] SecurityPkg/DxeImageVerificationLib: catch alignment overflow (CVE-2019-14562)

[Laszlo Ersek]

On 09/02/20 08:41, Yao, Jiewen wrote:
> Yes. I recommend to merge to stable202008.

Merged in commit range 751355992635..0b143fa43e92, via
.

Thanks!
Laszlo

> 
>> -Original Message-
>> From: devel@edk2.groups.io  On Behalf Of Laszlo Ersek
>> Sent: Wednesday, September 2, 2020 2:35 PM
>> To: devel@edk2.groups.io; Yao, Jiewen 
>> Cc: Wang, Jian J ; Xu, Min M ;
>> Wenyi Xie ; Philippe Mathieu-Daudé
>> ; Liming Gao (Byosoft address)
>> 
>> Subject: Re: [edk2-devel] [PATCH 0/3] SecurityPkg/DxeImageVerificationLib:
>> catch alignment overflow (CVE-2019-14562)
>>
>> (+Liming, +Phil)
>>
>> On 09/02/20 06:02, Yao, Jiewen wrote:
>>> The series (1~3) is reviewed-by: Jiewen Yao 
>>
>> Thank you Everyone for the reviews and testing.
>>
>> Jiewen: do you think we should merge this series into the master branch
>> before edk2-stable202008? I think it qualifies (it is a CVE fix), but I
>> would like *you* to decide about it.
>>
>> Thanks
>> Laszlo
>>
>>>
>>> Thank you
>>> Yao Jiewen
>>>
 -Original Message-
 From: devel@edk2.groups.io  On Behalf Of Laszlo
>> Ersek
 Sent: Tuesday, September 1, 2020 5:12 PM
 To: edk2-devel-groups-io 
 Cc: Wang, Jian J ; Yao, Jiewen
>> ;
 Xu, Min M ; Wenyi Xie 
 Subject: [edk2-devel] [PATCH 0/3] SecurityPkg/DxeImageVerificationLib:
>> catch
 alignment overflow (CVE-2019-14562)

 Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=2215
 Repo:   https://pagure.io/lersek/edk2.git
 Branch: tianocore_2215

 I'm neutral on whether this becomes part of edk2-stable202008.

 Cc: Jian J Wang 
 Cc: Jiewen Yao 
 Cc: Min Xu 
 Cc: Wenyi Xie 

 Thanks,
 Laszlo

 Laszlo Ersek (3):
   SecurityPkg/DxeImageVerificationLib: extract SecDataDirEnd,
 SecDataDirLeft
   SecurityPkg/DxeImageVerificationLib: assign WinCertificate after size
 check
   SecurityPkg/DxeImageVerificationLib: catch alignment overflow
 (CVE-2019-14562)

  SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.c | 16
 
  1 file changed, 12 insertions(+), 4 deletions(-)

 --
 2.19.1.3.g30247aa5d201



>>>
>>>
>>>
>>>
>>
>>
>>
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64971): https://edk2.groups.io/g/devel/message/64971
Mute This Topic: https://groups.io/mt/76552538/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-non-osi] [PATCH V1 0/2] Add CometlakeSiliconBinPkg

[Kathappan Esakkithevar]

For this series, Reviewed-by: Kathappan Esakkithevar 


> -Original Message-
> From: Chiu, Chasel 
> Sent: Wednesday, September 2, 2020 12:52 PM
> To: Desimone, Nathaniel L ;
> devel@edk2.groups.io
> Cc: Esakkithevar, Kathappan ;
> Chaganty, Rangasai V 
> Subject: RE: [edk2-non-osi] [PATCH V1 0/2] Add CometlakeSiliconBinPkg
> 
> 
> For this series, Reviewed-by: Chasel Chiu 
> 
> 
> > -Original Message-
> > From: Desimone, Nathaniel L 
> > Sent: Wednesday, September 2, 2020 3:11 PM
> > To: devel@edk2.groups.io
> > Cc: Esakkithevar, Kathappan ;
> > Chaganty, Rangasai V ; Chiu, Chasel
> > 
> > Subject: [edk2-non-osi] [PATCH V1 0/2] Add CometlakeSiliconBinPkg
> >
> > Adds binary package for Comet Lake.
> >
> > Cc: Kathappan Esakkithevar 
> > Cc: Sai Chaganty 
> > Cc: Chasel Chiu 
> > Signed-off-by: Nate DeSimone 
> >
> > Nate DeSimone (2):
> >   CometlakeSiliconBinPkg: Add package contents
> >   edk2-non-osi: Add CometlakeSiliconBinPkg maintainers
> >
> >  Maintainers.txt   |   4 ++
> >  .../CnlPchLpChipsetInitTable_Dx.bin   | Bin 0 -> 4620 bytes
> >  .../Intel/CometlakeSiliconBinPkg/License.txt  |  30 ++
> >  .../Microcode/IntelMicrocodeLicense.txt   |  37
> > ++
> >  .../Microcode/MicrocodeUpdates.inf|  18 +
> >  .../Microcode/m94806EC_00D6.mcb   | Bin 0 -> 103424
> > bytes
> >  6 files changed, 89 insertions(+)
> >  create mode 100644
> > Silicon/Intel/CometlakeSiliconBinPkg/ChipsetInit/CnlPchLpChipsetInitTa
> > ble_D
> > x.bin
> >  create mode 100644 Silicon/Intel/CometlakeSiliconBinPkg/License.txt
> >  create mode 100644
> > Silicon/Intel/CometlakeSiliconBinPkg/Microcode/IntelMicrocodeLicense.t
> > xt
> >  create mode 100644
> > Silicon/Intel/CometlakeSiliconBinPkg/Microcode/MicrocodeUpdates.inf
> >  create mode 100644
> >
> Silicon/Intel/CometlakeSiliconBinPkg/Microcode/m94806EC_00D6.mcb
> >
> > --
> > 2.27.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64970): https://edk2.groups.io/g/devel/message/64970
Mute This Topic: https://groups.io/mt/76577641/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms] [PATCH V1] CometlakeOpenBoardPkg: Add usage of CometlakeSiliconBinPkg

[Kathappan Esakkithevar]

Reviewed-by: Kathappan Esakkithevar 

> -Original Message-
> From: Chiu, Chasel 
> Sent: Wednesday, September 2, 2020 1:29 PM
> To: Desimone, Nathaniel L ;
> devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Kethi Reddy,
> Deepika ; Esakkithevar, Kathappan
> 
> Subject: RE: [edk2-platforms] [PATCH V1] CometlakeOpenBoardPkg: Add
> usage of CometlakeSiliconBinPkg
> 
> 
> Reviewed-by: Chasel Chiu 
> 
> > -Original Message-
> > From: Desimone, Nathaniel L 
> > Sent: Wednesday, September 2, 2020 3:15 PM
> > To: devel@edk2.groups.io
> > Cc: Chiu, Chasel ; Chaganty, Rangasai V
> > ; Kethi Reddy, Deepika
> > ; Esakkithevar, Kathappan
> > 
> > Subject: [edk2-platforms] [PATCH V1] CometlakeOpenBoardPkg: Add usage
> > of CometlakeSiliconBinPkg
> >
> > Updates CometlakeOpenBoardPkg to use CometlakeSiliconBinPkg instead
> of
> > CoffeelakeSiliconBinPkg.
> >
> > Cc: Chasel Chiu 
> > Cc: Rangasai V Chaganty 
> > Cc: Deepika Kethi Reddy 
> > Cc: Kathappan Esakkithevar 
> > Signed-off-by: Nate DeSimone 
> > ---
> >  .../CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc | 5
> > +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git
> >
> a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.
> d
> > sc
> >
> b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.
> d
> > sc
> > index 2d9dcb139f..6de834565a 100644
> > ---
> >
> a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.
> d
> > sc
> > +++
> >
> b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.
> d
> > s
> > +++ c
> > @@ -10,7 +10,7 @@
> >  [Defines]
> >DEFINE  PLATFORM_PACKAGE  = MinPlatformPkg
> >DEFINE  PLATFORM_SI_PACKAGE   = CoffeelakeSiliconPkg
> > -  DEFINE  PLATFORM_SI_BIN_PACKAGE   = CoffeelakeSiliconBinPkg
> > +  DEFINE  PLATFORM_SI_BIN_PACKAGE   = CometlakeSiliconBinPkg
> >DEFINE  PLATFORM_FSP_BIN_PACKAGE  =
> > CometLakeFspBinPkg/CometLake1
> >DEFINE  PLATFORM_BOARD_PACKAGE=
> > CometlakeOpenBoardPkg
> >DEFINE  BOARD = CometlakeURvp
> > @@ -39,7 +39,8 @@
> >#
> ># Include PCD configuration for this board.
> >#
> > -  !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
> >
> > +  !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
> > +
> >!include OpenBoardPkgPcd.dsc
> >!include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
> >
> > --
> > 2.27.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64969): https://edk2.groups.io/g/devel/message/64969
Mute This Topic: https://groups.io/mt/76577729/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] 回复: [PATCH 1/1] .pytool/EccCheck: Enable Ecc error code 10014 for open CI

[gaoliming]

Because the fix for ECC tool has been merged, I also request to catch this
change for stable202008 tag. 

Thanks
Liming
> -邮件原件-
> 发件人: bounce+27952+64967+4905953+8761...@groups.io
>  代表 gaoliming
> 发送时间: 2020年9月2日 17:06
> 收件人: 'Shenglei Zhang' ; devel@edk2.groups.io
> 抄送: 'Sean Brogan' ; 'Bret Barkelew'
> ; 'Michael D Kinney'
> 
> 主题: [edk2-devel] 回复: [PATCH 1/1] .pytool/EccCheck: Enable Ecc error
> code 10014 for open CI
> 
> Reviewed-by: Liming Gao 
> 
> Thanks
> Liming
> > -邮件原件-
> > 发件人: Shenglei Zhang 
> > 发送时间: 2020年9月2日 16:38
> > 收件人: devel@edk2.groups.io
> > 抄送: Sean Brogan ; Bret Barkelew
> > ; Michael D Kinney
> > ; Liming Gao 
> > 主题: [PATCH 1/1] .pytool/EccCheck: Enable Ecc error code 10014 for open
> CI
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2904
> > As the false positive issue whose error code is 10014 has been
> > fixed, we need to re-enable it on open CI.
> >
> > Cc: Sean Brogan 
> > Cc: Bret Barkelew 
> > Cc: Michael D Kinney 
> > Cc: Liming Gao 
> > Signed-off-by: Shenglei Zhang 
> > ---
> >  .pytool/Plugin/EccCheck/EccCheck.py | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/.pytool/Plugin/EccCheck/EccCheck.py
> > b/.pytool/Plugin/EccCheck/EccCheck.py
> > index 3eaad0bf5623..eee1ff7a77b5 100644
> > --- a/.pytool/Plugin/EccCheck/EccCheck.py
> > +++ b/.pytool/Plugin/EccCheck/EccCheck.py
> > @@ -301,7 +301,6 @@ class EccCheck(ICiBuildPlugin):
> >   "10011",
> >   "10012",
> >   "10013",
> > - "10014", #need to be removed after
> > BZ2904 is fixed
> >   "10015",
> >   "10016",
> >   "10017",
> > --
> > 2.18.0.windows.1
> 
> 
> 
> 
> 




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64968): https://edk2.groups.io/g/devel/message/64968
Mute This Topic: https://groups.io/mt/76578692/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] 回复: [PATCH 1/1] .pytool/EccCheck: Enable Ecc error code 10014 for open CI

[gaoliming]

Reviewed-by: Liming Gao 

Thanks
Liming
> -邮件原件-
> 发件人: Shenglei Zhang 
> 发送时间: 2020年9月2日 16:38
> 收件人: devel@edk2.groups.io
> 抄送: Sean Brogan ; Bret Barkelew
> ; Michael D Kinney
> ; Liming Gao 
> 主题: [PATCH 1/1] .pytool/EccCheck: Enable Ecc error code 10014 for open
CI
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2904
> As the false positive issue whose error code is 10014 has been
> fixed, we need to re-enable it on open CI.
> 
> Cc: Sean Brogan 
> Cc: Bret Barkelew 
> Cc: Michael D Kinney 
> Cc: Liming Gao 
> Signed-off-by: Shenglei Zhang 
> ---
>  .pytool/Plugin/EccCheck/EccCheck.py | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/.pytool/Plugin/EccCheck/EccCheck.py
> b/.pytool/Plugin/EccCheck/EccCheck.py
> index 3eaad0bf5623..eee1ff7a77b5 100644
> --- a/.pytool/Plugin/EccCheck/EccCheck.py
> +++ b/.pytool/Plugin/EccCheck/EccCheck.py
> @@ -301,7 +301,6 @@ class EccCheck(ICiBuildPlugin):
>   "10011",
>   "10012",
>   "10013",
> - "10014", #need to be removed after
> BZ2904 is fixed
>   "10015",
>   "10016",
>   "10017",
> --
> 2.18.0.windows.1




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64967): https://edk2.groups.io/g/devel/message/64967
Mute This Topic: https://groups.io/mt/76578467/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Correcting EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT definition

[Laszlo Ersek]

Hi Paul,

meta:

On 08/27/20 22:40, Paul wrote:
> In Acpi10.h, EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT is defined as 0x10,
> but should be 0x02 per the ACPI Specification.
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2937
> 
> Cc: Michael D Kinney 
> Cc: Liming Gao 
> Cc: Zhiguang Liu 
> Signed-off-by: Paul G 
> ---
>  MdePkg/Include/IndustryStandard/Acpi10.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

please consider setting the "user.name" git config knob to your full
name. We now have:

commit 5ffcbc46908a2037ae3260d3cfcc103e4a6a48c0
Author: Paul 
Date:   Fri Aug 28 04:40:51 2020 +0800

MdePkg: Correcting EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT definition

and I like to be friendly :) but I think the Author field should state,
in general, the full name, not just the first name.


Similary, the Signed-off-by tag at the end of the commit message should
carry the full name too. Please see section "Developer Certificate of
Origin" in "ReadMe.rst":

"""
Signed-off-by: Developer Name develo...@example.org

where ``Developer Name`` is the contributor's real name, and the email
address is one the developer is reachable through at the time of
contributing.
"""

It's quite obvious from the email address that "Paul G" stands for Paul
Grimes, but still spell it out.


(These requests are for the future, of course; the present patch has
been merged.)

Thanks!
Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64966): https://edk2.groups.io/g/devel/message/64966
Mute This Topic: https://groups.io/mt/76462757/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH 0/3] SecurityPkg/DxeImageVerificationLib: catch alignment overflow (CVE-2019-14562)

[gaoliming]

Laszlo:
  I am ok to merge it as the security bug fix for this stable tag. 

Thanks
Liming
> -邮件原件-
> 发件人: Laszlo Ersek 
> 发送时间: 2020年9月2日 14:46
> 收件人: Yao, Jiewen ; devel@edk2.groups.io
> 抄送: Wang, Jian J ; Xu, Min M
> ; Wenyi Xie ; Philippe
> Mathieu-Daudé ; Liming Gao (Byosoft address)
> 
> 主题: Re: [edk2-devel] [PATCH 0/3] SecurityPkg/DxeImageVerificationLib:
> catch alignment overflow (CVE-2019-14562)
> 
> On 09/02/20 08:41, Yao, Jiewen wrote:
> > Yes. I recommend to merge to stable202008.
> 
> Thank you, I will do that soon.
> Laszlo
> 
> >
> >
> >> -Original Message-
> >> From: devel@edk2.groups.io  On Behalf Of Laszlo
> Ersek
> >> Sent: Wednesday, September 2, 2020 2:35 PM
> >> To: devel@edk2.groups.io; Yao, Jiewen 
> >> Cc: Wang, Jian J ; Xu, Min M
> ;
> >> Wenyi Xie ; Philippe Mathieu-Daudé
> >> ; Liming Gao (Byosoft address)
> >> 
> >> Subject: Re: [edk2-devel] [PATCH 0/3]
> SecurityPkg/DxeImageVerificationLib:
> >> catch alignment overflow (CVE-2019-14562)
> >>
> >> (+Liming, +Phil)
> >>
> >> On 09/02/20 06:02, Yao, Jiewen wrote:
> >>> The series (1~3) is reviewed-by: Jiewen Yao 
> >>
> >> Thank you Everyone for the reviews and testing.
> >>
> >> Jiewen: do you think we should merge this series into the master branch
> >> before edk2-stable202008? I think it qualifies (it is a CVE fix), but I
> >> would like *you* to decide about it.
> >>
> >> Thanks
> >> Laszlo
> >>
> >>>
> >>> Thank you
> >>> Yao Jiewen
> >>>
>  -Original Message-
>  From: devel@edk2.groups.io  On Behalf Of
> Laszlo
> >> Ersek
>  Sent: Tuesday, September 1, 2020 5:12 PM
>  To: edk2-devel-groups-io 
>  Cc: Wang, Jian J ; Yao, Jiewen
> >> ;
>  Xu, Min M ; Wenyi Xie
> 
>  Subject: [edk2-devel] [PATCH 0/3] SecurityPkg/DxeImageVerificationLib:
> >> catch
>  alignment overflow (CVE-2019-14562)
> 
>  Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=2215
>  Repo:   https://pagure.io/lersek/edk2.git
>  Branch: tianocore_2215
> 
>  I'm neutral on whether this becomes part of edk2-stable202008.
> 
>  Cc: Jian J Wang 
>  Cc: Jiewen Yao 
>  Cc: Min Xu 
>  Cc: Wenyi Xie 
> 
>  Thanks,
>  Laszlo
> 
>  Laszlo Ersek (3):
>    SecurityPkg/DxeImageVerificationLib: extract SecDataDirEnd,
>  SecDataDirLeft
>    SecurityPkg/DxeImageVerificationLib: assign WinCertificate after size
>  check
>    SecurityPkg/DxeImageVerificationLib: catch alignment overflow
>  (CVE-2019-14562)
> 
> 
> SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.c | 16
>  
>   1 file changed, 12 insertions(+), 4 deletions(-)
> 
>  --
>  2.19.1.3.g30247aa5d201
> 
> 
> 
> >>>
> >>>
> >>>
> >>>
> >>
> >>
> >> 
> >




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64965): https://edk2.groups.io/g/devel/message/64965
Mute This Topic: https://groups.io/mt/76578406/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] Basetools as a pip module

[Laszlo Ersek]

On 09/02/20 02:49, Andrew Fish via groups.io wrote:
> 
> 
>> On Sep 1, 2020, at 4:35 PM, Matthew Carlson  
>> wrote:
>>
>> Hello all,
>>
>> A recent topic on the RFC mailing list went out and the work on moving 
>> Basetools/Sources/Python to a separate repo has started. See the RFC 
>> conversation here: https://edk2.groups.io/g/rfc/topic/74009714#270 
>> 
>>
>> The repo in question is here: https://github.com/tianocore/edk2-basetools 
>> 
>>
>> The current plan is shortly after the stable tag is created, a series of 
>> patches will come into edk2 that redirects the build system into the new 
>> python module as well as adds additional documentation. You can see a sample 
>> of this work here: https://github.com/matthewfcarlson/edk2 
>>  as this has a branch that has the 
>> work required to use the basetools pip module. The patches won't delete the 
>> Basetools/Sources/Python folder but will allow users to select between them. 
>> After a certain grace period, the python folder will be deleted and the pip 
>> module will be the de facto way of using basetools.
>>
>> Three questions need to be answered:
>>
>> 1. After the patches that enable the pip module land, how long should the 
>> grace period be?
>> 2. During the grace period, should basetools commits land in both places or 
>> just in the edk2-basetools directory?
>> 3. How should the user be able to select which basetools to use (the one in 
>> EDK2 or the pip module)? Currently the approach being considered is a simple 
>> environmental variable? One of the key considerations is transparency since 
>> it won't be apparent what is being used for a particular build without some 
>> sort of mechanism to notify the developer. With two seperate versions of 
>> Basetools, it becomes very easy for the version of basetools you're using to 
>> not be the one you expect.
>>
> 
> Matthew,
> 
> I’ll throw out some current developer centric ideas. 
> 
> 1) If you `source edksetup.sh` (edksetup.bat) you get the current behavior, 
> and you add an argument you get the pip flavor? So maybe `edksetup.bat 
> pip-basetools`?
> 2) We have similar issues to this with env variables and the build command 
> dumps them out when it runs. Can we use the current EDK_TOOL_PATH? Or maybe 
> add an extra print to show that the pip module is being used?

I've skimmed:

- the earlier discussion linked above (rooted at 
),

- the even earlier comments in the "Discussion: Basetools a separate repo" 
thread on edk2-devel:

  https://edk2.groups.io/g/devel/message/57482
  
http://mid.mail-archive.com/734D49CCEBEEF84792F5B80ED585239D5C5019CE@SHSMSX104.ccr.corp.intel.com

If I still understand / remember correctly, the way at least *I* would use the 
new feature is the following:

- set up a new virtual python environment,

- either install the new pip module "permanently" in the virtual environment, 
or else install it in "editable mode" from a git checkout (but *still* in the 
virtual environment)

- build edk2 with the virtual environment active

That is, for me anyway, the key distinguishing factor would be that I'd be in a 
python virtual environment where this particular python module existed / were 
installed.

Does this answer question (3)? Because, in my case anyway, I wouldn't have to 
be *notified* about using the separate basetools repo vs. using the one 
resident in edk2 -- instead, I'd have to *activate* the separate basetools repo 
myself, as first step. So if that activation brings some queriable feature into 
the environment (sets a new environment variable or makes a new python package 
appear in the environment), then I think it's good enough -- the usual tools 
that I run then can query these artifacts.

In short (I guess): commands should use the in-tree variant, unless I activate 
the virtual environment that has the basetools PIP module installed.

I think it would be fine to require that, *if* someone intends to activate such 
a python virtual environment, *then* they do so *before* running "edksetup.sh". 
So "edksetup.sh" could check for the python env having the external basetools 
repo / module active. Hopefully that would be "early enough".


Regarding the grace period -- questions (1) and (2):

- The patches introducing the new feature to edk2 should be posted to the list. 
These patches should also add a warning to "edksetup.sh" that urges the 
developer to use the out-of-tree basetools repo / PIP module, in case 
"edksetup.sh" determines the current choice is the in-tree variant (that is, 
the virtual env is inactive, or does not contain the new PIP module)

- While the patches are pending approval, BaseTools development is put on hold 
(no fixes, no features).

- For every package (subsystem) listed in Maintainers.txt, in *both* edk2 *and* 
edk2-platfomrs, at least one "M" per

Re: [edk2-devel] [PATCH v3] MdeModulePkg/Library: add PEIM and SEC module type to TpmMeasurementLibNull

[Wang, Jian J]

Reviewed-by: Jian J Wang 

Regards,
Jian

> -Original Message-
> From: Zhang, Qi1 
> Sent: Tuesday, September 01, 2020 3:26 PM
> To: devel@edk2.groups.io
> Cc: Zhang, Qi1 ; Wang, Jian J ;
> Wu, Hao A ; Yao, Jiewen ;
> Laszlo Ersek 
> Subject: [PATCH v3] MdeModulePkg/Library: add PEIM and SEC module type to
> TpmMeasurementLibNull
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2940
> 
> Signed-off-by: Qi Zhang 
> Cc: Jian J Wang 
> Cc: Hao A Wu 
> Cc: Jiewen Yao 
> Reviewed-by: Laszlo Ersek 
> ---
>  .../Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git
> a/MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.in
> f
> b/MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.in
> f
> index 61abcfa2ec..c3be447d40 100644
> ---
> a/MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.in
> f
> +++
> b/MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.in
> f
> @@ -12,7 +12,7 @@
>FILE_GUID  = 6DFD6E9F-9278-48D8-8F45-B6CFF2C2B69C
> 
>MODULE_TYPE= UEFI_DRIVER
> 
>VERSION_STRING = 1.0
> 
> -  LIBRARY_CLASS  = TpmMeasurementLib|DXE_DRIVER
> DXE_RUNTIME_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER
> 
> +  LIBRARY_CLASS  = TpmMeasurementLib|SEC PEIM DXE_DRIVER
> DXE_RUNTIME_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER
> 
>MODULE_UNI_FILE= TpmMeasurementLibNull.uni
> 
> 
> 
>  #
> 
> --
> 2.26.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64963): https://edk2.groups.io/g/devel/message/64963
Mute This Topic: https://groups.io/mt/76551779/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 1/1] .pytool/EccCheck: Enable Ecc error code 10014 for open CI

[Zhang, Shenglei]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2904
As the false positive issue whose error code is 10014 has been
fixed, we need to re-enable it on open CI.

Cc: Sean Brogan 
Cc: Bret Barkelew 
Cc: Michael D Kinney 
Cc: Liming Gao 
Signed-off-by: Shenglei Zhang 
---
 .pytool/Plugin/EccCheck/EccCheck.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/.pytool/Plugin/EccCheck/EccCheck.py 
b/.pytool/Plugin/EccCheck/EccCheck.py
index 3eaad0bf5623..eee1ff7a77b5 100644
--- a/.pytool/Plugin/EccCheck/EccCheck.py
+++ b/.pytool/Plugin/EccCheck/EccCheck.py
@@ -301,7 +301,6 @@ class EccCheck(ICiBuildPlugin):
  "10011",
  "10012",
  "10013",
- "10014", #need to be removed after BZ2904 is fixed
  "10015",
  "10016",
  "10017",
-- 
2.18.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64962): https://edk2.groups.io/g/devel/message/64962
Mute This Topic: https://groups.io/mt/76578291/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms] [PATCH V1] CometlakeOpenBoardPkg: Add usage of CometlakeSiliconBinPkg

[Chiu, Chasel]

Reviewed-by: Chasel Chiu 

> -Original Message-
> From: Desimone, Nathaniel L 
> Sent: Wednesday, September 2, 2020 3:15 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Chaganty, Rangasai V
> ; Kethi Reddy, Deepika
> ; Esakkithevar, Kathappan
> 
> Subject: [edk2-platforms] [PATCH V1] CometlakeOpenBoardPkg: Add usage of
> CometlakeSiliconBinPkg
> 
> Updates CometlakeOpenBoardPkg to use CometlakeSiliconBinPkg instead of
> CoffeelakeSiliconBinPkg.
> 
> Cc: Chasel Chiu 
> Cc: Rangasai V Chaganty 
> Cc: Deepika Kethi Reddy 
> Cc: Kathappan Esakkithevar 
> Signed-off-by: Nate DeSimone 
> ---
>  .../CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc | 5
> +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git
> a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.d
> sc
> b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.d
> sc
> index 2d9dcb139f..6de834565a 100644
> ---
> a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.d
> sc
> +++
> b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.d
> s
> +++ c
> @@ -10,7 +10,7 @@
>  [Defines]
>DEFINE  PLATFORM_PACKAGE  = MinPlatformPkg
>DEFINE  PLATFORM_SI_PACKAGE   = CoffeelakeSiliconPkg
> -  DEFINE  PLATFORM_SI_BIN_PACKAGE   = CoffeelakeSiliconBinPkg
> +  DEFINE  PLATFORM_SI_BIN_PACKAGE   = CometlakeSiliconBinPkg
>DEFINE  PLATFORM_FSP_BIN_PACKAGE  =
> CometLakeFspBinPkg/CometLake1
>DEFINE  PLATFORM_BOARD_PACKAGE=
> CometlakeOpenBoardPkg
>DEFINE  BOARD = CometlakeURvp
> @@ -39,7 +39,8 @@
>#
># Include PCD configuration for this board.
>#
> -  !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
> 
> +  !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
> +
>!include OpenBoardPkgPcd.dsc
>!include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
> 
> --
> 2.27.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64961): https://edk2.groups.io/g/devel/message/64961
Mute This Topic: https://groups.io/mt/76577729/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Add check for CR3/GDT/IDT.

[Laszlo Ersek]

Hi Eric,

On 09/02/20 02:43, Dong, Eric wrote:
> AP needs to run from real mode to 32bit mode to LONG mode. Page table
> (pointed by CR3) and GDT are necessary to set up to correct value when
> CPU execution mode is switched to LONG mode.
> AP uses the same location page table (CR3) and GDT as what BSP uses.
> But when the page table or GDT is above 4GB, it's impossible for CPU
> to use because GDTR.base and CR3 are 32bits before switching to LONG
> mode.
> This patch adds check for the CR3, GDT.Base and IDT.Base to not above
> 32 bits restriction.
> 
> Signed-off-by: Eric Dong 
> Cc: Ray Ni 
> Cc: Laszlo Ersek 
> ---
>  UefiCpuPkg/Library/MpInitLib/DxeMpLib.c |   8 +-
>  UefiCpuPkg/Library/MpInitLib/MpLib.c| 108 +++-
>  UefiCpuPkg/Library/MpInitLib/MpLib.h|   6 +-
>  3 files changed, 97 insertions(+), 25 deletions(-)

(1) This is not for edk2-stable202008, correct?


(2) If I understand correctly, this patch does not solve the problem
when any one of the IDT, GDT, and CR3, are out of 32-bit address space.
Instead, the patch makes the failure symptoms more graceful.

Is that correct?

If so, can you explain in the commit message what happens without the
patch, versus with the patch, when the IDT / GDT / CR3 are out of 32-bit
address space?

Like, if we abandon MpInitChangeApLoopCallback() mid-way, then (AIUI)
the AP "pen" (HLT loop) will not be relocated to reserved memory at
ExitBootServces(). I don't think that simply giving up can end well for
the OS!


(3) Can you remind us in the commit message where the IDT / GDT / page
tables are actually allocated? That is, can you please name the
component that is usually responsible for keeping the allocations in the
32-bit address space?

And once we know where the IDT / GDT / page tables come from --
shouldn't we rather modify those modules, to allocate IDT / GDT / page
tables in the 32-bit address space?

More below:

> diff --git a/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c 
> b/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
> index 2c00d72dde..27f12a75a8 100644
> --- a/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
> +++ b/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
> @@ -393,13 +393,19 @@ MpInitChangeApLoopCallback (
>)
>  {
>CPU_MP_DATA   *CpuMpData;
> +  EFI_STATUSStatus;
>  
>CpuMpData = GetCpuMpData ();
>CpuMpData->PmCodeSegment = GetProtectedModeCS ();
>CpuMpData->Pm16CodeSegment = GetProtectedMode16CS ();
>CpuMpData->ApLoopMode = PcdGet8 (PcdCpuApLoopMode);
>mNumberToFinish = CpuMpData->CpuCount - 1;
> -  WakeUpAP (CpuMpData, TRUE, 0, RelocateApLoop, NULL, TRUE);
> +  Status = WakeUpAP (CpuMpData, TRUE, 0, RelocateApLoop, NULL, TRUE);
> +  if (EFI_ERROR (Status)) {
> +DEBUG ((DEBUG_ERROR, "ERROR :: %a() Change Ap Loop Mode failed!\n", 
> __FUNCTION__));
> +return;
> +  }
> +
>while (mNumberToFinish > 0) {
>  CpuPause ();
>}
> diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c 
> b/UefiCpuPkg/Library/MpInitLib/MpLib.c
> index 07426274f6..21b17a7b40 100644
> --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c
> +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c
> @@ -470,7 +470,7 @@ GetProcessorNumber (
>  
>@return  CPU count detected
>  **/
> -UINTN
> +EFI_STATUS
>  CollectProcessorCount (
>IN CPU_MP_DATA *CpuMpData
>)
> @@ -478,12 +478,17 @@ CollectProcessorCount (
>UINTN  Index;
>CPU_INFO_IN_HOB*CpuInfoInHob;
>BOOLEANX2Apic;
> +  EFI_STATUS Status;
>  
>//
>// Send 1st broadcast IPI to APs to wakeup APs
>//
>CpuMpData->InitFlag = ApInitConfig;
> -  WakeUpAP (CpuMpData, TRUE, 0, NULL, NULL, TRUE);
> +  Status = WakeUpAP (CpuMpData, TRUE, 0, NULL, NULL, TRUE);
> +  if (EFI_ERROR (Status)) {
> +return Status;
> +  }
> +
>CpuMpData->InitFlag = ApInitDone;
>ASSERT (CpuMpData->CpuCount <= PcdGet32 (PcdCpuMaxLogicalProcessorNumber));
>//
> @@ -520,7 +525,11 @@ CollectProcessorCount (
>  //
>  // Wakeup all APs to enable x2APIC mode
>  //
> -WakeUpAP (CpuMpData, TRUE, 0, ApFuncEnableX2Apic, NULL, TRUE);
> +Status = WakeUpAP (CpuMpData, TRUE, 0, ApFuncEnableX2Apic, NULL, TRUE);
> +if (EFI_ERROR (Status)) {
> +  return Status;
> +}
> +
>  //
>  // Wait for all known APs finished
>  //
> @@ -546,7 +555,7 @@ CollectProcessorCount (
>  
>DEBUG ((DEBUG_INFO, "MpInitLib: Find %d processors in system.\n", 
> CpuMpData->CpuCount));
>  
> -  return CpuMpData->CpuCount;
> +  return EFI_SUCCESS;
>  }
>  
>  /**
> @@ -990,7 +999,7 @@ WaitApWakeup (
>@param[in] CpuMpData  Pointer to CPU MP Data
>  
>  **/
> -VOID
> +EFI_STATUS
>  FillExchangeInfoData (
>IN CPU_MP_DATA   *CpuMpData
>)
> @@ -1001,6 +1010,35 @@ FillExchangeInfoData (
>IA32_CR4 Cr4;
>  
>ExchangeInfo  = CpuMpData->MpCpuExchangeInfo;
> +  ExchangeInfo->Cr3 = AsmReadCr3 ();
> +  if (ExchangeInfo

Re: [edk2-devel] [edk2-non-osi] [PATCH V1 0/2] Add CometlakeSiliconBinPkg

[Chiu, Chasel]

For this series, Reviewed-by: Chasel Chiu 


> -Original Message-
> From: Desimone, Nathaniel L 
> Sent: Wednesday, September 2, 2020 3:11 PM
> To: devel@edk2.groups.io
> Cc: Esakkithevar, Kathappan ; Chaganty,
> Rangasai V ; Chiu, Chasel
> 
> Subject: [edk2-non-osi] [PATCH V1 0/2] Add CometlakeSiliconBinPkg
> 
> Adds binary package for Comet Lake.
> 
> Cc: Kathappan Esakkithevar 
> Cc: Sai Chaganty 
> Cc: Chasel Chiu 
> Signed-off-by: Nate DeSimone 
> 
> Nate DeSimone (2):
>   CometlakeSiliconBinPkg: Add package contents
>   edk2-non-osi: Add CometlakeSiliconBinPkg maintainers
> 
>  Maintainers.txt   |   4 ++
>  .../CnlPchLpChipsetInitTable_Dx.bin   | Bin 0 -> 4620 bytes
>  .../Intel/CometlakeSiliconBinPkg/License.txt  |  30 ++
>  .../Microcode/IntelMicrocodeLicense.txt   |  37
> ++
>  .../Microcode/MicrocodeUpdates.inf|  18 +
>  .../Microcode/m94806EC_00D6.mcb   | Bin 0 -> 103424
> bytes
>  6 files changed, 89 insertions(+)
>  create mode 100644
> Silicon/Intel/CometlakeSiliconBinPkg/ChipsetInit/CnlPchLpChipsetInitTable_D
> x.bin
>  create mode 100644 Silicon/Intel/CometlakeSiliconBinPkg/License.txt
>  create mode 100644
> Silicon/Intel/CometlakeSiliconBinPkg/Microcode/IntelMicrocodeLicense.txt
>  create mode 100644
> Silicon/Intel/CometlakeSiliconBinPkg/Microcode/MicrocodeUpdates.inf
>  create mode 100644
> Silicon/Intel/CometlakeSiliconBinPkg/Microcode/m94806EC_00D6.mcb
> 
> --
> 2.27.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64957): https://edk2.groups.io/g/devel/message/64957
Mute This Topic: https://groups.io/mt/76577641/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-platforms] [PATCH V1] CometlakeOpenBoardPkg: Add usage of CometlakeSiliconBinPkg

[Nate DeSimone]

Updates CometlakeOpenBoardPkg to use CometlakeSiliconBinPkg
instead of CoffeelakeSiliconBinPkg.

Cc: Chasel Chiu 
Cc: Rangasai V Chaganty 
Cc: Deepika Kethi Reddy 
Cc: Kathappan Esakkithevar 
Signed-off-by: Nate DeSimone 
---
 .../CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git 
a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc 
b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
index 2d9dcb139f..6de834565a 100644
--- a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
+++ b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
@@ -10,7 +10,7 @@
 [Defines]
   DEFINE  PLATFORM_PACKAGE  = MinPlatformPkg
   DEFINE  PLATFORM_SI_PACKAGE   = CoffeelakeSiliconPkg
-  DEFINE  PLATFORM_SI_BIN_PACKAGE   = CoffeelakeSiliconBinPkg
+  DEFINE  PLATFORM_SI_BIN_PACKAGE   = CometlakeSiliconBinPkg
   DEFINE  PLATFORM_FSP_BIN_PACKAGE  = CometLakeFspBinPkg/CometLake1
   DEFINE  PLATFORM_BOARD_PACKAGE= CometlakeOpenBoardPkg
   DEFINE  BOARD = CometlakeURvp
@@ -39,7 +39,8 @@
   #
   # Include PCD configuration for this board.
   #
-  !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc

+  !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
+
   !include OpenBoardPkgPcd.dsc
   !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
 
-- 
2.27.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64956): https://edk2.groups.io/g/devel/message/64956
Mute This Topic: https://groups.io/mt/76577729/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-non-osi] [PATCH V1 0/2] Add CometlakeSiliconBinPkg

[Nate DeSimone]

Adds binary package for Comet Lake.

Cc: Kathappan Esakkithevar 
Cc: Sai Chaganty 
Cc: Chasel Chiu 
Signed-off-by: Nate DeSimone 

Nate DeSimone (2):
  CometlakeSiliconBinPkg: Add package contents
  edk2-non-osi: Add CometlakeSiliconBinPkg maintainers

 Maintainers.txt   |   4 ++
 .../CnlPchLpChipsetInitTable_Dx.bin   | Bin 0 -> 4620 bytes
 .../Intel/CometlakeSiliconBinPkg/License.txt  |  30 ++
 .../Microcode/IntelMicrocodeLicense.txt   |  37 ++
 .../Microcode/MicrocodeUpdates.inf|  18 +
 .../Microcode/m94806EC_00D6.mcb   | Bin 0 -> 103424 bytes
 6 files changed, 89 insertions(+)
 create mode 100644 
Silicon/Intel/CometlakeSiliconBinPkg/ChipsetInit/CnlPchLpChipsetInitTable_Dx.bin
 create mode 100644 Silicon/Intel/CometlakeSiliconBinPkg/License.txt
 create mode 100644 
Silicon/Intel/CometlakeSiliconBinPkg/Microcode/IntelMicrocodeLicense.txt
 create mode 100644 
Silicon/Intel/CometlakeSiliconBinPkg/Microcode/MicrocodeUpdates.inf
 create mode 100644 
Silicon/Intel/CometlakeSiliconBinPkg/Microcode/m94806EC_00D6.mcb

-- 
2.27.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64954): https://edk2.groups.io/g/devel/message/64954
Mute This Topic: https://groups.io/mt/76577641/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-non-osi] [PATCH V1 1/2] CometlakeSiliconBinPkg: Add package contents

[Nate DeSimone]

Create the CometlakeSiliconBinPkg to contain binary files
needed by CoffeelakeSiliconPkg to support Comet Lake (CML)
generation products.

Cc: Kathappan Esakkithevar 
Cc: Sai Chaganty 
Cc: Chasel Chiu 
Signed-off-by: Nate DeSimone 
---
 .../CnlPchLpChipsetInitTable_Dx.bin   | Bin 0 -> 4620 bytes
 .../Intel/CometlakeSiliconBinPkg/License.txt  |  30 ++
 .../Microcode/IntelMicrocodeLicense.txt   |  37 ++
 .../Microcode/MicrocodeUpdates.inf|  18 +
 .../Microcode/m94806EC_00D6.mcb   | Bin 0 -> 103424 bytes
 5 files changed, 85 insertions(+)
 create mode 100644 
Silicon/Intel/CometlakeSiliconBinPkg/ChipsetInit/CnlPchLpChipsetInitTable_Dx.bin
 create mode 100644 Silicon/Intel/CometlakeSiliconBinPkg/License.txt
 create mode 100644 
Silicon/Intel/CometlakeSiliconBinPkg/Microcode/IntelMicrocodeLicense.txt
 create mode 100644 
Silicon/Intel/CometlakeSiliconBinPkg/Microcode/MicrocodeUpdates.inf
 create mode 100644 
Silicon/Intel/CometlakeSiliconBinPkg/Microcode/m94806EC_00D6.mcb

diff --git 
a/Silicon/Intel/CometlakeSiliconBinPkg/ChipsetInit/CnlPchLpChipsetInitTable_Dx.bin
 
b/Silicon/Intel/CometlakeSiliconBinPkg/ChipsetInit/CnlPchLpChipsetInitTable_Dx.bin
new file mode 100644
index 
..be213b9f3747a297ecb67f2da233097967aafde3
GIT binary patch
literal 4620
zcmZvgPiS1%6~@2!M>B6mBhNT>BE_Csl97$~afv{)kU?%mIv6cPVwx$@!lkYe
zty{b>c%;ZzYLSKd#+epkuoeoqi5G6kA`8<@!37sw;xvJ7N-K&Q4AsI5Qv#K(e&^gf
zSF@;AKOcYhocrf}_gtwI?eM3!Fopy`=DpIzy+1*b_@^3n7DZ5%^
zUyJN(k$q0pyPV1{=lhZ~uGfHpVP&@#WtX4q^OIfvdC^B)OPmCW9eZnTKQ~I)*ChvV
zb(LM+4?5~9ySmD*F4@;5%f3aKAU~|}U(a!SAna?AeJy2MOO9^%LKY!PF-BTh;Rtcu
z*N2vH76o#I;UB3cibq-*VQL}{Z3$Bo?P{v=u4X(|%@6HZ$}_`c8LRopb}Z+hni1w~
zYlb>B$Az7y+MyZm&`es5&hw7d=sedu=6PG#t#{R~Mc2DvHM-tqGS^EEai>G$@~B4g
zwD)ATV^3ym9^I4k9eGL-O0C%Kt(~*xk$nr?-ae#eBXIj1@A6|Gk8m$4mF%9&8SV0>
zjq98rM=@Gmw$^4xtu1nU&Lf@qJI-sfrI!39`t$0
zK991?qZ*fo?DKpe^RDh(sFzCOJD#eY8#%=CQzZQZHa_(+b+M03m+TYt;X}YdC>FKIl+KGXl!Kx8%L
z<}_Z_oB_%!w;abf+dP(xxmvU4^?y|=qK|QDMbFE!>ELFYi-@nE3Wj3QC#W{Z#>SMh
zST@s@SaXILSiywdLvpi&4JO;?d&7YLkUaEyGskXd=Nzx(a-Pk%9OnUpTW3_mx`uVT
z?ARHDDVsAvi#eCxka&pl0$QlqoM+9kq^4tI+&9&wYZ{Mm+icbB*c{4+`*XqSSIxvo
z^{19kE?jZnWQYyJO-dxr@A;~J&*VI&O>XVwIf-Ym+`K%HXsrxBH?8`-mhbsNuN
z%7kcXo;)s^(>wKRGB(7;74nMX<}Ra&qi1q9jurgCat}65wX6GvjgKybH|<)oIBxQ#
zyw;5{WVUN3-WN>|&Y5HL_(-@5=bD-MKsm&SskZQYiRUr3f}o{iyD`-a9S10xHyszT
zW$w8>2{5p5_=Rkbox>A@J$4SfH1f5`!yf63mn8h1V=M{wR$jq|2u>rJxv9ohTNvh|wko!7{G
z?^%CYw*De}f04bv$Pt{sH17OG_WmLVaQ-5Df04bv$lhP7cm7g#{vvySk-fjj-d|+z
zDP`v=viFqgou|m&Q_9XeWbYk~JMWOacgWs5s(0Q|z4Hs%`-SX1LiQffxbp~^{l$7j
zHO?cJtuM&l7i8}XviAkq`+|M5h`vP>5J(R#U}*8sp(EO(v)VV=`xqyur~ho(dqm^T
zBV>ANaVKGCSKhb!)jwjd9m{XHwO8W_Y9>MQ6|0$S{O!9|A7c9Iz(Mv(j?JL5n8!a~
zuw%y?Un}?N*rNEocTMM$;E};Z?|#t~@F>N^5oPwN#pud`0}|&QX;4~HF3MeZs=I7+
zuBQhN9(40rOSfk02PK~Hj@k+CD;JTZ)lavyRuMyuZ=U>Jzi9TL(#YfA$}!^AaSUpn
z0?Li(%HW`AiYPStH`>g8{gC}y^Sgdc&R{0RRH$P^Of~9``QNc|D?vn
zgI`bB>lvrl(l1Mv3%H-M-;GL~n$_mr{xMy1!$2=9iPT$w}b=h4hPe
z+0)7X&LQXUAU)jM`-auKKCYVcDTd;j#EUrF7#|-}4%&U3@ff$$|42_KM;KrI)kJPa
zID@IhdNt!}l}%E5^_-2D7W6HxIk!w)w_^irq_5QMdsXg)*Guf()Fc>KjKk;j9h+$1
ze`QYMTzfh&F{hfi-S<`hVaj*A>Url&-(M2FeSfB^58>_~%`;=LZs(9-XhGlejPn~_
zEfxyvGB#vS|5AE7IfqjE-{8LfUd(x>1^%Wiao*?Y?DaF1~-MfrEkt&R4!sEEsgxl@x7E*{=(|_HIi~y
zQMe1S$>sPr2Qss!xo*omsYM{(mbl!RkL4{vE?~F;?ALciz`mBqyHW30$JA(?`!BzP
F{SS$_*Ixht

literal 0
HcmV?d1

diff --git a/Silicon/Intel/CometlakeSiliconBinPkg/License.txt 
b/Silicon/Intel/CometlakeSiliconBinPkg/License.txt
new file mode 100644
index 000..ffd60e5
--- /dev/null
+++ b/Silicon/Intel/CometlakeSiliconBinPkg/License.txt
@@ -0,0 +1,30 @@
+Copyright (c) 2012 - 2020, Intel Corporation. All rights reserved.
+
+Redistribution and use in source and binary forms, with or without
+modification, are permitted provided that the following conditions
+are met:
+
+* Redistributions of source code must retain the above copyright
+  notice, this list of conditions and the following disclaimer.
+* Redistributions in binary form must reproduce the above copyright
+  notice, this list of conditions and the following disclaimer in
+  the documentation and/or other materials provided with the
+  distribution.
+
+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
+BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
+ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+POSSIBILITY OF SUCH DAMAGE.
+
+Some files are subject to a li

[edk2-devel] [edk2-non-osi] [PATCH V1 2/2] edk2-non-osi: Add CometlakeSiliconBinPkg maintainers

[Nate DeSimone]

Cc: Kathappan Esakkithevar 
Cc: Sai Chaganty 
Cc: Chasel Chiu 
Signed-off-by: Nate DeSimone 
---
 Maintainers.txt | 4 
 1 file changed, 4 insertions(+)

diff --git a/Maintainers.txt b/Maintainers.txt
index 652243e..7355c66 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -49,6 +49,10 @@ Platform/Intel/CoffeelakeSiliconBinPkg
 M: Chasel Chiu 
 M: Sai Chaganty 
 
+Platform/Intel/CometlakeSiliconBinPkg
+M: Kathappan Esakkithevar 
+M: Sai Chaganty 
+
 Silicon/Intel/KabylakeSiliconBinPkg
 M: Chasel Chiu 
 M: Sai Chaganty 
-- 
2.27.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64955): https://edk2.groups.io/g/devel/message/64955
Mute This Topic: https://groups.io/mt/76577642/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-