Re: [Geany-Devel] GTK version policy
On 2018-02-23 11:53 AM, Lars Paulsen wrote: Hello All, I have ported the scope plugin to GTK3. During that work I also noticed some deprecation warnings for the workbench plugin which I did create not long ago and as suggested by the HACKING file I did write it for GTK2. If I port a plugin to GTK3 should it still support GTK2? Should we change the HACKING file regarding the preferred GTK version to prevent people from writing new plugins based on GTK2? Hi, For the average plugin with minimal dependencies I would recommend to support both since it's so easy. You can put all of your version specific stuff into a single compatibility header (and/or re-use Geany's) so you don't need to litter your code with #ifdef stuff very much. Most distros, as well as the Windows and MacOS releases are still shipping the GTK+2 version of Geany/Geany-Plugins and it's the build system default as well, so if you care about supporting a wide user base, supporting both versions is a good idea. Regards, Matthew Brush ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] GTK version policy
On 24 February 2018 at 05:53, Lars Paulsen wrote: > Hello All, > > I have ported the scope plugin to GTK3. > During that work I also noticed some deprecation warnings for the workbench > plugin which I did create not long ago > and as suggested by the HACKING file I did write it for GTK2. > > If I port a plugin to GTK3 should it still support GTK2? For a plugin its up to you if its your plugin, if its a contribution to a maintained plugin its the maintainers decision, IMHO its not worth polluting new plugins with #ifdefs to support both. As I have been saying for a while, even for existing plugins I would make the GTK3 one a separate plugin. Most plugins have little development happening (except your new one) so it will be rare that changes have to be applied to both. With a #ifdefed plugin it takes effort to build it to support both and again to untangle it when GTK2 goes away, with two plugins you just delete one. And if people do start submitting improvements only for the GTK3 version, thats fine, clearly thats the version that is being used. > Should we change the HACKING file regarding the preferred GTK version to > prevent people from writing new plugins based on GTK2? Personally I vote for that, #1780 for Geany hacking, but the plugins hacking already only says "recommend" not "must" for supporting both GTK 2 and GTK 3. Cheers Lex > > Just a thought. > > Regards, > Lars > > ___ > Devel mailing list > Devel@lists.geany.org > https://lists.geany.org/cgi-bin/mailman/listinfo/devel ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
[Geany-Devel] GTK version policy
Hello All, I have ported the scope plugin to GTK3. During that work I also noticed some deprecation warnings for the workbench plugin which I did create not long ago and as suggested by the HACKING file I did write it for GTK2. If I port a plugin to GTK3 should it still support GTK2? Should we change the HACKING file regarding the preferred GTK version to prevent people from writing new plugins based on GTK2? Just a thought. Regards, Lars ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] Linker issues with VTE
A short update: Checking the documentation on GNOME Developer Center revealed that no VTE function used in the scope plugin seems to require a specific version. So I posted my PR without any version requirement for VTE (so only [vte-2.91]). Greetings, Lars On 23.02.2018 07:14, Lars Paulsen wrote: On 23.02.2018 04:19, Colomban Wendling wrote: Le 22/02/2018 à 15:09, Lars Paulsen a écrit : Then I installed it using apt-get install but Ubuntu only installed a version 0.42 which was older than required. It sounds odd you'd need a version not found in Ubuntu, unless you'd be using a very old Ubuntu. And in any case, depending on something too recent for major distributions to have it has to be a conscious choice: some users might not have access to your software, or have a harder time to get it. Just a thought. So I downloaded the sources and built it myself. After that the error message about the missing "#include " was gone. But I got linker errors for calls to unresolved external function "vte_terminal_set_color_foreground_rgba". I assume this is some geany macro stuff. It turned out I can simply call "vte_terminal_set_color_foreground" because they changed the parameter from "GdkColor" to "GdkRGBA" - just what I needed. Oooh, right, in Geany we have wrappers to bridge this ABI break so we don't have to deal with it, so yeah the `_rgba` suffix is just an internal Geany glitch in vte.c, not any actual API anywhere. Sorry for the confusion it gave you indeed. Regards, Colomban ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel About the version I simply copied what I found in the debugger plugin PR for GTK3 porting. If I got a version running I will re-check to find the smallest version of VTE2.91 which still works. For your information: I am running Ubuntu 16.04. Regards, Lars ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
