Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk
Nathan, I'm no Perl programmer AT ALL, so take this for what it it worth ($0). This RE correctly parses a version no. either at the beginning of the string or preceded by a white-space character. > $ echo "10.4.2" | perl -E 'while () { if ( m/(^|\s)((\d+\.)+\d+)/ ) { > $version = $2 ; print $version, "\n" ; last } }' > 10.4.2 I modified the RE from the last one I saw you post ($version =~ m/\s([\d\.]+\w?)/m;) to allow for multiple digit fields, to remove the "m" modifier ($ is gone now), and to only allow digits in the last field of the version number. I don't know all the contortions of version strings you are trying to match, i.e., why you allowed any alphanumeric (including _) for the last field. This one will match all digits with an optional single letter suffix at the end (i.e., must be at a word boundary). > $ echo "10.4.2A" | perl -E 'while () { if ( > m/(^|\s)((\d+\.)+\d+([a-zA-Z]\b)?)/ ) { $version = $2 ; print $version, "\n" > ; last } }' > 10.4.2A Larry Baker US Geological Survey 650-329-5608 ba...@usgs.gov On 15 Nov 2012, at 8:42 AM, Hjelm, Nathan T wrote: > Committed as r27615. Let me know if there are any more issues. > > -Nathan > > > From: devel-boun...@open-mpi.org [devel-boun...@open-mpi.org] on behalf of > Ralph Castain [r...@open-mpi.org] > Sent: Thursday, November 15, 2012 8:53 AM > To: Open MPI Developers > Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk > > Looks fine to me. I would only add one further refinement - I think we should > check m4, but add a check in autogen.pl so that if we get nothing useful back > from -v (or whatever), then output a warning that we couldn't validate the > version and assume it is okay. > > I believe the tool will return a non-zero status if the option isn't > supported, so we should be able to do this - yes? > > > On Nov 15, 2012, at 7:48 AM, "Hjelm, Nathan T" <hje...@lanl.gov> wrote: > >> Since the version of m4 that comes with Solaris likely works with all our >> .m4 files and there is no way to check the version (no --version, -v, -V, or >> anything from what I can tell) I guess we have no choice but to not check >> the m4 version. >> >> flex on the other hand we can check. How about this for the new regex (for >> reference the old one is $version =~ m/\s([\d\w\.]+)$/m; -- matching a >> version at the end of the line): >> >> $version =~ m/\s([\d\.]+\w?)/m; >> >> It works with Apple's flex and still works with glibtoolize, autoconf, and >> automake. >> >> Searching for autoconf >>Found autoconf version 2.69; checking version... >> Found version component 2 -- need 2 >> Found version component 69 -- need 65 >>==> ACCEPTED >> Searching for libtoolize >> libtoolize not found >> Searching for glibtoolize >>Found glibtoolize version 2.4.2; checking version... >> Found version component 2 -- need 2 >> Found version component 4 -- need 2 >>==> ACCEPTED >> Searching for automake >>Found automake version 1.12.2; checking version... >> Found version component 1 -- need 1 >> Found version component 12 -- need 11 >>==> ACCEPTED >> Searching for flex >>Found flex version 2.5.35; checking version... >> Found version component 2 -- need 2 >> Found version component 5 -- need 5 >> Found version component 35 -- need 35 >>==> ACCEPTED >> Searching for m4 >>Found m4 version 1.4.6; checking version... >> Found version component 1 -- need 1 >> Found version component 4 -- need 4 >> Found version component 6 -- need 16 >>==> Too low! Skipping this version >> Searching for gm4 >>Found gm4 version 1.4.16; checking version... >> Found version component 1 -- need 1 >> Found version component 4 -- need 4 >> Found version component 16 -- need 16 >>==> ACCEPTED >> >> >> -Nathan >> >> >> From: devel-boun...@open-mpi.org [devel-boun...@open-mpi.org] on behalf of >> Paul Hargrove [phhargr...@lbl.gov] >> Sent: Wednesday, November 14, 2012 7:37 PM >> To: Larry Baker >> Cc: Open MPI Developers >> Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk >> >> Larry, >> >> I just wanted to speak up quickly to be sure nobody used your example to >> "fix" the Mac OS problem and thereby break Solaris instead. No personal >> att
Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk
Nathan was addressing a problem that bit GP earlier this week. One of our teams wasted an entire day trying to determine why the trunk wouldn't build any more. Turned out that it was (a) some recent changes to code that used flex that introduced a true dependency on flex 2.5.35, and (b) an older version of flex on their machines. However, although we *require* flex 2.5.35, we never actually test for it. So we added that test - and then spotted the same situation wrt m4. So we decided that if we explicitly require something, then we should explicitly test for it. HTH Ralph On Nov 15, 2012, at 1:19 PM, Jeff Squyres (jsquyres) <jsquy...@cisco.com> wrote: > No issue, I guess. It's just new and I wondered why it was done. > > Sent from my phone. No type good. > > On Nov 15, 2012, at 11:34 AM, "Ralph Castain" <r...@open-mpi.org> wrote: > >> Sooo...what's the issue with checking for it then? Isn't it "required" by >> association? >> >> >> On Nov 15, 2012, at 10:27 AM, "Jeff Squyres (jsquyres)" <jsquy...@cisco.com> >> wrote: >> >>> We only call out te version of m4 because the Autotools we require need >>> that m4 version (which is not always already installed). We don't need that >>> version of m4 for OMPI itself. >>> >>> Sent from my phone. No type good. >>> >>> On Nov 15, 2012, at 10:04 AM, "Ralph Castain" <r...@open-mpi.org> wrote: >>> >>>> Only because we call out a minimum required version in our HACKING file, >>>> but we never check for it >>>> >>>> If we don't require a min version, then we shouldn't check - but if we do, >>>> then we should >>>> >>>> On Nov 15, 2012, at 9:00 AM, "Jeff Squyres (jsquyres)" >>>> <jsquy...@cisco.com> wrote: >>>> >>>>> Wait. >>>>> >>>>> Why did we just add a version check for m4? >>>>> >>>>> Sent from my phone. No type good. >>>>> >>>>> On Nov 15, 2012, at 9:43 AM, "Hjelm, Nathan T" <hje...@lanl.gov> wrote: >>>>> >>>>>> Committed as r27615. Let me know if there are any more issues. >>>>>> >>>>>> -Nathan >>>>>> >>>>>> >>>>>> From: devel-boun...@open-mpi.org [devel-boun...@open-mpi.org] on behalf >>>>>> of Ralph Castain [r...@open-mpi.org] >>>>>> Sent: Thursday, November 15, 2012 8:53 AM >>>>>> To: Open MPI Developers >>>>>> Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk >>>>>> >>>>>> Looks fine to me. I would only add one further refinement - I think we >>>>>> should check m4, but add a check in autogen.pl so that if we get nothing >>>>>> useful back from -v (or whatever), then output a warning that we >>>>>> couldn't validate the version and assume it is okay. >>>>>> >>>>>> I believe the tool will return a non-zero status if the option isn't >>>>>> supported, so we should be able to do this - yes? >>>>>> >>>>>> >>>>>> On Nov 15, 2012, at 7:48 AM, "Hjelm, Nathan T" <hje...@lanl.gov> wrote: >>>>>> >>>>>>> Since the version of m4 that comes with Solaris likely works with all >>>>>>> our .m4 files and there is no way to check the version (no --version, >>>>>>> -v, -V, or anything from what I can tell) I guess we have no choice but >>>>>>> to not check the m4 version. >>>>>>> >>>>>>> flex on the other hand we can check. How about this for the new regex >>>>>>> (for reference the old one is $version =~ m/\s([\d\w\.]+)$/m; -- >>>>>>> matching a version at the end of the line): >>>>>>> >>>>>>> $version =~ m/\s([\d\.]+\w?)/m; >>>>>>> >>>>>>> It works with Apple's flex and still works with glibtoolize, autoconf, >>>>>>> and automake. >>>>>>> >>>>>>> Searching for autoconf >>>>>>> Found autoconf version 2.69; checking version... >>>>>>> Found version component 2 -- need 2 >>>>>>> Found version component 69 -- need 65 &
Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk
No issue, I guess. It's just new and I wondered why it was done. Sent from my phone. No type good. On Nov 15, 2012, at 11:34 AM, "Ralph Castain" <r...@open-mpi.org> wrote: > Sooo...what's the issue with checking for it then? Isn't it "required" by > association? > > > On Nov 15, 2012, at 10:27 AM, "Jeff Squyres (jsquyres)" <jsquy...@cisco.com> > wrote: > >> We only call out te version of m4 because the Autotools we require need that >> m4 version (which is not always already installed). We don't need that >> version of m4 for OMPI itself. >> >> Sent from my phone. No type good. >> >> On Nov 15, 2012, at 10:04 AM, "Ralph Castain" <r...@open-mpi.org> wrote: >> >>> Only because we call out a minimum required version in our HACKING file, >>> but we never check for it >>> >>> If we don't require a min version, then we shouldn't check - but if we do, >>> then we should >>> >>> On Nov 15, 2012, at 9:00 AM, "Jeff Squyres (jsquyres)" <jsquy...@cisco.com> >>> wrote: >>> >>>> Wait. >>>> >>>> Why did we just add a version check for m4? >>>> >>>> Sent from my phone. No type good. >>>> >>>> On Nov 15, 2012, at 9:43 AM, "Hjelm, Nathan T" <hje...@lanl.gov> wrote: >>>> >>>>> Committed as r27615. Let me know if there are any more issues. >>>>> >>>>> -Nathan >>>>> >>>>> >>>>> From: devel-boun...@open-mpi.org [devel-boun...@open-mpi.org] on behalf >>>>> of Ralph Castain [r...@open-mpi.org] >>>>> Sent: Thursday, November 15, 2012 8:53 AM >>>>> To: Open MPI Developers >>>>> Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk >>>>> >>>>> Looks fine to me. I would only add one further refinement - I think we >>>>> should check m4, but add a check in autogen.pl so that if we get nothing >>>>> useful back from -v (or whatever), then output a warning that we couldn't >>>>> validate the version and assume it is okay. >>>>> >>>>> I believe the tool will return a non-zero status if the option isn't >>>>> supported, so we should be able to do this - yes? >>>>> >>>>> >>>>> On Nov 15, 2012, at 7:48 AM, "Hjelm, Nathan T" <hje...@lanl.gov> wrote: >>>>> >>>>>> Since the version of m4 that comes with Solaris likely works with all >>>>>> our .m4 files and there is no way to check the version (no --version, >>>>>> -v, -V, or anything from what I can tell) I guess we have no choice but >>>>>> to not check the m4 version. >>>>>> >>>>>> flex on the other hand we can check. How about this for the new regex >>>>>> (for reference the old one is $version =~ m/\s([\d\w\.]+)$/m; -- >>>>>> matching a version at the end of the line): >>>>>> >>>>>> $version =~ m/\s([\d\.]+\w?)/m; >>>>>> >>>>>> It works with Apple's flex and still works with glibtoolize, autoconf, >>>>>> and automake. >>>>>> >>>>>> Searching for autoconf >>>>>> Found autoconf version 2.69; checking version... >>>>>> Found version component 2 -- need 2 >>>>>> Found version component 69 -- need 65 >>>>>> ==> ACCEPTED >>>>>> Searching for libtoolize >>>>>> libtoolize not found >>>>>> Searching for glibtoolize >>>>>> Found glibtoolize version 2.4.2; checking version... >>>>>> Found version component 2 -- need 2 >>>>>> Found version component 4 -- need 2 >>>>>> ==> ACCEPTED >>>>>> Searching for automake >>>>>> Found automake version 1.12.2; checking version... >>>>>> Found version component 1 -- need 1 >>>>>> Found version component 12 -- need 11 >>>>>> ==> ACCEPTED >>>>>> Searching for flex >>>>>> Found flex version 2.5.35; checking version... >>>>>> Found version component 2 -- need 2 >>>>>> Found version component 5 -- need 5 >>>>>> Found version component 35 -- ne
Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk
Sooo...what's the issue with checking for it then? Isn't it "required" by association? On Nov 15, 2012, at 10:27 AM, "Jeff Squyres (jsquyres)" <jsquy...@cisco.com> wrote: > We only call out te version of m4 because the Autotools we require need that > m4 version (which is not always already installed). We don't need that > version of m4 for OMPI itself. > > Sent from my phone. No type good. > > On Nov 15, 2012, at 10:04 AM, "Ralph Castain" <r...@open-mpi.org> wrote: > >> Only because we call out a minimum required version in our HACKING file, but >> we never check for it >> >> If we don't require a min version, then we shouldn't check - but if we do, >> then we should >> >> On Nov 15, 2012, at 9:00 AM, "Jeff Squyres (jsquyres)" <jsquy...@cisco.com> >> wrote: >> >>> Wait. >>> >>> Why did we just add a version check for m4? >>> >>> Sent from my phone. No type good. >>> >>> On Nov 15, 2012, at 9:43 AM, "Hjelm, Nathan T" <hje...@lanl.gov> wrote: >>> >>>> Committed as r27615. Let me know if there are any more issues. >>>> >>>> -Nathan >>>> >>>> ________________ >>>> From: devel-boun...@open-mpi.org [devel-boun...@open-mpi.org] on behalf of >>>> Ralph Castain [r...@open-mpi.org] >>>> Sent: Thursday, November 15, 2012 8:53 AM >>>> To: Open MPI Developers >>>> Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk >>>> >>>> Looks fine to me. I would only add one further refinement - I think we >>>> should check m4, but add a check in autogen.pl so that if we get nothing >>>> useful back from -v (or whatever), then output a warning that we couldn't >>>> validate the version and assume it is okay. >>>> >>>> I believe the tool will return a non-zero status if the option isn't >>>> supported, so we should be able to do this - yes? >>>> >>>> >>>> On Nov 15, 2012, at 7:48 AM, "Hjelm, Nathan T" <hje...@lanl.gov> wrote: >>>> >>>>> Since the version of m4 that comes with Solaris likely works with all our >>>>> .m4 files and there is no way to check the version (no --version, -v, -V, >>>>> or anything from what I can tell) I guess we have no choice but to not >>>>> check the m4 version. >>>>> >>>>> flex on the other hand we can check. How about this for the new regex >>>>> (for reference the old one is $version =~ m/\s([\d\w\.]+)$/m; -- matching >>>>> a version at the end of the line): >>>>> >>>>> $version =~ m/\s([\d\.]+\w?)/m; >>>>> >>>>> It works with Apple's flex and still works with glibtoolize, autoconf, >>>>> and automake. >>>>> >>>>> Searching for autoconf >>>>> Found autoconf version 2.69; checking version... >>>>> Found version component 2 -- need 2 >>>>> Found version component 69 -- need 65 >>>>> ==> ACCEPTED >>>>> Searching for libtoolize >>>>> libtoolize not found >>>>> Searching for glibtoolize >>>>> Found glibtoolize version 2.4.2; checking version... >>>>> Found version component 2 -- need 2 >>>>> Found version component 4 -- need 2 >>>>> ==> ACCEPTED >>>>> Searching for automake >>>>> Found automake version 1.12.2; checking version... >>>>> Found version component 1 -- need 1 >>>>> Found version component 12 -- need 11 >>>>> ==> ACCEPTED >>>>> Searching for flex >>>>> Found flex version 2.5.35; checking version... >>>>> Found version component 2 -- need 2 >>>>> Found version component 5 -- need 5 >>>>> Found version component 35 -- need 35 >>>>> ==> ACCEPTED >>>>> Searching for m4 >>>>> Found m4 version 1.4.6; checking version... >>>>> Found version component 1 -- need 1 >>>>> Found version component 4 -- need 4 >>>>> Found version component 6 -- need 16 >>>>> ==> Too low! Skipping this version >>>>> Searching for gm4 >>>>> Found gm4 version 1.4.16; checking version... >>>>> Found version component 1 -
Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk
We only call out te version of m4 because the Autotools we require need that m4 version (which is not always already installed). We don't need that version of m4 for OMPI itself. Sent from my phone. No type good. On Nov 15, 2012, at 10:04 AM, "Ralph Castain" <r...@open-mpi.org> wrote: > Only because we call out a minimum required version in our HACKING file, but > we never check for it > > If we don't require a min version, then we shouldn't check - but if we do, > then we should > > On Nov 15, 2012, at 9:00 AM, "Jeff Squyres (jsquyres)" <jsquy...@cisco.com> > wrote: > >> Wait. >> >> Why did we just add a version check for m4? >> >> Sent from my phone. No type good. >> >> On Nov 15, 2012, at 9:43 AM, "Hjelm, Nathan T" <hje...@lanl.gov> wrote: >> >>> Committed as r27615. Let me know if there are any more issues. >>> >>> -Nathan >>> >>> >>> From: devel-boun...@open-mpi.org [devel-boun...@open-mpi.org] on behalf of >>> Ralph Castain [r...@open-mpi.org] >>> Sent: Thursday, November 15, 2012 8:53 AM >>> To: Open MPI Developers >>> Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk >>> >>> Looks fine to me. I would only add one further refinement - I think we >>> should check m4, but add a check in autogen.pl so that if we get nothing >>> useful back from -v (or whatever), then output a warning that we couldn't >>> validate the version and assume it is okay. >>> >>> I believe the tool will return a non-zero status if the option isn't >>> supported, so we should be able to do this - yes? >>> >>> >>> On Nov 15, 2012, at 7:48 AM, "Hjelm, Nathan T" <hje...@lanl.gov> wrote: >>> >>>> Since the version of m4 that comes with Solaris likely works with all our >>>> .m4 files and there is no way to check the version (no --version, -v, -V, >>>> or anything from what I can tell) I guess we have no choice but to not >>>> check the m4 version. >>>> >>>> flex on the other hand we can check. How about this for the new regex (for >>>> reference the old one is $version =~ m/\s([\d\w\.]+)$/m; -- matching a >>>> version at the end of the line): >>>> >>>> $version =~ m/\s([\d\.]+\w?)/m; >>>> >>>> It works with Apple's flex and still works with glibtoolize, autoconf, and >>>> automake. >>>> >>>> Searching for autoconf >>>> Found autoconf version 2.69; checking version... >>>>Found version component 2 -- need 2 >>>>Found version component 69 -- need 65 >>>> ==> ACCEPTED >>>> Searching for libtoolize >>>> libtoolize not found >>>> Searching for glibtoolize >>>> Found glibtoolize version 2.4.2; checking version... >>>>Found version component 2 -- need 2 >>>>Found version component 4 -- need 2 >>>> ==> ACCEPTED >>>> Searching for automake >>>> Found automake version 1.12.2; checking version... >>>>Found version component 1 -- need 1 >>>>Found version component 12 -- need 11 >>>> ==> ACCEPTED >>>> Searching for flex >>>> Found flex version 2.5.35; checking version... >>>>Found version component 2 -- need 2 >>>>Found version component 5 -- need 5 >>>>Found version component 35 -- need 35 >>>> ==> ACCEPTED >>>> Searching for m4 >>>> Found m4 version 1.4.6; checking version... >>>>Found version component 1 -- need 1 >>>>Found version component 4 -- need 4 >>>>Found version component 6 -- need 16 >>>> ==> Too low! Skipping this version >>>> Searching for gm4 >>>> Found gm4 version 1.4.16; checking version... >>>>Found version component 1 -- need 1 >>>>Found version component 4 -- need 4 >>>>Found version component 16 -- need 16 >>>> ==> ACCEPTED >>>> >>>> >>>> -Nathan >>>> >>>> >>>> From: devel-boun...@open-mpi.org [devel-boun...@open-mpi.org] on behalf of >>>> Paul Hargrove [phhargr...@lbl.gov] >>>> Sent: Wednesday, November 14, 2012 7:37 PM >>>> To: Larry Baker >>>> Cc: Open MPI D
Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk
Worked perfectly - thanks! On Nov 15, 2012, at 9:16 AM, "Hjelm, Nathan T" <hje...@lanl.gov> wrote: > Opps. missed that one. I updated the regex to make slightly more restricted > to fix this case. > > -Nathan > > From: devel-boun...@open-mpi.org [devel-boun...@open-mpi.org] on behalf of > Ralph Castain [r...@open-mpi.org] > Sent: Thursday, November 15, 2012 10:01 AM > To: Open MPI Developers > Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk > > Just an FYI: on the Mac ML, I see this: > > Searching for m4 > Found m4 version 4; checking version... > Found version component 4 -- need 1 > > $ m4 --version > m4 (GNU M4) 1.4.16 > > Looks like the parser isn't quite picking it up correctly, but it is > releasing it because it thinks the 4 is above the required 1 > > > On Nov 15, 2012, at 8:42 AM, "Hjelm, Nathan T" <hje...@lanl.gov> wrote: > >> Committed as r27615. Let me know if there are any more issues. >> >> -Nathan >> >> >> From: devel-boun...@open-mpi.org [devel-boun...@open-mpi.org] on behalf of >> Ralph Castain [r...@open-mpi.org] >> Sent: Thursday, November 15, 2012 8:53 AM >> To: Open MPI Developers >> Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk >> >> Looks fine to me. I would only add one further refinement - I think we >> should check m4, but add a check in autogen.pl so that if we get nothing >> useful back from -v (or whatever), then output a warning that we couldn't >> validate the version and assume it is okay. >> >> I believe the tool will return a non-zero status if the option isn't >> supported, so we should be able to do this - yes? >> >> >> On Nov 15, 2012, at 7:48 AM, "Hjelm, Nathan T" <hje...@lanl.gov> wrote: >> >>> Since the version of m4 that comes with Solaris likely works with all our >>> .m4 files and there is no way to check the version (no --version, -v, -V, >>> or anything from what I can tell) I guess we have no choice but to not >>> check the m4 version. >>> >>> flex on the other hand we can check. How about this for the new regex (for >>> reference the old one is $version =~ m/\s([\d\w\.]+)$/m; -- matching a >>> version at the end of the line): >>> >>> $version =~ m/\s([\d\.]+\w?)/m; >>> >>> It works with Apple's flex and still works with glibtoolize, autoconf, and >>> automake. >>> >>> Searching for autoconf >>> Found autoconf version 2.69; checking version... >>> Found version component 2 -- need 2 >>> Found version component 69 -- need 65 >>> ==> ACCEPTED >>> Searching for libtoolize >>> libtoolize not found >>> Searching for glibtoolize >>> Found glibtoolize version 2.4.2; checking version... >>> Found version component 2 -- need 2 >>> Found version component 4 -- need 2 >>> ==> ACCEPTED >>> Searching for automake >>> Found automake version 1.12.2; checking version... >>> Found version component 1 -- need 1 >>> Found version component 12 -- need 11 >>> ==> ACCEPTED >>> Searching for flex >>> Found flex version 2.5.35; checking version... >>> Found version component 2 -- need 2 >>> Found version component 5 -- need 5 >>> Found version component 35 -- need 35 >>> ==> ACCEPTED >>> Searching for m4 >>> Found m4 version 1.4.6; checking version... >>> Found version component 1 -- need 1 >>> Found version component 4 -- need 4 >>> Found version component 6 -- need 16 >>> ==> Too low! Skipping this version >>> Searching for gm4 >>> Found gm4 version 1.4.16; checking version... >>> Found version component 1 -- need 1 >>> Found version component 4 -- need 4 >>> Found version component 16 -- need 16 >>> ==> ACCEPTED >>> >>> >>> -Nathan >>> >>> >>> From: devel-boun...@open-mpi.org [devel-boun...@open-mpi.org] on behalf of >>> Paul Hargrove [phhargr...@lbl.gov] >>> Sent: Wednesday, November 14, 2012 7:37 PM >>> To: Larry Baker >>> Cc: Open MPI Developers >>> Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk >>> >>> Larry, >>> >>> I just wante
Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk
Opps. missed that one. I updated the regex to make slightly more restricted to fix this case. -Nathan From: devel-boun...@open-mpi.org [devel-boun...@open-mpi.org] on behalf of Ralph Castain [r...@open-mpi.org] Sent: Thursday, November 15, 2012 10:01 AM To: Open MPI Developers Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk Just an FYI: on the Mac ML, I see this: Searching for m4 Found m4 version 4; checking version... Found version component 4 -- need 1 $ m4 --version m4 (GNU M4) 1.4.16 Looks like the parser isn't quite picking it up correctly, but it is releasing it because it thinks the 4 is above the required 1 On Nov 15, 2012, at 8:42 AM, "Hjelm, Nathan T" <hje...@lanl.gov> wrote: > Committed as r27615. Let me know if there are any more issues. > > -Nathan > > > From: devel-boun...@open-mpi.org [devel-boun...@open-mpi.org] on behalf of > Ralph Castain [r...@open-mpi.org] > Sent: Thursday, November 15, 2012 8:53 AM > To: Open MPI Developers > Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk > > Looks fine to me. I would only add one further refinement - I think we should > check m4, but add a check in autogen.pl so that if we get nothing useful back > from -v (or whatever), then output a warning that we couldn't validate the > version and assume it is okay. > > I believe the tool will return a non-zero status if the option isn't > supported, so we should be able to do this - yes? > > > On Nov 15, 2012, at 7:48 AM, "Hjelm, Nathan T" <hje...@lanl.gov> wrote: > >> Since the version of m4 that comes with Solaris likely works with all our >> .m4 files and there is no way to check the version (no --version, -v, -V, or >> anything from what I can tell) I guess we have no choice but to not check >> the m4 version. >> >> flex on the other hand we can check. How about this for the new regex (for >> reference the old one is $version =~ m/\s([\d\w\.]+)$/m; -- matching a >> version at the end of the line): >> >> $version =~ m/\s([\d\.]+\w?)/m; >> >> It works with Apple's flex and still works with glibtoolize, autoconf, and >> automake. >> >> Searching for autoconf >>Found autoconf version 2.69; checking version... >> Found version component 2 -- need 2 >> Found version component 69 -- need 65 >>==> ACCEPTED >> Searching for libtoolize >> libtoolize not found >> Searching for glibtoolize >>Found glibtoolize version 2.4.2; checking version... >> Found version component 2 -- need 2 >> Found version component 4 -- need 2 >>==> ACCEPTED >> Searching for automake >>Found automake version 1.12.2; checking version... >> Found version component 1 -- need 1 >> Found version component 12 -- need 11 >>==> ACCEPTED >> Searching for flex >>Found flex version 2.5.35; checking version... >> Found version component 2 -- need 2 >> Found version component 5 -- need 5 >> Found version component 35 -- need 35 >>==> ACCEPTED >> Searching for m4 >>Found m4 version 1.4.6; checking version... >> Found version component 1 -- need 1 >> Found version component 4 -- need 4 >> Found version component 6 -- need 16 >>==> Too low! Skipping this version >> Searching for gm4 >>Found gm4 version 1.4.16; checking version... >> Found version component 1 -- need 1 >> Found version component 4 -- need 4 >> Found version component 16 -- need 16 >>==> ACCEPTED >> >> >> -Nathan >> >> >> From: devel-boun...@open-mpi.org [devel-boun...@open-mpi.org] on behalf of >> Paul Hargrove [phhargr...@lbl.gov] >> Sent: Wednesday, November 14, 2012 7:37 PM >> To: Larry Baker >> Cc: Open MPI Developers >> Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk >> >> Larry, >> >> I just wanted to speak up quickly to be sure nobody used your example to >> "fix" the Mac OS problem and thereby break Solaris instead. No personal >> attack/affront was intended. >> >> -Paulhttps://mymail.lanl.gov/owa/?ae=PreFormAction=IPM.Note=ReplyAll=RgD3GfjXt9HDTI902%2b63W1IcBwCuRfL1X%2babT5m7NFXoIdcVxVZxAACuRfL1X%2babT5m7NFXoIdcVAAAa4RQFAAAJ# >> >> On Wed, Nov 14, 2012 at 7:10 PM, Larry Baker >> <ba...@usgs.gov<mailto:ba...@usgs.gov>> wrote: >> Paul, >> >> 1) I wasn't trying
Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk
Only because we call out a minimum required version in our HACKING file, but we never check for it If we don't require a min version, then we shouldn't check - but if we do, then we should On Nov 15, 2012, at 9:00 AM, "Jeff Squyres (jsquyres)" <jsquy...@cisco.com> wrote: > Wait. > > Why did we just add a version check for m4? > > Sent from my phone. No type good. > > On Nov 15, 2012, at 9:43 AM, "Hjelm, Nathan T" <hje...@lanl.gov> wrote: > >> Committed as r27615. Let me know if there are any more issues. >> >> -Nathan >> >> >> From: devel-boun...@open-mpi.org [devel-boun...@open-mpi.org] on behalf of >> Ralph Castain [r...@open-mpi.org] >> Sent: Thursday, November 15, 2012 8:53 AM >> To: Open MPI Developers >> Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk >> >> Looks fine to me. I would only add one further refinement - I think we >> should check m4, but add a check in autogen.pl so that if we get nothing >> useful back from -v (or whatever), then output a warning that we couldn't >> validate the version and assume it is okay. >> >> I believe the tool will return a non-zero status if the option isn't >> supported, so we should be able to do this - yes? >> >> >> On Nov 15, 2012, at 7:48 AM, "Hjelm, Nathan T" <hje...@lanl.gov> wrote: >> >>> Since the version of m4 that comes with Solaris likely works with all our >>> .m4 files and there is no way to check the version (no --version, -v, -V, >>> or anything from what I can tell) I guess we have no choice but to not >>> check the m4 version. >>> >>> flex on the other hand we can check. How about this for the new regex (for >>> reference the old one is $version =~ m/\s([\d\w\.]+)$/m; -- matching a >>> version at the end of the line): >>> >>> $version =~ m/\s([\d\.]+\w?)/m; >>> >>> It works with Apple's flex and still works with glibtoolize, autoconf, and >>> automake. >>> >>> Searching for autoconf >>> Found autoconf version 2.69; checking version... >>> Found version component 2 -- need 2 >>> Found version component 69 -- need 65 >>> ==> ACCEPTED >>> Searching for libtoolize >>> libtoolize not found >>> Searching for glibtoolize >>> Found glibtoolize version 2.4.2; checking version... >>> Found version component 2 -- need 2 >>> Found version component 4 -- need 2 >>> ==> ACCEPTED >>> Searching for automake >>> Found automake version 1.12.2; checking version... >>> Found version component 1 -- need 1 >>> Found version component 12 -- need 11 >>> ==> ACCEPTED >>> Searching for flex >>> Found flex version 2.5.35; checking version... >>> Found version component 2 -- need 2 >>> Found version component 5 -- need 5 >>> Found version component 35 -- need 35 >>> ==> ACCEPTED >>> Searching for m4 >>> Found m4 version 1.4.6; checking version... >>> Found version component 1 -- need 1 >>> Found version component 4 -- need 4 >>> Found version component 6 -- need 16 >>> ==> Too low! Skipping this version >>> Searching for gm4 >>> Found gm4 version 1.4.16; checking version... >>> Found version component 1 -- need 1 >>> Found version component 4 -- need 4 >>> Found version component 16 -- need 16 >>> ==> ACCEPTED >>> >>> >>> -Nathan >>> >>> >>> From: devel-boun...@open-mpi.org [devel-boun...@open-mpi.org] on behalf of >>> Paul Hargrove [phhargr...@lbl.gov] >>> Sent: Wednesday, November 14, 2012 7:37 PM >>> To: Larry Baker >>> Cc: Open MPI Developers >>> Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk >>> >>> Larry, >>> >>> I just wanted to speak up quickly to be sure nobody used your example to >>> "fix" the Mac OS problem and thereby break Solaris instead. No personal >>> attack/affront was intended. >>> >>> -Paulhttps://mymail.lanl.gov/owa/?ae=PreFormAction=IPM.Note=ReplyAll=RgD3GfjXt9HDTI902%2b63W1IcBwCuRfL1X%2babT5m7NFXoIdcVxVZxAACuRfL1X%2babT5m7NFXoIdcVAAAa4RQFAAAJ# >>> >>> On Wed, Nov 14, 2012 at 7:10 PM, Larry Baker >>> <ba...@usgs.gov<mailto:ba...@usg
Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk
Just an FYI: on the Mac ML, I see this: Searching for m4 Found m4 version 4; checking version... Found version component 4 -- need 1 $ m4 --version m4 (GNU M4) 1.4.16 Looks like the parser isn't quite picking it up correctly, but it is releasing it because it thinks the 4 is above the required 1 On Nov 15, 2012, at 8:42 AM, "Hjelm, Nathan T" <hje...@lanl.gov> wrote: > Committed as r27615. Let me know if there are any more issues. > > -Nathan > > > From: devel-boun...@open-mpi.org [devel-boun...@open-mpi.org] on behalf of > Ralph Castain [r...@open-mpi.org] > Sent: Thursday, November 15, 2012 8:53 AM > To: Open MPI Developers > Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk > > Looks fine to me. I would only add one further refinement - I think we should > check m4, but add a check in autogen.pl so that if we get nothing useful back > from -v (or whatever), then output a warning that we couldn't validate the > version and assume it is okay. > > I believe the tool will return a non-zero status if the option isn't > supported, so we should be able to do this - yes? > > > On Nov 15, 2012, at 7:48 AM, "Hjelm, Nathan T" <hje...@lanl.gov> wrote: > >> Since the version of m4 that comes with Solaris likely works with all our >> .m4 files and there is no way to check the version (no --version, -v, -V, or >> anything from what I can tell) I guess we have no choice but to not check >> the m4 version. >> >> flex on the other hand we can check. How about this for the new regex (for >> reference the old one is $version =~ m/\s([\d\w\.]+)$/m; -- matching a >> version at the end of the line): >> >> $version =~ m/\s([\d\.]+\w?)/m; >> >> It works with Apple's flex and still works with glibtoolize, autoconf, and >> automake. >> >> Searching for autoconf >>Found autoconf version 2.69; checking version... >> Found version component 2 -- need 2 >> Found version component 69 -- need 65 >>==> ACCEPTED >> Searching for libtoolize >> libtoolize not found >> Searching for glibtoolize >>Found glibtoolize version 2.4.2; checking version... >> Found version component 2 -- need 2 >> Found version component 4 -- need 2 >>==> ACCEPTED >> Searching for automake >>Found automake version 1.12.2; checking version... >> Found version component 1 -- need 1 >> Found version component 12 -- need 11 >>==> ACCEPTED >> Searching for flex >>Found flex version 2.5.35; checking version... >> Found version component 2 -- need 2 >> Found version component 5 -- need 5 >> Found version component 35 -- need 35 >>==> ACCEPTED >> Searching for m4 >>Found m4 version 1.4.6; checking version... >> Found version component 1 -- need 1 >> Found version component 4 -- need 4 >> Found version component 6 -- need 16 >>==> Too low! Skipping this version >> Searching for gm4 >>Found gm4 version 1.4.16; checking version... >> Found version component 1 -- need 1 >> Found version component 4 -- need 4 >> Found version component 16 -- need 16 >>==> ACCEPTED >> >> >> -Nathan >> >> >> From: devel-boun...@open-mpi.org [devel-boun...@open-mpi.org] on behalf of >> Paul Hargrove [phhargr...@lbl.gov] >> Sent: Wednesday, November 14, 2012 7:37 PM >> To: Larry Baker >> Cc: Open MPI Developers >> Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk >> >> Larry, >> >> I just wanted to speak up quickly to be sure nobody used your example to >> "fix" the Mac OS problem and thereby break Solaris instead. No personal >> attack/affront was intended. >> >> -Paulhttps://mymail.lanl.gov/owa/?ae=PreFormAction=IPM.Note=ReplyAll=RgD3GfjXt9HDTI902%2b63W1IcBwCuRfL1X%2babT5m7NFXoIdcVxVZxAACuRfL1X%2babT5m7NFXoIdcVAAAa4RQFAAAJ# >> >> On Wed, Nov 14, 2012 at 7:10 PM, Larry Baker >> <ba...@usgs.gov<mailto:ba...@usgs.gov>> wrote: >> Paul, >> >> 1) I wasn't trying to solve the --version issue, only the parsing of the >> response. >> 2) I assumed from the initial e-mail that the broken parser was in a Perl >> script. I'm not a Perl person, so I wrote the example regular expression >> parser in sed. >> >> These commands were done on my Mac OS X 10.6 system. I have no idea where >>
Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk
Wait. Why did we just add a version check for m4? Sent from my phone. No type good. On Nov 15, 2012, at 9:43 AM, "Hjelm, Nathan T" <hje...@lanl.gov> wrote: > Committed as r27615. Let me know if there are any more issues. > > -Nathan > > > From: devel-boun...@open-mpi.org [devel-boun...@open-mpi.org] on behalf of > Ralph Castain [r...@open-mpi.org] > Sent: Thursday, November 15, 2012 8:53 AM > To: Open MPI Developers > Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk > > Looks fine to me. I would only add one further refinement - I think we should > check m4, but add a check in autogen.pl so that if we get nothing useful back > from -v (or whatever), then output a warning that we couldn't validate the > version and assume it is okay. > > I believe the tool will return a non-zero status if the option isn't > supported, so we should be able to do this - yes? > > > On Nov 15, 2012, at 7:48 AM, "Hjelm, Nathan T" <hje...@lanl.gov> wrote: > >> Since the version of m4 that comes with Solaris likely works with all our >> .m4 files and there is no way to check the version (no --version, -v, -V, or >> anything from what I can tell) I guess we have no choice but to not check >> the m4 version. >> >> flex on the other hand we can check. How about this for the new regex (for >> reference the old one is $version =~ m/\s([\d\w\.]+)$/m; -- matching a >> version at the end of the line): >> >> $version =~ m/\s([\d\.]+\w?)/m; >> >> It works with Apple's flex and still works with glibtoolize, autoconf, and >> automake. >> >> Searching for autoconf >>Found autoconf version 2.69; checking version... >> Found version component 2 -- need 2 >> Found version component 69 -- need 65 >>==> ACCEPTED >> Searching for libtoolize >> libtoolize not found >> Searching for glibtoolize >>Found glibtoolize version 2.4.2; checking version... >> Found version component 2 -- need 2 >> Found version component 4 -- need 2 >>==> ACCEPTED >> Searching for automake >>Found automake version 1.12.2; checking version... >> Found version component 1 -- need 1 >> Found version component 12 -- need 11 >>==> ACCEPTED >> Searching for flex >>Found flex version 2.5.35; checking version... >> Found version component 2 -- need 2 >> Found version component 5 -- need 5 >> Found version component 35 -- need 35 >>==> ACCEPTED >> Searching for m4 >>Found m4 version 1.4.6; checking version... >> Found version component 1 -- need 1 >> Found version component 4 -- need 4 >> Found version component 6 -- need 16 >>==> Too low! Skipping this version >> Searching for gm4 >>Found gm4 version 1.4.16; checking version... >> Found version component 1 -- need 1 >> Found version component 4 -- need 4 >> Found version component 16 -- need 16 >>==> ACCEPTED >> >> >> -Nathan >> >> >> From: devel-boun...@open-mpi.org [devel-boun...@open-mpi.org] on behalf of >> Paul Hargrove [phhargr...@lbl.gov] >> Sent: Wednesday, November 14, 2012 7:37 PM >> To: Larry Baker >> Cc: Open MPI Developers >> Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk >> >> Larry, >> >> I just wanted to speak up quickly to be sure nobody used your example to >> "fix" the Mac OS problem and thereby break Solaris instead. No personal >> attack/affront was intended. >> >> -Paulhttps://mymail.lanl.gov/owa/?ae=PreFormAction=IPM.Note=ReplyAll=RgD3GfjXt9HDTI902%2b63W1IcBwCuRfL1X%2babT5m7NFXoIdcVxVZxAACuRfL1X%2babT5m7NFXoIdcVAAAa4RQFAAAJ# >> >> On Wed, Nov 14, 2012 at 7:10 PM, Larry Baker >> <ba...@usgs.gov<mailto:ba...@usgs.gov>> wrote: >> Paul, >> >> 1) I wasn't trying to solve the --version issue, only the parsing of the >> response. >> 2) I assumed from the initial e-mail that the broken parser was in a Perl >> script. I'm not a Perl person, so I wrote the example regular expression >> parser in sed. >> >> These commands were done on my Mac OS X 10.6 system. I have no idea where >> the apps came from. I know the sed, at least, does not recognize regular >> expressions documented for GNU sed (such as \< \> for begin/end word). >> Maybe it is a BSD sed? >> >> I was
Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk
Committed as r27615. Let me know if there are any more issues. -Nathan From: devel-boun...@open-mpi.org [devel-boun...@open-mpi.org] on behalf of Ralph Castain [r...@open-mpi.org] Sent: Thursday, November 15, 2012 8:53 AM To: Open MPI Developers Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk Looks fine to me. I would only add one further refinement - I think we should check m4, but add a check in autogen.pl so that if we get nothing useful back from -v (or whatever), then output a warning that we couldn't validate the version and assume it is okay. I believe the tool will return a non-zero status if the option isn't supported, so we should be able to do this - yes? On Nov 15, 2012, at 7:48 AM, "Hjelm, Nathan T" <hje...@lanl.gov> wrote: > Since the version of m4 that comes with Solaris likely works with all our .m4 > files and there is no way to check the version (no --version, -v, -V, or > anything from what I can tell) I guess we have no choice but to not check the > m4 version. > > flex on the other hand we can check. How about this for the new regex (for > reference the old one is $version =~ m/\s([\d\w\.]+)$/m; -- matching a > version at the end of the line): > > $version =~ m/\s([\d\.]+\w?)/m; > > It works with Apple's flex and still works with glibtoolize, autoconf, and > automake. > > Searching for autoconf > Found autoconf version 2.69; checking version... > Found version component 2 -- need 2 > Found version component 69 -- need 65 > ==> ACCEPTED > Searching for libtoolize > libtoolize not found > Searching for glibtoolize > Found glibtoolize version 2.4.2; checking version... > Found version component 2 -- need 2 > Found version component 4 -- need 2 > ==> ACCEPTED > Searching for automake > Found automake version 1.12.2; checking version... > Found version component 1 -- need 1 > Found version component 12 -- need 11 > ==> ACCEPTED > Searching for flex > Found flex version 2.5.35; checking version... > Found version component 2 -- need 2 > Found version component 5 -- need 5 > Found version component 35 -- need 35 > ==> ACCEPTED > Searching for m4 > Found m4 version 1.4.6; checking version... > Found version component 1 -- need 1 > Found version component 4 -- need 4 > Found version component 6 -- need 16 > ==> Too low! Skipping this version > Searching for gm4 > Found gm4 version 1.4.16; checking version... > Found version component 1 -- need 1 > Found version component 4 -- need 4 > Found version component 16 -- need 16 > ==> ACCEPTED > > > -Nathan > > > From: devel-boun...@open-mpi.org [devel-boun...@open-mpi.org] on behalf of > Paul Hargrove [phhargr...@lbl.gov] > Sent: Wednesday, November 14, 2012 7:37 PM > To: Larry Baker > Cc: Open MPI Developers > Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk > > Larry, > > I just wanted to speak up quickly to be sure nobody used your example to > "fix" the Mac OS problem and thereby break Solaris instead. No personal > attack/affront was intended. > > -Paulhttps://mymail.lanl.gov/owa/?ae=PreFormAction=IPM.Note=ReplyAll=RgD3GfjXt9HDTI902%2b63W1IcBwCuRfL1X%2babT5m7NFXoIdcVxVZxAACuRfL1X%2babT5m7NFXoIdcVAAAa4RQFAAAJ# > > On Wed, Nov 14, 2012 at 7:10 PM, Larry Baker > <ba...@usgs.gov<mailto:ba...@usgs.gov>> wrote: > Paul, > > 1) I wasn't trying to solve the --version issue, only the parsing of the > response. > 2) I assumed from the initial e-mail that the broken parser was in a Perl > script. I'm not a Perl person, so I wrote the example regular expression > parser in sed. > > These commands were done on my Mac OS X 10.6 system. I have no idea where > the apps came from. I know the sed, at least, does not recognize regular > expressions documented for GNU sed (such as \< \> for begin/end word). Maybe > it is a BSD sed? > > I was just trying to illustrate how to fix the broken parsing of Ralph's > "flex --version". Assuming the RE parser I wrote is satisfactory, it would > have to be adapted to fit in the framework, i.e., it has to be portable. > > Larry Baker > US Geological Survey > 650-329-5608 > ba...@usgs.gov<mailto:ba...@usgs.gov> > > > > On 14 Nov 2012, at 5:41 PM, Paul Hargrove wrote: > > On Wed, Nov 14, 2012 at 6:26 PM, Larry Baker > <ba...@usgs.gov<mailto:ba...@usgs.gov>> wrote: > m4 --version | sed -n -E -e > '1s/^.*[^A-Za-z0-9_-]?([0-9]+[.][0-9]+
Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk
Looks fine to me. I would only add one further refinement - I think we should check m4, but add a check in autogen.pl so that if we get nothing useful back from -v (or whatever), then output a warning that we couldn't validate the version and assume it is okay. I believe the tool will return a non-zero status if the option isn't supported, so we should be able to do this - yes? On Nov 15, 2012, at 7:48 AM, "Hjelm, Nathan T" <hje...@lanl.gov> wrote: > Since the version of m4 that comes with Solaris likely works with all our .m4 > files and there is no way to check the version (no --version, -v, -V, or > anything from what I can tell) I guess we have no choice but to not check the > m4 version. > > flex on the other hand we can check. How about this for the new regex (for > reference the old one is $version =~ m/\s([\d\w\.]+)$/m; -- matching a > version at the end of the line): > > $version =~ m/\s([\d\.]+\w?)/m; > > It works with Apple's flex and still works with glibtoolize, autoconf, and > automake. > > Searching for autoconf > Found autoconf version 2.69; checking version... > Found version component 2 -- need 2 > Found version component 69 -- need 65 > ==> ACCEPTED > Searching for libtoolize > libtoolize not found > Searching for glibtoolize > Found glibtoolize version 2.4.2; checking version... > Found version component 2 -- need 2 > Found version component 4 -- need 2 > ==> ACCEPTED > Searching for automake > Found automake version 1.12.2; checking version... > Found version component 1 -- need 1 > Found version component 12 -- need 11 > ==> ACCEPTED > Searching for flex > Found flex version 2.5.35; checking version... > Found version component 2 -- need 2 > Found version component 5 -- need 5 > Found version component 35 -- need 35 > ==> ACCEPTED > Searching for m4 > Found m4 version 1.4.6; checking version... > Found version component 1 -- need 1 > Found version component 4 -- need 4 > Found version component 6 -- need 16 > ==> Too low! Skipping this version > Searching for gm4 > Found gm4 version 1.4.16; checking version... > Found version component 1 -- need 1 > Found version component 4 -- need 4 > Found version component 16 -- need 16 > ==> ACCEPTED > > > -Nathan > > > From: devel-boun...@open-mpi.org [devel-boun...@open-mpi.org] on behalf of > Paul Hargrove [phhargr...@lbl.gov] > Sent: Wednesday, November 14, 2012 7:37 PM > To: Larry Baker > Cc: Open MPI Developers > Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk > > Larry, > > I just wanted to speak up quickly to be sure nobody used your example to > "fix" the Mac OS problem and thereby break Solaris instead. No personal > attack/affront was intended. > > -Paulhttps://mymail.lanl.gov/owa/?ae=PreFormAction=IPM.Note=ReplyAll=RgD3GfjXt9HDTI902%2b63W1IcBwCuRfL1X%2babT5m7NFXoIdcVxVZxAACuRfL1X%2babT5m7NFXoIdcVAAAa4RQFAAAJ# > > On Wed, Nov 14, 2012 at 7:10 PM, Larry Baker > <ba...@usgs.gov<mailto:ba...@usgs.gov>> wrote: > Paul, > > 1) I wasn't trying to solve the --version issue, only the parsing of the > response. > 2) I assumed from the initial e-mail that the broken parser was in a Perl > script. I'm not a Perl person, so I wrote the example regular expression > parser in sed. > > These commands were done on my Mac OS X 10.6 system. I have no idea where > the apps came from. I know the sed, at least, does not recognize regular > expressions documented for GNU sed (such as \< \> for begin/end word). Maybe > it is a BSD sed? > > I was just trying to illustrate how to fix the broken parsing of Ralph's > "flex --version". Assuming the RE parser I wrote is satisfactory, it would > have to be adapted to fit in the framework, i.e., it has to be portable. > > Larry Baker > US Geological Survey > 650-329-5608 > ba...@usgs.gov<mailto:ba...@usgs.gov> > > > > On 14 Nov 2012, at 5:41 PM, Paul Hargrove wrote: > > On Wed, Nov 14, 2012 at 6:26 PM, Larry Baker > <ba...@usgs.gov<mailto:ba...@usgs.gov>> wrote: > m4 --version | sed -n -E -e > '1s/^.*[^A-Za-z0-9_-]?([0-9]+[.][0-9]+[.][0-9]+)[^A-Za-z0-9_-]?.*$/\1/p' > > > There are STILL problems with this approach as it is TWICE specific to GNU > software: > > 1) M4 on OpenBSD (maybe others) doesn't support a "--version" flag: > $ m4 --version | sed -n -E -e > '1s/^.*[^A-Za-z0-9_-]?([0-9]+[
Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk
Since the version of m4 that comes with Solaris likely works with all our .m4 files and there is no way to check the version (no --version, -v, -V, or anything from what I can tell) I guess we have no choice but to not check the m4 version. flex on the other hand we can check. How about this for the new regex (for reference the old one is $version =~ m/\s([\d\w\.]+)$/m; -- matching a version at the end of the line): $version =~ m/\s([\d\.]+\w?)/m; It works with Apple's flex and still works with glibtoolize, autoconf, and automake. Searching for autoconf Found autoconf version 2.69; checking version... Found version component 2 -- need 2 Found version component 69 -- need 65 ==> ACCEPTED Searching for libtoolize libtoolize not found Searching for glibtoolize Found glibtoolize version 2.4.2; checking version... Found version component 2 -- need 2 Found version component 4 -- need 2 ==> ACCEPTED Searching for automake Found automake version 1.12.2; checking version... Found version component 1 -- need 1 Found version component 12 -- need 11 ==> ACCEPTED Searching for flex Found flex version 2.5.35; checking version... Found version component 2 -- need 2 Found version component 5 -- need 5 Found version component 35 -- need 35 ==> ACCEPTED Searching for m4 Found m4 version 1.4.6; checking version... Found version component 1 -- need 1 Found version component 4 -- need 4 Found version component 6 -- need 16 ==> Too low! Skipping this version Searching for gm4 Found gm4 version 1.4.16; checking version... Found version component 1 -- need 1 Found version component 4 -- need 4 Found version component 16 -- need 16 ==> ACCEPTED -Nathan From: devel-boun...@open-mpi.org [devel-boun...@open-mpi.org] on behalf of Paul Hargrove [phhargr...@lbl.gov] Sent: Wednesday, November 14, 2012 7:37 PM To: Larry Baker Cc: Open MPI Developers Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk Larry, I just wanted to speak up quickly to be sure nobody used your example to "fix" the Mac OS problem and thereby break Solaris instead. No personal attack/affront was intended. -Paulhttps://mymail.lanl.gov/owa/?ae=PreFormAction=IPM.Note=ReplyAll=RgD3GfjXt9HDTI902%2b63W1IcBwCuRfL1X%2babT5m7NFXoIdcVxVZxAACuRfL1X%2babT5m7NFXoIdcVAAAa4RQFAAAJ# On Wed, Nov 14, 2012 at 7:10 PM, Larry Baker <ba...@usgs.gov<mailto:ba...@usgs.gov>> wrote: Paul, 1) I wasn't trying to solve the --version issue, only the parsing of the response. 2) I assumed from the initial e-mail that the broken parser was in a Perl script. I'm not a Perl person, so I wrote the example regular expression parser in sed. These commands were done on my Mac OS X 10.6 system. I have no idea where the apps came from. I know the sed, at least, does not recognize regular expressions documented for GNU sed (such as \< \> for begin/end word). Maybe it is a BSD sed? I was just trying to illustrate how to fix the broken parsing of Ralph's "flex --version". Assuming the RE parser I wrote is satisfactory, it would have to be adapted to fit in the framework, i.e., it has to be portable. Larry Baker US Geological Survey 650-329-5608 ba...@usgs.gov<mailto:ba...@usgs.gov> On 14 Nov 2012, at 5:41 PM, Paul Hargrove wrote: On Wed, Nov 14, 2012 at 6:26 PM, Larry Baker <ba...@usgs.gov<mailto:ba...@usgs.gov>> wrote: m4 --version | sed -n -E -e '1s/^.*[^A-Za-z0-9_-]?([0-9]+[.][0-9]+[.][0-9]+)[^A-Za-z0-9_-]?.*$/\1/p' There are STILL problems with this approach as it is TWICE specific to GNU software: 1) M4 on OpenBSD (maybe others) doesn't support a "--version" flag: $ m4 --version | sed -n -E -e '1s/^.*[^A-Za-z0-9_-]?([0-9]+[.][0-9]+[.][0-9]+)[^A-Za-z0-9_-]?.*$/\1/p' m4: unknown option -- - usage: m4 [-gPs] [-Dname[=value]] [-d flags] [-I dirname] [-o filename] [-t macro] [-Uname] [file ...] 2) sed on Solaris (maybe others) doesn't support a "-E" flag: $ m4 --version | sed -n -E -e '1s/^.*[^A-Za-z0-9_-]?([0-9]+[.][0-9]+[.][0-9]+)[^A-Za-z0-9_-]?.*$/\1/p' /bin/sed: illegal option -- E -Paul -- Paul H. Hargrove phhargr...@lbl.gov<mailto:phhargr...@lbl.gov> Future Technologies Group Computer and Data Sciences Department Tel: +1-510-495-2352<tel:%2B1-510-495-2352> Lawrence Berkeley National Laboratory Fax: +1-510-486-6900<tel:%2B1-510-486-6900> ___ devel mailing list de...@open-mpi.org<mailto:de...@open-mpi.org> http://www.open-mpi.org/mailman/listinfo.cgi/devel -- Paul H. Hargrove phhargr...@lbl.gov<mailto:phhargr...@lbl.gov> Future Technologies Group Computer and Data Sciences Department Tel: +1-510-495-2352 Lawrence Berkeley National Laboratory Fax: +1-510-486-6900
Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk
Larry, I just wanted to speak up quickly to be sure nobody used your example to "fix" the Mac OS problem and thereby break Solaris instead. No personal attack/affront was intended. -Paul On Wed, Nov 14, 2012 at 7:10 PM, Larry Bakerwrote: > Paul, > > 1) I wasn't trying to solve the --version issue, only the parsing of the > response. > 2) I assumed from the initial e-mail that the broken parser was in a Perl > script. I'm not a Perl person, so I wrote the example regular expression > parser in sed. > > These commands were done on my Mac OS X 10.6 system. I have no idea where > the apps came from. I know the sed, at least, does not recognize regular > expressions documented for GNU sed (such as \< \> for begin/end word). > Maybe it is a BSD sed? > > I was just trying to illustrate how to fix the broken parsing of Ralph's > "flex --version". Assuming the RE parser I wrote is satisfactory, it would > have to be adapted to fit in the framework, i.e., it has to be portable. > > Larry Baker > US Geological Survey > 650-329-5608 > ba...@usgs.gov > > > > On 14 Nov 2012, at 5:41 PM, Paul Hargrove wrote: > > On Wed, Nov 14, 2012 at 6:26 PM, Larry Baker wrote: > >> m4 --version | sed -n -E -e >> '1s/^.*[^A-Za-z0-9_-]?([0-9]+[.][0-9]+[.][0-9]+)[^A-Za-z0-9_-]?.*$/\1/p' >> > > > There are STILL problems with this approach as it is TWICE specific to GNU > software: > > 1) M4 on OpenBSD (maybe others) doesn't support a "--version" flag: > $ m4 --version | sed -n -E -e > '1s/^.*[^A-Za-z0-9_-]?([0-9]+[.][0-9]+[.][0-9]+)[^A-Za-z0-9_-]?.*$/\1/p' > m4: unknown option -- - > usage: m4 [-gPs] [-Dname[=value]] [-d flags] [-I dirname] [-o filename] > [-t macro] [-Uname] [file ...] > > 2) sed on Solaris (maybe others) doesn't support a "-E" flag: > $ m4 --version | sed -n -E -e > '1s/^.*[^A-Za-z0-9_-]?([0-9]+[.][0-9]+[.][0-9]+)[^A-Za-z0-9_-]?.*$/\1/p' > /bin/sed: illegal option -- E > > -Paul > > -- > Paul H. Hargrove phhargr...@lbl.gov > Future Technologies Group > Computer and Data Sciences Department Tel: +1-510-495-2352 > Lawrence Berkeley National Laboratory Fax: +1-510-486-6900 > > ___ > devel mailing list > de...@open-mpi.org > http://www.open-mpi.org/mailman/listinfo.cgi/devel > > > -- Paul H. Hargrove phhargr...@lbl.gov Future Technologies Group Computer and Data Sciences Department Tel: +1-510-495-2352 Lawrence Berkeley National Laboratory Fax: +1-510-486-6900
Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk
Ralph, > Ick - usually tools support some kind of version option. :-( In the olden days, -V (big V) was a reasonably standard request for version no. (little V being verbosity). The GHNU command line parsing added the wordy options preceded by double dashes. Unfortunately, gcc does not follow this convention (aargh). > savaii:~ baker$ gcc -V > gcc-4.2: argument to `-V' is missing > savaii:~ baker$ gcc -v > Using built-in specs. > Target: i686-apple-darwin10 > Configured with: /var/tmp/gcc/gcc-5666.3~6/src/configure --disable-checking > --enable-werror --prefix=/usr --mandir=/share/man > --enable-languages=c,objc,c++,obj-c++ > --program-transform-name=/^[cg][^.-]*$/s/$/-4.2/ --with-slibdir=/usr/lib > --build=i686-apple-darwin10 --program-prefix=i686-apple-darwin10- > --host=x86_64-apple-darwin10 --target=i686-apple-darwin10 > --with-gxx-include-dir=/include/c++/4.2.1 > Thread model: posix > gcc version 4.2.1 (Apple Inc. build 5666) (dot 3) Larry Baker US Geological Survey 650-329-5608 ba...@usgs.gov
Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk
Paul, 1) I wasn't trying to solve the --version issue, only the parsing of the response. 2) I assumed from the initial e-mail that the broken parser was in a Perl script. I'm not a Perl person, so I wrote the example regular expression parser in sed. These commands were done on my Mac OS X 10.6 system. I have no idea where the apps came from. I know the sed, at least, does not recognize regular expressions documented for GNU sed (such as \< \> for begin/end word). Maybe it is a BSD sed? I was just trying to illustrate how to fix the broken parsing of Ralph's "flex --version". Assuming the RE parser I wrote is satisfactory, it would have to be adapted to fit in the framework, i.e., it has to be portable. Larry Baker US Geological Survey 650-329-5608 ba...@usgs.gov On 14 Nov 2012, at 5:41 PM, Paul Hargrove wrote: > On Wed, Nov 14, 2012 at 6:26 PM, Larry Bakerwrote: > m4 --version | sed -n -E -e > '1s/^.*[^A-Za-z0-9_-]?([0-9]+[.][0-9]+[.][0-9]+)[^A-Za-z0-9_-]?.*$/\1/p' > > > There are STILL problems with this approach as it is TWICE specific to GNU > software: > > 1) M4 on OpenBSD (maybe others) doesn't support a "--version" flag: > $ m4 --version | sed -n -E -e > '1s/^.*[^A-Za-z0-9_-]?([0-9]+[.][0-9]+[.][0-9]+)[^A-Za-z0-9_-]?.*$/\1/p' > m4: unknown option -- - > usage: m4 [-gPs] [-Dname[=value]] [-d flags] [-I dirname] [-o filename] > [-t macro] [-Uname] [file ...] > > 2) sed on Solaris (maybe others) doesn't support a "-E" flag: > $ m4 --version | sed -n -E -e > '1s/^.*[^A-Za-z0-9_-]?([0-9]+[.][0-9]+[.][0-9]+)[^A-Za-z0-9_-]?.*$/\1/p' > /bin/sed: illegal option -- E > > -Paul > > -- > Paul H. Hargrove phhargr...@lbl.gov > Future Technologies Group > Computer and Data Sciences Department Tel: +1-510-495-2352 > Lawrence Berkeley National Laboratory Fax: +1-510-486-6900 > > ___ > devel mailing list > de...@open-mpi.org > http://www.open-mpi.org/mailman/listinfo.cgi/devel
Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk
Ick - usually tools support some kind of version option. :-( I'll give Nathan a chance to work on this tonight. If we can't resolve the problem, I'll revert the m4 check as well. On Nov 14, 2012, at 5:41 PM, Paul Hargrovewrote: > On Wed, Nov 14, 2012 at 6:26 PM, Larry Baker wrote: > m4 --version | sed -n -E -e > '1s/^.*[^A-Za-z0-9_-]?([0-9]+[.][0-9]+[.][0-9]+)[^A-Za-z0-9_-]?.*$/\1/p' > > > There are STILL problems with this approach as it is TWICE specific to GNU > software: > > 1) M4 on OpenBSD (maybe others) doesn't support a "--version" flag: > $ m4 --version | sed -n -E -e > '1s/^.*[^A-Za-z0-9_-]?([0-9]+[.][0-9]+[.][0-9]+)[^A-Za-z0-9_-]?.*$/\1/p' > m4: unknown option -- - > usage: m4 [-gPs] [-Dname[=value]] [-d flags] [-I dirname] [-o filename] > [-t macro] [-Uname] [file ...] > > 2) sed on Solaris (maybe others) doesn't support a "-E" flag: > $ m4 --version | sed -n -E -e > '1s/^.*[^A-Za-z0-9_-]?([0-9]+[.][0-9]+[.][0-9]+)[^A-Za-z0-9_-]?.*$/\1/p' > /bin/sed: illegal option -- E > > -Paul > > -- > Paul H. Hargrove phhargr...@lbl.gov > Future Technologies Group > Computer and Data Sciences Department Tel: +1-510-495-2352 > Lawrence Berkeley National Laboratory Fax: +1-510-486-6900 > > ___ > devel mailing list > de...@open-mpi.org > http://www.open-mpi.org/mailman/listinfo.cgi/devel
Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk
On Wed, Nov 14, 2012 at 6:26 PM, Larry Bakerwrote: > m4 --version | sed -n -E -e > '1s/^.*[^A-Za-z0-9_-]?([0-9]+[.][0-9]+[.][0-9]+)[^A-Za-z0-9_-]?.*$/\1/p' > There are STILL problems with this approach as it is TWICE specific to GNU software: 1) M4 on OpenBSD (maybe others) doesn't support a "--version" flag: $ m4 --version | sed -n -E -e '1s/^.*[^A-Za-z0-9_-]?([0-9]+[.][0-9]+[.][0-9]+)[^A-Za-z0-9_-]?.*$/\1/p' m4: unknown option -- - usage: m4 [-gPs] [-Dname[=value]] [-d flags] [-I dirname] [-o filename] [-t macro] [-Uname] [file ...] 2) sed on Solaris (maybe others) doesn't support a "-E" flag: $ m4 --version | sed -n -E -e '1s/^.*[^A-Za-z0-9_-]?([0-9]+[.][0-9]+[.][0-9]+)[^A-Za-z0-9_-]?.*$/\1/p' /bin/sed: illegal option -- E -Paul -- Paul H. Hargrove phhargr...@lbl.gov Future Technologies Group Computer and Data Sciences Department Tel: +1-510-495-2352 Lawrence Berkeley National Laboratory Fax: +1-510-486-6900
Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk
Ah. I see why it worked for me. I was using the MacPorts flex: vygr:build hjelmn$ type -p flex /opt/local/bin/flex vygr:build hjelmn$ flex --version flex 2.5.35 I will take a look tonight (if you haven't already fixed it) and see if I can improve find_and_check. -Nathan From: devel-boun...@open-mpi.org [devel-boun...@open-mpi.org] on behalf of Ralph Castain [r...@open-mpi.org] Sent: Wednesday, November 14, 2012 4:26 PM To: de...@open-mpi.org Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk Sorry Nathan - I had to revert this out as it broke builds on Mac ML. The problem is that the find_and_check parser looks for parens to find the version number, expecting something like this: $ m4 --version m4 (GNU M4) 1.4.16 or this: $ gcc --version i686-apple-darwin11-llvm-gcc-4.2 (GCC) 4.2.1 However, on Mac ML, you get this for flex: $ flex --version flex 2.5.35 Apple(flex-31) And so the parser incorrectly rejects the flex version. We'll have to come up with a more robust way of getting version numbers so we can do this test. On Nov 12, 2012, at 11:28 PM, svn-commit-mai...@open-mpi.org wrote: > Author: hjelmn (Nathan Hjelm) > Date: 2012-11-13 02:28:10 EST (Tue, 13 Nov 2012) > New Revision: 27601 > URL: https://svn.open-mpi.org/trac/ompi/changeset/27601 > > Log: > enforce minimum flex version in autogen.pl > > Text files modified: > trunk/autogen.pl | 4 > 1 files changed, 4 insertions(+), 0 deletions(-) > > Modified: trunk/autogen.pl > == > --- trunk/autogen.pl Tue Nov 13 02:21:10 2012(r27600) > +++ trunk/autogen.pl 2012-11-13 02:28:10 EST (Tue, 13 Nov 2012) (r27601) > @@ -56,11 +56,13 @@ > my $ompi_automake_version = "1.11.1"; > my $ompi_autoconf_version = "2.65"; > my $ompi_libtool_version = "2.2.6b"; > +my $ompi_flex_version = "2.5.35"; > > # Search paths > my $ompi_autoconf_search = "autoconf"; > my $ompi_automake_search = "automake"; > my $ompi_libtoolize_search = "libtoolize;glibtoolize"; > +my $ompi_flex_search = "flex"; > > # One-time setup > my $username; > @@ -797,6 +799,7 @@ >GNU Autoconf: $ompi_autoconf_version >GNU Automake: $ompi_automake_version >GNU Libtool: $ompi_libtool_version > +Flex: $ompi_flex_version > =\n"; >my_exit(1); > } > @@ -1015,6 +1018,7 @@ > _and_check("autoconf", $ompi_autoconf_search, $ompi_autoconf_version); > _and_check("libtool", $ompi_libtoolize_search, $ompi_libtool_version); > _and_check("automake", $ompi_automake_search, $ompi_automake_version); > +_and_check("flex", $ompi_flex_search, $ompi_flex_version); > > #--- > > ___ > svn mailing list > s...@open-mpi.org > http://www.open-mpi.org/mailman/listinfo.cgi/svn ___ devel mailing list de...@open-mpi.org http://www.open-mpi.org/mailman/listinfo.cgi/devel
Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk
Ralph, Try sed -n -E -e '1s/^.*[^A-Za-z0-9_-]?([0-9]+[.][0-9]+[.][0-9]+)[^A-Za-z0-9_-]?.*$/\1/p' (or its equivalent in Perl). -n = Don't print out lines that do not match the pattern -E = Telsl sed to recognize + pattern = .. (no attempt to rule out nonsense like 0.0.0) > savaii:~ baker$ m4 --version > GNU M4 1.4.6 > Copyright (C) 2006 Free Software Foundation, Inc. > This is free software; see the source for copying conditions. There is NO > warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. > > Written by Rene' Seindal. > > savaii:~ baker$ m4 --version | sed -n -E -e > '1s/^.*[^A-Za-z0-9_-]?([0-9]+[.][0-9]+[.][0-9]+)[^A-Za-z0-9_-]?.*$/\1/p' > 1.4.6 > savaii:~ baker$ gcc --version > i686-apple-darwin10-gcc-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5666) (dot 3) > Copyright (C) 2007 Free Software Foundation, Inc. > This is free software; see the source for copying conditions. There is NO > warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. > > savaii:~ baker$ gcc --version | sed -n -E -e > '1s/^.*[^A-Za-z0-9_-]?([0-9]+[.][0-9]+[.][0-9]+)[^A-Za-z0-9_-]?.*$/\1/p' > 4.2.1 > savaii:~ baker$ flex --version > flex 2.5.35 > > savaii:~ baker$ flex --version | sed -n -E -e > '1s/^.*[^A-Za-z0-9_-]?([0-9]+[.][0-9]+[.][0-9]+)[^A-Za-z0-9_-]?.*$/\1/p' > 2.5.35 To match Ralph's sample failure: > savaii:~ baker$ echo "flex 2.5.35 Apple(flex-31)" | sed -n -E -e > '1s/^.*[^A-Za-z0-9_-]?([0-9]+[.][0-9]+[.][0-9]+)[^A-Za-z0-9_-]?.*$/\1/p' > 2.5.35 Larry Baker US Geological Survey 650-329-5608 ba...@usgs.gov On 14 Nov 2012, at 3:26 PM, Ralph Castain wrote: > Sorry Nathan - I had to revert this out as it broke builds on Mac ML. The > problem is that the find_and_check parser looks for parens to find the > version number, expecting something like this: > > $ m4 --version > m4 (GNU M4) 1.4.16 > > or this: > > $ gcc --version > i686-apple-darwin11-llvm-gcc-4.2 (GCC) 4.2.1 > > However, on Mac ML, you get this for flex: > > $ flex --version > flex 2.5.35 Apple(flex-31) > > And so the parser incorrectly rejects the flex version. We'll have to come up > with a more robust way of getting version numbers so we can do this test. > > > > On Nov 12, 2012, at 11:28 PM, svn-commit-mai...@open-mpi.org wrote: > >> Author: hjelmn (Nathan Hjelm) >> Date: 2012-11-13 02:28:10 EST (Tue, 13 Nov 2012) >> New Revision: 27601 >> URL: https://svn.open-mpi.org/trac/ompi/changeset/27601 >> >> Log: >> enforce minimum flex version in autogen.pl >> >> Text files modified: >> trunk/autogen.pl | 4 >> 1 files changed, 4 insertions(+), 0 deletions(-) >> >> Modified: trunk/autogen.pl >> == >> --- trunk/autogen.pl Tue Nov 13 02:21:10 2012(r27600) >> +++ trunk/autogen.pl 2012-11-13 02:28:10 EST (Tue, 13 Nov 2012) (r27601) >> @@ -56,11 +56,13 @@ >> my $ompi_automake_version = "1.11.1"; >> my $ompi_autoconf_version = "2.65"; >> my $ompi_libtool_version = "2.2.6b"; >> +my $ompi_flex_version = "2.5.35"; >> >> # Search paths >> my $ompi_autoconf_search = "autoconf"; >> my $ompi_automake_search = "automake"; >> my $ompi_libtoolize_search = "libtoolize;glibtoolize"; >> +my $ompi_flex_search = "flex"; >> >> # One-time setup >> my $username; >> @@ -797,6 +799,7 @@ >> GNU Autoconf: $ompi_autoconf_version >> GNU Automake: $ompi_automake_version >> GNU Libtool: $ompi_libtool_version >> +Flex: $ompi_flex_version >> =\n"; >> my_exit(1); >> } >> @@ -1015,6 +1018,7 @@ >> _and_check("autoconf", $ompi_autoconf_search, $ompi_autoconf_version); >> _and_check("libtool", $ompi_libtoolize_search, $ompi_libtool_version); >> _and_check("automake", $ompi_automake_search, $ompi_automake_version); >> +_and_check("flex", $ompi_flex_search, $ompi_flex_version); >> >> #--- >> >> ___ >> svn mailing list >> s...@open-mpi.org >> http://www.open-mpi.org/mailman/listinfo.cgi/svn > > > ___ > devel mailing list > de...@open-mpi.org > http://www.open-mpi.org/mailman/listinfo.cgi/devel
Re: [OMPI devel] [OMPI svn] svn:open-mpi r27601 - trunk
Sorry Nathan - I had to revert this out as it broke builds on Mac ML. The problem is that the find_and_check parser looks for parens to find the version number, expecting something like this: $ m4 --version m4 (GNU M4) 1.4.16 or this: $ gcc --version i686-apple-darwin11-llvm-gcc-4.2 (GCC) 4.2.1 However, on Mac ML, you get this for flex: $ flex --version flex 2.5.35 Apple(flex-31) And so the parser incorrectly rejects the flex version. We'll have to come up with a more robust way of getting version numbers so we can do this test. On Nov 12, 2012, at 11:28 PM, svn-commit-mai...@open-mpi.org wrote: > Author: hjelmn (Nathan Hjelm) > Date: 2012-11-13 02:28:10 EST (Tue, 13 Nov 2012) > New Revision: 27601 > URL: https://svn.open-mpi.org/trac/ompi/changeset/27601 > > Log: > enforce minimum flex version in autogen.pl > > Text files modified: > trunk/autogen.pl | 4 > 1 files changed, 4 insertions(+), 0 deletions(-) > > Modified: trunk/autogen.pl > == > --- trunk/autogen.pl Tue Nov 13 02:21:10 2012(r27600) > +++ trunk/autogen.pl 2012-11-13 02:28:10 EST (Tue, 13 Nov 2012) (r27601) > @@ -56,11 +56,13 @@ > my $ompi_automake_version = "1.11.1"; > my $ompi_autoconf_version = "2.65"; > my $ompi_libtool_version = "2.2.6b"; > +my $ompi_flex_version = "2.5.35"; > > # Search paths > my $ompi_autoconf_search = "autoconf"; > my $ompi_automake_search = "automake"; > my $ompi_libtoolize_search = "libtoolize;glibtoolize"; > +my $ompi_flex_search = "flex"; > > # One-time setup > my $username; > @@ -797,6 +799,7 @@ >GNU Autoconf: $ompi_autoconf_version >GNU Automake: $ompi_automake_version >GNU Libtool: $ompi_libtool_version > +Flex: $ompi_flex_version > =\n"; >my_exit(1); > } > @@ -1015,6 +1018,7 @@ > _and_check("autoconf", $ompi_autoconf_search, $ompi_autoconf_version); > _and_check("libtool", $ompi_libtoolize_search, $ompi_libtool_version); > _and_check("automake", $ompi_automake_search, $ompi_automake_version); > +_and_check("flex", $ompi_flex_search, $ompi_flex_version); > > #--- > > ___ > svn mailing list > s...@open-mpi.org > http://www.open-mpi.org/mailman/listinfo.cgi/svn