Re: [PATCH 07/12] bsps: Avoid line continuation in Makefile.am

[Chris Johns]

On 12/04/2018 14:58, Sebastian Huber wrote:
> On 11/04/18 23:09, Chris Johns wrote:
>> Is it a requirement for Makefile.am we avoid line continuation?
> 
> For the source moves in the BSP tree I need Makefile.am which are friendly for
> automatic modification. The line continuation makes this a little bit more
> difficult.

I use the class at the top of this file to make bulk changes these days:

 https://ftp.rtems.org/pub/rtems/people/chrisj/test-am-convert

I used it for the preinstall work and now the testsuite change. It handles line
continuation, insert, delete, you can find something and then do a range of
edits. The script took me to within a few % of the completing the testsuite
task, the mp_tests I did by hand.

> 
>>
>> I had a choice and wrapped lines in the testsuites and without any 
>> guidelines I
>> choose a more compact format. It was easy to do with python's textwrap 
>> module.
>>
>> At some point I think it would be good to collect together what we want to do
>> with Makefile.am files as some form of a coding standard. I have some things
>> that might go in like conditionals ..
>>
>>   https://lists.rtems.org/pipermail/devel/2018-April/020889.html
> 
> I think we should focus on waf guidelines. The Makefile.am are a dead man 
> walking.
> 

Agreed.

Chris
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH 07/12] bsps: Avoid line continuation in Makefile.am

[Sebastian Huber]

On 11/04/18 23:09, Chris Johns wrote:

Is it a requirement for Makefile.am we avoid line continuation?


For the source moves in the BSP tree I need Makefile.am which are 
friendly for automatic modification. The line continuation makes this a 
little bit more difficult.




I had a choice and wrapped lines in the testsuites and without any guidelines I
choose a more compact format. It was easy to do with python's textwrap module.

At some point I think it would be good to collect together what we want to do
with Makefile.am files as some form of a coding standard. I have some things
that might go in like conditionals ..

  https://lists.rtems.org/pipermail/devel/2018-April/020889.html


I think we should focus on waf guidelines. The Makefile.am are a dead 
man walking.


--
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail  : sebastian.hu...@embedded-brains.de
PGP : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH 07/12] bsps: Avoid line continuation in Makefile.am

[Joel Sherrill]

On Wed, Apr 11, 2018 at 4:09 PM, Chris Johns  wrote:

> Is it a requirement for Makefile.am we avoid line continuation?
>
> I had a choice and wrapped lines in the testsuites and without any
> guidelines I
> choose a more compact format. It was easy to do with python's textwrap
> module.
>

I think it is nicer looking for the BSP Makefile.am's to use one source
file per line.

For the test Makefile.am's I don't know.

I think it is funny that Sebastian posted this patch. I recall doing this
in some
BSPs years ago and being told that it was a waste of time. :)


>
> At some point I think it would be good to collect together what we want to
> do
> with Makefile.am files as some form of a coding standard. I have some
> things
> that might go in like conditionals ..
>
>  https://lists.rtems.org/pipermail/devel/2018-April/020889.html


This is a good start. It covers a lot of ground.

>
>
> Chris
> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH 07/12] bsps: Avoid line continuation in Makefile.am

[Chris Johns]

Is it a requirement for Makefile.am we avoid line continuation?

I had a choice and wrapped lines in the testsuites and without any guidelines I
choose a more compact format. It was easy to do with python's textwrap module.

At some point I think it would be good to collect together what we want to do
with Makefile.am files as some form of a coding standard. I have some things
that might go in like conditionals ..

 https://lists.rtems.org/pipermail/devel/2018-April/020889.html

Chris
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel