Re: [Development] Status on Qt 5.1 merges from dev -> stable
On 26/03/2013, at 1:30 AM, Thiago Macieira wrote: > On segunda-feira, 25 de março de 2013 10.46.50, Sergio Ahumada wrote: >> Next step is to get qt5.git updated and add qtquickcontrols, qtsensors, >> qtserialport and qtx11extras to it. > > Shouldn't we do an API review on those before we add them? Or is it ok to > drop > them from beta (after alpha) if we find we don't actually want to release > them, > for whatever reason? qtsensors has already been released for 3 years now (QtMobility), it's API has already been reviewed. and tested. in production. > -- > Thiago Macieira - thiago.macieira (AT) intel.com > Software Architect - Intel Open Source Technology Center > ___ > Development mailing list > Development@qt-project.org > http://lists.qt-project.org/mailman/listinfo/development Lorn Potter Senior Software Engineer, QtSensors/QtSensorGestures ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Status on Qt 5.1 merges from dev -> stable
On segunda-feira, 25 de março de 2013 17.05.12, Frederik Gladhorn wrote: > Mandag 25. mars 2013 08.30.45 skrev Thiago Macieira: > > On segunda-feira, 25 de março de 2013 10.46.50, Sergio Ahumada wrote: > > > Next step is to get qt5.git updated and add qtquickcontrols, qtsensors, > > > qtserialport and qtx11extras to it. > > > > Shouldn't we do an API review on those before we add them? Or is it ok to > > drop them from beta (after alpha) if we find we don't actually want to > > release them, for whatever reason? > > For the qtquickcontrols we have been reviewing the API as much as possible > in the team working on them in Digia. Of course we'd like to get more > feedback, please go ahead with a review. > > This is an interesting question though, how do we make an API review for a > module? On the mailing list is most likely not the most efficient way. I simply asked to be sure that the review was done with someone experienced. I think it's fine if two (or more) people who can meet each other other face to face do it that way. Think of it as a clean bill of health. I'd like to see the same from QA, that the level of unit testing is acceptable. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center signature.asc Description: This is a digitally signed message part. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Status on Qt 5.1 merges from dev -> stable
On 3/25/13 7:13 PM, "Laszlo Papp" wrote: >> qtx11extras and qtserialport didn't need a merge, since they didn't have >dev/stable branches. > >We got that sorted out a couple of days ago, but it does not require any >work for the moment as stable got branched off master. Then, we just >began to follow the Qt branching model. > > >On 25 March 2013 15:30, Thiago Macieira wrote: > >> On segunda-feira, 25 de março de 2013 10.46.50 , >>Sergio Ahumada wrote: >>> Next step is to get qt5.git updated and add qtquickcontrols, qtsensors, >>> qtserialport and qtx11extras to it. >> >> Shouldn't we do an API review on those before we add them? Or is it ok >>to drop >> them from beta (after alpha) if we find we don't actually want to >>release them, >> for whatever reason? > > > > >QtSerialPort has already been reviewed on this mailing list, but I would >personally encourage everyone to take a (yet another) look at it if you >have time. Thank you. Yes, Qt Serialport has seen some reviews, so while more eyes won't hurt, I feel comfortable with it as is as well. Qt Quick Controls has also seen some reviews, so I believe we're now mostly in a situation where we need people to test (ie. have it as part of a beta) to fine tune things. Cheers, Lars ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Status on Qt 5.1 merges from dev -> stable
Hi, A this point in time, I think it is better to plan for dropping those parts from Beta we for some reason do not want to include to release. That said, reviews can be done already now if some part still needs it. We are just so close to Alpha that there is not time any more to do much before it. And definitely postponing Alpha is a bad idea at this point in time when we are just about there. Yours, Tuukka Lähettäjä: development-bounces+tuukka.turunen=digia@qt-project.org [development-bounces+tuukka.turunen=digia@qt-project.org] käyttäjän Laszlo Papp [lp...@kde.org] puolesta Lähetetty: 25. maaliskuuta 2013 20:13 Vastaanottaja: development@qt-project.org Cc: releas...@qt-project.org Aihe: Re: [Development] Status on Qt 5.1 merges from dev -> stable > qtx11extras and qtserialport didn't need a merge, since they didn't have > dev/stable branches. We got that sorted out a couple of days ago, but it does not require any work for the moment as stable got branched off master. Then, we just began to follow the Qt branching model. On 25 March 2013 15:30, Thiago Macieira mailto:thiago.macie...@intel.com>> wrote: > On segunda-feira, 25 de março de 2013 10.46.50, Sergio > Ahumada wrote: >> Next step is to get qt5.git updated and add qtquickcontrols, qtsensors, >> qtserialport and qtx11extras to it. > > Shouldn't we do an API review on those before we add them? Or is it ok to drop > them from beta (after alpha) if we find we don't actually want to release > them, > for whatever reason? QtSerialPort has already been reviewed on this mailing list, but I would personally encourage everyone to take a (yet another) look at it if you have time. Thank you. Laszlo ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Status on Qt 5.1 merges from dev -> stable
> qtx11extras and qtserialport didn't need a merge, since they didn't have dev/stable branches. We got that sorted out a couple of days ago, but it does not require any work for the moment as stable got branched off master. Then, we just began to follow the Qt branching model. On 25 March 2013 15:30, Thiago Macieira wrote: > > On segunda-feira, 25 de março de 2013 10.46.50, Sergio Ahumada wrote: > >> Next step is to get qt5.git updated and add qtquickcontrols, qtsensors, > >> qtserialport and qtx11extras to it. > > > > Shouldn't we do an API review on those before we add them? Or is it ok > to drop > > them from beta (after alpha) if we find we don't actually want to > release them, > > for whatever reason? > QtSerialPort has already been reviewed on this mailing list, but I would personally encourage everyone to take a (yet another) look at it if you have time. Thank you. Laszlo ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Status on Qt 5.1 merges from dev -> stable
On 25 March 2013 15:30, Thiago Macieira wrote: > On segunda-feira, 25 de março de 2013 10.46.50, Sergio Ahumada wrote: >> Next step is to get qt5.git updated and add qtquickcontrols, qtsensors, >> qtserialport and qtx11extras to it. > > Shouldn't we do an API review on those before we add them? Or is it ok to drop > them from beta (after alpha) if we find we don't actually want to release > them, > for whatever reason? Probably not needed for qtx11extras since at the moment it just brings back the QX11Info class from Qt 4. The only new method is an accessor for the XCB connection. For the others an API review is a good idea, though I've already done some review on qtserialport. Cheers Rich. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Status on Qt 5.1 merges from dev -> stable
Mandag 25. mars 2013 08.30.45 skrev Thiago Macieira: > On segunda-feira, 25 de março de 2013 10.46.50, Sergio Ahumada wrote: > > Next step is to get qt5.git updated and add qtquickcontrols, qtsensors, > > qtserialport and qtx11extras to it. > > Shouldn't we do an API review on those before we add them? Or is it ok to > drop them from beta (after alpha) if we find we don't actually want to > release them, for whatever reason? For the qtquickcontrols we have been reviewing the API as much as possible in the team working on them in Digia. Of course we'd like to get more feedback, please go ahead with a review. This is an interesting question though, how do we make an API review for a module? On the mailing list is most likely not the most efficient way. -- Best regards, Frederik Gladhorn Senior Software Engineer - Digia, Qt Visit us on: http://qt.digia.com ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Status on Qt 5.1 merges from dev -> stable
On segunda-feira, 25 de março de 2013 10.46.50, Sergio Ahumada wrote: > Next step is to get qt5.git updated and add qtquickcontrols, qtsensors, > qtserialport and qtx11extras to it. Shouldn't we do an API review on those before we add them? Or is it ok to drop them from beta (after alpha) if we find we don't actually want to release them, for whatever reason? -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center signature.asc Description: This is a digitally signed message part. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
[Development] Status on Qt 5.1 merges from dev -> stable
Hi, All merges from dev into stable needed for 5.1 have gone through now. - qtactiveqt - qtbase - qtdeclarative - qtdoc - qtgraphicaleffects - qtimageformats - qtjsbackend - qtmultimedia - qtquick1 - qtquickcontrols - qtscript - qtsensors - qtsvg - qttools - qttranslations - qtwebkit - qtwebkit-examples-and-demos - qtxmlpatterns qtx11extras and qtserialport didn't need a merge, since they didn't have dev/stable branches. Next step is to get qt5.git updated and add qtquickcontrols, qtsensors, qtserialport and qtx11extras to it. Thanks to everybody who helped with getting this done. Cheers, -- Sergio Ahumada Release Engineer - Digia, Qt ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
[Development] Status on Qt 5.1 merges from dev -> stable
Hi, Some merges have gone through already: - QtActiveQt - QtDoc - QtGraphicalEffects - QtImageFormats but some others are failing, this is the case of QtMultimedia. Who feels responsible or can take a look at the failing autotest? Is it a genuine failure or just yet another flaky test ? Can it be fixed or marked as insignificant ? More info here https://codereview.qt-project.org/51340 Cheers, -- Sergio Ahumada Release Engineer - Digia, Qt ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
