Re: Fellow Reports - December 2018

[Tim Graham]

Week ending December 29, 2018

Triaged

---

https://code.djangoproject.com/ticket/30052 - QuerySet.only() doesn't 
support annotations (invalid)

https://code.djangoproject.com/ticket/30049 - GIS widgets don't initialize 
properly after clicking "Add another" in admin inlines (accepted)

https://code.djangoproject.com/ticket/30064 - Admin search with a null 
character crashes with "A string literal cannot contain NUL (0x00) 
characters." on PostgreSQL (accepted)

Authored

--

https://github.com/django/django/pull/10795 - Refs #30033 -- Fixed schema's 
test_m2m_rename_field_in_target_model test failure on SQLite < 3.20.

https://github.com/django/django/pull/10798 - Bootstrapped Django 3.0.

Reviewed/committed

--
https://github.com/django/django/pull/10783 - Fixed #30056 -- Added SQLite 
support for StdDev and Variance functions.

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/118fe0bf-8361-46a8-9a91-ae731431e407%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: CSRF Middlware and usage of request attributes (META, csrf_cookie_needs_reset)

[Florian Apolloner]

Hi Adam,

On Saturday, December 29, 2018 at 7:59:44 PM UTC+1, Adam Johnson wrote:
>
> since request.META is always there whilst attributes might not be if the 
> middleware aren't set up properly?
>

request.META is always there, but the keys inside there might not be. In 
that sense you have to do "key in request.META" like we do with 
"hasattr(request, key)" if you are not sure on whether process_request of 
the middleware did actually set that stuff.
 

> It seems like it could just be oversight. I would think that moving would 
> require a standard deprecation period.
>

Unless we documented the attributes/keys I'd consider it an implementation 
detail of the middleware. 

Cheers,
Florian

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/fa76d5eb-68c6-4f9d-859d-3eb48011ae23%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: CSRF Middlware and usage of request attributes (META, csrf_cookie_needs_reset)

[Adam Johnson]

It looks like it dates back to the Django 1.1 refactor and extension in
https://github.com/django/django/commit/8e70cef9b67433edd70935dcc30c621d1e7fc0a0
ticket #9977, for which the referred wiki page (
https://code.djangoproject.com/wiki/CsrfProtection) is still up too with
rationales about the design. I can't find any discussion about request.META
vs attributes though, but since the move in the commit was from two
middlewares to a unified one, maybe it was to do with that, since
request.META is always there whilst attributes might not be if the
middleware aren't set up properly? It seems like it could just be
oversight. I would think that moving would require a standard deprecation
period.

On Sat, 29 Dec 2018 at 11:47, Florian Apolloner 
wrote:

> Hi there,
>
> I am considering rewriting and (hopefully) simplifying the CSRF
> middleware. While looking through the code I realized that we put stuff
> into request.META as well as attributes on the request object itself
> (csrf_cookie_needs_reset) for instance. Is there any reason why we do not
> stick to one format?
>
> Or more generally put: When should middlewares write into META as opposed
> to a attribute.
>
> Cheers,
> Florian
>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To post to this group, send email to django-developers@googlegroups.com.
> Visit this group at https://groups.google.com/group/django-developers.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/43f6d8da-c66c-4100-a6d6-e85d4cef3684%40googlegroups.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>


-- 
Adam

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAMyDDM2OPG%3DZo_NG5WScJNq4RwVgAttgdWHJ27u45onr8XQ5tw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: New Developer

[charettes]

Hello there,

You should find all you need from the contributing guide[0] but since you 
just started using Django it might be hard to contribute until you get more 
familiar with the framework.

This mailing list is dedicated to development of Django itself such as 
getting feedback for new features idea or gather consensus about how a long 
standing bug should be dealt with. I suggest you have a look at 
django-core-mentorship[1] mailing list to get further help instead of 
posting here.

Cheers,
Simon

[0] https://docs.djangoproject.com/en/2.1/internals/contributing/
[1] https://groups.google.com/forum/#!forum/django-core-mentorship

Le samedi 29 décembre 2018 10:21:53 UTC-5, Surajeet Das a écrit :
>
> I am a newbie to Django . I recently used it to create a website .But I am 
> interested in contributing to Django . How do I start helping ?
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/6f86e17f-84fa-4c44-820b-06ed3a80510a%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

New Developer

[Surajeet Das]

I am a newbie to Django . I recently used it to create a website .But I am 
interested in contributing to Django . How do I start helping ?

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/44806b6d-4da1-44ce-9108-c2845fdf7cc1%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

CSRF Middlware and usage of request attributes (META, csrf_cookie_needs_reset)

[Florian Apolloner]

Hi there,

I am considering rewriting and (hopefully) simplifying the CSRF middleware. 
While looking through the code I realized that we put stuff into 
request.META as well as attributes on the request object itself 
(csrf_cookie_needs_reset) for instance. Is there any reason why we do not 
stick to one format?

Or more generally put: When should middlewares write into META as opposed 
to a attribute.

Cheers,
Florian

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/43f6d8da-c66c-4100-a6d6-e85d4cef3684%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.