date:20240113

Re: [Django] #35107: How to write a management command that reads from stdin should be documented

2024-01-13 Thread Django

* status: assigned => closed
* type: Uncategorized => Cleanup/optimization
* resolution: => wontfix
* easy: 1 => 0

Comment:

Replying to [ticket:35107 Andrew Northall]:
> I hear you say, 'but reading from stdin is a Python feature, not a
Django feature, why should we document it?'.

Thanks for the ticket, however, we cannot document everything.

> In my mind, the documentation as it exists now could lead to confusion:
it makes specific mention that you should use `BaseCommand.stdout` and
`BaseCommand.stderr` within a management command to write to stdout or
stderr. It is not a big jump to then assume that you should also be using
`BaseCommand.stdin` (which does not exist) to handle incoming data. The
API, in this narrow sense, is inconsistent, and this is why the
documentation would be helpful.

I don't see anything inconsistency in API or docs. We don't document
nonexistent attributes, and users cannot assume that attributes exist if
they are not documented. In management commands you can use `sys.stdin`
like everywhere else, there is nothing specific that they provide. You can
start a discussion on DevelopersMailingList if you don't agree.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/0107018d06f6d723-520ffcf4-4a1c-4c6d-8d15-19abf1bcf987-00%40eu-central-1.amazonses.com.

Re: [Django] #35111: DateField's range and in lookups against expressions produce invalid values on SQLite.

2024-01-13 Thread Django

#35111: DateField's __range and __in lookups against expressions produce invalid
values on SQLite.
-+-
 Reporter:  Simon Charette   |Owner:  Simon
 |  Charette
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  5.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * owner:  nobody => Simon Charette
 * status:  new => assigned
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d06eda597-d190a8f0-de40-445a-8989-4388c3b866ca-00%40eu-central-1.amazonses.com.

Re: [Django] #33650: Update startproject template with config directory

2024-01-13 Thread Django

#33650: Update startproject template with config directory
-+-
 Reporter:  Timothy Allen|Owner:  (none)
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Core (Management |  Version:  dev
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:  startproject,| Triage Stage:
  template   |  Someday/Maybe
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * owner:  Salaah Amin => (none)
 * status:  assigned => new
 * has_patch:  1 => 0
 * stage:  Accepted => Someday/Maybe


Comment:

 Please don't accept tickets, for which discussion has been requested.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d06eb7c18-039786ec-063f-48ee-8b13-b718e6ce9e2a-00%40eu-central-1.amazonses.com.

Re: [Django] #33650: Update startproject template with config directory

2024-01-13 Thread Django

#33650: Update startproject template with config directory
-+-
 Reporter:  Timothy Allen|Owner:  Salaah
 Type:   |  Amin
  Cleanup/optimization   |   Status:  assigned
Component:  Core (Management |  Version:  dev
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:  startproject,| Triage Stage:  Accepted
  template   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Salaah Amin):

 * stage:  Ready for checkin => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d066420a1-1abeb20f-5624-454d-8ff1-ae81bb330a27-00%40eu-central-1.amazonses.com.

Re: [Django] #33650: Update startproject template with config directory

2024-01-13 Thread Django

#33650: Update startproject template with config directory
-+-
 Reporter:  Timothy Allen|Owner:  Salaah
 Type:   |  Amin
  Cleanup/optimization   |   Status:  assigned
Component:  Core (Management |  Version:  dev
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:  startproject,| Triage Stage:  Ready for
  template   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Salaah Amin):

 * cc: Salaah Amin (added)
 * stage:  Someday/Maybe => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d06627a3c-c52864e9-7da1-4863-8ce1-139a37e08c3d-00%40eu-central-1.amazonses.com.

Re: [Django] #35095: Monetary values in Switzerland discrepancy

2024-01-13 Thread Django

#35095: Monetary values in Switzerland discrepancy
-+-
 Reporter:  Andrea Angelini  |Owner:  Neil
 Type:   |  Pendyala
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  5.0
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Alexander Lazarević):

 So finally I vote to change the comment from:

 {{{
 # these are the separators for non-monetary numbers. For monetary numbers,
 # the DECIMAL_SEPARATOR is a . (decimal point) and the THOUSAND_SEPARATOR
 is a
 # , (comma).
 }}}

 to:

 {{{
 # These are the separators for non-monetary numbers.
 # The decimal separator for monetary numbers is a . (decimal point), but
 Django
 # will always use DECIMAL_SEPARATOR for any number.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d05f4a586-2c43118c-f488-4c83-aab2-f7d6b3dd7308-00%40eu-central-1.amazonses.com.

Re: [Django] #35095: Monetary values in Switzerland discrepancy

2024-01-13 Thread Django

#35095: Monetary values in Switzerland discrepancy
-+-
 Reporter:  Andrea Angelini  |Owner:  Neil
 Type:   |  Pendyala
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  5.0
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Alexander Lazarević):

 Well, on the other hand when I look at latest
 /usr/share/i18n/locales/de_CH on my system, it seems to be outdated as
 well and no help on the question:

 {{{
 ...
 date   "2007-09-23"
 ...
 LC_MONETARY
 int_curr_symbol   "CHF "
 currency_symbol   "CHF"
mon_decimal_point "."
mon_thousands_sep ""
 mon_grouping  3;3
 positive_sign ""
 negative_sign "-"
 int_frac_digits   2
 frac_digits   2
 p_cs_precedes 1
 p_sep_by_space1
 n_cs_precedes 1
 n_sep_by_space1
 p_sign_posn   4
 n_sign_posn   4
 END LC_MONETARY

 LC_NUMERIC
   decimal_point "."
   thousands_sep ""
 grouping  3;3
 END LC_NUMERIC

 }}}

 With ' (U+2019 RIGHT SINGLE QUOTATION MARK)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d05e36b26-94727ac4-817a-4f92-82d0-a20345db396a-00%40eu-central-1.amazonses.com.

Re: [Django] #35095: Monetary values in Switzerland discrepancy

2024-01-13 Thread Django

#35095: Monetary values in Switzerland discrepancy
-+-
 Reporter:  Andrea Angelini  |Owner:  Neil
 Type:   |  Pendyala
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  5.0
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Alexander Lazarević):

 Replying to [comment:16 Claude Paroz]:
 > This formatting difference is a Swiss peculiarity, AFAIK.

 And as far as I can tell there is also difference when formatting monetary
 values given in Franken or Rappen. So it's **Fr. 15.40** but **0,13 Rp.**

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d05d77526-8d2aadbb-bbe7-4d6f-b73c-bf6add472c89-00%40eu-central-1.amazonses.com.

Re: [Django] #35095: Monetary values in Switzerland discrepancy

2024-01-13 Thread Django

#35095: Monetary values in Switzerland discrepancy
-+-
 Reporter:  Andrea Angelini  |Owner:  Neil
 Type:   |  Pendyala
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  5.0
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Alexander Lazarević):

 Replying to [comment:12 Mariusz Felisiak]:
 > This PR is not about values used by Django, it's about comments and
 docs. Please check previous
 [https://code.djangoproject.com/ticket/35095?replyto=9#comment:3
 comments].

 That was my understanding from the beginning and I commented accordingly
 in the PR. Sorry for not being clear about that here.

 > However, both docs and comments mention that for **monetary values**
 format is different. The question is, should we change a comment to the:
 > > "For monetary numbers, the DECIMAL_SEPARATOR is a . (decimal point)
 and the THOUSAND_SEPARATOR is **a , (comma).**"
 > or should we change docs to the:
 > > "For monetary values, a **single quote** is used as the thousand
 separator and a decimal point for the decimal separator."

 Here I disagree, because from what I read in the referred official
 document there is **no special thousand separator for monetary values**.
 So my suggestion in the PR was to change the comment (and docs) to:
 > "For monetary numbers, the DECIMAL_SEPARATOR is a . (decimal point)."

 But maybe others can point me to the definition of a special thousand
 separator for monetary values in the referred document? I wasn't able to
 find one skimming the doc.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d05cf2301-125756b4-9f51-40b0-bec6-6e0feda5cbf7-00%40eu-central-1.amazonses.com.

Re: [Django] #33650: Update startproject template with config directory

2024-01-13 Thread Django

#33650: Update startproject template with config directory
-+-
 Reporter:  Timothy Allen|Owner:  Salaah
 Type:   |  Amin
  Cleanup/optimization   |   Status:  assigned
Component:  Core (Management |  Version:  dev
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:  startproject,| Triage Stage:
  template   |  Someday/Maybe
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Salaah Amin):

 * owner:  nobody => Salaah Amin
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d058be40f-0c1eeb30-b3a5-441e-836f-d7966f4c6132-00%40eu-central-1.amazonses.com.

Re: [Django] #35111: DateField's range and in lookups against expressions produce invalid values on SQLite.

2024-01-13 Thread Django

#35111: DateField's __range and __in lookups against expressions produce invalid
values on SQLite.
-+-
 Reporter:  Simon Charette   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  5.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Simon Charette):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d04b2879b-07928ab9-fc0b-442a-aebf-0e66b3c7c832-00%40eu-central-1.amazonses.com.

[Django] #35111: DateField's range and in lookups against expressions produce invalid values on SQLite.

2024-01-13 Thread Django

#35111: DateField's __range and __in lookups against expressions produce invalid
values on SQLite.
-+-
   Reporter:  Simon  |  Owner:  nobody
  Charette   |
   Type:  Bug| Status:  new
  Component:  Database   |Version:  5.0
  layer (models, ORM)|
   Severity:  Normal |   Keywords:
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 #22288 (4f138fe5a496a81115c4fba6615a517fc62c3b17) only partially addressed
 the issue of iterable right-hand-side lookups (`__range` and `__in`) by
 adapting Oracle's and SQLite operation modules to special case the
 adaptation of datetime and time value while missing that date values are
 still converted to string.

 This causes queries of the form

 {{{#!python
 Person.objects.filter(
 dob__between=(F("dob"), F("dob"))
 )
 }}}

 To be turned into

 {{{#!sql
 SELECT * FROM person WHERE dob BETWEEN "Col('dob')" AND "Col('dob')"
 }}}

 I believe the fundamental flaw in 4f138fe5a496a81115c4fba6615a517fc62c3b17
 is that expressions (`hasattr(obj, "resolve_expression")`) should never be
 passed to `Field.get_db_prep_value` in the first place during the
 `Lookup`'s right-hand-side ''processing'' phase just like they are not
 passed to `Field.get_prep_value`
 
[https://github.com/django/django/blob/92d6cff6a2fee7a3f9244081b84fd82c50cc71aa/django/db/models/lookups.py#L287-L295
 during the preparation phase].

 Initially discovered on [https://forum.djangoproject.com/t/range-lookup-
 with-complex-expressions/26795/7 the forum] by Joel Feiner.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d04ad275a-1fd3bdac-c0a5-469f-8157-ac07c0aeb992-00%40eu-central-1.amazonses.com.

Re: [Django] #35102: Performance regression on Model.objects.count() between Django 4.2 and 5.0

2024-01-13 Thread Django

#35102: Performance regression on Model.objects.count() between Django 4.2 and 
5.0
-+-
 Reporter:  Anthony Shaw |Owner:  (none)
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  5.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Simon Charette):

 * has_patch:  0 => 1


Comment:

 Submitted a PR that confirms [https://github.com/django/django/pull/17730
 the suite is happy with both changes].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d04695662-79b4dc1b-c9ee-4a09-9d3a-61276d9afc1c-00%40eu-central-1.amazonses.com.

Re: [Django] #35107: How to write a management command that reads from stdin should be documented

2024-01-13 Thread Django

#35107: How to write a management command that reads from stdin should be
documented
-+
 Reporter:  Andrew Northall  |Owner:  Richard Zhao
 Type:  Uncategorized|   Status:  assigned
Component:  Documentation|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+
Changes (by Richard Zhao):

 * owner:  nobody => Richard Zhao
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d04321995-6efde2d4-25f0-4fff-a07e-7e0b2ae9f8ca-00%40eu-central-1.amazonses.com.

Re: [Django] #14831: Django Template Style Guide

2024-01-13 Thread Django

#14831: Django Template Style Guide
-+-
 Reporter:  Simon Meers  |Owner:  Ryan
 |  Cheley
 Type:  New feature  |   Status:  assigned
Component:  Documentation|  Version:  1.2
 Severity:  Normal   |   Resolution:
 Keywords:  template, style, | Triage Stage:  Accepted
  format |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Ryan Cheley):

 Looking at the `{% block ... %}` I have this to locate the occurences

 {{{
 find . -name "*.html" ! -path "./venv/*" -exec grep -En
 "\{%\s*block\s+\w+\s*%\}" {} + | awk -F: '$2 > 2 {print "Filename: " $1 ",
 Line number: " $2 ", Matched string: " $3}'
 }}}

 This returns 365 files in 37 directories.

 Further investigation will have to wait until next time though

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d041ed1d7-39eb973a-6bcc-45d0-914c-3c09ffca46ea-00%40eu-central-1.amazonses.com.

Re: [Django] #14831: Django Template Style Guide

2024-01-13 Thread Django

#14831: Django Template Style Guide
-+-
 Reporter:  Simon Meers  |Owner:  Ryan
 |  Cheley
 Type:  New feature  |   Status:  assigned
Component:  Documentation|  Version:  1.2
 Severity:  Normal   |   Resolution:
 Keywords:  template, style, | Triage Stage:  Accepted
  format |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Ryan Cheley):

 Replying to [comment:14 Ryan Cheley]:
 > I moved the `{% load log %}` from line 25 to line 3 and there weren't
 any NEW test failures. Once a standard is decided on this could
 potentially be moved to the top and it doesn't look like any negative
 impact would be introduced (from a testing perspective anyway).
 >
 > Next step is to create a Django app locally and see what happens

 App locally seems to be behaving as expected.

 Also, in reading the docs I was reminded that a `{% load ... %}` can have
 more than one template tag added, so the two outliers here can be moved up
 into a single `{% load ... }` command instead of multiple lines

 This means that

 * /django/contrib/admin/templates/admin/auth/user/change_password.html can
 have line 2 updated to `{% load i18n static admin_urls %}`
 * ./django/contrib/admin/templates/admin/index.html can have line 2
 updated to be `{% load i18n static log %}`

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d040cbd72-25520f98-a4af-4c5a-9eae-d84c9c448cf3-00%40eu-central-1.amazonses.com.

Re: [Django] #14831: Django Template Style Guide

2024-01-13 Thread Django

#14831: Django Template Style Guide
-+-
 Reporter:  Simon Meers  |Owner:  Ryan
 |  Cheley
 Type:  New feature  |   Status:  assigned
Component:  Documentation|  Version:  1.2
 Severity:  Normal   |   Resolution:
 Keywords:  template, style, | Triage Stage:  Accepted
  format |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Ryan Cheley):

 I moved the `{% load log %}` from line 25 to line 3 and there weren't any
 NEW test failures. Once a standard is decided on this could potentially be
 moved to the top and it doesn't look like any negative impact would be
 introduced (from a testing perspective anyway).

 Next step is to create a Django app locally and see what happens

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d03fe4d80-2bf1857b-a5c2-4fdd-9a20-6737ee6a1006-00%40eu-central-1.amazonses.com.

Re: [Django] #14831: Django Template Style Guide

2024-01-13 Thread Django

#14831: Django Template Style Guide
-+-
 Reporter:  Simon Meers  |Owner:  Ryan
 |  Cheley
 Type:  New feature  |   Status:  assigned
Component:  Documentation|  Version:  1.2
 Severity:  Normal   |   Resolution:
 Keywords:  template, style, | Triage Stage:  Accepted
  format |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Ryan Cheley):

 Checking the `{% loads` using this bash command
 {{{
 find . -name "*.html" ! -path "./venv/*" -exec grep -En "\{% load" {} + |
 awk -F: '$2 > 2 {print "Filename: " $1 ", Line number: " $2 ", Matched
 string: " $3}'
 }}}
 returns the following results:

 * Filename:
 ./django/contrib/admin/templates/admin/auth/user/change_password.html,
 Line number: 3, Matched string: {% load admin_urls %}
 * Filename: ./django/contrib/admin/templates/admin/index.html, Line
 number: 25, Matched string: {% load log %}


 The first item is actually OK upon inspection as there are 2 `{% load ...
 }` statements in the file

 The second item `./django/contrib/admin/templates/admin/index.html` has
 `{% load log %}` on line 25. This was first added in commit
 
[https://github.com/django/django/blob/52f5c949e9b50ae3b0034d67f2d385219588aaf1/templates/admin/index.html
 52f5c9] so it's always been lower in the file.

 Next step is to determine if moving the line up will break anything

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d03f3a622-2a72d8a0-69fe-4860-bca8-6e6c3e4aca80-00%40eu-central-1.amazonses.com.

Re: [Django] #14831: Django Template Style Guide

2024-01-13 Thread Django

#14831: Django Template Style Guide
-+-
 Reporter:  Simon Meers  |Owner:  Ryan
 |  Cheley
 Type:  New feature  |   Status:  assigned
Component:  Documentation|  Version:  1.2
 Severity:  Normal   |   Resolution:
 Keywords:  template, style, | Triage Stage:  Accepted
  format |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Ryan Cheley):

 Checking the `{{% extends}}` using this bash command

 ```
 find . -name "*.html" ! -path "./venv/*" -exec grep -n "% extends" {} + |
 awk -F: '$2 > 1 {print "Filename: " $1 ", Line number: " $2 ", Matched
 string: " $3}'
 ```

 returns no results. It looks like the `{{% extends}}` is always at the top
 line of the `html` files

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d03dd816f-b283c6a0-c6c6-43b0-ac33-c143037822fc-00%40eu-central-1.amazonses.com.

Re: [Django] #16752: Multi-db without a 'default' database

2024-01-13 Thread Django

#16752: Multi-db without a 'default' database
-+-
 Reporter:  Jeremy Dunck |Owner:  (none)
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.3
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Ryan Cheley):

 * owner:  Ryan Cheley => (none)
 * status:  assigned => new


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d037eca92-303cdb40-b0bf-4f3e-b3cb-f0a2a72b8f06-00%40eu-central-1.amazonses.com.

Re: [Django] #34036: Low text contrast over light blue backgrounds in admin light theme

2024-01-13 Thread Django

#34036: Low text contrast over light blue backgrounds in admin light theme
-+-
 Reporter:  Thibaud Colas|Owner:  Mariana
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  accessibility,   | Triage Stage:  Ready for
  color contrast, ux |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-

Comment (by Tom Carrick):

 Colin, I agree that's a regression. On the PR you mention I've suggested
 only changing the colours so we can merge that faster. It should probably
 also be a release blocker.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d0328a46a-492dbc0a-14df-4fef-bcfe-d834762647f9-00%40eu-central-1.amazonses.com.

Re: [Django] #35107: How to write a management command that reads from stdin should be documented

Re: [Django] #35111: DateField's range and in lookups against expressions produce invalid values on SQLite.

Re: [Django] #33650: Update startproject template with config directory

Re: [Django] #33650: Update startproject template with config directory

Re: [Django] #33650: Update startproject template with config directory

Re: [Django] #35095: Monetary values in Switzerland discrepancy

Re: [Django] #35095: Monetary values in Switzerland discrepancy

Re: [Django] #35095: Monetary values in Switzerland discrepancy

Re: [Django] #35095: Monetary values in Switzerland discrepancy

Re: [Django] #33650: Update startproject template with config directory

Re: [Django] #35111: DateField's range and in lookups against expressions produce invalid values on SQLite.

[Django] #35111: DateField's range and in lookups against expressions produce invalid values on SQLite.

Re: [Django] #35102: Performance regression on Model.objects.count() between Django 4.2 and 5.0

Re: [Django] #35107: How to write a management command that reads from stdin should be documented

Re: [Django] #14831: Django Template Style Guide

Re: [Django] #14831: Django Template Style Guide

Re: [Django] #14831: Django Template Style Guide

Re: [Django] #14831: Django Template Style Guide

Re: [Django] #14831: Django Template Style Guide

Re: [Django] #16752: Multi-db without a 'default' database

Re: [Django] #34036: Low text contrast over light blue backgrounds in admin light theme

21 matches

Site Navigation

Mail list logo

Footer information