Re: [Dnsmasq-discuss] clang format

[Simon Kelley]

On 10/10/2019 22:00, Geert Stappers wrote:
> 
> In-Reply-To: <55adb604-91a9-77a8-ed41-500363f4c...@mail.com>
> Previous-Subject: Re: [Dnsmasq-discuss] [patch] empty empty lines
> On Mon, Sep 30, 2019 at 07:18:12PM +0200, john doe wrote:
>> On 9/30/2019 4:50 PM, Simon Kelley wrote:
>>> To be clear, I have no objection to this sort of patch/suggestion.
>>>
>>> It should be fairly clear, however, that my available time to work on
>>> dnsmasq at the moment is limited, and stuff like this is not a priority,
>>> and likely to be pushed to the back of the queue, possibly so far that
>>> it never emerges again.
>>>
>>> If we're going to do this, the first stage is probably to add hooks to
>>> git to run expand (for tabs) and this filter on all NEW commits. Then
>>> we won't ever have to do that again.
>>>
>>> As that filter will make massive  updates to existing code, we'll have
>>> to take a one-time commit across the codebase to get everything fixed
>>> once. Otherwise the filters will adding lots of extra formatting changes
>>> to other commits as they touch files, which is not good.
>>>
>>> So, let's come to a consensus if a one-time clean up commit across the
>>> codebase is a price worth paying to fix the formatting issues, and if it
>>> is, work out how to add automatic filters to git to keep things clean
>>> afterwards. If anyone has experience of that, I'd like to hear.
>>>
>>
>> The way I see things which is up for debate:
>> - Everyone that is committing to the project would need to use a Git
>> hook that would avoid committing if the code is not conform to the
>> standard used by the project
>> The pre-commit hook '.git/hooks/pre-commit' would need to be
>> modified to fit the coding stile required by the project which means
>>  that patch that does not comply to  the coding stile will be rejected.
>>
>> The above is only for new code that would be added, now to the question
>> of modifying code already pushed:
>> If we choose to reformat old pushed code, one commit should be created
>> including all the formatting issues then testing will need to be done to
>> verify that the commit in question does not introduce regression,
>> reformatting old code is questionable to say the lease.
> 
> 
> Where it is OK to get tooling to bend our source code in shape,
> is it more important to decide in which shape it should be bend.
> 
> Here I think it is wise to be standing on the shoulders of giants.
> The giants are this time the Linux Kernel developers.
> 
> Those giants have their coding style described.
>  https://www.kernel.org/doc/html/v5.3/process/coding-style.html
> 
> Machine readable version is
> at 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/.clang-format
> 
> Tooling they use is `clangformat`
>  https://clang.llvm.org/docs/ClangFormat.html
> 
> 
> Please take the above information as input for moving Dnsmasq from
> a project without a coding style to a project with a coding style.
> 


This seems to have escalated from inconsistent use of spaces and tabs to
"without a coding style". For information, the C coding style in dnsmasq
is the GNU style, except without the space preceding (

I like that style, I chose that style and it's not going to change.


Simon.


___
Dnsmasq-discuss mailing list
Dnsmasq-discuss@lists.thekelleys.org.uk
http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss

Re: [Dnsmasq-discuss] (PATCH) catch up

[Simon Kelley]

Noted, and the previous messages on this thread. Four commits tonight
and I'm out of time. Will come back to these in the next day or two.

Simon.

On 01/10/2019 17:51, Petr Mensik wrote:
> Hello Simon,
> 
> I would like to remind issue with TCP and recreated interfaces. Original
> thread [1], my GitHub branch [2]. Modified a bit since last time, not
> sure whether it is better to attach all those patches. Checkout of
> branch would be easier for me.
> 
> I would like also non-recursive queries commented or solved [3], with
> patch [4] message next.
> 
> For me, modern git hosting services make it much more simple to manage
> waiting tasks. Easy to get back to them once there is enough time again.
> They allow merging by single click, tagging issues into different
> categories or importance. Saving time in different tasks. I have found
> request for public clone [5]. Do you have any opinion for it?
> 
> Pull requests ability with comments to them would be greatly
> appreciated. Makes also packager work easier, because they can link
> issues in distribution to upstream issues. Would you consider creating
> your clone? You have got already commits on GitHub :)
> 
> Cheers,
> Petr
> 
> 1.
> http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/2019q3/013114.html
> 2. https://github.com/InfrastructureServices/dnsmasq/tree/master-bz1721668
> 3.
> http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/2019q2/013010.html
> 4.
> http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/2019q2/013013.html
> 5.
> http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/2015q2/009520.html
> 
> On 9/30/19 4:51 PM, Simon Kelley wrote:
>> Now would be a good time to tell me all the stuff I should be dealing with.
>>
>>
>>
>> Simon
>>
>> On 24/09/2019 06:54, Geert Stappers wrote:
>>> On Thu, Jan 03, 2019 at 08:12:43PM +, Simon Kelley wrote:
 Prodding me is fine, and has done the trick here.
>>>
>>> :-)
>>>
>>>
 In general, I'm way behind my inbox, and struggling to catch up. Moving
 house is not helping :(

 I will try and get to everything in the end, but I won't be offended is
 people remind me.
>>>
>>> What would be a reasonable interval time?
>>>
>>>
 Cheers,
 Simon.
>>>
>>>
>>> Regards
>>> Geert Stappers
>>>
>>>
>>> ___
>>> Dnsmasq-discuss mailing list
>>> Dnsmasq-discuss@lists.thekelleys.org.uk
>>> http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss
>>>
>>
>>
>> ___
>> Dnsmasq-discuss mailing list
>> Dnsmasq-discuss@lists.thekelleys.org.uk
>> http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss
>>
> 


___
Dnsmasq-discuss mailing list
Dnsmasq-discuss@lists.thekelleys.org.uk
http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss

Re: [Dnsmasq-discuss] FreeBSD TFTP issue (failure to serve via IPv4) reported against 11.3/12.x

[Simon Kelley]

On 05/10/2019 09:44, Matthias Andree wrote:
> Am 05.10.19 um 09:54 schrieb Geert Stappers:
>> Questions:
>> Which version of Dnsmasq did work?  ( git bi-sect  known good)
>> Which version of Dnsmasq doesn't work?  ( git bi-sect  known bad)
>>
>> In case it is stated in
>>> 
>>> 
>> have the curitisy to state it here also ...
> 
> FreeBSD have been shipping 2.80 for a long time (since before
> 2019-07-01), if there's a mismatch in the source code and what they
> quote in the Forums, it'll be easy to spot.
> The thing is not that dnsmasq changed, but that FreeBSD changed and it
> appears that some interface fiddling makes assumptions that were true in
> 11.2 but no longer hold in FreeBSD >= 11.3.
> 
> 


The patch in the buzilla entry looks good to me. The dnsmasq code is
wrong and has been for some time. The version-dependent failure is
probably down to the order in which the data is added to the control
array, or the relative size of the two datastructures changing.

http://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=commit;h=936bd82755e8f75fc09c1e9a67fb390175b157d4

should fix things. PLs test.


Cheers,

Simon.


> ___
> Dnsmasq-discuss mailing list
> Dnsmasq-discuss@lists.thekelleys.org.uk
> http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss
> 


___
Dnsmasq-discuss mailing list
Dnsmasq-discuss@lists.thekelleys.org.uk
http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss

Re: [Dnsmasq-discuss] (PATCH) catch up

[Pali Rohár]

On Monday 30 September 2019 22:40:20 Geert Stappers wrote:
> On Mon, Sep 30, 2019 at 03:51:43PM +0100, Simon Kelley wrote:
> > On 24/09/2019 06:54, Geert Stappers wrote:
> > > On Thu, Jan 03, 2019 at 08:12:43PM +, Simon Kelley wrote:
> > >> In general, I'm way behind my inbox, and struggling to catch up. Moving
> > >> house is not helping :(
> > >> I will try and get to everything in the end, but I won't be offended is
> > >> people remind me.
> > > 
> > > What would be a reasonable interval time?
> > > 
> >
> > Now would be a good time to tell me
> > all the stuff I should be dealing with.
> 
> DHCPv6: Honor assigning IPv6 address based on MAC address
> http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/2018q4/012707.html
> 
> Two "works for me" are
> in http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/2019q2/013098.html
> 
> Pali Roh�r   was early september still on this mailinglist
> ( http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/2019q3/013289.html 
> )

I'm still subscribed to dnsmasq mailing list. I'm reading it and so I'm still 
there!

(Btw, seems there is broken encoding in previous email, in my name is letter A 
with acute accent = á)

-- 
Pali Rohár
pali.ro...@gmail.com


signature.asc
Description: PGP signature
___
Dnsmasq-discuss mailing list
Dnsmasq-discuss@lists.thekelleys.org.uk
http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss

Re: [Dnsmasq-discuss] [PATCH] Add dhcp-ignore-clid configuration option

[Simon Kelley]

On 10/10/2019 16:54, Florent Fourcot wrote:
> Hello Simon,
> 
> 
>> Of course, it involves enumerating the broken machines, rather than a
>> blanket setting covering everything, but that's probably a good thing.
>> It's what I wanted to provide with the tag extension I suggested, and
>> rather renders that redundant.
>>
>> What do you thin Florent? Is this enough, or would you like the new
>> blanket option as well?
> 
> Thank you for the point on this option, I missed it before. However,
> iIterating on hosts is not really a solution for us, since it's customer
> devices (they appear/disappear out of our control, on a lot of sites).
> 
> Moreover, in our context, MAC addresses are more relevant than clients
> identifiers, even for hosts with a valid identifier. Our networks have
> some checks on couple IP/MAC addresses consistency, and distributing an
> IP address previously in use with another MAC is probably a bad idea for
> this kind of tools.
> 
> So, I'm still in favor of the blanket options.
> 

OK, I'm convinced. The patch is in.

Many thanks.

Simon.


___
Dnsmasq-discuss mailing list
Dnsmasq-discuss@lists.thekelleys.org.uk
http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss

Re: [Dnsmasq-discuss] dnsmasq won't run on Debian 10.1 buster

[john doe]

On 10/11/2019 5:09 PM, Guillaume B. wrote:
> Hello,
>
> First time subscriber here.
>
> I have issues with dnsmasq not working in Debian 10.1 buster. dnsmasq-base
> works fine with "dns=dnsmasq" set in NetworkManager.conf (that is I can
> query the upstream server and cache the dns addresses locally) but as soon
> as I install dnsmasq, the network won't work. It seems like I cannot get a
> DHCP lease from my router and I only receive a DHCPNAK reply instead of the
> normal DHCPACK which allows me to connect to the internet.
>

Looks like your are mixing the dhcp/dns server 'dnsmasq' with 'dhcp
client', the dhcp client will get a lease from the upstream server and
dnsmasq will take care of ip addressing and dns for the hosts that are
behind dnsmasq server.

On Debian the dhcp client is per default 'dhclient'.

> I have tried different options set in dnsmasq.conf but even a virgin list
> won't work, the network connection simply does not happen and
> NetworkManager won't even register any addresses in /etc/resolv.conf, it
> just leaves it blank (even when I manually set the local dns to 127.0.0.1
> and the upstream to my router's address it won't work).
>

- Why do you need dnsmasq and not simply 'dnsmasq-base'?
- Did you install the 'resolvconf' package (NM/resolvconf is handling
'/etc/resolv.conf')?
- Why do you want to use dnsmasq on a host where networkmanager is
installed?

--
John Doe

___
Dnsmasq-discuss mailing list
Dnsmasq-discuss@lists.thekelleys.org.uk
http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss

Re: [Dnsmasq-discuss] dnsmasq won't run on Debian 10.1 buster for me

[Geert Stappers]

On Fri, Oct 11, 2019 at 03:09:59PM +, Guillaume B. wrote:
> Hello,
> 
> First time subscriber here.

Welcome


> I have issues with dnsmasq not working in Debian 10.1 buster. dnsmasq-base
> works fine with "dns=dnsmasq" set in NetworkManager.conf (that is I can
> query the upstream server and cache the dns addresses locally) but as soon
> as I install dnsmasq, the network won't work. It seems like I cannot get a
> DHCP lease from my router and I only receive a DHCPNAK reply instead of the
> normal DHCPACK which allows me to connect to the internet.
> 
> I have tried different options set in dnsmasq.conf but even a virgin list
> won't work, the network connection simply does not happen and
> NetworkManager won't even register any addresses in /etc/resolv.conf, it
> just leaves it blank (even when I manually set the local dns to 127.0.0.1
> and the upstream to my router's address it won't work).
> 
> I was wondering if anybody could help make dnsmasq work for me, I depended
> on it in Debian Stretch but now it just won't work, even if I downgrade to
> stretch dnsmasq on Debian.
 
I don't understand the problem. A better better description is needed.

* Describe the LAN.
* Describe network wise the computer that should run Dnsmasq.
* Describe what is expected from Dnsmasq.


> Thank your for any help you might provide.

The request for help has been seen, what kind of help is needed not yet.


Groeten
Geert Stappers
-- 
Leven en laten leven

___
Dnsmasq-discuss mailing list
Dnsmasq-discuss@lists.thekelleys.org.uk
http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss