[edk2-devel] [PATCH 1/1] UefiCpuPkg/PiSmmCpuDxeSmm: Add check for pointer Pml5Entry
The pointer Pml5Entry, returned from call to function AllocatePageTableMemory, may be null. So add check for it. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Shenglei Zhang --- UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c index a3b62f778741..d7af3b6d7941 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c @@ -375,6 +375,7 @@ SmmInitPageTable ( // Fill PML5 entry // Pml5Entry = (UINT64*)AllocatePageTableMemory (1); +ASSERT (Pml5Entry != NULL); *Pml5Entry = (UINTN) Pml4Entry | mAddressEncMask | PAGE_ATTRIBUTE_BITS; ZeroMem (Pml5Entry + 1, EFI_PAGE_SIZE - sizeof (*Pml5Entry)); // -- 2.18.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44664): https://edk2.groups.io/g/devel/message/44664 Mute This Topic: https://groups.io/mt/32662314/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2] [PATCH v3 12/12] SourceLevelDebugPkg/DebugAgentCommon: Remove .S files
Hi Hao,
It seems it's not necessary to leave them here. I'll remove them in next
version.
Thanks,
Shenglei
> -Original Message-
> From: Wu, Hao A
> Sent: Monday, April 1, 2019 9:25 AM
> To: Zhang, Shenglei ; edk2-devel@lists.01.org
> Subject: RE: [PATCH v3 12/12] SourceLevelDebugPkg/DebugAgentCommon:
> Remove .S files
>
> Hello Shenglei,
>
> There are still two .S files under SourceLevelDebugPkg:
>
> edk2\SourceLevelDebugPkg\Library\PeCoffExtraActionLibDebug\Ia32\IntHa
> ndler.S
> edk2\SourceLevelDebugPkg\Library\PeCoffExtraActionLibDebug\X64\IntHan
> dler.S
>
> Is there any special reason to left them in the repo?
>
> Best Regards,
> Hao Wu
>
> > -Original Message-
> > From: Zhang, Shenglei
> > Sent: Friday, March 29, 2019 3:28 PM
> > To: edk2-devel@lists.01.org
> > Cc: Wu, Hao A
> > Subject: [PATCH v3 12/12] SourceLevelDebugPkg/DebugAgentCommon:
> > Remove .S files
> >
> > .nasm file has been added for X86 arch. .S assembly code
> > is not required any more.
> > https://bugzilla.tianocore.org/show_bug.cgi?id=1594
> >
> > Cc: Hao Wu
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Shenglei Zhang
> > ---
> > .../DebugAgentCommon/Ia32/AsmFuncs.S | 415 -
> > .../DebugAgentCommon/X64/AsmFuncs.S | 431 --
> > .../Library/DebugAgent/DxeDebugAgentLib.inf | 2 -
> > 3 files changed, 848 deletions(-)
> > delete mode 100644
> >
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/Asm
> Fun
> > cs.S
> > delete mode 100644
> >
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/Asm
> Fun
> > cs.S
> >
> > diff --git
> >
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/As
> mF
> > uncs.S
> >
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/A
> smF
> > uncs.S
> > deleted file mode 100644
> > index 30d279e80d..00
> > ---
> >
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/As
> mF
> > uncs.S
> > +++ /dev/null
> > @@ -1,415 +0,0 @@
> > -#--
> > -#
> > -# Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.
> > -# This program and the accompanying materials
> > -# are licensed and made available under the terms and conditions of the
> BSD
> > License
> > -# which accompanies this distribution. The full text of the license may be
> > found at
> > -# http://opensource.org/licenses/bsd-license.php.
> > -#
> > -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS"
> > BASIS,
> > -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
> > EXPRESS OR IMPLIED.
> > -#
> > -# Module Name:
> > -#
> > -# AsmFuncs.S
> > -#
> > -# Abstract:
> > -#
> > -# Debug interrupt handle functions.
> > -#
> > -#--
> > -
> > -#include "DebugException.h"
> > -
> > -ASM_GLOBAL ASM_PFX(InterruptProcess)
> > -ASM_GLOBAL ASM_PFX(Exception0Handle)
> > -ASM_GLOBAL ASM_PFX(ExceptionStubHeaderSize)
> > -ASM_GLOBAL ASM_PFX(TimerInterruptHandle)
> > -ASM_GLOBAL ASM_PFX(CommonEntry)
> > -
> > -.macro AGENT_HANDLER_SIGNATURE
> > - .byte 0x41, 0x47, 0x54, 0x48 # AGENT_HANDLER_SIGNATURE
> > SIGNATURE_32('A','G','T','H')
> > -.endm
> > -
> > -.data
> > -
> > -ASM_PFX(ExceptionStubHeaderSize): .long
> ASM_PFX(Exception1Handle) -
> > ASM_PFX(Exception0Handle)
> > -
> > -.text
> > -
> > -AGENT_HANDLER_SIGNATURE
> > -ASM_PFX(Exception0Handle):
> > - cli
> > - pushl %eax
> > - mov $0, %eax
> > - jmp ASM_PFX(CommonEntry)
> > -AGENT_HANDLER_SIGNATURE
> > -ASM_PFX(Exception1Handle):
> > - cli
> > - pushl %eax
> > - mov $1, %eax
> > - jmp ASM_PFX(CommonEntry)
> > -AGENT_HANDLER_SIGNATURE
> > -ASM_PFX(Exception2Handle):
> > - cli
> > - pushl %eax
> > - mov $2, %eax
> > - jmp ASM_PFX(CommonEntry)
> > -AGENT_HANDLER_SIGNATURE
> > -ASM_PFX(Exception3Handle):
> > - cli
> > - pushl %eax
> > - mov $3, %eax
> > - jmp ASM_PFX(CommonEntry)
> > -AGENT_HANDLER_SIGNATURE
> > -ASM_PFX(Exception4Handle):
> > - cli
> > - pushl
Re: [edk2] [PATCH 1/3] MdePkg/MdePkg.uni: Add the prompt and help information
Sorry that's my mistake. I'll fix the error in v2. Thanks, Shenglei > -Original Message- > From: Yao, Jiewen > Sent: Monday, March 11, 2019 9:49 AM > To: Zhang, Shenglei ; edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming > ; Yao, Jiewen > Subject: RE: [edk2] [PATCH 1/3] MdePkg/MdePkg.uni: Add the prompt and > help information > > HI > I am confused why the help info is " Indicates the maximum length of > Unicode string used in the following " ? > > > -Original Message- > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > > Shenglei Zhang > > Sent: Monday, March 11, 2019 8:55 AM > > To: edk2-devel@lists.01.org > > Cc: Kinney, Michael D ; Gao, Liming > > > > Subject: [edk2] [PATCH 1/3] MdePkg/MdePkg.uni: Add the prompt and > help > > information > > > > The prompt and help information are missing in MdePkg.uni. > > https://bugzilla.tianocore.org/show_bug.cgi?id=1600 > > > > Cc: Michael D Kinney > > Cc: Liming Gao > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Shenglei Zhang > > --- > > MdePkg/MdePkg.uni | 7 +++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/MdePkg/MdePkg.uni b/MdePkg/MdePkg.uni > > index 863a68d025..4f86432eb2 100644 > > --- a/MdePkg/MdePkg.uni > > +++ b/MdePkg/MdePkg.uni > > @@ -148,6 +148,13 @@ > > > > "0 - No length check for unicode string.\n" > > > > ">0 - Maximum length of unicode string." > > > > +#string > > > STR_gEfiMdePkgTokenSpaceGuid_PcdControlFlowEnforcementPropertyMas > > k_PROMPT #language en-US "Maximum Length of Unicode String." > > + > > +#string > > > STR_gEfiMdePkgTokenSpaceGuid_PcdControlFlowEnforcementPropertyMas > > k_HELP #language en-US "Indicates the maximum length of unicode > > string used in the following\n" > > + > > "BaseLib functions: StrLen(), StrSize(), StrCmp(), StrnCmp(), StrCpy(), > > StrnCpy()\n" > > + > > "0 - No length check for unicode string.\n" > > + > > ">0 - Maximum length of unicode string." > > + > > #string > > > STR_gEfiMdePkgTokenSpaceGuid_PcdMaximumAsciiStringLength_PROMPT > > #language en-US "Maximum Length of Ascii String" > > > > #string > > STR_gEfiMdePkgTokenSpaceGuid_PcdMaximumAsciiStringLength_HELP > > #language en-US "Sets the maximum number of ASCII characters used for > > string functions. This affects the following BaseLib functions: > > AsciiStrLen(), > > AsciiStrSize(), AsciiStrCmp(), AsciiStrnCmp(), AsciiStrCpy(), > > AsciiStrnCpy(). > > \n" > > -- > > 2.18.0.windows.1 > > > > ___ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH] ShellPkg: Correct a parameter's name
Hi Jaben, Do you have any opinion on "fs-path" rename to "file-full-path-name"? Thanks, Shenglei From: krishnaLee [mailto:sssky...@163.com] Sent: Thursday, February 21, 2019 10:00 AM To: Zhang, Shenglei Cc: edk2-devel@lists.01.org Subject: Re:[edk2] [PATCH] ShellPkg: Correct a parameter's name Hi Shenglei, I am confused some times,see UEFI_Shell_specification_2_2,chapter-3.7: 3.7 File Names The UEFI Shell supports file names and paths with the following format: fs-path := [fs-map-name] [fs-divider][fs-dirs][fs-name] May be if the define name "fs-path" rename to "file-full-path-name" is more clear,:) thanks, krishna. At 2019-02-21 09:28:07, "Shenglei Zhang" mailto:shenglei.zh...@intel.com>> wrote: >The parameter FilePath of ShellOpenFileByName defined in >ShellLib.h is incorrect. It should be FileName. >https://bugzilla.tianocore.org/show_bug.cgi?id=1221 > >Cc: Jaben Carsey mailto:jaben.car...@intel.com>> >Cc: Ruiyu Ni mailto:ruiyu...@intel.com>> >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: shenglei >mailto:shenglei.zh...@intel.com>> >--- > ShellPkg/Include/Library/ShellLib.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/ShellPkg/Include/Library/ShellLib.h >b/ShellPkg/Include/Library/ShellLib.h >index 2ecc5ee006..78bdcc8c53 100644 >--- a/ShellPkg/Include/Library/ShellLib.h >+++ b/ShellPkg/Include/Library/ShellLib.h >@@ -161,7 +161,7 @@ ShellOpenFileByDevicePath( > otherwise, the Filehandle is NULL. Attributes is valid only for > EFI_FILE_MODE_CREATE. > >- @param[in] FilePath The pointer to file name. >+ @param[in] FileName The pointer to file name. > @param[out] FileHandleThe pointer to the file handle. > @param[in] OpenMode The mode to open the file with. > @param[in] Attributes The file's file attributes. >@@ -186,7 +186,7 @@ ShellOpenFileByDevicePath( > EFI_STATUS > EFIAPI > ShellOpenFileByName( >- IN CONST CHAR16 *FilePath, >+ IN CONST CHAR16 *FileName, > OUT SHELL_FILE_HANDLE *FileHandle, > IN UINT64 OpenMode, > IN UINT64 Attributes >-- >2.18.0.windows.1 > >___ >edk2-devel mailing list >edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> >https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v4] MdePkg/BaseLib: Add Base64Encode() and Base64Decode()
> -Original Message- > From: Ni, Ray > Sent: Wednesday, January 30, 2019 5:49 PM > To: Zhang, Shenglei ; edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Mike Turner > ; Gao, Liming > Subject: Re: [edk2] [PATCH v4] MdePkg/BaseLib: Add Base64Encode() and > Base64Decode() > > Comments in below. > > On 1/30/2019 2:28 PM, Shenglei Zhang wrote: > > From: Mike Turner > > > > Introduce public functions Base64Encode and Base64Decode. > > https://bugzilla.tianocore.org/show_bug.cgi?id=1370 > > > > v2:1.Remove some white space. > > 2.Add unit test with test vectors in RFC 4648. > > https://github.com/shenglei10/edk2/tree/encode_test > > https://github.com/shenglei10/edk2/tree/decode_test > > > > v3:1.Align white space. > > 2.Update comments of Base64Encode and Base64Decode. > > 3.Change the use of macro RETURN_DEVICE_ERROR to > > RETURN_INVALID_PARAMETER in string.c. > > > > v4:Change parameters' names. > > > > Cc: Michael D Kinney > > Cc: Liming Gao > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Shenglei Zhang > > --- > > MdePkg/Include/Library/BaseLib.h | 56 + > > MdePkg/Library/BaseLib/String.c | 344 > +++ > > 2 files changed, 400 insertions(+) > > > > diff --git a/MdePkg/Include/Library/BaseLib.h > b/MdePkg/Include/Library/BaseLib.h > > index 1eb842384e..03173def58 100644 > > --- a/MdePkg/Include/Library/BaseLib.h > > +++ b/MdePkg/Include/Library/BaseLib.h > > @@ -2720,6 +2720,62 @@ AsciiStrnToUnicodeStrS ( > > OUT UINTN *DestinationLength > > ); > > > > +/** > > + Convert binary data to a Base64 encoded ascii string based on RFC4648. > > + > > + Produce a Null-terminated Ascii string in the output buffer specified by > Destination and DestinationSize. > > + The Ascii string is produced by converting the data string specified by > Source and SourceLength. > > + > > + @param Source Input UINT8 data > > + @param SourceLength Number of UINT8 bytes of data > > + @param Destination Pointer to output string buffer > > + @param DestinationSize Size of ascii buffer. Set to 0 to get the size > needed. > > + Caller is responsible for passing in buffer of > > DestinationSize > > + > > + @retval RETURN_SUCCESS When ascii buffer is filled in. > > + @retval RETURN_INVALID_PARAMETER If Source is NULL or > DestinationSize is NULL. > > + @retval RETURN_INVALID_PARAMETER If SourceLength or > DestinationSize is bigger than (MAX_ADDRESS - (UINTN)Destination). > > + @retval RETURN_BUFFER_TOO_SMALLIf SourceLength is 0 and > DestinationSize is <1. > > + @retval RETURN_BUFFER_TOO_SMALLIf Destination is NULL or > DestinationSize is smaller than required buffersize. > > + > > +**/ > > +RETURN_STATUS > > +EFIAPI > > +Base64Encode ( > > + IN CONST UINT8 *Source, > > + INUINTN SourceLength, > > + OUT CHAR8 *Destination OPTIONAL, > > + IN OUTUINTN *DestinationSize > > + ); > > + > > +/** > > + Convert Base64 ascii string to binary data based on RFC4648. > > + > > + Produce Null-terminated binary data in the output buffer specified by > Destination and DestinationSize. > > + The binary data is produced by converting the Base64 ascii string > specified by Source and SourceLength. > > + > > + @param Source Input ASCII characters > > + @param SourceLengthNumber of ASCII characters > > + @param Destination Pointer to output buffer > > + @param DestinationSize Caller is responsible for passing in buffer of at > least DestinationSize. > > + Set 0 to get the size needed. Set to bytes stored > > on return. > > + > > + @retval RETURN_SUCCESS When binary buffer is filled in. > > + @retval RETURN_INVALID_PARAMETER If Source is NULL or > DestinationSize is NULL. > > + @retval RETURN_INVALID_PARAMETER If SourceLength or > DestinationSize is bigger than (MAX_ADDRESS -(UINTN)Destination ). > > + @retval RETURN_INVALID_PARAMETER If there is any invalid character > in input stream. > > + @retval RETURN_BUFFER_TOO_SMALLIf buffer length is smaller than > required buffer size. > > + > > + **/ > > +RETURN_STATUS > > +EFIAPI > > +Base64Decode ( > > + IN CONST CHAR8 *Source, > > + INUINTN SourceLength,
Re: [edk2] [PATCH 0/2] Add two public functions
Hi Leif Thanks for your constructive guide. I 'll improve my later patches. Thanks, Shenglei > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Thursday, December 13, 2018 6:52 PM > To: Zhang, Shenglei > Cc: edk2-devel@lists.01.org; Kinney, Michael D > ; Gao, Liming > Subject: Re: [edk2] [PATCH 0/2] Add two public functions > > Please let the subject line give some sort of hint of what is being > done, and to what. "Add two functions" is not substantially more > descriptive than "add 572 characters". > > In this case, your're moving previously internal string helper functions > to BaseLib. > > On Thu, Dec 13, 2018 at 04:34:37PM +0800, Shenglei Zhang wrote: > > Add two public functions,CharToUpper and AsciiToUpper,and > > remove the same functional functions,InternalCharToUpper > > and InternalBaseLibAsciiToUpper. > > > > Cc: Michael D Kinney > > Cc: Liming Gao > > Cc: Bob Feng > > Cc: Yonghong Zhu > > Shenglei Zhang (2): > > MdePkg/BaseLib: Add two public functions > > BaseTools/Common: Remove InternalCharToUpper > > > > BaseTools/Source/C/Common/CommonLib.c | 16 ++--- > > BaseTools/Source/C/Common/CommonLib.h | 4 --- > > MdePkg/Include/Library/BaseLib.h | 40 + > > MdePkg/Library/BaseLib/BaseLibInternals.h | 42 --- > > MdePkg/Library/BaseLib/SafeString.c | 8 ++--- > > MdePkg/Library/BaseLib/String.c | 35 --- > > 6 files changed, 53 insertions(+), 92 deletions(-) > > > > -- > > 2.18.0.windows.1 > > > > ___ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v2 0/2] Remove DuetPkg and unused tools
Hi Hao, I thinks it's a good advice. Thanks for your comments and I'll take relevant actions. Thanks, Shenglei > -Original Message- > From: Wu, Hao A > Sent: Wednesday, November 28, 2018 4:06 PM > To: Wu, Hao A ; Zhang, Shenglei > ; edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Gao, Liming > Subject: RE: [PATCH v2 0/2] Remove DuetPkg and unused tools > > > -Original Message- > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > > Wu, Hao A > > Sent: Wednesday, November 28, 2018 3:39 PM > > To: Zhang, Shenglei; edk2-devel@lists.01.org > > Cc: Ni, Ruiyu; Gao, Liming > > Subject: Re: [edk2] [PATCH v2 0/2] Remove DuetPkg and unused tools > > > > > -Original Message- > > > From: Zhang, Shenglei > > > Sent: Tuesday, November 27, 2018 10:42 AM > > > To: edk2-devel@lists.01.org > > > Cc: Ni, Ruiyu; Wu, Hao A; Zhu, Yonghong; Gao, Liming > > > Subject: [PATCH v2 0/2] Remove DuetPkg and unused tools > > > > > > DuetPkg depends on Legacy BIOS to provide a UEFI environment. > > > It was invented in the era when UEFI environment is hard to find. > > > Since now UEFI is very popular in PC area, we could stop the > > > official support of this package and remove it from the master. > > > And moreover, the tools only used by DuetPkg can also be removed. > > > https://bugzilla.tianocore.org/show_bug.cgi?id=1322 > > > > > > The changes are placed in > > > https://github.com/shenglei10/edk2/tree/duet > > > > > > v2:Remove these tools in Makefile and GNUmakefile. > > > > Hi, > > > > For DuetPkg patch (2/2), I am wondering we can move the Makefile > changes > > in the > > BaseTools to either A) or B) below: > > > > A) To the 1/2 patch > > B) To a separate patch > > Another thing is that, it makes more sense to me that the deletion of the > DuetPkg should be the first patch of the series. Then, it comes the removal > of > the tools within BaseTools that are only used by DuetPkg. > > Best Regards, > Hao Wu > > > > > > > Best Regards, > > Hao Wu > > > > > > > > Cc: Ruiyu Ni > > > Cc: Hao Wu > > > Cc: Yonghong Zhu > > > Cc: Liming Gao > > > Shenglei Zhang (2): > > > BaseTools: Remove tools only used by DuetPkg > > > DuetPkg: Remove DuetPkg > > > > > > BaseTools/Source/BinaryFiles.txt |4 - > > > BaseTools/Source/C/BootSectImage/GNUmakefile | 21 - > > > BaseTools/Source/C/BootSectImage/Makefile | 22 - > > > .../Source/C/BootSectImage/bootsectimage.c| 955 -- > > > BaseTools/Source/C/BootSectImage/fat.h| 152 - > > > BaseTools/Source/C/BootSectImage/mbr.h| 58 - > > > BaseTools/Source/C/EfiLdrImage/EfiLdrImage.c | 319 -- > > > BaseTools/Source/C/EfiLdrImage/GNUmakefile| 21 - > > > BaseTools/Source/C/EfiLdrImage/Makefile | 22 - > > > BaseTools/Source/C/GNUmakefile|5 - > > > BaseTools/Source/C/GenBootSector/FatFormat.h | 152 - > > > .../Source/C/GenBootSector/GenBootSector.c| 823 - > > > .../Source/C/GenBootSector/GetDrvNumOffset.c | 73 - > > > BaseTools/Source/C/GenBootSector/Makefile | 22 - > > > BaseTools/Source/C/GenPage/GNUmakefile| 21 - > > > BaseTools/Source/C/GenPage/GenPage.c | 441 --- > > > BaseTools/Source/C/GenPage/Makefile | 22 - > > > BaseTools/Source/C/GenPage/VirtualMemory.h| 122 - > > > .../Source/C/GnuGenBootSector/FatFormat.h | 152 - > > > .../Source/C/GnuGenBootSector/GNUmakefile | 21 - > > > .../C/GnuGenBootSector/GnuGenBootSector.c | 455 --- > > > BaseTools/Source/C/Makefile |4 - > > > BaseTools/toolsetup.bat |4 - > > > DuetPkg/AcpiResetDxe/Reset.c | 212 -- > > > DuetPkg/AcpiResetDxe/Reset.inf| 47 - > > > DuetPkg/BiosVideoThunkDxe/BiosVideo.c | 2822 - > > > DuetPkg/BiosVideoThunkDxe/BiosVideo.h | 504 --- > > > DuetPkg/BiosVideoThunkDxe/BiosVideo.inf | 50 - > > > DuetPkg/BiosVideoThunkDxe/ComponentName.c | 166 - > > > DuetPkg/BiosVideoThunkDxe/LegacyBiosThunk.c | 220 -- > > > .../BiosVideoThunkDxe/VesaBiosExtensions.h| 457 --- > > > DuetPkg/BootSector/BootSector.inf | 79 - > > > DuetPkg/Boot
Re: [edk2] [PATCH 6/8] IntelFrameworkPkg: Remove the redundant INFs
Ray Thanks for your constructive comments. I'll improve it in next version. Thanks, Shenglei > -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, November 14, 2018 11:12 AM > To: Zhang, Shenglei ; edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming > > Subject: Re: [edk2] [PATCH 6/8] IntelFrameworkPkg: Remove the redundant > INFs > > On 11/13/2018 4:35 PM, Shenglei Zhang wrote: > > All INFs of unused Library instances in IntelFrameworkPkg > > are removed as they are not actually used. > > https://bugzilla.tianocore.org/show_bug.cgi?id=1190 > > > > Cc: Liming Gao > > Cc: Michael D Kinney > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Shenglei Zhang > > --- > > IntelFrameworkPkg/IntelFrameworkPkg.dsc | 7 --- > > 1 file changed, 7 deletions(-) > > > > diff --git a/IntelFrameworkPkg/IntelFrameworkPkg.dsc > b/IntelFrameworkPkg/IntelFrameworkPkg.dsc > > index bd5df8c5d9..802a80e3eb 100644 > > --- a/IntelFrameworkPkg/IntelFrameworkPkg.dsc > > +++ b/IntelFrameworkPkg/IntelFrameworkPkg.dsc > > @@ -63,13 +63,6 @@ > > # generated for it, but the binary will not be put into any firmware > volume. > > # > > > ## > # > > -[Components] > > - IntelFrameworkPkg/Library/DxeIoLibCpuIo/DxeIoLibCpuIo.inf > > - IntelFrameworkPkg/Library/FrameworkUefiLib/FrameworkUefiLib.inf > > - > IntelFrameworkPkg/Library/DxeSmmDriverEntryPoint/DxeSmmDriverEntryP > oint.inf > > - > IntelFrameworkPkg/Library/PeiSmbusLibSmbusPpi/PeiSmbusLibSmbusPpi.in > f > > - > IntelFrameworkPkg/Library/PeiHobLibFramework/PeiHobLibFramework.inf > > - > > [BuildOptions] > > *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES > > > > > Shenglei, > You cannot remove the INF in the separate patch like this. > You should either put this patch in the first patch in your serial, > or combine the DSC change with your library removal. > The goal is the the build won't fail when committing the patches one by one. > > -- > Thanks, > Ray ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 1/3] Maintainers.txt: Remove EdkShellPkg and EkdShellBinPkg
Hi Leif, Thanks for your comments. Actually there is a cover letter. https://lists.01.org/pipermail/edk2-devel/2018-October/031666.html It may not be needed to rework but I 'll push the patches in order according to the comments you mentioned. Thanks, Shenglei > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Wednesday, October 31, 2018 7:02 PM > To: Zhang, Shenglei > Cc: edk2-devel@lists.01.org; Andrew Fish ; Laszlo Ersek > ; Kinney, Michael D > Subject: Re: [PATCH 1/3] Maintainers.txt: Remove EdkShellPkg and > EkdShellBinPkg > > Hi Shenglei, > > I am happy with this change, but I think the deletion from > Maintainers.txt should come last (as 3/3). > Could you rework and resubmit, and add a cover letter (0/3)? > > Best Regards, > > Leif > > On Wed, Oct 31, 2018 at 02:05:23PM +0800, shenglei wrote: > > Given that EdkShellPkg and EkdShellBinPkg will be removed, > > information about them in Maintainers.txt should also be > > deleted. > > https://bugzilla.tianocore.org/show_bug.cgi?id=1107 > > https://bugzilla.tianocore.org/show_bug.cgi?id=1108 > > > > Cc: Andrew Fish > > Cc: Laszlo Ersek > > Cc: Leif Lindholm > > Cc: Michael D Kinney > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: shenglei > > --- > > Maintainers.txt | 6 -- > > 1 file changed, 6 deletions(-) > > > > diff --git a/Maintainers.txt b/Maintainers.txt > > index 36c6689afd..98f104b674 100644 > > --- a/Maintainers.txt > > +++ b/Maintainers.txt > > @@ -114,12 +114,6 @@ EdkCompatibilityPkg > > W: > https://github.com/tianocore/tianocore.github.io/wiki/EdkCompatibilityPkg > > M: Liming Gao > > > > -EdkShellPkg, EdkShellBinPkg > > -W: https://github.com/tianocore/tianocore.github.io/wiki/EdkShellPkg > > -M: Ruiyu Ni > > -T: svn - https://svn.code.sf.net/p/efi-shell/code/trunk/Shell/ > > -S: Obsolete (Use ShellPkg & ShellBinPkg instead) > > - > > EmbeddedPkg > > W: https://github.com/tianocore/tianocore.github.io/wiki/EmbeddedPkg > > M: Leif Lindholm > > -- > > 2.18.0.windows.1 > > ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 0/5] Remove EdkShellBinPkg in FDF, DSC and DEC
Thanks for your comments about 'USE_OLD_SHELL'. I'll improve the patches in next version. Shenglei > -Original Message- > From: Justen, Jordan L > Sent: Wednesday, October 31, 2018 2:48 PM > To: edk2-devel@lists.01.org; Zhang, Shenglei > Subject: Re: [edk2] [PATCH 0/5] Remove EdkShellBinPkg in FDF, DSC and DEC > > I also see USE_OLD_SHELL references in the .dsc files. > > (Try 'git grep USE_OLD_SHELL') > > After the platforms no longer reference EdkShellBinPkg, then the bin > package will be removed? > > -Jordan > > On 2018-10-30 22:57:06, shenglei wrote: > > Remove EdkShellBinPkg in CorebootPayloadPkg, EmulatorPkg, Nt32Pkg > > and OvmfPkg. Replace EdkShellBinPkg with EdkShellPkg in > > Vlv2TbltDevicePkg. > > > > shenglei (5): > > CorebootPayloadPkg: Remove EdkShellBinPkg in FDF > > EmulatorPkg: Remove EdkShellBinPkg in FDF and DEC > > Nt32Pkg: Remove EdkShellBinPkg in FDF,DSC and DEC > > OvmfPkg: Remove EdkShellBinPkg in FDF > > Vlv2TbltDevicePkg: Remove EdkShellBinPkg with ShellPkg > > > > CorebootPayloadPkg/CorebootPayloadPkg.fdf | 8 > > EmulatorPkg/EmulatorPkg.dec | 2 +- > > EmulatorPkg/EmulatorPkg.fdf | 4 > > Nt32Pkg/Nt32Pkg.dec | 2 +- > > Nt32Pkg/Nt32Pkg.dsc | 4 ++-- > > Nt32Pkg/Nt32Pkg.fdf | 4 > > OvmfPkg/OvmfPkgIa32.fdf | 4 > > OvmfPkg/OvmfPkgIa32X64.fdf| 4 > > OvmfPkg/OvmfPkgX64.fdf| 4 > > Vlv2TbltDevicePkg/PlatformPkg.fdf | 5 + > > Vlv2TbltDevicePkg/PlatformPkgGcc.fdf | 5 + > > Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 1 + > > Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 + > > Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 + > > 14 files changed, 9 insertions(+), 40 deletions(-) > > > > -- > > 2.18.0.windows.1 > > > > ___ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v2] Edk2Platforms: Replace FatBinPkg with FatPkg
Hi Jiewen, After my test, the KabyLake Platform based on my changes can be booted to Shell successfully. And a disk can be recognized correctly. Thanks, Shenglei > -Original Message- > From: Zhang, Shenglei > Sent: Thursday, October 18, 2018 4:38 PM > To: Yao, Jiewen ; edk2-devel@lists.01.org > Subject: RE: [edk2] [PATCH v2] Edk2Platforms: Replace FatBinPkg with FatPkg > > > > > -Original Message- > > From: Yao, Jiewen > > Sent: Thursday, October 18, 2018 11:00 AM > > To: Zhang, Shenglei ; edk2-devel@lists.01.org > > Cc: Yao, Jiewen > > Subject: RE: [edk2] [PATCH v2] Edk2Platforms: Replace FatBinPkg with > FatPkg > > > > Hi > > Would you please share what test has been done? > > I build edk2-platfroms for MinKabylake according to "readme" in edk2- > platforms. > And the EDKII BIOS build has successfully completed. > > Thanks, > Shenglei > > > > > Thank you > > Yao Jiewen > > > > > > > -Original Message- > > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > > > shenglei > > > Sent: Thursday, October 18, 2018 10:35 AM > > > To: edk2-devel@lists.01.org > > > Subject: [edk2] [PATCH v2] Edk2Platforms: Replace FatBinPkg with FatPkg > > > > > > In order to remove FatBinPkg, relationships depend on > > > FatBinPkg need to be replaced by FatPkg. > > > > > > v2: > > > 1.Replace FatBinPkg with FatPkg in CoreUefiBootInclude.fdf. > > > 2.Update the subject. > > > > > > Change-Id: I8949ad1c7d18abc56deac2d4b4381e00f030dcb2 > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: Shenglei Zhang > > > --- > > > Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc| 2 +- > > > .../Intel/MinPlatformPkg/Include/Fdf/CoreUefiBootInclude.fdf| 2 +- > > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git > > a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc > > > b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc > > > index 73aafce141..9b033f43a6 100644 > > > --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc > > > +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc > > > @@ -84,7 +84,7 @@ > > >MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > > >MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > > > > > > > > > MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf > > > - FatBinPkg/EnhancedFatDxe/Fat.inf > > > + FatPkg/EnhancedFatDxe/Fat.inf > > > > > > > > > > > > #MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputD > > x > > > e.inf > > > > > > > > > MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleD > > > xe.inf > > > diff --git > > > a/Platform/Intel/MinPlatformPkg/Include/Fdf/CoreUefiBootInclude.fdf > > > b/Platform/Intel/MinPlatformPkg/Include/Fdf/CoreUefiBootInclude.fdf > > > index 6406192443..da5ca76197 100644 > > > --- > a/Platform/Intel/MinPlatformPkg/Include/Fdf/CoreUefiBootInclude.fdf > > > +++ > > b/Platform/Intel/MinPlatformPkg/Include/Fdf/CoreUefiBootInclude.fdf > > > @@ -58,7 +58,7 @@ INF > > > MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf > > > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > > > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > > > INF > > > > > > MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf > > > -INF FatBinPkg/EnhancedFatDxe/Fat.inf > > > +INF FatPkg/EnhancedFatDxe/Fat.inf > > > > > > #INF > > > > > > MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDx > > e. > > > inf > > > INF > > > > > > MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleD > > > xe.inf > > > -- > > > 2.18.0.windows.1 > > > > > > ___ > > > edk2-devel mailing list > > > edk2-devel@lists.01.org > > > https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v2] Edk2Platforms: Replace FatBinPkg with FatPkg
> -Original Message- > From: Yao, Jiewen > Sent: Thursday, October 18, 2018 11:00 AM > To: Zhang, Shenglei ; edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: RE: [edk2] [PATCH v2] Edk2Platforms: Replace FatBinPkg with FatPkg > > Hi > Would you please share what test has been done? I build edk2-platfroms for MinKabylake according to "readme" in edk2-platforms. And the EDKII BIOS build has successfully completed. Thanks, Shenglei > > Thank you > Yao Jiewen > > > > -Original Message- > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > > shenglei > > Sent: Thursday, October 18, 2018 10:35 AM > > To: edk2-devel@lists.01.org > > Subject: [edk2] [PATCH v2] Edk2Platforms: Replace FatBinPkg with FatPkg > > > > In order to remove FatBinPkg, relationships depend on > > FatBinPkg need to be replaced by FatPkg. > > > > v2: > > 1.Replace FatBinPkg with FatPkg in CoreUefiBootInclude.fdf. > > 2.Update the subject. > > > > Change-Id: I8949ad1c7d18abc56deac2d4b4381e00f030dcb2 > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Shenglei Zhang > > --- > > Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc| 2 +- > > .../Intel/MinPlatformPkg/Include/Fdf/CoreUefiBootInclude.fdf| 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git > a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc > > b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc > > index 73aafce141..9b033f43a6 100644 > > --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc > > +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc > > @@ -84,7 +84,7 @@ > >MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > >MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > > > > > MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf > > - FatBinPkg/EnhancedFatDxe/Fat.inf > > + FatPkg/EnhancedFatDxe/Fat.inf > > > > > > > #MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputD > x > > e.inf > > > > > MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleD > > xe.inf > > diff --git > > a/Platform/Intel/MinPlatformPkg/Include/Fdf/CoreUefiBootInclude.fdf > > b/Platform/Intel/MinPlatformPkg/Include/Fdf/CoreUefiBootInclude.fdf > > index 6406192443..da5ca76197 100644 > > --- a/Platform/Intel/MinPlatformPkg/Include/Fdf/CoreUefiBootInclude.fdf > > +++ > b/Platform/Intel/MinPlatformPkg/Include/Fdf/CoreUefiBootInclude.fdf > > @@ -58,7 +58,7 @@ INF > > MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf > > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > > INF > > > MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf > > -INF FatBinPkg/EnhancedFatDxe/Fat.inf > > +INF FatPkg/EnhancedFatDxe/Fat.inf > > > > #INF > > > MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDx > e. > > inf > > INF > > > MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleD > > xe.inf > > -- > > 2.18.0.windows.1 > > > > ___ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v3 00/16] Removed unused PCDs
Hi all, Sorry for that. Ray and Chao just helped me push the patches. It's my fault about the mistake. I'll prepare patches more carefully next time and make sure all things correct. Best Regards, Shenglei > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, October 2, 2018 6:14 PM > To: Ni, Ruiyu ; Zhang, Chao B > Cc: Zhang, Shenglei ; edk2-devel@lists.01.org; > Kinney, Michael D > Subject: Re: [edk2] [PATCH v3 00/16] Removed unused PCDs > > Ray, Chao, > > guys, you keep breaking the development process. Please fix your email > clients *now*. > > > On 08/28/18 05:42, shenglei wrote: > > shenglei (16): > > IntelFsp2Pkg FspSecCore: Remove unused PCDs > > IntelFsp2Pkg/BaseFspCommonLib: Remove unused PCDs > > IntelFsp2Pkg/BaseFspPlatformLib: Remove unused PCDs > > IntelFsp2Pkg/BaseFspSwitchStackLib: Remove unused PCDs > > IntelFsp2WrapperPkg/FspWrapperNotifyDxe: Remove an unused PCD > > IntelFsp2WrapperPkg/BaseFspWrapperPlatformLibSample: Remove PCDs > > SecurityPkg/Tcg2ConfigPei: Remove an unused PCD > > This was patch #07 in this series. I had never reviewed it, yet Chao > pushed it with my R-b as commit > > https://github.com/tianocore/edk2/commit/3e11c27f67ea > > > > SecurityPkg/Tcg2Dxe: Remove unused PCDs > > UefiCpuPkg/CpuCommonFeaturesLib: Remove an unused PCD > > MdePkg/BaseLib: Remove an unused PCD > > MdeModulePkg/DxeCapsuleLibFmp: Remove unused PCDs > > MdeModulePkg/FirmwarePerformanceDataTableDxe: Remove an unused > PCD > > ShellPkg/Shell: Remove unused PCDs > > This was patch #13 in this series. I reviewed it: > > http://mid.mail-archive.com/70dfa56d-6781-e8c0-f3f4- > aa1255867...@redhat.com > > but Ray pushed it as commit > > https://github.com/tianocore/edk2/commit/a9dfe53f56bb > > without my R-b tag. (Note: there was 1 month between my feedback and > the > push date.) > > The commit message now suggests that I ignored the patch (because I was > on CC, but seemingly didn't respond). It mis-represents my acts. > > > > ShellPkg/DpDynamicCommand: Remove unused PCDs > > ShellPkg/UefiHandleParsingLib: Remove an unused PCD > > Same here. Patch #15, pushed as commit > > https://github.com/tianocore/edk2/commit/42a7c2871a65 > > My review was at: > > http://mid.mail-archive.com/a70f17d9-b937-2835-4d71- > 5464bad82...@redhat.com > > but it was dropped from the commit. > > > > ShellPkg/UefiShellDebug1CommandsLib: Remove unused PCDs > > Ditto. Patch #16. My review was at: > > http://mid.mail-archive.com/d23e7c95-96e9-4088-4e95- > 5dbc0a331...@redhat.com > > but the patch was pushed as commit > > https://github.com/tianocore/edk2/commit/aa9986651bfe > > with my review lost. > > > This is not the first time it has happened. If I remember correctly, Ray > blamed his email client last time (not showing message threads > correctly, or something similar). > > I'm sorry, but this is unacceptable. This is on-going, systemic > disregard for the project's other participants. > > Please fix your mail user agents *now*. > > Here's my promise. Next time, I'm going to revert such commits (assuming > I manage to catch them again). They do not represent the facts from the > mailing list. > > Laszlo ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
