Re: [edk2] a minor logic error in PcAtChipsetPkg\Library\AcpiTimerLib\AcpiTimerLib.c

[Zeng, Star]

The patch has been pushed at dde4aedc35ee3c06b67c1a5c4f392e7a0b0f8254.
Thanks for the contribution.

Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of wang 
xiaofeng
Sent: Friday, May 13, 2016 10:56 AM
To: Zeng, Star <star.z...@intel.com>
Cc: edk2-devel@lists.01.org; Gao, Liming <liming@intel.com>
Subject: Re: [edk2] a minor logic error in 
PcAtChipsetPkg\Library\AcpiTimerLib\AcpiTimerLib.c

Hi Star,
   The attached is my code change for  this issue .You can see the 
difference with beyond compare. It is not based on latest code. Could you help 
to start a formal code review with this patch on behalf of me?  I am not 
familar the process of checking code to edk2. 
   Thanks !








At 2016-05-13 10:34:21, "Zeng, Star" <star.z...@intel.com> wrote:
>I think you are right. Could you help contribute the patch to fix it?
>
>Thanks,
>Star
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of wang 
>xiaofeng
>Sent: Friday, May 13, 2016 10:20 AM
>To: edk2-devel@lists.01.org
>Subject: [edk2] a minor logic error in 
>PcAtChipsetPkg\Library\AcpiTimerLib\AcpiTimerLib.c
>
>Hi Everyone ,
>Please refer to the code in AcpiTimerLibConstructor  in 
> PcAtChipsetPkg\Library\AcpiTimerLib\AcpiTimerLib.c
>The orginal code is 
>
>
>  if ((PciRead8 (PCI_LIB_ADDRESS (Bus, Device, Function, EnableRegister) & 
> EnableMask) != EnableMask)) {
>
>
>The bracket place is not right, I think it should be 
>
>
>   if ((PciRead8 (PCI_LIB_ADDRESS (Bus, Device, Function, EnableRegister)) & 
> EnableMask) != EnableMask)
> 
>Anyhow , the impact is minor since it will enable ACPI I/O base again.
>
>___
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
>___
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] a minor logic error in PcAtChipsetPkg\Library\AcpiTimerLib\AcpiTimerLib.c

[wang xiaofeng]

Hi Star,
   The attached is my code change for  this issue .You can see the 
difference with beyond compare. It is not based on latest code. Could you help 
to start a formal code review with this patch on behalf of me?  I am not 
familar the process of checking code to edk2. 
   Thanks !








At 2016-05-13 10:34:21, "Zeng, Star"  wrote:
>I think you are right. Could you help contribute the patch to fix it?
>
>Thanks,
>Star
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of wang 
>xiaofeng
>Sent: Friday, May 13, 2016 10:20 AM
>To: edk2-devel@lists.01.org
>Subject: [edk2] a minor logic error in 
>PcAtChipsetPkg\Library\AcpiTimerLib\AcpiTimerLib.c
>
>Hi Everyone ,
>Please refer to the code in AcpiTimerLibConstructor  in 
> PcAtChipsetPkg\Library\AcpiTimerLib\AcpiTimerLib.c
>The orginal code is 
>
>
>  if ((PciRead8 (PCI_LIB_ADDRESS (Bus, Device, Function, EnableRegister) & 
> EnableMask) != EnableMask)) {
>
>
>The bracket place is not right, I think it should be 
>
>
>   if ((PciRead8 (PCI_LIB_ADDRESS (Bus, Device, Function, EnableRegister)) & 
> EnableMask) != EnableMask)
> 
>Anyhow , the impact is minor since it will enable ACPI I/O base again.
>
>___
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
>___
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] a minor logic error in PcAtChipsetPkg\Library\AcpiTimerLib\AcpiTimerLib.c

[Zeng, Star]

I think you are right. Could you help contribute the patch to fix it?

Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of wang 
xiaofeng
Sent: Friday, May 13, 2016 10:20 AM
To: edk2-devel@lists.01.org
Subject: [edk2] a minor logic error in 
PcAtChipsetPkg\Library\AcpiTimerLib\AcpiTimerLib.c

Hi Everyone ,
Please refer to the code in AcpiTimerLibConstructor  in 
PcAtChipsetPkg\Library\AcpiTimerLib\AcpiTimerLib.c
The orginal code is 


  if ((PciRead8 (PCI_LIB_ADDRESS (Bus, Device, Function, EnableRegister) & 
EnableMask) != EnableMask)) {


The bracket place is not right, I think it should be 


   if ((PciRead8 (PCI_LIB_ADDRESS (Bus, Device, Function, EnableRegister)) & 
EnableMask) != EnableMask)
 
Anyhow , the impact is minor since it will enable ACPI I/O base again.

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel