Re: ox-coma-letter and org-export-dispatch

2023-06-21 Thread Sébastien Gendre
It work.

Thank you. :)


Nick Dokos  writes:

> Sébastien Gendre  writes:
>
>
>> Recently I tested the export functions of ox-coma-letter. It work very
>> well.
>>
>> But I cannot found the entries in org-export-dispatch.
>>
>
> You probably need to load (or require) the feature. Add this to your
> init file:
>
> --8<---cut here---start->8---
> (require 'ox-koma-letter)
> --8<---cut here---end--->8---




Re: [BUG] `org-delete-char` and `org-delete-backward-char` don't respect `delete-active-region`

2023-06-21 Thread Okamsn
On 2023-06-21 10:14 UTC, Ihor Radchenko wrote:
> Okamsn  writes:
> 
>> `org-delete-char` and `org-delete-backward-char` don't respect
>> `delete-active-region`
> 
> Clarification first.
> `org-delete-char' and `org-delete-backward-char' are not supposed to
> respect `delete-active-region'. They are the replacements for
> `delete-char' and `delete-backward-char' that also do not respect it.
> Org only re-binds `delete-char' and `delete-backward-char' >
>> This works when `delete` is bound to `forward-delete-char` and
>> `backspace` is bound to `backward-delete-char-untabify`, because both
>> commands respect `delete-active-region`.
>>
>> This does not work with `org-delete-backward-char` or `org-delete-char`,
>> because those commands use `delete-char`, which does not respect
>> `delete-active-region`.
> 
> May you please explain what exactly you did? Or meow did? Did it bind
> the Org functions inappropriately? Or are you asking to add new Org
> commands that respect `delete-active-region'?

Thank you for the clarification. In my config, I had remapped 
`delete-char` to `delete-forward-char` years ago and I had forgotten 
that I did that. In Emacs 29, I see in the definition of 
`delete-backward-char` that this command _does_ respect 
`delete-active-region`, and that `delete-char` does not respect this 
setting.

Meow only sets `delete-active-region` to nil. It does not bind any Org 
commands. I only mentioned it to give context. My apologies for any 
confusion.

With your clarification, I am asking that Org commands be added/changed 
to support `delete-active-region`.

Thank you.



> --
> Ihor Radchenko // yantar92,
> Org mode contributor,
> Learn more about Org mode at .
> Support Org development at ,
> or support my work at 





Re: Inline comments

2023-06-21 Thread Max Nikulin

On 22/06/2023 07:04, ypuntot wrote:


Could it be possible to make inline comments (# something like this) ?

I found this, but it doesn't seem to world, or I misused it.
https://gist.github.com/andersjohansson/6baa1e42ad4d7353e125


Unfortunately the only native comments that Org has are ones that 
separate block-level elements. There are some workarounds however: 
@@comment: ...@@ taking advantage of unknown export backend, 
{{{comment(...)}}} macro expanding to nothing. Perhaps a dedicated babel 
language may be defined exporting nothing by default.


Previous discussion:

Max Nikulin to emacs-orgmode… Re: [PATCH] ox: fix comment exported as a 
blank line. Thu, 2 Jun 2022 23:09:04 +0700.

https://list.orgmode.org/e384d381-0a60-f777-b285-e0b8e62b1...@gmail.com




org-fold style text-properties slowdown

2023-06-21 Thread Sebastian Wålinder
Hello!

I write regularly in a massive org file ~160 000 lines, and experience 
progressive slowdowns as the buffer remains open when I have the setting `(setq 
org-fold-core-style 'text-properties)`.

When the file is first opened, all operations are very fast. But as I keep 
using, it keeps slowing down and eventually slows to a crawl where typing a 
single character takes several seconds. However, after closing the buffer and 
opening the file up again, the speed returns to normal.

With `(setq org-fold-core-style 'overlays)` in my `early-init.el`, I have no 
slowdown issue related to org-fold over time.

Running the CPU profiler while typing a few characters in the buffer yields me 
this report:
```
17969  99% - command-execute
17969  99%  - funcall-interactively
17956  99%   - org-self-insert-command
17940  99%- org-fold-core--fix-folded-region
178   0% - org-fold-core-next-folding-state-change
177   0%#
42   0% - org-fold-core-get-region-at-point
1   0%org-fold-core--property-symbol-get-create
21   0% - org-fold--reveal-outline-maybe
18   0%  - org-fold--reveal-headline-at-point
16   0%   - org-end-of-subtree
9   0%- org-back-to-heading-or-point-min
8   0% - org-before-first-heading-p
8   0%org-element-at-point
1   0%   org-back-to-heading
6   0%  org-element-at-point
2   0%  - rx-to-string
2   0%   - rx--translate
2   0%- rx--translate-form
1   0% - rx--translate-or
1   0%mapcan
1   0% - org-fold-core-get-folding-spec
1   0%org-fold-core--property-symbol-get-create
1   0% - org-fold-core-region-folded-p
1   0%  - org-fold-core-get-folding-spec
1   0% org-fold-core-get-folding-spec-from-alias
1   0%   #
1   0%- #
1   0%   let
1   0%- org-element--cache-after-change
1   0% - org-element--cache-submit-request
1   0%org-element--cache-sync
3   0%   - my/system-hydra/profiler-stop-and-exit
3   0%- hydra--call-interactively-remap-maybe
3   0%   funcall-interactively
3   0%   - evil-normal-state
1   0%- evil-change-state
1   0%   evil-insert-state
3   0%   - my/system-hydra/profiler-report-and-exit
2   0%- hydra--call-interactively-remap-maybe
2   0%   funcall-interactively
1   0%- hydra-keyboard-quit
1   0% - #
1   0%  - message
1   0%   - apply
1   0%  mini-modeline--reroute-msg
1   0%   - evil-previous-line
1   0%- evil-line-move
1   0%   line-move
1   0%   - my/system-hydra/body
1   0%- my/hydra-pre-cursor
1   0%   evil-set-cursor-color
```
The memory profiler reports nothing significant. It appears 
`org-fold-core--fix-folded-region` is what's taking all the cycles. What's the 
best way for me to proceed debugging this? 

Setup:
`GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 
1.16.0, Xaw3d scroll bars)`

`Org mode version 9.6.6 (release_9.6.6 @ 
/nix/store/q8adc2srnbipkahbwffwg006d09yk02g-emacs-git-20230618.0/share/emacs/30.0.50/lisp/org/)`

Thanks!
Sebastian



Inline comments

2023-06-21 Thread ypuntot
Hi

Could it be possible to make inline comments (# something like this) ?

I found this, but it doesn't seem to world, or I misused it.
https://gist.github.com/andersjohansson/6baa1e42ad4d7353e125

Best regards


Re: ox-coma-letter and org-export-dispatch

2023-06-21 Thread Nick Dokos
Sébastien Gendre  writes:


> Recently I tested the export functions of ox-coma-letter. It work very
> well.
>
> But I cannot found the entries in org-export-dispatch.
>

You probably need to load (or require) the feature. Add this to your
init file:

--8<---cut here---start->8---
(require 'ox-koma-letter)
--8<---cut here---end--->8---

-- 
Nick

"There are only two hard problems in computer science: cache
invalidation, naming things, and off-by-one errors." -Martin Fowler




ox-coma-letter and org-export-dispatch

2023-06-21 Thread Sébastien Gendre
Hello,


Recently I tested the export functions of ox-coma-letter. It work very
well.

But I cannot found the entries in org-export-dispatch.

Did I miss something ?



Best regards

---
Gendre Sébastien



[BUG] org-babel-tangle: Header arg `:comments org' produces no comment in the output [9.7-pre (release_9.6.6-418-g294a4d @ /home/nick/src/emacs/org/org-mode/lisp/)]

2023-06-21 Thread Nick Dokos



Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

 https://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org mailing list.


Here's an ECM:

--8<---cut here---start->8---
* Function heading

  #+begin_src elisp :tangle "file.el" :comments org
(message "FOO")
  #+end_src
--8<---cut here---end--->8---

Tangling it with `C-c C-v C-t' produces the following:

--8<---cut here---start->8---
(message "FOO")
--8<---cut here---end--->8---

with no comment added.

In 9.5.5, the output is correct:

--8<---cut here---start->8---
;; Function heading


(message "FOO")
--8<---cut here---end--->8---

I narrowed it down to this snippet of code in `org-babel-tangle-single-block':

,
|   ;; From the previous heading or code-block end
|   (funcall
|org-babel-process-comment-text
|(buffer-substring
| (max (condition-case nil
|  (save-excursion
|(org-back-to-heading t) ; Sets match data
|(match-end 0))
|(error (point-min)))
|  (save-excursion
|(if (re-search-backward
| org-babel-src-block-regexp nil t)
|(match-end 0)
|  (point-min
| (point)
`

and bisecting fingered this commit:

--8<---cut here---start->8---
2737128aa778297f41971cc93c464faf17718e34 is the first bad commit
commit 2737128aa778297f41971cc93c464faf17718e34
Author: Ihor Radchenko 
Date:   Tue Sep 13 20:59:13 2022 +0800

org-back-to-heading: Use cache

* lisp/org.el (org-back-to-heading): Use element cache when cache is
active.

 lisp/org.el | 63 -
 1 file changed, 41 insertions(+), 22 deletions(-)
--8<---cut here---end--->8---

Apparently, `org-back-to-heading' sets match data differently now: `(match-end 
0)' gets the end of the line,
Before the patch, it got the beginning of the line.

Emacs  : GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.37, 
cairo version 1.17.6)
 of 2023-06-21
Package: Org mode version 9.7-pre (release_9.6.6-418-g294a4d @ 
/home/nick/src/emacs/org/org-mode/lisp/)
-- 
Nick

"There are only two hard problems in computer science: cache
invalidation, naming things, and off-by-one errors." -Martin Fowler




Re: How to tell `org-html-link' to create a link with some HTML class?

2023-06-21 Thread Marcin Borkowski


On 2023-06-20, at 18:30, Max Nikulin  wrote:

> On 20/06/2023 11:42, Marcin Borkowski wrote:
>> as I mentioned some time ago, I'm writing a custom exporter
>> (actually,
>> a very thin wrapper around the HTML exporter).  I'd like `org-html-link'
>> to add some class to the links it generates.  Is that possible?
>
> I do not have a ready to use recipe. Some links to mailing list threads:
>
> [...]

Thanks.  My use case is a bit different – I explicitly do not want to
mark these links in the Org file, but I want my custom exporter to add
some class to "external" links.  (Yes, I am coding yet another blogging
platform on top of Org mode – but I believe it has some novel aspects;
I did review the existing options and none of them seems to do what
I want.)

Thanks anyway,

-- 
Marcin Borkowski
http://mbork.pl



Re: [PATCH] org-capture.el: Allow `(here)' as a template target

2023-06-21 Thread Tim Visher
On Wed, Jun 21, 2023 at 11:54 AM Ihor Radchenko  wrote:

> Tim Visher  writes:
>
> >> Also, may you update the docstring of `org-capture-templates'
> >
> >
> > Good catch! This has been done in patch 0004 now. Look good?
>
> Yup.
>



>> "10.1.3.1 Template elements" section of Org manual?
> >
> > I'm confused about what you're referring to here. Isn't that what 0002
> does?
>
> Yes, it does. I saw it, then noticed the missing `org-capture-templates'
> docstring update, and somehow deduced that manual must be missing
> :facepalm:
>




> > Again, happy to squash and provide a single complete patch once we're all
> > done the review. Thanks again, Ihor! :)
>
> Please, also add all the necessary changelog entries to the final commit
> message.
>

Will do! I've attached a prospective patch file but I'm not sure I follow
what you mean by 'add all the necessary changelog entries to the final
commit
message'. Looking at this commit

I'm guessing that I should have an `* …` entry for every file except
`etc/NEWS` that I changed so I've done that but please do let me know if
that was the wrong interpretation. :)


0001-org-capture.el-Allow-here-as-a-template-target 3.patch
Description: Binary data


Re: [PATCH] ox-html.el: add option to embed SVG for CSS support in SVG

2023-06-21 Thread Ihor Radchenko
Max Nikulin  writes:

> Besides the HTML related question how to mate all SVG options with all 
> Org features (figures, etc.) there is a purely Org design choice: 
> whether there should be multiple Org boolean variables and attributes 
> describing strategy for particular image or it is single variable and 
> attribute with symbol (or string) value.

If we talk about image attributes defined in the affiliated keywords, we
should better resort to #+ATTR_HTML. Introducing extra affiliated
keyword would be a breaking change.

Org only recognizes affiliated keywords listed in
org-element-affiliated-keywords + ATTR_* keywords.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 



Re: [PATCH] ox-html.el: add option to embed SVG for CSS support in SVG

2023-06-21 Thread Max Nikulin

On 21/06/2023 23:02, Ihor Radchenko wrote:

Max Nikulin writes:


I think you missed `org-html-inline-image-rules' where users can
include/exclude svg images from inlining.


Ihor, I am not sure that I get your point. If I understand it correctly,
`org-html-inline-image-rules' specifies whether links to svg files
should be kept as links or should be transformed to images. Gerard
proposes to add options how to treat SVG *images*: ,  or
include content of the SVG file literally. `org-html-inline-image-rules'
does not allow to specify extended options how to treat each match.


That's why Timothy should review this patch.
I am missing all these subtle details about HTML due to lack of knowledge.


Besides the HTML related question how to mate all SVG options with all 
Org features (figures, etc.) there is a purely Org design choice: 
whether there should be multiple Org boolean variables and attributes 
describing strategy for particular image or it is single variable and 
attribute with symbol (or string) value.





Re: [PATCH] ox-html.el: add option to embed SVG for CSS support in SVG

2023-06-21 Thread Ihor Radchenko
Max Nikulin  writes:

>> I think you missed `org-html-inline-image-rules' where users can
>> include/exclude svg images from inlining.
>
> Ihor, I am not sure that I get your point. If I understand it correctly, 
> `org-html-inline-image-rules' specifies whether links to svg files 
> should be kept as links or should be transformed to images. Gerard 
> proposes to add options how to treat SVG *images*: ,  or 
> include content of the SVG file literally. `org-html-inline-image-rules' 
> does not allow to specify extended options how to treat each match.

That's why Timothy should review this patch.
I am missing all these subtle details about HTML due to lack of knowledge.

> I am not against  option, my concern is to avoid extremely heavy 
> page by e.g. rendering a lot of math as svg files. I am not even sure 
> that the issue is real, however I suspect it might happen. Adding a 
> warning to docs would be enough.

We can add a warning iff we conclude that the issue is real.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 



Re: [PATCH] org-capture.el: Allow `(here)' as a template target

2023-06-21 Thread Ihor Radchenko
Tim Visher  writes:

>> Also, may you update the docstring of `org-capture-templates'
>
>
> Good catch! This has been done in patch 0004 now. Look good?

Yup.

>> "10.1.3.1 Template elements" section of Org manual?
>
> I'm confused about what you're referring to here. Isn't that what 0002 does?

Yes, it does. I saw it, then noticed the missing `org-capture-templates'
docstring update, and somehow deduced that manual must be missing :facepalm:

> Again, happy to squash and provide a single complete patch once we're all
> done the review. Thanks again, Ihor! :)

Please, also add all the necessary changelog entries to the final commit
message.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 



Re: [PATCH] ox-html.el: add option to embed SVG for CSS support in SVG

2023-06-21 Thread Max Nikulin

On 16/06/2023 03:51, Ihor Radchenko wrote:

gerard.vermeu...@posteo.net writes:


;; 1. It checks `svg-as-object' and "image in-lining" whether to
;;embed the SVG image in an  tag.

...

I think you missed `org-html-inline-image-rules' where users can
include/exclude svg images from inlining.


Ihor, I am not sure that I get your point. If I understand it correctly, 
`org-html-inline-image-rules' specifies whether links to svg files 
should be kept as links or should be transformed to images. Gerard 
proposes to add options how to treat SVG *images*: ,  or 
include content of the SVG file literally. `org-html-inline-image-rules' 
does not allow to specify extended options how to treat each match.


I am not against  option, my concern is to avoid extremely heavy 
page by e.g. rendering a lot of math as svg files. I am not even sure 
that the issue is real, however I suspect it might happen. Adding a 
warning to docs would be enough.








Re: [PATCH] org-capture.el: Allow `(here)' as a template target

2023-06-21 Thread Tim Visher
On Wed, Jun 21, 2023 at 6:29 AM Ihor Radchenko  wrote:

> Tim Visher  writes:
>
> > I've now created patches for updating the manual and NEWS file. Let me
> know
> > how they look!
>
> Thanks! The patches look good, and the commit messages look excellent.
>

٩( ᐛ )و


> You could, however, squash the patches together


Absolutely! Will do once we've approved the whole change. I will use the
commit message of 0001 for the whole patch.


> Also, may you update the docstring of `org-capture-templates'


Good catch! This has been done in patch 0004 now. Look good?


> "10.1.3.1 Template elements" section of Org manual?
>

I'm confused about what you're referring to here. Isn't that what 0002 does?

```
$ cat 0002-squash-doc-org-manual.org-Add-documentation-for-here.patch
>From 4b4bf944129635637c6fd57076f1c963b4c27bf6 Mon Sep 17 00:00:00 2001
From: Tim Visher 
Date: Tue, 20 Jun 2023 15:11:58 -0400
Subject: [PATCH 2/4] squash! doc/org-manual.org: Add documentation for
 `(here)` target

---
 doc/org-manual.org | 4 
 1 file changed, 4 insertions(+)

diff --git a/doc/org-manual.org b/doc/org-manual.org
index 21582fe8e..76131f110 100644
--- a/doc/org-manual.org
+++ b/doc/org-manual.org
@@ -7946,6 +7946,10 @@ Now lets look at the elements of a template
definition.  Each entry in

 File to the entry that is currently being clocked.

+  - =(here)= ::
+
+The position of =point=.
+
   - =(function function-finding-location)= ::

 Most general way: write your own function which both visits the
--
2.40.1
```

Again, happy to squash and provide a single complete patch once we're all
done the review. Thanks again, Ihor! :)


0002-squash-doc-org-manual.org-Add-documentation-for-here.patch
Description: Binary data


0003-squash-etc-ORG-NEWS-Add-entry-for-here-capture-templ.patch
Description: Binary data


0004-squash-Update-docstring-of-org-capture-templates.patch
Description: Binary data


0001-org-capture.el-Allow-here-as-a-template-target 2.patch
Description: Binary data


Re: [PATCH] Re: Offline documentation (Org Manual info file) of org hooks is misleading

2023-06-21 Thread libreville
Great! Thanks for the help and nice working with you. :)

On 2023-06-21 11:58, Ihor Radchenko wrote:
> libreville  writes:
> 
>> Thanks a lot for the pointers.
>> Is this better?
> 
> Yup. Thanks!
> 
> Applied, onto main, with amendment.
> 
> I have removed
> 
>>  Date:  Wed Jun 21 13:04:19 2023 +0200
>>  Changes to be committed:
>>  modified:   doc/org-manual.org
> 
> I have also fixed the changelog entry and added "." at the end of the
> sentence there.
> 
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=eab92e8f7
> 
> You are now listed in the contributor list.
> https://git.sr.ht/~bzg/worg/commit/3f85dd4c



Re: [PATCH] Re: Offline documentation (Org Manual info file) of org hooks is misleading

2023-06-21 Thread Ihor Radchenko
libreville  writes:

> Thanks a lot for the pointers.
> Is this better?

Yup. Thanks!

Applied, onto main, with amendment.

I have removed

>  Date:  Wed Jun 21 13:04:19 2023 +0200
>  Changes to be committed:
>   modified:   doc/org-manual.org

I have also fixed the changelog entry and added "." at the end of the
sentence there.

https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=eab92e8f7

You are now listed in the contributor list.
https://git.sr.ht/~bzg/worg/commit/3f85dd4c

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 



[PATCH] Re: Offline documentation (Org Manual info file) of org hooks is misleading

2023-06-21 Thread libreville
Thanks a lot for the pointers.
Is this better?

On 2023-06-21 11:35, Ihor Radchenko wrote:
> libreville  writes:
> 
>> Here's my attempt.
> 
> Thanks!
> 
>> It's my first time doing this, so kindly let me know if there's
>> something I can do better!
> 
> Generally, we have instructions in 
> https://orgmode.org/worg/org-contribute.html#first-patch
> 
>> For example, should I have replaced the subject line of this email with
>> the subject in the formatted .patch?
> 
> Not necessarily. Although, adding [PATCH] to the subject would be
> helpful as an indication.
> 
>> From c1fda8d0162583db709c90f01df2b8678ddc7957 Mon Sep 17 00:00:00 2001
>> From: libreville 
>> Date: Wed, 21 Jun 2023 13:04:19 +0200
>> Subject: [PATCH] Delete reference to non-existent examples of hook usage.
> 
> 1. I'd add "org-manual: ..." to indicate which part of Org is modified.
> 2. There is no need to end the subject (first) line with "."
> 3. You need to add TINYCHANGE cookie, unless you have FSF copyright
>assignment.
> 4. Changelog entry would be good, although this is a simple patch and we
>can skip it here.
> 
> Hope it is going to be a good practice :)
From 6d0ade6af4ec4ab2fd8be578dd8851fae9e91253 Mon Sep 17 00:00:00 2001
From: libreville 
Date: Wed, 21 Jun 2023 13:04:19 +0200
Subject: [PATCH] org-manual.org: Delete ref to non-existent examples of hook
 usage

 Date:  Wed Jun 21 13:04:19 2023 +0200
 Changes to be committed:
	modified:   doc/org-manual.org

* org-manual.org:  Delete ref to non-existent examples of hook usage in
A.1 Hooks

TINYCHANGE
---
 doc/org-manual.org | 7 +++
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/doc/org-manual.org b/doc/org-manual.org
index 4feb15e71..21582fe8e 100644
--- a/doc/org-manual.org
+++ b/doc/org-manual.org
@@ -21128,10 +21128,9 @@ of Org.
 :END:
 #+cindex: hooks
 
-Org has a large number of hook variables for adding functionality.
-This appendix illustrates using a few.  A complete list of hooks with
-documentation is maintained by the Worg project at
-https://orgmode.org/worg/doc.html#hooks.
+Org has a large number of hook variables for adding functionality.  A
+complete list of hooks with documentation is maintained by the Worg
+project at https://orgmode.org/worg/doc.html#hooks.
 
 ** Add-on Packages
 :PROPERTIES:
-- 
2.30.2



Re: Offline documentation (Org Manual info file) of org hooks is misleading

2023-06-21 Thread Ihor Radchenko
libreville  writes:

> Here's my attempt.

Thanks!

> It's my first time doing this, so kindly let me know if there's
> something I can do better!

Generally, we have instructions in 
https://orgmode.org/worg/org-contribute.html#first-patch

> For example, should I have replaced the subject line of this email with
> the subject in the formatted .patch?

Not necessarily. Although, adding [PATCH] to the subject would be
helpful as an indication.

> From c1fda8d0162583db709c90f01df2b8678ddc7957 Mon Sep 17 00:00:00 2001
> From: libreville 
> Date: Wed, 21 Jun 2023 13:04:19 +0200
> Subject: [PATCH] Delete reference to non-existent examples of hook usage.

1. I'd add "org-manual: ..." to indicate which part of Org is modified.
2. There is no need to end the subject (first) line with "."
3. You need to add TINYCHANGE cookie, unless you have FSF copyright
   assignment.
4. Changelog entry would be good, although this is a simple patch and we
   can skip it here.

Hope it is going to be a good practice :)

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 



Re: replace-regexp ignoring value of org-search-invisible

2023-06-21 Thread bobf32
Fair enough, thank you.

On Wed, 21 Jun 2023 at 11:20, Ihor Radchenko  wrote:

> bob...@gmail.com writes:
>
> > ...
> > I expect two replacements to be made, and all the invisible text to be
> > ignored. What actually happens is that the text is appended to all lines
> > under the ** B and ** C headings plus the two desired headings
> > themselves.
>
> Canceled.
> It is a bug in Emacs.
> See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64178
>
> --
> Ihor Radchenko // yantar92,
> Org mode contributor,
> Learn more about Org mode at .
> Support Org development at ,
> or support my work at 
>


Re: Offline documentation (Org Manual info file) of org hooks is misleading

2023-06-21 Thread libreville
Here's my attempt.

It's my first time doing this, so kindly let me know if there's
something I can do better!

For example, should I have replaced the subject line of this email with
the subject in the formatted .patch?


On 2023-06-21 10:26, Ihor Radchenko wrote:
> libreville  writes:
> 
>> Chapter A.1 Hooks of the Org Manual reads, in its entirety:
>> ...
>> Contrary to what it says, I couldn't find any illustrations of hook
>> usage in the appendix. The Variables index only refers to four, and
>> they're in other places.
>>
>> Perhaps the line about illustrating could be deleted, to avoid sending
>> people on a search for something that isn't there?
> 
> Agree.
> Would you be interested to submit a patch?
From c1fda8d0162583db709c90f01df2b8678ddc7957 Mon Sep 17 00:00:00 2001
From: libreville 
Date: Wed, 21 Jun 2023 13:04:19 +0200
Subject: [PATCH] Delete reference to non-existent examples of hook usage.

---
 doc/org-manual.org | 7 +++
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/doc/org-manual.org b/doc/org-manual.org
index 4feb15e71..21582fe8e 100644
--- a/doc/org-manual.org
+++ b/doc/org-manual.org
@@ -21128,10 +21128,9 @@ of Org.
 :END:
 #+cindex: hooks
 
-Org has a large number of hook variables for adding functionality.
-This appendix illustrates using a few.  A complete list of hooks with
-documentation is maintained by the Worg project at
-https://orgmode.org/worg/doc.html#hooks.
+Org has a large number of hook variables for adding functionality.  A
+complete list of hooks with documentation is maintained by the Worg
+project at https://orgmode.org/worg/doc.html#hooks.
 
 ** Add-on Packages
 :PROPERTIES:
-- 
2.30.2



Re: [PATCH] org-capture.el: Allow `(here)' as a template target

2023-06-21 Thread Ihor Radchenko
Tim Visher  writes:

> Sorry this took me forever to get to.
>
> I've now created patches for updating the manual and NEWS file. Let me know
> how they look!

Thanks! The patches look good, and the commit messages look excellent.
You could, however, squash the patches together - they are about the
same change; there is no good reason to separate them.

Also, may you update the docstring of `org-capture-templates' and
"10.1.3.1 Template elements" section of Org manual?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 



Re: Offline documentation (Org Manual info file) of org hooks is misleading

2023-06-21 Thread Ihor Radchenko
libreville  writes:

> Chapter A.1 Hooks of the Org Manual reads, in its entirety:
> ...
> Contrary to what it says, I couldn't find any illustrations of hook
> usage in the appendix. The Variables index only refers to four, and
> they're in other places.
>
> Perhaps the line about illustrating could be deleted, to avoid sending
> people on a search for something that isn't there?

Agree.
Would you be interested to submit a patch?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 



Re: replace-regexp ignoring value of org-search-invisible

2023-06-21 Thread Ihor Radchenko
bob...@gmail.com writes:

> ...
> I expect two replacements to be made, and all the invisible text to be
> ignored. What actually happens is that the text is appended to all lines
> under the ** B and ** C headings plus the two desired headings
> themselves.

Canceled.
It is a bug in Emacs.
See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64178

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 



Re: [BUG] `org-delete-char` and `org-delete-backward-char` don't respect `delete-active-region`

2023-06-21 Thread Ihor Radchenko
Okamsn  writes:

> `org-delete-char` and `org-delete-backward-char` don't respect
> `delete-active-region`

Clarification first.
`org-delete-char' and `org-delete-backward-char' are not supposed to
respect `delete-active-region'. They are the replacements for
`delete-char' and `delete-backward-char' that also do not respect it.
Org only re-binds `delete-char' and `delete-backward-char'.

> This works when `delete` is bound to `forward-delete-char` and 
> `backspace` is bound to `backward-delete-char-untabify`, because both 
> commands respect `delete-active-region`.
>
> This does not work with `org-delete-backward-char` or `org-delete-char`, 
> because those commands use `delete-char`, which does not respect 
> `delete-active-region`.

May you please explain what exactly you did? Or meow did? Did it bind
the Org functions inappropriately? Or are you asking to add new Org
commands that respect `delete-active-region'?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 



Offline documentation (Org Manual info file) of org hooks is misleading

2023-06-21 Thread libreville
Howdy friends,

Chapter A.1 Hooks of the Org Manual reads, in its entirety:

"Org has a large number of hook variables for adding functionality. 
This appendix illustrates using a few.  A complete list of hooks with
documentation is maintained by the Worg project at
."

(I have the manual for Org 9.3, the online version of the chapter is
newer, but identical at this point.)

Contrary to what it says, I couldn't find any illustrations of hook
usage in the appendix. The Variables index only refers to four, and
they're in other places.

Perhaps the line about illustrating could be deleted, to avoid sending
people on a search for something that isn't there?

Best regards,
libreville