[E-devel] ecore_x_netwm: is allowed_action_isset correct ?

2007-03-18 Thread Vincent Torri

Hey,

In ecore_x_netwm_allowed_action_isset (ecore_x_netwm.c), we get the atoms 
from the ECORE_X_ATOM_NET_WM_WINDOW_TYPE property. I think that we should 
use ECORE_X_ATOM_NET_WM_ALLOWED_ACTIONS. Am I right ?

Vincent

-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT  business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] ecore_x_netwm: is allowed_action_isset correct ?

2007-03-18 Thread Christopher Michael
Vincent Torri wrote:
 Hey,
 
 In ecore_x_netwm_allowed_action_isset (ecore_x_netwm.c), we get the atoms 
 from the ECORE_X_ATOM_NET_WM_WINDOW_TYPE property. I think that we should 
 use ECORE_X_ATOM_NET_WM_ALLOWED_ACTIONS. Am I right ?
 
 Vincent

WM_ALLOWED_ACTIONS sounds proper to me...tho I recommend checking with 
someone more familiar with netwm :)

dh

-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT  business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] Ibox oddity when restarting E...

2007-03-18 Thread Christopher Michael
Ravenlock wrote:
 Hello,
 
 Most will probably not be bothered by this behavior.  But for some 
 reason it drives me crazy.
 
 It seems that when you restart E, you get all iconified applications 
 added to the iconbox present on the current desk regardless of the Show 
 windows from active desktop setting.
 
 For example,  If I have 4 desks, each with 2 iconified apps on them. 
 Then I restart E...  I will end up with 8 iconified apps in the icon box 
 on the current desktop.  If you switch from the current desktop to any 
 other... things get straightened out.  But it still bothers me.
 
 Attached is a patch to fix this behavior.
 
 
In cvs...Good catch :)

dh

-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT  business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] ecore_x_netwm: is allowed_action_isset correct ?

2007-03-18 Thread Kim Woelders
Vincent Torri wrote:
 Hey,
 
 In ecore_x_netwm_allowed_action_isset (ecore_x_netwm.c), we get the atoms 
 from the ECORE_X_ATOM_NET_WM_WINDOW_TYPE property. I think that we should 
 use ECORE_X_ATOM_NET_WM_ALLOWED_ACTIONS. Am I right ?
 
Yes.

However, I'm not sure this function should exist at all.
The WM sets the allowed actions list on client windows and should never 
have to test what it actually did :)
Clients that bother about allowed actions (typically a taskbar) should 
monitor the property and keep a local allowed actions state and not 
query the server using e.g. ecore_x_netwm_allowed_action_isset every 
time it needs the info.

/Kim

-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT  business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] [ENM] A network manager front end

2007-03-18 Thread Alexander Griesser
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

watchwolf wrote:
 The application can have some bugs for you as segv :p 

Well, and what to do if it has?

vi-edv003:/home/tuxx/enm_18_03_07/etk# ./enm
Segmentation fault
vi-edv003:/home/tuxx/enm_18_03_07/etk#

Otherwise, the screenshots look really nice, I'd love to give it a try
:)

ciao,
- --
|   .-.  |Alexander Griesser -- [EMAIL PROTECTED] | .''`. |
|   /v\   \  http://www.tuxx-home.at/ / : :' : |
| /(   )\  |  GPG-KeyID: 0xA2949B5A  |  `. `'  |
|  ^^ ^^   `-'`-   |
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFF/Xa966HVD6KUm1oRAgMCAJ4pMFbqRfdKBS18YddFqccXgNfxQACdEaAM
ReYSKYTot+cWSPfZ/TCxtCw=
=o1Xs
-END PGP SIGNATURE-

-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT  business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] [ENM] A network manager front end

2007-03-18 Thread Zachary Goldberg
Hey, just tried to test out your program.  Unfortunatly it won't
compile due to the following error:


src/general_panel.c:26: error: too many arguments to function
'etk_combobox_column_add'

I believe this is an error due to a (very) recent API change within etk.

--ZGold


On 3/18/07, watchwolf [EMAIL PROTECTED] wrote:
 hello,

 I want present you a new application writed with etk for E17.
 The application can have some bugs for you as segv :p . The code is not
 perfect, I need to add some tests  errors outputs. The next steps,
 before add new functions, is to clean/correct the code.

 You can see screenshots  the source code on my blog.
 http://watchwolf.fr/index.php?post/2007/03/18/%5BE17-Network-manager%
 5D-Pesentation

 To compile us this makefile: etk/Makefile.

 --
 powered by gnu/linux

 -
 Take Surveys. Earn Cash. Influence the Future of IT
 Join SourceForge.net's Techsay panel and you'll get the chance to share your
 opinions on IT  business topics through brief surveys-and earn cash
 http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
 ___
 enlightenment-devel mailing list
 enlightenment-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-devel




-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT  business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] [ENM] A network manager front end

2007-03-18 Thread Zachary Goldberg
By changing lines 25 and 26 of general_panel.c to

etk_combobox_column_add(ETK_COMBOBOX(pnl-cmbox_ethernet),
ETK_COMBOBOX_IMAGE, 25, ETK_FALSE,   0.5);
   etk_combobox_column_add(ETK_COMBOBOX(pnl-cmbox_ethernet),
ETK_COMBOBOX_LABEL, 25, ETK_FALSE,  0.5);


I'm successfully able to run the program -- quite nice from my first
impression.  Great work

--ZGold

On 3/18/07, Zachary Goldberg [EMAIL PROTECTED] wrote:
 Hey, just tried to test out your program.  Unfortunatly it won't
 compile due to the following error:


 src/general_panel.c:26: error: too many arguments to function
 'etk_combobox_column_add'

 I believe this is an error due to a (very) recent API change within etk.

 --ZGold


 On 3/18/07, watchwolf [EMAIL PROTECTED] wrote:
  hello,
 
  I want present you a new application writed with etk for E17.
  The application can have some bugs for you as segv :p . The code is not
  perfect, I need to add some tests  errors outputs. The next steps,
  before add new functions, is to clean/correct the code.
 
  You can see screenshots  the source code on my blog.
  http://watchwolf.fr/index.php?post/2007/03/18/%5BE17-Network-manager%
  5D-Pesentation
 
  To compile us this makefile: etk/Makefile.
 
  --
  powered by gnu/linux
 
  -
  Take Surveys. Earn Cash. Influence the Future of IT
  Join SourceForge.net's Techsay panel and you'll get the chance to share your
  opinions on IT  business topics through brief surveys-and earn cash
  http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
  ___
  enlightenment-devel mailing list
  enlightenment-devel@lists.sourceforge.net
  https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
 
 
 


-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT  business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] [ENM] A network manager front end

2007-03-18 Thread Alexander Griesser
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

watchwolf wrote:
 you can try:
 in libenm/src/ethernet.c , comment eth_load_gateway(); in the function
 eth_load_configuration()
 The application will not load your gateway.

OK, I found out what's wrong:
I have the cisco VPN client installed which creates an interface called
cipsec0.
Your program seems to have troubles in reading this interface's
configuration and therefore I `rmmod`ed the cisco_ipsec kernel module.

Afterwards, the program started.

JFYI: The output of `ifconfig cipsec0` looks like this:

cipsec0   Link encap:Ethernet  HWaddr 00:0B:FC:F8:01:8F
  NOARP  MTU:1356  Metric:1
  RX packets:0 errors:0 dropped:0 overruns:0 frame:0
  TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
  collisions:0 txqueuelen:1000
  RX bytes:0 (0.0 b)  TX bytes:0 (0.0 b)


Please tell me, if I can help you any further with this issue.

ciao,
- --
|   .-.  |Alexander Griesser -- [EMAIL PROTECTED] | .''`. |
|   /v\   \  http://www.tuxx-home.at/ / : :' : |
| /(   )\  |  GPG-KeyID: 0xA2949B5A  |  `. `'  |
|  ^^ ^^   `-'`-   |
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFF/YCK66HVD6KUm1oRAkRMAJwOgFBzsT+0gCGauZNKRiJL2KYNiQCfXlix
PJnwV7CPwJjgjSzFQfGRvC4=
=tDJd
-END PGP SIGNATURE-

-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT  business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] Is efreet still coming?

2007-03-18 Thread Brian Mattern
On Sun, Mar 18, 2007 at 03:29:13PM +1000, David Seikel wrote:
 Raster made this commit about two weeks ago :
 
  a lot of patches - also my work on moving the IO stuff in e_fm to a
  slave process to stop e from ever locking up. this unfortunately
  breaks the other source stuff and thus breaks the app editor config
  dialogs and anything using fm2 for .desktop stuff from the e
  applications/all repo. i am doing this as i expect this to go away
  with efreet anyway so not too much of an issue. not all fm operatiosn
  work currently - note. so beware. it can view files though :)
 
 So I have been holding off on any attempt to repair these things and
 just sitting and waiting for efreet to solve all our problems.  The
 users are now complaining about the broken app editor.  I have not seen
 any efreet commits for a while, is it going to replace ecore_desktop
 soon?  Or should I put in some effort to patching up the app editor
 while we wait?

Efreet is pretty much complete, other than being itegrated into e17.
Unfortunately, dan doesn't use e17 on anymore and seb and I have been
pretty busy lately. 

 
 What state of development is efreet in anyway?

It is mostly complete.

Loading .desktop files, finding icons and parsing / building menus all
works. Executing desktops (and even downloading the files if necessary)
has been implemented.

There may be a small amount of work left to be done to properly do menu
editing. I think we just never decided to what degree we want to
integrate things. E.g. converting directly from efreet's menu structures
into an E_Menu, or doing an intermediate step and building .order files
first.

But, I'm busy with work, planning a wedding, and preparing for grad
school in the fall. So, its hard to find the motivation to work on this
in what little free time I have. :(

rephorm


-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT  business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] [ENM] A network manager front end

2007-03-18 Thread Brian Mattern
On Sun, Mar 18, 2007 at 06:15:59PM +0100, watchwolf wrote:
 hello,
 
 I want present you a new application writed with etk for E17.
 The application can have some bugs for you as segv :p . The code is not
 perfect, I need to add some tests  errors outputs. The next steps,
 before add new functions, is to clean/correct the code.
 
 You can see screenshots  the source code on my blog.
 http://watchwolf.fr/index.php?post/2007/03/18/%5BE17-Network-manager%
 5D-Pesentation 
 
 To compile us this makefile: etk/Makefile.
 

Just to be clear, this doesn't seem to have anything to do with
NetworkManager (http://www.gnome.org/projects/NetworkManager/), the dbus
lib / api, right? (Looks like its a frontend to i{f,w}config / route /
etc).

Is future NM support planned? Or is the naming similarity just a
coincidence?

rephorm


-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT  business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] [ENM] A network manager front end

2007-03-18 Thread watchwolf
On Sun, 2007-03-18 at 17:03 -0500, Brian Mattern wrote:
 On Sun, Mar 18, 2007 at 06:15:59PM +0100, watchwolf wrote:
  hello,
  
  I want present you a new application writed with etk for E17.
  The application can have some bugs for you as segv :p . The code is not
  perfect, I need to add some tests  errors outputs. The next steps,
  before add new functions, is to clean/correct the code.
  
  You can see screenshots  the source code on my blog.
  http://watchwolf.fr/index.php?post/2007/03/18/%5BE17-Network-manager%
  5D-Pesentation 
  
  To compile us this makefile: etk/Makefile.
  
 
 Just to be clear, this doesn't seem to have anything to do with
 NetworkManager (http://www.gnome.org/projects/NetworkManager/), the dbus
 lib / api, right? (Looks like its a frontend to i{f,w}config / route /
 etc).
 
 Is future NM support planned? Or is the naming similarity just a
 coincidence?
 
 rephorm

Enm means e17 network manager for me, but maybe I ll change the name,
I had no idea so I choose enm. I have no link with the NetworkManager
project.

I write a library (called libenm because the application is enm ...).
The library use if/iwconfig, iwlist and route to manage the network.
My first idea was to write a little wifi manager like wifi-radar
(http://wifi-radar.systemimager.org) but finally I added wired card
support and dns configuration.

-- 
powered by gnu/linux


-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT  business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] [ENM] A network manager front end

2007-03-18 Thread Lucian-Mircea Patcas
Do you plan it to work with wpa_supplicant?

On 3/18/07, watchwolf [EMAIL PROTECTED] wrote:

 On Sun, 2007-03-18 at 17:03 -0500, Brian Mattern wrote:
  On Sun, Mar 18, 2007 at 06:15:59PM +0100, watchwolf wrote:
   hello,
  
   I want present you a new application writed with etk for E17.
   The application can have some bugs for you as segv :p . The code is
 not
   perfect, I need to add some tests  errors outputs. The next steps,
   before add new functions, is to clean/correct the code.
  
   You can see screenshots  the source code on my blog.
   http://watchwolf.fr/index.php?post/2007/03/18/%5BE17-Network-manager%
   5D-Pesentation
  
   To compile us this makefile: etk/Makefile.
  
 
  Just to be clear, this doesn't seem to have anything to do with
  NetworkManager (http://www.gnome.org/projects/NetworkManager/), the dbus
  lib / api, right? (Looks like its a frontend to i{f,w}config / route /
  etc).
 
  Is future NM support planned? Or is the naming similarity just a
  coincidence?
 
  rephorm

 Enm means e17 network manager for me, but maybe I ll change the name,
 I had no idea so I choose enm. I have no link with the NetworkManager
 project.

 I write a library (called libenm because the application is enm ...).
 The library use if/iwconfig, iwlist and route to manage the network.
 My first idea was to write a little wifi manager like wifi-radar
 (http://wifi-radar.systemimager.org) but finally I added wired card
 support and dns configuration.

 --
 powered by gnu/linux


 -
 Take Surveys. Earn Cash. Influence the Future of IT
 Join SourceForge.net's Techsay panel and you'll get the chance to share
 your
 opinions on IT  business topics through brief surveys-and earn cash
 http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
 ___
 enlightenment-devel mailing list
 enlightenment-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT  business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] [ENM] A network manager front end

2007-03-18 Thread raoul
Le lundi 19 mars 2007, watchwolf a écrit :
 On Sun, 2007-03-18 at 17:03 -0500, Brian Mattern wrote:
  On Sun, Mar 18, 2007 at 06:15:59PM +0100, watchwolf wrote:
   hello,
  
   I want present you a new application writed with etk for E17.
   The application can have some bugs for you as segv :p . The code is not
   perfect, I need to add some tests  errors outputs. The next steps,
   before add new functions, is to clean/correct the code.
  
   You can see screenshots  the source code on my blog.
   http://watchwolf.fr/index.php?post/2007/03/18/%5BE17-Network-manager%
   5D-Pesentation
  
   To compile us this makefile: etk/Makefile.
 
  Just to be clear, this doesn't seem to have anything to do with
  NetworkManager (http://www.gnome.org/projects/NetworkManager/), the dbus
  lib / api, right? (Looks like its a frontend to i{f,w}config / route /
  etc).
 
  Is future NM support planned? Or is the naming similarity just a
  coincidence?
 
  rephorm

 Enm means e17 network manager for me, but maybe I ll change the name,
 I had no idea so I choose enm. I have no link with the NetworkManager
 project.
Perhaps you could call it enigma ... 
It's just an idea...

-- 
raoul


-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT  business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] [ENM] A network manager front end

2007-03-18 Thread watchwolf
yes, I plan to add wpa_supplicant. But before I finish the dns/wired
network support and next the wifi.

On Sun, 2007-03-18 at 19:10 -0400, Lucian-Mircea Patcas wrote:
 Do you plan it to work with wpa_supplicant?
 
 On 3/18/07, watchwolf [EMAIL PROTECTED] wrote: 
 On Sun, 2007-03-18 at 17:03 -0500, Brian Mattern wrote:
  On Sun, Mar 18, 2007 at 06:15:59PM +0100, watchwolf wrote: 
   hello,
  
   I want present you a new application writed with etk for
 E17.
   The application can have some bugs for you as segv :p .
 The code is not
   perfect, I need to add some tests  errors outputs. The
 next steps, 
   before add new functions, is to clean/correct the code.
  
   You can see screenshots  the source code on my blog.
   http://watchwolf.fr/index.php?post/2007/03/18/%
 5BE17-Network-manager%
   5D-Pesentation
  
   To compile us this makefile: etk/Makefile.
  
 
  Just to be clear, this doesn't seem to have anything to do
 with 
  NetworkManager
 (http://www.gnome.org/projects/NetworkManager/), the dbus
  lib / api, right? (Looks like its a frontend to
 i{f,w}config / route /
  etc).
 
  Is future NM support planned? Or is the naming similarity
 just a
  coincidence?
 
  rephorm
 
 Enm means e17 network manager for me, but maybe I ll change
 the name, 
 I had no idea so I choose enm. I have no link with the
 NetworkManager
 project.
 
 I write a library (called libenm because the application is
 enm ...).
 The library use if/iwconfig, iwlist and route to manage the
 network. 
 My first idea was to write a little wifi manager like
 wifi-radar
 (http://wifi-radar.systemimager.org) but finally I added wired
 card
 support and dns configuration. 
 
 --
 powered by gnu/linux
 
 
 
 -
 Take Surveys. Earn Cash. Influence the Future of IT
 Join SourceForge.net's Techsay panel and you'll get the chance
 to share your 
 opinions on IT  business topics through brief surveys-and
 earn cash
 
 http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
 ___
 enlightenment-devel mailing list
 enlightenment-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
 
-- 
powered by gnu/linux


-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT  business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


[E-devel] Desklock's idle timer....

2007-03-18 Thread Ravenlock

Hello,

The desklock's idle timer was apparently broken from the start. 
Keyboard activity was not considered when determining if the user was 
active or not.


Here are some patches which fix this.  With these patches a persons 
keyboard and mouse activity are both taken into consideration when 
determining if the user is active.


This implementation requires that the XScreensaver extension be present. 
 This is the easy fix.  If the powers that be prefer that this 
functionality *not* depend on the XScreensaver extension, well... then 
its a bigger problem.


Questions/comments/complaints welcome. :)

--
Regards,
Ravenlock
Index: e17/apps/e/src/bin/e_desklock.c
===
RCS file: /var/cvs/e/e17/apps/e/src/bin/e_desklock.c,v
retrieving revision 1.34
diff -u -r1.34 e_desklock.c
--- e17/apps/e/src/bin/e_desklock.c 11 Mar 2007 05:01:49 -  1.34
+++ e17/apps/e/src/bin/e_desklock.c 19 Mar 2007 05:00:36 -
@@ -794,23 +794,13 @@
 static int 
 _e_desklock_cb_idle_timer(void *data)
 {
-   static double time_of_last_event = 0;
-   static unsigned int xtime_of_last_user_activity = 0;
-
-   if ( ecore_x_current_user_activity_time_get()  xtime_of_last_user_activity 
)
- {
-xtime_of_last_user_activity = ecore_x_current_user_activity_time_get();
-time_of_last_event = ecore_time_get();
- }
-
if (e_config-desklock_autolock_idle)
  {
/* If a desklock is already up, bail */
 if ((_e_custom_desklock_exe) || (edd)) return 1;
 
/* If we have exceeded our idle time... */
-double t = ecore_time_get();
-if (t - time_of_last_event = e_config-desklock_autolock_idle_timeout)
+if (ecore_x_screensaver_idle_time_get() = 
e_config-desklock_autolock_idle_timeout)
  {
 /*
  * Unfortunately, not all desklocks stay up for as long as
Index: e17/libs/ecore/src/lib/ecore_x/Ecore_X.h
===
RCS file: /var/cvs/e/e17/libs/ecore/src/lib/ecore_x/Ecore_X.h,v
retrieving revision 1.184
diff -u -r1.184 Ecore_X.h
--- e17/libs/ecore/src/lib/ecore_x/Ecore_X.h13 Mar 2007 16:29:02 -  
1.184
+++ e17/libs/ecore/src/lib/ecore_x/Ecore_X.h19 Mar 2007 04:57:24 -
@@ -981,7 +981,6 @@
 EAPI void ecore_x_kill(Ecore_X_Window win);
 
 EAPI Ecore_X_Time ecore_x_current_time_get(void);
-EAPI Ecore_X_Time ecore_x_current_user_activity_time_get(void);
 
 EAPI void ecore_x_error_handler_set(void (*func) (void *data), 
const void *data);
 EAPI void ecore_x_io_error_handler_set(void (*func) (void *data), 
const void *data);
@@ -1374,6 +1373,7 @@
 EAPI int ecore_x_xinerama_screen_geometry_get(int screen, int 
*x, int *y, int *w, int *h);
 
 EAPI int ecore_x_screensaver_event_available_get(void);
+EAPI intecore_x_screensaver_idle_time_get(void);
 EAPI voidecore_x_screensaver_set(int timeout, int interval, 
int blank, int expose);
 EAPI voidecore_x_screensaver_timeout_set(double timeout);
 EAPI double  ecore_x_screensaver_timeout_get(void);
Index: e17/libs/ecore/src/lib/ecore_x/ecore_x.c
===
RCS file: /var/cvs/e/e17/libs/ecore/src/lib/ecore_x/ecore_x.c,v
retrieving revision 1.125
diff -u -r1.125 ecore_x.c
--- e17/libs/ecore/src/lib/ecore_x/ecore_x.c9 Mar 2007 01:11:09 -   
1.125
+++ e17/libs/ecore/src/lib/ecore_x/ecore_x.c19 Mar 2007 04:57:25 -
@@ -37,7 +37,6 @@
 Display *_ecore_x_disp = NULL;
 double   _ecore_x_double_click_time = 0.25;
 Time _ecore_x_event_last_time = 0;
-Time _ecore_x_event_last_user_activity_time = 0;
 Window   _ecore_x_event_last_win = 0;
 int  _ecore_x_event_last_root_x = 0;
 int  _ecore_x_event_last_root_y = 0;
@@ -650,16 +649,6 @@
return _ecore_x_event_last_time;
 }
 
-/*
- * Return the last time a *USER* generated an event
- *   Should corespond to key-down, key-up, mouse-down, mouse-up, mouse move
- */
-EAPI Ecore_X_Time
-ecore_x_current_user_activity_time_get()
-{
-   return _ecore_x_event_last_user_activity_time;
-}
-
 static int
 _ecore_x_fd_handler(void *data, Ecore_Fd_Handler *fd_handler __UNUSED__)
 {
Index: e17/libs/ecore/src/lib/ecore_x/ecore_x_events.c
===
RCS file: /var/cvs/e/e17/libs/ecore/src/lib/ecore_x/ecore_x_events.c,v
retrieving revision 1.94
diff -u -r1.94 ecore_x_events.c
--- e17/libs/ecore/src/lib/ecore_x/ecore_x_events.c 13 Feb 2007 16:24:37 
-  1.94
+++ e17/libs/ecore/src/lib/ecore_x/ecore_x_events.c 19 Mar 2007 04:57:26 
-
@@ -228,7 +228,6 @@
e-time = xevent-xkey.time;
e-modifiers = xevent-xkey.state;
_ecore_x_event_last_time = e-time;
-   _ecore_x_event_last_user_activity_time = e-time;
ecore_event_add(ECORE_X_EVENT_KEY_DOWN, 

Re: [E-devel] ecore_x_netwm: is allowed_action_isset correct ?

2007-03-18 Thread Nathan Ingersoll
On 3/18/07, Kim Woelders [EMAIL PROTECTED] wrote:

 Clients that bother about allowed actions (typically a taskbar) should
 monitor the property and keep a local allowed actions state and not
 query the server using e.g. ecore_x_netwm_allowed_action_isset every
 time it needs the info.

Does it make sense to keep the function for the case of the window
manager restarting or starting up with existing client windows?

-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT  business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel