[E-devel] : Elementary: Elm_colorpalette - New widget patch
Hi All, Please find attached patch for new elementary widget elm_colorpalette.c. Change description: New widget colorpalette added. elm_colorpalette is a color selection widget. It provides by default, theme specific set of Predefined colors and also allows to set a series of colors. The colors can be picked by user from the color set by clicking on any color rectangle. Thanks Regards Shilpa Singh elm_colorpalette.patch Description: Binary data -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: tasn IN trunk/elementary/src: bin lib
On Thu, 16 Feb 2012 01:26:30 -0800 Enlightenment SVN no-re...@enlightenment.org wrote: Log: Elm pager: die pager, die! Use naviframe instead. Author: tasn Date: 2012-02-16 01:26:30 -0800 (Thu, 16 Feb 2012) New Revision: 68015 Trac: http://trac.enlightenment.org/e/changeset/68015 Removed: trunk/elementary/src/bin/test_pager.c trunk/elementary/src/lib/elm_pager.h Modified: trunk/elementary/src/bin/Makefile.am trunk/elementary/src/bin/test.c trunk/elementary/src/lib/Elementary.h.in trunk/elementary/src/lib/Makefile.am trunk/elementary/src/lib/elc_naviframe.c trunk/elementary/src/lib/elc_naviframe.h trunk/elementary/src/lib/elm_deprecated.h trunk/elementary/src/lib/elm_pager.c thankfully you've included a brief description of how to switch to naviframe in your detailed commit log which explains why you're doing this as well as updated http://trac.enlightenment.org/e/wiki/ElementaryChanges -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: tasn IN trunk/elementary/src: bin lib
See the docs, all clearly say Use naviframe. I guess people are smart enough to use the same functions. Will update the wiki in a sec. -- Tom. On 16/02/12 11:29, Michael Blumenkrantz wrote: On Thu, 16 Feb 2012 01:26:30 -0800 Enlightenment SVNno-re...@enlightenment.org wrote: Log: Elm pager: die pager, die! Use naviframe instead. Author: tasn Date: 2012-02-16 01:26:30 -0800 (Thu, 16 Feb 2012) New Revision: 68015 Trac: http://trac.enlightenment.org/e/changeset/68015 Removed: trunk/elementary/src/bin/test_pager.c trunk/elementary/src/lib/elm_pager.h Modified: trunk/elementary/src/bin/Makefile.am trunk/elementary/src/bin/test.c trunk/elementary/src/lib/Elementary.h.in trunk/elementary/src/lib/Makefile.am trunk/elementary/src/lib/elc_naviframe.c trunk/elementary/src/lib/elc_naviframe.h trunk/elementary/src/lib/elm_deprecated.h trunk/elementary/src/lib/elm_pager.c thankfully you've included a brief description of how to switch to naviframe in your detailed commit log which explains why you're doing this as well as updated http://trac.enlightenment.org/e/wiki/ElementaryChanges -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: tasn IN trunk/elementary/src: bin lib
Btw, thanks for the gracious 2-3 minutes to get around to changing the wiki page before posting this annoying email... -- Tom. On 16/02/12 11:29, Michael Blumenkrantz wrote: On Thu, 16 Feb 2012 01:26:30 -0800 Enlightenment SVNno-re...@enlightenment.org wrote: Log: Elm pager: die pager, die! Use naviframe instead. Author: tasn Date: 2012-02-16 01:26:30 -0800 (Thu, 16 Feb 2012) New Revision: 68015 Trac: http://trac.enlightenment.org/e/changeset/68015 Removed: trunk/elementary/src/bin/test_pager.c trunk/elementary/src/lib/elm_pager.h Modified: trunk/elementary/src/bin/Makefile.am trunk/elementary/src/bin/test.c trunk/elementary/src/lib/Elementary.h.in trunk/elementary/src/lib/Makefile.am trunk/elementary/src/lib/elc_naviframe.c trunk/elementary/src/lib/elc_naviframe.h trunk/elementary/src/lib/elm_deprecated.h trunk/elementary/src/lib/elm_pager.c thankfully you've included a brief description of how to switch to naviframe in your detailed commit log which explains why you're doing this as well as updated http://trac.enlightenment.org/e/wiki/ElementaryChanges -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: tasn IN trunk/elementary/src: bin lib
On Thu, 16 Feb 2012 11:34:09 +0200 Tom Hacohen tom.haco...@samsung.com wrote: Btw, thanks for the gracious 2-3 minutes to get around to changing the wiki page before posting this annoying email... -- Tom. On 16/02/12 11:29, Michael Blumenkrantz wrote: On Thu, 16 Feb 2012 01:26:30 -0800 Enlightenment SVNno-re...@enlightenment.org wrote: Log: Elm pager: die pager, die! Use naviframe instead. Author: tasn Date: 2012-02-16 01:26:30 -0800 (Thu, 16 Feb 2012) New Revision: 68015 Trac: http://trac.enlightenment.org/e/changeset/68015 Removed: trunk/elementary/src/bin/test_pager.c trunk/elementary/src/lib/elm_pager.h Modified: trunk/elementary/src/bin/Makefile.am trunk/elementary/src/bin/test.c trunk/elementary/src/lib/Elementary.h.in trunk/elementary/src/lib/Makefile.am trunk/elementary/src/lib/elc_naviframe.c trunk/elementary/src/lib/elc_naviframe.h trunk/elementary/src/lib/elm_deprecated.h trunk/elementary/src/lib/elm_pager.c thankfully you've included a brief description of how to switch to naviframe in your detailed commit log which explains why you're doing this as well as updated http://trac.enlightenment.org/e/wiki/ElementaryChanges -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel NOO PROBLEMOOO -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch
Will take a look soon, but please, next time you submit patches make sure to base yourself on current svn version... :| -- Tom. On 16/02/12 11:24, SHILPA ONKAR SINGH wrote: Hi All, Please find attached patch for new elementary widget elm_colorpalette.c. Change description: New widget colorpalette added. elm_colorpalette is a color selection widget. It provides by default, theme specific set of Predefined colors and also allows to set a series of colors. The colors can be picked by user from the color set by clicking on any color rectangle. Thanks Regards Shilpa Singh -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch
Widget looks nice. A bit plain maybe, but I guess it's somehow needed. Can't review API/code atm, sorry. -- Tom. On 16/02/12 11:44, Tom Hacohen wrote: Will take a look soon, but please, next time you submit patches make sure to base yourself on current svn version... :| -- Tom. On 16/02/12 11:24, SHILPA ONKAR SINGH wrote: Hi All, Please find attached patch for new elementary widget elm_colorpalette.c. Change description: New widget colorpalette added. elm_colorpalette is a color selection widget. It provides by default, theme specific set of Predefined colors and also allows to set a series of colors. The colors can be picked by user from the color set by clicking on any color rectangle. Thanks Regards Shilpa Singh -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch
On Thu, 16 Feb 2012 11:48:25 +0200 Tom Hacohen tom.haco...@samsung.com wrote: Widget looks nice. A bit plain maybe, but I guess it's somehow needed. Can't review API/code atm, sorry. -- Tom. On 16/02/12 11:44, Tom Hacohen wrote: Will take a look soon, but please, next time you submit patches make sure to base yourself on current svn version... :| -- Tom. On 16/02/12 11:24, SHILPA ONKAR SINGH wrote: Hi All, Please find attached patch for new elementary widget elm_colorpalette.c. Change description: New widget colorpalette added. elm_colorpalette is a color selection widget. It provides by default, theme specific set of Predefined colors and also allows to set a series of colors. The colors can be picked by user from the color set by clicking on any color rectangle. Thanks Regards Shilpa Singh does it have that thing where you click the dropper and then click something else and then it gets the color from where you clicked? -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch
Dunno, arleady deleted it. But yeah, being able to longpress/right click on a colour to edit the palette manually is possibly important -- Tom. On 16/02/12 11:55, Michael Blumenkrantz wrote: On Thu, 16 Feb 2012 11:48:25 +0200 Tom Hacohentom.haco...@samsung.com wrote: Widget looks nice. A bit plain maybe, but I guess it's somehow needed. Can't review API/code atm, sorry. -- Tom. On 16/02/12 11:44, Tom Hacohen wrote: Will take a look soon, but please, next time you submit patches make sure to base yourself on current svn version... :| -- Tom. On 16/02/12 11:24, SHILPA ONKAR SINGH wrote: Hi All, Please find attached patch for new elementary widget elm_colorpalette.c. Change description: New widget colorpalette added. elm_colorpalette is a color selection widget. It provides by default, theme specific set of Predefined colors and also allows to set a series of colors. The colors can be picked by user from the color set by clicking on any color rectangle. ThanksRegards Shilpa Singh does it have that thing where you click the dropper and then click something else and then it gets the color from where you clicked? -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch
Hi, This widget is a color palette, it takes the initial set of colors from theme and provides option to application to provide its own list of colors. Application can provide a option to pick a color from external source and then add the new set of colors to color palette widget. Thanks Regards Shilpa Singh --- Original Message --- Sender : Tom Hacohentom.haco...@samsung.com Engineer/STRI-EFL Enhancement/Samsung Electronics Date : Feb 16, 2012 18:57 (GMT+09:00) Title : Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch Dunno, arleady deleted it. But yeah, being able to longpress/right click on a colour to edit the palette manually is possibly important -- Tom. On 16/02/12 11:55, Michael Blumenkrantz wrote: On Thu, 16 Feb 2012 11:48:25 +0200 Tom Hacohen wrote: Widget looks nice. A bit plain maybe, but I guess it's somehow needed. Can't review API/code atm, sorry. -- Tom. On 16/02/12 11:44, Tom Hacohen wrote: Will take a look soon, but please, next time you submit patches make sure to base yourself on current svn version... :| -- Tom. On 16/02/12 11:24, SHILPA ONKAR SINGH wrote: Hi All, Please find attached patch for new elementary widget elm_colorpalette.c. Change description: New widget colorpalette added. elm_colorpalette is a color selection widget. It provides by default, theme specific set of Predefined colors and also allows to set a series of colors. The colors can be picked by user from the color set by clicking on any color rectangle. ThanksRegards Shilpa Singh does it have that thing where you click the dropper and then click something else and then it gets the color from where you clicked? -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch
I understand that. With that being said, please consider doing what Mike and I suggested and make right click/longpress open color_selector to change that specific colour. -- Tom. On 16/02/12 13:07, SHILPA ONKAR SINGH wrote: Hi, This widget is a color palette, it takes the initial set of colors from theme and provides option to application to provide its own list of colors. Application can provide a option to pick a color from external source and then add the new set of colors to color palette widget. Thanks Regards Shilpa Singh --- Original Message --- Sender : Tom Hacohentom.haco...@samsung.com Engineer/STRI-EFL Enhancement/Samsung Electronics Date : Feb 16, 2012 18:57 (GMT+09:00) Title : Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch Dunno, arleady deleted it. But yeah, being able to longpress/right click on a colour to edit the palette manually is possibly important -- Tom. On 16/02/12 11:55, Michael Blumenkrantz wrote: On Thu, 16 Feb 2012 11:48:25 +0200 Tom Hacohen wrote: Widget looks nice. A bit plain maybe, but I guess it's somehow needed. Can't review API/code atm, sorry. -- Tom. On 16/02/12 11:44, Tom Hacohen wrote: Will take a look soon, but please, next time you submit patches make sure to base yourself on current svn version... :| -- Tom. On 16/02/12 11:24, SHILPA ONKAR SINGH wrote: Hi All, Please find attached patch for new elementary widget elm_colorpalette.c. Change description: New widget colorpalette added. elm_colorpalette is a color selection widget. It provides by default, theme specific set of Predefined colors and also allows to set a series of colors. The colors can be picked by user from the color set by clicking on any color rectangle. Thanks Regards Shilpa Singh does it have that thing where you click the dropper and then click something else and then it gets the color from where you clicked? -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch
Hi, We understand the below requirement, on right click/long press we should be able to open color selector and change the palette's specific color. we will work on this requirement and send it as an enhancement patch. hence please consider this patch as base version, review it and if ok please push it to svn or provide your feedback based on this base version. Thanks Regards Shilpa Singh --- Original Message --- Sender : Tom Hacohentom.haco...@samsung.com Engineer/STRI-EFL Enhancement/Samsung Electronics Date : Feb 16, 2012 20:12 (GMT+09:00) Title : Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch I understand that. With that being said, please consider doing what Mike and I suggested and make right click/longpress open color_selector to change that specific colour. -- Tom. On 16/02/12 13:07, SHILPA ONKAR SINGH wrote: Hi, This widget is a color palette, it takes the initial set of colors from theme and provides option to application to provide its own list of colors. Application can provide a option to pick a color from external source and then add the new set of colors to color palette widget. Thanks Regards Shilpa Singh --- Original Message --- Sender : Tom Hacohen Engineer/STRI-EFL Enhancement/Samsung Electronics Date : Feb 16, 2012 18:57 (GMT+09:00) Title : Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch Dunno, arleady deleted it. But yeah, being able to longpress/right click on a colour to edit the palette manually is possibly important -- Tom. On 16/02/12 11:55, Michael Blumenkrantz wrote: On Thu, 16 Feb 2012 11:48:25 +0200 Tom Hacohen wrote: Widget looks nice. A bit plain maybe, but I guess it's somehow needed. Can't review API/code atm, sorry. -- Tom. On 16/02/12 11:44, Tom Hacohen wrote: Will take a look soon, but please, next time you submit patches make sure to base yourself on current svn version... :| -- Tom. On 16/02/12 11:24, SHILPA ONKAR SINGH wrote: Hi All, Please find attached patch for new elementary widget elm_colorpalette.c. Change description: New widget colorpalette added. elm_colorpalette is a color selection widget. It provides by default, theme specific set of Predefined colors and also allows to set a series of colors. The colors can be picked by user from the color set by clicking on any color rectangle. Thanks Regards Shilpa Singh does it have that thing where you click the dropper and then click something else and then it gets the color from where you clicked? -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch] Elementary: New custom widget Popup
Your patch doesn't apply. Won't review. -- Tom. On 16/02/12 12:05, Rajeev Ranjan wrote: Hi All, Attached to the mail is the patch for a new custom elementary widget elm_popup for your review. Change description: New custom widget Popup added. elm_popup is an enhancement over elm_notify widget with widely used parts such as Title, Content and Action Buttons. Items are supported as well and they are put inside the content area which can have either an Evas Object/Set of items/Description text. Signed-Off-By: RAJEEV RANJANrajee...@samsumg.com Thank you Regards Rajeev -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch
On 16/02/12 13:26, SHILPA ONKAR SINGH wrote: We understand the below requirement, on right click/long press we should be able to open color selector and change the palette's specific color. we will work on this requirement and send it as an enhancement patch. hence please consider this patch as base version, review it and if ok please push it to svn or provide your feedback based on this base version. I don't want to sound cynical, but it's not the first time we get a patch with a promise to make an enhancement patch if this gets in... -- Tom. -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch][elm_map] Refactoring Elementary Map
I know you did a good job but this smells like a big blob of patch. (I didn't even read the code yet.) But we can't review this big patch at a time. Please split this patch as small as possible. Thanks. Daniel Juyung Seo (SeoZ) On Thu, Feb 16, 2012 at 8:14 PM, Bluezery ohpo...@gmail.com wrote: Hello, I have done refactoring code clean-up in elm_map. Event if this patch have much changes, refactoring code clean-up jobs almost always do. Anyway, code is shortened and optimized I think. I have done following jobs in my patch. (1) Always change child size Scroller Child size is changed when integer zoom level is changed before. This makes bugs which mouse pointer is not correct on the map when map is dragging. Now, scroller child size is always changed when double zoom level is changed. (2) Evas map Evas map is used for rotation zooming before. But now it is used for only rotation. evas_object_resize() can do zooming because (1) makes child size always changed. (3) Grid Marker Route, etc. Because of (1), all coordinate calculations are all changed. So grid marker route should be changed. When I have fixed these, I have these split into small function (create, free, update, place, etc.) So these can be easily reused for other purpose ( I will add overlay later.) Also marker size is not changed and is not rotated anymore because marker's coordinate is just rotated and evas_map is not used for marker. And grouping algorithm is somewhat changed. Each marker can be group leader and if other markers (followers) are closed to leader, markers are grouped. Actually _marker_place() function do almost everything. (place marker, bubble, group make group, etc.) Bubbles go along with parent object. (show, hide, move) and this is created when marker group are opened. At now, bubble display bugs are all fixed. As before, grid is created when elm_map_add() or tile source is changed. And I add _grid_item_* functions for each 256x256 tile management. So grid_place() function can be simple now. (4) Download idler Before download is not a job or idler and is integrated with grid calculation. I have separated this into independent idler. So now, download idler do download jobs when idler time. (5) Zoom I have made one zoom_do() function. This does all zoom jobs. At now, pinch_zoom wheel_zoom animated zoom do not much jobs. just call zoom_do(). (6) Delayed jobs As I know, evas is based on a retained mode and calculation can be do later. So sometimes elm_map APIs can not do the jobs correctly. For example, elm_map_marker_list_show() or elm_map_zoom_set() can not be used right after elm_map_add() because window size and pan size can be 0. (refer map_example_02.c) So when APIs related such calculation are called. These are deferred and calculated later when _pan_calculate() is called. 5) Code clean-up I have removed unused variables functions. and rearranged struct functions declaration static variables, etc. Instead of if (!wd) return; , I changed this by macro, EINA_SAFETY_ON_NULL_RETURN(wd);. This is better for function entrance check. Also ELM_NEW is used instead of calloc or malloc. Aboves are all related each other. So it can be hard to split this file. If these should be splitted, I'm going to freak ;D. This patch does no harm :D. After this patch, I will add overlay APIs based on this patch. I doubt whether I will add this before elementary 1.0 release. :( -- BRs, Kim. -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: woohyun trunk/elementary/src/lib
On Thu, Feb 16, 2012 at 8:39 PM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: Reviewed elm_label's API and documentation Author: woohyun Date: 2012-02-16 03:39:07 -0800 (Thu, 16 Feb 2012) New Revision: 68024 Trac: http://trac.enlightenment.org/e/changeset/68024 Modified: trunk/elementary/src/lib/Elementary.h.intrunk/elementary/src/lib/elm_deprecated.h trunk/elementary/src/lib/elm_label.c trunk/elementary/src/lib/elm_label.h Modified: trunk/elementary/src/lib/Elementary.h.in === --- trunk/elementary/src/lib/Elementary.h.in2012-02-16 11:37:54 UTC (rev 68023) +++ trunk/elementary/src/lib/Elementary.h.in2012-02-16 11:39:07 UTC (rev 68024) @@ -211,7 +211,7 @@ #include elm_hover.h // OK #include elm_image.h // OK #include elm_index.h // OK -#include elm_label.h +#include elm_label.h // OK #include elm_layout.h #include elm_macros.h #include elm_mapbuf.h Modified: trunk/elementary/src/lib/elm_deprecated.h === --- trunk/elementary/src/lib/elm_deprecated.h 2012-02-16 11:37:54 UTC (rev 68023) +++ trunk/elementary/src/lib/elm_deprecated.h 2012-02-16 11:39:07 UTC (rev 68024) @@ -4739,7 +4739,60 @@ */ EINA_DEPRECATED EAPI const char *elm_pager_item_style_default_get(const Evas_Object *obj); +/** + * @brief Set the font size on the label object. + * + * @param obj The label object + * @param size font size + * + * @warning NEVER use this. It is for hyper-special cases only. use styles + * instead. e.g. default, marker, slide_long etc. + * @deprecated Use tag instead + */ Hello, +EAPI voidelm_label_fontsize_set(Evas_Object *obj, int fontsize); Mark EINA_DEPRECATED for deprecated APIs. Check others as well. Thanks in advance. Daniel Juyung Seo (SeoZ) /** + * @brief Set the text color on the label object + * + * @param obj The label object + * @param r Red property background color of The label object + * @param g Green property background color of The label object + * @param b Blue property background color of The label object + * @param a Alpha property background color of The label object + * + * @warning NEVER use this. It is for hyper-special cases only. use styles + * instead. e.g. default, marker, slide_long etc. + * @deprecated Use tag instead + */ +EAPI voidelm_label_text_color_set(Evas_Object *obj, unsigned int r, unsigned int g, unsigned int b, unsigned int a); + +/** + * @brief Set the text align on the label object + * + * @param obj The label object + * @param align align mode (left, center, right) + * + * @warning NEVER use this. It is for hyper-special cases only. use styles + * instead. e.g. default, marker, slide_long etc. + * @deprecated Use tag instead + */ +EAPI voidelm_label_text_align_set(Evas_Object *obj, const char *alignmode); + +/** + * @brief Set background color of the label + * + * @param obj The label object + * @param r Red property background color of The label object + * @param g Green property background color of The label object + * @param b Blue property background color of The label object + * @param a Alpha property background alpha of The label object + * + * @warning NEVER use this. It is for hyper-special cases only. use styles + * instead. e.g. default, marker, slide_long etc. + * @deprecated Just make colored background by yourself. + */ +EAPI void elm_label_background_color_set(Evas_Object *obj, unsigned int r, unsigned int g, unsigned int b, unsigned int a); + +/** * @} */ Modified: trunk/elementary/src/lib/elm_label.c === --- trunk/elementary/src/lib/elm_label.c2012-02-16 11:37:54 UTC (rev 68023) +++ trunk/elementary/src/lib/elm_label.c2012-02-16 11:39:07 UTC (rev 68024) @@ -773,6 +773,15 @@ } +EAPI Eina_Bool +elm_label_ellipsis_get(const Evas_Object *obj) +{ + ELM_CHECK_WIDTYPE(obj, widtype) EINA_FALSE; + Widget_Data *wd = elm_widget_data_get(obj); + if (!wd) return EINA_FALSE; + return wd-ellipsis; +} + EAPI void elm_label_slide_set(Evas_Object *obj, Eina_Boolslide) @@ -789,7 +798,7 @@ } EAPI Eina_Bool -elm_label_slide_get(Evas_Object *obj) +elm_label_slide_get(const Evas_Object *obj) { ELM_CHECK_WIDTYPE(obj, widtype) EINA_FALSE; Widget_Data *wd = elm_widget_data_get(obj); @@ -812,7 +821,7 @@ } EAPI double -elm_label_slide_duration_get(Evas_Object *obj) +elm_label_slide_duration_get(const Evas_Object *obj) { ELM_CHECK_WIDTYPE(obj, widtype) 0.0; Widget_Data *wd = elm_widget_data_get(obj); Modified: trunk/elementary/src/lib/elm_label.h === ---
Re: [E-devel] E SVN: woohyun trunk/elementary/src/lib
On Thu, Feb 16, 2012 at 4:38 AM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: Reviewed elm_index's APIs and documentations. So many things to be modified :( I never see the point in having index as an independent widget as opposed to a decoration of indexed elements. Could anyone explain? I can explain why having them different is painful: - desktop have clickable scrollbar, usually at right. Index usually goes at right - conflict! - sometimes people add the index to the window, instead of the list... then you get index outside of list boundaries So far it could go into genlist/gengrid/list.. any more? Maybe scroller in general? Note: for next-elementary (post release) ProFUSION is working with Samsung to fix the class hierarchy and add interfaces, the index could be an interface own its own, or at least part of scrollable interface. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: woohyun trunk/elementary/src/lib
On Thu, Feb 16, 2012 at 10:20 AM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: Add EINA_DEPRECATED ~ thx to Seoz -EAPI void elm_label_fontsize_set(Evas_Object *obj, int fontsize); +EINA_DEPRECATED EAPI void elm_label_fontsize_set(Evas_Object *obj, int fontsize); usually we add EINA_DEPRECATED *after* the function, not before. This also means it does not get into .c file... It is an attribute similar to EINA_ARG_NONNULL() et al... EAPI we use to make it easier to find public functions, so we give it special treatment. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: tasn trunk/eina/src/examples
On Thu, Feb 16, 2012 at 10:37 AM, Enlightenment SVN no-re...@enlightenment.org wrote: @@ -47,8 +47,8 @@ /* define extra methods */ type-type_size = sizeof(Animal_Type); - _ANIMAL_TYPE.breathe = _animal_breathe; - _ANIMAL_TYPE.eat = _animal_eat; + ANIMAL_TYPE(type)-breathe = _animal_breathe; + ANIMAL_TYPE(type)-eat = _animal_eat; } no ugly, needless! :-( -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: woohyun trunk/elementary/src/lib
On 16/02/12 15:11, Gustavo Sverzut Barbieri wrote: On Thu, Feb 16, 2012 at 10:20 AM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: Add EINA_DEPRECATED ~ thx to Seoz -EAPI voidelm_label_fontsize_set(Evas_Object *obj, int fontsize); +EINA_DEPRECATED EAPI void elm_label_fontsize_set(Evas_Object *obj, int fontsize); usually we add EINA_DEPRECATED *after* the function, not before. This also means it does not get into .c file... It is an attribute similar to EINA_ARG_NONNULL() et al... EAPI we use to make it easier to find public functions, so we give it special treatment. Yeah, but raster actually made a good point about that. He suggested we do this special treatment with EINA_DEPRECATED as well so it'll be easier to grep for them and remove them. -- Tom. -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: woohyun trunk/elementary/src/lib
On Thu, 16 Feb 2012 15:10:44 +0200 Tom Hacohen tom.haco...@samsung.com wrote: On 16/02/12 15:09, Gustavo Sverzut Barbieri wrote: Note: for next-elementary (post release) ProFUSION is working with Samsung to fix the class hierarchy and add interfaces, the index could be an interface own its own, or at least part of scrollable interface. Yeah, that's the idea. So many oddities like this will be solved once class hierarchy is fixed. Um, so why release before it's fixed? Isn't that a large part of the API? Which will got frozen and unfixable the moment you release? -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. signature.asc Description: PGP signature -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Elementary improvements/review
Since people are patching elementary like crazy, goes an idea: Some time ago we've introduced couple of elm_layout styles to help applications writers. Could you replace manual assignment of box/table with them, making everyone's lives easier, particularly to the newcomers that may try to use tests as example. There are couple in data/themes/widgets/layout.edc: elm/layout/application/content-back elm/layout/application/content-back-next elm/layout/application/titlebar elm/layout/application/toolbar-content elm/layout/application/toolbar-content-back elm/layout/application/toolbar-content-back-next elm/layout/application/toolbar-table elm/layout/application/toolbar-vbox Feel free to add more. The idea is to have canned solutions to help people. For instance the mobile theme can put the toolbar a the bottom to cope with native look feel, while desktops leave it at the top. Titlebar can have decorations, etc. Old school (read raster) never remember about these helpers, but they are worth! give them a try! BTW, the content-back and content-back-next were similar to naviframe, and they got in svn before it... if someone could take the time to merge these things, would help a lot (naviframe should use the layout, which should be fixed if does not fit perfectly). -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: tasn trunk/eina/src/examples
On 16/02/12 15:14, Gustavo Sverzut Barbieri wrote: no ugly, needless! :-( Consistency In the case of multi-level inheritance, having: type-version = bla; ANIMAL(type)-eat = _eat; HUMAN(type)-poop = _poop; is better than _HUMAN_TYPE.parent_class.parent_class.version = bla; _HUMAN_TYPE.parent_class.eat = eat; _HUMAN_TYPE.poop = poop; Or even worse, when there are more than 3 levels (3 levels will be wasted on Eina_Object - Evas_Object - Elm_Widget anyway...), so we'll have way more... -- Tom. -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: woohyun trunk/elementary/src/lib
On 16/02/12 15:18, David Seikel wrote: On Thu, 16 Feb 2012 15:10:44 +0200 Tom Hacohen tom.haco...@samsung.com wrote: On 16/02/12 15:09, Gustavo Sverzut Barbieri wrote: Note: for next-elementary (post release) ProFUSION is working with Samsung to fix the class hierarchy and add interfaces, the index could be an interface own its own, or at least part of scrollable interface. Yeah, that's the idea. So many oddities like this will be solved once class hierarchy is fixed. Um, so why release before it's fixed? Isn't that a large part of the API? Which will got frozen and unfixable the moment you release? New API will be added as possible old API will be maintained until 2.0. Unfortunate, but we can't wait another year... -- Tom. -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: tasn trunk/eina/src/examples
On Thu, Feb 16, 2012 at 11:30 AM, Tom Hacohen tom.haco...@samsung.com wrote: On 16/02/12 15:14, Gustavo Sverzut Barbieri wrote: no ugly, needless! :-( Consistency In the case of multi-level inheritance, having: type-version = bla; ANIMAL(type)-eat = _eat; HUMAN(type)-poop = _poop; is better than I still think it's better to have the _ANIMAL_TYPE explicit in the case above... but maybe it's just me. _HUMAN_TYPE.parent_class.parent_class.version = bla; _HUMAN_TYPE.parent_class.eat = eat; _HUMAN_TYPE.poop = poop; yeah, I know you dislike it... but that should be done to remember you that people shouldn't be writing apps in C :-) Or even worse, when there are more than 3 levels (3 levels will be wasted on Eina_Object - Evas_Object - Elm_Widget anyway...), so we'll have way more... argh... see why I complain about using a single object model for everything? So far we have Evas_Object - Elm_Widget, then we'll have 1 level more. anyway, the evas case is bogus as we can't break Evas_Smart_Class and Evas_Object until 2.0 :-) -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: tasn trunk/eina/src/examples
On Thu, 16 Feb 2012 11:36:26 -0200 Gustavo Sverzut Barbieri barbi...@profusion.mobi wrote: On Thu, Feb 16, 2012 at 11:30 AM, Tom Hacohen tom.haco...@samsung.com wrote: On 16/02/12 15:14, Gustavo Sverzut Barbieri wrote: no ugly, needless! :-( Consistency In the case of multi-level inheritance, having: type-version = bla; ANIMAL(type)-eat = _eat; HUMAN(type)-poop = _poop; is better than I still think it's better to have the _ANIMAL_TYPE explicit in the case above... but maybe it's just me. _HUMAN_TYPE.parent_class.parent_class.version = bla; _HUMAN_TYPE.parent_class.eat = eat; _HUMAN_TYPE.poop = poop; yeah, I know you dislike it... but that should be done to remember you that people shouldn't be writing apps in C :-) C is a great language to be writing apps in. :-P -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. signature.asc Description: PGP signature -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: woohyun trunk/elementary/src/lib
On Thu, Feb 16, 2012 at 11:18 AM, David Seikel onef...@gmail.com wrote: On Thu, 16 Feb 2012 15:10:44 +0200 Tom Hacohen tom.haco...@samsung.com wrote: On 16/02/12 15:09, Gustavo Sverzut Barbieri wrote: Note: for next-elementary (post release) ProFUSION is working with Samsung to fix the class hierarchy and add interfaces, the index could be an interface own its own, or at least part of scrollable interface. Yeah, that's the idea. So many oddities like this will be solved once class hierarchy is fixed. Um, so why release before it's fixed? Isn't that a large part of the API? Which will got frozen and unfixable the moment you release? It's a very big task and will take us a stable SVN to avoid conflicts. Basically you need to change every widget in elementary, plus the base. To the outside it is transparent, no big changes. Remembering that so far elm_widget.h is not stable, due this reason. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch] Elementary: New custom widget Popup
On Thu, Feb 16, 2012 at 9:30 AM, Tom Hacohen tom.haco...@samsung.com wrote: Your patch doesn't apply. Won't review. aside from that I wonder what it offers on top of elm_layout. Maybe just add a canned layout as we do with others? how does it compare with inwin? Isn't it better to provide styles for notify and inwin? Whenever sending these patches, please elaborate on the need, the existing solutions and why they do not fit or why they are not fixable. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch] Elementary: New custom widget Popup
On 16/02/12 16:38, Gustavo Sverzut Barbieri wrote: On Thu, Feb 16, 2012 at 9:30 AM, Tom Hacohentom.haco...@samsung.com wrote: Your patch doesn't apply. Won't review. aside from that I wonder what it offers on top of elm_layout. Maybe just add a canned layout as we do with others? how does it compare with inwin? Isn't it better to provide styles for notify and inwin? Whenever sending these patches, please elaborate on the need, the existing solutions and why they do not fit or why they are not fixable. It's a layout inside an elm_notify if I understand it correctly, I don't understand why such a simple widget should become to be 1450 lines. Also, I dislike the wrap_set API, I think it's awful. -- Tom. -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch
On Thu, Feb 16, 2012 at 7:24 AM, SHILPA ONKAR SINGH shilpa.si...@samsung.com wrote: Hi All, Please find attached patch for new elementary widget elm_colorpalette.c. Change description: New widget colorpalette added. elm_colorpalette is a color selection widget. It provides by default, theme specific set of Predefined colors and also allows to set a series of colors. The colors can be picked by user from the color set by clicking on any color rectangle. how does it compare with existing Colorselector (http://docs.enlightenment.org/auto/elementary/group__Colorselector.html) can't it be made together with colorselector? If you provide only discrete colors instead of letting user define the color based on RGB... maybe you could offer a mode? It would even make sense to offer the last selected colors in the colorselector, and be possible to add new colors to a pre-defined palette using it. Please elaborate as we really don't need even more widgets that partially do one function :-( Maybe add: elm_colorselector_palette_set(Evas_Object *o, const Eina_List *colors); elm_colorselector_palette_grid_set(Evas_Object *o, unsigned columns, unsigned rows); you can even automatically hide/show the palette if colors==NULL || columns == 0 || rows == 0. You can add some flag to hide the current selector: elm_colorselector_palette_only_set(Evas_Object *o, Eina_Bool); Comes to mind other flags, like allow user to add new colors to palette (button? dummy color entry?) Last but not least, never do this: elm_colorpalette_color_set(Evas_Object *obj, Eina_List *color_list) { ... wd-color_list = color_list; ... } you're stealing a parameter and this is not good, as convention is to never do this on setters. Instead take an const Eina_List * and copy the color inside. Or alternatively you can use: elm_colorselector_palette_color_add(Evas_Object *o, int r, int g, int b, int a); which matches evas api. Eventually you can remove the elm_colorselector_palette_grid_set() and make it automatically by having column/row in the palette_color_add: elm_colorselector_palette_color_add(Evas_Object *o, int column, in row, int red, int green, int blue, int alpha); -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: sanjeev IN trunk/PROTO/elev8: . src src/bin src/include src/modules
On 02/16/2012 04:02 AM, Enlightenment SVN wrote: Log: Modularize elev8. Cleanup required, but this is a working version. It would be nice if, instead of loading everything automatically, we had a global modules object, where we could do things like: elm = modules.elm; dbus = modules.dbus; If the modules object does not have either elm or dbus keys, it will be loaded -- essentially becoming a way to dynamically importing modules. After the module has been loaded, a reference to it will be in the modules object already, so that even if one use modules.elm it won't reload the module. Assigning to a short variable isn't mandatory, of course. So writing elm = modules.elm would just create a shorthand so things like elm.window() will still work. This might also be used to load JavaScript modules, much like the way Python does (import foo will try to load foomodule.so and if that fails, will try to load foo.py), so libraries built on top of Elev8's JS API can be written and distributed alongside it. Python also have a PYTHONPATH environment variable which can be used to specify (much like the standard PATH variable) a colon-delimited list of places to look for a module. Any thoughts on this? -void load_modules(v8::Handlev8::ObjectTemplate global) + +//TODO : Add support for User Home Dir based modules. +void load_modules() { - Eina_Inlist *itr = NULL; - for (itr = root; itr != NULL; itr = itr-next) + int retval = 0; + + /* load all the modules in the installed path PACKAGE_LIB_DIR */ + + DIR *dirp; + struct dirent *dp; + char buffer[MAX_LEN]; + Eina_Module *ptr = NULL; These are not being used. It would be a good idea to build this with -Werror -Wall -Wextra -Wshadow to catch this kind of errors. === --- trunk/PROTO/elev8/src/include/elev8_dbus.h2012-02-16 05:58:47 UTC (rev 68002) +++ trunk/PROTO/elev8/src/include/elev8_dbus.h2012-02-16 06:02:26 UTC (rev 68003) @@ -10,6 +10,13 @@ #includemap #includeelev8_common.h +#define DBUS_DBG(...) EINA_LOG_DOM_DBG(elev8_dbus_log_domain, __VA_ARGS__) +#define DBUS_INF(...) EINA_LOG_DOM_INFO(elev8_dbus_log_domain, __VA_ARGS__) +#define DBUS_WRN(...) EINA_LOG_DOM_WARN(elev8_dbus_log_domain, __VA_ARGS__) +#define DBUS_ERR(...) EINA_LOG_DOM_ERR(elev8_dbus_log_domain, __VA_ARGS__) +#define DBUS_CRT(...) EINA_LOG_DOM_CRITICAL(elev8_dbus_log_domain, __VA_ARGS__) You could move each module to its own directory -- and the .cc files only include files from these directories, you could have DBG(...) instead of ${MODULE}_DBG(...) to keep things cleaner. This way no other module will accidentally use another module's log domain. Also, there's no need to use these macros with a newline character, since Eina_Log already does that for you: INF(frobnicating foobar); (Unless you'd like to space things out more so that a message stands out -- but then you should really use other tools to filter out these messages anyway.) +typedef int (*module_init)(HandleObjectTemplate global); +typedef int (*module_deinit)(void); Won't a data voidptr be useful while deallocating a module? By the way, with you splitting things into loadable modules, it would be a nice idea to also implement each elm widget in its own .cc file. This would not only make incremental building faster, but would also be easier to scrounge inside each wrapper's code. Cheers, Leandro -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: hermet IN trunk/elementary: data/themes/widgets src/lib
2012/2/16 ChunEon Park her...@naver.com I think theme should not broken the compatibility neither. It means we don't need to check the versions in minor changes. but when major version of elm is updated, then it allows the breaking of the theme compatibility. So I though just collection need to check the version. I still not understand your point in versioning collection... maybe you are thinking only at elm...think also at apps, for example in my apps usually I have: collections{ group { name: my/main/interface; // this is not an elm widget ... } group { name: elm/button; // this is an extension of the elm theme ... } } in this case there are 2 different version to match: the one for elm/button and the one for my app theme. Also: are you thinking at theme_version==elm_version? ...I was thinking about different versions -Regards, Hermet- -Original Message- From: Davide Andreolilt;d...@gurumeditation.itgt; To: Enlightenment developer list lt;enlightenment-devel@lists.sourceforge.netgt; Cc: enlightenment-...@lists.sourceforge.net Sent: 12-02-16(목) 05:01:48 Subject: Re: [E-devel] E SVN: hermet IN trunk/elementary: data/themes/widgets src/lib 2012/2/15 ChunEon Park lt;her...@naver.comgt; IMHO, we should not break compatibility of theme as possible. But actually, edj is a program. it works so much things. We can't regard it just as a ui layout theme. It could break compatibility of widget theme always. (like this case) Someday, it may need to break the program cause of the incompatibility of theme when major version is changed. At that time, those version checking will be helpful. If then, how about supporting version values in collections instead of data? collection { version { major : xx minor: xx } } Having a new version block in edje (instead of (ab)using the data) is ok for me, but I still think the block must be at group level, not at collection. Inside a collection you can have different group that can serve as themes for different apps, you can make, for example, an edj with both e17 themes bits and elm bits inside. thus the groups need different versions. davemds -Regards, Hermet- -Original Message- From: Davide Andreolilt;d...@gurumeditation.itgt; To: Enlightenment developer list lt;enlightenment-devel@lists.sourceforge.net Cc: enlightenment-...@lists.sourceforge.net Sent: 12-02-15(수) 04:19:30 Subject: Re: [E-devel] E SVN: hermet IN trunk/elementary: data/themes/widgets src/lib 2012/2/13 ChunEon Park lt;her...@naver.comgt;: Sorry. I did not realize about other themes. Its not just other themes, also apps that use custom styles for the widget got broken, we always undervalue themes breakage. Maybe we should use some sort of versioning in edje themes? a standardized data field in the groups? like: group{ data { item: version X; } ... } and check the version on edje_load... It's an idea? davemds -Regards, Hermet- -Original Message- From: Michael Blumenkrantzlt;michael.blumenkra...@gmail.comgt; To: enlightenment-...@lists.sourceforge.net Cc: enlightenment-devel@lists.sourceforge.net Sent: 12-02-13(월) 06:54:35 Subject: Re: [E-devel] E SVN: hermet IN trunk/elementary: data/themes/widgets src/lib On Wed, 1 Feb 2012 03:26:25 -0800 Enlightenment SVN lt;no-re...@enlightenment.orggt; wrote: Log: elementary/ctxpopup - + hide effect Author: hermet Date: 2012-02-01 03:26:25 -0800 (Wed, 01 Feb 2012) New Revision: 67673 Trac: http://trac.enlightenment.org/e/changeset/67673 Modified: trunk/elementary/data/themes/widgets/ctxpopup.edc trunk/elementary/src/lib/elc_ctxpopup.c I'm pretty sure this has been said many times before, but CHANGES LIKE THIS WHICH BREAK THEMES NEED TO BE HIGHER PROFILE. If you make a commit which breaks ALL other themes like this one does, YOU NEED TO TELL OTHER PEOPLE. There are a few of us out here who actually try to create and maintain other themes, and it's extremely frustrating to find out that everything has been broken by other people since you last used it. This applies not only to this commit, but to all commits of a similar nature. If you want to see and use other themes, create an environment in which the creators of such themes do not stop maintaining them because it is too bothersome to do so. -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___
Re: [E-devel] E SVN: hermet IN trunk/elementary: data/themes/widgets src/lib
On Thu, Feb 16, 2012 at 6:20 PM, Davide Andreoli d...@gurumeditation.it wrote: 2012/2/16 ChunEon Park her...@naver.com I think theme should not broken the compatibility neither. It means we don't need to check the versions in minor changes. but when major version of elm is updated, then it allows the breaking of the theme compatibility. So I though just collection need to check the version. I still not understand your point in versioning collection... maybe you are thinking only at elm...think also at apps, for example in my apps usually I have: collections{ group { name: my/main/interface; // this is not an elm widget ... } group { name: elm/button; // this is an extension of the elm theme ... } } in this case there are 2 different version to match: the one for elm/button and the one for my app theme. Also: are you thinking at theme_version==elm_version? ...I was thinking about different versions I also agree with you. If it's what he says, the collection's version is just a way to automatically declare version for all groups that do not specify it. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: barbieri trunk/eina/src/tests
On Thu, 16 Feb 2012 11:33:50 -0800 Enlightenment SVN no-re...@enlightenment.org wrote: Log: 3/3 eina_model: fix inheritance test. HUMAN_POOPER_IFACE must have ANIMAL_POOPER_IFACE as parent interface, otherwise the order will be incorrect. best commit message. The test were also improved in other ways: * use ck_assert_int_eq() instead of fail_if()... it prints the incorrect value * check refcount * unref models * shutdown eina Author: barbieri Date: 2012-02-16 11:33:50 -0800 (Thu, 16 Feb 2012) New Revision: 68034 Trac: http://trac.enlightenment.org/e/changeset/68034 Modified: trunk/eina/src/tests/eina_test_model.c -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: barbieri trunk/eina/src/tests
On Thu, Feb 16, 2012 at 6:48 PM, Michael Blumenkrantz michael.blumenkra...@gmail.com wrote: On Thu, 16 Feb 2012 11:33:50 -0800 Enlightenment SVN no-re...@enlightenment.org wrote: Log: 3/3 eina_model: fix inheritance test. HUMAN_POOPER_IFACE must have ANIMAL_POOPER_IFACE as parent interface, otherwise the order will be incorrect. best commit message. so yakov did this and pooped on the human poop. Oh wait... -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: barbieri trunk/eina/src/tests
On 02/16/2012 06:48 PM, Michael Blumenkrantz wrote: On Thu, 16 Feb 2012 11:33:50 -0800 Enlightenment SVNno-re...@enlightenment.org wrote: Log: 3/3 eina_model: fix inheritance test. HUMAN_POOPER_IFACE must have ANIMAL_POOPER_IFACE as parent interface, otherwise the order will be incorrect. best commit message. http://26.media.tumblr.com/tumblr_lz25l1Up1H1qzpsuoo1_500.jpg Leandro -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: barbieri trunk/eina/src/tests
On 16/02/12 22:53, Gustavo Sverzut Barbieri wrote: On Thu, Feb 16, 2012 at 6:48 PM, Michael Blumenkrantz michael.blumenkra...@gmail.com wrote: On Thu, 16 Feb 2012 11:33:50 -0800 Enlightenment SVN no-re...@enlightenment.org wrote: Log: 3/3 eina_model: fix inheritance test. HUMAN_POOPER_IFACE must have ANIMAL_POOPER_IFACE as parent interface, otherwise the order will be incorrect. best commit message. so yakov did this and pooped on the human poop. Oh wait... Nah, this one is actually a small test I hacked together in a couple of seconds... He did the examples. -- Tom. -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: sanjeev IN trunk/PROTO/elev8: . src src/bin src/include src/modules
Leonardo, Thanks for your review. On 02/17/2012 12:46 AM, Leandro Pereira wrote: On 02/16/2012 04:02 AM, Enlightenment SVN wrote: Log: Modularize elev8. Cleanup required, but this is a working version. It would be nice if, instead of loading everything automatically, we had a global modules object, where we could do things like: elm = modules.elm; dbus = modules.dbus; If the modules object does not have either elm or dbus keys, it will be loaded -- essentially becoming a way to dynamically importing modules. After the module has been loaded, a reference to it will be in the modules object already, so that even if one use modules.elm it won't reload the module. Are you suggesting that we load the modules when the JS parser sees the module name in the JS file? elev8 passes the complete JS file as one text blob to the JS compiler. I need to check the v8 API. Will get back on this one soon. Assigning to a short variable isn't mandatory, of course. So writing elm = modules.elm would just create a shorthand so things like elm.window() will still work. This might also be used to load JavaScript modules, much like the way Python does (import foo will try to load foomodule.so and if that fails, will try to load foo.py), so libraries built on top of Elev8's JS API can be written and distributed alongside it. Python also have a PYTHONPATH environment variable which can be used to specify (much like the standard PATH variable) a colon-delimited list of places to look for a module. Any thoughts on this? I agree that we do need support for import in elev8. I'll do it after the cleanup. -void load_modules(v8::Handlev8::ObjectTemplate global) + +//TODO : Add support for User Home Dir based modules. +void load_modules() { - Eina_Inlist *itr = NULL; - for (itr = root; itr != NULL; itr = itr-next) + int retval = 0; + + /* load all the modules in the installed path PACKAGE_LIB_DIR */ + + DIR *dirp; + struct dirent *dp; + char buffer[MAX_LEN]; + Eina_Module *ptr = NULL; These are not being used. It would be a good idea to build this with -Werror -Wall -Wextra -Wshadow to catch this kind of errors. Will fix today. === --- trunk/PROTO/elev8/src/include/elev8_dbus.h 2012-02-16 05:58:47 UTC (rev 68002) +++ trunk/PROTO/elev8/src/include/elev8_dbus.h 2012-02-16 06:02:26 UTC (rev 68003) @@ -10,6 +10,13 @@ #includemap #includeelev8_common.h +#define DBUS_DBG(...) EINA_LOG_DOM_DBG(elev8_dbus_log_domain, __VA_ARGS__) +#define DBUS_INF(...) EINA_LOG_DOM_INFO(elev8_dbus_log_domain, __VA_ARGS__) +#define DBUS_WRN(...) EINA_LOG_DOM_WARN(elev8_dbus_log_domain, __VA_ARGS__) +#define DBUS_ERR(...) EINA_LOG_DOM_ERR(elev8_dbus_log_domain, __VA_ARGS__) +#define DBUS_CRT(...) EINA_LOG_DOM_CRITICAL(elev8_dbus_log_domain, __VA_ARGS__) Will fix today. You could move each module to its own directory -- and the .cc files only include files from these directories, you could have DBG(...) instead of ${MODULE}_DBG(...) to keep things cleaner. This way no other module will accidentally use another module's log domain. Will fix today. Also, there's no need to use these macros with a newline character, since Eina_Log already does that for you: INF(frobnicating foobar); (Unless you'd like to space things out more so that a message stands out -- but then you should really use other tools to filter out these messages anyway.) +typedef int (*module_init)(HandleObjectTemplate global); +typedef int (*module_deinit)(void); Won't a data voidptr be useful while deallocating a module? Yes. Will fix today. By the way, with you splitting things into loadable modules, it would be a nice idea to also implement each elm widget in its own .cc file. This would not only make incremental building faster, but would also be easier to scrounge inside each wrapper's code. The elm implementation is not complete. For the time being, I find it convenient to have everything in one file. Once most of the functionality is in, splitting can be done. Cheers, Leandro -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service.
Re: [E-devel] [Patch] Elementary: New custom widget Popup
I think Rajeev needs to have a solid explanation why popup is needed even though we already have notify widget. Rajeev, can you describe that? Thanks in advance. Daniel Juyung Seo (SeoZ) On Thu, Feb 16, 2012 at 11:43 PM, Tom Hacohen tom.haco...@samsung.comwrote: On 16/02/12 16:38, Gustavo Sverzut Barbieri wrote: On Thu, Feb 16, 2012 at 9:30 AM, Tom Hacohentom.haco...@samsung.com wrote: Your patch doesn't apply. Won't review. aside from that I wonder what it offers on top of elm_layout. Maybe just add a canned layout as we do with others? how does it compare with inwin? Isn't it better to provide styles for notify and inwin? Whenever sending these patches, please elaborate on the need, the existing solutions and why they do not fit or why they are not fixable. It's a layout inside an elm_notify if I understand it correctly, I don't understand why such a simple widget should become to be 1450 lines. Also, I dislike the wrap_set API, I think it's awful. -- Tom. -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: sanjeev IN trunk/PROTO/elev8: . src src/bin src/include src/modules
On Thu, Feb 16, 2012 at 11:04 PM, Sanjeev as290...@samsung.com wrote: Are you suggesting that we load the modules when the JS parser sees the module name in the JS file? Imagine you expose an object called modules to JavaScript. This object is implemented in C++ using the V8 API: modules = {}; This object is initially empty (except for pretty basic stuff that exists in all objects). If you try to access any element that doesn't exist in that object: elm = modules.elm; Most certainly you'll get some error condition from the V8 side. So, instead of actually having an error, you can recover from the it by loading the 'elm' module, creating the reference for it inside the modules object and actually returning another reference to that to whoever called it. Or you just continue with the error if the module doesn't exist anyway (say, modules.elmo -- which should display a red, fluffy character). Now -- I haven't seen the V8 API to know how easy or how difficult this is to implement. But, without looking into it, given the dynamic nature of JavaScript, I'd say this wouldn't be difficult to make with libv8. Worst case scenario, we could have an import() function, but then we might need to know which module is loaded, we might want to unload modules, etc, things we can do easily by leveraging the structures JavaScript already offers, so I'd prefer to go with the initially empty modules object. Cheers, Leandro -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: sanjeev IN trunk/PROTO/elev8: . src src/bin src/include src/modules
*Leandro -Original Message- From: Sanjeev [mailto:as290...@samsung.com] Sent: Friday, February 17, 2012 10:04 AM To: Enlightenment developer list Subject: RE: [E-devel] E SVN: sanjeev IN trunk/PROTO/elev8: . src src/bin src/include src/modules Leonardo, Thanks for your review. On 02/17/2012 12:46 AM, Leandro Pereira wrote: On 02/16/2012 04:02 AM, Enlightenment SVN wrote: Log: Modularize elev8. Cleanup required, but this is a working version. It would be nice if, instead of loading everything automatically, we had a global modules object, where we could do things like: elm = modules.elm; dbus = modules.dbus; If the modules object does not have either elm or dbus keys, it will be loaded -- essentially becoming a way to dynamically importing modules. After the module has been loaded, a reference to it will be in the modules object already, so that even if one use modules.elm it won't reload the module. Are you suggesting that we load the modules when the JS parser sees the module name in the JS file? elev8 passes the complete JS file as one text blob to the JS compiler. I need to check the v8 API. Will get back on this one soon. Assigning to a short variable isn't mandatory, of course. So writing elm = modules.elm would just create a shorthand so things like elm.window() will still work. This might also be used to load JavaScript modules, much like the way Python does (import foo will try to load foomodule.so and if that fails, will try to load foo.py), so libraries built on top of Elev8's JS API can be written and distributed alongside it. Python also have a PYTHONPATH environment variable which can be used to specify (much like the standard PATH variable) a colon-delimited list of places to look for a module. Any thoughts on this? I agree that we do need support for import in elev8. I'll do it after the cleanup. -void load_modules(v8::Handlev8::ObjectTemplate global) + +//TODO : Add support for User Home Dir based modules. +void load_modules() { - Eina_Inlist *itr = NULL; - for (itr = root; itr != NULL; itr = itr-next) + int retval = 0; + + /* load all the modules in the installed path PACKAGE_LIB_DIR */ + + DIR *dirp; + struct dirent *dp; + char buffer[MAX_LEN]; + Eina_Module *ptr = NULL; These are not being used. It would be a good idea to build this with -Werror -Wall -Wextra -Wshadow to catch this kind of errors. Will fix today. === --- trunk/PROTO/elev8/src/include/elev8_dbus.h 2012-02-16 05:58:47 UTC (rev 68002) +++ trunk/PROTO/elev8/src/include/elev8_dbus.h 2012-02-16 06:02:26 UTC (rev 68003) @@ -10,6 +10,13 @@ #includemap #includeelev8_common.h +#define DBUS_DBG(...) EINA_LOG_DOM_DBG(elev8_dbus_log_domain, __VA_ARGS__) +#define DBUS_INF(...) EINA_LOG_DOM_INFO(elev8_dbus_log_domain, __VA_ARGS__) +#define DBUS_WRN(...) EINA_LOG_DOM_WARN(elev8_dbus_log_domain, __VA_ARGS__) +#define DBUS_ERR(...) EINA_LOG_DOM_ERR(elev8_dbus_log_domain, __VA_ARGS__) +#define DBUS_CRT(...) EINA_LOG_DOM_CRITICAL(elev8_dbus_log_domain, __VA_ARGS__) Will fix today. You could move each module to its own directory -- and the .cc files only include files from these directories, you could have DBG(...) instead of ${MODULE}_DBG(...) to keep things cleaner. This way no other module will accidentally use another module's log domain. Will fix today. Also, there's no need to use these macros with a newline character, since Eina_Log already does that for you: INF(frobnicating foobar); (Unless you'd like to space things out more so that a message stands out -- but then you should really use other tools to filter out these messages anyway.) +typedef int (*module_init)(HandleObjectTemplate global); +typedef int (*module_deinit)(void); Won't a data voidptr be useful while deallocating a module? Yes. Will fix today. By the way, with you splitting things into loadable modules, it would be a nice idea to also implement each elm widget in its own .cc file. This would not only make incremental building faster, but would also be easier to scrounge inside each wrapper's code. The elm implementation is not complete. For the time being, I find it convenient to have everything in one file. Once most of the functionality is in, splitting can be done. Cheers, Leandro -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: tasn trunk/elementary/src/lib
Why does elm_naviframe_item_style_default_set API required? This API says that elm_object_style_default_set is also needed. -Regards, Hermet- -Original Message- From: Enlightenment SVNlt;no-re...@enlightenment.orggt; To: enlightenment-...@lists.sourceforge.net Cc: Sent: 12-02-16(목) 01:27:34 Subject: E SVN: tasn trunk/elementary/src/lib Log: Elm naviframe: Fix naviframe a little and add item default style set/get 1. items_get is no longer completely broken 2. default style set/get is used as a replacement for the style NULL Author: tasn Date: 2012-02-15 08:27:34 -0800 (Wed, 15 Feb 2012) New Revision: 67989 Trac: http://trac.enlightenment.org/e/changeset/67989 Modified: trunk/elementary/src/lib/elc_naviframe.c trunk/elementary/src/lib/elc_naviframe.h Modified: trunk/elementary/src/lib/elc_naviframe.c === --- trunk/elementary/src/lib/elc_naviframe.c 2012-02-15 15:33:54 UTC (rev 67988) +++ trunk/elementary/src/lib/elc_naviframe.c 2012-02-15 16:27:34 UTC (rev 67989) @@ -13,6 +13,7 @@ Eina_Bool preserve: 1; Eina_Bool auto_pushed: 1; Eina_Bool freeze_events: 1; + Eina_Stringshare *item_style; }; struct _Elm_Naviframe_Content_Item_Pair @@ -180,6 +181,7 @@ if (!wd-stack) break; } } + eina_stringshare_del(wd-item_style); free(wd); } @@ -906,13 +908,14 @@ Elm_Naviframe_Content_Item_Pair *content_pair; Elm_Naviframe_Text_Item_Pair *text_pair; Widget_Data *wd; + wd = elm_widget_data_get(WIDGET(navi_it)); + if (!wd) return; char buf[256]; if (!item_style) { - strcpy(buf, item/basic); - eina_stringshare_replace(navi_it-style, basic); + snprintf(buf, sizeof(buf), item/%s, wd-item_style); } else { @@ -950,9 +953,6 @@ navi_it-title_visible = EINA_TRUE; _sizing_eval(WIDGET(navi_it)); - wd = elm_widget_data_get(WIDGET(navi_it)); - if (!wd) return; - if (wd-freeze_events) evas_object_freeze_events_set(VIEW(navi_it), EINA_FALSE); } @@ -1070,6 +1070,7 @@ wd-auto_pushed = EINA_TRUE; wd-freeze_events = EINA_TRUE; + wd-item_style = eina_stringshare_add(basic); return obj; } @@ -1329,11 +1330,11 @@ Elm_Naviframe_Item *navi_it = (Elm_Naviframe_Item *) it; //Return if new style is exsiting one. - if (item_style) - if (!strcmp(item_style, navi_it-style)) return; + if ((item_style navi_it-style) (!strcmp(item_style, navi_it-style))) + return; - if (!item_style) - if (!strcmp(basic, navi_it-style)) return; + if ((!item_style) (!navi_it-style)) + return; _item_style_set(navi_it, item_style); } @@ -1385,13 +1386,19 @@ return wd-auto_pushed; } -EAPI Eina_Inlist * +EAPI Eina_List * elm_naviframe_items_get(const Evas_Object *obj) { ELM_CHECK_WIDTYPE(obj, widtype) NULL; Widget_Data *wd = elm_widget_data_get(obj); if (!wd) return NULL; - return wd-stack; + Eina_List *ret = NULL; + Elm_Naviframe_Item *itr; + EINA_INLIST_FOREACH(wd-stack, itr) + { + ret = eina_list_append(ret, itr); + } + return ret; } EAPI void @@ -1413,3 +1420,22 @@ if (!wd) return EINA_FALSE; return !wd-freeze_events; } + +EAPI void +elm_naviframe_item_style_default_set(Evas_Object *obj, const char *style) +{ + ELM_CHECK_WIDTYPE(obj, widtype); + Widget_Data *wd = elm_widget_data_get(obj); + if (!wd) return; + eina_stringshare_replace(wd-item_style, style); + _theme_hook(obj); +} + +EAPI const char * +elm_naviframe_item_style_default_get(const Evas_Object *obj) +{ + ELM_CHECK_WIDTYPE(obj, widtype) NULL; + Widget_Data *wd = elm_widget_data_get(obj); + if (!wd) return NULL; + return wd-item_style; +} Modified: trunk/elementary/src/lib/elc_naviframe.h === --- trunk/elementary/src/lib/elc_naviframe.h 2012-02-15 15:33:54 UTC (rev 67988) +++ trunk/elementary/src/lib/elc_naviframe.h 2012-02-15 16:27:34 UTC (rev 67989) @@ -320,12 +320,12 @@ * @brief Get a list of all the naviframe items. * * @param obj The naviframe object - * @return An Eina_Inlist* of naviframe items, #Elm_Object_Item, + * @return An Eina_List of naviframe items, #Elm_Object_Item, * or @c NULL on failure. * * @ingroup Naviframe */ -EAPI Eina_Inlist *elm_naviframe_items_get(const Evas_Object *obj); +EAPI Eina_List *elm_naviframe_items_get(const Evas_Object *obj) EINA_MALLOC EINA_WARN_UNUSED_RESULT; /** * @brief Set the event enabled when pushing/popping items @@ -361,5 +361,29 @@ EAPI Eina_Bool elm_naviframe_event_enabled_get(const Evas_Object *obj); /** + * @brief Set the default item style. + * + * Default item style will be used with items who's style is NULL + * + * @param obj The naviframe object + * @param style The style + * + * @ingroup Naviframe + */ +EAPI void elm_naviframe_item_style_default_set(Evas_Object *obj, const char *style); + +/** + * @brief Get the default item style + * + * @param obj The naviframe object + * @return the default item style + * + * @see elm_naviframe_item_style_default_set() + * + * @ingroup Naviframe + */ +EAPI
Re: [E-devel] E SVN: hermet IN trunk/elementary: data/themes/widgets src/lib
You are missing our point. Think outside of the box, elementary is not the sole user of Edje. Imagine the user is using elementary at theme version 1 and libXYZ at theme version 2. If they are the same file, as it is common, then in your proposal it fails. A concrete case for that is app-specific theme. Like enjoy support. You can update enjoy while you keep elementary the same On Friday, February 17, 2012, ChunEon Park wrote: Anycase, that will be no problem. Actually, if each group have their own versions, it could check any breakings elaborately. But still I think we don't need to have a version for each groups. Reasons. 1. elm would not break abi or functional operations in minor changes. also I think elm should not break theme compatibility in minor changes. If we have above precondition, each group does not need to have version checking. So, If app upgrades elm to new major version's then it is recommended to update their all overrided styles and collection version also. If they missed to update their collection, elm will check the collection version and could print some warning or error messages. So, They will compare their own groups with new version of groups. And found out some groups didn't changed and some groups changed. then they will merge them. and synchronize the version of their collection to the new elm collection. -Regards, Hermet- -Original Message- From: Gustavo Sverzut Barbierilt;barbi...@profusion.mobi javascript:; gt; To: Enlightenment developer list lt;enlightenment-devel@lists.sourceforge.net javascript:;gt; Cc: enlightenment-...@lists.sourceforge.net javascript:; Sent: 12-02-17(금) 05:28:48 Subject: Re: [E-devel] E SVN: hermet IN trunk/elementary: data/themes/widgets src/lib On Thu, Feb 16, 2012 at 6:20 PM, Davide Andreoli lt;d...@gurumeditation.it javascript:;gt; wrote: 2012/2/16 ChunEon Park lt;her...@naver.com javascript:;gt; I think theme should not broken the compatibility neither. It means we don't need to check the versions in minor changes. but when major version of elm is updated, then it allows the breaking of the theme compatibility. So I though just collection need to check the version. I still not understand your point in versioning collection... maybe you are thinking only at elm...think also at apps, for example in my apps usually I have: collections{ group { name: my/main/interface; // this is not an elm widget ... } group { name: elm/button; // this is an extension of the elm theme ... } } in this case there are 2 different version to match: the one for elm/button and the one for my app theme. Also: are you thinking at theme_version==elm_version? ...I was thinking about different versions I also agree with you. If it's what he says, the collection's version is just a way to automatically declare version for all groups that do not specify it. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com javascript:; Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net javascript:; https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net javascript:; https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: hermet IN trunk/elementary: data/themes/widgets src/lib
it sounds like dependency of packages are broken already. -Regards, Hermet- -Original Message- From: Gustavo Sverzut Barbierilt;barbi...@profusion.mobigt; To: Enlightenment developer listlt;enlightenment-devel@lists.sourceforge.netgt; Cc: enlightenment-...@lists.sourceforge.netlt;enlightenment-...@lists.sourceforge.netgt; Sent: 12-02-17(금) 12:38:55 Subject: Re: [E-devel] E SVN: hermet IN trunk/elementary: data/themes/widgets src/lib You are missing our point. Think outside of the box, elementary is not the sole user of Edje. Imagine the user is using elementary at theme version 1 and libXYZ at theme version 2. If they are the same file, as it is common, then in your proposal it fails. A concrete case for that is app-specific theme. Like enjoy support. You can update enjoy while you keep elementary the same On Friday, February 17, 2012, ChunEon Park wrote: Anycase, that will be no problem. Actually, if each group have their own versions, it could check any breakings elaborately. But still I think we don't need to have a version for each groups. Reasons. 1. elm would not break abi or functional operations in minor changes. also I think elm should not break theme compatibility in minor changes. If we have above precondition, each group does not need to have version checking. So, If app upgrades elm to new major version's then it is recommended to update their all overrided styles and collection version also. If they missed to update their collection, elm will check the collection version and could print some warning or error messages. So, They will compare their own groups with new version of groups. And found out some groups didn't changed and some groups changed. then they will merge them. and synchronize the version of their collection to the new elm collection. -Regards, Hermet- -Original Message- From: Gustavo Sverzut Barbierilt;barbi...@profusion.mobigt; To: Enlightenment developer list lt;enlightenment-devel@lists.sourceforge.net Cc: enlightenment-...@lists.sourceforge.net Sent: 12-02-17(금) 05:28:48 Subject: Re: [E-devel] E SVN: hermet IN trunk/elementary: data/themes/widgets src/lib On Thu, Feb 16, 2012 at 6:20 PM, Davide Andreoli lt;d...@gurumeditation.it wrote: 2012/2/16 ChunEon Park lt;her...@naver.comgt; I think theme should not broken the compatibility neither. It means we don't need to check the versions in minor changes. but when major version of elm is updated, then it allows the breaking of the theme compatibility. So I though just collection need to check the version. I still not understand your point in versioning collection... maybe you are thinking only at elm...think also at apps, for example in my apps usually I have: collections{ group { name: my/main/interface; // this is not an elm widget ... } group { name: elm/button; // this is an extension of the elm theme ... } } in this case there are 2 different version to match: the one for elm/button and the one for my app theme. Also: are you thinking at theme_version==elm_version? ...I was thinking about different versions I also agree with you. If it's what he says, the collection's version is just a way to automatically declare version for all groups that do not specify it. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses
Re: [E-devel] E SVN: sanjeev IN trunk/PROTO/elev8: . src src/bin src/include src/modules
On Thu, 16 Feb 2012 13:46:57 -0200 Leandro Pereira lean...@profusion.mobi wrote: On 02/16/2012 04:02 AM, Enlightenment SVN wrote: Log: Modularize elev8. Cleanup required, but this is a working version. It would be nice if, instead of loading everything automatically, we had a global modules object, where we could do things like: elm = modules.elm; dbus = modules.dbus; If the modules object does not have either elm or dbus keys, it will be loaded -- essentially becoming a way to dynamically importing modules. After the module has been loaded, a reference to it will be in the modules object already, so that even if one use modules.elm it won't reload the module. Assigning to a short variable isn't mandatory, of course. So writing elm = modules.elm would just create a shorthand so things like elm.window() will still work. This might also be used to load JavaScript modules, much like the way Python does (import foo will try to load foomodule.so and if that fails, will try to load foo.py), so libraries built on top of Elev8's JS API can be written and distributed alongside it. Python also have a PYTHONPATH environment variable which can be used to specify (much like the standard PATH variable) a colon-delimited list of places to look for a module. Any thoughts on this? Lua does all of that to, it's a good idea. -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. signature.asc Description: PGP signature -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [e-users] Exquisite bootsplash release
(FYI: for those who didn't read from IRC, when Carsten realized I meant to transform exquisite into a library+tools, and not add a new library to the set, he agreed to it). So I've done it, just finished, but I have a couple of questions : - what should I use for creating an object? exquisite_object_add, or exquisite_object_new ? I think _add makes more sense and follows with the edje API. - What version should I give it ? Should I keep it to 1.0.0 (or 1.0.99 to be more exact), or bump it to match the core efl libs versions (1.1.99)? - Do you have any documentation written for exquisite that I could reuse? Especially with regards to the format to follow for creating themes for it? - Why is the tag 1 for success and 0 for failure in the edc, why not success failure ? Would make it more logical, and I can use an enum for the status without hardcoding the values of the enum. - There seems to be a bug in the default theme, where the last line of text appears cropped after you add a text, I just tried with ./run-demo.sh and part of the last text is cropped after adding one line, then a bigger part after adding another line, then the last lines don't even show up. I tracked it to the shift_text embryo script in the edj, which does y = y - 8; however, the font size is not fixed to 8 pixels height, I changed it to y - 13 and it worked. A better solution must be used to make sure the text always shows independently of your default font size or whatever might affect it. Thanks, KaKaRoTo On Tue, Feb 14, 2012 at 12:25 AM, Carsten Haitzler ras...@rasterman.comwrote: On Tue, 14 Feb 2012 00:07:38 -0500 Youness Alaoui kakar...@kakaroto.homelinux.net said: well it's more because it really has very little additional beyond a progressbar and it functions for the same purpose - it just can have a large fill my window style. :) Humm... it may go as a widget in elementary, although it seems more like a megawidget than a simple generic widget, so I'm not sure its place is inside elementary. But you know best what should go in there. I however do not use elementary for the ps3 (because it hasn't been fully ported yet) so I prefer to stay with pure edje. And since exquisite is already written.. it's not much trouble to expose its functions into a header. So if you don't need/want it in elementary yourself, then don't bother since I probably won't be using it anyways. Thanks On Mon, Feb 13, 2012 at 4:07 AM, Carsten Haitzler ras...@rasterman.com wrote: On Mon, 13 Feb 2012 03:46:22 -0500 Youness Alaoui kakar...@kakaroto.homelinux.net said: hmm well if mainloop is alive... making an elementary widget would be the way to go... :) call it the splash widget - u can fill a window with it, just put it on the left/bottom half of your screen/window or whatever. :) it's really more of a progressbar PLUS a few more text fields that pb doesnt have... in fact u can do all of it with progressbars and setting text elements in the progressbar if we added another 1. you can do the end anim with signal emits - in fact u'd want the callback when done and an api for this... i'd actually suggest adding some more features to progressbar as above and adding this as a style for it. only thing then is the text log scroll - should this be in progressbar or not - do you want/need it? Yes, I've read the code, I know how small and easy it is, however, if there's a library for it, then apps could reuse the same .edc from other apps, it would give a sort of 'standard' way of doing this kind of splash screens, with a standard set of features, and a set of themes for it that people can reuse.. and obviously, if someone wants it a bit different, they can always just do their own edc instead. I just saw exquisite (release announcement on planet E) and thought it was cool, wanted to look at the API then realized it was an app, and I thought it would be better as a lib. As for uses, I do have a use for it, there are many tools for the PS3 that take a while and do many things but have no output on the screen and I thought they could benefit from that, like the messages dumping ram, patching kernel, flashing NAND, formatting flash, etc.. as well as having a progress bar.. Telling someone (who has no idea what the EFL even is) to write an EDC and set up his canvas and send signals, etc.. just for a progress bar or for printing a message on screen is a big turn off. Also, I think games may benefit from it, it's not always about boot time, but it would be for loading game levels for example, you often see a Loading screen in games, and this could be used for example. And for my immediate use, I have a tool that unzips largs packages into the PS3 HDD and I'd like to use it as a progress bar for when I unzip files, it could be used for the progress