date:20131104

Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm_conform.c: Added virtualkeypad, size, changed smart callback.

2013-11-04 Thread ChunEon Park

incorrect. 

state is not regarded to the size.
State defines just on/off. it does not mean size changed.

if you think size, changed covers the state on/off
then the name should be state,changed.

the scope of the size change is under the state change.
but state change does not under the size change scope.



-Regards, Hermet- 

-Original Message-
From: Daniel Juyung Seoseojuyu...@gmail.com 
To: Enlightenment developer listenlightenment-devel@lists.sourceforge.net; 
Cc: g...@lists.enlightenment.org; 
Sent: 2013-11-04 (월) 16:34:51
Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm_conform.c: 
Added virtualkeypad, size, changed smart callback.

On Thu, Oct 31, 2013 at 6:03 PM, ChunEon Park hermet@naver.com wrote:

 Sorry. I don't agree on this change.

 This callback will be called wheneven any keypad state is changed.
 regardless of the size changed.


If you meant *keypad state change* by virtualkeypad,state,on/off, keypad
size is changed as well.
So it's correct.
The new callback covers more use cases than just
virtualkeypad,state,on/off.
Application code can be rewritten simpler by the new api than previous one.

If there is any cases that virtualkeypad,size,changed is called even
though keypad size is not changed, please let me know.
Thanks in advance.

Daniel Juyung Seo (SeoZ)





 
 -Regards, Hermet-

 -Original Message-
 From: Daniel Juyung Seoseojuyung2@gmail.com
 To: git@lists.enlightenment.org;
 Cc:
 Sent: 2013-10-30 (수) 16:24:37
 Subject: [EGIT] [core/elementary] master 01/01: elm_conform.c: Added
 virtualkeypad,size,changed smart callback.

 seoz pushed a commit to branch master.


 http://git.enlightenment.org/core/elementary.git/commit/?id=cbd7446f0bf413ad821ac40703d2a2ca728758ef

 commit cbd7446f0bf413ad821ac40703d2a2ca728758ef
 Author: Daniel Juyung Seo seojuyung2@gmail.com
 Date:   Wed Oct 30 16:17:57 2013 +0900

 elm_conform.c: Added virtualkeypad,size,changed smart callback.

 When the virtualkeypad size is changed, applications get the notice.
 Applications can do internal object calculation according to the exact
 virtualkeypad size.
 This is useful when the exact size is important such as webkit usecase.
 ---
  ChangeLog  4 
  NEWS   1 +
  src/lib/elm_conform.c  7 +++
  src/lib/elm_conform.h  3 +++
  4 files changed, 15 insertions(+)

 diff --git a/ChangeLog b/ChangeLog
 index fbeecc7..e99d3fd 100644
 --- a/ChangeLog
 +++ b/ChangeLog
 @@ -1727,3 +1727,7 @@
  2013-10-30  Amitesh Singh (_ami_)

  * image: Add support for clicked callback on
 Return/space/KP_Enter key press.
 +
 +2013-10-30  Daniel Juyung Seo (SeoZ)
 +
 +* conform: Added virtualkeypad,size,changed callback on
 virtualkeypad min size change.
 diff --git a/NEWS b/NEWS
 index 8481107..6876073 100644
 --- a/NEWS
 +++ b/NEWS
 @@ -101,6 +101,7 @@ Additions:
 * Add elm_fileselector_hidden_visible_set/get() to show or hide hidden
 files/directories.
 * Add signals spinner,drag,start and spinner,drag,stop to the
 spinner widget.
 * Add support for clicked callback on Return/space/KP_Enter key
 press for image.
 +   * Add virtualkeypad,size,changed callback on virtualkeypad min size
 change for conformant.

  Improvements:

 diff --git a/src/lib/elm_conform.c b/src/lib/elm_conform.c
 index 9636ab8..cb00888 100644
 --- a/src/lib/elm_conform.c
 +++ b/src/lib/elm_conform.c
 @@ -36,12 +36,14 @@ static const char SOFTKEY_PART[] =
 elm.swallow.softkey;

  static const char SIG_VIRTUALKEYPAD_STATE_ON[] = virtualkeypad,state,on;
  static const char SIG_VIRTUALKEYPAD_STATE_OFF[] =
 virtualkeypad,state,off;
 +static const char SIG_VIRTUALKEYPAD_SIZE_CHANGED[] =
 virtualkeypad,size,changed;
  static const char SIG_CLIPBOARD_STATE_ON[] = clipboard,state,on;
  static const char SIG_CLIPBOARD_STATE_OFF[] = clipboard,state,off;

  static const Evas_Smart_Cb_Description _smart_callbacks[] = {
 {SIG_VIRTUALKEYPAD_STATE_ON, },
 {SIG_VIRTUALKEYPAD_STATE_OFF, },
 +   {SIG_VIRTUALKEYPAD_SIZE_CHANGED, },
 {SIG_CLIPBOARD_STATE_ON, },
 {SIG_CLIPBOARD_STATE_OFF, },
 {NULL, NULL}
 @@ -166,6 +168,8 @@ _conformant_part_sizing_eval(Evas_Object *obj,

 if (part_type  ELM_CONFORMANT_VIRTUAL_KEYPAD_PART)
   {
 +Evas_Coord_Rectangle rect;
 +
  #ifdef HAVE_ELEMENTARY_X
  if ((!_conformant_part_geometry_get_from_env
 (ILLUME_KBD, sx, sy, sw, sh))  (xwin))
 @@ -189,6 +193,9 @@ _conformant_part_sizing_eval(Evas_Object *obj,
  DBG([KEYPAD]: size(%d,%d, %dx%d)., sx, sy, sw, sh);
  _conformant_part_size_hints_set
(obj, sd-virtualkeypad, sx, sy, sw, sh);
 +
 +rect.x = sx; rect.y = sy; rect.w = sw; rect.h = sh;
 +evas_object_smart_callback_call(obj,
 SIG_VIRTUALKEYPAD_SIZE_CHANGED, (void *)rect);
   }

 if (part_type  ELM_CONFORMANT_SOFTKEY_PART)
 diff --git

Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added support for popup move. elm_popup_move.

2013-11-04 Thread ChunEon Park

Regardless of the API useful,  I don't  agree pushing the API at this moment.

It wil break popup concept. otherwise, similiar behavior of move() and align() 
will be conflicted. 
if you agree align_set() can cover the popup_move()
please just keep the align_set() only.

 

-Regards, Hermet- 

-Original Message-
From: Daniel Juyung Seoseojuyu...@gmail.com 
To: Enlightenment developer listenlightenment-devel@lists.sourceforge.net; 
Cc: g...@lists.enlightenment.org; 
Sent: 2013-11-04 (월) 16:29:02
Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added 
support for popup move. elm_popup_move.

On Mon, Nov 4, 2013 at 2:42 PM, ChunEon Park hermet@naver.com wrote:

 Abosulte position for the popup is insane if the parent position is
 changed.
 And totally popup is depends on the notify, it should follow the notify
 concept.


Agreed. I also suggested to create elm_popup_align_set() instead of this.
And he suggested elm_popup_move() to use pixel which I found it useful.

Because the author of this commit is away, I will fix it before the today's
feature freeze:
1. adding elm_popup_align_set()
2. fixing elm_popup_move() to depend on its parent position.
3. (optional) adding elm_notify_move() to use pixel

Thanks.

Daniel Juyung Seo (SeoZ)



 
 -Regards, Hermet-

 -Original Message-
 From: Daniel Juyung Seoseojuyung2@gmail.com
 To: Enlightenment developer list
 enlightenment-devel@lists.sourceforge.net;
 Cc: git@lists.enlightenment.org;
 Sent: 2013-11-04 (월) 14:37:54
 Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added
 support for popup move. elm_popup_move.

 On Mon, Nov 4, 2013 at 2:31 PM, ChunEon Park hermet@naver.com wrote:

  Eek!
 
  How about keeping the API name with notify?
  elm_notify_align_set()?
 

 Thanks for the interest and comments but the concept is different from
 align_set.
 elm_notify_align_set() gets relative position as a parameter but
 elm_popup_move() gets absolute pixel information just like elm_menu_move().
 So elm_popup_move() is correct.

 EAPI void elm_notify_align_set(Evas_Object *obj,
 double horizontal, double vertical);
 EAPI void elm_menu_move(Evas_Object *obj,
 Evas_Coord x, Evas_Coord y);
 EAPI void elm_popup_move(Evas_Object *obj, Evas_Coord x, Evas_Coord y);

 Thanks.

 Daniel Juyung Seo (SeoZ)



 
  
  -Regards, Hermet-
 
 
  -Original Message-
  From: Abhinandan Aryadiptaa.aryadipta@samsung.com
  To: git@lists.enlightenment.org;
  Cc:
  Sent: 2013-11-03 (일) 23:29:06
  Subject: [EGIT] [core/elementary] master 01/01: popup: Added support for
  popup move. elm_popup_move.
 
  seoz pushed a commit to branch master.
 
 
 
 http://git.enlightenment.org/core/elementary.git/commit/?id=f67ecb2028dd663aa4b0d9fe78b2a392ac169e7e
 
  commit f67ecb2028dd663aa4b0d9fe78b2a392ac169e7e
  Author: Abhinandan Aryadipta a.aryadipta@samsung.com
  Date:   Sun Nov 3 23:01:19 2013 +0900
 
  popup: Added support for popup move. elm_popup_move.
 
  Summary: Added support for popup move
 
  Test Plan: elm_popup_move
 
  Reviewers: seoz, singh.amitesh, tasn, Hermet
 
  CC: raster
 
  Differential Revision: https://phab.enlightenment.org/D247
  ---
   ChangeLog4 
   NEWS 1 +
   src/bin/test_popup.c58
  ++
   src/lib/elc_popup.c 41 
   src/lib/elc_popup_eo.h  14 +++
   src/lib/elc_popup_legacy.h  15 
   6 files changed, 133 insertions(+)
 
  diff --git a/ChangeLog b/ChangeLog
  index 66e4536..434f65f 100644
  --- a/ChangeLog
  +++ b/ChangeLog
  @@ -1741,3 +1741,7 @@
   * genlist , gengrid: Add
  ELM_OBJECT_MULTIPLE_SELECT_MODE_WITH_CONTROL.
   It disallow multiple selection when clicked without control
  pressed although
   multiple selection is enabled.
  +
  +2013-10-03  Abhinandan Aryadipta (aryarockstar)
  +
  +* Popup - Added elm_popup_move() api.
  diff --git a/NEWS b/NEWS
  index 4ba58bf..fece1e7 100644
  --- a/NEWS
  +++ b/NEWS
  @@ -102,6 +102,7 @@ Additions:
  * Add virtualkeypad,size,changed callback on virtualkeypad min size
  change for conformant.
  * Add elm_slider_step_get(), elm_slider_step_set() for slider.
  * Add ELM_OBJECT_MULTIPLE_SELECT_MODE_WITH_CONTROL select mode for
  genlist/gengrid.
  +   * Add support elm_popup_move() for popup.
 
   Improvements:
 
  diff --git a/src/bin/test_popup.c b/src/bin/test_popup.c
  index fa2d06e..945c3df 100644
  --- a/src/bin/test_popup.c
  +++ b/src/bin/test_popup.c
  @@ -22,6 +22,35 @@ _popup_close_cb(void *data, Evas_Object *obj
  EINA_UNUSED,
   }
 
   static void
  +_popup_move_cb(void *data, Evas_Object *obj EINA_UNUSED,
  +   void *event_info EINA_UNUSED)
  +{
  +   static int

[EGIT] [core/elementary] master 01/01: Quicklaunch: Remove extra build code for elm_test

2013-11-04 Thread Jean-Philippe Andre

jpeg pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=97264f434d88af38aead65426d67236c7f89ffc0

commit 97264f434d88af38aead65426d67236c7f89ffc0
Author: Jean-Philippe Andre jp.an...@samsung.com
Date:   Mon Nov 4 17:19:43 2013 +0900

Quicklaunch: Remove extra build code for elm_test

Now that we know we can just compile PIE programs and run them with
quicklaunch, let's simplify the build logic.
I'm pretty sure it even gives a nice boost in the build process :)
---
 src/bin/Makefile.am | 48 
 1 file changed, 8 insertions(+), 40 deletions(-)

diff --git a/src/bin/Makefile.am b/src/bin/Makefile.am
index 9069050..959ad07 100644
--- a/src/bin/Makefile.am
+++ b/src/bin/Makefile.am
@@ -37,7 +37,7 @@ bin_PROGRAMS = \
 @ELM_PREFS_CC_PRG@
 
 if BUILD_QUICKLAUNCH
-bin_PROGRAMS += elementary_quicklaunch elementary_run elementary_testql
+bin_PROGRAMS += elementary_quicklaunch elementary_run
 endif
 
 EXTRA_PROGRAMS = elementary_test elementary_config elementary_codegen 
elm_prefs_cc
@@ -157,8 +157,14 @@ elementary_test_LDADD = 
$(top_builddir)/src/lib/libelementary.la \
@EIO_LIBS@ \
@ELEMENTARY_WEB_LIBS@ \
@my_libs@
+elementary_test_CFLAGS =
 elementary_test_LDFLAGS =
 
+if BUILD_QUICKLAUNCH
+elementary_test_CFLAGS += -fpie
+elementary_test_LDFLAGS += -pie -rdynamic
+endif
+
 elementary_config_SOURCES = \
 config.c
 
@@ -228,45 +234,7 @@ elementary_run_SOURCES = run.c
 elementary_run_LDADD =
 elementary_run_LDFLAGS =
 endif
-
-## This is how to build a quicklanch capable app
-# build the shared lib version - libtool produces a .a and .la file as well
-# as a .so - these get put in libdir ($PREFIX/lib) as elementary_testql.so
-# etc. - this is where elementary will expect to find the .so's for
-# quicklaunch apps.
-elementary_testqldir = $(libdir)
-elementary_testql_LTLIBRARIES = elementary_testql.la
-elementary_testql_la_SOURCES = $(elementary_test_SOURCES)
-elementary_testql_la_LIBADD = $(top_builddir)/src/lib/libelementary.la \
-@ELEMENTARY_WAYLAND_LIBS@ \
-   @ELEMENTARY_EWEATHER_LIBS@ \
-   @ELEMENTARY_ELDBUS_LIBS@ \
-   @ELEMENTARY_EFREET_LIBS@ \
-   @ELEMENTARY_ELOCATION_LIBS@ \
-   @ELEMENTARY_EMAP_LIBS@ \
-   @ELEMENTARY_LIBS@ \
-   @EIO_LIBS@ \
-   @ELEMENTARY_WEB_LIBS@ \
-   @my_libs@
-
-elementary_testql_la_CFLAGS =
-elementary_testql_la_LDFLAGS = -module -avoid-version -no-undefined
-elementary_testql_SOURCES = $(elementary_test_SOURCES)
-elementary_testql_LDADD = $(top_builddir)/src/lib/libelementary.la \
-@ELEMENTARY_WAYLAND_LIBS@ \
-   @ELEMENTARY_EWEATHER_LIBS@ \
-   @ELEMENTARY_ELDBUS_LIBS@ \
-   @ELEMENTARY_EFREET_LIBS@ \
-   @ELEMENTARY_ELOCATION_LIBS@ \
-   @ELEMENTARY_EMAP_LIBS@ \
-   @ELEMENTARY_LIBS@ \
-   @EIO_LIBS@ \
-   @ELEMENTARY_WEB_LIBS@ \
-   @my_libs@
-
-elementary_testql_CFLAGS = -DELM_LIB_QUICKLAUNCH=1
-elementary_testql_LDFLAGS =
 endif
 
 EXTRA_DIST = \
-test_factory.c
\ No newline at end of file
+test_factory.c

--

Re: [E-devel] Elementary QuickLaunch and PIE executables

2013-11-04 Thread Jean-Philippe André

Hello again,

I have submitted some changes to Elementary, reviewed by Cedric, so blame
him if everything is broken now :)
The following commits remove elementary_testql, simplify the build logic
based on PIE and even simplify execution of quicklaunch programs (by
extending the searched paths):
https://git.enlightenment.org/core/elementary.git/commit/?id=876f8bccc7fed2f8511c9bdbe1c0e21be30290ca
https://git.enlightenment.org/core/elementary.git/commit/?id=97264f434d88af38aead65426d67236c7f89ffc0

I'll remove the now useless #ifdef ELM_LIB_QUICKLAUNCH in elementary.

Btw, I forgot to add that the linker needs -rdynamic -pie and not just -pie
:)

Best regards,

2013/11/4 Jean-Philippe André j...@videolan.org

Hello,

TL;DR: I want to get rid of the quicklaunch complex wrapper + lib system
and compile apps with -fPIC and link with -pie instead. Little to no
changes required in elementary.

As was pointed out recentely on this very mailing list, it is possible to
make .so files that are runnable. The mail pointed to:
http://rachid.koucha.free.fr/tech_corner/executable_lib.html

This is IMO a pretty hacky solution (especially the part where we need to
point directly to ld-linux-2.so). It's not very portable as it already
won't run on x64 (need to change the ld library path). Also, I could not
manage to get proper argc, argv in main (only the program name).

Instead of that, we can compile apps with -fPIC (or -fpic or -fpie or
-fPIE) and link with -pie. This will make linkable executables, instead of
executable shared libraries :)

Now, as you know, we have this Quicklaunch system that will load a library
containing the application's code and run elm_main from there. The
associated executable is then just a wrapper linked to that library and
that calls elm_quicklaunch_fallback().

I see a few drawbacks to this model:
- Compilation requires to take care of Quicklaunch, enabling #define flags
as well as adding specific instructions in Makefiles to generate the lib
and wrapper.
- A program needs to be installed in order to be run by elementary_run
(looks into ../lib folder)
- There are two files instead of one (lib + wrapper)

All of this seems a bit confusing to me, especially considering it is
pretty easy to render an executable linkable by dlopen/dlsym, by using
-fpie and -pie.
I believe we can consider the performance hit minimal in normal use cases.

For legacy support, we need to keep some stuff around, but I believe we
should get rid of -DELM_LIB_QUICKLAUNCH and advise to compile PIE instead.
Should we go as far as adding a #warning if ELM_LIB_QUICKLAUNCH is
defined? :)

Best regards,

--
Jean-Philippe André

--
Jean-Philippe André
--
Android is increasing in popularity, but the open development platform that
developers love is also attractive to malware creators. Download this white
paper to learn more about secure code signing practices that can help keep
Android apps secure.
http://pubads.g.doubleclick.net/gampad/clk?id=65839951iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

94 matches

Mail list logo