Re: [E-devel] EFL 1.20.0 beta 2

[Jean-Philippe André]

2017-07-13 8:57 GMT+09:00 Carsten Haitzler :

> On Wed, 12 Jul 2017 16:13:48 + Andrew Williams 
> said:
>
> > On Linux and on OS X the scrollbars in Elementary now jump when dragged
> so
> > that the top of the bar is under the cursor. This happened in the last 2
> > days as far as I can tell.
>
> yeah. i see that... that's bad... :(
>
> Yeah I see it as well and I think I know the culprit.
I'll have a look, thanks for the report.


> > Andy
> >
> > On Wed, 12 Jul 2017 at 14:12 Jean Guyomarc'h 
> > wrote:
> >
> > > Hi,
> > >
> > > I haven't tested the beta2 on osx, but it was "fine" (except the
> infamous
> > > segfault when ending a graphical program) during alpha phase.
> > > I'll try to have a look during the week, but since my hardware is
> dying,
> > > build times are terrible, which make development harder.
> > >
> > > Jean
> > >
> > > On Wed, Jul 12, 2017 at 12:50 PM, Andrew Williams <
> a...@andywilliams.me>
> > > wrote:
> > >
> > > > Hi,
> > > >
> > > > Have people been testing on OS X in the last week? I just updated to
> > > master
> > > > (almost the same as beta2?) and I see many new issues / regressions.
> Will
> > > > document them in tickets and link here later.
> > > >
> > > > Thanks,
> > > > Andy
> > > > On Wed, 12 Jul 2017 at 11:02, Stefan Schmidt  >
> > > > wrote:
> > > >
> > > > > Hello.
> > > > >
> > > > > On 07/12/2017 02:49 AM, William L. Thomson Jr. wrote:
> > > > > > On Tue, 11 Jul 2017 23:51:54 +0200
> > > > > > Stefan Schmidt  wrote:
> > > > > >
> > > > > >> Second beta release for the 1.20 release cycle. Please give it
> some
> > > > > >> good testing
> > > > > >>
> > > > > >> **Download**
> > > > > >>
> > > > > >> http://download.enlightenment.org/rel/libs/efl/efl-1.20.0-
> > > > beta2.tar.gz
> > > > > >> 1a845c6cfdb139d25bc29d7bfdbc15bcf7d246aad2d1f6be3218f7925cfd
> 7078
> > > > > >>
> > > > > >> http://download.enlightenment.org/rel/libs/efl/efl-1.20.0-
> > > > beta2.tar.xz
> > > > > >> b0f33bc39b28ea13c2581326b2544f8a75935f0c877ba2db790531021764
> f82b
> > > > > >
> > > > > > Failed to build with same issue as beta1. Which I thought was
> fixed?
> > > > >
> > > > > I was under the same impression. That this was fixed.
> > > > >
> > > > > > make[4]: *** No rule to make target 'lib/efl_wl/copiedfromweston.
> x',
> > > > > > needed by ' lib/efl_wl/libefl_wl.la'.  Stop.
> > > > > >
> > > > > >   * ERROR: dev-libs/efl-1.20.0_beta2::os-xtoo failed (compile
> phase):
> > > > > >   *   emake failed
> > > > >
> > > > > I was able to reproduce this here now. Will ahve a look to get this
> > > > fixed.
> > > > >
> > > > > regards
> > > > > Stefan Schmidt
> > > > >
> > > > >
> > > > > 
> > > > --
> > > > > Check out the vibrant tech community on one of the world's most
> > > > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> > > > > ___
> > > > > enlightenment-devel mailing list
> > > > > enlightenment-devel@lists.sourceforge.net
> > > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> > > > >
> > > > --
> > > > http://andywilliams.me
> > > > http://ajwillia.ms
> > > > 
> > > > --
> > > > Check out the vibrant tech community on one of the world's most
> > > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> > > > ___
> > > > enlightenment-devel mailing list
> > > > enlightenment-devel@lists.sourceforge.net
> > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> > > >
> > >
> > > 
> --
> > > Check out the vibrant tech community on one of the world's most
> > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> > > ___
> > > enlightenment-devel mailing list
> > > enlightenment-devel@lists.sourceforge.net
> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> > >
> > --
> > http://andywilliams.me
> > http://ajwillia.ms
> > 
> --
> > Check out the vibrant tech community on one of the world's most
> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> > ___
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >
>
>
> --
> - Codito, ergo sum - "I code, therefore I am" --
> The Rasterman (Carsten Haitzler)ras...@rasterman.com
>
>
> 
> --
> Check out the vibrant tech community on one of the 

[EGIT] [core/efl] master 01/01: win: fix compiler warning

[Amitesh Singh]

ami pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=98b9bb0da519c3ac9eb1c33caad79e54349e5a7f

commit 98b9bb0da519c3ac9eb1c33caad79e54349e5a7f
Author: Amitesh Singh 
Date:   Thu Jul 13 11:16:48 2017 +0900

win: fix compiler warning
---
 src/lib/elementary/efl_ui_win.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/elementary/efl_ui_win.c b/src/lib/elementary/efl_ui_win.c
index 90bdb2c145..cd54c583ca 100644
--- a/src/lib/elementary/efl_ui_win.c
+++ b/src/lib/elementary/efl_ui_win.c
@@ -5339,7 +5339,7 @@ _efl_ui_win_elm_widget_focus_manager_factory(Eo *obj 
EINA_UNUSED, Efl_Ui_Win_Dat
 }
 
 EOLIAN static void
-_efl_ui_win_efl_object_destructor(Eo *obj EINA_UNUSED, Efl_Ui_Win_Data *pd)
+_efl_ui_win_efl_object_destructor(Eo *obj EINA_UNUSED, Efl_Ui_Win_Data *pd 
EINA_UNUSED)
 {
 #ifdef HAVE_ELEMENTARY_WL2
if (pd->type == ELM_WIN_FAKE)

-- 

Re: [E-devel] main menu breakage

[Jean-Philippe André]

2017-07-13 6:18 GMT+09:00 Andrew Williams :

> Hi,
>
> Thanks for the fixage.
> I have noticed that there is still an outstanding issue on OS X
> unfortunately.
> If you have a main menu in the window then on OSX the window is too short
> by the height of a menu.
> Check it out in elementary_test or in edi too.
> I could look at addressing it but I don't know where to start :)
>

Thanks for the report. I'm not too surprised and will look into it.
I can test with Ubuntu's Unity desktop I think. I can't test OSX.


>
> Thanks,
> Andy
>
> On Tue, 4 Jul 2017 at 12:42 Andrew Williams  wrote:
>
> > Great thanks.
> > I look forward to seeing how the api was misused as well - it seemed like
> > such a simple concept :)
> >
> > Andy
> > On Tue, 4 Jul 2017 at 05:27, Jean-Philippe André 
> > wrote:
> >
> >> Hi Andy,
> >>
> >> I've just pushed some patches in my efl dev branch.
> >> Not merging to master right now but will do tomorrow unless I find new
> >> issues.
> >>
> >> Also I will push some pathes for edi itself (misuse of the main menu
> api).
> >>
> >> Hopefully this solves everything. Resizing seems faster but it's still
> >> quite slow, so I guess we can still improve a lot there.
> >>
> >> Best regards,
> >>
> >>
> >> 2017-07-04 0:48 GMT+09:00 Andrew Williams :
> >>
> >> > Let's get that in to the the next release at least and we can figure
> the
> >> > rest based on that. Edi did have a workaround applied that I removed
> so
> >> I
> >> > may need to play with things a little to see if there is strangeness
> at
> >> > that end too.
> >> >
> >> > Thanks,
> >> > Andy
> >> > On Mon, 3 Jul 2017 at 02:43, Jean-Philippe André 
> >> > wrote:
> >> >
> >> > > Hi,
> >> > >
> >> > > 2017-06-29 20:57 GMT+09:00 Andrew Williams :
> >> > >
> >> > > > Hi,
> >> > > >
> >> > > > I meant to get this resolved at the weekend but we ran out of the
> >> time.
> >> > > > Some strange sizing issues have been haunting us (
> >> > > > https://phab.enlightenment.org/T5482) I have tracked it down to a
> >> main
> >> > > > menu
> >> > > > that's bigger than the window content.
> >> > > >
> >> > > > If someone can help please apply the attached patch to EFL then
> run
> >> > > > elementary_test and click "Main menu" - you will see a very
> unhappy
> >> > > > window...
> >> > > >
> >> > > > First to solve this get's a special prize!
> >> > > >
> >> > >
> >> > > I've got a pending patch for that but I'm not too happy with it and
> it
> >> > also
> >> > > doesn't solve your issues with EDI.
> >> > > I'll keep investigating.
> >> > >
> >> > > --
> >> > > Jean-Philippe André
> >> > >
> >> > > 
> >> > --
> >> > > Check out the vibrant tech community on one of the world's most
> >> > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> >> > > ___
> >> > > enlightenment-devel mailing list
> >> > > enlightenment-devel@lists.sourceforge.net
> >> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >> > >
> >> > --
> >> > http://andywilliams.me
> >> > http://ajwillia.ms
> >> > 
> >> > --
> >> > Check out the vibrant tech community on one of the world's most
> >> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> >> > ___
> >> > enlightenment-devel mailing list
> >> > enlightenment-devel@lists.sourceforge.net
> >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >> >
> >>
> >>
> >>
> >> --
> >> Jean-Philippe André
> >>
> >> 
> --
> >> Check out the vibrant tech community on one of the world's most
> >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> >> ___
> >> enlightenment-devel mailing list
> >> enlightenment-devel@lists.sourceforge.net
> >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >>
> > --
> > http://andywilliams.me
> > http://ajwillia.ms
> >
> --
> http://andywilliams.me
> http://ajwillia.ms
> 
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>



-- 
Jean-Philippe André
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

Re: [E-devel] Work items towards 1.20

[Christopher Michael]

On 07/12/2017 08:53 PM, Stephen Houston wrote:

The phab ticket this email refers to was filed by Mike ages ago. Thus why I
figured I'd prod the list with it, especially now, as we try to finish up
our e_widget to elm conversions.


Yay

 There is no reason that code shouldn't be

in elm_image as it has stably worked in E since I'm guessing the eapp to
desktop switch ages ago as you said. Anyhow. Surely now someone will add it
for efl 1.21.



Indeed !! +1

dh



On Wed, Jul 12, 2017, 7:49 PM Christopher Michael 
wrote:


On 07/12/2017 08:45 PM, Stephen Houston wrote:

Nah Ephoto doesn't use it. Only e_icon widget in enlightenment that Im
aware of, maybe EDI. For all of the .desktop handling in launchers,


.desktop handling was something done years ago...how did it get lost ?


everything, ibar, luncher, efm, etc..., etc... been tested quite awhile

in

those places. So it shouldn't have much trouble being stable for 1.21



Cool



On Wed, Jul 12, 2017, 7:35 PM Christopher Michael <

cp.mich...@samsung.com>

wrote:


On 07/12/2017 08:15 PM, Stephen Houston wrote:

No worries. It's been tested for a very long time as it resides in

e_icon

and has for a long time. It can go in Next release.



Sounds great ! I'm sure it's been tested in Ephoto... ;)

dh


On Wed, Jul 12, 2017, 7:11 PM Carsten Haitzler 

wrote:



On Wed, 12 Jul 2017 19:21:47 -0400 Christopher Michael <
cp.mich...@samsung.com>
said:


On 07/12/2017 07:08 PM, Simon Lees wrote:



On 13/07/17 01:59, Stephen Houston wrote:

Yep. Understand. Just figured I'd throw it out there since it will

need to

be backported to this release and others anyway...



Why? we only really backport bugfixes not new features. No one will

run

e22 with a older version of efl,


Umm .. history says otherwise. People will try


just make it a requirement at compile time. that SHOULD translate to

it

being
also a minimum req at package time if done right... e can also check
versions
at runtime too - efl does expose its version in the efl_version

struct...



  so just bump the minimum efl

requirement for e22 to 1.21, if e22 was going to be released in the

next

month or so there might be a case for including it in efl 1.20 now,


E fallows it's own release schedule.,...

  but I

don't think thats likely.



Perhaps not...doesn't stop people from trying to run versions that

are

not meant to work together...


see above. :)


I believe Stefan's stance is that this could be considered a "new
feature"...one not tested by the majority of people, and therefore
cannot be certain that condensed code would be wiser...


I have nothing against the idea and getting rid of code duplication

is

a

 >>> good goal as well


My stance:

I do not think we should start this now, so late
in the stabilization schedule.



agreed. leave it for 1.21 to clean up (ie wait for 1.20 to be out then

push

your cleanup from a branch or do the work then and have it tested for

a

few

weeks/months from git before 1.21).


dh


On Wed, Jul 12, 2017, 11:18 AM Stefan Schmidt <

ste...@osg.samsung.com



wrote:


Hello.

On 07/12/2017 04:17 PM, Stephen Houston wrote:

Sorry that I have missed bringing this up before:
https://phab.enlightenment.org/T4996

This has been around for a while... I have the code and it is

simple:

in elm_image_file_set, if the file extension is .desktop, then

create an

Efreet_Desktop *desktop object and do the following:
const char *path = NULL, *key = NULL;
char buf[4096];
if (!desktop->icon)
   path = NULL;
 else if (strncmp(desktop->icon, "/", 1) &&
!ecore_file_exists(desktop->icon))
   {
  clamp = (4 * round((double)ic->inst->size/4));
  path = efreet_icon_path_find(e_config->icon_theme,
desktop->icon, clamp);
  if (!path)
{
   if (e_util_strcmp(e_config->icon_theme,

"hicolor"))

 path = efreet_icon_path_find("hicolor",

desktop->icon,

clamp);
}
   }
 else if (ecore_file_exists(desktop->icon))
   {
  path = desktop->icon;
   }
 if (!path && desktop->icon)
   {
  snprintf(buf, sizeof(buf), "e/icons/%s",

desktop->icon);

  if


(eina_list_count(e_theme_collection_items_find("base/theme/icons",

buf)))

{
   path =

e_theme_edje_file_get("base/theme/icons",

buf);

   k = buf;
}
  else
{
   path =

e_theme_edje_file_get("base/theme/icons",

"e/icons/unknown");
   k =  "e/icons/unknown";
}
   }
 else if (!path && !desktop->icon)
   {
  path = e_theme_edje_file_get("base/theme/icons",
"e/icons/unknown");
  k = "e/icons/unknown";
   }
 if (path && desktop->icon && !k)
   {
  len 

Re: [E-devel] Work items towards 1.20

[Stephen Houston]

The phab ticket this email refers to was filed by Mike ages ago. Thus why I
figured I'd prod the list with it, especially now, as we try to finish up
our e_widget to elm conversions. There is no reason that code shouldn't be
in elm_image as it has stably worked in E since I'm guessing the eapp to
desktop switch ages ago as you said. Anyhow. Surely now someone will add it
for efl 1.21.

On Wed, Jul 12, 2017, 7:49 PM Christopher Michael 
wrote:

> On 07/12/2017 08:45 PM, Stephen Houston wrote:
> > Nah Ephoto doesn't use it. Only e_icon widget in enlightenment that Im
> > aware of, maybe EDI. For all of the .desktop handling in launchers,
>
> .desktop handling was something done years ago...how did it get lost ?
>
> > everything, ibar, luncher, efm, etc..., etc... been tested quite awhile
> in
> > those places. So it shouldn't have much trouble being stable for 1.21
> >
>
> Cool
>
>
> > On Wed, Jul 12, 2017, 7:35 PM Christopher Michael <
> cp.mich...@samsung.com>
> > wrote:
> >
> >> On 07/12/2017 08:15 PM, Stephen Houston wrote:
> >>> No worries. It's been tested for a very long time as it resides in
> e_icon
> >>> and has for a long time. It can go in Next release.
> >>>
> >>
> >> Sounds great ! I'm sure it's been tested in Ephoto... ;)
> >>
> >> dh
> >>
> >>> On Wed, Jul 12, 2017, 7:11 PM Carsten Haitzler 
> >> wrote:
> >>>
>  On Wed, 12 Jul 2017 19:21:47 -0400 Christopher Michael <
>  cp.mich...@samsung.com>
>  said:
> 
> > On 07/12/2017 07:08 PM, Simon Lees wrote:
> >>
> >>
> >> On 13/07/17 01:59, Stephen Houston wrote:
> >>> Yep. Understand. Just figured I'd throw it out there since it will
>  need to
> >>> be backported to this release and others anyway...
> >>>
> >>
> >> Why? we only really backport bugfixes not new features. No one will
> >> run
> >> e22 with a older version of efl,
> >
> > Umm .. history says otherwise. People will try
> 
>  just make it a requirement at compile time. that SHOULD translate to
> it
>  being
>  also a minimum req at package time if done right... e can also check
>  versions
>  at runtime too - efl does expose its version in the efl_version
> >> struct...
> 
> >   so just bump the minimum efl
> >> requirement for e22 to 1.21, if e22 was going to be released in the
>  next
> >> month or so there might be a case for including it in efl 1.20 now,
> >
> > E fallows it's own release schedule.,...
> >
> >   but I
> >> don't think thats likely.
> >>
> >
> > Perhaps not...doesn't stop people from trying to run versions that
> are
> > not meant to work together...
> 
>  see above. :)
> 
> > I believe Stefan's stance is that this could be considered a "new
> > feature"...one not tested by the majority of people, and therefore
> > cannot be certain that condensed code would be wiser...
> >
> > 
> > I have nothing against the idea and getting rid of code duplication
> is
> >> a
> >  >>> good goal as well
> > 
> >
> > My stance:
> > 
> > I do not think we should start this now, so late
> > in the stabilization schedule.
> > 
> 
>  agreed. leave it for 1.21 to clean up (ie wait for 1.20 to be out then
> >> push
>  your cleanup from a branch or do the work then and have it tested for
> a
> >> few
>  weeks/months from git before 1.21).
> 
> > dh
> >
> >>> On Wed, Jul 12, 2017, 11:18 AM Stefan Schmidt <
> >> ste...@osg.samsung.com
> >
> >>> wrote:
> >>>
>  Hello.
> 
>  On 07/12/2017 04:17 PM, Stephen Houston wrote:
> > Sorry that I have missed bringing this up before:
> > https://phab.enlightenment.org/T4996
> >
> > This has been around for a while... I have the code and it is
>  simple:
> > in elm_image_file_set, if the file extension is .desktop, then
>  create an
> > Efreet_Desktop *desktop object and do the following:
> > const char *path = NULL, *key = NULL;
> > char buf[4096];
> > if (!desktop->icon)
> >path = NULL;
> >  else if (strncmp(desktop->icon, "/", 1) &&
> > !ecore_file_exists(desktop->icon))
> >{
> >   clamp = (4 * round((double)ic->inst->size/4));
> >   path = efreet_icon_path_find(e_config->icon_theme,
> > desktop->icon, clamp);
> >   if (!path)
> > {
> >if (e_util_strcmp(e_config->icon_theme,
>  "hicolor"))
> >  path = efreet_icon_path_find("hicolor",
>  desktop->icon,
> > clamp);
> > }
> >}
> >  else if (ecore_file_exists(desktop->icon))
> >{
> > 

Re: [E-devel] Work items towards 1.20

[Christopher Michael]

On 07/12/2017 08:45 PM, Stephen Houston wrote:

Nah Ephoto doesn't use it. Only e_icon widget in enlightenment that Im
aware of, maybe EDI. For all of the .desktop handling in launchers,


.desktop handling was something done years ago...how did it get lost ?


everything, ibar, luncher, efm, etc..., etc... been tested quite awhile in
those places. So it shouldn't have much trouble being stable for 1.21



Cool



On Wed, Jul 12, 2017, 7:35 PM Christopher Michael 
wrote:


On 07/12/2017 08:15 PM, Stephen Houston wrote:

No worries. It's been tested for a very long time as it resides in e_icon
and has for a long time. It can go in Next release.



Sounds great ! I'm sure it's been tested in Ephoto... ;)

dh


On Wed, Jul 12, 2017, 7:11 PM Carsten Haitzler 

wrote:



On Wed, 12 Jul 2017 19:21:47 -0400 Christopher Michael <
cp.mich...@samsung.com>
said:


On 07/12/2017 07:08 PM, Simon Lees wrote:



On 13/07/17 01:59, Stephen Houston wrote:

Yep. Understand. Just figured I'd throw it out there since it will

need to

be backported to this release and others anyway...



Why? we only really backport bugfixes not new features. No one will

run

e22 with a older version of efl,


Umm .. history says otherwise. People will try


just make it a requirement at compile time. that SHOULD translate to it
being
also a minimum req at package time if done right... e can also check
versions
at runtime too - efl does expose its version in the efl_version

struct...



  so just bump the minimum efl

requirement for e22 to 1.21, if e22 was going to be released in the

next

month or so there might be a case for including it in efl 1.20 now,


E fallows it's own release schedule.,...

  but I

don't think thats likely.



Perhaps not...doesn't stop people from trying to run versions that are
not meant to work together...


see above. :)


I believe Stefan's stance is that this could be considered a "new
feature"...one not tested by the majority of people, and therefore
cannot be certain that condensed code would be wiser...


I have nothing against the idea and getting rid of code duplication is

a

 >>> good goal as well


My stance:

I do not think we should start this now, so late
in the stabilization schedule.



agreed. leave it for 1.21 to clean up (ie wait for 1.20 to be out then

push

your cleanup from a branch or do the work then and have it tested for a

few

weeks/months from git before 1.21).


dh


On Wed, Jul 12, 2017, 11:18 AM Stefan Schmidt <

ste...@osg.samsung.com



wrote:


Hello.

On 07/12/2017 04:17 PM, Stephen Houston wrote:

Sorry that I have missed bringing this up before:
https://phab.enlightenment.org/T4996

This has been around for a while... I have the code and it is

simple:

in elm_image_file_set, if the file extension is .desktop, then

create an

Efreet_Desktop *desktop object and do the following:
const char *path = NULL, *key = NULL;
char buf[4096];
if (!desktop->icon)
   path = NULL;
 else if (strncmp(desktop->icon, "/", 1) &&
!ecore_file_exists(desktop->icon))
   {
  clamp = (4 * round((double)ic->inst->size/4));
  path = efreet_icon_path_find(e_config->icon_theme,
desktop->icon, clamp);
  if (!path)
{
   if (e_util_strcmp(e_config->icon_theme,

"hicolor"))

 path = efreet_icon_path_find("hicolor",

desktop->icon,

clamp);
}
   }
 else if (ecore_file_exists(desktop->icon))
   {
  path = desktop->icon;
   }
 if (!path && desktop->icon)
   {
  snprintf(buf, sizeof(buf), "e/icons/%s",

desktop->icon);

  if
(eina_list_count(e_theme_collection_items_find("base/theme/icons",

buf)))

{
   path = e_theme_edje_file_get("base/theme/icons",

buf);

   k = buf;
}
  else
{
   path = e_theme_edje_file_get("base/theme/icons",
"e/icons/unknown");
   k =  "e/icons/unknown";
}
   }
 else if (!path && !desktop->icon)
   {
  path = e_theme_edje_file_get("base/theme/icons",
"e/icons/unknown");
  k = "e/icons/unknown";
   }
 if (path && desktop->icon && !k)
   {
  len = strlen(desktop->icon);
  if ((len > 4) && (!strcasecmp(desktop->icon + len -

4,

".edj")))
k = "icon";
   }
Then just set the path and key.  The e_theme_edje* stuff of course

would

be

substituted with elm theme stuff of course.
No need for anything special in image_file_get as the path and key

set in

file_set would return normally.

This would allow a TON of redundant code throughout E and

potentially

other

places to be removed and elm_icon to fully replace e_icon.  I'm

also sure

this would be helpful for other apps 

Re: [E-devel] Work items towards 1.20

[Stephen Houston]

Nah Ephoto doesn't use it. Only e_icon widget in enlightenment that Im
aware of, maybe EDI. For all of the .desktop handling in launchers,
everything, ibar, luncher, efm, etc..., etc... been tested quite awhile in
those places. So it shouldn't have much trouble being stable for 1.21

On Wed, Jul 12, 2017, 7:35 PM Christopher Michael 
wrote:

> On 07/12/2017 08:15 PM, Stephen Houston wrote:
> > No worries. It's been tested for a very long time as it resides in e_icon
> > and has for a long time. It can go in Next release.
> >
>
> Sounds great ! I'm sure it's been tested in Ephoto... ;)
>
> dh
>
> > On Wed, Jul 12, 2017, 7:11 PM Carsten Haitzler 
> wrote:
> >
> >> On Wed, 12 Jul 2017 19:21:47 -0400 Christopher Michael <
> >> cp.mich...@samsung.com>
> >> said:
> >>
> >>> On 07/12/2017 07:08 PM, Simon Lees wrote:
> 
> 
>  On 13/07/17 01:59, Stephen Houston wrote:
> > Yep. Understand. Just figured I'd throw it out there since it will
> >> need to
> > be backported to this release and others anyway...
> >
> 
>  Why? we only really backport bugfixes not new features. No one will
> run
>  e22 with a older version of efl,
> >>>
> >>> Umm .. history says otherwise. People will try
> >>
> >> just make it a requirement at compile time. that SHOULD translate to it
> >> being
> >> also a minimum req at package time if done right... e can also check
> >> versions
> >> at runtime too - efl does expose its version in the efl_version
> struct...
> >>
> >>>   so just bump the minimum efl
>  requirement for e22 to 1.21, if e22 was going to be released in the
> >> next
>  month or so there might be a case for including it in efl 1.20 now,
> >>>
> >>> E fallows it's own release schedule.,...
> >>>
> >>>   but I
>  don't think thats likely.
> 
> >>>
> >>> Perhaps not...doesn't stop people from trying to run versions that are
> >>> not meant to work together...
> >>
> >> see above. :)
> >>
> >>> I believe Stefan's stance is that this could be considered a "new
> >>> feature"...one not tested by the majority of people, and therefore
> >>> cannot be certain that condensed code would be wiser...
> >>>
> >>> 
> >>> I have nothing against the idea and getting rid of code duplication is
> a
> >>>  >>> good goal as well
> >>> 
> >>>
> >>> My stance:
> >>> 
> >>> I do not think we should start this now, so late
> >>> in the stabilization schedule.
> >>> 
> >>
> >> agreed. leave it for 1.21 to clean up (ie wait for 1.20 to be out then
> push
> >> your cleanup from a branch or do the work then and have it tested for a
> few
> >> weeks/months from git before 1.21).
> >>
> >>> dh
> >>>
> > On Wed, Jul 12, 2017, 11:18 AM Stefan Schmidt <
> ste...@osg.samsung.com
> >>>
> > wrote:
> >
> >> Hello.
> >>
> >> On 07/12/2017 04:17 PM, Stephen Houston wrote:
> >>> Sorry that I have missed bringing this up before:
> >>> https://phab.enlightenment.org/T4996
> >>>
> >>> This has been around for a while... I have the code and it is
> >> simple:
> >>> in elm_image_file_set, if the file extension is .desktop, then
> >> create an
> >>> Efreet_Desktop *desktop object and do the following:
> >>> const char *path = NULL, *key = NULL;
> >>> char buf[4096];
> >>> if (!desktop->icon)
> >>>path = NULL;
> >>>  else if (strncmp(desktop->icon, "/", 1) &&
> >>> !ecore_file_exists(desktop->icon))
> >>>{
> >>>   clamp = (4 * round((double)ic->inst->size/4));
> >>>   path = efreet_icon_path_find(e_config->icon_theme,
> >>> desktop->icon, clamp);
> >>>   if (!path)
> >>> {
> >>>if (e_util_strcmp(e_config->icon_theme,
> >> "hicolor"))
> >>>  path = efreet_icon_path_find("hicolor",
> >> desktop->icon,
> >>> clamp);
> >>> }
> >>>}
> >>>  else if (ecore_file_exists(desktop->icon))
> >>>{
> >>>   path = desktop->icon;
> >>>}
> >>>  if (!path && desktop->icon)
> >>>{
> >>>   snprintf(buf, sizeof(buf), "e/icons/%s",
> >> desktop->icon);
> >>>   if
> >>> (eina_list_count(e_theme_collection_items_find("base/theme/icons",
> >> buf)))
> >>> {
> >>>path = e_theme_edje_file_get("base/theme/icons",
> >> buf);
> >>>k = buf;
> >>> }
> >>>   else
> >>> {
> >>>path = e_theme_edje_file_get("base/theme/icons",
> >>> "e/icons/unknown");
> >>>k =  "e/icons/unknown";
> >>> }
> >>>}
> >>>  else if (!path && !desktop->icon)
> >>>{
> >>>   path = 

Re: [E-devel] Work items towards 1.20

[Simon Lees]

On 13/07/17 08:51, Christopher Michael wrote:
> On 07/12/2017 07:08 PM, Simon Lees wrote:
>>
>>
>> On 13/07/17 01:59, Stephen Houston wrote:
>>> Yep. Understand. Just figured I'd throw it out there since it will
>>> need to
>>> be backported to this release and others anyway...
>>>
>>
>> Why? we only really backport bugfixes not new features. No one will run
>> e22 with a older version of efl,
> 
> Umm .. history says otherwise. People will try
> 

Thats why we have configure checks, when e21 was released we only
supported efl 1.17 and later, 1.17 was the efl release at the time.
There was then a bunch of wayland fixes in efl 1.18 and so the minimum
for running e21 under wayland is efl 1.18. I didn't here any complaints
about that.

>  so just bump the minimum efl
>> requirement for e22 to 1.21, if e22 was going to be released in the next
>> month or so there might be a case for including it in efl 1.20 now,
> 
> E fallows it's own release schedule.,...
> 

It does but we won't release e while it depends on unreleased efl
features, keeping in mind that e generally has a decent length stability
period and efl releases are every 3 months making sure this happens
doesn't tend to cause issues. Given that e isn't ready for release yet
(in my opinion anyway) leaving this feature till efl 1.21 and setting
that as the current oldest supported version is fine.

>  but I
>> don't think thats likely.
>>
> 
> Perhaps not...doesn't stop people from trying to run versions that are
> not meant to work together...
> 

But ./configure does do this and has been doing so for quite some time.

> I believe Stefan's stance is that this could be considered a "new
> feature"...one not tested by the majority of people, and therefore
> cannot be certain that condensed code would be wiser...
> 
> 
> I have nothing against the idea and getting rid of code duplication is a
 good goal as well
> 
> 
> My stance:
> 
> I do not think we should start this now, so late
> in the stabilization schedule.
> 
> 

I agree here, it seems like a good feature for efl 1.21 and thats where
it should be included and as we don't backport features only bugfixes
that means that it will only be in efl 1.21 and later which means e22
will depend on efl 1.21 and later which is fine (its similar to what we
did with e21) and to be honest when I put out a new stable release i'll
only be testing it with the version of efl that was released around the
same time as the e release.

My point here was more if e needs this feature and e was going to be
released really soon then there maybe a case to be made for including it
in efl this late in the release cycle, but too the best of my knowledge
e22 is not about to be released so its not a issue.


-- 

Simon Lees (Simotek)http://simotek.net

Emergency Update Team   keybase.io/simotek
SUSE Linux   Adelaide Australia, UTC+10:30
GPG Fingerprint: 5B87 DB9D 88DC F606 E489 CEC5 0922 C246 02F0 014B



signature.asc
Description: OpenPGP digital signature
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Work items towards 1.20

[Christopher Michael]

On 07/12/2017 08:15 PM, Stephen Houston wrote:

No worries. It's been tested for a very long time as it resides in e_icon
and has for a long time. It can go in Next release.



Sounds great ! I'm sure it's been tested in Ephoto... ;)

dh


On Wed, Jul 12, 2017, 7:11 PM Carsten Haitzler  wrote:


On Wed, 12 Jul 2017 19:21:47 -0400 Christopher Michael <
cp.mich...@samsung.com>
said:


On 07/12/2017 07:08 PM, Simon Lees wrote:



On 13/07/17 01:59, Stephen Houston wrote:

Yep. Understand. Just figured I'd throw it out there since it will

need to

be backported to this release and others anyway...



Why? we only really backport bugfixes not new features. No one will run
e22 with a older version of efl,


Umm .. history says otherwise. People will try


just make it a requirement at compile time. that SHOULD translate to it
being
also a minimum req at package time if done right... e can also check
versions
at runtime too - efl does expose its version in the efl_version struct...


  so just bump the minimum efl

requirement for e22 to 1.21, if e22 was going to be released in the

next

month or so there might be a case for including it in efl 1.20 now,


E fallows it's own release schedule.,...

  but I

don't think thats likely.



Perhaps not...doesn't stop people from trying to run versions that are
not meant to work together...


see above. :)


I believe Stefan's stance is that this could be considered a "new
feature"...one not tested by the majority of people, and therefore
cannot be certain that condensed code would be wiser...


I have nothing against the idea and getting rid of code duplication is a
 >>> good goal as well


My stance:

I do not think we should start this now, so late
in the stabilization schedule.



agreed. leave it for 1.21 to clean up (ie wait for 1.20 to be out then push
your cleanup from a branch or do the work then and have it tested for a few
weeks/months from git before 1.21).


dh


On Wed, Jul 12, 2017, 11:18 AM Stefan Schmidt icon)
   path = NULL;
 else if (strncmp(desktop->icon, "/", 1) &&
!ecore_file_exists(desktop->icon))
   {
  clamp = (4 * round((double)ic->inst->size/4));
  path = efreet_icon_path_find(e_config->icon_theme,
desktop->icon, clamp);
  if (!path)
{
   if (e_util_strcmp(e_config->icon_theme,

"hicolor"))

 path = efreet_icon_path_find("hicolor",

desktop->icon,

clamp);
}
   }
 else if (ecore_file_exists(desktop->icon))
   {
  path = desktop->icon;
   }
 if (!path && desktop->icon)
   {
  snprintf(buf, sizeof(buf), "e/icons/%s",

desktop->icon);

  if
(eina_list_count(e_theme_collection_items_find("base/theme/icons",

buf)))

{
   path = e_theme_edje_file_get("base/theme/icons",

buf);

   k = buf;
}
  else
{
   path = e_theme_edje_file_get("base/theme/icons",
"e/icons/unknown");
   k =  "e/icons/unknown";
}
   }
 else if (!path && !desktop->icon)
   {
  path = e_theme_edje_file_get("base/theme/icons",
"e/icons/unknown");
  k = "e/icons/unknown";
   }
 if (path && desktop->icon && !k)
   {
  len = strlen(desktop->icon);
  if ((len > 4) && (!strcasecmp(desktop->icon + len - 4,
".edj")))
k = "icon";
   }
Then just set the path and key.  The e_theme_edje* stuff of course

would

be

substituted with elm theme stuff of course.
No need for anything special in image_file_get as the path and key

set in

file_set would return normally.

This would allow a TON of redundant code throughout E and

potentially

other

places to be removed and elm_icon to fully replace e_icon.  I'm

also sure

this would be helpful for other apps that would have a need to load

a

.desktop's image.

This would be very simple to add to elm_image_file_set, with the

catch

being it probably should be backported to other efl releases as

well.  I

really think this is a necessary functionality that should exist

and is

warranted.  With the simplicity of adding the code, if someone who

is

more

familiar with the current layout of the eo and elm stuff and who is

more

familiar with backporting than I am would apply this, I think it is

very

necessary.

Re: [E-devel] Work items towards 1.20

[Stephen Houston]

No worries. It's been tested for a very long time as it resides in e_icon
and has for a long time. It can go in Next release.

On Wed, Jul 12, 2017, 7:11 PM Carsten Haitzler  wrote:

> On Wed, 12 Jul 2017 19:21:47 -0400 Christopher Michael <
> cp.mich...@samsung.com>
> said:
>
> > On 07/12/2017 07:08 PM, Simon Lees wrote:
> > >
> > >
> > > On 13/07/17 01:59, Stephen Houston wrote:
> > >> Yep. Understand. Just figured I'd throw it out there since it will
> need to
> > >> be backported to this release and others anyway...
> > >>
> > >
> > > Why? we only really backport bugfixes not new features. No one will run
> > > e22 with a older version of efl,
> >
> > Umm .. history says otherwise. People will try
>
> just make it a requirement at compile time. that SHOULD translate to it
> being
> also a minimum req at package time if done right... e can also check
> versions
> at runtime too - efl does expose its version in the efl_version struct...
>
> >   so just bump the minimum efl
> > > requirement for e22 to 1.21, if e22 was going to be released in the
> next
> > > month or so there might be a case for including it in efl 1.20 now,
> >
> > E fallows it's own release schedule.,...
> >
> >   but I
> > > don't think thats likely.
> > >
> >
> > Perhaps not...doesn't stop people from trying to run versions that are
> > not meant to work together...
>
> see above. :)
>
> > I believe Stefan's stance is that this could be considered a "new
> > feature"...one not tested by the majority of people, and therefore
> > cannot be certain that condensed code would be wiser...
> >
> > 
> > I have nothing against the idea and getting rid of code duplication is a
> >  >>> good goal as well
> > 
> >
> > My stance:
> > 
> > I do not think we should start this now, so late
> > in the stabilization schedule.
> > 
>
> agreed. leave it for 1.21 to clean up (ie wait for 1.20 to be out then push
> your cleanup from a branch or do the work then and have it tested for a few
> weeks/months from git before 1.21).
>
> > dh
> >
> > >> On Wed, Jul 12, 2017, 11:18 AM Stefan Schmidt  >
> > >> wrote:
> > >>
> > >>> Hello.
> > >>>
> > >>> On 07/12/2017 04:17 PM, Stephen Houston wrote:
> >  Sorry that I have missed bringing this up before:
> >  https://phab.enlightenment.org/T4996
> > 
> >  This has been around for a while... I have the code and it is
> simple:
> >  in elm_image_file_set, if the file extension is .desktop, then
> create an
> >  Efreet_Desktop *desktop object and do the following:
> >  const char *path = NULL, *key = NULL;
> >  char buf[4096];
> >  if (!desktop->icon)
> > path = NULL;
> >   else if (strncmp(desktop->icon, "/", 1) &&
> >  !ecore_file_exists(desktop->icon))
> > {
> >    clamp = (4 * round((double)ic->inst->size/4));
> >    path = efreet_icon_path_find(e_config->icon_theme,
> >  desktop->icon, clamp);
> >    if (!path)
> >  {
> > if (e_util_strcmp(e_config->icon_theme,
> "hicolor"))
> >   path = efreet_icon_path_find("hicolor",
> > >>> desktop->icon,
> >  clamp);
> >  }
> > }
> >   else if (ecore_file_exists(desktop->icon))
> > {
> >    path = desktop->icon;
> > }
> >   if (!path && desktop->icon)
> > {
> >    snprintf(buf, sizeof(buf), "e/icons/%s",
> desktop->icon);
> >    if
> >  (eina_list_count(e_theme_collection_items_find("base/theme/icons",
> buf)))
> >  {
> > path = e_theme_edje_file_get("base/theme/icons",
> buf);
> > k = buf;
> >  }
> >    else
> >  {
> > path = e_theme_edje_file_get("base/theme/icons",
> >  "e/icons/unknown");
> > k =  "e/icons/unknown";
> >  }
> > }
> >   else if (!path && !desktop->icon)
> > {
> >    path = e_theme_edje_file_get("base/theme/icons",
> >  "e/icons/unknown");
> >    k = "e/icons/unknown";
> > }
> >   if (path && desktop->icon && !k)
> > {
> >    len = strlen(desktop->icon);
> >    if ((len > 4) && (!strcasecmp(desktop->icon + len - 4,
> >  ".edj")))
> >  k = "icon";
> > }
> >  Then just set the path and key.  The e_theme_edje* stuff of course
> would
> > >>> be
> >  substituted with elm theme stuff of course.
> >  No need for anything special in image_file_get as the path and key
> set in
> >  file_set would return normally.
> > 
> >  This would allow a 

Re: [E-devel] Work items towards 1.20

[The Rasterman]

On Wed, 12 Jul 2017 19:21:47 -0400 Christopher Michael 
said:

> On 07/12/2017 07:08 PM, Simon Lees wrote:
> >
> >
> > On 13/07/17 01:59, Stephen Houston wrote:
> >> Yep. Understand. Just figured I'd throw it out there since it will need to
> >> be backported to this release and others anyway...
> >>
> >
> > Why? we only really backport bugfixes not new features. No one will run
> > e22 with a older version of efl,
> 
> Umm .. history says otherwise. People will try

just make it a requirement at compile time. that SHOULD translate to it being
also a minimum req at package time if done right... e can also check versions
at runtime too - efl does expose its version in the efl_version struct...

>   so just bump the minimum efl
> > requirement for e22 to 1.21, if e22 was going to be released in the next
> > month or so there might be a case for including it in efl 1.20 now,
> 
> E fallows it's own release schedule.,...
> 
>   but I
> > don't think thats likely.
> >
> 
> Perhaps not...doesn't stop people from trying to run versions that are 
> not meant to work together...

see above. :)

> I believe Stefan's stance is that this could be considered a "new 
> feature"...one not tested by the majority of people, and therefore 
> cannot be certain that condensed code would be wiser...
> 
> 
> I have nothing against the idea and getting rid of code duplication is a
>  >>> good goal as well
> 
> 
> My stance:
> 
> I do not think we should start this now, so late
> in the stabilization schedule.
> 

agreed. leave it for 1.21 to clean up (ie wait for 1.20 to be out then push
your cleanup from a branch or do the work then and have it tested for a few
weeks/months from git before 1.21).

> dh
> 
> >> On Wed, Jul 12, 2017, 11:18 AM Stefan Schmidt 
> >> wrote:
> >>
> >>> Hello.
> >>>
> >>> On 07/12/2017 04:17 PM, Stephen Houston wrote:
>  Sorry that I have missed bringing this up before:
>  https://phab.enlightenment.org/T4996
> 
>  This has been around for a while... I have the code and it is simple:
>  in elm_image_file_set, if the file extension is .desktop, then create an
>  Efreet_Desktop *desktop object and do the following:
>  const char *path = NULL, *key = NULL;
>  char buf[4096];
>  if (!desktop->icon)
> path = NULL;
>   else if (strncmp(desktop->icon, "/", 1) &&
>  !ecore_file_exists(desktop->icon))
> {
>    clamp = (4 * round((double)ic->inst->size/4));
>    path = efreet_icon_path_find(e_config->icon_theme,
>  desktop->icon, clamp);
>    if (!path)
>  {
> if (e_util_strcmp(e_config->icon_theme, "hicolor"))
>   path = efreet_icon_path_find("hicolor",
> >>> desktop->icon,
>  clamp);
>  }
> }
>   else if (ecore_file_exists(desktop->icon))
> {
>    path = desktop->icon;
> }
>   if (!path && desktop->icon)
> {
>    snprintf(buf, sizeof(buf), "e/icons/%s", desktop->icon);
>    if
>  (eina_list_count(e_theme_collection_items_find("base/theme/icons", buf)))
>  {
> path = e_theme_edje_file_get("base/theme/icons", buf);
> k = buf;
>  }
>    else
>  {
> path = e_theme_edje_file_get("base/theme/icons",
>  "e/icons/unknown");
> k =  "e/icons/unknown";
>  }
> }
>   else if (!path && !desktop->icon)
> {
>    path = e_theme_edje_file_get("base/theme/icons",
>  "e/icons/unknown");
>    k = "e/icons/unknown";
> }
>   if (path && desktop->icon && !k)
> {
>    len = strlen(desktop->icon);
>    if ((len > 4) && (!strcasecmp(desktop->icon + len - 4,
>  ".edj")))
>  k = "icon";
> }
>  Then just set the path and key.  The e_theme_edje* stuff of course would
> >>> be
>  substituted with elm theme stuff of course.
>  No need for anything special in image_file_get as the path and key set in
>  file_set would return normally.
> 
>  This would allow a TON of redundant code throughout E and potentially
> >>> other
>  places to be removed and elm_icon to fully replace e_icon.  I'm also sure
>  this would be helpful for other apps that would have a need to load a
>  .desktop's image.
> 
>  This would be very simple to add to elm_image_file_set, with the catch
>  being it probably should be backported to other efl releases as well.  I
>  really think this is a necessary functionality that 

Re: [E-devel] EFL 1.20.0 beta 2

[The Rasterman]

On Wed, 12 Jul 2017 16:13:48 + Andrew Williams  said:

> On Linux and on OS X the scrollbars in Elementary now jump when dragged so
> that the top of the bar is under the cursor. This happened in the last 2
> days as far as I can tell.

yeah. i see that... that's bad... :(

> Andy
> 
> On Wed, 12 Jul 2017 at 14:12 Jean Guyomarc'h 
> wrote:
> 
> > Hi,
> >
> > I haven't tested the beta2 on osx, but it was "fine" (except the infamous
> > segfault when ending a graphical program) during alpha phase.
> > I'll try to have a look during the week, but since my hardware is dying,
> > build times are terrible, which make development harder.
> >
> > Jean
> >
> > On Wed, Jul 12, 2017 at 12:50 PM, Andrew Williams 
> > wrote:
> >
> > > Hi,
> > >
> > > Have people been testing on OS X in the last week? I just updated to
> > master
> > > (almost the same as beta2?) and I see many new issues / regressions. Will
> > > document them in tickets and link here later.
> > >
> > > Thanks,
> > > Andy
> > > On Wed, 12 Jul 2017 at 11:02, Stefan Schmidt 
> > > wrote:
> > >
> > > > Hello.
> > > >
> > > > On 07/12/2017 02:49 AM, William L. Thomson Jr. wrote:
> > > > > On Tue, 11 Jul 2017 23:51:54 +0200
> > > > > Stefan Schmidt  wrote:
> > > > >
> > > > >> Second beta release for the 1.20 release cycle. Please give it some
> > > > >> good testing
> > > > >>
> > > > >> **Download**
> > > > >>
> > > > >> http://download.enlightenment.org/rel/libs/efl/efl-1.20.0-
> > > beta2.tar.gz
> > > > >> 1a845c6cfdb139d25bc29d7bfdbc15bcf7d246aad2d1f6be3218f7925cfd7078
> > > > >>
> > > > >> http://download.enlightenment.org/rel/libs/efl/efl-1.20.0-
> > > beta2.tar.xz
> > > > >> b0f33bc39b28ea13c2581326b2544f8a75935f0c877ba2db790531021764f82b
> > > > >
> > > > > Failed to build with same issue as beta1. Which I thought was fixed?
> > > >
> > > > I was under the same impression. That this was fixed.
> > > >
> > > > > make[4]: *** No rule to make target 'lib/efl_wl/copiedfromweston.x',
> > > > > needed by ' lib/efl_wl/libefl_wl.la'.  Stop.
> > > > >
> > > > >   * ERROR: dev-libs/efl-1.20.0_beta2::os-xtoo failed (compile phase):
> > > > >   *   emake failed
> > > >
> > > > I was able to reproduce this here now. Will ahve a look to get this
> > > fixed.
> > > >
> > > > regards
> > > > Stefan Schmidt
> > > >
> > > >
> > > > 
> > > --
> > > > Check out the vibrant tech community on one of the world's most
> > > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> > > > ___
> > > > enlightenment-devel mailing list
> > > > enlightenment-devel@lists.sourceforge.net
> > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> > > >
> > > --
> > > http://andywilliams.me
> > > http://ajwillia.ms
> > > 
> > > --
> > > Check out the vibrant tech community on one of the world's most
> > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> > > ___
> > > enlightenment-devel mailing list
> > > enlightenment-devel@lists.sourceforge.net
> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> > >
> >
> > --
> > Check out the vibrant tech community on one of the world's most
> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> > ___
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >
> -- 
> http://andywilliams.me
> http://ajwillia.ms
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> 


-- 
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Work items towards 1.20

[Christopher Michael]

On 07/12/2017 07:08 PM, Simon Lees wrote:



On 13/07/17 01:59, Stephen Houston wrote:

Yep. Understand. Just figured I'd throw it out there since it will need to
be backported to this release and others anyway...



Why? we only really backport bugfixes not new features. No one will run
e22 with a older version of efl,


Umm .. history says otherwise. People will try

 so just bump the minimum efl

requirement for e22 to 1.21, if e22 was going to be released in the next
month or so there might be a case for including it in efl 1.20 now,


E fallows it's own release schedule.,...

 but I

don't think thats likely.



Perhaps not...doesn't stop people from trying to run versions that are 
not meant to work together...


I believe Stefan's stance is that this could be considered a "new 
feature"...one not tested by the majority of people, and therefore 
cannot be certain that condensed code would be wiser...



I have nothing against the idea and getting rid of code duplication is a
>>> good goal as well


My stance:

I do not think we should start this now, so late
in the stabilization schedule.


dh


On Wed, Jul 12, 2017, 11:18 AM Stefan Schmidt 
wrote:


Hello.

On 07/12/2017 04:17 PM, Stephen Houston wrote:

Sorry that I have missed bringing this up before:
https://phab.enlightenment.org/T4996

This has been around for a while... I have the code and it is simple:
in elm_image_file_set, if the file extension is .desktop, then create an
Efreet_Desktop *desktop object and do the following:
const char *path = NULL, *key = NULL;
char buf[4096];
if (!desktop->icon)
   path = NULL;
 else if (strncmp(desktop->icon, "/", 1) &&
!ecore_file_exists(desktop->icon))
   {
  clamp = (4 * round((double)ic->inst->size/4));
  path = efreet_icon_path_find(e_config->icon_theme,
desktop->icon, clamp);
  if (!path)
{
   if (e_util_strcmp(e_config->icon_theme, "hicolor"))
 path = efreet_icon_path_find("hicolor",

desktop->icon,

clamp);
}
   }
 else if (ecore_file_exists(desktop->icon))
   {
  path = desktop->icon;
   }
 if (!path && desktop->icon)
   {
  snprintf(buf, sizeof(buf), "e/icons/%s", desktop->icon);
  if
(eina_list_count(e_theme_collection_items_find("base/theme/icons", buf)))
{
   path = e_theme_edje_file_get("base/theme/icons", buf);
   k = buf;
}
  else
{
   path = e_theme_edje_file_get("base/theme/icons",
"e/icons/unknown");
   k =  "e/icons/unknown";
}
   }
 else if (!path && !desktop->icon)
   {
  path = e_theme_edje_file_get("base/theme/icons",
"e/icons/unknown");
  k = "e/icons/unknown";
   }
 if (path && desktop->icon && !k)
   {
  len = strlen(desktop->icon);
  if ((len > 4) && (!strcasecmp(desktop->icon + len - 4,
".edj")))
k = "icon";
   }
Then just set the path and key.  The e_theme_edje* stuff of course would

be

substituted with elm theme stuff of course.
No need for anything special in image_file_get as the path and key set in
file_set would return normally.

This would allow a TON of redundant code throughout E and potentially

other

places to be removed and elm_icon to fully replace e_icon.  I'm also sure
this would be helpful for other apps that would have a need to load a
.desktop's image.

This would be very simple to add to elm_image_file_set, with the catch
being it probably should be backported to other efl releases as well.  I
really think this is a necessary functionality that should exist and is
warranted.  With the simplicity of adding the code, if someone who is

more

familiar with the current layout of the eo and elm stuff and who is more
familiar with backporting than I am would apply this, I think it is very
necessary.

Again, sorry for the late notice.  Thoughts?


Right now we are looking at showstopper bugs that would block a release.
Not at new features suitable for re-factoring parts of the code base.

I have nothing against the idea and getting rid of code duplication is a
good goal as well, but I do not think we should start this now, so late
in the stabilization schedule.

regards
Stefan Schmidt






--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Work items towards 1.20

[Stephen Houston]

Gotcha.

On Wed, Jul 12, 2017, 6:10 PM Simon Lees  wrote:

>
>
> On 13/07/17 01:59, Stephen Houston wrote:
> > Yep. Understand. Just figured I'd throw it out there since it will need
> to
> > be backported to this release and others anyway...
> >
>
> Why? we only really backport bugfixes not new features. No one will run
> e22 with a older version of efl, so just bump the minimum efl
> requirement for e22 to 1.21, if e22 was going to be released in the next
> month or so there might be a case for including it in efl 1.20 now but I
> don't think thats likely.
>
> > On Wed, Jul 12, 2017, 11:18 AM Stefan Schmidt 
> > wrote:
> >
> >> Hello.
> >>
> >> On 07/12/2017 04:17 PM, Stephen Houston wrote:
> >>> Sorry that I have missed bringing this up before:
> >>> https://phab.enlightenment.org/T4996
> >>>
> >>> This has been around for a while... I have the code and it is simple:
> >>> in elm_image_file_set, if the file extension is .desktop, then create
> an
> >>> Efreet_Desktop *desktop object and do the following:
> >>> const char *path = NULL, *key = NULL;
> >>> char buf[4096];
> >>> if (!desktop->icon)
> >>>path = NULL;
> >>>  else if (strncmp(desktop->icon, "/", 1) &&
> >>> !ecore_file_exists(desktop->icon))
> >>>{
> >>>   clamp = (4 * round((double)ic->inst->size/4));
> >>>   path = efreet_icon_path_find(e_config->icon_theme,
> >>> desktop->icon, clamp);
> >>>   if (!path)
> >>> {
> >>>if (e_util_strcmp(e_config->icon_theme, "hicolor"))
> >>>  path = efreet_icon_path_find("hicolor",
> >> desktop->icon,
> >>> clamp);
> >>> }
> >>>}
> >>>  else if (ecore_file_exists(desktop->icon))
> >>>{
> >>>   path = desktop->icon;
> >>>}
> >>>  if (!path && desktop->icon)
> >>>{
> >>>   snprintf(buf, sizeof(buf), "e/icons/%s", desktop->icon);
> >>>   if
> >>> (eina_list_count(e_theme_collection_items_find("base/theme/icons",
> buf)))
> >>> {
> >>>path = e_theme_edje_file_get("base/theme/icons",
> buf);
> >>>k = buf;
> >>> }
> >>>   else
> >>> {
> >>>path = e_theme_edje_file_get("base/theme/icons",
> >>> "e/icons/unknown");
> >>>k =  "e/icons/unknown";
> >>> }
> >>>}
> >>>  else if (!path && !desktop->icon)
> >>>{
> >>>   path = e_theme_edje_file_get("base/theme/icons",
> >>> "e/icons/unknown");
> >>>   k = "e/icons/unknown";
> >>>}
> >>>  if (path && desktop->icon && !k)
> >>>{
> >>>   len = strlen(desktop->icon);
> >>>   if ((len > 4) && (!strcasecmp(desktop->icon + len - 4,
> >>> ".edj")))
> >>> k = "icon";
> >>>}
> >>> Then just set the path and key.  The e_theme_edje* stuff of course
> would
> >> be
> >>> substituted with elm theme stuff of course.
> >>> No need for anything special in image_file_get as the path and key set
> in
> >>> file_set would return normally.
> >>>
> >>> This would allow a TON of redundant code throughout E and potentially
> >> other
> >>> places to be removed and elm_icon to fully replace e_icon.  I'm also
> sure
> >>> this would be helpful for other apps that would have a need to load a
> >>> .desktop's image.
> >>>
> >>> This would be very simple to add to elm_image_file_set, with the catch
> >>> being it probably should be backported to other efl releases as well.
> I
> >>> really think this is a necessary functionality that should exist and is
> >>> warranted.  With the simplicity of adding the code, if someone who is
> >> more
> >>> familiar with the current layout of the eo and elm stuff and who is
> more
> >>> familiar with backporting than I am would apply this, I think it is
> very
> >>> necessary.
> >>>
> >>> Again, sorry for the late notice.  Thoughts?
> >>
> >> Right now we are looking at showstopper bugs that would block a release.
> >> Not at new features suitable for re-factoring parts of the code base.
> >>
> >> I have nothing against the idea and getting rid of code duplication is a
> >> good goal as well, but I do not think we should start this now, so late
> >> in the stabilization schedule.
> >>
> >> regards
> >> Stefan Schmidt
> >>
> >>
> >>
> --
> >> Check out the vibrant tech community on one of the world's most
> >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> >> ___
> >> enlightenment-devel mailing list
> >> enlightenment-devel@lists.sourceforge.net
> >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >>
> >
> 

Re: [E-devel] Work items towards 1.20

[Simon Lees]

On 13/07/17 01:59, Stephen Houston wrote:
> Yep. Understand. Just figured I'd throw it out there since it will need to
> be backported to this release and others anyway...
> 

Why? we only really backport bugfixes not new features. No one will run
e22 with a older version of efl, so just bump the minimum efl
requirement for e22 to 1.21, if e22 was going to be released in the next
month or so there might be a case for including it in efl 1.20 now but I
don't think thats likely.

> On Wed, Jul 12, 2017, 11:18 AM Stefan Schmidt 
> wrote:
> 
>> Hello.
>>
>> On 07/12/2017 04:17 PM, Stephen Houston wrote:
>>> Sorry that I have missed bringing this up before:
>>> https://phab.enlightenment.org/T4996
>>>
>>> This has been around for a while... I have the code and it is simple:
>>> in elm_image_file_set, if the file extension is .desktop, then create an
>>> Efreet_Desktop *desktop object and do the following:
>>> const char *path = NULL, *key = NULL;
>>> char buf[4096];
>>> if (!desktop->icon)
>>>path = NULL;
>>>  else if (strncmp(desktop->icon, "/", 1) &&
>>> !ecore_file_exists(desktop->icon))
>>>{
>>>   clamp = (4 * round((double)ic->inst->size/4));
>>>   path = efreet_icon_path_find(e_config->icon_theme,
>>> desktop->icon, clamp);
>>>   if (!path)
>>> {
>>>if (e_util_strcmp(e_config->icon_theme, "hicolor"))
>>>  path = efreet_icon_path_find("hicolor",
>> desktop->icon,
>>> clamp);
>>> }
>>>}
>>>  else if (ecore_file_exists(desktop->icon))
>>>{
>>>   path = desktop->icon;
>>>}
>>>  if (!path && desktop->icon)
>>>{
>>>   snprintf(buf, sizeof(buf), "e/icons/%s", desktop->icon);
>>>   if
>>> (eina_list_count(e_theme_collection_items_find("base/theme/icons", buf)))
>>> {
>>>path = e_theme_edje_file_get("base/theme/icons", buf);
>>>k = buf;
>>> }
>>>   else
>>> {
>>>path = e_theme_edje_file_get("base/theme/icons",
>>> "e/icons/unknown");
>>>k =  "e/icons/unknown";
>>> }
>>>}
>>>  else if (!path && !desktop->icon)
>>>{
>>>   path = e_theme_edje_file_get("base/theme/icons",
>>> "e/icons/unknown");
>>>   k = "e/icons/unknown";
>>>}
>>>  if (path && desktop->icon && !k)
>>>{
>>>   len = strlen(desktop->icon);
>>>   if ((len > 4) && (!strcasecmp(desktop->icon + len - 4,
>>> ".edj")))
>>> k = "icon";
>>>}
>>> Then just set the path and key.  The e_theme_edje* stuff of course would
>> be
>>> substituted with elm theme stuff of course.
>>> No need for anything special in image_file_get as the path and key set in
>>> file_set would return normally.
>>>
>>> This would allow a TON of redundant code throughout E and potentially
>> other
>>> places to be removed and elm_icon to fully replace e_icon.  I'm also sure
>>> this would be helpful for other apps that would have a need to load a
>>> .desktop's image.
>>>
>>> This would be very simple to add to elm_image_file_set, with the catch
>>> being it probably should be backported to other efl releases as well.  I
>>> really think this is a necessary functionality that should exist and is
>>> warranted.  With the simplicity of adding the code, if someone who is
>> more
>>> familiar with the current layout of the eo and elm stuff and who is more
>>> familiar with backporting than I am would apply this, I think it is very
>>> necessary.
>>>
>>> Again, sorry for the late notice.  Thoughts?
>>
>> Right now we are looking at showstopper bugs that would block a release.
>> Not at new features suitable for re-factoring parts of the code base.
>>
>> I have nothing against the idea and getting rid of code duplication is a
>> good goal as well, but I do not think we should start this now, so late
>> in the stabilization schedule.
>>
>> regards
>> Stefan Schmidt
>>
>>
>> --
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> ___
>> enlightenment-devel mailing list
>> enlightenment-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>>
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> 

Re: [E-devel] main menu breakage

[Andrew Williams]

Hi,

Thanks for the fixage.
I have noticed that there is still an outstanding issue on OS X
unfortunately.
If you have a main menu in the window then on OSX the window is too short
by the height of a menu.
Check it out in elementary_test or in edi too.
I could look at addressing it but I don't know where to start :)

Thanks,
Andy

On Tue, 4 Jul 2017 at 12:42 Andrew Williams  wrote:

> Great thanks.
> I look forward to seeing how the api was misused as well - it seemed like
> such a simple concept :)
>
> Andy
> On Tue, 4 Jul 2017 at 05:27, Jean-Philippe André 
> wrote:
>
>> Hi Andy,
>>
>> I've just pushed some patches in my efl dev branch.
>> Not merging to master right now but will do tomorrow unless I find new
>> issues.
>>
>> Also I will push some pathes for edi itself (misuse of the main menu api).
>>
>> Hopefully this solves everything. Resizing seems faster but it's still
>> quite slow, so I guess we can still improve a lot there.
>>
>> Best regards,
>>
>>
>> 2017-07-04 0:48 GMT+09:00 Andrew Williams :
>>
>> > Let's get that in to the the next release at least and we can figure the
>> > rest based on that. Edi did have a workaround applied that I removed so
>> I
>> > may need to play with things a little to see if there is strangeness at
>> > that end too.
>> >
>> > Thanks,
>> > Andy
>> > On Mon, 3 Jul 2017 at 02:43, Jean-Philippe André 
>> > wrote:
>> >
>> > > Hi,
>> > >
>> > > 2017-06-29 20:57 GMT+09:00 Andrew Williams :
>> > >
>> > > > Hi,
>> > > >
>> > > > I meant to get this resolved at the weekend but we ran out of the
>> time.
>> > > > Some strange sizing issues have been haunting us (
>> > > > https://phab.enlightenment.org/T5482) I have tracked it down to a
>> main
>> > > > menu
>> > > > that's bigger than the window content.
>> > > >
>> > > > If someone can help please apply the attached patch to EFL then run
>> > > > elementary_test and click "Main menu" - you will see a very unhappy
>> > > > window...
>> > > >
>> > > > First to solve this get's a special prize!
>> > > >
>> > >
>> > > I've got a pending patch for that but I'm not too happy with it and it
>> > also
>> > > doesn't solve your issues with EDI.
>> > > I'll keep investigating.
>> > >
>> > > --
>> > > Jean-Philippe André
>> > >
>> > > 
>> > --
>> > > Check out the vibrant tech community on one of the world's most
>> > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> > > ___
>> > > enlightenment-devel mailing list
>> > > enlightenment-devel@lists.sourceforge.net
>> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>> > >
>> > --
>> > http://andywilliams.me
>> > http://ajwillia.ms
>> > 
>> > --
>> > Check out the vibrant tech community on one of the world's most
>> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> > ___
>> > enlightenment-devel mailing list
>> > enlightenment-devel@lists.sourceforge.net
>> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>> >
>>
>>
>>
>> --
>> Jean-Philippe André
>>
>> --
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> ___
>> enlightenment-devel mailing list
>> enlightenment-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>>
> --
> http://andywilliams.me
> http://ajwillia.ms
>
-- 
http://andywilliams.me
http://ajwillia.ms
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[EGIT] [core/enlightenment] master 01/01: Cpuclock: Don't debug print the exec string.

[Stephen 'Okra' Houston]

okra pushed a commit to branch master.

http://git.enlightenment.org/core/enlightenment.git/commit/?id=392d12bafdcd228bb63b2b76dd687f17d38af0cc

commit 392d12bafdcd228bb63b2b76dd687f17d38af0cc
Author: Stephen 'Okra' Houston 
Date:   Wed Jul 12 16:07:58 2017 -0500

Cpuclock: Don't debug print the exec string.
---
 src/modules/sysinfo/cpuclock/cpuclock.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/modules/sysinfo/cpuclock/cpuclock.c 
b/src/modules/sysinfo/cpuclock/cpuclock.c
index f37d349d8..0047373f8 100644
--- a/src/modules/sysinfo/cpuclock/cpuclock.c
+++ b/src/modules/sysinfo/cpuclock/cpuclock.c
@@ -89,12 +89,10 @@ _cpuclock_set_governor(const char *governor)
 
snprintf(exe, 4096, "%s/%s/cpuclock_sysfs",
 e_module_dir_get(sysinfo_config->module), MODULE_ARCH);
-   printf("%s\n", exe);
if (stat(exe, ) < 0) return;
 
snprintf(buf, sizeof(buf),
 "%s %s %s", exe, "governor", governor);
-   printf("%s\n", buf);
system(buf);
 }
 

-- 

[EGIT] [core/enlightenment] master 01/01: Gadgets: Make sure to avoid conflicts with functions and globals.

[Stephen 'Okra' Houston]

okra pushed a commit to branch master.

http://git.enlightenment.org/core/enlightenment.git/commit/?id=9e7b78ffabf588c096ceba18a9069b1bd58ecaea

commit 9e7b78ffabf588c096ceba18a9069b1bd58ecaea
Author: Stephen 'Okra' Houston 
Date:   Wed Jul 12 16:03:06 2017 -0500

Gadgets: Make sure to avoid conflicts with functions and globals.
---
 src/modules/backlight/gadget/backlight.h|  2 --
 src/modules/backlight/gadget/mod.c  |  3 ---
 src/modules/luncher/luncher.h   |  4 ++--
 src/modules/mixer/gadget/mixer.c|  1 -
 src/modules/mixer/gadget/mixer.h|  3 +--
 src/modules/mixer/gadget/mod.c  |  3 ---
 src/modules/pager/gadget/mod.c  |  3 ---
 src/modules/pager/gadget/pager.h|  7 +++
 src/modules/sysinfo/batman/batman.h | 28 ++--
 src/modules/sysinfo/batman/batman_sysctl.c  |  4 ++--
 src/modules/sysinfo/batman/batman_udev.c|  6 +++---
 src/modules/sysinfo/batman/batman_upower.c  |  6 +++---
 src/modules/sysinfo/cpuclock/cpuclock.h | 12 ++--
 src/modules/sysinfo/cpumonitor/cpumonitor.h | 12 ++--
 src/modules/sysinfo/memusage/memusage.h |  8 
 src/modules/sysinfo/netstatus/netstatus.h   | 12 ++--
 src/modules/sysinfo/sysinfo.h   |  4 ++--
 src/modules/sysinfo/thermal/thermal.h   | 10 +-
 src/modules/xkbswitch/gadget/xkbswitch.h|  2 +-
 19 files changed, 58 insertions(+), 72 deletions(-)

diff --git a/src/modules/backlight/gadget/backlight.h 
b/src/modules/backlight/gadget/backlight.h
index 7b26537fc..a6cfd1aed 100644
--- a/src/modules/backlight/gadget/backlight.h
+++ b/src/modules/backlight/gadget/backlight.h
@@ -11,6 +11,4 @@ EINTERN Evas_Object *backlight_gadget_create(Evas_Object 
*parent, int *id EINA_U
 EINTERN void backlight_init(void);
 EINTERN void backlight_shutdown(void);
 
-extern E_Module *gm;
-
 #endif
diff --git a/src/modules/backlight/gadget/mod.c 
b/src/modules/backlight/gadget/mod.c
index 4e618250f..7025dfeb6 100644
--- a/src/modules/backlight/gadget/mod.c
+++ b/src/modules/backlight/gadget/mod.c
@@ -1,11 +1,8 @@
 #include "backlight.h"
 
-E_Module *gm;
-
 EINTERN void *
 e_modapi_gadget_init(E_Module *m)
 {
-   gm = m;
backlight_init();
e_gadget_type_add("Backlight", backlight_gadget_create, NULL);
return m;
diff --git a/src/modules/luncher/luncher.h b/src/modules/luncher/luncher.h
index e64ce7f22..e79701522 100644
--- a/src/modules/luncher/luncher.h
+++ b/src/modules/luncher/luncher.h
@@ -112,7 +112,7 @@ EINTERN Evas_Object *grid_create(Evas_Object *parent, int 
*id, E_Gadget_Site_Ori
 EINTERN void grid_reorder(Instance *inst);
 EINTERN void grid_recalculate(Instance *inst);
 
-extern Config *luncher_config;
-extern Eina_List *luncher_instances;
+EINTERN extern Config *luncher_config;
+EINTERN extern Eina_List *luncher_instances;
 
 #endif
diff --git a/src/modules/mixer/gadget/mixer.c b/src/modules/mixer/gadget/mixer.c
index c68c0e197..04a8c5304 100644
--- a/src/modules/mixer/gadget/mixer.c
+++ b/src/modules/mixer/gadget/mixer.c
@@ -1269,7 +1269,6 @@ mixer_init(void)
 
 gmixer_context->desklock_handler =
ecore_event_handler_add(E_EVENT_DESKLOCK, _desklock_cb, NULL);
-gmixer_context->module = gm;
 snprintf(buf, sizeof(buf), "%s/mixer.edj",
  e_module_dir_get(gmixer_context->module));
 gmixer_context->theme = strdup(buf);
diff --git a/src/modules/mixer/gadget/mixer.h b/src/modules/mixer/gadget/mixer.h
index 014a0e528..bb9ece15a 100644
--- a/src/modules/mixer/gadget/mixer.h
+++ b/src/modules/mixer/gadget/mixer.h
@@ -10,8 +10,7 @@ EINTERN void *e_modapi_gadget_init(E_Module *m);
 EINTERN int   e_modapi_gadget_shutdown(E_Module *m);
 EINTERN int   e_modapi_gadget_save(E_Module *m);
 
-extern int _e_gemix_log_domain;
-extern E_Module *gm;
+EINTERN extern int _e_gemix_log_domain;
 
 #undef GDBG
 #undef GINF
diff --git a/src/modules/mixer/gadget/mod.c b/src/modules/mixer/gadget/mod.c
index 80daabf7c..52e685c39 100644
--- a/src/modules/mixer/gadget/mod.c
+++ b/src/modules/mixer/gadget/mod.c
@@ -1,7 +1,6 @@
 #include "mixer.h"
 
 int _e_gemix_log_domain;
-E_Module *gm;
 
 EINTERN void *
 e_modapi_gadget_init(E_Module *m)
@@ -12,8 +11,6 @@ e_modapi_gadget_init(E_Module *m)
 
EINA_SAFETY_ON_FALSE_RETURN_VAL(emix_init(), NULL);
 
-   gm = m;
-
loaded = mixer_init();
if (!loaded)
  goto err;
diff --git a/src/modules/pager/gadget/mod.c b/src/modules/pager/gadget/mod.c
index c593c54ba..cb7687d6d 100644
--- a/src/modules/pager/gadget/mod.c
+++ b/src/modules/pager/gadget/mod.c
@@ -1,7 +1,6 @@
 #include "pager.h"
 static E_Config_DD *conf_edd = NULL;
 Config *pager_config;
-E_Module *gmodule;
 Evas_Object *cfg_dialog;
 Eina_List *ginstances, *ghandlers;
 
@@ -60,8 +59,6 @@ e_modapi_gadget_init(E_Module *m)
E_CONFIG_LIMIT(pager_config->btn_noplace, 0, 32);
E_CONFIG_LIMIT(pager_config->btn_desk, 

[EGIT] [core/enlightenment] master 03/03: Thermal: Add units.

[Stephen 'Okra' Houston]

okra pushed a commit to branch master.

http://git.enlightenment.org/core/enlightenment.git/commit/?id=b93849072a27905819bbb7ccd20819169ddd45e7

commit b93849072a27905819bbb7ccd20819169ddd45e7
Author: Stephen 'Okra' Houston 
Date:   Wed Jul 12 15:44:01 2017 -0500

Thermal: Add units.
---
 src/modules/sysinfo/thermal/thermal.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/modules/sysinfo/thermal/thermal.c 
b/src/modules/sysinfo/thermal/thermal.c
index d2e1ddfdf..467c7d6bf 100644
--- a/src/modules/sysinfo/thermal/thermal.c
+++ b/src/modules/sysinfo/thermal/thermal.c
@@ -290,7 +290,6 @@ _thermal_resize_cb(void *data, Evas *e EINA_UNUSED, 
Evas_Object *obj EINA_UNUSED
Instance *inst = data;
 

edje_object_parts_extends_calc(elm_layout_edje_get(inst->cfg->thermal.o_gadget),
 0, 0, , );
-   printf("%d x %d\n", w, h);
if (w < 1) w = 1;
if (h < 1) h = 1;
if (inst->cfg->esm == E_SYSINFO_MODULE_THERMAL)

-- 

[EGIT] [core/enlightenment] master 01/03: CPUClock: Allow setting of governors.

[Stephen 'Okra' Houston]

okra pushed a commit to branch master.

http://git.enlightenment.org/core/enlightenment.git/commit/?id=ada1fdb71a48821f9ed369d149c751638c1d6660

commit ada1fdb71a48821f9ed369d149c751638c1d6660
Author: Stephen 'Okra' Houston 
Date:   Wed Jul 12 15:42:56 2017 -0500

CPUClock: Allow setting of governors.
---
 src/modules/Makefile_sysinfo.mk|  21 -
 src/modules/sysinfo/cpuclock/cpuclock.c| 107 -
 src/modules/sysinfo/cpuclock/cpuclock.h|   3 -
 src/modules/sysinfo/cpuclock/cpuclock_config.c |   4 +-
 src/modules/sysinfo/cpuclock/cpuclock_sysfs.c  | 105 
 src/modules/sysinfo/mod.c  |   2 -
 src/modules/sysinfo/sysinfo.h  |   1 -
 7 files changed, 162 insertions(+), 81 deletions(-)

diff --git a/src/modules/Makefile_sysinfo.mk b/src/modules/Makefile_sysinfo.mk
index 9965321e3..8dfa15d3c 100644
--- a/src/modules/Makefile_sysinfo.mk
+++ b/src/modules/Makefile_sysinfo.mk
@@ -24,7 +24,6 @@ src_modules_sysinfo_module_la_SOURCES = 
src/modules/sysinfo/mod.c \
  src/modules/sysinfo/thermal/thermal_fallback.c \
  src/modules/sysinfo/cpuclock/cpuclock.h \
  src/modules/sysinfo/cpuclock/cpuclock.c \
- src/modules/sysinfo/cpuclock/cpuclock_sysfs.c \
  src/modules/sysinfo/cpuclock/cpuclock_config.c \
  src/modules/sysinfo/cpumonitor/cpumonitor.h \
  src/modules/sysinfo/cpumonitor/cpumonitor.c \
@@ -84,7 +83,23 @@ endif
 endif
 endif
 
+src_modules_sysinfo_sysfsfreqdir = $(sysinfopkgdir)
+src_modules_sysinfo_sysfsfreq_PROGRAMS = 
src/modules/sysinfo/cpuclock/cpuclock_sysfs
+
+src_modules_sysinfo_sysfsfreq_SOURCES = 
src/modules/sysinfo/cpuclock/cpuclock_sysfs.c
+src_modules_sysinfo_sysfsfreq_CPPFLAGS  = $(MOD_CPPFLAGS) @e_cflags@ 
@SUID_CFLAGS@
+src_modules_sysinfo_sysfsfreq_LDFLAGS = @SUID_LDFLAGS@
+
+sysfsfreq_setuid_root_mode = a=rx,u+xs
+sysfsfreq_setuid_root_user = root
+
+sysfsfreq-install-data-hook:
+   @chown $(sysfsfreq_setuid_root_user) 
$(DESTDIR)$(src_modules_sysinfo_sysfsfreqdir)/cpuclock_sysfs$(EXEEXT) || true
+   @chmod $(sysfsfreq_setuid_root_mode) 
$(DESTDIR)$(src_modules_sysinfo_sysfsfreqdir)/cpuclock_sysfs$(EXEEXT) || true
+
+INSTALL_DATA_HOOKS += sysfsfreq-install-data-hook
+
 PHONIES += sysinfo install-sysinfo
-sysinfo: $(sysinfopkg_LTLIBRARIES) $(sysinfo_DATA)
-install-sysinfo: install-sysinfoDATA install-sysinfopkgLTLIBRARIES
+sysinfo: $(sysinfopkg_LTLIBRARIES) $(sysinfo_DATA) 
$(src_modules_sysinfo_sysfsfreq_PROGRAMS)
+install-sysinfo: install-sysinfoDATA install-sysinfopkgLTLIBRARIES 
install-src_modules_sysinfo_sysfsfreqPROGRAMS
 endif
diff --git a/src/modules/sysinfo/cpuclock/cpuclock.c 
b/src/modules/sysinfo/cpuclock/cpuclock.c
index 0172a5e79..f37d349d8 100644
--- a/src/modules/sysinfo/cpuclock/cpuclock.c
+++ b/src/modules/sysinfo/cpuclock/cpuclock.c
@@ -62,38 +62,13 @@ _cpuclock_cb_sort(const void *item1, const void *item2)
return 0;
 }
 
-static void
-_cpuclock_set_thread_governor(void *data, Ecore_Thread *th EINA_UNUSED)
-{
-   const char *governor = data;
-
-   if (_cpuclock_sysfs_setall("scaling_governor", governor) == 0)
- return;
-   if (!strcmp(governor, "ondemand"))
- _cpuclock_sysfs_set("ondemand/ignore_nice_load", "0");
-   else if (!strcmp(governor, "conservative"))
- _cpuclock_sysfs_set("conservative/ignore_nice_load", "0");
-}
-
+#if defined(__FreeBSD__) || defined(__DragonFly__) || defined (__OpenBSD__)
 static void
 _cpuclock_set_thread_frequency(void *data, Ecore_Thread *th EINA_UNUSED)
 {
const char *freq = data;
-
-#if defined(__FreeBSD__) || defined(__DragonFly__) || defined (__OpenBSD__)
int frequency = atoi(freq);
_cpuclock_sysctl_frequency(frequency);
-#else
-   _cpuclock_sysfs_setall("scaling_setspeed", freq);
-#endif
-}
-
-static void
-_cpuclock_set_thread_pstate(void *data, Ecore_Thread *th EINA_UNUSED)
-{
-   Pstate_Config *pc = data;
-
-   _cpuclock_sysfs_pstate(pc->min, pc->max, pc->turbo);
 }
 
 static void
@@ -101,16 +76,7 @@ _cpuclock_set_thread_done(void *data EINA_UNUSED, 
Ecore_Thread *th EINA_UNUSED)
 {
return;
 }
-
-static void
-_cpuclock_set_thread_pstate_done(void *data, Ecore_Thread *th EINA_UNUSED)
-{
-   Pstate_Config *pc = data;
-
-   E_FREE_FUNC(pc, free);
-
-   return;
-}
+#endif
 
 void
 _cpuclock_set_governor(const char *governor)
@@ -118,24 +84,44 @@ _cpuclock_set_governor(const char *governor)
 #if defined __FreeBSD__ || defined __OpenBSD__
return;
 #endif
-
-   ecore_thread_run(_cpuclock_set_thread_governor, _cpuclock_set_thread_done, 
NULL, governor);
+   char buf[4096], exe[4096];
+   struct stat st;
+
+   snprintf(exe, 4096, "%s/%s/cpuclock_sysfs",
+e_module_dir_get(sysinfo_config->module), MODULE_ARCH);
+   printf("%s\n", exe);
+   if (stat(exe, ) < 0) return;
+
+   snprintf(buf, 

[EGIT] [core/enlightenment] master 02/03: Luncher: Remove useless and dangerous global.

[Stephen 'Okra' Houston]

okra pushed a commit to branch master.

http://git.enlightenment.org/core/enlightenment.git/commit/?id=731590ee7613e0af29e9e51906c1937dbf3dea82

commit 731590ee7613e0af29e9e51906c1937dbf3dea82
Author: Stephen 'Okra' Houston 
Date:   Wed Jul 12 15:43:39 2017 -0500

Luncher: Remove useless and dangerous global.
---
 src/modules/luncher/luncher.h | 1 -
 src/modules/luncher/mod.c | 3 +--
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/modules/luncher/luncher.h b/src/modules/luncher/luncher.h
index e2b7037e9..e64ce7f22 100644
--- a/src/modules/luncher/luncher.h
+++ b/src/modules/luncher/luncher.h
@@ -114,6 +114,5 @@ EINTERN void grid_recalculate(Instance *inst);
 
 extern Config *luncher_config;
 extern Eina_List *luncher_instances;
-extern E_Module *module;
 
 #endif
diff --git a/src/modules/luncher/mod.c b/src/modules/luncher/mod.c
index b03e34c1a..919d63f55 100644
--- a/src/modules/luncher/mod.c
+++ b/src/modules/luncher/mod.c
@@ -5,7 +5,6 @@
 static E_Config_DD *conf_edd = NULL;
 static E_Config_DD *conf_item_edd = NULL;
 Eina_List *luncher_instances = NULL;
-E_Module *module = NULL;
 Config *luncher_config = NULL;
 
 EINTERN void
@@ -91,7 +90,7 @@ e_modapi_init(E_Module *m)
 {
luncher_init();
 
-   module = m;
+   luncher_config->module = m;
return m;
 }
 

-- 

[EGIT] [core/enlightenment] master 01/02: Thermal: Add left click info popup

[Stephen 'Okra' Houston]

okra pushed a commit to branch master.

http://git.enlightenment.org/core/enlightenment.git/commit/?id=2fa8df456a57fb48860beb0caec3db3d43d42498

commit 2fa8df456a57fb48860beb0caec3db3d43d42498
Author: Stephen 'Okra' Houston 
Date:   Wed Jul 12 13:31:22 2017 -0500

Thermal: Add left click info popup
---
 src/modules/sysinfo/mod.c |  4 +-
 src/modules/sysinfo/sysinfo.c |  1 +
 src/modules/sysinfo/sysinfo.h |  2 +
 src/modules/sysinfo/thermal/thermal.c | 93 ---
 4 files changed, 91 insertions(+), 9 deletions(-)

diff --git a/src/modules/sysinfo/mod.c b/src/modules/sysinfo/mod.c
index 5dad8227d..b87a4520c 100644
--- a/src/modules/sysinfo/mod.c
+++ b/src/modules/sysinfo/mod.c
@@ -96,6 +96,7 @@ sysinfo_init(void)
 ci->thermal.sensor_name = NULL;
 ci->thermal.temp = -900;
 ci->thermal.units = CELSIUS;
+ci->thermal.popup = NULL;
 ci->thermal.configure = NULL;
ci->cpuclock.poll_interval = 32;
 ci->cpuclock.restore_governor = 0;
@@ -104,7 +105,8 @@ sysinfo_init(void)
 ci->cpuclock.governor = NULL;
 ci->cpuclock.pstate_min = 1;
 ci->cpuclock.pstate_max = 101;
-ci->cpuclock.configure = NULL;
+ci->cpuclock.popup = NULL;
+   ci->cpuclock.configure = NULL;
ci->cpumonitor.poll_interval = 32;
 ci->cpumonitor.total = 0;
 ci->cpumonitor.idle = 0;
diff --git a/src/modules/sysinfo/sysinfo.c b/src/modules/sysinfo/sysinfo.c
index 4b97fae54..4dc02f01b 100644
--- a/src/modules/sysinfo/sysinfo.c
+++ b/src/modules/sysinfo/sysinfo.c
@@ -104,6 +104,7 @@ _conf_item_get(int *id)
ci->thermal.sensor_type = SENSOR_TYPE_NONE;
ci->thermal.sensor_name = NULL;
ci->thermal.units = CELSIUS;
+   ci->thermal.popup = NULL;
ci->thermal.configure = NULL;
ci->cpuclock.poll_interval = 32;
ci->cpuclock.restore_governor = 0;
diff --git a/src/modules/sysinfo/sysinfo.h b/src/modules/sysinfo/sysinfo.h
index 06f06eaae..98275af8a 100644
--- a/src/modules/sysinfo/sysinfo.h
+++ b/src/modules/sysinfo/sysinfo.h
@@ -157,6 +157,8 @@ struct _Config_Item
{
   Evas_Object *o_gadget;
   Evas_Object *configure;
+  Evas_Object *popup;
+  Evas_Object *popup_label;
   int  poll_interval;
   int  low, high;
   int  sensor_type;
diff --git a/src/modules/sysinfo/thermal/thermal.c 
b/src/modules/sysinfo/thermal/thermal.c
index ddf0d7215..d2e1ddfdf 100644
--- a/src/modules/sysinfo/thermal/thermal.c
+++ b/src/modules/sysinfo/thermal/thermal.c
@@ -32,7 +32,6 @@ _thermal_face_level_set(Instance *inst, double level)
 static void
 _thermal_apply(Instance *inst, int temp)
 {
-   char buf[64];
 
if (inst->cfg->thermal.temp == temp) return;
inst->cfg->thermal.temp = temp;
@@ -46,15 +45,10 @@ _thermal_apply(Instance *inst, int temp)
  elm_layout_signal_emit(inst->cfg->thermal.o_gadget, 
"e,state,known", "");
  inst->cfg->thermal.have_temp = EINA_TRUE;
   }
-if (inst->cfg->thermal.units == FAHRENHEIT)
-  snprintf(buf, sizeof(buf), "%i°F", temp);
-else
-  snprintf(buf, sizeof(buf), "%i°C", temp);
 
 _thermal_face_level_set(inst,
 (double)(temp - inst->cfg->thermal.low) /
 (double)(inst->cfg->thermal.high - 
inst->cfg->thermal.low));
-elm_layout_text_set(inst->cfg->thermal.o_gadget, "e.text.reading", 
buf);
  }
else
  {
@@ -62,11 +56,20 @@ _thermal_apply(Instance *inst, int temp)
   {
  /* disable therm object */
  elm_layout_signal_emit(inst->cfg->thermal.o_gadget, 
"e,state,unknown", "");
- elm_layout_text_set(inst->cfg->thermal.o_gadget, 
"e.text.reading", "N/A");
  _thermal_face_level_set(inst, 0.5);
  inst->cfg->thermal.have_temp = EINA_FALSE;
   }
  }
+   if (inst->cfg->thermal.popup)
+ {
+char buf[100];
+
+if (inst->cfg->thermal.units == FAHRENHEIT)
+  snprintf(buf, 100, "%s: %d F", _("Temperature"), 
(int)((inst->cfg->thermal.temp * 9.0 / 5.0) + 32));
+else
+  snprintf(buf, 100, "%s: %d C", _("Temperature"), 
inst->cfg->thermal.temp);
+elm_object_text_set(inst->cfg->thermal.popup_label, buf);
+ } 
 }
 
 #if defined(HAVE_EEZE)
@@ -146,18 +149,82 @@ _thermal_configure_cb(Evas_Object *g)
Instance *inst = evas_object_data_get(g, "Instance");
 
if (!sysinfo_config) return NULL;
+   if (inst->cfg->thermal.popup) return NULL;
return thermal_configure(inst);
 }
 
 static void
+_thermal_popup_dismissed(void *data, Evas_Object *obj, void *event_info 
EINA_UNUSED)
+{
+   Instance *inst = data;
+   E_FREE_FUNC(obj, evas_object_del);
+
+   inst->cfg->thermal.popup = NULL;
+   inst->cfg->thermal.popup_label = NULL;
+}
+
+static void

[EGIT] [core/enlightenment] master 02/02: Cpuclock: Clean up some governor handling code.

[Stephen 'Okra' Houston]

okra pushed a commit to branch master.

http://git.enlightenment.org/core/enlightenment.git/commit/?id=d4bc101866c09188bc90d68e3cd9f72d294c3606

commit d4bc101866c09188bc90d68e3cd9f72d294c3606
Author: Stephen 'Okra' Houston 
Date:   Wed Jul 12 13:32:56 2017 -0500

Cpuclock: Clean up some governor handling code.
---
 src/modules/sysinfo/cpuclock/cpuclock.c| 3 ++-
 src/modules/sysinfo/cpuclock/cpuclock_config.c | 8 +---
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/src/modules/sysinfo/cpuclock/cpuclock.c 
b/src/modules/sysinfo/cpuclock/cpuclock.c
index 71dab70f6..0172a5e79 100644
--- a/src/modules/sysinfo/cpuclock/cpuclock.c
+++ b/src/modules/sysinfo/cpuclock/cpuclock.c
@@ -67,7 +67,8 @@ _cpuclock_set_thread_governor(void *data, Ecore_Thread *th 
EINA_UNUSED)
 {
const char *governor = data;
 
-   _cpuclock_sysfs_setall("scaling_governor", governor);
+   if (_cpuclock_sysfs_setall("scaling_governor", governor) == 0)
+ return;
if (!strcmp(governor, "ondemand"))
  _cpuclock_sysfs_set("ondemand/ignore_nice_load", "0");
else if (!strcmp(governor, "conservative"))
diff --git a/src/modules/sysinfo/cpuclock/cpuclock_config.c 
b/src/modules/sysinfo/cpuclock/cpuclock_config.c
index 995258370..255b10104 100644
--- a/src/modules/sysinfo/cpuclock/cpuclock_config.c
+++ b/src/modules/sysinfo/cpuclock/cpuclock_config.c
@@ -154,7 +154,7 @@ _powersave_changed(void *data, Evas_Object *obj, void 
*event_info EINA_UNUSED)
 {
Cpuclock_Config *cc = data;
Instance *inst = cc->inst;
-   const char *value = elm_object_text_get(obj);
+   const char *value = evas_object_data_get(obj, "governor");
 
if (value)
  eina_stringshare_replace(>cfg->cpuclock.powersave_governor, value);
@@ -167,7 +167,7 @@ _governor_changed(void *data, Evas_Object *obj, void 
*event_info EINA_UNUSED)
 {
Cpuclock_Config *cc = data;
Instance *inst = cc->inst;
-   const char *value = elm_object_text_get(obj);
+   const char *value = evas_object_data_get(obj, "governor");
 
if (value)
  {
@@ -403,7 +403,8 @@ cpuclock_configure(Instance *inst)
   elm_object_text_set(o, _("Maximum Speed"));
 else
   elm_object_text_set(o, l->data);
-elm_box_pack_end(box, o);
+   evas_object_data_set(o, "governor", (const char *)l->data);
+   elm_box_pack_end(box, o);
 evas_object_smart_callback_add(o, "changed", _governor_changed, cc);
 evas_object_show(o);
 
@@ -472,6 +473,7 @@ cpuclock_configure(Instance *inst)
 else
   elm_object_text_set(o, l->data);
 elm_object_disabled_set(o, inst->cfg->cpuclock.auto_powersave);
+   evas_object_data_set(o, "governor", l->data);
elm_box_pack_end(box, o);
 evas_object_smart_callback_add(o, "changed", _powersave_changed, cc);
 evas_object_show(o);

-- 

[EGIT] [core/efl] master 01/01: Thermal theme: Remove text from theme and quit wasting space.

[Stephen 'Okra' Houston]

okra pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=d2ce06c69ba9e65ee5490108c0b21d0049ece5a1

commit d2ce06c69ba9e65ee5490108c0b21d0049ece5a1
Author: Stephen 'Okra' Houston 
Date:   Wed Jul 12 13:07:22 2017 -0500

Thermal theme: Remove text from theme and quit wasting space.
---
 data/elementary/themes/edc/temperature.edc | 99 +-
 1 file changed, 97 insertions(+), 2 deletions(-)

diff --git a/data/elementary/themes/edc/temperature.edc 
b/data/elementary/themes/edc/temperature.edc
index d21f3a7a97..41a0d49e62 100644
--- a/data/elementary/themes/edc/temperature.edc
+++ b/data/elementary/themes/edc/temperature.edc
@@ -1,6 +1,4 @@
 group { name: "e/modules/temperature/main";
-   alias: "e/gadget/thermal/main";
-   alias: "e/gadget/thermal/main_vert";
images.image: "therm_content.png" COMP;
images.image: "therm_shadow.png" COMP;
images.image: "therm_shine.png" COMP;
@@ -115,4 +113,101 @@ group { name: "e/modules/temperature/main";
}
 }
 
+group { name: "e/gadget/thermal/main";
+   alias: "e/gadget/thermal/main_vert";
+   images.image: "therm_content.png" COMP;
+   images.image: "therm_shadow.png" COMP;
+   images.image: "therm_shine.png" COMP;
+   script {
+public message(Msg_Type:type, id, ...) {
+   if ((type == MSG_FLOAT) && (id == 1)) {
+  new Float:val;
+  val = getfarg(2);
+  set_drag(PART:"temp_top", 0.0, val);
+   }
+}
+   }
+   parts {
+  part { name: "base"; type: SPACER;
+ description { state: "default" 0.0;
+aspect: (80 / 160) (80 / 160);
+aspect_preference: BOTH;
+ }
+  }
+  part { name: "shadow";
+ description { state: "default" 0.0;
+rel1.to: "base";
+rel2.to: "base";
+image.normal: "therm_shadow.png";
+ }
+  }
+   part { name: "temp";
+ clip_to: "temp_clip";
+ description { state: "default" 0.0;
+rel1.to: "base";
+rel2.to: "base";
+image.normal: "therm_content.png";
+ }
+  }
+  part { name: "overlay";
+ description { state: "default" 0.0;
+rel1.to: "base";
+rel2.to: "base";
+image.normal: "therm_shine.png";
+ }
+  }
+  part { name: "fade_clip"; type: RECT;
+ description { state: "default" 0.0;
+rel1.to_x: "base";
+rel2.to_x: "base";
+color: 255 255 255 255;
+ }
+ description { state: "faded" 0.0;
+color: 255 255 255 128;
+ }
+  }
+  part { name: "temp_clip"; type: RECT;
+ clip_to: "fade_clip";
+ description { state: "default" 0.0;
+rel1.to_x: "base";
+rel2.to_x: "base";
+rel1.to_y: "temp_top";
+ }
+  }
+  part { name: "temp_top"; type: SPACER;
+ dragable.x: 0 0 0;
+ dragable.y: -1 1 0;
+ dragable.confine: "temp_limit";
+ description { state: "default" 0.0;
+ }
+  }
+  part { name: "temp_limit"; type: SPACER;
+ description { state: "default" 0.0;
+rel1.to_x: "base";
+rel2.to_x: "base";
+rel1.relative: 0.0 0.1;
+rel2.relative: 1.0 0.9;
+ }
+  }
+  part { name: "over"; type: RECT;
+ description { state: "default" 0.0;
+rel1.to_x: "base";
+rel2.to_x: "base";
+color: 0 0 0 0;
+ }
+  }
+   }
+   programs {
+  program {
+ signal: "e,state,known"; source: "e";
+ action: STATE_SET "default" 0.0;
+ target: "fade_clip";
+  }
+  program {
+ signal: "e,state,unknown"; source: "e";
+ action: STATE_SET "faded" 0.0;
+ target: "fade_clip";
+  }
+   }
+}
 

-- 

[EGIT] [core/efl] master 01/01: ecore_anim: set the tick thread's fds CLOEXEC

[Derek Foreman]

derekf pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=599cdc93fa69dd54e132aec65cdda313db0133c6

commit 599cdc93fa69dd54e132aec65cdda313db0133c6
Author: Derek Foreman 
Date:   Wed Jul 12 13:01:43 2017 -0500

ecore_anim: set the tick thread's fds CLOEXEC

If we don't set them CLOEXEC then they end up in the fd space of every
client Enlightenment launches, allowing any client to write to them
and mess with animator timings or freeze the compositor.
---
 src/lib/ecore/ecore_anim.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/lib/ecore/ecore_anim.c b/src/lib/ecore/ecore_anim.c
index 47282c7801..d3b4400ae8 100644
--- a/src/lib/ecore/ecore_anim.c
+++ b/src/lib/ecore/ecore_anim.c
@@ -397,6 +397,8 @@ _timer_tick_begin(void)
 int fds[2];
 
 if (pipe(fds) != 0) return;
+eina_file_close_on_exec(fds[0], EINA_TRUE);
+eina_file_close_on_exec(fds[1], EINA_TRUE);
 timer_fd_read = fds[0];
 timer_fd_write = fds[1];
 if (getenv("ECORE_ANIMATOR_SKIP")) tick_skip = EINA_TRUE;

-- 

[EGIT] [core/efl] master 01/01: efl-wl: initialize variable

[Mike Blumenkrantz]

discomfitor pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=46f024bbe3542a73957aae0562e4b2dbd1213335

commit 46f024bbe3542a73957aae0562e4b2dbd1213335
Author: Mike Blumenkrantz 
Date:   Wed Jul 12 13:41:23 2017 -0400

efl-wl: initialize variable

CID 1377573
---
 src/lib/efl_wl/efl_wl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/efl_wl/efl_wl.c b/src/lib/efl_wl/efl_wl.c
index 76db17eea5..c3a37e821d 100644
--- a/src/lib/efl_wl/efl_wl.c
+++ b/src/lib/efl_wl/efl_wl.c
@@ -1002,7 +1002,7 @@ static Eina_Bool
 data_device_selection_read(void *d, Ecore_Fd_Handler *fdh)
 {
Comp_Data_Device_Source *ds = d;
-   int len;
+   int len = -1;
 
do
  {

-- 

Re: [E-devel] EFL 1.20.0 beta 2

[Stefan Schmidt]

Hello.

On 07/12/2017 12:01 PM, Stefan Schmidt wrote:

Hello.

On 07/12/2017 02:49 AM, William L. Thomson Jr. wrote:

On Tue, 11 Jul 2017 23:51:54 +0200
Stefan Schmidt  wrote:


Second beta release for the 1.20 release cycle. Please give it some
good testing

**Download**

http://download.enlightenment.org/rel/libs/efl/efl-1.20.0-beta2.tar.gz
1a845c6cfdb139d25bc29d7bfdbc15bcf7d246aad2d1f6be3218f7925cfd7078

http://download.enlightenment.org/rel/libs/efl/efl-1.20.0-beta2.tar.xz
b0f33bc39b28ea13c2581326b2544f8a75935f0c877ba2db790531021764f82b


Failed to build with same issue as beta1. Which I thought was fixed?


I was under the same impression. That this was fixed.


make[4]: *** No rule to make target 'lib/efl_wl/copiedfromweston.x',
needed by ' lib/efl_wl/libefl_wl.la'.  Stop.

  * ERROR: dev-libs/efl-1.20.0_beta2::os-xtoo failed (compile phase):
  *   emake failed


I was able to reproduce this here now. Will ahve a look to get this fixed.


Fixed now.

http://git.enlightenment.org/core/efl.git/commit/?id=44b36e6697ce3fcde71e909867c7c02851653b04

regards
Stefan Schmidt

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[EGIT] [core/efl] master 01/01: build: efl_wl: make sure we have the two files for efl_wl included

[Stefan Schmidt]

stefan pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=44b36e6697ce3fcde71e909867c7c02851653b04

commit 44b36e6697ce3fcde71e909867c7c02851653b04
Author: Stefan Schmidt 
Date:   Wed Jul 12 18:56:47 2017 +0200

build: efl_wl: make sure we have the two files  for efl_wl included

These two files coming in via EXTRA_DIST have not been included becuase
they have been living inside an ifdef which would only have them
included in a dist when configured with wayland enabled. We always want
to have these files in the dist though. Building for wayland out of a
tarball release works now again.

Problem reported by William L. Thomson Jr.
---
 src/Makefile.am| 2 +-
 src/Makefile_efl_wl.am | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/Makefile.am b/src/Makefile.am
index 10eba0771e..b3cced6e3d 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -175,7 +175,7 @@ dist-hook:
@mkdir -p $(distdir)/lib/evas/common/evas_op_mask 
$(distdir)/lib/evas/common/evas_op_mul
@mkdir -p $(distdir)/lib/evas/common/evas_op_sub 
$(distdir)/lib/evas/filters/blur
@mkdir -p $(distdir)/static_libs/http-parser/contrib 
$(distdir)/bindings/luajit/eina
-   @mkdir -p $(distdir)/wayland_protocol
+   @mkdir -p $(distdir)/wayland_protocol $(distdir)/lib/efl_wl/
@mkdir -p $(distdir)/modules/evas/engines/software_generic/filters/blur
for F in $(EXTRA_DIST2); do cp -f $(srcdir)/$$F $(distdir)/$$F; done
 
diff --git a/src/Makefile_efl_wl.am b/src/Makefile_efl_wl.am
index 270c99fc0a..aae58ff780 100644
--- a/src/Makefile_efl_wl.am
+++ b/src/Makefile_efl_wl.am
@@ -46,8 +46,8 @@ bin_efl_wl_efl_wl_test_stack_CPPFLAGS = \
 @EFL_WL_CFLAGS@ \
 @ELEMENTARY_CFLAGS@
 
+endif
+
 EXTRA_DIST2 += \
 lib/efl_wl/copiedfromweston.x \
 lib/efl_wl/x11.x
-
-endif

-- 

Re: [E-devel] Work items towards 1.20

[Stephen Houston]

Yep. Understand. Just figured I'd throw it out there since it will need to
be backported to this release and others anyway...

On Wed, Jul 12, 2017, 11:18 AM Stefan Schmidt 
wrote:

> Hello.
>
> On 07/12/2017 04:17 PM, Stephen Houston wrote:
> > Sorry that I have missed bringing this up before:
> > https://phab.enlightenment.org/T4996
> >
> > This has been around for a while... I have the code and it is simple:
> > in elm_image_file_set, if the file extension is .desktop, then create an
> > Efreet_Desktop *desktop object and do the following:
> > const char *path = NULL, *key = NULL;
> > char buf[4096];
> > if (!desktop->icon)
> >path = NULL;
> >  else if (strncmp(desktop->icon, "/", 1) &&
> > !ecore_file_exists(desktop->icon))
> >{
> >   clamp = (4 * round((double)ic->inst->size/4));
> >   path = efreet_icon_path_find(e_config->icon_theme,
> > desktop->icon, clamp);
> >   if (!path)
> > {
> >if (e_util_strcmp(e_config->icon_theme, "hicolor"))
> >  path = efreet_icon_path_find("hicolor",
> desktop->icon,
> > clamp);
> > }
> >}
> >  else if (ecore_file_exists(desktop->icon))
> >{
> >   path = desktop->icon;
> >}
> >  if (!path && desktop->icon)
> >{
> >   snprintf(buf, sizeof(buf), "e/icons/%s", desktop->icon);
> >   if
> > (eina_list_count(e_theme_collection_items_find("base/theme/icons", buf)))
> > {
> >path = e_theme_edje_file_get("base/theme/icons", buf);
> >k = buf;
> > }
> >   else
> > {
> >path = e_theme_edje_file_get("base/theme/icons",
> > "e/icons/unknown");
> >k =  "e/icons/unknown";
> > }
> >}
> >  else if (!path && !desktop->icon)
> >{
> >   path = e_theme_edje_file_get("base/theme/icons",
> > "e/icons/unknown");
> >   k = "e/icons/unknown";
> >}
> >  if (path && desktop->icon && !k)
> >{
> >   len = strlen(desktop->icon);
> >   if ((len > 4) && (!strcasecmp(desktop->icon + len - 4,
> > ".edj")))
> > k = "icon";
> >}
> > Then just set the path and key.  The e_theme_edje* stuff of course would
> be
> > substituted with elm theme stuff of course.
> > No need for anything special in image_file_get as the path and key set in
> > file_set would return normally.
> >
> > This would allow a TON of redundant code throughout E and potentially
> other
> > places to be removed and elm_icon to fully replace e_icon.  I'm also sure
> > this would be helpful for other apps that would have a need to load a
> > .desktop's image.
> >
> > This would be very simple to add to elm_image_file_set, with the catch
> > being it probably should be backported to other efl releases as well.  I
> > really think this is a necessary functionality that should exist and is
> > warranted.  With the simplicity of adding the code, if someone who is
> more
> > familiar with the current layout of the eo and elm stuff and who is more
> > familiar with backporting than I am would apply this, I think it is very
> > necessary.
> >
> > Again, sorry for the late notice.  Thoughts?
>
> Right now we are looking at showstopper bugs that would block a release.
> Not at new features suitable for re-factoring parts of the code base.
>
> I have nothing against the idea and getting rid of code duplication is a
> good goal as well, but I do not think we should start this now, so late
> in the stabilization schedule.
>
> regards
> Stefan Schmidt
>
>
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[EGIT] [core/efl] master 01/01: edje_edit: fix source generation

[Andrii Kroitor]

lorddrew pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=5f021bbfcfdaafda9bcc0e0be29d7aa21035ccd8

commit 5f021bbfcfdaafda9bcc0e0be29d7aa21035ccd8
Author: Andrii Kroitor 
Date:   Wed Jul 12 19:21:15 2017 +0300

edje_edit: fix source generation
---
 src/lib/edje/edje_edit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/edje/edje_edit.c b/src/lib/edje/edje_edit.c
index 83f0cfa480..15da38971b 100644
--- a/src/lib/edje/edje_edit.c
+++ b/src/lib/edje/edje_edit.c
@@ -14378,7 +14378,7 @@ _edje_generate_source_state_map(Edje *ed,
  for (i = 0; i < pd->map.colors_count; ++i)
{
   if ((pd->map.colors[i]->r != 255) || (pd->map.colors[i]->g 
!= 255) ||
-  (pd->map.colors[i]->b != 255) || (pd->map.colors[i]->b 
!= 255))
+  (pd->map.colors[i]->b != 255) || (pd->map.colors[i]->a 
!= 255))
 BUF_APPENDF(I6 "color: %d %d %d %d %d;\n", 
pd->map.colors[i]->idx,
 pd->map.colors[i]->r, pd->map.colors[i]->g,
 pd->map.colors[i]->b, pd->map.colors[i]->a);

-- 

Re: [E-devel] Work items towards 1.20

[Stefan Schmidt]

Hello.

On 07/12/2017 04:17 PM, Stephen Houston wrote:

Sorry that I have missed bringing this up before:
https://phab.enlightenment.org/T4996

This has been around for a while... I have the code and it is simple:
in elm_image_file_set, if the file extension is .desktop, then create an
Efreet_Desktop *desktop object and do the following:
const char *path = NULL, *key = NULL;
char buf[4096];
if (!desktop->icon)
   path = NULL;
 else if (strncmp(desktop->icon, "/", 1) &&
!ecore_file_exists(desktop->icon))
   {
  clamp = (4 * round((double)ic->inst->size/4));
  path = efreet_icon_path_find(e_config->icon_theme,
desktop->icon, clamp);
  if (!path)
{
   if (e_util_strcmp(e_config->icon_theme, "hicolor"))
 path = efreet_icon_path_find("hicolor", desktop->icon,
clamp);
}
   }
 else if (ecore_file_exists(desktop->icon))
   {
  path = desktop->icon;
   }
 if (!path && desktop->icon)
   {
  snprintf(buf, sizeof(buf), "e/icons/%s", desktop->icon);
  if
(eina_list_count(e_theme_collection_items_find("base/theme/icons", buf)))
{
   path = e_theme_edje_file_get("base/theme/icons", buf);
   k = buf;
}
  else
{
   path = e_theme_edje_file_get("base/theme/icons",
"e/icons/unknown");
   k =  "e/icons/unknown";
}
   }
 else if (!path && !desktop->icon)
   {
  path = e_theme_edje_file_get("base/theme/icons",
"e/icons/unknown");
  k = "e/icons/unknown";
   }
 if (path && desktop->icon && !k)
   {
  len = strlen(desktop->icon);
  if ((len > 4) && (!strcasecmp(desktop->icon + len - 4,
".edj")))
k = "icon";
   }
Then just set the path and key.  The e_theme_edje* stuff of course would be
substituted with elm theme stuff of course.
No need for anything special in image_file_get as the path and key set in
file_set would return normally.

This would allow a TON of redundant code throughout E and potentially other
places to be removed and elm_icon to fully replace e_icon.  I'm also sure
this would be helpful for other apps that would have a need to load a
.desktop's image.

This would be very simple to add to elm_image_file_set, with the catch
being it probably should be backported to other efl releases as well.  I
really think this is a necessary functionality that should exist and is
warranted.  With the simplicity of adding the code, if someone who is more
familiar with the current layout of the eo and elm stuff and who is more
familiar with backporting than I am would apply this, I think it is very
necessary.

Again, sorry for the late notice.  Thoughts?


Right now we are looking at showstopper bugs that would block a release. 
Not at new features suitable for re-factoring parts of the code base.


I have nothing against the idea and getting rid of code duplication is a 
good goal as well, but I do not think we should start this now, so late 
in the stabilization schedule.


regards
Stefan Schmidt

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] EFL 1.20.0 beta 2

[Andrew Williams]

On Linux and on OS X the scrollbars in Elementary now jump when dragged so
that the top of the bar is under the cursor. This happened in the last 2
days as far as I can tell.

Andy

On Wed, 12 Jul 2017 at 14:12 Jean Guyomarc'h 
wrote:

> Hi,
>
> I haven't tested the beta2 on osx, but it was "fine" (except the infamous
> segfault when ending a graphical program) during alpha phase.
> I'll try to have a look during the week, but since my hardware is dying,
> build times are terrible, which make development harder.
>
> Jean
>
> On Wed, Jul 12, 2017 at 12:50 PM, Andrew Williams 
> wrote:
>
> > Hi,
> >
> > Have people been testing on OS X in the last week? I just updated to
> master
> > (almost the same as beta2?) and I see many new issues / regressions. Will
> > document them in tickets and link here later.
> >
> > Thanks,
> > Andy
> > On Wed, 12 Jul 2017 at 11:02, Stefan Schmidt 
> > wrote:
> >
> > > Hello.
> > >
> > > On 07/12/2017 02:49 AM, William L. Thomson Jr. wrote:
> > > > On Tue, 11 Jul 2017 23:51:54 +0200
> > > > Stefan Schmidt  wrote:
> > > >
> > > >> Second beta release for the 1.20 release cycle. Please give it some
> > > >> good testing
> > > >>
> > > >> **Download**
> > > >>
> > > >> http://download.enlightenment.org/rel/libs/efl/efl-1.20.0-
> > beta2.tar.gz
> > > >> 1a845c6cfdb139d25bc29d7bfdbc15bcf7d246aad2d1f6be3218f7925cfd7078
> > > >>
> > > >> http://download.enlightenment.org/rel/libs/efl/efl-1.20.0-
> > beta2.tar.xz
> > > >> b0f33bc39b28ea13c2581326b2544f8a75935f0c877ba2db790531021764f82b
> > > >
> > > > Failed to build with same issue as beta1. Which I thought was fixed?
> > >
> > > I was under the same impression. That this was fixed.
> > >
> > > > make[4]: *** No rule to make target 'lib/efl_wl/copiedfromweston.x',
> > > > needed by ' lib/efl_wl/libefl_wl.la'.  Stop.
> > > >
> > > >   * ERROR: dev-libs/efl-1.20.0_beta2::os-xtoo failed (compile phase):
> > > >   *   emake failed
> > >
> > > I was able to reproduce this here now. Will ahve a look to get this
> > fixed.
> > >
> > > regards
> > > Stefan Schmidt
> > >
> > >
> > > 
> > --
> > > Check out the vibrant tech community on one of the world's most
> > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> > > ___
> > > enlightenment-devel mailing list
> > > enlightenment-devel@lists.sourceforge.net
> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> > >
> > --
> > http://andywilliams.me
> > http://ajwillia.ms
> > 
> > --
> > Check out the vibrant tech community on one of the world's most
> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> > ___
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >
>
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
-- 
http://andywilliams.me
http://ajwillia.ms
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] ssh broken

[Stefan Schmidt]

Hello.

On 07/12/2017 01:39 PM, Kai Huuhko wrote:

2017-07-11 23:18 GMT+03:00 Stefan Schmidt :

Hello.


On 07/11/2017 10:00 PM, Davide Andreoli wrote:


2017-07-11 21:47 GMT+02:00 Stefan Schmidt :


Hello.


On 07/11/2017 07:23 PM, Davide Andreoli wrote:


2017-07-11 16:35 GMT+02:00 Stefan Schmidt :

Hello.



On 07/11/2017 12:21 PM, Stefan Schmidt wrote:

Hello.



On 07/11/2017 11:37 AM, Stefan Schmidt wrote:




On 07/10/2017 09:24 PM, Davide Andreoli wrote:

2017-07-10 15:33 GMT+02:00 Mike Blumenkrantz <


michael.blumenkra...@gmail.com

[EGIT] [core/efl] master 06/09: efl-wl: return if pipe reading fails in x11 bridge

[Mike Blumenkrantz]

discomfitor pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=bad0d9dbd677087895cf09ca4108f4c7c28fc621

commit bad0d9dbd677087895cf09ca4108f4c7c28fc621
Author: Mike Blumenkrantz 
Date:   Wed Jul 12 12:00:52 2017 -0400

efl-wl: return if pipe reading fails in x11 bridge

CID 1377526, 1377534
---
 src/lib/efl_wl/x11.x | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/lib/efl_wl/x11.x b/src/lib/efl_wl/x11.x
index f33bdcedc6..4538e7e24d 100644
--- a/src/lib/efl_wl/x11.x
+++ b/src/lib/efl_wl/x11.x
@@ -254,6 +254,7 @@ x11_pipe_read(void *data, Ecore_Fd_Handler *fdh)
 free(buf);
 _incr_update(p, 0);
 eina_hash_del_by_key(pipes, >win);
+return ECORE_CALLBACK_RENEW;
  }
if (len == INCR_CHUNK_SIZE)
  {

-- 

[EGIT] [core/efl] master 05/09: efl-wl: check returns in x11 selection request handler

[Mike Blumenkrantz]

discomfitor pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=7c80d82f25fbf3b56f131038483baeb6844fa646

commit 7c80d82f25fbf3b56f131038483baeb6844fa646
Author: Mike Blumenkrantz 
Date:   Wed Jul 12 12:00:52 2017 -0400

efl-wl: check returns in x11 selection request handler

CID 1377518
---
 src/lib/efl_wl/x11.x | 14 --
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/src/lib/efl_wl/x11.x b/src/lib/efl_wl/x11.x
index 892b167d35..f33bdcedc6 100644
--- a/src/lib/efl_wl/x11.x
+++ b/src/lib/efl_wl/x11.x
@@ -342,9 +342,19 @@ x11_selection_request(void *d EINA_UNUSED, int t 
EINA_UNUSED, Ecore_X_Event_Sele
 {
int fds[2];
 
+   if (socketpair(AF_UNIX, (SOCK_STREAM | SOCK_CLOEXEC), 0, fds) < 
0)
+ {
+EINA_LOG_ERR("socketpair failed!\n");
+continue;
+ }
+   if (fcntl(fds[0], F_SETFL, O_NONBLOCK) < 0)
+ {
+close(fds[0]);
+close(fds[1]);
+EINA_LOG_ERR("NONBLOCK for socketpair failed!\n");
+continue;
+ }
p = calloc(1, sizeof(Pipe));
-   socketpair(AF_UNIX, (SOCK_STREAM | SOCK_CLOEXEC), 0, fds);
-   fcntl(fds[0], F_SETFL, O_NONBLOCK);
p->fdh = ecore_main_fd_handler_add(fds[0], ECORE_FD_READ, 
x11_pipe_read, p, NULL, NULL);
p->win = ev->requestor;
p->source = source;

-- 

[EGIT] [core/efl] master 09/09: efl-wl: change x11 atom name var to normal char*

[Mike Blumenkrantz]

discomfitor pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=1cc9748c613e6f99580567614822d3aee8f75b7a

commit 1cc9748c613e6f99580567614822d3aee8f75b7a
Author: Mike Blumenkrantz 
Date:   Wed Jul 12 12:00:52 2017 -0400

efl-wl: change x11 atom name var to normal char*
---
 src/lib/efl_wl/x11.x | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/efl_wl/x11.x b/src/lib/efl_wl/x11.x
index 49bc0560a9..cc567990ba 100644
--- a/src/lib/efl_wl/x11.x
+++ b/src/lib/efl_wl/x11.x
@@ -341,7 +341,7 @@ x11_selection_request(void *d EINA_UNUSED, int t 
EINA_UNUSED, Ecore_X_Event_Sele
  }
else
  {
-const char *name;
+char *name;
 Pipe *p;
 
 name = ecore_x_atom_name_get(ev->target);

-- 

[EGIT] [core/efl] master 03/09: efl-wl: check return of ecore_main_fd_handler_fd_get

[Mike Blumenkrantz]

discomfitor pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=c6f41d8e10515f214e6a27237e927280e4bb3957

commit c6f41d8e10515f214e6a27237e927280e4bb3957
Author: Mike Blumenkrantz 
Date:   Wed Jul 12 12:00:52 2017 -0400

efl-wl: check return of ecore_main_fd_handler_fd_get

CID 1377541, 1377546, 1377519, 1377529, 1377543
---
 src/lib/efl_wl/efl_wl.c | 10 --
 src/lib/efl_wl/x11.x| 19 +--
 2 files changed, 21 insertions(+), 8 deletions(-)

diff --git a/src/lib/efl_wl/efl_wl.c b/src/lib/efl_wl/efl_wl.c
index 99509deda5..a119b9c735 100644
--- a/src/lib/efl_wl/efl_wl.c
+++ b/src/lib/efl_wl/efl_wl.c
@@ -395,8 +395,11 @@ tiler_new(void)
 static inline void
 fdh_del(Ecore_Fd_Handler *fdh)
 {
+   int fd;
if (!fdh) return;
-   close(ecore_main_fd_handler_fd_get(fdh));
+   fd = ecore_main_fd_handler_fd_get(fdh);
+   if (fd >= 0)
+ close(fd);
ecore_main_fd_handler_del(fdh);
 }
 
@@ -1004,8 +1007,11 @@ data_device_selection_read(void *d, Ecore_Fd_Handler 
*fdh)
do
  {
 unsigned char buf[2048];
+int fd;
 
-len = read(ecore_main_fd_handler_fd_get(fdh), buf, sizeof(buf));
+fd = ecore_main_fd_handler_fd_get(fdh);
+if (fd < 0) break;
+len = read(fd, buf, sizeof(buf));
 if (len > 0)
   {
  if (!ds->reader_data)
diff --git a/src/lib/efl_wl/x11.x b/src/lib/efl_wl/x11.x
index 75a1da7b96..892b167d35 100644
--- a/src/lib/efl_wl/x11.x
+++ b/src/lib/efl_wl/x11.x
@@ -25,7 +25,9 @@ typedef struct
 static void
 _pipe_free(Pipe *p)
 {
-   close(ecore_main_fd_handler_fd_get(p->fdh));
+   int fd = ecore_main_fd_handler_fd_get(p->fdh);
+   if (fd >= 0)
+ close(fd);
ecore_main_fd_handler_del(p->fdh);
eina_binbuf_free(p->buf);
free(p);
@@ -57,9 +59,11 @@ x11_offer_write(void *data, Ecore_Fd_Handler *fdh)
 
if (ecore_main_fd_handler_active_get(fdh, ECORE_FD_WRITE))
  {
-len = write(ecore_main_fd_handler_fd_get(fdh),
-eina_binbuf_string_get(dt->source->reader_data) + 
dt->offset,
-eina_binbuf_length_get(dt->source->reader_data) - 
dt->offset);
+int fd = ecore_main_fd_handler_fd_get(fdh);
+if (fd >= 0)
+  len = write(fd,
+  eina_binbuf_string_get(dt->source->reader_data) + 
dt->offset,
+  eina_binbuf_length_get(dt->source->reader_data) - 
dt->offset);
 if (len > 0) dt->offset += len;
  }
 
@@ -237,11 +241,14 @@ static Eina_Bool
 x11_pipe_read(void *data, Ecore_Fd_Handler *fdh)
 {
Pipe *p = data;
-   ssize_t len;
+   ssize_t len = -1;
unsigned char *buf;
+   int fd;
 
buf = malloc(INCR_CHUNK_SIZE);
-   len = read(ecore_main_fd_handler_fd_get(fdh), (void*)buf, INCR_CHUNK_SIZE);
+   fd = ecore_main_fd_handler_fd_get(fdh);
+   if (fd >= 0)
+ len = read(fd, (void*)buf, INCR_CHUNK_SIZE);
if (len < 0)
  {
 free(buf);

-- 

[EGIT] [core/efl] master 08/09: efl-wl: free atom name when sending selection

[Mike Blumenkrantz]

discomfitor pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=9940cabd13f5afd9dbf1fd496123f894ad13c57a

commit 9940cabd13f5afd9dbf1fd496123f894ad13c57a
Author: Mike Blumenkrantz 
Date:   Wed Jul 12 12:00:52 2017 -0400

efl-wl: free atom name when sending selection

CID 1377542
---
 src/lib/efl_wl/x11.x | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/lib/efl_wl/x11.x b/src/lib/efl_wl/x11.x
index f5220c1428..49bc0560a9 100644
--- a/src/lib/efl_wl/x11.x
+++ b/src/lib/efl_wl/x11.x
@@ -99,6 +99,7 @@ x11_send_send(Comp_Data_Device_Source *source, const char* 
mime_type, int32_t fd
Ecore_X_Atom t, sel = ECORE_X_ATOM_SELECTION_CLIPBOARD;
Comp_Data_Device_Transfer *dt;
Ecore_Window win;
+   char *name;
win = 
ecore_evas_window_get(ecore_evas_ecore_evas_get(source->seat->c->evas));
if (type == COMP_DATA_DEVICE_OFFER_TYPE_DND)
  sel = ECORE_X_ATOM_SELECTION_XDND;
@@ -112,7 +113,9 @@ x11_send_send(Comp_Data_Device_Source *source, const char* 
mime_type, int32_t fd
dt->type = type;
dt->fdh = ecore_main_fd_handler_add(fd, 0, x11_offer_write, dt, NULL, NULL);
dt->source = source;
-   dt->mime_type = eina_stringshare_add(ecore_x_atom_name_get(t));
+   name = ecore_x_atom_name_get(t);
+   dt->mime_type = eina_stringshare_add(name);
+   free(name);
dt->source->transfers = eina_inlist_append(dt->source->transfers, 
EINA_INLIST_GET(dt));
xconvertselection(ecore_x_display_get(), sel, t, comp_dnd_atom, win, 
ecore_x_current_time_get());
 }

-- 

[EGIT] [core/efl] master 07/09: efl-wl: free x11 pipe read buf on read fail

[Mike Blumenkrantz]

discomfitor pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=39c70f1fa7dca2c8b914736a1dbde8a12b2e4b03

commit 39c70f1fa7dca2c8b914736a1dbde8a12b2e4b03
Author: Mike Blumenkrantz 
Date:   Wed Jul 12 12:00:52 2017 -0400

efl-wl: free x11 pipe read buf on read fail

CID 1377520
---
 src/lib/efl_wl/x11.x | 8 ++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/lib/efl_wl/x11.x b/src/lib/efl_wl/x11.x
index 4538e7e24d..f5220c1428 100644
--- a/src/lib/efl_wl/x11.x
+++ b/src/lib/efl_wl/x11.x
@@ -273,8 +273,12 @@ x11_pipe_read(void *data, Ecore_Fd_Handler *fdh)
 return ECORE_CALLBACK_RENEW;
  }
if (len)
- p->buf = eina_binbuf_manage_new(buf, len, 0);
-   _incr_upload(p);
+ {
+p->buf = eina_binbuf_manage_new(buf, len, 0);
+_incr_upload(p);
+ }
+   else
+ free(buf);
if (p->incr)
  ecore_main_fd_handler_active_set(p->fdh, 0);
else

-- 

[EGIT] [core/efl] master 04/09: efl-wl: mmap byte for nul terminator in keymap string

[Mike Blumenkrantz]

discomfitor pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=74bd1d4000d82d1cd66a639ddabfbe13573ef881

commit 74bd1d4000d82d1cd66a639ddabfbe13573ef881
Author: Mike Blumenkrantz 
Date:   Wed Jul 12 12:00:52 2017 -0400

efl-wl: mmap byte for nul terminator in keymap string

CID 1377545
---
 src/lib/efl_wl/efl_wl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/efl_wl/efl_wl.c b/src/lib/efl_wl/efl_wl.c
index a119b9c735..76db17eea5 100644
--- a/src/lib/efl_wl/efl_wl.c
+++ b/src/lib/efl_wl/efl_wl.c
@@ -3493,7 +3493,7 @@ seat_keymap_update(Comp_Seat *s)
eina_file_unlink(file);
eina_tmpstr_del(file);
s->kbd.keymap_mem =
- mmap(NULL, s->kbd.keymap_mem_size,
+ mmap(NULL, s->kbd.keymap_mem_size + 1,
PROT_READ | PROT_WRITE, MAP_SHARED, s->kbd.keymap_fd, 0);
 
memcpy(s->kbd.keymap_mem, str, s->kbd.keymap_mem_size);

-- 

[EGIT] [core/efl] master 01/09: efl_wl: error and cleanup on CLOEXEC fail

[Mike Blumenkrantz]

discomfitor pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=98e14ef3d496c2665395f8d8cf84b35a47739154

commit 98e14ef3d496c2665395f8d8cf84b35a47739154
Author: Mike Blumenkrantz 
Date:   Wed Jul 12 12:00:52 2017 -0400

efl_wl: error and cleanup on CLOEXEC fail

CID 1377530, 1377531
---
 src/lib/efl_wl/efl_wl.c | 13 +
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/src/lib/efl_wl/efl_wl.c b/src/lib/efl_wl/efl_wl.c
index d1760a39e5..6f9dd313d2 100644
--- a/src/lib/efl_wl/efl_wl.c
+++ b/src/lib/efl_wl/efl_wl.c
@@ -3466,10 +3466,15 @@ seat_keymap_update(Comp_Seat *s)
str = xkb_map_get_as_string(s->kbd.keymap);
s->kbd.keymap_mem_size = strlen(str) + 1;
s->kbd.keymap_fd = eina_file_mkstemp("comp-keymapXX", );
-   {
-  int flags = fcntl(s->kbd.keymap_fd, F_GETFD);
-  fcntl(s->kbd.keymap_fd, F_SETFD, flags | FD_CLOEXEC);
-   }
+   if (!eina_file_close_on_exec(s->kbd.keymap_fd, 1))
+ {
+EINA_LOG_ERR("Failed to set CLOEXEC on fd %d\n", s->kbd.keymap_fd);
+close(s->kbd.keymap_fd);
+s->kbd.keymap_fd = -1;
+xkb_state_unref(s->kbd.state);
+s->kbd.state = NULL;
+return;
+ }
ftruncate(s->kbd.keymap_fd, s->kbd.keymap_mem_size);
eina_file_unlink(file);
eina_tmpstr_del(file);

-- 

[EGIT] [core/efl] master 02/09: efl_wl: check mkstemp return

[Mike Blumenkrantz]

discomfitor pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=8c2afaf251d5b65c82723be22ba2c23913343bef

commit 8c2afaf251d5b65c82723be22ba2c23913343bef
Author: Mike Blumenkrantz 
Date:   Wed Jul 12 12:00:52 2017 -0400

efl_wl: check mkstemp return

CID 1377533
---
 src/lib/efl_wl/efl_wl.c | 8 
 1 file changed, 8 insertions(+)

diff --git a/src/lib/efl_wl/efl_wl.c b/src/lib/efl_wl/efl_wl.c
index 6f9dd313d2..99509deda5 100644
--- a/src/lib/efl_wl/efl_wl.c
+++ b/src/lib/efl_wl/efl_wl.c
@@ -3466,6 +3466,14 @@ seat_keymap_update(Comp_Seat *s)
str = xkb_map_get_as_string(s->kbd.keymap);
s->kbd.keymap_mem_size = strlen(str) + 1;
s->kbd.keymap_fd = eina_file_mkstemp("comp-keymapXX", );
+   if (s->kbd.keymap_fd < 0)
+ {
+EINA_LOG_ERR("mkstemp failed!\n");
+s->kbd.keymap_fd = -1;
+xkb_state_unref(s->kbd.state);
+s->kbd.state = NULL;
+return;
+ }
if (!eina_file_close_on_exec(s->kbd.keymap_fd, 1))
  {
 EINA_LOG_ERR("Failed to set CLOEXEC on fd %d\n", s->kbd.keymap_fd);

-- 

[EGIT] [core/efl] master 01/01: efl_wl: Fix resource leak

[Christopher Michael]

devilhorns pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=627fc6842adc64da7ee0d4ac25f5bb1ea1aab1ea

commit 627fc6842adc64da7ee0d4ac25f5bb1ea1aab1ea
Author: Chris Michael 
Date:   Wed Jul 12 11:24:37 2017 -0400

efl_wl: Fix resource leak

Coverity reports that 'name' is leaked here, so free the return
ecore_x_atom_name_get.

Fixes CID1377537

@fix

Signed-off-by: Chris Michael 
---
 src/lib/efl_wl/x11.x | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/lib/efl_wl/x11.x b/src/lib/efl_wl/x11.x
index f554b8eaaf..75a1da7b96 100644
--- a/src/lib/efl_wl/x11.x
+++ b/src/lib/efl_wl/x11.x
@@ -350,6 +350,7 @@ x11_selection_request(void *d EINA_UNUSED, int t 
EINA_UNUSED, Ecore_X_Event_Sele
eina_hash_add(pipes, >win, p);
break;
 }
+   free(name);
  }
return ECORE_CALLBACK_RENEW;
 }

-- 

[EGIT] [core/efl] master 01/01: elput: Fix resource leak

[Christopher Michael]

devilhorns pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=c45da5c138dca2b9ff26143572c8aee76736a9e7

commit c45da5c138dca2b9ff26143572c8aee76736a9e7
Author: Chris Michael 
Date:   Wed Jul 12 11:02:16 2017 -0400

elput: Fix resource leak

Coverity CID1377539 says that we leak the eldbus reply here when we
error out, so be sure to cleanup 'reply'

Fixes CID1377539

@fix

Signed-off-by: Chris Michael 
---
 src/lib/elput/elput_logind.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/lib/elput/elput_logind.c b/src/lib/elput/elput_logind.c
index e93633edc1..aa9006e5bb 100644
--- a/src/lib/elput/elput_logind.c
+++ b/src/lib/elput/elput_logind.c
@@ -196,7 +196,10 @@ _logind_session_object_path_get(Elput_Manager *em)
 goto message_fail;
  }
if (!eldbus_message_arguments_get(reply, "o", ))
+ {
+eldbus_message_unref(reply);
 goto message_fail;
+ }
 
em->dbus.path = strdup(str);
eldbus_message_unref(reply);

-- 

[EGIT] [core/efl] master 01/01: ecore: Fix coverity resource leak

[Christopher Michael]

devilhorns pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=cd615667d56ae5c165ff61a6b56798d078999ada

commit cd615667d56ae5c165ff61a6b56798d078999ada
Author: Chris Michael 
Date:   Wed Jul 12 10:58:28 2017 -0400

ecore: Fix coverity resource leak

Coverity CID1377544 reports that poller is leaked here if we error out
and return null. As poller is created with calloc, we should free it
before returning.

@fix

Signed-off-by: Chris Michael 
---
 src/lib/ecore/ecore_poller.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/lib/ecore/ecore_poller.c b/src/lib/ecore/ecore_poller.c
index b5567bc5e6..b46f0dfcaf 100644
--- a/src/lib/ecore/ecore_poller.c
+++ b/src/lib/ecore/ecore_poller.c
@@ -254,6 +254,7 @@ ecore_poller_add(Ecore_Poller_Type type EINA_UNUSED,
if (!func)
  {
 ERR("callback function must be set up for an object of class: '%s'", 
MY_CLASS_NAME);
+free(poller);
 return NULL;
  }
 

-- 

Re: [E-devel] Work items towards 1.20

[Stephen Houston]

Sorry that I have missed bringing this up before:
https://phab.enlightenment.org/T4996

This has been around for a while... I have the code and it is simple:
in elm_image_file_set, if the file extension is .desktop, then create an
Efreet_Desktop *desktop object and do the following:
const char *path = NULL, *key = NULL;
char buf[4096];
if (!desktop->icon)
  path = NULL;
else if (strncmp(desktop->icon, "/", 1) &&
!ecore_file_exists(desktop->icon))
  {
 clamp = (4 * round((double)ic->inst->size/4));
 path = efreet_icon_path_find(e_config->icon_theme,
desktop->icon, clamp);
 if (!path)
   {
  if (e_util_strcmp(e_config->icon_theme, "hicolor"))
path = efreet_icon_path_find("hicolor", desktop->icon,
clamp);
   }
  }
else if (ecore_file_exists(desktop->icon))
  {
 path = desktop->icon;
  }
if (!path && desktop->icon)
  {
 snprintf(buf, sizeof(buf), "e/icons/%s", desktop->icon);
 if
(eina_list_count(e_theme_collection_items_find("base/theme/icons", buf)))
   {
  path = e_theme_edje_file_get("base/theme/icons", buf);
  k = buf;
   }
 else
   {
  path = e_theme_edje_file_get("base/theme/icons",
"e/icons/unknown");
  k =  "e/icons/unknown";
   }
  }
else if (!path && !desktop->icon)
  {
 path = e_theme_edje_file_get("base/theme/icons",
"e/icons/unknown");
 k = "e/icons/unknown";
  }
if (path && desktop->icon && !k)
  {
 len = strlen(desktop->icon);
 if ((len > 4) && (!strcasecmp(desktop->icon + len - 4,
".edj")))
   k = "icon";
  }
Then just set the path and key.  The e_theme_edje* stuff of course would be
substituted with elm theme stuff of course.
No need for anything special in image_file_get as the path and key set in
file_set would return normally.

This would allow a TON of redundant code throughout E and potentially other
places to be removed and elm_icon to fully replace e_icon.  I'm also sure
this would be helpful for other apps that would have a need to load a
.desktop's image.

This would be very simple to add to elm_image_file_set, with the catch
being it probably should be backported to other efl releases as well.  I
really think this is a necessary functionality that should exist and is
warranted.  With the simplicity of adding the code, if someone who is more
familiar with the current layout of the eo and elm stuff and who is more
familiar with backporting than I am would apply this, I think it is very
necessary.

Again, sorry for the late notice.  Thoughts?

On Wed, Jul 12, 2017 at 4:33 AM Stefan Schmidt 
wrote:

> Hello.
>
> This comes really late this time. Sorry for that.
>
> This is the list of items that need fixing before we can go ahead and
> release 1.20. Help is very much appreciated on them. If you think one is
> not critical or another one is speak up before it is to late.
>
> Phab show stopper:
> --
> infinite loop on evas free is back
> https://phab.enlightenment.org/T5680
>
> image rendering fails with no feedback and then never renders
> https://phab.enlightenment.org/T5678
>
> buffer rendering regression
> https://phab.enlightenment.org/T5595
>
> macOS graphical programs crash on termination
> https://phab.enlightenment.org/T5245
>
> Screen does not unblank...
> https://phab.enlightenment.org/T5462
>
>
> Are there any other issues that need to be promoted to a showstopper?
>
>
> Coverity high impact:
> -
> 1377545 Out-of-bounds write Memory - corruptions
> /src/lib/efl_wl/efl_wl.c
>
> 1377544 Resource leak
> /src/lib/ecore/ecore_poller.c
>
> 1377542 Resource leak
> /src/lib/efl_wl/x11.x
>
> 1377539 Resource leak
> /src/lib/elput/elput_logind.c
>
> 1377537 Resource leak
> /src/lib/efl_wl/x11.x
>
> 1377526 Use after free Memory - illegal accesses
> /src/lib/efl_wl/x11.x
>
> 1377520 Resource leak
> /src/lib/efl_wl/x11.x
>
> 1374646 Resource leak
> /src/modules/evas/engines/gl_...vas_ector_gl_image_buffer.c
>
> 1374645 Resource leak
> /src/modules/evas/engines/gl_generic/evas_ector_gl_buffer.c
>
> 1365656 Resource leak
> /src/lib/evas/canvas/efl_canvas_image.c
>
>
> ABI/API report:
> ---
> https://abi-laboratory.pro/tracker/timeline/efl/index.html
> o People need to review this one
> o I need to prepare our own report to compare against the one from
> abi-laboratory
>
> regards
> Stefan Schmidt
>
>
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> enlightenment-devel mailing 

Re: [E-devel] EFL 1.20.0 beta 2

[Jean Guyomarc'h]

Hi,

I haven't tested the beta2 on osx, but it was "fine" (except the infamous
segfault when ending a graphical program) during alpha phase.
I'll try to have a look during the week, but since my hardware is dying,
build times are terrible, which make development harder.

Jean

On Wed, Jul 12, 2017 at 12:50 PM, Andrew Williams 
wrote:

> Hi,
>
> Have people been testing on OS X in the last week? I just updated to master
> (almost the same as beta2?) and I see many new issues / regressions. Will
> document them in tickets and link here later.
>
> Thanks,
> Andy
> On Wed, 12 Jul 2017 at 11:02, Stefan Schmidt 
> wrote:
>
> > Hello.
> >
> > On 07/12/2017 02:49 AM, William L. Thomson Jr. wrote:
> > > On Tue, 11 Jul 2017 23:51:54 +0200
> > > Stefan Schmidt  wrote:
> > >
> > >> Second beta release for the 1.20 release cycle. Please give it some
> > >> good testing
> > >>
> > >> **Download**
> > >>
> > >> http://download.enlightenment.org/rel/libs/efl/efl-1.20.0-
> beta2.tar.gz
> > >> 1a845c6cfdb139d25bc29d7bfdbc15bcf7d246aad2d1f6be3218f7925cfd7078
> > >>
> > >> http://download.enlightenment.org/rel/libs/efl/efl-1.20.0-
> beta2.tar.xz
> > >> b0f33bc39b28ea13c2581326b2544f8a75935f0c877ba2db790531021764f82b
> > >
> > > Failed to build with same issue as beta1. Which I thought was fixed?
> >
> > I was under the same impression. That this was fixed.
> >
> > > make[4]: *** No rule to make target 'lib/efl_wl/copiedfromweston.x',
> > > needed by ' lib/efl_wl/libefl_wl.la'.  Stop.
> > >
> > >   * ERROR: dev-libs/efl-1.20.0_beta2::os-xtoo failed (compile phase):
> > >   *   emake failed
> >
> > I was able to reproduce this here now. Will ahve a look to get this
> fixed.
> >
> > regards
> > Stefan Schmidt
> >
> >
> > 
> --
> > Check out the vibrant tech community on one of the world's most
> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> > ___
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >
> --
> http://andywilliams.me
> http://ajwillia.ms
> 
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] ssh broken

[Kai Huuhko]

2017-07-11 23:18 GMT+03:00 Stefan Schmidt :
> Hello.
>
>
> On 07/11/2017 10:00 PM, Davide Andreoli wrote:
>>
>> 2017-07-11 21:47 GMT+02:00 Stefan Schmidt :
>>
>>> Hello.
>>>
>>>
>>> On 07/11/2017 07:23 PM, Davide Andreoli wrote:
>>>
 2017-07-11 16:35 GMT+02:00 Stefan Schmidt :

 Hello.
>
>
> On 07/11/2017 12:21 PM, Stefan Schmidt wrote:
>
> Hello.
>>
>>
>> On 07/11/2017 11:37 AM, Stefan Schmidt wrote:
>>
>>
>>>
>>> On 07/10/2017 09:24 PM, Davide Andreoli wrote:
>>>
>>> 2017-07-10 15:33 GMT+02:00 Mike Blumenkrantz <

 michael.blumenkra...@gmail.com
  :
>>
>>
>
   Hi,

   I've been getting this error for some time now on one of my
 machines
   when I
   try to do git/ssh operations:

   ssh_exchange_identification: Connection closed by remote host
   fatal: Could not read from remote repository.

   Please make sure you have the correct access rights
   and the repository exists.

   Others have been experiencing this issue as well, so it seems
 to
 be
   a new
   issue with server configuration.


 Same here, I cannot perform any git operation anymore


>>> My situation is that I can pull and push to git just fine. But in the
>>> exact same shell I get a error when trying to log into a shell of our
>>> server.
>>>
>>> stefan@work efl (master) $ ssh download.enlightenment.org
>>> ssh_exchange_identification: Connection closed by remote host
>>>
>>> This blocks the upload of any efl beta2 tarballs right now.
>>> I will try to debug this a bit further on my end. As far as I can do
>>> that.
>>>
>>>
>> It looks like we have two different problems here:
>>
>> 1) Git access over ssh does not work. Zmike(?) as well as Dave seem to
>> have this problem. A lot of people are pushing and pulling without a
>> problem at the same time though.
>>
>>
> Zmike, Dave could you retry? The problem Marcel and I had is fixed, not
> sure of that would help your scenario at all. See below.
>
>
 Yes, works for me now, I can git-pull again
 Thanks for the fix

>>>
>>> This puzzles me a bit. Normally a git pull would not need to go through
>>> the proxy. Do you have by any chance git.e.org also configured to go
>>> through the proxy command?
>>>
>>> For example by having this in your local ssh_config
>>>
>>> Host *.enlightenment.org
>>>User 
>>>ProxyCommand ssh -q e5v1.enlightenment.org -W %h:%p
>>>
>>> but no extra white list entry for git like:
>>>
>>> Host git.enlightenment.org
>>>User git
>>>ProxyCommand none
>>>
>>>
>>> ?
>>>
>>
>> This is my ssh config file:
>>
>> Host e? e?.enlightenment.org e?v*.enlightenment.org
>>User davemds
>>ProxyCommand none
>>
>> Host *.enlightenment.org
>>User davemds
>>ProxyCommand ssh -q e5v1.enlightenment.org -W %h:%p
>>
>>
>> I really cannot remember where I copied this from, I think somewhere
>> in the wiki, but I cannot find it anymore
>
>
> https://phab.enlightenment.org/w/hosting/ssh/

I just subscribed to this page. Could we also have the developer
facing infra changes announced on a mailing list? Maybe a separate
list, or use e-announce? Even if they're temporary, would be great to
get a short note about them.

>
> So you are missing the git.e.org white list entry which explains why it
> failed for git over ssh for you and is now fixed. That makes more sense now.
> :)
>
> regards
> Stefan Schmidt
>
>
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] EFL 1.20.0 beta 2

[Andrew Williams]

Hi,

Have people been testing on OS X in the last week? I just updated to master
(almost the same as beta2?) and I see many new issues / regressions. Will
document them in tickets and link here later.

Thanks,
Andy
On Wed, 12 Jul 2017 at 11:02, Stefan Schmidt  wrote:

> Hello.
>
> On 07/12/2017 02:49 AM, William L. Thomson Jr. wrote:
> > On Tue, 11 Jul 2017 23:51:54 +0200
> > Stefan Schmidt  wrote:
> >
> >> Second beta release for the 1.20 release cycle. Please give it some
> >> good testing
> >>
> >> **Download**
> >>
> >> http://download.enlightenment.org/rel/libs/efl/efl-1.20.0-beta2.tar.gz
> >> 1a845c6cfdb139d25bc29d7bfdbc15bcf7d246aad2d1f6be3218f7925cfd7078
> >>
> >> http://download.enlightenment.org/rel/libs/efl/efl-1.20.0-beta2.tar.xz
> >> b0f33bc39b28ea13c2581326b2544f8a75935f0c877ba2db790531021764f82b
> >
> > Failed to build with same issue as beta1. Which I thought was fixed?
>
> I was under the same impression. That this was fixed.
>
> > make[4]: *** No rule to make target 'lib/efl_wl/copiedfromweston.x',
> > needed by ' lib/efl_wl/libefl_wl.la'.  Stop.
> >
> >   * ERROR: dev-libs/efl-1.20.0_beta2::os-xtoo failed (compile phase):
> >   *   emake failed
>
> I was able to reproduce this here now. Will ahve a look to get this fixed.
>
> regards
> Stefan Schmidt
>
>
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
-- 
http://andywilliams.me
http://ajwillia.ms
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] API mentioned in doc but is inexistant

[Vincent Torri]

hello

in eina_inarray.h, eina_inarray_lookup and  eina_inarray_lookup_sorted
are mentioned in doc, but a grep tells that these functions do not
exist at all

maybe it is worth removing them from the doc

Vincent

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Evas_Event_Mouse_Move missing data

[Andrew Williams]

Hi,

It may be specific to OS X as that's what I was using yesterday - will get
more info if I can today.

Thanks,
Andy
On Wed, 12 Jul 2017 at 03:48, Jean-Philippe André  wrote:

> I couldn't reproduce that with today's git.
> Can you provide me with some test code? Maybe in EDI?
>
> 2017-07-12 4:57 GMT+09:00 Andrew Williams :
>
> > Hi,
> >
> > Thanks for the help - I will test it shortly.
> > Unfortunately I have also found that Mouse_Wheel data structures always
> > seem to have canvas.x and .y are always 0 :(
> >
> > I assume this is a different issue as it's broken on git master.
> >
> > Thanks,
> > Andy
> >
> > On Mon, 10 Jul 2017 at 08:04 Jean-Philippe André 
> > wrote:
> >
> > > Hi Andy,
> > >
> > > 2017-07-10 11:56 GMT+09:00 Jean-Philippe André :
> > >
> > > >
> > > >
> > > >
> > > > 2017-07-09 2:19 GMT+09:00 Andrew Williams :
> > > >
> > > >> Hi,
> > > >>
> > > >> I was trying to use a mouse_move event earlier but found it was
> > missing
> > > >> critical info:
> > > >>
> > > >> event->buttons
> > > >> event->prev.canvas.x
> > > >> event->prev.canvas.y
> > > >>
> > > >> Were always 0.
> > > >> Am I missing something obvious? I had to code up the gesture using
> > > >> mouse_down/up to capture the missing info instead...
> > > >>
> > > >
> > > > I'll have a look, thanks.
> > > >
> > >
> > > I assume you set up a callback on the window or the evas? And you had
> no
> > > problems with normal objects?
> > > If that is so, then this should be fixed. Please let me know if you are
> > > still having issues.
> > >
> > > --
> > > Jean-Philippe André
> > >
> > > 
> > --
> > > Check out the vibrant tech community on one of the world's most
> > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> > > ___
> > > enlightenment-devel mailing list
> > > enlightenment-devel@lists.sourceforge.net
> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> > >
> > --
> > http://andywilliams.me
> > http://ajwillia.ms
> > 
> > --
> > Check out the vibrant tech community on one of the world's most
> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> > ___
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >
>
>
>
> --
> Jean-Philippe André
>
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
-- 
http://andywilliams.me
http://ajwillia.ms
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] EFL 1.20.0 beta 2

[Stefan Schmidt]

Hello.

On 07/12/2017 02:49 AM, William L. Thomson Jr. wrote:

On Tue, 11 Jul 2017 23:51:54 +0200
Stefan Schmidt  wrote:


Second beta release for the 1.20 release cycle. Please give it some
good testing

**Download**

http://download.enlightenment.org/rel/libs/efl/efl-1.20.0-beta2.tar.gz
1a845c6cfdb139d25bc29d7bfdbc15bcf7d246aad2d1f6be3218f7925cfd7078

http://download.enlightenment.org/rel/libs/efl/efl-1.20.0-beta2.tar.xz
b0f33bc39b28ea13c2581326b2544f8a75935f0c877ba2db790531021764f82b


Failed to build with same issue as beta1. Which I thought was fixed?


I was under the same impression. That this was fixed.


make[4]: *** No rule to make target 'lib/efl_wl/copiedfromweston.x',
needed by ' lib/efl_wl/libefl_wl.la'.  Stop.

  * ERROR: dev-libs/efl-1.20.0_beta2::os-xtoo failed (compile phase):
  *   emake failed


I was able to reproduce this here now. Will ahve a look to get this fixed.

regards
Stefan Schmidt

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[EGIT] [core/efl] master 01/01: edje: give proper width to entry's cursor according to its theme

[Youngbok Shin]

jpeg pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=e81be3a664737dd5743552578e832656e9c5b87e

commit e81be3a664737dd5743552578e832656e9c5b87e
Author: Youngbok Shin 
Date:   Wed Jul 12 18:37:50 2017 +0900

edje: give proper width to entry's cursor according to its theme

Summary:
evas_object_textblock_cursor_geometry_get() always return 0 as cursor's 
width
for BEFORE type cursor. It casued different cursor width when cursor_fg2 
was shown.
The cursor_fg and cursor_fg2 must have same width according to its min 
width.

Also, the patch will enclose code for cursor_fg2 by cursor_fg code.
It is used when only there is cursor_fg.
@fix

Test Plan:
1. Give bigger width to entry's cursor by changing its theme.
2. See the width cursor_fg, cursor_fg2 when there is [LTR text + RTL text].

Reviewers: raster, herdsman, cedric, jpeg

Subscribers: stefan_schmidt

Differential Revision: https://phab.enlightenment.org/D4798
---
 src/lib/edje/edje_entry.c | 57 ---
 1 file changed, 34 insertions(+), 23 deletions(-)

diff --git a/src/lib/edje/edje_entry.c b/src/lib/edje/edje_entry.c
index 8dcc2af1ec..2b3d6449fb 100644
--- a/src/lib/edje/edje_entry.c
+++ b/src/lib/edje/edje_entry.c
@@ -2966,18 +2966,18 @@ _edje_entry_real_part_init(Edje *ed, Edje_Real_Part *rp)
 evas_object_clip_set(en->cursor_fg, evas_object_clip_get(rp->object));
 evas_object_pass_events_set(en->cursor_fg, EINA_TRUE);
 _edje_subobj_register(ed, en->cursor_fg);
- }
-   /* A proxy to the main cursor. */
-   if (rp->part->cursor_mode == EDJE_ENTRY_CURSOR_MODE_BEFORE)
- {
-en->cursor_fg2 = evas_object_image_add(ed->base->evas);
-evas_object_image_source_set(en->cursor_fg2, en->cursor_fg);
-evas_object_image_fill_set(en->cursor_fg2, 0, 0, 1, 1);
-evas_object_smart_member_add(en->cursor_fg2, ed->obj);
-evas_object_stack_above(en->cursor_fg2, rp->object);
-evas_object_clip_set(en->cursor_fg2, evas_object_clip_get(rp->object));
-evas_object_pass_events_set(en->cursor_fg2, EINA_TRUE);
-_edje_subobj_register(en->ed, en->cursor_fg2);
+
+/* A proxy to the main cursor. */
+if (rp->part->cursor_mode == EDJE_ENTRY_CURSOR_MODE_BEFORE)
+  {
+ en->cursor_fg2 = edje_object_add(ed->base->evas);
+ edje_object_file_set(en->cursor_fg2, ed->path, rp->part->source4);
+ evas_object_smart_member_add(en->cursor_fg2, ed->obj);
+ evas_object_stack_above(en->cursor_fg2, rp->object);
+ evas_object_clip_set(en->cursor_fg2, 
evas_object_clip_get(rp->object));
+ evas_object_pass_events_set(en->cursor_fg2, EINA_TRUE);
+ _edje_subobj_register(ed, en->cursor_fg2);
+  }
  }
 
evas_object_textblock_legacy_newline_set(rp->object, EINA_TRUE);
@@ -3152,27 +3152,38 @@ _edje_entry_real_part_configure(Edje *ed, 
Edje_Real_Part *rp)
 if (hh < 1) hh = 1;
 if (en->cursor_bg)
   {
+ int bg_w = ww;
+
+ if (rp->part->cursor_mode == EDJE_ENTRY_CURSOR_MODE_BEFORE)
+   edje_object_size_min_restricted_calc(en->cursor_bg, _w, 
NULL, ww, 0);
+
  evas_object_move(en->cursor_bg, x + xx, y + yy);
- evas_object_resize(en->cursor_bg, ww, hh);
+ evas_object_resize(en->cursor_bg, bg_w, hh);
   }
 if (en->cursor_fg)
   {
+ int fg_w = ww;
+
+ if (rp->part->cursor_mode == EDJE_ENTRY_CURSOR_MODE_BEFORE)
+   edje_object_size_min_restricted_calc(en->cursor_fg, _w, 
NULL, ww, 0);
+
  evas_object_move(en->cursor_fg, x + xx, y + yy);
- evas_object_resize(en->cursor_fg, ww, hh);
-  }
-if (en->cursor_fg2)
-  {
+
  if (bidi_cursor)
{
-  evas_object_image_fill_set(en->cursor_fg2, 0, 0, ww, hh / 2);
-  evas_object_move(en->cursor_fg2, x + xx2, y + yy2 + (hh / 
2));
-  evas_object_resize(en->cursor_fg, ww, hh / 2);
-  evas_object_resize(en->cursor_fg2, ww, hh / 2);
-  evas_object_show(en->cursor_fg2);
+  if (en->cursor_fg2)
+{
+   evas_object_move(en->cursor_fg2, x + xx2, y + yy2 + (hh 
/ 2));
+   evas_object_resize(en->cursor_fg, fg_w, hh / 2);
+   evas_object_resize(en->cursor_fg2, fg_w, hh / 2);
+   evas_object_show(en->cursor_fg2);
+}
}
  else
{
-  evas_object_hide(en->cursor_fg2);
+  evas_object_resize(en->cursor_fg, fg_w, hh);
+  if (en->cursor_fg2)
+

[E-devel] Work items towards 1.20

[Stefan Schmidt]

Hello.

This comes really late this time. Sorry for that.

This is the list of items that need fixing before we can go ahead and 
release 1.20. Help is very much appreciated on them. If you think one is 
not critical or another one is speak up before it is to late.


Phab show stopper:
--
infinite loop on evas free is back
https://phab.enlightenment.org/T5680

image rendering fails with no feedback and then never renders
https://phab.enlightenment.org/T5678

buffer rendering regression
https://phab.enlightenment.org/T5595

macOS graphical programs crash on termination
https://phab.enlightenment.org/T5245

Screen does not unblank...
https://phab.enlightenment.org/T5462


Are there any other issues that need to be promoted to a showstopper?


Coverity high impact:
-
1377545 Out-of-bounds write Memory - corruptions
/src/lib/efl_wl/efl_wl.c

1377544 Resource leak
/src/lib/ecore/ecore_poller.c

1377542 Resource leak
/src/lib/efl_wl/x11.x

1377539 Resource leak
/src/lib/elput/elput_logind.c

1377537 Resource leak
/src/lib/efl_wl/x11.x

1377526 Use after free Memory - illegal accesses
/src/lib/efl_wl/x11.x

1377520 Resource leak
/src/lib/efl_wl/x11.x

1374646 Resource leak
/src/modules/evas/engines/gl_...vas_ector_gl_image_buffer.c

1374645 Resource leak
/src/modules/evas/engines/gl_generic/evas_ector_gl_buffer.c

1365656 Resource leak
/src/lib/evas/canvas/efl_canvas_image.c


ABI/API report:
---
https://abi-laboratory.pro/tracker/timeline/efl/index.html
o People need to review this one
o I need to prepare our own report to compare against the one from 
abi-laboratory


regards
Stefan Schmidt

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[EGIT] [core/efl] master 01/01: evas_smart: Fix evas_smart_callback_description_find

[Jean-Philippe ANDRÉ]

jpeg pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=9513fed85ea00637745362a5a34083da3d230f22

commit 9513fed85ea00637745362a5a34083da3d230f22
Author: Jean-Philippe Andre 
Date:   Wed Jul 12 17:19:28 2017 +0900

evas_smart: Fix evas_smart_callback_description_find

bsearch was returnign a cb** not a cb*

Fixes T4540
---
 src/lib/evas/canvas/evas_smart.c | 8 ++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/lib/evas/canvas/evas_smart.c b/src/lib/evas/canvas/evas_smart.c
index ccd9a69855..a070c98a95 100644
--- a/src/lib/evas/canvas/evas_smart.c
+++ b/src/lib/evas/canvas/evas_smart.c
@@ -326,7 +326,11 @@ _evas_smart_cb_description_cmp_search(const void *p1, 
const void *p2)
 const Evas_Smart_Cb_Description *
 evas_smart_cb_description_find(const Evas_Smart_Cb_Description_Array *a, const 
char *name)
 {
+   const Evas_Smart_Cb_Description **found = NULL;
+
if (!a->array) return NULL;
-   return bsearch(name, a->array, a->size, sizeof(Evas_Smart_Cb_Description *),
-  _evas_smart_cb_description_cmp_search);
+   found = bsearch(name, a->array, a->size, sizeof(Evas_Smart_Cb_Description 
*),
+   _evas_smart_cb_description_cmp_search);
+
+   return found ? (*found) : NULL;
 }

-- 

[EGIT] [core/efl] master 03/03: po files - update lines/comments

[Carsten Haitzler]

raster pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=a11e374166d1355c1249ecd3f7d1673059730c91

commit a11e374166d1355c1249ecd3f7d1673059730c91
Author: Carsten Haitzler (Rasterman) 
Date:   Wed Jul 12 15:45:17 2017 +0900

po files - update lines/comments
---
 po/ca.po| 48 
 po/cs.po| 48 
 po/de.po| 48 
 po/el.po| 48 
 po/eo.po| 48 
 po/es.po| 48 
 po/fi.po| 48 
 po/fr.po| 48 
 po/gl.po| 48 
 po/hu.po| 48 
 po/it.po| 48 
 po/ja.po| 46 +++---
 po/ko.po| 46 +++---
 po/lt.po| 48 
 po/nl.po| 48 
 po/pl.po| 48 
 po/pt.po| 48 
 po/ru.po| 48 
 po/sl.po| 48 
 po/sr.po| 48 
 po/tr.po| 48 
 po/vi.po| 48 
 po/zh_CN.po | 48 
 23 files changed, 550 insertions(+), 550 deletions(-)

diff --git a/po/ca.po b/po/ca.po
index 32e8dcd5da..0f156f4e93 100644
--- a/po/ca.po
+++ b/po/ca.po
@@ -9,7 +9,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: Elementary\n"
 "Report-Msgid-Bugs-To: enlightenment-devel@lists.sourceforge.net\n"
-"POT-Creation-Date: 2017-06-28 12:12+0200\n"
+"POT-Creation-Date: 2017-07-11 17:19+0900\n"
 "PO-Revision-Date: 2015-02-10 09:34+\n"
 "Last-Translator: JoanColl \n"
 "Language-Team: Catalan\n"
@@ -240,33 +240,33 @@ msgstr "Imatges"
 msgid "Videos"
 msgstr "Vídeos"
 
-#: src/lib/elementary/elc_fileselector.c:1895
+#: src/lib/elementary/elc_fileselector.c:1919
 msgid "Up"
 msgstr "Amunt"
 
-#: src/lib/elementary/elc_fileselector.c:1909
+#: src/lib/elementary/elc_fileselector.c:1933
 msgid "Home"
 msgstr "Carpeta personal"
 
-#: src/lib/elementary/elc_fileselector.c:1928
+#: src/lib/elementary/elc_fileselector.c:1952
 msgid "Search"
 msgstr "Cerca"
 
-#: src/lib/elementary/elc_fileselector.c:2219
-#: src/lib/elementary/elm_entry.c:1715 src/lib/elementary/elm_entry.c:1740
-msgid "Cancel"
-msgstr "Cancel·la"
-
-#: src/lib/elementary/elc_fileselector.c:2229
+#: src/lib/elementary/elc_fileselector.c:2246
 msgid "OK"
 msgstr "Accepta"
 
+#: src/lib/elementary/elc_fileselector.c:2256
+#: src/lib/elementary/elm_entry.c:1732 src/lib/elementary/elm_entry.c:1757
+msgid "Cancel"
+msgstr "Cancel·la"
+
 #: src/lib/elementary/elc_hoversel.c:438 src/lib/elementary/efl_ui_button.c:278
 #: src/lib/elementary/efl_ui_check.c:212 src/lib/elementary/elm_gengrid.c:1470
-#: src/lib/elementary/elm_genlist.c:1743 src/lib/elementary/elm_list.c:2176
+#: src/lib/elementary/elm_genlist.c:1738 src/lib/elementary/elm_list.c:2176
 #: src/lib/elementary/efl_ui_radio.c:214
 #: src/lib/elementary/elm_segment_control.c:529
-#: src/lib/elementary/elm_spinner.c:1016 src/lib/elementary/elm_toolbar.c:2347
+#: src/lib/elementary/elm_spinner.c:1020 src/lib/elementary/elm_toolbar.c:2347
 msgid "State: Disabled"
 msgstr "Estat: desactivat"
 
@@ -429,23 +429,23 @@ msgstr "selector de dia"
 msgid "diskselector item"
 msgstr "selector de disc"
 
-#: src/lib/elementary/elm_entry.c:1705
+#: src/lib/elementary/elm_entry.c:1722
 msgid "Cut"
 msgstr "Retalla"
 
-#: src/lib/elementary/elm_entry.c:1708
+#: src/lib/elementary/elm_entry.c:1725
 msgid "Copy"
 msgstr "Copia"
 
-#: src/lib/elementary/elm_entry.c:1712 src/lib/elementary/elm_entry.c:1734
+#: src/lib/elementary/elm_entry.c:1729 src/lib/elementary/elm_entry.c:1751
 msgid "Paste"
 msgstr "Enganxa"
 
-#: src/lib/elementary/elm_entry.c:1727
+#: src/lib/elementary/elm_entry.c:1744
 msgid "Select"
 msgstr "Selecciona"
 
-#: src/lib/elementary/elm_entry.c:3814
+#: src/lib/elementary/elm_entry.c:3833
 msgid "Entry"
 msgstr "Entrada"
 
@@ -461,7 +461,7 @@ msgstr "Índex"
 msgid "Index Item"
 msgstr "Element d'índex"
 
-#: src/lib/elementary/elm_label.c:411
+#: src/lib/elementary/elm_label.c:405
 msgid "Label"
 msgstr "Etiqueta"
 
@@ -510,27 +510,27 @@ msgstr "Element de control del segment"
 msgid "slider"
 msgstr "control lliscant"
 
-#: src/lib/elementary/elm_spinner.c:1046
+#: 

[EGIT] [core/efl] master 02/03: ignore - add some build binary files to gitignore

[Carsten Haitzler]

raster pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=3610c9c74dc75779d7ae1f066435ac9289190e31

commit 3610c9c74dc75779d7ae1f066435ac9289190e31
Author: Carsten Haitzler (Rasterman) 
Date:   Wed Jul 12 15:44:51 2017 +0900

ignore - add some build binary files to gitignore
---
 .gitignore | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.gitignore b/.gitignore
index 47a8bb73cf..0cbcca20ee 100644
--- a/.gitignore
+++ b/.gitignore
@@ -77,6 +77,8 @@ Session.vim
 /src/modules/evas/engines/gl_common/shader_3d/evas_3d_shaders.x
 /src/scripts/eo/eo_debug
 /src/bin/ecore_con/efl_net_proxy_helper
+/src/bin/efl_wl/efl_wl_test
+/src/bin/efl_wl/efl_wl_test_stack
 
 #wayland generated protocol - some legacy headers will be ignored
 *-protocol.h

-- 

[EGIT] [core/efl] master 01/03: evas mouse in/out/move event fix to remove "invalid move"

[Carsten Haitzler]

raster pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=ea7dd2a9c29b96d9bc648feccb1270b4788529d6

commit ea7dd2a9c29b96d9bc648feccb1270b4788529d6
Author: Carsten Haitzler (Rasterman) 
Date:   Wed Jul 12 15:43:41 2017 +0900

evas mouse in/out/move event fix to remove "invalid move"

this should fix T5582 "properly" by emitting a move after an in only
if pointer x,y changed. this fixes rage and i hope still should handle
the original issue. let me know if it doesn't.

@fix
---
 src/lib/evas/canvas/evas_events.c | 60 +++
 1 file changed, 42 insertions(+), 18 deletions(-)

diff --git a/src/lib/evas/canvas/evas_events.c 
b/src/lib/evas/canvas/evas_events.c
index 82a040765c..e6e3efffc5 100644
--- a/src/lib/evas/canvas/evas_events.c
+++ b/src/lib/evas/canvas/evas_events.c
@@ -738,9 +738,13 @@ _evas_event_source_mouse_move_events(Evas_Object *eo_obj, 
Evas *eo_e,
 ev->action = EFL_POINTER_ACTION_IN;
 evas_object_event_callback_call(eo_child, child, 
EVAS_CALLBACK_MOUSE_IN, evt,
 event_id2, 
EFL_EVENT_POINTER_IN);
-ev->action = EFL_POINTER_ACTION_MOVE;
-evas_object_event_callback_call(eo_child, child, 
EVAS_CALLBACK_MOUSE_MOVE, evt,
-event_id2, 
EFL_EVENT_POINTER_MOVE);
+if ((ev->cur.x != ev->prev.x) &&
+(ev->cur.y != ev->prev.y))
+  {
+ ev->action = EFL_POINTER_ACTION_MOVE;
+ evas_object_event_callback_call(eo_child, child, 
EVAS_CALLBACK_MOUSE_MOVE, evt,
+ event_id2, 
EFL_EVENT_POINTER_MOVE);
+  }
 if (e->delete_me) break;
  }
 }
@@ -1224,9 +1228,13 @@ _evas_event_source_mouse_in_events(Evas_Object *eo_obj, 
Evas *eo_e,
  ev->action = EFL_POINTER_ACTION_IN;
  evas_object_event_callback_call(eo_child, child, 
EVAS_CALLBACK_MOUSE_IN, evt,
  event_id, EFL_EVENT_POINTER_IN);
- ev->action = EFL_POINTER_ACTION_MOVE;
- evas_object_event_callback_call(eo_child, child, 
EVAS_CALLBACK_MOUSE_MOVE, evt,
- event_id, EFL_EVENT_POINTER_MOVE);
+ if ((ev->cur.x != ev->prev.x) &&
+ (ev->cur.y != ev->prev.y))
+   {
+  ev->action = EFL_POINTER_ACTION_MOVE;
+  evas_object_event_callback_call(eo_child, child, 
EVAS_CALLBACK_MOUSE_MOVE, evt,
+  event_id, 
EFL_EVENT_POINTER_MOVE);
+   }
  if (e->delete_me || e->is_frozen) break;
   }
  }
@@ -1658,9 +1666,13 @@ _post_up_handle(Evas_Public_Data *e, Efl_Input_Pointer 
*parent_ev,
   ev->action = EFL_POINTER_ACTION_IN;
   evas_object_event_callback_call(eo_obj_itr, obj_itr, 
EVAS_CALLBACK_MOUSE_IN, evt,
   event_id, 
EFL_EVENT_POINTER_IN);
-  ev->action = EFL_POINTER_ACTION_MOVE;
-  evas_object_event_callback_call(eo_obj_itr, obj_itr, 
EVAS_CALLBACK_MOUSE_MOVE, evt,
-  event_id, 
EFL_EVENT_POINTER_MOVE);
+  if ((ev->cur.x != ev->prev.x) &&
+  (ev->cur.y != ev->prev.y))
+{
+   ev->action = EFL_POINTER_ACTION_MOVE;
+   evas_object_event_callback_call(eo_obj_itr, obj_itr, 
EVAS_CALLBACK_MOUSE_MOVE, evt,
+   event_id, 
EFL_EVENT_POINTER_MOVE);
+}
   if ((obj_itr->proxy->is_proxy) &&
   (obj_itr->proxy->src_events))
 _evas_event_source_mouse_in_events(eo_obj_itr, eo_e, evt, 
event_id);
@@ -2287,9 +2299,13 @@ _canvas_event_feed_mouse_move_internal(Evas_Public_Data 
*e, Efl_Input_Pointer_Da
ev->action = EFL_POINTER_ACTION_IN;
evas_object_event_callback_call(eo_obj, obj, 
EVAS_CALLBACK_MOUSE_IN, evt,
event_id, 
EFL_EVENT_POINTER_IN);
-   ev->action = EFL_POINTER_ACTION_MOVE;
-   evas_object_event_callback_call(eo_obj, obj, 
EVAS_CALLBACK_MOUSE_MOVE, evt,
-   event_id, 
EFL_EVENT_POINTER_MOVE);
+if ((ev->cur.x != ev->prev.x) &&
+(ev->cur.y != ev->prev.y))
+  {
+   

[EGIT] [core/efl] master 01/01: Theme: Don't display freq on the meter for cpuclock.

[Stephen 'Okra' Houston]

okra pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=1130d10852a341e66dffbee4e23f663c66a9c0c2

commit 1130d10852a341e66dffbee4e23f663c66a9c0c2
Author: Stephen 'Okra' Houston 
Date:   Wed Jul 12 01:24:43 2017 -0500

Theme: Don't display freq on the meter for cpuclock.
---
 data/elementary/themes/edc/cpufreq.edc | 16 
 1 file changed, 16 insertions(+)

diff --git a/data/elementary/themes/edc/cpufreq.edc 
b/data/elementary/themes/edc/cpufreq.edc
index c8a581ac54..fac534d78c 100644
--- a/data/elementary/themes/edc/cpufreq.edc
+++ b/data/elementary/themes/edc/cpufreq.edc
@@ -351,3 +351,19 @@ group { name: "e/modules/cpufreq/main";
   }
}
 }
+
+group { name: "e/gadget/cpuclock/main";
+   alias: "e/gadget/cpuclock/main_vert";
+   inherit: "e/modules/cpufreq/main";
+   parts {
+  part { name: "readout"; type: TEXT; mouse_events: 0;
+ scale: 1;
+ effect: SHADOW BOTTOM;
+ clip_to: "fade_clip";
+ description { state: "default" 0.0;
+visible: 0;
+ }
+  }
+   }
+}
+

-- 

[EGIT] [core/enlightenment] master 02/03: Sysinfo - Cpuclock: Add the left click info and right click config popup.

[Stephen 'Okra' Houston]

okra pushed a commit to branch master.

http://git.enlightenment.org/core/enlightenment.git/commit/?id=d03c254f5ea82ec75b9c33b392ca53ab3b1fbc76

commit d03c254f5ea82ec75b9c33b392ca53ab3b1fbc76
Author: Stephen 'Okra' Houston 
Date:   Wed Jul 12 01:08:34 2017 -0500

Sysinfo - Cpuclock: Add the left click info and right click config popup.
---
 src/modules/Makefile_sysinfo.mk|   1 +
 src/modules/sysinfo/cpuclock/cpuclock.c| 172 ++-
 src/modules/sysinfo/cpuclock/cpuclock.h|  22 +
 src/modules/sysinfo/cpuclock/cpuclock_config.c | 617 +
 src/modules/sysinfo/mod.c  |   3 +-
 src/modules/sysinfo/sysinfo.c  |   2 +
 src/modules/sysinfo/sysinfo.h  |   3 +
 7 files changed, 818 insertions(+), 2 deletions(-)

diff --git a/src/modules/Makefile_sysinfo.mk b/src/modules/Makefile_sysinfo.mk
index faf424776..9965321e3 100644
--- a/src/modules/Makefile_sysinfo.mk
+++ b/src/modules/Makefile_sysinfo.mk
@@ -25,6 +25,7 @@ src_modules_sysinfo_module_la_SOURCES = 
src/modules/sysinfo/mod.c \
  src/modules/sysinfo/cpuclock/cpuclock.h \
  src/modules/sysinfo/cpuclock/cpuclock.c \
  src/modules/sysinfo/cpuclock/cpuclock_sysfs.c \
+ src/modules/sysinfo/cpuclock/cpuclock_config.c \
  src/modules/sysinfo/cpumonitor/cpumonitor.h \
  src/modules/sysinfo/cpumonitor/cpumonitor.c \
  src/modules/sysinfo/cpumonitor/cpumonitor_config.c \
diff --git a/src/modules/sysinfo/cpuclock/cpuclock.c 
b/src/modules/sysinfo/cpuclock/cpuclock.c
index f93017509..394f262bf 100644
--- a/src/modules/sysinfo/cpuclock/cpuclock.c
+++ b/src/modules/sysinfo/cpuclock/cpuclock.c
@@ -120,7 +120,7 @@ _cpuclock_set_governor(const char *governor)
ecore_thread_run(_cpuclock_set_thread_governor, _cpuclock_set_thread_done, 
NULL, governor);
 }
 
-static void
+void
 _cpuclock_set_frequency(int frequency)
 {
char buf[4096];
@@ -259,6 +259,106 @@ _cpuclock_event_cb_powersave(void *data, int type, void 
*event)
return ECORE_CALLBACK_PASS_ON;
 }
 
+static Evas_Object *
+_cpuclock_configure_cb(Evas_Object *g)
+{
+   Instance *inst = evas_object_data_get(g, "Instance");
+
+   if (!sysinfo_config) return NULL;
+   if (inst->cfg->cpuclock.popup) return NULL;
+   return cpuclock_configure(inst);
+}
+
+static void
+_cpuclock_popup_dismissed(void *data, Evas_Object *obj, void *event_info 
EINA_UNUSED)
+{
+   Instance *inst = data;
+   E_FREE_FUNC(obj, evas_object_del);
+
+   inst->cfg->cpuclock.popup = NULL;
+   inst->cfg->cpuclock.popup_label = NULL;
+}
+
+static void
+_cpuclock_popup_deleted(void *data, Evas *e EINA_UNUSED, Evas_Object *obj 
EINA_UNUSED, void *event_info EINA_UNUSED)
+{
+   Instance *inst = data;
+   inst->cfg->cpuclock.popup = NULL;
+}
+
+static Evas_Object *
+_cpuclock_popup_create(Instance *inst)
+{
+   Evas_Object *popup, *box, *label;
+   double f = inst->cfg->cpuclock.status->cur_frequency;
+   char buf[100];
+
+   if (f < 100)
+ {
+f += 500;
+f /= 1000;
+ }
+   else
+ {
+f += 5;
+f /= 100;
+ }
+
+   popup = elm_ctxpopup_add(e_comp->elm);
+   elm_object_style_set(popup, "noblock");
+   evas_object_smart_callback_add(popup, "dismissed",
+  _cpuclock_popup_dismissed, inst);
+   evas_object_event_callback_add(popup, EVAS_CALLBACK_DEL,
+  _cpuclock_popup_deleted, inst);
+
+   box = elm_box_add(popup);
+   elm_box_horizontal_set(box, EINA_FALSE);
+   E_EXPAND(box); E_FILL(box);
+   elm_object_content_set(popup, box);
+   evas_object_show(box);
+
+   label = elm_label_add(box);
+   elm_object_style_set(label, "marker");
+   snprintf(buf, 100, "%s: %1.1f", _("Frequency"), f);
+   elm_object_text_set(label, buf);
+   elm_box_pack_end(box, label);
+   evas_object_show(label);
+   inst->cfg->cpuclock.popup_label = label;
+
+   e_gadget_util_ctxpopup_place(inst->o_main, popup,
+inst->cfg->cpuclock.o_gadget);
+   evas_object_show(popup);
+
+   return popup;
+}
+
+static void
+_cpuclock_mouse_down_cb(void *data, Evas *e EINA_UNUSED, Evas_Object *obj 
EINA_UNUSED, void *event_data)
+{
+   Evas_Event_Mouse_Down *ev = event_data;
+   Instance *inst = data;
+
+   if (ev->event_flags & EVAS_EVENT_FLAG_ON_HOLD) return;
+   if (ev->button != 3)
+ {
+if (inst->cfg->cpuclock.popup)
+  elm_ctxpopup_dismiss(inst->cfg->cpuclock.popup);
+else
+  inst->cfg->cpuclock.popup = _cpuclock_popup_create(inst);
+ }
+   else
+ {
+if (inst->cfg->cpuclock.popup)
+  elm_ctxpopup_dismiss(inst->cfg->cpuclock.popup);
+if (!sysinfo_config) return;
+ev->event_flags |= EVAS_EVENT_FLAG_ON_HOLD;
+if (inst->cfg->esm != E_SYSINFO_MODULE_CPUCLOCK)
+  

[EGIT] [core/enlightenment] master 03/03: Sysinfo: Update Cpuclock and Thermal to the powersave api.

[Stephen 'Okra' Houston]

okra pushed a commit to branch master.

http://git.enlightenment.org/core/enlightenment.git/commit/?id=2bbdd999ed91f1e078278feee3b9c5e930202b13

commit 2bbdd999ed91f1e078278feee3b9c5e930202b13
Author: Stephen 'Okra' Houston 
Date:   Wed Jul 12 01:24:03 2017 -0500

Sysinfo: Update Cpuclock and Thermal to the powersave api.
---
 src/modules/sysinfo/cpuclock/cpuclock.c | 8 +---
 src/modules/sysinfo/sysinfo.h   | 1 +
 src/modules/sysinfo/thermal/thermal.c   | 8 +++-
 3 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/src/modules/sysinfo/cpuclock/cpuclock.c 
b/src/modules/sysinfo/cpuclock/cpuclock.c
index 394f262bf..71dab70f6 100644
--- a/src/modules/sysinfo/cpuclock/cpuclock.c
+++ b/src/modules/sysinfo/cpuclock/cpuclock.c
@@ -9,6 +9,7 @@ struct _Thread_Config
 {
int interval;
Instance *inst;
+   E_Powersave_Sleeper *sleeper;
 };
 
 typedef struct _Pstate_Config Pstate_Config;
@@ -238,7 +239,6 @@ _cpuclock_event_cb_powersave(void *data, int type, void 
*event)
 eina_stringshare_del(inst->cfg->cpuclock.status->orig_governor);
 inst->cfg->cpuclock.status->orig_governor = NULL;
 break;
-
   case E_POWERSAVE_MODE_MEDIUM:
   case E_POWERSAVE_MODE_HIGH:
 if ((inst->cfg->cpuclock.powersave_governor) || (has_conservative))
@@ -249,8 +249,8 @@ _cpuclock_event_cb_powersave(void *data, int type, void 
*event)
_cpuclock_set_governor("conservative");
  break;
   }
-
   case E_POWERSAVE_MODE_EXTREME:
+  default:
 if (has_powersave)
   _cpuclock_set_governor("powersave");
 break;
@@ -831,7 +831,7 @@ _cpuclock_cb_frequency_check_main(void *data, Ecore_Thread 
*th)
 else
   _cpuclock_status_free(status);
 if (ecore_thread_check(th)) break;
-usleep((100.0 / 8.0) * (double)thc->interval);
+e_powersave_sleeper_sleep(thc->sleeper, thc->interval);
  }
 }
 
@@ -877,6 +877,7 @@ static void
 _cpuclock_cb_frequency_check_end(void *data, Ecore_Thread *th EINA_UNUSED)
 {
Thread_Config *thc = data;
+   e_powersave_sleeper_free(thc->sleeper);
E_FREE_FUNC(thc, free);
 }
 
@@ -894,6 +895,7 @@ _cpuclock_poll_interval_update(Instance *inst)
if (thc)
  {
 thc->inst = inst;
+   thc->sleeper = e_powersave_sleeper_new();
 thc->interval = inst->cfg->cpuclock.poll_interval;
 inst->cfg->cpuclock.frequency_check_thread =
   ecore_thread_feedback_run(_cpuclock_cb_frequency_check_main,
diff --git a/src/modules/sysinfo/sysinfo.h b/src/modules/sysinfo/sysinfo.h
index ae9a07981..06f06eaae 100644
--- a/src/modules/sysinfo/sysinfo.h
+++ b/src/modules/sysinfo/sysinfo.h
@@ -76,6 +76,7 @@ struct _Tempthread
const char *sensor_name;
const char *sensor_path;
void *extn;
+   E_Powersave_Sleeper *sleeper;
 #ifdef HAVE_EEZE
Eina_List *tempdevs;
 #endif
diff --git a/src/modules/sysinfo/thermal/thermal.c 
b/src/modules/sysinfo/thermal/thermal.c
index e9f670fd5..ddf0d7215 100644
--- a/src/modules/sysinfo/thermal/thermal.c
+++ b/src/modules/sysinfo/thermal/thermal.c
@@ -13,6 +13,7 @@ _thermal_thread_free(Tempthread *tth)
 #if defined(HAVE_EEZE)
EINA_LIST_FREE(tth->tempdevs, s) eina_stringshare_del(s);
 #endif
+   e_powersave_sleeper_free(tth->sleeper);
free(tth->extn);
free(tth);
 }
@@ -93,7 +94,11 @@ _thermal_check_sysctl(void *data, Ecore_Thread *th)
 temp = thermal_sysctl_get(tth);
 if (ptemp != temp) ecore_thread_feedback(th, (void *)((long)temp));
 ptemp = temp;
-usleep((100.0 / 8.0) * (double)tth->poll_interval);
+e_powersave_sleeper_sleep(tth->sleeper, tth->poll_interval);
+if (e_powersave_mode_get() == E_POWERSAVE_MODE_FREEZE)
+  usleep((100.0 / 800.0) * (double)tth->poll_interval);
+else
+  usleep((100.0 / 8.0) * (double)tth->poll_interval);
 if (ecore_thread_check(th)) break;
  }
 }
@@ -173,6 +178,7 @@ _thermal_config_updated(Instance *inst)
tth->poll_interval = inst->cfg->thermal.poll_interval;
tth->sensor_type = inst->cfg->thermal.sensor_type;
tth->inst = inst;
+   tth->sleeper = e_powersave_sleeper_new();
if (inst->cfg->thermal.sensor_name)
  tth->sensor_name = eina_stringshare_add(inst->cfg->thermal.sensor_name);
 

-- 

[EGIT] [core/enlightenment] master 01/03: Thermal config: Fix rounding and math issues when switching between units.

[Stephen 'Okra' Houston]

okra pushed a commit to branch master.

http://git.enlightenment.org/core/enlightenment.git/commit/?id=ae26e913caca459a0ee01f53548879786ec58d4e

commit ae26e913caca459a0ee01f53548879786ec58d4e
Author: Stephen 'Okra' Houston 
Date:   Tue Jul 11 21:41:05 2017 -0500

Thermal config: Fix rounding and math issues when switching between units.
---
 src/modules/sysinfo/thermal/thermal_config.c | 28 ++--
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/src/modules/sysinfo/thermal/thermal_config.c 
b/src/modules/sysinfo/thermal/thermal_config.c
index 737cd8ef4..afd2676e3 100644
--- a/src/modules/sysinfo/thermal/thermal_config.c
+++ b/src/modules/sysinfo/thermal/thermal_config.c
@@ -19,7 +19,7 @@ _update_high_temperature(void *data, Evas_Object *obj 
EINA_UNUSED, void *event_i
 {
Thermal_Config *tc = data;
Instance *inst = tc->inst;
-   int value = elm_slider_value_get(tc->high);
+   int value = (int)elm_slider_value_get(tc->high);
 
inst->cfg->thermal.high = value;
e_config_save_queue();
@@ -31,7 +31,7 @@ _update_low_temperature(void *data, Evas_Object *obj 
EINA_UNUSED, void *event_in
 {
Thermal_Config *tc = data;
Instance *inst = tc->inst;
-   int value = elm_slider_value_get(tc->low);
+   int value = (int)elm_slider_value_get(tc->low);
 
inst->cfg->thermal.low = value;
e_config_save_queue();
@@ -61,10 +61,10 @@ _units_changed(void *data, Evas_Object *obj, void 
*event_info EINA_UNUSED)
  {
 elm_slider_min_max_set(tc->low, 0, 200);
 elm_slider_min_max_set(tc->high, 0, 230);
-val = elm_slider_value_get(tc->low);
-elm_slider_value_set(tc->low, CEL_2_FAR(val));
-val = elm_slider_value_get(tc->high);
-elm_slider_value_set(tc->high, CEL_2_FAR(val));
+val = (int)elm_slider_value_get(tc->low);
+elm_slider_value_set(tc->low, ceil(CEL_2_FAR(val)));
+val = (int)elm_slider_value_get(tc->high);
+elm_slider_value_set(tc->high, ceil(CEL_2_FAR(val)));
 elm_slider_unit_format_set(tc->high, "%1.0f F");
 elm_slider_indicator_format_set(tc->high, "%1.0f F");
elm_slider_unit_format_set(tc->low, "%1.0f F");
@@ -72,20 +72,20 @@ _units_changed(void *data, Evas_Object *obj, void 
*event_info EINA_UNUSED)
  }
else
  {
-elm_slider_min_max_set(tc->low, 0, 95);
-elm_slider_min_max_set(tc->high, 0, 110);
-val = elm_slider_value_get(tc->low);
-elm_slider_value_set(tc->low, FAR_2_CEL(val));
-val = elm_slider_value_get(tc->high);
-elm_slider_value_set(tc->high, FAR_2_CEL(val));
+val = (int)elm_slider_value_get(tc->low);
+elm_slider_value_set(tc->low, ceil(FAR_2_CEL(val)));
+val = (int)elm_slider_value_get(tc->high);
+elm_slider_value_set(tc->high, ceil(FAR_2_CEL(val)));
 elm_slider_unit_format_set(tc->low, "%1.0f C");
 elm_slider_indicator_format_set(tc->low, "%1.0f C");
elm_slider_unit_format_set(tc->high, "%1.0f C");
 elm_slider_indicator_format_set(tc->high, "%1.0f C");
+elm_slider_min_max_set(tc->low, 0, 95);
+elm_slider_min_max_set(tc->high, 0, 110);
  }
-   val = elm_slider_value_get(tc->high);
+   val = (int)elm_slider_value_get(tc->high);
inst->cfg->thermal.high = val;
-   val = elm_slider_value_get(tc->low);
+   val = (int)elm_slider_value_get(tc->low);
inst->cfg->thermal.low = val;
e_config_save_queue();
_thermal_config_updated(inst);

--