Re: [E-devel] EFL 1.24 first abi checker results (beta2)

2020-04-27 Thread Xavi Artigas
Totally agreed. That's generated code, though.

Xavi

On Mon, 27 Apr 2020 at 19:15, Davide Andreoli 
wrote:

> What about cleaning the build warnings for the release?
> I'm getting this ones on latest git:
>
> [1806/2261] Compiling C object 'src/lib/elementary/f70ca57@@elementary@sha
> > /efl_ui_widget.c.o'.
> > In file included from ../src/lib/elementary/efl_ui_widget.c:5701:
> > src/lib/elementary/efl_ui_widget_part.eo.c: In function
> > ‘__eolian_efl_ui_widget_part_efl_gfx_entity_scale_set’:
> > src/lib/elementary/efl_ui_widget_part.eo.c:49:125: warning: unused
> > parameter ‘scale’ [-Wunused-parameter]
> >49 | static void
> > __eolian_efl_ui_widget_part_efl_gfx_entity_scale_set(Eo *obj EINA_UNUSED,
> > Elm_Part_Data *pd EINA_UNUSED, double scale)
> >   |
> >~~~^
> > [1829/2261] Compiling C object 'src/lib/elementary/f70ca57@
> @elementary@sha
> > /efl_ui_view_model.c.o'.
> > In file included from ../src/lib/elementary/efl_ui_view_model.c:859:
> > src/lib/elementary/efl_ui_view_model.eo.c: In function
> > ‘_efl_ui_view_model_property_logic_add_ownership_fallback’:
> > src/lib/elementary/efl_ui_view_model.eo.c:13:86: warning: unused
> parameter
> > ‘get_data’ [-Wunused-parameter]
> >13 | _efl_ui_view_model_property_logic_add_ownership_fallback(const
> > char *property, void *get_data, EflUiViewModelPropertyGet get,
> Eina_Free_Cb
> > get_free_cb, void *set_data, EflUiViewModelPropertySet set, Eina_Free_Cb
> > set_free_cb, Eina_Iterator *bound)
> >   |
> >  ~~^~~~
> > src/lib/elementary/efl_ui_view_model.eo.c:13:140: warning: unused
> > parameter ‘get_free_cb’ [-Wunused-parameter]
> >13 | _efl_ui_view_model_property_logic_add_ownership_fallback(const
> > char *property, void *get_data, EflUiViewModelPropertyGet get,
> Eina_Free_Cb
> > get_free_cb, void *set_data, EflUiViewModelPropertySet set, Eina_Free_Cb
> > set_free_cb, Eina_Iterator *bound)
> >   |
> >
> > ~^~~
> > src/lib/elementary/efl_ui_view_model.eo.c:13:159: warning: unused
> > parameter ‘set_data’ [-Wunused-parameter]
> >13 | _efl_ui_view_model_property_logic_add_ownership_fallback(const
> > char *property, void *get_data, EflUiViewModelPropertyGet get,
> Eina_Free_Cb
> > get_free_cb, void *set_data, EflUiViewModelPropertySet set, Eina_Free_Cb
> > set_free_cb, Eina_Iterator *bound)
> >   |
> >
> >   ~~^~~~
> > src/lib/elementary/efl_ui_view_model.eo.c:13:213: warning: unused
> > parameter ‘set_free_cb’ [-Wunused-parameter]
> >13 | _efl_ui_view_model_property_logic_add_ownership_fallback(const
> > char *property, void *get_data, EflUiViewModelPropertyGet get,
> Eina_Free_Cb
> > get_free_cb, void *set_data, EflUiViewModelPropertySet set, Eina_Free_Cb
> > set_free_cb, Eina_Iterator *bound)
> >   |
> >
> >
> >  ~^~~
> >
>
> They seems easy to fix and they give a bad impression on a stable release
> just my 2 cents
> Dave
>
>
> Il giorno lun 27 apr 2020 alle ore 16:15 Stefan Schmidt <
> ste...@datenfreihafen.org> ha scritto:
>
> > Hello.
> >
> > I just uploaded another run for current git master.
> >
> >
> >
> http://www.enlightenment.org/~stefan/abi-tracker/objects_report/efl/1.24.0-beta3/current/report.html
> >
> > This looks good for the changes from beta3 to current.
> >
> > If anyone wants to do another review this would be the last chance to do
> > so as I am planning to do the final release on Wednesday.
> >
> > regards
> > Stefan Schmidt
> >
> >
> > ___
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >
>
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>

___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] So long and thanks for all the fish

2020-01-20 Thread Xavi Artigas
Yeah, it's been fun working with you on the C# bindings all this time.
Thanks for all your work!
And see you around! FOSS is a small world :)

Best of lucks!
Xavi

On Sun, 19 Jan 2020 at 00:33, Felipe Magno de Almeida <
felipe.m.alme...@gmail.com> wrote:

> On Sat, Jan 18, 2020 at 12:07 AM Lauro Moura  wrote:
> >
> > As some of you may already know, I moved to a different company and will
> > have to step away from EFL development, at least on a fulltime basis.
> >
> > It has been over 4 years (thanks, Felipe) working mainly on the language
> > bindings, trying to help Eo/Eolian improve its "polyglotiness", making
> (new
> > and old) friends along the way.
> >
> > So, thanks again and happy hacking :)
> >
> > PS: I should be around on IRC (still working on FOSS projects, yay).
>
> Thank you Lauro. It was very good to work with you, and I'm sure you
> will be happy
> in the new company.
>
> I am happy that I helped you decide to move to Florianópolis, BTW.
>
> > --
> > Lauro Moura ("lauromoura" on Freenode)
> > http://dev.to/lauromoura
>
> Regards,
> --
> Felipe Magno de Almeida
> Owner @ Expertise Solutions
> www: https://expertise.dev
> phone: +55 48 9 9681.0157
> LinkedIn: in/felipealmeida
>
>
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>

___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] Legacy API Vs Unified API

2019-12-04 Thread Xavi Artigas
> Is this list the complete API out of beta?

https://www.enlightenment.org/develop/api/start


Yes it is, for EFL 1.23.
The documentation was generated and uploaded this week so it's fresh :)

Xavi

___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


[EGIT] [core/efl] master 01/01: docs: nitpicking

2019-11-28 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=7c79ca674d7583b19a0c03e3763c69c943056884

commit 7c79ca674d7583b19a0c03e3763c69c943056884
Author: Xavi Artigas 
Date:   Thu Nov 28 18:13:47 2019 +0100

docs: nitpicking

We should not refer to individual library names anymore. They are all
part of EFL now!
---
 src/lib/efl/interfaces/efl_text_font.eo | 7 +++
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/lib/efl/interfaces/efl_text_font.eo 
b/src/lib/efl/interfaces/efl_text_font.eo
index f7a6e4064c..836835c2a6 100644
--- a/src/lib/efl/interfaces/efl_text_font.eo
+++ b/src/lib/efl/interfaces/efl_text_font.eo
@@ -1,4 +1,3 @@
-// src/lib/efl/interfaces/efl_text_font.eo
 import efl_gfx_types;
 enum @beta Efl.Text_Font_Weight {
[[Type of font weight]]
@@ -58,12 +57,12 @@ interface @beta Efl.Text_Font {
This property controls the font name of a text object.
The font string has to follow fontconfig's convention for
naming fonts, as it's the underlying library used to query system
-   fonts by Evas (see the fc-list command's output, on your system,
-   to get an idea). Alternatively, youe can use the full path to a font
+   fonts by EFL (see the $[fc-list] command's output, on your system,
+   to get an idea). Alternatively, you can use the full path to a font
file.
 
When reading it, the font name string is still owned by
-   Evas and should not be freed.
+   EFL and should not be freed.
See also @.font_source.
  ]]
  set {

-- 




[EGIT] [website/www-content] master 01/01: Wiki page 2019-11-26-e-dev-days-2019.txt changed with summary [Added attendees names and phab links.] by Xavi Artigas

2019-11-28 Thread Xavi Artigas
WWW-www.enlightenment.org pushed a commit to branch master.

http://git.enlightenment.org/website/www-content.git/commit/?id=a5b73ce5680864276c941cf8c8947ecb51cf339b

commit a5b73ce5680864276c941cf8c8947ecb51cf339b
Author: Xavi Artigas 
Date:   Thu Nov 28 06:19:57 2019 -0800

Wiki page 2019-11-26-e-dev-days-2019.txt changed with summary [Added 
attendees names and phab links.] by Xavi Artigas
---
 pages/news/2019-11-26-e-dev-days-2019.txt.txt | 18 +-
 1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/pages/news/2019-11-26-e-dev-days-2019.txt.txt 
b/pages/news/2019-11-26-e-dev-days-2019.txt.txt
index e5d7ce9f9..47df13c1a 100644
--- a/pages/news/2019-11-26-e-dev-days-2019.txt.txt
+++ b/pages/news/2019-11-26-e-dev-days-2019.txt.txt
@@ -18,7 +18,23 @@ Finally, a big thank you to Stefan Schmidt for organizing 
everything and getting
 See you all, and a bunch more, next year!
 
 {{ :news:edd2019_pic1.jpg?800,direct | Attendees hard at work!}}
-Attendees hard at work!
+
+Left, front to back, and then back to front:
+[[https://phab.enlightenment.org/p/escwyp|escwyp]],
+[[https://phab.enlightenment.org/p/netstar|netstar]],
+[[https://phab.enlightenment.org/p/rafspiny|rafspiny]],
+[[https://phab.enlightenment.org/p/bu5hm4n|bu5hm4n]],
+[[https://phab.enlightenment.org/p/cedric|cedric]],
+[[https://phab.enlightenment.org/p/herb|herb]],
+[[https://phab.enlightenment.org/p/raster|raster]],
+[[https://phab.enlightenment.org/p/q66|q66]],
+[[https://phab.enlightenment.org/p/michael.bouchaud|yoz]],
+[[https://phab.enlightenment.org/p/vtorri|vtorri]],
+[[https://phab.enlightenment.org/p/peter2121|peter2121]],
+[[https://phab.enlightenment.org/p/SanghyeonLee|SanghyeonLee]],
+[[https://phab.enlightenment.org/p/stefan_schmidt|stefan]]. 
+Picture: [[https://phab.enlightenment.org/p/SegFaultXavi|Yours truly]].
+
 
 {{ :news:edd2019_pic2.jpg?800,direct | Tapas!}}
 Tapas!

-- 




Re: [E-devel] EDD2019: Thank you all and pictures

2019-11-28 Thread Xavi Artigas
>
> what about tagging the photo to know who is who ?
>

Done :)

___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] EDD2019: Thank you all and pictures

2019-11-28 Thread Xavi Artigas
Hi people,

We made it to the enlightenment.org news front page!
https://www.enlightenment.org/news :P

Xavi

On Tue, 26 Nov 2019 at 12:11, Xavi Artigas  wrote:

> Hi people,
>
> First off, thank you all for coming to Barcelona. I hope you enjoyed your
> stay :)
>
> I am planning on writing a news article for our site, and also use it as a
> blog post for the Samsung Open Source Group blog... which some day will be
> truly Open...
>
> I would like to ask if everybody is OK with using this picture:
> https://www.enlightenment.org/_media/news/edd2019_pic1.jpg
> And of course if you have better pictures and want to share them, feel
> free to send them to me!
>
> Xavi
>

___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


[EGIT] [website/www-content] master 01/01: Wiki page 2019-11-26-e-dev-days-2019.txt changed with summary [created] by Xavi Artigas

2019-11-28 Thread Xavi Artigas
WWW-www.enlightenment.org pushed a commit to branch master.

http://git.enlightenment.org/website/www-content.git/commit/?id=bb724d728e99b840ac8af7cdd2588111bf269474

commit bb724d728e99b840ac8af7cdd2588111bf269474
Author: Xavi Artigas 
Date:   Thu Nov 28 03:11:08 2019 -0800

Wiki page 2019-11-26-e-dev-days-2019.txt changed with summary [created] by 
Xavi Artigas
---
 pages/news/2019-11-26-e-dev-days-2019.txt.txt | 31 +++
 1 file changed, 31 insertions(+)

diff --git a/pages/news/2019-11-26-e-dev-days-2019.txt.txt 
b/pages/news/2019-11-26-e-dev-days-2019.txt.txt
new file mode 100644
index 0..e5d7ce9f9
--- /dev/null
+++ b/pages/news/2019-11-26-e-dev-days-2019.txt.txt
@@ -0,0 +1,31 @@
+=== Enlightenment Developer Days 2019 ===
+  * //2019-11-28 - by Xavi Artigas//
+
+On November 23 part of the Enlightenment community gathered for two days in 
Barcelona, Spain, to hold the Enlightenment Developer Days.
+
+Except for the hiatus in 2018, this tradition has been honored uninterruptedly 
since 2012, when it was also held in Barcelona.
+
+Over the weekend, 14 people from 7 countries presented their latest work, 
discussed their current problems, and talked about what lies ahead.
+
+Attendees included Enlightenment Desktop users, application developers, and 
core maintainers, producing a very interesting mixture. The outcome was varied: 
doubts were dispelled, action items for the upcoming months were laid out and, 
most importantly, the community was strengthened. For those of us who attended 
for the first time, it was a pleasure to put a face to the IRC nicks!
+
+I had the honor of being the host this time, and I enjoyed the opportunity to 
show my enlightened fellows around the city and take them out to have some 
Spanish tapas for dinner. Thanks a lot for coming!
+
+Thanks also to the Pompeu Fabra University who allowed us to use their 
facilities free of charge.
+
+Finally, a big thank you to Stefan Schmidt for organizing everything and 
getting Samsung to sponsor the meals for both days.
+
+See you all, and a bunch more, next year!
+
+{{ :news:edd2019_pic1.jpg?800,direct | Attendees hard at work!}}
+Attendees hard at work!
+
+{{ :news:edd2019_pic2.jpg?800,direct | Tapas!}}
+Tapas!
+
+{{ :news:edd2019_pic3.jpg?800,direct | And some light supper for the meat 
lovers.}}
+And some light supper for the meat 
lovers.
+
+{{:blank.png?nolink&100|}}
+~~DISCUSSIONS~~
+

-- 




[EGIT] [core/efl] master 01/01: Efl.Canvas.Text: Further update docs

2019-11-28 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=92d2cc7ae362275f2a7512778e1f0fa994cdc946

commit 92d2cc7ae362275f2a7512778e1f0fa994cdc946
Author: Xavi Artigas 
Date:   Thu Nov 28 11:08:11 2019 +0100

Efl.Canvas.Text: Further update docs
---
 src/lib/evas/canvas/efl_canvas_text.eo | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/lib/evas/canvas/efl_canvas_text.eo 
b/src/lib/evas/canvas/efl_canvas_text.eo
index 2367f51bcc..e242c78920 100644
--- a/src/lib/evas/canvas/efl_canvas_text.eo
+++ b/src/lib/evas/canvas/efl_canvas_text.eo
@@ -19,7 +19,9 @@ class @beta Efl.Canvas.Text extends Efl.Canvas.Object 
implements Efl.Text,
   }
   cursor_add {
  [[Adds an existing cursor to the text object.
-   It is typically more convenient to obtain a cursor directly from 
the text object using @.cursor_create.]]
+   If the cursor already belonged to another text object it will be 
reassigned to the new one.
+   It is typically more convenient to obtain a cursor directly from 
the text object using @.cursor_create.
+ ]]
  params {
 cursor: Efl.Text.Cursor; [[The text cursor to use.]]
  }

-- 




[EGIT] [core/efl] master 01/01: Efl.Canvas.Text: Update docs

2019-11-28 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=dfe0c7b110fa038611ae38a8a1fba78e14550d76

commit dfe0c7b110fa038611ae38a8a1fba78e14550d76
Author: Xavi Artigas 
Date:   Thu Nov 28 11:03:55 2019 +0100

Efl.Canvas.Text: Update docs
---
 src/lib/evas/canvas/efl_canvas_text.eo | 113 +
 1 file changed, 60 insertions(+), 53 deletions(-)

diff --git a/src/lib/evas/canvas/efl_canvas_text.eo 
b/src/lib/evas/canvas/efl_canvas_text.eo
index 6cdfaff8be..2367f51bcc 100644
--- a/src/lib/evas/canvas/efl_canvas_text.eo
+++ b/src/lib/evas/canvas/efl_canvas_text.eo
@@ -5,40 +5,42 @@ class @beta Efl.Canvas.Text extends Efl.Canvas.Object 
implements Efl.Text,
Efl.Text_Style, Efl.Text_Format,
Efl.Text_Markup, Efl.Ui.I18n
 {
-   [[Efl canvas text class]]
+   [[This is the Canvas-level text class. This class only takes care of 
rendering text,
+ if you need user interaction consider the classes in $Efl.Ui.]]
methods {
   @property is_empty {
- [[Whether the object is empty (no text) or not
+ [[Whether the object is empty (no text) or not.
  ]]
  get {
  }
  values {
-is_empty: bool; [[$true if empty, $false otherwise]]
+is_empty: bool; [[$true if empty.]]
  }
   }
   cursor_add {
- [[Add cursor that will manipulate and iterate content of the text 
object
+ [[Adds an existing cursor to the text object.
It is typically more convenient to obtain a cursor directly from 
the text object using @.cursor_create.]]
  params {
-cursor: Efl.Text.Cursor; [[Text cursor.]]
+cursor: Efl.Text.Cursor; [[The text cursor to use.]]
  }
   }
   cursor_create {
- [[ Create new cursor and add it to text object
+ [[Creates a new cursor and adds it to the text object.
+   This cursor can be used to manipulate and iterate the content of 
the text object.
  ]]
- return: Efl.Text.Cursor @move; [[Text cursor.]]
+ return: Efl.Text.Cursor @move; [[The created text cursor.]]
   }
   visible_range_get {
  [[Returns the currently visible range.
 
-   The given $start and $end cursor act like out-variables here,
-   as they are set to the positions of the start and the end of the
+   The given $start and $end cursors are output variables:
+   they are set to the positions of the start and the end of the
visible range in the text, respectively.
  ]]
- return: bool; [[$true on success, $false otherwise]]
+ return: bool; [[$true on success.]]
  params {
-@in start: Efl.Text.Cursor; [[Range start position]]
-@in end: Efl.Text.Cursor; [[Range end position]]
+@in start: Efl.Text.Cursor; [[Range start position.]]
+@in end: Efl.Text.Cursor; [[Range end position.]]
  }
   }
   @property style_insets {
@@ -48,92 +50,97 @@ class @beta Efl.Canvas.Text extends Efl.Canvas.Object 
implements Efl.Text,
  ]]
  get {}
  values {
-l: int; [[Left padding]]
-r: int; [[Right padding]]
-t: int; [[Top padding]]
-b: int; [[Bottom padding]]
+l: int; [[Left padding.]]
+r: int; [[Right padding.]]
+t: int; [[Top padding.]]
+b: int; [[Bottom padding.]]
  }
   }
   @property bidi_delimiters {
- [[BiDi delimiters are used for in-paragraph separation of bidi
+ [[BiDi delimiters are used for in-paragraph separation of 
bidirectional
segments. This is useful, for example, in the recipient fields of
-   e-mail clients where bidi oddities can occur when mixing RTL
-   and LTR.
+   e-mail clients where bidi oddities can occur when mixing RTL 
(right-to-left)
+   and LTR (left-to-right) text.
  ]]
  set {}
  get {}
  values {
-delim: string; [[A null terminated string of delimiters, e.g ",|" 
or $null if empty]]
+delim: string; [[A null terminated string of delimiters, e.g ",|" 
or $null if empty.]]
  }
   }
   @property newline_as_paragraph_separator {
- [[When $true, newline character will behave as a paragraph separator.
+ [[When $true, the newline character will behave as a paragraph 
separator.
  ]]
  set {}
  get {}
  values {
-mode: bool; [[$true for legacy mode, $false otherwise]]
+mode: bool; [[$true for legacy mode, $false otherwise.]]
  }
   }
   style_apply {
- [[apply the style for this object, sent style member will override 
old ones, other styles will not be affected.
- similar to setting s

[E-devel] EDD2019: Thank you all and pictures

2019-11-26 Thread Xavi Artigas
Hi people,

First off, thank you all for coming to Barcelona. I hope you enjoyed your
stay :)

I am planning on writing a news article for our site, and also use it as a
blog post for the Samsung Open Source Group blog... which some day will be
truly Open...

I would like to ask if everybody is OK with using this picture:
https://www.enlightenment.org/_media/news/edd2019_pic1.jpg
And of course if you have better pictures and want to share them, feel free
to send them to me!

Xavi

___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


[EGIT] [website/www-content] master 01/01: EDD2019 pictures

2019-11-26 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/website/www-content.git/commit/?id=58ccc3355f93508af6cce25d382a08d259e5ab63

commit 58ccc3355f93508af6cce25d382a08d259e5ab63
Author: Xavi Artigas 
Date:   Tue Nov 26 12:00:38 2019 +0100

EDD2019 pictures
---
 media/news/edd2019_pic1.jpg | Bin 0 -> 2776058 bytes
 media/news/edd2019_pic2.jpg | Bin 0 -> 3121773 bytes
 media/news/edd2019_pic3.jpg | Bin 0 -> 3075937 bytes
 3 files changed, 0 insertions(+), 0 deletions(-)

diff --git a/media/news/edd2019_pic1.jpg b/media/news/edd2019_pic1.jpg
new file mode 100755
index 0..309a8c143
Binary files /dev/null and b/media/news/edd2019_pic1.jpg differ
diff --git a/media/news/edd2019_pic2.jpg b/media/news/edd2019_pic2.jpg
new file mode 100755
index 0..130fb4eeb
Binary files /dev/null and b/media/news/edd2019_pic2.jpg differ
diff --git a/media/news/edd2019_pic3.jpg b/media/news/edd2019_pic3.jpg
new file mode 100755
index 0..e13addde0
Binary files /dev/null and b/media/news/edd2019_pic3.jpg differ

-- 




[EGIT] [core/efl] master 01/01: Efl.Text.Cursor: Add missing documentation

2019-11-22 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=98ae0bb4ccab87fe2029b205b01440779a920071

commit 98ae0bb4ccab87fe2029b205b01440779a920071
Author: Xavi Artigas 
Date:   Fri Nov 22 12:50:35 2019 +0100

Efl.Text.Cursor: Add missing documentation

This was breaking the C# bindings build.
---
 src/lib/evas/canvas/efl_text_cursor.eo | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/evas/canvas/efl_text_cursor.eo 
b/src/lib/evas/canvas/efl_text_cursor.eo
index 781a1799fe..47786b7f2e 100644
--- a/src/lib/evas/canvas/efl_text_cursor.eo
+++ b/src/lib/evas/canvas/efl_text_cursor.eo
@@ -1,4 +1,4 @@
-struct @beta Efl_Text_Cursor_Handle;
+struct @beta Efl_Text_Cursor_Handle; [[Opaque handle for Text cursors.]]
 
 enum @beta Efl.Text.Cursor_Type
 {

-- 




[EGIT] [core/efl] master 01/01: docs: Remove repeated words

2019-11-22 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=070c8f6ae9c6ac3d937fb82e1700e7a650eca259

commit 070c8f6ae9c6ac3d937fb82e1700e7a650eca259
Author: Xavi Artigas 
Date:   Fri Nov 22 10:39:33 2019 +0100

docs: Remove repeated words

This had already been pointed out in the review.
---
 src/lib/evas/canvas/efl_text_cursor.eo | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/lib/evas/canvas/efl_text_cursor.eo 
b/src/lib/evas/canvas/efl_text_cursor.eo
index 28247522f3..781a1799fe 100644
--- a/src/lib/evas/canvas/efl_text_cursor.eo
+++ b/src/lib/evas/canvas/efl_text_cursor.eo
@@ -12,8 +12,8 @@ enum @beta Efl.Text.Cursor_Move_Type
[[Text cursor movement types.]]
char_next,   [[Advances to the next character.]]
char_prev,   [[Advances to the previous character.]]
-   cluster_next,[[Advances to the next grapheme cluster, Grapheme cluster 
(A character sequence rendered together. See 
https://unicode.org/reports/tr29/).]]
-   cluster_prev,[[Advances to the previous grapheme cluster, Grapheme 
cluster (A character sequence rendered together. See 
https://unicode.org/reports/tr29/).]]
+   cluster_next,[[Advances to the next grapheme cluster (A character 
sequence rendered together. See https://unicode.org/reports/tr29/).]]
+   cluster_prev,[[Advances to the previous grapheme cluster (A character 
sequence rendered together. See https://unicode.org/reports/tr29/).]]
paragraph_start, [[Advances to the first character in this paragraph.]]
paragraph_end,   [[Advances to the last character in this paragraph.]]
word_start,  [[Advance to current word start.]]
@@ -247,4 +247,4 @@ class @beta Efl.Text.Cursor extends Efl.Object implements 
Efl.Duplicate{
Efl.Object.destructor;
Efl.Duplicate.duplicate;
}
-}
\ No newline at end of file
+}

-- 




[E-devel] Fwd: [DF] [Request] [+++-- ] D10716: Polish text interface methods

2019-11-22 Thread Xavi Artigas
I cannot see this patch:
Access Denied: Restricted Differential Revision
You do not have permission to view this object.
Xavi

-- Forwarded message -
From: a.srour (Abdalrahman Srour) 
Date: Thu, 21 Nov 2019 at 17:12
Subject: [DF] [Request] [+++-- ] D10716: Polish text interface methods
To: 


a.srour created this revision.
a.srour added a reviewer: ali.alzyod.
Herald added a subscriber: cedric.
Herald added a project: efl.
a.srour requested review of this revision. View Revision

*REVISION SUMMARY*

This patch is set to rename some properties of Efl.Text_Font &
Efl.Text_Format interfaces.

*REPOSITORY*
rEFL core/efl

*BRANCH*
master

*REVISION DETAIL*
https://phab.enlightenment.org/D10716

*AFFECTED FILES*
src/bin/elementary/test_efl_ui_text.c
src/bin/elementary/test_gfx_filters.c
src/bin/elementary/test_ui_relative_container.c
src/examples/elementary/efl_canvas_layout_text.c
src/examples/elementary/efl_ui_list_example_1.c
src/lib/edje/edje_part_text.c
src/lib/edje/edje_text.c
src/lib/edje/efl_canvas_layout_part_text.eo
src/lib/efl/interfaces/efl_text_font.eo
src/lib/efl/interfaces/efl_text_format.eo
src/lib/elementary/efl_ui_text.c
src/lib/evas/canvas/efl_canvas_text.eo
src/lib/evas/canvas/evas_object_text.c
src/lib/evas/canvas/evas_object_textblock.c
src/lib/evas/canvas/evas_object_textgrid.c
src/lib/evas/canvas/evas_text_eo.c
src/lib/evas/canvas/evas_textgrid_eo.c
src/lib/evas/canvas/evas_textgrid_eo.h
src/lib/evas/canvas/evas_textgrid_eo.legacy.h
src/tests/edje/edje_test_text.c
src/tests/evas/evas_test_textblock.c

*EMAIL PREFERENCES*
https://phab.enlightenment.org/settings/panel/emailpreferences/

*To: *a.srour, ali.alzyod
*Cc: *committers, cedric, reviewers, derbyw, aishenhaowe

___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


[EGIT] [core/efl] master 01/06: Unify "animated" flags

2019-11-20 Thread Xavi Artigas
bu5hm4n pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=9bb2df996642f046f79466cff8fefcd43d28921e

commit 9bb2df996642f046f79466cff8fefcd43d28921e
Author: Xavi Artigas 
Date:   Mon Nov 11 16:38:08 2019 +

Unify "animated" flags

There exist several flags to indicate whether an object should be animated, 
with inconsistent names:
Efl.Canvas.Layout.animation: bool indicating if Edje animations should be 
played
Efl.Ui.Spotlight_Manager.animation_enabled: bool indicating if page 
transitions should be animated
Efl.Canvas.Animation_Player.animation: Efl.Canvas.Animation object

This commit unifies all of them: "animated" is now a flag, and "animation" 
is an object.

Note: Animation_Player is in the process of being replaced by an 
"animation" property in the
Efl.Canvas.Object, hence the need for non-clashing animation flags.

Reviewed-by: Marcel Hollerbach 
Differential Revision: https://phab.enlightenment.org/D10645
---
 src/bin/elementary/test_ui_spotlight.c| 4 ++--
 src/lib/edje/edje_program.c   | 4 ++--
 src/lib/edje/efl_canvas_layout.eo | 2 +-
 src/lib/edje/efl_canvas_layout_eo.legacy.c| 4 ++--
 src/lib/elementary/efl_ui_spotlight_container.c   | 4 ++--
 src/lib/elementary/efl_ui_spotlight_manager.eo| 8 +---
 src/lib/elementary/efl_ui_spotlight_manager_plain.c   | 4 ++--
 src/lib/elementary/efl_ui_spotlight_manager_plain.eo  | 2 +-
 src/lib/elementary/efl_ui_spotlight_manager_scroll.c  | 4 ++--
 src/lib/elementary/efl_ui_spotlight_manager_scroll.eo | 2 +-
 src/lib/elementary/efl_ui_spotlight_manager_stack.c   | 4 ++--
 src/lib/elementary/efl_ui_spotlight_manager_stack.eo  | 2 +-
 src/tests/elementary/efl_ui_test_spotlight.c  | 4 ++--
 13 files changed, 25 insertions(+), 23 deletions(-)

diff --git a/src/bin/elementary/test_ui_spotlight.c 
b/src/bin/elementary/test_ui_spotlight.c
index a41ab69be5..fe095ab879 100644
--- a/src/bin/elementary/test_ui_spotlight.c
+++ b/src/bin/elementary/test_ui_spotlight.c
@@ -513,7 +513,7 @@ _animation_cb(void *data, const Efl_Event *ev)
 {
Params *params = data;
 
-   
efl_ui_spotlight_manager_animation_enabled_set(efl_ui_spotlight_manager_get(params->spotlight),
 efl_ui_selectable_selected_get(ev->object));
+   
efl_ui_spotlight_manager_animated_transition_set(efl_ui_spotlight_manager_get(params->spotlight),
 efl_ui_selectable_selected_get(ev->object));
 }
 
 static void
@@ -536,7 +536,7 @@ view_animation_cb(void *data,
 
ck = efl_add(EFL_UI_CHECK_CLASS, box);
efl_event_callback_add(ck, EFL_UI_EVENT_SELECTED_CHANGED, _animation_cb, 
params);
-   efl_ui_selectable_selected_set(ck, 
efl_ui_spotlight_manager_animation_enabled_get(efl_ui_spotlight_manager_get(params->spotlight)));
+   efl_ui_selectable_selected_set(ck, 
efl_ui_spotlight_manager_animated_transition_get(efl_ui_spotlight_manager_get(params->spotlight)));
efl_text_set(ck, "Animation");
efl_pack_end(box, ck);
efl_gfx_entity_visible_set(ck, 1);
diff --git a/src/lib/edje/edje_program.c b/src/lib/edje/edje_program.c
index b047031da1..b1edd1fa2b 100644
--- a/src/lib/edje/edje_program.c
+++ b/src/lib/edje/edje_program.c
@@ -320,7 +320,7 @@ _efl_canvas_layout_efl_layout_signal_signal_emit(Eo *obj 
EINA_UNUSED, Edje *ed,
 
 /* FIXDOC: Verify/Expand */
 EOLIAN void
-_efl_canvas_layout_animation_set(Eo *obj, Edje *ed, Eina_Bool on)
+_efl_canvas_layout_animated_set(Eo *obj, Edje *ed, Eina_Bool on)
 {
Eina_List *l;
unsigned short i;
@@ -390,7 +390,7 @@ break_prog:
 }
 
 EOLIAN Eina_Bool
-_efl_canvas_layout_animation_get(const Eo *obj EINA_UNUSED, Edje *ed)
+_efl_canvas_layout_animated_get(const Eo *obj EINA_UNUSED, Edje *ed)
 {
if (!ed) return EINA_FALSE;
if (ed->delete_me) return EINA_FALSE;
diff --git a/src/lib/edje/efl_canvas_layout.eo 
b/src/lib/edje/efl_canvas_layout.eo
index bed3439d36..ef33c5bd8f 100644
--- a/src/lib/edje/efl_canvas_layout.eo
+++ b/src/lib/edje/efl_canvas_layout.eo
@@ -10,7 +10,7 @@ class @beta Efl.Canvas.Layout extends Efl.Canvas.Group 
implements Efl.File, Efl.
event_c_prefix: efl_layout;
data: Edje;
methods {
-  @property animation {
+  @property animated {
  [[Whether this object is animating or not.
 
This property indicates whether animations are stopped or not.
diff --git a/src/lib/edje/efl_canvas_layout_eo.legacy.c 
b/src/lib/edje/efl_canvas_layout_eo.legacy.c
index f55e5d5f4b..ec6eb8930d 100644
--- a/src/lib/edje/efl_canvas_layout_eo.legacy.c
+++ b/src/lib/edje/efl_canvas_layout_eo.legacy.c
@@ -2,13 +2,13 @@
 EAPI void
 edje_object_animation_set(Efl_Canvas_Layout *obj, Eina_Bool on)
 {
-   efl_canvas_layout_animation_set(obj, on);
+   efl_canvas_layout_animated_set(obj, on);
 }
 
 EAPI Eina_Bool
 edje_object_animation_get(const Efl_Canvas_Layo

[EGIT] [core/efl] master 01/01: docs: Copy all images to output folder

2019-11-19 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=36c70ee93295d4b5040c0f8a20a2fdb70a0cd646

commit 36c70ee93295d4b5040c0f8a20a2fdb70a0cd646
Author: Xavi Artigas 
Date:   Mon Nov 18 15:20:38 2019 +0100

docs: Copy all images to output folder

Summary:
Doxygen only copies to the output folder ("html") images included through
the \image tag. However, we have several images included using \htmlonly
blocks with  tags inside, which also need copying.
Old makefiles included code to manually copy all pngs, and this patch does
the same for meson.
I apologize for needing an external script just to run "cp -rf", it looks
like meson does not allow wildcards passed to "cp".
Files not in the output folder won't be included in the tarball and won't
be distributed.

Test Plan:
Generated documentation now includes images for pages like:
`group__Eina__List__Group.html#details`

Reviewers: bu5hm4n, lauromoura

Reviewed By: bu5hm4n

Subscribers: cedric, #reviewers, #committers, myoungwoon

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10690
---
 doc/efl_copy.sh |  1 +
 doc/meson.build | 10 +-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/doc/efl_copy.sh b/doc/efl_copy.sh
new file mode 100755
index 00..af975fbd8f
--- /dev/null
+++ b/doc/efl_copy.sh
@@ -0,0 +1 @@
+cp $@
diff --git a/doc/meson.build b/doc/meson.build
index 81c0e34910..18b9aeecf4 100644
--- a/doc/meson.build
+++ b/doc/meson.build
@@ -104,6 +104,7 @@ widget_preview_eps = 
custom_target('widget_preview_prefs_epc',
 
 shot_sh = find_program('shot.sh')
 tar = find_program('tar')
+efl_copy = find_program('efl_copy.sh')
 
 foreach text_filter_property : text_filter_properties
   text = text_filter_property[0]
@@ -181,10 +182,17 @@ doc_target += custom_target('doxygen',
   build_by_default: false
 )
 
+# This is not pretty but meson does not seem to allow wildcards in plain cp 
commands
+copy_images = custom_target('documentation images',
+  command: [efl_copy, '-rf', join_paths(meson.current_source_dir(), 'img', 
'*.png'), 'html'],
+  output: ['empty_img_copy'],
+  build_by_default: false
+)
+
 compress_target = custom_target('package_doc_tar',
   command: [tar, '-C', meson.build_root(), '--xz',  '-cf', 
'efl-'+meson.project_version()+'-doc.tar.xz', 'html', 'man'],
   output: 'efl-'+meson.project_version()+'-doc.tar.xz',
-  depends: doc_target,
+  depends: [doc_target, copy_images],
   build_by_default: false
 )
 

-- 




[EGIT] [core/efl] master 01/01: docs: Typos in ninja doc screen output

2019-11-18 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=070cde61b5a55bae055a084aa4dffbca02dfdcba

commit 070cde61b5a55bae055a084aa4dffbca02dfdcba
Author: Xavi Artigas 
Date:   Mon Nov 18 12:30:22 2019 +0100

docs: Typos in ninja doc screen output
---
 doc/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/meson.build b/doc/meson.build
index 5598b18ba3..81c0e34910 100644
--- a/doc/meson.build
+++ b/doc/meson.build
@@ -189,7 +189,7 @@ compress_target = custom_target('package_doc_tar',
 )
 
 run_target('doc',
-  command: ['echo', 'Documentation sucessfully build!'],
+  command: ['echo', 'Documentation built successfully'],
   depends: compress_target,
 )
 

-- 




[EGIT] [core/efl] master 01/01: doxygen: Prevent auto-linking of invalid links

2019-11-18 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=1c5849c5a8b2b3ccc48caf55e5568f122bb0be9a

commit 1c5849c5a8b2b3ccc48caf55e5568f122bb0be9a
Author: Xavi Artigas 
Date:   Mon Nov 18 11:57:30 2019 +0100

doxygen: Prevent auto-linking of invalid links

Anything starting with http://, ftp:// or file:// is automatically
converted into a link by doxygen. However, we have a few instances
where we do not want this. Fortunately, doxygen allows using % to
forbid specific words from being linked.
---
 src/lib/ecore_file/Ecore_File.h | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/lib/ecore_file/Ecore_File.h b/src/lib/ecore_file/Ecore_File.h
index 23a0521945..37f3bd8a0c 100644
--- a/src/lib/ecore_file/Ecore_File.h
+++ b/src/lib/ecore_file/Ecore_File.h
@@ -609,8 +609,8 @@ EAPI Eina_List *ecore_file_app_list(void);
  * @return @c EINA_TRUE if the download start or @c EINA_FALSE on failure.
  *
  * This function starts the download of the URL @p url and saves it to
- * @p dst. @p url must provide the protocol, including 'http://',
- * 'ftp://' or 'file://'. Ecore_File must be compiled with CURL to
+ * @p dst. @p url must provide the protocol, including '%http://',
+ * '%ftp://' or '%file://'. Ecore_File must be compiled with CURL to
  * download using http and ftp protocols. If @p dst is ill-formed, or
  * if it already exists, the function returns @c EINA_FALSE. When the
  * download is complete, the callback @p completion_cb is called and
@@ -684,8 +684,8 @@ EAPI void  
ecore_file_download_abort(Ecore_File_Download_Job *job);
  * @return @c EINA_TRUE if protocol is handled, @c EINA_FALSE otherwise.
  *
  * This function returns @c EINA_TRUE if @p protocol is supported,
- * @c EINA_FALSE otherwise. @p protocol can be 'http://', 'ftp://' or
- * 'file://'. Ecore_FILE must be compiled with CURL to handle http and
+ * @c EINA_FALSE otherwise. @p protocol can be '%http://', '%ftp://' or
+ * '%file://'. Ecore_FILE must be compiled with CURL to handle http and
  * ftp protocols.
  */
 EAPI Eina_Bool ecore_file_download_protocol_available(const char *protocol);

-- 




[E-devel] Phabricator popups

2019-11-14 Thread Xavi Artigas
Hi people,

Has anybody else noticed that Phab no longer shows the yellow popup when
the page you are working on is being updated by someone else?
Or the blue popup when someone else added something to another page?

Is this related to the server migration?

Xavi

___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


[EGIT] [core/efl] master 01/01: Efl.Ui.Scroll_Manager: Fix indentation

2019-11-12 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=3fc7102561a4604f0578990d820e10ae750a2522

commit 3fc7102561a4604f0578990d820e10ae750a2522
Author: Xavi Artigas 
Date:   Tue Nov 12 13:00:23 2019 +0100

Efl.Ui.Scroll_Manager: Fix indentation
---
 src/lib/elementary/efl_ui_scroll_manager.eo | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/lib/elementary/efl_ui_scroll_manager.eo 
b/src/lib/elementary/efl_ui_scroll_manager.eo
index 2a05083be5..957a4f4d4d 100644
--- a/src/lib/elementary/efl_ui_scroll_manager.eo
+++ b/src/lib/elementary/efl_ui_scroll_manager.eo
@@ -8,16 +8,16 @@ class @beta Efl.Ui.Scroll.Manager extends Efl.Object 
implements
c_prefix: efl_ui_scroll_manager;
methods {
   @property pan @protected {
-[[This is the internal pan object managed by scroll manager.
+ [[This is the internal pan object managed by scroll manager.
 
-  This property is protected as it is meant for scrollable object
-  implementations only, to set and access the internal pan object.
-  If pan is set to $NULL, scrolling does not work.
-]]
+   This property is protected as it is meant for scrollable object
+   implementations only, to set and access the internal pan object.
+   If pan is set to $NULL, scrolling does not work.
+ ]]
  set {
  }
  values {
-pan: Efl.Ui.Pan; [[Pan object]]
+pan: Efl.Ui.Pan; [[Pan object.]]
  }
   }
}

-- 




[EGIT] [core/efl] master 01/01: Efl.Interpolator*: More sensible API names and docs

2019-11-06 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=9ca84821fc91d3e5661edb9d2393788b28c56f7c

commit 9ca84821fc91d3e5661edb9d2393788b28c56f7c
Author: Xavi Artigas 
Date:   Tue Nov 5 20:26:14 2019 +0100

Efl.Interpolator*: More sensible API names and docs

Summary:
OK, so, ALL interpolator parameters were called "factor" and the docs
literally said "First factor, Second factor, ..."
After diving into the actual implementation, proper names (and types) for 
the
parameters were found and proper docs written.

I am afraid I could not make any sense of the Divisor interpolator code. 
Those
docs still need writing.

Test Plan: Everything still builds and passes tests. No functional changes.

Reviewers: zmike, cedric, bu5hm4n, Jaehyun_Cho

Reviewed By: bu5hm4n

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10603
---
 src/bin/elementary/test_efl_anim_interpolator.c | 15 +---
 src/lib/ecore/efl_accelerate_interpolator.c | 16 
 src/lib/ecore/efl_accelerate_interpolator.eo| 14 ---
 src/lib/ecore/efl_bounce_interpolator.c | 40 
 src/lib/ecore/efl_bounce_interpolator.eo| 24 +---
 src/lib/ecore/efl_cubic_bezier_interpolator.c   | 50 -
 src/lib/ecore/efl_cubic_bezier_interpolator.eo  | 26 +
 src/lib/ecore/efl_decelerate_interpolator.c | 16 
 src/lib/ecore/efl_decelerate_interpolator.eo| 14 ---
 src/lib/ecore/efl_divisor_interpolator.c| 39 +++
 src/lib/ecore/efl_divisor_interpolator.eo   | 20 +++---
 src/lib/ecore/efl_linear_interpolator.eo|  3 +-
 src/lib/ecore/efl_sinusoidal_interpolator.c | 16 
 src/lib/ecore/efl_sinusoidal_interpolator.eo| 13 ---
 src/lib/ecore/efl_spring_interpolator.c | 44 +-
 src/lib/ecore/efl_spring_interpolator.eo| 24 +---
 src/lib/efl/interfaces/efl_interpolator.eo  | 21 +--
 17 files changed, 250 insertions(+), 145 deletions(-)

diff --git a/src/bin/elementary/test_efl_anim_interpolator.c 
b/src/bin/elementary/test_efl_anim_interpolator.c
index 9a6522f6d7..96c7649373 100644
--- a/src/bin/elementary/test_efl_anim_interpolator.c
+++ b/src/bin/elementary/test_efl_anim_interpolator.c
@@ -33,32 +33,35 @@ _interpolator_create(int index, Evas_Object *win)
else if (index == 1)
  {
 interp = efl_add(EFL_SINUSOIDAL_INTERPOLATOR_CLASS, win);
-efl_sinusoidal_interpolator_factor_set(interp, 1.0);
+efl_sinusoidal_interpolator_slope_set(interp, 1.0);
  }
else if (index == 2)
  {
 interp = efl_add(EFL_DECELERATE_INTERPOLATOR_CLASS, win);
-efl_decelerate_interpolator_factor_set(interp, 1.0);
+efl_decelerate_interpolator_slope_set(interp, 1.0);
  }
else if (index == 3)
  {
 interp = efl_add(EFL_ACCELERATE_INTERPOLATOR_CLASS, win);
-efl_accelerate_interpolator_factor_set(interp, 1.0);
+efl_accelerate_interpolator_slope_set(interp, 1.0);
  }
else if (index == 4)
  {
 interp = efl_add(EFL_DIVISOR_INTERPOLATOR_CLASS, win);
-efl_divisor_interpolator_factors_set(interp, 1.0, 1.0);
+efl_divisor_interpolator_divisor_set(interp, 1.0);
+efl_divisor_interpolator_power_set(interp, 1);
  }
else if (index == 5)
  {
 interp = efl_add(EFL_BOUNCE_INTERPOLATOR_CLASS, win);
-efl_bounce_interpolator_factors_set(interp, 1.0, 1.0);
+efl_bounce_interpolator_rigidness_set(interp, 1.0);
+efl_bounce_interpolator_bounces_set(interp, 1);
  }
else if (index == 6)
  {
 interp = efl_add(EFL_SPRING_INTERPOLATOR_CLASS, win);
-efl_spring_interpolator_factors_set(interp, 1.0, 1.0);
+efl_spring_interpolator_decay_set(interp, 1.0);
+efl_spring_interpolator_oscillations_set(interp, 1);
  }
 
return interp;
diff --git a/src/lib/ecore/efl_accelerate_interpolator.c 
b/src/lib/ecore/efl_accelerate_interpolator.c
index 917c032d05..b2e10320cb 100644
--- a/src/lib/ecore/efl_accelerate_interpolator.c
+++ b/src/lib/ecore/efl_accelerate_interpolator.c
@@ -11,7 +11,7 @@ typedef struct _Efl_Accelerate_Interpolator_Data 
Efl_Accelerate_Interpolator_Dat
 
 struct _Efl_Accelerate_Interpolator_Data
 {
-   double factor;
+   double slope;
 };
 
 EOLIAN static double
@@ -23,22 +23,22 @@ 
_efl_accelerate_interpolator_efl_interpolator_interpolate(Eo *eo_obj EINA_UNUSED
  return progress;
 
return ecore_animator_pos_map(progress, ECORE_POS_MAP_ACCELERATE_FACTOR,
- pd->factor, 0);
+ pd->slope, 0);
 }
 
 EOLIAN static void
-_efl_accelerate_interpolator_factor_set(Eo *eo_obj EINA_UNUSED,
+_efl_accelerate_interpo

[EGIT] [core/efl] master 01/01: docs: Add caveat details to Efl.Canvas.Animation

2019-11-06 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=8a597b1566f0025f9aff394002b766069beb

commit 8a597b1566f0025f9aff394002b766069beb
Author: Xavi Artigas 
Date:   Wed Oct 30 18:47:07 2019 +0100

docs: Add caveat details to Efl.Canvas.Animation

Summary:
Regarding object properties not matching actual rendered values when 
animations
are running.

Depends on D10560

Reviewers: bu5hm4n, cedric, zmike, Jaehyun_Cho

Reviewed By: bu5hm4n

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10566
---
 src/lib/evas/canvas/efl_canvas_animation.eo | 16 +++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/src/lib/evas/canvas/efl_canvas_animation.eo 
b/src/lib/evas/canvas/efl_canvas_animation.eo
index 987220bf4d..f8c371c0c9 100644
--- a/src/lib/evas/canvas/efl_canvas_animation.eo
+++ b/src/lib/evas/canvas/efl_canvas_animation.eo
@@ -1,4 +1,5 @@
 import efl_canvas_animation_types;
+parse efl_canvas_animation_player;
 
 class @beta Efl.Canvas.Animation extends Efl.Object implements Efl.Playable
 {
@@ -10,12 +11,25 @@ class @beta Efl.Canvas.Animation extends Efl.Object 
implements Efl.Playable
  evolves from $[0] to $[1].
 
  For example implementations see @Efl.Canvas.Animation_Translate or 
@Efl.Canvas.Animation_Scale.
+
+ Note: Unless @.final_state_keep is used, when an animation finishes any 
effect it introduced on the object is
+ removed. This means that if the animation does not end in the object's 
initial state there will be a noticeable
+ sudden jump.
+ To avoid this, animations must finish in the same state as they begin, or 
the object's state must be
+ matched to the animation's ending state once the animation finishes 
(using the @[Efl.Canvas.Animation_Player.ended]
+ event).
]]
c_prefix: efl_animation;
methods {
   @property final_state_keep {
  [[If $true the last mapping state the animation applies will be kept.
-   Otherwise all the @Efl.Gfx.Mapping properties will be reset when 
the animation ends.]]
+   Otherwise all the @Efl.Gfx.Mapping properties will be reset when 
the animation ends.
+
+   Be careful, though. Object properties like @Efl.Gfx.Entity.position 
do not take
+   animations into account so they might not match the actual rendered 
values.
+   It is usually better to remove the effects of the animation as soon 
as it finishes
+   and set the final values on the object's properties.
+ ]]
  set {
  }
  get {

-- 




[EGIT] [core/efl] master 01/01: docs: Efl.Gfx.View

2019-11-05 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=714478cbf3ba6630e2f3255ae56f1d2af4ac7312

commit 714478cbf3ba6630e2f3255ae56f1d2af4ac7312
Author: Xavi Artigas 
Date:   Tue Nov 5 11:48:40 2019 +0100

docs: Efl.Gfx.View
---
 src/lib/efl/interfaces/efl_gfx_view.eo | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/lib/efl/interfaces/efl_gfx_view.eo 
b/src/lib/efl/interfaces/efl_gfx_view.eo
index bf29419c60..1737aa73e7 100644
--- a/src/lib/efl/interfaces/efl_gfx_view.eo
+++ b/src/lib/efl/interfaces/efl_gfx_view.eo
@@ -2,7 +2,10 @@ import eina_types;
 
 interface @beta Efl.Gfx.View
 {
-   [[Efl graphics view interface]]
+   [[Interface for graphical objects with a native size which might be
+ different from the desired rendered size (controlled through the
+ @.view_size property).
+   ]]
c_prefix: efl_gfx;
methods {
   @property view_size {

-- 




[EGIT] [core/efl] master 01/01: docs: Efl.Ui.Table_Static

2019-11-05 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=6a647880c60c376aa8c6acb9e54a16d9221d6658

commit 6a647880c60c376aa8c6acb9e54a16d9221d6658
Author: Xavi Artigas 
Date:   Tue Nov 5 11:31:29 2019 +0100

docs: Efl.Ui.Table_Static

The need for this class is still being discussed in
https://phab.enlightenment.org/T8206
but at least it is a bit more clear what its purpose is.
---
 src/lib/elementary/efl_ui_table_static.eo | 8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/lib/elementary/efl_ui_table_static.eo 
b/src/lib/elementary/efl_ui_table_static.eo
index c459dcb03a..461d7dcc44 100644
--- a/src/lib/elementary/efl_ui_table_static.eo
+++ b/src/lib/elementary/efl_ui_table_static.eo
@@ -1,6 +1,12 @@
 class @beta Efl.Ui.Table_Static extends Efl.Ui.Table
 {
-   [[Efl UI table static class]]
+   [[Widget container that arranges its elements in a uniform grid.
+
+ For convenience, the grid has an initial size of 100 by 100 cells, so all 
positions and
+ sizes can be interpreted as percentages.
+ Cells are always shown with the same size, regardless of their content. 
Therefore, adding
+ content to one cell does not affect other cells.
+   ]]
data: null;
implements {
   Efl.Object.constructor;

-- 




[EGIT] [core/efl] master 01/01: docs: Polish Efl.Canvas.Animation_Group and sons

2019-11-04 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=0e71e0e286d97c4aaee76f1c079e2f00fc616cbf

commit 0e71e0e286d97c4aaee76f1c079e2f00fc616cbf
Author: Xavi Artigas 
Date:   Wed Oct 30 15:26:08 2019 +0100

docs: Polish Efl.Canvas.Animation_Group and sons

Summary: These docs were almost empty.

Reviewers: bu5hm4n, zmike, cedric, Jaehyun_Cho

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10564
---
 src/lib/evas/canvas/efl_canvas_animation_group.eo | 19 ---
 .../canvas/efl_canvas_animation_group_parallel.eo |  9 -
 .../canvas/efl_canvas_animation_group_sequential.eo   | 10 +-
 3 files changed, 29 insertions(+), 9 deletions(-)

diff --git a/src/lib/evas/canvas/efl_canvas_animation_group.eo 
b/src/lib/evas/canvas/efl_canvas_animation_group.eo
index fdf42e2d88..f9cada25a7 100644
--- a/src/lib/evas/canvas/efl_canvas_animation_group.eo
+++ b/src/lib/evas/canvas/efl_canvas_animation_group.eo
@@ -1,24 +1,29 @@
 abstract @beta Efl.Canvas.Animation_Group extends Efl.Canvas.Animation
 {
-   [[Efl group animation abstract class]]
+   [[Base class for combined animations (groups of animations that are played 
together).
+
+ This class provides methods to add, remove and retrieve individual 
animations from the group.
+   
+ See for example @Efl.Canvas.Animation_Group_Parallel and 
@Efl.Canvas.Animation_Group_Sequential.
+   ]]
c_prefix: efl_animation_group;
data: Efl_Canvas_Animation_Group_Data;
methods {
   animation_add {
- [[Add the given animation to the animation group.]]
+ [[Adds the given animation to the animation group.]]
  params {
-@in animation: Efl.Canvas.Animation; [[The animation which needs 
to be added to the animation group]]
+@in animation: Efl.Canvas.Animation; [[Animation to add to the 
group.]]
  }
   }
   animation_del {
- [[Delete the given animation from the animation group.]]
+ [[Removes the given animation from the animation group.]]
  params {
-@in animation: Efl.Canvas.Animation; [[The animation which needs 
to be deleted from the animation group]]
+@in animation: Efl.Canvas.Animation; [[Animation to remove from 
the group.]]
  }
   }
   animations_get @const {
- [[Get the animations of the animation group.]]
- return: list; [[The animations of the animation 
group]]
+ [[Gets the list of animations currently in the animation group.]]
+ return: list; [[List of animations in the 
group.]]
   }
}
implements {
diff --git a/src/lib/evas/canvas/efl_canvas_animation_group_parallel.eo 
b/src/lib/evas/canvas/efl_canvas_animation_group_parallel.eo
index 63773ddac3..e0434e7ad4 100644
--- a/src/lib/evas/canvas/efl_canvas_animation_group_parallel.eo
+++ b/src/lib/evas/canvas/efl_canvas_animation_group_parallel.eo
@@ -1,6 +1,13 @@
 class @beta Efl.Canvas.Animation_Group_Parallel extends 
Efl.Canvas.Animation_Group
 {
-   [[Efl group parallel animation class]]
+   [[Combined animation which plays its individual animations in parallel
+ (all of them simultaneously).
+
+ For instance, this could be used to move an @Efl.Canvas.Object from one 
position to another
+ while rotating it along the way.
+
+ Use @Efl.Canvas.Animation_Group.animation_add to append individual 
animations.
+   ]]
c_prefix: efl_animation_group_parallel;
data: null;
methods {
diff --git a/src/lib/evas/canvas/efl_canvas_animation_group_sequential.eo 
b/src/lib/evas/canvas/efl_canvas_animation_group_sequential.eo
index 415a87f999..aebd70ede5 100644
--- a/src/lib/evas/canvas/efl_canvas_animation_group_sequential.eo
+++ b/src/lib/evas/canvas/efl_canvas_animation_group_sequential.eo
@@ -1,6 +1,14 @@
 class @beta Efl.Canvas.Animation_Group_Sequential extends 
Efl.Canvas.Animation_Group
 {
-   [[Efl group sequential animation class]]
+   [[Combined animation which plays its individual animations in a sequential 
order
+ (one after the other).
+
+ For instance, this could be used to move an @Efl.Canvas.Object from one 
position to another
+ and then start rotating it once it reaches its destination.
+
+ Use @Efl.Canvas.Animation_Group.animation_add to append individual 
animations.
+ Animations are played in the order in which they are added.
+   ]]
data: null;
methods {
}

-- 




[EGIT] [core/efl] master 05/05: docs: Polish Efl.Canvas.Animation_*

2019-11-04 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=dc5ffbb8660db8f93ebf698802a56b31daeaf8b9

commit dc5ffbb8660db8f93ebf698802a56b31daeaf8b9
Author: Xavi Artigas 
Date:   Mon Nov 4 13:06:41 2019 +0100

docs: Polish Efl.Canvas.Animation_*

Summary:
These docs were lacking a lot of detail.

Depends on D10562

Reviewers: bu5hm4n, cedric, zmike, Jaehyun_Cho

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10565
---
 src/lib/evas/canvas/efl_canvas_animation_alpha.eo  | 15 +---
 src/lib/evas/canvas/efl_canvas_animation_rotate.eo | 40 +++--
 src/lib/evas/canvas/efl_canvas_animation_scale.eo  | 41 --
 .../evas/canvas/efl_canvas_animation_translate.eo  | 28 +++
 4 files changed, 91 insertions(+), 33 deletions(-)

diff --git a/src/lib/evas/canvas/efl_canvas_animation_alpha.eo 
b/src/lib/evas/canvas/efl_canvas_animation_alpha.eo
index 1ff9720c3e..d76a80c1a0 100644
--- a/src/lib/evas/canvas/efl_canvas_animation_alpha.eo
+++ b/src/lib/evas/canvas/efl_canvas_animation_alpha.eo
@@ -1,18 +1,25 @@
 class @beta Efl.Canvas.Animation_Alpha extends Efl.Canvas.Animation
 {
-   [[Efl alpha animation class]]
+   [[Animated alpha blending effect.
+
+ The @Efl.Canvas.Object will have its alpha (transparency) value 
multiplied by
+ this animation.
+ This can be used to create fade-in and fade-out transitions, for example.
+   ]]
c_prefix: efl_animation_alpha;
data: Efl_Canvas_Animation_Alpha_Data;
methods {
   @property alpha {
- [[Alpha property]]
+ [[Alpha range to animate. $[0.0] means the object is transparent and 
$[1.0] means
+   the object is opaque.
+ ]]
  set {
  }
  get {
  }
  values {
-from_alpha: double; [[Alpha value when animation starts]]
-to_alpha: double; [[Alpha value when animation ends]]
+from_alpha: double; [[Initial alpha value.]]
+to_alpha: double; [[Ending alpha value.]]
  }
   }
}
diff --git a/src/lib/evas/canvas/efl_canvas_animation_rotate.eo 
b/src/lib/evas/canvas/efl_canvas_animation_rotate.eo
index 3c1d8af086..c7463f8824 100644
--- a/src/lib/evas/canvas/efl_canvas_animation_rotate.eo
+++ b/src/lib/evas/canvas/efl_canvas_animation_rotate.eo
@@ -1,33 +1,51 @@
 class @beta Efl.Canvas.Animation_Rotate extends Efl.Canvas.Animation
 {
-   [[Efl rotate animation class]]
+   [[Animated rotation effect.
+
+ The @Efl.Canvas.Object will rotate around a pivot point from one degree 
to another.
+ Coordinates for the pivot point can be relative to another object or 
absolute
+ (relative to the containing canvas).
+
+ Note: Changing an object's position using @Efl.Gfx.Entity.position while 
this
+ animation is running might lead to unexpected results.
+   ]]
c_prefix: efl_animation_rotate;
data: Efl_Canvas_Animation_Rotate_Data;
methods {
   @property rotate {
- [[Rotate property]]
+ [[Degree range to animate and pivot object.
+   The object will rotate from $from_degree to $to_degree around the 
pivot point.
+   All of the object's vertices (i.e. the corners, if it's a 
rectangular object)
+   will be rotated by these degrees, relative to the pivot point 
inside the pivot object.
+   The pivot point is another object $pivot plus an additional offset 
$center_point.
+ ]]
  set {
  }
  get {
  }
  values {
-from_degree: double; [[Rotation degree when animation starts]]
-to_degree: double; [[Rotation degree when animation ends]]
-pivot: Efl.Canvas.Object; [[Pivot object for the center point.
-If the pivot object is $NULL, then the 
object is rotated on itself.]]
-center_point : Eina.Vector2; [[Relative coordinate of the center 
point.]]
+from_degree: double; [[Initial rotation (from 0 to 360). 0 means 
no rotation.]]
+to_degree: double; [[Ending rotation (from 0 to 360). 0 means no 
rotation.]]
+pivot: Efl.Canvas.Object; [[Object to use as pivot. $NULL means 
the animated object itself.]]
+center_point: Eina.Vector2; [[Position in pixels of the pivot 
point inside the pivot object.
+ $[(0,0)] means the upper-left 
corner.]]
  }
   }
   @property rotate_absolute {
- [[Rotate absolute property]]
+ [[Degree range to animate and absolute pivot point.
+   The object will rotate from $from_degree to $to_degree around the 
pivot point.
+   All of the object's vertices (i.e. the corners, if it's a 
rectangular object)
+   will be rotated by these degrees, relative

[EGIT] [core/efl] master 01/01: Replace tabs with spaces

2019-10-29 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=c4621408843b45e5b5d7b76c584212d3d5e224ae

commit c4621408843b45e5b5d7b76c584212d3d5e224ae
Author: Xavi Artigas 
Date:   Tue Oct 29 14:56:01 2019 +0100

Replace tabs with spaces

As our coding conventions mandate.
---
 src/lib/ecore/efl_boolean_model.eo | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/lib/ecore/efl_boolean_model.eo 
b/src/lib/ecore/efl_boolean_model.eo
index 48eab607c4..f8ee356713 100644
--- a/src/lib/ecore/efl_boolean_model.eo
+++ b/src/lib/ecore/efl_boolean_model.eo
@@ -11,13 +11,13 @@ class @beta Efl.Boolean_Model extends Efl.Composite_Model
  params {
 @in name: string; [[The name of the new boolean property.]]
 @in default_value: bool; [[Default value for new boolean 
property.]]
-}
+ }
   }
   boolean_del {
  [[Deletes an existing named boolean property.]]
  params {
 @in name: string; [[Name of the property to be deleted.]]
-}
+ }
   }
   boolean_iterator_get {
  [[Gets an iterator that will quickly find all the indices with the 
requested value for a specific property.]]

-- 




[EGIT] [core/efl] master 01/01: docs: Polished docs for Efl.Ui.Scrollable

2019-10-28 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=e25ed4f35377dbb54de1a60147d4bda7f9f98e3a

commit e25ed4f35377dbb54de1a60147d4bda7f9f98e3a
Author: Xavi Artigas 
Date:   Mon Oct 28 19:32:23 2019 +0100

docs: Polished docs for Efl.Ui.Scrollable
---
 src/lib/efl/interfaces/efl_ui_scrollable.eo | 104 ++--
 1 file changed, 53 insertions(+), 51 deletions(-)

diff --git a/src/lib/efl/interfaces/efl_ui_scrollable.eo 
b/src/lib/efl/interfaces/efl_ui_scrollable.eo
index 1c9c3f516a..872f883b81 100644
--- a/src/lib/efl/interfaces/efl_ui_scrollable.eo
+++ b/src/lib/efl/interfaces/efl_ui_scrollable.eo
@@ -3,24 +3,29 @@ import efl_ui_layout_orientable;
 
 interface Efl.Ui.Scrollable
 {
-   [[Efl UI scrollable interface
+   [[Interface for widgets capable of displaying content through a viewport, 
which might be smaller
+ than the actual content.
+ This interface does not control how the content is added. This is 
typically done through @Efl.Content.
+
+ When the content does not fit inside the viewport, typically 
@Efl.Ui.Scrollbar widgets will be used,
+ but this is beyond the scope of this interface.
 
  @since 1.23
]]
event_c_prefix: efl_ui;
methods {
   @property content_pos {
- [[The content position]]
+ [[Position of the content inside the scroller.]]
  set {
  }
  get {
  }
  values {
-pos: Eina.Position2D; [[The position is virtual value, (0, 0) 
starting at the top-left.]]
+pos: Eina.Position2D; [[The position is a virtual value, where 
$[0,0] means the top-left corner.]]
  }
   }
   @property content_size {
- [[The content size]]
+ [[Current size of the content, for convenience.]]
  get {
  }
  values {
@@ -28,7 +33,10 @@ interface Efl.Ui.Scrollable
  }
   }
   @property viewport_geometry {
- [[The viewport geometry]]
+ [[Current position and size of the viewport (or scroller window), for 
convenience.
+
+   This is the viewport through which the content is displayed.
+ ]]
  get {
  }
  values {
@@ -36,57 +44,54 @@ interface Efl.Ui.Scrollable
  }
   }
   @property bounce_enabled {
- [[Bouncing behavior
-
-   When scrolling, the scroller may "bounce" when reaching the edge of 
the
+ [[When scrolling, the scroller may "bounce" when reaching the edge of 
the
content object. This is a visual way to indicate the end has been 
reached.
-   This is enabled by default for both axes. This API will determine 
if it's enabled
-   for the given axis with the boolean parameters for each one.]]
+   This is enabled by default for both axes. This property determines 
if bouncing is enabled
+   in each axis.
+   When bouncing is disabled, scrolling just stops upon reaching the 
end of the content.
+ ]]
  set {
  }
  get {
  }
  values {
-horiz: bool; [[Horizontal bounce policy.]]
-vert: bool; [[Vertical bounce policy.]]
+horiz: bool; [[Horizontal bouncing is enabled.]]
+vert: bool; [[Vertical bouncing is enabled.]]
  }
   }
   @property scroll_freeze {
- [[Freeze property
-   This function will freeze scrolling movement (by input of a user).
-   Unlike @.movement_block, this function freezes bidirectionally.
+ [[Freezes scrolling movement (by input of a user).
+   Unlike @.movement_block, this property freezes bidirectionally.
If you want to freeze in only one direction,
-   see @.movement_block.set.
+   see @.movement_block.
  ]]
  get {
  }
  set {
  }
  values {
-freeze: bool; [[$true if freeze, $false otherwise]]
+freeze: bool; [[$true if freeze.]]
  }
   }
   @property scroll_hold {
- [[Hold property
-   When hold turns on, it only scrolls by holding action.
- ]]
+ [[When hold turns on, it only scrolls by holding action.]]
  get {
  }
  set {
  }
  values {
-hold: bool; [[$true if hold, $false otherwise]]
+hold: bool; [[$true if hold.]]
  }
   }
   @property looping {
- [[Controls an infinite loop for a scroller.]]
+ [[Controls infinite looping for a scroller.]]
  set {
  }
  get {
  }
  values {
-loop_h: bool; [[The scrolling horizontal loop]]
-loop_v: bool; [[The Scrolling vertical loop]]
+loop_h: bool; [[Scroll horizontal looping is enabled.]]
+loop_v: bool; [[Scroll vertical looping is enabled.]]
  }
 

[EGIT] [core/efl] master 01/01: docs: Formatting and polishing Efl.Ui.Factory docs

2019-10-28 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=cb396554c6da2a9b72490c05008284fdc5b12994

commit cb396554c6da2a9b72490c05008284fdc5b12994
Author: Xavi Artigas 
Date:   Mon Oct 28 18:46:13 2019 +0100

docs: Formatting and polishing Efl.Ui.Factory docs
---
 src/lib/efl/interfaces/efl_ui_factory.eo | 21 ++---
 1 file changed, 14 insertions(+), 7 deletions(-)

diff --git a/src/lib/efl/interfaces/efl_ui_factory.eo 
b/src/lib/efl/interfaces/efl_ui_factory.eo
index cdc699d951..f9dd26f7d4 100644
--- a/src/lib/efl/interfaces/efl_ui_factory.eo
+++ b/src/lib/efl/interfaces/efl_ui_factory.eo
@@ -24,7 +24,7 @@ interface Efl.Ui.Factory extends Efl.Ui.Property_Bind, 
Efl.Ui.Factory_Bind
you should rely on @Efl.Ui.View_Factory.create_with_event.]]
  params {
 models: iterator @move; [[Efl iterator providing the 
model to be associated to the new item.
-   It should remain valid until the 
end of the function call.]]
+ It should remain valid until 
the end of the function call.]]
  }
  return: future @move @no_unused; [[Created UI 
object.]]
   }
@@ -36,11 +36,18 @@ interface Efl.Ui.Factory extends Efl.Ui.Property_Bind, 
Efl.Ui.Factory_Bind
   }
}
events {
-  item,constructing: Efl.Gfx.Entity; [[Event triggered when an item is 
under construction (between the @Efl.Object.constructor and 
@Efl.Object.finalize call on the item).
- Note:  If the @Efl.Ui.Factory does 
keep a cache of objects, this won't be called when objects are pulled out of 
the cache.]]
-  item,building: Efl.Gfx.Entity; [[Event triggered when an item has 
processed @Efl.Object.finalize, but before all the factory are done building it.
- Note: if the @Efl.Ui.Factory does keep a 
cache of object, this will be called when object are pulled out of the cache.]]
-  item,created: Efl.Gfx.Entity; [[Event triggered when an item has been 
successfully created by the factory and is about to be used by an 
@Efl.Ui.View.]]
-  item,releasing: Efl.Gfx.Entity; [[Event triggered when an item is being 
released by the @Efl.Ui.Factory. It must be assumed that after this call, the 
object can be recycle to another @Efl.Ui.View and there can be more than one 
call for the same item.]]
+  item,constructing: Efl.Gfx.Entity; [[Event emitted when an item is under 
construction (between the
+   @Efl.Object.constructor and 
@Efl.Object.finalize call on the item).
+   Note: If the @Efl.Ui.Factory keeps 
a cache of objects, this won't be
+   called when objects are pulled from 
the cache.]]
+  item,building: Efl.Gfx.Entity; [[Event emitted when an item has 
processed @Efl.Object.finalize, but before all
+   the factory are done building it.
+   Note: If the @Efl.Ui.Factory keeps a 
cache of objects, this will be called when
+   objects are pulled from the cache.]]
+  item,created: Efl.Gfx.Entity; [[Event emitted when an item has been 
successfully created by the factory and is
+  about to be used by an @Efl.Ui.View.]]
+  item,releasing: Efl.Gfx.Entity; [[Event emitted when an item is being 
released by the @Efl.Ui.Factory.
+It must be assumed that after this 
call, the object can be recycles to another
+@Efl.Ui.View and there can be more 
than one call for the same item.]]
}
 }

-- 




[EGIT] [core/efl] master 01/01: docs: Improve documentation on cache-related classes

2019-10-28 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=368db272fd0bfdc2215ea19ac0ce3b62fc9fd177

commit 368db272fd0bfdc2215ea19ac0ce3b62fc9fd177
Author: Xavi Artigas 
Date:   Mon Oct 28 16:05:08 2019 +0100

docs: Improve documentation on cache-related classes

Also, code comments and typos.
---
 src/lib/efl/interfaces/efl_cached_item.eo| 17 ++---
 src/lib/elementary/efl_ui_caching_factory.c  |  4 ++--
 src/lib/elementary/efl_ui_caching_factory.eo |  7 ---
 3 files changed, 20 insertions(+), 8 deletions(-)

diff --git a/src/lib/efl/interfaces/efl_cached_item.eo 
b/src/lib/efl/interfaces/efl_cached_item.eo
index 533d0faa49..427f75972e 100644
--- a/src/lib/efl/interfaces/efl_cached_item.eo
+++ b/src/lib/efl/interfaces/efl_cached_item.eo
@@ -1,13 +1,24 @@
 interface @beta Efl.Cached.Item
 {
-   [[Efl Cached Item interface]]
+   [[Interface for objects which can be cached in memory.
+
+ Since memory is a limited resource, it is interesting to know how much of 
it an object
+ requires. This interface provides a read-only property for objects to 
report their
+ memory consumption.
+
+ Keep in mind that this should not only take into account by the object 
structure
+ itself, but any dynamic memory it might allocate.
+
+ This is used by @Efl.Ui.Caching_Factory, for example, to keep track of 
the total
+ amount of memory used by the objects the factory creates.
+   ]]
methods {
   @property memory_size {
- [[The memory size associated with an object.]]
+ [[The amount of memory currently used by this object.]]
  get {
  }
  values {
-consumed: uint; [[Bytes of memory consumed by this object.]]
+consumed: uint; [[Bytes of memory.]]
  }
   }
}
diff --git a/src/lib/elementary/efl_ui_caching_factory.c 
b/src/lib/elementary/efl_ui_caching_factory.c
index 5c714d99b8..1ec9bd19c3 100644
--- a/src/lib/elementary/efl_ui_caching_factory.c
+++ b/src/lib/elementary/efl_ui_caching_factory.c
@@ -438,8 +438,8 @@ _efl_ui_caching_factory_pause(void *data, const Efl_Event 
*event EINA_UNUSED)
Efl_Ui_Caching_Factory_Data *pd = data;
Efl_Gfx_Entity *entity;
 
-   // Application is going into background, let's free ressource
-   // Possible improvement would be to delay that by a few second.
+   // Application is going into background, let's free resources.
+   // Possible improvement would be to delay that by a few seconds.
EINA_LIST_FREE(pd->cache, entity)
  efl_del(entity);
 
diff --git a/src/lib/elementary/efl_ui_caching_factory.eo 
b/src/lib/elementary/efl_ui_caching_factory.eo
index 9907da7e05..e3a6c6b7b7 100644
--- a/src/lib/elementary/efl_ui_caching_factory.eo
+++ b/src/lib/elementary/efl_ui_caching_factory.eo
@@ -1,3 +1,5 @@
+parse efl_app;
+
 class @beta Efl.Ui.Caching_Factory extends Efl.Ui.Widget_Factory
 {
[[Efl UI Factory that provides object caching.
@@ -6,14 +8,13 @@ class @beta Efl.Ui.Caching_Factory extends 
Efl.Ui.Widget_Factory
  defined.
  This factory will rely on its parent class @Efl.Ui.Widget_Factory for 
creating the subset of class that match the
  @Efl.Ui.Widget interface.
- The factory will automatically empties the cache when the application 
goes into pause.
+ The factory will automatically empty the cache when the application goes 
into the background
+ (@[Efl.App.pause] event).
 
  Creating objects is costly and time consuming, keeping a few on hand for 
when you next will need them helps a lot.
  This is what this factory caching infrastructure provides. It will create 
the object from the class defined on it
  and set the parent and the model as needed for all created items. The 
View has to release the Item using the
  release function of the Factory interface for all of this to work 
properly.
-
- The cache might decide to flush itself when the application event pause 
is triggered.
]]
methods {
   @property memory_limit {

-- 




[EGIT] [core/efl] master 01/01: Silence mono warning in tests

2019-10-28 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=5299a65d453b59e16cd48741c65974a1fae34916

commit 5299a65d453b59e16cd48741c65974a1fae34916
Author: Xavi Artigas 
Date:   Mon Oct 28 15:12:35 2019 +0100

Silence mono warning in tests

../src/tests/efl_mono/Model.cs(35,13): warning CS0219: The variable 
`veggies' is assigned but its value is never used

This was driving me nuts... Am I the only one seeing these things?
---
 src/tests/efl_mono/Model.cs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/tests/efl_mono/Model.cs b/src/tests/efl_mono/Model.cs
index 54f7200575..63d28d408f 100644
--- a/src/tests/efl_mono/Model.cs
+++ b/src/tests/efl_mono/Model.cs
@@ -32,7 +32,7 @@ public class TestModel {
 {
 Efl.Loop loop = Efl.App.AppMain;
 
-var veggies = CreateModel(loop);
+CreateModel(loop);
 }
 
 internal static async Task EasyModelExtractionAsync (Efl.Loop loop)

-- 




Re: [E-devel] Eolian property setters with return values

2019-10-28 Thread Xavi Artigas
>
> IMO, we should just use a typedef for a known type which generators
> can use to know that it means error, and the typedef documentation
> can mention if false means error, or true means error. Which Eina_Bool
> is not explicit about.
>

Agreed!
Let's move forward with https://phab.enlightenment.org/T8383 then.

Xavi

___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


[EGIT] [tools/examples] master 01/01: Update code comments (and typos)

2019-10-28 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/tools/examples.git/commit/?id=868ed775486f927a2608f6bf04172a9689a2

commit 868ed775486f927a2608f6bf04172a9689a2
Author: Xavi Artigas 
Date:   Mon Oct 28 09:48:42 2019 +0100

Update code comments (and typos)
---
 reference/c/ui/src/ui_container.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/reference/c/ui/src/ui_container.c 
b/reference/c/ui/src/ui_container.c
index 81288a8c..0c7270a0 100644
--- a/reference/c/ui/src/ui_container.c
+++ b/reference/c/ui/src/ui_container.c
@@ -6,7 +6,7 @@
 #include 
 
 /*
- * Efl.UI container exmaples.
+ * Efl.UI container examples.
  *
  * Load and pack a selection of containers.
  * Each has it's own unique layout and methods which are demonstrated below.
@@ -17,7 +17,6 @@
  * TODO - still ELM Conformant
  * TODO - still ELM Mapbuf
  * TODO - still ELM Scroller
- * TODO - still ELM Table
  */
 
 // quit the app, called if the user clicks the Quit button or the window is 
deleted

-- 




[EGIT] [core/efl] master 01/01: Typo in comment

2019-10-28 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=07bca58d6dc4b8f8694216910a92f4abb300cb4e

commit 07bca58d6dc4b8f8694216910a92f4abb300cb4e
Author: Xavi Artigas 
Date:   Mon Oct 28 09:40:33 2019 +0100

Typo in comment
---
 src/bin/eolian_mono/eolian/mono/documentation.hh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/bin/eolian_mono/eolian/mono/documentation.hh 
b/src/bin/eolian_mono/eolian/mono/documentation.hh
index eab15943e7..b57dc4a6de 100644
--- a/src/bin/eolian_mono/eolian/mono/documentation.hh
+++ b/src/bin/eolian_mono/eolian/mono/documentation.hh
@@ -85,7 +85,7 @@ struct documentation_generator
   const char* eo_name = ::eolian_function_name_get(function);
   std::string name = object_ref_conversion(klass);
 
-  // Klass is needed to check the property naming rulles
+  // Klass is needed to check the property naming rules
   attributes::klass_def klass_d((const ::Eolian_Class *)klass, 
eolian_object_unit_get(klass));
 
   // Comment the block below to enable @see reference conversion for 
non-public interface members.

-- 




[EGIT] [core/efl] master 01/01: Efl.Ui.Text: Fix Text Cursor composition

2019-10-25 Thread Xavi Artigas
lauromoura pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=08d7d2b0645cc0c9e18269836c17a709e89c25f1

commit 08d7d2b0645cc0c9e18269836c17a709e89c25f1
Author: Xavi Artigas 
Date:   Fri Oct 25 18:00:31 2019 -0300

Efl.Ui.Text: Fix Text Cursor composition

Summary:
This is a temporary fix while Text is being revamped.
Efl.Ui.Text internally composites Efl.Text_Cursor (through some other 
interfaces)
but this was not being advertised in the EO file.
This caused no trouble to C but was preventing C# from using the Cursors API
(because C# relies on the EO composites section).

On top of this, the cursor_new() method has been removed, since it was 
redundant.

Test Plan:
Builds and passes tests, and C# is able to do things like:
```
Efl.TextCursorCursor cursor = 
screen.GetTextCursor(Efl.TextCursorGetType.Main);
screen.InsertCursorText(cursor, str);
```

Reviewers: lauromoura, cedric, tasn

Reviewed By: lauromoura

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10465
---
 src/lib/elementary/efl_ui_text.c  | 7 ---
 src/lib/elementary/efl_ui_text.eo | 6 +-
 2 files changed, 1 insertion(+), 12 deletions(-)

diff --git a/src/lib/elementary/efl_ui_text.c b/src/lib/elementary/efl_ui_text.c
index a57ca7e4f9..ec32ab3581 100644
--- a/src/lib/elementary/efl_ui_text.c
+++ b/src/lib/elementary/efl_ui_text.c
@@ -3389,13 +3389,6 @@ _efl_ui_text_efl_access_object_i18n_name_get(const Eo 
*obj, Efl_Ui_Text_Data *pd
return ret;
 }
 
-EOLIAN static Efl_Text_Cursor_Cursor *
-_efl_ui_text_cursor_new(Eo *obj EINA_UNUSED, Efl_Ui_Text_Data *sd EINA_UNUSED)
-{
-   Eo *text_obj = sd->text_obj;
-   return efl_text_cursor_new(text_obj);
-}
-
 static void
 _edje_signal_emit(Efl_Ui_Text_Data *sd, const char *sig, const char *src)
 {
diff --git a/src/lib/elementary/efl_ui_text.eo 
b/src/lib/elementary/efl_ui_text.eo
index 2118babe50..e742053eb9 100644
--- a/src/lib/elementary/efl_ui_text.eo
+++ b/src/lib/elementary/efl_ui_text.eo
@@ -5,7 +5,7 @@ class @beta Efl.Ui.Text extends Efl.Ui.Layout_Base implements 
Efl.Input.Clickabl
  Efl.Access.Text, Efl.Access.Editable.Text, Efl.File,
  Efl.Ui.Text_Selectable
composites
- Efl.Text_Interactive, Efl.Text_Markup
+ Efl.Text_Interactive, Efl.Text_Markup, Efl.Text_Cursor
 {
[[A flexible text widget which can be static (as a label) or editable by
  the user (as a text entry). It provides all sorts of editing facilities
@@ -279,10 +279,6 @@ class @beta Efl.Ui.Text extends Efl.Ui.Layout_Base 
implements Efl.Input.Clickabl
 @in data: const(void_ptr) @optional; [[The data to associate with 
the item for related functions.]]
  }
   }
-  cursor_new {
- [[Creates and returns a new cursor for the text.]]
- return: ptr(Efl.Text_Cursor_Cursor); [[Text cursor]]
-  }
}
implements {
   Efl.Object.constructor;

-- 




Re: [E-devel] Eolian property setters with return values

2019-10-25 Thread Xavi Artigas
>
> As for having an error_return flag/type, this also seems fine from a
> functional and documentation perspective, though it feels a bit strange and
> not-intuitive to have a different keyword/return type specific to property
> set methods than is used for methods which return bool.
>

We could use this error_flag everywhere, not just in properties. Since it's
actually an Eina_Bool, there's no API break.
I currently like this idea better than custom eolian tags, for reasons
discussed in
https://phab.enlightenment.org/D10432

We need to take a decision so, unless anybody has anything against it,
we'll start working on the boolean-alias idea next week:
https://phab.enlightenment.org/T8383

Xavi

___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] Eolian property setters with return values

2019-10-21 Thread Xavi Artigas
>
> Maybe in general we need a way to mark a return/parameter as an error
> indicator? It's just a half-baked thought, though maybe worth exploring.
>

There's already a couple of ideas on Phab in this direction: Add custom
tags to Eolian ( https://phab.enlightenment.org/T8294 ) or use Eina.Error
instead of bool when the setter intends to actually return an error.
To avoid breaking API in the second case, we could use a "lightweight eina
error" which is actually a boolean (as Marcel suggests).
I just thought that if we could agree that setters returning bools always
mean "error", we could avoid the extra complexity.

Xavi


>
> --
> Tom
>
> On 21/10/2019 17:49, Xavi Artigas wrote:
> > Hi people,
> >
> > We are encountering a problem when matching EO properties to C#
> properties,
> > since the C# ones cannot have a return value.
> >
> > We mostly use return values in EO property setters to indicate error
> > conditions and this is pretty easily matched to C# by throwing an
> > exception. We just need to know WHEN a returned bool from a setter really
> > means ERROR and when it is not.
> > Currently, all property setters in our tree returning a bool use it to
> > indicate an error, so it is just a matter of we all agreeing that in the
> > future this will always be the case (and documenting it).
> > If we agree on this, then the C# bindings can start throwing exceptions
> on
> > setters returning FALSE (there's a patch ready, but I cannot access it
> > right now).
> >
> > If nobody has anything against it, I'll land this patch in a week
> (October
> > 28th).
> >
> > Thanks!
> > Xavi
> >
> > ___
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >
>
>
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>

___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


[E-devel] Eolian property setters with return values

2019-10-21 Thread Xavi Artigas
Hi people,

We are encountering a problem when matching EO properties to C# properties,
since the C# ones cannot have a return value.

We mostly use return values in EO property setters to indicate error
conditions and this is pretty easily matched to C# by throwing an
exception. We just need to know WHEN a returned bool from a setter really
means ERROR and when it is not.
Currently, all property setters in our tree returning a bool use it to
indicate an error, so it is just a matter of we all agreeing that in the
future this will always be the case (and documenting it).
If we agree on this, then the C# bindings can start throwing exceptions on
setters returning FALSE (there's a patch ready, but I cannot access it
right now).

If nobody has anything against it, I'll land this patch in a week (October
28th).

Thanks!
Xavi

___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


[EGIT] [tools/edocgen] master 01/01: include PROPERTY documentation

2019-10-09 Thread Xavi Artigas
q66 pushed a commit to branch master.

http://git.enlightenment.org/tools/edocgen.git/commit/?id=35b2a10dd5e05e668e025697075076851acff845

commit 35b2a10dd5e05e668e025697075076851acff845
Author: Xavi Artigas 
Date:   Wed Oct 9 20:17:10 2019 +0200

include PROPERTY documentation

This shows the summary of properties in class pages.
---
 docgen/eolian_utils.lua | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docgen/eolian_utils.lua b/docgen/eolian_utils.lua
index 94c1246..52c9e25 100644
--- a/docgen/eolian_utils.lua
+++ b/docgen/eolian_utils.lua
@@ -668,7 +668,7 @@ M.impl_fallback_doc_get = function(obj)
 elseif is and not ig then
 return obj:documentation_get(eolian.function_type.PROP_SET)
 end
-return nil
+return obj:documentation_get(eolian.function_type.PROPERTY)
 end
 
 local revh = {}

-- 




[EGIT] [core/efl] master 02/02: mono-docs: Merge Property and getter/setter docs

2019-10-09 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=9dcfe4bbbce4bef369d4ab7cd23f5c3a61d3a73d

commit 9dcfe4bbbce4bef369d4ab7cd23f5c3a61d3a73d
Author: Xavi Artigas 
Date:   Wed Oct 9 16:18:14 2019 +0200

mono-docs: Merge Property and getter/setter docs

Summary:
Property docs, when present, should always be included in Property and 
Accessor
(setter and getter) docs.
Accessor docs, when present, should be included in their accessor method, 
and
also in the property method, as a side note.
This patch does just that.

Depends on D10285
Ref T8309

Test Plan: Generate docs and take a look at `Efl.Ui.Calendar`, for example, 
which has a bit of everything.

Reviewers: lauromoura

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8309

Differential Revision: https://phab.enlightenment.org/D10298
---
 src/bin/eolian_mono/eolian/mono/documentation.hh | 45 
 1 file changed, 23 insertions(+), 22 deletions(-)

diff --git a/src/bin/eolian_mono/eolian/mono/documentation.hh 
b/src/bin/eolian_mono/eolian/mono/documentation.hh
index 0bdfbda64e..7bcdfc58d6 100644
--- a/src/bin/eolian_mono/eolian/mono/documentation.hh
+++ b/src/bin/eolian_mono/eolian/mono/documentation.hh
@@ -437,20 +437,24 @@ struct documentation_generator
template
bool generate(OutputIterator sink, attributes::property_def const& prop, 
Context const& context) const
{
-   std::string tail_text = "";
-
+   // Generate docs by merging Property, Accessor, Since and Beta pieces.
+   std::string text = prop.documentation.full_text;
+   if (!prop.documentation.since.empty())
+ text += "\\\nSince EFL " + prop.documentation.since + ".";
+   if (prop.setter.is_engaged() && 
!prop.setter->documentation.full_text.empty())
+ text += "\\\n\\Note on writing:\\ " + 
prop.setter->documentation.full_text;
+   if (prop.getter.is_engaged() && 
!prop.getter->documentation.full_text.empty())
+ text += "\\\n\\Note on reading:\\ " + 
prop.getter->documentation.full_text;
if (!prop.klass.is_beta)
  {
 if ((prop.setter.is_engaged() && prop.setter->is_beta) ||
 (prop.getter.is_engaged() && prop.getter->is_beta))
-  {
- tail_text = BETA_PROPERTY_REMARK;
-  }
+  text += BETA_PROPERTY_REMARK;
  }
-   if (!generate(sink, prop.documentation, context, tail_text))
- return false;
+   if (!generate_tag_summary(sink, text, context))
+  return false;
 
-   std::string text;
+   text = "";
if (prop.setter.is_engaged())
  text = prop.setter->parameters[0].documentation.full_text;
else if (prop.getter.is_engaged())
@@ -478,21 +482,18 @@ struct documentation_generator
template
bool generate_property(OutputIterator sink, attributes::function_def const& 
func, Context const& context) const
{
-   std::string tail_text = "";
-   if (!func.klass.is_beta && func.is_beta)
- {
-tail_text = BETA_METHOD_REMARK;
- }
-
-   // First, try the get/set specific documentation
-   if (!func.documentation.summary.empty())
- {
-if (!generate(sink, func.documentation, context, tail_text))
-  return false;
- }
-   else // fallback to common property documentation
+   if (!func.documentation.full_text.empty() ||
+   !func.property_documentation.full_text.empty())
  {
-if (!generate(sink, func.property_documentation, context, 
tail_text))
+// Generate docs by merging Property, Accessor, Since and Beta 
pieces.
+std::string text = func.property_documentation.full_text;
+if (!func.property_documentation.since.empty())
+  text += "\\\nSince EFL " + 
func.property_documentation.since + ".";
+if (!func.documentation.full_text.empty())
+  text += "\\\n\\Note:\\ " + 
func.documentation.full_text;
+if (!func.klass.is_beta && func.is_beta)
+  text += BETA_METHOD_REMARK;
+if (!generate_tag_summary(sink, text, context))
   return false;
  }
 

-- 




[EGIT] [website/www-content] master 01/01: Wiki page section changed with summary [created] by Xavi Artigas

2019-10-08 Thread Xavi Artigas
WWW-www.enlightenment.org pushed a commit to branch master.

http://git.enlightenment.org/website/www-content.git/commit/?id=d586f1fac501ff14107bb3661eec4001000994f6

commit d586f1fac501ff14107bb3661eec4001000994f6
Author: Xavi Artigas 
Date:   Tue Oct 8 02:19:14 2019 -0700

Wiki page section changed with summary [created] by Xavi Artigas
---
 pages/develop/api-include/efl/ui/efl.ui.radio_box/section.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/pages/develop/api-include/efl/ui/efl.ui.radio_box/section.txt 
b/pages/develop/api-include/efl/ui/efl.ui.radio_box/section.txt
new file mode 100644
index 0..86b607d9e
--- /dev/null
+++ b/pages/develop/api-include/efl/ui/efl.ui.radio_box/section.txt
@@ -0,0 +1 @@
+Testing.
\ No newline at end of file

-- 




[EGIT] [core/efl] master 01/01: docs: Remove redundant documentation

2019-10-07 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=5a447ed3273b6b80d9e48aea3cddfcafa1cb8c33

commit 5a447ed3273b6b80d9e48aea3cddfcafa1cb8c33
Author: Xavi Artigas 
Date:   Mon Oct 7 16:40:50 2019 +0200

docs: Remove redundant documentation

Lots of EO files had the same information at the property and set/get level.
Removed the redundant bits, and moved to the property level the common ones.
Set and Get documentation should be used only to clarify setter-only or
getter-only behavior.
---
 src/lib/ecore/efl_loop_consumer.eo |  5 ++-
 src/lib/edje/efl_canvas_layout_part.eo |  1 -
 src/lib/edje/efl_layout_calc.eo|  2 --
 src/lib/edje/efl_layout_group.eo   |  2 +-
 src/lib/efl/interfaces/efl_gfx_filter.eo   |  1 -
 src/lib/efl/interfaces/efl_gfx_hint.eo |  1 -
 .../interfaces/efl_gfx_image_load_controller.eo| 20 ---
 src/lib/efl/interfaces/efl_model.eo|  2 +-
 src/lib/efl/interfaces/efl_ui_drag.eo  | 12 ---
 src/lib/efl/interfaces/efl_ui_i18n.eo  |  2 --
 src/lib/efl/interfaces/efl_ui_menu.eo  |  8 ++---
 src/lib/elementary/efl_access_text.eo  |  3 +-
 src/lib/elementary/efl_access_value.eo |  3 +-
 src/lib/elementary/efl_ui_calendar.eo  | 42 +-
 .../elementary/efl_ui_internal_text_scroller.eo|  4 +--
 src/lib/elementary/efl_ui_theme.eo |  1 -
 src/lib/elementary/efl_ui_view_model.eo|  2 --
 src/lib/elementary/efl_ui_widget.eo| 34 +-
 src/lib/elementary/efl_ui_win.eo   | 21 ++-
 src/lib/evas/canvas/efl_canvas_group.eo|  1 -
 20 files changed, 45 insertions(+), 122 deletions(-)

diff --git a/src/lib/ecore/efl_loop_consumer.eo 
b/src/lib/ecore/efl_loop_consumer.eo
index 35053265ea..e384240c0b 100644
--- a/src/lib/ecore/efl_loop_consumer.eo
+++ b/src/lib/ecore/efl_loop_consumer.eo
@@ -9,12 +9,11 @@ abstract Efl.Loop_Consumer extends Efl.Object
c_prefix: efl_loop;
methods {
   @property loop {
- [[The loop to which this object belongs to.]]
+ [[Handle of the loop this object belongs to.]]
  get {
-[[Gets a handle to the loop.]]
  }
  values {
-loop: Efl.Loop; [[Efl loop]]
+loop: Efl.Loop; [[Efl loop.]]
  }
   }
   future_resolved @const {
diff --git a/src/lib/edje/efl_canvas_layout_part.eo 
b/src/lib/edje/efl_canvas_layout_part.eo
index eed8aaf0de..9346cc68d5 100644
--- a/src/lib/edje/efl_canvas_layout_part.eo
+++ b/src/lib/edje/efl_canvas_layout_part.eo
@@ -27,7 +27,6 @@ class @beta Efl.Canvas.Layout_Part extends Efl.Object 
implements Efl.Gfx.Entity,
   @property part_type {
  [[Type of this part in the layout.]]
  get {
-[[Returns the type of the part.]]
  }
  values {
 type: 
Efl.Canvas.Layout_Part_Type(Efl.Canvas.Layout_Part_Type.none);
diff --git a/src/lib/edje/efl_layout_calc.eo b/src/lib/edje/efl_layout_calc.eo
index 0417629b0e..1f77db64fc 100644
--- a/src/lib/edje/efl_layout_calc.eo
+++ b/src/lib/edje/efl_layout_calc.eo
@@ -26,10 +26,8 @@ interface Efl.Layout.Calc
event.
  ]]
  set {
-[[Enable or disable auto-update of size hints.]]
  }
  get {
-[[Whether this object updates its size hints automatically.]]
  }
  values {
 update: bool(false); [[Whether or not update the size hints.]]
diff --git a/src/lib/edje/efl_layout_group.eo b/src/lib/edje/efl_layout_group.eo
index df1d9dc5ac..77113abc81 100644
--- a/src/lib/edje/efl_layout_group.eo
+++ b/src/lib/edje/efl_layout_group.eo
@@ -111,7 +111,7 @@ interface Efl.Layout.Group
 
See also @Efl.Canvas.Layout_Part.part_type.
  ]]
- get { [[Returns $true if the part exists in the EDC group.]] }
+ get {}
  keys {
 part: string; [[The part name to check.]]
  }
diff --git a/src/lib/efl/interfaces/efl_gfx_filter.eo 
b/src/lib/efl/interfaces/efl_gfx_filter.eo
index ed74c087fd..ecb306f5f3 100644
--- a/src/lib/efl/interfaces/efl_gfx_filter.eo
+++ b/src/lib/efl/interfaces/efl_gfx_filter.eo
@@ -59,7 +59,6 @@ interface @beta Efl.Gfx.Filter
by using the function 'padding_set' in the Lua program.
  ]]
  get {
-[[Gets the padding required to apply this filter.]]
  }
  values {
 l: int; [[Padding on the left]]
diff --git a/src/lib/efl/interfaces/efl_gfx_hint.eo 
b/src/lib/efl/interfaces/efl_gfx_hint.eo
index 5906b2523f..3511592ead 100644
--- a/src/lib/efl/interfaces/efl_gfx_hint.eo
+++ b/src/lib/efl/interfaces/efl_gfx_hint.eo
@@ -99,7 +99,6 @@ interface Efl.Gfx.Hint
 ]]
  }
  get

[EGIT] [website/www-content] master 01/01: Wiki page start changed with summary [typo] by Xavi Artigas

2019-10-03 Thread Xavi Artigas
WWW-www.enlightenment.org pushed a commit to branch master.

http://git.enlightenment.org/website/www-content.git/commit/?id=a51083242e234817a8049b2bf783a2c33b806f3b

commit a51083242e234817a8049b2bf783a2c33b806f3b
Author: Xavi Artigas 
Date:   Thu Oct 3 08:40:38 2019 -0700

Wiki page start changed with summary [typo] by Xavi Artigas
---
 pages/docs/start.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pages/docs/start.txt b/pages/docs/start.txt
index e8bef2b3a..a5b8c2da1 100755
--- a/pages/docs/start.txt
+++ b/pages/docs/start.txt
@@ -36,7 +36,7 @@ distro/platform, you can see the latest information at
 The EFL is currently undergoing a significant redesign to give a better
 developer experience when building apps using our platform. We will be
 announcing the new API shortly to get early feedback from developers but
-for now we recommend using the stable API and it's Bindings.
+for now we recommend using the stable API and its Bindings.
 
 You can find all the documentation for our [[/develop/legacy/api/c/|stable C 
API]],
 and bindings to 
[[https://docs.enlightenment.org/auto/group__Efl__Cxx__API.html|C++]] and 

-- 




[EGIT] [tools/examples] master 01/02: Game of Life: Remove last uses of Legacy API

2019-10-03 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/tools/examples.git/commit/?id=0a23c904cbfd702d52e2cab260b40ad06d6b0f58

commit 0a23c904cbfd702d52e2cab260b40ad06d6b0f58
Author: Xavi Artigas 
Date:   Thu Oct 3 12:12:38 2019 +0200

Game of Life: Remove last uses of Legacy API
---
 apps/c/life/src/life_main.c   | 6 +++---
 apps/c/life/src/life_render.c | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/apps/c/life/src/life_main.c b/apps/c/life/src/life_main.c
index 93728cfa..0a754fbb 100644
--- a/apps/c/life/src/life_main.c
+++ b/apps/c/life/src/life_main.c
@@ -51,12 +51,12 @@ _life_win_key_down(void *data EINA_UNUSED, const Efl_Event 
*event)
  life_board_pause_toggle(win);
 }
 
-static Evas_Object *
+static Efl_Ui_Win *
 _life_win_setup(void)
 {
Efl_Ui_Win *win;
-   Evas_Coord w;
-   Evas_Coord h;
+   int w;
+   int h;
 
win = efl_add(EFL_UI_WIN_CLASS, efl_main_loop_get(),
  efl_ui_win_type_set(efl_added, EFL_UI_WIN_TYPE_BASIC),
diff --git a/apps/c/life/src/life_render.c b/apps/c/life/src/life_render.c
index 32777f35..f5bafacc 100644
--- a/apps/c/life/src/life_render.c
+++ b/apps/c/life/src/life_render.c
@@ -46,7 +46,7 @@ life_render_layout(Efl_Ui_Win *win)
 {
Eina_Size2D size;
double cw, ch;
-   Evas_Object *rect;
+   Efl_Canvas_Rectangle *rect;
int x, y;
 
size = efl_gfx_entity_size_get(win);
@@ -67,7 +67,7 @@ life_render_layout(Efl_Ui_Win *win)
 void
 life_render_cell(Efl_Ui_Win *win EINA_UNUSED, int x, int y)
 {
-   Evas_Object *rect;
+   Efl_Canvas_Rectangle *rect;
int i;
 
i = life_render_index_for_position(x, y);

-- 




[EGIT] [tools/examples] master 02/02: Adapt examples to latest Unified API changes

2019-10-03 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/tools/examples.git/commit/?id=b8fd0c3b74d5a7c9db92c187daddfdf2a3add4c9

commit b8fd0c3b74d5a7c9db92c187daddfdf2a3add4c9
Author: Xavi Artigas 
Date:   Thu Oct 3 12:19:03 2019 +0200

Adapt examples to latest Unified API changes

Efl.Ui.Text headers have to be manually included for now, since they still 
depend
on Legacy headers.
Padding API has lost a parameter.
---
 apps/c/texteditor/src/texteditor_main.c | 4 +++-
 reference/c/ui/src/focus_main.c | 4 +++-
 reference/c/ui/src/ui_container.c   | 5 +++--
 reference/csharp/ui/src/ui_container.cs | 2 +-
 tutorial/c/hello-gui/src/gui_main.c | 4 +++-
 5 files changed, 13 insertions(+), 6 deletions(-)

diff --git a/apps/c/texteditor/src/texteditor_main.c 
b/apps/c/texteditor/src/texteditor_main.c
index 7a5501bb..bc70b618 100644
--- a/apps/c/texteditor/src/texteditor_main.c
+++ b/apps/c/texteditor/src/texteditor_main.c
@@ -1,8 +1,10 @@
 #define EFL_BETA_API_SUPPORT 1
 
-#include 
 #include 
 #include 
+// Temporary workaround until Unified Text stops using Legacy classes 
internally
+#include 
+#include 
 
 Efl_Ui_Text *_editor;
 Efl_Ui_Button *_toolbar_new;
diff --git a/reference/c/ui/src/focus_main.c b/reference/c/ui/src/focus_main.c
index 5bd14dde..d4f678eb 100644
--- a/reference/c/ui/src/focus_main.c
+++ b/reference/c/ui/src/focus_main.c
@@ -1,8 +1,10 @@
 #define EFL_BETA_API_SUPPORT 1
 
-#include 
 #include 
 #include 
+// Temporary workaround until Unified Text stops using Legacy classes 
internally
+#include 
+#include 
 
 static void
 _gui_about_clicked_cb(void *data EINA_UNUSED, const Efl_Event *event 
EINA_UNUSED)
diff --git a/reference/c/ui/src/ui_container.c 
b/reference/c/ui/src/ui_container.c
index 166a458a..81288a8c 100644
--- a/reference/c/ui/src/ui_container.c
+++ b/reference/c/ui/src/ui_container.c
@@ -1,8 +1,9 @@
 #define EFL_BETA_API_SUPPORT 1
 
-#include 
 #include 
 #include 
+// Temporary workaround until Unified Text stops using Legacy classes 
internally
+#include 
 
 /*
  * Efl.UI container exmaples.
@@ -61,7 +62,7 @@ _ui_boxes_setup(Efl_Ui_Win *win)
int i;
 
box = efl_add(EFL_UI_BOX_CLASS, win,
- efl_gfx_arrangement_content_padding_set(efl_added, 5, 0, 
EINA_TRUE));
+ efl_gfx_arrangement_content_padding_set(efl_added, 5, 0));
 
for (i = 1; i <= 4; i++)
  {
diff --git a/reference/csharp/ui/src/ui_container.cs 
b/reference/csharp/ui/src/ui_container.cs
index 5379ee66..f52a5bdb 100644
--- a/reference/csharp/ui/src/ui_container.cs
+++ b/reference/csharp/ui/src/ui_container.cs
@@ -14,7 +14,7 @@ public class Example : Efl.Csharp.Application
 {
 Efl.Ui.Box box = new Efl.Ui.Box(win);
 // Set distance between contained elements
-box.SetContentPadding(5, 0, true);
+box.SetContentPadding(5, 0);
 
 for (int i = 1; i <= 4; ++i)
 {
diff --git a/tutorial/c/hello-gui/src/gui_main.c 
b/tutorial/c/hello-gui/src/gui_main.c
index b67249b6..882443f6 100644
--- a/tutorial/c/hello-gui/src/gui_main.c
+++ b/tutorial/c/hello-gui/src/gui_main.c
@@ -1,8 +1,10 @@
 #define EFL_BETA_API_SUPPORT 1
 
-#include 
 #include 
 #include 
+// Temporary workaround until Unified Text stops using Legacy classes 
internally
+#include 
+#include 
 
 static void
 _gui_quit_cb(void *data EINA_UNUSED, const Efl_Event *event EINA_UNUSED)

-- 




[EGIT] [core/efl] master 01/01: evas: silence compiler warning in textblock

2019-10-02 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=5e5aac50065abfd12da8bd90fa1b8dec5e86aea7

commit 5e5aac50065abfd12da8bd90fa1b8dec5e86aea7
Author: Xavi Artigas 
Date:   Wed Oct 2 16:37:33 2019 +0200

evas: silence compiler warning in textblock

Uninitialized variable.
---
 src/lib/evas/canvas/evas_object_textblock.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/evas/canvas/evas_object_textblock.c 
b/src/lib/evas/canvas/evas_object_textblock.c
index 82c66e3c0d..1ec71f2f53 100644
--- a/src/lib/evas/canvas/evas_object_textblock.c
+++ b/src/lib/evas/canvas/evas_object_textblock.c
@@ -9737,7 +9737,7 @@ 
_evas_textblock_cursor_cluster_pos_get(Evas_Textblock_Cursor *cur, Eina_Bool inc
Evas_Text_Props_Info *info = ti->text_props.info;
int it_index = ((inc) ? cur->pos : ret) - 
last_it->text_pos;
 
-   Evas_Font_OT_Info ot;
+   Evas_Font_OT_Info ot = {0};
if (ti->text_props.len != ti->text_props.text_len)/*if 
code point count same as glyph count skip it*/
  {
 Evas_BiDi_Direction itdir = 
ti->text_props.bidi_dir;

-- 




[EGIT] [tools/examples] master 01/01: cs snippets: small updates to Slider and Box

2019-10-02 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/tools/examples.git/commit/?id=6dfa4bac1dbebac00fc5fef44b3d82e33ad57ca7

commit 6dfa4bac1dbebac00fc5fef44b3d82e33ad57ca7
Author: Xavi Artigas 
Date:   Wed Oct 2 16:27:28 2019 +0200

cs snippets: small updates to Slider and Box
---
 reference/csharp/snippets/Efl.Ui.Box.cs| 3 ++-
 reference/csharp/snippets/Efl.Ui.Slider.cs | 7 +++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/reference/csharp/snippets/Efl.Ui.Box.cs 
b/reference/csharp/snippets/Efl.Ui.Box.cs
index 48c1488c..09ad6d87 100644
--- a/reference/csharp/snippets/Efl.Ui.Box.cs
+++ b/reference/csharp/snippets/Efl.Ui.Box.cs
@@ -1,6 +1,7 @@
 Efl.Ui.Box box = new Efl.Ui.Box(parent);
 
-//Creating content which we will pack into the box - it can be any widgets, 
for example buttons.
+//Creating content which we will pack into the box
+//It can be any widget, for example, buttons
 Efl.Ui.Button button1 = new Efl.Ui.Button(box);
 Efl.Ui.Button button2 = new Efl.Ui.Button(box);
 
diff --git a/reference/csharp/snippets/Efl.Ui.Slider.cs 
b/reference/csharp/snippets/Efl.Ui.Slider.cs
index 5205a7d2..def44397 100644
--- a/reference/csharp/snippets/Efl.Ui.Slider.cs
+++ b/reference/csharp/snippets/Efl.Ui.Slider.cs
@@ -3,7 +3,14 @@ Efl.Ui.Slider slider = new Efl.Ui.Slider(parent);
 slider.SetRangeLimits(0, 100);
 slider.SetRangeValue(50);
 
+// You get this event every time the slider moves
 slider.ChangedEvent += (sender, args) =>
 {
 Console.WriteLine("Current slider value is: " + slider.GetRangeValue());
 };
+
+// You only get this event once the slider is stable
+slider.SteadyEvent += (sender, args) =>
+{
+Console.WriteLine("STEADY slider value is: " + slider.GetRangeValue());
+};

-- 




[EGIT] [core/efl] master 01/01: docs: Fix problems with monospaced text

2019-10-02 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=f53583a5c91cc0e960d8177555919f168281ac15

commit f53583a5c91cc0e960d8177555919f168281ac15
Author: Xavi Artigas 
Date:   Wed Oct 2 11:31:19 2019 +0200

docs: Fix problems with monospaced text

Eolian recently added support for $[...] which allows highlighting
more than one word in monospaced text.
---
 src/lib/efl/interfaces/efl_text_markup_util.eo | 16 +++-
 src/lib/elementary/efl_ui_average_model.eo |  4 ++--
 src/lib/elementary/efl_ui_exact_model.eo   |  8 
 src/lib/elementary/efl_ui_homogeneous_model.eo | 14 +++---
 src/lib/elementary/efl_ui_size_model.eo| 10 +-
 5 files changed, 25 insertions(+), 27 deletions(-)

diff --git a/src/lib/efl/interfaces/efl_text_markup_util.eo 
b/src/lib/efl/interfaces/efl_text_markup_util.eo
index 90d63e10d4..7f83a10272 100644
--- a/src/lib/efl/interfaces/efl_text_markup_util.eo
+++ b/src/lib/efl/interfaces/efl_text_markup_util.eo
@@ -5,23 +5,21 @@ class @beta Efl.Text_Markup_Util {
methods {
   text_to_markup @static {
  [[Converts a given (UTF-8) text to a markup-compatible string.
-   This is used mainly to set a plain text with the $.markup_set
-   property.
+   This is used mainly to set a plain text with 
@Efl.Text_Markup.markup.set.
  ]]
  params {
-@in text: string; [[The text (UTF-8) to convert to markup]]
+@in text: string; [[The text (UTF-8) to convert to markup.]]
  }
- return: mstring @move; [[The markup representation of given text]]
+ return: mstring @move; [[The markup representation of given text.]]
   }
   markup_to_text @static {
- [[Converts a given (UTF-8) text to a markup-compatible string.
-   This is used mainly to set a plain text with the $.markup_set
-   property.
+ [[Converts a markup string to a (UTF-8) plain text.
+   This is used mainly to set a markup text with the 
@Efl.Text.text.set.
  ]]
  params {
-@in text: string; [[The markup-text to convert to text (UTF-8)]]
+@in text: string; [[The markup-text to convert to text (UTF-8).]]
  }
- return: mstring @move; [[The text representation of given format]]
+ return: mstring @move; [[The text representation of given markup 
string.]]
   }
}
 }
diff --git a/src/lib/elementary/efl_ui_average_model.eo 
b/src/lib/elementary/efl_ui_average_model.eo
index 98d97598f8..9c1413995a 100644
--- a/src/lib/elementary/efl_ui_average_model.eo
+++ b/src/lib/elementary/efl_ui_average_model.eo
@@ -3,10 +3,10 @@ class @beta Efl.Ui.Average_Model extends Efl.Ui.Exact_Model
[[Class to be used to store object item size for List/Grid View.
 
This model provide the same feature as @Efl.Ui.Exact_Model except for the
-   @Efl.Model.property "$total.width" and "$total.height" which reflect an
+   @Efl.Model.property $["total.width"] and $["total.height"] which reflect an
estimated value of the total size by using the currently know size from its
children as an average size for all its children. As more children fill
-   "$self.width" and "$self.height", this model will figure out a more precise
+   $["self.width"] and $["self.height"], this model will figure out a more 
precise
answer. Once all children size is known, the result will be exact and the 
same
as @Efl.Ui.Exact_Model.
 
diff --git a/src/lib/elementary/efl_ui_exact_model.eo 
b/src/lib/elementary/efl_ui_exact_model.eo
index 691a7504ef..0e63976e54 100644
--- a/src/lib/elementary/efl_ui_exact_model.eo
+++ b/src/lib/elementary/efl_ui_exact_model.eo
@@ -2,13 +2,13 @@ class @beta Efl.Ui.Exact_Model extends Efl.Ui.Size_Model
 {
[[Class to be used to store object item size for List/Grid View.
 
-   This model provide "$total.width" and "$total.height" as an accumulated 
size of all
-   its children "$self.width" and "$self.height" @Efl.Model.property. This is 
currently
+   This model provide $["total.width"] and $["total.height"] as an accumulated 
size of all
+   its children $["self.width"] and $["self.height"] @Efl.Model.property. This 
is currently
assuming a vertical list only.
 
-   This model will return an error code EAGAIN for "$item.width" and 
"$item.height" all
+   This model will return an error code $EAGAIN for $["item.width"] and 
$["item.height"] all
the time and the View that use this Model should continue to get this value 
even after
-   computing all the "$self.width" and "$self.height" of this object 
children.]]
+   computing all the $["self.width"] and $["self.height"] of this 

Re: [E-devel] Enlightenment Foundation Libraries 1.23 Release

2019-10-01 Thread Xavi Artigas
Yeah! Thanks man.

Xavi

On Tue, 1 Oct 2019 at 19:45, Michael Blumenkrantz <
michael.blumenkra...@gmail.com> wrote:

> Stefan, thanks again for putting in all the time to make this happen. I
> really appreciate your work, and I'm sure everyone working on EFL feels the
> same.
>
>
> Mike
>
> On Tue, 1 Oct 2019 15:11:22 +0200
> Stefan Schmidt  wrote:
>
> > After almost 6 months of development we are releasing version 1.23 of
> > the Enlightenment Foundation Libraries, featuring over 2100 patches from
> > 48 developers around the world. Thanks a lot for your contributions!
> >
> > == Download ==
> >
> > http://download.enlightenment.org/rel/libs/efl/efl-1.23.0.tar.xz
> > cd9625161b324621f873f00eb841de03398892078ce73d60205abd1766c15cc5
> >
> > 
> >
> > == What's New ==
> >
> > Again, the primary focus of this release has been stabilizing the EO
> > library as well as an extending the set of unified API which is based on
> it.
> >  From this release onwards we also switched to meson as our only build
> > system (RIP autotools, you served us well for a long time). The 2110
> > commits contain more changes to possible list here, but you will find
> > improved DRM support, a new widget for controlling vector animations, a
> > first step towards MVVM support, general bugfixes and more.
> >
> > Please see the NEWS file for more details.
> >
> > 
> >
> > == Statistics ==
> >
> > (git log --pretty=oneline v1.22.0..v1.23.0 | wc -l) \\
> > Number of commits in 1.23: 2110 \\
> > Number of commits in 1.22: 2152 \\
> >
> > (git shortlog -ns v1.22.0..v1.23.0 | wc -l) \\
> > Number of authors in 1.23: 48 \\
> > Number of authors in 1.22: 55 \\
> >
> > (git diff --stat v1.22.0..v1.23.0 | tail -1) \\
> > 2296 files changed, 90115 insertions(+), 85554 deletions(-) in 1.23 \\
> > 3154 files changed, 169564 insertions(+), 79861 deletions(-) in 1.22 \\
> >
> > 
> >
> > === Compiling and installing ===
> >
> > See the INSTALL file:
> > https://git.enlightenment.org/core/efl.git/tree/INSTALL
> >
> > == Requirements ==
> >
> > EFL requires a C and C++ compiler by default. C++ exists mostly to
> interface
> > to C++ libraries like Bullet and our C++ bindings.
> >
> > Required by default:
> >
> >* bullet
> >* libpng
> >* libjpeg
> >* gstreamer (1.x, 0.10 support optional. Ensure all codecs you want
> > are installed.)
> >* zlib
> >* luajit (lua 5.1 or 5.2 support optional)
> >* libtiff
> >* openssl
> >* curl
> >* dbus
> >* libc
> >* fontconfig
> >* freetype2
> >* fribidi
> >* libpulse
> >* libsndfile
> >* libx11
> >* libxau
> >* libxcomposite
> >* libxdamage
> >* libxdmcp
> >* libxext
> >* libxfixes
> >* libxinerama
> >* libxrandr
> >* libxrender
> >* libxss
> >* libxtst
> >* libxcursor
> >* libxp
> >* libxi (2.2 or newer)
> >* opengl(mesa etc.) (opengl/glx/full or opengl-es2/egl. full opengl
> > only on osx - must be explicitly specified to be full to have support)
> >* giflib
> >* util-linux (limbount + libblkid)
> >* systemd / libudev
> >* poppler / poppler-cpp
> >* libraw
> >* libspectre
> >* librsvg
> >* openmp (clang needs libomp, while gcc uses libgomp)
> >
> > You might want webp support so disable fewer loaders and remove webp
> > from the disablers with: -Devas-loaders-disabler=json
> >
> > == Wayland support ==
> >
> > You may also want wayland support when on Linux. This enables support
> > for EFL to trget wayland support for client applications. To do this
> > supply: -Dwl=true
> >
> > == Framebuffer support ==
> >
> > This requires linux frame-buffer support, headers etc. This supports
> > basic frame-buffers like /dev/fb as well as input via /dev/input for
> > keyboards and mice in a basic way. Enable this with: -Dfb=true
> >
> > For more modern framebuffer support you may want drm/kms rendering
> > support so enable this. This is what you also want for wayland
> > compositor support in enlightenment as it will want to be able to
> > render to a moder framebuffer tarbet with atomic buffer swapping. To
> > do this provide: -Ddrm=true
> >
> > == Prefix ==
> >
> > You may want to change the install prefix for EFL with:
> > --prefix=/path/to/prefix
> >
> > The default prefix if not given is "/usr/local". Many people like to
> > use prefixes like /opt/e or /opt/efl or /home/USERNAME/software etc.
> >
> > == Compiler flags ==
> >
> > You can affect compilation optimization, debugging and other factors
> > by setting your CFLAGS environment variable (and CXXFLAGS). Be aware
> > that to ensure ABI stability you should use the exact same CFLAGS /
> > CXXFLAGS for all the build of EFL and any applications/libraries that
> > depend on them.
> >
> > There are many other configure options that can be used, but in
> > general it is not a good idea to go enabling or disabling things
> > unless you wish to break things. The defaults are well tested, with
> > the 

[EGIT] [core/efl] master 01/01: Revert "eolian: disallow missing docs for stable API where necessary"

2019-09-30 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=835e230f2fefa14cdfae7af84dc5afbc40bca985

commit 835e230f2fefa14cdfae7af84dc5afbc40bca985
Author: Xavi Artigas 
Date:   Mon Sep 30 19:48:19 2019 +0200

Revert "eolian: disallow missing docs for stable API where necessary"

I'm afraid but this breaks the mono bindings too close to a release.
This also fixes the missing docs errors by adding a lot of inconsistent
placeholder text ("No description supplied.", "TBD") which will make
finding them later on more complicated.

I was the one that asked for this feature but it is not critical at this
point, so I suggest we explore some refinements (like T8291) before landing
this patch in its current state.

This reverts commit 2946cb3c325f27d77354ac1b83b614e3a1d9e1d5.
---
 src/lib/ecore/efl_loop_model.eo  |   1 -
 src/lib/eolian/database_validate.c   |  65 ++--
 src/tests/ecore/ecore_audio_out_test.eo  |   1 -
 src/tests/ecore/efl_app_test_cml.eo  |   2 +-
 src/tests/efl_mono/dummy_child.eo|   6 +-
 src/tests/efl_mono/dummy_constructible_object.eo |   9 -
 src/tests/efl_mono/dummy_event_manager.eo|   5 +-
 src/tests/efl_mono/dummy_hidden_object.eo|   1 -
 src/tests/efl_mono/dummy_inherit_helper.eo   |   3 -
 src/tests/efl_mono/dummy_inherit_iface.eo|   2 -
 src/tests/efl_mono/dummy_numberwrapper.eo|   2 -
 src/tests/efl_mono/dummy_part_holder.eo  |   2 +-
 src/tests/efl_mono/dummy_test_iface.eo   |   8 -
 src/tests/efl_mono/dummy_test_object.eo  | 366 +++
 src/tests/eina_cxx/eina_simple.eo|   1 -
 src/tests/elementary/focus_manager_test.eo   |   2 +-
 src/tests/elementary/focus_test.eo   |   3 -
 src/tests/elementary/focus_test_sub_main.eo  |   1 -
 src/tests/eolian/data/base.eo|   4 -
 src/tests/eolian/data/class_funcs.eo |   7 -
 src/tests/eolian/data/class_requires.eo  |   2 +-
 src/tests/eolian/data/complex_type.eo|   3 -
 src/tests/eolian/data/consts.eo  |   1 -
 src/tests/eolian/data/ctor_dtor.eo   |   4 -
 src/tests/eolian/data/enum.eo|  10 +-
 src/tests/eolian/data/events.eo  |  10 +-
 src/tests/eolian/data/extern.eo  |   8 +-
 src/tests/eolian/data/free_func.eo   |   8 +-
 src/tests/eolian/data/function_as_argument.eo|   3 -
 src/tests/eolian/data/function_as_argument_ref.h |  21 --
 src/tests/eolian/data/function_types.eot |   4 -
 src/tests/eolian/data/function_types_ref.h   |  16 -
 src/tests/eolian/data/iface.eo   |   5 +-
 src/tests/eolian/data/import.eo  |   2 -
 src/tests/eolian/data/import_types.eot   |   3 +-
 src/tests/eolian/data/import_types_ref.h |   8 -
 src/tests/eolian/data/mixins_require.eo  |   3 +-
 src/tests/eolian/data/nmsp1_class1.eo|   1 -
 src/tests/eolian/data/nmsp1_nmsp11_class2.eo |   2 -
 src/tests/eolian/data/nmsp2_class1.eo|   1 -
 src/tests/eolian/data/no_nmsp.eo |   2 -
 src/tests/eolian/data/object_impl.eo |   6 -
 src/tests/eolian/data/object_impl_add.eo |   2 -
 src/tests/eolian/data/override.eo|   6 -
 src/tests/eolian/data/parts.eo   |   1 -
 src/tests/eolian/data/scope.eo   |   7 -
 src/tests/eolian/data/struct.eo  |   9 +-
 src/tests/eolian/data/struct_ref.h   |  20 --
 src/tests/eolian/data/struct_ref_stub.h  |  12 -
 src/tests/eolian/data/typedef.eo |  15 +-
 src/tests/eolian/data/typedef_ref.h  |  32 --
 src/tests/eolian/data/typedef_ref_stub.h |  16 -
 src/tests/eolian/data/unimpl.eo  |   1 -
 src/tests/eolian/data/var.eo |   4 +-
 src/tests/eolian/data_aux/aux_a.eo   |   5 +-
 src/tests/eolian/data_aux/aux_b.eo   |   1 -
 src/tests/eolian/data_aux/aux_c.eo   |   7 +-
 src/tests/eolian/generated_future.eo |   1 -
 src/tests/eolian_cxx/a.eo|   1 -
 src/tests/eolian_cxx/b.eo|   1 -
 src/tests/eolian_cxx/c.eo|   1 -
 src/tests/eolian_cxx/complex.eo  |  40 ---
 src/tests/eolian_cxx/cyclic1.eo  |   2 -
 src/tests/eolian_cxx/cyclic2.eo  |   2 -
 src/tests/eolian_cxx/generic.eo  |  43 +--
 src/tests/eolian_cxx/generic_interface.eo|   1 -
 src/tests/eolian_cxx/name_name.eo|   1 -
 src/tests/eolian_cxx/ns_name.eo  |   1 -
 src/tests/eolian_cxx/ns_name_other.eo|   1 -
 src/tests/eolian_cxx/property_holder.

[EGIT] [core/efl] master 01/01: mono-docs: Formatting of @since tags

2019-09-30 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=09859cacf29d23dfa62fa1b9ac3efd897ac1c3f7

commit 09859cacf29d23dfa62fa1b9ac3efd897ac1c3f7
Author: Xavi Artigas 
Date:   Mon Sep 30 18:05:07 2019 +0200

mono-docs: Formatting of @since tags

Use a line break  now that we can properly escape these things.
Previously we appended (Since EFL X.XX) which didn't look very nice.
---
 src/bin/eolian_mono/eolian/mono/documentation.hh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/bin/eolian_mono/eolian/mono/documentation.hh 
b/src/bin/eolian_mono/eolian/mono/documentation.hh
index 6ed8169632..0035754dbe 100644
--- a/src/bin/eolian_mono/eolian/mono/documentation.hh
+++ b/src/bin/eolian_mono/eolian/mono/documentation.hh
@@ -560,7 +560,7 @@ struct documentation_generator
{
   std::string str = doc.full_text;
   if (!doc.since.empty())
-str += "\n(Since EFL " + doc.since + ")";
+str += "\\Since EFL " + doc.since;
   str += tail_text;
   return generate_tag_summary(sink, str, context);
}

-- 




[EGIT] [core/efl] master 01/01: mono-docs: Add some missing docs for workaround.cs

2019-09-30 Thread Xavi Artigas
lauromoura pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=62139f2292c9eb0136559fbc0f51300285f39e30

commit 62139f2292c9eb0136559fbc0f51300285f39e30
Author: Xavi Artigas 
Date:   Mon Sep 30 10:26:17 2019 -0300

mono-docs: Add some missing docs for workaround.cs

Test Plan: Only docs changed.

Reviewers: lauromoura

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10249
---
 src/bindings/mono/eo_mono/workaround.cs | 21 +
 1 file changed, 17 insertions(+), 4 deletions(-)

diff --git a/src/bindings/mono/eo_mono/workaround.cs 
b/src/bindings/mono/eo_mono/workaround.cs
index a8079e4090..ff254f005d 100644
--- a/src/bindings/mono/eo_mono/workaround.cs
+++ b/src/bindings/mono/eo_mono/workaround.cs
@@ -47,29 +47,42 @@ public struct Efl_Object_Ops
 namespace Efl
 {
 
+///This struct holds the description of a specific event (Since EFL 
1.22).
 [StructLayout(LayoutKind.Sequential)]
 public struct EventDescription
 {
+///Name of the event.
 public IntPtr Name;
+///true if the event cannot be frozen.
 [MarshalAs(UnmanagedType.U1)] public bool Unfreezable;
+///Internal use: true if this is a legacy event.
 [MarshalAs(UnmanagedType.U1)] public bool Legacy_is;
+///true if when the even is triggered again from a 
callback it
+///will start from where it was.
 [MarshalAs(UnmanagedType.U1)] public bool Restart;
 
 private static Dictionary descriptions = new 
Dictionary();
 
-public EventDescription(string module, string name)
+///Constructor for EventDescription
+///The name of the module containing the 
event.
+///The name of the event.
+public EventDescription(string moduleName, string name)
 {
-this.Name = GetNative(module, name);
+this.Name = GetNative(moduleName, name);
 this.Unfreezable = false;
 this.Legacy_is = false;
 this.Restart = false;
 }
 
-public static IntPtr GetNative(string module, string name)
+///Get the native structure.
+///The name of the module containing the 
event.
+///The name of the event.
+///Pointer to the native structure.
+public static IntPtr GetNative(string moduleName, string name)
 {
 if (!descriptions.ContainsKey(name))
 {
-IntPtr data = Efl.Eo.FunctionInterop.LoadFunctionPointer(module, 
name);
+IntPtr data = 
Efl.Eo.FunctionInterop.LoadFunctionPointer(moduleName, name);
 
 if (data == IntPtr.Zero)
 {

-- 




[EGIT] [core/efl] master 02/02: themes: Rename "dragable" to "draggable"

2019-09-27 Thread Xavi Artigas
zmike pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=18ea5fd118dd0f1c6503eb3e57fb7bd0184c3572

commit 18ea5fd118dd0f1c6503eb3e57fb7bd0184c3572
Author: Xavi Artigas 
Date:   Fri Sep 27 08:42:27 2019 -0400

themes: Rename "dragable" to "draggable"

Summary:
"Dragable" is a misspelling:
https://en.wiktionary.org/wiki/dragable

We have it EVERYWHERE in EFL, even with jokes:
./src/lib/efl/interfaces/efl_ui_drag.eo:1

This patch only fixes the theme API so it does not get carved in stone for 
this release.

Depends on D10217

Test Plan: No functional changes.

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10218
---
 data/elementary/themes/edc/efl/collection.edc |   4 +-
 data/elementary/themes/edc/efl/grid.edc   |   8 +-
 data/elementary/themes/edc/efl/image_zoomable.edc |   4 +-
 data/elementary/themes/edc/efl/list.edc   |   8 +-
 data/elementary/themes/edc/efl/scroller.edc   |  96 -
 data/elementary/themes/edc/efl/slider.edc | 120 +++---
 data/elementary/themes/edc/efl/text.edc   |   4 +-
 src/lib/elementary/efl_ui_image_zoomable.c|  60 +--
 src/lib/elementary/efl_ui_scroll_util.c   |  64 ++--
 src/lib/elementary/efl_ui_slider.c|  12 +--
 src/lib/elementary/efl_ui_slider_interval.c   |  28 ++---
 src/lib/elementary/elm_interface_scrollable.c |   4 +-
 12 files changed, 206 insertions(+), 206 deletions(-)

diff --git a/data/elementary/themes/edc/efl/collection.edc 
b/data/elementary/themes/edc/efl/collection.edc
index d2e4ba6dba..ab56e8be7e 100644
--- a/data/elementary/themes/edc/efl/collection.edc
+++ b/data/elementary/themes/edc/efl/collection.edc
@@ -1,7 +1,7 @@
 /**
 Group: efl/collection (@since 1.23)
-Part Rectangle: efl.dragable.horizontal_bar (required)
-Part Rectangle: efl.dragable.vertical_bar (required)
+Part Rectangle: efl.draggable.horizontal_bar (required)
+Part Rectangle: efl.draggable.vertical_bar (required)
 Part Swallow: efl.background (required)
 Part Swallow: efl.content (required)
 Part Swallow: efl.overlay (required)
diff --git a/data/elementary/themes/edc/efl/grid.edc 
b/data/elementary/themes/edc/efl/grid.edc
index a57a120038..51c1bd941d 100644
--- a/data/elementary/themes/edc/efl/grid.edc
+++ b/data/elementary/themes/edc/efl/grid.edc
@@ -1,7 +1,7 @@
 /**
 Group: efl/grid (@since 1.23)
-Part Rectangle: efl.dragable.horizontal_bar (required)
-Part Rectangle: efl.dragable.vertical_bar (required)
+Part Rectangle: efl.draggable.horizontal_bar (required)
+Part Rectangle: efl.draggable.vertical_bar (required)
 Part Swallow: efl.background (required)
 Part Swallow: efl.content (required)
 Part Swallow: efl.overlay (required)
@@ -19,8 +19,8 @@ Group: efl/grid_item (@since 1.23)
 Signal: efl,state,selected
 Signal: efl,state,unselected
 Group: efl/view_grid (@since 1.23)
-Part Rectangle: efl.dragable.horizontal_bar (required)
-Part Rectangle: efl.dragable.vertical_bar (required)
+Part Rectangle: efl.draggable.horizontal_bar (required)
+Part Rectangle: efl.draggable.vertical_bar (required)
 Part Swallow: efl.background (required)
 Part Swallow: efl.content (required)
 Part Swallow: efl.overlay (required)
diff --git a/data/elementary/themes/edc/efl/image_zoomable.edc 
b/data/elementary/themes/edc/efl/image_zoomable.edc
index 6b3e905f63..535cbbde6b 100644
--- a/data/elementary/themes/edc/efl/image_zoomable.edc
+++ b/data/elementary/themes/edc/efl/image_zoomable.edc
@@ -1,7 +1,7 @@
 /**
 Group: efl/image_zoomable (@since 1.23)
-Part Rectangle: efl.dragable.horizontal_bar (required)
-Part Rectangle: efl.dragable.vertical_bar (required)
+Part Rectangle: efl.draggable.horizontal_bar (required)
+Part Rectangle: efl.draggable.vertical_bar (required)
 Part Swallow: efl.background (required)
 Part Swallow: efl.content (required)
 Part Swallow: efl.overlay (required)
diff --git a/data/elementary/themes/edc/efl/list.edc 
b/data/elementary/themes/edc/efl/list.edc
index e96ee028a1..71da7877f2 100644
--- a/data/elementary/themes/edc/efl/list.edc
+++ b/data/elementary/themes/edc/efl/list.edc
@@ -1,7 +1,7 @@
 /**
 Group: efl/list (@since 1.23)
-Part Rectangle: efl.dragable.horizontal_bar (required)
-Part Rectangle: efl.dragable.vertical_bar (required)
+Part Rectangle: efl.draggable.horizontal_bar (required)
+Part Rectangle: efl.draggable.vertical_bar (required)
 Part Swallow: efl.background (required)
 Part Swallow: efl.content (r

[EGIT] [core/efl] master 01/01: docs: formatting nitpick in Efl.Player.eo

2019-09-25 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=eda96947b3720cdaab16ae21880d351618b5e46a

commit eda96947b3720cdaab16ae21880d351618b5e46a
Author: Xavi Artigas 
Date:   Wed Sep 25 12:33:24 2019 +0200

docs: formatting nitpick in Efl.Player.eo
---
 src/lib/efl/interfaces/efl_player.eo | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/efl/interfaces/efl_player.eo 
b/src/lib/efl/interfaces/efl_player.eo
index e6425ee244..3157715bec 100644
--- a/src/lib/efl/interfaces/efl_player.eo
+++ b/src/lib/efl/interfaces/efl_player.eo
@@ -9,7 +9,7 @@ interface Efl.Player
  This property sets the playback state of the object. Re-setting 
the current
  playback state has no effect.
 
- If set to $false, the object's @.playback_progress property is, 
by default, reset to $0.0. A
+ If set to $false, the object's @.playback_progress property is, 
by default, reset to $[0.0]. A
  class may alter this behavior, and it will be stated in the 
documentation for a class
  if such behavior changes should be expected.
 

-- 




[EGIT] [core/efl] master 05/11: theme: add 'required' to efl/border parts

2019-09-24 Thread Xavi Artigas
zmike pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=63358e42862ba6bfa168ce442fde87ec794becf4

commit 63358e42862ba6bfa168ce442fde87ec794becf4
Author: Xavi Artigas 
Date:   Tue Sep 24 16:59:50 2019 -0400

theme: add 'required' to efl/border parts

Summary: ref T8231

Reviewers: zmike, cedric

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10094
---
 data/elementary/themes/edc/efl/border.edc | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/data/elementary/themes/edc/efl/border.edc 
b/data/elementary/themes/edc/efl/border.edc
index 67bee1658d..12f52b73c2 100644
--- a/data/elementary/themes/edc/efl/border.edc
+++ b/data/elementary/themes/edc/efl/border.edc
@@ -130,7 +130,7 @@ group { "efl/border"; data.item: "version" "123";
 rel.to: "efl.menu";
  }
   }
-  swallow { "efl.menu";
+  swallow { "efl.menu"; required;
  required: 1; // since 1.19
  desc { "default";
 rel.to: "indicator_spacer";
@@ -162,7 +162,7 @@ group { "efl/border"; data.item: "version" "123";
   }
 
   /* application contents */
-  swallow { "efl.client";
+  swallow { "efl.client"; required;
  clip: "client_clip";
  desc { "default";
 rel.to: "client_spacer";
@@ -308,7 +308,7 @@ group { "efl/border"; data.item: "version" "123";
 rel2.relative: 1.2 1.2;
  }
   }
-  swallow {  "efl.icon"; nomouse;
+  swallow {  "efl.icon"; nomouse; required;
  clip_to: "top_clip";
  desc { "default";
 rel1.to: "icon";
@@ -694,7 +694,7 @@ group { "efl/border"; data.item: "version" "123";
 color: 0 0 0 0;
  }
   }
-  swallow { "efl.indicator";
+  swallow { "efl.indicator"; required;
  clip: "bg_clip";
  desc { "default";
 rel.to: "top_clip";

-- 




[EGIT] [core/efl] master 01/02: docs: Update Efl.Ui.Scrollbar docs

2019-09-24 Thread Xavi Artigas
zmike pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=036e01579c4d0cc7dbb64e330ba33892da221d10

commit 036e01579c4d0cc7dbb64e330ba33892da221d10
Author: Xavi Artigas 
Date:   Tue Sep 24 14:51:01 2019 -0400

docs: Update Efl.Ui.Scrollbar docs

Summary: Ref T7884

Reviewers: zmike, eagleeye

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7884

Differential Revision: https://phab.enlightenment.org/D10041
---
 src/lib/efl/interfaces/efl_ui_scrollbar.eo | 51 ++
 1 file changed, 30 insertions(+), 21 deletions(-)

diff --git a/src/lib/efl/interfaces/efl_ui_scrollbar.eo 
b/src/lib/efl/interfaces/efl_ui_scrollbar.eo
index 8008bc7ce0..aeba2d9c2a 100644
--- a/src/lib/efl/interfaces/efl_ui_scrollbar.eo
+++ b/src/lib/efl/interfaces/efl_ui_scrollbar.eo
@@ -11,42 +11,51 @@ enum Efl.Ui.Scrollbar_Mode
 
 interface Efl.Ui.Scrollbar
 {
-   [[Interface used by widgets which can display scrollbars, enabling them to 
contain more content
- than actually fits inside them.]]
+   [[Interface used by widgets which can display scrollbars, enabling them to 
hold more content
+ than actually visible through the viewport.
+ A scrollbar contains a draggable part (thumb) which allows the user to 
move the viewport
+ around the content. The size of the thumb relates to the size of the 
viewport compared to
+ the whole content.
+   ]]
methods {
   @property bar_mode {
- [[Scrollbar visibility policy]]
+ [[Scrollbar visibility mode, for each of the scrollbars.]]
  set {
  }
  get {
  }
  values {
-hbar: Efl.Ui.Scrollbar_Mode; [[Horizontal scrollbar.]]
-vbar: Efl.Ui.Scrollbar_Mode; [[Vertical scrollbar.]]
+hbar: Efl.Ui.Scrollbar_Mode(Efl.Ui.Scrollbar_Mode.auto); 
[[Horizontal scrollbar mode.]]
+vbar: Efl.Ui.Scrollbar_Mode(Efl.Ui.Scrollbar_Mode.auto); 
[[Vertical scrollbar mode.]]
  }
   }
   @property bar_size {
- [[Scrollbar size.
-   It is calculated based on viewport size-content sizes.
- ]] // TODO: This needs more details. What does 1.0 mean?
+ [[This returns the relative size the thumb should have, given the 
current size of the viewport and
+   the content.
+   $[0.0] means the viewport is much smaller than the content: the 
thumb will have its minimum size.
+   $[1.0] means the viewport has the same size as the content (or 
bigger): the thumb will have the same
+   size as the scrollbar and cannot move.
+ ]]
  get {
  }
  values {
-width: double; [[Value between 0.0 and 1.0.]]
-height: double; [[Value between 0.0 and 1.0.]]
+width: double; [[Value between $[0.0] and $[1.0].]]
+height: double; [[Value between $[0.0] and $[1.0].]]
  }
   }
   @property bar_position {
- [[Scrollbar position.
-   It is calculated based on current position-maximum positions.
+ [[Position of the thumb (the draggable zone) inside the scrollbar.
+   It is calculated based on current position of the viewport inside 
the total content.
  ]]
  set {
  }
  get {
  }
  values {
-posx: double; [[Value between 0.0 and 1.0.]]
-posy: double; [[Value between 0.0 and 1.0.]]
+posx: double; [[Value between $[0.0] (the left side of the thumb 
is touching the left edge of the widget)
+and $[1.0] (the right side of the thumb is 
touching the right edge of the widget).]]
+posy: double; [[Value between $[0.0] (the top side of the thumb is 
touching the top edge of the widget)
+and $[1.0] (the bottom side of the thumb is 
touching the bottom edge of the widget).]]
  }
   }
   bar_visibility_update @protected @beta{
@@ -58,12 +67,12 @@ interface Efl.Ui.Scrollbar
   }
}
events {
-  bar,pressed: Efl.Ui.Layout_Orientation; [[Called when bar is pressed.]]
-  bar,unpressed: Efl.Ui.Layout_Orientation; [[Called when bar is 
unpressed.]]
-  bar,dragged: Efl.Ui.Layout_Orientation; [[Called when bar is dragged.]]
-  bar,size,changed: void; [[Called when bar size is changed.]]
-  bar,pos,changed: void; [[Called when bar position is changed.]]
-  bar,show: Efl.Ui.Layout_Orientation; [[Callend when bar is shown.]]
-  bar,hide: Efl.Ui.Layout_Orientation; [[Called when bar is hidden.]]
+  bar,pressed: Efl.Ui.Layout_Orientation; [[Emitted when thumb is 
pressed.]]
+  bar,unpressed: Efl.Ui.Layout_Orientation; [[Emitted when thumb is 
unpressed.]]
+  bar,dragged: Efl.Ui.Layout_Orientation; [[Emitted when thumb is 
dragged.]]
+  bar,size,changed: void; [[Emitted when

[EGIT] [core/efl] master 01/01: Efl.Ui.Layout_Pack: fix obvious uninitialized variable

2019-09-24 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=6ea61dc83a3dfd3179ab9067987883e4dc36a63a

commit 6ea61dc83a3dfd3179ab9067987883e4dc36a63a
Author: Xavi Artigas 
Date:   Tue Sep 24 17:57:00 2019 +0200

Efl.Ui.Layout_Pack: fix obvious uninitialized variable

Why did this ever work?
---
 src/lib/elementary/efl_ui_layout_pack.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/elementary/efl_ui_layout_pack.c 
b/src/lib/elementary/efl_ui_layout_pack.c
index 0e2743db01..b043ffa112 100644
--- a/src/lib/elementary/efl_ui_layout_pack.c
+++ b/src/lib/elementary/efl_ui_layout_pack.c
@@ -269,7 +269,7 @@ _efl_ui_layout_part_table_efl_pack_unpack(Eo *obj 
EINA_UNUSED, Efl_Ui_Layout_Tab
 EOLIAN static Eina_Bool
 _efl_ui_layout_part_table_efl_pack_pack(Eo *obj, Efl_Ui_Layout_Table_Data *pd, 
Efl_Gfx_Entity *subobj)
 {
-   int last_col, last_row;
+   int last_col = 0, last_row = 0;
int req_cols, req_rows;
Eina_Iterator *iter;
Eo *pack, *element;

-- 




[EGIT] [core/efl] master 01/01: docs: Add documentation for Efl.Ui.Scroller

2019-09-23 Thread Xavi Artigas
zmike pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=7dcce72eb7bf248ff2d8b1b26a181f3a74392863

commit 7dcce72eb7bf248ff2d8b1b26a181f3a74392863
Author: Xavi Artigas 
Date:   Mon Sep 23 16:51:17 2019 -0400

docs: Add documentation for Efl.Ui.Scroller

Summary:
These docs were missing.
Ref T7891

Test Plan: Only docs changed

Reviewers: zmike, woohyun, bu5hm4n

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7891

Differential Revision: https://phab.enlightenment.org/D10019
---
 src/lib/elementary/efl_ui_scroller.eo | 13 -
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/src/lib/elementary/efl_ui_scroller.eo 
b/src/lib/elementary/efl_ui_scroller.eo
index 9355d9dbae..43fcc4f26e 100644
--- a/src/lib/elementary/efl_ui_scroller.eo
+++ b/src/lib/elementary/efl_ui_scroller.eo
@@ -6,7 +6,18 @@ class @beta Efl.Ui.Scroller extends Efl.Ui.Layout_Base 
implements
Efl.Ui.Scrollable,
Efl.Ui.Scrollbar
 {
-   [[Efl ui scroller class]]
+   [[Widget container that allows objects bigger than itself to be put inside 
it, and provides
+ scrolling functionality so the whole content is visible.
+   
+ Some widgets have scrolling capabilities (like @Efl.Ui.List) that allow 
big content
+ to be shown inside a small viewport, using the well-known scrollbar 
objects.
+ Some other widgets (like @Efl.Ui.Box, for example) cannot scroll by 
themselves and
+ therefore would not be fully visible when placed inside a viewport 
smaller than them.
+
+ The @Efl.Ui.Scroller is a helper class that provides scrolling 
capabilities for widgets
+ which don't have them. In the above example, simply putting the 
@Efl.Ui.Box inside a
+ @Efl.Ui.Scroller (using @Efl.Content.content.set) would give it the 
ability to scroll.
+   ]]
implements {
   Efl.Object.constructor;
   Efl.Object.finalize;

-- 




[EGIT] [core/efl] master 02/02: theme: add 'required' to efl/tab_pager group parts

2019-09-23 Thread Xavi Artigas
zmike pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=5de77bd005cf9383bd98fd29c7e23a3ca725aa57

commit 5de77bd005cf9383bd98fd29c7e23a3ca725aa57
Author: Xavi Artigas 
Date:   Mon Sep 23 16:09:36 2019 -0400

theme: add 'required' to efl/tab_pager group parts

Summary: ref T8231

Reviewers: zmike, cedric

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10087
---
 data/elementary/themes/edc/efl/tab_pager.edc | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/data/elementary/themes/edc/efl/tab_pager.edc 
b/data/elementary/themes/edc/efl/tab_pager.edc
index fb63e58a61..11ea591441 100644
--- a/data/elementary/themes/edc/efl/tab_pager.edc
+++ b/data/elementary/themes/edc/efl/tab_pager.edc
@@ -5,7 +5,7 @@ group { "efl/tab_pager";
  desc { "default";
  }
   }
-  swallow { "efl.tab_root";
+  swallow { "efl.tab_root"; required;
  scale;
  desc { "default";
 rel.to: "base";
@@ -15,7 +15,7 @@ group { "efl/tab_pager";
 fixed: 0 1;
  }
   }
-  swallow { "efl.page_root";
+  swallow { "efl.page_root"; required;
  scale;
  desc { "default";
 rel1.to: "efl.tab_root";
@@ -23,7 +23,7 @@ group { "efl/tab_pager";
 rel1.relative: 0 1;
  }
   }
-  swallow { "efl.event";
+  swallow { "efl.event"; required;
  scale;
  repeat_events: 1;
  desc { "default";

-- 




[EGIT] [core/efl] master 03/06: theme: add 'required' to efl/timepicker parts

2019-09-23 Thread Xavi Artigas
zmike pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=27ec3c7c671e44dcaa94621e832614ba0f7e9b3c

commit 27ec3c7c671e44dcaa94621e832614ba0f7e9b3c
Author: Xavi Artigas 
Date:   Mon Sep 23 15:27:45 2019 -0400

theme: add 'required' to efl/timepicker parts

Summary: ref T8231

Reviewers: zmike, cedric

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10083
---
 data/elementary/themes/edc/efl/timepicker.edc | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/data/elementary/themes/edc/efl/timepicker.edc 
b/data/elementary/themes/edc/efl/timepicker.edc
index d045e732e4..050a470068 100644
--- a/data/elementary/themes/edc/efl/timepicker.edc
+++ b/data/elementary/themes/edc/efl/timepicker.edc
@@ -105,7 +105,7 @@ group { "efl/timepicker";
 align: 1.0 1.0;
  }
   }
-  swallow { "efl.field0";
+  swallow { "efl.field0"; required;
  mouse;
  scale;
  desc { "default";
@@ -197,7 +197,7 @@ group { "efl/timepicker";
 max: 0 0;
  }
   }
-  swallow { "efl.field1";
+  swallow { "efl.field1"; required;
  mouse;
  scale;
  desc { "default";
@@ -289,7 +289,7 @@ group { "efl/timepicker";
 max: 0 0;
  }
   }
-  swallow { "efl.field2";
+  swallow { "efl.field2"; required;
  mouse;
  scale;
  desc { "default";

-- 




[EGIT] [core/efl] master 06/06: theme: add 'required' to efl/button:anchor group parts

2019-09-23 Thread Xavi Artigas
zmike pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=b90bcbd3b59ef2dc525a453c6d19adfd811acbbd

commit b90bcbd3b59ef2dc525a453c6d19adfd811acbbd
Author: Xavi Artigas 
Date:   Mon Sep 23 15:27:50 2019 -0400

theme: add 'required' to efl/button:anchor group parts

Summary: ref T8231

Reviewers: zmike, cedric

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10086
---
 data/elementary/themes/edc/efl/button.edc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/data/elementary/themes/edc/efl/button.edc 
b/data/elementary/themes/edc/efl/button.edc
index 4a9e2dae82..203e467cc7 100644
--- a/data/elementary/themes/edc/efl/button.edc
+++ b/data/elementary/themes/edc/efl/button.edc
@@ -493,7 +493,7 @@ group { name: "efl/button:anchor";
 color: 255 255 255 64;
  }
   }
-  swallow { "efl.background"; nomouse;
+  swallow { "efl.background"; nomouse; required;
  desc { "default";
 rel1.to: "base";
 rel2.to: "base";
@@ -504,7 +504,7 @@ group { name: "efl/button:anchor";
 visible: 1;
  }
   }
-  swallow { "efl.content"; nomouse;
+  swallow { "efl.content"; nomouse; required;
  clip_to: "icon_clip";
  desc { "default";
 fixed: 1 0;

-- 




[EGIT] [core/efl] master 04/06: theme: add 'required' to efl/spin_button group parts

2019-09-23 Thread Xavi Artigas
zmike pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=84dd06aa667e063b7868d3f2898f5500f88a7255

commit 84dd06aa667e063b7868d3f2898f5500f88a7255
Author: Xavi Artigas 
Date:   Mon Sep 23 15:27:47 2019 -0400

theme: add 'required' to efl/spin_button group parts

Summary: ref T8231

Reviewers: zmike, cedric

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10084
---
 data/elementary/themes/edc/efl/spin_button.edc | 14 +++---
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/data/elementary/themes/edc/efl/spin_button.edc 
b/data/elementary/themes/edc/efl/spin_button.edc
index cca7f1d479..070144de28 100644
--- a/data/elementary/themes/edc/efl/spin_button.edc
+++ b/data/elementary/themes/edc/efl/spin_button.edc
@@ -36,7 +36,7 @@ group { "efl/spin_button/horizontal";
 vis;
  }
   }
-  swallow { "efl.entry";
+  swallow { "efl.entry"; required;
  clip: "clip";
  desc { "default";
 fixed: 1 1;
@@ -49,7 +49,7 @@ group { "efl/spin_button/horizontal";
 vis;
  }
   }
-  swallow { "efl.dec_button";
+  swallow { "efl.dec_button"; required;
  scale;
  desc { "default";
 fixed: 1 0;
@@ -58,7 +58,7 @@ group { "efl/spin_button/horizontal";
 aspect: 1.0 1.0; aspect_preference: VERTICAL;
  }
   }
-  swallow { "efl.inc_button";
+  swallow { "efl.inc_button"; required;
  scale;
  desc { "default";
 fixed: 1 0;
@@ -67,7 +67,7 @@ group { "efl/spin_button/horizontal";
 aspect: 1.0 1.0; aspect_preference: VERTICAL;
  }
   }
-  swallow { "efl.text_button";
+  swallow { "efl.text_button"; required;
  scale;
  desc { "default";
 vis;
@@ -158,7 +158,7 @@ group { "efl/spin_button/vertical";
 min: 40 150;
  }
   }
-  swallow { "efl.inc_button";
+  swallow { "efl.inc_button"; required;
  scale;
  desc { "default";
 rel.to: "inset";
@@ -168,7 +168,7 @@ group { "efl/spin_button/vertical";
 fixed: 1 1;
  }
   }
-  swallow { "efl.dec_button";
+  swallow { "efl.dec_button"; required;
  scale;
  desc { "default";
 rel.to: "inset";
@@ -178,7 +178,7 @@ group { "efl/spin_button/vertical";
 fixed: 1 1;
  }
   }
-  swallow { "efl.text_button";
+  swallow { "efl.text_button"; required;
  scale;
  desc { "default";
 rel.to_x: "inset";

-- 




[EGIT] [core/efl] master 01/06: docs: Clarify behavior of NULL in Efl.Pack_Linear.

2019-09-23 Thread Xavi Artigas
zmike pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=b5e5117992e2e8601cfa786f90614a4a2e0be39c

commit b5e5117992e2e8601cfa786f90614a4a2e0be39c
Author: Xavi Artigas 
Date:   Mon Sep 23 15:27:14 2019 -0400

docs: Clarify behavior of NULL in Efl.Pack_Linear.

Summary: Depends on D10023

Reviewers: zmike, bu5hm4n

Reviewed By: bu5hm4n

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8210

Differential Revision: https://phab.enlightenment.org/D10024
---
 src/lib/efl/interfaces/efl_pack_linear.eo | 14 ++
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/src/lib/efl/interfaces/efl_pack_linear.eo 
b/src/lib/efl/interfaces/efl_pack_linear.eo
index 0d152ec613..f23886e35f 100644
--- a/src/lib/efl/interfaces/efl_pack_linear.eo
+++ b/src/lib/efl/interfaces/efl_pack_linear.eo
@@ -36,29 +36,35 @@ interface Efl.Pack_Linear extends Efl.Pack
  return: bool; [[$false if $subobj could not be packed.]]
   }
   pack_before {
- [[Prepend an object before an existing sub-object.
+ [[Prepend an object before the $existing sub-object.
 
When this container is deleted, it will request deletion of the
given $subobj. Use @Efl.Pack.unpack to remove $subobj from this
container without deleting it.
+
+   If $existing is $NULL this method behaves like @.pack_begin.
  ]]
  params {
 @in subobj: Efl.Gfx.Entity; [[Object to pack before $existing.]]
-@in existing: const(Efl.Gfx.Entity); [[Existing reference 
sub-object.]]
+@in existing: const(Efl.Gfx.Entity); [[Existing reference 
sub-object. Must already belong to the container
+   or be $NULL.]]
  }
  return: bool; [[$false if $existing could not be found or $subobj
  could not be packed.]]
   }
   pack_after {
- [[Append an object after an existing sub-object.
+ [[Append an object after the $existing sub-object.
 
When this container is deleted, it will request deletion of the
given $subobj. Use @Efl.Pack.unpack to remove $subobj from this
container without deleting it.
+
+   If $existing is $NULL this method behaves like @.pack_end.
  ]]
  params {
 @in subobj: Efl.Gfx.Entity; [[Object to pack after $existing.]]
-@in existing: const(Efl.Gfx.Entity); [[Existing reference 
sub-object.]]
+@in existing: const(Efl.Gfx.Entity); [[Existing reference 
sub-object. Must already belong to the container
+   or be $NULL.]]
  }
  return: bool; [[$false if $existing could not be found or $subobj
  could not be packed.]]

-- 




[EGIT] [core/efl] master 01/01: docs: Efl.Ui.Widget_Scroller_Content updated docs

2019-09-23 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=883ef612b771d44c6170f05655de723fa3a2e9e5

commit 883ef612b771d44c6170f05655de723fa3a2e9e5
Author: Xavi Artigas 
Date:   Mon Sep 23 18:05:07 2019 +0200

docs: Efl.Ui.Widget_Scroller_Content updated docs

Summary: Ref T8254

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8254

Differential Revision: https://phab.enlightenment.org/D10082
---
 .../elementary/efl_ui_widget_scrollable_content.eo | 28 ++
 1 file changed, 13 insertions(+), 15 deletions(-)

diff --git a/src/lib/elementary/efl_ui_widget_scrollable_content.eo 
b/src/lib/elementary/efl_ui_widget_scrollable_content.eo
index 9dba617de1..2b0c24b22a 100644
--- a/src/lib/elementary/efl_ui_widget_scrollable_content.eo
+++ b/src/lib/elementary/efl_ui_widget_scrollable_content.eo
@@ -3,14 +3,14 @@ parse efl_text_format;
 
 mixin @beta Efl.Ui.Widget_Scrollable_Content requires Efl.Object
 {
-   [[Efl widget scrollable content mixin
+   [[Mixin helper to add scrollable content to widgets.
 
- This can be used to provide scrollable contents and text for widgets. 
When a scrollable
- text or content is set, this mixin will create and manage an internal 
scroller object which
+ This can be used to provide scrollable contents and text for widgets. 
When @.scrollable_content or
+ @.scrollable_text is set, this mixin will create and manage an internal 
scroller object which
  will be the container of that text or content.
 
- Only a single content or text can be set at any given time. Setting 
@.scrollable_content
- will unset @.scrollable_text and vice versa.
+ Only a single content or text can be set at any given time. Setting 
@.scrollable_text
+ will unset @.scrollable_content.
 
  @since 1.23
]]
@@ -21,34 +21,32 @@ mixin @beta Efl.Ui.Widget_Scrollable_Content requires 
Efl.Object
   @property scrollable_content_did_group_calc @protected @beta {
  [[Widgets can call this function during their 
@Efl.Canvas.Group.group_calculate
implementation after the super call to determine whether the 
internal scroller
-   has performed sizing calculations.
+   has already performed sizing calculations.
 
-   The optimal_size,calc event will have been emitted during the super 
call if
-   this method returns $true.
-
-   In the case that this returns $true, it's likely that the widget 
should be completing
-   its internal sizing calculations from the 
@[Efl.Ui.Widget_Scrollable_Content.optimal_size,calc] callback using
+   If this property is $true, the 
@[Efl.Ui.Widget_Scrollable_Content.optimal_size,calc] event will have been
+   emitted during the super call. In this case it's likely that the 
widget should be completing
+   its internal sizing calculations from that event using:
 
efl_canvas_group_calculate(efl_super(ev->object, 
EFL_UI_WIDGET_SCROLLABLE_CONTENT_MIXIN));
 
-   in order to skip the scrollable sizing calc.
+   in order to skip the scrollable sizing calculation.
 
@since 1.23
  ]]
  get {}
  values {
-did_group_calc: bool; [[Whether the internal scroller has done 
sizing calcs.]]
+did_group_calc: bool; [[Whether the internal scroller has already 
done sizing calculations.]]
  }
   }
   @property scrollable_content {
  [[This is the content which will be placed in the internal scroller.
 
-   If a scrollable text string is set, this will return $NULL.
+   If a @.scrollable_text string is set, this property will be $NULL.
 
@since 1.23
  ]]
  set {
-return: bool; [[True on success]]
+return: bool; [[$true on success.]]
  }
  get {}
  values {

-- 




[EGIT] [core/efl] master 01/01: docs: Typos in Efl.Object

2019-09-23 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=3b53749149f69aa865d011f7c4b8635c5c2ab110

commit 3b53749149f69aa865d011f7c4b8635c5c2ab110
Author: Xavi Artigas 
Date:   Mon Sep 23 10:41:46 2019 +0200

docs: Typos in Efl.Object
---
 src/lib/eo/efl_object.eo | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/lib/eo/efl_object.eo b/src/lib/eo/efl_object.eo
index 02827dc8c1..68082f54c6 100644
--- a/src/lib/eo/efl_object.eo
+++ b/src/lib/eo/efl_object.eo
@@ -289,7 +289,7 @@ abstract Efl.Object
  ]]
   }
   event_global_thaw @static {
- [[Gobally thaw events for ALL EFL OBJECTS.
+ [[Globally thaw events for ALL EFL OBJECTS.
 
Allows event callbacks to be called for all EFL objects after they 
have
been disabled by @.event_global_freeze. The amount of thaws must 
match
@@ -347,7 +347,7 @@ abstract Efl.Object
  }
   }
   children_iterator_new {
- [[Get an iterator on all childrens]]
+ [[Get an iterator on all children.]]
  return: iterator @move @no_unused; [[Children iterator]]
   }
   composite_attach @beta {

-- 




[EGIT] [core/efl] master 01/01: Use proper Eolian syntax for default values instead of docs

2019-09-20 Thread Xavi Artigas
lauromoura pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=61ce4c79fd004948f922e928b84765b6f26657a9

commit 61ce4c79fd004948f922e928b84765b6f26657a9
Author: Xavi Artigas 
Date:   Fri Sep 20 11:38:18 2019 -0300

Use proper Eolian syntax for default values instead of docs

Summary:
Eolian supports reporting the defaults for parameters and return values, 
but in some
places we have been writing this information in the documentation instead.
This patch moves it to its proper place, where documentation generators can 
pick it up
and render it in a consistent manner.

Ref T8171

Reviewers: zmike, bu5hm4n, lauromoura

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8171

Differential Revision: https://phab.enlightenment.org/D10051
---
 src/lib/ecore/efl_task.eo  |  6 ++--
 src/lib/efl/interfaces/efl_gfx_arrangement.eo  | 14 
 src/lib/efl/interfaces/efl_gfx_entity.eo   |  5 ++-
 src/lib/efl/interfaces/efl_gfx_image.eo| 41 ++
 .../interfaces/efl_ui_scrollable_interactive.eo| 23 ++--
 src/lib/efl/interfaces/efl_ui_zoom.eo  |  2 +-
 src/lib/elementary/efl_ui_animation_view.eo| 22 +---
 .../elementary/efl_ui_spotlight_manager_scroll.eo  |  8 ++---
 src/lib/elementary/efl_ui_text.eo  |  3 +-
 src/lib/evas/canvas/efl_canvas_object.eo   | 11 +++---
 10 files changed, 58 insertions(+), 77 deletions(-)

diff --git a/src/lib/ecore/efl_task.eo b/src/lib/ecore/efl_task.eo
index caef983b3b..056ccbf632 100644
--- a/src/lib/ecore/efl_task.eo
+++ b/src/lib/ecore/efl_task.eo
@@ -43,13 +43,11 @@ abstract Efl.Task extends Efl.Loop_Consumer
  }
   }
   @property flags {
- [[Flags to further customize task's behavior. The default value:
- exit_with_parent
- ]]
+ [[Flags to further customize task's behavior.]]
  set { }
  get { }
  values {
-flags: Efl.Task_Flags; [[Desired task flags.]]
+flags: Efl.Task_Flags(Efl.Task_Flags.exit_with_parent); [[Desired 
task flags.]]
  }
   }
   run @pure_virtual {
diff --git a/src/lib/efl/interfaces/efl_gfx_arrangement.eo 
b/src/lib/efl/interfaces/efl_gfx_arrangement.eo
index 7bfe70ea82..02cda25495 100644
--- a/src/lib/efl/interfaces/efl_gfx_arrangement.eo
+++ b/src/lib/efl/interfaces/efl_gfx_arrangement.eo
@@ -22,10 +22,10 @@ interface @beta Efl.Gfx.Arrangement
  set {}
  get {}
  values {
-align_horiz: double; [[Double, ranging from 0.0 to 1.0, where 0.0 
is at the start of the horizontal axis
-   and 1.0 is at the end. The default value is 
0.5.]]
-align_vert:  double; [[Double, ranging from 0.0 to 1.0, where 0.0 
is at the start of the vertical axis
-   and 1.0 is at the end. The default value is 
0.5.]]
+align_horiz: double(0.5); [[Double, ranging from 0.0 to 1.0, where 
0.0 is at the start of the horizontal
+axis and 1.0 is at the end.]]
+align_vert:  double(0.5); [[Double, ranging from 0.0 to 1.0, where 
0.0 is at the start of the vertical
+axis and 1.0 is at the end.]]
  }
   }
   @property content_padding {
@@ -40,9 +40,9 @@ interface @beta Efl.Gfx.Arrangement
  set {}
  get {}
  values {
-pad_horiz: double; [[Horizontal padding. The default value is 
0.0.]]
-pad_vert:  double; [[Vertical padding. The default value is 0.0.]]
-scalable:  bool; [[$true if scalable, $false otherwise. The 
default value is $false.]]
+pad_horiz: double(0.0); [[Horizontal padding.]]
+pad_vert:  double(0.0); [[Vertical padding.]]
+scalable:  bool(false); [[$true if scalable.]]
  }
   }
}
diff --git a/src/lib/efl/interfaces/efl_gfx_entity.eo 
b/src/lib/efl/interfaces/efl_gfx_entity.eo
index 115fb2a782..b33504cca2 100644
--- a/src/lib/efl/interfaces/efl_gfx_entity.eo
+++ b/src/lib/efl/interfaces/efl_gfx_entity.eo
@@ -83,7 +83,7 @@ interface Efl.Gfx.Entity {
   This property is an individual scaling factor on the object (Edje
   or UI widget). This property (or Edje's global scaling factor, when
   applicable), will affect this object's part sizes. If scale is
-  not zero, than the individual scaling will override any global
+  not zero, then the individual scaling will override any global
   scaling set, for the object obj's parts. Set it back to zero to
   get the effects of the global scaling again.
 
@@ -98,8 +98,7 @@ interface Efl.Gfx.Entity {
[[Gets an object's scaling factor

[EGIT] [core/efl] master 01/01: docs: Update documentation for Efl.Gfx.Color_Class

2019-09-19 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=f8926697ff430e025d782fbdbb588db8ee154852

commit f8926697ff430e025d782fbdbb588db8ee154852
Author: Xavi Artigas 
Date:   Thu Sep 19 16:51:04 2019 +0200

docs: Update documentation for Efl.Gfx.Color_Class
---
 src/lib/efl/interfaces/efl_gfx_color_class.eo | 7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/lib/efl/interfaces/efl_gfx_color_class.eo 
b/src/lib/efl/interfaces/efl_gfx_color_class.eo
index 6acfa42f0f..7d91347dfe 100644
--- a/src/lib/efl/interfaces/efl_gfx_color_class.eo
+++ b/src/lib/efl/interfaces/efl_gfx_color_class.eo
@@ -2,7 +2,10 @@ import efl_gfx_types;
 
 mixin @beta Efl.Gfx.Color_Class
 {
-   [[Efl Gfx Color Class mixin class]]
+   [[This mixin provides an interface for objects supporting color classes
+ (this is, named colors) and provides a helper method to also allow 
hexadecimal
+ color codes.
+   ]]
data: null;
methods {
   @property color_class @pure_virtual {
@@ -53,7 +56,7 @@ mixin @beta Efl.Gfx.Color_Class
 
 Setting color emits a signal "color_class,set" with source being
 the given color.
-
+
 When retrieving the color of an object, if no explicit
 object color is set, then global values will be used.
 

-- 




[EGIT] [core/efl] master 01/01: docs: Update docs for Efl.Gfx.Image_Orientable

2019-09-19 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=5428f26f7d08b03ce4e7963595d6f83f70d5957a

commit 5428f26f7d08b03ce4e7963595d6f83f70d5957a
Author: Xavi Artigas 
Date:   Thu Sep 19 13:11:00 2019 +0200

docs: Update docs for Efl.Gfx.Image_Orientable
---
 src/lib/efl/interfaces/efl_gfx_image_orientable.eo | 6 +-
 src/lib/efl/interfaces/efl_ui_layout_orientable.eo | 2 ++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/lib/efl/interfaces/efl_gfx_image_orientable.eo 
b/src/lib/efl/interfaces/efl_gfx_image_orientable.eo
index 09653edd9e..9e4c90cda4 100644
--- a/src/lib/efl/interfaces/efl_gfx_image_orientable.eo
+++ b/src/lib/efl/interfaces/efl_gfx_image_orientable.eo
@@ -29,7 +29,11 @@ enum Efl.Gfx.Image_Orientation
 
 interface Efl.Gfx.Image_Orientable
 {
-   [[Interface for objects which can be oriented.]]
+   [[Interface for images which can be rotated or flipped (mirrored).
+
+ Compare with @Efl.Ui.Layout_Orientable which works for layout objects and 
does
+ not include rotation.
+   ]]
c_prefix: efl_gfx;
methods {
@property image_orientation {
diff --git a/src/lib/efl/interfaces/efl_ui_layout_orientable.eo 
b/src/lib/efl/interfaces/efl_ui_layout_orientable.eo
index 34da902e56..e1e2d667fd 100644
--- a/src/lib/efl/interfaces/efl_ui_layout_orientable.eo
+++ b/src/lib/efl/interfaces/efl_ui_layout_orientable.eo
@@ -30,6 +30,8 @@ interface Efl.Ui.Layout_Orientable
 
  For example, sliders, which can be horizontal or vertical, or container
  boxes, which can arrange their elements in a horizontal or vertical 
fashion.
+
+ Compare with @Efl.Gfx.Image_Orientable that works for images and includes 
rotation.
]]
c_prefix: efl_ui_layout;
methods {

-- 




[EGIT] [core/efl] master 01/01: docs: Update documentation on Gestures

2019-09-19 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=ac531f881fe084b4683e96f6de6b8a64a2ca0c9d

commit ac531f881fe084b4683e96f6de6b8a64a2ca0c9d
Author: Xavi Artigas 
Date:   Thu Sep 19 11:17:49 2019 +0200

docs: Update documentation on Gestures

We need to keep in mind that the Manager and the Recognizers are not 
visible to the user.
The user only sees the events and the different Efl.Canvas.Gesture_* 
payloads.
---
 src/lib/evas/gesture/efl_canvas_gesture.eo | 27 +++--
 .../evas/gesture/efl_canvas_gesture_double_tap.eo  |  8 ++--
 src/lib/evas/gesture/efl_canvas_gesture_flick.eo   | 21 ++-
 .../evas/gesture/efl_canvas_gesture_long_tap.eo|  9 ++---
 src/lib/evas/gesture/efl_canvas_gesture_manager.eo | 26 +++--
 .../evas/gesture/efl_canvas_gesture_momentum.eo| 12 +++---
 .../evas/gesture/efl_canvas_gesture_recognizer.eo  | 38 +--
 .../efl_canvas_gesture_recognizer_double_tap.eo| 12 +++---
 .../gesture/efl_canvas_gesture_recognizer_flick.eo |  8 ++--
 .../efl_canvas_gesture_recognizer_long_tap.eo  | 12 +++---
 .../efl_canvas_gesture_recognizer_momentum.eo  |  8 ++--
 .../gesture/efl_canvas_gesture_recognizer_tap.eo   |  8 ++--
 .../efl_canvas_gesture_recognizer_triple_tap.eo| 24 ++--
 .../gesture/efl_canvas_gesture_recognizer_zoom.eo  |  8 ++--
 src/lib/evas/gesture/efl_canvas_gesture_tap.eo |  9 ++---
 .../evas/gesture/efl_canvas_gesture_triple_tap.eo  |  9 ++---
 src/lib/evas/gesture/efl_canvas_gesture_zoom.eo| 20 +-
 src/lib/evas/gesture/efl_gesture_events.eo | 44 ++
 18 files changed, 170 insertions(+), 133 deletions(-)

diff --git a/src/lib/evas/gesture/efl_canvas_gesture.eo 
b/src/lib/evas/gesture/efl_canvas_gesture.eo
index b76aac0936..eaced25ad8 100644
--- a/src/lib/evas/gesture/efl_canvas_gesture.eo
+++ b/src/lib/evas/gesture/efl_canvas_gesture.eo
@@ -1,44 +1,49 @@
 import efl_canvas_gesture_types;
+parse efl_gesture_events;
 
 abstract @beta Efl.Canvas.Gesture extends Efl.Object
 {
-   [[EFL Gesture abstract class
+   [[Base abstract class to support gesture-specific classes.
 
- A gesture class defines a method that specific gesture event and privides 
information
- about the gesture's type, state, and associated pointer information.
+ A gesture object holds the current state of that gesture (i.e. whether 
the gesture has
+ just been started, it is in progress or it has finished) along with any 
gesture-specific
+ information it needs (like the number of taps so far, to detect 
triple-taps, for example).
 
- For cetain gesture types, additional methods are defined to provide 
meaningful gesture
- information to the user.]]
+ Typically this class is not used directly, instead, some sub-class of it 
(like
+ @Efl.Canvas.Gesture_Tap or @Efl.Canvas.Gesture_Zoom) is retrieved from 
gesture events
+ (like @[Efl.Gesture.Events.gesture,tap] or 
@[Efl.Gesture.Events.gesture,zoom]).
+   ]]
c_prefix: efl_gesture;
methods {
   @property state {
- [[This property holds the current state of the gesture.]]
+ [[Current state of the gesture, from initial detection to successful 
recognition.]]
  get {
  }
  set {
  }
  values {
-state: Efl.Canvas.Gesture_State; [[gesture state]]
+state: Efl.Canvas.Gesture_State; [[State.]]
  }
   }
   @property hotspot {
- [[This property holds the hotspot of the current gesture.]]
+ [[Hotspot of the gesture currently being analyzed.
+   The exact meaning depends on the gesture type.]]
  get {
  }
  set {
  }
  values {
-hotspot: Eina.Position2D;[[hotspot co-ordinate]]
+hotspot: Eina.Position2D;[[Hotspot coordinates.]]
  }
   }
   @property timestamp {
- [[This property holds the timestamp of the current gesture.]]
+ [[Moment when the gesture currently being analyzed started.]]
  get {
  }
  set {
  }
  values {
-timestamp: uint;[[The timestamp]]
+timestamp: uint;[[The time-stamp.]]
  }
   }
}
diff --git a/src/lib/evas/gesture/efl_canvas_gesture_double_tap.eo 
b/src/lib/evas/gesture/efl_canvas_gesture_double_tap.eo
index 5a0b1bc57b..87b93ccd9c 100644
--- a/src/lib/evas/gesture/efl_canvas_gesture_double_tap.eo
+++ b/src/lib/evas/gesture/efl_canvas_gesture_double_tap.eo
@@ -1,9 +1,9 @@
 class @beta Efl.Canvas.Gesture_Double_Tap extends Efl.Canvas.Gesture
 {
-   [[EFL Gesture Double Tap class
-   
- A gesture class defines a method that double tap gesture event and 
provides information
- about the double tap gesture's type, state and associated pointer 
information.]]
+   [[Double-tap gesture class holding state information.
+ See

[EGIT] [website/www-content] master 01/01: Wiki page hello-world.md changed with summary [Typo] by Xavi Artigas

2019-09-19 Thread Xavi Artigas
WWW-www.enlightenment.org pushed a commit to branch master.

http://git.enlightenment.org/website/www-content.git/commit/?id=660fd4e778b59bf94254566bebd0fa46bbf76954

commit 660fd4e778b59bf94254566bebd0fa46bbf76954
Author: Xavi Artigas 
Date:   Thu Sep 19 01:07:54 2019 -0700

Wiki page hello-world.md changed with summary [Typo] by Xavi Artigas
---
 pages/develop/tutorials/c/hello-world.md.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pages/develop/tutorials/c/hello-world.md.txt 
b/pages/develop/tutorials/c/hello-world.md.txt
index ab9dadf95..48f4fdc08 100644
--- a/pages/develop/tutorials/c/hello-world.md.txt
+++ b/pages/develop/tutorials/c/hello-world.md.txt
@@ -42,7 +42,7 @@ efl_main(void *data EINA_UNUSED, const Efl_Event *ev 
EINA_UNUSED)
 
 EFL takes care of all initialization tasks and calls your ``efl_main()`` 
method when everything is ready.
 
-At this point the parameters to ``efl_main()`` are not being used, hence the 
``EINA_UNUSED`` macro. This is optional but it gets rid of warnings regarding 
unused parameters so it's worth having. Moreover, the ``data`` argument will 
always be NULL in this tutorials.
+At this point the parameters to ``efl_main()`` are not being used, hence the 
``EINA_UNUSED`` macro. This is optional but it gets rid of warnings regarding 
unused parameters so it's worth having. Moreover, the ``data`` argument will 
always be NULL in these tutorials.
 
 ## Step Three: Print "Hello World" ##
 

-- 




[EGIT] [website/www-content] master 01/01: Wiki page hello-world.md changed with summary [Typo] by Xavi Artigas

2019-09-19 Thread Xavi Artigas
WWW-www.enlightenment.org pushed a commit to branch master.

http://git.enlightenment.org/website/www-content.git/commit/?id=5d9a4b888f24b0120ce399f2f16493b99e59d86d

commit 5d9a4b888f24b0120ce399f2f16493b99e59d86d
Author: Xavi Artigas 
Date:   Thu Sep 19 01:06:43 2019 -0700

Wiki page hello-world.md changed with summary [Typo] by Xavi Artigas
---
 pages/develop/tutorials/c/hello-world.md.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pages/develop/tutorials/c/hello-world.md.txt 
b/pages/develop/tutorials/c/hello-world.md.txt
index 6a607bdc0..ab9dadf95 100644
--- a/pages/develop/tutorials/c/hello-world.md.txt
+++ b/pages/develop/tutorials/c/hello-world.md.txt
@@ -18,7 +18,7 @@ Using your favorite text editor, create a text file and save 
it as ``hello-world
 #include 
 ```
 
-The new EFL API has been in Beta stage for a while, and some libraries still 
need that you define the ``EFL_BETA_API_SUPPORT`` symbols before including any 
EFL library. Don't worry, though, they should not be required any more in the 
near future.
+The new EFL API has been in Beta stage for a while, and some libraries still 
need that you define the ``EFL_BETA_API_SUPPORT`` symbol before including any 
EFL library. Don't worry, though, they should not be required any more in the 
near future.
 
 The EFL is split into several libraries. You only need to include the ones you 
actually want to use. In this tutorial you will be calling methods from the 
``Eina`` and ``Efl`` libraries, therefore you just need to include the 
``Efl_Core.h`` header which includes ``Eina.h`` and ``Efl.h``.
 

-- 




[EGIT] [website/www-content] master 01/01: Update libraries needed by first tutorial.

2019-09-19 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/website/www-content.git/commit/?id=4e0e7c4615dc4af3ef8c8279b417dc1f5c44539d

commit 4e0e7c4615dc4af3ef8c8279b417dc1f5c44539d
Author: Xavi Artigas 
Date:   Thu Sep 19 10:03:41 2019 +0200

Update libraries needed by first tutorial.

Original author: Vincent Torri 
---
 pages/develop/tutorials/c/hello-world.md.txt | 14 +++---
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/pages/develop/tutorials/c/hello-world.md.txt 
b/pages/develop/tutorials/c/hello-world.md.txt
index 8b0d7ca3d..6a607bdc0 100644
--- a/pages/develop/tutorials/c/hello-world.md.txt
+++ b/pages/develop/tutorials/c/hello-world.md.txt
@@ -15,13 +15,12 @@ Using your favorite text editor, create a text file and 
save it as ``hello-world
 ```c
 #define EFL_BETA_API_SUPPORT 1
 
-#include 
 #include 
 ```
 
 The new EFL API has been in Beta stage for a while, and some libraries still 
need that you define the ``EFL_BETA_API_SUPPORT`` symbols before including any 
EFL library. Don't worry, though, they should not be required any more in the 
near future.
 
-The EFL is split into several libraries. You only need to include the ones you 
actually want to use. In this tutorial you will be calling methods from the 
``Eina`` and ``Efl`` libraries, therefore you need to include the ``Eina.h`` 
and ``Efl_Core.h`` headers.
+The EFL is split into several libraries. You only need to include the ones you 
actually want to use. In this tutorial you will be calling methods from the 
``Eina`` and ``Efl`` libraries, therefore you just need to include the 
``Efl_Core.h`` header which includes ``Eina.h`` and ``Efl.h``.
 
 You will explore the EFL libraries in greater depth in later tutorials. Other 
examples are ``Efl_Net.h`` for network operations and ``Efl_Ui.h`` to create 
*User Interface* elements like windows and buttons.
 
@@ -43,7 +42,7 @@ efl_main(void *data EINA_UNUSED, const Efl_Event *ev 
EINA_UNUSED)
 
 EFL takes care of all initialization tasks and calls your ``efl_main()`` 
method when everything is ready.
 
-At this point the parameters to ``efl_main()`` are not being used, hence the 
``EINA_UNUSED`` macro. This is optional but it gets rid of warnings regarding 
unused parameters so it's worth having.
+At this point the parameters to ``efl_main()`` are not being used, hence the 
``EINA_UNUSED`` macro. This is optional but it gets rid of warnings regarding 
unused parameters so it's worth having. Moreover, the ``data`` argument will 
always be NULL in this tutorials.
 
 ## Step Three: Print "Hello World" ##
 
@@ -84,7 +83,8 @@ This is not mandatory but it simplifies the setup and 
shutdown processes conside
 
 Your program should now look something like this:
 ```c
-#include 
+#define EFL_BETA_API_SUPPORT 1
+
 #include 
 
 void
@@ -100,7 +100,7 @@ EFL_MAIN()
 Save the program then build it as outlined in [Setting up the Development 
Environment](/develop/setup/c/#Building). As a reminder, if you are using the 
``gcc`` compiler, run:
 
 ```bash
-gcc -o hello-world hello-world.c `pkg-config --cflags --libs eina efl 
elementary`
+gcc -o hello-world hello-world.c `pkg-config --cflags --libs ecore`
 ```
 
 If the systems displays no errors, your program should be ready. Test it by 
typing:
@@ -158,8 +158,8 @@ In the above example, if no parameters are passed to your 
program (``eina_array_
 
 At the end of this tutorial you have learned:
 
-* **Header files** must be included for any EFL libraries you intend to use. 
Typically, these are ``Eina.h`` and ``Efl.h``.
+* **Header files** must be included for any EFL libraries you intend to use. 
Typically, these are ``Efl_Core.h`` or ``Efl_Ui.h``.
 * Your **main method** should be ``efl_main()``.
 * Your EFL programs should **always call ``efl_exit()``** at some stage.
 * Your EFL programs should **include the ``EFL_MAIN()`` macro** at the end so 
EFL can insert its own start-up and shutdown code.
-* **Command line parameters** are available through the ``Efl_Event *`` 
parameter in ``efl_main()``, and can be accessed with ``eina_array_count()`` 
and ``eina_array_data_get()``.
\ No newline at end of file
+* **Command line parameters** are available through the ``Efl_Event *`` 
parameter in ``efl_main()``, and can be accessed with ``eina_array_count()`` 
and ``eina_array_data_get()``.

-- 




[EGIT] [core/efl] master 01/01: TABS

2019-09-18 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=6e3bfa6bb14ccf1d77516f4604be958661d4b9a8

commit 6e3bfa6bb14ccf1d77516f4604be958661d4b9a8
Author: Xavi Artigas 
Date:   Wed Sep 18 16:05:17 2019 +0200

TABS
---
 src/lib/evas/gesture/efl_gesture_events.eo | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/lib/evas/gesture/efl_gesture_events.eo 
b/src/lib/evas/gesture/efl_gesture_events.eo
index 376b51ef4b..df4e874ad8 100644
--- a/src/lib/evas/gesture/efl_gesture_events.eo
+++ b/src/lib/evas/gesture/efl_gesture_events.eo
@@ -4,10 +4,10 @@ interface @beta Efl.Gesture.Events
events {
   gesture,tap: Efl.Canvas.Gesture_Tap; [[Event for tap gesture]]
   gesture,double_tap: Efl.Canvas.Gesture_Double_Tap; [[Event for double 
tap gesture]]
- gesture,triple_tap: Efl.Canvas.Gesture_Triple_Tap; [[Event for triple 
tap gesture]]
- gesture,long_tap: Efl.Canvas.Gesture_Long_Tap; [[Event for long tap 
gesture]]
+  gesture,triple_tap: Efl.Canvas.Gesture_Triple_Tap; [[Event for triple 
tap gesture]]
+  gesture,long_tap: Efl.Canvas.Gesture_Long_Tap; [[Event for long tap 
gesture]]
   gesture,momentum: Efl.Canvas.Gesture_Momentum; [[Event for momentum 
gesture]]
- gesture,flick: Efl.Canvas.Gesture_Flick; [[Event for flick gesture]]
- gesture,zoom: Efl.Canvas.Gesture_Zoom; [[Event for zoom gesture]]
+  gesture,flick: Efl.Canvas.Gesture_Flick; [[Event for flick gesture]]
+  gesture,zoom: Efl.Canvas.Gesture_Zoom; [[Event for zoom gesture]]
}
 }

-- 




[EGIT] [core/efl] master 03/03: Efl.ThreadIO: replace empty implementations with @pure_virtual

2019-09-18 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=f4290cb330f8c594c460bb5fdbf36fcaf5459152

commit f4290cb330f8c594c460bb5fdbf36fcaf5459152
Author: Xavi Artigas 
Date:   Wed Sep 18 13:40:32 2019 +0200

Efl.ThreadIO: replace empty implementations with @pure_virtual

The implementation for call and call_async are empty on this mixin.
I think removing them and marking them as @pure_virtual in the EO file is 
cleaner.
---
 src/lib/ecore/efl_threadio.c  | 11 ---
 src/lib/ecore/efl_threadio.eo |  4 ++--
 2 files changed, 2 insertions(+), 13 deletions(-)

diff --git a/src/lib/ecore/efl_threadio.c b/src/lib/ecore/efl_threadio.c
index 96a2c4fa26..7d6c21cd26 100644
--- a/src/lib/ecore/efl_threadio.c
+++ b/src/lib/ecore/efl_threadio.c
@@ -43,17 +43,6 @@ _efl_threadio_outdata_get(const Eo *obj EINA_UNUSED, 
Efl_ThreadIO_Data *pd)
return pd->outdata;
 }
 
-EOLIAN static void
-_efl_threadio_call(Eo *obj EINA_UNUSED, Efl_ThreadIO_Data *pd EINA_UNUSED, 
void *func_data EINA_UNUSED, EflThreadIOCall func EINA_UNUSED, Eina_Free_Cb 
func_free_cb EINA_UNUSED)
-{
-}
-
-EOLIAN static void *
-_efl_threadio_call_sync(Eo *obj EINA_UNUSED, Efl_ThreadIO_Data *pd 
EINA_UNUSED, void *func_data EINA_UNUSED, EflThreadIOCallSync func EINA_UNUSED, 
Eina_Free_Cb func_free_cb EINA_UNUSED)
-{
-   return NULL;
-}
-
 //
 
 #include "efl_threadio.eo.c"
diff --git a/src/lib/ecore/efl_threadio.eo b/src/lib/ecore/efl_threadio.eo
index f8d778c59a..58629fd7b4 100644
--- a/src/lib/ecore/efl_threadio.eo
+++ b/src/lib/ecore/efl_threadio.eo
@@ -39,13 +39,13 @@ mixin @beta Efl.ThreadIO
 data: void_ptr; [[Data pointer.]]
  }
   }
-  call {
+  call @pure_virtual {
  [[Executes a method on a different thread, asynchronously.]]
  params {
 func: EflThreadIOCall; [[The method to execute asynchronously.]]
  }
   }
-  call_sync {
+  call_sync @pure_virtual {
  [[Executes a method on a different thread, synchronously.
This call will not return until the method finishes and its return 
value can be recovered.
  ]]

-- 




[EGIT] [core/efl] master 02/03: docs: Update Efl.Threadio and Efl.Appthread

2019-09-18 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=214ced325f6e4507d093c8413a22b09986183fa3

commit 214ced325f6e4507d093c8413a22b09986183fa3
Author: Xavi Artigas 
Date:   Wed Sep 18 13:40:05 2019 +0200

docs: Update Efl.Threadio and Efl.Appthread
---
 src/lib/ecore/efl_appthread.eo |  8 +---
 src/lib/ecore/efl_threadio.eo  | 43 --
 2 files changed, 25 insertions(+), 26 deletions(-)

diff --git a/src/lib/ecore/efl_appthread.eo b/src/lib/ecore/efl_appthread.eo
index 87f10d0183..6a3c23ac34 100644
--- a/src/lib/ecore/efl_appthread.eo
+++ b/src/lib/ecore/efl_appthread.eo
@@ -1,9 +1,11 @@
 class @beta Efl.Appthread extends Efl.Loop
   implements Efl.ThreadIO, Efl.Io.Reader, 
Efl.Io.Writer, Efl.Io.Closer, Efl.Core.Command_Line
 {
-   [[@Efl.Appthread object created to house the thread and run the loop.
- @Efl.Appthread also Inherits from @Efl.Loop, @Efl.Io and @Efl.Task
- So it works almost the same as Efl.App but misses some of the 
process-global controls from @Efl.App.]]
+   [[This class houses the application's thread and main loop.
+ It works similarly to @Efl.App but allows communicating with it from a 
different thread
+ through the @Efl.ThreadIO, @Efl.Io.Reader and @Efl.Io.Writer interfaces.
+ Methods can be scheduled to be executed in this thread using 
@Efl.ThreadIO.call and @Efl.ThreadIO.call_sync.
+   ]]
methods {
}
events {
diff --git a/src/lib/ecore/efl_threadio.eo b/src/lib/ecore/efl_threadio.eo
index 4da455bb43..f8d778c59a 100644
--- a/src/lib/ecore/efl_threadio.eo
+++ b/src/lib/ecore/efl_threadio.eo
@@ -1,61 +1,58 @@
 import efl_object;
 
 function @beta EflThreadIOCall {
-   [[ A Function to call on the "other end" of a thread object ]]
+   [[A Function to be called asynchronously on a different thread.]]
params {
-  @in event: const(event); [[Event struct with an EFL_LOOP_HANDLER_CLASS 
as info]]
+  @in event: const(event); [[Event struct with an @Efl.Loop_Handler as 
payload.]]
}
 };
 
 function @beta EflThreadIOCallSync {
-   [[ A Function to call on the "other end" of a thread object ]]
+   [[A Function to be called synchronously on another thread.
+ Execution will be stopped until this function returns and its return 
value can be recovered.
+   ]]
params {
-  @in event: const(event); [[Event struct with an EFL_LOOP_HANDLER_CLASS 
as info]]
+  @in event: const(event); [[Event struct with an @Efl.Loop_Handler as 
payload.]]
}
-   return: void_ptr; [[The "other end" of a thread object's data]]
+   return: void_ptr; [[Data that the function executed on the other thread 
returned.]]
 };
 
 mixin @beta Efl.ThreadIO
 {
-   [[This adds a simple indata and outdata void ptr to begin that you can
- set on @Efl.Thread objects (set the indata) and get the outdata too to
- get results. then on the efl.appthread side the indata is set on the
- @Efl.Appthread before it runs and on quit the thread can set the
- outdata on the appthread, and this appears back on the @Efl.Thread
- object in the parent thread.
-
- So you can basically share pointers to anything in and out this way on
- start/exit in addition to string args etc.
+   [[This mixin defines input and output pointers to allow exchanging data 
with another thread.
+ It also defines a mechanism to call methods on that thread.
]]
methods {
   @property indata {
- [[Sets/gets on Efl.Thread object's indata.]]
+ [[Input data pointer for the thread.]]
  set { }
  get { }
  values {
-data: void_ptr; [[Pointer data set to indata.]]
+data: void_ptr; [[Data pointer.]]
  }
   }
   @property outdata {
- [[Sets/gets on Efl.Thread object's outdata.]]
+ [[Output data pointer for the thread.]]
  set { }
  get { }
  values {
-data: void_ptr; [[Pointer data set to outdata.]]
+data: void_ptr; [[Data pointer.]]
  }
   }
   call {
- [[Write a command as async.]]
+ [[Executes a method on a different thread, asynchronously.]]
  params {
-func: EflThreadIOCall; [[A Function to call on the "other end" of 
a thread object]]
+func: EflThreadIOCall; [[The method to execute asynchronously.]]
  }
   }
   call_sync {
- [[Write a command as sync.]]
+ [[Executes a method on a different thread, synchronously.
+   This call will not return until the method finishes and its return 
value can be recovered.
+ ]]
  params {
-func: EflThreadIOCallSync; [[A Function to call on the "other end" 
of a thread object]]
+func: EflThreadIOCallSync; [[The method to execute synchronously.]]
  }
- return: voi

[EGIT] [tools/examples] master 01/01: mono snippets: Added README in the snippets folder

2019-09-17 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/tools/examples.git/commit/?id=fd32510f350d8d445be7dcd174bff2561c763962

commit fd32510f350d8d445be7dcd174bff2561c763962
Author: Xavi Artigas 
Date:   Tue Sep 17 12:10:22 2019 +0200

mono snippets: Added README in the snippets folder
---
 reference/csharp/snippets/README | 9 +
 1 file changed, 9 insertions(+)

diff --git a/reference/csharp/snippets/README b/reference/csharp/snippets/README
new file mode 100644
index ..bab98f4c
--- /dev/null
+++ b/reference/csharp/snippets/README
@@ -0,0 +1,9 @@
+Place code snippets in this folder.
+If the file name matches a class name (like Efl.Ui.Win) or a property name 
(like Efl.Ui.Win.FocusHighlightEnabled)
+the mono documentation generator (DocFX) will pick up the content of the file 
and embed it.
+Two file formats are supported:
+- Plain code (files with .cs extension): Code snippets are copied into the 
documentation inside  and 
+  tags.
+- XML text (files with .xml extension): This allows including explanatory text 
besides the code snippets, but the file
+  must include the ESCAPED \ and \ tags. Escaping is 
accomplished by adding a backslash in front of
+  angle brackets. Quotes must be escaped too: \"

-- 




[EGIT] [core/efl] master 01/01: mono-docs: Allow embedding examples in XML format

2019-09-17 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=4673120a19c7ffb76c191e4ec248d65b4788f35b

commit 4673120a19c7ffb76c191e4ec248d65b4788f35b
Author: Xavi Artigas 
Date:   Tue Sep 17 12:02:19 2019 +0200

mono-docs: Allow embedding examples in XML format

XML examples must provide their own  and  tags, and these
tags MUST be escaped: \< \> \" etc.
This is more inconvenient, but it allows adding explanatory text outside
the  and inside the .
Examples are first looked for in XML format, and if not found, in CS format.
---
 src/bin/eolian_mono/eolian/mono/documentation.hh | 28 ++--
 1 file changed, 21 insertions(+), 7 deletions(-)

diff --git a/src/bin/eolian_mono/eolian/mono/documentation.hh 
b/src/bin/eolian_mono/eolian/mono/documentation.hh
index 6cf57fd342..201ee168a9 100644
--- a/src/bin/eolian_mono/eolian/mono/documentation.hh
+++ b/src/bin/eolian_mono/eolian/mono/documentation.hh
@@ -367,20 +367,34 @@ struct documentation_generator
   auto options = 
efl::eolian::grammar::context_find_tag(context);
   // Example embedding not requested
   if (options.examples_dir.empty()) return true;
-  std::string file_name = options.examples_dir + full_object_name + ".cs";
+  bool is_plain_code = false;
+  std::string file_name = options.examples_dir + full_object_name + ".xml";
   std::ifstream exfile(file_name);
-  // There is no example file for this class or method, just return
-  if (!exfile.good()) return true;
+  if (!exfile.good())
+{
+   // There is no example XML file for this class, try a CS file
+   file_name = options.examples_dir + full_object_name + ".cs";
+   exfile.open(file_name);
+   // There are no example files for this class or method, just return
+   if (!exfile.good()) return true;
+   is_plain_code = true;
+}
   std::stringstream example_buff;
   // Start with a newline so the first line renders with same indentation 
as the rest
   example_buff << std::endl << exfile.rdbuf();
 
   if (!as_generator(scope_tab(scope_size) << "/// ").generate(sink, 
attributes::unused, context)) return false;
-  if (!generate_opening_tag(sink, "example", context)) return false;
-  if (!generate_opening_tag(sink, "code", context)) return false;
+  if (is_plain_code)
+{
+   if (!generate_opening_tag(sink, "example", context)) return false;
+   if (!generate_opening_tag(sink, "code", context)) return false;
+}
   if (!generate_escaped_content(sink, example_buff.str(), context)) return 
false;
-  if (!generate_closing_tag(sink, "code", context)) return false;
-  if (!generate_closing_tag(sink, "example", context)) return false;
+  if (is_plain_code)
+{
+   if (!generate_closing_tag(sink, "code", context)) return false;
+   if (!generate_closing_tag(sink, "example", context)) return false;
+}
   return as_generator("\n").generate(sink, attributes::unused, context);
}
 

-- 




[EGIT] [core/efl] master 01/01: efl_ui_format: fix some more harmless Coverity warnings

2019-09-16 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=22b329d2f446468fdd9077ffca1c784ddb39f9c3

commit 22b329d2f446468fdd9077ffca1c784ddb39f9c3
Author: Xavi Artigas 
Date:   Mon Sep 16 18:10:09 2019 +0200

efl_ui_format: fix some more harmless Coverity warnings

1403023 Unchecked return value
1403024 Unchecked return value
1403026 Unchecked return value

If the eina value conversion fails the default value (0) will be used, 
which is already a good default.
ERRs have been added so the developer has a hint of what is happening.
---
 src/lib/elementary/efl_ui_format.c | 9 ++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/src/lib/elementary/efl_ui_format.c 
b/src/lib/elementary/efl_ui_format.c
index 7e3ce115d3..d3cafa1e5a 100644
--- a/src/lib/elementary/efl_ui_format.c
+++ b/src/lib/elementary/efl_ui_format.c
@@ -110,14 +110,16 @@ _do_format_string(Efl_Ui_Format_Data *pd, Eina_Strbuf 
*str, const Eina_Value val
   case FORMAT_TYPE_DOUBLE:
   {
 double v = 0.0;
-eina_value_double_convert(, );
+if (!eina_value_double_convert(, ))
+   ERR("Format conversion failed");
 eina_strbuf_append_printf(str, pd->format_string, v);
 break;
   }
   case FORMAT_TYPE_INT:
   {
 int v = 0;
-eina_value_int_convert(, );
+if (!eina_value_int_convert(, ))
+   ERR("Format conversion failed");
 eina_strbuf_append_printf(str, pd->format_string, v);
 break;
   }
@@ -269,7 +271,8 @@ _efl_ui_format_formatted_value_get(Eo *obj EINA_UNUSED, 
Efl_Ui_Format_Data *pd,
 /* Search in the format_values array if we have one */
 Efl_Ui_Format_Value val = { 0 };
 int ndx;
-eina_value_int_convert(, );
+if (!eina_value_int_convert(, ))
+   ERR("Format conversion failed");
 ndx = eina_inarray_search_sorted(pd->format_values, , 
(Eina_Compare_Cb)_value_compare);
 if (ndx > -1) {
   Efl_Ui_Format_Value *entry = eina_inarray_nth(pd->format_values, 
ndx);

-- 




[EGIT] [core/efl] master 01/01: docs: Update Efl.Ui.Box_Stack docs

2019-09-16 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=416b01ee74f7d960b9c86b20ab8ab8bbf5a3c8d3

commit 416b01ee74f7d960b9c86b20ab8ab8bbf5a3c8d3
Author: Xavi Artigas 
Date:   Mon Sep 16 17:44:56 2019 +0200

docs: Update Efl.Ui.Box_Stack docs
---
 src/lib/elementary/efl_ui_box_stack.eo | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/lib/elementary/efl_ui_box_stack.eo 
b/src/lib/elementary/efl_ui_box_stack.eo
index 61035b45f9..060f470f35 100644
--- a/src/lib/elementary/efl_ui_box_stack.eo
+++ b/src/lib/elementary/efl_ui_box_stack.eo
@@ -2,7 +2,10 @@ class @beta Efl.Ui.Box_Stack extends Efl.Ui.Box
 {
[[A custom layout engine for @Efl.Ui.Box that stacks items.
 
- Items will be stacked on top of each other (in the Z direction).
+ Items will be stacked on top of each other (in the Z direction) meaning 
that, in the absence of transparency,
+ only the last item added through the @Efl.Pack interface will actually be 
visible.
+
+ This can be useful to display transparent objects on top of each other, 
for example.
]]
data: null;
implements {

-- 




[EGIT] [core/efl] master 01/01: docs: Clarify event emission in Image.Gfx.Image_Load_Controller

2019-09-16 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=22f3cc0574d50a57430ee35ab0ba0987a16af966

commit 22f3cc0574d50a57430ee35ab0ba0987a16af966
Author: Xavi Artigas 
Date:   Mon Sep 16 16:53:16 2019 +0200

docs: Clarify event emission in Image.Gfx.Image_Load_Controller

And minor formatting.
---
 .../interfaces/efl_gfx_image_load_controller.eo| 22 +++---
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/src/lib/efl/interfaces/efl_gfx_image_load_controller.eo 
b/src/lib/efl/interfaces/efl_gfx_image_load_controller.eo
index 2523d12d44..d7b0bbf238 100644
--- a/src/lib/efl/interfaces/efl_gfx_image_load_controller.eo
+++ b/src/lib/efl/interfaces/efl_gfx_image_load_controller.eo
@@ -21,8 +21,8 @@ interface @beta Efl.Gfx.Image_Load_Controller
   load_async_start {
  [[Begin preloading an image object's image data in the background.
 
-   Once the background task is complete the event $load,done will be
-   emitted.
+   Once the background task is complete the event @[.load,done] will be
+   emitted if loading succeeded, @[.load,error] otherwise.
  ]]
   }
   load_async_cancel {
@@ -51,9 +51,9 @@ interface @beta Efl.Gfx.Image_Load_Controller
 
The image will be loaded into memory as if it was the specified
size instead of its original size. This can save a lot of memory
-   and is important for scalable types like svg.
+   and is important for scalable types like SVG.
 
-   By default, the load size is not specified, so it is 0x0.
+   By default, the load size is not specified, so it is $[0x0].
  ]]
  set {
 [[Requests the canvas to load the image at the given size.
@@ -89,7 +89,7 @@ interface @beta Efl.Gfx.Image_Load_Controller
  ]]
  get {}
  values {
-support: bool; [[$true if region load of the image is supported, 
$false otherwise]]
+support: bool; [[$true if region load of the image is supported, 
$false otherwise.]]
  }
   }
   @property load_region {
@@ -101,7 +101,7 @@ interface @beta Efl.Gfx.Image_Load_Controller
 
Note: The image loader for the image format in question has
to support selective region loading in order for this function
-   to work.
+   to work (see @.load_region_support).
  ]]
  set {
  }
@@ -137,7 +137,7 @@ interface @beta Efl.Gfx.Image_Load_Controller
image. Most useful for the SVG image loader but also applies
to JPEG, PNG and BMP.
 
-   Powers of two (2, 4, 8) are best supported (especially with JPEG)
+   Powers of two (2, 4, 8, ...) are best supported (especially with 
JPEG).
  ]]
  set {
 [[Requests the image loader to scale down by $div times.
@@ -152,7 +152,7 @@ interface @beta Efl.Gfx.Image_Load_Controller
   @property load_skip_header {
  [[Initial load should skip header check and leave it all to data load.
 
-   If this is true, then future loads of images will defer header
+   If this is $true, then future loads of images will defer header
loading to a preload stage and/or data load later on rather than
at the start when the load begins (e.g. when file is set).
  ]]
@@ -160,12 +160,12 @@ interface @beta Efl.Gfx.Image_Load_Controller
  }
  get {}
  values {
-skip: bool; [[Will be true if header is to be skipped. ]]
+skip: bool; [[$true if header is to be skipped.]]
  }
   }
}
events {
-  load,done: void; [[Called when he image was loaded]]
-  load,error: Eina.Error; [[Called when an error happened during image 
loading]]
+  load,done: void; [[Emitted after the image has been loaded.]]
+  load,error: Eina.Error; [[Emitted if an error happened during image 
loading.]]
}
 }

-- 




[EGIT] [core/efl] master 02/02: elm/datepicker, timepicker: Fix uninitialized vars

2019-09-16 Thread Xavi Artigas
zmike pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=b0c3062e246a1f39835f783d345f71e5db3ba4ce

commit b0c3062e246a1f39835f783d345f71e5db3ba4ce
Author: Xavi Artigas 
Date:   Mon Sep 16 10:01:31 2019 -0400

elm/datepicker, timepicker: Fix uninitialized vars

Summary:
Should fix all timepicker and datepicker uninitializer variable usage 
detected by Coverity:
1396954 Uninitialized scalar variable: efl_ui_timepicker.c
1396978 Uninitialized scalar variable: efl_ui_timepicker.c
1397006 Uninitialized scalar variable: efl_ui_timepicker.c
1396979 Uninitialized scalar variable: efl_ui_datepicker.c
1404748 Uninitialized scalar variable: efl_ui_datepicker.c
1404757 Uninitialized scalar variable: efl_ui_datepicker.c

Test Plan: Everything builds and passes tests. Coverity should complain 
less.

Reviewers: stefan_schmidt, zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9967
---
 src/lib/elementary/efl_ui_datepicker.c | 2 +-
 src/lib/elementary/efl_ui_timepicker.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/lib/elementary/efl_ui_datepicker.c 
b/src/lib/elementary/efl_ui_datepicker.c
index 6a9cbb4d24..8a6ee63985 100644
--- a/src/lib/elementary/efl_ui_datepicker.c
+++ b/src/lib/elementary/efl_ui_datepicker.c
@@ -23,7 +23,7 @@
 
 #define DATE_SET()   \
do {  \
- Efl_Time t; \
+ Efl_Time t = { 0 }; \
  t.tm_year = pd->cur_date[DATEPICKER_YEAR] - 1900;   \
  t.tm_mon = pd->cur_date[DATEPICKER_MONTH] - 1;  \
  t.tm_mday = pd->cur_date[DATEPICKER_DAY]  - 1;  \
diff --git a/src/lib/elementary/efl_ui_timepicker.c 
b/src/lib/elementary/efl_ui_timepicker.c
index ba6917b4ee..2fc578dd61 100644
--- a/src/lib/elementary/efl_ui_timepicker.c
+++ b/src/lib/elementary/efl_ui_timepicker.c
@@ -22,7 +22,7 @@
 
 #define TIME_SET()   \
do {  \
- Efl_Time t; \
+ Efl_Time t = { 0 }; \
  t.tm_hour = pd->cur_time[TIMEPICKER_HOUR];  \
  t.tm_min = pd->cur_time[TIMEPICKER_MIN];\
  efl_datetime_manager_value_set(pd->dt_manager, t);  \

-- 




[EGIT] [core/efl] master 03/03: efl_ui_widget: remove misleading comments

2019-09-16 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=6065e7f141d5f3dfc4283bb8071a2fbcd960908d

commit 6065e7f141d5f3dfc4283bb8071a2fbcd960908d
Author: Xavi Artigas 
Date:   Mon Sep 16 12:37:59 2019 +0200

efl_ui_widget: remove misleading comments

Summary:
We settled for the focus_allow name.
The other APIs are not internal, they are protected, and this is
noted, no need to say that again.
Additionally it is not helpfull to have commented out c_prefix
definitions.
Depends on D9936

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9937
---
 src/lib/elementary/efl_ui_widget.eo | 4 
 1 file changed, 4 deletions(-)

diff --git a/src/lib/elementary/efl_ui_widget.eo 
b/src/lib/elementary/efl_ui_widget.eo
index f96bbee983..fe7a032324 100644
--- a/src/lib/elementary/efl_ui_widget.eo
+++ b/src/lib/elementary/efl_ui_widget.eo
@@ -25,7 +25,6 @@ abstract Efl.Ui.Widget extends Efl.Canvas.Group implements 
Efl.Access.Object,
  implements section.
  @since 1.22
]]
-   //c_prefix: efl_ui_widget;
event_prefix: efl_ui_widget;
data: Efl_Ui_Widget_Data;
methods {
@@ -179,7 +178,6 @@ abstract Efl.Ui.Widget extends Efl.Canvas.Group implements 
Efl.Access.Object,
  }
  return: bool; [[$true on success, $false otherwise]]
   }
-  // FIXME: focus_allow? can_focus? focusable?
   @property focus_allow {
  [[The ability for a widget to be focused.
 
@@ -253,8 +251,6 @@ abstract Efl.Ui.Widget extends Efl.Canvas.Group implements 
Efl.Access.Object,
 @in enable: bool; [[$true if accessibility is enabled.]]
  }
   }
-
-  /* Internal hooks. */
   widget_sub_object_add @protected {
  [[Virtual function customizing sub objects being added.
 

-- 




[EGIT] [core/efl] master 03/04: efl/image: Efl.Gfx.Image_Scale_Type -> Efl.Gfx.Image_Scale_Method

2019-09-16 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=944d5f37c7add5772a62d0d976db48b3a2a90982

commit 944d5f37c7add5772a62d0d976db48b3a2a90982
Author: Xavi Artigas 
Date:   Mon Sep 16 11:06:02 2019 +0200

efl/image: Efl.Gfx.Image_Scale_Type -> Efl.Gfx.Image_Scale_Method

ref T7927, T7875
Depends on D9931
---
 src/bin/elementary/test_bg.c| 18 +--
 src/bin/elementary/test_efl_gfx_mapping.c   |  2 +-
 src/bin/elementary/test_evas_map.c  |  2 +-
 src/bin/elementary/test_image.c | 20 ++--
 src/bin/elementary/test_part_bg.c   |  6 ++--
 src/bin/elementary/test_ui_image.c  | 20 ++--
 src/examples/elementary/bg_cxx_example_02.cc|  2 +-
 src/examples/elementary/efl_ui_list_example_1.c |  4 +--
 src/examples/elementary/icon_cxx_example_01.cc  |  2 +-
 src/lib/efl/interfaces/efl_gfx_image.eo |  7 +++--
 src/lib/elementary/efl_ui_bg.c  | 42 -
 src/lib/elementary/efl_ui_bg.eo |  2 +-
 src/lib/elementary/efl_ui_image.c   | 34 ++--
 src/lib/elementary/efl_ui_image.eo  |  2 +-
 src/lib/elementary/efl_ui_widget.c  | 10 +++---
 src/lib/elementary/efl_ui_widget_image.h|  2 +-
 src/lib/elementary/efl_ui_widget_part_bg.eo |  2 +-
 src/lib/elementary/efl_ui_win.c |  2 +-
 18 files changed, 90 insertions(+), 89 deletions(-)

diff --git a/src/bin/elementary/test_bg.c b/src/bin/elementary/test_bg.c
index 45afcac021..29fdeec7c3 100644
--- a/src/bin/elementary/test_bg.c
+++ b/src/bin/elementary/test_bg.c
@@ -318,7 +318,7 @@ _image_cb(void *data, const Efl_Event *ev)
  {
 efl_file_simple_get(ev->object, , );
 o = efl_add(EFL_UI_IMAGE_CLASS, win,
-efl_gfx_image_scale_type_set(efl_added, 
EFL_GFX_IMAGE_SCALE_TYPE_EXPAND),
+efl_gfx_image_scale_method_set(efl_added, 
EFL_GFX_IMAGE_SCALE_METHOD_EXPAND),
 efl_file_set(efl_added, f),
 efl_file_key_set(efl_added, k)
 );
@@ -380,7 +380,7 @@ _cb_radio_changed_scale_type(void *data, const Efl_Event 
*ev)
int v = efl_ui_radio_group_selected_value_get(bx);
if (v == -1) v = 0;
 
-   efl_gfx_image_scale_type_set(o_bg, v);
+   efl_gfx_image_scale_method_set(o_bg, v);
 }
 
 static void
@@ -437,48 +437,48 @@ test_bg_scale_type(void *data EINA_UNUSED, Evas_Object 
*obj EINA_UNUSED, void *e
   efl_pack(box, efl_added));
 
rd = efl_add(EFL_UI_RADIO_CLASS, hbox);
-   efl_ui_radio_state_value_set(rd, EFL_GFX_IMAGE_SCALE_TYPE_FILL);
+   efl_ui_radio_state_value_set(rd, EFL_GFX_IMAGE_SCALE_METHOD_FILL);
efl_text_set(rd, "Fill");
efl_gfx_hint_weight_set(rd, EFL_GFX_HINT_EXPAND, 0.0);
efl_event_callback_add(rd, EFL_UI_EVENT_SELECTED_CHANGED, 
_cb_radio_changed_scale_type, o_bg);
efl_pack(hbox, rd);
 
rd = efl_add(EFL_UI_RADIO_CLASS, hbox);
-   efl_ui_radio_state_value_set(rd, EFL_GFX_IMAGE_SCALE_TYPE_FIT);
+   efl_ui_radio_state_value_set(rd, EFL_GFX_IMAGE_SCALE_METHOD_FIT);
efl_text_set(rd, "Fit");
efl_gfx_hint_weight_set(rd, EFL_GFX_HINT_EXPAND, 0.0);
efl_event_callback_add(rd, EFL_UI_EVENT_SELECTED_CHANGED, 
_cb_radio_changed_scale_type, o_bg);
efl_pack(hbox, rd);
 
rd = efl_add(EFL_UI_RADIO_CLASS, hbox);
-   efl_ui_radio_state_value_set(rd, EFL_GFX_IMAGE_SCALE_TYPE_FIT_WIDTH);
+   efl_ui_radio_state_value_set(rd, EFL_GFX_IMAGE_SCALE_METHOD_FIT_WIDTH);
efl_text_set(rd, "Fit Horizontally");
efl_gfx_hint_weight_set(rd, EFL_GFX_HINT_EXPAND, 0.0);
efl_event_callback_add(rd, EFL_UI_EVENT_SELECTED_CHANGED, 
_cb_radio_changed_scale_type, o_bg);
efl_pack(hbox, rd);
 
rd = efl_add(EFL_UI_RADIO_CLASS, hbox);
-   efl_ui_radio_state_value_set(rd, EFL_GFX_IMAGE_SCALE_TYPE_FIT_HEIGHT);
+   efl_ui_radio_state_value_set(rd, EFL_GFX_IMAGE_SCALE_METHOD_FIT_HEIGHT);
efl_text_set(rd, "Fit Verically");
efl_gfx_hint_weight_set(rd, EFL_GFX_HINT_EXPAND, 0.0);
efl_event_callback_add(rd, EFL_UI_EVENT_SELECTED_CHANGED, 
_cb_radio_changed_scale_type, o_bg);
efl_pack(hbox, rd);
 
rd = efl_add(EFL_UI_RADIO_CLASS, hbox);
-   efl_ui_radio_state_value_set(rd, EFL_GFX_IMAGE_SCALE_TYPE_EXPAND);
+   efl_ui_radio_state_value_set(rd, EFL_GFX_IMAGE_SCALE_METHOD_EXPAND);
efl_text_set(rd, "Expand");
efl_gfx_hint_weight_set(rd, EFL_GFX_HINT_EXPAND, 0.0);
efl_event_callback_add(rd, EFL_UI_EVENT_SELECTED_CHANGED, 
_cb_radio_changed_scale_type, o_bg);
efl_pack(hbox, rd);
 
rd = efl_add(EFL_UI_RADIO_CLASS, hbox);
-   efl_ui_radio_state_value_set(rd, EFL_GFX_IMAGE_SCALE_TYPE_TILE);
+   efl_ui_radio_state_value_set(rd, EFL_GFX_IMAGE_SCALE_METHOD_TILE);
efl_text_set(rd, "Tile");
efl_gfx_hint_weight_set(rd, EFL_GFX_HINT_EXPAND, 

[EGIT] [core/efl] master 01/01: docs: Proper documentation for Collection and Item classes

2019-09-16 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=2ce877d9147caf310622b60fb28670a3e5ef34fa

commit 2ce877d9147caf310622b60fb28670a3e5ef34fa
Author: Xavi Artigas 
Date:   Fri Aug 30 11:53:40 2019 +0200

docs: Proper documentation for Collection and Item classes

Reviewers: bu5hm4n

Reviewed By: bu5hm4n

Subscribers: cedric, #reviewers, #committers

Tags: #efl, #documentation

Differential Revision: https://phab.enlightenment.org/D9798
---
 src/lib/elementary/efl_ui_collection.eo| 40 ++
 src/lib/elementary/efl_ui_default_item.eo  | 20 +++--
 src/lib/elementary/efl_ui_grid.eo  | 14 +++--
 src/lib/elementary/efl_ui_grid_default_item.eo |  7 +++--
 src/lib/elementary/efl_ui_group_item.eo| 10 ++-
 src/lib/elementary/efl_ui_item.eo  |  9 --
 src/lib/elementary/efl_ui_list.eo  | 14 +++--
 src/lib/elementary/efl_ui_list_default_item.eo |  6 ++--
 8 files changed, 85 insertions(+), 35 deletions(-)

diff --git a/src/lib/elementary/efl_ui_collection.eo 
b/src/lib/elementary/efl_ui_collection.eo
index d566ff15e0..ecd0eb1e94 100644
--- a/src/lib/elementary/efl_ui_collection.eo
+++ b/src/lib/elementary/efl_ui_collection.eo
@@ -7,34 +7,50 @@ class @beta Efl.Ui.Collection extends Efl.Ui.Layout_Base 
implements
Efl.Ui.Focus.Manager_Sub,
Efl.Ui.Widget_Focus_Manager
 {
-   [[This widget displays a list of items in an arrangement controlled by an 
external $position_manager object. By using different $position_manager objects 
this widget can show lists of items or two-dimensional grids of items, for 
example.
+   [[This widget displays a list of items in an arrangement controlled by an 
external @.position_manager
+ object. By using different @.position_manager objects this widget can 
show unidimensional lists or
+ two-dimensional grids of items, for example.
 
-Items inside this widget can be selected according to the $select_mode 
policy, and retrieved with $selected_items_get.
+ This class is intended to act as a base for widgets like @Efl.Ui.List or 
@Efl.Ui.Grid, which hide
+ this complexity from the user.
+
+ Items are added using the @Efl.Pack_Linear interface and must be of 
@Efl.Ui.Item type.
+
+ The direction of the arrangement can be controlled through 
@Efl.Ui.Layout_Orientable.orientation.
+
+ If all items do not fit in the current widget size scrolling facilities 
are provided.
+
+ Items inside this widget can be selected according to the 
@Efl.Ui.Multi_Selectable.select_mode
+ policy, and the selection can be retrieved with 
@Efl.Ui.Multi_Selectable.selected_items_get.
]]
event_prefix:efl_ui;
methods {
   item_scroll {
- [[Bring the passed item into the viewport.]]
+ [[Brings the passed item into the viewport.]]
  params {
-@in item: Efl.Ui.Item; [[The target to move in.]]
-@in animation: bool; [[If you want to have an animation or not.]]
+@in item: Efl.Ui.Item; [[The target to move into view.]]
+@in animation: bool; [[If you want to have an animated 
transition.]]
  }
   }
   item_scroll_align {
- [[Bring the passed item into the viewport, place the item accordingly 
to align in the viewport.
+ [[Brings the passed item into the viewport and align it.
 
- $align selects the final position of the object inside the viewport. 
0.0 will move the object to the first visible position inside the viewport, 1.0 
will move it to the last visible position, and values in between will move it 
accordingly to positions in between, along the scrolling axis.
+   $align selects the final position of the object inside the 
viewport. 0.0 will move the object
+   to the first visible position inside the viewport, 1.0 will move it 
to the last visible
+   position, and values in between will move it accordingly to 
positions in between, along the
+   scrolling axis.
  ]]
  params {
-@in item: Efl.Ui.Item; [[The target to move in.]]
-@in align: double; [[0.0 to have this item at the upper or left 
side of the viewport, 1.0 to have this item at the lower or right side of the 
viewport]]
-@in animation: bool; [[If you want to have an animation or not.]]
+@in item: Efl.Ui.Item; [[The target to move into view.]]
+@in align: double; [[0.0 to have this item at the upper or left 
side of the viewport,
+ 1.0 to have this item at the lower or right 
side of the viewport.]]
+@in animation: bool; [[If you want to have an animated 
transition.]]
  }
   }
   @property position_manager {
  [[Position manager object that handles placement of items.]]
  values

[EGIT] [core/efl] master 01/01: mono-docs: Remove useless semicolon from doc comments

2019-09-16 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=aa4c59b0dee5dabd153959023ec3c810c434682d

commit aa4c59b0dee5dabd153959023ec3c810c434682d
Author: Xavi Artigas 
Date:   Wed Aug 28 13:42:28 2019 +0200

mono-docs: Remove useless semicolon from doc comments
---
 src/bin/eolian_mono/eolian/mono/struct_definition.hh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/bin/eolian_mono/eolian/mono/struct_definition.hh 
b/src/bin/eolian_mono/eolian/mono/struct_definition.hh
index f4d55ea4f9..93eed6086c 100644
--- a/src/bin/eolian_mono/eolian/mono/struct_definition.hh
+++ b/src/bin/eolian_mono/eolian/mono/struct_definition.hh
@@ -436,7 +436,7 @@ struct struct_definition_generator
   // Constructor with default parameters for easy struct initialization
   if(!as_generator(
   indent << scope_tab << "/// Constructor for " 
<< string << ".\n"
-  << *(indent << scope_tab << field_argument_docs << ";\n")
+  << *(indent << scope_tab << field_argument_docs << "\n")
   << indent << scope_tab << "public " << string << "(\n"
   << ((indent << scope_tab << scope_tab << 
field_argument_default) % ",\n")
   << indent << scope_tab << ")\n"

-- 




[EGIT] [core/efl] master 01/01: Rename Efl.Gfx.Image.Stretch_Region -> Efl.Gfx.Image_Stretch_Region

2019-09-16 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=bc955f35bb5a7fc88133fe811c48123a9b49f8f0

commit bc955f35bb5a7fc88133fe811c48123a9b49f8f0
Author: Xavi Artigas 
Date:   Fri Jul 26 22:35:40 2019 +0200

Rename Efl.Gfx.Image.Stretch_Region -> Efl.Gfx.Image_Stretch_Region

Otherwise we have a symbol <-> namespace clash. Again.
---
 src/lib/efl/interfaces/efl_gfx_image.eo | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/lib/efl/interfaces/efl_gfx_image.eo 
b/src/lib/efl/interfaces/efl_gfx_image.eo
index 64bd6b873d..db71b17ab5 100644
--- a/src/lib/efl/interfaces/efl_gfx_image.eo
+++ b/src/lib/efl/interfaces/efl_gfx_image.eo
@@ -40,7 +40,7 @@ enum @beta Efl.Gfx.Image_Scale_Type
none [[Not scale the image]]
 }
 
-struct Efl.Gfx.Image.Stretch_Region
+struct Efl.Gfx.Image_Stretch_Region
 {
[[This struct holds the description of a stretchable region in one 
dimension (vertical or horizontal).
Used when scaling an image.
@@ -183,8 +183,8 @@ interface @beta Efl.Gfx.Image
  }
  get {}
  values {
-horizontal: iterator; 
[[Representation of area that are stretchable in the image horizontal space.]]
-vertical: iterator; 
[[Representation of area that are stretchable in the image vertical space.]]
+horizontal: iterator; 
[[Representation of area that are stretchable in the image horizontal space.]]
+vertical: iterator; 
[[Representation of area that are stretchable in the image vertical space.]]
  }
   }
   @property image_size {

-- 




[EGIT] [core/efl] master 01/02: mono-docs: More tweaks to the docs blacklist

2019-09-16 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=4b80c5b4e14d62138464a9c629ad3209922b2c48

commit 4b80c5b4e14d62138464a9c629ad3209922b2c48
Author: Xavi Artigas 
Date:   Thu Jul 25 16:38:52 2019 +0200

mono-docs: More tweaks to the docs blacklist
---
 doc/docfx/filterConfig.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/docfx/filterConfig.yml b/doc/docfx/filterConfig.yml
index 616c03fb87..e03726ce9c 100644
--- a/doc/docfx/filterConfig.yml
+++ b/doc/docfx/filterConfig.yml
@@ -4,7 +4,7 @@ apiRules:
 - exclude:
 uidRegex: ^.*NativeStruct$
 - exclude:
-uidRegex: ^.*ConstructingHandle.*$
+uidRegex: ^.*NativeClass$
 - exclude:
 uidRegex: ^.*WrappingHandle.*$
 - exclude:

-- 




[EGIT] [core/efl] master 01/01: efl_task/exe: Further update docs

2019-09-16 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=f78b4861af140bd5b333fb530556e81915acbaab

commit f78b4861af140bd5b333fb530556e81915acbaab
Author: Xavi Artigas 
Date:   Tue Sep 10 12:26:03 2019 +0200

efl_task/exe: Further update docs
---
 src/lib/ecore/efl_exe.eo  | 23 ---
 src/lib/ecore/efl_task.eo |  2 +-
 2 files changed, 13 insertions(+), 12 deletions(-)

diff --git a/src/lib/ecore/efl_exe.eo b/src/lib/ecore/efl_exe.eo
index 30ce703248..23b68935e4 100644
--- a/src/lib/ecore/efl_exe.eo
+++ b/src/lib/ecore/efl_exe.eo
@@ -15,7 +15,7 @@ enum @beta Efl.Exe_Signal {
 }
 
 enum @beta Efl.Exe_Flags {
-   [[Flags to customize task behavior.]] // TODO: This needs more detail.
+   [[Flags to customize process behavior.]]
none = 0, [[No special flags.]]
group_leader = 1, [[Process will be executed in its own session.]]
hide_io  = 4  [[All console IO will be hidden.]]
@@ -23,20 +23,21 @@ enum @beta Efl.Exe_Flags {
 
 class @beta Efl.Exe extends Efl.Task implements Efl.Io.Reader, Efl.Io.Writer, 
Efl.Io.Closer, Efl.Core.Command_Line
 {
-   [[The Efl.Exe
-
- Efl.Exe is a kind of specialized @Efl.Task which is a abstraction of 
process(task).
- This class provides a way to execute some commands with certain executing 
flags under certain environment variables.
- and also it can provides a way to manage signals to a process that it 
handles.]]
+   [[This is a specialized @Efl.Task which abstracts an operating system 
process.
+ This class provides a way to start a task by running an executable file 
(specified using the
+ @Efl.Core.Command_Line interface) and further customize its execution 
flags (@.exe_flags) and
+ environment variables (@.env).
+ It also allows communicating with the process through signals (@.signal).
+   ]]
methods {
   signal {
- [[Send a signal to this task.]]
+ [[Send a signal to this process.]]
  params {
 sig: Efl.Exe_Signal; [[Signal number to send.]]
  }
   }
   @property exe_flags {
-[[Customize the task's behavior.]]
+[[Customize the process' behavior.]]
 set { }
 get { }
 values {
@@ -44,17 +45,17 @@ class @beta Efl.Exe extends Efl.Task implements 
Efl.Io.Reader, Efl.Io.Writer, Ef
 }
   }
   @property exit_signal {
- [[The final exit signal of this task.]]
+ [[The signal this process emitted upon exiting, if any.]]
  get { }
  values {
 sig: int; [[The exit signal, or -1 if no exit signal happened.]]
  }
   }
   @property env {
- [[If $env is $null then the process created by this object is
+ [[If $env is $NULL then the process created by this object is
going to inherit the environment of this process.
 
-   In case $env is not $null then the environment variables declared
+   In case $env is not $NULL then the environment variables declared
in this object will represent the environment passed to the new 
process.
  ]]
  get {
diff --git a/src/lib/ecore/efl_task.eo b/src/lib/ecore/efl_task.eo
index baf8ce80b5..6fd162bd90 100644
--- a/src/lib/ecore/efl_task.eo
+++ b/src/lib/ecore/efl_task.eo
@@ -58,7 +58,7 @@ abstract Efl.Task extends Efl.Loop_Consumer
   }
   end @pure_virtual {
  [[Request the task end (may send a signal or interrupt
-   signal resulting in a terminate event being tiggered in the
+   signal resulting in a terminate event being triggered in the
target task loop).]]
   }
}

-- 




[EGIT] [core/efl] master 01/01: eolian: Remove the EOLIAN_PROPERTY_DOC_WARN envvar

2019-09-16 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=4c018509c5fe644bbfc38e9b2501ddfa8f62d978

commit 4c018509c5fe644bbfc38e9b2501ddfa8f62d978
Author: Xavi Artigas 
Date:   Fri Sep 13 12:41:16 2019 +0200

eolian: Remove the EOLIAN_PROPERTY_DOC_WARN envvar

This test is now always enabled, so ALL properties should have 
property-level
documentation. Setter and getter docs are optional.
---
 src/lib/eolian/eo_parser.c | 23 ++-
 1 file changed, 10 insertions(+), 13 deletions(-)

diff --git a/src/lib/eolian/eo_parser.c b/src/lib/eolian/eo_parser.c
index 3786dcc198..1631082081 100644
--- a/src/lib/eolian/eo_parser.c
+++ b/src/lib/eolian/eo_parser.c
@@ -1217,19 +1217,16 @@ parse_accessor:
check_next(ls, '{');
if ((ls->t.token == TOK_DOC) && !prop->impl->common_doc)
  {
-if (getenv("EOLIAN_PROPERTY_DOC_WARN"))
-  {
- Eolian_Object tmp;
- memset(, 0, sizeof(Eolian_Object));
- tmp.file = prop->base.file;
- tmp.line = line;
- tmp.column = col;
- tmp.unit = ls->unit;
- eolian_state_log_obj(ls->state, ,
-  "%s doc without property doc for '%s.%s'",
-  is_get ? "getter" : "setter",
-  ls->klass->base.name, prop->base.name);
-  }
+Eolian_Object tmp;
+memset(, 0, sizeof(Eolian_Object));
+tmp.file = prop->base.file;
+tmp.line = line;
+tmp.column = col;
+tmp.unit = ls->unit;
+eolian_state_log_obj(ls->state, ,
+ "%s doc without property doc for '%s.%s'",
+ is_get ? "getter" : "setter",
+ ls->klass->base.name, prop->base.name);
  }
if (is_get)
  {

-- 




[EGIT] [core/efl] master 01/01: mono-docs: Add more event args link for event handlers

2019-09-16 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=d13c59fb8953764a4042aa481e5b88f7a1eb56b6

commit d13c59fb8953764a4042aa481e5b88f7a1eb56b6
Author: Xavi Artigas 
Date:   Fri Aug 2 17:29:27 2019 +0200

mono-docs: Add more event args link for event handlers

There were some events missing  tags (see 
f01b1134012bafcc4d0c82588230796a7c9ef5bb)
---
 src/bin/eolian_mono/eolian/mono/events.hh | 4 
 1 file changed, 4 insertions(+)

diff --git a/src/bin/eolian_mono/eolian/mono/events.hh 
b/src/bin/eolian_mono/eolian/mono/events.hh
index 6daccc21c9..053fd65579 100644
--- a/src/bin/eolian_mono/eolian/mono/events.hh
+++ b/src/bin/eolian_mono/eolian/mono/events.hh
@@ -367,6 +367,10 @@ struct event_definition_generator
 
   if(!as_generator(documentation(1)).generate(sink, evt, context))
 return false;
+  if (etype.is_engaged())
+if (!as_generator(
+scope_tab << "/// \n"
+ ).generate(sink, evt, context)) return false;
 
   // Visible event declaration. Either a regular class member or an 
explicit interface implementation.
   if (klass.type == attributes::class_type::interface_ || klass.type == 
attributes::class_type::mixin)

-- 




[EGIT] [core/efl] master 01/01: mono-docs: Proper indentation for previous commit

2019-09-16 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=3fd5542f6dd6b9905c0ab33037e69e8af140267c

commit 3fd5542f6dd6b9905c0ab33037e69e8af140267c
Author: Xavi Artigas 
Date:   Fri Aug 2 13:53:19 2019 +0200

mono-docs: Proper indentation for previous commit
---
 src/bin/eolian_mono/eolian/mono/events.hh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/bin/eolian_mono/eolian/mono/events.hh 
b/src/bin/eolian_mono/eolian/mono/events.hh
index 777d22591c..013b7d8702 100644
--- a/src/bin/eolian_mono/eolian/mono/events.hh
+++ b/src/bin/eolian_mono/eolian/mono/events.hh
@@ -283,7 +283,7 @@ struct event_declaration_generator
).generate(sink, evt, context)) return false;
   if (evt.type.is_engaged())
 if (!as_generator(
-scope_tab << scope_tab << "/// \n"
+scope_tab << "/// \n"
  ).generate(sink, evt, context)) return false;
   if (!as_generator(
   scope_tab << "event EventHandler" << wrapper_args_type << " " << 
evt_name << ";\n"

-- 




[EGIT] [core/efl] master 02/02: mono-docs: Clearer docs for ConstructingHandle

2019-09-16 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=5a3d659006c66c82617aafa544218f141d33d323

commit 5a3d659006c66c82617aafa544218f141d33d323
Author: Xavi Artigas 
Date:   Thu Jul 25 17:30:44 2019 +0200

mono-docs: Clearer docs for ConstructingHandle

Only *slightly* clearer.
---
 src/bin/eolian_mono/eolian/mono/klass.hh | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/bin/eolian_mono/eolian/mono/klass.hh 
b/src/bin/eolian_mono/eolian/mono/klass.hh
index a98866e34a..46215b95a1 100644
--- a/src/bin/eolian_mono/eolian/mono/klass.hh
+++ b/src/bin/eolian_mono/eolian/mono/klass.hh
@@ -204,7 +204,8 @@ struct klass
 
  if (!as_generator
 (
- scope_tab << "/// Constructor to be used when objects 
are expected to be constructed from native code.\n"
+ scope_tab << "/// Subclasses should override this 
constructor if they are expected to be instantiated from native code.\n"
+ << scope_tab << "/// Do not call this constructor 
directly.\n"
  << scope_tab << "/// Tag struct storing the 
native handle of the object being constructed.\n"
  << scope_tab << "private " << concrete_name << 
"(ConstructingHandle ch) : base(ch)\n"
  << scope_tab << "{\n"
@@ -511,7 +512,8 @@ struct klass
  << (*(scope_tab << scope_tab << constructor_invocation << 
"\n"))
  << scope_tab << scope_tab << "FinishInstantiation();\n"
  << scope_tab << "}\n\n"
- << scope_tab << "/// Constructor to be used when 
objects are expected to be constructed from native code.\n"
+ << scope_tab << "/// Subclasses should override 
this constructor if they are expected to be instantiated from native code.\n"
+ << scope_tab << "/// Do not call this constructor 
directly.\n"
  << scope_tab << "/// Tag struct 
storing the native handle of the object being constructed.\n"
  << scope_tab << "protected " << inherit_name << 
"(ConstructingHandle ch) : base(ch)\n"
  << scope_tab << "{\n"

-- 




[EGIT] [core/efl] master 01/01: eolian_gen: add missing param doc for event raising

2019-09-16 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=6bac60262e859a5ff5de6eed9ca0d596262d9537

commit 6bac60262e859a5ff5de6eed9ca0d596262d9537
Author: Xavi Artigas 
Date:   Fri Sep 13 14:26:21 2019 +0200

eolian_gen: add missing param doc for event raising
---
 src/bin/eolian_mono/eolian/mono/events.hh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/bin/eolian_mono/eolian/mono/events.hh 
b/src/bin/eolian_mono/eolian/mono/events.hh
index 053fd65579..14a7f9b5ce 100644
--- a/src/bin/eolian_mono/eolian/mono/events.hh
+++ b/src/bin/eolian_mono/eolian/mono/events.hh
@@ -416,6 +416,7 @@ struct event_definition_generator
   std::string upper_c_name = utils::to_uppercase(evt.c_name);
   if (!as_generator(
 scope_tab << "/// Method to raise event "<< event_name << 
".\n"
+<< scope_tab << "/// Event to raise.\n"
 << scope_tab << "public void On" << event_name << "(" << 
event_args_type << " e)\n"
 << scope_tab << "{\n"
 << scope_tab << scope_tab << "var key = \"_" << upper_c_name << 
"\";\n"

-- 




[EGIT] [core/efl] master 01/01: Efl.Ui.Text: Minor tweaks on the documentation.

2019-09-16 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=e40f666807ea4dfd19dfd37b96c8da5a56c7a62e

commit e40f666807ea4dfd19dfd37b96c8da5a56c7a62e
Author: Xavi Artigas 
Date:   Thu Feb 7 18:01:56 2019 +0100

Efl.Ui.Text: Minor tweaks on the documentation.
---
 src/lib/elementary/efl_ui_selection_types.eot |  2 +-
 src/lib/elementary/efl_ui_text.eo | 24 ++--
 2 files changed, 11 insertions(+), 15 deletions(-)

diff --git a/src/lib/elementary/efl_ui_selection_types.eot 
b/src/lib/elementary/efl_ui_selection_types.eot
index a8d156c37e..cbe5e0dc7b 100644
--- a/src/lib/elementary/efl_ui_selection_types.eot
+++ b/src/lib/elementary/efl_ui_selection_types.eot
@@ -11,7 +11,7 @@ enum @beta Efl.Ui.Selection_Format
 {
[[Selection format]]
targets = -1, [[For matching every possible atom]]
-   none = 0x0, [[Content is from outside of Elementary]]
+   none = 0x0, [[Content is from outside of EFL]]
text = 0x01, [[Plain unformatted text: Used for things that don't want rich 
markup]]
markup = 0x2, [[Edje textblock markup, including inline images]]
image = 0x4, [[Images]]
diff --git a/src/lib/elementary/efl_ui_text.eo 
b/src/lib/elementary/efl_ui_text.eo
index 4ebb3faec8..d34b2822d2 100644
--- a/src/lib/elementary/efl_ui_text.eo
+++ b/src/lib/elementary/efl_ui_text.eo
@@ -5,24 +5,20 @@ class @beta Efl.Ui.Text extends Efl.Ui.Layout_Base implements 
Efl.Ui.Clickable,
  Efl.Access.Text, Efl.Access.Editable.Text, Efl.File,
  Efl.Ui.Selectable, Efl.Text_Interactive, Efl.Text_Markup
 {
-   [[Efl UI text class]]
+   [[A flexible text widget which can be static (as a label) or editable by
+ the user (as a text entry). It provides all sorts of editing facilities
+ like automatic scrollbars, virtual keyboard, clipboard, configurable
+ context menus, password mode or autocapitalization, for example.]]
methods {
   @property scrollable {
- set {
-[[Enable or disable scrolling in entry
+ [[Enable or disable scrolling in the widget.
 
-  Normally the entry is not scrollable unless you enable it with 
this call.
-]]
- }
- get {
-[[Get the scrollable state of the entry
-
-  Normally the entry is not scrollable. This gets the scrollable 
state
-  of the entry.
-]]
- }
+   When scrolling is enabled scrollbars will appear if the text does
+   not fit the widget size.]]
+ set {}
+ get {}
  values {
-scroll: bool; [[$true if it is to be scrollable, $false 
otherwise.]]
+scroll: bool; [[$true to enable scrolling. Default is $false.]]
  }
   }
   @property input_panel_show_on_demand {

-- 




[EGIT] [core/efl] master 01/01: docs: nicer formatting of the NULL keyword, everywhere

2019-09-16 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=96d8b9bc3e5b14e2a8ad004debffa220ff28e36d

commit 96d8b9bc3e5b14e2a8ad004debffa220ff28e36d
Author: Xavi Artigas 
Date:   Tue Sep 10 16:05:44 2019 +0200

docs: nicer formatting of the NULL keyword, everywhere
---
 src/lib/ecore/ecore_event_message.eo | 2 +-
 src/lib/ecore/efl_io_copier.eo   | 2 +-
 src/lib/ecore_audio/ecore_audio.eo   | 2 +-
 src/lib/ecore_con/efl_net_dialer.eo  | 4 ++--
 src/lib/ecore_con/efl_net_dialer_http.eo | 6 +++---
 src/lib/ecore_con/efl_net_dialer_ssl.eo  | 4 ++--
 src/lib/ecore_con/efl_net_dialer_tcp.eo  | 4 ++--
 src/lib/ecore_con/efl_net_dialer_websocket.eo| 2 +-
 src/lib/ecore_con/efl_net_ip_address.eo  | 2 +-
 src/lib/ecore_con/efl_net_session.eo | 6 +++---
 src/lib/ecore_con/efl_net_socket_ssl.eo  | 6 +++---
 src/lib/ecore_con/efl_net_ssl_context.eo | 2 +-
 src/lib/efl/interfaces/efl_gfx_color_class.eo| 2 +-
 src/lib/efl/interfaces/efl_io_buffer.eo  | 2 +-
 src/lib/elementary/efl_access_object.eo  | 2 +-
 src/lib/elementary/efl_ui_item.eo| 4 ++--
 src/lib/elementary/efl_ui_popup.eo   | 4 ++--
 src/lib/elementary/efl_ui_position_manager_data_access_v1.eo | 2 +-
 src/lib/elementary/efl_ui_scroll_manager.eo  | 2 +-
 src/lib/elementary/efl_ui_spotlight_container.eo | 2 +-
 src/lib/elementary/efl_ui_tags.eo| 2 +-
 src/lib/elementary/efl_ui_text.eo| 2 +-
 src/lib/elementary/elm_code_widget.eo| 2 +-
 src/lib/eo/efl_object.eo | 2 +-
 src/lib/evas/canvas/efl_canvas_animation_rotate.eo   | 2 +-
 src/lib/evas/canvas/efl_canvas_animation_scale.eo| 2 +-
 26 files changed, 37 insertions(+), 37 deletions(-)

diff --git a/src/lib/ecore/ecore_event_message.eo 
b/src/lib/ecore/ecore_event_message.eo
index ca39084c17..a674da49bc 100644
--- a/src/lib/ecore/ecore_event_message.eo
+++ b/src/lib/ecore/ecore_event_message.eo
@@ -15,7 +15,7 @@ class @beta Ecore.Event.Message extends Efl.Loop_Message
   }
   data_steal {
  [[ Steal the data out and set internal values to -1
-for type and NULL for other vals ]]
+for type and $NULL for other vals ]]
  params {
 @out type: int; [[ The event type ]]
 @out data: void_ptr; [[ The event data ]]
diff --git a/src/lib/ecore/efl_io_copier.eo b/src/lib/ecore/efl_io_copier.eo
index 2e9506d394..e172a0c41d 100644
--- a/src/lib/ecore/efl_io_copier.eo
+++ b/src/lib/ecore/efl_io_copier.eo
@@ -147,7 +147,7 @@ class @beta Efl.Io.Copier extends Efl.Loop_Consumer 
implements Efl.Io.Closer {
  If @.source is flagged "eos" and all data is written to the
  destination then the "done" event is emitted.
 
- If the destination is not set (ie: NULL) then data is kept
+ If the destination is not set (ie: $NULL) then data is kept
  in a internal @Eina.Binbuf, which can be stolen with
  @.binbuf_steal once "data" or "line" events are
  emitted. It exists as a useful shortcut to easily drain
diff --git a/src/lib/ecore_audio/ecore_audio.eo 
b/src/lib/ecore_audio/ecore_audio.eo
index 79be83c5dd..45fb7a0e6d 100644
--- a/src/lib/ecore_audio/ecore_audio.eo
+++ b/src/lib/ecore_audio/ecore_audio.eo
@@ -89,7 +89,7 @@ abstract @beta Ecore.Audio extends Efl.Object
   data: void_ptr; [[User data to pass to the VIO functions]]
   free_func: efl_key_data_free_func; [[This function takes care to
   clean up $data when he VIO is
-  destroyed. NULL means do
+  destroyed. $NULL means do
   nothing.
 ]]
  }
diff --git a/src/lib/ecore_con/efl_net_dialer.eo 
b/src/lib/ecore_con/efl_net_dialer.eo
index 47685e1434..8570e6538e 100644
--- a/src/lib/ecore_con/efl_net_dialer.eo
+++ b/src/lib/ecore_con/efl_net_dialer.eo
@@ -74,7 +74,7 @@ interface @beta Efl.Net.Dialer extends Efl.Net.Socket {
   'http'.
 
   Whenever appropriate dialers may use system proxy if the
-  proxy is NULL (the default). To forcefully disable
+  proxy is $NULL (the default). To forcefully disable
   proxy, use an empty string ("").
 
 - http://username:password\@

[EGIT] [core/efl] master 01/03: mono-docs: Indicate when a class is BETA

2019-09-16 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=5585420e858bbb17ae3b7cc599b4a0f2eb178075

commit 5585420e858bbb17ae3b7cc599b4a0f2eb178075
Author: Xavi Artigas 
Date:   Tue Jul 23 16:38:04 2019 +0200

mono-docs: Indicate when a class is BETA

Summary:
The mono generator adds a  section to all BETA classes with an 
explanatory text.
These tags are understood by DocFX and Monodevelop.
On top of this, this commit modifies the DocFX template to give the Remarks 
section a more
prominent place in the page.

Test Plan: Render docs, Beta classes should have a big blue box with a 
remark about the class being Beta and dangerous.

Reviewers: lauromoura, vitor.sousa

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9381
---
 doc/docfx/default_efl/partials/class.header.tmpl.partial | 10 ++
 doc/docfx/default_efl/partials/class.tmpl.partial|  4 
 doc/docfx/default_efl/styles/docfx.css   |  6 ++
 src/bin/eolian_mono/eolian/mono/documentation.hh |  6 ++
 4 files changed, 18 insertions(+), 8 deletions(-)

diff --git a/doc/docfx/default_efl/partials/class.header.tmpl.partial 
b/doc/docfx/default_efl/partials/class.header.tmpl.partial
index f6bff1af39..18c6dc7341 100644
--- a/doc/docfx/default_efl/partials/class.header.tmpl.partial
+++ b/doc/docfx/default_efl/partials/class.header.tmpl.partial
@@ -3,6 +3,12 @@
 {{>partials/title}}
 {{{summary}}}
 {{{conceptual}}}
+{{#remarks}}
+
+{{__global.remarks}}
+{{{remarks}}}
+
+{{/remarks}}
 {{#inClass}}
 
   {{__global.inheritance}}
@@ -82,10 +88,6 @@
   
 
 {{/syntax.typeParameters.0}}
-{{#remarks}}
-{{__global.remarks}}
-{{{remarks}}}
-{{/remarks}}
 {{#example.0}}
 {{__global.examples}}
 {{/example.0}}
diff --git a/doc/docfx/default_efl/partials/class.tmpl.partial 
b/doc/docfx/default_efl/partials/class.tmpl.partial
index ae9de66364..75bfce0e9b 100644
--- a/doc/docfx/default_efl/partials/class.tmpl.partial
+++ b/doc/docfx/default_efl/partials/class.tmpl.partial
@@ -143,10 +143,6 @@
 {{__global.overrides}}
 
 {{/overridden}}
-{{#remarks}}
-{{__global.remarks}}
-{{{remarks}}}
-{{/remarks}}
 {{#example.0}}
 {{__global.examples}}
 {{/example.0}}
diff --git a/doc/docfx/default_efl/styles/docfx.css 
b/doc/docfx/default_efl/styles/docfx.css
index f94c4b0377..81beac718e 100644
--- a/doc/docfx/default_efl/styles/docfx.css
+++ b/doc/docfx/default_efl/styles/docfx.css
@@ -995,3 +995,9 @@ div.embeddedvideo iframe {
 
 .mainContainer[dir='rtl'] main ul[role="tablist"] {
   margin: 0; }
+
+.remarks {
+  background-color: #c0c0ff;
+  border-radius: 6px;
+  padding: 6px;
+}
diff --git a/src/bin/eolian_mono/eolian/mono/documentation.hh 
b/src/bin/eolian_mono/eolian/mono/documentation.hh
index a672d209b4..26e5645eb2 100644
--- a/src/bin/eolian_mono/eolian/mono/documentation.hh
+++ b/src/bin/eolian_mono/eolian/mono/documentation.hh
@@ -12,6 +12,7 @@
 #include 
 
 static const std::string BETA_REF_SUFFIX = " (object still in beta stage)";
+static const std::string BETA_SUMMARY_REMARKS = "This is a \\BETA\\ 
class. It can be modified or removed in the future. Do not use it for product 
development.";
 
 namespace eolian_mono {
 
@@ -390,6 +391,11 @@ struct documentation_generator
{
if (!generate(sink, klass.documentation, context)) return false;
 
+   if (klass.is_beta)
+ {
+if (!generate_tag(sink, "remarks", BETA_SUMMARY_REMARKS, context)) 
return false;
+ }
+
std::string klass_name = 
name_helpers::klass_full_concrete_or_interface_name(klass);
return generate_tag_example(sink, klass_name, context);
}

-- 




[EGIT] [core/efl] master 03/03: mono-docs: Indicate when methods and properties are BETA

2019-09-16 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=7c030aa57e0141bd5802b7201f31b9bd7b138a0f

commit 7c030aa57e0141bd5802b7201f31b9bd7b138a0f
Author: Xavi Artigas 
Date:   Tue Jul 23 20:58:42 2019 +0200

mono-docs: Indicate when methods and properties are BETA

Summary:
Previous commit added a  section to BETA classes.
Methods (and properties) cannot have  section so a bit
of bold text is added instead to their summary.

Depends on D9380

Test Plan: Generate docs and observe beta methods and properties have a 
note regarding their betaness in the summary.

Reviewers: lauromoura, vitor.sousa

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9382
---
 src/bin/eolian_mono/eolian/mono/documentation.hh | 38 +++-
 1 file changed, 31 insertions(+), 7 deletions(-)

diff --git a/src/bin/eolian_mono/eolian/mono/documentation.hh 
b/src/bin/eolian_mono/eolian/mono/documentation.hh
index 26e5645eb2..93bc42ef4b 100644
--- a/src/bin/eolian_mono/eolian/mono/documentation.hh
+++ b/src/bin/eolian_mono/eolian/mono/documentation.hh
@@ -12,7 +12,9 @@
 #include 
 
 static const std::string BETA_REF_SUFFIX = " (object still in beta stage)";
-static const std::string BETA_SUMMARY_REMARKS = "This is a \\BETA\\ 
class. It can be modified or removed in the future. Do not use it for product 
development.";
+static const std::string BETA_CLASS_REMARK = "This is a \\BETA\\ 
class. It can be modified or removed in the future. Do not use it for product 
development.";
+static const std::string BETA_PROPERTY_REMARK = "\n\n\\This is a BETA 
property\\. It can be modified or removed in the future. Do not use it 
for product development.";
+static const std::string BETA_METHOD_REMARK = "\n\n\\This is a BETA 
method\\. It can be modified or removed in the future. Do not use it for 
product development.";
 
 namespace eolian_mono {
 
@@ -393,7 +395,7 @@ struct documentation_generator
 
if (klass.is_beta)
  {
-if (!generate_tag(sink, "remarks", BETA_SUMMARY_REMARKS, context)) 
return false;
+if (!generate_tag(sink, "remarks", BETA_CLASS_REMARK, context)) 
return false;
  }
 
std::string klass_name = 
name_helpers::klass_full_concrete_or_interface_name(klass);
@@ -403,7 +405,17 @@ struct documentation_generator
template
bool generate(OutputIterator sink, attributes::property_def const& prop, 
Context const& context) const
{
-   if (!generate(sink, prop.documentation, context))
+   std::string tail_text = "";
+
+   if (!prop.klass.is_beta)
+ {
+if ((prop.setter.is_engaged() && prop.setter->is_beta) ||
+(prop.getter.is_engaged() && prop.getter->is_beta))
+  {
+ tail_text = BETA_PROPERTY_REMARK;
+  }
+ }
+   if (!generate(sink, prop.documentation, context, tail_text))
  return false;
 
std::string text;
@@ -434,16 +446,21 @@ struct documentation_generator
template
bool generate_property(OutputIterator sink, attributes::function_def const& 
func, Context const& context) const
{
+   std::string tail_text = "";
+   if (!func.klass.is_beta && func.is_beta)
+ {
+tail_text = BETA_METHOD_REMARK;
+ }
 
// First, try the get/set specific documentation
if (!func.documentation.summary.empty())
  {
-if (!generate(sink, func.documentation, context))
+if (!generate(sink, func.documentation, context, tail_text))
   return false;
  }
else // fallback to common property documentation
  {
-if (!generate(sink, func.property_documentation, context))
+if (!generate(sink, func.property_documentation, context, 
tail_text))
   return false;
  }
 
@@ -463,7 +480,13 @@ struct documentation_generator
template
bool generate_function(OutputIterator sink, attributes::function_def const& 
func, Context const& context) const
{
-   if (!generate(sink, func.documentation, context))
+   std::string tail_text = "";
+   if (!func.klass.is_beta && func.is_beta)
+ {
+tail_text = BETA_METHOD_REMARK;
+ }
+
+   if (!generate(sink, func.documentation, context, tail_text))
  return false;
 
for (auto&& param : func.parameters)
@@ -486,11 +509,12 @@ struct documentation_generator
}
 
template
-   bool generate(OutputIterator sink, attributes::documentation_def const& 
doc, Context const& context) const
+   bool generate(OutputIterator sink, attributes::documentation_def const& 
d

[EGIT] [core/efl] master 02/03: mono-docs: Allow HTML codes in documentation

2019-09-16 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=d20b8ad42adf8ce6968fc39c38960cf933218780

commit d20b8ad42adf8ce6968fc39c38960cf933218780
Author: Xavi Artigas 
Date:   Tue Jul 23 12:45:17 2019 +0200

mono-docs: Allow HTML codes in documentation

Summary:
All comments from EO files are HTML-escaped (i.e. "<" is turned into 
""), and this is good.
However all text added by the mono code generator is HTML-escaped too, and 
that is a pity.
Circumventing the escaping in the generator involves serious code changes 
so it is simpler to
allow "escaping" characters to avoid escaping...
"<" is turned into ""
but
"\<" is turned into "<"

If you are giving these strings from C, remember that the backslash needs 
to be escaped too!
For example: "\\Hello\\"

This is intended for use in the generators, NOT in the EO docs.

Test Plan: Everything works as before, but now HTML codes can be added from 
the generators.

Reviewers: lauromoura, vitor.sousa, felipealmeida

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9380
---
 src/lib/eolian_cxx/grammar/html_escaped_string.hpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/lib/eolian_cxx/grammar/html_escaped_string.hpp 
b/src/lib/eolian_cxx/grammar/html_escaped_string.hpp
index 9a6eef1f7c..371afcda24 100644
--- a/src/lib/eolian_cxx/grammar/html_escaped_string.hpp
+++ b/src/lib/eolian_cxx/grammar/html_escaped_string.hpp
@@ -26,6 +26,7 @@ struct html_escaped_string_generator
case '\'': out.append(""); break;
case '<':  out.append(""); break;
case '>':  out.append(""); break;
+   case '\\': if (pos < input.size() - 1) pos++; // Deliberate 
fallthrough
default:   out.append([pos], 1); break;
 }
 }

-- 




[EGIT] [core/efl] master 01/01: eolian_mono: Fix whitespace in generated cs files

2019-09-16 Thread Xavi Artigas
xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=84601549e8d50ff6f3671728f68100b220c1e89b

commit 84601549e8d50ff6f3671728f68100b220c1e89b
Author: Xavi Artigas 
Date:   Thu Aug 1 13:27:51 2019 +0200

eolian_mono: Fix whitespace in generated cs files

Pet peeve of mine.
---
 src/bin/eolian_mono/eolian/mono/events.hh|  6 +++---
 src/bin/eolian_mono/eolian/mono/klass.hh |  2 +-
 src/bin/eolian_mono/eolian/mono/struct_definition.hh | 20 ++--
 3 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/src/bin/eolian_mono/eolian/mono/events.hh 
b/src/bin/eolian_mono/eolian/mono/events.hh
index ef4f5f4dbd..fc623d02e3 100644
--- a/src/bin/eolian_mono/eolian/mono/events.hh
+++ b/src/bin/eolian_mono/eolian/mono/events.hh
@@ -247,12 +247,12 @@ struct event_argument_wrapper_generator
 
   std::string evt_name = name_helpers::managed_event_name(evt.name);
 
-  return as_generator("///Event argument wrapper for event Event argument wrapper for event .\n"
   << "[Efl.Eo.BindingEntity]\n"
   << "public class " << 
name_helpers::managed_event_args_short_name(evt) << " : EventArgs {\n"
-  << scope_tab << "///Actual event 
payload.\n"
+  << scope_tab << "/// Actual event 
payload.\n"
   << scope_tab << "public " << type << " arg { get; 
set; }\n"
   << "}\n"
  ).generate(sink, *etype, context);
@@ -404,7 +404,7 @@ struct event_definition_generator
   auto library_name = 
context_find_tag(context).actual_library_name(klass.filename);
   std::string upper_c_name = utils::to_uppercase(evt.c_name);
   if (!as_generator(
-scope_tab << "///Method to raise event "<< event_name << 
".\n"
+scope_tab << "/// Method to raise event "<< event_name << 
".\n"
 << scope_tab << "public void On" << event_name << "(" << 
event_args_type << " e)\n"
 << scope_tab << "{\n"
 << scope_tab << scope_tab << "var key = \"_" << upper_c_name << 
"\";\n"
diff --git a/src/bin/eolian_mono/eolian/mono/klass.hh 
b/src/bin/eolian_mono/eolian/mono/klass.hh
index 46215b95a1..80d4debc99 100644
--- a/src/bin/eolian_mono/eolian/mono/klass.hh
+++ b/src/bin/eolian_mono/eolian/mono/klass.hh
@@ -459,7 +459,7 @@ struct klass
  auto inherit_name = name_helpers::klass_concrete_name(cls);
 
  if(!as_generator(
-scope_tab << "///Pointer to the native class 
description.\n"
+scope_tab << "/// Pointer to the native class 
description.\n"
 << scope_tab << "public override System.IntPtr NativeClass\n"
 << scope_tab << "{\n"
 << scope_tab << scope_tab << "get\n"
diff --git a/src/bin/eolian_mono/eolian/mono/struct_definition.hh 
b/src/bin/eolian_mono/eolian/mono/struct_definition.hh
index c949783945..d358dc78ba 100644
--- a/src/bin/eolian_mono/eolian/mono/struct_definition.hh
+++ b/src/bin/eolian_mono/eolian/mono/struct_definition.hh
@@ -274,7 +274,7 @@ struct struct_internal_definition_generator
  if (!as_generator
  (
   indent << "#pragma warning disable CS1591\n\n"
-  << indent << "///Internal wrapper for struct " << string << 
".\n"
+  << indent << "/// Internal wrapper for struct " << string 
<< ".\n"
   << indent << "[StructLayout(LayoutKind.Sequential)]\n"
   << indent << "public struct " << string << "\n"
   << indent << "{\n"
@@ -295,7 +295,7 @@ struct struct_internal_definition_generator
   || regular->base_type == "stringshare"
   || regular->base_type == "any_value_ptr")))
 {
-   if (!as_generator(indent << scope_tab << "///Internal 
wrapper for field " << field_name << "\n"
+   if (!as_generator(indent << scope_tab << "/// Internal 
wrapper for field " << field_name << "\n"
  << indent << scope_tab << "public 
System.IntPtr " << field_

  1   2   3   >