Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get().
I thought there is no reason to be discussd. Because nobody cared this on the mail thread. Only me and Daniel talked about this. And Nobody disagreed except me and Daniel when Rafael and Bluezery asked it. If you want then I can search the history for you. Even the similar API (maybe genlist/gengrid_item_object_get()) I removed before elm 1.0 Because it looked no need to be there at the moment even the API was not pretty much good to me. But Now, people want it, So i added it again. And this api doesnt expose internal structure. It's regardless the symbol. Thank you. -Original Message- From: "Iván Briano"@gmail.com> To: "Enlightenment developer list"@lists.sourceforge.net>; Cc: Sent: 2013-09-04 (수) 01:35:48 Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get(). On Tue, Sep 3, 2013 at 9:12 AM, ChunEon Park @naver.com> wrote: > just it. > That's not how you raise a discussion, you did it by proposing the solution to a given problem before committing said solution. And since it seems we are into slowly allowing all sorts of "not recommended" behaviors, why don't we just expose every single structure in our header files and let developers who believe to know what they are doing just access everything? It'll save us a lot of time and entries in the symbols tables. > > -Regards, Hermet- > > -Original Message- > From: "Tom Hacohen"@samsung.com> > To: "Enlightenment developer > list"@lists.sourceforge.net>; > Cc: > Sent: 2013-09-03 (화) 21:08:10 > Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: > elementary/widget - introduce elm_object_item_object_get(). > > On 03/09/13 13:01, ChunEon Park wrote: >> And i raised again. > > When? By committing and hoping it would go unnoticed until Mike saw the > commit and commented on it? > > -- > Tom. > > > -- > Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! > Discover the easy way to master current and previous Microsoft technologies > and advance your career. Get an incredible 1,500+ hours of step-by-step > tutorial videos with LearnDevNow. Subscribe today and save! > http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > -- > Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! > Discover the easy way to master current and previous Microsoft technologies > and advance your career. Get an incredible 1,500+ hours of step-by-step > tutorial videos with LearnDevNow. Subscribe today and save! > http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get().
I thought there is no reason to discuss. Because nobody cared this. Only me and Daniel talked about this. And Nobody disagreed except me and Daniel when Rafael and Bluezery asked it. If you want then I can search the history for you. Even that API I removed before. Because it looked no need to be there at the moment even the API is not pretty much good. But Now, people want it, So i added it again. And This api doesnt expose internal structure. It's regardless the symbol. Thank you. -Regards, Hermet- -Original Message- From: "Iván Briano" To: "Enlightenment developer list"; Cc: Sent: 2013-09-04 (수) 01:35:48 Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get(). On Tue, Sep 3, 2013 at 9:12 AM, ChunEon Park @naver.com> wrote: > just it. > That's not how you raise a discussion, you did it by proposing the solution to a given problem before committing said solution. And since it seems we are into slowly allowing all sorts of "not recommended" behaviors, why don't we just expose every single structure in our header files and let developers who believe to know what they are doing just access everything? It'll save us a lot of time and entries in the symbols tables. > > -Regards, Hermet- > > -Original Message- > From: "Tom Hacohen"@samsung.com> > To: "Enlightenment developer > list"@lists.sourceforge.net>; > Cc: > Sent: 2013-09-03 (화) 21:08:10 > Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: > elementary/widget - introduce elm_object_item_object_get(). > > On 03/09/13 13:01, ChunEon Park wrote: >> And i raised again. > > When? By committing and hoping it would go unnoticed until Mike saw the > commit and commented on it? > > -- > Tom. > > > -- > Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! > Discover the easy way to master current and previous Microsoft technologies > and advance your career. Get an incredible 1,500+ hours of step-by-step > tutorial videos with LearnDevNow. Subscribe today and save! > http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > -- > Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! > Discover the easy way to master current and previous Microsoft technologies > and advance your career. Get an incredible 1,500+ hours of step-by-step > tutorial videos with LearnDevNow. Subscribe today and save! > http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get().
On Tue, Sep 3, 2013 at 9:12 AM, ChunEon Park wrote: > just it. > That's not how you raise a discussion, you did it by proposing the solution to a given problem before committing said solution. And since it seems we are into slowly allowing all sorts of "not recommended" behaviors, why don't we just expose every single structure in our header files and let developers who believe to know what they are doing just access everything? It'll save us a lot of time and entries in the symbols tables. > > -Regards, Hermet- > > -Original Message- > From: "Tom Hacohen" > To: "Enlightenment developer list"; > Cc: > Sent: 2013-09-03 (화) 21:08:10 > Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: > elementary/widget - introduce elm_object_item_object_get(). > > On 03/09/13 13:01, ChunEon Park wrote: >> And i raised again. > > When? By committing and hoping it would go unnoticed until Mike saw the > commit and commented on it? > > -- > Tom. > > > -- > Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! > Discover the easy way to master current and previous Microsoft technologies > and advance your career. Get an incredible 1,500+ hours of step-by-step > tutorial videos with LearnDevNow. Subscribe today and save! > http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > -- > Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! > Discover the easy way to master current and previous Microsoft technologies > and advance your career. Get an incredible 1,500+ hours of step-by-step > tutorial videos with LearnDevNow. Subscribe today and save! > http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get().
On Tue, Sep 3, 2013 at 1:54 PM, Michael Blumenkrantz wrote: > On Tue, 3 Sep 2013 13:35:48 -0300 > Iván Briano wrote: > >> On Tue, Sep 3, 2013 at 9:12 AM, ChunEon Park wrote: >> > just it. >> > >> >> That's not how you raise a discussion, you did it by proposing the >> solution to a given problem >> before committing said solution. >> >> And since it seems we are into slowly allowing all sorts of "not >> recommended" behaviors, why don't >> we just expose every single structure in our header files and let >> developers who believe to know what >> they are doing just access everything? It'll save us a lot of time and >> entries in the symbols tables. > > that's how e works and I hear no complaints from its developers problem here is that it's a lib... bad APIs stay until we decide to do a new major release. in E we can break the API at will. If what Hermet wanted was to "raise the question again" like he said, by this thread he clearly accomplished that. And people complained it's bad. Again. So let's revert until there's consensus this is inevitable or there's a better way, ok? Lucas De Marchi -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get().
On Tue, 3 Sep 2013 16:46:17 -0300 Lucas De Marchi wrote: > On Tue, Sep 3, 2013 at 1:54 PM, Michael Blumenkrantz > wrote: > > On Tue, 3 Sep 2013 13:35:48 -0300 > > Iván Briano wrote: > > > >> On Tue, Sep 3, 2013 at 9:12 AM, ChunEon Park wrote: > >> > just it. > >> > > >> > >> That's not how you raise a discussion, you did it by proposing the > >> solution to a given problem > >> before committing said solution. > >> > >> And since it seems we are into slowly allowing all sorts of "not > >> recommended" behaviors, why don't > >> we just expose every single structure in our header files and let > >> developers who believe to know what > >> they are doing just access everything? It'll save us a lot of time and > >> entries in the symbols tables. > > > > that's how e works and I hear no complaints from its developers > > problem here is that it's a lib... bad APIs stay until we decide to do > a new major release. > > in E we can break the API at will. > > If what Hermet wanted was to "raise the question again" like he said, > by this thread he clearly accomplished that. And people complained > it's bad. Again. So let's revert until there's consensus this is > inevitable or there's a better way, ok? > > > Lucas De Marchi > I guess my sarcasm didn't translate there; it has nothing to do with breaking api, it's that I'm the only e developer. I agree that this should probably be reverted until we reach an agreement to avoid another one of those cases where it gets left in and then released because we forget about it. -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get().
On Tue, Sep 3, 2013 at 1:54 PM, Michael Blumenkrantz wrote: > On Tue, 3 Sep 2013 13:35:48 -0300 > Iván Briano wrote: > >> On Tue, Sep 3, 2013 at 9:12 AM, ChunEon Park wrote: >> > just it. >> > >> >> That's not how you raise a discussion, you did it by proposing the >> solution to a given problem >> before committing said solution. >> >> And since it seems we are into slowly allowing all sorts of "not >> recommended" behaviors, why don't >> we just expose every single structure in our header files and let >> developers who believe to know what >> they are doing just access everything? It'll save us a lot of time and >> entries in the symbols tables. > > that's how e works and I hear no complaints from its developers Your psychiatrist will be happy to know you are not talking to yourself. > >> >> > >> > -Regards, Hermet- >> > >> > -----Original Message----- >> > From: "Tom Hacohen" >> > To: "Enlightenment developer >> > list"; >> > Cc: >> > Sent: 2013-09-03 (화) 21:08:10 >> > Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: >> > elementary/widget - introduce elm_object_item_object_get(). >> > >> > On 03/09/13 13:01, ChunEon Park wrote: >> >> And i raised again. >> > >> > When? By committing and hoping it would go unnoticed until Mike saw the >> > commit and commented on it? >> > >> > -- >> > Tom. -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get().
On Tue, 3 Sep 2013 13:35:48 -0300 Iván Briano wrote: > On Tue, Sep 3, 2013 at 9:12 AM, ChunEon Park wrote: > > just it. > > > > That's not how you raise a discussion, you did it by proposing the > solution to a given problem > before committing said solution. > > And since it seems we are into slowly allowing all sorts of "not > recommended" behaviors, why don't > we just expose every single structure in our header files and let > developers who believe to know what > they are doing just access everything? It'll save us a lot of time and > entries in the symbols tables. that's how e works and I hear no complaints from its developers > > > > > -Regards, Hermet- > > > > -Original Message- > > From: "Tom Hacohen" > > To: "Enlightenment developer > > list"; > > Cc: > > Sent: 2013-09-03 (화) 21:08:10 > > Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: > > elementary/widget - introduce elm_object_item_object_get(). > > > > On 03/09/13 13:01, ChunEon Park wrote: > >> And i raised again. > > > > When? By committing and hoping it would go unnoticed until Mike saw the > > commit and commented on it? > > > > -- > > Tom. -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get().
On Tue, 3 Sep 2013 13:56:48 -0300 Iván Briano wrote: > On Tue, Sep 3, 2013 at 1:54 PM, Michael Blumenkrantz > wrote: > > On Tue, 3 Sep 2013 13:35:48 -0300 > > Iván Briano wrote: > > > >> On Tue, Sep 3, 2013 at 9:12 AM, ChunEon Park wrote: > >> > just it. > >> > > >> > >> That's not how you raise a discussion, you did it by proposing the > >> solution to a given problem > >> before committing said solution. > >> > >> And since it seems we are into slowly allowing all sorts of "not > >> recommended" behaviors, why don't > >> we just expose every single structure in our header files and let > >> developers who believe to know what > >> they are doing just access everything? It'll save us a lot of time and > >> entries in the symbols tables. > > > > that's how e works and I hear no complaints from its developers > > Your psychiatrist will be happy to know you are not talking to yourself. but zmike and I are such good friends! > > > > >> > >> > -------------------- > >> > -Regards, Hermet- > >> > > >> > -Original Message- > >> > From: "Tom Hacohen" > >> > To: "Enlightenment developer > >> > list"; > >> > Cc: > >> > Sent: 2013-09-03 (화) 21:08:10 > >> > Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: > >> > elementary/widget - introduce elm_object_item_object_get(). > >> > > >> > On 03/09/13 13:01, ChunEon Park wrote: > >> >> And i raised again. > >> > > >> > When? By committing and hoping it would go unnoticed until Mike saw the > >> > commit and commented on it? > >> > > >> > -- > >> > Tom. -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get().
just it. -Regards, Hermet- -Original Message- From: "Tom Hacohen" To: "Enlightenment developer list"; Cc: Sent: 2013-09-03 (화) 21:08:10 Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get(). On 03/09/13 13:01, ChunEon Park wrote: > And i raised again. When? By committing and hoping it would go unnoticed until Mike saw the commit and commented on it? -- Tom. -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get().
On 03/09/13 13:01, ChunEon Park wrote: > And i raised again. When? By committing and hoping it would go unnoticed until Mike saw the commit and commented on it? -- Tom. -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get().
And i raised again. -Regards, Hermet- -Original Message- From: "Tom Hacohen" To: "Enlightenment developer list"; Cc: Sent: 2013-09-03 (화) 20:56:57 Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get(). On 03/09/13 12:44, ChunEon Park wrote: > Normally. we dont' have discussion for just adding simple API. > So I didin't. > > I knew that If it had the problem, then somebody would argue the objection. As Antognolli said, it had been discussed and rejected. -- Tom. -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get().
On 03/09/13 12:44, ChunEon Park wrote: > Normally. we dont' have discussion for just adding simple API. > So I didin't. > > I knew that If it had the problem, then somebody would argue the objection. As Antognolli said, it had been discussed and rejected. -- Tom. -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get().
Normally. we dont' have discussion for just adding simple API.
So I didin't.
I knew that If it had the problem, then somebody would argue the objection.
---
-Regards, Hermet-
-Original Message-
From: "Rafael Antognolli"
To: "Enlightenment developer list";
Cc:
Sent: 2013-09-03 (화) 10:20:51
Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget
- introduce elm_object_item_object_get().
Totally agree with Mike and Tom.
I have even asked for this more than once, got the "It was decided
that elementary wouldn't expose the object" answer, and had to work
around this through other methods. Now it just gets in without
discussions.
-1 for changing this without discussion.
On Mon, Sep 2, 2013 at 6:20 AM, Tom Hacohen @samsung.com> wrote:
> I have to side with Mike here. Both the decision process and the
> solution smell badly. Worse than Mike's tuna breakfasts.
>
> --
> Tom.
>
> On 02/09/13 09:48, ChunEon Park wrote:
>> If they know what they are doing exactly, then it won' t be problem.
>> This gives the applications a chance to decorate their appilcation easily.
>>
>>
>> -Regards, Hermet-
>>
>> -Original Message-
>> From: "Michael Blumenkrantz"@gmail.com>
>> To: "Enlightenment developer
>> list"@lists.sourceforge.net>;
>> Cc:
>> Sent: 2013-09-02 (월) 17:29:41
>> Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01:
>> elementary/widget - introduce elm_object_item_object_get().
>>
>> so wait a minute...everyone fights against this for literally over a year,
>> and now it gets in without further discussion because "applications require
>> it" seriously?
>>
>>
>> On Mon, Sep 2, 2013 at 9:25 AM, ChunEon Park - Enlightenment Git <
>> no-re...@enlightenment.org> wrote:
>>
>>> hermet pushed a commit to branch master.
>>>
>>> commit ddc3cf80ce0a50a9161fcb212d3414f5d7b5898c
>>> Author: ChunEon Park @hermet.pe.kr>
>>> Date: Mon Sep 2 17:19:36 2013 +0900
>>>
>>> elementary/widget - introduce elm_object_item_object_get().
>>>
>>> We've countered application's requirements multiple times to they have
>>> the object handle from the elm_object_item.
>>>
>>> Now we introduce it for their convenient but they should use it
>>> carefully.
>>> ---
>>> ChangeLog 6 +-
>>> NEWS1 +
>>> src/lib/elm_main.c 6 ++
>>> src/lib/elm_object_item.h 19 +++
>>> src/lib/elm_removed.h 15 +--
>>> src/lib/elm_widget.c7 +++
>>> src/lib/elm_widget.h1 +
>>> 7 files changed, 40 insertions(+), 15 deletions(-)
>>>
>>> diff --git a/ChangeLog b/ChangeLog
>>> index 4c59fdc..1695f01 100644
>>> --- a/ChangeLog
>>> +++ b/ChangeLog
>>> @@ -1578,6 +1578,10 @@
>>>
>>> * Gengrid: implement selectraise feature.
>>>
>>> -2013-08-28 DAniel Juyung Seo (SeoZ)
>>> +2013-08-28 Daniel Juyung Seo (SeoZ)
>>>
>>> * Bg: Add bg reset feature.
>>> +
>>> +2013-09-02 ChunEon Park (Hermet)
>>> +
>>> +* Widget: Introduce elm_object_item_object_get() API.
>>> diff --git a/NEWS b/NEWS
>>> index c2056f3..c6046bd 100644
>>> --- a/NEWS
>>> +++ b/NEWS
>>> @@ -85,6 +85,7 @@ Additions:
>>> * Add elm_win_focus_highlight_animate_set/get().
>>> * Add selectraise feature to gengrid.
>>> * Add bg reset feature.
>>> + * Add elm_object_item_object_get().
>>>
>>> Improvements:
>>>
>>> diff --git a/src/lib/elm_main.c b/src/lib/elm_main.c
>>> index 2fa2ea0..9f138b2 100644
>>> --- a/src/lib/elm_main.c
>>> +++ b/src/lib/elm_main.c
>>> @@ -1859,3 +1859,9 @@ elm_object_item_cursor_engine_only_get(const
>>> Elm_Object_Item *it)
>>> {
>>> return elm_widget_item_cursor_engine_only_get(it);
>>> }
>>> +
>>> +EAPI const Evas_Object *
>>> +elm_object_item_object_get(const Elm_Object_Item *it)
>>> +{
>>> + return _elm_widget_item_object_get((Elm_Widget_Item*)it);
>>> +}
>>> diff --git a/src/lib/elm_object_item.h b/src/lib/elm_object_item.h
>>> index 8a0ccde..f256a63 100644
>>> --- a/src/lib/elm_
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get().
Carsten Haitzler wrote: >On Tue, 3 Sep 2013 04:19:37 +1000 David Seikel >said: > >> On Tue, 3 Sep 2013 02:52:14 +0900 (KST) ChunEon Park > >> wrote: >> >> > There is no way to add resize callback to the object item at this >> > moment. >> > >> > And sure, this api can be dangerous if app uses it incorrectly. >> >> C can be dangerous if app uses it incorrectly. It's well known for >it >> in fact. B-) >> >> Safety is for high level languages. C is for people that want or >need >> to get their hands on nasty low level details. I really don't think >> much effort should be spent on protecting C coders from themselves, >at >> the expense of making it hard to do stuff. >> >> This is just a general principle though, I've not looked at the API >in >> question. > >i used to think that... but in the past 4 years or so... reality has >changed my >mind on this. :) > >p.s. > >just to set the record - efl, even back to imlib2 and imlib2 has always >had a >habit of "assuming programmer is dumb and pick up the pieces for them" >- that's >why there was always a cache... assume programmer will be dumb and load >1 image >100 times, so go de-duplicate on load for them by matching file path >keys >etc. ... and keep images around for a bit in case needed again soon - >this >allows a certain amount of laziness for the programmer - early on that >was me - >to just be dumb and know the lib will be smart for them. but this is a >different kind of "protection". it's assuming a programmer is lazy and >will do >the lazy thing... so make up for it, but the core principle is the same >- >assume programmer will be bad and save them from themselves. :) > >-- >- Codito, ergo sum - "I code, therefore I am" >-- >The Rasterman (Carsten Haitzler)ras...@rasterman.com > > >-- >Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! >Discover the easy way to master current and previous Microsoft >technologies >and advance your career. Get an incredible 1,500+ hours of step-by-step >tutorial videos with LearnDevNow. Subscribe today and save! >http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk >___ >enlightenment-devel mailing list >enlightenment-devel@lists.sourceforge.net >https://lists.sourceforge.net/lists/listinfo/enlightenment-devel So if we're keen on safety checks and coddling bad programmers, can we start adding safety checks to some functions like elm_popup_add to make them always return NULL? -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get().
Totally agree with Mike and Tom.
I have even asked for this more than once, got the "It was decided
that elementary wouldn't expose the object" answer, and had to work
around this through other methods. Now it just gets in without
discussions.
-1 for changing this without discussion.
On Mon, Sep 2, 2013 at 6:20 AM, Tom Hacohen wrote:
> I have to side with Mike here. Both the decision process and the
> solution smell badly. Worse than Mike's tuna breakfasts.
>
> --
> Tom.
>
> On 02/09/13 09:48, ChunEon Park wrote:
>> If they know what they are doing exactly, then it won' t be problem.
>> This gives the applications a chance to decorate their appilcation easily.
>>
>>
>> -Regards, Hermet-
>>
>> -Original Message-
>> From: "Michael Blumenkrantz"
>> To: "Enlightenment developer
>> list";
>> Cc:
>> Sent: 2013-09-02 (월) 17:29:41
>> Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01:
>> elementary/widget - introduce elm_object_item_object_get().
>>
>> so wait a minute...everyone fights against this for literally over a year,
>> and now it gets in without further discussion because "applications require
>> it" seriously?
>>
>>
>> On Mon, Sep 2, 2013 at 9:25 AM, ChunEon Park - Enlightenment Git <
>> no-re...@enlightenment.org> wrote:
>>
>>> hermet pushed a commit to branch master.
>>>
>>> commit ddc3cf80ce0a50a9161fcb212d3414f5d7b5898c
>>> Author: ChunEon Park @hermet.pe.kr>
>>> Date: Mon Sep 2 17:19:36 2013 +0900
>>>
>>> elementary/widget - introduce elm_object_item_object_get().
>>>
>>> We've countered application's requirements multiple times to they have
>>> the object handle from the elm_object_item.
>>>
>>> Now we introduce it for their convenient but they should use it
>>> carefully.
>>> ---
>>> ChangeLog 6 +-
>>> NEWS1 +
>>> src/lib/elm_main.c 6 ++
>>> src/lib/elm_object_item.h 19 +++
>>> src/lib/elm_removed.h 15 +--
>>> src/lib/elm_widget.c7 +++
>>> src/lib/elm_widget.h1 +
>>> 7 files changed, 40 insertions(+), 15 deletions(-)
>>>
>>> diff --git a/ChangeLog b/ChangeLog
>>> index 4c59fdc..1695f01 100644
>>> --- a/ChangeLog
>>> +++ b/ChangeLog
>>> @@ -1578,6 +1578,10 @@
>>>
>>> * Gengrid: implement selectraise feature.
>>>
>>> -2013-08-28 DAniel Juyung Seo (SeoZ)
>>> +2013-08-28 Daniel Juyung Seo (SeoZ)
>>>
>>> * Bg: Add bg reset feature.
>>> +
>>> +2013-09-02 ChunEon Park (Hermet)
>>> +
>>> +* Widget: Introduce elm_object_item_object_get() API.
>>> diff --git a/NEWS b/NEWS
>>> index c2056f3..c6046bd 100644
>>> --- a/NEWS
>>> +++ b/NEWS
>>> @@ -85,6 +85,7 @@ Additions:
>>> * Add elm_win_focus_highlight_animate_set/get().
>>> * Add selectraise feature to gengrid.
>>> * Add bg reset feature.
>>> + * Add elm_object_item_object_get().
>>>
>>> Improvements:
>>>
>>> diff --git a/src/lib/elm_main.c b/src/lib/elm_main.c
>>> index 2fa2ea0..9f138b2 100644
>>> --- a/src/lib/elm_main.c
>>> +++ b/src/lib/elm_main.c
>>> @@ -1859,3 +1859,9 @@ elm_object_item_cursor_engine_only_get(const
>>> Elm_Object_Item *it)
>>> {
>>> return elm_widget_item_cursor_engine_only_get(it);
>>> }
>>> +
>>> +EAPI const Evas_Object *
>>> +elm_object_item_object_get(const Elm_Object_Item *it)
>>> +{
>>> + return _elm_widget_item_object_get((Elm_Widget_Item*)it);
>>> +}
>>> diff --git a/src/lib/elm_object_item.h b/src/lib/elm_object_item.h
>>> index 8a0ccde..f256a63 100644
>>> --- a/src/lib/elm_object_item.h
>>> +++ b/src/lib/elm_object_item.h
>>> @@ -34,6 +34,25 @@ typedef void
>>> (*Elm_Object_Item_Signal_Cb)(void *data, Elm_Objec
>>> EAPI Evas_Object *elm_object_item_widget_get(const
>>> Elm_Object_Item *it);
>>>
>>> /**
>>> + * Get the object item's internal object handle.
>>> + *
>>> + * @param it The Elementary object item
>>> + * @return The Internal object of the object item.
>>> + *
>>>
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get().
On Tue, 3 Sep 2013 08:24:59 +0900 Carsten Haitzler (The Rasterman) wrote: > On Tue, 3 Sep 2013 04:19:37 +1000 David Seikel > said: > > > On Tue, 3 Sep 2013 02:52:14 +0900 (KST) ChunEon Park > > wrote: > > > > > There is no way to add resize callback to the object item at this > > > moment. > > > > > > And sure, this api can be dangerous if app uses it incorrectly. > > > > C can be dangerous if app uses it incorrectly. It's well known for > > it in fact. B-) > > > > Safety is for high level languages. C is for people that want or > > need to get their hands on nasty low level details. I really don't > > think much effort should be spent on protecting C coders from > > themselves, at the expense of making it hard to do stuff. > > > > This is just a general principle though, I've not looked at the API > > in question. > > i used to think that... but in the past 4 years or so... reality has > changed my mind on this. :) > > p.s. > > just to set the record - efl, even back to imlib2 and imlib2 has > always had a habit of "assuming programmer is dumb and pick up the > pieces for them" - that's why there was always a cache... assume > programmer will be dumb and load 1 image 100 times, so go > de-duplicate on load for them by matching file path keys etc. ... and > keep images around for a bit in case needed again soon - this allows > a certain amount of laziness for the programmer - early on that was > me - to just be dumb and know the lib will be smart for them. but > this is a different kind of "protection". it's assuming a programmer > is lazy and will do the lazy thing... so make up for it, but the core > principle is the same - assume programmer will be bad and save them > from themselves. :) So long as you don't get in the way of the good programmers, coz that's just annoying. :-P -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. signature.asc Description: PGP signature -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get().
On Tue, 3 Sep 2013 04:19:37 +1000 David Seikel said: > On Tue, 3 Sep 2013 02:52:14 +0900 (KST) ChunEon Park > wrote: > > > There is no way to add resize callback to the object item at this > > moment. > > > > And sure, this api can be dangerous if app uses it incorrectly. > > C can be dangerous if app uses it incorrectly. It's well known for it > in fact. B-) > > Safety is for high level languages. C is for people that want or need > to get their hands on nasty low level details. I really don't think > much effort should be spent on protecting C coders from themselves, at > the expense of making it hard to do stuff. > > This is just a general principle though, I've not looked at the API in > question. i used to think that... but in the past 4 years or so... reality has changed my mind on this. :) p.s. just to set the record - efl, even back to imlib2 and imlib2 has always had a habit of "assuming programmer is dumb and pick up the pieces for them" - that's why there was always a cache... assume programmer will be dumb and load 1 image 100 times, so go de-duplicate on load for them by matching file path keys etc. ... and keep images around for a bit in case needed again soon - this allows a certain amount of laziness for the programmer - early on that was me - to just be dumb and know the lib will be smart for them. but this is a different kind of "protection". it's assuming a programmer is lazy and will do the lazy thing... so make up for it, but the core principle is the same - assume programmer will be bad and save them from themselves. :) -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get().
On Tue, 3 Sep 2013 02:52:14 +0900 (KST) ChunEon Park wrote: > There is no way to add resize callback to the object item at this > moment. > > And sure, this api can be dangerous if app uses it incorrectly. C can be dangerous if app uses it incorrectly. It's well known for it in fact. B-) Safety is for high level languages. C is for people that want or need to get their hands on nasty low level details. I really don't think much effort should be spent on protecting C coders from themselves, at the expense of making it hard to do stuff. This is just a general principle though, I've not looked at the API in question. signature.asc Description: PGP signature -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get().
There is no way to add resize callback to the object item at this moment. And sure, this api can be dangerous if app uses it incorrectly. However, If this api should be used by all apps obligatorily, then I won't add it. Problem is, we can't sure all apis are perfect in the world. simply like double free(). So we provide api doc to warn the developers for dangerous cases. -Regards, Hermet- -Original Message- From: "daniel.za...@samsung.com" To: "Enlightenment developer list"; Cc: "ChunEon Park"; Sent: 2013-09-02 (월) 20:01:07 Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get(). Sorry for the dumb question but resize callback can't help on that? Imo, storing pointers to obsolete objects can be very dangerous. But it is just my opinion ;-) Vive Valgrind! Vive la France! JackDanielZ, alias daniel On 09/02/2013 01:53 PM, ChunEon Park wrote: > I think figuring out the items geometry can be one of the common scenarios in > app side. > > This is already raised before but nobody answered solution properly as far as > I remember. > > My conclusion is, this is a fight between "flexibilty" and "stable" > > For stable, we don't provide that api. > But i don't think this gurantee application stable and developers satisfy. > Maybe this may cause them painful to find out proper solutions and they may > try more dangerous and difficult method in worse case. > > This causes app go around too much. > > And we don't need to make app developers hard to make it. > > > -Regards, Hermet- > > -Original Message- > From: "Tom Hacohen"@samsung.com> > To: "Enlightenment developer > list"@lists.sourceforge.net>; > Cc: > Sent: 2013-09-02 (월) 18:20:35 > Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: > elementary/widget - introduce elm_object_item_object_get(). > > I have to side with Mike here. Both the decision process and the > solution smell badly. Worse than Mike's tuna breakfasts. > > -- > Tom. > > On 02/09/13 09:48, ChunEon Park wrote: >> If they know what they are doing exactly, then it won' t be problem. >> This gives the applications a chance to decorate their appilcation easily. >> >> ---------------- >> -Regards, Hermet- >> >> -Original Message- >> From: "Michael Blumenkrantz"@gmail.com> >> To: "Enlightenment developer >> list"@lists.sourceforge.net>; >> Cc: >> Sent: 2013-09-02 (월) 17:29:41 >> Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: >> elementary/widget - introduce elm_object_item_object_get(). >> >> so wait a minute...everyone fights against this for literally over a year, >> and now it gets in without further discussion because "applications require >> it" seriously? >> >> >> On Mon, Sep 2, 2013 at 9:25 AM, ChunEon Park - Enlightenment Git < >> no-re...@enlightenment.org> wrote: >> >>> hermet pushed a commit to branch master. >>> >>> commit ddc3cf80ce0a50a9161fcb212d3414f5d7b5898c >>> Author: ChunEon Park @hermet.pe.kr> >>> Date: Mon Sep 2 17:19:36 2013 +0900 >>> >>> elementary/widget - introduce elm_object_item_object_get(). >>> >>> We've countered application's requirements multiple times to they have >>> the object handle from the elm_object_item. >>> >>> Now we introduce it for their convenient but they should use it >>> carefully. >>> --- >>>ChangeLog 6 +- >>>NEWS1 + >>>src/lib/elm_main.c 6 ++ >>>src/lib/elm_object_item.h 19 +++ >>>src/lib/elm_removed.h 15 +-- >>>src/lib/elm_widget.c7 +++ >>>src/lib/elm_widget.h1 + >>>7 files changed, 40 insertions(+), 15 deletions(-) >>> >>> diff --git a/ChangeLog b/ChangeLog >>> index 4c59fdc..1695f01 100644 >>> --- a/ChangeLog >>> +++ b/ChangeLog >>> @@ -1578,6 +1578,10 @@ >>> >>>* Gengrid: implement selectraise feature. >>> >>> -2013-08-28 DAniel Juyung Seo (SeoZ) >>> +2013-08-28 Daniel Juyung Seo (SeoZ) >>> >>>* Bg: Add bg reset feature. >>> + >>> +2013-09-02 ChunEon Park (Hermet) >>> + >&
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get().
On Mon, 02 Sep 2013 14:56:31 +0100 Tom Hacohen wrote: > On 02/09/13 14:52, Iván Briano wrote: > > On Mon, Sep 2, 2013 at 9:23 AM, Tom Hacohen wrote: > >> On 02/09/13 13:16, Michael Blumenkrantz wrote: > >>> I think it's too late to get rid of bad API considering the state of elm > >>> at > >>> 1.0 > >> > >> Obviously. I was thinking about 2.0. > >> > >> I have a few widgets on my kill-list. > >> > > > > Yeah, me too. Namely, all but layout. > > Without making any generalizations, it is apparent from the past efforts > of the ex-Profusion team that you guys like the layout widget. :) > > -- > Tom. > > imo we just delete all the widgets and use e widgets -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get().
On 02/09/13 14:52, Iván Briano wrote: > On Mon, Sep 2, 2013 at 9:23 AM, Tom Hacohen wrote: >> On 02/09/13 13:16, Michael Blumenkrantz wrote: >>> I think it's too late to get rid of bad API considering the state of elm at >>> 1.0 >> >> Obviously. I was thinking about 2.0. >> >> I have a few widgets on my kill-list. >> > > Yeah, me too. Namely, all but layout. Without making any generalizations, it is apparent from the past efforts of the ex-Profusion team that you guys like the layout widget. :) -- Tom. -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get().
On Mon, Sep 2, 2013 at 9:23 AM, Tom Hacohen wrote: > On 02/09/13 13:16, Michael Blumenkrantz wrote: >> I think it's too late to get rid of bad API considering the state of elm at >> 1.0 > > Obviously. I was thinking about 2.0. > > I have a few widgets on my kill-list. > Yeah, me too. Namely, all but layout. > -- > Tom. > > > -- > Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! > Discover the easy way to master current and previous Microsoft technologies > and advance your career. Get an incredible 1,500+ hours of step-by-step > tutorial videos with LearnDevNow. Subscribe today and save! > http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get().
On 02/09/13 13:16, Michael Blumenkrantz wrote: > I think it's too late to get rid of bad API considering the state of elm at > 1.0 Obviously. I was thinking about 2.0. I have a few widgets on my kill-list. -- Tom. -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get().
I think it's too late to get rid of bad API considering the state of elm at 1.0 On Mon, Sep 2, 2013 at 1:12 PM, Tom Hacohen wrote: > On 02/09/13 12:01, daniel.za...@samsung.com wrote: > > Sorry for the dumb question but resize callback can't help on that? > > Imo, storing pointers to obsolete objects can be very dangerous. But it > > is just my opinion ;-) > > It's not just your opinion, it's objectively dangerous. > > > Vive Valgrind! Vive la France! > > Remind me again, where does your allegiance lie? > > > I wonder if this will become one of those threads in which everyone > argue against, until there's no one more to argue against, so the thread > dies. After which, we forget about it, and the bad API just stays in > until the next stable version. > > Maybe we need a pre-release new API review as another opportunity for > getting rid of smelly API. > > -- > Tom. > > > -- > Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! > Discover the easy way to master current and previous Microsoft technologies > and advance your career. Get an incredible 1,500+ hours of step-by-step > tutorial videos with LearnDevNow. Subscribe today and save! > http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get().
On 02/09/13 12:01, daniel.za...@samsung.com wrote: > Sorry for the dumb question but resize callback can't help on that? > Imo, storing pointers to obsolete objects can be very dangerous. But it > is just my opinion ;-) It's not just your opinion, it's objectively dangerous. > Vive Valgrind! Vive la France! Remind me again, where does your allegiance lie? I wonder if this will become one of those threads in which everyone argue against, until there's no one more to argue against, so the thread dies. After which, we forget about it, and the bad API just stays in until the next stable version. Maybe we need a pre-release new API review as another opportunity for getting rid of smelly API. -- Tom. -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get().
Actually I want to discuss about this kinds of APIs for long time ago. http://sourceforge.net/mailarchive/message.php?msg_id=31297258 But nobody is interested in this. ;-( This API is dangerous but the root cause was from App. developers. For the genlist/gengrid cases, App can use realized/unrealized callback for checking evas object of the object item. 2013/9/2 ChunEon Park > I think figuring out the items geometry can be one of the common scenarios > in app side. > > This is already raised before but nobody answered solution properly as far > as I remember. > > My conclusion is, this is a fight between "flexibilty" and "stable" > > For stable, we don't provide that api. > But i don't think this gurantee application stable and developers satisfy. > Maybe this may cause them painful to find out proper solutions and they > may try more dangerous and difficult method in worse case. > > This causes app go around too much. > > And we don't need to make app developers hard to make it. > > > -Regards, Hermet- > > -Original Message- > From: "Tom Hacohen" > To: "Enlightenment developer list"< > enlightenment-devel@lists.sourceforge.net>; > Cc: > Sent: 2013-09-02 (월) 18:20:35 > Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: > elementary/widget - introduce elm_object_item_object_get(). > > I have to side with Mike here. Both the decision process and the > solution smell badly. Worse than Mike's tuna breakfasts. > > -- > Tom. > > On 02/09/13 09:48, ChunEon Park wrote: > > If they know what they are doing exactly, then it won' t be problem. > > This gives the applications a chance to decorate their appilcation > easily. > > > > > > -Regards, Hermet- > > > > -Original Message----- > > From: "Michael Blumenkrantz"@gmail.com> > > To: "Enlightenment developer list"@ > lists.sourceforge.net>; > > Cc: > > Sent: 2013-09-02 (월) 17:29:41 > > Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: > elementary/widget - introduce elm_object_item_object_get(). > > > > so wait a minute...everyone fights against this for literally over a > year, > > and now it gets in without further discussion because "applications > require > > it" seriously? > > > > > > On Mon, Sep 2, 2013 at 9:25 AM, ChunEon Park - Enlightenment Git < > > no-re...@enlightenment.org> wrote: > > > >> hermet pushed a commit to branch master. > >> > >> commit ddc3cf80ce0a50a9161fcb212d3414f5d7b5898c > >> Author: ChunEon Park @hermet.pe.kr> > >> Date: Mon Sep 2 17:19:36 2013 +0900 > >> > >> elementary/widget - introduce elm_object_item_object_get(). > >> > >> We've countered application's requirements multiple times to they > have > >> the object handle from the elm_object_item. > >> > >> Now we introduce it for their convenient but they should use it > >> carefully. > >> --- > >> ChangeLog 6 +- > >> NEWS1 + > >> src/lib/elm_main.c 6 ++ > >> src/lib/elm_object_item.h 19 +++ > >> src/lib/elm_removed.h 15 +-- > >> src/lib/elm_widget.c7 +++ > >> src/lib/elm_widget.h1 + > >> 7 files changed, 40 insertions(+), 15 deletions(-) > >> > >> diff --git a/ChangeLog b/ChangeLog > >> index 4c59fdc..1695f01 100644 > >> --- a/ChangeLog > >> +++ b/ChangeLog > >> @@ -1578,6 +1578,10 @@ > >> > >> * Gengrid: implement selectraise feature. > >> > >> -2013-08-28 DAniel Juyung Seo (SeoZ) > >> +2013-08-28 Daniel Juyung Seo (SeoZ) > >> > >> * Bg: Add bg reset feature. > >> + > >> +2013-09-02 ChunEon Park (Hermet) > >> + > >> +* Widget: Introduce elm_object_item_object_get() API. > >> diff --git a/NEWS b/NEWS > >> index c2056f3..c6046bd 100644 > >> --- a/NEWS > >> +++ b/NEWS > >> @@ -85,6 +85,7 @@ Additions: > >> * Add elm_win_focus_highlight_animate_set/get(). > >> * Add selectraise feature to gengrid. > >> * Add bg reset feature. > >> + * Add elm_object_item_object_get(). > >> > >> Improvements: > >> > >> diff --git a/src/lib/elm_main.c b/
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get().
Sorry for the dumb question but resize callback can't help on that? Imo, storing pointers to obsolete objects can be very dangerous. But it is just my opinion ;-) Vive Valgrind! Vive la France! JackDanielZ, alias daniel On 09/02/2013 01:53 PM, ChunEon Park wrote: > I think figuring out the items geometry can be one of the common scenarios in > app side. > > This is already raised before but nobody answered solution properly as far as > I remember. > > My conclusion is, this is a fight between "flexibilty" and "stable" > > For stable, we don't provide that api. > But i don't think this gurantee application stable and developers satisfy. > Maybe this may cause them painful to find out proper solutions and they may > try more dangerous and difficult method in worse case. > > This causes app go around too much. > > And we don't need to make app developers hard to make it. > > > -Regards, Hermet- > > -Original Message- > From: "Tom Hacohen" > To: "Enlightenment developer list"; > Cc: > Sent: 2013-09-02 (월) 18:20:35 > Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: > elementary/widget - introduce elm_object_item_object_get(). > > I have to side with Mike here. Both the decision process and the > solution smell badly. Worse than Mike's tuna breakfasts. > > -- > Tom. > > On 02/09/13 09:48, ChunEon Park wrote: >> If they know what they are doing exactly, then it won' t be problem. >> This gives the applications a chance to decorate their appilcation easily. >> >> >> -Regards, Hermet- >> >> -Original Message- >> From: "Michael Blumenkrantz"@gmail.com> >> To: "Enlightenment developer >> list"@lists.sourceforge.net>; >> Cc: >> Sent: 2013-09-02 (월) 17:29:41 >> Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: >> elementary/widget - introduce elm_object_item_object_get(). >> >> so wait a minute...everyone fights against this for literally over a year, >> and now it gets in without further discussion because "applications require >> it" seriously? >> >> >> On Mon, Sep 2, 2013 at 9:25 AM, ChunEon Park - Enlightenment Git < >> no-re...@enlightenment.org> wrote: >> >>> hermet pushed a commit to branch master. >>> >>> commit ddc3cf80ce0a50a9161fcb212d3414f5d7b5898c >>> Author: ChunEon Park @hermet.pe.kr> >>> Date: Mon Sep 2 17:19:36 2013 +0900 >>> >>> elementary/widget - introduce elm_object_item_object_get(). >>> >>> We've countered application's requirements multiple times to they have >>> the object handle from the elm_object_item. >>> >>> Now we introduce it for their convenient but they should use it >>> carefully. >>> --- >>>ChangeLog 6 +- >>>NEWS1 + >>>src/lib/elm_main.c 6 ++ >>>src/lib/elm_object_item.h 19 +++ >>>src/lib/elm_removed.h 15 +-- >>>src/lib/elm_widget.c7 +++ >>>src/lib/elm_widget.h1 + >>>7 files changed, 40 insertions(+), 15 deletions(-) >>> >>> diff --git a/ChangeLog b/ChangeLog >>> index 4c59fdc..1695f01 100644 >>> --- a/ChangeLog >>> +++ b/ChangeLog >>> @@ -1578,6 +1578,10 @@ >>> >>>* Gengrid: implement selectraise feature. >>> >>> -2013-08-28 DAniel Juyung Seo (SeoZ) >>> +2013-08-28 Daniel Juyung Seo (SeoZ) >>> >>>* Bg: Add bg reset feature. >>> + >>> +2013-09-02 ChunEon Park (Hermet) >>> + >>> +* Widget: Introduce elm_object_item_object_get() API. >>> diff --git a/NEWS b/NEWS >>> index c2056f3..c6046bd 100644 >>> --- a/NEWS >>> +++ b/NEWS >>> @@ -85,6 +85,7 @@ Additions: >>> * Add elm_win_focus_highlight_animate_set/get(). >>> * Add selectraise feature to gengrid. >>> * Add bg reset feature. >>> + * Add elm_object_item_object_get(). >>> >>>Improvements: >>> >>> diff --git a/src/lib/elm_main.c b/src/lib/elm_main.c >>> index 2fa2ea0..9f138b2 100644 >>> --- a/src/lib/elm_main.c >>> +++ b/src/lib/elm_main.c >>> @@ -1859,3 +1859,9 @@ elm_object_item_cursor_engine_only_get(const >>> Elm_O
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get().
I think figuring out the items geometry can be one of the common scenarios in
app side.
This is already raised before but nobody answered solution properly as far as I
remember.
My conclusion is, this is a fight between "flexibilty" and "stable"
For stable, we don't provide that api.
But i don't think this gurantee application stable and developers satisfy.
Maybe this may cause them painful to find out proper solutions and they may try
more dangerous and difficult method in worse case.
This causes app go around too much.
And we don't need to make app developers hard to make it.
-Regards, Hermet-
-Original Message-
From: "Tom Hacohen"
To: "Enlightenment developer list";
Cc:
Sent: 2013-09-02 (월) 18:20:35
Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget
- introduce elm_object_item_object_get().
I have to side with Mike here. Both the decision process and the
solution smell badly. Worse than Mike's tuna breakfasts.
--
Tom.
On 02/09/13 09:48, ChunEon Park wrote:
> If they know what they are doing exactly, then it won' t be problem.
> This gives the applications a chance to decorate their appilcation easily.
>
>
> -Regards, Hermet-
>
> -Original Message-
> From: "Michael Blumenkrantz"@gmail.com>
> To: "Enlightenment developer
> list"@lists.sourceforge.net>;
> Cc:
> Sent: 2013-09-02 (월) 17:29:41
> Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01:
> elementary/widget - introduce elm_object_item_object_get().
>
> so wait a minute...everyone fights against this for literally over a year,
> and now it gets in without further discussion because "applications require
> it" seriously?
>
>
> On Mon, Sep 2, 2013 at 9:25 AM, ChunEon Park - Enlightenment Git <
> no-re...@enlightenment.org> wrote:
>
>> hermet pushed a commit to branch master.
>>
>> commit ddc3cf80ce0a50a9161fcb212d3414f5d7b5898c
>> Author: ChunEon Park @hermet.pe.kr>
>> Date: Mon Sep 2 17:19:36 2013 +0900
>>
>> elementary/widget - introduce elm_object_item_object_get().
>>
>> We've countered application's requirements multiple times to they have
>> the object handle from the elm_object_item.
>>
>> Now we introduce it for their convenient but they should use it
>> carefully.
>> ---
>> ChangeLog 6 +-
>> NEWS1 +
>> src/lib/elm_main.c 6 ++
>> src/lib/elm_object_item.h 19 +++
>> src/lib/elm_removed.h 15 +--
>> src/lib/elm_widget.c7 +++
>> src/lib/elm_widget.h1 +
>> 7 files changed, 40 insertions(+), 15 deletions(-)
>>
>> diff --git a/ChangeLog b/ChangeLog
>> index 4c59fdc..1695f01 100644
>> --- a/ChangeLog
>> +++ b/ChangeLog
>> @@ -1578,6 +1578,10 @@
>>
>> * Gengrid: implement selectraise feature.
>>
>> -2013-08-28 DAniel Juyung Seo (SeoZ)
>> +2013-08-28 Daniel Juyung Seo (SeoZ)
>>
>> * Bg: Add bg reset feature.
>> +
>> +2013-09-02 ChunEon Park (Hermet)
>> +
>> +* Widget: Introduce elm_object_item_object_get() API.
>> diff --git a/NEWS b/NEWS
>> index c2056f3..c6046bd 100644
>> --- a/NEWS
>> +++ b/NEWS
>> @@ -85,6 +85,7 @@ Additions:
>> * Add elm_win_focus_highlight_animate_set/get().
>> * Add selectraise feature to gengrid.
>> * Add bg reset feature.
>> + * Add elm_object_item_object_get().
>>
>> Improvements:
>>
>> diff --git a/src/lib/elm_main.c b/src/lib/elm_main.c
>> index 2fa2ea0..9f138b2 100644
>> --- a/src/lib/elm_main.c
>> +++ b/src/lib/elm_main.c
>> @@ -1859,3 +1859,9 @@ elm_object_item_cursor_engine_only_get(const
>> Elm_Object_Item *it)
>> {
>> return elm_widget_item_cursor_engine_only_get(it);
>> }
>> +
>> +EAPI const Evas_Object *
>> +elm_object_item_object_get(const Elm_Object_Item *it)
>> +{
>> + return _elm_widget_item_object_get((Elm_Widget_Item*)it);
>> +}
>> diff --git a/src/lib/elm_object_item.h b/src/lib/elm_object_item.h
>> index 8a0ccde..f256a63 100644
>> --- a/src/lib/elm_object_item.h
>> +++ b/src/lib/elm_object_item.h
>> @@ -34,6 +34,25 @@ typedef void
>> (*Elm_Object_Item_Signal_Cb)(void *data, Elm_Objec
>> EAPI Evas_Object *elm_object_item_widget_get(const
>> Elm_Object_Item *it);
>>
>> /**
>> + * Get the ob
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get().
I have to side with Mike here. Both the decision process and the
solution smell badly. Worse than Mike's tuna breakfasts.
--
Tom.
On 02/09/13 09:48, ChunEon Park wrote:
> If they know what they are doing exactly, then it won' t be problem.
> This gives the applications a chance to decorate their appilcation easily.
>
>
> -Regards, Hermet-
>
> -Original Message-
> From: "Michael Blumenkrantz"
> To: "Enlightenment developer list";
> Cc:
> Sent: 2013-09-02 (월) 17:29:41
> Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01:
> elementary/widget - introduce elm_object_item_object_get().
>
> so wait a minute...everyone fights against this for literally over a year,
> and now it gets in without further discussion because "applications require
> it" seriously?
>
>
> On Mon, Sep 2, 2013 at 9:25 AM, ChunEon Park - Enlightenment Git <
> no-re...@enlightenment.org> wrote:
>
>> hermet pushed a commit to branch master.
>>
>> commit ddc3cf80ce0a50a9161fcb212d3414f5d7b5898c
>> Author: ChunEon Park @hermet.pe.kr>
>> Date: Mon Sep 2 17:19:36 2013 +0900
>>
>> elementary/widget - introduce elm_object_item_object_get().
>>
>> We've countered application's requirements multiple times to they have
>> the object handle from the elm_object_item.
>>
>> Now we introduce it for their convenient but they should use it
>> carefully.
>> ---
>> ChangeLog 6 +-
>> NEWS1 +
>> src/lib/elm_main.c 6 ++
>> src/lib/elm_object_item.h 19 +++
>> src/lib/elm_removed.h 15 +--
>> src/lib/elm_widget.c7 +++
>> src/lib/elm_widget.h1 +
>> 7 files changed, 40 insertions(+), 15 deletions(-)
>>
>> diff --git a/ChangeLog b/ChangeLog
>> index 4c59fdc..1695f01 100644
>> --- a/ChangeLog
>> +++ b/ChangeLog
>> @@ -1578,6 +1578,10 @@
>>
>> * Gengrid: implement selectraise feature.
>>
>> -2013-08-28 DAniel Juyung Seo (SeoZ)
>> +2013-08-28 Daniel Juyung Seo (SeoZ)
>>
>> * Bg: Add bg reset feature.
>> +
>> +2013-09-02 ChunEon Park (Hermet)
>> +
>> +* Widget: Introduce elm_object_item_object_get() API.
>> diff --git a/NEWS b/NEWS
>> index c2056f3..c6046bd 100644
>> --- a/NEWS
>> +++ b/NEWS
>> @@ -85,6 +85,7 @@ Additions:
>> * Add elm_win_focus_highlight_animate_set/get().
>> * Add selectraise feature to gengrid.
>> * Add bg reset feature.
>> + * Add elm_object_item_object_get().
>>
>> Improvements:
>>
>> diff --git a/src/lib/elm_main.c b/src/lib/elm_main.c
>> index 2fa2ea0..9f138b2 100644
>> --- a/src/lib/elm_main.c
>> +++ b/src/lib/elm_main.c
>> @@ -1859,3 +1859,9 @@ elm_object_item_cursor_engine_only_get(const
>> Elm_Object_Item *it)
>> {
>> return elm_widget_item_cursor_engine_only_get(it);
>> }
>> +
>> +EAPI const Evas_Object *
>> +elm_object_item_object_get(const Elm_Object_Item *it)
>> +{
>> + return _elm_widget_item_object_get((Elm_Widget_Item*)it);
>> +}
>> diff --git a/src/lib/elm_object_item.h b/src/lib/elm_object_item.h
>> index 8a0ccde..f256a63 100644
>> --- a/src/lib/elm_object_item.h
>> +++ b/src/lib/elm_object_item.h
>> @@ -34,6 +34,25 @@ typedef void
>> (*Elm_Object_Item_Signal_Cb)(void *data, Elm_Objec
>> EAPI Evas_Object *elm_object_item_widget_get(const
>> Elm_Object_Item *it);
>>
>> /**
>> + * Get the object item's internal object handle.
>> + *
>> + * @param it The Elementary object item
>> + * @return The Internal object of the object item.
>> + *
>> + * @note This function should only be used if you really need to refer the
>> + * internal object's properties (i.e geometry). Since the object items are
>> + * managed/controlled by the widget, you should not modify the object
>> directly
>> + * nor you should not treat the object without validation.
>> + *
>> + * Some widget items may return @c NULL for this API if the items @p are
>> not
>> + * based on the evas object.
>> + *
>> + * @since 1.8
>> + * @ingroup General
>> + */
>> +EAPI const Evas_Object *elm_object_item_object_get(const
>> Elm_Object_Item *it);
>> +
>> +/**
>>* Set a content of an object item
>>*
>>* @param it The Elementary object it
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get().
If they know what they are doing exactly, then it won' t be problem.
This gives the applications a chance to decorate their appilcation easily.
-Regards, Hermet-
-Original Message-
From: "Michael Blumenkrantz"
To: "Enlightenment developer list";
Cc:
Sent: 2013-09-02 (월) 17:29:41
Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget
- introduce elm_object_item_object_get().
so wait a minute...everyone fights against this for literally over a year,
and now it gets in without further discussion because "applications require
it" seriously?
On Mon, Sep 2, 2013 at 9:25 AM, ChunEon Park - Enlightenment Git <
no-re...@enlightenment.org> wrote:
> hermet pushed a commit to branch master.
>
> commit ddc3cf80ce0a50a9161fcb212d3414f5d7b5898c
> Author: ChunEon Park @hermet.pe.kr>
> Date: Mon Sep 2 17:19:36 2013 +0900
>
> elementary/widget - introduce elm_object_item_object_get().
>
> We've countered application's requirements multiple times to they have
> the object handle from the elm_object_item.
>
> Now we introduce it for their convenient but they should use it
> carefully.
> ---
> ChangeLog 6 +-
> NEWS1 +
> src/lib/elm_main.c 6 ++
> src/lib/elm_object_item.h 19 +++
> src/lib/elm_removed.h 15 +--
> src/lib/elm_widget.c7 +++
> src/lib/elm_widget.h1 +
> 7 files changed, 40 insertions(+), 15 deletions(-)
>
> diff --git a/ChangeLog b/ChangeLog
> index 4c59fdc..1695f01 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1578,6 +1578,10 @@
>
> * Gengrid: implement selectraise feature.
>
> -2013-08-28 DAniel Juyung Seo (SeoZ)
> +2013-08-28 Daniel Juyung Seo (SeoZ)
>
> * Bg: Add bg reset feature.
> +
> +2013-09-02 ChunEon Park (Hermet)
> +
> +* Widget: Introduce elm_object_item_object_get() API.
> diff --git a/NEWS b/NEWS
> index c2056f3..c6046bd 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -85,6 +85,7 @@ Additions:
> * Add elm_win_focus_highlight_animate_set/get().
> * Add selectraise feature to gengrid.
> * Add bg reset feature.
> + * Add elm_object_item_object_get().
>
> Improvements:
>
> diff --git a/src/lib/elm_main.c b/src/lib/elm_main.c
> index 2fa2ea0..9f138b2 100644
> --- a/src/lib/elm_main.c
> +++ b/src/lib/elm_main.c
> @@ -1859,3 +1859,9 @@ elm_object_item_cursor_engine_only_get(const
> Elm_Object_Item *it)
> {
> return elm_widget_item_cursor_engine_only_get(it);
> }
> +
> +EAPI const Evas_Object *
> +elm_object_item_object_get(const Elm_Object_Item *it)
> +{
> + return _elm_widget_item_object_get((Elm_Widget_Item*)it);
> +}
> diff --git a/src/lib/elm_object_item.h b/src/lib/elm_object_item.h
> index 8a0ccde..f256a63 100644
> --- a/src/lib/elm_object_item.h
> +++ b/src/lib/elm_object_item.h
> @@ -34,6 +34,25 @@ typedef void
> (*Elm_Object_Item_Signal_Cb)(void *data, Elm_Objec
> EAPI Evas_Object *elm_object_item_widget_get(const
> Elm_Object_Item *it);
>
> /**
> + * Get the object item's internal object handle.
> + *
> + * @param it The Elementary object item
> + * @return The Internal object of the object item.
> + *
> + * @note This function should only be used if you really need to refer the
> + * internal object's properties (i.e geometry). Since the object items are
> + * managed/controlled by the widget, you should not modify the object
> directly
> + * nor you should not treat the object without validation.
> + *
> + * Some widget items may return @c NULL for this API if the items @p are
> not
> + * based on the evas object.
> + *
> + * @since 1.8
> + * @ingroup General
> + */
> +EAPI const Evas_Object *elm_object_item_object_get(const
> Elm_Object_Item *it);
> +
> +/**
> * Set a content of an object item
> *
> * @param it The Elementary object item
> diff --git a/src/lib/elm_removed.h b/src/lib/elm_removed.h
> index 416726a..59b982f 100644
> --- a/src/lib/elm_removed.h
> +++ b/src/lib/elm_removed.h
> @@ -490,19 +490,6 @@ EINA_DEPRECATED EAPI Elm_Gen_Item
> *elm_gen_item_prev_get(const Elm_Gen_Item *it)
> EINA_DEPRECATED EAPI Evas_Object *elm_gen_item_widget_get(const
> Elm_Gen_Item *it);
>
> /**
> - * Get the widget object's handle which contains a given item
> - *
> - * @param it The Elementary object item
> - * @return The widget object
> - *
> - * @note This returns the widget object itself that an item belongs to.
> - * @note Every elm_object_item supports this API
> - * @deprecated Use
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary/widget - introduce elm_object_item_object_get().
so wait a minute...everyone fights against this for literally over a year,
and now it gets in without further discussion because "applications require
it" seriously?
On Mon, Sep 2, 2013 at 9:25 AM, ChunEon Park - Enlightenment Git <
no-re...@enlightenment.org> wrote:
> hermet pushed a commit to branch master.
>
> commit ddc3cf80ce0a50a9161fcb212d3414f5d7b5898c
> Author: ChunEon Park
> Date: Mon Sep 2 17:19:36 2013 +0900
>
> elementary/widget - introduce elm_object_item_object_get().
>
> We've countered application's requirements multiple times to they have
> the object handle from the elm_object_item.
>
> Now we introduce it for their convenient but they should use it
> carefully.
> ---
> ChangeLog | 6 +-
> NEWS | 1 +
> src/lib/elm_main.c| 6 ++
> src/lib/elm_object_item.h | 19 +++
> src/lib/elm_removed.h | 15 +--
> src/lib/elm_widget.c | 7 +++
> src/lib/elm_widget.h | 1 +
> 7 files changed, 40 insertions(+), 15 deletions(-)
>
> diff --git a/ChangeLog b/ChangeLog
> index 4c59fdc..1695f01 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1578,6 +1578,10 @@
>
> * Gengrid: implement selectraise feature.
>
> -2013-08-28 DAniel Juyung Seo (SeoZ)
> +2013-08-28 Daniel Juyung Seo (SeoZ)
>
> * Bg: Add bg reset feature.
> +
> +2013-09-02 ChunEon Park (Hermet)
> +
> +* Widget: Introduce elm_object_item_object_get() API.
> diff --git a/NEWS b/NEWS
> index c2056f3..c6046bd 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -85,6 +85,7 @@ Additions:
> * Add elm_win_focus_highlight_animate_set/get().
> * Add selectraise feature to gengrid.
> * Add bg reset feature.
> + * Add elm_object_item_object_get().
>
> Improvements:
>
> diff --git a/src/lib/elm_main.c b/src/lib/elm_main.c
> index 2fa2ea0..9f138b2 100644
> --- a/src/lib/elm_main.c
> +++ b/src/lib/elm_main.c
> @@ -1859,3 +1859,9 @@ elm_object_item_cursor_engine_only_get(const
> Elm_Object_Item *it)
> {
> return elm_widget_item_cursor_engine_only_get(it);
> }
> +
> +EAPI const Evas_Object *
> +elm_object_item_object_get(const Elm_Object_Item *it)
> +{
> + return _elm_widget_item_object_get((Elm_Widget_Item*)it);
> +}
> diff --git a/src/lib/elm_object_item.h b/src/lib/elm_object_item.h
> index 8a0ccde..f256a63 100644
> --- a/src/lib/elm_object_item.h
> +++ b/src/lib/elm_object_item.h
> @@ -34,6 +34,25 @@ typedef void
> (*Elm_Object_Item_Signal_Cb)(void *data, Elm_Objec
> EAPI Evas_Object *elm_object_item_widget_get(const
> Elm_Object_Item *it);
>
> /**
> + * Get the object item's internal object handle.
> + *
> + * @param it The Elementary object item
> + * @return The Internal object of the object item.
> + *
> + * @note This function should only be used if you really need to refer the
> + * internal object's properties (i.e geometry). Since the object items are
> + * managed/controlled by the widget, you should not modify the object
> directly
> + * nor you should not treat the object without validation.
> + *
> + * Some widget items may return @c NULL for this API if the items @p are
> not
> + * based on the evas object.
> + *
> + * @since 1.8
> + * @ingroup General
> + */
> +EAPI const Evas_Object *elm_object_item_object_get(const
> Elm_Object_Item *it);
> +
> +/**
> * Set a content of an object item
> *
> * @param it The Elementary object item
> diff --git a/src/lib/elm_removed.h b/src/lib/elm_removed.h
> index 416726a..59b982f 100644
> --- a/src/lib/elm_removed.h
> +++ b/src/lib/elm_removed.h
> @@ -490,19 +490,6 @@ EINA_DEPRECATED EAPI Elm_Gen_Item
> *elm_gen_item_prev_get(const Elm_Gen_Item *it)
> EINA_DEPRECATED EAPI Evas_Object *elm_gen_item_widget_get(const
> Elm_Gen_Item *it);
>
> /**
> - * Get the widget object's handle which contains a given item
> - *
> - * @param it The Elementary object item
> - * @return The widget object
> - *
> - * @note This returns the widget object itself that an item belongs to.
> - * @note Every elm_object_item supports this API
> - * @deprecated Use elm_object_item_widget_get() instead
> - * @ingroup General
> - */
> -EINA_DEPRECATED EAPI Evas_Object
> *elm_object_item_object_get(const Elm_Object_Item *it);
> -
> -/**
> * Set the text to show in the anchorblock
> *
> * Sets the text of the anchorblock to @p text. This text can include
> markup
> @@ -3303,7 +3290,7 @@ EINA_DEPRECATED EAPI void
> elm_slideshow_show(Elm_Object_Item *i
> *
> * This returns the toolbar object itself that an item belongs to.
> *
> - * @deprecated use elm_object_item_object_get() instead.
> + * @deprecated use elm_object_item_widget_get() instead.
> */
> EINA_DEPRECATED EAPI Evas_Object *elm_toolbar_item_toolbar_get(const
> Elm_Object_Item *it);
>
> diff --git a/src/lib/elm_widget.c b/src/lib/elm_widget.c
> index 5f1aae8..9bcec72 100644
> --- a/src/lib/elm_widget.c
> +++ b/src/lib/elm_widget.c
> @@ -5771,6 +5771,13 @@ _elm_widget_
