Re: [E-devel] [PATCH 2/2] Zero is a valid fd value
On Mon, 2011-01-24 at 08:49 +0100, Vincent Torri wrote: > imho, B) with a file in it saying at which revision it has been deleted Or better yet, start writing sane *descriptive* and *searchable* log messages in svn and maybe even use tags like [REMOVED-DEPRECATED] or stuff like that and then it will be easy to find the wanted revision. We need to start doing that anyway, so that's a good time to start :) -- Tom. -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH 2/2] Zero is a valid fd value
On Mon, 24 Jan 2011 10:16:37 + Tom Hacohen wrote: > On Mon, 2011-01-24 at 08:49 +0100, Vincent Torri wrote: > > imho, B) with a file in it saying at which revision it has been deleted > > Or better yet, start writing sane *descriptive* and *searchable* log > messages in svn balderdash. -- Mike Blumenkrantz Zentific: NULL pointer dereferences now 50% off! -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [PATCH] Handle ecore signals with a pipe
The way ecore handles signals is racy.
The attached patch uses a pipe to avoid races between signals and select/poll().
A fix for before or after 1.0...?
thanks,
Mike
btw. the SIGRTMIN is totally borken and probably should be deleted
>From 1a21c643e08e325b2773e53ecde27bcf46ca5148 Mon Sep 17 00:00:00 2001
From: Mike McCormack
Date: Mon, 24 Jan 2011 20:36:20 +0900
Subject: [PATCH] Handle ecore signals with a pipe
This removes a race condition in the main loop where
a signal could come after the signal check, and before
entering the select loop, possibly resulting in a hang.
In practice, this hang wouldn't be seen due to other activity
in the main loop.
---
trunk/ecore/src/lib/ecore/ecore_signal.c | 269 --
1 files changed, 110 insertions(+), 159 deletions(-)
diff --git a/trunk/ecore/src/lib/ecore/ecore_signal.c b/trunk/ecore/src/lib/ecore/ecore_signal.c
index f072c06..0a0c038 100644
--- a/trunk/ecore/src/lib/ecore/ecore_signal.c
+++ b/trunk/ecore/src/lib/ecore/ecore_signal.c
@@ -17,20 +17,13 @@
/* valgrind in some versions/setups uses SIGRT's... hmmm */
#undef SIGRTMIN
+static int _ecore_signal_pipe[2];
+
typedef void (*Signal_Handler)(int sig, siginfo_t *si, void *foo);
static void _ecore_signal_callback_set(int sig, Signal_Handler func);
static void _ecore_signal_callback_ignore(int sig, siginfo_t *si, void *foo);
-static void _ecore_signal_callback_sigchld(int sig, siginfo_t *si, void *foo);
-static void _ecore_signal_callback_sigusr1(int sig, siginfo_t *si, void *foo);
-static void _ecore_signal_callback_sigusr2(int sig, siginfo_t *si, void *foo);
-static void _ecore_signal_callback_sighup(int sig, siginfo_t *si, void *foo);
-static void _ecore_signal_callback_sigquit(int sig, siginfo_t *si, void *foo);
-static void _ecore_signal_callback_sigint(int sig, siginfo_t *si, void *foo);
-static void _ecore_signal_callback_sigterm(int sig, siginfo_t *si, void *foo);
-#ifdef SIGPWR
-static void _ecore_signal_callback_sigpwr(int sig, siginfo_t *si, void *foo);
-#endif
+static void _ecore_signal_callback_write_pipe(int sig, siginfo_t *si, void *foo);
#ifdef SIGRTMIN
static void _ecore_signal_callback_sigrt(int sig, siginfo_t *si, void *foo);
@@ -99,6 +92,9 @@ _ecore_signal_shutdown(void)
sigterm_count = 0;
sig_count = 0;
+ close(_ecore_signal_pipe[0]);
+ close(_ecore_signal_pipe[1]);
+
#ifdef SIGRTMIN
for (i = 0; i < num; i++)
{
@@ -123,24 +119,110 @@ _ecore_signal_shutdown(void)
#endif
}
+Eina_Bool
+_ecore_signal_pipe_read(void *data, Ecore_Fd_Handler *fdh)
+{
+ siginfo_t si;
+ int sig = -1;
+ int r;
+ int n;
+
+ r = read(_ecore_signal_pipe[0], &si, sizeof si);
+ if (r != sizeof si)
+ {
+WRN("failed to read signal\n");
+return;
+ }
+
+ sig = si.si_signo;
+
+ switch (sig)
+ {
+ case SIGCHLD:
+ n = sigchld_count++;
+ sig_count++;
+ if (n < MAXSIGQ)
+ sigchld_info[n] = si;
+ break;
+ case SIGUSR1:
+ n = sigusr1_count++;
+ sig_count++;
+ if (n < MAXSIGQ)
+ sigusr1_info[n] = si;
+ break;
+ case SIGUSR2:
+ n = sigusr2_count++;
+ sig_count++;
+ if (n < MAXSIGQ)
+ sigusr2_info[n] = si;
+ break;
+ case SIGHUP:
+ n = sighup_count++;
+ sig_count++;
+ if (n < MAXSIGQ)
+ sighup_info[n] = si;
+ break;
+ case SIGQUIT:
+ n = sigquit_count++;
+ sig_count++;
+ if (n < MAXSIGQ)
+ sigquit_info[n] = si;
+ break;
+ case SIGINT:
+ n = sigint_count++;
+ sig_count++;
+ if (n < MAXSIGQ)
+ sigint_info[n] = si;
+ break;
+ case SIGTERM:
+ n = sigterm_count++;
+ sig_count++;
+ if (n < MAXSIGQ)
+ sigterm_info[n] = si;
+ break;
+#ifdef SIGPWR
+ case SIGPWR:
+ n = sigpwr_count++;
+ sig_count++;
+ if (n < MAXSIGQ)
+ sigpwr_info[n] = si;
+ break;
+#endif
+ default:
+ ERR("unknown signal %d\n", sig);
+ break;
+ }
+}
+
void
_ecore_signal_init(void)
{
#ifdef SIGRTMIN
int i, num = SIGRTMAX - SIGRTMIN;
#endif
+ int pfd[2];
+ int r;
+
+ r = pipe(_ecore_signal_pipe);
+ if (r < 0)
+ {
+ ERR("pipe failed (%d)\n", r);
+ exit(1);
+ }
+ ecore_main_fd_handler_add(_ecore_signal_pipe[0], ECORE_FD_READ,
+ &_ecore_signal_pipe_read, NULL, NULL, NULL);
_ecore_signal_callback_set(SIGPIPE, _ecore_signal_callback_ignore);
_ecore_signal_callback_set(SIGALRM, _ecore_signal_callback_ignore);
- _ecore_signal_callback_set(SIGCHLD, _ecore_signal_callback_sigchld);
- _ecore_signal_callback_set(SIGUSR1, _ecore_signal_callback_sigusr1);
- _ecore_signal_callback_set(SIGUSR2, _ecore_signal_callback_sigusr2);
- _ecore_signal_callback_set(SIGHUP, _ecore_signal_callback_sighup);
-
Re: [E-devel] [PATCH] Handle ecore signals with a pipe
On Mon, 24 Jan 2011 20:56:25 +0900 Mike McCormack wrote: > > The way ecore handles signals is racy. > The attached patch uses a pipe to avoid races between signals and > select/poll(). > > A fix for before or after 1.0...? > > thanks, > > Mike > > > btw. the SIGRTMIN is totally borken and probably should be deleted I'll look a bit more carefully later, but it looks like some great cleanup work that would be nice to see in 1.0 since the current code is a total mess. -- Mike Blumenkrantz Zentific: NULL pointer dereferences now 50% off! -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] Handle ecore signals with a pipe
On Mon, 2011-01-24 at 06:58 -0500, Mike Blumenkrantz wrote: > I'll look a bit more carefully later, but it looks like some great cleanup > work > that would be nice to see in 1.0 since the current code is a total mess. > We were supposed to release yesterday, I don't think it's a good time for redesigning stuff. Although I truly trust mike (not you!) and the quality of his work, I think it's a case of too many changes too close to release, but hey, I don't even believe in big releases, so.. :P -- Tom. -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Startup applications issues
On 01/23/2011 07:36 PM, Jeff Hoogland wrote: > So after talks about my issues with start up applications with a fresh user > creation in IRC last night, I am certain it is an efreet cache issue. I > removed LXDM and used GDM as the login manager and the startup applications > still fail to load without the cache being there. I guess it considers no cache as not found :) I'll take a look. Sebastian -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Failed to add poll on fd 18 (errno = 17)!
Am Sun, 19 Dec 2010 10:07:52 +0100 schrieb Andreas Volz: > > so the question is... is it really adding the same fd twice - and if > > so.. why was it doing that? that "userspace" code needs fixing if it > > did. > > May be an hint. I also noticed that the function was called twice > while stepping through. First time it works and second time it > failed. Now when you say these it sounds logic. I've to check later > what's the problem here... Only an information to complete this thread. It was an problem in Dbus-C++ ecore binding (also developed by myself). I fixed the problem there and now all works great. regards Andreas -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] e_dbus and places module patches
2011/1/19 Mike Blumenkrantz : > On Wed, 19 Jan 2011 11:57:21 -0500 > Nikolas Arend wrote: > >> Hello, >> >> Attached please find two small patches for e_dbus and the places module. >> They fix segfaults for me (triggered in e_hal_property_bool_get()) that >> I was experiencing when resuming my laptop after suspend. It'd be great >> if you could review and apply them if considered adequate. >> >> Thanks, Nick. > I have applied the e_hal patch. The patch for places can wait for the places > maintainer since he may have some local changes to commit. in. Thanks :) > > -- > Mike Blumenkrantz > Zentific: NULL pointer dereferences now 50% off! > > -- > Protect Your Site and Customers from Malware Attacks > Learn about various malware tactics and how to avoid them. Understand > malware threats, the impact they can have on your business, and how you > can protect your company and customers by using code signing. > http://p.sf.net/sfu/oracle-sfdevnl > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] Handle ecore signals with a pipe
On Mon, 24 Jan 2011 21:10:30 +0900 Tom Hacohen wrote: > On Mon, 2011-01-24 at 06:58 -0500, Mike Blumenkrantz wrote: > > I'll look a bit more carefully later, but it looks like some great cleanup > > work that would be nice to see in 1.0 since the current code is a total > > mess. > > > > We were supposed to release yesterday, I don't think it's a good time > for redesigning stuff. Although I truly trust mike (not you!) and the > quality of his work, I think it's a case of too many changes too close > to release, but hey, I don't even believe in big releases, so.. :P > > -- > Tom. > Isn't "just before release" the best time to be fixing stuff that is messy? -- Mike Blumenkrantz Zentific: NULL pointer dereferences now 50% off! -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] Handle ecore signals with a pipe
On Monday, 24 January 2011, at 14:56:52 (-0500), Mike Blumenkrantz wrote: > Isn't "just before release" the best time to be fixing stuff that is messy? No. Just before release isn't the best time to fix anything. It's an appropriate time to fix critical bugs, but it's not even an appropriate time to fix "messy," let alone the best time. Michael -- Michael Jennings (a.k.a. KainX) http://www.kainx.org/ Linux Server/Cluster Admin, LBL.gov Author, Eterm (www.eterm.org) --- "I disapprove of what you say, but I will defend to the death your right to say it."-- Voltaire -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Startup applications issues
On 01/24/2011 04:57 PM, Sebastian Dransfeld wrote: > On 01/23/2011 07:36 PM, Jeff Hoogland wrote: >> So after talks about my issues with start up applications with a fresh user >> creation in IRC last night, I am certain it is an efreet cache issue. I >> removed LXDM and used GDM as the login manager and the startup applications >> still fail to load without the cache being there. > > I guess it considers no cache as not found :) > > I'll take a look. > > Sebastian Well, problem is simple. In the startup file files are added as filenames without full path. This requires you to look up files in xdg preferred order. This is done during cache build. So it is not possible to do startup without the cache. The question then is, should we wait for cache to be built before doing startup, or execute startup files after cache has been built (which could be seconds after the desktop is shown). Sebastian -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Startup applications issues
On 01/24/2011 05:46 PM, Sebastian Dransfeld wrote: > On 01/24/2011 04:57 PM, Sebastian Dransfeld wrote: >> On 01/23/2011 07:36 PM, Jeff Hoogland wrote: >>> So after talks about my issues with start up applications with a fresh user >>> creation in IRC last night, I am certain it is an efreet cache issue. I >>> removed LXDM and used GDM as the login manager and the startup applications >>> still fail to load without the cache being there. >> >> I guess it considers no cache as not found :) >> >> I'll take a look. >> >> Sebastian > > Well, problem is simple. In the startup file files are added as > filenames without full path. This requires you to look up files in xdg > preferred order. This is done during cache build. So it is not possible > to do startup without the cache. > So if they get added with the full patch to the desktop file, then if the cache does not exist, it won't be a problem ? > The question then is, should we wait for cache to be built before doing > startup, or execute startup files after cache has been built (which > could be seconds after the desktop is shown). > > Sebastian > I would think that E startup apps, could be delayed until cache is built ... else we need to get the cache build started earlier in the process. dh -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Startup applications issues
On 01/24/2011 11:53 PM, Christopher Michael wrote: > On 01/24/2011 05:46 PM, Sebastian Dransfeld wrote: >> On 01/24/2011 04:57 PM, Sebastian Dransfeld wrote: >>> On 01/23/2011 07:36 PM, Jeff Hoogland wrote: So after talks about my issues with start up applications with a fresh user creation in IRC last night, I am certain it is an efreet cache issue. I removed LXDM and used GDM as the login manager and the startup applications still fail to load without the cache being there. >>> >>> I guess it considers no cache as not found :) >>> >>> I'll take a look. >>> >>> Sebastian >> >> Well, problem is simple. In the startup file files are added as >> filenames without full path. This requires you to look up files in xdg >> preferred order. This is done during cache build. So it is not possible >> to do startup without the cache. >> > So if they get added with the full patch to the desktop file, then if > the cache does not exist, it won't be a problem ? No, then you do a direct lookup on the filename, and if the file exists but isn't in the cache, it will be read from file. > >> The question then is, should we wait for cache to be built before doing >> startup, or execute startup files after cache has been built (which >> could be seconds after the desktop is shown). >> >> Sebastian >> > > I would think that E startup apps, could be delayed until cache is built > ... else we need to get the cache build started earlier in the process. The first cache build can be slow, so a wait is probably needed anyway. Sebastian -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch] patch for elm_main.c (about elm_all_flush func)
Hello, Anybody can review this patch? It looks like Woohyun is right. Below 3 APIs has nothing to do with _elm_win_list. And at least if _elm_win_list is NULL, below 3 APIs are not called. ejde_file_cache_flush(); edje_collection_cache_flush(); eet_clearcache(); Thank you. Daniel Juyung Seo (SeoZ) On Fri, Jan 21, 2011 at 6:11 PM, David Seikel wrote: > On Fri, 21 Jan 2011 17:56:50 +0900 Tom Hacohen > wrote: > >> On Fri, 2011-01-21 at 18:51 +1000, David Seikel wrote: >> > On Fri, 21 Jan 2011 17:46:58 +0900 Tom Hacohen >> > wrote: >> > >> > > Nice tip: >> > > Just modify the settings for your mailing list account so it'll >> > > send you a copy of your own emails, so you'll get them in your >> > > inbox when they get to the mailing list. >> > >> > Unless you use gmail, they have a "feature" that filters out your >> > own emails, even if sent back from mailing lists. I use a work >> > around which involves two accounts on mailing lists, one for >> > writing, one for reading. >> >> Nice hack around it: >> Add another filter rule: "not from your.em...@gmail.com~. > > Last time I checked the "feature" that removed your own emails > (actually, sends them to the archive and bypasses sending them to you) > got to the emails BEFORE the filters. So at the time that trick did > not work. > >> But I bet they have a decent way of doing it... Anyhow, he isn't using >> gmail. :) > > Well, several bug reports from several people later and google where > still adamant that it's a feature, not a bug. I was just mentioning it > for people that do use gmail, I know he's using the company email > system. > > Who knows, maybe there is a more elegant way around it now, I do know > the "feature" still exists though, after a lot of years. Elegant as in > "hey gmail idiots, just let me turn the damned 'feature' off". > >> (Damn, I hate top-posting, but it's so much easier...) > > There, fixed for you. B-) > > -- > Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! > Finally, a world-class log management solution at an even better price-free! > Download using promo code Free_Logger_4_Dev2Dev. Offer expires > February 28th, so secure your free ArcSight Logger TODAY! > http://p.sf.net/sfu/arcsight-sfd2d > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] Handle ecore signals with a pipe
On Mon, 2011-01-24 at 14:56 -0500, Mike Blumenkrantz wrote: > Isn't "just before release" the best time to be fixing stuff that is messy? > Not in my pov, so close to release we should try to avoid doing big changes because big changes sometimes (usually) bring bugs in. But what a "big change" is, is subjective so maybe someone else has a better interpretation of the term that considers this one as a "small change" :) -- Tom. -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] Handle ecore signals with a pipe
On Mon, Jan 24, 2011 at 9:56 AM, Mike McCormack wrote: > > The way ecore handles signals is racy. > The attached patch uses a pipe to avoid races between signals and > select/poll(). Couldn't we use signalfd instead? It's the most clean way I know. > > A fix for before or after 1.0...? After, for sure. thanks, Mike Lucas De Marchi -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [Patch] genlist item cache exception handling patch
Hello, I added "no cached item" handling. In some case, items should not be cached and should not use caches. For example, if there was a state change in item style, it should not be cached because it remembers the state changes. And if we use elm_genlist_item_item_class_update() API, item should not be cached as well. It needs to be a fresh item style without remembering the state changes. Anybody please review this and apply it to upstream code. Ps. Btw, there are three pending genlist patches on mailing list other than this email. 1. Jan 21 (Sohyun Kim) : [E-devel] [Patch] elm_genlist patch regarding inlist 2. Jan 21 (Daniel Juyung Seo) : [E-devel] [Patch] Removed dead code in elm_genlist.c 3. Jan 18 (Daniel Juyung Seo) : [E-devel] [Patch] elm_genlist patch for group index handling and bug fix Please review them as well. They are small patches :) Thanks. Daniel Juyung Seo (SeoZ) elm_genlist.c.patch Description: Binary data -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: jeffdameth trunk/E-MODULES-EXTRA/everything-websearch/src
On Mon, 24 Jan 2011 08:57:41 -0800 "Enlightenment SVN" wrote: > Log: > disable youtube download actions, dont work anymore > > > Author: jeffdameth > Date: 2011-01-24 08:57:41 -0800 (Mon, 24 Jan 2011) > New Revision: 56288 > Trac: http://trac.enlightenment.org/e/changeset/56288 That's chasing a moving target. Many people try to pull youtube videos out of the advert infested soup they are meant to live in. Youtube are well aware of this and keep trying to make that hard or impossible. It's the adverts that are their revenue stream after all. signature.asc Description: PGP signature -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Clicked signal in elm_entry
Hey all, MJ (in cc) has brought to my attention that the elm_entry "clicked" signal (and actually all of the rest as well) is connected to the text part of the edje object entry, which is not always the same size as the entry's evas_object. For example, if an entry is of size 200x200 and it's text is 50x50, all the white space around won't be clickable. To me both make sense - less in the current case, but more if someone decides to change the elm entry's theme to include a nice heavy frame or even to show the scroller bars. I think we should probably add an event layer to the theme of elm_entry and register signals to that event layer so the "active part" will be set by the theme. This will let the theme designer more flexibility on how he wants to redesign the theme and will also allow more complex themes. Any objections? -- Tom. -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] Handle ecore signals with a pipe
On 01/25/2011 12:10 PM, Lucas De Marchi wrote: > On Mon, Jan 24, 2011 at 9:56 AM, Mike McCormack > wrote: >> >> The way ecore handles signals is racy. >> The attached patch uses a pipe to avoid races between signals and >> select/poll(). > > Couldn't we use signalfd instead? It's the most clean way I know. Clean, but not portable, as I understand. I could add it with a fallback to the pipe method. There's actually quite a bit of cleaning up to do for ecore signal handling. I'm not even sure that it's a good idea for a library (or framework) to be messing with signal handlers without an explicit request from the application using it. >> A fix for before or after 1.0...? > > After, for sure. I agree. Was testing the general consensus. Will queue this and work on cleaning up the rest of it. thanks, Mike -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] GSOC 2011
it's that time of year again. Google has just announced their Summer of code for 2011... We should really try to participate this year! the announcement is herel Google has just announced GSoC2011. http://google-opensource.blogspot.com/2011/01/google-summer-of-code-announced-at-lca.html The timeline is here: http://www.google-melange.com/document/show/gsoc_program/google/gsoc2011/timeline Lets hear your thoughts... Thanks, Ian Caldwell -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [Patch] patch for elm_module
Hello. Mr. Wonguk Jeong made a patch for elm_module. This patch is for changing the timing of module loading. For now, module loading is done in elm_init Thus, modules are always loaded, even if the application does not use them. So this patch deferred the timing of module loading to "_elm_module_find_as". Can anyone check about this ? Thanks. elm_module.c.patch Description: Binary data -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch] patch for elm_module
Dear WooHyun, I haven't really reviewed the patch because I really don't know enough about elementary's modules. But I did manage to spot a couple of issues that mean that the patch can't be accepted: 1. line 15 of the patch: "if (_elm_module_load(m) == EINA_FALSE)" should be "if (!_elm_module_load(m))". 2. there's wrong indentation in all of _elm_module_load As I said, I haven't even looked at the content, just a went over the styling, which as I said, does not comply. Please fix those and send a new patch. For more info about the e coding style, please check this page: http://trac.enlightenment.org/e/wiki/ECoding Thanks a lot, Tom. On Tue, 2011-01-25 at 14:46 +0900, WooHyun Jung wrote: > Hello. > > Mr. Wonguk Jeong made a patch for elm_module. > > This patch is for changing the timing of module loading. > > > > For now, module loading is done in elm_init > > Thus, modules are always loaded, even if the application does not use them. > > > > So this patch deferred the timing of module loading to > "_elm_module_find_as". > > > > Can anyone check about this ? > > Thanks. > > -- > Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! > Finally, a world-class log management solution at an even better price-free! > Download using promo code Free_Logger_4_Dev2Dev. Offer expires > February 28th, so secure your free ArcSight Logger TODAY! > http://p.sf.net/sfu/arcsight-sfd2d > ___ enlightenment-devel mailing > list enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
