Re: [Evolution-hackers] Evolution crashes while creating appointment from Mail
Samarjit, You should report this in bugzilla. Thanks. //Johnny On Mon, Apr 8, 2013 at 5:52 AM, samarjit Adhikari samarjit.adhik...@gmail.com wrote: Hi All [My Evolution configuration] Version: 3.6.4+ Plugin: evolution-mapi [steps to reproduce] 1. Select any mail from inbox. 2. Right Click on a mail. A action menu list will appear. 3. Choose Create--Create an Appointment 4. it will ask for Select destination 5. Select Personal on this computer followed by OK 6. A Appointment window will open. Just cancel it by closing it. 7. It will ask Would you like to save changes to this appointment? 8. Select Discard Changes 9. Now left click on any places of evolution. It will crash Attaching gdb what is being found === Breakpoint 1, e_mail_reader_check_state (reader=reader@entry=0x7f22a8d31340) at e-mail-reader.c:4129 4129e-mail-reader.c: No such file or directory. (gdb) c Continuing. Breakpoint 2, camel_folder_get_parent_store (folder=0x7f22a8f93730) at camel-folder.c:2113 2113camel-folder.c: No such file or directory. (gdb) p folder $1 = (CamelFolder *) 0x7f22a8f93730 (gdb) p *folder $2 = {parent = {parent = {g_type_instance = {g_class = 0x7f22a8f93580}, ref_count = 0, qdata = 0x0}, priv = 0x7f22a8f937d0}, priv = 0x7f22a8f937e0, summary = 0x0, folder_flags = CAMEL_FOLDER_HAS_SUMMARY_CAPABILITY, permanent_flags = 159, later = {0x0, 0x0, 0x0, 0x0}} (gdb) b e-mail-reader.c:4172 Breakpoint 3 at 0x7f22729ff41c: file e-mail-reader.c, line 4172. (gdb) c Continuing. Breakpoint 2, camel_folder_get_parent_store (folder=0x7f22a8f93730) at camel-folder.c:2112 2112in camel-folder.c *(gdb) p store $3 = (GtkListStore *) 0x0 *(gdb) p *folder $4 = {parent = {parent = {g_type_instance = {g_class = 0x7f22a8f93580}, ref_count = 0, qdata = 0x0}, priv = 0x7f22a8f937d0}, priv = 0x7f22a8f937e0, summary = 0x0, folder_flags = CAMEL_FOLDER_HAS_SUMMARY_CAPABILITY, permanent_flags = 159, later = {0x0, 0x0, 0x0, 0x0}} (gdb) p *folder-priv $5 = {lock = {mutex = {mutex = 0x7f224c178940, unused = {__data = {__lock = 0, __count = 0, __owner = 0, __nusers = 0, __kind = 0, __spins = 0, __list = {__prev = 0x0, __next = 0x0}}, __size = '\000' repeats 39 times, __align = 0}}, depth = 0, unused = { owner = 0, dummy = 0}}, change_lock = {mutex = 0x0, unused = {__data = {__lock = 0, __count = 0, __owner = 0, __nusers = 0, __kind = 0, __spins = 0, __list = {__prev = 0x0, __next = 0x0}}, __size = '\000' repeats 39 times, __align = 0}}, frozen = 0, changed_frozen = 0x7f22840212f0, skip_folder_lock = 0, pending_changes = 0x0, parent_store = 0x0, full_name = 0x7f224c005f90 \300c, display_name = 0x7f224c0013f0 \260\020, description = 0x7f224c006380 \240]} (gdb) p *account_store No symbol account_store in current context. === File bt_evolution_8651_04082013.txt contains stack trace just before step 9. File createAppointmentStackTrace contains traces when crash happens at step 9 With regards, Samarjit ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers -- [ http://about.me/johnnyjacob ] ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] Code typo in current evolution-mapi git master head
On Thu, 2009-12-10 at 12:41 -0500, Paul Smith wrote: Hi guys; please apply this patch to fix a build error. Thanks! Patch committed to master. -- [johnnyjacob.org] May you share freely, never taking more than you give signature.asc Description: This is a digitally signed message part ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] MAPI support not even close... ?!?! Can I help?
On Mon, 2009-12-07 at 14:39 -0500, Paul Smith wrote: On Mon, 2009-12-07 at 14:25 -0500, Paul Smith wrote: I tried this and it's a disaster. Every single attempt to connect to the Exchange 2007 server causes Evolution to dump core. I had to start it with --offline to keep it up long enough that I could delete my Exchange MAPI account. I vaguely remembered that you have to use the Exchange server IP address, not hostname (lame!!) so I tried that and I did get it to connect without crashing this time (uber-lame!!) This crash seems to be a issue with the specific distro builds. In suse, this was solved with compiler flags such as -Bsymbolic (nasty!) Since we are using samba4 for libmapi and most of the distros ship samba3, there were namespace collision caused by some krb5_* symbols. However, I still see some of the same problems as before: about half of my inbox has no subject line listed in the summary window. The calendar does seem to work better but there are still a number of meetings missing that should be there. I can't query free/busy information on other attendees when I create meetings (critically important!) I haven't tried things like sending meeting invites. Any email I send to external addresses still has the TNEF attachment. GAL seems to actually work with this, though, which is nice! ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] Want to contribute to evolution-mapi
On Wed, 2009-11-11 at 08:57 -0500, Matthew Barnes wrote: On Wed, 2009-11-11 at 18:09 +0530, balaji cherukuri wrote: I am a software engineer, I want to contribute to evolution-mapi. Could you give some guidance how would I proceed. Awesome! Some more pointers : http://www.go-evolution.org/MAPIProvider#Download - This page has some information on compiling evolution-mapi (Sadly it is outdated. For evolution-mapi you would need to use git. and for openchange it is still in svn) http://www.go-evolution.org/MAPI_FAQ Feel free to ping me on IRC. I'm 'jony' in #evolution and usually available from 0500 UTC to 1200 UTC. I am new to GNOME development. Great! We could certainly use more help. As with any open source project, the best way to get involved with development is to first familiarize yourself with the source code and relevant libraries, and then try fixing some simple bugs and submitting source code patches to the developers of the project. For evolution-mapi, a good place to bookmark and browse open bugs is: https://bugzilla.gnome.org/browse.cgi?product=evolution-mapi Some good instructions for generating and submitting source code patches: http://live.gnome.org/GnomeLove/SubmittingPatches Here's a more generic overview on getting involved with GNOME. Some parts may be slightly outdated or not applicable to evolution-mapi specifically, but there's still a lot of good information there. http://live.gnome.org/GnomeLove/ In addition to posting questions to this mailing list, I would also encourage you to join the #evolution IRC channel on irc.gnome.org to chat with Evolution developers in real time. Keep in mind, however, that most of the developers are in Indian or European time zones, so their work schedule may be different from yours. Also keep in mind that we're all pretty busy and don't have much time for much hand holding or for questions that can be easily answered with a Google search. But if you present yourself as competent, patient and respectful of others' time, I think you'll find we're a pretty friendly bunch. Good luck! Matthew Barnes ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] go-evolution.org
On Fri, 2009-09-04 at 15:20 +0200, Andre Klapper wrote: Dear Nirav, Ping. :) my two questions still stand. Can you please answer them? Am Dienstag, den 18.08.2009, 12:54 +0200 schrieb Andre Klapper: So have you tried creating a new account on go-evolution.org? If so, please share the steps. Because I fail. Removing the very basic features of a wiki (participation) is not what I'd call a solution. Am Donnerstag, den 23.07.2009, 12:22 +0200 schrieb Andre Klapper: Am Donnerstag, den 23.07.2009, 00:54 -0600 schrieb Nirav Kumar: Migrating Wiki to live.gnome.org/evolution may be difficult with the high data content that evolution wiki holds. Please provide exact numbers. Thanks, andre signature.asc Description: This is a digitally signed message part ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] how to use EDS API
On Fri, 2009-08-07 at 08:39 +0800, Saint yeyo wrote: hello, I wanna use EDS to handle address book, such as add a new address book from backend, I have watch 'eds architeture', it's not too clear, I dont know how to use it, is there some examples? I need you help, thank you. http://test.maemo.org/platform/docs/howtos/howto_using_abook.html#eds Seems to have a good doc for using EDS Addressbook apis. HTH. - Johnny signature.asc Description: This is a digitally signed message part ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] go-evolution.org
On Thu, 2009-07-23 at 19:20 -0600, Nirav Kumar wrote: On Thu, 2009-07-23 at 14:48 -0400, Matthew Barnes wrote: On Thu, 2009-07-23 at 12:17 -0600, Nirav Kumar wrote: As such any takers for revamping wiki on a continuous basis? Define revamping. To revise(make changes) or reconstruct Probably i can give a try for a resource for revamping Wiki and for installing captcha and updating drupple for go-evolution.org. Do you mean Drupal? That would answer my earlier question. Yes live.gnome.org uses MoinMoin, go-evolution.org uses Drupal? Mostly Drupal gets used. http://www.go-evolution.org/Special:Version Mediawiki :-) -- Johnny (johnnyjacob.wordpress.com | johnnyjacob.org) May you share freely, never taking more than you give signature.asc Description: This is a digitally signed message part ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] go-evolution.org
On Thu, 2009-07-23 at 11:09 -0400, Matthew Barnes wrote: On Thu, 2009-07-23 at 06:15 -0600, P Chenthill wrote: We would still need to maintain the old data to know the history though they may become obsolete. Certainly a lot of things mentioned still hold true ;) A compromise might be to only migrate the pages with current and accurate information to l.g.o, and keep go-evolution.org around as a historical archive. Archived pages brought back to life at a later date could be migrated individually. It -is- a wiki, after all. Might be interesting to compile a list of pages we still maintain or care about. I have a few not listed on the front page (BugzillaTopics and ReleaseHOWTO, for example). Perhaps a bigger issue is converting the page markup. I've noticed syntactic differences between the two sites [1], but I don't even know what wiki software the two sites are using. Need to see if there's markup migration scripts out there. Matthew Barnes [1] live.gnome.org's markup syntax seems way more expressive and is actually DOCUMENTED! (http://live.gnome.org/HelpOnEditing) Unlike our own. (http://www.go-evolution.org/Help:Editing) Not to mention the style sheets are prettier. **IMHO** I would prefer live.gnome.org . So +1 for that. And somebody suggested that we can redirect go-evolution.org domain to live.gnome.org/evolution -- Johnny (johnnyjacob.wordpress.com | johnnyjacob.org) May you share freely, never taking more than you give signature.asc Description: This is a digitally signed message part ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] MAPI support of Evo and Windows port
On Tue, 2009-07-14 at 19:23 +0200, Kálmán KAMI Szalai wrote: Hi Evolution Gurus, I am really interested in MAPI support of Evolution. What is the status of MAPI plugin. Is it possible to use Exchange 2007/AD contact list. If the answer is yes, how? Should we configure Samba 4 (Alpha 6) to connect the Domain? Do you have a guide to setup? Also do you know about ongoing efforts of MAPI port to Windows. We are interested in running Evo on Windows with Exchange 2007 server. What is the status of the port, and how can we help? Can you give references for this ? Best regards, KAMI ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers signature.asc Description: This is a digitally signed message part ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] [openchange][devel] [ANN] Evolution-mapi moved to new SVN repository
On Wed, 2008-11-19 at 09:21 +0100, Julien Kerihuel wrote: On Wed, 2008-11-19 at 11:18 +0530, Johnny Jacob wrote: Hello, We have created a new SVN repo for evolution-mapi provider. ** svn://svn.gnome.org/svn/evolution-mapi ** This has repo has : 1. MAPI Account setup e-plugin. 2. libexchangemapi - Backend code for talking to server using openchange's libmapi. 3. Evolution Data Server backends for addressbook and calendar. 4. Camel provider (mails). Hi Johny, Thanks for the update. In the meanwhile, I have written a patch for EXCHANGE-MAPI evolution-data-server yesterday which make evolution work with libmapi-0.8 latest trunk revision. I'll move my patch from EXCHANGE-MAPI-EXCHANGE (local copy) to evolution-mapi new repository asap. I was able to send/receive emails, appointments and contacts. The only update issue I have diagnosed so far is a problem with the recipients routine (the DON'T f***ing touch this function ones function and sub-functions) which I'll presumably be changing ;-) sure :) When I have completed this latest task, I'll update evolution-mapi code to use latest libmapi API functions and review the code for possible bugs/unexpected behavior related to libmapi usage. Thanks Julien! - Johnny ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
[Evolution-hackers] [ANN] Evolution-mapi moved to new SVN repository
Hello, We have created a new SVN repo for evolution-mapi provider. ** svn://svn.gnome.org/svn/evolution-mapi ** This has repo has : 1. MAPI Account setup e-plugin. 2. libexchangemapi - Backend code for talking to server using openchange's libmapi. 3. Evolution Data Server backends for addressbook and calendar. 4. Camel provider (mails). More information on building evolution-mapi is available here [1]. We will be creating a new bugzilla component in bugzilla.gnome.org for evolution-mapi. The EXCHANGE_MAPI_BRANCH[2][3] is closed. Thanks, Johnny [1] http://www.go-evolution.org/MAPIProvider [2] svn://svn.gnome.org/svn/evolution-data-server/branches/EXCHANGE_MAPI_BRANCH [3] svn://svn.gnome.org/svn/evolution-/branches/EXCHANGE_MAPI_BRANCH ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] MAPI backend
On Tue, 2008-08-19 at 20:22 +0200, Patrick Ohly wrote: Hello, I'll soon be migrated to Exchange 2007 at work, so I'll have to get the MAPI backend working or I'll loose convenient access to the shared calendar. I don't have root access, therefore I compiled all the required components (Samba, libmapi, EDS, Evolution) from source. I haven't tried to run it yet. I ran into several compile issues (dolt uses += which my bash didn't support; include paths wrong for out-of-tree compilation) and have patches for them. Shall I submit them to bugzilla.gnome.org? yes please. Add evolution[mapi] in status whiteboard. Have the licensing issues been resolved? It is in progress. What's the recommended way to keep track of the MAPI development (known issues, current status, etc.)? Are the go-evolution pages kept up-to-date? http://www.go-evolution.org/MAPIProvider Yep , we try to keep this page updated. There is a #evo-mapi channel for this. Thanks a lot ! ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] mapi good/bad
On Wed, 2008-08-13 at 10:03 +0100, William John Murray wrote: Hello there, I should have reported earlier: libmapi-0.7-69.5.x86_64 evolution-mapi-provider-20080730.0-2.2.x86_64 worked-for-me, in the sense that I could read all my mail folders. I had previously reported seeing only half of them. Still no calendar, but I think I should not expect it. However, libmapi-0.7-69.6.x86_64 evolution-mapi-provider-20080812.0-1.1.x86_64 do now work. I can see the email previously stored, but no more is downloaded. Right! Looks like i've broken it. Will fix it ASAP. Lots of: camel-mapi-store.c(158):camel_mapi_store_get_type:Reached are printed; it doesn't sound worrying. Is it? Yep. They are just some debug printfs. :) Thanks a lot ! ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] Conduits
On Sun, 2008-07-27 at 20:13 +0200, Oliver Sampson wrote: Hi, I'm interested in poking around/helping out with the conduits portion of Evolution. Where's the code for that located? Evolution-devel? The source doesn't seem to be included with the evolution-condutis package. http://svn.gnome.org/viewvc/evolution/trunk/calendar/conduits/ http://svn.gnome.org/viewvc/evolution/trunk/addressbook/conduit/ hth. Thanks ! -- Johnny Jacob http://johnnyjacob.org signature.asc Description: This is a digitally signed message part ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] Evolution Exchange Summary File format
On Tue, 2008-07-15 at 09:06 +1000, Joel Heenan wrote: Hi, I was wondering whether there is any documentation on the exchange summary file. I'm attempting to write a patch for tracker so that it supports exchange and I'm up to the point where tracker parses the email messages out of the file. It is able to correctly parse out the folder structure and number of emails but can't read the emails themselves probably because there is a bit of data at the beginning its not expecting or the data format is not quite the same. I'm looking for something like: uid | flags | size | date_sent | date_received or maybe you can just tell me how the exchange summary file differs from a standard summary file. afaik, it is the same .. isn't it .. I may be wrong here . -- Johnny Jacob http://johnnyjacob.org signature.asc Description: This is a digitally signed message part ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] Request for a new EPlugin hook in composer windowI would like to modify the Evolution Composer windo
On Mon, 2008-04-14 at 23:36 +0200, Andre Klapper wrote: ahoj, Am Montag, den 14.04.2008, 15:55 -0400 schrieb Gary Ilijevich: I would like to modify the Evolution Composer window. I would like to add a button to the window that, when pressed, checks the entered text for unallowed words (DirtyWords). I would also like to do this check when the user presses the Send button. sounds basically like what the attachment reminder plugin already does (when clicking Send, check the text for some dirty words like attach and when there's no attachment show a warning)? Yep ! just need to modify the popup's message. :) -- Johnny Jacob [EMAIL PROTECTED] http://johnnyjacob.org GPG fingerprint = E296 D0B9 77D9 D968 5574 DB0D 5FD0 B7CA 03DC E845 signature.asc Description: This is a digitally signed message part ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] [Evolution] Building Evo SVN on Ubuntu Hardy
On Wed, 2008-04-09 at 17:02 +1000, Greg Vickers wrote: Hi Paul, Paul Smith wrote: On Wed, 2008-04-09 at 16:45 +1000, Greg Vickers wrote: Will this work on Ubuntu 7.10 (Gutsy)? Yes, definitely. Up until last week I was using it on Gutsy regularly. Create a local.mk file in the same directory and put: DISTRO := gutsy there and you should be all set. And we're off :) I'm hopeful that using the latest version of Evolution will mean that I can talk Exchange MAPI to the Exchange 2007 server that we recently moved to... Greg, I've updated the RPMs in openSUSE Build service [1]. libmapi 0.7 with updated samba4 GIT 41309dc. [1] http://download.opensuse.org/repositories/home:/jjohnny:/evolution-exchange-mapi-provider/ Thanks ! -- Johnny Jacob [EMAIL PROTECTED] http://johnnyjacob.org GPG fingerprint = E296 D0B9 77D9 D968 5574 DB0D 5FD0 B7CA 03DC E845 signature.asc Description: This is a digitally signed message part ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] EPlugin Newbie query
Sandeep, On Mon, 2008-02-25 at 22:23 +0100, Sandeep Gupta wrote: Hi all I need to write a plugin in Evolution. It should be able to add a menu option in compose new mail option. On clicking the menu, it should ask for a file through a dialog box. Then, take this file and body of the mail as input for processing. After processing, it should attach a file produced as result of previous step to the mail. This is very much possible with e-plugins. Now, reading at eplugin documentation, I have faint idea that I need to write an xml file and a C file. C file should implement the call back function. Yep ! Is there a manual for writing the C part of eplugin? Any other help based on the above requirement would be appreciated. Afaik there is a outdated manual available : http://www.gnome.org/projects/evolution/developer-doc/eplugin/. Best way to proceed is by reading code of other plugins. Check : + Save Attachments Plugin for playing with attachments. HTH. - Johnny signature.asc Description: This is a digitally signed message part ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] [RFC PATCH] Uninitialized item.type
On Sun, 2006-08-13 at 03:51 -0400, Pavel Roskin wrote: Hello! Current Evolution from CVS have become very unstable, and I'm trying to fix at least some breakage using Valgrind. The first error it has found is jump depending on uninitialized variable in e-search-bar.c on line 637: switch (items[i].type) { Items are created in e-filter-bar.c in function build_items(). I see that item.type is initialized to 0 if the type argument is 0. Otherwise, it's simply not initialized. set_option() in the same e-filter-bar.c calls build_items() with type=1. I also noticed that ESearchBarItemType is not used in the sources. I think it exists to improve readability of the sources. Please be careful with this patch. I have no idea what filter-bar is and how to invoke it. The patch initializes item.type with type not only when type is 0. It also uses ESearchBarItemType consistently. --- widgets/misc/e-filter-bar.c +++ widgets/misc/e-filter-bar.c @@ -337,7 +337,7 @@ dup_item_no_subitems (ESearchBarItem *de } static GArray * -build_items (ESearchBar *esb, ESearchBarItem *items, int type, int *start, GPtrArray *rules) +build_items (ESearchBar *esb, ESearchBarItem *items, ESearchBarItemType type, int *start, GPtrArray *rules) { FilterRule *rule = NULL; EFilterBar *efb = (EFilterBar *)esb; @@ -368,14 +368,14 @@ build_items (ESearchBar *esb, ESearchBar *start = id; - if (type == 0) {Thanks for pointing the issue of uninitialized item.type. 'type' here denotes the type of the _menu_ to build and not the type of the _menu item_ : type == 0 : Search menu with saved searches. (in menu bar) type == 1 : Search Options menu in search bar. So ESearchBarItemType cannot be used here. + item.type = type; + if (type == ESB_ITEMTYPE_NORMAL) { source = FILTER_SOURCE_INCOMING; /* Add a separator if there is at least one custom rule. */ if (rule_context_next_rule (efb-context, rule, source) != NULL) { item.id = 0; item.text = NULL; - item.type = 0; g_array_append_vals (menu, item, 1); } } else { @@ -386,7 +386,7 @@ build_items (ESearchBar *esb, ESearchBar while ((rule = rule_context_next_rule (efb-context, rule, source))) { item.id = id++; - if (type == 0 num = 10) { + if (type == ESB_ITEMTYPE_NORMAL num = 10) { item.text = g_strdup_printf (_%d. %s, num % 10, rule-name); num ++; } else { @@ -418,7 +418,7 @@ build_items (ESearchBar *esb, ESearchBar } /* always add on the advanced menu */ - if (type == 1) { + if (type == ESB_ITEMTYPE_CHECK) { ESearchBarItem sb_items[2] = { E_FILTERBAR_SEPARATOR, E_FILTERBAR_ADVANCED, /* E_FILTERBAR_SEPARATOR, E_FILTERBAR_SAVE */ }; ESearchBarItem dup_items[2]; @@ -458,7 +458,7 @@ generate_menu (ESearchBar *esb, ESearchB EFilterBar *efb = (EFilterBar *)esb; GArray *menu; - menu = build_items (esb, items, 0, efb-menu_base, efb-menu_rules); + menu = build_items (esb, items, ESB_ITEMTYPE_NORMAL, efb-menu_base, efb-menu_rules); ((ESearchBarClass *)parent_class)-set_menu (esb, (ESearchBarItem *)menu-data); free_built_items (menu); } @@ -507,7 +507,7 @@ set_option (ESearchBar *esb, ESearchBarI GArray *menu; EFilterBar *efb = (EFilterBar *)esb; - menu = build_items (esb, items, 1, efb-option_base, efb-option_rules); + menu = build_items (esb, items, ESB_ITEMTYPE_CHECK, efb-option_base, efb-option_rules); ((ESearchBarClass *)parent_class)-set_option (esb, (ESearchBarItem *)menu-data); free_built_items (menu); -- Johnny ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers