[Bug 192889] Review Request: openais standards based cluster framework

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openais standards based cluster framework


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 02:50 EST ---
(In reply to comment #37)
 The /sbin/service requirement isn't needed as initscripts get pulled in due to
 deps in the Exceptions list.

The initscripts deps were there for the scripts (install-time requirements), not
build dependencies. The exceptions list applies to build requirements. A system
using a different init system (such as initng) might not use initscripts at all.

An example showing an explicit dependency on /sbin/service can be found on the
ScriptletSnippets wiki page:
)http://fedoraproject.org/wiki/ScriptletSnippets?highlight=%28snippets%29#head-24ef9d59bda6032df14cf3cb433ce4ef09348f69



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194011] Review Request: curry - MÃ ¼nster Curry compiler

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: curry -  Münster Curry compiler


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194011





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 03:21 EST ---
I remember reading that shared libraries with ghc were either not
possible or problematic, probably this applies to curry too.
In any case, the only point I would really consider is splitting
out the _g library. It would be possible too patch cyc and cymake
to check for the library (when invoked using --debug) and bail out
with an error when it is not present.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 184450] Review Request: wcstools

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wcstools


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=184450


[EMAIL PROTECTED] changed:

   What|Removed |Added

  QAContact|fedora-extras-  |fedora-package-
   |[EMAIL PROTECTED] |[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 04:50 EST ---
Only 2 small notes - the Requires(post) and Requires(postun) should be moved to
the libwcs subpackage (ldconfig is run after installing or uninstalling the
libraries), the libwcs-devel subpackage doesn't need the run of ldconfig

If you are already Fedora Extras contributor, I will start a formal review.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194572] additional language bug

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: additional language bug


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194572


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||DUPLICATE
  Component|Package Review  |pirut
 CC|fedora-package- |
   |[EMAIL PROTECTED]   |




--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 05:50 EST ---


*** This bug has been marked as a duplicate of 185946 ***

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193342] Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cegui - Free library providing windowing and widgets 
for graphics APIs / engines


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193342





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 06:01 EST ---
Created an attachment (id=130806)
 -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=130806action=view)
Patch fixing tinyxml usage bug

I've been testing cegui with Secret Maryo Chronicles yesterday (fungame, but
I'm afraid its a bit to inspired/like the original to be packagable). While
testing I've found a small (and known but not fixed judging from the comments
GRRR) bug in the TinyXML calling code. This patch fixes this:

About your -5 spin, looking good but:
@@ -6889,7 +6889,7 @@
 # are reset later if shared libraries are not supported. Putting them
 # here allows them to be overridden if necessary.
 runpath_var=LD_RUN_PATH
-hardcode_libdir_flag_spec='${wl}--rpath ${wl}$libdir'
+hardcode_libdir_flag_spec='${wl}$libdir'
 export_dynamic_flag_spec='${wl}--export-dynamic'
 # ancient GNU ld didn't support --whole-archive et. al.
 if $LD --help 21 | grep 'no-whole-archive'  /dev/null; then

That should be:
+hardcode_libdir_flag_spec=''

The old version would expand to:
hardcode_libdir_flag_spec='-Wl,--rpath -Wl,$libdir'
Which would cause gcc to call ld with:
--rpath $libdir
So both must be removed. Notice that there are multiple cases in the patch
where you've got this wrong.

Hint: in cases like this I often find it easier to just edit the patch then to
generate a whole new one, just change the offending lines starting with a +
without touching anything else.

p.s.

If you're interested in SMC let me know I've got some patches for some issues
it has (send upstream too).


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194051] Review Request: abcMIDI - ABC to/from MIDI conversion utilities

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: abcMIDI - ABC to/from MIDI conversion utilities


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194051





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 06:01 EST ---
URL for the spec file is wrong, I'm getting error 404

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194051] Review Request: abcMIDI - ABC to/from MIDI conversion utilities

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: abcMIDI - ABC to/from MIDI conversion utilities


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194051





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 06:07 EST ---
small notes
  - when compiling store.c there is a warning from gcc about an overflow buffer
in sprintf
  - install the binaries with install --strip -m ...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194051] Review Request: abcMIDI - ABC to/from MIDI conversion utilities

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: abcMIDI - ABC to/from MIDI conversion utilities


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194051





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 06:07 EST ---
(In reply to comment #1)
 URL for the spec file is wrong, I'm getting error 404

it should be http://math.ifi.unizh.ch/fedora/spec/abcMIDI.spec ;-)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 192889] Review Request: openais standards based cluster framework

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openais standards based cluster framework


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 06:33 EST ---
(In reply to comment #40)
 Thanks for the link about scriptlets.  I haven't seen this link before.  I
 believe I have the condrestart code wrong (according to the scriptlet docs).
 
 Do I need something like?
 %postun
 if [ $1 -ge 1 ]; then
 /sbin/service openais condrestart /dev/null 21 ||:
 fi
 
 the current code looks like:
 %post
 /sbin/chkconfig --add openais || :
 /sbin/service openais condrestart || :

Yes, though could make it a one-liner:
%postun
[ $1 -ge 1 ]  /sbin/service openais condrestart /dev/null || :

/sbin/service would then be needed in Requires(preun) and Requires(postun) -
don't forget to remove the condrestart from %post.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 185423] Review Request: php-pear-PEAR-Command-Packaging: make-rpm-spec command for PEAR

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-PEAR-Command-Packaging: make-rpm-spec command 
for PEAR


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185423





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 07:28 EST ---
Good call Remi; thanks for spotting that. Updated here:

http://www.timj.co.uk/linux/specs/php-pear-PEAR-Command-Packaging.spec
http://www.timj.co.uk/linux/srpms/php-pear-PEAR-Command-Packaging-0.1.1-2.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194594] New: Review Request: wireshark

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194594

   Summary: Review Request: wireshark
   Product: Fedora Core
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com


Spec URL: wireshark.spec
SRPM URL: 
http://people.redhat.com/rvokal/wireshark/wireshark-0.99.1pre1-1.src.rpm
Description: 

The world's most popular network protocol analyzer has a new name.

Gerald Combs, the creator of the Ethereal® network protocol analyzer, has 
accepted a position with CACE Technologies. CACE is best known for the popular 
WinPcap packet capture library.

Along with the move comes a new name for the project: Wireshark.

This site (http://www.wireshark.org/) is the new home of the project. We look 
forward to continuing our success as world-class network protocol analyzer 
under the new name, and we welcome you to join us. 

The package replaces ethereal but keeps tethereal as a symlink for tshark.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194606] New: Review Request: libica

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194606

   Summary: Review Request: libica
   Product: Fedora Core
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com


Spec URL: http://people.redhat.com/pknirsch/FC/libica.spec
SRPM URL: http://people.redhat.com/pknirsch/FC/libica-1.3.7-1.src.rpm
Description:

This request is for Fedora Core 6.

A library of functions for accessing ICA hardware crypto on IBM zSeries.

This library is split out from openssl and should now become a separate package 
in order to allow easier updates and bugfixes to it.

I've read the packaging guidlines and the package runs smoothly through rpmlint.

Please let me know if anything isn't done correctly.

Thanks,

Read ya, Phil

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194607] New: Review Request: openssl-ibmca

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194607

   Summary: Review Request: openssl-ibmca
   Product: Fedora Core
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com


Spec URL: http://people.redhat.com/pknirsch/FC/openssl-ibmca.spec
SRPM URL: http://people.redhat.com/pknirsch/FC/openssl-ibmca-1.0.0.rc2-1.src.rpm
Description:

This request is for Fedora Core 6.

A dynamic OpenSSL engine for IBMCA crypto hardware on IBM zSeries machines.

The latest openssl-0.9.8 and later allows dynamic engines to be loaded during 
runtime. This package here contains such an engine for IBM zSeries crypto 
hardware and was formerly directly patched into the openssl package itself via 
a huge patch.

This is now split of as a separate package to ease bugfixes for it and keep it 
functional separate from openssl itself.

I've read the packaging guidlines and the package runs smoothly through rpmlint.

Please let me know if anything isn't done correctly.

Thanks,

Read ya, Phil

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 177583] Review Request: zaptel-kmod

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: zaptel-kmod


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177583





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 09:46 EST ---
(In reply to comment #38)
 (In reply to comment #37)
  I've also been seeing the following errors when trying to build i386 
  packages on
  a x86_64 host in mock:
 
 use setarch i686 mock ... to build

Thanks! That works...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 192432] Review Request: compiz

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: compiz


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192432





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 10:07 EST ---
Hehe, compiz on Fedora...
A part of the work is done.

Spec URL: http://fedoraxgl.tuxfamily.org/repository/5/SPECS/compiz.spec
SRPM URL:
http://fedoraxgl.tuxfamily.org/repository/5/SRPMS/compiz-0.0.13-1.fc5.src.rpm

Here what is made: 
* Fri Jun 9 2006 Alphonse Van Assche [EMAIL PROTECTED] 0.0.13-1
- update to 0.0.13
- remove novell.png from the sources archive.
- add a patch for remove all novell.png entry in the sources.
- disable libsvg (only requiere by cube plugin, the plugin work witout but 
  unfortunately the nice fedora logo is no more on the top of the cube... snif).
- remove xgl from requiered packages.
- chang packages description.
- Remove Mesa build-in source stuff.

So for further go, It need some additional:
- Where can we find FBConfig mesa patch for the current rawhide, have find this
one, on the compiz mailing list
http://lists.freedesktop.org/archives/compiz/2006-April/72.html. is that  
patch?
- Where can we find SRPMS for Aiglx? 
- What are the good/best card for aixgl, I will buy one this w-e to test aiglx 
too.
 
I impatiently wait the patched for mesa and Xorg :-D

Thanks




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194551] Review Request: ifd-egate

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ifd-egate


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194551





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 10:18 EST ---
The patch line is 

Patch0: ifd-egate-0.05.timing.patch

but it's more common to see patches named of the form

ifd-egate-0.05-timing.patch

Also, when you apply the patch you do:

%patch0

but it's better to do:

%patch0 -p1 -b .timing

This way the version of the source the patch applies against is encoded into the
patch itself (as the first path component of source and dest lines) and backups
of the unpatched files are made with the .timing extension so that the patch can
be regenerated with /usr/bin/gendiff more easily later.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194551] Review Request: ifd-egate

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ifd-egate


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194551





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 10:20 EST ---
you have the same version number listed twice in your dependencies for libusb.

To make it easier to change that number later, you might want to put something 
like

%define libusb_version 0.1.7

at the top of your file and change all occurences of 0.1.7 to %{libusb_version}

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194551] Review Request: ifd-egate

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ifd-egate


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194551





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 10:28 EST ---
There are a few odd lines at the bottom of the file list:

 %doc ChangeLog COPYING.LIB COPYRIGHT LICENSE PROTOCOL README README-MACOS-X
 %{_libdir}/pcsc/drivers/ifd-egate.bundle/Contents/Info.plist
 %{_libdir}/pcsc/drivers/ifd-egate.bundle/Contents/Linux/libifd_egate.so

README-MACOS-X? ifd-egate.bundle? Info.plist?  Aren't these OSX things?  Can we
nuke the OSX readme, Info.plist, and .bundle dirs and move the dso up 3
directories?  Or would that break things?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 192889] Review Request: openais standards based cluster framework

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openais standards based cluster framework


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 10:37 EST ---
Or to avoid needing service, you could just call /etc/init.d/openais condrestart

Paul, thanks for the info regarding the (preun) (postun) requirements.  I'm
still not entirely convinced that you would be able to have a Fedora system sans
some sort of init scripts.  Personally I try to avoid using the 'service' tool
and instead call the init script by hand, thus avoiding any confusion on needing
initscripts.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 177583] Review Request: zaptel-kmod

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: zaptel-kmod


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177583





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 10:39 EST ---
(In reply to comment #39)

 Can you put up the latest spec and src.rpm that you are using thats building
 cleanly?

Those source rpms were built using mock, so they should be building cleanly. 
Nevertheless I've pushed out new source RPMs.  The URL is:

http://repo.ocjtech.us/asterisk-1.2/fedora/5/SRPMS/


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194621] New: Review Request: kdenetwork: K Desktop Environment - Network Applications

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194621

   Summary: Review Request: kdenetwork: K Desktop Environment -
Network Applications
   Product: Fedora Extras
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


Spec URL: http://kde-redhat.unl.edu/apt/kde-redhat/SPECS/kdenetwork.spec
SRPM URL: 
http://kde-redhat.unl.edu/apt/kde-redhat/all/SRPMS.testing/kdenetwork-3.5.3-2.src.rpm
Description:
Networking applications, including:
* kdict: graphical client for the DICT protocol.
* kget: downloader manager.
* kio_lan: lan browsing kio slave.
* knewsticker: RDF newsticker applet
* kopete: chat client (requires qca-tls for optional jabber/ssl support)
* kpf: public fileserver applet
* kppp: dialer and front end for pppd
* krdc: a client for Desktop Sharing and other VNC servers (requires rdesktop)
* krfb: Desktop Sharing server, allow others to access your desktop via VNC
* ksirc: IRC client
* ktalkd: talk daemon
* lisa: lan information server

%changelog
* Fri Jun 09 2006 Rex Dieter rexdieter[AT]users.sf.net 7:3.5.3-2
- --enable-sametime-plugin, BR: libmeanwhile0-devel
- --enable-slp, BR: openslp-devel
- --with-xmms, BR: xmms-devel
- BR: libxml2 libxslt
- %%doc: AUTHORS COPYING README, app docs (README, TODO, etc...)
- update %%description
- follow icon spec
- don't use usermode(gtk) for kppp (allows users to have separate profiles)
- Requires(hint): rdesktop (krdc)
- Obsoletes/Provides: kopete
- Requires(hint): qca-tls (jabber/tls support for kopete)

* Mon Jun 05 2006 Than Ngo [EMAIL PROTECTED] 7:3.5.3-1
- update to 3.5.3

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 184450] Review Request: wcstools

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wcstools


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=184450


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 10:53 EST ---
%package -n libwcs-devel
Summary: Libraries, includes, etc. used to develop an application with libwcs
Group: Development/Libraries
Requires: libwcs = %{version}-%{release}

Requires should really be

Requires: %{name} = %{version}-%{release}

For the make install, can you not have

make DESTDIR=%{buildroot} install

this then removes the necessity to create a pile of directories and other such
gubbins

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194011] Review Request: curry - MÃ ¼nster Curry compiler

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: curry -  Münster Curry compiler


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194011





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 10:56 EST ---
I split off a curry-debugger package which only contains libcurry_g.a
I patche cyc so that when invoked with --debug with the debugger
package installed, it will give an error and a hint that
the curry-debugger package should be installed.

http://math.ifi.unizh.ch/fedora/5/i386/SRPMS.gemi/curry-0.9.10-2.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 192889] Review Request: openais standards based cluster framework

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openais standards based cluster framework


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 10:57 EST ---
(In reply to comment #42)
 Or to avoid needing service, you could just call /etc/init.d/openais 
 condrestart
 
 Paul, thanks for the info regarding the (preun) (postun) requirements.  I'm
 still not entirely convinced that you would be able to have a Fedora system 
 sans
 some sort of init scripts.  Personally I try to avoid using the 'service' tool
 and instead call the init script by hand, thus avoiding any confusion on 
 needing
 initscripts.

Good point, though I wouldn't hardcode the initscript pathname, particularly not
using the deprecated /etc/init.d location; since the package installs the
initscript into %{_initrddir}, it should run it from there too:

%{_initrddir}/openais condrestart


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 191922] Review Request: dbus-qt: Qt-based library for using D-BUS

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dbus-qt: Qt-based library for using D-BUS


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191922


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 11:02 EST ---
closing, built for FC-4, FC-5, devel branches

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 191589] Review Request: qsa: Qt Script for Applications

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qsa: Qt Script for Applications


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191589


Bug 191589 depends on bug 193256, which changed state.

Bug 193256 Summary: qt4-devel: .qmake.cache missing
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193256

   What|Old Value   |New Value

 Resolution||NOTABUG
 Status|ASSIGNED|CLOSED



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 184450] Review Request: wcstools

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wcstools


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=184450


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163776  |163778
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 11:09 EST ---
Here we go ...

- rpmlint warns about not stripped binaries and libraries = add -s option
when calling install for the binaries, could work also for the lib
- when compiling edhead there is a security warning which recommends to use
mkstemp instead of tempnam - you could create a patch and send it also upstream
- Makefile should use ${RPM_OPT_FLAGS} for CFLAGS instead of direct -g -O2
- when creating the shared lib use $(CC) instead of direct cc
- licensing - in the source files for libwcs I see LGPL = the subpackage should
 have LGPL, but the license for the binaries is unclear, please clarify, you
should (as written in the Package Review Guidelines) also ask the upstream to
include separate license files with the distributed archive
- the libwcs subpackage should go into System Environment/Libraries group, the
-devel subpackage is correctly in Development/Libraries
- the libwcs subpackage should provide libwcs.so.3 and not libwcs.so.3.0.0 - 
you need to play with the link stage (library's name/soname?)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 191589] Review Request: qsa: Qt Script for Applications

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qsa: Qt Script for Applications


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191589


[EMAIL PROTECTED] changed:

   What|Removed |Added

  BugsThisDependsOn|193256  |




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189010] Review Request: pybaz - Python library bindings for the GNU Arch/Bazaar RCS

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pybaz - Python library bindings for the GNU 
Arch/Bazaar RCS


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189010





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 11:19 EST ---
Thanks for your patience in reviewing this package, I've been swamped with work,
school and other miscellany so that fixing troublesome packages has been
relatively low on the TODO list.  I have new packages files up that you can look
at, they add 'make check' and change the pseudo-fix before to work around the
problem at the epydoc level. 'make doc' give a warning at the end as a result
about not building the documentation for 'logging.Logger', but as it's a
standard module I don't think it should have been trying to build that
documenation anyway...

http://shahms.mesd.k12.or.us/packages/pybaz.spec
http://shahms.mesd.k12.or.us/packages/pybaz-1.4-0.2.20060602arch.patch1.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 184450] Review Request: wcstools

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wcstools


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=184450





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 11:28 EST ---
(In reply to comment #4)
 Here we go ...
 
 - rpmlint warns about not stripped binaries and libraries = add -s option
 when calling install for the binaries, could work also for the lib

This will result in a useless debuginfo file. Binaries should be stripped
automatically by the rpm build process, and if they're not, it's probably
because they've been installed without write or execute permission. If the
permissions are fixed, the stripping should happen properly.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 175168] Review Request: gideon - GUI designer for GTK/C++

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gideon - GUI designer for GTK/C++


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=175168





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 11:30 EST ---
So close ... so close. It looks pretty clean to me, so the review should be a
quick one. A little help please...


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 184450] Review Request: wcstools

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wcstools


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=184450





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 11:34 EST ---
(In reply to comment #3)
 Requires: libwcs = %{version}-%{release}

fixed

 For the make install, can you not have
 
 make DESTDIR=%{buildroot} install
 

I don't think so. The makefile is not standard, it does not have even the
install rule

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194594] Review Request: wireshark

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wireshark


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194594





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 11:39 EST ---
ACK for inclusion once review is passed.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194606] Review Request: libica

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libica


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194606





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 11:40 EST ---
So... why do we need a s390-specific package in Core? :)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194607] Review Request: openssl-ibmca

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openssl-ibmca


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194607





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 11:46 EST ---
See similar comment about libica.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194594] Review Request: wireshark

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wireshark


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194594





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 11:48 EST ---
Considering Ethereal is in Core, does Wireshark (which, from everything I
understand, replaces it) really belong in Extras?

Just wondering...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194594] Review Request: wireshark

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wireshark


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194594





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 11:52 EST ---
Pardon my too-quick reply; I didn't realize Core package reviews went out to the
same list, nor that this blocked FC-NEW, not FE-NEW. Doi.

Hooray for the new package, at any rate. :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194628] New: Review Request: vnc-reflector

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194628

   Summary: Review Request: vnc-reflector
   Product: Fedora Extras
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


Spec URL: http://home.comcast.net/~ckweyl/vnc-reflector.spec
SRPM URL: http://home.comcast.net/~ckweyl/vnc-reflector-1.2.4-0.fc5.src.rpm
Description: 

Reflector is a specialized VNC server which acts as a proxy sitting between
real VNC server (a host) and a number of VNC clients. It was designed to work
efficiently with large number of clients.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 191589] Review Request: qsa: Qt Script for Applications

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qsa: Qt Script for Applications


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191589


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 11:55 EST ---
Looks good, everything builds, installs, uninstalls fine for me. 

APPROVED.

SHOULD items:
* include in main pkg
%doc README

* without modification, due to qt4 buglet (see bug #193602), a useless
-debuginfo pkg will (likely?) get created.  Until this is fixed (I'm leaning
toward setting QMAKE_STRIP to empty by default), you'll have to workaround the
problem.  See texmaker bug #193601 for one such workaround.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 184450] Review Request: wcstools

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wcstools


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=184450





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 12:07 EST ---
(In reply to comment #5)
 (In reply to comment #4)
  Here we go ...
  
  - rpmlint warns about not stripped binaries and libraries = add -s option
  when calling install for the binaries, could work also for the lib
 
 This will result in a useless debuginfo file.

Yes, you are right.

 Binaries should be stripped
 automatically by the rpm build process, and if they're not, it's probably
 because they've been installed without write or execute permission. If the
 permissions are fixed, the stripping should happen properly.

When I rebuild the srpm as root, then all files are correctly stripped. So it is
a problem when building the rpm as regular user. So please ignore this point.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 184450] Review Request: wcstools

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wcstools


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=184450





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 12:18 EST ---
  For the make install, can you not have
  
  make DESTDIR=%{buildroot} install
  
 
 I don't think so. The makefile is not standard, it does not have even the
 install rule

install -D will create all directories in the path for the target file

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 184450] Review Request: wcstools

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wcstools


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=184450





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 12:22 EST ---
(In reply to comment #7)
  Binaries should be stripped
  automatically by the rpm build process, and if they're not, it's probably
  because they've been installed without write or execute permission. If the
  permissions are fixed, the stripping should happen properly.
 
 When I rebuild the srpm as root, then all files are correctly stripped. So it 
 is
 a problem when building the rpm as regular user. So please ignore this point.

My regular user has disabled the debug packages, when I enable them, then are
binaries and libs correctly stripped. Interesting ...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 184450] Review Request: wcstools

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wcstools


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=184450





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 12:33 EST ---
(In reply to comment #9)
 My regular user has disabled the debug packages, when I enable them, then are
 binaries and libs correctly stripped. Interesting ...

This will be because it is the process of creating the debuginfo package that
strips the debuginfo from the binaries. Not a good idea to turn it off.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 184450] Review Request: wcstools

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wcstools


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=184450





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 12:42 EST ---
Created an attachment (id=130829)
 -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=130829action=view)
Enable use of custom CFLAGS

With the addition of this patch, the %build section of the script can be
changed to:

%{__make} CC=%{__cc} CFLAGS=%{optflags} -fPIC all

and the package build honors %{optflags}

It also results in some interesting warning messages, such as:
catutil.c:750: warning: call to __builtin___strcpy_chk will always overflow
destination buffer
catutil.c:774: warning: call to __builtin___strcpy_chk will always overflow
destination buffer
imutil.c:648: warning: too few arguments for format
imutil.c:737: warning: too few arguments for format
imutil.c:824: warning: too few arguments for format
getdate.c:388: warning: call to __builtin___strcpy_chk will always overflow
destination buffer
simpos.c:191: warning: control reaches end of non-void function

Makes one wonder about the code quality...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193632] Review Request: tkdnd

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tkdnd


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193632


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 12:45 EST ---
Built for FC-5 and devel

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194551] Review Request: ifd-egate

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ifd-egate


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194551





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 12:50 EST ---
New versions are available now:
Spec URL: 
http://directory.fedora.redhat.com/built/rpm_review/rrelyea/ifd-egate.spec
SRPM URL:
http://directory.fedora.redhat.com/built/rpm_review/rrelyea/ifd-egate-0.05-9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193187] Review Request: pcsc-lite ccid

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pcsc-lite  ccid


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193187





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 12:52 EST ---
Thanks Ville, You may not be able to approve the packages, but your reviews help
give me the confidence that the package is correct. 

bob

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193191] Review Request: rename of notify-daemon to notification-daemon

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rename of notify-daemon to notification-daemon


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193191





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 12:52 EST ---
Package now builds, couple problems: 

W: notification-daemon non-conffile-in-etc
/etc/gconf/schemas/notification-daemon.schemas
W: notification-daemon non-standard-dir-in-usr libexec

Building for x86_64 now.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 192889] Review Request: openais standards based cluster framework

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openais standards based cluster framework


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 13:27 EST ---
Ah right, %{_initrddir} would be proper.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193191] Review Request: rename of notify-daemon to notification-daemon

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rename of notify-daemon to notification-daemon


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193191





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 13:33 EST ---
I don't think renames require any approval (well, barring renames to
fedora-sucks-101 or something.)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 192918] Review Request: kerry - Kerry Beagle is a KDE frontend for the Beagle desktop search

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kerry - Kerry Beagle is a KDE frontend for the Beagle 
desktop search


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192918


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 14:04 EST ---
Imported and built. Closing.
Thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194594] Review Request: wireshark

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wireshark


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194594


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]  |[EMAIL PROTECTED]
OtherBugsDependingO|188265  |188267
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 14:05 EST ---
Radek, it would be helpful if the spec was linked to outside the srpm, just
makes reviews easier.

NEEDSWORK:
- buildroot should be 
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
- You need Provides: ethereal to go along with your Obsoletes: for upgrade 
paths.
- Summary for wireshark-gnome, surely this is for more than just Red Hat 
Gnome ?
- Again, need Provides ethereal-gnome to go along w/ Obsoletes
- tshark - tethereal link is well above the comment regarding it.
- files in /etc should be marked as config files, unless they are init scripts
- Desktop file present but not installed using desktop-file-install (which would
have a BuildRequires: on destkop-file-utils)

Question:
- If you take out the manual Requires, and let rpmbuild figure it out by soname
requirements, does it do the right thing?  THis is preferred method for 
Requires.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 191589] Review Request: qsa: Qt Script for Applications

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qsa: Qt Script for Applications


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191589





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 14:30 EST ---
So the readme is fixed. The debug bug will be better fixed global.
Tell me when you have done it.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194648] New: Review Request: 3ddesktop - 3D OpenGL virtual desktop switcher

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194648

   Summary: Review Request: 3ddesktop - 3D OpenGL virtual desktop
switcher
   Product: Fedora Extras
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


Spec URL: http://www.devin.com.br/eitch/rpm/fedora/SPECS/3ddesktop.spec
SRPM URL: 
http://www.devin.com.br/eitch/rpm/fedora/5/SRPMS/3ddesktop-0.2.9-1.src.rpm
Description: 

3d Destkop is an OpenGL program for switching virtual desktops in a
seamless 3-dimensional manner. The current desktop is mapped into a 3D
space where you may choose other screens. When activated the current
desktop appears to zoom out into the 3D view.  Several different
visualization modes are available.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 180092] Review Request: NRPE - Monitoring agent for Nagios

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: NRPE - Monitoring agent for Nagios


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180092


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 14:43 EST ---
During configure:

checking for Kerberos include files... could not find include files



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194481] Review Request: eggdrop

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eggdrop


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194481





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 14:46 EST ---
Yes, I think that would be suitable for rpmlint.  Just be sure to run rpmlint on
your rpms to make sure.  Note however I am just making comments to your package,
I do not have the authority or powerz to review packages that need a sponser 
yet.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 192889] Review Request: openais standards based cluster framework

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openais standards based cluster framework


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 14:55 EST ---
The changelog for this new SRPM is:
* Fri Jun 9 2006 Steven Dake [EMAIL PROTECTED] - 0.76-1.6
- Change condrestart to restart as specified in Fedora Wiki.
- Call initscript directly as suggested by Jesse.

The new SRPM and specfile can be downloaded from:
Spec URL: http://developer.osdl.org/dev/openais/SRPM/openais.spec
SRPM URL: http://developer.osdl.org/dev/openais/SRPM/openais-0.76-1.6.src.rpm

I have tested that the upgrade actually restarts the daemon and it seems to
work.  Thanks for the suggestion of the one liner Paul.  I also made Jesse's
suggestion of removing /sbin/service entirely from the specfile.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193982] Review Request: osgal - Adapts OpenSceneGraph to use OpenAL++

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: osgal - Adapts OpenSceneGraph to use OpenAL++


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193982





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 15:09 EST ---
(In reply to comment #3)
  Whats this? : /usr/lib/libosgdb_osgAL.so
 
 when you write an osg plugin (nodekit), you have two parts: the library that
 implements the nodekit libosgal.so, and you also have a osgDB binding that
 allows it to be associated to a file extension (roughly) libosgdb_osgAL.so.
 

Ah i read gdb as dbg from debug, so I thought it might be a special debug build,
which is ofcouse not good, as we have -debuginfo for that.

  What does the -version-info 1:0:0 in osgal-cvs-debian-01.dpatch do?
 
 version-info is temporary, the next osgal version will have proper soname
 versioning because I discussed it with the upstream and he understands why 
 it's
 necessary

Good!


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193342] Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cegui - Free library providing windowing and widgets 
for graphics APIs / engines


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193342





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 15:12 EST ---
Created an attachment (id=130838)
 -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=130838action=view)
Patch fixjng 64 bit problems

And the next and hopefully last patch there is a wrong usage of long instead of
int in the openGL renderer which breaks things on 64 bit, this patch fixes
this. Without this all the samples went black, now they actually work. With
this patch I've also got SMC running 100% on 64 bit, so its seems CEGUI is 64
bit clean with this little fix.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 191589] Review Request: qsa: Qt Script for Applications

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qsa: Qt Script for Applications


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191589





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 15:18 EST ---
FYI, just queue'd a fixed qt4 build for the QMAKE_STRIP issue.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193187] Review Request: pcsc-lite ccid

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pcsc-lite  ccid


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193187





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 16:04 EST ---
I trust Ville's judgement.  However this package fails to build in mock(brew):
checking for libusb-config... yes
/usr/bin/libusb-config: line 80: pkg-config: command not found
/usr/bin/libusb-config: line 83: pkg-config: command not found
checking usb.h usability... yes
checking usb.h presence... yes
checking for usb.h... yes
checking for usb_init... configure: error: libusb not found, use ./configure
LIBUSB_LIBS=...
error: Bad exit status from /var/tmp/rpm-tmp.63602 (%build)

Looks like a possible missing BR on pkgconfig ?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194436] Review Request: wormux - 2D Kill 'em all game

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wormux - 2D Kill 'em all game


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194436


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 16:09 EST ---
My Review:

OKS

 * Package's name is ok
 * rpmlint returns ok
 * Spec name is ok and legible in English
 * License is ok and included in %doc
 * Package's source matches upstream checksum
 * Package builds fine
 * BuildRequires are ok
 * Package's %files are ok and all directories owned
 * Package's %clean is ok
 * Use of macros and scriptlets are fine

SHOULD

 * Currently the package doesn't have locale files and the %find_lang macro 
isn't necessary. But in the future this could change, so I think it should be 
used from now
 * You should create a sub-package to the data files, for example, 
wormux-data. This will save the users' bandwidth when minor fixes are applied 
to the main package.
 * The description field is too vague. Try describing the game better ;-)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194051] Review Request: abcMIDI - ABC to/from MIDI conversion utilities

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: abcMIDI - ABC to/from MIDI conversion utilities


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194051





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 16:30 EST ---
- install the binaries with install --strip -m ...
 This is not necessary, stripping is handled by rpmbuild.
 

Yes, you are right. It was a problem on my system with disabled building of
debug packages. In such case the stripping doesn't work.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194481] Review Request: eggdrop

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eggdrop


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194481





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 16:55 EST ---
I know, spec file and Source RPM were updated.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194436] Review Request: wormux - 2D Kill 'em all game

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wormux - 2D Kill 'em all game


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194436


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194436] Review Request: wormux - 2D Kill 'em all game

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wormux - 2D Kill 'em all game


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194436





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 17:09 EST ---
(In reply to comment #1)

 SHOULD
 
  * Currently the package doesn't have locale files and the %find_lang macro 
 isn't necessary. But in the future this could change, so I think it should be 
 used from now

I prefer not to include %find_lang until there are actual lang files.  Otherwise
it leads to extra misleading cruft in the spec file.

  * You should create a sub-package to the data files, for example, 
 wormux-data. This will save the users' bandwidth when minor fixes are applied 
 to the main package.

Good point.  Done.  Note that this won't actually reduce the size of the
downloads, since a new -data subpackage will automatically get built when the
game engine is updated.  upstream should package the game data in a separate
tarball for us to really benefit from the -data subpackage.

  * The description field is too vague. Try describing the game better ;-)

Yeah, I kinda flaked on that.  I tend to cut and paste the descriptions from the
packages' home pages.  In this case, the home page didn't have a decent
description when I first wrote the spec.  It should look better now.

http://www.kobold.org/~wart/fedora/wormux-0.7.2-2.src.rpm
http://www.kobold.org/~wart/fedora/wormux.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193187] Review Request: pcsc-lite ccid

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pcsc-lite  ccid


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193187





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 17:17 EST ---
Which of the 2 packages failed?
I was able to build pcsc-lite without pkgconfig
I was not able to build ccid without it, but ccid depends on pcsc-lite-devel 
which
  has a requires of pkgconfig (I wasn't able to install pcsc-lite-devel without
  installing pkgconfig).

So is the correct fix updating the BuildRequires line for ccid to require
pcsc-lite-devel version 1.3.1 instead of 1.3.0, or is the correct fix to add
an explicit BuildRequires for ccid for pkgconfig, or both;)?

I'm assuming ccid is the one that blew up since I was able to build
pcsc-lite.spec fine without it.

bob

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193187] Review Request: pcsc-lite ccid

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pcsc-lite  ccid


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193187





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 17:19 EST ---
AFAIK, all that's required is to wait for a fixed libusb to percolate.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194051] Review Request: abcMIDI - ABC to/from MIDI conversion utilities

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: abcMIDI - ABC to/from MIDI conversion utilities


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194051


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193342] Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cegui - Free library providing windowing and widgets 
for graphics APIs / engines


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193342





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 17:47 EST ---
Hi here's the latest version with those patches applied too, much obliged Hans.
Regarding those SMC patches, sure I wouldn't mind them. Coincidentally it was
SMC that got me looking into cegui and DevIL in the first place :)

http://dribble.org.uk/cegui.spec
http://dribble.org.uk/cegui-0.4.1-6.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194051] Review Request: abcMIDI - ABC to/from MIDI conversion utilities

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: abcMIDI - ABC to/from MIDI conversion utilities


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194051





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 17:50 EST ---
The formal side looks well, but when trying to run
abc2midi /usr/share/doc/abcMIDI-20060422/demo.abc -c -v

the result is:
Reference X: 1
scanning tune
handling grace notes
fixing repeats
track 0, voice 0
Floating point exception

It could have probably something to do with the buffer overflow.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194436] Review Request: wormux - 2D Kill 'em all game

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wormux - 2D Kill 'em all game


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194436





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 18:06 EST ---
* rpmlint output okay:
W: wormux-data no-documentation
* Package is named according to package naming guidelines
* spec file matches package %{name}
* Package meets packaging guidelines
* Package licensed with open source compatible license
* License in spec file matches actual license
* License text file included in %doc
* Spec file written in American english
* Spec file is legible
* Sources match upstream source
08d897a89f06cb855709be2904308cac  wormux-0.7.2.tar.gz
* Package successfully compiles and builds on x86_64 FC-5
* All build dependencies are listed in BuildRequires

- Except for pkgconfig which will be needed for FC-6

* No locales in package
* Package does not make a shared library
* Package is not relocatable
* Package owns all directories it creates
* Package does not contain duplicate files in %files
* Permissions on files set properly
* Package has appropriate %clean section

- Macro usage is not consistant

* Package contains permissible content
* Package does not contain large documentation to warrent a -doc subpackage
* Files in %doc do not affect runtime of application
* Package does not contain header files or static libraries
* Package does not contain any .pc files
* Package does not contain any .so files
* Package does not need a devel subpackage
* Package does not contain any .la files
* Package contains a nearly appropriate .desktop file

- .desktop file missing Encoding section

* Package does not own files or directories owned by other packages


MUST:
- Add pkgconfig to BuildRequires for FC6 builds
- Add Encoding field to .desktop file
- Use %{buildroot} consistantly, there is an $RPM_BUILD_ROOT adn %{buildroot}
- Remove INSTALL from %files

Notes:
- Credits button doesn't seem to do anything, not sure if its broken or just not
implemented yet.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194051] Review Request: abcMIDI - ABC to/from MIDI conversion utilities

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: abcMIDI - ABC to/from MIDI conversion utilities


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194051





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 18:33 EST ---
(In reply to comment #6)
 The formal side looks well, but when trying to run
 abc2midi /usr/share/doc/abcMIDI-20060422/demo.abc -c -v
 
 the result is:
 Reference X: 1
 scanning tune
 handling grace notes
 fixing repeats
 track 0, voice 0
 Floating point exception
 
 It could have probably something to do with the buffer overflow.
This seems to be a division by zero, triggered by code that is run
only when the -c option is given.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194436] Review Request: wormux - 2D Kill 'em all game

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wormux - 2D Kill 'em all game


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194436





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 18:44 EST ---
(In reply to comment #3)
 MUST:
 - Add pkgconfig to BuildRequires for FC6 builds

This shouldn't be necessary.  There is already a BR: libxml++-devel which itself
requires pkgconfig
 
 - Add Encoding field to .desktop file

Fixed

 - Use %{buildroot} consistantly, there is an $RPM_BUILD_ROOT adn %{buildroot}

Fixed

 - Remove INSTALL from %files

Fixed

 Notes:
 - Credits button doesn't seem to do anything, not sure if its broken or just 
 not
 implemented yet.

I'll take a closer look at that.

Here's a new package that fixes all of the above except for the broken credits
button:

http://www.kobold.org/~wart/fedora/wormux-0.7.2-3.src.rpm
http://www.kobold.org/~wart/fedora/wormux.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194436] Review Request: wormux - 2D Kill 'em all game

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wormux - 2D Kill 'em all game


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194436


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 18:58 EST ---
** APPROVED **

Noticed that exerminate is missing a t.  Non-blocker, but please fix.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193957] Review Request: nant

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nant


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193957





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 19:09 EST ---
I have to look at the libdir issue some more this weekend first.

Also tibbs has asked spot to look into what kind of formal guidelines would make
sense for mono applications as well.  So far there's been discussion about
redefining %{_libdir}, whether %{_datadir} vs /usr/lib is something worth
waiting for, and the security issues WRT .dlls distributed by a project that is
not its upstream.  If you have any guideline ideas or whatnot, it would be good
to email fedora-extras or jump into fedora-extras IRC to discuss them.  I'm
pretty sure that with some more formal guidelines there will be more people
willing to review mono packages.

The libdir thing is so hacky that a lot of people just don't know what would be
a good idea with mono and what would not.  I'm willing to look at it.  But
understanding the underlying issues and trying to figure out whether redefining
libdir is really needed and what other methods might be applied to fixing things
has to come before I can do a competent job of reviewing.

It would really suck if a whole slew of mono apps were approved now and we had
to chase them all down and fix them later.  And it would really suck if some of
the other mono packagers weren't as conscientious as you about fixing things
once issues were brought up and we had packages needing fixes sitting around the
repository for years.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193110] Review Request: python-sexy

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-sexy


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193110


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||177841
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 21:17 EST ---
Add a block to FE-NEEDSPONSOR, per the initial comment...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194648] Review Request: 3ddesktop - 3D OpenGL virtual desktop switcher

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: 3ddesktop - 3D OpenGL virtual desktop switcher


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194648


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 21:30 EST ---
Not a review, but:

* imlib2-devel is needed as a build requires.

* Build fails on my x86_64 box (fc5) with:
...
configure: creating ./config.status
config.status: creating Makefile
config.status: creating 3ddesktop.spec
config.status: creating maketar.sh
config.status: creating config.h
config.status: executing depfiles commands
+ make -j2
cd .  /bin/sh /home/cweyl/rpms/tmp/BUILD/3ddesktop-0.2.9/missing --run 
autoheader
rm -f stamp-h1
touch config.h.in
cd .  /bin/sh ./config.status config.h
config.status: creating config.h
config.status: config.h is unchanged
make  all-am
make[1]: Entering directory `/home/cweyl/rpms/tmp/BUILD/3ddesktop-0.2.9'
if g++ -DHAVE_CONFIG_H -I. -I. -I.-Wall -O3 -DQT_CLEAN_NAMESPACE
-DSHAREDIR=\/usr/share/3ddesktop\ -DSYSCONFDIR=\/etc\  -O2 -g -pipe -Wall
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4
-m64 -mtune=generic  -MT 3ddesk.o -MD -MP -MF .deps/3ddesk.Tpo -c -o 3ddesk.o
3ddesk.cpp; \
then mv -f .deps/3ddesk.Tpo .deps/3ddesk.Po; else rm -f .deps/3ddesk.Tpo;
exit 1; fi
if g++ -DHAVE_CONFIG_H -I. -I. -I.-Wall -O3 -DQT_CLEAN_NAMESPACE
-DSHAREDIR=\/usr/share/3ddesktop\ -DSYSCONFDIR=\/etc\  -O2 -g -pipe -Wall
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4
-m64 -mtune=generic  -MT 3ddeskd.o -MD -MP -MF .deps/3ddeskd.Tpo -c -o
3ddeskd.o 3ddeskd.cpp; \
then mv -f .deps/3ddeskd.Tpo .deps/3ddeskd.Po; else rm -f
.deps/3ddeskd.Tpo; exit 1; fi
event.hpp: In member function 'void EventManager::print_events_in_queue()':
event.hpp:77: error: cast from 'void (*)(Event*)' to 'unsigned int' loses 
precision
if g++ -DHAVE_CONFIG_H -I. -I. -I.-Wall -O3 -DQT_CLEAN_NAMESPACE
-DSHAREDIR=\/usr/share/3ddesktop\ -DSYSCONFDIR=\/etc\  -O2 -g -pipe -Wall
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4
-m64 -mtune=generic  -MT xutil.o -MD -MP -MF .deps/xutil.Tpo -c -o xutil.o
xutil.cpp; \
then mv -f .deps/xutil.Tpo .deps/xutil.Po; else rm -f .deps/xutil.Tpo;
exit 1; fi
make[1]: *** [3ddeskd.o] Error 1
make[1]: *** Waiting for unfinished jobs
xutil.cpp: In member function 'int VDesktops::sawfish_get_current_workspace()':
xutil.cpp:525: warning: ignoring return value of 'int fscanf(FILE*, const char*,
...)', declared with attribute warn_unused_result
xutil.cpp: In member function 'int VDesktops::sawfish_get_workspace_count()':
xutil.cpp:543: warning: ignoring return value of 'int fscanf(FILE*, const char*,
...)', declared with attribute warn_unused_result
xutil.cpp: In member function 'void 
VDesktops::sawfish_set_current_workspace(int)':
xutil.cpp:557: warning: ignoring return value of 'int system(const char*)',
declared with attribute warn_unused_result
make[1]: Leaving directory `/home/cweyl/rpms/tmp/BUILD/3ddesktop-0.2.9'
make: *** [all] Error 2
error: Bad exit status from /home/cweyl/rpms/tmp/rpm-tmp.89127 (%build)


RPM build errors:
Bad exit status from /home/cweyl/rpms/tmp/rpm-tmp.89127 (%build)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193187] Review Request: pcsc-lite ccid

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pcsc-lite  ccid


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193187





--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 22:07 EST ---
I fixed that, and now this package builds for i386 and x86_64.

rpmlint has some things to say:

W: pcsc-lite strange-permission pcsc-lite-1.3.1.tar.gz 0666
W: pcsc-lite strange-permission pcsc-lite-docinst.patch 0666
W: pcsc-lite strange-permission pcsc-lite.spec 0666
W: pcsc-lite strange-permission pcsc-lite-1.3.0-rpath64.patch 0666
W: pcsc-lite conffile-without-noreplace-flag /etc/reader.conf
W: pcsc-lite non-conffile-in-etc /etc/reader.conf.d/README
W: pcsc-lite service-default-enabled /etc/rc.d/init.d/pcscd
W: pcsc-lite incoherent-subsys /etc/rc.d/init.d/pcscd $prog
W: pcsc-lite incoherent-init-script-name pcscd
W: pcsc-lite-devel no-dependency-on pcsc-lite
W: pcsc-lite-devel no-documentation
W: pcsc-lite-libs no-documentation


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194730] New: Review Request: guichan - A Portable C++ GUI library for games using Allegro, SDL and OpenGL

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194730

   Summary: Review Request: guichan - A Portable C++ GUI library for
games using Allegro, SDL and OpenGL
   Product: Fedora Extras
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


Spec URL: http://www.devin.com.br/eitch/rpm/fedora/SPECS/guichan.spec
SRPM URL: 
http://www.devin.com.br/eitch/rpm/fedora/5/SRPMS/guichan-0.4.0-1.src.rpm
Description:

Guichan is a small, efficient C++ GUI library designed for games. It comes
with a standard set of widgets and can use several different objects for
displaying graphics and grabbing user input.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194436] Review Request: wormux - 2D Kill 'em all game

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wormux - 2D Kill 'em all game


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194436


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2006-06-09 22:50 EST ---
Imported and built on -devel

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194730] Review Request: guichan - A Portable C++ GUI library for games using Allegro, SDL and OpenGL

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: guichan - A Portable C++ GUI library for games using 
Allegro, SDL and OpenGL


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194730


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 188359] Review Request: bugzilla - bug tracking tool

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bugzilla - bug tracking tool


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188359





--- Additional Comments From [EMAIL PROTECTED]  2006-06-10 00:17 EST ---
Well, that took longer than I anticipated.

I found that the requires filtering in the spec wasn't working at all.  Plus, it
looks like it was attempting to filter out more than necessary.  I found that if
I just filter out the perl(globals.pl) bit, everything looks sane.

Also, the .cvsignore files are still being packaged; the statement in %build to
delete them is looking for directories named .cvsignore, not files.

Finally, this needs to live under /usr/share, not /var/www, which is a simple
edit of the first line plus the httpd.conf file.

I'll attach the specfile I used to build; with this there are only the two
no-documentation warnings from rpmlint can be ignored.  Care to look it over
and push a fresh package for a final review?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 188359] Review Request: bugzilla - bug tracking tool

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bugzilla - bug tracking tool


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188359





--- Additional Comments From [EMAIL PROTECTED]  2006-06-10 00:21 EST ---
Created an attachment (id=130877)
 -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=130877action=view)
Suggested specfile


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194730] Review Request: guichan - A Portable C++ GUI library for games using Allegro, SDL and OpenGL

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: guichan - A Portable C++ GUI library for games using 
Allegro, SDL and OpenGL


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194730





--- Additional Comments From [EMAIL PROTECTED]  2006-06-10 00:44 EST ---
MUST

* name matches upstream
* BSD license ok, license file included
* Spec file legible and in Am. English
* Sources match upstream:
  f68b6c603c4fb3d70a8737f916214a35  guichan-0.4.0-src.tar.gz
* No excessive BR:
* Owns all directories that it creates
* No duplicate %files
* file permissions look ok
* Not relocatable
* ldconfig called where needed
* macro use consistent
* headers and unversioned .so files in -devel package
* RPM_BUILD_ROOT cleaned where needed
* No .la files
* no -doc subpackage needed
* devel require base using fully versioned dependency
* No .desktop file needed
* Compiles and builds on:
  FC4-i386, FC4-x86_64, FC5-i386, FC5-x86_64

MUSTFIX
===
* Remove the leading 'A' from the summary
* Remove the empty Requires: line
* Add the following in %prep to prevent the trigger of calls to autoxxx:
touch aclocal.m4 Makefile.in */Makefile.in */*/Makefile.in */*/*/Makefile.in
touch include/config.hpp.in

QUESTIONS
=
* why the 'cp -a' in %prep?  Just use %doc docs/html/* to pick up all of
  the files.

- Doesn't compile on FC-6 due to missing autoxxx.  The 'touch' commands
  above should fix that.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 188359] Review Request: bugzilla - bug tracking tool

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bugzilla - bug tracking tool


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188359





--- Additional Comments From [EMAIL PROTECTED]  2006-06-10 00:58 EST ---
(In reply to comment #24)
 Finally, this needs to live under /usr/share, not /var/www, which is a simple
 edit of the first line plus the httpd.conf file.

  Will SELinux actually allow Apache to execute CGIs that live in /usr/share?
Particularly ones that need to write to directories?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 188359] Review Request: bugzilla - bug tracking tool

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bugzilla - bug tracking tool


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188359





--- Additional Comments From [EMAIL PROTECTED]  2006-06-10 01:22 EST ---
I suggest you peruse the gallery2 review, which deals with this issue:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181599

My understanding is that selinux will allow apache to run things out of
/usr/share as long as the appropriate selinux boolean is set.  And if it didn't,
we'd need to work with the selinux folks to get the necessary bits in.  It's
simply not permissible for us to put things in /var/www.

Now, what does bugzilla need to write?  I thought it was entirely database
driven.  Obviously it can't write to /usr/share, so we have to use another
location.  The gallery2 package uses a directory under /srv for this, but it
does take selinux bits.  The bug for that is
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=183140

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 188359] Review Request: bugzilla - bug tracking tool

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bugzilla - bug tracking tool


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188359





--- Additional Comments From [EMAIL PROTECTED]  2006-06-10 01:37 EST ---
It has to write to the data/ directory and various subdirectories under that.
The data directory is created by checksetup.pl. You can change where Bugzilla
expects the data directory to be by editing the $datadir variable in
Bugzilla/Config.pm.

Why can't we put something in /var/www? It's where we normally put Bugzilla.

Also note that Bugzilla requires *either* DBD::Pg or DBD::mysql, but it doesn't
need both. I'm not sure how to handle that in RPM. The automatic deps will
probably pick up both.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193807] Review Request: libsvg-cairo

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libsvg-cairo


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193807


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 192432] Review Request: compiz

2006-06-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: compiz


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192432


Bug 192432 depends on bug 193807, which changed state.

Bug 193807 Summary: Review Request: libsvg-cairo
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193807

   What|Old Value   |New Value

 Resolution||NEXTRELEASE
 Status|NEW |CLOSED



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review