[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Core |Fedora -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED OtherBugsDependingO||188267 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-06-14 03:09 EST --- My review from yesterday got lost with the bugzilla crash: Review == rpmlint output: E: openais non-readable /usr/sbin/ais-keygen 0700 E: openais non-standard-executable-perm /usr/sbin/ais-keygen 0700 (required permissions) W: openais non-standard-dir-in-usr libexec (not *that* non-standard) W: openais incoherent-subsys /etc/rc.d/init.d/openais $prog (daemon and package name are incoherent upstream) W: openais-devel conffile-without-noreplace-flag /etc/ld.so.conf.d/openais-i686.conf (is anyone *really* going to edit this file anyway?) I don't believe any of these are blockers, or even need fixing. - package and spec file naming OK - package meets guidelines - license is BSD, matches spec, text included - spec file written in ENglish and is legible - sources match upstream - builds OK in mock for rawhide (i386) - buildreqs OK - no locale-specific data - shared libraries present in -devel package (only needed for devel) ldconfig is properly called in %post and %postun for the devel package - not relocatable - no directory ownership or permissions issues - no duplicate files - %clean section present and correct - macro usage is consistent - code, not content - documentation volume not excessive - docs don't affect runtime - header files properly located in -devel package - static libraries disabled - no pkgconfig file - -devel package has fully-versioned dependency on main package - no libtool archives included - not a GUI application, so no desktop file needed - scriptlets are sane Issues == - package is ExclusiveArch: i386 ppc x86_64 ppc64 Since this covers all current Fedora Core architectures, why is it present? - please correct confusing 0.76-1.6 changelog entry Once these are addressed, I'll be in a position where I'd be happy to approve this package if it was for Fedora Extras, However, I cannot approve Core packages, so someone else will need to do that. Post-review, it was noted that the package failed to build on x86_64 due to -fPIC being missing from CFLAGS, This was to be fixed by a patched Makefile. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 --- Additional Comments From [EMAIL PROTECTED] 2006-06-14 04:27 EST --- The last few postings to bugzilla were lost. Here are some of the last changelog entries: * Tue Jun 13 2006 Steven Dake [EMAIL PROTECTED] - 0.76-1.8 - Add makefile override patch which fixes build with optflags on x86_64 arch. - Remove -DOPENAIS_LINUX from passed CFLAGS since it now works properly with makefile override patch. * Tue Jun 13 2006 Steven Dake [EMAIL PROTECTED] - 0.76-1.7 - Remove ExclusiveArch since all Fedora Core 6 arches have been tested. * Fri Jun 9 2006 Steven Dake [EMAIL PROTECTED] - 0.76-1.6 - Move condrestart to %%postun instead of %%post. - Call initscript directly as suggested by Jesse. * Thu Jun 8 2006 Steven Dake [EMAIL PROTECTED] - 0.76-1.5 - Changed BuildRoot tag to match convention specified in Fedora Wiki. - Removed /sbin/service dependency since it is pulled in from init packages. * Mon Jun 5 2006 Steven Dake [EMAIL PROTECTED] - 0.76-1.4 - Moved uid 102 to 39 since uids over 99 are not suitable for core at Bill's suggestion. * Mon Jun 5 2006 Steven Dake [EMAIL PROTECTED] - 0.76-1.3 - Allocated uid 102 from setup package for user add operation. - Added || : to initscript stuff so initscript bugs dont cause RPM transaction failures as per Paul's suggestion. - Added /sbin/services to post requires as per Paul's suggestion. - Removed ldconfig from the requires post for the main package as per Paul's suggestion. - Changed post devel scriptlet action as per Paul's suggestion. * Thu May 31 2006 Steven Dake [EMAIL PROTECTED] - 0.76-1.2 - Add user account for AIS applications and authentication. - Move /etc/ld.so.conf/openais-*.conf to devel package since it is only needed there. - Move ldconfig to devel package. - Execute condrestart on upgrade * Fri May 25 2006 Steven Dake [EMAIL PROTECTED] - 0.76-1.1 - Fix unowned dirs problem. - Correct make with optflags work properly. - Move plugins from /usr/lib/openais/lcrso to /usr/libexec/lcrso. The latest SRPM and specfile are located at: Spec URL: http://developer.osdl.org/dev/openais/SRPM/openais.spec SRPM URL: http://developer.osdl.org/dev/openais/SRPM/openais-0.76-1.8.src.rpm Jesse I believe the rpmlint errors were discussed in some of the thread that was lot in the bz crash but I agree with Paul's analysis in comment #40. I have tested that the rpm binaries build, install and work as expected on x86_64 WS4 and i386 FC5. Version 0.76 has been tested on both ppc and ppc64. I don't have other (ppc*) target arches with FC5 or rawhide to test the rpm build process. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE OtherBugsDependingO|188267 |188268 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-06-14 16:35 EST --- This was added to rawhide. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||188267 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-06-13 09:42 EST --- Review == rpmlint output: E: openais non-readable /usr/sbin/ais-keygen 0700 E: openais non-standard-executable-perm /usr/sbin/ais-keygen 0700 (required permissions) W: openais non-standard-dir-in-usr libexec (not *that* non-standard) W: openais incoherent-subsys /etc/rc.d/init.d/openais $prog (daemon and package name are incoherent upstream) W: openais-devel conffile-without-noreplace-flag /etc/ld.so.conf.d/openais-i686.conf (is anyone *really* going to edit this file anyway?) I don't believe any of these are blockers, or even need fixing. - package and spec file naming OK - package meets guidelines - license is BSD, matches spec, text included - spec file written in ENglish and is legible - sources match upstream - builds OK in mock for rawhide (i386) - buildreqs OK - no locale-specific data - shared libraries present in -devel package (only needed for devel) ldconfig is properly called in %post and %postun for the devel package - not relocatable - no directory ownership or permissions issues - no duplicate files - %clean section present and correct - macro usage is consistent - code, not content - documentation volume not excessive - docs don't affect runtime - header files properly located in -devel package - static libraries disabled - no pkgconfig file - -devel package has fully-versioned dependency on main package - no libtool archives included - not a GUI application, so no desktop file needed - scriptlets are sane Issues == - package is ExclusiveArch: i386 ppc x86_64 ppc64 Since this covers all current Fedora Core architectures, why is it present? - please correct confusing 0.76-1.6 changelog entry (Comment #48) Once these are addressed, I'll be in a position where I'd be happy to approve this package if it was for Fedora Extras, However, I cannot approve Core packages, so someone else will need to do that. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |NEEDINFO_REPORTER -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEEDINFO_REPORTER |ASSIGNED --- Additional Comments From [EMAIL PROTECTED] 2006-06-13 11:30 EST --- (In reply to comment #50) Review == rpmlint output: E: openais non-readable /usr/sbin/ais-keygen 0700 E: openais non-standard-executable-perm /usr/sbin/ais-keygen 0700 (required permissions) W: openais non-standard-dir-in-usr libexec (not *that* non-standard) W: openais incoherent-subsys /etc/rc.d/init.d/openais $prog (daemon and package name are incoherent upstream) W: openais-devel conffile-without-noreplace-flag /etc/ld.so.conf.d/openais-i686.conf (is anyone *really* going to edit this file anyway?) I don't believe any of these are blockers, or even need fixing. - package and spec file naming OK - package meets guidelines - license is BSD, matches spec, text included - spec file written in ENglish and is legible - sources match upstream - builds OK in mock for rawhide (i386) - buildreqs OK - no locale-specific data - shared libraries present in -devel package (only needed for devel) ldconfig is properly called in %post and %postun for the devel package - not relocatable - no directory ownership or permissions issues - no duplicate files - %clean section present and correct - macro usage is consistent - code, not content - documentation volume not excessive - docs don't affect runtime - header files properly located in -devel package - static libraries disabled - no pkgconfig file - -devel package has fully-versioned dependency on main package - no libtool archives included - not a GUI application, so no desktop file needed - scriptlets are sane Issues == - package is ExclusiveArch: i386 ppc x86_64 ppc64 Since this covers all current Fedora Core architectures, why is it present? - please correct confusing 0.76-1.6 changelog entry (Comment #48) Once these are addressed, I'll be in a position where I'd be happy to approve this package if it was for Fedora Extras, However, I cannot approve Core packages, so someone else will need to do that. Paul Thank you for your review. I've updated the package as follows: * Tue Jun 13 2006 Steven Dake [EMAIL PROTECTED] - 0.76-1.7 - Remove ExclusiveArch since all Fedora Core 6 arches have been tested. * Fri Jun 9 2006 Steven Dake [EMAIL PROTECTED] - 0.76-1.6 - Move condrestart to %%postun instead of %%post. - Call initscript directly as suggested by Jesse. The new SRPM and specfile can be downloaded from: Spec URL: http://developer.osdl.org/dev/openais/SRPM/openais.spec SRPM URL: http://developer.osdl.org/dev/openais/SRPM/openais-0.76-1.7.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|NEEDINFO_REPORTER --- Additional Comments From [EMAIL PROTECTED] 2006-06-13 11:49 EST --- This actually fails to build on x86_64: cc -shared -Wl,-soname,service_evs.lcrso evs.o -o service_evs.lcrso /usr/bin/ld: evs.o: relocation R_X86_64_32 against `evs_service_handler' can not be used when making a shared object; recompile with -fPIC evs.o: could not read symbols: Bad value collect2: ld returned 1 exit status make[1]: *** [service_evs.lcrso] Error 1 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: openais standards based cluster framework
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889
--- Additional Comments From [EMAIL PROTECTED] 2006-06-13 11:53 EST ---
(In reply to comment #54)
This actually fails to build on x86_64:
cc -shared -Wl,-soname,service_evs.lcrso evs.o -o service_evs.lcrso
/usr/bin/ld: evs.o: relocation R_X86_64_32 against `evs_service_handler' can
not
be used when making a shared object; recompile with -fPIC
evs.o: could not read symbols: Bad value
collect2: ld returned 1 exit status
make[1]: *** [service_evs.lcrso] Error 1
This should be fixable by changing:
CFLAGS=$(echo '%{optflags}' | sed -e 's/-O[0-9]*//') -O3 -DOPENAIS_LINUX
to:
CFLAGS=$(echo '%{optflags}' | sed -e 's/-O[0-9]*//') -O3 -DOPENAIS_LINUX -fPIC
I'll get an x86_64 box soon so I can find these things for myself...
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEEDINFO_REPORTER |ASSIGNED --- Additional Comments From [EMAIL PROTECTED] 2006-06-13 12:51 EST --- (In reply to comment #54) This actually fails to build on x86_64: cc -shared -Wl,-soname,service_evs.lcrso evs.o -o service_evs.lcrso /usr/bin/ld: evs.o: relocation R_X86_64_32 against `evs_service_handler' can not be used when making a shared object; recompile with -fPIC evs.o: could not read symbols: Bad value collect2: ld returned 1 exit status make[1]: *** [service_evs.lcrso] Error 1 Jesse, This actually should be fixed upstream and a patch has been submitted for the issue. The problem is that the Makefile uses something like CFLAGS += -fPIC. With the optflags, CFLAGS is overridden. The makefile should use the override keyword. I've created a new rpm with a patch that fixes this issue and buids on i386 and x86_64. I've also tested operation on x86_64 (not fc5, but ws4) and i386 (fc5). The changelog: * Tue Jun 13 2006 Steven Dake [EMAIL PROTECTED] - 0.76-1.8 - Add makefile override patch which fixes build with optflags on x86_64 arch. - Remove -DOPENAIS_LINUX from passed CFLAGS since it now works properly with makefile override patch. The new SRPM and specfile can be downloaded from: Spec URL: http://developer.osdl.org/dev/openais/SRPM/openais.spec SRPM URL: http://developer.osdl.org/dev/openais/SRPM/openais-0.76-1.8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 --- Additional Comments From [EMAIL PROTECTED] 2006-06-13 23:42 EST --- General approval from my end, if it's needed by the current Core cluster stuff. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 --- Additional Comments From [EMAIL PROTECTED] 2006-06-13 23:48 EST --- rpmlint has some things to say: E: openais non-readable /usr/sbin/ais-keygen 0700 E: openais non-standard-executable-perm /usr/sbin/ais-keygen 0700 W: openais non-standard-dir-in-usr libexec W: openais incoherent-subsys /etc/rc.d/init.d/openais $prog W: openais-devel conffile-without-noreplace-flag /etc/ld.so.conf.d/openais-i686.conf -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 --- Additional Comments From [EMAIL PROTECTED] 2006-06-12 10:35 EST --- What is the ais user used for? Nothing in the package is owned by this user, nor does the service run as that user. I don't understand this comment in the changelog: * Fri Jun 9 2006 Steven Dake [EMAIL PROTECTED] - 0.76-1.6 - Change condrestart to restart as specified in Fedora Wiki. What exactly has been changed, and why? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 --- Additional Comments From [EMAIL PROTECTED] 2006-06-12 14:02 EST --- Paul, Any application that wants to use the AIS must be user ais. Read SECURITY for a description of the IPC authentication and why the ais user is needed. The Fedora Wiki states that condrestart should not be done in post, but instead in postun. http://fedoraproject.org/wiki/ScriptletSnippets?highlight=%28snippets%29#head-24ef9d59bda6032df14cf3cb433ce4ef09348f69 It was previously done in post, as you suggested in comment #22. In comment #41 you suggest an alternative method to one line the postun step which is what is done in the new spec file. Regards -steve -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 --- Additional Comments From [EMAIL PROTECTED] 2006-06-12 14:09 EST --- (In reply to comment #47) Any application that wants to use the AIS must be user ais. Read SECURITY for a description of the IPC authentication and why the ais user is needed. OK, so there's nothing in this package that needs to be owned by that user, nor does the service need to run as that user - just trying to understand things. The Fedora Wiki states that condrestart should not be done in post, but instead in postun. http://fedoraproject.org/wiki/ScriptletSnippets?highlight=%28snippets%29#head-24ef9d59bda6032df14cf3cb433ce4ef09348f69 It was previously done in post, as you suggested in comment #22. In comment #41 you suggest an alternative method to one line the postun step which is what is done in the new spec file. Right, so the changelog entry should have been more like: - Move condrestart to %%postun instead of %%post rather than: - Change condrestart to restart as specified in Fedora Wiki Changing condrestart to restart would have been something very different, and very wrong, which is why I was confused about it. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 --- Additional Comments From [EMAIL PROTECTED] 2006-06-12 14:34 EST --- (In reply to comment #48) (In reply to comment #47) Any application that wants to use the AIS must be user ais. Read SECURITY for a description of the IPC authentication and why the ais user is needed. OK, so there's nothing in this package that needs to be owned by that user, nor does the service need to run as that user - just trying to understand things. Yes your understanding is correct. The Fedora Wiki states that condrestart should not be done in post, but instead in postun. http://fedoraproject.org/wiki/ScriptletSnippets?highlight=%28snippets%29#head-24ef9d59bda6032df14cf3cb433ce4ef09348f69 It was previously done in post, as you suggested in comment #22. In comment #41 you suggest an alternative method to one line the postun step which is what is done in the new spec file. Right, so the changelog entry should have been more like: - Move condrestart to %%postun instead of %%post yes sorry for causing confusion with the changelog. rather than: - Change condrestart to restart as specified in Fedora Wiki Changing condrestart to restart would have been something very different, and very wrong, which is why I was confused about it. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 --- Additional Comments From [EMAIL PROTECTED] 2006-06-09 02:50 EST --- (In reply to comment #37) The /sbin/service requirement isn't needed as initscripts get pulled in due to deps in the Exceptions list. The initscripts deps were there for the scripts (install-time requirements), not build dependencies. The exceptions list applies to build requirements. A system using a different init system (such as initng) might not use initscripts at all. An example showing an explicit dependency on /sbin/service can be found on the ScriptletSnippets wiki page: )http://fedoraproject.org/wiki/ScriptletSnippets?highlight=%28snippets%29#head-24ef9d59bda6032df14cf3cb433ce4ef09348f69 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 --- Additional Comments From [EMAIL PROTECTED] 2006-06-09 06:33 EST --- (In reply to comment #40) Thanks for the link about scriptlets. I haven't seen this link before. I believe I have the condrestart code wrong (according to the scriptlet docs). Do I need something like? %postun if [ $1 -ge 1 ]; then /sbin/service openais condrestart /dev/null 21 ||: fi the current code looks like: %post /sbin/chkconfig --add openais || : /sbin/service openais condrestart || : Yes, though could make it a one-liner: %postun [ $1 -ge 1 ] /sbin/service openais condrestart /dev/null || : /sbin/service would then be needed in Requires(preun) and Requires(postun) - don't forget to remove the condrestart from %post. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 --- Additional Comments From [EMAIL PROTECTED] 2006-06-09 10:37 EST --- Or to avoid needing service, you could just call /etc/init.d/openais condrestart Paul, thanks for the info regarding the (preun) (postun) requirements. I'm still not entirely convinced that you would be able to have a Fedora system sans some sort of init scripts. Personally I try to avoid using the 'service' tool and instead call the init script by hand, thus avoiding any confusion on needing initscripts. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: openais standards based cluster framework
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889
--- Additional Comments From [EMAIL PROTECTED] 2006-06-09 10:57 EST ---
(In reply to comment #42)
Or to avoid needing service, you could just call /etc/init.d/openais
condrestart
Paul, thanks for the info regarding the (preun) (postun) requirements. I'm
still not entirely convinced that you would be able to have a Fedora system
sans
some sort of init scripts. Personally I try to avoid using the 'service' tool
and instead call the init script by hand, thus avoiding any confusion on
needing
initscripts.
Good point, though I wouldn't hardcode the initscript pathname, particularly not
using the deprecated /etc/init.d location; since the package installs the
initscript into %{_initrddir}, it should run it from there too:
%{_initrddir}/openais condrestart
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: openais standards based cluster framework
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889
--- Additional Comments From [EMAIL PROTECTED] 2006-06-09 13:27 EST ---
Ah right, %{_initrddir} would be proper.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 --- Additional Comments From [EMAIL PROTECTED] 2006-06-09 14:55 EST --- The changelog for this new SRPM is: * Fri Jun 9 2006 Steven Dake [EMAIL PROTECTED] - 0.76-1.6 - Change condrestart to restart as specified in Fedora Wiki. - Call initscript directly as suggested by Jesse. The new SRPM and specfile can be downloaded from: Spec URL: http://developer.osdl.org/dev/openais/SRPM/openais.spec SRPM URL: http://developer.osdl.org/dev/openais/SRPM/openais-0.76-1.6.src.rpm I have tested that the upgrade actually restarts the daemon and it seems to work. Thanks for the suggestion of the one liner Paul. I also made Jesse's suggestion of removing /sbin/service entirely from the specfile. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 --- Additional Comments From [EMAIL PROTECTED] 2006-06-08 17:57 EST --- I'm getting 403 forbidden on the srpm. Buildroot is still wrong. The /sbin/service requirement isn't needed as initscripts get pulled in due to deps in the Exceptions list. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2006-06-08 21:11 EST --- The 403 problem has been resolved. Thank you for pointing out the buiroot error. I copied the original package from device-mapper which appears to have this error. The changelog for this new SRPM is: * Thu Jun 8 2006 Steven dake [EMAIL PROTECTED] - 0.76-1.5 - Changed BuildRoot tag to match convention specified in Fedora Wiki. - Removed /sbin/services dependency since it is pulled in from init packages. The new SRPM and specfile can be downloaded from: Spec URL: http://developer.osdl.org/dev/openais/SRPM/openais.spec SRPM URL: http://developer.osdl.org/dev/openais/SRPM/openais-0.76-1.5.src.rpm Thanks in advance for reviewing the updates. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 --- Additional Comments From [EMAIL PROTECTED] 2006-06-06 03:01 EST --- Why does this UID have to be static? Is there data, owned by this user, that needs to be shared over the network? Should any of the files in this package be owned by this user? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 --- Additional Comments From [EMAIL PROTECTED] 2006-06-05 11:57 EST --- yes check out the new source rpm I have added the functionality. Unfortunately I am not sure which UID to use. Is there a UID registry maintained for fedora? There probably is but I don't know where (Bill Nottingham will probably know). However, unless there is a requirement for the account to have the same UID across different machines on a network (e.g. if they required shared access to the same files using NFS), you could just use the -r option of useradd to create a systen account and not worry about the exact UID. Reserve a uid in the uidgid registry (part of the setup package). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2006-06-05 15:13 EST --- Added Phil as CC for review of new uidgid file. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 --- Additional Comments From [EMAIL PROTECTED] 2006-06-05 15:21 EST --- Created an attachment (id=130534) -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=130534action=view) a patch to modify the uidgid registry to add the core package openais this should be merged into the setup package. Phil will you do this or should I? Thanks. -steve -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 --- Additional Comments From [EMAIL PROTECTED] 2006-06-05 16:19 EST --- As per Paul's suggestions, I have made the following changes: * Mon Jun 5 2006 Steven Dake [EMAIL PROTECTED] - 0.76-1.3 - Allocated uid 102 from setup package for user add operation. - Added || : to initscript stuff so initscript bugs dont cause RPM transaction failures as per Paul's suggestion. - Added /sbin/services to post requires as per Paul's suggestion. - Removed ldconfig from the requires post for the main package as per Paul's suggestion. - Changed post devel scriptlet action as per Paul's suggestion. The new SRPM and specfile can be downloaded from: Spec URL: http://developer.osdl.org/dev/openais/SRPM/openais.spec SRPM URL: http://developer.osdl.org/dev/openais/SRPM/openais-0.76-1.3.src.rpm Thanks again Paul regards -steve -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 --- Additional Comments From [EMAIL PROTECTED] 2006-06-05 16:24 EST --- Wit. gkrellm aside (that's a bug) all system UIDs for core should be 100. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 --- Additional Comments From [EMAIL PROTECTED] 2006-05-26 02:50 EST --- Paul, Thanks for all of your wonderful comments. There is a new srpm and specfile available below: Spec URL: http://developer.osdl.org/dev/openais/SRPM/openais.spec SRPM URL: http://developer.osdl.org/dev/openais/SRPM/openais-0.76-1.0.src.rpm I have tested that the make install part works on x86_64 and i386 and that on fedora core 5 the openais package runs properly from the init script. Would you provide one last sanity check? Thanks -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 --- Additional Comments From [EMAIL PROTECTED] 2006-05-26 04:51 EST --- (In reply to comment #18) - Still shipping static libs - Packages still contain unowned dirs - Compilation still doesn't honor optflags Without having looked into details, packaging of dynamic libs/plugins seems to be way off from any common conventions on Linux. Thank you for your comments. Regarding issue #1: Based upon feedback with the user community there are many people which would like to link statically to the libraries. That is one of the motivations of the project being BSD instead of lgpl. I see two choices. I can either a) add the above text as a comment in the specfile or b) remove the static libs entirely from the rpm. I suppose option B has the effect of people then complaining that the openais package doesn't have the static libs. Rather more important for me is inclusion of the package in Fedora Core 6, so if static libs are non-negotiable they can be removed and I'll deal with the complaining from the user community. Regarding issue #2: I am not sure which unowned dirs I am missing. Would you be kind enough point them out to me? Thanks. Regarding issue #3: Somehow I uploaded the wrong specfile to the site. I did fix the optflags issue as per Paul's suggestion, and checked the specfile on my laptop has this change. I'll upload another tomorrow with the unowned dirs change (if you could point out the unowned dirs). rpmlint doesn't seem to complain about this. Regarding issue #4: Could you please provide an argument for packaging conventions being way off from common conventions in Linux. What exactly is wrong? I need to understand what is unsuitable about the packaging methods so they can be fixed (or I can convince you otherwise). I'll take a stab anyway: The packaging of the dynamic libs as files libSaAmf.so.1.0 as an example is required by the SA Forum specification. We try to match the specification as closely as possible for code portability between implementations. Hence using libsaamf.so.1.0 is not suitable. First it would not be compliant with the specification, second code portability would be reduced. I know the naming is obnoxious. The libraries should go into a separate library (and this is indeed the default of upstream) so that different SA Forum implementations may be tried on the same system. Since the filenames of the libraries are defined in the spec, if we installed to /usr/lib or /usr/lib64, it would prevent people from installing alternative implementations. The plugins (the .lcrso files) are a mechanism for exporting interfaces and supporting Live Component Replacement ie: replacing a plugin that is already loaded with a replacement component without service interruption. This is not really a plugin and a shared object doesn't get the job done. It is more of a complete component providing a specific service (for example, we have an object database component which is never used directly by any APIs). If you have a suggestion as to where these should live rather then /usr/lib/lcrso or /usr/lib64/lcrso, I'd entertain getting this changed upstream. As is, we intend to produce various other lcrso components for use by various projects (and our lcrso's are totally reusable). Regards -steve -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 --- Additional Comments From [EMAIL PROTECTED] 2006-05-26 22:31 EST --- (In reply to comment #20) (In reply to comment #19) (In reply to comment #18) - Still shipping static libs - Packages still contain unowned dirs - Compilation still doesn't honor optflags Without having looked into details, packaging of dynamic libs/plugins seems to be way off from any common conventions on Linux. Thank you for your comments. snip Thank you for your comments and suggestions. I have modified the specfile and project as follows: * Indeed this time I believe I have the unowned dirs problem solved. * The static libraries have been removed from the RPM. * The devel libraries have been renamed library.so.1.0.0 with links from library.so and library.so.1 * The lcrso files have been moved to /usr/libexec/lcrso as this was suggested as a better location for the files. * optflags is now honored * all warnings related to optflags have been resolved and merged upstream The lcrso files (part of the main package) do not need a version number. They are not meant to be processed by ldconfig or other system utilities. The LCRSO system handles all versioning since it must handle live replacement while a process is active. Please find the new files at the following location: Spec URL: http://developer.osdl.org/dev/openais/SRPM/openais.spec SRPM URL: http://developer.osdl.org/dev/openais/SRPM/openais-0.76-1.1.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 --- Additional Comments From [EMAIL PROTECTED] 2006-05-24 08:09 EST --- Created an attachment (id=129912) -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=129912action=view) New spec file promised in Comment #11 rpmlint output from building with this spec: E: openais non-readable /usr/sbin/ais-keygen 0700 E: openais non-standard-executable-perm /usr/sbin/ais-keygen 0700 W: openais incoherent-subsys /etc/rc.d/init.d/openais $prog The first two are unavoidable due to the permissions having to be restrictive. The last is I believe unavoidable if the initscript name doesn't match the executable name (as is the case here) and you want to be able to use the standard status function. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 --- Additional Comments From [EMAIL PROTECTED] 2006-05-24 17:05 EST --- Paul Thanks for all the help!!! As you can probably tell, I am not expert in RPM packages.. The openais project doesn't allow CFLAGS to be overridden from Make. I think this is an error upstream and will work to get it resolved and a new release issued. I'll also get your other patches merged upstream. Thanks for the patches. The problem you are having with the optflags is that -DOPENAIS_LINUX is not being defined. A few questions about optflags... First how do I use rpmbuild to set the optflags like you have done so I can test out the package build? Second, The code should compile with -O3 for performance reasons. But if optflags is set to -O2 or less, how do I resolve this in the Makefiles? Here is what I am thinking. In the toplevel openais Makefile.inc, I will only add to the CFLAGS variable instead of ever setting it directly. But this brings up the issue of a compile with -O2 and -O3 both specified in the command line. Your expterise would be helpful here. Thanks! -steve -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2006-05-23 16:10 EST --- Added Chris as CC. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: openais standards based cluster framework
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Additional Comments From [EMAIL PROTECTED] 2006-05-23 16:17 EST ---
A few initial comments:
* omit static libs. If there's good reason to include, please add comment in
specfile to justify inclusion
* IMO, not enough docs here to warrant a separate package, but those bits
where appropriate either in main pkg or -devel.
* Why are libs placed in %{_libdir}/openais/ which forces use of ld.so.conf.d/
instead of simply putting in %{_libdir}?
* use %%{_initrddir} macro instead of hard-coding /etc/rc.d/init.d
* There seem to be %{_libdir}/openais/lib*.so symlinks not packaged
(in -devel?)
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: openais standards based cluster framework
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889
--- Additional Comments From [EMAIL PROTECTED] 2006-05-23 16:19 EST ---
*Usually* pkgs that include shared libs include in main pkg (something like):
%{libdir}/lib*.so.*
and in -devel:
%{_libdir}/lib*.so
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 --- Additional Comments From [EMAIL PROTECTED] 2006-05-23 16:57 EST --- Thanks Rex for your review. I've updated the spec file to address these problems and put the patch here http://developer.osdl.org:/dev/openais/SRPM/fix-unowned-dirs.patch Would you review the patch and see if it resolves the problem? I have also updated the spec file and SRPM on the web at the above addresses. Regards -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 --- Additional Comments From [EMAIL PROTECTED] 2006-05-23 17:24 EST --- Addressing comment #2 point #3 on the topic of location of library dirs: Upstream places the files in the separate openais directory. The reason this is done is because it may be that people want to install two competing SA Forum AIS standard implementations (this is what openais provides) on their Fedora system at once. This would cause collisions if they both used /usr/lib allowing only one implementation at a time. The standard specifies the name of the shared objects. We could declare that only openais could be installed on a FC6 system, but I think we would be more friendly if we allowed other vendors to operate on Fedora Core 6 as well. On the topic of ld.so.conf.d, the project uses a component model to load services (that is what those lcrso files are). Upstream doesn't place the lcrso files in the /usr/lib dir since they are not generally useful shared libraries. Either way, ld.so.conf.d must be modified as this is how the component loader finds its components. First it scans the cwd, then /usr/lib then /usr/lib64, then /etc/ld.so.conf (which may have include lines which are then scanned). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 --- Additional Comments From [EMAIL PROTECTED] 2006-05-23 17:29 EST --- Addressing comment #3: Do you mean by this comment that I should not list out each individual shared object file, but instead use wildcards? It appears from the many examples I found that each file is listed separately but I could remove all of the separate filenames and then use the wildcard lines. I have no preference either way, although it is somewhat helpful for the package maintainer (me) if the specfile were to complain during build because of a shared object additiion/removal. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192889] Review Request: openais standards based cluster framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 --- Additional Comments From [EMAIL PROTECTED] 2006-05-23 23:36 EST --- (In reply to comment #7) Addressing comment #2 point #2 on the topic of documentation, we intend in the community to add about 75-150 man pages in the coming months. Is this suitable for a separate docs package? Nope. man pages should always be part of the package, which implements what they document. I.e. in general, API docs should be part of *-devel packages, while user application man pages would be part of non-devel packages. A separate *-doc packages would be useful for other (non-man, non-info) documentation, e.g. html formated books. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
