[Bug 201149] Review Request: Cherokee Flexible WebServer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Cherokee Flexible WebServer Alias: Cherokee https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201149 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |CLOSED Resolution||NOTABUG OtherBugsDependingO|177841 |201449 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2007-06-08 23:56 EST --- Manuel: I am going to close this now. If you want to continue this submission feel free to re-open this request, or file a new one. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201149] Review Request: Cherokee Flexible WebServer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Cherokee Flexible WebServer Alias: Cherokee https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201149 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] OtherBugsDependingO|163776 | nThis|| --- Additional Comments From [EMAIL PROTECTED] 2007-06-01 23:34 EST --- Hey Manuel: Do you still wish to submit this package for review? If so, could you look at addressing the points in comments 13, 14, 15 and uploading a current spec and src.rpm? If I don't hear from you in a week I will go ahead and close this request out. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201149] Review Request: Cherokee Flexible WebServer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Cherokee Flexible WebServer Alias: Cherokee https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201149 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2006-09-21 17:37 EST --- (I'm not a reviewer but just helping out) One of the Fedora Extras guidelines and requirements is to run rpmlint on each package - I ran it on your SRPM and it produced: *** output: *** W: cherokee non-standard-group Productivity/Networking/Web/Servers The value of the Group tag in the package is not valid. Valid groups are: Amusements/Games, Amusements/Graphics, Applications/Archiving, Applications/Communications, Applications/Databases, Applications/Editors, Applications/Emulators, Applications/Engineering, Applications/File, Applications/Internet, Applications/Multimedia, Applications/Productivity, Applications/Publishing, Applications/System, Applications/Text, Development/Debug, Development/Debuggers, Development/Languages, Development/Libraries, Development/System, Development/Tools, Documentation, System Environment/Base, System Environment/Daemons, System Environment/Kernel, System Environment/Libraries, System Environment/Shells, User Interface/Desktops, User Interface/X, User Interface/X Hardware Support. E: cherokee no-changelogname-tag There is no %changelog tag in your spec file. To insert it, just insert a '%changelog' in your spec file and rebuild it. E: cherokee unknown-key GPG#6b9d6523 The package was signed, but with an unknown key. See the rpm --import option for more information. E: cherokee no-cleaning-of-buildroot You should clean $RPM_BUILD_ROOT in the %clean section and just after the beginning of %install section. Use rm -Rf $RPM_BUILD_ROOT. *** end output Don't worry about the GPG warning, it's just because it's signed with a key rpmlint doesn't know. I don't think you need to worry about the invalid group, although I would make it one of the 'standard' ones just for the sake of getting rid of the warning. The E:'s you should look into, especially the changelog. Another requirement is to have a changelog entry for each release you push, so that's a good one to have! Even if all it says is something like initial build, that's OK. As long as there's an entry for each version you make. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201149] Review Request: Cherokee Flexible WebServer
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: Cherokee Flexible WebServer
Alias: Cherokee
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201149
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Additional Comments From [EMAIL PROTECTED] 2006-09-21 18:45 EST ---
I just took a look into http://manuel.todo-linux.com/cherokee/spec/cherokee.spec
and there is a lot that should be fixed. Please read
http://fedoraproject.org/wiki/Packaging/Guidelines
%configure already sets these options:
--prefix=%{_prefix} \
--sysconfdir=%{_sysconfdir} \
--mandir=%{_mandir} \
--sbindir=%{_sbindir} \
So they are not needed here. (see rpm --eval %configure)
%configure also sets CFLAGS=$RPM_OPT_FLAGS
So you should set CFLAGS=-O0 -g3 before the invocation of %configure to make
sure that $RPM_OPT_FLAGS are honourd. Do you really need debug level 3 and no
optimization?
Why are these commands in %post?
ln -s %{_sysconfdir}/cherokee/sites-available/default \
%{_sysconfdir}/cherokee/sites-enabled/default
mkdir -p /home/httpd
The COPYING file is missing
There is an unneeded Source:, since there is already Source0:
Why is there still a Docdir Tag?
Why don't you use %{?dist} in the release?
The %changelog is still empty.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201149] Review Request: Cherokee Flexible WebServer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Cherokee Flexible WebServer Alias: Cherokee https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201149 --- Additional Comments From [EMAIL PROTECTED] 2006-09-02 14:35 EST --- Which is the most recent spec and/or srpm? As a reviewer I much prefer a full spec or srpm to download either an updated attachment or external URL. Your comment has make CFLAGS=-O0 -g3 commented out but the attached srpm does not. If at all possible I don't want to have to apply spec patches before reviewing. Why do you redefine Docdir? If it is a legacy from the existing spec you should be able to remove it. Please make Source0 point to a URL where the tarball can be downloaded. Build fails in %prep at the gzip line: gzip: %SOURCE.gz: No such file or directory %setup macro makes the gzip line after it redundant anyway, the setup macro should decompress sources. (At least it does when your source has the Source0 tag.) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201149] Review Request: Cherokee Flexible WebServer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Cherokee Flexible WebServer Alias: Cherokee https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201149 --- Additional Comments From [EMAIL PROTECTED] 2006-09-02 14:57 EST --- (In reply to comment #11) Which is the most recent spec and/or srpm? As a reviewer I much prefer a full spec or srpm to download either an updated attachment or external URL. The latest spec file is here: http://manuel.todo-linux.com/cherokee/spec/cherokee.spec And SRPM is also at: http://manuel.todo-linux.com/cherokee/srpm/cherokee-0.5.4-22.1.src.rpm Your comment has make CFLAGS=-O0 -g3 commented out but the attached srpm does not. You're right. After some talkings with other cherokee developers, we would like to use CFLAGS, because we think that it's a good idea to compile Cherokee with debug info. So I have delete the comment therefore, make CFLAGS is alive again. If at all possible I don't want to have to apply spec patches before reviewing. Roger. Why do you redefine Docdir? If it is a legacy from the existing spec you should be able to remove it. Ok I'm going to remove it. Please make Source0 point to a URL where the tarball can be downloaded. Done Thank you very much John. I tought that this ticket would die because of that, I've been working with this spec and no new versions have been uploaded to my server. Hope we can work hard to be successful with this package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201149] Review Request: Cherokee Flexible WebServer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Cherokee Flexible WebServer Alias: Cherokee https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201149 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201149] Review Request: Cherokee Flexible WebServer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Cherokee Flexible WebServer Alias: Cherokee https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201149 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201149] Review Request: Cherokee Flexible WebServer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Cherokee Flexible WebServer Alias: Cherokee https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201149 --- Additional Comments From [EMAIL PROTECTED] 2006-08-16 02:59 EST --- Created an attachment (id=134280) -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=134280action=view) New SRPM made after John Patrick told me some errors on my spec file -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201149] Review Request: Cherokee Flexible WebServer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Cherokee Flexible WebServer Alias: Cherokee https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201149 --- Additional Comments From [EMAIL PROTECTED] 2006-08-16 03:00 EST --- Created an attachment (id=134281) -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=134281action=view) New spec file for Cherokee -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201149] Review Request: Cherokee Flexible WebServer
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: Cherokee Flexible WebServer
Alias: Cherokee
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201149
--- Additional Comments From [EMAIL PROTECTED] 2006-08-16 03:01 EST ---
(From update of attachment 134281)
# Cherokee
# 2006 Alvaro Lopez Ortega
Name: cherokee
Version:0.5.4
Release:1
License:GPL
BuildRoot: %{_tmppath}/%{name}-%{version}-build
Docdir: %{_datadir}/doc
Source: %{name}-%{version}.tar.gz
Summary:Flexible and Fast web server
Group: Productivity/Networking/Web/Servers
URL:http://www.0x50.org
BuildRequires: bison
%description
Cherokee is a very fast, flexible and easy to configure Web Server.
It supports the widespread technologies nowadays: FastCGI, SCGI, PHP,
CGI, TLS and SSL encrypted connections, Virtual hosts, Authentication,
on the fly encoding, Apache compatible log files, and much more.
%prep
%setup -q
%build
CFLAGS=$RPM_OPT_FLAGS \
./configure --prefix=%{_prefix} \
--sysconfdir=%{_sysconfdir} \
--mandir=%{_mandir} \
--sbindir=%{_sbindir} \
--with-wwwroot=/home/httpd/ \
--enable-pthreads
make CFLAGS=-O0 -g3
%install
make install DESTDIR=$RPM_BUILD_ROOT
#rm $RPM_BUILD_ROOT/etc/cherokee/sites-enabled/default
%clean
rm -rf $RPM_BUILD_ROOT
%post
/sbin/ldconfig
ln -s %{_sysconfdir}/cherokee/sites-available/default \
%{_sysconfdir}/cherokee/sites-enabled/default
mkdir -p /home/httpd
%postun
/sbin/ldconfig
%files
%{_mandir}/*
%{_bindir}/*
%{_libdir}/*
%{_datadir}/*
%{_sbindir}/*
%{_includedir}/*
%{_sysconfdir}/*
/home/httpd/*
%changelog
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201149] Review Request: Cherokee Flexible WebServer
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: Cherokee Flexible WebServer
Alias: Cherokee
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201149
--- Additional Comments From [EMAIL PROTECTED] 2006-08-16 03:11 EST ---
(In reply to comment #7)
CFLAGS=$RPM_OPT_FLAGS \
./configure --prefix=%{_prefix} \
--sysconfdir=%{_sysconfdir} \
--mandir=%{_mandir} \
--sbindir=%{_sbindir} \
--with-wwwroot=/home/httpd/ \
--enable-pthreads
Any particular reason for not using %configure?
Also, here you are not passing --includedir, nevertheless you are using it in
%files.
make CFLAGS=-O0 -g3
Why this? Above you are exporting CFLAGS=$RPM_OPT_FLAGS, here you are
overriding it with something compatible again?
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201149] Review Request: Cherokee Flexible WebServer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Cherokee Flexible WebServer Alias: Cherokee https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201149 --- Additional Comments From [EMAIL PROTECTED] 2006-08-16 03:12 EST --- Typo: s/compatible/incompatible -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201149] Review Request: Cherokee Flexible WebServer
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: Cherokee Flexible WebServer
Alias: Cherokee
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201149
--- Additional Comments From [EMAIL PROTECTED] 2006-08-16 03:45 EST ---
(In reply to comment #8)
(In reply to comment #7)
CFLAGS=$RPM_OPT_FLAGS \
./configure --prefix=%{_prefix} \
--sysconfdir=%{_sysconfdir} \
--mandir=%{_mandir} \
--sbindir=%{_sbindir} \
--with-wwwroot=/home/httpd/ \
--enable-pthreads
Any particular reason for not using %configure?
Also, here you are not passing --includedir, nevertheless you are using it in
%files.
make CFLAGS=-O0 -g3
Why this? Above you are exporting CFLAGS=$RPM_OPT_FLAGS, here you are
overriding it with something compatible again?
You're right, I've corrected it, here the spec file after those new points of
view.
Thank you very much, Ralf.
%prep
%setup -q
%build
CFLAGS=$RPM_OPT_FLAGS \
%configure --prefix=%{_prefix} \
--sysconfdir=%{_sysconfdir} \
--mandir=%{_mandir} \
--sbindir=%{_sbindir} \
--with-wwwroot=/home/httpd/ \
--enable-pthreads
#make CFLAGS=-O0 -g3
%install
make install DESTDIR=$RPM_BUILD_ROOT
#rm $RPM_BUILD_ROOT/etc/cherokee/sites-enabled/default
%clean
rm -rf $RPM_BUILD_ROOT
%post
/sbin/ldconfig
ln -s %{_sysconfdir}/cherokee/sites-available/default \
%{_sysconfdir}/cherokee/sites-enabled/default
mkdir -p /home/httpd
%postun
/sbin/ldconfig
%files
%{_mandir}/*
%{_bindir}/*
%{_libdir}/*
%{_datadir}/*
%{_sbindir}/*
%{_includedir}/*
%{_sysconfdir}/*
/home/httpd/*
%changelog
*2006-08-16 Manuel Arostegui Ramirez [EMAIL PROTECTED]
-Misc changes on spec file in order to make it much more polished. Thanks John
and Ralf
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201149] Review Request: Cherokee Flexible WebServer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Cherokee Flexible WebServer Alias: Cherokee https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201149 [EMAIL PROTECTED] changed: What|Removed |Added Summary|Review Request: Cherokee |Review Request: Cherokee ||Flexible WebServer -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201149] Review Request: Cherokee Flexible WebServer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Cherokee Flexible WebServer Alias: Cherokee https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201149 --- Additional Comments From [EMAIL PROTECTED] 2006-08-15 05:47 EST --- I've corrected two oversight on the spec file, for instance, I forgot : after BuildRequires. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201149] Review Request: Cherokee Flexible WebServer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Cherokee Flexible WebServer Alias: Cherokee https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201149 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||177841 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
