A new config/cmdline option

2019-02-09 Thread Jan Tosovsky 
Dear All,

there is a proposal to enhanced painting of table borders to avoid visual
inconsistencies in some renderers (Acrobat Reader, Chrome):
https://issues.apache.org/jira/browse/FOP-2536

That technique renders another set of shapes over the existing ones. Not
everyone wants this as a default behaviour. After applying the patch it can
be activated via RendererOption 'overpaint-table-borders'. It means it can
be set programmatically, but not via configuration file or cmdline options.

I personally do not need this as a cmdline switch, but having this option in
the configuration file is IMHO a must for general audience.

So the questions:
(1) option name (is boolean 'overpaint-table-borders' Ok or something else
should be prefered, e.g. 'table-border-rendering-mode' with the set of
String values, initially 'standard' and 'overpaint')

(2) If cmdline switch would be useful, what the name should be used

Thanks,

Jan

Project pages - updating obsolete content

2019-02-09 Thread Jan Tosovsky 
Dear All,

I've found a mention of Avalon in the 'Using a Configuration File' section: 
https://xmlgraphics.apache.org/fop/trunk/embedding.html#config-internal

On compliance page https://xmlgraphics.apache.org/fop/compliance.html we can
make green:
§6.13.2 change-bar-begin
§6.13.3 change-bar-end
§7.30.1 change-bar-class
§7.30.2 change-bar-color
§7.30.3 change-bar-offset
§7.30.4 change-bar-placement
§7.30.5 change-bar-style
§7.30.6 change-bar-width

Jan

RE: UserAgent's Renderer Options purpose

2019-02-09 Thread Jan Tosovsky 
On 2019-01-23 Jan Tosovsky wrote:
> On 2018-06-23 Jan Tosovsky wrote:
> >
> > is there any relation of RendererOptions to the FOP user config?
> > Looking into the related code RendererOptions seems to be initialized 
> > as an empty map, which can be later used as a temporary storage. 
> > I can't see any relation to the config.
> >
> > So if some feature is activated based on RendererOptions, does it mean
it
> > cannot be activated by config?
> >
> > How can then I activate "overpaint-table-borders" without writing custom
> > FOP wrapper?
> 
> I'd like to refresh this topic related to
> https://issues.apache.org/jira/browse/FOP-2536
> 
> That feature is activated by a dedicated RendererOptions entry. This can
be
> done via code, but AFAIK not via config. It means it cannot be used when
> calling FOP from cmdline. And it is also difficult to test.
> 

I've inspected the commandline parsing code and I can answer myself: Some
commandline options are put into RendererOptions map, e.g.
} else if (args[i].equals("-a")) {
this.renderingOptions.put(Accessibility.ACCESSIBILITY,
Boolean.TRUE);

So RendererOptions are not related to the config. They can, however,
override some config values.

Jan