Re: [fossil-users] Lots of web interface changes

2017-12-14 Thread Richard Hipp
On 12/14/17, John P. Rouillard  wrote:
>>
>>.timelineModernCell[id], .timelineColumnarCell[id], .timelineDetailCell[id]
>> {
>>background-color: #333;
>>}
>

You picked up an extra space character on the copy/paste, in between
the last "id" and the following "]".  You can clearly see this space
if you look at https://rouilj.dynamic-dns.net/fossil/roundup_sysadmin/style.css

Remove that extra space, and I think it should work a lot better for you.
-- 
D. Richard Hipp
d...@sqlite.org
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] Lots of web interface changes

2017-12-14 Thread Richard Hipp
On 12/14/17, John P. Rouillard  wrote:
>
> I use a dark theme with white text. In release:
>
>Fossil version 2.5 [dc7d0a2e27] 2017-12-14 18:03:01
>
> the background for the timeline detail is very light. This makes it
> difficult to view the white text.

Please try adding the following rule to your CSS:

.timelineModernCell[id], .timelineColumnarCell[id], .timelineDetailCell[id] {
background-color: #333;
}
-- 
D. Richard Hipp
d...@sqlite.org
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] Lots of web interface changes

2017-12-14 Thread John P. Rouillard
Hello Richard:

In message

Re: [fossil-users] Fossil vs. GitHub

2017-12-14 Thread Ron W
On Thu, Dec 14, 2017 at 7:00 AM, 
wrote:
>
> Date: Wed, 13 Dec 2017 18:04:41 -0600 (CST)
> From: Roy Keene 
> Subject: Re: [fossil-users] Fossil vs. GitHub
>
> One thing I often wish Fossil did was show other things (tickets, wiki
> pages) that reference tickets rather than just checkins -- I often have a
> mess of tickets that refer to other tickets and no place to generate a
> list of them, or reverse them.


I'm not sure how the TH1 regexp command works, but it might be possible to
at least find other tickets that reference a specific ticket using a
combination of SQL in Fossil's ticket report subsystem and TH1+SQL in the
new and edit ticket scripts in the ticket configuration.

In the ticket configuration, add a new table to the ticket schema to that
has 2 columns: "referree" and "referrer"..

In the new and edit ticket TH1 scripts, enhance the submit handling to find
artifact references using the regexp command with the regex "\[[0-9a-f]\]".
For each match, add (or update) a row to the new table with referree = ID
found and referrer = ID of current ticket.

Of course, this assumes that the ticket TH1 scripts can access the ID of
the current ticket and that the TH1 regexp command can be used to get a
list of locations of regex matches.

Maybe some Javascript can extract the ticket ID from the URL and supply
that as a hidden field back to the TH1 scripts.

If regexp doesn't work as needed, may be possible to use "string first" and
"string range" to find and extract artifact IDs.

As for wiki pages, maybe the "webpage_notify" hook can be used to find
artifact references.
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] tangent vs. wyoung on recent commti

2017-12-14 Thread Stephan Beal
On Thu, Dec 14, 2017 at 9:38 PM, Ron W  wrote:

> Local, command line usage seems to grant the command line user full
> permissions as long as the user has RW access to the repo file, itself.
>
> Right now, I can't test this to confirm this behavior.
>

That's correct: all CLI commands simply bypass (i.e. don't check)
permissions. Only client/server commands check permissions.

-- 
- stephan beal
http://wanderinghorse.net/home/stephan/
"Freedom is sloppy. But since tyranny's the only guaranteed byproduct of
those who insist on a perfect world, freedom will have to do." -- Bigby Wolf
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] tangent vs. wyoung on recent commti

2017-12-14 Thread Ron W
On Thu, Dec 14, 2017 at 2:31 PM, 
wrote:
>
> Date: Thu, 14 Dec 2017 12:31:21 -0700
> From: Scott Robison 
> Subject: Re: [fossil-users] tangent vs. wyoung on recent commti
>
> I'd bet that you can commit as anyone and push it if you have that access.
> You probably wouldn't keep that access for long, though.
>

As I understand it, Fossil's "check in" permission really means "push"
permission. That is, whether a repo will accept a push from another repo
under that user name.

Local, command line usage seems to grant the command line user full
permissions as long as the user has RW access to the repo file, itself.

Right now, I can't test this to confirm this behavior.
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] tangent vs. wyoung on recent commti

2017-12-14 Thread Scott Robison
I'd bet that you can commit as anyone and push it if you have that access.
You probably wouldn't keep that access for long, though.

On Dec 14, 2017 12:13 PM, "Warren Young"  wrote:

> On Dec 14, 2017, at 10:19 AM, jungle Boogie 
> wrote:
> >
> > So Warren edited a file at the same exact time as tangent?
>
> Fossil arguably has a bug here, where if you check a change in as local
> user name “tangent”, as I do here, then *later* do a “fossil sync” to a URL
> with a user name, some bit of the local on-disk state remembers that you
> originally cloned the repo as tangent and makes your changes under that
> name.  Then when you go to push to the remote repo, it uses your remote
> user name and password credentials, but the changes are tagged with your
> local user name.
>
> I think Fossil ought to catch this kind of thing and either silently
> rewrite the user name or force some local fix-up it can’t be done
> automatically for some reason.
>
> This kind of thing happens when a previous outsider to a project is later
> granted privileges, but under a different name.
>
> I assume Fossil is the way it currently is because:
>
> a) many people use the same user name everywhere
> b) it’s a rare occurrence; and
> c) it’s easy to fix when it happens
>
> But even knowing all of this, it’s happened to me twice with the
> fossil-scm.org repository, once from two different machines.  The first
> was a pure surprise to me on my first checkin to fossil-scm.org, and the
> second happened to me yesterday because I missed one client machine when I
> went around and closed, re-cloned and re-opened the fossil-scm.org
> repository to make each one forget about user tangent.
>
> I classify this as a bug because it could be used for an impersonation
> attack.  I expect that it would not allow me to check changes in as drh
> simply by creating a local drh user, since that’s a known user and I cannot
> produce drh’s password, but it certainly will let me check changes in as
> billgates.
> ___
> fossil-users mailing list
> fossil-users@lists.fossil-scm.org
> http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
>
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] tangent vs. wyoung on recent commti

2017-12-14 Thread Warren Young
On Dec 14, 2017, at 10:19 AM, jungle Boogie  wrote:
> 
> So Warren edited a file at the same exact time as tangent?

Fossil arguably has a bug here, where if you check a change in as local user 
name “tangent”, as I do here, then *later* do a “fossil sync” to a URL with a 
user name, some bit of the local on-disk state remembers that you originally 
cloned the repo as tangent and makes your changes under that name.  Then when 
you go to push to the remote repo, it uses your remote user name and password 
credentials, but the changes are tagged with your local user name.

I think Fossil ought to catch this kind of thing and either silently rewrite 
the user name or force some local fix-up it can’t be done automatically for 
some reason.

This kind of thing happens when a previous outsider to a project is later 
granted privileges, but under a different name.

I assume Fossil is the way it currently is because:

a) many people use the same user name everywhere
b) it’s a rare occurrence; and
c) it’s easy to fix when it happens

But even knowing all of this, it’s happened to me twice with the fossil-scm.org 
repository, once from two different machines.  The first was a pure surprise to 
me on my first checkin to fossil-scm.org, and the second happened to me 
yesterday because I missed one client machine when I went around and closed, 
re-cloned and re-opened the fossil-scm.org repository to make each one forget 
about user tangent.

I classify this as a bug because it could be used for an impersonation attack.  
I expect that it would not allow me to check changes in as drh simply by 
creating a local drh user, since that’s a known user and I cannot produce drh’s 
password, but it certainly will let me check changes in as billgates.
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] tangent vs. wyoung on recent commti

2017-12-14 Thread jungle Boogie
On 14 December 2017 at 10:07, Richard Hipp  wrote:
> On 12/14/17, jungle Boogie  wrote:
>> Hi All,
>>
>> This commit caught my eye:
>> http://fossil-scm.org/index.html/info/ec059849f5c73a43
>>
>> User & Date:wyoung on 2017-12-13 21:37:20
>> Original User & Date:tangent on 2017-12-13 21:37:20
>>
>> So Warren edited a file at the same exact time as tangent?
>>
>
> No.  The commit was originally by a user named "tangent" at the time
> shown.  Then a tag was added
> (http://fossil-scm.org/index.html/info/80f1e8a521518104) that changed
> the username to "wyoung".
>
> I'm guessing that "tangent" is some local username on Warren's
> desktop.  After he committed, he noticed that the commit picked up the
> wrong username and so he changed it to his "public" username "wyoung".
> I don't have any issues with this.  In fact, I think it was the right
> thing to do.

Ah, that's probably what it is. I don't see a notation of an edit. Am
I missing that, or are username changes no recorded?

> --
> D. Richard Hipp
> d...@sqlite.org


-- 
---
inum: 883510009027723
sip: jungleboo...@sip2sip.info
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] tangent vs. wyoung on recent commti

2017-12-14 Thread Richard Hipp
On 12/14/17, jungle Boogie  wrote:
> Hi All,
>
> This commit caught my eye:
> http://fossil-scm.org/index.html/info/ec059849f5c73a43
>
> User & Date:wyoung on 2017-12-13 21:37:20
> Original User & Date:tangent on 2017-12-13 21:37:20
>
> So Warren edited a file at the same exact time as tangent?
>

No.  The commit was originally by a user named "tangent" at the time
shown.  Then a tag was added
(http://fossil-scm.org/index.html/info/80f1e8a521518104) that changed
the username to "wyoung".

I'm guessing that "tangent" is some local username on Warren's
desktop.  After he committed, he noticed that the commit picked up the
wrong username and so he changed it to his "public" username "wyoung".
I don't have any issues with this.  In fact, I think it was the right
thing to do.
-- 
D. Richard Hipp
d...@sqlite.org
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


[fossil-users] tangent vs. wyoung on recent commti

2017-12-14 Thread jungle Boogie
Hi All,

This commit caught my eye:
http://fossil-scm.org/index.html/info/ec059849f5c73a43

User & Date:wyoung on 2017-12-13 21:37:20
Original User & Date:tangent on 2017-12-13 21:37:20

So Warren edited a file at the same exact time as tangent?

Clicking on tangent, I see this:
http://fossil-scm.org/index.html/timeline?c=2017-12-13+21:37:20=tangent

But those both show Warren's name.

I don't mean to call out you, Warren, directly and I certainly am not
pointing a proverbial finger at you.

-- 
---
inum: 883510009027723
sip: jungleboo...@sip2sip.info
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] Lots of web interface changes

2017-12-14 Thread Richard Hipp
On 12/6/17, John P. Rouillard  wrote:
> I see a major flash of unstyled content.

Do you still have this problem with the latest trunk version of
Fossil?  There was a change at
https://www.fossil-scm.org/fossil/timeline?c=20e680aa that might have
fixed it.

-- 
D. Richard Hipp
d...@sqlite.org
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] Unmatched parenthesis in the new file history

2017-12-14 Thread Richard Hipp
On 12/14/17, Dingyuan Wang  wrote:
> The commit metadata says:
>
> file: [92589049] check-in: [e59a7fd3] user: drh, branch: trunk, size: 28652)

Thanks.  Good catch!  Should be fixed now.

Everybody:  Please continue to keep a close eye out for these kinds of
subtle problems, and do not be bashful about reporting them.  If you
do not want to post on the mailing list, you can send email directly
to me.

-- 
D. Richard Hipp
d...@sqlite.org
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


[fossil-users] Unmatched parenthesis in the new file history

2017-12-14 Thread Dingyuan Wang
Hi,

The recent CSS update looks good. There is a bug in "File History" view.

eg.


The commit metadata says:

file: [92589049] check-in: [e59a7fd3] user: drh, branch: trunk, size: 28652)

This appears in each kind of view.

___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users