[Framework-Team] Re: [Plone 4] PLIP #9249 Add TinyMCE as the default visual editor
Rob Gietema wrote: Hi, I'm currently working on TinyMCE for Plone 4 and would like some feedback on two issues: Yay! I'm using it in a project right now, and really like it. 1) The current code base is located in the Collective. Since TinyMCE will be the default editor in Plone 4 should I move (copy) the code base to Plone SVN? +0 This means the copyright transfers to the Foundation, so if anyone other than you worked on it, you may need their approval. 2) I'm currently using the Products namespace for the package. Would it be better to switch to the plone(.app) namespace for Plone 4 (and keep the Products.TinyMCE for Plone 3)? -1 if it'll break imports for people who've got Products.TinyMCE now and upgrade. +0 otherwise. Martin -- Author of `Professional Plone Development`, a book for developers who want to work with Plone. See http://martinaspeli.net/plone-book ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] Re: [Plone 4] PLIP #9249 Add TinyMCE as the default visual editor
Hi Martin, On Mon, Jul 27, 2009 at 4:07 PM, Martin Aspeli optilude+li...@gmail.comoptilude%2bli...@gmail.com wrote: Rob Gietema wrote: Hi, I'm currently working on TinyMCE for Plone 4 and would like some feedback on two issues: Yay! I'm using it in a project right now, and really like it. 1) The current code base is located in the Collective. Since TinyMCE will be the default editor in Plone 4 should I move (copy) the code base to Plone SVN? +0 This means the copyright transfers to the Foundation, so if anyone other than you worked on it, you may need their approval. This shouldn't be an issue at all since 99.9% of the code is done by me, just some small bugfixes by others who also have commit access to Plone SVN and I'm sure won't mind. 2) I'm currently using the Products namespace for the package. Would it be better to switch to the plone(.app) namespace for Plone 4 (and keep the Products.TinyMCE for Plone 3)? -1 if it'll break imports for people who've got Products.TinyMCE now and upgrade. Correct me if I'm wrong, but I can't find any usecase where someone would want to import something from Products.TinyMCE. +0 otherwise. Martin -- Rob ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
[Framework-Team] Re: [Plone 4] PLIP #9249 Add TinyMCE as the default visual editor
Rob Gietema wrote: Correct me if I'm wrong, but I can't find any usecase where someone would want to import something from Products.TinyMCE. What about persistent data, e.g. the tool? Can be fixed with module aliases, though. Martin -- Author of `Professional Plone Development`, a book for developers who want to work with Plone. See http://martinaspeli.net/plone-book ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] Re: [Plone 4] PLIP #9249 Add TinyMCE as the default visual editor
On 7/27/09 4:56 PM, Rob Gietema wrote: This shouldn't be an issue at all since 99.9% of the code is done by me, just some small bugfixes by others who also have commit access to Plone SVN and I'm sure won't mind. That's not good enough: you need explicit approval. Wichert. ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] [Plone 4] PLIP #9249 Add TinyMCE as the default visual editor
On 7/27/09 1:38 PM, Rob Gietema wrote: Hi, I'm currently working on TinyMCE for Plone 4 and would like some feedback on two issues: 1) The current code base is located in the Collective. Since TinyMCE will be the default editor in Plone 4 should I move (copy) the code base to Plone SVN? -0 I see no reason to move it. 2) I'm currently using the Products namespace for the package. Would it be better to switch to the plone(.app) namespace for Plone 4 (and keep the Products.TinyMCE for Plone 3)? -1 There is no benefit to moving, and this will make it harder to maintain Plone 3 and 4 trees in parallel. Wichert. ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
[Framework-Team] Re: [Plone 4] PLIP #9249 Add TinyMCE as the default visual editor
Wichert Akkerman wich...@wiggy.net writes: On 7/27/09 1:38 PM, Rob Gietema wrote: Hi, I'm currently working on TinyMCE for Plone 4 and would like some feedback on two issues: 1) The current code base is located in the Collective. Since TinyMCE will be the default editor in Plone 4 should I move (copy) the code base to Plone SVN? -0 I see no reason to move it. 2) I'm currently using the Products namespace for the package. Would it be better to switch to the plone(.app) namespace for Plone 4 (and keep the Products.TinyMCE for Plone 3)? -1 There is no benefit to moving, and this will make it harder to maintain Plone 3 and 4 trees in parallel. I'm -1 to both of these, potential disruption for no benefit I can see. Ross ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] Re: [Plone 4] PLIP #9249 Add TinyMCE as the default visual editor
I don't see much upside to renaming the package. On the other hand, the more core Plone code that's owned by the foundation the better, IMO. If Rob is willing to do the work to get all contributors to sign over their contributions, then it's probably worth pursuing. Alec On Mon, Jul 27, 2009 at 11:37 AM, Ross Pattersonm...@rpatterson.net wrote: Wichert Akkerman wich...@wiggy.net writes: On 7/27/09 1:38 PM, Rob Gietema wrote: Hi, I'm currently working on TinyMCE for Plone 4 and would like some feedback on two issues: 1) The current code base is located in the Collective. Since TinyMCE will be the default editor in Plone 4 should I move (copy) the code base to Plone SVN? -0 I see no reason to move it. 2) I'm currently using the Products namespace for the package. Would it be better to switch to the plone(.app) namespace for Plone 4 (and keep the Products.TinyMCE for Plone 3)? -1 There is no benefit to moving, and this will make it harder to maintain Plone 3 and 4 trees in parallel. I'm -1 to both of these, potential disruption for no benefit I can see. Ross ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] Re: [Plone 4] PLIP #9249 Add TinyMCE as the default visual editor
Absolutely. Getting the code into the Foundation's long-term conservancy is very much worth doing if it's not too terribly hard. I've not been through the process before of moving Collective code to the Foundation, but I know Jarn has done this, so perhaps Geir can enlighten us there on whether any additional steps are required other than making sure all contributors have signed the Contributor Agreement. :jon On Mon, Jul 27, 2009 at 1:01 PM, Alec Mitchellap...@columbia.edu wrote: I don't see much upside to renaming the package. On the other hand, the more core Plone code that's owned by the foundation the better, IMO. If Rob is willing to do the work to get all contributors to sign over their contributions, then it's probably worth pursuing. Alec On Mon, Jul 27, 2009 at 11:37 AM, Ross Pattersonm...@rpatterson.net wrote: Wichert Akkerman wich...@wiggy.net writes: On 7/27/09 1:38 PM, Rob Gietema wrote: Hi, I'm currently working on TinyMCE for Plone 4 and would like some feedback on two issues: 1) The current code base is located in the Collective. Since TinyMCE will be the default editor in Plone 4 should I move (copy) the code base to Plone SVN? -0 I see no reason to move it. 2) I'm currently using the Products namespace for the package. Would it be better to switch to the plone(.app) namespace for Plone 4 (and keep the Products.TinyMCE for Plone 3)? -1 There is no benefit to moving, and this will make it harder to maintain Plone 3 and 4 trees in parallel. I'm -1 to both of these, potential disruption for no benefit I can see. Ross ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] Re: [Plone 4] PLIP #9249 Add TinyMCE as the default visual editor
On 27. juli. 2009, at 22.12, Jon Stahl wrote: Absolutely. Getting the code into the Foundation's long-term conservancy is very much worth doing if it's not too terribly hard. I've not been through the process before of moving Collective code to the Foundation, but I know Jarn has done this, so perhaps Geir can enlighten us there on whether any additional steps are required other than making sure all contributors have signed the Contributor Agreement. I don't know of any special considerations beyond the normal ones. - Code must meet Plone's quality assurance level. (i.e pass PLIP review) - All contributors must have signed the agreement. - Some sort of consensus that the code is of general use to Plone and the community, and that the community is the best entity to manage maintenance long term. - Licensing Makes sense to me to move it to the Plone repository in preparation of PLIP review — as long as licenses match and all contributors are clear. :-) -- ___ Geir Bækholt · Managing Director, Jarn · www.jarn.com Plone Solutions, Development, Hosting and Support __ ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
