Re: WARNING: driver bpf should register devices with make_dev()
John Baldwin wrote: > > I already managed to test it locally here and commit the proper fix. > It was an order of operations bug due to the fact that ! is > evaluated before &. Ok, thanks! -- Marcel Moolenaar mail: [EMAIL PROTECTED] / [EMAIL PROTECTED] tel: (408) 447-4222 To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: WARNING: driver bpf should register devices with make_dev()
On 02-Nov-00 Marcel Moolenaar wrote: > John Baldwin wrote: >> >> Quick question: Is this a problem for people _without_ DEVFS? > > That's a yes for me. > >> non-DEVFS case. Try this hackish patch: >> >> Index: bpf.c >> === >> RCS file: /usr/cvs/src/sys/net/bpf.c,v >> retrieving revision 1.68 >> diff -u -r1.68 bpf.c >> --- bpf.c 2000/10/09 14:19:09 1.68 >> +++ bpf.c 2000/11/02 20:26:09 >> @@ -363,7 +363,7 @@ >> */ >> if (d) >> return (EBUSY); >> - if (!dev->si_flags & SI_NAMED) >> + if (!devfs_present) >> make_dev(&bpf_cdevsw, minor(dev), UID_ROOT, GID_WHEEL, 0600, >> "bpf%d", dev2unit(dev)); >> MALLOC(d, struct bpf_d *, sizeof(*d), M_BPF, M_WAITOK); >> >> Hmm. Or try doing changing it to this instead: >> >> if (dev->si_flags & SI_NAMED != 0) >> >> It could be an order of operations buglet. > > Give me a couple of days to play with it... I already managed to test it locally here and commit the proper fix. It was an order of operations bug due to the fact that ! is evaluated before &. -- John Baldwin <[EMAIL PROTECTED]> -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: WARNING: driver bpf should register devices with make_dev()
> > Quick question: Is this a problem for people _without_ DEVFS? Poul > may have accidentally broke calling make_dev for the bpf device in the > non-DEVFS case. Try this hackish patch: Personally, I surely get it with DEVFS and I think I also got it when running without it. I will try the patch nonetheless... I'll be back. -- I believe the technical term is "Oops!" To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: WARNING: driver bpf should register devices with make_dev()
John Baldwin wrote: > > Quick question: Is this a problem for people _without_ DEVFS? That's a yes for me. > non-DEVFS case. Try this hackish patch: > > Index: bpf.c > === > RCS file: /usr/cvs/src/sys/net/bpf.c,v > retrieving revision 1.68 > diff -u -r1.68 bpf.c > --- bpf.c 2000/10/09 14:19:09 1.68 > +++ bpf.c 2000/11/02 20:26:09 > @@ -363,7 +363,7 @@ > */ > if (d) > return (EBUSY); > - if (!dev->si_flags & SI_NAMED) > + if (!devfs_present) > make_dev(&bpf_cdevsw, minor(dev), UID_ROOT, GID_WHEEL, 0600, > "bpf%d", dev2unit(dev)); > MALLOC(d, struct bpf_d *, sizeof(*d), M_BPF, M_WAITOK); > > Hmm. Or try doing changing it to this instead: > > if (dev->si_flags & SI_NAMED != 0) > > It could be an order of operations buglet. Give me a couple of days to play with it... -- Marcel Moolenaar mail: [EMAIL PROTECTED] / [EMAIL PROTECTED] tel: (408) 447-4222 To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: WARNING: driver bpf should register devices with make_dev()
On 02-Nov-00 John Baldwin wrote: > > On 02-Nov-00 Marcel Moolenaar wrote: >> [EMAIL PROTECTED] wrote: >>> >>> > I get it as well. IIRC, it simply means that the bpf pseudo device needs >>> > to be updated, but is otherwise harmless. I forgot the details, but it's >>> > all in the mailinglist archives. Somewhere... :-) >>> >>> Anybody handling this, or anybody can give pointers as to what needs to be >>> done? >> >> I'm not aware someone is working on it. It doesn't look like it needs >> much work, but I don't know the details as I said. For pointers: mail >> archives. > > Quick question: Is this a problem for people _without_ DEVFS? Poul > may have accidentally broke calling make_dev for the bpf device in the > non-DEVFS case. Try this hackish patch: > > Index: bpf.c > === > RCS file: /usr/cvs/src/sys/net/bpf.c,v > retrieving revision 1.68 > diff -u -r1.68 bpf.c > --- bpf.c 2000/10/09 14:19:09 1.68 > +++ bpf.c 2000/11/02 20:26:09 > @@ -363,7 +363,7 @@ > */ > if (d) > return (EBUSY); > - if (!dev->si_flags & SI_NAMED) > + if (!devfs_present) > make_dev(&bpf_cdevsw, minor(dev), UID_ROOT, GID_WHEEL, 0600, > "bpf%d", dev2unit(dev)); > MALLOC(d, struct bpf_d *, sizeof(*d), M_BPF, M_WAITOK); > > Hmm. Or try doing changing it to this instead: > > if (dev->si_flags & SI_NAMED != 0) > > It could be an order of operations buglet. Argh, that should be "== 0" not "!= 0". -- John Baldwin <[EMAIL PROTECTED]> -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: WARNING: driver bpf should register devices with make_dev()
On 02-Nov-00 Marcel Moolenaar wrote: > [EMAIL PROTECTED] wrote: >> >> > I get it as well. IIRC, it simply means that the bpf pseudo device needs >> > to be updated, but is otherwise harmless. I forgot the details, but it's >> > all in the mailinglist archives. Somewhere... :-) >> >> Anybody handling this, or anybody can give pointers as to what needs to be >> done? > > I'm not aware someone is working on it. It doesn't look like it needs > much work, but I don't know the details as I said. For pointers: mail > archives. Quick question: Is this a problem for people _without_ DEVFS? Poul may have accidentally broke calling make_dev for the bpf device in the non-DEVFS case. Try this hackish patch: Index: bpf.c === RCS file: /usr/cvs/src/sys/net/bpf.c,v retrieving revision 1.68 diff -u -r1.68 bpf.c --- bpf.c 2000/10/09 14:19:09 1.68 +++ bpf.c 2000/11/02 20:26:09 @@ -363,7 +363,7 @@ */ if (d) return (EBUSY); - if (!dev->si_flags & SI_NAMED) + if (!devfs_present) make_dev(&bpf_cdevsw, minor(dev), UID_ROOT, GID_WHEEL, 0600, "bpf%d", dev2unit(dev)); MALLOC(d, struct bpf_d *, sizeof(*d), M_BPF, M_WAITOK); Hmm. Or try doing changing it to this instead: if (dev->si_flags & SI_NAMED != 0) It could be an order of operations buglet. -- John Baldwin <[EMAIL PROTECTED]> -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: WARNING: driver bpf should register devices with make_dev() (dev_t="#bpf/0")
[EMAIL PROTECTED] wrote: > > > I get it as well. IIRC, it simply means that the bpf pseudo device needs > > to be updated, but is otherwise harmless. I forgot the details, but it's > > all in the mailinglist archives. Somewhere... :-) > > Anybody handling this, or anybody can give pointers as to what needs to be > done? I'm not aware someone is working on it. It doesn't look like it needs much work, but I don't know the details as I said. For pointers: mail archives. -- Marcel Moolenaar mail: [EMAIL PROTECTED] / [EMAIL PROTECTED] tel: (408) 447-4222 To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: WARNING: driver bpf should register devices with make_dev() (dev_t ="#bpf/0")
Marcel Moolenaar wrote: > [EMAIL PROTECTED] wrote: > > > > WARNING: driver bpf should register devices with make_dev() (dev_t = "#bpf/0") > > > > probably at first usage. Card is an xe PC Card. > > I know I will probably get flamed for not RTF*, but I couldn't find a clue > > anywhere... > > I get it as well. IIRC, it simply means that the bpf pseudo device needs > to be updated, but is otherwise harmless. I forgot the details, but it's > all in the mailinglist archives. Somewhere... :-) Anybody handling this, or anybody can give pointers as to what needs to be done? -- Reboot America. To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: WARNING: driver bpf should register devices with make_dev() (dev_t ="#bpf/0")
[EMAIL PROTECTED] wrote: > > WARNING: driver bpf should register devices with make_dev() (dev_t = "#bpf/0") > > probably at first usage. Card is an xe PC Card. > I know I will probably get flamed for not RTF*, but I couldn't find a clue > anywhere... I get it as well. IIRC, it simply means that the bpf pseudo device needs to be updated, but is otherwise harmless. I forgot the details, but it's all in the mailinglist archives. Somewhere... :-) -- Marcel Moolenaar mail: [EMAIL PROTECTED] / [EMAIL PROTECTED] tel: (408) 447-4222 To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
WARNING: driver bpf should register devices with make_dev() (dev_t ="#bpf/0")
Subject says it all. I get: WARNING: driver bpf should register devices with make_dev() (dev_t = "#bpf/0") probably at first usage. Card is an xe PC Card. I know I will probably get flamed for not RTF*, but I couldn't find a clue anywhere... Bye, Andrea -- Give a man a fish and you feed him for a day; teach him to use the Net and he won't bother you for weeks. To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
