libufs, a library for dealing with UFS from userland.
Hi, I'm trying to get review of something phk@ talked me into having a go at, libufs, which is a library to un-duplicate code for dealing with UFS on a raw disk device. Currently it defines a generic structure for UFS on any disk that one might want to refer to from the userland, including the UFS superblock, version, and the name and file descriptor for the device used to work with the disk. That structure is then used by implementations of block read/write (bread/bwrite), functions to read and write the superblock in a uufsd structure (sbread/sbwrite) and a function to get the inode structure for a given file. Here's a shell archive: http://people.freebsd.org/~jmallett/libufs.shar And here's diffs to dumpfs and tunefs: http://people.freebsd.org/~jmallett/libufs-dumpfs.diff http://people.freebsd.org/~jmallett/libufs-tunefs.diff To build (e.g. tunefs) with libufs, do something like: cd libufs make co /home/ncvs/src/sbin/tunefs.c,v cc tunefs.c -o libufs-tunefs -L. -lufs I get identical output from dumpfs and libufs-dumpfs currently and I can toggle softdep flags fine with tunefs. I'd like to commit this by the coming Tuesday as I will be out of town from Tuesday morning and will not have any way to further work on this, etc. Further functionality may/will be added to libufs, however this is a good milestone of abstraction, in my opinion, as it can replace code in a number of utilities, namely dump, dumpfs, tunefs, ffsinfo, growfs, and possibly one or two others, if I recall correctly. Architectural review, comments, and feel free to commit welcome :) Thanks, juli. -- Juli Mallett [EMAIL PROTECTED] | FreeBSD: The Power To Serve Taking over the FreeBSD negaverse.| FreeBSD Negacore Team Will break world for fulltime employment. | finger [EMAIL PROTECTED] To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: libufs, a library for dealing with UFS from userland.
* Juli Mallett [EMAIL PROTECTED] [020629 05:38] wrote: I get identical output from dumpfs and libufs-dumpfs currently and I can toggle softdep flags fine with tunefs. I'd like to commit this by the coming Tuesday as I will be out of town from Tuesday morning and will not have any way to further work on this, etc. The work is really nice, but the timing sounds rather bad, is there a way you can either commit it earlier or after you return from hiatus? -- -Alfred Perlstein [[EMAIL PROTECTED]] 'Instead of asking why a piece of software is using 1970s technology, start asking why software is ignoring 30 years of accumulated wisdom.' Tax deductible donations for FreeBSD: http://www.freebsdfoundation.org/ To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: libufs, a library for dealing with UFS from userland.
* Alfred Perlstein [EMAIL PROTECTED] escriuréres The work is really nice, but the timing sounds rather bad, is there Thanks. a way you can either commit it earlier or after you return from hiatus? I can commit it a few weeks from now, or I can commit it five minutes from now. I just don't want it going in with any architectural deficiency hanging over its head, and so I wanted to give adequate time for review, if such seems necessary. Really I can commit while out of town, but if any changes need made because of said review, I wouldn't want to commit, as (as mentioned) I'll be unable to test (outside of compiles). Thanks again. -- Juli Mallett [EMAIL PROTECTED] | FreeBSD: The Power To Serve Will break world for fulltime employment. | finger [EMAIL PROTECTED] To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: libufs, a library for dealing with UFS from userland.
* Juli Mallett [EMAIL PROTECTED] [020629 06:31] wrote: * Alfred Perlstein [EMAIL PROTECTED] escriuréres The work is really nice, but the timing sounds rather bad, is there Thanks. a way you can either commit it earlier or after you return from hiatus? I can commit it a few weeks from now, or I can commit it five minutes from now. I just don't want it going in with any architectural deficiency hanging over its head, and so I wanted to give adequate time for review, if such seems necessary. Really I can commit while out of town, but if any changes need made because of said review, I wouldn't want to commit, as (as mentioned) I'll be unable to test (outside of compiles). I think if you committed it sunday night that would be fine, that's plenty of time for people to get a look at it, especially considering this is being proposed over the weekend. It also gives you two days to correct any issues should they come up. -- -Alfred Perlstein [[EMAIL PROTECTED]] 'Instead of asking why a piece of software is using 1970s technology, start asking why software is ignoring 30 years of accumulated wisdom.' Tax deductible donations for FreeBSD: http://www.freebsdfoundation.org/ To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: libufs, a library for dealing with UFS from userland.
At 5:37 AM -0700 6/29/02, Juli Mallett wrote: I get identical output from dumpfs and libufs-dumpfs currently and I can toggle softdep flags fine with tunefs. I'd like to commit this by the coming Tuesday as I will be out of town from Tuesday morning and will not have any way to further work on this, etc. When do you get back into town? If anyone asks for review on a Saturday, then I would hope that they'd wait until at least Monday evening before doing the commit. And I don't think the project should be too comfortable with the idea of developers making a commit just before they head out of town. Also, there was the big KSE commit this weekend, and it might be prudent to let that settle in for a few days. -- Garance Alistair Drosehn= [EMAIL PROTECTED] Senior Systems Programmer or [EMAIL PROTECTED] Rensselaer Polytechnic Instituteor [EMAIL PROTECTED] To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
