[Freeciv-Dev] [patch #1296] restructure basic notify functions
Follow-up Comment #4, patch #1296 (project freeciv): + my_snprintf(packet_send.message, sizeof(packet_send.message), %s, + packet-message); Why is this not simple strncpy()? Or sz_strlcpy(packet_send.message, packet-message)? ___ Reply to this item at: http://gna.org/patch/?1296 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14333] S2_2 and trunk don't compile with --enable-debug
Follow-up Comment #5, bug #14333 (project freeciv): that options did you use to get this warning? I don't do anything particular. I configure with --enable-debug --enable-auth. My gcc version 4.3.3, maybe that's the point. ___ Reply to this item at: http://gna.org/bugs/?14333 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1286] Featured test: inputline toolkit
Follow-up Comment #1, patch #1286 (project freeciv): Updated to work against current revisions. (file #6727) ___ Additional Item Attachment: File name: trunk_S2_2_ft_inputline_toolkit2.diff Size:22 KB ___ Reply to this item at: http://gna.org/patch/?1286 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14267] Featured text chatline shortcuts should be documented at helpdata.txt
Follow-up Comment #9, bug #14267 (project freeciv): In my opinion, it would be most clear to the average enduser to say it something like: This expression can also be started and finished within the same pair of brackets, like '[link target=city id=121/]' (note the slash at the end). I'm thinking that avoiding using some technical vocabulary would be easier to understand. I added the part because I didn't see the ending slash until just now... I took care about this comments to make the new patch. Thank you. I don't know of any term to describe a pair of brackets (ie, []), nor two pairs of brackets (ie, [color=xx][/color]), but neither would the majority of the people reading the helpfile. You could probably refer to [] as a bracket, brackets, bracket pair, pair of brackets, etc... At least in non-perfect spoken English, I don't have a book of grammar, just going by what sounds right to me, and how I would probably say it. It is kind of ambiguous to me what the technically correct way of saying it is. I guess that the current version of the patch is enough good to be included in the svn repository. If a fanatic of English language assumes that it is notfully correct, he could make other suggestions... (file #6729) ___ Additional Item Attachment: File name: trunk_S2_2_ft_helptext2.diff Size:4 KB ___ Reply to this item at: http://gna.org/bugs/?14267 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13465] wrong savename used for savefile name generation
Follow-up Comment #4, bug #13465 (project freeciv): I think whole new command for fixing this rather small detail is overkill, and additional command in server help makes learning curve only steeper. Logic to decide when to send settings should be in the client side. This should not be limited to savename but all settings loaded from savegame should be preferred over client defaults. I looked this (client sources) and bug is not as obvious as previously thought. Client should send settings only to forked servers (so server has definitely loaded savegame before client requests it) and before savegame is loaded. Thus values loaded from savegame should override ones sent by client. ___ Reply to this item at: http://gna.org/bugs/?13465 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1289] Version specific datasubdir
Update of patch #1289 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1289 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13501] auto save overwrites existing save games
Update of bug #13501 (project freeciv): Status:None = Need Info ___ Follow-up Comment #1: I cannot reproduce. Game is never saved when I quit client or Leave game. Any instructions on how to reproduce? ___ Reply to this item at: http://gna.org/bugs/?13501 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13465] wrong savename used for savefile name generation
Update of bug #13465 (project freeciv): Status:None = Confirmed ___ Reply to this item at: http://gna.org/bugs/?13465 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1253] add 'bool city_ok' to unit survival functions
Update of patch #1253 (project freeciv): Status:None = Wont Do Assigned to:None = cazfi Open/Closed:Open = Closed ___ Follow-up Comment #1: This is quite ugly... and as noted in bug #14037 resolves nothing. ___ Reply to this item at: http://gna.org/patch/?1253 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14037] unit_change_homecity_handling() teleports units
Follow-up Comment #13, bug #14037 (project freeciv): Not teleporting units from transferred city to far away cities but next to transferred city causes them to be inside borders of new owner. What problems this will cause? It's already possible that units from other (home)cities are next to transferred city. So this should bring no (new) problems at all. ___ Reply to this item at: http://gna.org/bugs/?14037 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1286] Featured test: inputline toolkit
Follow-up Comment #3, patch #1286 (project freeciv): Tooltips could give out shortcut keys performing same actions. ___ Reply to this item at: http://gna.org/patch/?1286 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
