[Freeciv-Dev] [patch #1498] Improve packet log message by providing packet name in addition to number
URL: http://gna.org/patch/?1498 Summary: Improve packet log message by providing packet name in addition to number Project: Freeciv Submitted by: cazfi Submitted on: Monday 03/01/2010 at 16:07 Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.2.1 ___ Details: $subject when receiving packets in wrong server state. ___ File Attachments: --- Date: Monday 03/01/2010 at 16:07 Name: 14_LogGotPacketByName.diff Size: 860B By: cazfi http://gna.org/patch/download.php?file_id=8341 ___ Reply to this item at: http://gna.org/patch/?1498 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15517] got a packet of type VOTE_SUBMIT(149) outside S_S_RUNNING
URL: http://gna.org/bugs/?15517 Summary: got a packet of type VOTE_SUBMIT(149) outside S_S_RUNNING Project: Freeciv Submitted by: cazfi Submitted on: Monday 03/01/2010 at 16:10 Category: general Severity: 2 - Minor Priority: 1 - Later Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: My server logs have message got a packet of type VOTE_SUBMIT(149) outside S_S_RUNNING every now and then. Error message is bogus, I believe. Isn't voting allowed in pregame? ___ Reply to this item at: http://gna.org/bugs/?15517 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15518] Valgrind warning from openload_ruleset_file()
URL: http://gna.org/bugs/?15518 Summary: Valgrind warning from openload_ruleset_file() Project: Freeciv Submitted by: cazfi Submitted on: Monday 03/01/2010 at 16:23 Category: general Severity: 3 - Normal Priority: 1 - Later Status: None Assigned to: None Originator Email: Open/Closed: Open Release: S2_2 r16933 Discussion Lock: Any Operating System: None Planned Release: ___ Details: I have not seen this warning before so it's probably related to recent section file changes: ==27020== Conditional jump or move depends on uninitialised value(s) ==27020==at 0x5506290: inflateReset2 (inflate.c:157) ==27020==by 0x550637F: inflateInit2_ (inflate.c:193) ==27020==by 0x54FFC86: gz_open (gzio.c:186) ==27020==by 0x51BEAF: fz_from_file (ioz.c:227) ==27020==by 0x50C9F3: inf_from_file (inputfile.c:227) ==27020==by 0x509C1D: section_file_load_nodup (registry.c:703) ==27020==by 0x468DCB: openload_ruleset_file (ruleset.c:213) ==27020==by 0x46E890: load_rulesets (ruleset.c:3786) ==27020==by 0x40BFCE: srv_main (srv_main.c:2187) ==27020==by 0x404334: main (civserver.c:359) ___ Reply to this item at: http://gna.org/bugs/?15518 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15519] ai_settler_init() memory leak
URL: http://gna.org/bugs/?15519 Summary: ai_settler_init() memory leak Project: Freeciv Submitted by: cazfi Submitted on: Monday 03/01/2010 at 16:34 Category: None Severity: 3 - Normal Priority: 1 - Later Status: None Assigned to: None Originator Email: Open/Closed: Open Release: S2_2 r16933 Discussion Lock: Any Operating System: None Planned Release: ___ Details: I run longish autogame in Valgrind. I'm not going to submit separate ticket for all of the memory loos records. Several cases of the unfreed memory is allocated in end_phase() - xxx_init(). It's likely that all these seemingly separate leaks are caused by one bug causing proper xxx_deinit() for these xxx_init() functions not to run. Example report, one with most memory consumed: ==27020== 32,448 bytes in 1 blocks are still reachable in loss record 1,185 of 1,186 ==27020==at 0x4C222A8: realloc (vg_replace_malloc.c:476) ==27020==by 0x506554: fc_real_realloc (mem.c:104) ==27020==by 0x497B03: ai_settler_init (aisettler.c:455) ==27020==by 0x40962E: end_phase (srv_main.c:859) ==27020==by 0x40B09D: srv_running (srv_main.c:2100) ==27020==by 0x40C29E: srv_main (srv_main.c:2458) ==27020==by 0x404334: main (civserver.c:359) ==27020== ___ Reply to this item at: http://gna.org/bugs/?15519 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1498] Improve packet log message by providing packet name in addition to number
Follow-up Comment #1, patch #1498 (project freeciv): This won't apply to trunk. Also, if the packet is not supported, is there a way that get_packet_name would returns the packet number? ___ Reply to this item at: http://gna.org/patch/?1498 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15517] got a packet of type VOTE_SUBMIT(149) outside S_S_RUNNING
Follow-up Comment #1, bug #15517 (project freeciv): Does this still happen after the fix of bug #15451? ___ Reply to this item at: http://gna.org/bugs/?15517 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15518] Valgrind warning from openload_ruleset_file()
Follow-up Comment #1, bug #15518 (project freeciv): There have been no such changes in the section file stuff in the S2_2 branch recently. ___ Reply to this item at: http://gna.org/bugs/?15518 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1498] Improve packet log message by providing packet name in addition to number
Follow-up Comment #2, patch #1498 (project freeciv): Nevermind, the number is also reported. ___ Reply to this item at: http://gna.org/patch/?1498 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1230] save worked tiles from main map
Follow-up Comment #5, patch #1230 (project freeciv): bug fix for the savegame format 'playeri.cj.workers' has to be present within the savegame. If it is not found, old servers crash if they try to load a new savegame (file #8346) ___ Additional Item Attachment: File name: 20100301-trunk--savegame-format-save-worked-tiles-from-main-map.diff Size:12 KB ___ Reply to this item at: http://gna.org/patch/?1230 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15487] /team help still claims that players can be made teamless
Update of bug #15487 (project freeciv): Assigned to:None = jtn ___ Reply to this item at: http://gna.org/bugs/?15487 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1230] save worked tiles from main map
Follow-up Comment #6, patch #1230 (project freeciv): 'playeri.cj.workers' has to be present within the savegame. If it is not found, old servers crash if they try to load a new savegame How to do this the right way? The old version of this patch (file #8299) will crash old trunk servers without a usefull message (the pointer to the setting 'playeri.cj.workers' is NULL but not checked) while the new patch (file #8346) will result in tons of error messages but not crash old server. As info: The savegame format is changed between 2.2 and trunk (replace '1/0' by 'TRUE/FALSE'). ___ Reply to this item at: http://gna.org/patch/?1230 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15519] ai_settler_init() memory leak
Follow-up Comment #1, bug #15519 (project freeciv):
The function this points to has the following code:
void ai_settler_init(struct player *pplayer)
{
cachemap = fc_realloc(cachemap, MAP_INDEX_SIZE * sizeof(*cachemap));
memset(cachemap, -1, MAP_INDEX_SIZE * sizeof(*cachemap));
}
The cachemap is only used within this file. Could it be that valgrind reports
this due to the fact that this memory is never freed within the code but
reused?
Related (solved) bug wrt other reallocated pointers: bugs #15305
___
Reply to this item at:
http://gna.org/bugs/?15519
___
Nachricht geschickt von/durch Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1494] [Metaticket] merge longturn into mainline
Update of patch #1494 (project freeciv): Depends on: = patch #1201 ___ Reply to this item at: http://gna.org/patch/?1494 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1494] [Metaticket] merge longturn into mainline
Update of patch #1494 (project freeciv): Depends on: = patch #1258 ___ Reply to this item at: http://gna.org/patch/?1494 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15520] readd (?) saving of game.server.timeoutaddenemymove
URL: http://gna.org/bugs/?15520 Summary: readd (?) saving of game.server.timeoutaddenemymove Project: Freeciv Submitted by: syntron Submitted on: Montag 01.03.2010 um 23:54 Category: general Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.2.1, 2.3.0 ___ Details: the server tries to read game.server.timeoutaddenemymove from the savegame but it is never saved ___ File Attachments: --- Date: Montag 01.03.2010 um 23:54 Name: 20100301-trunk-readd-saving-of-game.server.timeoutaddenemymove.diff Size: 1009B By: syntron http://gna.org/bugs/download.php?file_id=8347 ___ Reply to this item at: http://gna.org/bugs/?15520 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1499] Convenience function for formatting a time string
URL: http://gna.org/patch/?1499 Summary: Convenience function for formatting a time string Project: Freeciv Submitted by: syntron Submitted on: Montag 01.03.2010 um 23:55 Category: general Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.3.0 ___ Details: patch by book for longturn ___ File Attachments: --- Date: Montag 01.03.2010 um 23:55 Name: 20100301-trunk-Convenience-function-for-formatting-a-time-string.diff Size: 2kB By: syntron http://gna.org/patch/download.php?file_id=8348 ___ Reply to this item at: http://gna.org/patch/?1499 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1494] [Metaticket] merge longturn into mainline
Update of patch #1494 (project freeciv): Depends on: = patch #1499 ___ Reply to this item at: http://gna.org/patch/?1494 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1500] fix for turn change double-move problem
URL: http://gna.org/patch/?1500 Summary: fix for turn change double-move problem Project: Freeciv Submitted by: syntron Submitted on: Montag 01.03.2010 um 23:57 Category: general Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.3.0 ___ Details: - Setting 'unitwaittime' gives the minimum number of seconds between unit moves over a turn change. - Save and restore unitwaittime in savegame. patch by book for longturn needs an update of the network capabilities ___ File Attachments: --- Date: Montag 01.03.2010 um 23:57 Name: 20100301-trunk-fix-for-turn-change-double-move-problem.diff Size: 9kB By: syntron http://gna.org/patch/download.php?file_id=8349 ___ Reply to this item at: http://gna.org/patch/?1500 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1494] [Metaticket] merge longturn into mainline
Update of patch #1494 (project freeciv): Depends on: = patch #1500 ___ Reply to this item at: http://gna.org/patch/?1494 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1501] add option to slowly kill unhomed units: 'killunhomed'
URL: http://gna.org/patch/?1501 Summary: add option to slowly kill unhomed units: 'killunhomed' Project: Freeciv Submitted by: syntron Submitted on: Montag 01.03.2010 um 23:59 Category: general Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.3.0 ___ Details: patch from longturn modified for mainline freeciv needs an update of the network capabilities ___ File Attachments: --- Date: Montag 01.03.2010 um 23:59 Name: 20100301-trunk-add-option-to-slowly-kill-unhomed-units-killunhomed.diff Size: 6kB By: syntron http://gna.org/patch/download.php?file_id=8350 ___ Reply to this item at: http://gna.org/patch/?1501 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1494] [Metaticket] merge longturn into mainline
Update of patch #1494 (project freeciv): Depends on: = patch #1501 ___ Reply to this item at: http://gna.org/patch/?1494 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1494] [Metaticket] merge longturn into mainline
Update of patch #1494 (project freeciv): Depends on: = patch #1263 ___ Reply to this item at: http://gna.org/patch/?1494 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1494] [Metaticket] merge longturn into mainline
Follow-up Comment #1, patch #1494 (project freeciv): I added some patches; leftovers: * setting: citytrading * command: rename * longturn command level (equal to info?) * (c++) adding new player and changes to ./server/generator/startpos.c * (c++) updated mysql connection * teams placement patch (see http://www.longturn.org/forum/how-know-whats-happening-when-youre-not-ingame) ___ Reply to this item at: http://gna.org/patch/?1494 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15510] accidently clicking a settler/worker/engineer loses all terrain improvement progress
Follow-up Comment #2, bug #15510 (project freeciv): Another related issue is that I think progress towards an improvement is somehow accounted to individual engineers; if I have one working on a transformation, and later put another one on the same activity/tile, after that, if I want to take one of the engineers off the project, how long the remaining one will take to finish the transformation depends on which one it is (and I have no way of telling them apart). Hopefully the fix will involve some way of telling how far along the project is... ___ Reply to this item at: http://gna.org/bugs/?15510 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1230] save worked tiles from main map
Follow-up Comment #7, patch #1230 (project freeciv): Don't care of old trunk servers, there shouldn't be really played as they are the development branch. ___ Reply to this item at: http://gna.org/patch/?1230 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1501] add option to slowly kill unhomed units: 'killunhomed'
Follow-up Comment #1, patch #1501 (project freeciv): Do the client really need to know this value? If not, then, it should a part of game.server, not game.info. ___ Reply to this item at: http://gna.org/patch/?1501 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1500] fix for turn change double-move problem
Follow-up Comment #1, patch #1500 (project freeciv): Do the client really need to know this value? If not, then, it should a part of game.server, not game.info. ___ Reply to this item at: http://gna.org/patch/?1500 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15520] readd (?) saving of game.server.timeoutaddenemymove
Follow-up Comment #1, bug #15520 (project freeciv): In S2_1 is saved game.info.timeoutaddenemymove instead of game.timeoutaddenemymove also. ___ Reply to this item at: http://gna.org/bugs/?15520 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
