[Freeciv-Dev] [bug #16212] Default size of city dialog gives scrollbar on city map with amplio tileset

2010-07-01 Thread Matthias Pfafferodt

Update of bug #16212 (project freeciv):

 Planned Release: = 2.2.2, 2.3.0   

___

Follow-up Comment #2:

The default width and height of the city dialog can be adapted. At the time
the patch was created the main goal was to reduce the size for a netbook. I
do change the size each time I start a game. Perhaps the width and height can
be saved as an client option? At the moment these values are saved during a
session but, as you said, not across sessions.

___

Reply to this item at:

  http://gna.org/bugs/?16212

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #16213] Fix typo / English in city dialog happiness tab

2010-07-01 Thread Matthias Pfafferodt

Update of bug #16213 (project freeciv):

 Planned Release:   2.2.2 = 2.2.2, 2.3.0   

___

Follow-up Comment #2:

Thanks for catching this! Could you also apply this patch to 2.3.0?

___

Reply to this item at:

  http://gna.org/bugs/?16213

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] Longturn Freeciv

2010-07-01 Thread Goswin von Brederlow
Matthias Pfafferodt matthias.pfaffer...@mapfa.de writes:

 Am Tuesday 29 June 2010 22:59:03 schrieb Andreas Røsdal:
 * Server architecture:
 The current single-threaded architecture of the Freeciv server will also
 be a limitation for large Longturn games. The server should probably be
 multithreaded to be more scalable. Would this be realistic?

 No idea here.

Is the server actually taking so much time? I think the worst time hog
is the AI. Split that out into seperate threads and things should
improve greatly.

MfG
Goswin

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1725] fix info table of the happiness notebook in the citydialog to the top

2010-07-01 Thread Matthias Pfafferodt

URL:
  http://gna.org/patch/?1725

 Summary: fix info table of the happiness notebook in the
citydialog to the top
 Project: Freeciv
Submitted by: syntron
Submitted on: Donnerstag 01.07.2010 um 10:29
Category: client-gtk-2.0
Priority: 3 - Low
  Status: Ready For Test
 Privacy: Public
 Assigned to: syntron
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.2.2,2.3.0

___

Details:





___

File Attachments:


---
Date: Donnerstag 01.07.2010 um 10:29  Name:
20100701-08-trunk-fix-info-table-of-the-happiness-notebook-in-the-city.patch 
Size: 892B   By: syntron

http://gna.org/patch/download.php?file_id=9407

___

Reply to this item at:

  http://gna.org/patch/?1725

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #16212] Default size of city dialog gives scrollbar on city map with amplio tileset

2010-07-01 Thread Matthias Pfafferodt

Update of bug #16212 (project freeciv):

Priority:   1 - Later = 5 - Normal 
  Status:None = Ready For Test 
 Assigned to:None = syntron

___

Follow-up Comment #3:

patch comment:


save the size of the city dialog across sessions

- add gui_gtk2_citydlg_save_size, gui_gtk2_citydlg_xsave and
gui_gtk2_citydlg_ysave options
- rename citydlg_(height|width) to citydlg_map_(height|width)


The city dialog should have a smaller width as in your screenshot. If it is
automatically scaled to this width, it would be a bug ...

(file #9408)
___

Additional Item Attachment:

File name:
20100701-09-trunk-save-the-size-of-the-city-dialog-across-sessions.patch
Size:7 KB


___

Reply to this item at:

  http://gna.org/bugs/?16212

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] Longturn Freeciv

2010-07-01 Thread Marko Lindqvist
On 1 July 2010 10:53, Goswin von Brederlow goswin-...@web.de wrote:
 Matthias Pfafferodt matthias.pfaffer...@mapfa.de writes:

 Am Tuesday 29 June 2010 22:59:03 schrieb Andreas Røsdal:
 * Server architecture:
 The current single-threaded architecture of the Freeciv server will also
 be a limitation for large Longturn games. The server should probably be
 multithreaded to be more scalable. Would this be realistic?

 No idea here.

 Is the server actually taking so much time? I think the worst time hog
 is the AI. Split that out into seperate threads and things should
 improve greatly.

 A couple of years ago I wrote proof-of-concept patch that run AI's in
separate thread so they could work at the same time when players move
removing long wait between turns. The idea was rejected on basis that
it would make debugging much harder.


 - ML

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] Fwd: Longturn Freeciv

2010-07-01 Thread Matthias Pfafferodt
  Great. Would you be interested in sharing how the code needs to be
  cleaned up? Perhaps I can help with making the changed necessary to
  making this work.
 
- Andreas

 Have a look at the source code and the attached patches. At the moment all
 player slots are statically allocated. I did try to change this to a player
 list. Therefore I first renamed some functions (to player_id() and
 player_by_name()). After that I wanted to do all at once, but this did not
 work. At that time I also got the feeling that small steps are needed. But
 as the player definition and also the map definition are one of the basic
 data of freeciv it is interconnected with all the code.

 At the end I through about this roadmap:

 1) implement players as pointer
 2) add player_list
 3) make the required changes to the player struct (step by step)
 4) increase the number of players

 Do not expect the patches to apply cleanly or even to work. They are based
 on the svn from 2010-04-21 patch 'Add utilities to make safe operations on
 UTF-8 strings.'. I do not have the svn ID as I import the svn into a git
 repo.

Some additional ideas how to do this (I pondered this a long time) :

- if the number of player is increased, the player struct should be defined as 
pointer

- some data in the struct is saved for each player (diplstat), thus old player 
*must not* be removed; else one cannot access this data using the player id 
(= index of the player in the corresponding list)

- as result, the player struct should be divided into two parts; one with the 
basic data (name) and one with all the data only needed if the player is 
alive

- speclist.h should be used for the list of players and also the additional 
data per player (player-diplstat)

- there should be functions to add a player (to the list of players and also 
to the diplstat of *each* player) and to kill a player (remove the variable 
data part and set the diplstat to a defined state)

- the network protocol and the client have to be checked (can they handle the 
changes?)



My TODO list is at the moment as follows (no guarantee and no deadline; I 
could even stop ...):

short time:
- bug fixes and small changes (gtk client)

long time:
- merge longturn
- check enums / code cleanup

far away:
- save ruleset in one file and use it to send the ruleset to the clients
- savegame cleanup (and save ruleset in savegame)

far far away:
- mapimg (save an image of the map for each turn; this is at the moment at the 
end of the list, but a nice project; once upon a time parts of it were 
working ...)

dreaming:
- loyal citizens
- more players
- larger maps
- ...

Matthias


 I have to do other things at the moment and freeciv is only a tool to
 distract me ... (but the original task has to be done!)

 Matthias
-- 
Matthias Pfafferodt - http://www.mapfa.de
Matthias.Pfafferodt at mapfa.de

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15945] Impossible to investigate a city twice

2010-07-01 Thread pepeto

Update of bug #15945 (project freeciv):

 Assigned to:None = pepeto 


___

Reply to this item at:

  http://gna.org/bugs/?15945

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #16071] Default savegame prefix should include 'freeciv'

2010-07-01 Thread Matthias Pfafferodt

Update of bug #16071 (project freeciv):

  Status:None = Ready For Test 
 Assigned to:None = syntron

___

Follow-up Comment #2:

something like this? rename savegame from 'civgame-*' to 'freeciv-*'

(file #9409)
___

Additional Item Attachment:

File name:
20100701-10-trunk-change-name-of-savefiles-fro-civgame-to-freeciv.patch
Size:0 KB


___

Reply to this item at:

  http://gna.org/bugs/?16071

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #16215] Received VOTE_SUBMIT(149) from observer

2010-07-01 Thread Marko Lindqvist

URL:
  http://gna.org/bugs/?16215

 Summary: Received VOTE_SUBMIT(149) from observer
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thursday 07/01/2010 at 16:50
Category: None
Severity: 3 - Normal
Priority: 1 - Later
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.2.1
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

1:Received packet VOTE_SUBMIT(149) from non-player connection ... (observer)

Client in question reported itself as gtk2.





___

Reply to this item at:

  http://gna.org/bugs/?16215

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #16209] engineers revert to maximum task time upon reloading game

2010-07-01 Thread anonymous

Follow-up Comment #2, bug #16209 (project freeciv):

Please consider me completely ignorant. What do I do with the fix files?

___

Reply to this item at:

  http://gna.org/bugs/?16209

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1715] Translation fixes for FR

2010-07-01 Thread pepeto

Update of patch #1715 (project freeciv):

 Planned Release:   2.2.2 = 2.2.2, 2.3.0   

___

Follow-up Comment #1:

Attached version for the S2_2 branch.


(file #9411)
___

Additional Item Attachment:

File name: S2_2_fr_po.diffSize:21 KB


___

Reply to this item at:

  http://gna.org/patch/?1715

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1718] French version : translation error for Slovenian nation

2010-07-01 Thread pepeto

Update of patch #1718 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 
 Planned Release: = 2.2.2  


___

Reply to this item at:

  http://gna.org/patch/?1718

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #16204] Property Editor window briefly visible at startup

2010-07-01 Thread pepeto

Update of bug #16204 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?16204

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #16209] engineers revert to maximum task time upon reloading game

2010-07-01 Thread Jacob Nevins

Update of bug #16209 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 

___

Follow-up Comment #5:

You don't _have_ to do anything with them :) they were here primarily so the
dev team could review them internally.

I've now committed them, so the fix will be in the next 2.2.x release.

(If you're able to apply patches and compile Freeciv from source, you're
welcome to try the fix before that, of course.)

___

Reply to this item at:

  http://gna.org/bugs/?16209

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #16212] Default size of city dialog gives scrollbar on city map with amplio tileset

2010-07-01 Thread Matthias Pfafferodt

Follow-up Comment #4, bug #16212 (project freeciv):

updated patch; changes:

- only xsize and ysize options
- use correct order for default/min/max

(file #9413)
___

Additional Item Attachment:

File name:
20100702-09-trunk-save-the-size-of-the-city-dialog-across-sessions.patch
Size:6 KB


___

Reply to this item at:

  http://gna.org/bugs/?16212

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15922] minimap scale not reset when loading/connecting

2010-07-01 Thread Matthias Pfafferodt

Update of bug #15922 (project freeciv):

  Status:   Confirmed = Ready For Test 
 Assigned to:None = syntron
 Planned Release: = 2.3.0  

___

Follow-up Comment #1:

this patch fixes the size of the overview (gtk client) if one changes between
games with different map sizes

Are similar changes needed for other clients? Was the bug even for the gtk
client?

(file #9414)
___

Additional Item Attachment:

File name: 20100702-11-trunk-fix-overview-size.patch Size:3 KB


___

Reply to this item at:

  http://gna.org/bugs/?15922

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev