[Freeciv-Dev] [bug #18266] gtk2 freeciv-modpack Windows build problem

2011-06-22 Thread Marko Lindqvist 

URL:
  

 Summary: gtk2 freeciv-modpack Windows build problem
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 23 Jun 2011 07:47:40 AM EEST
Category: bootstrap
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.4.0

___

Details:

When gtk2-version of freeciv-modpack is being built, configure sets wrong
variables.

Fix attached




___

File Attachments:


---
Date: Thu 23 Jun 2011 07:47:40 AM EEST  Name: Gtk2MPWin.diff  Size: 570B  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2734] Unit unpackaging to temporary structure code comments

2011-06-22 Thread Marko Lindqvist 

Update of patch #2734 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2740] Comment AI interface

2011-06-22 Thread Marko Lindqvist 

Update of patch #2740 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2742] Attacker orientation

2011-06-22 Thread Marko Lindqvist 

Update of patch #2742 (project freeciv):

  Status:  Ready For Test => In Progress


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18265] Quotation problem in ai modules configure check

2011-06-22 Thread Marko Lindqvist 

URL:
  

 Summary: Quotation problem in ai modules configure check
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 23 Jun 2011 01:06:07 AM EEST
Category: bootstrap
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.4.0

___

Details:

When $LIBS is copied to temporary variable and back, $LIBS containing space
is not handled correctly.

Fix attached.



___

File Attachments:


---
Date: Thu 23 Jun 2011 01:06:07 AM EEST  Name: AiModCheckLibs.diff  Size: 910B
  By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16566] Duplicate base building actions on combat menu for workers

2011-06-22 Thread Marko Lindqvist 

Update of bug #16566 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18264] Compiler warning about unused variable in NDEBUG build

2011-06-22 Thread Marko Lindqvist 

Update of bug #18264 (project freeciv):

 Planned Release:   2.4.0 => 2.3.0, 2.4.0   


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2731] Omit final release date from beta release

2011-06-22 Thread Marko Lindqvist 

Update of patch #2731 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2746] Remove set but unused variable unit_died

2011-06-22 Thread Marko Lindqvist 

URL:
  

 Summary: Remove set but unused variable unit_died
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 22 Jun 2011 11:49:42 PM EEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.4.0

___

Details:

Attached patch fixes one of the easier "set but unused variable" -warnings.



___

File Attachments:


---
Date: Wed 22 Jun 2011 11:49:42 PM EEST  Name: UnusedUnitDied.diff  Size: 852B
  By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18170] auth md5 sum broken on big-endian machines (e.g., sparc64)

2011-06-22 Thread Jacob Nevins 

Update of bug #18170 (project freeciv):

  Status: In Progress => Ready For Test 
 Planned Release: 2.3.0,2.4.0 => 2.2.6,2.3.0,2.4.0  

___

Follow-up Comment #14:

Attached new patches without the believed-unnecessary bug compatibility mode.
These just change the MD5 implementation.

(They also move the creation of the MD5 sum that's saved in the database from
new users from SQL to C.)

The S2_3 version backports cleanly to S2_2, and this is less invasive than I
thought it would be, so I'm inclined to put this in 2.2.6.

In principle these are candidates for committing. However, I haven't yet
tested them (beyond verifying the MD5 calculation) as I haven't got round to
setting up a MySQL database as the backend for authentication. Such testing
(involving creating a new user and logging in as an existing user) is probably
a prerequisite for committing.

(file #13317, file #13318)
___

Additional Item Attachment:

File name: trunk-md5-portability.diff Size:33 KB
File name: S2_3-S2_2-md5-portability.diff Size:33 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18264] Compiler warning about unused variable in NDEBUG build

2011-06-22 Thread Marko Lindqvist 

URL:
  

 Summary: Compiler warning about unused variable in NDEBUG
build
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 22 Jun 2011 11:47:02 PM EEST
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.4.0

___

Details:

There's one compiler warning in NDEBUG builds.
With NDEBUG fc_assert() extends to nothing, so pplayer is not used. As there
is absolutely nothing inside this iteration with NDEBUG, attached patch
removes also iteration itself from those builds.



___

File Attachments:


---
Date: Wed 22 Jun 2011 11:47:02 PM EEST  Name: NDebugWarn.diff  Size: 519B  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16281] problem with modifying/changing terrain

2011-06-22 Thread Marko Lindqvist 

Update of bug #16281 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13643] [Metaticket] Use lua for customizable database access

2011-06-22 Thread Matthias Pfafferodt 

Follow-up Comment #13, bug #13643 (project freeciv):

I hope to have internet ready at the end of this week - after the backlog is
finished I can also start doing something for freeciv again ...

> Unless I've missed something, the area of authentication and 
> databases in Freeciv is short on documentation. It would be nice 
> if there were some sort of README.auth or README.fcdb explaining 
> how a server operator would set up authentication -- I'm finding 
> that I have to reverse engineer it from the code. (This was true 
> already, but the instructions will presumably be different after 
> this work.) 

I will do such an README file

> Is the database.lua checked in to trunk intended to work with 
> backends other than MySQL? I ask because it references 
> luasql._MYSQLVERSION. Is a server operator who wants to use 
> (say) SQLite expected to rewrite database.lua?

At the moment it is mainly the old backend (mysql). For other backends such a
lua file has to be written. THe main difference would be to replace all
references to the mysql lua module to another luasql module.

> Talking of dependencies on MySQL, we've discovered in bug 
> #18170 that database.lua:user_save() depends on the SQL 
> function "md5()" (as did the C code that pre-dated it). Is 
> this supported by backends other than MySQL (SQLite, 
> Postgres)? It smells like a proprietary extension; I can't 
> find mention of it in the SQLite docs.
> I'm inclined to move the MD5 generation into the Freeciv core 
> code, where the MD5 verification already is. Alternatively, 
> verification could be moved out of the core code into Lua, I 
> suppose.

I propose to do it in freeciv (or lua). Thus, there is no dependency on the
database backend to have this function. I will check this.

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2745] GTK_WIDGET_HAS_FOCUS() -> gtk_widget_has_focus()

2011-06-22 Thread Marko Lindqvist 

URL:
  

 Summary: GTK_WIDGET_HAS_FOCUS() -> gtk_widget_has_focus()
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 22 Jun 2011 09:55:46 PM EEST
Category: client-gtk-3.0
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.4.0

___

Details:

Attached patch replaces use of deprecated GTK_WIDGET_HAS_FOCUS() macros with
gtk_widget_has_focus() -calls in gtk3-client



___

File Attachments:


---
Date: Wed 22 Jun 2011 09:55:46 PM EEST  Name: Gtk3WidgetHasFocus.diff  Size:
2kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18263] Tolua build has hardcoded lua paths

2011-06-22 Thread Marko Lindqvist 

URL:
  

 Summary: Tolua build has hardcoded lua paths
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 22 Jun 2011 07:38:39 PM EEST
Category: bootstrap
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.2.6, 2.3.0, 2.4.0

___

Details:

Tolua build does not use lua paths set by configure. This does not affect
current freeciv as distributed since configure itself always set those paths
to same value. I want to fix this also in stable branches mainly because there
exist patches, like one used by Debian, that do change what configure sets.



___

File Attachments:


---
Date: Wed 22 Jun 2011 07:38:39 PM EEST  Name: ToluaLuaFlags.diff  Size: 842B 
 By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [task #7246] Publish Amplio for 2.3 as stand-alone package

2011-06-22 Thread Daniel Markstedt 

Update of task #7246 (project freeciv):

  Status:None => Cancelled  
 Open/Closed:Open => Closed 

___

Follow-up Comment #4:

Alright, if everyone are fine with the added overhead of having both amplio
and amplio2 to maintain in svn there's of course no harm in keeping both
there.

As a matter of fact, I think it might be a good idea to add more tilesets to
Gna svn if they fulfill these criteria:

-not actively maintained by the original author
-have clear authorship and licensing status
-of good quality

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18262] freeciv-modpack fails to find home directory portable way

2011-06-22 Thread Marko Lindqvist 

URL:
  

 Summary: freeciv-modpack fails to find home directory
portable way
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 22 Jun 2011 06:02:54 PM EEST
Category: module installer
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.3.0, 2.4.0

___

Details:

freeciv-modpack uses getenv("HOME") to find user home directory instead of
using user_home_dir() that returns correct (=same as freeciv will use when
trying to find installed files) directory.

Fix attached



___

File Attachments:


---
Date: Wed 22 Jun 2011 06:02:54 PM EEST  Name: MPHomeDir.diff  Size: 676B  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] Launcher for new AI module projects

2011-06-22 Thread Marko Lindqvist 
Freeciv development version supports loadable ai modules. I've created
small script to help setup projects to create such ai modules.

Version 0.0.1 is available for download from
http://www.cazfi.net/freeciv/altai-0.0.1.tar.bz2

1. Unpack tarball: tar xjf altai-0.0.1.tar.bz2
2. Run scripts ./create_fcai_project.sh with name of the ai type you
want to create as parameter: ./create_fcai_project.sh cazfiai
3. You get tarball named after your new project containing initial
version of your project. Start developing.

---

 To build you project:

> tar xjf cazfiai.tar.bz2
> cd cazfiai
> ./autogen.sh
> mkdir build
> cd build
> ../configure --with-freeciv= --prefix= freeciv installation>
> make install


 - ML

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev