[Freeciv-Dev] [patch #2513] [lua01] rename files (preparation for lua module rework)
Follow-up Comment #9, patch #2513 (project freeciv): If these two patches are split further, some code has to be moved. There are more dependencies to server code in the api_*.(c|h) files moved to ./common/scriptcore. If you have not done it, I will create a patch, which does only move files _and_ some code between files. I could also check if it is possible to split changes into separate patches (as you have done with patch #2887). ___ Reply to this item at: http://gna.org/patch/?2513 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18461] crash using lua function civil_war (in ai_plr_data_get() [aidata.c::310]: assertion 'ai-phase_initialized' failed.)
Update of bug #18461 (project freeciv): Status: Ready For Test = In Progress ___ Follow-up Comment #7: I'm not 100% sure about the patch - can't be as I did only test my error case. Here it did remove the crash and, furthermore, did not add any other. As I see it the following work flow is done: srv_running() - begin_turn() -- _new_ initialisation to ai/adv phase - loop (phases) -- begin_phases() --- initialisation to ai/adv phase; if initialised, do nothing -- (some code) -- end_phase() --- end of ai/adv phase - end (loop phases) - end_turn() -- in this function the ai/adv phase can be closed to have the correct count of begin/end; these functions will do nothing at the moment but as you said, would be helpful to read the code ___ Reply to this item at: http://gna.org/bugs/?18461 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2890] man page for freeciv-modpack
URL: http://gna.org/patch/?2890 Summary: man page for freeciv-modpack Project: Freeciv Submitted by: cazfi Submitted on: Wed 10 Aug 2011 06:37:18 PM EEST Category: docs Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.3.1, 2.4.0 ___ Details: This patch adds freeciv-modpack man page. ___ File Attachments: --- Date: Wed 10 Aug 2011 06:37:18 PM EEST Name: MPMan.diff Size: 4kB By: cazfi http://gna.org/patch/download.php?file_id=13823 ___ Reply to this item at: http://gna.org/patch/?2890 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2891] Remove references to ftwl-client from man page
URL: http://gna.org/patch/?2891 Summary: Remove references to ftwl-client from man page Project: Freeciv Submitted by: cazfi Submitted on: Wed 10 Aug 2011 06:47:20 PM EEST Category: docs Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.0 ___ Details: ___ File Attachments: --- Date: Wed 10 Aug 2011 06:47:20 PM EEST Name: ManNoFtwl.diff Size: 3kB By: cazfi http://gna.org/patch/download.php?file_id=13824 ___ Reply to this item at: http://gna.org/patch/?2891 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2885] Fix autosettler to use rail connectivity bonus when planning for railroads
Update of patch #2885 (project freeciv): Status:None = Ready For Test Assigned to:None = cazfi Planned Release: = 2.4.0 ___ Reply to this item at: http://gna.org/patch/?2885 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2513] [lua01] rename files (preparation for lua module rework)
Update of patch #2513 (project freeciv): Status: In Progress = Ready For Test ___ Follow-up Comment #10: The attached patch includes the _minimal_ changes needed to compile freeciv after moving the files. No functionally change at all. The patch is on top of patch #2868, patch #2886 and patch #2887). If this is the way to go, I will rebase the other patches on top of this one ... (file #13825) ___ Additional Item Attachment: File name: 20110810-05-luascript-minimal-changes-to-compile-freeciv-after-m.patch Size:71 KB ___ Reply to this item at: http://gna.org/patch/?2513 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13620] [Wishlist] Gfx layer about native tiles
Update of bug #13620 (project freeciv): Category:None = client Priority: 1 - Later = 5 - Normal Status:None = Ready For Test ___ Follow-up Comment #1: Patch attached. New graphics for this in tileset is optional - grid.unavailable (for use of city) graphics will be used as fallback. (file #13826) ___ Additional Item Attachment: File name: DisplayNonNative_13620.diffSize:15 KB ___ Reply to this item at: http://gna.org/bugs/?13620 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2808] Commandline options for freeciv-modpack
Follow-up Comment #2, patch #2808 (project freeciv): - Updated against current svn (file #13828, file #13829) ___ Additional Item Attachment: File name: MPCmdLine_2808-3.diff Size:6 KB File name: MPCmdLine_2808-S2_3-3.diff Size:6 KB ___ Reply to this item at: http://gna.org/patch/?2808 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18339] Typo in signal name
Update of bug #18339 (project freeciv): Planned Release: 2.2.8, 2.3.0, 2.4.0 = 2.4.0 ___ Reply to this item at: http://gna.org/bugs/?18339 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2861] CPUHog evaluates governments every turn
Update of patch #2861 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?2861 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18481] lua-5.1, ldebug.c compilation failure
URL: http://gna.org/bugs/?18481 Summary: lua-5.1, ldebug.c compilation failure Project: Freeciv Submitted by: cazfi Submitted on: Wed 10 Aug 2011 11:03:58 PM EEST Category: bootstrap Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.3.1, 2.4.0 ___ Details: Reported by Michal Mazurek akfaew as part of bug #18468: cc1: warnings being treated as errors ldebug.c: In function 'luaG_errormsg': ldebug.c:620: warning: cast increases required alignment of target type gmake[4]: *** [ldebug.o] Error 1 gmake[4]: Leaving directory `/home/longturn/src/freeciv-2.3.0/dependencies/lua-5.1/src' gmake[3]: *** [all-recursive] Error 1 gmake[3]: Leaving directory `/home/longturn/src/freeciv-2.3.0/dependencies/lua-5.1' gmake[2]: *** [all-recursive] Error 1 gmake[2]: Leaving directory `/home/longturn/src/freeciv-2.3.0/dependencies' gmake[1]: *** [all-recursive] Error 1 gmake[1]: Leaving directory `/home/longturn/src/freeciv-2.3.0' gmake: *** [all] Error 2 ___ Reply to this item at: http://gna.org/bugs/?18481 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18482] Bus error on secfile_lookup_int_vec()
URL: http://gna.org/bugs/?18482 Summary: Bus error on secfile_lookup_int_vec() Project: Freeciv Submitted by: cazfi Submitted on: Wed 10 Aug 2011 11:06:10 PM EEST Category: general Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.3.1, 2.4.0 ___ Details: Reported by Michal Mazurek akfaew as part of bug #18468 That Lan bind failed might be yet another bug. [11:22:ttypd][longturn@spock:~/src/freeciv-2.3.0:36]$ ./ser -p This is the server for Freeciv version 2.3.0 You can learn a lot about Freeciv at http://www.freeciv.org/ 1: Lan bind failed: Address already in use 2: Loading rulesets. Bus error (core dumped) (gdb) bt #0 0x002b4aa8 in secfile_lookup_int_vec (secfile=0x208be8000, dim=0xb58d54, path=0x404bf8 civstyle.granary_food_ini) at registry.c:1973 #1 0x00187324 in load_ruleset_game () at ruleset.c:3230 #2 0x001931b8 in load_rulesets () at ruleset.c:4019 #3 0x0010d420 in srv_main () at srv_main.c:2269 #4 0x001038d0 in main (argc=3, argv=0xfffc9668) at civserver.c:375 ___ Reply to this item at: http://gna.org/bugs/?18482 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18468] Missing sys/socket.h and netinet/in.h includes from dataio.c
Update of bug #18468 (project freeciv): Severity: 4 - Important = 3 - Normal Status:None = Ready For Test Assigned to:None = cazfi Planned Release: = 2.3.1, 2.4.0 Summary: 2.3.0 does not compile on OpenBSD 4.9 = Missing sys/socket.h and netinet/in.h includes from dataio.c ___ Follow-up Comment #3: Please report exactly one issue / ticket in the future. That way ticket status gets clearly resolved when fix is committed, and not to some weird half-resolved state which forces maintainers to waste a lot of time and effort to figure out what remains to be done. I've now opened sepoarate tickets for ldebug.c compilation error (bug #18481) and bus error (bug #18482). This ticket is about original issue of missing includes only. ___ Reply to this item at: http://gna.org/bugs/?18468 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18481] lua-5.1, ldebug.c compilation failure
Follow-up Comment #1, bug #18481 (project freeciv): Can you test if attached patch makes error to go away. This is definitely not suitable patch for committing (being gcc specific) but it can be used to determine if problem is in restorestack() cast from char * to TValue *. (file #13831) ___ Additional Item Attachment: File name: AlignedRestoreStack_18481.diff Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?18481 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18388] wakeup_neighbor_sentries() has buggy alone_in_city detection
Update of bug #18388 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?18388 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] [bug #18468] Missing sys/socket.h and netinet/in.h includes from dataio.c
On Wed, Aug 10, 2011 at 10:14:02PM +0200, Marko Lindqvist wrote: Update of bug #18468 (project freeciv): Severity: 4 - Important = 3 - Normal Status:None = Ready For Test Assigned to:None = cazfi Planned Release: = 2.3.1, 2.4.0 Summary: 2.3.0 does not compile on OpenBSD 4.9 = Missing sys/socket.h and netinet/in.h includes from dataio.c ___ Follow-up Comment #3: Please report exactly one issue / ticket in the future. That way ticket status gets clearly resolved when fix is committed, and not to some weird half-resolved state which forces maintainers to waste a lot of time and effort to figure out what remains to be done. Ok, sorry about that. It appears I've marked the severity incorrectly. If the server not compiling does not have severity Important, what does? -- Michal Mazurek ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] [bug #18468] Missing sys/socket.h and netinet/in.h includes from dataio.c
On 10 August 2011 23:42, Michal Mazurek akf...@gmail.com wrote: On Wed, Aug 10, 2011 at 10:14:02PM +0200, Marko Lindqvist wrote: Severity: 4 - Important = 3 - Normal It appears I've marked the severity incorrectly. If the server not compiling does not have severity Important, what does? Server not compiling affecting many users :-) I mainly reduced the severity to indicate that I'm not going to rush the fix as compilation fix without inspection period. Bug is not new, yet nobody has complained so far. I take it that it doesn't affect many people, or those affected are not needing freeciv so urgently that inspection period before fix is committed would be too long wait. Even you are not seriously affected - you already have fixed it for yourself. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2889] Allow autosettlers to plan for farmland
Follow-up Comment #2, patch #2889 (project freeciv): Your second concern is already addressed by the code; my modifications only take effect in the case that the tile is not already irrigated (but can be). Your first concern is a valid complaint. The remedy is ugly, though, and possibly fruitless: I'm not sure that the game allows rule-sets to make farmland building and irrigation take a different amount of time because, unlike building roads and railroads, building farmland uses the same activity type as irrigation. (This quirk is, in fact, why I couldn't implement farmland planning in the same way that railroad planning is already performed.) ___ Reply to this item at: http://gna.org/patch/?2889 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
