[Freeciv-Dev] [patch #1339] Unit type requirements
Follow-up Comment #11, patch #1339 (project freeciv): Updated patch trunk rev.21114 The patch is different. I don't delete nothing, but I only add new functions: server/ruleset.c, common/unittype.c, common/unittype.h, common/packets.def and client/packhand.c. gmake result: city.c: In function 'city_choose_build_default': city.c:1020:2: warning: comparison between pointer and integer [enabled by default] improvement.c: In function 'impr_provides_buildable_units': improvement.c:334:3: warning: comparison between pointer and integer [enabled by default] unittype.c: In function 'unit_type_by_translated_name': unittype.c:512:3: warning: comparison between pointer and integer [enabled by default] unittype.c: In function 'unit_type_by_rule_name': unittype.c:529:3: warning: comparison between pointer and integer [enabled by default] unittype.c: In function 'can_unit_happen': unittype.c:749:26: warning: passing argument 8 of 'are_reqs_active' from incompatible pointer type [enabled by default] requirements.h:95:6: note: expected 'const struct requirement_vector *' but argument is of type 'struct requirement_vector **' unittype.c:752:25: warning: passing argument 8 of 'are_reqs_active' from incompatible pointer type [enabled by default] requirements.h:95:6: note: expected 'const struct requirement_vector *' but argument is of type 'struct requirement_vector **' unittype.c: In function 'precalc_one': unittype.c:813:3: warning: comparison between pointer and integer [enabled by default] unittype.c:822:5: warning: comparison between pointer and integer [enabled by default] unittype.c: In function 'unit_types_init': unittype.c:982:5: warning: passing argument 1 of 'requirement_vector_init' from incompatible pointer type [enabled by default] ../utility/specvec.h:72:1: note: expected 'struct requirement_vector *' but argument is of type 'struct requirement_vector **' unittype.c:983:5: warning: passing argument 1 of 'requirement_vector_init' from incompatible pointer type [enabled by default] ../utility/specvec.h:72:1: note: expected 'struct requirement_vector *' but argument is of type 'struct requirement_vector **' unittype.c: In function 'unit_types_free': unittype.c:1004:3: warning: comparison between pointer and integer [enabled by default] unittype.c:1006:5: warning: passing argument 1 of 'requirement_vector_free' from incompatible pointer type [enabled by default] ../utility/specvec.h:117:1: note: expected 'struct requirement_vector *' but argument is of type 'struct requirement_vector **' unittype.c:1007:5: warning: passing argument 1 of 'requirement_vector_free' from incompatible pointer type [enabled by default] ../utility/specvec.h:117:1: note: expected 'struct requirement_vector *' but argument is of type 'struct requirement_vector **' aiair.c: In function 'dai_choose_attacker_air': aiair.c:444:3: warning: comparison between pointer and integer [enabled by default] aihunt.c: In function 'dai_hunter_guess_best': aihunt.c:85:3: warning: comparison between pointer and integer [enabled by default] aihunt.c: In function 'dai_hunter_missile_want': aihunt.c:165:3: warning: comparison between pointer and integer [enabled by default] aiparatrooper.c: In function 'dai_choose_paratrooper': aiparatrooper.c:340:3: warning: comparison between pointer and integer [enabled by default] aiunit.c: In function 'update_simple_ai_types': aiunit.c:2574:3: warning: comparison between pointer and integer [enabled by default] ruleset.c: In function 'load_unit_names': ruleset.c:1098:3: warning: comparison between pointer and integer [enabled by default] ruleset.c: In function 'load_ruleset_units': ruleset.c:1373:3: warning: comparison between pointer and integer [enabled by default] ruleset.c:1406:3: warning: comparison between pointer and integer [enabled by default] ruleset.c:1414:5: warning: passing argument 1 of 'requirement_vector_copy' from incompatible pointer type [enabled by default] ../utility/specvec.h:110:1: note: expected 'struct requirement_vector *' but argument is of type 'struct requirement_vector **' ruleset.c:1417:5: warning: passing argument 1 of 'requirement_vector_copy' from incompatible pointer type [enabled by default] ../utility/specvec.h:110:1: note: expected 'struct requirement_vector *' but argument is of type 'struct requirement_vector **' ruleset.c:1559:3: warning: comparison between pointer and integer [enabled by default] ruleset.c:1590:3: warning: comparison between pointer and integer [enabled by default] ruleset.c:1620:3: warning: comparison between pointer and integer [enabled by default] ruleset.c: In function 'load_ruleset_buildings': ruleset.c:1819:5: warning: comparison between pointer and integer [enabled by default] ruleset.c: In function 'send_ruleset_units': ruleset.c:3890:3: warning: comparison between pointer and integer [enabled by default] ruleset.c:3908:5: error: request for member 'size' in something not a structure or union ruleset.c:3908:5: error: request for member 'p' in
[Freeciv-Dev] [bug #19608] Number of units built
URL:
http://gna.org/bugs/?19608
Summary: Number of units built
Project: Freeciv
Submitted by: akfaew
Submitted on: Tue Apr 3 15:19:30 2012
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Release: 2.3
Discussion Lock: Any
Operating System: None
Planned Release:
___
Details:
I have a city with prod 81 (+70) (11 upkeep). The production reads Riflemen
1/{2*40} even though only 71 shields will be cumulated.
___
Reply to this item at:
http://gna.org/bugs/?19608
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19609] View Native Tiles city dialog
URL: http://gna.org/bugs/?19609 Summary: View Native Tiles city dialog Project: Freeciv Submitted by: cazfi Submitted on: Tue 03 Apr 2012 08:01:33 PM EEST Category: client Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.4.0, 2.5.0 ___ Details: Don't know which part should be considered a bug, but together these form a problem: - If View Native Tiles is enabled and one has unit selected, tile nativity information is diplayed in city dialog also. - Even default Aplio2 tileset reuses tile unusable sprite for non-native tiles. End result: Having land unit selected while opening city dialog causes all ocean tiles to seem like unusable. ___ Reply to this item at: http://gna.org/bugs/?19609 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19611] Cannot move defender to city in non-native terrain.
URL: http://gna.org/bugs/?19611 Summary: Cannot move defender to city in non-native terrain. Project: Freeciv Submitted by: cazfi Submitted on: Wed 04 Apr 2012 12:22:45 AM EEST Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: I assume this is because of the quite recent changes to when city tile is considered native or not (it used to be considered always native) I'm playing with Alien World ruleset (development version, but that shouldn't make a difference) in S2_4. I've got Native Settlers (city builders who consider radiation tiles native) but no defense unit that would consider radiation tiles native. Native Settler founded city to Alien Forest (one of radiation terrains) tile. Tile is also coastal, if that makes any difference for the city center nativity code. Now I'd like to move Turtle Defender built in another city to it, but cannot. I can move to tile next to city, but not the last step to city itself. According to goto line, I could move Raft Turtle Defender is loaded to, in to that city. From Alien World's perspective this is rather serious bug as for a long time no unit can enter (are they even completely safe from occupying forces?) cities founded by Native Settlers to radiation tiles. ___ Reply to this item at: http://gna.org/bugs/?19611 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3233] Commit Goran Rakić's partial Serbian localisation
Update of patch #3233 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?3233 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19608] Number of units built
Follow-up Comment #1, bug #19608 (project freeciv):
I think this is working as designed, even if it's not very obvious.
The curly brackets in 1/{2*40} indicate that the city will not use all its
slots this turn, and I and (I think) you expect not all slots to be used given
the numbers.
In contrast, if it said 1/[2*40], that would indicate we're getting 2
Riflemen this turn (but would require at least +79 production surplus).
I'm not brilliantly happy about the use of non-obvious punctuation to indicate
this distinction, but I didn't have a better idea (at least not one that was
sufficiently concise to use everywhere this notation is used). Ideas welcome.
(I notice that for some reason I didn't document this notation in the online
help for build slots... perhaps I assumed that people would pick it up if they
cared?)
___
Reply to this item at:
http://gna.org/bugs/?19608
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
