[Freeciv-Dev] [patch #3885] base_assess_defense_unit() BadCityDefender handling
Follow-up Comment #2, patch #3885 (project freeciv): Extra check for pcity != NULL makes sense for future compatibility, but note that currently this function is used for selecting city defenders only, i.e., it should never be called with pcity == NULL. ___ Reply to this item at: http://gna.org/patch/?3885 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3885] base_assess_defense_unit() BadCityDefender handling
Follow-up Comment #3, patch #3885 (project freeciv): Indeed, looking through the call stack, the couple places where it is called without a check that pcity != NULL happen to be in city iterations, where it is safe to assume pcity isn't null (or the iterator is broken, which is a larger issue). In that case, we probably don't need to check for pcity for the ground units either, but there's no reason to fix that here: that can be part of the fix for is_ground_unit(), and the inline FIXME. Given this consideration, AssessBadCityDefense.patch (file 17845) is a perfectly good solution for this issue: the ways in which it might be incomplete are irrelevant and/or likely to be fixed in another nativity pass over base_assess_defense_unit() anyway. ___ Reply to this item at: http://gna.org/patch/?3885 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] Here be dragons
Now is as opportune a time to mention this as any... On Mon, Apr 29, 2013 at 2:49 AM, Sveinung Kvilhaugsvik sveinun...@users.sourceforge.net wrote: It may also have potential as a real paranoid debugging tool by testing that each packet is the same when nothing is supposed to have changed (not implemented yet). Here's another debugging tool: http://repo.or.cz/w/freeciv/berndj.git/commit/104328d54ce9e3b19ff71ce446023cfbcd43043c (I still need to update it for 2.4.) While it doesn't make it particularly easy to create test cases, it does the testing that ... is the same part. The focus is on testing client and server behaviour overall, packets be damned, so not really in the same category as your recorder tool. P.S. Maybe I'm doing something wrong but I don't see anything at http://folk.ntnu.no/kvilhaug/bazaar/FreecivRecorder/ with my www browser - or is that expected for a bzr repository? ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3826] Allow bases on city tiles
Update of patch #3826 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?3826 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] Here be dragons
On 4/30/13, Bernd Jendrissek bernd.jendris...@gmail.com wrote: The focus is on testing client and server behaviour overall, packets be damned, so not really in the same category as your recorder tool. It still looks interesting. I wrote my recorder because I'll need records on the level of player actions for another project* and because writing it would help me test my Java implementation of the Freeciv protocol. I'll have a closer look at you tool when time permits. Maybe I'm doing something wrong but I don't see anything at http://folk.ntnu.no/kvilhaug/bazaar/FreecivRecorder/ with my www browser - or is that expected for a bzr repository? It is expected. Bazaar will look in .bzr when branching. A source tarball containing the source code of Freeciv and the source code of my system is coming. I just want to fix some issues I imagine may scare testers away for good first. After it is uploaded fixing the 2.4 issues will hopefully make it accessible to those that don't want to compile Freeciv them self. * that I'll keep secret for now as there are enough vaporware out there already -- Sincerely Sveinung Kvilhaugsvik ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20721] Recursive logging
Update of bug #20721 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?20721 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3885] base_assess_defense_unit() BadCityDefender handling
Update of patch #3885 (project freeciv): Planned Release:2.5.0, 2.6.0 = 2.6.0 ___ Reply to this item at: http://gna.org/patch/?3885 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3730] Remove MAX_LEN_USERNAME
Update of patch #3730 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?3730 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3889] [Metaticket] Fix things deprecated in gtk+-3.4 (oldest supported) already
Follow-up Comment #1, patch #3889 (project freeciv): Attached is deprecation warnings from current TRUNK when built against gtk+-3.4.0. (file #17867) ___ Additional Item Attachment: File name: stderr.log Size:2 KB ___ Reply to this item at: http://gna.org/patch/?3889 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3889] [Metaticket] Fix things deprecated in gtk+-3.4 (oldest supported) already
Follow-up Comment #2, patch #3889 (project freeciv):
In random order:
- gtk_rc_get_theme_dir is an annoyance: it was a concept change in gtk3, css
themes are read from by default from paths hardcoded on (gtk+) build time
(i.e. ${prefix}/share/themes), so there's no real equivalent for it
- create_cma_dialog got stuck in patch #3560 (again, IMHO, that *upstream*
setting is not much different than freeciv small display settings)
- citydlg.c:2799:3 and cityrep.c:1437:3 go back to what I've wrote in i.e. bug
#20097 - silencing those warnings would be easy, writing a proper fix - not
so
- mapctrl.c set is patch #3550 and this one should be a proper fix
___
Reply to this item at:
http://gna.org/patch/?3889
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
