[Freeciv-Dev] [patch #4774] Unit flag to prevent barbarian appearance from huts

2014-06-04 Thread Emmet Hikory 
Follow-up Comment #1, patch #4774 (project freeciv):

Explicitly adding a NoBarbs UserFlag rather than enforcing this in the engine
has the side effect of providing a nice place to document the feature in the
units ruleset.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4774] Unit flag to prevent barbarian appearance from huts

2014-06-04 Thread Jacob Nevins 
URL:
  

 Summary: Unit flag to prevent barbarian appearance from huts
 Project: Freeciv
Submitted by: jtn
Submitted on: Thu 05 Jun 2014 01:45:25 BST
Category: rulesets
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Currently, units with GameLoss flag cannot unleash barbarians from huts.

I've sometimes thought it might be useful if other units in custom rulesets
could have this property (like CivIV Scout units).

Since hut behaviour is implemented in Lua, this doesn't need a new built-in
flag; our default.lua could honour a user flag "NoBarbs", and in rulesets
where that's not defined, no unit gets this property. So it's just a
convention that this user flag has this behaviour, which ruleset authors can
override.
(Should GameLoss units should continue to have this effect for general sanity,
or do we explicitly add NoBarbs to existing GameLoss units?)




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4773] Improve ruleset comments for embarks/disembarks/unreachable

2014-06-04 Thread Jacob Nevins 
Update of patch #4773 (project freeciv):

  Status: In Progress => Ready For Test 

___

Additional Item Attachment:

File name: trunk-S2_5-rulesetdoc-unreachable-transports.patch Size:16 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22142] MR_CANNOT_DISEMBARK message misleading

2014-06-04 Thread Jacob Nevins 
Update of bug #22142 (project freeciv):

  Status:None => Ready For Test 
 Assigned to:None => jtn

___

Additional Item Attachment:

File name: trunk-S2_5-disembark-msg-city.patch Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22141] Experimental ruleset Partisan help needs updating for nationality-based partisans

2014-06-04 Thread Jacob Nevins 
Update of bug #22141 (project freeciv):

  Status:None => Ready For Test 
 Assigned to:None => jtn

___

Additional Item Attachment:

File name: trunk-S2_5-help-experimental-partisan.patch Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22137] Redundant check for existing mine in execute_orders()

2014-06-04 Thread Jacob Nevins 
Update of bug #22137 (project freeciv):

  Status:None => Ready For Test 
 Assigned to:None => jtn

___

Follow-up Comment #1:

Untested patch.

(file #20926)
___

Additional Item Attachment:

File name: S2_5-execute-orders-redundant-mine.patch Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4773] Improve ruleset comments for embarks/disembarks/unreachable

2014-06-04 Thread Jacob Nevins 
URL:
  

 Summary: Improve ruleset comments for
embarks/disembarks/unreachable
 Project: Freeciv
Submitted by: jtn
Submitted on: Thu 05 Jun 2014 01:28:12 BST
Category: rulesets
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0, 2.6.0

___

Details:

Mainly expanding description of Unreachable flag to acknowledge its effect on
transports.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22142] MR_CANNOT_DISEMBARK message misleading

2014-06-04 Thread Jacob Nevins 
Update of bug #22142 (project freeciv):

 Summary: MR_DISEMBARK message misleading =>
MR_CANNOT_DISEMBARK message misleading


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22143] Help improvements for embarks/disembarks

2014-06-04 Thread Jacob Nevins 
URL:
  

 Summary: Help improvements for embarks/disembarks
 Project: Freeciv
Submitted by: jtn
Submitted on: Thu 05 Jun 2014 00:55:03 BST
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.5.0, 2.6.0

___

Details:

In transport units with unreachable flag, add:

"* Can carry and refuel up to 3 Land units.
"  * Some cargo cannot load/unload except in a city or a base native to this
transport."

Maybe suppress the caveat if all possible cargo can embark/disembark (and
suppress corresponding messages in cargo units).

Maybe change "Some cargo cannot ..." to just "Cargo cannot ..." if *no* units
have embarks/disembarks set?

In cargo units with embarks/disembarks set for unreachable unit classes, add
some text:

"* May load onto Air transports while underway."

and/or

"* May unload from Helicopter transports while underway."

or in the common case where embarks==disembarks:

"* May load and unload from Air, Helicopter, or Balloon transports while
underway."




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22142] MR_DISEMBARK message misleading

2014-06-04 Thread Jacob Nevins 
URL:
  

 Summary: MR_DISEMBARK message misleading
 Project: Freeciv
Submitted by: jtn
Submitted on: Thu 05 Jun 2014 00:41:30 BST
Category: None
Severity: 2 - Minor
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.5.0, 2.6.0

___

Details:

can_unit_move_to_tile_with_notify(): "%s cannot disembark without a native
base for %s on the tile." But units can disembark in a city too.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3793] [metaticket] Help updates for 2.5.0

2014-06-04 Thread Jacob Nevins 
Follow-up Comment #5, patch #3793 (project freeciv):

Acknowledge that the possibility of civil war is ruleset-dependent (patch
#3818).

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22126] AI traits valgrind errors

2014-06-04 Thread pepeto 
Update of bug #22126 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22050] Recursive transport problems

2014-06-04 Thread pepeto 
Update of bug #22050 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 

___

Follow-up Comment #7:

Committed to trunk (r25047
) and S2_5
(r25048 ).


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22141] Experimental ruleset Partisan help needs updating for nationality-based partisans

2014-06-04 Thread Jacob Nevins 
URL:
  

 Summary: Experimental ruleset Partisan help needs updating
for nationality-based partisans
 Project: Freeciv
Submitted by: jtn
Submitted on: Wed 04 Jun 2014 22:25:39 BST
Category: rulesets
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: S2_5 r25046
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.5.0, 2.6.0

___

Details:

Patch #3762 changed the experimental ruleset so that partisan appearance is
based on citizen nationality of the conquered city, but the help for the
Partisan unit in this ruleset still says "You must be the player who
originally built the city."




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4724] Enable disjunctive requirements vectors

2014-06-04 Thread Emmet Hikory 
Follow-up Comment #3, patch #4724 (project freeciv):

Both the AI and help use similar constructions to untangle requirements: one
of the sensible prerequsites of this patch would be to generalise these calls
such that the calling modules are asking sensible questions (e.g. What must
happen to construct this unit?  What value does this technology provide?,
etc.).

Flags help some, and being able to construct arbitrary numbers of similar
effects helps some, but there's still some things that are impossible without
disjunction: the example I often consider is "this improvement may be built
with an adjacent mountain or river (which I believe was once the default for
Hydro Plant)".

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21992] Useless but non-obsolete city improvements not redundant with present==FALSE effects requirements

2014-06-04 Thread Emmet Hikory 
Follow-up Comment #7, bug #21992 (project freeciv):

Sorry to catch this so late: the attached patch doesn't solve the problem I
intended to report, although it does improve things to some degree with the
existing rulesets (so there's no point reverting it).

More specifically, it is possible to use PRESENT=FALSE as a means to allow
semi-disjunction: given a set of values in a range, using FALSE for all the
unacceptable values (making any acceptable values inherently true), so that
one may have more than one acceptable value.  This is semantically distinct
from the use to indicate that something is obsolete or redundant.

The right solution (which belongs in another patch) is to evaluate the effect
for the improvement, and determine if another improvement provides that effect
in such a way that this improvement isn't useful.

To put this another way, we shouldn't impose semantic meaning on the notation
n the ruleset (present=FALSE), but rather analyze the improvement to determine
if it is redundant.

An example of how the current patch might go wrong: imagine an improvement
that provides +1 happiness if there are less than 4 units in the city: with
this patch, that would be marked redundant for overpopulated cities (and sold
with "Sell All Redundant", whereas an nreqs-based implementation would use
present=FALSE to indicate the effect shouldn't work, so that the nreqs weren't
triggered (as the improvement becomes useful again as soon as there are fewer
units in the city).

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22118] Document numbers of supported user flags in ruleset

2014-06-04 Thread Jacob Nevins 
Update of bug #22118 (project freeciv):

  Status: In Progress => Ready For Test 

___

Additional Item Attachment:

File name: trunk-S2_5-rulesetdoc-userflags-fix.patch Size:8 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev