[Freeciv-Dev] [patch #5737] dataio_json.[ch] packets_json.[ch]
Follow-up Comment #3, patch #5737 (project freeciv): Feel free to commit this and make any changes you see required to Freeciv-web on github if needed. ___ Reply to this item at: http://gna.org/patch/?5737 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23213] Fallback icons needed for Qt client
Follow-up Comment #4, bug #23213 (project freeciv): Ok, replaced fork and disconnect with standard qt ok and cancel button. Replaced rosa add, added mine. Kicked rosa configure out. Rosa is no more now. (file #23630, file #23631) ___ Additional Item Attachment: File name: icons.tar.bz2 Size:10 KB File name: qt-icons.patch Size:3 KB ___ Reply to this item at: http://gna.org/bugs/?23213 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23212] connection.c JSON_CONNECTION
Update of bug #23212 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?23212 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5758] TRANS comments for translateable ruleset flag names
URL: http://gna.org/patch/?5758 Summary: TRANS comments for translateable ruleset flag names Project: Freeciv Submitted by: jtn Submitted on: Mon 26 Jan 2015 21:19:07 UTC Category: None Priority: 5 - Normal Status: In Progress Privacy: Public Assigned to: jtn Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.5.0, 2.6.0, 3.0.0 ___ Details: Patch #4762 made various ruleset flag names localisable. These flags have some quite awkward names (ParadropFrom, Build_Airborne, Cant_Fortify). They should at least have TRANS comments explaining the sort of context they'll appear in. (That flag names like this can be presented to players is still a bit unsatisfactory, though.) ___ Reply to this item at: http://gna.org/patch/?5758 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5758] TRANS comments for translateable ruleset flag names
Follow-up Comment #1, patch #5758 (project freeciv): Also a lot of the flag names are single word that might be used in other contexts (Horse, Bridge, Farmland etc). They might benefit from have ?foo: disambiguation. (But I won't do that in this patch.) ___ Reply to this item at: http://gna.org/patch/?5758 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3793] [metaticket] Help updates for 2.5.0
Update of patch #3793 (project freeciv): Depends on: = patch #5759 ___ Reply to this item at: http://gna.org/patch/?3793 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5759] Move helptext for bridges to the ruleset
URL: http://gna.org/patch/?5759 Summary: Move helptext for bridges to the ruleset Project: Freeciv Submitted by: jtn Submitted on: Mon 26 Jan 2015 21:43:39 UTC Category: docs Priority: 5 - Normal Status: In Progress Privacy: Public Assigned to: jtn Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.5.0, 2.6.0, 3.0.0 ___ Details: I've been struggling for a while with how to reword the helptext strings about bridges not to be tied to a standard ruleset with rivers and roads: * * Allows %s to build roads on river tiles. * * Cannot be built to river tiles unless some technology allowing bridge building is knowns. I've failed. I think the answer is for the game engine to stop trying to document this relationship between river-like paths, road-like paths, and bridge-enabling techs, and for that text to be hand-written in the ruleset instead in the description of the relevant roads and tech(s). ___ Reply to this item at: http://gna.org/patch/?5759 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5751] Improve unitwaittime short description
Update of patch #5751 (project freeciv): Status:None = In Progress Assigned to:None = jtn Planned Release: = 2.4.5, 2.5.0, 2.6.0, 3.0.0 ___ Reply to this item at: http://gna.org/patch/?5751 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5762] [Qt client] Allow choosing a government by clicking the indicator
URL: http://gna.org/patch/?5762 Summary: [Qt client] Allow choosing a government by clicking the indicator Project: Freeciv Submitted by: louis94 Submitted on: mar. 27 janv. 2015 02:51:38 UTC Category: None Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: This patch adds a menu to the government indicator to allow quickly initiating a revolution. In order to do that, the government-related code is taken out of mr_menu to a new class (gov_menu) handling everything. The mr_menu code is adjusted to use the new class. Depends on patch #5760. ___ File Attachments: --- Date: mar. 27 janv. 2015 02:51:38 UTC Name: gov-menu-in-indicator.patch Size: 13 ko By: louis94 http://gna.org/patch/download.php?file_id=23642 --- Date: mar. 27 janv. 2015 02:51:38 UTC Name: gov-menu-in-indicator-s25.patch Size: 13 ko By: louis94 http://gna.org/patch/download.php?file_id=23643 ___ Reply to this item at: http://gna.org/patch/?5762 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23218] Loopholes when disaster wrecks current production
Follow-up Comment #2, bug #23218 (project freeciv): Is this related to funny behavior I encountered in recent game: within one turn I bought production, enemy diplomat sabotaged it, I bought again, second enemy diplomat sabotaged it again. ___ Reply to this item at: http://gna.org/bugs/?23218 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20681] Select menu disabled when no units selected, but Unit selection dialog could be used
Update of bug #20681 (project freeciv): Planned Release: 2.5.0, 2.6.0, 3.0.0 = 2.5.1, 2.6.0, 3.0.0 ___ Reply to this item at: http://gna.org/bugs/?20681 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22448] Freeciv server fails to start (bind failed: The operation completed successfully)
Follow-up Comment #22, bug #22448 (project freeciv): Patch to pass sizeof fc_sockaddr union (i.e. size of biggest member) instead of specific member on Windows builds (I really don't want to mess the other systems by replacing what looks like more correct thing to do with something that windows might accept). Completely untested at the moment, and I wouldn't be surprised if it makes Windows network code not to function at all. (file #23644) ___ Additional Item Attachment: File name: WinSockaddrSize.patch Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?22448 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5758] TRANS comments for translateable ruleset flag names
Update of patch #5758 (project freeciv): Status: In Progress = Ready For Test ___ Additional Item Attachment: File name: trunk-S2_6-ruleset-flag-trans-comments.patch Size:18 KB File name: S2_5-ruleset-flag-trans-comments.patch Size:7 KB ___ Reply to this item at: http://gna.org/patch/?5758 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22448] Freeciv server fails to start (bind failed: The operation completed successfully)
Follow-up Comment #21, bug #22448 (project freeciv): 0: bind failed: The system detected an invalid pointer address in attempting to use a pointer argument in a call. is really common on my machine. https://msdn.microsoft.com/en-us/library/windows/desktop/ms740668%28v=vs.85%29.aspx specifically mentions if the length of an argument, which is a sockaddr structure, is smaller than the sizeof(sockaddr). as an example where this error gets returned. So maybe it's our attempt to be smart and pass correct size depending on address family instead of generic size (one suitable for any address family) that Windows is not liking. ___ Reply to this item at: http://gna.org/bugs/?22448 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5751] Improve unitwaittime short description
Update of patch #5751 (project freeciv): Status: In Progress = Ready For Test ___ Additional Item Attachment: File name: trunk-S2_6-S2_5-S2_4-unitwaittime-shortdesc.patch Size:0 KB ___ Reply to this item at: http://gna.org/patch/?5751 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23219] Team members can agree on pacts
URL: http://gna.org/bugs/?23219 Summary: Team members can agree on pacts Project: Freeciv Submitted by: cazfi Submitted on: Tue 27 Jan 2015 06:47:45 AM EET Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: One can form an alliance with his/her team member. I don't think this can be right. That will mean that their diplomatic state is no longer DS_TEAM, but DS_ALLIANCE. They will still have the same team number, of course, and some parts of the code *do* depend on that instead of diplstate. Resulting diplstate vs team numbers inconsistency is an opposite case to one in bug #22111 (so doesn't explain it). ___ Reply to this item at: http://gna.org/bugs/?23219 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5760] [Qt client] Use widgets instead of hand-drawing the game info panel
URL: http://gna.org/patch/?5760 Summary: [Qt client] Use widgets instead of hand-drawing the game info panel Project: Freeciv Submitted by: louis94 Submitted on: mar. 27 janv. 2015 00:19:10 UTC Category: client-qt Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: This patch is a rewrite of the game information panel (the one with the 'Turn Done' button) to be widget-based instead of drawing everything by hand. Not having to manually layout draw things simplifies the code a lot (-75 lines). Qt stylesheets are used to customize the appearance; modifying it is now very easy. I tried to mimic the old styling, but small differences remain. Since everything in the map view layout seems to be tied very close together, issues with other internal panels may appear. I could play a full game without finding one, though. ___ File Attachments: --- Date: mar. 27 janv. 2015 00:19:10 UTC Name: game_info_widgets.patch.bz2 Size: 6 ko By: louis94 http://gna.org/patch/download.php?file_id=23632 --- Date: mar. 27 janv. 2015 00:19:10 UTC Name: game_info_widgets-s25.patch.bz2 Size: 6 ko By: louis94 http://gna.org/patch/download.php?file_id=23633 ___ Reply to this item at: http://gna.org/patch/?5760 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5761] Rework disaster messages
URL: http://gna.org/patch/?5761 Summary: Rework disaster messages Project: Freeciv Submitted by: jtn Submitted on: Tue 27 Jan 2015 00:40:59 UTC Category: None Priority: 5 - Normal Status: In Progress Privacy: Public Assigned to: jtn Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.5.0, 2.6.0, 3.0.0 ___ Details: When a disaster occurs: * Disaster name was not translated * Avoid terminology food box and production box that's otherwise not mentioned in the help (except server settings) * For EmptyProdStock, explain what project was affected. * Use city_link() more. Also expand the description of the 'disasters' server setting. ___ Reply to this item at: http://gna.org/patch/?5761 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5759] Move helptext for bridges to the ruleset
Update of patch #5759 (project freeciv): Status: In Progress = Ready For Test ___ Additional Item Attachment: File name: trunk-S2_6-bridge-help.patch Size:3 KB File name: S2_5-bridge-help.patch Size:3 KB ___ Reply to this item at: http://gna.org/patch/?5759 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23218] Loopholes when disaster wrecks current production
Update of bug #23218 (project freeciv): Status: In Progress = Ready For Test ___ Follow-up Comment #1: Untested patch. (file #23639) ___ Additional Item Attachment: File name: trunk-S2_6-S2_5-disaster-emptyprodbox-loophole.patch Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?23218 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5761] Rework disaster messages
Update of patch #5761 (project freeciv): Status: In Progress = Ready For Test ___ Additional Item Attachment: File name: trunk-S2_6-disaster-messages.patch Size:4 KB File name: S2_5-disaster-messages.patch Size:4 KB ___ Reply to this item at: http://gna.org/patch/?5761 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20758] Buoys getting vision twice
Update of bug #20758 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?20758 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22863] Pillaged buoys still visible on fogged tiles
Update of bug #22863 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?22863 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5233] Client goto turn number
Follow-up Comment #14, patch #5233 (project freeciv): Version 5 attached: reworked tileset sprite handling. The tileset author can choose to make sprites for every state and turn number (e.g. for having different font, shape or color), or to define a global sprite for every state (or both). (file #23629) ___ Additional Item Attachment: File name: client_goto_turn_number5.patch Size:19 KB ___ Reply to this item at: http://gna.org/patch/?5233 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5681] Client goto turn number art
Update of patch #5681 (project freeciv): Depends on: = patch #5233 ___ Reply to this item at: http://gna.org/patch/?5681 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23218] Loopholes when disaster wrecks current production
URL: http://gna.org/bugs/?23218 Summary: Loopholes when disaster wrecks current production Project: Freeciv Submitted by: jtn Submitted on: Mon 26 Jan 2015 23:29:38 UTC Category: None Severity: 3 - Normal Priority: 5 - Normal Status: In Progress Assigned to: jtn Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: Any Planned Release: 2.5.0, 2.6.0, 3.0.0 ___ Details: diplomat_sabotage() does this when current production is sabotaged: nullify_prechange_production(pcity); /* Make it impossible to recover */ Probably apply_disaster() should do the same thing? ___ Reply to this item at: http://gna.org/bugs/?23218 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev