[Freeciv-Dev] [patch #6222] Sanity check: unique units are unique
Follow-up Comment #3, patch #6222 (project freeciv): In fact, considering that death of a leader is always a risk, almost always odds that none of them dies gets higher when any one of them is removed from the game. It doesn't need to be the least defended one. The exception when the leaders defend each other, so removal of the strong one makes weak one more vulnerable. Anyway, if we're going by sanity checking, it still should take place on savegame loading and output a clear warning that the problem is in the savegame, and it's a known one. That should also be something that is checked in all builds, not only in those where game state sanity checking is enabled (debug/development builds). ___ Reply to this item at: http://gna.org/patch/?6222 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #6225] orders system: support the Enter Marketplace action
URL: http://gna.org/patch/?6225 Summary: orders system: support the Enter Marketplace action Project: Freeciv Submitted by: sveinung Submitted on: Wed 12 Aug 2015 08:54:30 PM UTC Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: sveinung Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 3.0.0 ___ Details: ___ File Attachments: --- Date: Wed 12 Aug 2015 08:54:30 PM UTC Name: 0008-orders-system-support-the-Enter-Marketplace-action.patch Size: 774B By: sveinung http://gna.org/patch/download.php?file_id=24855 ___ Reply to this item at: http://gna.org/patch/?6225 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #6224] Tell if the actions are ready for use
URL: http://gna.org/patch/?6224 Summary: Tell if the actions are ready for use Project: Freeciv Submitted by: sveinung Submitted on: Wed 12 Aug 2015 08:53:46 PM UTC Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: sveinung Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 3.0.0, 2.6.0 ___ Details: Add the new function actions_are_ready() to make it easy to test if the actions are completely initialized. ___ File Attachments: --- Date: Wed 12 Aug 2015 08:53:46 PM UTC Name: 0005-Tell-if-the-actions-are-ready-for-use.patch Size: 4kB By: sveinung http://gna.org/patch/download.php?file_id=24854 ___ Reply to this item at: http://gna.org/patch/?6224 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #6227] orders system: support the Investigate City action
URL: http://gna.org/patch/?6227 Summary: orders system: support the Investigate City action Project: Freeciv Submitted by: sveinung Submitted on: Thu 13 Aug 2015 12:27:35 AM UTC Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: sveinung Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 3.0.0 ___ Details: ___ File Attachments: --- Date: Thu 13 Aug 2015 12:27:35 AM UTC Name: 0010-orders-system-support-the-Investigate-City-action.patch Size: 723B By: sveinung http://gna.org/patch/download.php?file_id=24858 ___ Reply to this item at: http://gna.org/patch/?6227 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23719] no support for most keyboard shortcuts
Follow-up Comment #2, bug #23719 (project freeciv): @sds: We are using the X11 GUI, and thus need linuxish-type modifier keys. Opt-N will get you a new game, Opt-L to load, etc. Note that if you are using XQuartz you may need to set the preferences for Input - Option keys send Alt_L and Alt-R. About: the existing shortcuts are inconsistent. I think you refer to the fact that the opening screen responds to the Option/Alt key while the in-game menus respond to Control key. If so, then i have to admit that the current situation is not ideal, but the menus speak truth when they [for example] Ctrl-S to save. That's certainly not something we are going to be able to fix in the near future. @jtn: The Gnome Project's GTK-OSX toolchain theoretically should compile Freeciv into a OSX-native 'Cocoa' bundle, with the key bindings modified appropriately. I say 'should' as i haven't tried it yet; i understand that is how, for example, Gnucash and Gimp provide executables now. I will do this at my earliest convenience, though i don't know when that will be since i'm in the middle of divorce right now. In other OSes, do the Meta keys actually change from Alt in the opening screen to Ctrl in the main screen? If not, how did we end up this way? As far as status, this WFM though i'm not sure if that's sufficient justification to close the bug. ___ Reply to this item at: http://gna.org/bugs/?23719 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #6226] Action ID is validity check
URL: http://gna.org/patch/?6226 Summary: Action ID is validity check Project: Freeciv Submitted by: sveinung Submitted on: Wed 12 Aug 2015 11:50:33 PM UTC Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: sveinung Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 3.0.0, 2.6.0 ___ Details: Add the new function action_id_is_valid() and have it replace all calls to gen_action_is_valid(). ___ File Attachments: --- Date: Wed 12 Aug 2015 11:50:33 PM UTC Name: 3.0_valid_id.patch Size: 3kB By: sveinung http://gna.org/patch/download.php?file_id=24856 --- Date: Wed 12 Aug 2015 11:50:33 PM UTC Name: 2.6_valid_id.patch Size: 2kB By: sveinung http://gna.org/patch/download.php?file_id=24857 ___ Reply to this item at: http://gna.org/patch/?6226 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #6228] orders system: explain known illegal action
URL: http://gna.org/patch/?6228 Summary: orders system: explain known illegal action Project: Freeciv Submitted by: sveinung Submitted on: Thu 13 Aug 2015 12:28:37 AM UTC Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: sveinung Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 3.0.0 ___ Details: A perform action order can be canceled if the player has enough information to know that the ordered action is illegal. This is done to escape any punishment trying to do an illegal action may bring. Try to explanation why the action was illegal in case the player haven't noticed the information or don't know the rules. ___ File Attachments: --- Date: Thu 13 Aug 2015 12:28:37 AM UTC Name: 0011-orders-system-explain-known-illegal-action.patch Size: 3kB By: sveinung http://gna.org/patch/download.php?file_id=24859 ___ Reply to this item at: http://gna.org/patch/?6228 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23719] no support for most keyboard shortcuts
Follow-up Comment #3, bug #23719 (project freeciv): the opt-alt option is set. Opt-N does nothing in the splash screen (new game expected). ___ Reply to this item at: http://gna.org/bugs/?23719 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #6214] --enable-freeciv-manual
Update of patch #6214 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?6214 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #6222] Sanity check: unique units are unique
Follow-up Comment #2, patch #6222 (project freeciv): The question is would such a savegame fixing (removal of some units on savegame load) do more good than harm? It would be tricky to remove the right (least well-defended) Leader. The sanity checks would at least clue players in that something is awry with their game. ___ Reply to this item at: http://gna.org/patch/?6222 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #6220] orders system: replace ORDER_BUILD_CITY with ORDER_PERFORM_ACTION
Update of patch #6220 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?6220 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #6218] Allow joining cities at the neighbor tile
Update of patch #6218 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?6218 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #6217] Split the hard coded join and found city requirements from each other
Update of patch #6217 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?6217 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #6219] orders system: support the Join City action
Update of patch #6219 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?6219 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23772] Dev save compat can corrupt 3.0 custom ruleset join city orders
Update of bug #23772 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?23772 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #6215] orders system: support the Establish Trade Route action
Update of patch #6215 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?6215 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #6216] orders system: replace ORDER_TRADE_ROUTE with ORDER_PERFORM_ACTION
Update of patch #6216 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?6216 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21752] freeciv-client-gtk: Does always want to connect to localhost
Update of bug #21752 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?21752 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #6223] Remove GUI_XAW gui_type definition
URL: http://gna.org/patch/?6223 Summary: Remove GUI_XAW gui_type definition Project: Freeciv Submitted by: cazfi Submitted on: Wed 12 Aug 2015 07:35:47 PM EEST Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 3.0.0 ___ Details: ___ File Attachments: --- Date: Wed 12 Aug 2015 07:35:47 PM EEST Name: GuiXawRm.patch Size: 2kB By: cazfi http://gna.org/patch/download.php?file_id=24853 ___ Reply to this item at: http://gna.org/patch/?6223 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23700] Private messages addressed to username disappear in cache
Follow-up Comment #8, bug #23700 (project freeciv): Still needs fixing IMHO. ___ Reply to this item at: http://gna.org/bugs/?23700 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23761] Alien ruleset Transportation does not work on hex map
Update of bug #23761 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?23761 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #6205] Make victory_lead_pct to be just the lead, not 100% for a draw already
Update of patch #6205 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?6205 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #6222] Sanity check: unique units are unique
Update of patch #6222 (project freeciv): Status: Ready For Test = In Progress ___ Follow-up Comment #4: _While sanitychecking unique units each turn might be a generally good idea, it has nothing to do with the savegame_ Thank you for the correction. ___ Reply to this item at: http://gna.org/patch/?6222 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #6204] Coding style of the Mac specific part of civserver.c
Update of patch #6204 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?6204 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
